| JoshNang | well, no lockups. but i can't get it to lock up without the patch either | 00:04 |
|---|---|---|
| adam_g | Shrews was having success reproducing it on demand, maybe he can help confirm tomorrow | 00:06 |
| *** killer_prince has joined #openstack-ironic | 00:09 | |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Implement version 2 payload with more hw info https://review.openstack.org/86475 | 00:11 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Implement version 2 payload with more hw info https://review.openstack.org/86475 | 00:22 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Implement version 2 payload with more hw info https://review.openstack.org/86475 | 00:23 |
| *** matsuhashi has joined #openstack-ironic | 00:26 | |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Close file handle after use https://review.openstack.org/86476 | 00:27 |
| openstackgerrit | A change was merged to openstack/ironic: Fix hosts mapping for conductor's periodic tasks https://review.openstack.org/84142 | 00:45 |
| *** jrist has quit IRC | 00:52 | |
| *** jrist has joined #openstack-ironic | 00:52 | |
| Shrews | adam_g: omg, i hope that's it. i spent most of today trying to track that frickin' bug down | 01:09 |
| Shrews | will try the patch tomorrow | 01:09 |
| *** killer_prince has quit IRC | 01:15 | |
| *** wendar_ has joined #openstack-ironic | 01:19 | |
| *** GheRivero_ has joined #openstack-ironic | 01:19 | |
| *** SpamapS_ has joined #openstack-ironic | 01:21 | |
| *** lynxman_ has joined #openstack-ironic | 01:22 | |
| *** rushiagr has quit IRC | 01:22 | |
| *** SpamapS has quit IRC | 01:22 | |
| *** dshulyak has quit IRC | 01:22 | |
| *** antonym has quit IRC | 01:23 | |
| *** lynxman has quit IRC | 01:23 | |
| *** mordred has quit IRC | 01:23 | |
| *** dividehex has quit IRC | 01:23 | |
| *** wendar has quit IRC | 01:23 | |
| *** GheRivero has quit IRC | 01:23 | |
| *** sanek11 has joined #openstack-ironic | 01:23 | |
| *** agordeev has quit IRC | 01:24 | |
| *** rushiagr has joined #openstack-ironic | 01:24 | |
| *** lynxman_ is now known as lynxman | 01:24 | |
| *** mordred has joined #openstack-ironic | 01:24 | |
| *** dividebin has joined #openstack-ironic | 01:24 | |
| *** dshulyak has joined #openstack-ironic | 01:24 | |
| *** lynxman has quit IRC | 01:24 | |
| *** lynxman has joined #openstack-ironic | 01:24 | |
| *** antonym has joined #openstack-ironic | 01:25 | |
| *** killer_prince has joined #openstack-ironic | 01:39 | |
| *** nosnos has joined #openstack-ironic | 01:48 | |
| *** Haomeng has joined #openstack-ironic | 02:02 | |
| *** coolsvap|afk is now known as coolsvap | 02:12 | |
| *** rloo has quit IRC | 02:18 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Bring agent deploy driver up to date with virt https://review.openstack.org/86490 | 02:23 |
| *** radsy has quit IRC | 02:31 | |
| *** radsy has joined #openstack-ironic | 02:31 | |
| *** harlowja is now known as harlowja_away | 02:39 | |
| *** harlowja_away is now known as harlowja | 02:39 | |
| *** datajerk has quit IRC | 02:51 | |
| *** jgrimm has joined #openstack-ironic | 03:14 | |
| *** matsuhashi has quit IRC | 03:22 | |
| *** matsuhashi has joined #openstack-ironic | 03:32 | |
| *** dwalleck has joined #openstack-ironic | 03:35 | |
| *** eghobo has joined #openstack-ironic | 03:43 | |
| *** BadCub01 has quit IRC | 03:43 | |
| *** nosnos has quit IRC | 04:09 | |
| *** dwalleck_ has joined #openstack-ironic | 04:15 | |
| *** dwalleck has quit IRC | 04:19 | |
| *** dwalleck_ has quit IRC | 04:41 | |
| *** nosnos has joined #openstack-ironic | 04:47 | |
| *** jgrimm has quit IRC | 05:08 | |
| *** rameshg87 has joined #openstack-ironic | 05:09 | |
| *** russell_h has quit IRC | 05:09 | |
| *** russell_h has joined #openstack-ironic | 05:10 | |
| *** harlowja is now known as harlowja_away | 05:10 | |
| *** russell_h has quit IRC | 05:10 | |
| *** russell_h has joined #openstack-ironic | 05:10 | |
| *** vkozhukalov has joined #openstack-ironic | 05:16 | |
| *** ilives has joined #openstack-ironic | 05:19 | |
| *** vkozhukalov has quit IRC | 05:19 | |
| *** ilives has quit IRC | 05:25 | |
| *** ilives has joined #openstack-ironic | 05:25 | |
| *** pradipta_away is now known as pradipta | 05:26 | |
| *** vkozhukalov has joined #openstack-ironic | 05:26 | |
| *** radsy has quit IRC | 05:29 | |
| *** eghobo has quit IRC | 05:37 | |
| *** eghobo has joined #openstack-ironic | 05:38 | |
| *** ilives has quit IRC | 05:47 | |
| *** ilives has joined #openstack-ironic | 05:47 | |
| *** ilives has quit IRC | 05:49 | |
| *** eguz has joined #openstack-ironic | 05:51 | |
| *** ilives has joined #openstack-ironic | 05:53 | |
| *** eghobo has quit IRC | 05:55 | |
| openstackgerrit | Jenkins proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/83956 | 06:07 |
| *** ilives has quit IRC | 06:08 | |
| *** vkozhukalov has quit IRC | 06:15 | |
| *** lsmola has joined #openstack-ironic | 06:16 | |
| *** ewindisch has quit IRC | 06:16 | |
| *** SpamapS_ is now known as SpamapS | 06:20 | |
| *** SpamapS has joined #openstack-ironic | 06:20 | |
| *** ewindisch has joined #openstack-ironic | 06:27 | |
| openstackgerrit | Russell Haering proposed a change to openstack/ironic: Factor hash ring management out of the conductor https://review.openstack.org/84814 | 06:42 |
| *** ilives has joined #openstack-ironic | 06:55 | |
| *** ilives has quit IRC | 07:06 | |
| *** ilives has joined #openstack-ironic | 07:07 | |
| *** rameshg87 has left #openstack-ironic | 07:10 | |
| rushiagr | hello Ironic! | 07:19 |
| rushiagr | In the docs, 'exercising the services locally' | 07:19 |
| rushiagr | http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#exercising-the-services-locally | 07:19 |
| *** max_lobur has joined #openstack-ironic | 07:19 | |
| rushiagr | Can I specify a fake mac address, IPMI credentials, and make the node creation etc things work? | 07:20 |
| rushiagr | or will I need to use a 'real' node? The doc is slightly ambiguous | 07:20 |
| *** rameshg87 has joined #openstack-ironic | 07:23 | |
| Haomeng | rushiagr: welcome | 07:23 |
| *** mdickson has quit IRC | 07:24 | |
| Haomeng | rushiagr: depends on what you want | 07:24 |
| Haomeng | rushiagr: what case you want to run | 07:24 |
| rushiagr | I just wanted to check the node-create, etc APIs. I just wanted to play around with Ironic, on my local machine (laptop) | 07:25 |
| rushiagr | Haomeng: ^ | 07:25 |
| Haomeng | rushiagr: :) | 07:25 |
| Haomeng | rushiagr: if you just run node-create without any true deployment, you can use any fake mac address and ipmi credentials, but ipmi poweron/off function will not work I think:) | 07:26 |
| rushiagr | Haomeng: okay. Cool. That will do the job for me | 07:27 |
| *** romcheg has joined #openstack-ironic | 07:28 | |
| *** zigo has quit IRC | 07:29 | |
| *** romcheg has quit IRC | 07:31 | |
| *** romcheg has joined #openstack-ironic | 07:32 | |
| *** romcheg has quit IRC | 07:32 | |
| Haomeng | rushiagr: :) | 07:33 |
| rushiagr | Haomeng: thanks | 07:33 |
| Haomeng | rushiagr: welcome:) | 07:33 |
| *** ndipanov has joined #openstack-ironic | 07:38 | |
| *** yuriyz has joined #openstack-ironic | 07:39 | |
| *** vkozhukalov has joined #openstack-ironic | 07:39 | |
| *** max_lobur has quit IRC | 07:43 | |
| *** romcheg has joined #openstack-ironic | 07:48 | |
| *** eguz has quit IRC | 07:49 | |
| *** jistr has joined #openstack-ironic | 08:07 | |
| *** lucasagomes has joined #openstack-ironic | 08:13 | |
| openstackgerrit | A change was merged to openstack/ironic: Handling validation in conductor consistently https://review.openstack.org/84374 | 08:17 |
| *** romcheg has quit IRC | 08:19 | |
| *** matsuhashi has quit IRC | 08:21 | |
| *** matsuhashi has joined #openstack-ironic | 08:21 | |
| *** zigo has joined #openstack-ironic | 08:23 | |
| *** matsuhashi has quit IRC | 08:25 | |
| *** killer_prince has quit IRC | 08:26 | |
| *** derekh has joined #openstack-ironic | 08:26 | |
| *** killer_prince has joined #openstack-ironic | 08:27 | |
| *** romcheg has joined #openstack-ironic | 08:28 | |
| *** lazy_prince has joined #openstack-ironic | 08:29 | |
| *** killer_prince has quit IRC | 08:32 | |
| *** lazy_prince is now known as killer_prince | 08:32 | |
| *** aignatov has quit IRC | 08:32 | |
| *** aignatov has joined #openstack-ironic | 08:34 | |
| *** matsuhashi has joined #openstack-ironic | 08:37 | |
| *** athomas has joined #openstack-ironic | 08:42 | |
| dtantsur | Morning Ironic | 08:42 |
| Haomeng | dtantsur: morning:) | 08:42 |
| * dtantsur needs 3rd cup of coffee today :( | 08:42 | |
| *** lsmola has quit IRC | 08:46 | |
| romcheg | Morning folks! | 08:47 |
| *** athomas has quit IRC | 08:49 | |
| lucasagomes | morning Haomeng romcheg dtantsur | 08:54 |
| lucasagomes | dtantsur, I didn't know about that list vs tuple performance | 08:55 |
| Haomeng | lucasagomes: morning:) | 08:55 |
| yuriyz | morning all | 08:55 |
| romcheg | Morning lucasagomes! | 08:55 |
| lucasagomes | dtantsur, any links you can point me to that talks about it? | 08:55 |
| lucasagomes | yuriyz, morning :D | 08:55 |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Do not sync power state for new invalidated nodes https://review.openstack.org/86529 | 08:57 |
| dtantsur | lucasagomes, Morning! To put it simply, both tuples and list require O(N) for 'in' operation, but as list is a complex mutable structure, creating it just for 2 comparisons may be suboptimal. Also, afaik Python compiler under come conditions can even pre-construct this tuple as a constant | 08:57 |
| dtantsur | lucasagomes, if this explanation does not satisfy you, I can try find something serious on this :) | 08:57 |
| *** tatyana has joined #openstack-ironic | 08:57 | |
| dtantsur | morning romcheg, yuriyz | 08:58 |
| lucasagomes | dtantsur, heh, it's grand to me, just curious | 08:58 |
| lucasagomes | I haven't heard about it that's why I'm questioning | 08:58 |
| lucasagomes | and yeah, for a list/tuple of 2 items it won't hit any performance impact I be | 08:59 |
| lucasagomes | bet* | 08:59 |
| lucasagomes | dtantsur, so its more about the creation of it, not searching in it itself | 08:59 |
| *** lsmola has joined #openstack-ironic | 09:00 | |
| lucasagomes | cool thanks, here's a good explanation about it: http://stackoverflow.com/questions/3340539/why-tuple-is-faster-than-list | 09:02 |
| dtantsur | lucasagomes, well yeah, I think list (which can grow) is much harder to construct (and takes essentially more memory) that tuple (which is of fixed size). Searching may be only slightly different due to the fact tuple is simpler | 09:02 |
| dtantsur | lucasagomes, ah, ok :) | 09:02 |
| dtantsur | lucasagomes, I actually like the 3rd answer, it goes into some implementation details: http://stackoverflow.com/a/3341629 | 09:04 |
| *** athomas has joined #openstack-ironic | 09:04 | |
| lucasagomes | cool thanks | 09:05 |
| *** romcheg has quit IRC | 09:10 | |
| Mikhail_D_wk | Morning all! :) | 09:13 |
| Mikhail_D_wk | lucasagomes: morning! :) | 09:13 |
| lucasagomes | Mikhail_D_wk, morning | 09:13 |
| dtantsur | morning Mikhail_D_wk | 09:13 |
| *** martyntaylor has joined #openstack-ironic | 09:16 | |
| *** ilives has quit IRC | 09:18 | |
| *** ilives has joined #openstack-ironic | 09:19 | |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Cleanup mock patch without `with` part 2 https://review.openstack.org/73256 | 09:21 |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Cleanup mock patch without `with` part 1 https://review.openstack.org/73223 | 09:21 |
| Haomeng | Mikhail_D_wk: morning:) | 09:22 |
| *** tatyana has quit IRC | 09:22 | |
| *** lazy_prince has joined #openstack-ironic | 09:24 | |
| *** killer_prince has quit IRC | 09:24 | |
| *** lazy_prince is now known as killer_prince | 09:24 | |
| *** max_lobur has joined #openstack-ironic | 09:25 | |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Cleanup mock patch without `with` part 3 https://review.openstack.org/86536 | 09:26 |
| *** mrda is now known as mrda_away | 09:27 | |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Cleanup mock patch without `with` part 3 https://review.openstack.org/86536 | 09:29 |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Get rid of the newline "\" https://review.openstack.org/66793 | 09:29 |
| *** matsuhashi has quit IRC | 09:30 | |
| *** matsuhashi has joined #openstack-ironic | 09:34 | |
| *** uberj has quit IRC | 09:35 | |
| *** uberj_ has joined #openstack-ironic | 09:36 | |
| *** romcheg has joined #openstack-ironic | 09:39 | |
| *** radsy has joined #openstack-ironic | 09:42 | |
| *** max_lobur1 has joined #openstack-ironic | 09:52 | |
| *** max_lobur has quit IRC | 09:54 | |
| *** ilives has quit IRC | 10:16 | |
| *** ilives has joined #openstack-ironic | 10:17 | |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Get rid object model `dict` methods part 3 https://review.openstack.org/64108 | 10:19 |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Get rid object model `dict` methods part 1 https://review.openstack.org/60025 | 10:19 |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Get rid object model `dict` methods part 2 https://review.openstack.org/62331 | 10:19 |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Get rid object model `dict` methods part 5 https://review.openstack.org/64278 | 10:19 |
| openstackgerrit | Mikhail Durnosvistov proposed a change to openstack/ironic: Old value 'updated_at' field returned after update https://review.openstack.org/75430 | 10:19 |
| *** matsuhashi has quit IRC | 10:20 | |
| *** matsuhashi has joined #openstack-ironic | 10:25 | |
| openstackgerrit | Vladimir Kozhukalov proposed a change to openstack/ironic-python-agent: Added lvm partitioner https://review.openstack.org/85672 | 10:34 |
| openstackgerrit | Vladimir Kozhukalov proposed a change to openstack/ironic-python-agent: Added disk partitioner https://review.openstack.org/86163 | 10:36 |
| *** mrda_away is now known as mrda | 10:40 | |
| *** overlayer has joined #openstack-ironic | 10:55 | |
| *** radsy has quit IRC | 10:58 | |
| *** nosnos has quit IRC | 10:59 | |
| *** nosnos has joined #openstack-ironic | 10:59 | |
| lucasagomes | dtantsur, ping re @patch decorator | 11:00 |
| dtantsur | lucasagomes, sure | 11:00 |
| lucasagomes | dtantsur, so if I use the decorator, it give me the mocked object as a parameter | 11:00 |
| lucasagomes | how can I stop that mock? | 11:00 |
| lucasagomes | calling mock.stop() doesn't seems to be working | 11:01 |
| dtantsur | lucasagomes, yep. It will be stopped once you live decorated method. No stop() required | 11:01 |
| lucasagomes | (I used the @patch.mock, on the class itself so all the methods has this mock being passed by parameters) | 11:01 |
| dtantsur | * live = leave | 11:01 |
| lucasagomes | dtantsur, but for some tests I don't want it to be mocked | 11:01 |
| lucasagomes | that's why I created that stopPatchers() method | 11:01 |
| lucasagomes | so I could call stop() | 11:02 |
| lucasagomes | or you think that for that specific tests I should create a new class? | 11:02 |
| lucasagomes | where it won't be mocked | 11:02 |
| dtantsur | lucasagomes, I think there are two Correct(tm) ways of doing it: 1. seperate into two test cases. this what I vote for - if you need different setUp's - then they are different cases | 11:03 |
| lucasagomes | ack | 11:03 |
| lucasagomes | dtantsur, yeah I thought about #1 | 11:03 |
| dtantsur | ok, I think it's better | 11:03 |
| lucasagomes | but was thinking if there was a nice way to stop it | 11:03 |
| lucasagomes | so I could just use the same class | 11:03 |
| lucasagomes | dtantsur, cheerios | 11:03 |
| dtantsur | :) | 11:03 |
| *** nosnos has quit IRC | 11:03 | |
| *** overlayer has quit IRC | 11:12 | |
| *** coolsvap is now known as coolsvap|afk | 11:12 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Replace sfdisk with parted https://review.openstack.org/84396 | 11:14 |
| *** matsuhashi has quit IRC | 11:14 | |
| *** overlayer has joined #openstack-ironic | 11:15 | |
| *** ndipanov has quit IRC | 11:16 | |
| *** rameshg87 has left #openstack-ironic | 11:19 | |
| *** matsuhashi has joined #openstack-ironic | 11:22 | |
| *** mkerrin has quit IRC | 11:25 | |
| *** ndipanov has joined #openstack-ironic | 11:31 | |
| *** matsuhashi has quit IRC | 11:31 | |
| *** mkerrin has joined #openstack-ironic | 11:32 | |
| *** sanek11 is now known as agordeev | 11:33 | |
| *** matsuhas_ has joined #openstack-ironic | 11:33 | |
| *** mrda is now known as mrda_away | 11:44 | |
| *** mdickson has joined #openstack-ironic | 11:47 | |
| openstackgerrit | Andrey Kurilin proposed a change to openstack/python-ironicclient: Sync latest code and reuse exceptions from oslo https://review.openstack.org/71500 | 11:51 |
| *** mdickson has quit IRC | 11:54 | |
| *** matsuhas_ has quit IRC | 11:57 | |
| *** mdickson has joined #openstack-ironic | 11:57 | |
| *** mdickson has quit IRC | 12:04 | |
| *** jistr has quit IRC | 12:07 | |
| *** jistr has joined #openstack-ironic | 12:07 | |
| *** romcheg has quit IRC | 12:08 | |
| openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Do not sync power state for new invalidated nodes https://review.openstack.org/86529 | 12:09 |
| *** romcheg has joined #openstack-ironic | 12:10 | |
| *** jdob has joined #openstack-ironic | 12:32 | |
| *** linggao has joined #openstack-ironic | 12:35 | |
| *** romcheg has quit IRC | 12:35 | |
| *** romcheg has joined #openstack-ironic | 12:37 | |
| *** foexle has joined #openstack-ironic | 12:41 | |
| foexle | heyho guys, could anyone give an answer of this question? https://ask.openstack.org/en/question/26901/ironic-if-the-compute-node-fails/ it would be very helpful. sry for the push | 12:42 |
| Shrews | lucasagomes: i highly recommend that 86473 gets merged today. | 12:49 |
| lucasagomes | Shrews, will take a quick look | 12:50 |
| Shrews | lucasagomes: it fixes the OOM problem | 12:50 |
| lucasagomes | Shrews, great! only one objection about using tearDown() | 12:55 |
| lucasagomes | Shrews, http://lists.openstack.org/pipermail/openstack-dev/2013-October/016203.html | 12:55 |
| lucasagomes | Shrews, I will comment on the patch | 12:55 |
| lucasagomes | but otherwise it lgtm | 12:55 |
| *** pradipta is now known as pradipta_away | 12:55 | |
| Shrews | lucasagomes: ah, that's interesting | 12:56 |
| lucasagomes | Shrews, yeah, I left a snippet inline | 12:57 |
| Shrews | great | 12:57 |
| *** rloo has joined #openstack-ironic | 12:57 | |
| lucasagomes | once it's get's update I will +2 it and then we ping another core to approve it | 12:57 |
| Shrews | awesome. adam_g ^^^^ | 12:58 |
| lucasagomes | :) | 12:59 |
| *** jbjohnso_ has joined #openstack-ironic | 13:00 | |
| openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add FlowExtension https://review.openstack.org/85412 | 13:04 |
| openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic-python-agent: Resolve circular import, introduce ExecuteCommandMixin https://review.openstack.org/86341 | 13:04 |
| *** matty_dubs|gone is now known as matty_dubs | 13:08 | |
| *** dtantsur is now known as dtantsur|bbl | 13:11 | |
| *** mdickson has joined #openstack-ironic | 13:20 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMINative to use the new ManagementInterface https://review.openstack.org/86588 | 13:22 |
| *** mdickson has quit IRC | 13:24 | |
| openstackgerrit | A change was merged to openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/83488 | 13:36 |
| *** mdickson has joined #openstack-ironic | 13:47 | |
| *** saju_m has joined #openstack-ironic | 13:50 | |
| *** mdickson has quit IRC | 13:52 | |
| *** dwalleck_ has joined #openstack-ironic | 13:54 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Use configurable driver name in lookup URL https://review.openstack.org/86201 | 13:57 |
| openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add FlowExtension https://review.openstack.org/85412 | 13:59 |
| openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic-python-agent: Resolve circular import, introduce ExecuteCommandMixin https://review.openstack.org/86341 | 13:59 |
| *** mdickson has joined #openstack-ironic | 13:59 | |
| NobodyCam | good morning Ironic | 14:04 |
| agordeev | NobodyCam: good morning | 14:06 |
| NobodyCam | morning agordeev | 14:06 |
| Mikhail_D_wk | NobodyCam: morning :) | 14:06 |
| NobodyCam | mornig Mikhail_D_wk :) | 14:06 |
| *** dwalleck_ has quit IRC | 14:10 | |
| *** dwalleck has joined #openstack-ironic | 14:12 | |
| *** datajerk has joined #openstack-ironic | 14:13 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Use # instead of """ for copyright blocks https://review.openstack.org/86455 | 14:14 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Bring agent deploy driver up to date with virt https://review.openstack.org/86490 | 14:16 |
| jroll | morning ironic :) | 14:18 |
| NobodyCam | good morning jroll | 14:20 |
| jbjohnso_ | morning | 14:20 |
| NobodyCam | morning jbjohnso_ :) | 14:21 |
| openstackgerrit | Vladimir Kozhukalov proposed a change to openstack/ironic-python-agent: Added disk partitioner https://review.openstack.org/86163 | 14:21 |
| *** mdickson2 has joined #openstack-ironic | 14:22 | |
| *** mdickson has quit IRC | 14:22 | |
| agordeev | jroll: morning | 14:24 |
| Mikhail_D_wk | jroll: morning :) | 14:25 |
| *** mdickson2 has quit IRC | 14:28 | |
| *** jgrimm has joined #openstack-ironic | 14:29 | |
| *** jgrimm has quit IRC | 14:29 | |
| *** mdickson has joined #openstack-ironic | 14:30 | |
| *** jgrimm has joined #openstack-ironic | 14:30 | |
| rloo | lucasagomes: when do you +2 vs +1? https://review.openstack.org/#/c/85600/ | 14:33 |
| NobodyCam | morning rloo | 14:33 |
| rloo | morning NobodyCam (and all ironic'ers) | 14:34 |
| lucasagomes | rloo, heh I can't +2 that because it's in another branch | 14:34 |
| lucasagomes | the milestone proposed branch | 14:34 |
| lucasagomes | morning rloo NobodyCam | 14:34 |
| NobodyCam | morning lucasagomes | 14:34 |
| lucasagomes | rloo, these are back-port patches | 14:34 |
| rloo | lucasgomes: ahh, so core isn't all-that powerful :-) | 14:35 |
| lucasagomes | rloo, https://review.openstack.org/#/q/status:open+project:openstack/ironic+branch:milestone-proposed,n,z | 14:35 |
| lucasagomes | rloo, heh not really | 14:35 |
| lucasagomes | :( | 14:35 |
| rloo | lucasagomes: otherwise, do you normally +2 instead of +1? | 14:35 |
| lucasagomes | rloo, yup | 14:35 |
| lucasagomes | rloo, but, sometimes I use +1 | 14:35 |
| NobodyCam | lucasagomes: question, have any thought on why I cn not force debug logging? | 14:35 |
| lucasagomes | rloo, one example, https://review.openstack.org/#/c/84374/ | 14:36 |
| lucasagomes | rloo, the code lgtm, but I was a bit concerned about issuing IPMI commands synchronously... As I don't have much experience/knowledge of IPMI I +1 and put my concerns in the comment | 14:36 |
| lucasagomes | NobodyCam, hey, idk really... I saw ur patch yesterday | 14:37 |
| NobodyCam | heheheh | 14:37 |
| lucasagomes | I didn't do any investigation on it, but that looked fine, setting the debug=True in the ironic.conf works in my env as far as I can tell | 14:37 |
| lucasagomes | NobodyCam, lemme test it | 14:37 |
| rloo | lucasagomes: ahh, got it. That explains your comment there ;) | 14:37 |
| lucasagomes | NobodyCam, 2014-04-10 13:01:55.085 12077 DEBUG ironic.conductor.manager [req-11921e85-8747-461e-a27a-b97549a95a8a admin admin] RPC update_node called for node cda524d3-93d4-477d-8f3e-dc2caa0899ee. update_node /opt/stack/ironic/ironic/conductor/manager.py:188 | 14:38 |
| *** mdickson2 has joined #openstack-ironic | 14:38 | |
| lucasagomes | NobodyCam, I see debug logs in my env | 14:38 |
| *** mdickson has quit IRC | 14:39 | |
| lucasagomes | rloo, yeah :) | 14:39 |
| NobodyCam | lucasagomes: your running devstack. and the default conf option in openstack/common/log to true | 14:39 |
| NobodyCam | s/and the/and set the/ | 14:40 |
| lucasagomes | right | 14:40 |
| agordeev | rloo: morning | 14:40 |
| NobodyCam | ack | 14:40 |
| mdickson2 | I have an ironic "philosophy" question... Is Ironic targeting hardware provisioning or hardware management? That is, how in scope is full management of the hardware (BIOS settings, firmware management, real time hardware monitoring, etc)? | 14:43 |
| rloo | morning/afternoon? agordeev | 14:44 |
| *** dwalleck_ has joined #openstack-ironic | 14:45 | |
| NobodyCam | mdickson2: provisioning.. thou that may involve some management. like setting vt bit in bios | 14:45 |
| lucasagomes | mdickson2, ^, no monitoring | 14:46 |
| mdickson2 | Ok, understood. So things that relate to provisioning.. But it wouldn't be a replacement for a hardware management and monitoring solution. | 14:47 |
| NobodyCam | not at all | 14:47 |
| *** ilives has quit IRC | 14:47 | |
| NobodyCam | (wouldn't be a replacement for a hardware management and monitoring solution) | 14:47 |
| mdickson2 | I see some issues if you do full management with tenants. Being able to assign bare metal resources to projects and then losing control of the server. | 14:47 |
| NobodyCam | yes there are many securty conserns with untrusted tentants in baremetal | 14:48 |
| mdickson2 | Ok, thank you. Having some internal discussions in my group and its been represented differently. I understood it as more focused on the provisioning issue. | 14:48 |
| *** lazy_prince has joined #openstack-ironic | 14:48 | |
| *** ilives has joined #openstack-ironic | 14:48 | |
| *** dwalleck has quit IRC | 14:49 | |
| NobodyCam | mdickson2: prob because of blueprints like this: https://blueprints.launchpad.net/ironic/+spec/send-data-to-ceilometer | 14:50 |
| agordeev | rloo: morning/evening :) | 14:50 |
| rloo | agordeev: not night? :-) | 14:51 |
| NobodyCam | we can talk to the chassis' bmc and there for it is possible for ironic to get that data | 14:51 |
| *** dwalleck_ has quit IRC | 14:51 | |
| agordeev | rloo: not night, right. The sun will go down within a hour | 14:52 |
| mdickson2 | I do understand that some drivers might be able to provide sensor information, etc. And I dont see a real issue with that. But thing like managing firmware revisions and configuring storage, etc.. Things that would normally be handled by a hardware management platform seem out of scope. | 14:53 |
| rloo | agordeev: ok, your night is my noon then ;) | 14:54 |
| mdickson2 | I know there is a blueprint for firmware for instance but that seems more focused on loading nic firmware and that sort of thing vs something that might keep track of compatible firmware versions or manage chassis and bmc firmware, etc. | 14:54 |
| jbjohnso_ | so, does anyone think a blueprint for that console service I youtubed would be of interest? | 14:54 |
| NobodyCam | jbjohnso_: I do | 14:55 |
| NobodyCam | mdickson2: yes we may be able to do the FW upgrade about we do not track anything about it | 14:55 |
| jbjohnso_ | I need to see what keystone auth would mean for the http half... | 14:55 |
| lucasagomes | jbjohnso_, do you have the youtube link handy? | 14:56 |
| jbjohnso_ | https://www.youtube.com/watch?v=G_lDaktYnsQ | 14:56 |
| mdickson2 | Thanks for the clarification! | 14:57 |
| NobodyCam | :) happy to :) | 14:57 |
| jbjohnso_ | lucasagomes, I kept it at 5 minutes, which is about as much attention span as I can generally spare for videos | 14:57 |
| NobodyCam | brb | 14:58 |
| lucasagomes | jbjohnso_, heh thanks | 14:58 |
| jbjohnso_ | I saw a 45 minute video about tmux...I love tmux but man.... | 14:58 |
| jbjohnso_ | well, saw that there *was* a 45 minute video, couldn't watch it | 14:58 |
| devananda | g'morning, all | 14:59 |
| NobodyCam | good morning devananda | 14:59 |
| openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add FlowExtension https://review.openstack.org/85412 | 14:59 |
| openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic-python-agent: Resolve circular import, introduce ExecuteCommandMixin https://review.openstack.org/86341 | 14:59 |
| agordeev | devananda: morning | 15:00 |
| jbjohnso_ | lucasagomes, also, http://sourceforge.net/p/xcat/confluent/ci/master/tree/ | 15:00 |
| jbjohnso_ | for people to bash code | 15:00 |
| lucasagomes | jbjohnso_, nice... btw when you changed address there and the title changed to unconnected, would the right world be disconnected? | 15:02 |
| lucasagomes | wouldn't* | 15:03 |
| lucasagomes | word* | 15:03 |
| lucasagomes | gosh | 15:03 |
| lucasagomes | hah | 15:03 |
| jbjohnso_ | I think it disconnects the wrong world | 15:03 |
| jbjohnso_ | I need to dictionary up | 15:04 |
| lucasagomes | right, I thought unconnected was used only if something was never connected before | 15:04 |
| lucasagomes | jbjohnso_, no worries just wondering, I'm not even a native speaker | 15:05 |
| *** ifarkas has quit IRC | 15:05 | |
| jbjohnso_ | well, that is a possible state too.. | 15:05 |
| lucasagomes | just curiosity | 15:05 |
| *** saju_m has quit IRC | 15:05 | |
| jbjohnso_ | didn't know if 'was connected and no longer' was worth distinguishing from 'never was connected' | 15:05 |
| lucasagomes | jbjohnso_, great video! | 15:05 |
| lucasagomes | jbjohnso_, yeah, english is tricky, in portuguese we have no distinction for no connectivity... but english sometimes has different words for very specific things, like unconnected vs disconnected | 15:07 |
| lucasagomes | anyhoo | 15:07 |
| openstackgerrit | Russell Haering proposed a change to openstack/ironic: Factor hash ring management out of the conductor https://review.openstack.org/84814 | 15:09 |
| lucasagomes | romcheg, https://review.openstack.org/#/c/85996/ w00t! | 15:10 |
| romcheg | lucasagomes: yup :) | 15:11 |
| jbjohnso_ | lucasagomes, dictionaries just confused me | 15:11 |
| lucasagomes | jbjohnso_, lol | 15:11 |
| lucasagomes | jbjohnso_, google says | 15:11 |
| lucasagomes | unconnected: not joined together or to something else. | 15:11 |
| romcheg | lucasagomes: Let's wait until it's merged and try re-checking your patch again. | 15:11 |
| lucasagomes | disconnected: having had a connection broken. | 15:11 |
| lucasagomes | jbjohnso_, disconnected sounds more accurate to me for that case | 15:12 |
| romcheg | lucasagomes: I'm going to disappear in about an hour or so to drink much alcohol regarding to my birthday last Monday | 15:12 |
| *** foexle has quit IRC | 15:12 | |
| NobodyCam | :) enjoy romcheg :) | 15:12 |
| NobodyCam | and good morning | 15:12 |
| romcheg | Morning NobodyCam and everyone else | 15:13 |
| lucasagomes | romcheg, oh enjoy it and happy birthday (late)!! | 15:13 |
| romcheg | Hopefully this patch merges faster than I will have to go :) | 15:13 |
| lucasagomes | romcheg, yeah, I can trigger the recheck (and remove the WIP) once it's merged | 15:14 |
| lucasagomes | NobodyCam, btw, I want to remove that driver_fields mapping from the driver | 15:15 |
| NobodyCam | lucasagomes: sure | 15:15 |
| NobodyCam | it was a first stab | 15:15 |
| lucasagomes | NobodyCam, reason: if ironic have to translate some field, like swap_mb -> swap_gb, it doesn't fits very well on that model | 15:15 |
| lucasagomes | NobodyCam, yeah | 15:15 |
| *** coolsvap|afk is now known as coolsvap | 15:16 | |
| lucasagomes | I want to encapsulate it in a class and make it get the fields/do conversions for me | 15:16 |
| lucasagomes | let's see, /me looking the code | 15:16 |
| lucasagomes | looking at* | 15:16 |
| NobodyCam | :) | 15:16 |
| *** datajerk has quit IRC | 15:17 | |
| NobodyCam | ahh ha | 15:21 |
| NobodyCam | lucasagomes: do you have any logging.conf files in your /etc/ironic dir? | 15:21 |
| lucasagomes | NobodyCam, not really | 15:22 |
| lucasagomes | [stack@localhost devstack]$ ls /etc/ironic/ | 15:22 |
| lucasagomes | ironic.conf policy.json rootwrap.conf rootwrap.d | 15:22 |
| NobodyCam | https://github.com/openstack/tripleo-image-elements/blob/master/elements/ironic-conductor/os-apply-config/etc/ironic/logging-conductor.conf | 15:22 |
| NobodyCam | boo ya | 15:22 |
| lucasagomes | NobodyCam, oh | 15:23 |
| lucasagomes | NobodyCam, so that might be changing the logging level you think? | 15:23 |
| NobodyCam | putting up a patch to remove them now | 15:23 |
| lucasagomes | right | 15:23 |
| NobodyCam | nope just going to remove them. | 15:23 |
| lucasagomes | I c | 15:23 |
| rloo | NobodyCam: do we need to document the ordering/how log levels are determined? | 15:25 |
| *** dwalleck_ has joined #openstack-ironic | 15:26 | |
| *** mdickson2 has quit IRC | 15:27 | |
| *** dwalleck has joined #openstack-ironic | 15:28 | |
| *** dwalleck_ has quit IRC | 15:31 | |
| *** dwalleck has quit IRC | 15:33 | |
| NobodyCam | rloo: hummm... | 15:37 |
| rloo | NobodyCam: just thinking that if it took you awhile to figure out what was going on, maybe there is something we can do to make it easier next time ;) | 15:38 |
| NobodyCam | ya but the logging level are standard.. this was / is a config error | 15:39 |
| rloo | NobodyCam: ok. I wasn't paying much attention. I thought you set Debug=true in ironic.conf, but that was overruled by the logging.conf file? | 15:40 |
| Shrews | lucasagomes: thx for your explanation on HTTPBadRequest. based on your comments, I think I'll just remove handling that from the wrapper and let the calling code deal with it. sound good? | 15:42 |
| lucasagomes | Shrews, yup it sounds good | 15:42 |
| russell_h | this just needs one more +2: https://review.openstack.org/#/c/82773/ | 15:43 |
| lucasagomes | it's my patch otherwise I would +2/A :) | 15:43 |
| NobodyCam | i'll take a look right after quick walkies | 15:44 |
| rloo | russell_h: am actually looking at it now. | 15:45 |
| openstackgerrit | David Shrewsbury proposed a change to openstack/ironic: Encapsulate Ironic client retry logic https://review.openstack.org/83105 | 15:45 |
| *** mdickson has joined #openstack-ironic | 15:47 | |
| *** mdickson2 has joined #openstack-ironic | 15:49 | |
| rloo | russell_h: ok, I approved it ;) | 15:50 |
| *** mdickson has quit IRC | 15:51 | |
| *** mdickson2 has quit IRC | 15:51 | |
| NobodyCam | w00t Ty rloo :) | 15:53 |
| rloo | NobodyCam: yw ;) | 15:54 |
| *** eghobo has joined #openstack-ironic | 15:54 | |
| *** mdickson has joined #openstack-ironic | 15:55 | |
| *** comstud has quit IRC | 15:55 | |
| *** comstud has joined #openstack-ironic | 15:55 | |
| openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add FlowExtension https://review.openstack.org/85412 | 15:58 |
| openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic-python-agent: Resolve circular import, introduce ExecuteCommandMixin https://review.openstack.org/86341 | 15:58 |
| *** russellb has quit IRC | 15:59 | |
| *** russellb has joined #openstack-ironic | 15:59 | |
| russell_h | agordeev: we discovered yesterday that its really hard to mock with open('/foo') | 16:00 |
| russell_h | agordeev: although I think we got it sort of working eventually | 16:00 |
| agordeev | russell_h: have you seen this ? http://stackoverflow.com/questions/1289894/how-do-i-mock-an-open-used-in-a-with-statement-using-the-mock-framework-in-pyth | 16:06 |
| NobodyCam | lucasagomes: rloo: and anyone else: mind taking a quick look at https://review.openstack.org/86639 | 16:06 |
| * NobodyCam get mo coffee | 16:07 | |
| rloo | NobodyCam: am in the middle of another review (and then want to grab some food). Will look in a bit. | 16:07 |
| NobodyCam | rloo: ack :) Ty | 16:08 |
| agordeev | russell_h: using of mock_open looks very simple and clear | 16:09 |
| lucasagomes | NobodyCam, so os-apply-config on both of that element is only applying that logging.conf file? | 16:12 |
| lucasagomes | NobodyCam, I see u'r removing the dependency there | 16:13 |
| NobodyCam | only frm api.. on conductor its still used for ssh key | 16:13 |
| lucasagomes | ah yeah sorry for the api | 16:13 |
| lucasagomes | NobodyCam, ack, so it lgtm :) | 16:13 |
| NobodyCam | :) +1 helps seepd landing | 16:14 |
| NobodyCam | speed even | 16:14 |
| NobodyCam | :-p | 16:14 |
| *** dtantsur|bbl is now known as dtantsur | 16:15 | |
| lucasagomes | heh | 16:16 |
| *** martyntaylor has left #openstack-ironic | 16:23 | |
| devananda | lucasagomes: on https://review.openstack.org/#/c/84687/5/ironic/nova/virt/ironic/driver.py, whhy do you think a powered ON node, with no instance and not in maintenance, is ok for nova? | 16:25 |
| devananda | lucasagomes: iiuc, ironic will prevent an instance association because the power state isn't OFF | 16:25 |
| NobodyCam | devananda: yes true that | 16:26 |
| lucasagomes | devananda, because it has a valid state | 16:26 |
| lucasagomes | devananda, but yeah hmmm | 16:26 |
| * lucasagomes thinking | 16:26 | |
| lucasagomes | devananda, yeah I can see that conditional | 16:27 |
| lucasagomes | if node_obj['power_state'] != states.POWER_OFF: | 16:28 |
| lucasagomes | raise exception.NodeInWrongPowerState( | 16:28 |
| devananda | right | 16:28 |
| devananda | and virt.ironic.driver L400 | 16:28 |
| devananda | sets the instance_uuid at the top of spawn(), before checking/changing power state | 16:29 |
| devananda | so calling spawn() on a node in states.POWER_ON will fail, i think | 16:29 |
| lucasagomes | devananda, it will | 16:29 |
| devananda | oooh | 16:29 |
| devananda | so that totally prevents the workflow that jroll and folks want to have | 16:30 |
| devananda | with long-lived agents and always-on machines | 16:30 |
| lucasagomes | devananda, it something we cna discuss, if the node is on but has no association or is not in maintenance mode | 16:30 |
| *** dwalleck has joined #openstack-ironic | 16:30 | |
| lucasagomes | should we just reboot it when deploying? | 16:30 |
| lucasagomes | set boot device to pxe, reboot it | 16:30 |
| devananda | well, taht'll depend on the driver | 16:31 |
| devananda | right? | 16:31 |
| devananda | pxe driver will need to reboot it. agent driver will need it to NOT reboot. ilo driver will ... do what ilo driver does | 16:31 |
| lucasagomes | heh yeah | 16:31 |
| lucasagomes | I didn't fully get the always-on thing | 16:31 |
| devananda | so yea, i can see accepting power state ON, because the driver can then make that decision | 16:31 |
| devananda | i don't like it | 16:31 |
| devananda | but i understand the goal -- save ~5 minutes | 16:32 |
| lucasagomes | why you would have always on machines?! | 16:32 |
| lucasagomes | ah | 16:32 |
| devananda | becase POST is very slow on hardware | 16:32 |
| lucasagomes | yeah save 5 minutes in the deployment and spent a lot of money with electricity | 16:32 |
| devananda | right | 16:32 |
| *** yuriyz has quit IRC | 16:32 | |
| lucasagomes | sounds a bit hmm "goofy" but ok it's valid | 16:32 |
| * NobodyCam would choose save the $$$ | 16:33 | |
| JayF | In our hardware lab, it's more like 10m for a reboot ;) | 16:33 |
| lucasagomes | devananda, so, if someone has a use case for that we might want to remove that conditional from ironic | 16:33 |
| devananda | right | 16:33 |
| lucasagomes | devananda, you want me to fill a bug about it? or you are doing that already? | 16:34 |
| devananda | actually | 16:34 |
| lucasagomes | JayF, yeah, well people has different uses cases so we have to incorporate both | 16:34 |
| devananda | JayF: hi! mind if i toss a bug and some doc work your way (or to your team, at least) | 16:34 |
| JayF | technically it's russell_h's team ;) | 16:35 |
| *** vkozhukalov has quit IRC | 16:35 | |
| devananda | since this is more relevant to your use case than any one else's right now | 16:35 |
| devananda | heh | 16:35 |
| JayF | I think this was on jroll's todo list | 16:35 |
| devananda | JayF: i'll just say "ya'll" from now on | 16:35 |
| JayF | devananda: y'all ;) | 16:35 |
| lucasagomes | heh | 16:35 |
| lucasagomes | ye? | 16:35 |
| jroll | devananda: this is indeed on my todo list | 16:35 |
| jroll | so yes | 16:35 |
| jroll | toss away | 16:35 |
| devananda | awesome | 16:35 |
| jroll | for version one we're using the no always on model | 16:36 |
| jroll | and then I was going to poke at that stuff | 16:36 |
| devananda | * file a bug that instance association isn't possible while a node is in state POWER_ON | 16:36 |
| devananda | maybe fix it. should actually be trivial to fix | 16:36 |
| devananda | also, as part of that, add some RST docs (or diagram or something) showing the different permutations of power, association, and maintenance state | 16:37 |
| jroll | sure | 16:37 |
| devananda | i think we're going to all need that to avoid confusion as different drivers follow different workflows around power state | 16:37 |
| lucasagomes | devananda, as _right now_ we don't support the always on thing, do you think I should edit that patch and remove the POWERON (since it's going fail) | 16:38 |
| *** lazy_prince has quit IRC | 16:38 | |
| devananda | lucasagomes: yep | 16:38 |
| lucasagomes | or just leave it to not add extra work later? | 16:38 |
| lucasagomes | devananda, ack | 16:38 |
| lucasagomes | will update | 16:38 |
| devananda | lucasagomes: better to not land something that we know is broken. adding that later is one line in that file :) | 16:38 |
| lucasagomes | devananda, +1 | 16:38 |
| devananda | lucasagomes: you can always tag a #TODO in there | 16:39 |
| * devananda loves #TODOs | 16:39 | |
| lucasagomes | heh | 16:39 |
| devananda | jroll: and thanks! | 16:39 |
| jroll | yep :) | 16:41 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Properly mock _cmd so blockdev does not run https://review.openstack.org/86645 | 16:42 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Implement version 2 payload with more hw info https://review.openstack.org/86475 | 16:44 |
| lucasagomes | devananda, the TODO would be nice if I had more insight about the always on thing or a bug ticket | 16:45 |
| lucasagomes | otherwise it will be a bit "loose" | 16:45 |
| *** hemna_ has joined #openstack-ironic | 16:45 | |
| devananda | lucasagomes: ah, good point | 16:45 |
| devananda | lucasagomes: while you're still here, any thoughts on parted change? | 16:45 |
| devananda | lucasagomes: i see your reply on 84396 | 16:46 |
| lucasagomes | devananda, I left a big log there | 16:46 |
| devananda | ah, /me reads | 16:46 |
| lucasagomes | devananda, so I was investigating it this morning, tl;dr, idk as the same time that sfdisk says its not aligned | 16:46 |
| lucasagomes | parted says it's aligned | 16:46 |
| lucasagomes | devananda, and oddly, sfdisk just complain about misalignement if the partition is < 8GB | 16:47 |
| devananda | :( | 16:47 |
| lucasagomes | devananda, if it's >=8GB sfdisk is pretty happy with it (even if it starts at the same offset as before) | 16:47 |
| lucasagomes | devananda, but if you do an align-check with parted it says "aligned" | 16:48 |
| *** saju_m has joined #openstack-ironic | 16:48 | |
| lucasagomes | so idk it's like parted vs sfdisk args here | 16:48 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Better check for available nodes https://review.openstack.org/84687 | 16:49 |
| devananda | retrying my tests with 9GB root | 16:49 |
| lucasagomes | devananda, ack lemme know | 16:49 |
| lucasagomes | devananda, I want to dig more into the sfdisk code | 16:49 |
| lucasagomes | I will do it, idk strace or something | 16:49 |
| lucasagomes | cause for me it makes no sense that >=8GB it doesn't complain | 16:50 |
| lucasagomes | it starts at the exactly same offset | 16:50 |
| *** epim has joined #openstack-ironic | 16:56 | |
| devananda | lucasagomes: so with 9GB root, i'm not seeing the CHS alignment issue | 16:57 |
| *** derekh has quit IRC | 16:57 | |
| devananda | lucasagomes: but sfdisk -V still complains | 16:57 |
| lucasagomes | devananda, right | 16:57 |
| lucasagomes | :( I gotta dig more into it | 16:57 |
| devananda | "partition does not start at a cylinder boundary" probably does not matter, but "start of partition 1 has impossible value for head" | 16:58 |
| devananda | seems suspicious | 16:58 |
| lucasagomes | devananda, yeah, idk if it's something that parted is actually doing that sfdisk doesn't understand/like | 16:58 |
| lucasagomes | cause for parted it seems fine, you can run align-check there | 16:59 |
| lucasagomes | and it says "aligned" | 16:59 |
| devananda | yea | 16:59 |
| devananda | odd :( | 16:59 |
| lucasagomes | gotta find the root cause of it, but def these two doesn't understand each other | 16:59 |
| NobodyCam | brb | 17:00 |
| devananda | lucasagomes: so I think we should go ahead with the change and the back port, even with the alignment concern | 17:02 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Properly mock _cmd so blockdev does not run https://review.openstack.org/86645 | 17:02 |
| devananda | lucasagomes: afaict, things still _work_. so it's clearly an improvement. and it'll sync up the tooling for icehouse & juno, so later backports of fixes, if needed, would be possible | 17:03 |
| lucasagomes | devananda, right, I'm not concerned about breakage, but if it's really misaligned as sfdisks says it might impact in performance | 17:03 |
| lucasagomes | so it worth have a bug open about it | 17:03 |
| devananda | lucasagomes: if we leave sfdisk in icehouse, we can't backport parted to it after the release | 17:03 |
| lucasagomes | devananda, yeah | 17:03 |
| devananda | lucasagomes: yea. perf issue is, IMO, acceptable at this point | 17:03 |
| lucasagomes | devananda, +1 | 17:03 |
| devananda | broken deploys if swap != 0 ... not acceptable | 17:04 |
| * devananda lands the fixes | 17:04 | |
| lucasagomes | devananda, I will open a bug about it | 17:04 |
| devananda | thanks | 17:04 |
| lucasagomes | the aligment thing | 17:04 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Implement version 2 payload with more hw info https://review.openstack.org/86475 | 17:05 |
| devananda | any other cores want to go approve 84396? | 17:06 |
| *** harlowja_away is now known as harlowja | 17:07 | |
| lucasagomes | I came to the office today... so i gotta go now (take the train) | 17:07 |
| lucasagomes | have a good night everyone | 17:07 |
| NobodyCam | have a good night lucasagomes | 17:07 |
| lucasagomes | devananda, I will try to dig more into it tomorrow, see if I can get some more info about the problem | 17:08 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Implement version 2 payload with more hw info https://review.openstack.org/86475 | 17:08 |
| lucasagomes | night! | 17:08 |
| JoshNang | so i broke a couple tempest test trying to fix the db details leak bug https://review.openstack.org/#/c/73121/. where do i go to fix those tests? | 17:08 |
| *** lucasagomes has quit IRC | 17:09 | |
| *** yongli has quit IRC | 17:13 | |
| *** yongli has joined #openstack-ironic | 17:14 | |
| *** datajerk has joined #openstack-ironic | 17:17 | |
| NobodyCam | devananda: looks like mr Jenkins broke on https://review.openstack.org/#/c/84814/ .. is that recheck or reverify? | 17:18 |
| JayF | lots of jenkins failures from network breakage :z | 17:20 |
| *** jistr has quit IRC | 17:20 | |
| NobodyCam | yea :( | 17:20 |
| *** jistr has joined #openstack-ironic | 17:21 | |
| devananda | yea, recheck is fine | 17:25 |
| NobodyCam | :) | 17:25 |
| devananda | they changed things a while back and reverify isn't really needed now ... heh | 17:25 |
| NobodyCam | ahh I was alway confuzzled by it | 17:25 |
| *** jistr has quit IRC | 17:28 | |
| * NobodyCam grabs mo coffee | 17:37 | |
| NobodyCam | rloo: you commented on 78787 about node_id='123' vs node_id = self.node.id .. but +1'd it | 17:42 |
| rloo | NobodyCam. yeah, I didn't know what to give. Anything but a +/-2. Life was easier when I only had to deal with one's. | 17:42 |
| NobodyCam | hehehe | 17:43 |
| rloo | NobodyCam -- there were so many +1s there. Maybe I should be more hard-nosed. What do you think I should have done? | 17:43 |
| NobodyCam | are you good with it landing as 123? | 17:43 |
| rloo | NobodyCam. yes, that's why I didn't -1 it ;) | 17:44 |
| rloo | also, the 123 was there already. Lucas just refactored it. | 17:44 |
| NobodyCam | ack.. ya.. | 17:44 |
| rloo | so it didn't totally seem fair to block his changes cuz of previous changes ;) | 17:44 |
| NobodyCam | I'll land it.. we can refactor it with another patch | 17:45 |
| rloo | NobodyCam -- let me know when you land it and I'll open a low-hanging-fruit bug for those ;) | 17:45 |
| * rloo thinks it might be nice to somehow reserve really-low-hanging-fruit for newbies. | 17:46 | |
| NobodyCam | yes!!! +a'd should land shortly | 17:46 |
| NobodyCam | devananda: your comments on 84396 (short-term fix sfdisk with parted) still valid after you chat with lucas? patch LGTM. I'm ready to +a just want to dbl check as lucas ended with "I will try to dig more into it tomorrow" | 17:58 |
| devananda | NobodyCam: yea. i still have some small reservations about parted in general, but i havent been able to resolve the bug another way yet | 18:00 |
| devananda | NobodyCam: the issue appears to be just that sfdisk is not happy with the alignment that parted is creating with a root partition < 8GB | 18:00 |
| NobodyCam | devananda: ack, I recall us trying parted with BM | 18:01 |
| NobodyCam | devananda: http://h10025.www1.hp.com/ewfrf/wc/document?cc=uk&lc=en&dlc=en&docname=c03479326 | 18:04 |
| jroll | devananda: here's that bug for deploying to nodes with power state on https://bugs.launchpad.net/ironic/+bug/1306202 | 18:05 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Close file handle after use https://review.openstack.org/86476 | 18:07 |
| NobodyCam | actually this reads a easier: http://rainbow.chard.org/2013/01/30/how-to-align-partitions-for-best-performance-using-parted/ | 18:07 |
| JayF | agordeev: russell_h: Re-implemented the file close with a context_manager and fixed the tests. Awaiting a re-review here -> https://review.openstack.org/#/c/86476 | 18:08 |
| NobodyCam | Bagel Time..brb | 18:10 |
| devananda | NobodyCam: I also opened a bug to add better tests for how we're doing partitioning | 18:13 |
| NobodyCam | devananda: ack I'll land that now! | 18:17 |
| linggao | Hi devananda and NobodyCam, now I am ready to check in the console patch. | 18:21 |
| linggao | I am on the branch that sjing was using. | 18:21 |
| *** uberj_ is now known as uberj | 18:21 | |
| NobodyCam | \o/ | 18:21 |
| linggao | when going git commit -a it asks me to put some message | 18:21 |
| linggao | I thougt I do not need to because sjing already had messages in there. | 18:22 |
| NobodyCam | should have the orginal message there to edit | 18:22 |
| devananda | linggao: i think you want "git commit -a --amend" | 18:22 |
| openstackgerrit | Adam Gandelman proposed a change to openstack/ironic: Cleanup running conductor services in tests https://review.openstack.org/86473 | 18:22 |
| devananda | so that it reuses same commit | 18:22 |
| linggao | ah, forgot --amend :) | 18:23 |
| *** zul has quit IRC | 18:25 | |
| openstackgerrit | linggao proposed a change to openstack/ironic: Support serial console access https://review.openstack.org/64100 | 18:25 |
| linggao | cool! | 18:26 |
| NobodyCam | :> | 18:26 |
| rloo | should we be doing 'recheck' of reviews, or wait til the network hiccups subside? | 18:27 |
| NobodyCam | ??? | 18:28 |
| NobodyCam | prob should check with -infra | 18:28 |
| *** vkozhukalov has joined #openstack-ironic | 18:33 | |
| openstackgerrit | A change was merged to openstack/ironic-python-agent: Close file handle after use https://review.openstack.org/86476 | 18:33 |
| NobodyCam | brb | 18:36 |
| *** max_lobur1 has quit IRC | 18:39 | |
| *** zul has joined #openstack-ironic | 18:40 | |
| *** overlayer has quit IRC | 18:46 | |
| devananda | going for a walk // getting coffee, bbiab | 18:47 |
| *** coolsvap is now known as coolsvap|afk | 18:48 | |
| *** ndipanov has quit IRC | 18:55 | |
| openstackgerrit | A change was merged to openstack/ironic: Replace sfdisk with parted https://review.openstack.org/84396 | 19:01 |
| * devananda is back | 19:08 | |
| *** dwalleck_ has joined #openstack-ironic | 19:08 | |
| *** dwalleck has quit IRC | 19:12 | |
| *** ilives has quit IRC | 19:24 | |
| *** dwalleck has joined #openstack-ironic | 19:29 | |
| *** dwalleck_ has quit IRC | 19:32 | |
| *** krtaylor has quit IRC | 19:36 | |
| *** dwalleck has quit IRC | 19:37 | |
| JayF | vkozhukalov: I responded to your comments on https://review.openstack.org/#/c/86475 -- most of them sounded like good features to be added in the future or concerns about preexisting code. | 19:45 |
| JayF | vkozhukalov: I'd appreciate you to take another look and file bugs for the concerns on the preexisting stuff | 19:46 |
| JayF | vkozhukalov: although, fwiw, I'm going to undertake migrating all the shell out stuff to processutils as my next task | 19:46 |
| openstackgerrit | A change was merged to openstack/ironic-python-agent: Properly mock _cmd so blockdev does not run https://review.openstack.org/86645 | 19:47 |
| vkozhukalov | JayF: thank you for your answers, I agree that most of my comments are about future plans. I'll take a look. and fyi right now I am working on kind of design doc for partitioning, so as to make it clearer for everyone how we are going to use lvm, md, and how to make data driven | 19:52 |
| JayF | vkozhukalov: yeah, given the chatter in here yesterday about whether or not ironic should support md and lvm, I'd like deva to +1 putting LVM/MD stuff in the agent and get a general consensus for doing that | 19:53 |
| *** romcheg1 has joined #openstack-ironic | 19:54 | |
| *** dividebin has quit IRC | 19:56 | |
| devananda | comstud: in your make-things-use-objects, have you touched tests/api/v1/test_ports ? | 19:57 |
| devananda | comstud: if not, i'm going to fix that now, since I need to patch that file anyway for another thing | 19:58 |
| NobodyCam | woo hoo only need one more +2 on https://review.openstack.org/#/c/86639/ | 20:01 |
| comstud | devananda: looking | 20:02 |
| comstud | i'm fixing my patches right now | 20:02 |
| *** dividehex has joined #openstack-ironic | 20:03 | |
| comstud | devananda: I've touched it very little... in 1 patch where I add 'create' on Node | 20:03 |
| *** krtaylor has joined #openstack-ironic | 20:03 | |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Fix Node object version https://review.openstack.org/86696 | 20:05 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Sync object list stuff from Nova https://review.openstack.org/86697 | 20:05 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Add create() and destroy() to Node https://review.openstack.org/84823 | 20:05 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Make tests use Node object instead of dict https://review.openstack.org/84860 | 20:05 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Clean up calls to get_node() https://review.openstack.org/84573 | 20:05 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Remove a DB query for get_ports_by_node() https://review.openstack.org/84861 | 20:05 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Remove DB query from _sync_power_states https://review.openstack.org/84862 | 20:05 |
| comstud | devananda: https://review.openstack.org/#/c/84823/4/ironic/tests/api/v1/test_ports.py | 20:06 |
| comstud | I think those are the only changes I have so far | 20:06 |
| comstud | although | 20:07 |
| devananda | comstud: ok. the file's kinda a mess afaict | 20:07 |
| comstud | I might have messed up something here, because I don't see what this change does at all | 20:07 |
| devananda | test_ports is not mocking the rpc call -- it's using a conductor instance and mocking just a part of that | 20:08 |
| comstud | yeah, I was going to hit all Port stuff next, but haven't gotten there yet | 20:08 |
| comstud | gotcha | 20:08 |
| devananda | which is why it's breaking when i'm changing how conductor service loads drivers | 20:08 |
| devananda | lemme take tthat file :) | 20:08 |
| comstud | yeah, go for it... i can fix up anything i end up doing | 20:09 |
| devananda | fwiw, https://review.openstack.org/#/c/83572 | 20:09 |
| devananda | but once i fix up test_ports, i'll post a new version | 20:09 |
| comstud | https://review.openstack.org/#/c/86696/ | 20:09 |
| comstud | ^ found this as I was rebasing | 20:09 |
| comstud | brb | 20:10 |
| devananda | comstud: thanks, +2'd | 20:11 |
| NobodyCam | rloo: you happen to be around? | 20:12 |
| rloo | NobodyCam: it so happens, yes :-) | 20:12 |
| NobodyCam | hehehe | 20:12 |
| NobodyCam | quick question.. would hate me if I asked to add the irc channel to 85096 | 20:13 |
| rloo | NobodyCam: I think that crossed my mind. I actually copied this from ironic. But I can add irc channel to it. | 20:14 |
| rloo | NobodyCam: I'll even add your nick to it ;) | 20:15 |
| NobodyCam | :) has just about everything else :) | 20:15 |
| NobodyCam | ieek | 20:15 |
| NobodyCam | :) | 20:15 |
| *** NobodyCam is now known as NotNobodyCam | 20:15 | |
| NotNobodyCam | o_o | 20:15 |
| rloo | ha ha | 20:15 |
| *** NotNobodyCam is now known as NobodyCam | 20:16 | |
| JoshNang | heh | 20:16 |
| NobodyCam | :-p | 20:16 |
| rloo | I think, though, NobodyCam, that if you have a comment about a review, you have to be nice enough to provide the wording ;) | 20:16 |
| NobodyCam | I can do that | 20:16 |
| rloo | good, then you can't -1 me for that part! | 20:17 |
| NobodyCam | :-p /me -1 hehehe | 20:17 |
| NobodyCam | maybe -.5 | 20:17 |
| *** epim has quit IRC | 20:18 | |
| rloo | NobodyCam, you can do better than that, write something that deserves a +2! | 20:18 |
| *** epim has joined #openstack-ironic | 20:27 | |
| *** saju_m has quit IRC | 20:28 | |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Implement version 2 payload with more hw info https://review.openstack.org/86475 | 20:28 |
| *** saju_m has joined #openstack-ironic | 20:29 | |
| NobodyCam | rloo: pre your request -1'd :) | 20:30 |
| NobodyCam | hehehe | 20:30 |
| rloo | NobodyCam: thx I think :-) | 20:30 |
| NobodyCam | heheh | 20:30 |
| linggao | devananda, NobodyCam, pep8 failed on my patch. https://review.openstack.org/#/c/64100/ I cannot figure out why from the error log. Could you please help? | 20:31 |
| * NobodyCam looks | 20:31 | |
| rloo | linggao: there have been some network issues. might be due to that. | 20:31 |
| NobodyCam | humm looks like ironic.conf.sample | 20:32 |
| linggao | rloo, but other tests seem proceeded well. | 20:32 |
| NobodyCam | check_uptodate.sh: ironic.conf.sample is not up to date. | 20:33 |
| rloo | linggao: just looked. NobodyCam is right, the sample isn't correct. | 20:34 |
| NobodyCam | linggao: source the venv and run ./tools/config/generate_sample.sh -b ./ -p ironic -o ./etc/ | 20:34 |
| linggao | NobodyCam, rloo. I did not regenerate the sample file after the rebase. Let me work on that. Thanks. | 20:34 |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Implement version 2 payload with more hw info https://review.openstack.org/86475 | 20:36 |
| linggao | NobodyCam, I ran that command, a new file sample file is created, but git status does not show it. | 20:44 |
| linggao | That means it is up to date. | 20:45 |
| NobodyCam | what does git status | 20:45 |
| NobodyCam | sho | 20:45 |
| NobodyCam | w | 20:45 |
| NobodyCam | :-p | 20:45 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Add create() and destroy() to Node https://review.openstack.org/84823 | 20:46 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Sync object list stuff from Nova https://review.openstack.org/86697 | 20:46 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Make tests use Node object instead of dict https://review.openstack.org/84860 | 20:46 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Clean up calls to get_node() https://review.openstack.org/84573 | 20:46 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Remove a DB query for get_ports_by_node() https://review.openstack.org/84861 | 20:46 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Remove DB query from _sync_power_states https://review.openstack.org/84862 | 20:46 |
| NobodyCam | ieek | 20:46 |
| NobodyCam | :-p | 20:46 |
| comstud | sorry, had to rebase :) | 20:46 |
| devananda | NobodyCam: https://review.openstack.org/#/c/84497/ could really use an approval | 20:46 |
| devananda | NobodyCam: it's a backport potential, and we need to alnd the one on master first | 20:46 |
| linggao | NobodyCam, git status shows: nothing to commit (working directory clean) | 20:47 |
| NobodyCam | ahh yes I was going to approve lastnight but both gates jobs failes to I rechecked. and ofc haven't gotten back to it... | 20:47 |
| NobodyCam | looking now | 20:48 |
| devananda | :) | 20:48 |
| devananda | thanks | 20:48 |
| openstackgerrit | Ruby Loo proposed a change to openstack/python-ironicclient: Documentation for contributors https://review.openstack.org/85096 | 20:49 |
| NobodyCam | devananda: it hadn't changed so it got a quick +2 / +a | 20:49 |
| devananda | great, thanks | 20:50 |
| NobodyCam | wow rloo I like your working much better then mine :) | 20:50 |
| NobodyCam | wording even | 20:51 |
| rloo | NobodyCam: I haven't even finished replying to your comment! | 20:51 |
| NobodyCam | :-p | 20:51 |
| NobodyCam | :) | 20:51 |
| rloo | NobodyCam: I couldn't plagiarize when I was in school, but now ... | 20:52 |
| NobodyCam | lol | 20:52 |
| *** killer_prince has quit IRC | 20:53 | |
| NobodyCam | rloo: should I run it thru http://www.dustball.com/cs/plagiarism.checker/ | 20:53 |
| rloo | NobodyCam. ha ha. So, I think that as part of the OpenStack family, we should all speak the same, so it is OK to use similar wording as other members ;) | 20:54 |
| rloo | NobodyCam, and believe me, after looking around at other openstack doc, there's quite a bit of copy/paste :-) | 20:55 |
| *** harlowja is now known as harlowja_away | 20:56 | |
| NobodyCam | hehheeh yes <ctrl-v> there <crtl-v> IS. | 20:56 |
| NobodyCam | Ty rloo +2'ing | 20:57 |
| rloo | thx NobodyCam! Our newbies thank you too ;) | 20:57 |
| *** vkozhukalov has quit IRC | 20:59 | |
| *** mrda_away is now known as mrda | 21:01 | |
| *** matty_dubs is now known as matty_dubs|gone | 21:01 | |
| mrda | morning all | 21:04 |
| NobodyCam | good morning mrda | 21:04 |
| *** mrda is now known as manslaughter | 21:05 | |
| *** radsy has joined #openstack-ironic | 21:06 | |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Deprecate hardware._cmd in favor of utils.execute https://review.openstack.org/86711 | 21:13 |
| NobodyCam | devananda: did you want to keep https://review.openstack.org/#/c/72538/ blocked? | 21:14 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Better handling of missing drivers https://review.openstack.org/83572 | 21:16 |
| * devananda looks | 21:17 | |
| devananda | ooh, no | 21:17 |
| devananda | NobodyCam: thanks for the ping | 21:17 |
| devananda | Haomeng:thanks for the patch! | 21:17 |
| NobodyCam | :) | 21:18 |
| *** jbjohnso_ has quit IRC | 21:19 | |
| *** linggao has quit IRC | 21:21 | |
| openstackgerrit | Jay Faulkner proposed a change to openstack/ironic-python-agent: Deprecate hardware._cmd in favor of utils.execute https://review.openstack.org/86711 | 21:27 |
| openstackgerrit | A change was merged to openstack/ironic: Fix Nova rescheduling tear down problem https://review.openstack.org/84497 | 21:27 |
| JayF | proper formatting for the header license is # prepended to each line, not """ around the whole thing, correct? | 21:34 |
| NobodyCam | ?? I use """ for doc strings and Comments (#) for headers | 21:34 |
| JayF | that's what I thought, thanks | 21:35 |
| JayF | lots of files in ipa that don't match that now, and we have licenses in empty files | 21:35 |
| JayF | so I'm going to fix that | 21:35 |
| JoshNang | JayF: didn't jroll just do a big patch to fix that? | 21:35 |
| jroll | hm | 21:35 |
| NobodyCam | else you'll end up with headers inthe generated docs | 21:35 |
| JayF | um. If he did I missed it. | 21:35 |
| jroll | I did | 21:35 |
| jroll | for the agent | 21:35 |
| JayF | ah | 21:35 |
| JayF | then I should probably review and +2 it, shouldn't I | 21:36 |
| JoshNang | :) | 21:36 |
| jroll | https://review.openstack.org/#/c/86455/ | 21:36 |
| *** vkozhukalov has joined #openstack-ironic | 21:36 | |
| JayF | yup, I completely missed it | 21:36 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Better handling of missing drivers https://review.openstack.org/83572 | 21:39 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Better handling of missing drivers https://review.openstack.org/83572 | 21:40 |
| *** harlowja_away is now known as harlowja | 21:45 | |
| *** tatyana has joined #openstack-ironic | 21:46 | |
| *** krtaylor has quit IRC | 21:46 | |
| devananda | hmm, the bot didn't post my next patch | 21:47 |
| devananda | https://review.openstack.org/86722 | 21:47 |
| *** yonglihe_ has joined #openstack-ironic | 21:49 | |
| rloo | hey, for the ironic install guide, nova.conf needs to be modified. Is it just nova-compute that needs the changes? Am wondering if I should say to make the change to controller and compute nodes, and restart all nova services. | 21:50 |
| *** yongli has quit IRC | 21:50 | |
| *** stack_ has joined #openstack-ironic | 21:51 | |
| devananda | rloo: hmm. no, it is both compute and scheduler, i believe | 21:51 |
| rloo | devananda: yes, you're right. the scheduler_host_manager is also changed. thx, I say restart EVERYTHING! | 21:52 |
| devananda | hehehe | 21:53 |
| devananda | rloo: fwiw, nova conductor and api probably dont need to restart | 21:53 |
| rloo | devananda: just nova-compute and nova-scheduler. | 21:53 |
| rloo | devananda. I was thinking to be safe, if things change in the future, restart it all, but I guess that's kind of cheating. | 21:54 |
| devananda | ya | 21:54 |
| devananda | this should represent current usage | 21:54 |
| devananda | so if something changes, we should change th docs! | 21:54 |
| devananda | :) | 21:54 |
| devananda | also -- it's in teh same code repo | 21:54 |
| rloo | boo hoo | 21:54 |
| devananda | so we can -1 a change that updaets functionality and does not updaet the relevant docs | 21:54 |
| rloo | sure, if you remember ;) | 21:55 |
| devananda | well. if *someone* remembers | 21:55 |
| NobodyCam | and DocImpact tag in commit message | 21:55 |
| rloo | at some point, the nova-related code will be in nova repo (we hope), will the docs move there too? ha ha. | 21:56 |
| devananda | rloo: some of it, yes! heehee | 21:58 |
| devananda | rloo: or into the docs repo for nova | 21:58 |
| devananda | rloo: the end goal is for all the user/deployer/etc docs to move out of our tree and into the doc team | 21:58 |
| devananda | we'll jus tkeep the developer docs in tree | 21:58 |
| rloo | devananda: oh yeah, I forgot about that. Seems so far into the future! | 21:59 |
| devananda | ..... | 21:59 |
| rloo | and is it 'compute service', 'compute services', argh, they don't know how to describe themselves... | 21:59 |
| *** tatyana has quit IRC | 22:01 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Accept new parameters for `prepare_image` https://review.openstack.org/86723 | 22:01 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Better handling of missing drivers https://review.openstack.org/83572 | 22:05 |
| devananda | rloo: as for the doc, i get that it's a WIP -- it's just so good I want to land it now :) | 22:08 |
| devananda | jroll: re your comment on https://review.openstack.org/#/c/81919/2, could that be done in a follow on patch? | 22:09 |
| jroll | devananda: without that, it doesn't... work | 22:10 |
| jroll | like all methods get routed to the base driver | 22:10 |
| devananda | jroll: heh, gotcha | 22:11 |
| devananda | hmm | 22:14 |
| devananda | i think MixinVendorInterface should be in base, not utils | 22:14 |
| devananda | anyway, battery is about to die, heading home | 22:14 |
| devananda | bbiab | 22:14 |
| rloo | devananda: I'm almost done with the install BUT you'll have to wait a few more hours cuz I'm being called for dinner ;) | 22:14 |
| NobodyCam | ok :) enjoy the walk | 22:15 |
| *** saju_m has quit IRC | 22:20 | |
| NobodyCam | humm 84687 has no tests | 22:33 |
| NobodyCam | but devananda +2'd it | 22:33 |
| *** tatyana has joined #openstack-ironic | 22:49 | |
| NobodyCam | brb | 22:50 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Use a released version of Pecan https://review.openstack.org/86729 | 22:52 |
| *** jgrimm has quit IRC | 22:52 | |
| openstackgerrit | A change was merged to openstack/ironic-python-agent: Deprecate hardware._cmd in favor of utils.execute https://review.openstack.org/86711 | 22:52 |
| *** tatyana has quit IRC | 22:53 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding swift temp url support https://review.openstack.org/81391 | 22:55 |
| *** vkozhukalov has quit IRC | 22:55 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 22:56 |
| *** romcheg1 has quit IRC | 23:03 | |
| openstackgerrit | Russell Haering proposed a change to openstack/ironic: Drivers may expose a top-level passthru API https://review.openstack.org/81919 | 23:03 |
| NobodyCam | i wish global updates had a link as to why we need them. would save all the digging | 23:11 |
| JayF | agordeev: https://review.openstack.org/#/c/86341/ needs a rebase and I think you'll have to fix an import in tests/agent.py afterwards | 23:14 |
| NobodyCam | for example: https://review.openstack.org/#/c/85820 looks like it stems from https://github.com/openstack/requirements/commit/f3a3d620191b9b79b885e799edbee8dbfc085070 | 23:15 |
| *** mikal is now known as stillbert | 23:19 | |
| *** eguz has joined #openstack-ironic | 23:21 | |
| *** eghobo has quit IRC | 23:25 | |
| openstackgerrit | A change was merged to openstack/ironic: Move duplicated _get_node(s)_mac_addresses() https://review.openstack.org/78787 | 23:30 |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Drivers to determine acceptable power states https://review.openstack.org/86744 | 23:40 |
| openstackgerrit | A change was merged to openstack/ironic: Fix Node object version https://review.openstack.org/86696 | 23:41 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!