| *** ChanServ changes topic to "OpenStack Bare Metal Provisioning | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic | Status: https://etherpad.openstack.org/p/IronicWhiteBoard" | 00:04 | |
| -openstackstatus- NOTICE: the gate is still fairly backed up, though nodepool is back on track and chipping away at remaining changes. some py3k/pypy node starvation is slowing recovery | 00:04 | |
| *** matsuhashi has joined #openstack-ironic | 00:04 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Factoring out PXE and TFTP functions https://review.openstack.org/90233 | 00:06 |
|---|---|---|
| *** vkozhukalov has quit IRC | 00:09 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Factoring out PXE and TFTP functions https://review.openstack.org/90233 | 00:13 |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 00:15 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 00:37 |
| jroll | I love the back and forth | 00:37 |
| JoshNang | heh | 00:38 |
| JoshNang | what'd ya fix? | 00:38 |
| jroll | node doesn't get passed to vendor validate() or vendor_passthru() | 00:38 |
| JoshNang | ahh | 00:38 |
| JoshNang | sweet thanks | 00:38 |
| jroll | np | 00:39 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Fix typo in rpcapi.driver_vendor_passthru https://review.openstack.org/91493 | 00:47 |
| jroll | ^ SUPER easy review if anyone wants to grab it | 00:48 |
| jroll | (lol) | 00:48 |
| JoshNang | heh | 00:49 |
| *** eguz has quit IRC | 01:10 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 01:23 |
| *** rloo has quit IRC | 01:36 | |
| *** nosnos has joined #openstack-ironic | 01:49 | |
| *** max_lobur1 has quit IRC | 01:59 | |
| *** killer_prince has joined #openstack-ironic | 02:28 | |
| *** jrist is now known as jrist-afk | 02:30 | |
| *** eghobo has joined #openstack-ironic | 03:08 | |
| openstackgerrit | A change was merged to stackforge/pyghmi: General cleanup of session https://review.openstack.org/91425 | 03:18 |
| *** harlowja is now known as harlowja_away | 03:20 | |
| *** harlowja_away is now known as harlowja | 03:21 | |
| *** matsuhashi has quit IRC | 03:28 | |
| *** nosnos has quit IRC | 03:46 | |
| *** matsuhashi has joined #openstack-ironic | 04:35 | |
| *** nosnos has joined #openstack-ironic | 04:36 | |
| *** matsuhashi has quit IRC | 04:48 | |
| *** matsuhashi has joined #openstack-ironic | 04:53 | |
| *** vkozhukalov has joined #openstack-ironic | 05:03 | |
| *** killer_prince is now known as lazy_prince | 05:24 | |
| *** harlowja is now known as harlowja_away | 05:37 | |
| *** Manishanker has joined #openstack-ironic | 05:41 | |
| *** Manishanker has quit IRC | 05:59 | |
| *** derekh has joined #openstack-ironic | 06:02 | |
| *** dwalleck__ has joined #openstack-ironic | 06:03 | |
| *** coolsvap|afk is now known as coolsvap | 06:04 | |
| *** dwalleck__ has quit IRC | 06:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/88508 | 06:07 |
| *** dkehn_ has quit IRC | 06:10 | |
| *** romcheg has joined #openstack-ironic | 06:17 | |
| *** Mikhail_D_ltp has joined #openstack-ironic | 06:20 | |
| *** eghobo has quit IRC | 06:24 | |
| *** vkozhukalov has left #openstack-ironic | 06:54 | |
| *** matsuhashi has quit IRC | 07:09 | |
| *** matsuhas_ has joined #openstack-ironic | 07:12 | |
| *** derekh has quit IRC | 07:13 | |
| *** mrda is now known as mrda_away | 07:43 | |
| *** mkerrin has joined #openstack-ironic | 08:03 | |
| *** lucasagomes has joined #openstack-ironic | 08:20 | |
| *** matsuhas_ has quit IRC | 08:33 | |
| *** athomas has joined #openstack-ironic | 08:33 | |
| *** dkehn has joined #openstack-ironic | 08:33 | |
| *** martyntaylor has joined #openstack-ironic | 08:36 | |
| *** matsuhashi has joined #openstack-ironic | 08:41 | |
| *** gilliard has joined #openstack-ironic | 08:44 | |
| *** Mikhail_D_ltp has quit IRC | 08:48 | |
| *** lynxman has quit IRC | 08:58 | |
| *** derekh has joined #openstack-ironic | 09:07 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Use GB instead of MB for swap https://review.openstack.org/83788 | 09:07 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Place root partition last so that it can always be expanded https://review.openstack.org/90675 | 09:07 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Stop creating a swap partition when none was specified https://review.openstack.org/83726 | 09:07 |
| *** jrist-afk has quit IRC | 09:08 | |
| *** jrist-afk has joined #openstack-ironic | 09:11 | |
| *** lynxman has joined #openstack-ironic | 09:12 | |
| *** tatyana has joined #openstack-ironic | 09:20 | |
| *** tatyana has quit IRC | 09:21 | |
| *** Manishanker has joined #openstack-ironic | 09:23 | |
| *** athomas has quit IRC | 09:30 | |
| *** matsuhashi has quit IRC | 09:32 | |
| *** matsuhashi has joined #openstack-ironic | 09:33 | |
| *** nosnos has quit IRC | 09:54 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMINative set_boot_device persistent https://review.openstack.org/85742 | 10:10 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMITool to use the new ManagementInterface https://review.openstack.org/86092 | 10:10 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: SeaMicro to use the new ManagementInterface https://review.openstack.org/86328 | 10:10 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: IPMINative to use the new ManagementInterface https://review.openstack.org/86588 | 10:10 |
| *** athomas has joined #openstack-ironic | 10:11 | |
| *** max_lobur has joined #openstack-ironic | 10:36 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: SSH virsh to use the new ManagementInterface https://review.openstack.org/89884 | 10:37 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Use GB instead of MB for swap https://review.openstack.org/83788 | 10:45 |
| *** max_lobur has quit IRC | 11:38 | |
| *** dkehn__ has joined #openstack-ironic | 11:48 | |
| *** dkehn__ has quit IRC | 11:49 | |
| *** dkehn__ has joined #openstack-ironic | 11:49 | |
| *** dkehn has quit IRC | 11:50 | |
| *** coolsvap is now known as coolsvap|afk | 11:50 | |
| *** martyntaylor has quit IRC | 11:52 | |
| *** martyntaylor has joined #openstack-ironic | 12:01 | |
| *** lazy_prince has quit IRC | 12:09 | |
| *** killer_prince has joined #openstack-ironic | 12:15 | |
| *** linggao has joined #openstack-ironic | 12:24 | |
| *** Manishanker has quit IRC | 12:31 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/91551 | 12:37 |
| NobodyCam | good morning says the man mak'n coffee | 12:37 |
| *** rloo has joined #openstack-ironic | 12:45 | |
| Shrews | NobodyCam: morning | 12:47 |
| *** jdob has joined #openstack-ironic | 12:47 | |
| NobodyCam | good morning Shrews :) Glade to see you safe...How the weather today? | 12:48 |
| Shrews | gloomy, chance of more storms later, but quiet right now | 12:49 |
| NobodyCam | :) looks like you got power back :) | 12:49 |
| lucasagomes | morning NobodyCam Shrews | 12:49 |
| NobodyCam | morning lucasagomes :) | 12:50 |
| Shrews | NobodyCam: yeah. once the power came back on yesterday, i had to replace a gfci outlet that was buzzing for some reason. that was weird and a little unnerving | 12:50 |
| NobodyCam | :) sounds like a surge when it came back... | 12:51 |
| Shrews | it was an old outlet. probably was about to go anyway | 12:51 |
| Shrews | just never heard one buzz before | 12:51 |
| NobodyCam | I've seen a power strip burn itself to a crisp | 12:52 |
| NobodyCam | anyone have any exp pxe booting SuSe ES? | 12:53 |
| rloo | lucasagomes: qq about https://review.openstack.org/#/c/72418/. I didn't approve it because I thought it had to be verified first. It is OK to approve w/o that? | 12:55 |
| rloo | lucasagomes, NobodyCam, Shrews: hi! :-) | 12:56 |
| NobodyCam | morning rloo :) | 12:56 |
| NobodyCam | rloo as I recall that was a change in the last update. | 12:56 |
| Shrews | hi rloo | 12:56 |
| lucasagomes | rloo, oh crap... not really I should wait for the tripleO verification | 12:56 |
| lucasagomes | rloo, damn it takes ages to be verified then | 12:56 |
| NobodyCam | yes! :( | 12:57 |
| lucasagomes | rloo, but I tested it locally here, it works | 12:57 |
| rloo | lucasagomes: for whatever reason, I thought there were issues that was slowing things down yest. | 12:57 |
| lucasagomes | anyhoo, my bad, I didn't see it wasn't verified... ur +2 was like yesterday 6pm | 12:57 |
| lucasagomes | and it's now 13:57pm here and the verificatino didn't worked yet | 12:57 |
| rloo | lucasagomes: so how does it hurt to approve before the verified? | 12:57 |
| rloo | or does it mean it'll get merged even if the verification fails? | 12:58 |
| lucasagomes | rloo, I think it will merge, I don't think the tripleO verification is actually blocking it | 12:58 |
| rloo | lucasagomes: there is something odd though. Usually jenkins sends email saying it is going to do something. | 12:59 |
| lucasagomes | rloo, yeah... well let's see if it's going to merged b4 or not | 13:00 |
| rloo | lucasagomes: hey, one other question. all your 'remove node from' patches. I approved the first yesterday. then i was wondering if it mattered whether we approved all these, or approve comstud's changes before approving the rest of yours. (wrt rebasing etc) | 13:02 |
| lucasagomes | rloo, hmm I think it's easier to approve comstud changes first | 13:03 |
| lucasagomes | then I can rebase on top of it | 13:03 |
| rloo | lucasagomes: ok, I was wondering that yest. should have asked before approving yours ;) | 13:04 |
| lucasagomes | rloo, heh, it's grand, not a big deal :) just a rebase | 13:04 |
| rloo | lucasagomes: I wasn't sure that it would be a 'simple' rebase :-) | 13:05 |
| *** jrist-afk is now known as jrist | 13:09 | |
| *** rloo has left #openstack-ironic | 13:10 | |
| *** matty_dubs|gone is now known as matty_dubs | 13:26 | |
| jroll | good morning ironic :) | 13:28 |
| NobodyCam | good morning jroll | 13:28 |
| jroll | lucasagomes: when you see this bug, it causes a nova-compute crash, right? https://bugs.launchpad.net/ironic/+bug/1309048 | 13:28 |
| jroll | hey NobodyCam :) | 13:28 |
| lucasagomes | jroll, at start up? | 13:30 |
| jroll | yes | 13:30 |
| jroll | that's what I'm seeing anyway | 13:30 |
| lucasagomes | jroll, it crashes if you use the default ComputeManager | 13:30 |
| lucasagomes | jroll, if you use the ClusteredComputeManager it doesn't | 13:30 |
| jroll | ahh | 13:30 |
| jroll | nice, thank you :) | 13:30 |
| lucasagomes | jrist, you can set in nova | 13:31 |
| lucasagomes | jrist, sorry! | 13:31 |
| jrist | :) | 13:31 |
| jroll | heh | 13:31 |
| jroll | someone needs to change nicks | 13:31 |
| jrist | I rather like my occasional looks into ironic | 13:31 |
| jroll | heh | 13:31 |
| lucasagomes | jroll, you can set in nova under [DEFAULT] compute_manager=ironic.nova.compute.manager.ClusteredComputeManager | 13:31 |
| jroll | I also ping on 'jim' so I end up looking at -infra a lot :P | 13:31 |
| lucasagomes | heh yeah I usually type the first to letters of the nick and hit tab | 13:31 |
| jroll | cool, thanks | 13:32 |
| jroll | right | 13:32 |
| jroll | some clients decide tab priority based on who last spoke, which can be nice | 13:32 |
| lucasagomes | yeah that would be great, I'm using Xchat so it's not that sophisticated :P | 13:33 |
| jroll | heh | 13:33 |
| *** jbjohnso has joined #openstack-ironic | 13:33 | |
| jroll | that did work, thanks lucasagomes :D | 13:35 |
| lucasagomes | jroll, np :) | 13:36 |
| *** dkehn_ has joined #openstack-ironic | 13:38 | |
| *** dkehn__ has quit IRC | 13:40 | |
| NobodyCam | brb | 13:42 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/91551 | 13:44 |
| openstackgerrit | A change was merged to openstack/ironic: Fix typo in rpcapi.driver_vendor_passthru https://review.openstack.org/91493 | 13:46 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/91239 | 13:50 |
| *** max_lobur has joined #openstack-ironic | 13:56 | |
| *** shakamunyi has joined #openstack-ironic | 13:59 | |
| jroll | lucasagomes: one more thing about https://bugs.launchpad.net/ironic/+bug/1309048 ... it also assumes node must be off to deploy. which is valid for the pxe driver, but not the agent driver | 14:04 |
| jroll | see also https://launchpad.net/bugs/1306202 | 14:04 |
| lucasagomes | jroll, I think that patch which is fixing that bug is considering that https://review.openstack.org/#/c/88476/6 | 14:07 |
| lucasagomes | it only checks for NOSTATE and ERROR | 14:07 |
| jroll | lucasagomes: as a temp fix maybe we should just remove the 'and node is powered off'? | 14:07 |
| jroll | mmm | 14:07 |
| lucasagomes | jroll, +1 | 14:07 |
| * jroll looks | 14:07 | |
| lucasagomes | idk why that bug is assigned to me | 14:07 |
| lucasagomes | lemme assign it to adam, he's fixing it | 14:07 |
| jroll | cool | 14:08 |
| jroll | lol | 14:08 |
| lucasagomes | heh sorry for the confusion | 14:08 |
| *** jgrimm has joined #openstack-ironic | 14:11 | |
| jroll | no worries | 14:14 |
| NobodyCam | lol sudo is not a default package on SuSe server :-p | 14:22 |
| lucasagomes | command? | 14:25 |
| NobodyCam | ??? | 14:25 |
| matty_dubs | What? | 14:26 |
| *** max_lobur has quit IRC | 14:26 | |
| lucasagomes | hah, I mean the sudo command is not present by default? | 14:26 |
| matty_dubs | I did a minimal install of Fedora the other day. It was truly minimal. I had to install openssh-client to scp things to it, some LSB stuff for non-default init scripts to work, lsof, vim... | 14:27 |
| NobodyCam | when building SuSe cloudimages dont forget to include Sudo package | 14:27 |
| matty_dubs | It's funny how many things I just take for granted | 14:27 |
| NobodyCam | matty_dubs: ++ | 14:27 |
| matty_dubs | Oh, tar was missing also | 14:30 |
| NobodyCam | nice | 14:30 |
| matty_dubs | But I think no sudo would actually take me a bit to figure out | 14:30 |
| matty_dubs | I've all but forgotten su ;) | 14:31 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 14:31 |
| *** rloo has joined #openstack-ironic | 14:33 | |
| NobodyCam | ya | 14:33 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 14:37 |
| *** dkehn_ is now known as dkehnx | 14:40 | |
| *** matsuhashi has quit IRC | 14:54 | |
| NobodyCam | and no lsb-release... another package | 14:57 |
| NobodyCam | not included | 14:57 |
| matty_dubs | Ooh, my favorite new Gerrit feature -- double-clicking on the Download URL no longer causes it to disappear | 15:06 |
| NobodyCam | :) | 15:07 |
| NobodyCam | ls | 15:12 |
| NobodyCam | ww | 15:12 |
| *** Nisha has joined #openstack-ironic | 15:12 | |
| matty_dubs | lucasagomes: Hey, do you know anything about this? http://paste.openstack.org/show/78236/ | 15:14 |
| * lucasagomes clicks | 15:14 | |
| matty_dubs | It only appeared once in ironic.conf, and commenting it out makes no difference | 15:14 |
| lucasagomes | matty_dubs, yes :) | 15:14 |
| lucasagomes | matty_dubs, you need to clean ur local repo to get rid of the pyc | 15:14 |
| matty_dubs | Ah! | 15:14 |
| lucasagomes | the oslo.message patch removed the whole openstack/common/rpc/* stuff | 15:15 |
| lucasagomes | but the pyc aren't deleted cause they r not tracked by git | 15:15 |
| lucasagomes | matty_dubs, rm -rf ironic/openstack/common/rpc | 15:15 |
| matty_dubs | Sweet, thanks | 15:17 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Add pagination support to {node, port, chassis}-list https://review.openstack.org/91585 | 15:20 |
| lucasagomes | NobodyCam, rloo ^ | 15:21 |
| NobodyCam | :) | 15:21 |
| dhellmann | devananda, russell_h: it sounds like you want to write a PriorityManager or ElectionManager or something that uses an algorithm to let the plugins decide who should take some action before taking it | 15:21 |
| lucasagomes | we didn't get in our tests because the default pagination in the ironic api is 1000 items, but we would have problems after that limit | 15:21 |
| lucasagomes | when using the driver | 15:21 |
| lucasagomes | nova ironic driver* | 15:21 |
| rloo | lucasagomes: do the tests have > 1000 items? (There seem to be an awful lot of stuff to review.) | 15:22 |
| lucasagomes | rloo, heh no | 15:23 |
| rloo | lucasagomes: so is it OK if 91585 doesn't get merged for several weeks? | 15:23 |
| lucasagomes | rloo, but the api by default limit the list of resources returned by the api | 15:23 |
| lucasagomes | rloo, sure | 15:23 |
| lucasagomes | rloo, not ok for me :P that have to keep maintaining the patch heh | 15:24 |
| lucasagomes | but yeah for the rest is ok | 15:24 |
| lucasagomes | :P | 15:24 |
| dhellmann | devananda, russell_h: maybe a similar api to EnabledManager, with a check function that returns a score | 15:26 |
| lucasagomes | I enabled the new gerrit interface and it looks super complicated:O | 15:29 |
| lucasagomes | (you can enable it going to Settings->Preferences and set 'Change View' to 'New Screen' | 15:30 |
| rloo | lucasagomes: if i look at how long some reviews have been in the queue, it has been weeks. so just wanted to understand the priority. seems like everyone needs to rebase their stuff frequently :-( | 15:32 |
| NobodyCam | rloo we need to have a review jam to clean that up | 15:32 |
| lucasagomes | NobodyCam, +1 | 15:32 |
| comstud | i can rebase my task manager patch if needed | 15:33 |
| lucasagomes | comstud, that looks good and I tested :) good stuff | 15:33 |
| rloo | NobodyCam: I'm not convinced a review jam will help. But we could try. It seems like the review jams worked for you before. | 15:33 |
| comstud | lucasagomes: great! | 15:33 |
| lucasagomes | we have a lot of patches refactoring stuff, and usually they change a lot of parts of the code-base | 15:33 |
| lucasagomes | that causes a lot of other patches to have to rebase their stuff | 15:34 |
| lucasagomes | maybe we need a special review jam for such types of patches | 15:34 |
| lucasagomes | refactors and cosmetic changes | 15:34 |
| rloo | lucasagomes: i was wondering if a 'pass the baton' would be faster than a review jam. esp for cosmetic, they usually cover quite a few files, so it takes time to review. Seems like if one core +2, if a second is avail and can approve quickly, that gets it out. | 15:35 |
| *** hemna has joined #openstack-ironic | 15:38 | |
| lucasagomes | rloo, hmm that would work as well | 15:38 |
| rloo | lucasagomes: like what you/i tried to do with that one that replace 'with mock'. I really wanted to approve that one except that two tests got merged :-( | 15:39 |
| lucasagomes | rloo, oh so it just needs a rebase right? | 15:42 |
| lucasagomes | and fixing that two new tests | 15:42 |
| lucasagomes | I +2'd that I think | 15:42 |
| rloo | lucasagomes: yeah, you +2's that. It probably needs a rebase by now, and put back the line that got deleted (I think). I also commented on other stuff that wasn't as important. Was hoping it would be updated soon. | 15:43 |
| Shrews | lucasagomes, devananda: added you two to this devstack change - https://review.openstack.org/#/c/91589/ | 15:43 |
| lucasagomes | rloo, right, so when it gets updated I will review that again asap | 15:44 |
| lucasagomes | the owner is not online :/ | 15:44 |
| rloo | lucasagomes: me too, if I'm around :-) | 15:44 |
| lucasagomes | I think it might be holiday in Ukraine | 15:44 |
| rloo | I hope they can enjoy their holiday... | 15:45 |
| rloo | btw lucasagomes: http://docs.openstack.org/developer/python-ironicclient/. devananda released a new version so we could get that doc up. | 15:51 |
| *** martyntaylor has left #openstack-ironic | 15:53 | |
| * lucasagomes clicks | 15:54 | |
| lucasagomes | ah nice | 15:55 |
| rloo | lucasagomes: apparently, the clients are hooked up so that those docs are only updated when they are released. | 15:55 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: Add create() and destroy() to Node https://review.openstack.org/84823 | 15:56 |
| gilliard | Hi what's the state of "preserve-ephemeral" type functionality in ironic? I believe that it's not implemented, and I'd like to know if there's any bug/bluyeprint/patches which relate? | 15:57 |
| *** newell_ has joined #openstack-ironic | 15:58 | |
| lucasagomes | gilliard, it's implemented in Ironic, you can tell ironic to preserve the ephemeral by adding a config pxe_preserve_ephemeral to the nodes/driver_info | 15:59 |
| *** eghobo has joined #openstack-ironic | 15:59 | |
| gilliard | lucasagomes: Oh! Thank you! | 16:00 |
| lucasagomes | gilliard, I dunno if we are proxying that through nova tho | 16:00 |
| *** athomas has quit IRC | 16:00 | |
| comstud | lucasagomes: I'm rebasing my single-node task_manager patch | 16:00 |
| comstud | definitely got conflicts now | 16:00 |
| lucasagomes | :( | 16:01 |
| rloo | comstud: just started reviewing. | 16:01 |
| comstud | it's not too bad | 16:01 |
| comstud | just a few tests | 16:01 |
| rloo | comstud: I'll wait then. so far just grammatical issues. | 16:01 |
| lucasagomes | gilliard, https://review.openstack.org/#/c/90429/ | 16:03 |
| *** jxstanford has joined #openstack-ironic | 16:04 | |
| comstud | rloo: in the task_manager docstring? | 16:04 |
| gilliard | lucasagomes: thanks again. | 16:04 |
| *** newell_ has quit IRC | 16:04 | |
| lucasagomes | np | 16:04 |
| rloo | comstud: yeah. really minor but i just started. typo in 'peform' (the docstring for the file I guess). and don't know if it is ok or not, but there are two blank spaces before the 'You' in line 25 | 16:06 |
| rloo | comstud: that's as far as I got ;) | 16:06 |
| comstud | ok | 16:06 |
| comstud | thanks | 16:06 |
| comstud | looks like that 'peform' was in master | 16:06 |
| comstud | heh | 16:07 |
| * comstud fixes | 16:07 | |
| rloo | comstud: yeah. i was going to ask politely since it isn't part of your goal :-) | 16:07 |
| comstud | ok, fixed the double space before new sentence, too | 16:08 |
| comstud | no worries :) | 16:08 |
| rloo | thx! | 16:08 |
| comstud | of course, i have an import error somewhere when running tox | 16:08 |
| comstud | now | 16:08 |
| comstud | which is fun to try to track down | 16:08 |
| comstud | ah | 16:08 |
| rloo | ouch. | 16:08 |
| openstackgerrit | David Shrewsbury proposed a change to openstack/ironic: Fix ironic node state comparison https://review.openstack.org/91593 | 16:09 |
| comstud | found it | 16:09 |
| *** newell_ has joined #openstack-ironic | 16:09 | |
| Shrews | dtantsur: 91593 ^^^^ addresses your comment in 90429 | 16:10 |
| *** matty_dubs is now known as matty_dubs|lunch | 16:12 | |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: TaskManager: Only support single node locking https://review.openstack.org/91419 | 16:15 |
| comstud | lucasagomes, rloo: ^ | 16:15 |
| rloo | comstud: should I wait for jenkins first? ;) | 16:15 |
| comstud | Ran 829 (+758) tests in 4.785s (-5.293s) | 16:16 |
| comstud | PASSED (id=99, skips=24) | 16:16 |
| comstud | is that good enough? | 16:16 |
| comstud | hehe | 16:16 |
| * comstud could have faked it | 16:16 | |
| rloo | this is a community based on trust! | 16:16 |
| comstud | :) | 16:18 |
| lucasagomes | hah:D | 16:18 |
| rloo | comstud: qq. the commit sez that the tests were refactored to not use the DB. I am fine with that but just wondering if others will think it should be in a separate patch. | 16:23 |
| comstud | rloo: Well, the tests pretty much needed re-done anyway | 16:26 |
| comstud | completely | 16:26 |
| comstud | because they all passed a list of uuids | 16:26 |
| comstud | but nod | 16:27 |
| rloo | comstud: just cross your fingers... | 16:27 |
| comstud | this is one i'd argue if someone didn't like it | 16:28 |
| comstud | :) | 16:28 |
| rloo | go comstud go! | 16:28 |
| *** tatyana has joined #openstack-ironic | 16:45 | |
| *** newell_ has quit IRC | 16:46 | |
| *** newell_ has joined #openstack-ironic | 16:47 | |
| *** Nisha has quit IRC | 16:49 | |
| lucasagomes | alright going home now (came to the office today)... have a g'night everybody :) | 16:52 |
| *** newell_ has quit IRC | 16:55 | |
| *** lucasagomes has quit IRC | 16:55 | |
| *** newell_ has joined #openstack-ironic | 16:58 | |
| *** derekh has quit IRC | 17:06 | |
| *** stack_ has joined #openstack-ironic | 17:07 | |
| *** shakamunyi has quit IRC | 17:09 | |
| *** martyntaylor has joined #openstack-ironic | 17:12 | |
| *** newell_ is now known as newell | 17:13 | |
| *** matty_dubs|lunch is now known as matty_dubs | 17:14 | |
| *** datajerk has joined #openstack-ironic | 17:20 | |
| *** newell has quit IRC | 17:27 | |
| *** newell has joined #openstack-ironic | 17:31 | |
| *** eghobo has quit IRC | 17:46 | |
| *** eghobo has joined #openstack-ironic | 17:46 | |
| *** Mikhail_D_ltp has joined #openstack-ironic | 17:53 | |
| NobodyCam | going afk for a bit | 17:59 |
| notq | :P | 17:59 |
| *** max_lobur has joined #openstack-ironic | 18:07 | |
| *** harlowja_away is now known as harlowja | 18:12 | |
| *** eguz has joined #openstack-ironic | 19:19 | |
| *** eguz has quit IRC | 19:19 | |
| *** eghobo has quit IRC | 19:23 | |
| *** martyntaylor has left #openstack-ironic | 19:43 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Factoring out PXE and TFTP functions https://review.openstack.org/90233 | 19:45 |
| openstackgerrit | Adam Gandelman proposed a change to openstack/ironic: Decouple state inspection and availability check https://review.openstack.org/88476 | 19:55 |
| *** schofield has joined #openstack-ironic | 19:55 | |
| *** max_lobur has quit IRC | 19:55 | |
| *** schofield has quit IRC | 19:56 | |
| *** schofield has joined #openstack-ironic | 19:57 | |
| *** schofield has left #openstack-ironic | 20:04 | |
| *** derekh_ has joined #openstack-ironic | 20:06 | |
| *** derekh_ has quit IRC | 20:17 | |
| *** stack_ has quit IRC | 20:38 | |
| *** stack__ has joined #openstack-ironic | 20:39 | |
| *** rch has left #openstack-ironic | 20:56 | |
| *** jdob has quit IRC | 21:03 | |
| *** eghobo has joined #openstack-ironic | 21:10 | |
| *** eghobo has quit IRC | 21:11 | |
| *** eghobo has joined #openstack-ironic | 21:11 | |
| *** matty_dubs is now known as matty_dubs|gone | 21:14 | |
| *** tatyana has quit IRC | 21:17 | |
| openstackgerrit | linggao proposed a change to openstack/ironic: Add base function for testing xml response https://review.openstack.org/91681 | 21:19 |
| *** jgrimm has quit IRC | 21:20 | |
| *** newell has quit IRC | 21:21 | |
| *** linggao has quit IRC | 21:22 | |
| *** newell has joined #openstack-ironic | 21:25 | |
| *** jbjohnso has quit IRC | 21:32 | |
| comstud | so | 21:39 |
| comstud | Is the gate skipping test_seamicro? | 21:39 |
| comstud | because not having seamicroclient | 21:39 |
| comstud | because I had some obvious things I didn't fix up in it ina review | 21:40 |
| comstud | that need fixed | 21:40 |
| comstud | and of course, passed locally because I think they're being skipped | 21:40 |
| comstud | but appears the gate must have skipped as well | 21:40 |
| rloo | comstud: yes, the gate skips seamicro. deva has a patch up for that. sec. | 21:41 |
| comstud | yeah | 21:41 |
| comstud | i saw that | 21:41 |
| *** romcheg has quit IRC | 21:41 | |
| comstud | i didn't realize that the gate didn't have the client, tho | 21:42 |
| rloo | the whole idea with mocking, is that the gate will never have 3rd party driver client libraries. | 21:42 |
| comstud | nod | 21:42 |
| comstud | i agree with that | 21:42 |
| rloo | yeah, so things wrt seamicro have failed in the past because of this. initially we had the client and then deva realized that was wrong and took it out. | 21:43 |
| comstud | gotcha | 21:44 |
| openstackgerrit | Chris Behrens proposed a change to openstack/ironic: TaskManager: Only support single node locking https://review.openstack.org/91419 | 21:45 |
| comstud | rloo: ^ i think i hit everything | 21:45 |
| rloo | comstud: thx. i'm trying to force myself to do the test_task_manager.py and I think I have to give up. Don't have the energy. I'll give you what I have in a few. | 21:47 |
| comstud | ok | 21:47 |
| rloo | comstud. that's it for me for this week. I'll take a look at it next week if it hasn't merged by then.;) | 21:52 |
| comstud | ok | 21:56 |
| comstud | ty | 21:56 |
| comstud | rloo: oh, there was supposed to be a test that just tests acquire() calls TaskManager() appropriately. | 21:57 |
| comstud | ie, a unit test for acquire().. if that's not in there, i'll add it. | 21:58 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 21:59 |
| rloo | comstud: ok, i didn't see it, but then, to be honest, I couldn't get myself to 'read' a bunch of the tests. I think I did a quick search. | 21:59 |
| comstud | yeah | 22:00 |
| comstud | I think i forgot it | 22:00 |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 22:07 |
| *** mrda_away is now known as mrda | 22:10 | |
| *** Mikhail_D_ltp has quit IRC | 22:15 | |
| *** romcheg has joined #openstack-ironic | 22:38 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 22:44 |
| *** mrda is now known as manslaughter | 22:55 | |
| *** jxstanford has quit IRC | 23:03 | |
| *** radsy has joined #openstack-ironic | 23:11 | |
| *** radsy has quit IRC | 23:11 | |
| *** radsy has joined #openstack-ironic | 23:11 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 23:12 |
| *** mikal is now known as stillbert | 23:18 | |
| *** manslaughter is now known as misunderstand | 23:25 | |
| *** misunderstand is now known as manslaughter | 23:26 | |
| *** radsy has quit IRC | 23:27 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 23:30 |
| *** shakamunyi has joined #openstack-ironic | 23:42 | |
| *** radsy has joined #openstack-ironic | 23:47 | |
| *** radsy has joined #openstack-ironic | 23:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!