*** lifeless has joined #openstack-ironic | 00:07 | |
*** eghobo has quit IRC | 00:37 | |
*** datajerk has joined #openstack-ironic | 00:41 | |
*** nosnos has joined #openstack-ironic | 01:41 | |
*** Haomeng has quit IRC | 01:49 | |
*** datajerk has quit IRC | 01:51 | |
*** lifeless has quit IRC | 02:16 | |
*** matsuhashi has joined #openstack-ironic | 02:17 | |
*** lifeless has joined #openstack-ironic | 02:24 | |
*** killer_prince has quit IRC | 02:50 | |
*** eghobo has joined #openstack-ironic | 03:19 | |
*** lnxnut has joined #openstack-ironic | 03:30 | |
*** coolsvap|afk is now known as coolsvap | 03:32 | |
*** eghobo has quit IRC | 03:39 | |
*** nosnos has quit IRC | 03:51 | |
*** lnxnut has quit IRC | 03:57 | |
*** john3213 has joined #openstack-ironic | 04:02 | |
*** john3213 has left #openstack-ironic | 04:07 | |
*** eghobo has joined #openstack-ironic | 04:20 | |
*** nosnos has joined #openstack-ironic | 04:32 | |
*** radsy has quit IRC | 05:19 | |
*** Mikhail_D_ltp has joined #openstack-ironic | 05:36 | |
*** Mikhail_D_ltp has quit IRC | 05:52 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/88508 | 06:09 |
---|---|---|
*** ramineni has joined #openstack-ironic | 06:18 | |
*** adam_gone is now known as adam_g | 06:19 | |
*** matsuhashi has quit IRC | 06:25 | |
*** matsuhashi has joined #openstack-ironic | 06:28 | |
*** eghobo has quit IRC | 06:40 | |
*** eghobo has joined #openstack-ironic | 06:40 | |
*** ifarkas has joined #openstack-ironic | 06:42 | |
*** Mikhail_D_wk has joined #openstack-ironic | 06:51 | |
Mikhail_D_wk | Good morning Ironic! :) | 06:53 |
*** eguz has joined #openstack-ironic | 06:57 | |
*** eghobo has quit IRC | 06:57 | |
*** eguz has quit IRC | 06:59 | |
dtantsur | Morning Ironic | 07:02 |
*** geertj has joined #openstack-ironic | 07:23 | |
*** foexle has joined #openstack-ironic | 07:35 | |
*** jistr has joined #openstack-ironic | 08:01 | |
*** killer_prince has joined #openstack-ironic | 08:15 | |
*** athomas has joined #openstack-ironic | 08:19 | |
*** _dguerri is now known as dguerri | 08:26 | |
*** lucasagomes has joined #openstack-ironic | 08:32 | |
*** martyntaylor has joined #openstack-ironic | 08:33 | |
*** derekh_ has joined #openstack-ironic | 08:37 | |
*** dguerri is now known as _dguerri | 08:52 | |
*** _dguerri is now known as dguerri | 09:01 | |
*** ndipanov has joined #openstack-ironic | 09:16 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Add pagination support to {node, port, chassis}-list https://review.openstack.org/91585 | 09:22 |
*** lsmola has joined #openstack-ironic | 09:44 | |
*** matsuhashi has quit IRC | 09:50 | |
*** geertj has quit IRC | 09:57 | |
*** geertj has joined #openstack-ironic | 10:07 | |
*** martyntaylor has left #openstack-ironic | 10:07 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove 'node' parameter from the Console and Rescue interfaces https://review.openstack.org/91097 | 10:08 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove 'node' parameter from the Power interface https://review.openstack.org/91093 | 10:09 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove 'node' parameter from the Deploy interface https://review.openstack.org/91062 | 10:09 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove 'node' parameter from the validate() methods https://review.openstack.org/91104 | 10:09 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove 'node' parameter from the Console and Rescue interfaces https://review.openstack.org/91097 | 10:15 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove 'node' parameter from the validate() methods https://review.openstack.org/91104 | 10:15 |
*** coolsvap is now known as coolsvap|afk | 10:16 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Pass kwargs to ClientWrapper's call() method https://review.openstack.org/92384 | 10:29 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: list_instances() to return a list of instances names https://review.openstack.org/92385 | 10:29 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add the remaining unittests to the ClientWrapper class https://review.openstack.org/92416 | 10:35 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Run keepalive in a dedicated thread https://review.openstack.org/93083 | 10:39 |
*** ramineni has quit IRC | 11:01 | |
*** dguerri is now known as _dguerri | 11:12 | |
*** lnxnut has joined #openstack-ironic | 11:13 | |
*** overlayer has joined #openstack-ironic | 11:16 | |
*** nosnos has quit IRC | 11:21 | |
*** lnxnut has quit IRC | 11:24 | |
NobodyCam | Good morning Iroinc | 11:45 |
agordeev | NobodyCam: good morning | 11:46 |
agordeev | for everyone else good morning too! | 11:46 |
lucasagomes | NobodyCam, hey buddy! worrying about u cause u didn't appear in the summit on the last days | 11:47 |
lucasagomes | NobodyCam, everything is ok? | 11:47 |
lucasagomes | agordeev, morining | 11:47 |
Shrews | morning all | 11:49 |
lucasagomes | morning Shrews | 11:49 |
NobodyCam | morning agordeev lucasagomes and Shrews | 11:50 |
NobodyCam | lucasagomes: I had to leave the summot to deal with family issues... :( | 11:50 |
lucasagomes | NobodyCam, :( I c, I hope everything is fine by now | 11:51 |
NobodyCam | my dad had a stroke | 11:51 |
lucasagomes | NobodyCam, oh, sorry to hear that | 11:51 |
NobodyCam | I am about two hours out side NEbreaska | 11:51 |
agordeev | lucasagomes, Shrews morning :) | 11:51 |
NobodyCam | will be htere today | 11:51 |
lucasagomes | NobodyCam, :) | 11:52 |
lucasagomes | good good | 11:52 |
NobodyCam | brb walkies and coffee | 11:53 |
lucasagomes | ack, I'm going for lunch brb as well | 11:58 |
*** lucasagomes is now known as lucas-hungry | 11:58 | |
*** pelix has joined #openstack-ironic | 11:59 | |
geertj | Question: is there a place to store driver specific information that is not node specific? | 12:00 |
NobodyCam | geertj: such as? | 12:04 |
geertj | NobodyCam: I'm trying to do a "virtual bare metal" driver for Ravello. I need a global API username, password, and some more metadata. | 12:04 |
Shrews | geertj: config options? | 12:07 |
openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic-python-agent: Add hardware_utils https://review.openstack.org/92399 | 12:08 |
NobodyCam | geertj: I don't think we have that today. | 12:08 |
openstackgerrit | Aleksandr Gordeev proposed a change to openstack/ironic-python-agent: Introduce MainlineHardwareManager https://review.openstack.org/92847 | 12:08 |
NobodyCam | ya I could see a config option | 12:08 |
geertj | NobodyCam/Shrews: I think config options are the right solution. | 12:09 |
geertj | I see there's options for "ssh" and "seamicro" too. | 12:09 |
Shrews | yup | 12:09 |
NobodyCam | :) | 12:11 |
NobodyCam | I've also envisioned chassis holding defaults for nodes. but not yet | 12:12 |
NobodyCam | :0p | 12:12 |
*** Mikhail_D_wk has quit IRC | 12:12 | |
*** Mikhail_D_wk has joined #openstack-ironic | 12:13 | |
geertj | Options in a chassis would actually be useful here. Ravello has the notion of an application which would map very well to a chassis. | 12:13 |
geertj | But I can look into that later. First want to get something up and running :) | 12:13 |
NobodyCam | geertj: yep :) | 12:13 |
geertj | Regarding the options: it looks like etc/ironic/ironic.conf.sample is autogenerated? Any hints? | 12:13 |
NobodyCam | ??? add the option and regrn the sample | 12:14 |
NobodyCam | add the option to the code and re gen the sample congig | 12:14 |
NobodyCam | gah ... /me needs coffee | 12:15 |
geertj | This is all new to me... Where do I add define an option (sorry for asking noob questions...) | 12:15 |
NobodyCam | geertj: taake a look at something like the ssh driver. https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ssh.py#L41-L48 | 12:16 |
geertj | OK that is simple.. (*blush*) | 12:17 |
NobodyCam | :) | 12:18 |
Shrews | ugh, just tried the new gerrit change view. *vomit* | 12:18 |
*** jdob has joined #openstack-ironic | 12:20 | |
*** krtaylor has joined #openstack-ironic | 12:22 | |
*** early has quit IRC | 12:29 | |
*** dhellmann is now known as dhellmann_ | 12:31 | |
*** early has joined #openstack-ironic | 12:32 | |
*** lucas-hungry is now known as lucasagomes | 13:00 | |
*** dlfryar has joined #openstack-ironic | 13:00 | |
*** jbjohnso has joined #openstack-ironic | 13:10 | |
anteaya | hey ironic, a third party meeting is now a thing: https://wiki.openstack.org/wiki/Meetings/ThirdParty | 13:12 |
anteaya | so if you or anyone you love should be there | 13:13 |
anteaya | do share the info | 13:13 |
NobodyCam | Ty anteaya | 13:18 |
NobodyCam | and good mornignn | 13:18 |
NobodyCam | morning even | 13:18 |
*** dlfryar has quit IRC | 13:18 | |
anteaya | morning | 13:22 |
anteaya | sorry I didn't get to meet the kids | 13:22 |
anteaya | I hope you got things smoothed out? | 13:22 |
NobodyCam | ty :( ya did quite go as I planed.. :( | 13:23 |
NobodyCam | will know more later tonight / today. just about two hours out side my dads town now. | 13:23 |
NobodyCam | working on some tests :-p | 13:24 |
anteaya | k | 13:24 |
anteaya | I hope things go well | 13:24 |
anteaya | good luck | 13:24 |
anteaya | :D | 13:24 |
NobodyCam | TY.. :/ | 13:24 |
anteaya | yeah :/ | 13:24 |
*** killer_prince has quit IRC | 13:34 | |
*** romcheg has joined #openstack-ironic | 13:46 | |
*** matty_dubs|gone is now known as matty_dubs | 13:48 | |
NobodyCam | lucasagomes: can I ask you a mock question | 13:50 |
lucasagomes | NobodyCam, sure, I'm not expert in mock tho | 13:51 |
openstackgerrit | Andrey Kurilin proposed a change to openstack/ironic: Renaming ironicclient exceptions in nova driver https://review.openstack.org/90040 | 13:52 |
NobodyCam | lucasagomes: http://paste.openstack.org/show/LdvqET2tPvG7rZdbwSNp/ | 13:53 |
lucasagomes | NobodyCam, seems that there's a "seek=-35" that is being passed to the dd command | 13:54 |
lucasagomes | which is not part of the expected command list | 13:54 |
*** romcheg has quit IRC | 13:54 | |
NobodyCam | am I setting up that mock correctly? | 13:54 |
NobodyCam | humm | 13:55 |
NobodyCam | http://paste.openstack.org/show/p3E4aoe2YVn4oGiXTzBU/ | 13:55 |
lucasagomes | NobodyCam, ahh, so that function runs 2 dd's? | 13:55 |
lucasagomes | so there's a way to test it, lemme find an e.g for u | 13:56 |
NobodyCam | thats the code it should be testing | 13:56 |
jroll | morning ironic | 13:56 |
*** annegent^ has joined #openstack-ironic | 13:57 | |
NobodyCam | morning jroll | 13:57 |
lucasagomes | NobodyCam, https://github.com/openstack/ironic/blob/master/ironic/tests/drivers/test_ipmitool.py#L247-L253 | 13:57 |
jroll | NobodyCam: the tldr is you make a list of calls, like calls = [mock.call(arg1, arg2=arg2), mock.call(...)], then use mock_func.assert_has_calls(calls) | 13:58 |
jroll | or that works too | 13:58 |
lucasagomes | jroll, yeah, we use assertEqual to check for the calls | 13:58 |
jroll | ah, ok | 13:58 |
lucasagomes | jroll, but assert_has_calls seems grand as well | 13:58 |
jroll | yeah, does the same thing | 13:59 |
*** jrist has joined #openstack-ironic | 13:59 | |
NobodyCam | ahh TY | 14:00 |
jroll | NobodyCam: one more thing that is nice to know, you can use mock.ANY as an expected argument to allow any value for that arg (like for a random number or something) | 14:00 |
*** killer_prince has joined #openstack-ironic | 14:02 | |
anteaya | so when devananda is available, do you actually want a separate gerrit group for your specs repo? ironic-specs-core? https://review.openstack.org/#/c/94113/2/modules/openstack_project/files/gerrit/acls/openstack/ironic-specs.config | 14:03 |
anteaya | I just want to ensure this is what you want to have happen | 14:03 |
matty_dubs | Morning all! | 14:04 |
NobodyCam | morning matty_dubs | 14:04 |
*** rwsu has joined #openstack-ironic | 14:06 | |
*** linggao has joined #openstack-ironic | 14:06 | |
NobodyCam | brb... quick walkies | 14:07 |
geertj | Do Ironic drivers run in their own thread? Is it OK to call blocking network calls? | 14:08 |
devananda | morning, all | 14:10 |
lucasagomes | devananda, morning | 14:11 |
devananda | geertj: no. ironic-conductor is currently using greenthreads, not real threads | 14:11 |
geertj | devananda: ouch... | 14:12 |
devananda | anteaya: it seems reasonable to me to allow separate groups to review code vs. design | 14:12 |
devananda | geertj: that said, eventlet handles most network io in a non-blocking way | 14:13 |
geertj | devananda: I need to call a restful API service. I've got an wrapper that is using Python's httplib. | 14:13 |
devananda | geertj: that should be fine | 14:13 |
geertj | devananda: OK.. so eventlet is patching the stdlib? | 14:14 |
jroll | morning devananda | 14:14 |
*** lnxnut has joined #openstack-ironic | 14:14 | |
linggao | morning, ironic folks. | 14:16 |
anteaya | devananda: great, as long as this is intentional, I am good with that | 14:16 |
devananda | geertj: http://eventlet.net/doc/patching.html#monkeypatching-the-standard-library | 14:16 |
anteaya | devananda: chmouel did find an oops with the test file on that patch though, so I will wait for a new patchset | 14:17 |
geertj | devananda: kewl | 14:17 |
devananda | anteaya: ack, looking | 14:17 |
anteaya | and hello everybody | 14:17 |
anteaya | hey matty_dubs | 14:17 |
anteaya | I just love saying your username | 14:17 |
matty_dubs | Howdy anteaya | 14:17 |
matty_dubs | Haha | 14:17 |
anteaya | :D | 14:18 |
lucasagomes | morning linggao matty_dubs | 14:19 |
lucasagomes | anteaya, and geertj as well :) | 14:19 |
matty_dubs | Heya lucasagomes | 14:19 |
anteaya | hey lucasagomes | 14:19 |
geertj | morning lucasgomes :) | 14:19 |
linggao | morning devananda, lucasagomes, matty_dubs, NobodyCam | 14:20 |
matty_dubs | Hi linggao! | 14:20 |
matty_dubs | So, as a Rubyist reluctantly working in Python, I got a big chuckle out of seeing this book at one of the bookstores in the Atlanta airport: http://www.amazon.com/The-Spirit-Python-Exposing-Squeeze/dp/1621362205 | 14:21 |
NobodyCam | mornig linggao devananda | 14:21 |
linggao | NobodyCam, are you still on the road? | 14:22 |
lucasagomes | matty_dubs, lol hah | 14:23 |
lucasagomes | matty_dubs, did you buy it? | 14:24 |
jroll | matty_dubs: lolol | 14:24 |
linggao | matty_dubs, lol. | 14:25 |
NobodyCam | linggao: yes I am in Kansas City .. about two hours out from where my dad lives | 14:26 |
linggao | NobodyCam, cool! enjoy! | 14:26 |
*** lazy_prince3 has joined #openstack-ironic | 14:30 | |
*** lazy_prince3 is now known as lazy_prince | 14:31 | |
devananda | hmmm well, we're skipping our meetnig today, BUT anteaya is hosting the inaugural third-party-CI meeting today | 14:44 |
devananda | so if anyone is around and can attend, that'd be great -- details here -- https://wiki.openstack.org/wiki/Meetings/ThirdParty | 14:44 |
anteaya | thanks devananda | 14:45 |
anteaya | all welcome | 14:45 |
*** lnxnut is now known as hipster | 14:45 | |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Workaround for conflicting volume labels https://review.openstack.org/93133 | 14:49 |
NobodyCam | any one want to take a look at ^^^ | 14:49 |
NobodyCam | lucasagomes: can you look at the test and let me know how you think they look | 14:49 |
NobodyCam | bbt...brb | 14:51 |
*** jgrimm has joined #openstack-ironic | 14:51 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Speed up Nova Ironic driver tests https://review.openstack.org/94202 | 14:51 |
lucasagomes | NobodyCam, sure, will do | 14:51 |
NobodyCam | :) TY | 14:52 |
*** blamar has joined #openstack-ironic | 15:07 | |
NobodyCam | brb | 15:07 |
*** hipster has quit IRC | 15:08 | |
pelix | trying to get ironic running via devstack by following http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack | 15:22 |
pelix | running into a brick wall around getting the baremetal nodes created to come up | 15:22 |
pelix | seems no IP address is available for them from DHCP provided by neutron/dnsmasq when booting | 15:22 |
pelix | any suggestions on where to look to see what's going wrong? | 15:23 |
NobodyCam | pelix: is there a firewall running? | 15:25 |
pelix | NobodyCam: no, the dnsmasq program sees the request but logs "dnsmasq-dhcp[16004]: DHCPDISCOVER(tapde587ec3-65) 52:54:00:01:f9:25 no address available" to syslog and doesn't respond | 15:28 |
pelix | adding an IP address manually to the hosts file and issuing a SIGHUP to the process 16004 and resetting the domain allows the ipaddress to be assigned, but then it reports no file found (I'm guessing as in no pxelinux.0 file found) | 15:29 |
pelix | so it seems like something earlier hasn't done the expected set up both for neutron to provide the address and for the tftpboot area to be properly available | 15:29 |
*** mkerrin has joined #openstack-ironic | 15:30 | |
pelix | btw, although ufw reports as inactive, there is some output from 'iptables -L' | 15:31 |
pelix | but since it isn't blocking the DHCP request or response I'm assuming whatever being done regarding firewall conf, is working as expected (tftp port is open as well). | 15:32 |
NobodyCam | humm | 15:34 |
lucasagomes | NobodyCam, reviewed | 15:34 |
pelix | NobodyCam: has anything changed that renders the conf listed in the docs as obsolete? | 15:35 |
NobodyCam | lucasagomes: TY | 15:37 |
*** igor_ has joined #openstack-ironic | 15:37 | |
lucasagomes | NobodyCam, np | 15:37 |
lucasagomes | left some inline comments | 15:38 |
NobodyCam | pelix: not that I know of | 15:38 |
NobodyCam | yep will address now | 15:38 |
*** dlfryar has joined #openstack-ironic | 15:39 | |
devananda | in case folks didn't see the mail yet, i've started working on our specs repo | 15:42 |
devananda | for the moment, it's on my github (pending infra adding it to openstack) | 15:42 |
devananda | https://github.com/devananda/ironic-specs/blob/master/specs/template.rst | 15:42 |
*** Mikhail_D_ltp has joined #openstack-ironic | 15:44 | |
*** matty_dubs is now known as matty_dubs|lunch | 15:46 | |
lucasagomes | devananda, the template looks good... one thing | 15:47 |
lucasagomes | devananda, in the performance impact section you say that periodic tasks runs in a single greenthread etc... this is true for now, but it's going to be fixed no? I remember you mentioning that there is some ongoing work on nova to fix that am I correct? | 15:48 |
lucasagomes | (just thinking if it worth to be mentioned in the template if it's going to be fixed soonish) | 15:49 |
devananda | lucasagomes: we can always change the template when it gets fixed | 15:50 |
lucasagomes | devananda, sure, ack... good stuff! | 15:51 |
lucasagomes | the template lgtm | 15:51 |
*** hemnafk is now known as hemna | 15:54 | |
devananda | lucasagomes: also https://github.com/devananda/ironic-specs/blob/master/specs/juno/fully-async-api.rst | 15:57 |
*** eghobo has joined #openstack-ironic | 15:58 | |
*** datajerk has joined #openstack-ironic | 15:58 | |
lucasagomes | devananda, nice will read in a sec | 15:58 |
devananda | jroll: ping | 16:01 |
lucasagomes | devananda, I was thinking about creating the concepting of task for those async calls... e.g | 16:02 |
lucasagomes | PUT (or POST even) {'enabled': 'true'} /v1/nodes/<uuid>states/console, HTTP CODE: 202, LOCATION /v1/nodes/<uuid>states/console/a66h12 | 16:03 |
lucasagomes | this way, the task is traceable via /v1/nodes/<uuid>states/console/a66h12 | 16:03 |
lucasagomes | so use can issue a GET on that URI to get the status of it | 16:03 |
lucasagomes | (didn't think much about it) just an initial idea | 16:04 |
devananda | lucasagomes: that leads to constant polling by clients, not very scalable | 16:06 |
lucasagomes | devananda, yeah :/ as-is today's | 16:06 |
lucasagomes | devananda, maybe a callback mechanism would be better | 16:06 |
devananda | lucasagomes: and managing those resources end-of-life as well | 16:06 |
devananda | we talked in the nova track about cross service callback mechanisms | 16:07 |
devananda | nova<->neutron already does this a little bit | 16:07 |
devananda | at some point, we'll want to be able to call back to nova to say "this request is done" rather than have nova continuously poll status | 16:07 |
lucasagomes | devananda, neat... yeah, I was just thinking because that would offer some flexibility when managing specific tasks, like being able to issue DELETE to abort a giving task etc | 16:07 |
lucasagomes | yeah the callback seems pretty good and scalable | 16:08 |
devananda | it's good for inter-service communication. not so much with HTTP clients | 16:08 |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Workaround for conflicting volume labels https://review.openstack.org/93133 | 16:09 |
devananda | how would a CLI user receive a callback when they are, say, behind a NAT firewall? | 16:09 |
NobodyCam | lucasagomes: ^^^ :) | 16:09 |
devananda | lucasagomes: here's another idea | 16:10 |
lucasagomes | NobodyCam, will take a look in a bit, finishing something up quickly | 16:10 |
devananda | * allow API service to lock nodes, as part of precondition checking | 16:11 |
devananda | * API updates "target_*" states when requested to do something (eg, start a deploy) | 16:11 |
devananda | * API then "cast"s a notice to the conductor, and responds with 202 to user | 16:11 |
devananda | there's no synchronous RPC call at all, but the user knows the action can start | 16:11 |
NobodyCam | :) | 16:12 |
devananda | if API is unable to lock the node w/in some timeout (less than HTTP timeout), user gets a timeout error | 16:12 |
devananda | and if API gets a lock but the state check fails, user gets a notice as to why their request couldn't be performed | 16:12 |
devananda | this needs no change in the REST API usage or error codes, I think... | 16:13 |
devananda | actually, one positive change - clients won't need to retry for NodeLocked errors any more | 16:15 |
devananda | russell_h: ping | 16:15 |
lucasagomes | devananda, should the API service do the locking? it would require moving the task manager to a common place | 16:15 |
russell_h | devananda: hey | 16:15 |
devananda | lucasagomes: yes | 16:15 |
lucasagomes | I mean, it could be done via RPC as well | 16:15 |
devananda | russell_h: hey there. see my mail to the list re: specs repo? | 16:15 |
NobodyCam | ok last of the road trips (at least for a while). Kansas city to Omaha | 16:15 |
russell_h | so locks get passed via RPC? | 16:15 |
devananda | lucasagomes: doign that over RPC leads t othe problem we have today | 16:16 |
devananda | russell_h: I was pinging you re: specs, not this conversation -- we're multitasking :) | 16:16 |
russell_h | heh, yeah, sorry I was just catching up on this conversation | 16:16 |
*** jistr has quit IRC | 16:16 | |
russell_h | I was experimenting with refactoring locking yesterday | 16:16 |
russell_h | so I'm interested | 16:16 |
russell_h | anyway | 16:16 |
devananda | russell_h: pending infra adding it to openstack/irinic-specs, I've got draft up here https://github.com/devananda/ironic-specs/blob/master/specs/template.rst | 16:17 |
russell_h | re: specs, didn't read the email yet | 16:17 |
lucasagomes | yeah, hmm def the idea worth a go | 16:17 |
russell_h | but I love the idea if its what I think it is | 16:17 |
devananda | russell_h: i'm soliciting input on whether the template covers all the things. And suggesting that ya'll start spec'ing the things that need to be spec'd | 16:17 |
*** hipster has joined #openstack-ironic | 16:18 | |
devananda | russell_h: in particular, the refactoring for instance_info and pulling out common methods for image and dhcp manipulation | 16:18 |
devananda | russell_h: as those will need to land before the IPA driver anyway | 16:18 |
russell_h | seems reasonable | 16:18 |
russell_h | alright, I'll take a look at the template in an hour or so | 16:19 |
devananda | russell_h: thanks much | 16:19 |
russell_h | and put the team on getting specs up over the next few days | 16:19 |
*** geertj has quit IRC | 16:21 | |
lucasagomes | btw, the tests we currently have on devstack it doesn't issue any nova boot right? | 16:22 |
lucasagomes | devananda, ^ | 16:22 |
lucasagomes | NobodyCam, ^, would the check-tripleo-ironic-undercloud-precise do that? | 16:23 |
devananda | lucasagomes: ironic-virtual test does a full deploy and SSH into the instane | 16:26 |
devananda | we should make that voting soon, IMO | 16:26 |
*** newell_ has joined #openstack-ironic | 16:26 | |
lucasagomes | devananda, hmm I thought it did as well but idk now, because I was reviewing the refactoring patch (https://review.openstack.org/90233) | 16:27 |
lucasagomes | and it's broken because it's not generating the pxe config files (the function is not being called) | 16:28 |
lucasagomes | but the tests passed | 16:28 |
russell_h | devananda: lucasagomes: I was experimenting some with making locking pluggable yesterday: https://gist.github.com/russellhaering/5035399c523cacbca604 | 16:30 |
devananda | lucasagomes: no they didn't -- look at http://logs.openstack.org/33/90233/34/check/check-tempest-dsvm-virtual-ironic/fe0a140 | 16:30 |
devananda | lucasagomes: that's exactly why it should be made voting :) | 16:30 |
lucasagomes | devananda, ah damn! I was looking at the tripleo ones | 16:31 |
lucasagomes | devananda, +1 for making it voting! _much_ needed | 16:31 |
lucasagomes | russell_h, will take a look | 16:32 |
russell_h | lucasagomes: it may not be quite what we want if we're planning to rework how locking works, but my goal was basically to make it to where I could plug in zookeeper for locking | 16:33 |
russell_h | and eventually for conductor registration as well | 16:33 |
lucasagomes | russell_h, I see, it might worth to spend some time on the meeting (or even here on IRC) to think about hw the locks and new api model should work and build the specs for it | 16:35 |
lucasagomes | would be good to refactor that out asap like j1 or start of j2 to get it all in trunk | 16:35 |
russell_h | yes | 16:35 |
lucasagomes | on IRC I mean this channel | 16:36 |
russell_h | yeah, I figured | 16:36 |
russell_h | thats actually better for me | 16:36 |
russell_h | I'm triple-booked during the weekly meeting | 16:36 |
russell_h | every week | 16:36 |
russell_h | its great | 16:36 |
lucasagomes | oh I c, it works for me here as well | 16:36 |
JoshNang | i thought there wasn't a meeting this week anyway? | 16:36 |
lucasagomes | JoshNang, there's not | 16:36 |
lucasagomes | but we could add it to the agenda for the next if that's the case | 16:37 |
JoshNang | +1 | 16:37 |
lucasagomes | and put some initial thoughts somewhere where people can read before attending to it | 16:37 |
russell_h | I'd rather put more rigor into it before the meeting | 16:38 |
russell_h | so we're basically proposing a detailed plan | 16:38 |
russell_h | but, I just don't like meetings | 16:38 |
russell_h | so either way :) | 16:38 |
lucasagomes | heh, russell_h it's odd for me to hear a manager saying he/she doesn't like meetings :) | 16:39 |
lucasagomes | I agree | 16:39 |
lucasagomes | although the ironic one, 1 hour per week is being beneficial | 16:39 |
russell_h | yeah, I usually end up just reading the backlog, but it seems decent | 16:40 |
devananda | russell_h: we can move the meeting - you're not the only one for whom its not a good time. | 16:42 |
devananda | russell_h: though the openstack meeting calendar is preciously full already... | 16:44 |
jroll | devananda: pong | 16:44 |
*** foexle has quit IRC | 16:45 | |
devananda | jroll: hi! was just pinging you re: the specs repo, same as I pinged russell_h. see ML or scrollback | 16:45 |
devananda | russell_h: re: pluggable lock model -- yes please | 16:45 |
*** igor_ has quit IRC | 16:45 | |
devananda | russell_h: as far as plan vs. irc discussion, that's what the specs repo is for :) | 16:45 |
jroll | devananda: reading scrollback now :) | 16:45 |
*** igor_ has joined #openstack-ironic | 16:45 | |
devananda | then we discuss on the spec review rather than during the already-crammed weekly meeting | 16:46 |
russell_h | +1million | 16:46 |
lucasagomes | there's only one openstack-meeting channel? | 16:46 |
russell_h | I basically ran into the question of how to implement "blocking for a lock", given that we must do that inline in the API call | 16:46 |
devananda | there's two now | 16:46 |
lucasagomes | wouldn't be better to create more maybe? so time would be more flexible for projects | 16:46 |
lucasagomes | I see | 16:46 |
devananda | maybe three, heh | 16:46 |
jroll | devananda: your email said 'I will focus on creating and landing the specs for items essential for graduation first...' - I'm assuming you're not creating *all* of the specs, just the ones you're responsible for or something. like, I'll create the agent specs etc | 16:46 |
lucasagomes | I see, yeah that would be useful | 16:46 |
devananda | yep, there's 3, heh | 16:47 |
devananda | jroll: agent isn't req'd for graduation | 16:47 |
devananda | jroll: but i'm happy if others create the specs for the things that are req'd if they want to | 16:47 |
jroll | devananda: oh, wow, I totally read that as 'critical for juno' | 16:48 |
* jroll chugs coffee | 16:48 | |
russell_h | I see two options: a) block only for a short period of time, then error out, or b) add a task-tracking API so we can accept API calls, then actually execute the associated task when the node frees up | 16:48 |
devananda | russell_h: a++ | 16:48 |
*** harlowja has joined #openstack-ironic | 16:48 | |
devananda | b-- | 16:48 |
russell_h | devananda: do we actually need to do the locking in the API? Is it OK to still do it in the conductor, just with a timeout known to be much shorter than the API timeout? | 16:49 |
devananda | russell_h: get lock; validate pre-state; set target-state in db; unlock; cast to conductor; return 202 | 16:49 |
devananda | well | 16:50 |
devananda | i'm still being too pessimistic with locking for that to scale well | 16:50 |
russell_h | if the validation happens in the API, every API will need to load every driver | 16:50 |
*** igor_ has quit IRC | 16:50 | |
russell_h | in real life thats probably fine | 16:50 |
russell_h | but a little different from today's model | 16:50 |
devananda | hm. that's not the validation i'm referring to | 16:51 |
devananda | so let's think about how this could be done with no lock in the API | 16:51 |
russell_h | oh, you just mean the stuff thats already in the API | 16:51 |
*** matty_dubs|lunch is now known as matty_dubs | 16:51 | |
*** martyntaylor has joined #openstack-ironic | 16:51 | |
russell_h | common validation of node state and so on | 16:51 |
lucasagomes | devananda, between the unlock and the cast some periodic task could then take the lock from the conductor | 16:51 |
devananda | right | 16:51 |
lucasagomes | and then we would have a dirty target_state and no conductor working on it | 16:52 |
russell_h | so if we moved that out of the API, and into the conductor | 16:52 |
russell_h | to happen _after_ the lock is achieved | 16:52 |
devananda | lucasagomes: yep. so periodic tasks would need to skip that node during that interval | 16:52 |
*** derekh_ has quit IRC | 16:52 | |
lucasagomes | devananda, would be better to keep the lock? | 16:52 |
devananda | we need an intent-lock anyhow | 16:52 |
jroll | I want to point out that validation on node state sometimes needs to happen in the driver | 16:52 |
devananda | also for the external scheduler bits we discussed | 16:52 |
jroll | e.g. power_state validation for do_node_deploy | 16:52 |
lucasagomes | devananda, and use a call with a greenthread to guaratee that the conductor got the task? | 16:52 |
lucasagomes | yeah that's an intent lock | 16:53 |
lucasagomes | jroll, I think that the validation devananda is referering to is just checking the current db value, not issuing any driver-specific commands | 16:54 |
russell_h | devananda: you could also _not_ unlock in the API, and actually "hand off" the lock to the conductor | 16:54 |
russell_h | there are... risks | 16:55 |
lucasagomes | russell_h, yeah, that's the intent lock | 16:55 |
lucasagomes | I agree with it | 16:55 |
devananda | extrapolating all this out, we're talking about a distributed state machine. FSMs are a blight on existence. DFSMs are unspeakable. | 16:55 |
russell_h | heh | 16:55 |
jroll | lucasagomes: you might be right, but that's an example of something stored in the db that validation is performed on | 16:55 |
devananda | do we actually need one, or just /think/ we do? | 16:55 |
russell_h | well | 16:55 |
russell_h | there is another option | 16:56 |
russell_h | a conductor could lock every node it thinks it owns, just up front | 16:56 |
russell_h | then schedule work against that node in-process | 16:56 |
russell_h | if the conductor manages all state, its not distributed | 16:56 |
russell_h | excepting between the conductor and the db | 16:56 |
russell_h | (well, and the BMC and...) | 16:57 |
devananda | api service then casts "a request to do something" | 16:57 |
devananda | and the conductor may choose to ignore it if it's unservicable (like "deploy node X" when node X is already deployed) | 16:57 |
russell_h | something like that, yes | 16:58 |
devananda | it resolves all the locking and race conditions cleanly. however the user experience will be more like "hey, where'd my request go" | 16:58 |
russell_h | so, you don't have to rely on cast | 16:58 |
devananda | unless there's some state checking in the API | 16:58 |
devananda | even if that's async, non-locked, and possibly stale | 16:59 |
devananda | it's probably good enough | 16:59 |
russell_h | you can have the conductor either respond "yes, will do", or "no, not possible" | 16:59 |
*** martyntaylor has left #openstack-ironic | 16:59 | |
russell_h | basically what happens today | 16:59 |
devananda | russell_h: which is what i'm proposing to avoid | 16:59 |
russell_h | except that everything is in-memory in a single conductor | 16:59 |
russell_h | right | 17:00 |
devananda | anyhow | 17:00 |
devananda | i'd rather we discuss all this in a review on the specs repo, once it's created | 17:00 |
*** killer_prince has quit IRC | 17:00 | |
russell_h | agreed | 17:00 |
devananda | so there's a trail for future reference (aside from irc logs) | 17:00 |
lucasagomes | +1 | 17:01 |
jroll | devananda: can you ping me when the specs repo exists, and I'll get those agent specs going? | 17:10 |
lucasagomes | alright, it's dinner time for me | 17:13 |
lucasagomes | have a good night everyone! | 17:14 |
matty_dubs | Adios, lucasagomes! | 17:14 |
*** lucasagomes is now known as lucas-hungry | 17:14 | |
jroll | \o | 17:15 |
*** igor_ has joined #openstack-ironic | 17:16 | |
*** igor_ has quit IRC | 17:21 | |
*** athomas has quit IRC | 17:35 | |
*** killer_p- has joined #openstack-ironic | 17:39 | |
*** killer_p- is now known as killer_prince | 17:40 | |
*** lazy_prince has quit IRC | 17:40 | |
*** geertj has joined #openstack-ironic | 17:41 | |
devananda | jroll: you can start from what i've got here: https://github.com/devananda/ironic-specs/blob/master/specs/template.rst | 17:46 |
openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Adding a reference driver for the agent https://review.openstack.org/84795 | 17:46 |
devananda | jroll: i'll notify the ML when the repo gets moved to openstack/ | 17:46 |
jroll | devananda: cool, that was my plan. thanks | 17:46 |
*** harlowja has quit IRC | 17:50 | |
*** harlowja has joined #openstack-ironic | 17:50 | |
*** harlowja has quit IRC | 18:00 | |
*** harlowja has joined #openstack-ironic | 18:00 | |
*** datajerk has quit IRC | 18:00 | |
*** geertj has quit IRC | 18:08 | |
*** datajerk has joined #openstack-ironic | 18:12 | |
*** hipster has quit IRC | 18:15 | |
*** igor_ has joined #openstack-ironic | 18:16 | |
*** datajerk has quit IRC | 18:17 | |
*** igor_ has quit IRC | 18:21 | |
*** eghobo has quit IRC | 18:29 | |
*** datajerk has joined #openstack-ironic | 18:34 | |
*** pelix has quit IRC | 18:34 | |
*** tatyana has joined #openstack-ironic | 18:37 | |
openstackgerrit | David Shrewsbury proposed a change to openstack/ironic: Update dev quickstart guide for ephemeral testing https://review.openstack.org/92105 | 18:39 |
*** datajerk has quit IRC | 18:41 | |
*** lazy_prince has joined #openstack-ironic | 18:42 | |
*** hipster has joined #openstack-ironic | 18:47 | |
*** hipster has quit IRC | 18:51 | |
*** eghobo has joined #openstack-ironic | 18:59 | |
*** geertj has joined #openstack-ironic | 19:00 | |
*** igor_ has joined #openstack-ironic | 19:17 | |
*** hipster has joined #openstack-ironic | 19:18 | |
*** igor_ has quit IRC | 19:22 | |
*** hipster has quit IRC | 19:23 | |
*** dlfryar has quit IRC | 19:29 | |
matty_dubs | So, dumb question time. I see 'dsvm' in a lot of the tests. What does that stand for? | 19:35 |
matty_dubs | Google is completely unhelpful and keeps showing the DSM 5 when I try to search, which isn't helping. | 19:35 |
*** eguz has joined #openstack-ironic | 19:37 | |
*** eghobo has quit IRC | 19:41 | |
*** lazy_prince has quit IRC | 19:46 | |
*** hipster has joined #openstack-ironic | 19:47 | |
Shrews | devstack vm? | 19:49 |
Shrews | where do you see it? | 19:49 |
*** epim has joined #openstack-ironic | 19:49 | |
*** epim is now known as Penick | 19:50 | |
matty_dubs | Just in test names, like check-tempest-dsvm-ironic | 19:51 |
matty_dubs | 'devstack vm' makes perfect sense | 19:51 |
matty_dubs | But somehow never occurred to me | 19:51 |
*** hipster has quit IRC | 19:52 | |
*** greghaynes has quit IRC | 19:53 | |
Shrews | we don't have nearly enough acronyms | 19:53 |
*** christopheraedo has quit IRC | 19:54 | |
*** zul has quit IRC | 19:54 | |
*** ewindisch has quit IRC | 19:54 | |
*** soren has quit IRC | 19:54 | |
*** jrist has quit IRC | 19:55 | |
*** tteggel has quit IRC | 19:55 | |
*** tteggel has joined #openstack-ironic | 19:55 | |
*** christopheraedo has joined #openstack-ironic | 19:55 | |
*** soren has joined #openstack-ironic | 19:56 | |
*** geertj has quit IRC | 19:56 | |
*** zul has joined #openstack-ironic | 19:58 | |
*** harlowja has quit IRC | 20:01 | |
*** tatyana has quit IRC | 20:02 | |
*** harlowja has joined #openstack-ironic | 20:02 | |
*** foexle has joined #openstack-ironic | 20:03 | |
*** jrist has joined #openstack-ironic | 20:06 | |
*** tatyana has joined #openstack-ironic | 20:07 | |
*** greghaynes has joined #openstack-ironic | 20:09 | |
*** ewindisch has joined #openstack-ironic | 20:16 | |
*** igor_ has joined #openstack-ironic | 20:18 | |
*** tatyana has quit IRC | 20:21 | |
*** dlfryar has joined #openstack-ironic | 20:22 | |
*** igor_ has quit IRC | 20:23 | |
*** foexle has quit IRC | 20:29 | |
*** Mikhail_D_ltp has quit IRC | 20:33 | |
*** lazy_prince has joined #openstack-ironic | 20:34 | |
*** Hefeweizen has joined #openstack-ironic | 20:35 | |
*** hipster has joined #openstack-ironic | 20:47 | |
*** linggao has quit IRC | 20:48 | |
*** hipster has quit IRC | 20:52 | |
Shrews | umm, the check-tripleo-ironic-* tests are coming back NOT_REGISTERED. is that new or have i been totally unobservant? | 20:54 |
*** jdob has quit IRC | 20:59 | |
*** gmatefi has joined #openstack-ironic | 20:59 | |
*** jbjohnso has quit IRC | 21:08 | |
devananda | Shrews: i think infra changed something in how things report recently | 21:09 |
devananda | also, it looks like dsvm-virtual-ironic has may be failing all the time now?? | 21:10 |
adam_g | hmm | 21:11 |
adam_g | http://no-carrier.net/~adam/openstack/ironic_gate_status.html | 21:11 |
devananda | adam_g: hm, ok. not all the time - just the ones I randomly looked at | 21:13 |
* devananda bookmarks that | 21:13 | |
devananda | adam_g: any thoughts on how to determine what % of those are false negatives? | 21:14 |
adam_g | devananda, hmm. looks like the tempest run is passing, but some logs have non-whitelisted errors in them | 21:16 |
adam_g | ie https://jenkins05.openstack.org/job/check-tempest-dsvm-virtual-ironic-nv/369/console | 21:16 |
devananda | I see. both of those are expected. | 21:18 |
devananda | *should be | 21:18 |
devananda | and should be present in every run | 21:18 |
adam_g | devananda, the mac addr errors? | 21:18 |
*** igor_ has joined #openstack-ironic | 21:19 | |
devananda | yep | 21:21 |
devananda | those come from a tempest test | 21:21 |
devananda | though, i had a patch up to suppress logging them | 21:22 |
*** igor_ has quit IRC | 21:23 | |
*** matty_dubs is now known as matty_dubs|gone | 21:27 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Implement the Conductor side of ring rebalancing https://review.openstack.org/79194 | 21:30 |
*** Penick has quit IRC | 21:31 | |
devananda | mrda-summit: found some old code I was working on for the hash ring -- https://review.openstack.org/#/c/79194/ -- this may give you a starting point. or may be totally wrong and should be re-buried | 21:31 |
*** harlowja has quit IRC | 21:32 | |
openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Don't update neutron VIF if MAC is duplicated https://review.openstack.org/90436 | 21:33 |
devananda | adam_g: yea, this patch should hide the MACAlreadyExists error -- https://review.openstack.org/#/c/90436/ but the patch may need a bit more work | 21:33 |
*** harlowja has joined #openstack-ironic | 21:33 | |
adam_g | devananda, cool. i dont see how all runs are not failing on that error, since it should be logged everytime the negative test runs? | 21:34 |
devananda | right | 21:35 |
devananda | i dont understand that yet either | 21:35 |
adam_g | AFAICS the ironic logs errors are failing the test, not any of the others that appear not to be whitelisted | 21:35 |
*** hipster has joined #openstack-ironic | 21:47 | |
*** lazy_prince has quit IRC | 21:48 | |
NobodyCam | Hello from Greenwood Ne | 21:50 |
devananda | NobodyCam: o/ | 21:51 |
*** hipster has quit IRC | 21:52 | |
NobodyCam | \o devananda | 21:52 |
NobodyCam | devananda:(and all others) have a minute to look at https://review.openstack.org/#/c/93133 | 21:54 |
*** igor_ has joined #openstack-ironic | 21:58 | |
*** igor_ has quit IRC | 22:03 | |
*** foexle has joined #openstack-ironic | 22:10 | |
NobodyCam | ty devananda will get a new patch up in a bit to address the comments/ conserns :) | 22:11 |
*** radsy has joined #openstack-ironic | 22:31 | |
*** jgrimm has quit IRC | 22:38 | |
*** gmatefi has quit IRC | 22:38 | |
*** hipster has joined #openstack-ironic | 22:42 | |
*** hipster_ has joined #openstack-ironic | 22:44 | |
*** hipster has quit IRC | 22:47 | |
*** hipster has joined #openstack-ironic | 22:47 | |
*** hipster_ has quit IRC | 22:49 | |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Workaround for conflicting volume labels https://review.openstack.org/93133 | 22:49 |
*** r-daneel has joined #openstack-ironic | 22:50 | |
NobodyCam | devananda: see if that addresses the conserns... maybe to hackish | 22:50 |
*** hipster has quit IRC | 22:52 | |
*** overlayer has quit IRC | 22:57 | |
*** igor_ has joined #openstack-ironic | 22:59 | |
*** r-daneel has quit IRC | 23:03 | |
*** igor_ has quit IRC | 23:03 | |
*** r-daneel has joined #openstack-ironic | 23:04 | |
*** r-daneel has quit IRC | 23:07 | |
*** datajerk has joined #openstack-ironic | 23:17 | |
*** datajerk has quit IRC | 23:22 | |
*** datajerk has joined #openstack-ironic | 23:23 | |
*** lucas-hungry has quit IRC | 23:24 | |
*** matsuhashi has joined #openstack-ironic | 23:27 | |
*** datajerk has quit IRC | 23:28 | |
*** romcheg has joined #openstack-ironic | 23:38 | |
*** romcheg1 has joined #openstack-ironic | 23:40 | |
*** romcheg has quit IRC | 23:42 | |
jroll | devananda: this landed a while ago, can we kill the blueprint somehow? https://blueprints.launchpad.net/ironic/+spec/add-node-instance-info | 23:44 |
jroll | devananda: also, do you want a spec for moving things driver_info -> instance_info? instinct says yes | 23:44 |
*** dlfryar has quit IRC | 23:45 | |
*** hipster has joined #openstack-ironic | 23:47 | |
*** hemna is now known as hemna_ | 23:49 | |
*** hipster has quit IRC | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!