Wednesday, 2014-07-02

* NobodyCam loves that his irc host's time zone is set so that at 5 pm he gets Day changed to 02 Jul 201400:01
jrollheh00:04
NobodyCamwhat the day doesn't start at 5:00pm00:04
NobodyCam:-p00:04
*** chuckC has quit IRC00:07
* NobodyCam calls it a : ψ ︿_____︿_ψ_ ☼ 00:08
* devananda packs up for dinner, bbl00:11
*** Penick has quit IRC00:13
NobodyCamnight devananda00:14
mrdaNight Deva00:22
*** hemna has quit IRC00:24
*** ccrouch has joined #openstack-ironic00:50
openstackgerritDan Prince proposed a change to openstack/ironic: Port iBoot PDU driver from Nova  https://review.openstack.org/5097700:52
*** Sam_S has joined #openstack-ironic00:54
*** mitz_ has joined #openstack-ironic01:11
openstackgerritDan Prince proposed a change to openstack/ironic: Port iBoot PDU driver from Nova  https://review.openstack.org/5097701:18
*** nosnos has joined #openstack-ironic01:49
*** nosnos has quit IRC01:55
*** nosnos has joined #openstack-ironic01:55
*** hemna has joined #openstack-ironic01:56
*** max_lobur has quit IRC01:59
*** chuckC has joined #openstack-ironic02:44
*** harlowja is now known as harlowja_away02:50
*** ajc_ has joined #openstack-ironic02:50
*** killer_prince is now known as lazy_prince02:59
*** lazy_prince is now known as killer_prince03:00
*** hemna has quit IRC03:11
*** nosnos has quit IRC03:27
*** sabah has joined #openstack-ironic03:46
*** coolsvap|afk is now known as coolsvap03:53
*** sabah has quit IRC03:53
*** Poornima has joined #openstack-ironic03:59
*** pcrews has quit IRC04:02
*** rakesh_hs has joined #openstack-ironic04:05
*** rakesh_hs has quit IRC04:16
*** rakesh_hs has joined #openstack-ironic04:17
*** lazy_prince has joined #openstack-ironic04:25
*** bvivek has joined #openstack-ironic04:36
*** rakesh_hs2 has joined #openstack-ironic04:36
*** rakesh_hs has quit IRC04:36
*** nosnos has joined #openstack-ironic04:42
*** k4n0 has joined #openstack-ironic04:42
*** lazy_prince has quit IRC04:46
*** killer_prince is now known as lazy_prince04:47
*** geekyogi has joined #openstack-ironic04:52
*** geekyogi has quit IRC05:05
*** Nisha has joined #openstack-ironic05:06
*** kpavel has quit IRC05:07
*** amitpp has joined #openstack-ironic05:21
adam_gShrews, https://review.openstack.org/104069 you might be interested in this, it overlaps a bunch with your rebuild scenario test.05:22
*** rwsu has quit IRC05:24
*** pradipta_away is now known as pradipta05:30
*** eghobo has joined #openstack-ironic05:30
*** romcheg has joined #openstack-ironic05:31
*** sabah has joined #openstack-ironic05:32
*** amitpp has quit IRC05:35
*** amitpp has joined #openstack-ironic05:40
*** pradipta is now known as pradipta_away05:47
*** pradipta_away is now known as pradipta05:47
*** pradipta is now known as pradipta_away05:50
*** bvivek has quit IRC05:53
*** eguz has joined #openstack-ironic05:53
*** bvivek has joined #openstack-ironic05:56
*** eghobo has quit IRC05:57
*** geekyogi has joined #openstack-ironic06:01
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex  https://review.openstack.org/10329106:02
*** Mikhail_D_ltp has joined #openstack-ironic06:09
*** Haomeng has joined #openstack-ironic06:12
*** bvivek2 has joined #openstack-ironic06:25
*** bvivek has quit IRC06:25
*** radsy has quit IRC06:34
*** max_lobur has joined #openstack-ironic06:45
*** mitz_ has quit IRC06:48
*** ramineni has joined #openstack-ironic06:49
*** mitz_ has joined #openstack-ironic06:50
*** eguz has quit IRC06:55
GheRivero_afkmorning all06:56
*** GheRivero_afk is now known as GheRivero06:56
*** pcrews has joined #openstack-ironic07:01
*** foexle has joined #openstack-ironic07:04
*** wanyen has quit IRC07:06
*** romcheg has quit IRC07:09
*** geekyogi has quit IRC07:10
mrdaNight all, see you tomorrow07:11
*** mrda is now known as mrda_away07:11
*** pradipta_away is now known as pradipta07:11
*** bvivek2 has quit IRC07:14
*** pcrews has quit IRC07:17
*** foexle has quit IRC07:20
*** bvivek has joined #openstack-ironic07:28
openstackgerritNisha Agarwal proposed a change to openstack/ironic-specs: Discover node properties for iLO driver  https://review.openstack.org/10300707:33
*** romcheg has joined #openstack-ironic07:34
*** jcoufal has joined #openstack-ironic07:38
*** geekyogi has joined #openstack-ironic07:41
*** mkerrin has joined #openstack-ironic07:45
*** geekyogi has quit IRC07:50
* devananda reviews all the specs07:50
* devananda reviews ^Das many specs as he can before falling asleep07:51
*** ifarkas has joined #openstack-ironic07:51
*** lucasagomes has joined #openstack-ironic07:51
*** athomas has joined #openstack-ironic07:53
*** geekyogi has joined #openstack-ironic07:55
*** lsmola__ has joined #openstack-ironic07:56
*** max_lobur has quit IRC08:00
*** ndipanov has joined #openstack-ironic08:02
*** foexle has joined #openstack-ironic08:07
*** loki184 has joined #openstack-ironic08:11
*** amitpp has quit IRC08:14
*** amitpp has joined #openstack-ironic08:14
*** rakesh_hs2 has quit IRC08:19
*** rakesh_hs has joined #openstack-ironic08:22
*** bvivek has quit IRC08:22
openstackgerritA change was merged to openstack/ironic-specs: Update pbr version  https://review.openstack.org/10333408:31
openstackgerritA change was merged to openstack/ironic: PEP fixes for the Nova driver  https://review.openstack.org/10316208:32
openstackgerritA change was merged to openstack/ironic: pep8 cleanup of Nova code  https://review.openstack.org/10300108:32
openstackgerritA change was merged to openstack/ironic: Fix the section name in CONTRIBUTING.rst  https://review.openstack.org/10318908:32
*** derekh_ has joined #openstack-ironic08:41
*** bvivek has joined #openstack-ironic08:41
*** jcoufal has quit IRC08:48
*** pelix has joined #openstack-ironic08:56
openstackgerritImre Farkas proposed a change to openstack/ironic-specs: DRAC power driver  https://review.openstack.org/9935209:14
*** romcheg has quit IRC09:21
*** romcheg has joined #openstack-ironic09:24
romchegMorning Ironic09:24
romchegIt looks like I won't be able to come to our mid-cycle meet up09:25
romcheg:(09:25
*** overlayer has joined #openstack-ironic09:25
*** sabah has quit IRC09:36
*** loki184 has quit IRC09:36
*** rakesh_hs has quit IRC09:41
*** sabah has joined #openstack-ironic10:03
*** Nisha has quit IRC10:08
*** sabah has quit IRC10:08
*** jcoufal has joined #openstack-ironic10:13
*** sabah has joined #openstack-ironic10:14
*** takadayuiko has joined #openstack-ironic10:19
*** rakesh_hs has joined #openstack-ironic10:42
*** Alexei_9871 has joined #openstack-ironic10:43
*** ramineni has quit IRC10:56
*** loki184 has joined #openstack-ironic11:05
openstackgerritSyed Ismail Faizan Barmawer proposed a change to openstack/ironic-specs: UEFI support for Ironic deploy drivers  https://review.openstack.org/9985011:06
*** subah has joined #openstack-ironic11:07
*** sabah has quit IRC11:07
*** bvivek has quit IRC11:08
*** pradipta is now known as pradipta_away11:15
*** pradipta_away is now known as pradipta11:18
*** coolsvap is now known as coolsvap|afk11:23
*** Poornima has quit IRC11:25
openstackgerritRamakrishnan G proposed a change to openstack/ironic-specs: iLO Virtual Media Deploy Driver  https://review.openstack.org/9774411:27
*** athomas has quit IRC11:29
*** athomas has joined #openstack-ironic11:31
*** subah has quit IRC11:38
*** faizan has joined #openstack-ironic11:40
*** loki184 has quit IRC11:41
*** amitpp has quit IRC11:50
*** pradipta is now known as pradipta_away11:58
*** ajc_ has quit IRC11:58
*** nosnos has quit IRC11:59
*** nosnos has joined #openstack-ironic11:59
*** Shrews has quit IRC12:00
*** Shrews has joined #openstack-ironic12:01
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic-specs: iPXE boot  https://review.openstack.org/9882212:04
*** nosnos has quit IRC12:04
*** takadayuiko has quit IRC12:06
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements  https://review.openstack.org/10212612:24
*** jdob has joined #openstack-ironic12:25
*** k4n0 has quit IRC12:41
*** Poornima has joined #openstack-ironic12:43
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Rename/update common/tftp to drivers/modules/pxe_utils  https://review.openstack.org/10359512:45
openstackgerritLucas Alvares Gomes proposed a change to openstack/ironic: Add iPXE support for Ironic  https://review.openstack.org/9931812:45
*** linggao has joined #openstack-ironic12:46
*** jbjohnso has joined #openstack-ironic12:55
*** rloo has joined #openstack-ironic13:17
*** ramineni has joined #openstack-ironic13:20
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Cleanup mock patch without `with` part 3  https://review.openstack.org/7325613:23
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Get rid of the newline "\"  https://review.openstack.org/6679313:23
openstackgerritMikhail Durnosvistov proposed a change to openstack/ironic: Check whether specified FS is supported  https://review.openstack.org/9810213:25
*** Mikhail_D_ltp has quit IRC13:27
NobodyCamgood morning Ironic13:32
NobodyCamI have some family business to take care of this morning / today so I will in and out most of the day13:35
*** pcrews has joined #openstack-ironic13:37
NobodyCamromcheg: :( why13:37
romchegI'm not likely to be funded for some unknown an bureaucratic reasons13:37
NobodyCam:(13:37
romchegMorning NobodyCam lucasagomes and everyone else!13:38
NobodyCammorning romcheg13:38
lucasagomesmorning NobodyCam romcheg13:38
NobodyCammorning lucasagomes13:38
romcheg1.5k for tickets is too much for me13:38
NobodyCamya13:38
lucasagomesNobodyCam, one thing before you go13:38
romcheg*only for tickets13:38
lucasagomesNobodyCam, can you take a look at the ironic -> ceilometer spec ?13:38
lucasagomesif u have time, if not that's fine13:38
NobodyCamis that the send sensor data to ceilometer13:40
*** romcheg has quit IRC13:40
*** romcheg has joined #openstack-ironic13:40
rloohello ironickers!13:42
NobodyCammorning rloo13:42
romchegMorning rloo!13:43
NobodyCamlucasagomes: my concern was if we have a large pool of nodes and several conductors. with out the tracking the last time we sent data, on ring reblaance every node would queue up for data colection13:44
NobodyCamif we have 10k nodes thats a lot of traffic13:45
*** lazy_prince is now known as killer_prince13:45
lucasagomesNobodyCam, hmm on ring rebalance we don't trigger the periodic tasks to run immediately13:46
lucasagomesNobodyCam, so it would wait the for the interval13:46
lucasagomes(which is by default 600)13:46
NobodyCamahh ok13:46
rlooquick question, the etherpad shows that the gate status is DOWN due to glanceclient but that has been merged. Are there other issues with Gate or is everything grand in ironicland?13:47
NobodyCamrloo that should be fixed now13:47
lucasagomesrloo, oh it was fixed yesterday I think13:47
lucasagomesyeah13:47
romchegGuys, do we have any sprints in EU?13:47
lucasagomesromcheg, yes, I'm in one right now13:47
romchegfffuuu13:47
rloothx NobodyCam, lucasagomes , I'll update the status.13:47
lucasagomesromcheg, https://wiki.openstack.org/wiki/Sprints/ParisJuno201413:48
lucasagomesin paris13:48
lucasagomesromcheg, it started today and will end on friday13:48
*** rakesh_hs has quit IRC13:50
ramineniMorning Ironic13:50
rameshg87ramineni: good morning :-)13:51
NobodyCamlucasagomes: changed my vote. on the spec.. feel free to land away13:51
romchegI will be in Spain and Amsterdam this August so I can meet some of you if you have time to drink beer and discuss the things13:51
romcheg:)13:51
rameshg87rloo: please have a look at https://review.openstack.org/#/c/97455/ , got approval from devananda. he wanted you to take a look at it before approving :-)13:51
lucasagomesNobodyCam, Yay!13:51
lucasagomesNobodyCam, thanks for raising those concerns anyway, make me think/learn more about ceilometer13:52
lucasagomesdata points13:52
lucasagomesromcheg, nice, where in spain?13:52
NobodyCamas long as we dont trigger a rdata poll on rebalance I'm ok with it13:52
raminenilucasgomes,romcheg,rloo ,NobodyCam , can u guys have a look at firmware update design spec , if you have some time13:52
rameshg87rloo: this is for ilo power spec review13:52
lucasagomesromcheg, and what day?13:52
NobodyCambrb13:52
rloorameshg87: will look in a few minutes (catching up on stuff still)13:54
romcheglucasagomes: Barcelona 8-12, Madrid 12-15, Porto (not Spain but very close) 15-18, Amsterdam 18-2513:54
rameshg87rloo: thanks13:54
lucasagomesromcheg, cool13:57
*** amitpp has joined #openstack-ironic13:57
romcheglucasagomes: Would you be able to join me somewhere?13:57
lucasagomesromcheg, I can check that out, I'm planning to go to spain has a while13:57
lucasagomesso it may work out13:57
lucasagomesromcheg, ur going to the midcycle in beaverton?13:58
romcheglucasagomes: I'd say no, because I'm not likely to be funded for that13:59
*** amitpp has quit IRC14:00
romcheglucasagomes: It's been another re-org here + my relocation so there's no budged for Ironic midcycle event14:01
lucasagomesromcheg, :( I see14:01
*** dkehnx has joined #openstack-ironic14:02
*** rloo has quit IRC14:05
*** max_lobur has joined #openstack-ironic14:09
*** rwsu has joined #openstack-ironic14:10
*** rloo_ has joined #openstack-ironic14:20
rameshg87rloo_: just wanted to discuss on the comments  :-)14:27
rameshg87rloo_: is it okay to discuss now ?14:27
*** stendulker has joined #openstack-ironic14:29
*** Nisha has joined #openstack-ironic14:30
rloo_rameshg87: hi14:33
*** jcoufal has quit IRC14:34
rameshg87rloo_: i just posted back some comments14:34
rameshg87rloo_: for https://review.openstack.org/#/c/97455/1314:35
rameshg87rloo_: for the security impact section, since storing passwords in db is the same with every available driver, i thought i can skip that part14:35
rameshg87rloo_: do you feel i should add i note there ?14:35
*** Mikhail_D_ltp has joined #openstack-ironic14:36
*** jcoufal has joined #openstack-ironic14:36
stendulkerjayF: Hi14:36
rloo_rameshg87: I don't know if you should or not. Personally, I would prefer if the spec mentioned that info, but I don't want to delay the spec if others don't think it is worth mentioning.14:37
stendulkerjayF:  can you please review the design spec for firmware settings https://review.openstack.org/#/c/101122/14:38
rameshg87rloo_: okay, i can add a note there. not a problem.14:38
rameshg87rloo_: regarding the tempest testing, we wanted to add but don't have any plans now.14:39
rameshg87rloo_: since power is a very small module and not much useful by itself, it might be worth thinking about it when more advanced features like deploy are available in ilo driver14:40
rloo_rameshg87: if you're going to update the spec, maybe it is worth mentioning that there will be tempest tests in the future when you add an ilo deploy. or not mention . i don't know, i got the info I wanted ;)14:40
stendulkerjroll: Hi14:40
stendulkerjroll: I have updated the firmware setting spec resolving your comments https://review.openstack.org/#/c/101122/14:41
*** Poornima has quit IRC14:41
rameshg87rloo_: i will add a note saying tempest tests will be considered when more advanced modules like deploy are submitted14:41
rameshg87rloo_: thanks, i will revise the spec14:41
rloo_rameshg87: sounds good to me. thx!14:41
stendulkerjroll: Can you please check the  same. Also wanted to know more about the comments related to security concerns14:42
jrollstendulker: I just think there should be a note about: if an unauthorized person can access this endpoint, that's very very bad14:43
*** jgrimm has joined #openstack-ironic14:44
*** stendulker has quit IRC14:46
*** dwalleck has joined #openstack-ironic14:46
*** ramineni has quit IRC14:46
openstackgerritRamakrishnan G proposed a change to openstack/ironic-specs: iLO Power Driver for Ironic  https://review.openstack.org/9745514:48
*** max_lobur has quit IRC14:48
rameshg87rloo_: i have added the notes as discussed, please have a look at the spec again when you get time :-)14:49
*** ramineni has joined #openstack-ironic14:49
*** stendulker has joined #openstack-ironic14:50
*** coolsvap|afk is now known as coolsvap14:53
*** foexle has quit IRC14:53
rloo_rameshg87: thx. I just reviewed it.14:53
*** rloo_ has left #openstack-ironic14:54
*** rloo_ has joined #openstack-ironic14:55
stendulkerdtantsur: Hi14:56
stendulkerdtantsur: I have resolved your reviw comments for firmware settings design spec https://review.openstack.org/#/c/10112214:57
stendulkerdtantsur: Can you please review the same.14:57
rameshg87rloo_: thanks. :-)14:59
jrollstendulker: I just think there should be a note about: if an unauthorized person can access this endpoint, that's very very bad15:01
stendulkerjroll: this endpoint would be similar to other endpoint like power, where it could impact the BM. I can add a note on similar lines under security section.15:04
*** ndipanov_ has joined #openstack-ironic15:05
*** krtaylor has quit IRC15:05
jrollstendulker: I would want to see a similar note if someone added the power state endpoint today :)15:06
stendulkerjroll: Do you feel, any other thing that needs to be updated with respect to security15:06
jrollstendulker: no, just a note that this is very scary (tm) :)15:06
stendulkerjroll: Sure, will do that.15:07
*** ndipanov has quit IRC15:08
stendulkerjroll: I have resolved your other comments. Please look at the new version of the same15:08
jrollthanks15:11
jrollwill do15:11
*** dwalleck has quit IRC15:18
shardyHey all15:18
shardyFYI I've posted some heat resources which expose the Ironic API:15:19
shardyhttps://review.openstack.org/#/q/status:open+project:openstack/heat+branch:master+topic:bp/ironic-resource,n,z15:19
shardyCurrently an initial draft but review feedback from ironic experts welcome ;)15:19
shardylucasagomes: ^^15:19
*** max_lobur has joined #openstack-ironic15:27
*** dwalleck has joined #openstack-ironic15:30
stendulkerjroll: thank you15:31
lucasagomesshardy, w00t! thanks I will take a look at it15:40
stendulkerlucasgomes: Hi15:41
stendulkerlucasgomes: Can you please review firmware settings related to review https://review.openstack.org/#/c/10112215:41
*** jcoufal has quit IRC15:42
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements  https://review.openstack.org/10212615:42
stendulkerlucasgomes: this review is for design spec for this feature15:42
*** faizan has quit IRC15:42
lucasagomesstendulker, hi yeah, I will take a look... I probably will have to see it tomorrow because it's a bit late here15:43
stendulkerlucasgomes: Thank you.15:46
*** rameshg87 is now known as rameshg87_afk15:52
openstackgerritRuby Loo proposed a change to openstack/ironic-specs: API to get driver_info properties  https://review.openstack.org/10291415:54
*** rakesh_hs has joined #openstack-ironic15:57
JayFstendulker: I put a comment on that, it looks good just had a question about the scope and wanted it explicitly stated15:58
*** eghobo has joined #openstack-ironic16:03
*** killer_prince is now known as lazy_prince16:05
*** ndipanov_ has quit IRC16:07
*** eghobo has quit IRC16:08
*** ramineni has quit IRC16:08
*** eghobo has joined #openstack-ironic16:08
stendulkerJayF: Thank you for the review.16:10
rloo_devananda, lucasagomes, NobodyCam, romcheg, anyone: how are we handling patches that change the nova ironic driver. We can +2 but we shouldn't approve?16:11
stendulkerJayF: I'm planning to change the scope statement more explicit to cover in-band mechanism IPA as well.16:11
*** coolsvap is now known as coolsvap|afk16:12
stendulkerIt proposes to introduce standard APIs to support common firmware settings. These firmware settings could be retrieved out-of-band using IPMI, iLO, DRAC etc. or via some in-band mechanism, e.g. IPA.16:12
*** dwalleck has quit IRC16:13
lucasagomesrloo_, hmm I'm also not sure... but that sounds correct16:13
stendulkerJayF: It proposes to introduce standard APIs to support common firmware settings. These firmware settings could be retrieved out-of-band using IPMI, iLO, DRAC etc. or via some in-band mechanism, e.g. IPA.16:13
JayFstendulker: So first of all, we should have these chats somewhat in the spec so others can see/comment async :)16:14
stendulkerJayF: I think this should make it explicit that this feature is applicable to both OOB and IB mechanism16:14
JayFstendulker: but generally, I don't think we should make it applicable to IB16:14
JayFstendulker: primarily because there /is no/ generic way to modify BIOS settings in band16:14
JayFstendulker: for instance, on the servers we're using for OnMetal, we can't 'flip' any single setting, we have to apply a complete set of settings16:15
stendulkerJay: ok16:15
JayFstendulker: so I'm not sure that the API should or could be the same even across different IB implementations of BIOS/Firmware settings16:15
stendulkerJayF: ok.16:15
JayFI'd be +1 right now if IB was taken out of scope16:15
JayFalso curious as to what jroll ^ thinks of all this16:15
stendulkerJayF: I was not aware of this part.16:15
JayFstendulker: That's probably why jroll wanted me to look at it :) I've been doing most of the stuff on-server for these boxse16:16
JayFand pretty much setting BIOS settings from in-band requires proprietary tooling, and is different for each bios16:16
stendulkerJayF: with respect to inability to apply the individual  firmware settings .16:16
JayFfor ours, which is running an AMI bios, it's a proprietary utility that only takes in full configuration sets, not individual settings16:16
JayFI can't speak to others, or if it's even possible on others, I just know the one example I have doesn't align well at all16:17
devanandamorning, all16:17
NobodyCamgood morning devananda16:17
devanandarloo_: right now, I'd prefer to be a gatekeeper for any patch that touches the nova driver in our tree16:17
stendulkerJayF: Ok. Yes, but there could be more such platforms.16:18
devanandarloo_: simply because I need to merge all those changes into the proposal to Nova16:18
rloo_devananda: that makes sense. how about you -2 them, so that we can't accidentally approve?16:18
devanandarloo_: ack16:18
JayFstendulker: I personally haven't seen many IB implementations that allow single options to be flipped (I wish they did exist though :C)16:18
devanandarloo_: got one in mind?16:18
stendulkerJayF: I'm fine with stating that this spec is applicable to OOB mechanisms.16:19
rloo_devananda: https://review.openstack.org/#/c/103136/16:19
rloo_devananda: https://review.openstack.org/#/c/92416/16:19
JayFstendulker: cool, thanks16:19
rloo_devananda: https://review.openstack.org/#/c/103137/16:19
*** jcoufal has joined #openstack-ironic16:20
devanandarloo_: woo, a bunch! thanks16:20
*** ndipanov_ has joined #openstack-ironic16:20
rloo_devananda: https://review.openstack.org/#/c/97536/16:20
stendulkerJayF: jroll has reviewed it and in the current patch I have addressed his comments. He had a concern related to security, which I have discussed with him and would add a note related to the same. jroll have agreed to look at the current patch.16:20
rloo_devananda: there may be more. Those were the ones I noticed. Did you want me to look through them all?16:21
stendulkerdevananda: Hi16:21
stendulkerdevananda: Can you please review firmware settings related to review https://review.openstack.org/#/c/10112216:21
devanandarloo_: hmm. no, but pls point them out if you see them16:21
rloo_devananda: will do ;)16:21
devanandastendulker: hi! not right now, no. I've already outlined what my review priorities are, and will get to additional specs later in the cycle, probably around the midcycle meeting16:22
*** dwalleck has joined #openstack-ironic16:23
devanandastendulker: thank you for the ping, though. I wish I had more time to review everything, but unfortunately, do not16:23
devanandamrda_away: https://review.openstack.org/#/c/102695 looks like a failure in your changeset, but also looks like a valuable change which I'd love to be able to land soonish ...16:26
jrollstendulker, JayF: I don't think we should restrict it to oob implementations. could still do single settings flip inband... would just require the implementation to do something like get all settings -> apply all settings with this one change (not ideal, I know). the driver could also just raise NotImplementedError if it's not possible.16:26
stendulkerdevananda: I understand. I pinged you as you had API related concern. I wished to convey you that its being addressed with the help of dtantsur, jroll, JayF and NobodyCam16:26
jrollwe don't need everybody to review, especially for lower priority things :)16:27
*** overlayer has quit IRC16:28
JayFjroll: honestly from my experience with the tooling, at least that we're using right now, I think that's a pretty bad road to go down16:28
stendulkerjroll, JayF: thank you for your feedback. If JayF is fine, I will retain references to IB mechanisms in the spec.16:29
jrollJayF: then leave it up to the driver16:29
lucasagomesdevananda, morning16:29
JayFjroll: I could be OK with a "here's a collection of settings, apply them", but the in band tools to do this really are awful16:29
*** athomas has quit IRC16:29
lucasagomesI will have to go, have a good night everybody16:29
jrollJayF: there might be wrird hw where ipa *can* do it inband16:29
jrollweird*16:29
jrollnight lucasagomes16:30
stendulkerlucasgomes: good night :)16:30
*** lucasagomes has quit IRC16:30
*** krtaylor has joined #openstack-ironic16:30
JayFjroll: I just think that in a lot of ways, applying firmware settings in-band is a radically different thing than applying them out of band16:31
jrollJayF: I just don't see an issue with having the same api16:32
JayFand I think there are inherent differences that are going to be incredibly difficult, if not borderline impossible in some cases, to abstract away16:32
jrollJayF: and an implementation can choose not to implement it16:33
*** lazy_prince is now known as killer_prince16:34
JayFWould this preclude a non-managementinterface implementation of firmware setting in-band?16:34
*** lsmola__ has quit IRC16:34
JayFif so, then I think those differences are relevant now from the perspective of that spec16:34
*** ifarkas has quit IRC16:34
devanandaJayF, jroll: have you both seen the async API spec's latest incarnation?16:34
jrollJayF: unclear what you mean16:34
Nishadevananda: lifeless Hi, Did you had a chance to look at Discover node properties at node-create/node-update https://review.openstack.org/#/c/100951/16?16:35
jrolldevananda: no16:35
JayFI haven't read any incarnation of it, but I think from what you said I probably should :)16:35
devanandaI think it presents a framework for a REST API where a single ManagementInterface could handle both in- and out-of-band16:35
devanandayes16:35
devanandabasically it's a proposal for a /v2/ API16:35
devanandato address several issues we're seeing16:35
jrollright16:35
jrollI haven't looked in a week or two16:36
devanandaI suspect we'll all end up talking at length about it at the midcycle, but it's gonna end up being a lot more work than we can do in Juno, clearly16:36
devanandaso iterative improvements for now, while we discuss if larger changes are really necessary // how to address issues caused by the underlying API architecture we have today16:37
stendulkerjayF, jroll: just curious, given that all of the firmware settings needs to be applied in one go for in-band mechanism. what kind of mangement interface would address it?16:38
JayFstendulker: I'm not saying for /all/ in-band mechanisms, just the ones I'm familiar with16:38
romchegrloo_: having a class right now16:38
JayFstendulker: and honestly, I don't know, but I would see something that talks more about the purpose of the settings, and leaves the implementation to the hardware manager in IPA for in band16:39
rloo_romcheg: no worries, I got the answer from deva.16:39
*** dkehn__ has joined #openstack-ironic16:39
JayFstendulker: for instance, "set bios settings to VM_OPTIMAL" might enable VT, disable Turbo mode and power saving16:39
stendulkerjayF, jroll: ok. but again, it would be a binary patch, I suppose.16:39
jrolldevananda: agreed16:39
JayFstendulker: or "set bios settings to secure" might set some BIOS settings that 'lock down' the instance for a customer16:39
JayFstendulker: but the key is that it has to be generic enough that the IPA HardwareManager has lots of freedom to implement it in whatever crazy way a vendor decided you should set bios settings for their box16:40
jroll"binary patch"?16:40
stendulkerjayF: ok. so single setting would change the related settings as well.16:40
*** geekyogi1 has joined #openstack-ironic16:40
openstackgerritEllen Hui proposed a change to openstack/ironic: Add more INFO logging to ironic/common  https://review.openstack.org/9949516:41
devanandastendulker: Jayf: https://review.openstack.org/9492316:41
stendulkerjroll: since it was mentioned that multiple settings are updated through single shot, i thought the propritary tool generates a patch based upon settings input. My mistake16:41
JayFstendulker: I'm just thinking more about talking about what, on a high level, we're trying to do rather than trying to make Ironic (and IPA) smart enough to know how to flip single settings on and off16:41
devanandaproposal for a "convergence API"16:41
jrollstendulker: oh. dunno.16:41
*** dkehnx has quit IRC16:41
devanandabased on an approach like that, an inband firmware update could be done in a single pass16:42
devanandawhereby the user makes one or more API requests for the state they want, and then at some time (eg, just before deploy, or something else... TBD) the agent applies them16:42
Nishadevananda could you please review https://review.openstack.org/#/c/100951/16? Got +1 from NobodyCam16:42
*** geekyogi has quit IRC16:43
*** Isotopp has quit IRC16:43
devanandaNisha: I will take a look when I have time16:43
*** Isotopp has joined #openstack-ironic16:43
devanandawhich may be a while. I alraedy spent ~4 hours reviewing specs today16:43
Nishadevananda: Thanks...16:43
stendulkerdevananda: thanks for pointing to this spec.16:43
*** Isotopp has quit IRC16:44
*** Isotopp has joined #openstack-ironic16:45
stendulkerNobodyCam: I have responded to your queries wrt firmware settings review https://review.openstack.org/#/c/101122 Please have a look.16:45
*** hemna__ is now known as hemna16:45
stendulkerjroll, JayF: JayF, if you agree, I will mention that this spec applies to in-band mechanisms as well.16:47
JayFI disagree but I'll have a battle royale with jroll when he gets into the office since we work together :)16:48
jroll^16:48
jrollthere may be something I'm missing16:48
stendulkeroh :)16:48
stendulkerjayF, jroll: May be we can take a final call, once both of you could discuss this in person.16:49
jrollstendulker: we'll comment on the review so that everyone can see16:50
stendulkerjroll: that would help. I opened the discussion here for quicker resolution as we work across time zones. Shall I capture this discussion in the review as a comment?16:51
NobodyCamstendulker: will do...16:51
jrollstendulker: right. do that if you like16:51
stendulkerNobodyCam: thank you16:52
stendulkerjroll: will do that. will add summary on this discussion16:52
*** pelix has quit IRC16:52
*** harlowja_away is now known as harlowja16:52
jrollstendulker: for what its worth, there's no rush on this spec as it is not a priority for juno... but still faster is better :)16:52
stendulkerjroll: yes, unfortunately. But if this spec could get into right shape, it may have a luck in later cycle.16:54
jrollstendulker: of course16:55
*** dkehn__ is now known as dkehnx16:57
*** ndipanov_ has quit IRC17:01
*** Penick has joined #openstack-ironic17:07
*** Alexei_9871 has quit IRC17:09
*** derekh_ has quit IRC17:11
*** loki184 has joined #openstack-ironic17:13
*** eghobo has quit IRC17:14
openstackgerritGhe Rivero proposed a change to openstack/ironic: Update nova rebuild to account for new image  https://review.openstack.org/10322717:20
*** dkehn__ has joined #openstack-ironic17:21
openstackgerritGhe Rivero proposed a change to openstack/ironic: Update nova rebuild to account for new image  https://review.openstack.org/10322717:23
*** dkehn__ has quit IRC17:23
*** dkehn__ has joined #openstack-ironic17:24
*** dkehnx has quit IRC17:25
*** dkehn__ is now known as dkehnx17:26
*** romcheg has quit IRC17:29
JoshNangNobodyCam: in the swift spec, about setting the tenant_id as a conf option limiting it to a single tenant, that's true. i'm not sure how to work around it though. do i have access to the user's tenant_id at deploy time?17:31
devanandaGheRivero: that ^ has unresolved merge conflict at L742 of driver.py17:32
GheRiverodevananda: agh! I fixed another, but miss that one! silly me.17:34
openstackgerritGhe Rivero proposed a change to openstack/ironic: Update nova rebuild to account for new image  https://review.openstack.org/10322717:38
*** stendulker has quit IRC17:38
lifelessNisha: no I haven't, as I said, early next week.17:40
linggaoHi Shrews, is the bug that you mentioned to me yesterday landed?17:43
*** chuckC has quit IRC17:43
*** datajerk has quit IRC17:43
Shrewslinggao: yes17:43
*** Penick has quit IRC17:45
linggaoShrews, do you know the bug number?17:45
linggaoI need to recheck my patch.17:45
Shrewslinggao: no. you’ll need to rebase before you recheck though17:46
linggaooh, no.17:46
jrollJoshNang: I believe you don't have the user's tenant id in callbacks17:48
*** Penick has joined #openstack-ironic17:48
*** openstackgerrit has quit IRC17:49
JoshNangjroll: ahh yeah. but i could save it in instance info or something beforehand if that's the only blocker. or generate the temp url earlier or something.17:50
*** openstackgerrit has joined #openstack-ironic17:50
jrollgah.17:51
JoshNangthough, i'd still need to know the backend container the image is stored in. i'm leaning towards documenting that if you don't have direct_url you're limited to a single tenant_id/container17:51
jrolldisclaimer, didn't read the comment yet17:51
jrollmaybe17:51
jrollbut like17:51
jrollI don't want to be limited to that17:51
*** rameshg87_afk is now known as rameshg8717:51
JoshNangi agree. i wonder if there's a way i could query glance for it. you'd think there'd be a way to not enable direct_url in the standard glance image-show, but allow admins to see it only.17:52
*** Shrews has quit IRC17:55
*** sseago has quit IRC17:56
*** loki184 has quit IRC17:57
*** rameshg87 is now known as rameshg87_afk18:00
jrollJoshNang: I mean, glance has like a storage url or something, yes?18:01
openstackgerritJim Rollenhagen proposed a change to openstack/ironic-python-agent: Add current directory logging to build script  https://review.openstack.org/10427618:04
JoshNangjroll: wdym?18:05
jrollJoshNang: I think glance-show gives you a 'storage url'. kind of like a direct url without creds.18:06
jrollI might be completely wrong18:06
JoshNangjroll: i don't think so. i'll go check though18:07
jrollI swear I've heard of it18:08
jrollidk18:08
openstackgerritA change was merged to openstack/ironic-python-agent: Add current directory logging to build script  https://review.openstack.org/10427618:12
*** sseago has joined #openstack-ironic18:12
*** Shrews has joined #openstack-ironic18:12
devanandarloo, NobodyCam: either of you want to review another cleanup to the nova driver? https://review.openstack.org/#/c/97536/18:13
rloo_devananda: I'll take a look18:17
*** sseago has quit IRC18:17
JoshNangjroll: this is all i see in an image-show (no direct_url, swift as backend). https://gist.github.com/pcsforeducation/ac2e8b8e0aea4968ed6218:17
jrollJoshNang: 'nova image-show' might not display all the data18:19
*** amitpp has joined #openstack-ironic18:19
jrollJoshNang: if you run with --debug, you should see the actual json flying around18:19
*** faizan has joined #openstack-ironic18:25
NobodyCamrloo_: I +2's that review (97536) but did not +a so you can look it over :)18:29
NobodyCams/\'s/\'d/18:29
rloo_NobodyCam: thx. Am almost done.18:29
*** sseago has joined #openstack-ironic18:29
rloo_devananda: wrt 97536, all yours to approve when you want!18:30
*** chuckC has joined #openstack-ironic18:31
*** wanyen has joined #openstack-ironic18:32
*** overlayer has joined #openstack-ironic18:39
*** amitpp has quit IRC18:41
devanandaNobodyCam: have a minute to take a look at https://review.openstack.org/#/c/102373/ again?18:43
NobodyCamI might :)18:45
*** eghobo has joined #openstack-ironic18:47
*** eghobo has quit IRC18:47
*** eghobo has joined #openstack-ironic18:48
*** overlayer has quit IRC18:49
*** overlayer has joined #openstack-ironic18:50
devanandaGheRivero: https://review.openstack.org/#/c/103227/4 still failing18:50
NobodyCamdevananda: vote updated to +2 thou I did not +a, leaving that click to you :-p18:53
*** romcheg has joined #openstack-ironic18:53
*** chuckC has quit IRC18:54
openstackgerritGhe Rivero proposed a change to openstack/ironic: Update nova rebuild to account for new image  https://review.openstack.org/10322718:54
GheRiverodevananda: fixed. with the rebase some ironic.nova pep8 changes landed and break the new tests. My bad for not testing it locally before pushing it18:55
devanandaNobodyCam: ack, ty18:55
devanandaGheRivero: ah yea. several fixes are in-flight right now :) trying to land all the driver cleanup so I can update the driver proposal to Nova18:56
NobodyCamdevananda: Thank you for comments18:56
NobodyCamlol makes more sense reading it then just thinkng thru the tests :-p18:57
*** chuckC has joined #openstack-ironic18:57
*** harlowja is now known as harlowja_away18:59
*** Penick has quit IRC19:02
*** harlowja_away is now known as harlowja19:03
*** Nisha has quit IRC19:06
*** Penick has joined #openstack-ironic19:12
openstackgerritA change was merged to openstack/ironic: Add the remaining unittests to the ClientWrapper class  https://review.openstack.org/9241619:13
*** datajerk has joined #openstack-ironic19:13
*** faizan has quit IRC19:23
openstackgerritA change was merged to openstack/ironic: Nova Ironic driver get_info() to return memory stats in KBytes  https://review.openstack.org/10313619:25
openstackgerritA change was merged to openstack/ironic: Update Nova Ironic Driver destroy() method  https://review.openstack.org/10313719:25
openstackgerritA change was merged to openstack/ironic: Add/Update docstrings in the Nova Ironic Driver  https://review.openstack.org/9753619:27
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Remove unused classmethod from nova.virt.ironic driver  https://review.openstack.org/10432219:27
NobodyCamreally thats not used :-p19:31
devanandaNobodyCam: where is it used?19:32
NobodyCamno no I'm just kinda shocked its not. I have not found it in use yet19:33
devanandai've grepped for self.instance and IronicDriver.instance -- nothing19:33
NobodyCaminstance or *._instance?19:34
NobodyCamif not hasattr(cls, '_instance'):19:34
devanandaNobodyCam: it is creating an instance of the driver, then stashing it on the class ... but why? I don't see anything in nova that uses that19:36
* devananda lunches, bbi2019:39
NobodyCamya not seeing it used either19:39
NobodyCambut /me opts to wait for tempest tests19:39
NobodyCam:-p19:39
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Minor cleanups to nova virt driver and tests  https://review.openstack.org/10432219:39
NobodyCamenjoy lunch19:39
devanandaupdating with two other fixes :)19:39
NobodyCamack19:39
NobodyCamfood sounds good19:40
NobodyCambrb19:41
*** overlayer has quit IRC19:42
*** overlayer has joined #openstack-ironic19:43
openstackgerritlinggao proposed a change to openstack/ironic-specs: Add console log support  https://review.openstack.org/9653819:51
JoshNangjroll: that was glance image-show. even with debug its pretty scarce on details. nova image-show with debug shows endpoints from keystone. the token gives us the tenant_id. but we'd still be short glance/swift container19:55
jrollhrm, ok19:56
*** jdob has quit IRC19:57
*** jdob has joined #openstack-ironic19:58
openstackgerritlinggao proposed a change to openstack/ironic: Fix exception handling in console  https://review.openstack.org/10231819:59
openstackgerritJosh Gachnang proposed a change to openstack/ironic-specs: Swift Temporary URLs Spec  https://review.openstack.org/9890420:02
*** rakesh_hs has quit IRC20:06
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Allow noauth for Neutron  https://review.openstack.org/9892220:08
*** harlowja is now known as harlowja_away20:09
*** zdiN0bot has joined #openstack-ironic20:10
*** romcheg has quit IRC20:14
*** zdiN0bot has quit IRC20:17
*** sseago has quit IRC20:22
*** sseago has joined #openstack-ironic20:22
openstackgerritAlex Weeks proposed a change to openstack/ironic-specs: Add metric reporting spec.  https://review.openstack.org/10072920:28
ShrewsAnyone familiar with the disk_available_least compute node value?20:33
*** sseago has quit IRC20:37
rloo_JoshNang: I just commented on 98922 (noauth for neutron). let me know if you have questions.20:38
*** romcheg has joined #openstack-ironic20:38
*** harlowja_away is now known as harlowja20:39
*** Mikhail_D_ltp has quit IRC20:40
Shrewsadam_g: we have 4 bugs marked with 'ironic-tempest' tag, and 3 marked with 'tempest'. Wondering which ones are mis-tagged20:45
ShrewsNeither tag appears in our "official" list: https://wiki.openstack.org/wiki/Bug_Tags#Ironic20:46
adam_gShrews, they're mostly tempest bugs, didnt realize they needed to be 'official' tags. was tagging for my own personal book keeping. ill bring that up with tempest guys tomorrow.20:48
Shrewsoh, those are under the tempest bugs20:48
JoshNangrloo_: nope that makes sense to me!20:48
Shrewsadam_g: my bad... thought they were filed under ironic20:49
rloo_JoshNang: ok thx. Sorry, I totally forgot about that patch; I should have given then feedback sooner.20:49
JoshNangrloo_: no worries!20:50
* devananda is back20:50
*** krtaylor has quit IRC20:50
*** zdiN0bot has joined #openstack-ironic20:52
*** dwalleck has quit IRC20:54
*** zdiN0bot has quit IRC20:55
NobodyCamwb devananda20:57
Shrewsdevananda: fyi, https://bugs.launchpad.net/ironic/+bug/133693720:57
Shrewsprobably should fix that before merging the driver back into nova20:59
Shrewsbut i have no idea what that value is yet20:59
*** mrda_away is now known as mrda21:02
*** linggao has quit IRC21:02
mrdaMorning Ironic!21:02
Shrewsmorning mrda21:02
NobodyCammorning mrda21:03
mrdadevananda: I'll be working on that changeset re: caching today.  Looks like a little more work, but hoping to get another patch up soon (might need some work in ironicclient)21:03
NobodyCamfilename.docx is a M$ word file, I think?21:03
mrdahey Shrews & NobodyCam :)21:03
devanandamrda: ack, thanks!21:03
devanandaNobodyCam: yes21:04
devanandamrda: and g'morning!21:04
* mrda is off to cafe hack, bbs (\o deva)21:04
devanandaShrews: interesting...21:04
*** romcheg has quit IRC21:04
devanandaShrews: not causing a functional problem for us, but def needs to be fixed as part of the tempest cleanup21:05
devanandaShrews: it's not immediately clear to me what we should set that to21:05
*** zdiN0bot has joined #openstack-ironic21:05
devanandaShrews: size of the root_gb on the smallest node?21:06
devananda*shrug*21:06
Shrewsdevananda: me neither. best i could find so far is the libvirt driver comments and http://www-01.ibm.com/support/knowledgecenter/#!/SS4KMC_2.3.0/com.ibm.sco.doc_2.3/sr/hv/hvr_trohyer.html21:06
openstackgerritGhe Rivero proposed a change to openstack/ironic: Fix tear_down a node with missing info  https://review.openstack.org/10368521:07
*** jbjohnso has quit IRC21:08
devanandaadam_g: have you been hitting https://bugs.launchpad.net/ironic/+bug/1326364 in the last ~3 weeks? it looks like both fixes landed but the bug wasn't closed yet21:10
*** steveh has joined #openstack-ironic21:11
openstackgerritJosh Gachnang proposed a change to openstack/ironic: Allow noauth for Neutron  https://review.openstack.org/9892221:14
JoshNangrloo_: so i basically took your advice but made it a bit more explicit. a few other OS services use auth_strategy=keystone as default, so i stuck to that and added error checking. thanks for the review21:15
*** romcheg has joined #openstack-ironic21:19
*** zdiN0bot has quit IRC21:21
*** zdiN0bot has joined #openstack-ironic21:21
adam_gdevananda, the unique constraint is only a partial fix. i had a patch for it, one min21:27
adam_gdevananda, https://review.openstack.org/#/c/99519/ was my fix. didn't get li9nked21:28
devanandaadam_g: I think the "." on the closes-bug line breaks the parsing sometimes21:29
adam_gdevananda, yeah, thats my hunch too. ive stopped adding it lately21:29
*** sseago has joined #openstack-ironic21:29
devanandaadam_g: so you feel the bug is fixed now?21:30
devanandaadam_g: if so, i'll link and close it21:30
adam_gdevananda, it should be, yes.21:30
devanandaadam_g: awesome21:30
adam_gthanks21:30
*** overlayer has quit IRC21:30
*** jdob has quit IRC21:31
rloo_JoshNang: just one little thing now ;)21:31
openstackgerritA change was merged to openstack/ironic: Update Nova's available resources at termination  https://review.openstack.org/10237321:36
*** overlayer has joined #openstack-ironic21:40
rloo_JoshNang: wrt your spec: https://review.openstack.org/#/c/98904/. Did some changes get lost? eg the para under Performance Impact is diff from revision 7.21:42
*** romcheg has quit IRC21:49
*** Haomeng|2 has joined #openstack-ironic21:50
*** Haomeng has quit IRC21:50
* NobodyCam is back with doped up bubbie. :-p21:54
openstackgerritA change was merged to openstack/ironic: Updated from global requirements  https://review.openstack.org/10212621:55
*** zdiN0bot has quit IRC22:04
*** ccrouch has quit IRC22:04
openstackgerritJim Rollenhagen proposed a change to openstack/ironic-python-agent: Run make with sudo when building  https://review.openstack.org/10436122:11
*** ccrouch has joined #openstack-ironic22:17
*** radsy has joined #openstack-ironic22:27
openstackgerritEllen Hui proposed a change to openstack/ironic: Add more INFO logging to ironic/conductor  https://review.openstack.org/9974422:27
*** jgrimm has quit IRC22:37
*** Penick has quit IRC22:38
NobodyCamhum we have a blueprint for secure storage for IPMI creds (kinda) but not a spec :-p22:48
*** zdiN0bot has joined #openstack-ironic22:52
*** krtaylor has joined #openstack-ironic22:56
openstackgerritEllen Hui proposed a change to openstack/ironic: Add more INFO logging to ironic/common  https://review.openstack.org/9949522:58
*** blamar_ has joined #openstack-ironic23:01
*** blamar has quit IRC23:01
*** blamar_ is now known as blamar23:01
*** faizan has joined #openstack-ironic23:04
*** blamar has quit IRC23:04
NobodyCamrloo_: LOL - pros: no code changes at all, no need to write this specification23:09
*** zdiN0bot has quit IRC23:09
JayFNobodyCam: doped up bubbie? haha I don't know what that means but it sounds fun and hilarious23:13
NobodyCamJayF: Bubbie is our name for our male Great Dane. just got him back from surgery23:15
JayFAha.23:15
JayFI went almost the entire other direction :)23:15
NobodyCam:) all is good with him... just groggy23:15
*** ccrouch has quit IRC23:26
*** zdiN0bot has joined #openstack-ironic23:30
*** jcoufal has quit IRC23:48
openstackgerritJosh Gachnang proposed a change to openstack/ironic-python-agent: Adding support for decommissioning  https://review.openstack.org/10437923:51
openstackgerritDevananda van der Veen proposed a change to openstack/ironic: Use "incubated" doc theme  https://review.openstack.org/10438023:51
devanandaone more review for the nova driver, if anyone's still around: https://review.openstack.org/#/c/103227/23:54
openstackgerritOpenStack Proposal Bot proposed a change to openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/8872223:54
*** zdiN0bot has quit IRC23:54
*** max_lobur has quit IRC23:58
faizanDevananda: NobodyCam: thanks for reviewing uefi spec 99850. I have address most of your comments and posted a patch. I need to discuss on few of the review comments23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!