| *** max_lobur has quit IRC | 00:09 | |
| *** ellenh has quit IRC | 00:12 | |
| *** ellenh has joined #openstack-ironic | 00:18 | |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Make ComputeCapabilitiesFilter work with Ironic https://review.openstack.org/105802 | 00:23 |
|---|---|---|
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Clean up nova virt driver test code https://review.openstack.org/105925 | 00:23 |
| devananda | trivial code cleanup ^ if anyone wants to +2 | 00:23 |
| devananda | NobodyCam: the CCF patch up there now has unit tests | 00:24 |
| devananda | but i had to clean up the test code... | 00:24 |
| *** max_lobur has joined #openstack-ironic | 00:26 | |
| *** eguz has joined #openstack-ironic | 00:27 | |
| *** eguz has quit IRC | 00:27 | |
| *** max_lobur has quit IRC | 00:27 | |
| *** ellenh has quit IRC | 00:28 | |
| *** eghobo has quit IRC | 00:30 | |
| *** ellenh has joined #openstack-ironic | 00:32 | |
| *** dkehnx1 has quit IRC | 00:34 | |
| *** hemna is now known as hemna_ | 00:45 | |
| *** sseago has quit IRC | 00:55 | |
| rloo | mrda: yt? | 00:56 |
| mrda | rloo: \o | 00:57 |
| rloo | hey mrda. wrt https://review.openstack.org/#/c/104467/ | 00:57 |
| mrda | yes? | 00:57 |
| rloo | mrda. the propagated test. | 00:57 |
| mrda | :) | 00:57 |
| rloo | mrda. I think it was better before my comments. I misread the code. | 00:58 |
| rloo | mrda. but I'm afraid to ask you to undo it... | 00:58 |
| mrda | lol, ok. I can revert. | 00:58 |
| rloo | mrda. thx. i'll +2 it after that. | 00:58 |
| mrda | No need to be afraid, just make a suggestion on how I can avoid the race in 102695 and I'll consider us even ;) | 00:58 |
| rloo | what race? I'm bad at races anyway, I'm too slow ;) | 00:59 |
| mrda | (a different, but related patch) | 00:59 |
| rloo | mrda: i'll try to take a look tomorrow, not sure I have time for that tonight. (Have to go read to my daughter now.) | 01:00 |
| mrda | rloo: thanks, and have a nice night! | 01:01 |
| openstackgerrit | Michael Davies proposed a change to openstack/python-ironicclient: Expose auth_ref in ironicclient client object https://review.openstack.org/104467 | 01:01 |
| *** eghobo has joined #openstack-ironic | 01:02 | |
| *** ellenh has quit IRC | 01:04 | |
| *** eghobo has quit IRC | 01:33 | |
| *** eghobo has joined #openstack-ironic | 01:34 | |
| *** eghobo has quit IRC | 01:45 | |
| *** nosnos has joined #openstack-ironic | 01:48 | |
| *** jerryz has joined #openstack-ironic | 01:54 | |
| *** Haomeng|2 has quit IRC | 02:02 | |
| *** Haomeng has joined #openstack-ironic | 02:32 | |
| *** killer_prince is now known as lazy_prince | 02:53 | |
| *** Poornima has joined #openstack-ironic | 02:58 | |
| *** ramineni has joined #openstack-ironic | 02:59 | |
| *** vinbs has joined #openstack-ironic | 03:03 | |
| Shrews | NobodyCam: 103331 requires a backport to stable/icehouse to fix that. | 03:07 |
| Shrews | NobodyCam: this one, actually: https://review.openstack.org/105583 | 03:08 |
| *** eghobo has joined #openstack-ironic | 03:18 | |
| *** nosnos has quit IRC | 03:23 | |
| *** aswadr has joined #openstack-ironic | 03:25 | |
| *** rloo has quit IRC | 03:25 | |
| *** Nisha has joined #openstack-ironic | 03:27 | |
| *** jerryz has quit IRC | 03:29 | |
| *** lazy_prince is now known as killer_prince | 03:37 | |
| *** Poornima has quit IRC | 03:46 | |
| *** coolsvap|afk is now known as coolsvap | 03:50 | |
| *** sseago has joined #openstack-ironic | 03:53 | |
| *** nosnos has joined #openstack-ironic | 03:53 | |
| *** blamar has quit IRC | 03:54 | |
| *** radsy has quit IRC | 04:02 | |
| *** geekyogi has joined #openstack-ironic | 04:04 | |
| *** eghobo has quit IRC | 04:04 | |
| *** coolsvap is now known as coolsvap|afk | 04:08 | |
| *** blamar has joined #openstack-ironic | 04:08 | |
| *** killer_prince is now known as lazy_prince | 04:11 | |
| *** chuckC has quit IRC | 04:12 | |
| *** amitpp has joined #openstack-ironic | 04:19 | |
| *** takadayuiko has joined #openstack-ironic | 04:24 | |
| *** sabah has joined #openstack-ironic | 04:32 | |
| *** pcrews has quit IRC | 04:34 | |
| *** pcrews has joined #openstack-ironic | 04:36 | |
| *** eghobo has joined #openstack-ironic | 04:38 | |
| *** rameshg87 has joined #openstack-ironic | 04:44 | |
| *** pcrews has quit IRC | 04:46 | |
| *** eghobo has quit IRC | 04:48 | |
| *** eghobo has joined #openstack-ironic | 04:48 | |
| *** k4n0 has joined #openstack-ironic | 05:03 | |
| *** eguz has joined #openstack-ironic | 05:05 | |
| *** eghobo has quit IRC | 05:09 | |
| *** bmahalakshmi has joined #openstack-ironic | 05:12 | |
| *** bvivek has joined #openstack-ironic | 05:32 | |
| *** k4n0 has quit IRC | 05:34 | |
| *** k4n0 has joined #openstack-ironic | 05:35 | |
| vinbs | Morning Ironic! | 05:42 |
| takadayuiko | Hi, vinbs! | 05:51 |
| *** lazy_prince is now known as killer_prince | 05:52 | |
| mrda | hi takadayuiko and vinbs | 05:55 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/105359 | 06:02 |
| *** geekyogi has quit IRC | 06:06 | |
| *** nosnos has quit IRC | 06:08 | |
| GheRivero | morning all | 06:09 |
| mrda | Hi GheRivero | 06:13 |
| *** killer_prince is now known as lazy_prince | 06:16 | |
| takadayuiko | mrda, hi | 06:18 |
| *** lazy_prince has quit IRC | 06:23 | |
| *** jcoufal has joined #openstack-ironic | 06:32 | |
| *** max_lobur has joined #openstack-ironic | 06:33 | |
| *** eguz has quit IRC | 06:33 | |
| *** geekyogi has joined #openstack-ironic | 06:44 | |
| *** harlowja is now known as harlowja_away | 06:47 | |
| *** coolsvap|afk is now known as coolsvap | 06:53 | |
| *** geekyogi1 has joined #openstack-ironic | 07:00 | |
| *** Poornima|mtg has joined #openstack-ironic | 07:01 | |
| *** Poornima|mtg has quit IRC | 07:03 | |
| *** killer_prince has joined #openstack-ironic | 07:21 | |
| *** killer_prince has quit IRC | 07:21 | |
| *** lazy_prince has joined #openstack-ironic | 07:22 | |
| *** ndipanov has joined #openstack-ironic | 07:22 | |
| *** geekyogi1 has quit IRC | 07:40 | |
| *** max_lobur has quit IRC | 07:48 | |
| *** foexle has joined #openstack-ironic | 07:50 | |
| *** mkerrin has quit IRC | 07:51 | |
| *** mkerrin has joined #openstack-ironic | 07:58 | |
| Haomeng | morning vinbs, takadayuiko, mrda, GheRivero :) | 07:59 |
| mrda | hi Haomeng! | 08:00 |
| Haomeng | mrda: :) | 08:00 |
| *** lucasagomes has joined #openstack-ironic | 08:13 | |
| *** derekh_ has joined #openstack-ironic | 08:15 | |
| *** bvivek has quit IRC | 08:17 | |
| *** jistr has joined #openstack-ironic | 08:18 | |
| takadayuiko | Haomeng, hi! | 08:30 |
| Haomeng | takadayuiko: :) | 08:31 |
| *** athomas has joined #openstack-ironic | 08:32 | |
| *** martyntaylor has joined #openstack-ironic | 08:35 | |
| *** bvivek has joined #openstack-ironic | 08:52 | |
| *** Alexei_987 has joined #openstack-ironic | 08:52 | |
| *** athomas has quit IRC | 08:58 | |
| *** zigo has quit IRC | 09:05 | |
| *** zigo has joined #openstack-ironic | 09:07 | |
| ramineni | JoshNang : Hi | 09:07 |
| *** Isotopp has quit IRC | 09:09 | |
| *** Isotopp has joined #openstack-ironic | 09:09 | |
| *** athomas has joined #openstack-ironic | 09:12 | |
| *** rameshg87 is now known as rameshg87_afk | 09:21 | |
| *** lazy_prince is now known as killer_prince | 09:23 | |
| *** killer_prince is now known as lazy_prince | 09:30 | |
| *** pelix has joined #openstack-ironic | 09:33 | |
| *** Nisha has quit IRC | 09:51 | |
| *** lazy_prince is now known as killer_prince | 09:59 | |
| *** romcheg has joined #openstack-ironic | 10:04 | |
| *** killer_prince is now known as lazy_prince | 10:06 | |
| *** martyntaylor has left #openstack-ironic | 10:12 | |
| *** bvivek has quit IRC | 10:13 | |
| *** bvivek has joined #openstack-ironic | 10:14 | |
| *** romcheg has quit IRC | 10:21 | |
| *** chuckC has joined #openstack-ironic | 10:27 | |
| *** chuckC has quit IRC | 10:31 | |
| *** chuckC has joined #openstack-ironic | 10:31 | |
| *** ramineni has quit IRC | 10:44 | |
| *** sabah has quit IRC | 10:58 | |
| *** Haomeng|2 has joined #openstack-ironic | 11:02 | |
| *** Haomeng has quit IRC | 11:03 | |
| *** sabah has joined #openstack-ironic | 11:04 | |
| *** romcheg has joined #openstack-ironic | 11:07 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Add pagination support to {node, port, chassis}-list https://review.openstack.org/91585 | 11:10 |
| *** k4n0 has quit IRC | 11:26 | |
| *** lucasagomes is now known as lucas-hungry | 11:33 | |
| *** lazy_prince has quit IRC | 11:37 | |
| *** sabah has quit IRC | 11:37 | |
| *** amitpp has quit IRC | 11:40 | |
| *** geekyogi1 has joined #openstack-ironic | 11:44 | |
| *** geekyogi has quit IRC | 11:45 | |
| *** openstackgerrit has quit IRC | 11:47 | |
| mrda | Night Ironic... | 11:50 |
| *** mrda is now known as mrda-away | 11:50 | |
| *** killer_prince has joined #openstack-ironic | 11:52 | |
| *** killer_prince is now known as lazy_prince | 11:53 | |
| *** Haomeng has joined #openstack-ironic | 12:04 | |
| *** Haomeng|2 has quit IRC | 12:05 | |
| *** lazy_prince has quit IRC | 12:07 | |
| *** vinbs has quit IRC | 12:09 | |
| *** jdob has joined #openstack-ironic | 12:15 | |
| *** lucas-hungry is now known as lucasagomes | 12:17 | |
| *** coolsvap is now known as coolsvap|afk | 12:23 | |
| *** dhellmann is now known as dhellmann_ | 12:38 | |
| *** ramineni has joined #openstack-ironic | 12:40 | |
| *** bmahalakshmi has quit IRC | 12:46 | |
| ramineni | NobodyCam : Hi | 12:57 |
| *** rloo has joined #openstack-ironic | 12:58 | |
| *** bvivek has quit IRC | 12:59 | |
| *** ramineni has quit IRC | 13:02 | |
| *** ramineni has joined #openstack-ironic | 13:03 | |
| ramineni | rloo: Hi , good morning :) | 13:04 |
| rloo | hi ramineni. | 13:06 |
| *** coolsvap|afk is now known as coolsvap | 13:07 | |
| ramineni | rloo: Hi , Request you to have a look at ilo power driver code - https://review.openstack.org/#/c/89500/ | 13:10 |
| ramineni | rloo: waiting to get into j2 :) | 13:11 |
| *** tatyana has joined #openstack-ironic | 13:11 | |
| *** bvivek has joined #openstack-ironic | 13:11 | |
| rloo | ramineni: I'll take a look but I don' t know when. There are a few other things I said I'd do today. My guess is that I most likely won't get to it until next week (I'm off after today). | 13:12 |
| ramineni | rloo: ooh :( | 13:13 |
| rloo | ramineni: if you haven't, you can help by reviewing other patches. (Guess what takes up a lot of my time...) | 13:13 |
| *** athomas has quit IRC | 13:14 | |
| *** athomas has joined #openstack-ironic | 13:15 | |
| *** tatyana has quit IRC | 13:15 | |
| ramineni | rloo: sure . will do that . looked at specs only till now. | 13:15 |
| rloo | ramineni: looking at specs helps too. Lots of stuff to do around here! | 13:16 |
| ramineni | rloo : ya :) | 13:16 |
| *** killer_prince has joined #openstack-ironic | 13:26 | |
| *** killer_prince is now known as lazy_prince | 13:26 | |
| lucasagomes | rloo, morning, I submitted a new patch for the pagination. Please take a look when you get some time | 13:26 |
| rloo | hiya lucasagomes. Yep, just starting to ;) | 13:26 |
| lucasagomes | rloo, okie dokie :) | 13:27 |
| lucasagomes | rloo, I tried to make it clear on the docstrings, about the conditions etc... | 13:27 |
| rloo | lucasagomes: good :) | 13:27 |
| lucasagomes | rloo, another thing... I will fix this patch soon https://review.openstack.org/#/c/103595/ | 13:35 |
| lucasagomes | I will remove the blueprint tag, cause it's not really related (as jroll pointed out) | 13:36 |
| rloo | lucasagomes: ah. ok, ping me when you've fixed it and i'll remove the -2. | 13:36 |
| lucasagomes | rloo, once I do it, can you remove the -2? (if u agree it's not related to the bp) | 13:36 |
| lucasagomes | rloo, aight | 13:36 |
| lucasagomes | ta much! | 13:36 |
| rloo | lucasagomes: i'm not going to police to make sure it is or is not related. I trust you :) | 13:37 |
| lucasagomes | rloo, :) yeah it's basically moving some existing code from A to B | 13:37 |
| lucasagomes | so, not big deal really | 13:37 |
| rloo | lucasagomes: ok. btw, what's the story with the ipxe spec. is it close to being approved? | 13:37 |
| lucasagomes | rloo, I think it's, but we have so few core looking at specs right now | 13:38 |
| lucasagomes | rloo, I got that spec and patches are also up | 13:38 |
| lucasagomes | they are testable, you can test with devstack and nested vms (same as we do in gate) | 13:38 |
| rloo | lucasagomes: ok, cuz this stuff is hopefully for j2, right? i'll try to take a look at the spec later, although it doesn't help much cuz i can only +1 it. | 13:38 |
| lucasagomes | rloo, every little helps :) | 13:39 |
| rloo | lucasagomes: yup. | 13:39 |
| lucasagomes | rloo, yeah, devananda mentioned he may want to get it merged for j2 | 13:39 |
| *** matty_dubs|gone is now known as matty_dubs | 13:40 | |
| *** bvivek has quit IRC | 13:53 | |
| *** jcoufal has quit IRC | 13:56 | |
| *** pcrews has joined #openstack-ironic | 13:57 | |
| *** jistr has quit IRC | 13:59 | |
| *** jgrimm has joined #openstack-ironic | 14:01 | |
| *** gilliard_ has joined #openstack-ironic | 14:01 | |
| gilliard_ | Does passing <path=value> to "ironic node-update" have the same effect as using --properties <key=value> when doing node-create? | 14:03 |
| gilliard_ | When I try to use it, it seems not (attributes != properties) but then does that mean there's no way to add a property to a node after it's been created? | 14:05 |
| lucasagomes | gilliard_, node-update $NODE add properties/<path>=<value> | 14:05 |
| gilliard_ | lucasagomes: ahhhh :) thanks | 14:05 |
| lucasagomes | gilliard_, --properties is adding to the "/properties" field of the Nodes | 14:05 |
| *** jcoufal has joined #openstack-ironic | 14:06 | |
| NobodyCam | good mornign ironic | 14:07 |
| romcheg | Morning NobodyCam and everyone else! | 14:07 |
| NobodyCam | morning romcheg | 14:08 |
| NobodyCam | lucasagomes: and rloo too | 14:08 |
| lucasagomes | NobodyCam, morning | 14:08 |
| rloo | morning NobodyCam! | 14:08 |
| rloo | (and afternoon romcheg) | 14:08 |
| jroll | mornin y'all | 14:09 |
| jroll | :) | 14:09 |
| jroll | uh oh, no bot :( | 14:12 |
| NobodyCam | morning jroll | 14:12 |
| jroll | 100364, 100734, and 100735 should be good to go | 14:12 |
| jroll | ^^ morning NobodyCam, presents for you :) | 14:12 |
| NobodyCam | hehehe :) | 14:13 |
| * BadCub_ yawns and prays to coffee gods | 14:17 | |
| BadCub_ | MOrning | 14:17 |
| *** jistr has joined #openstack-ironic | 14:28 | |
| *** ramineni has quit IRC | 14:30 | |
| *** Alexei_987 has quit IRC | 14:37 | |
| *** Isotopp has quit IRC | 14:53 | |
| *** jbjohnso has joined #openstack-ironic | 14:54 | |
| *** geekyogi has joined #openstack-ironic | 14:55 | |
| *** geekyogi1 has quit IRC | 14:57 | |
| *** dkehnx1 has joined #openstack-ironic | 15:01 | |
| *** jistr has quit IRC | 15:24 | |
| *** jistr has joined #openstack-ironic | 15:24 | |
| *** max_lobur has joined #openstack-ironic | 15:26 | |
| *** openstackgerrit has joined #openstack-ironic | 15:32 | |
| *** martyntaylor has joined #openstack-ironic | 15:35 | |
| *** martyntaylor has left #openstack-ironic | 15:36 | |
| *** geekyogi has quit IRC | 15:39 | |
| *** geekyogi has joined #openstack-ironic | 15:40 | |
| *** romcheg has quit IRC | 15:45 | |
| *** geekyogi has quit IRC | 15:45 | |
| *** geekyogi has joined #openstack-ironic | 15:45 | |
| *** eghobo has joined #openstack-ironic | 15:51 | |
| *** tatyana has joined #openstack-ironic | 15:52 | |
| NobodyCam | brb | 15:52 |
| *** eghobo has quit IRC | 15:53 | |
| *** eghobo has joined #openstack-ironic | 15:53 | |
| *** hemna has joined #openstack-ironic | 15:54 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Fix node to chassis and port to node association. https://review.openstack.org/106083 | 15:59 |
| devananda | morning, all | 16:05 |
| NobodyCam | good morning devananda | 16:05 |
| NobodyCam | :) | 16:05 |
| BadCub_ | morning Devananda | 16:06 |
| *** ramineni has joined #openstack-ironic | 16:07 | |
| ramineni | JoshNang: Hi | 16:09 |
| *** tatyana has quit IRC | 16:11 | |
| *** ramineni1 has joined #openstack-ironic | 16:11 | |
| *** ramineni has quit IRC | 16:14 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Update docstring for api...node.validate https://review.openstack.org/106092 | 16:15 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: REST API 'limit' parameter to only accept positive values https://review.openstack.org/106093 | 16:16 |
| lucasagomes | devananda, morning | 16:16 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: REST API 'limit' parameter to only accept positive values https://review.openstack.org/106093 | 16:17 |
| *** Poornima has joined #openstack-ironic | 16:17 | |
| *** ramineni1 has quit IRC | 16:17 | |
| *** ellenh has joined #openstack-ironic | 16:19 | |
| *** ellenh has quit IRC | 16:19 | |
| *** ellenh_ is now known as ellenh | 16:20 | |
| *** Nisha has joined #openstack-ironic | 16:29 | |
| *** romcheg has joined #openstack-ironic | 16:33 | |
| *** Poornima has quit IRC | 16:33 | |
| *** geekyogi has quit IRC | 16:34 | |
| openstackgerrit | Ruby Loo proposed a change to openstack/ironic: Update webapi doc with link and console https://review.openstack.org/106102 | 16:48 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Fix node to chassis and port to node association https://review.openstack.org/106083 | 16:50 |
| *** jistr has quit IRC | 16:52 | |
| *** derekh_ has quit IRC | 16:56 | |
| *** athomas has quit IRC | 17:05 | |
| *** pelix has quit IRC | 17:11 | |
| *** harlowja_away is now known as harlowja | 17:13 | |
| *** romcheg has quit IRC | 17:13 | |
| *** lazy_prince is now known as killer_prince | 17:14 | |
| *** tatyana has joined #openstack-ironic | 17:16 | |
| *** tatyana has quit IRC | 17:17 | |
| *** lucasagomes has quit IRC | 17:19 | |
| *** romcheg has joined #openstack-ironic | 17:22 | |
| *** dhellmann_ is now known as dhellmann | 17:27 | |
| *** harlowja has quit IRC | 17:30 | |
| *** harlowja has joined #openstack-ironic | 17:30 | |
| *** tatyana has joined #openstack-ironic | 17:31 | |
| JayF | Is there a way in oslo.processutils to specify the working directory I want the command executed in? | 17:31 |
| *** tatyana has quit IRC | 17:33 | |
| sirushti | devananda, Hi, could you take a look at https://review.openstack.org/#/c/97150/ . I've resolved the things you've pointed out and uploaded a new patch | 17:35 |
| NobodyCam | JayF: would somehting like: "cd /directory/where/you/want; <command to execute>; cd -" work :-p | 17:38 |
| JayF | NobodyCam: that's basically what I'm going to end up doing | 17:38 |
| * NobodyCam has done that b4 | 17:39 | |
| devananda | jroll: oh hey, so i just realized, the pxe driver could create configdrive partitions too, couldn't it? | 17:47 |
| JayF | Absolutely | 17:53 |
| jroll | devananda: sure, why not | 17:53 |
| devananda | :) | 17:54 |
| devananda | i dont know why i think i didn't think of that sooner | 17:54 |
| jroll | devananda: also, wanted to get your thoughts on something... | 17:55 |
| devananda | also, i'm about to propose a /contrib directory since no one else has done it yet | 17:55 |
| jroll | so, we just landed this: https://review.openstack.org/#/c/105788/ | 17:55 |
| jroll | which allows running stock coreos, as long as you have a cloud-config.yml | 17:55 |
| jroll | and the cloud-config.yml file makes the agent run etc | 17:55 |
| jroll | what if... | 17:56 |
| jroll | instead of external static dhcp configs | 17:56 |
| jroll | we had coreos get cloud-config.yml from ironic | 17:56 |
| jroll | ironic dynamically serves it | 17:56 |
| jroll | with options that could be node-specific or whatever | 17:56 |
| jroll | and this could be a neutron dhcp alternative | 17:57 |
| jroll | and then your 'external dhcp' is just stock coreos | 17:57 |
| jroll | with cloud-config=http://ironic/blablabla/cloud-config in the kernel cmd line | 17:57 |
| JayF | jroll: Doesn't quite allow running stock yet, but it makes it trivial to do so | 17:58 |
| JayF | jroll: We would have to specify cloud-config URL on the kernel CLI for CoreOS, then add units in the cloud-config.yaml to download the agent container on the fly (as well as extract it, as it does now) | 17:58 |
| jroll | JayF: right | 18:01 |
| *** max_lobur has quit IRC | 18:02 | |
| *** martyntaylor has joined #openstack-ironic | 18:14 | |
| *** aswadr has quit IRC | 18:22 | |
| *** overlayer has joined #openstack-ironic | 18:25 | |
| *** Penick has joined #openstack-ironic | 18:30 | |
| *** max_lobur has joined #openstack-ironic | 18:34 | |
| NobodyCam | brb | 18:35 |
| openstackgerrit | Devananda van der Veen proposed a change to openstack/ironic: Create drivers/contrib directory https://review.openstack.org/106135 | 18:38 |
| *** Penick has quit IRC | 19:10 | |
| *** Penick has joined #openstack-ironic | 19:12 | |
| *** dwalleck has joined #openstack-ironic | 19:23 | |
| *** dwalleck has quit IRC | 19:24 | |
| openstackgerrit | A change was merged to openstack/ironic: Allow overriding the log level for ironicclient https://review.openstack.org/97048 | 19:27 |
| *** Faizan has joined #openstack-ironic | 19:29 | |
| devananda | jroll: that could be fit on top of the instance config stuff done by the driver and cached eg. in the tftp or http dir | 19:34 |
| *** Isotopp_ has joined #openstack-ironic | 19:35 | |
| devananda | jroll: I would hesitate to make it a REST API call, unless the contents of the file were cached somewhere such that it could be answered w/o an RPC call to the conductor | 19:35 |
| devananda | *and the conductor doing a bunch of work to build it on the fly | 19:35 |
| devananda | jroll: so in that case, how does ironic know all the networky bits taht need to get fed back? isn't that really neutron's job? | 19:36 |
| devananda | jroll: knowledge of VLANs, port bonding, and IP assignment - just as an example. determining those is not Ironic's responsibility, even if it is feeding the resulting data to the node (or the agent) | 19:37 |
| devananda | so you still need some external service from which Ironic gets that information | 19:38 |
| devananda | and then, why is Ironic sitting between cloud-init and that data source in the first place? | 19:38 |
| jroll | devananda: not cloud-init... cloud-config. which is like cloud-init for coreos. this would configure the *agent* | 19:39 |
| *** Isotopp_ is now known as Isotopp | 19:39 | |
| devananda | ah | 19:39 |
| jroll | devananda: things like secret token | 19:39 |
| jroll | etc | 19:39 |
| jroll | I haven't fully thought this through... just putting it out there | 19:39 |
| *** pcrews has quit IRC | 19:44 | |
| *** pcrews has joined #openstack-ironic | 19:51 | |
| Shrews | devananda: any thoughts on http://lists.openstack.org/pipermail/openstack-dev/2014-July/039808.html ? | 19:57 |
| devananda | Shrews: that doesn't jive with my recollection of "dont disable services in d-g just because ironic doesn't need them" | 19:59 |
| devananda | which was a lengthy discussion i had with clarkb and, i think, also sdague a few months back | 20:00 |
| devananda | but personally, i think it's fine | 20:00 |
| devananda | actually | 20:00 |
| devananda | it's only fine now, because ironic has a seprate tempest job | 20:00 |
| *** Penick has quit IRC | 20:01 | |
| devananda | Shrews: what happens when ironic is integrated and gets run in the common -tempest-dsvm job? | 20:01 |
| Shrews | i was not aware that was going to happen | 20:02 |
| devananda | Shrews: actually never mind. i'm suffering from heatstroke. that's not going to happen. | 20:02 |
| Shrews | O.o | 20:02 |
| devananda | not really | 20:02 |
| devananda | but it is f'in hot in here, and i should find somewhere with AC to work from | 20:02 |
| *** Penick has joined #openstack-ironic | 20:05 | |
| *** Faizan has quit IRC | 20:11 | |
| *** coolsvap is now known as coolsvap|afk | 20:13 | |
| devananda | Shrews: is it really the cinder api tests taht fail? or the nova/volume api tests? | 20:16 |
| Shrews | devananda: api.compute.volume test, but apparently there are scenario tests to worry about too | 20:18 |
| Shrews | taking adam's word on that last bit as i haven't explored that yet | 20:19 |
| Shrews | ah, yeah, there are some | 20:22 |
| NobodyCam | oh Shrews Ty for the links this morning :) | 20:25 |
| devananda | Shrews: so api.compute.volume is nova, and should be a featuer flag on nova, right? | 20:26 |
| Shrews | np | 20:26 |
| Shrews | devananda: *i* think so, but not sure if that's correct | 20:26 |
| devananda | Shrews: can we disable the cinder scenario tests with config flags? | 20:27 |
| Shrews | devananda: yep | 20:28 |
| devananda | great. let's do that. replying to the ML now | 20:28 |
| *** blamar has quit IRC | 20:30 | |
| Shrews | devananda: one thing though | 20:30 |
| Shrews | https://github.com/openstack/tempest/blob/master/tempest/scenario/test_minimum_basic.py#L131 | 20:31 |
| Shrews | that entire test would have to be skipped | 20:31 |
| rloo | jroll: you there? Have you seen this 'Reset service processor' spec: https://review.openstack.org/#/c/96545/ | 20:31 |
| rloo | jroll: wrt your https://review.openstack.org/#/c/100364/ | 20:31 |
| *** max_lobur has quit IRC | 20:31 | |
| jroll | rloo: ... | 20:32 |
| jroll | rloo: no I haven't | 20:32 |
| *** overlayer has quit IRC | 20:32 | |
| rloo | jroll: your opinion is desired ;) | 20:32 |
| jroll | rloo: I think we should have it... | 20:32 |
| devananda | Shrews: yep | 20:33 |
| jroll | rloo: general rule is implement in vendor_passthru until someone promotes it to an official interface, right? :) | 20:33 |
| devananda | Shrews: right now, Ironic does not pass that | 20:33 |
| devananda | Shrews: it's accurate | 20:33 |
| rloo | jroll: i'm not sure we have a general rule about that. | 20:33 |
| jroll | I should s/general/unwritten/ | 20:33 |
| rloo | jroll: mgt interface exists even though the spec hasn't yet been approved. | 20:33 |
| rloo | jroll: i don't want the overhead of putting in vendor_passthru if it'll end up in mgtInterface. | 20:34 |
| jroll | rloo: I mean individual methods | 20:34 |
| jroll | rloo: we'll just move it when you add that... | 20:34 |
| rloo | jroll: but you're thinking. gad. i don't want to wait. | 20:34 |
| rloo | jroll: i ain't adding anything. this isn't my spec. | 20:34 |
| jroll | oh oops, read that wrong | 20:34 |
| jroll | but like | 20:35 |
| devananda | Shrews: ironic does not (and probably can not ever reasonably) pass the current expectations of a nova hypervisor's minimum set of features | 20:35 |
| rloo | jroll: ha ha. i was just skimming some specs and noticed it. | 20:35 |
| jroll | I want to add a single function to ipmitool | 20:35 |
| Shrews | devananda: understood | 20:35 |
| devananda | Shrews: because it can't attach a volume to a running instance, live snapshot, or live migrate | 20:35 |
| jroll | rloo: I think we should land my patch. then if/when that spec gets implemented, move it to the reset_service_processor method that describes this | 20:36 |
| devananda | in some special cases, we /might/ be able to live-attach a volume. but live snapshot/migrate? that'd require some rrather fancy hardware to do :) | 20:36 |
| jroll | that the spec describes* | 20:36 |
| rloo | jroll: yeah. do we need to worry about backwards compatibility once it is moved from vendorpassthru to mgt? I hadn't thought about that wrt the new mgt interface. | 20:36 |
| rloo | jroll: so ... i'll pretend I didn't see the connection between the two. no one else is listening. | 20:37 |
| jroll | rloo: idk. we can change any code that uses it. not sure about the rest api. | 20:37 |
| jroll | rloo: ok :) | 20:37 |
| jroll | :P | 20:37 |
| rloo | jroll: you might want to weigh in on that spec though ;) | 20:38 |
| jroll | rloo: I'll try to get to that... priorities are hard | 20:38 |
| rloo | jroll: yeah, I realize that. we all have our marching orders or whatever. | 20:38 |
| jroll | lol | 20:38 |
| jroll | or things we think are important :) | 20:38 |
| jroll | if I thought an official method for this was important, I would have written that spec | 20:39 |
| *** Penick has quit IRC | 20:39 | |
| rloo | jroll: well, does it fit better in mgtInterface or vendorPassthru? | 20:39 |
| jroll | unclear | 20:40 |
| jroll | do we want all vendors to implement it/ | 20:40 |
| jroll | ? | 20:40 |
| rloo | mgtInterface, as vendorPassthru, aren't core. so not required at all. | 20:41 |
| rloo | and even if they are implemented, they don't have to implement (ie support) all the methods in that interface. | 20:41 |
| jroll | oh. hm | 20:42 |
| *** coolsvap|afk has quit IRC | 20:42 | |
| rloo | my understanding anyway. i suspect that vendors may throw methods via vendorpassthru cuz that is simplest and they only care about their driver. i suspect over time or if someone notices, it may become clear that some method should migrate to another interface. | 20:43 |
| *** martyntaylor has quit IRC | 20:48 | |
| *** ndipanov has quit IRC | 20:56 | |
| *** Penick has joined #openstack-ironic | 20:57 | |
| * NobodyCam will be heading out shortly to bubbie to the vet....post-op check-up .. remove stiches, etc... | 20:57 | |
| rloo | NobodyCam: I hope bubbie is up and running soon :-) | 21:01 |
| *** harlowja is now known as harlowja_away | 21:01 | |
| NobodyCam | :) he wants to.. | 21:01 |
| rloo | NobodyCam: or they think they want to ;) | 21:01 |
| NobodyCam | but we can't let him play to much until vet okay's it | 21:01 |
| *** foexle has quit IRC | 21:02 | |
| NobodyCam | oh he does | 21:02 |
| NobodyCam | :-p | 21:02 |
| *** foexle has joined #openstack-ironic | 21:06 | |
| *** harlowja_away is now known as harlowja | 21:08 | |
| *** overlayer has joined #openstack-ironic | 21:08 | |
| *** jdob has quit IRC | 21:09 | |
| *** matty_dubs is now known as matty_dubs|gone | 21:09 | |
| *** Nisha has quit IRC | 21:11 | |
| *** jcoufal has quit IRC | 21:27 | |
| *** jbjohnso has quit IRC | 21:29 | |
| *** mrda-away is now known as mrda | 21:35 | |
| mrda | Morning Ironic! | 21:36 |
| rloo | top of the morning to you mrda. | 21:37 |
| Shrews | mrda: morning | 21:37 |
| mrda | \o | 21:39 |
| jroll | heya mrda :) | 21:45 |
| mrda | \o | 21:46 |
| *** max_lobur has joined #openstack-ironic | 21:52 | |
| *** blamar has joined #openstack-ironic | 22:04 | |
| *** Penick has quit IRC | 22:08 | |
| *** eguz has joined #openstack-ironic | 22:09 | |
| *** Penick has joined #openstack-ironic | 22:11 | |
| *** romcheg1 has joined #openstack-ironic | 22:11 | |
| *** eguz has quit IRC | 22:12 | |
| *** eguz has joined #openstack-ironic | 22:12 | |
| *** eghobo has quit IRC | 22:12 | |
| *** romcheg has quit IRC | 22:13 | |
| *** Penick has quit IRC | 22:14 | |
| *** Penick has joined #openstack-ironic | 22:19 | |
| *** romcheg has joined #openstack-ironic | 22:22 | |
| *** romcheg1 has quit IRC | 22:24 | |
| *** krtaylor has quit IRC | 22:32 | |
| *** jgrimm has quit IRC | 22:32 | |
| *** chuckC has quit IRC | 22:32 | |
| *** rwsu has quit IRC | 22:32 | |
| *** mmitchell_ has quit IRC | 22:32 | |
| *** tteggel has quit IRC | 22:32 | |
| *** pleia2 has quit IRC | 22:32 | |
| *** aignatov has quit IRC | 22:32 | |
| *** rch has quit IRC | 22:32 | |
| *** sbadia has quit IRC | 22:32 | |
| *** zigo has quit IRC | 22:32 | |
| *** blamar has quit IRC | 22:32 | |
| *** dkehnx1 has quit IRC | 22:32 | |
| *** sseago has quit IRC | 22:32 | |
| *** pradipta_away has quit IRC | 22:32 | |
| *** davidlenwell has quit IRC | 22:32 | |
| *** hemna_ has quit IRC | 22:33 | |
| *** datajerk has quit IRC | 22:33 | |
| *** annegentle has quit IRC | 22:33 | |
| *** notq has quit IRC | 22:33 | |
| *** pcrews has quit IRC | 22:33 | |
| *** hemna has quit IRC | 22:33 | |
| *** rameshg87_afk has quit IRC | 22:33 | |
| *** sirushti has quit IRC | 22:33 | |
| *** SpamapS has quit IRC | 22:33 | |
| *** steveh has quit IRC | 22:33 | |
| *** proffalken has quit IRC | 22:33 | |
| *** devananda has quit IRC | 22:33 | |
| *** kylestev has quit IRC | 22:33 | |
| *** russell_h has quit IRC | 22:33 | |
| *** matty_dubs|gone has quit IRC | 22:33 | |
| *** pquerna has quit IRC | 22:33 | |
| *** Madasi has quit IRC | 22:33 | |
| *** anteaya has quit IRC | 22:33 | |
| *** zul has quit IRC | 22:33 | |
| *** killer_prince has quit IRC | 22:33 | |
| *** keekz has quit IRC | 22:33 | |
| *** Shrews has quit IRC | 22:33 | |
| *** Ng has quit IRC | 22:33 | |
| *** Hefeweizen has quit IRC | 22:33 | |
| *** mitz_ has quit IRC | 22:33 | |
| *** Penick has quit IRC | 22:33 | |
| *** overlayer has quit IRC | 22:33 | |
| *** harlowja has quit IRC | 22:33 | |
| *** openstackgerrit has quit IRC | 22:33 | |
| *** gilliard_ has quit IRC | 22:33 | |
| *** kevinbenton has quit IRC | 22:33 | |
| *** ekarlso has quit IRC | 22:33 | |
| *** Haomeng has quit IRC | 22:33 | |
| *** boris-42 has quit IRC | 22:33 | |
| *** foexle has quit IRC | 22:33 | |
| *** antonym has quit IRC | 22:33 | |
| *** wendar has quit IRC | 22:33 | |
| *** jroll has quit IRC | 22:33 | |
| *** mrda has quit IRC | 22:33 | |
| *** toabctl has quit IRC | 22:33 | |
| *** d0ugal has quit IRC | 22:33 | |
| *** dhellmann has quit IRC | 22:33 | |
| *** JoshNang has quit IRC | 22:33 | |
| *** romcheg has quit IRC | 22:33 | |
| *** rloo has quit IRC | 22:33 | |
| *** mkerrin has quit IRC | 22:33 | |
| *** NobodyCam has quit IRC | 22:33 | |
| *** GheRivero has quit IRC | 22:33 | |
| *** zer0c00l has quit IRC | 22:33 | |
| *** takadayuiko has quit IRC | 22:33 | |
| *** max_lobur has quit IRC | 22:33 | |
| *** Isotopp has quit IRC | 22:33 | |
| *** aweeks has quit IRC | 22:33 | |
| *** mgagne has quit IRC | 22:33 | |
| *** BadCub_ has quit IRC | 22:33 | |
| *** enikanorov_ has quit IRC | 22:33 | |
| *** lynxman has quit IRC | 22:33 | |
| *** dtantsur has quit IRC | 22:33 | |
| *** agordeev has quit IRC | 22:33 | |
| *** LiveOne has quit IRC | 22:33 | |
| *** comstud has quit IRC | 22:33 | |
| *** Mikhail_D_wk1 has quit IRC | 22:33 | |
| *** stevebaker has quit IRC | 22:33 | |
| *** adam_g has quit IRC | 22:33 | |
| *** dguerri has quit IRC | 22:33 | |
| *** soren has quit IRC | 22:33 | |
| *** mikal has quit IRC | 22:33 | |
| *** tteggel has joined #openstack-ironic | 22:36 | |
| *** sbadia has joined #openstack-ironic | 22:36 | |
| *** rch has joined #openstack-ironic | 22:36 | |
| *** aignatov has joined #openstack-ironic | 22:36 | |
| *** mmitchell_ has joined #openstack-ironic | 22:36 | |
| *** rwsu has joined #openstack-ironic | 22:36 | |
| *** jgrimm has joined #openstack-ironic | 22:36 | |
| *** chuckC has joined #openstack-ironic | 22:36 | |
| *** romcheg has joined #openstack-ironic | 22:36 | |
| *** Penick has joined #openstack-ironic | 22:36 | |
| *** blamar has joined #openstack-ironic | 22:36 | |
| *** max_lobur has joined #openstack-ironic | 22:36 | |
| *** overlayer has joined #openstack-ironic | 22:36 | |
| *** foexle has joined #openstack-ironic | 22:36 | |
| *** pcrews has joined #openstack-ironic | 22:36 | |
| *** Isotopp has joined #openstack-ironic | 22:36 | |
| *** harlowja has joined #openstack-ironic | 22:36 | |
| *** hemna has joined #openstack-ironic | 22:36 | |
| *** openstackgerrit has joined #openstack-ironic | 22:36 | |
| *** dkehnx1 has joined #openstack-ironic | 22:36 | |
| *** gilliard_ has joined #openstack-ironic | 22:36 | |
| *** killer_prince has joined #openstack-ironic | 22:36 | |
| *** rloo has joined #openstack-ironic | 22:36 | |
| *** Haomeng has joined #openstack-ironic | 22:36 | |
| *** zigo has joined #openstack-ironic | 22:36 | |
| *** mkerrin has joined #openstack-ironic | 22:36 | |
| *** rameshg87_afk has joined #openstack-ironic | 22:36 | |
| *** takadayuiko has joined #openstack-ironic | 22:36 | |
| *** sseago has joined #openstack-ironic | 22:36 | |
| *** boris-42 has joined #openstack-ironic | 22:36 | |
| *** pradipta_away has joined #openstack-ironic | 22:36 | |
| *** keekz has joined #openstack-ironic | 22:36 | |
| *** NobodyCam has joined #openstack-ironic | 22:36 | |
| *** anteaya has joined #openstack-ironic | 22:36 | |
| *** sirushti has joined #openstack-ironic | 22:36 | |
| *** SpamapS has joined #openstack-ironic | 22:36 | |
| *** GheRivero has joined #openstack-ironic | 22:36 | |
| *** davidlenwell has joined #openstack-ironic | 22:36 | |
| *** zul has joined #openstack-ironic | 22:36 | |
| *** d0ugal has joined #openstack-ironic | 22:36 | |
| *** Shrews has joined #openstack-ironic | 22:36 | |
| *** steveh has joined #openstack-ironic | 22:36 | |
| *** kevinbenton has joined #openstack-ironic | 22:36 | |
| *** Ng has joined #openstack-ironic | 22:36 | |
| *** zer0c00l has joined #openstack-ironic | 22:36 | |
| *** Hefeweizen has joined #openstack-ironic | 22:36 | |
| *** hemna_ has joined #openstack-ironic | 22:36 | |
| *** datajerk has joined #openstack-ironic | 22:36 | |
| *** antonym has joined #openstack-ironic | 22:36 | |
| *** mgagne has joined #openstack-ironic | 22:36 | |
| *** aweeks has joined #openstack-ironic | 22:36 | |
| *** BadCub_ has joined #openstack-ironic | 22:36 | |
| *** wendar has joined #openstack-ironic | 22:36 | |
| *** mitz_ has joined #openstack-ironic | 22:36 | |
| *** annegentle has joined #openstack-ironic | 22:36 | |
| *** notq has joined #openstack-ironic | 22:36 | |
| *** ekarlso has joined #openstack-ironic | 22:36 | |
| *** enikanorov_ has joined #openstack-ironic | 22:36 | |
| *** jroll has joined #openstack-ironic | 22:36 | |
| *** LiveOne has joined #openstack-ironic | 22:36 | |
| *** lynxman has joined #openstack-ironic | 22:36 | |
| *** dtantsur has joined #openstack-ironic | 22:36 | |
| *** proffalken has joined #openstack-ironic | 22:36 | |
| *** agordeev has joined #openstack-ironic | 22:36 | |
| *** Madasi has joined #openstack-ironic | 22:36 | |
| *** pquerna has joined #openstack-ironic | 22:36 | |
| *** matty_dubs|gone has joined #openstack-ironic | 22:36 | |
| *** russell_h has joined #openstack-ironic | 22:36 | |
| *** kylestev has joined #openstack-ironic | 22:36 | |
| *** devananda has joined #openstack-ironic | 22:36 | |
| *** mrda has joined #openstack-ironic | 22:36 | |
| *** toabctl has joined #openstack-ironic | 22:36 | |
| *** Mikhail_D_wk1 has joined #openstack-ironic | 22:36 | |
| *** comstud has joined #openstack-ironic | 22:36 | |
| *** stevebaker has joined #openstack-ironic | 22:36 | |
| *** adam_g has joined #openstack-ironic | 22:36 | |
| *** dguerri has joined #openstack-ironic | 22:36 | |
| *** soren has joined #openstack-ironic | 22:36 | |
| *** dhellmann has joined #openstack-ironic | 22:36 | |
| *** JoshNang has joined #openstack-ironic | 22:36 | |
| *** mikal has joined #openstack-ironic | 22:36 | |
| *** morgabra has quit IRC | 22:37 | |
| *** morgabra has joined #openstack-ironic | 22:37 | |
| *** pleia2 has joined #openstack-ironic | 22:38 | |
| jroll | rloo: about https://review.openstack.org/#/c/100364 | 22:47 |
| jroll | rloo: I didn't add InvalidParamValue to the docstrings, because those methods don't raise that, validate() does | 22:47 |
| jroll | rloo: and validate is called by vendor_passthru, not by _send_raw_bytes | 22:47 |
| rloo | jroll: that _parse_driver_info or whatever it is, raises it. | 22:51 |
| rloo | jroll: i think. i don't have the code in front of me. | 22:51 |
| jroll | rloo: ffffffff | 22:51 |
| jroll | you're probably right | 22:51 |
| rloo | jroll: I know. fine ;) | 22:51 |
| * jroll cries | 22:52 | |
| rloo | jroll: it isn't like you're losing any +2s. (Ok, that's the bright side.) | 22:52 |
| jroll | no, just another set of rebases | 22:52 |
| rloo | jroll: well, you'd have to rebase anyway then. | 22:52 |
| mrda | rebasing is sooo much fun! | 22:53 |
| rloo | jroll: i can't remember now, but I think if you address my changes, it might be worth a +2 from me. | 22:53 |
| jroll | yeah | 22:53 |
| rloo | jroll: no promises though. | 22:53 |
| NobodyCam | jroll: :( | 22:53 |
| jroll | :P | 22:53 |
| NobodyCam | and I was just looking at 100734 | 22:53 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Add methods to ipmitool driver https://review.openstack.org/100364 | 22:57 |
| jroll | rloo: ^ | 22:57 |
| * rloo looks | 22:58 | |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Factor out TFTPImageCache https://review.openstack.org/100734 | 22:59 |
| rloo | jroll: you just copy/pasted? | 22:59 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Factor out deploy info from PXE driver https://review.openstack.org/100735 | 22:59 |
| jroll | NobodyCam: ^ | 22:59 |
| jroll | oh grrrrrrrr | 22:59 |
| jroll | rloo: sec | 22:59 |
| NobodyCam | lol | 22:59 |
| rloo | jroll: just to let you know, you'll need to do another revision. | 22:59 |
| rloo | jroll: want me to stop looking? | 22:59 |
| jroll | rloo: right | 22:59 |
| jroll | rloo: something else or just that? | 22:59 |
| rloo | the 'invalid boot device' thing is what i'm thinking of. | 23:00 |
| jroll | yeah | 23:00 |
| rloo | jroll: twice. that's it. | 23:00 |
| jroll | wait, I'm wondering if this should be here at all | 23:00 |
| *** Penick has quit IRC | 23:00 | |
| jroll | do we say a method :raises: because a method it calls raises something? | 23:00 |
| jroll | because otherwise, I don't raise anything | 23:01 |
| rloo | jroll: so that's why i mentioned in my comment, that i wasn't sure if it should or should not be mentioned, but that it was mentioned in the _set_boot_device(). | 23:02 |
| jroll | yeah | 23:02 |
| jroll | but that method raises InvalidBlablabla itself | 23:02 |
| *** Penick has joined #openstack-ironic | 23:02 | |
| rloo | jroll: typically, it is the non 'internal' methods where we mention it. | 23:02 |
| rloo | jroll: thinking about it. What's probably missing is a docstring for vendor_passthru(). | 23:02 |
| * devananda runs off to get ready for dinner and an art gallery opening | 23:04 | |
| jroll | that doesn't have a docstring at all... | 23:04 |
| rloo | jroll: yeah, i hope i didn't approve that piece of code w/o a docstring ;) | 23:04 |
| mrda | devananda: don't you mean to prep a CFP submission? :P But have a good night! | 23:05 |
| *** harlowja has quit IRC | 23:05 | |
| rloo | jroll: you're welcome to add a docstring to it or not, i wouldn't ding you either way on that. but I don't know what others might think. | 23:05 |
| *** harlowja has joined #openstack-ironic | 23:05 | |
| jroll | I'm just going to copy the one from VendorInterface | 23:05 |
| jroll | I think | 23:05 |
| jroll | \maybe in a different patch | 23:06 |
| jroll | maybe add a list of supported methods | 23:06 |
| NobodyCam | oh have a good time devananda | 23:07 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Add methods to ipmitool driver https://review.openstack.org/100364 | 23:08 |
| jroll | rloo: ^ | 23:08 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Factor out TFTPImageCache https://review.openstack.org/100734 | 23:10 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Factor out deploy info from PXE driver https://review.openstack.org/100735 | 23:10 |
| jroll | NobodyCam: ^ | 23:10 |
| NobodyCam | :) | 23:10 |
| jroll | thank you both | 23:10 |
| *** romcheg has quit IRC | 23:11 | |
| NobodyCam | lol | 23:11 |
| *** overlayer has quit IRC | 23:12 | |
| NobodyCam | humm how cruel am I today | 23:13 |
| jroll | oh damnit | 23:13 |
| jroll | I just found a bug in the first one | 23:13 |
| jroll | hjkdsfgaigfhlasdf | 23:13 |
| jroll | go ahead and be cruel, NobodyCam, I need to rebase | 23:13 |
| NobodyCam | line 61 of 100735's tftp.py... H403: multi line docstrings should end on a new line | 23:14 |
| jroll | ok, I'll grab it | 23:14 |
| NobodyCam | ( I wouldn't have hit you with it.. but.. | 23:14 |
| NobodyCam | as your pushing up a new one | 23:14 |
| jroll | yeah, it's fine | 23:15 |
| NobodyCam | :0p | 23:15 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Add methods to ipmitool driver https://review.openstack.org/100364 | 23:20 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Add missing docstrings https://review.openstack.org/106202 | 23:20 |
| jroll | ok, this one is good | 23:20 |
| jroll | I sweart | 23:20 |
| jroll | -t | 23:20 |
| jroll | plus added docstring | 23:20 |
| jroll | s | 23:20 |
| JayF | jroll: you need newlines after the end of your shiny new multiline doc strings | 23:21 |
| jroll | no you don't | 23:21 |
| jroll | the trailing """ has to be on its own line | 23:22 |
| JayF | aaah | 23:22 |
| jroll | is what NobodyCam was mentioning | 23:22 |
| jroll | you'll see it failed pep8 ;) | 23:22 |
| JayF | Most of the other ones in the file had a full newline between the last line and the """ | 23:22 |
| jroll | some of them | 23:22 |
| JayF | which is why I mentioned it | 23:22 |
| jroll | idk if there's a standard for that | 23:22 |
| JayF | most == the first two others I saw | 23:22 |
| JayF | lol | 23:22 |
| jroll | :) | 23:22 |
| JayF | IDC if it passes pep8 | 23:22 |
| jroll | well | 23:22 |
| jroll | it won't merge if it dsoesn't, so | 23:22 |
| jroll | doesn't | 23:22 |
| NobodyCam | I dont think we rung the full hacking tests do we? | 23:23 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Factor out TFTPImageCache https://review.openstack.org/100734 | 23:23 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Factor out deploy info from PXE driver https://review.openstack.org/100735 | 23:23 |
| jroll | omg, finally | 23:23 |
| jroll | NobodyCam: just +A all of these | 23:23 |
| jroll | please | 23:23 |
| jroll | I hate them | 23:23 |
| NobodyCam | oh is there a spec | 23:23 |
| * NobodyCam ducks | 23:23 | |
| NobodyCam | :-p | 23:24 |
| JayF | jroll: want a +ay? http://i.imgur.com/yLdMaKE.gif | 23:24 |
| rloo | jroll: you didn't get past 50. NobodyCam has the record I think. | 23:24 |
| jroll | rloo: 84795 | 23:25 |
| jroll | lol | 23:25 |
| NobodyCam | lol 84 I think was mine | 23:25 |
| jroll | this hit 98 before we gave up: https://review.openstack.org/#/c/84795 | 23:25 |
| rloo | jroll: you're REALLY close to 100. go go go! | 23:25 |
| jroll | noooooooo that patch will never land | 23:25 |
| jroll | long live 101020 | 23:26 |
| rloo | jroll: what do you mean, you're abandoning it? | 23:26 |
| JoshNang | "+2561, -36" for changes | 23:26 |
| jroll | rloo: it has all the fancy features... it will never land as one patch | 23:26 |
| jroll | we've been splitting it up | 23:26 |
| jroll | main patch: https://review.openstack.org/#/c/101020 | 23:26 |
| jroll | what's going on: https://etherpad.openstack.org/p/ipa-todos | 23:26 |
| rloo | jroll: ahhh. ok. I see the 'abandoned' now. | 23:27 |
| jroll | :) | 23:27 |
| * rloo is glad she never reviewed 84795 | 23:27 | |
| jroll | JoshNang: can you fix up 81391 sometime in the very near future? | 23:28 |
| JoshNang | jroll: gah yeah | 23:28 |
| jroll | JoshNang: waiting on you before I rebase 101020 any more :) | 23:28 |
| JoshNang | kk | 23:28 |
| NobodyCam | brb gota run to the gas station real quick | 23:30 |
| mrda | rloo: me too (re: 84795) | 23:37 |
| JayF | rloo: we've had that up for four months :x | 23:39 |
| JayF | rloo: (84795) | 23:39 |
| *** faizan has joined #openstack-ironic | 23:41 | |
| faizan | NobodyCam: Hi | 23:44 |
| NobodyCam | hi faizan | 23:45 |
| faizan | NododyCam: Did you get a chance to relook at the uefi design spec - 99850 | 23:45 |
| NobodyCam | I did a quick look and am looking again | 23:49 |
| NobodyCam | how is boot_mode getting set, by admin or by reading the value over ipmi? | 23:50 |
| faizan | NobodyCam: Thanks. | 23:50 |
| faizan | boot_mode is set as a flavor extra_spec property - baremetal:boot_mode='uefi' | 23:51 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/88722 | 23:51 |
| NobodyCam | Ahh I see your note about setting / reading current setting | 23:51 |
| NobodyCam | over ipmi | 23:51 |
| NobodyCam | (ipmitool) | 23:52 |
| NobodyCam | I can say that I do find the *_boot_mode vars some what confusing... boot_mode, next_boot_mode, current_boot_mode, supported_boot_modes, default_..... | 23:54 |
| NobodyCam | I think you may be using boot_mode and current_boot_mode for the same thing, but am not 100% sure | 23:55 |
| faizan | next_boot_mode, current_boot_mode and supported_ boot_modes are part of node-properties and reflect the settings on the actual node. | 23:56 |
| faizan | where as boot_mode is the one which is obtained as part of user request and is part of instance_info field | 23:57 |
| NobodyCam | faizan: so it would be requested_boot_mode? | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
