| *** mkerrin has quit IRC | 00:22 | |
| * NobodyCam head out for dinner | 00:24 | |
| NobodyCam | heads even | 00:25 |
|---|---|---|
| NobodyCam | :-p | 00:25 |
| NobodyCam | Night All | 00:25 |
| *** mkerrin has joined #openstack-ironic | 00:33 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic-python-agent: Adding support for decommissioning https://review.openstack.org/104379 | 00:49 |
| *** mkerrin has quit IRC | 00:58 | |
| openstackgerrit | Ellen Hui proposed a change to openstack/ironic: Make DHCP provider pluggable https://review.openstack.org/112351 | 01:02 |
| *** ellenh has quit IRC | 01:08 | |
| *** mkerrin has joined #openstack-ironic | 01:17 | |
| *** rloo_afk has quit IRC | 01:34 | |
| *** dlaube has quit IRC | 01:34 | |
| *** mkerrin has quit IRC | 01:37 | |
| *** nosnos has joined #openstack-ironic | 01:43 | |
| *** nosnos has quit IRC | 01:45 | |
| *** nosnos has joined #openstack-ironic | 01:45 | |
| *** nosnos has quit IRC | 01:46 | |
| *** nosnos has joined #openstack-ironic | 01:47 | |
| *** mkerrin has joined #openstack-ironic | 01:57 | |
| *** dlaube has joined #openstack-ironic | 02:07 | |
| *** dlaube has quit IRC | 02:11 | |
| *** eguz has joined #openstack-ironic | 02:17 | |
| *** eghobo has quit IRC | 02:18 | |
| *** Poornima has joined #openstack-ironic | 02:21 | |
| *** eghobo has joined #openstack-ironic | 02:29 | |
| *** eguz has quit IRC | 02:33 | |
| *** pcrews has quit IRC | 02:49 | |
| *** ramineni has joined #openstack-ironic | 03:00 | |
| *** vinbs has joined #openstack-ironic | 03:05 | |
| *** jgrimm has joined #openstack-ironic | 03:05 | |
| *** mkerrin has quit IRC | 03:06 | |
| *** nosnos has quit IRC | 03:22 | |
| *** Poornima has quit IRC | 03:31 | |
| *** chenglch has joined #openstack-ironic | 03:33 | |
| *** rwsu has quit IRC | 03:38 | |
| *** mkerrin has joined #openstack-ironic | 03:42 | |
| *** mkerrin has quit IRC | 03:49 | |
| *** mkerrin has joined #openstack-ironic | 03:50 | |
| *** Poornima has joined #openstack-ironic | 03:58 | |
| devananda | mrda: around? | 04:01 |
| *** eghobo has joined #openstack-ironic | 04:03 | |
| *** romcheg1 has joined #openstack-ironic | 04:10 | |
| *** romcheg1 has quit IRC | 04:13 | |
| *** nosnos has joined #openstack-ironic | 04:25 | |
| *** eghobo has quit IRC | 04:29 | |
| *** eghobo has joined #openstack-ironic | 04:35 | |
| *** eghobo has quit IRC | 04:47 | |
| *** eghobo has joined #openstack-ironic | 04:47 | |
| *** bmahalakshmi has joined #openstack-ironic | 04:50 | |
| mrda | hey devananda | 04:54 |
| devananda | mrda: hey there! | 04:57 |
| devananda | mrda: was just about to email you -- this is better | 04:57 |
| mrda | np | 04:57 |
| devananda | mrda: so, short version - this is my last week before FeatureFreeze | 04:57 |
| devananda | mrda: I will be gone 8/18 - 9/3 | 04:57 |
| mrda | and you're going to have a *great* time :) | 04:58 |
| devananda | mrda: we obviously aren't getting a ton of reviews from Nova on the drivers yet. mostly just dansmith (which is great, but we need >1) | 04:58 |
| devananda | mrda: yes. I am. | 04:58 |
| mrda | yeah, so I need to keep it at the top of the list of reviews | 04:58 |
| mrda | which means iterating quickl;y | 04:58 |
| devananda | mrda: so, since you're already tracking the work, and iterating :), please also try to make the nova weekly meetings and occasionally nag people in channel | 04:59 |
| devananda | mrda: there's a couple nova cores who "signed up" for it -- the sponsors. they'd be the best ones to nag | 04:59 |
| mrda | I'll commit to making every second one - I won't do the 12:30am one in addition to the 4:30am ironic. That would be too hard :) | 04:59 |
| devananda | hah! fair :) | 05:00 |
| mrda | so who has "signed up"? | 05:00 |
| mrda | every second nova meeting is a more reasonable time slot | 05:00 |
| devananda | perhaps you can coordinate with lucas to get representation at the one that's a bad time for you | 05:00 |
| mrda | sure, good idea | 05:00 |
| devananda | or shrews - he also has experience in the nova driver code | 05:01 |
| mrda | ok, sounds good. I'll find someone to represent us | 05:01 |
| mrda | So we need to get this landed by J3 | 05:03 |
| mrda | so I'll keep working to that end | 05:03 |
| devananda | right - we have ~3 weeks | 05:04 |
| *** bvivek has joined #openstack-ironic | 05:17 | |
| *** radsy has quit IRC | 05:21 | |
| *** eghobo has quit IRC | 05:31 | |
| *** eghobo has joined #openstack-ironic | 05:31 | |
| *** k4n0 has joined #openstack-ironic | 05:37 | |
| *** bvivek has quit IRC | 05:38 | |
| *** jasondotstar has quit IRC | 05:45 | |
| *** matty_dubs|gone has quit IRC | 05:46 | |
| *** jasondotstar has joined #openstack-ironic | 05:47 | |
| *** matty_dubs|gone has joined #openstack-ironic | 05:47 | |
| *** bvivek has joined #openstack-ironic | 05:53 | |
| *** killer_prince has joined #openstack-ironic | 05:54 | |
| *** dtantsur|afk is now known as dtantsur | 05:54 | |
| dtantsur | Morning Ironic | 05:55 |
| *** lazy_prince has quit IRC | 05:56 | |
| mrda | hey dtantsur | 05:57 |
| *** eguz has joined #openstack-ironic | 05:59 | |
| mrda | hey devananda, just regarding https://review.openstack.org/#/c/113047, this is a new interface we need to support. It's just a hard-coded return true. Are you happy for this to merge and then we push it into the Nova driver? If so, can I get a +A on this? | 06:02 |
| *** matty_dubs|gone has quit IRC | 06:02 | |
| *** jasondotstar has quit IRC | 06:02 | |
| *** eghobo has quit IRC | 06:03 | |
| dtantsur | devananda, btw got this request from https://review.openstack.org/#/c/104222/7/contrib/ironic/ironic/resources/ironic.py: "Currently there is (strangely) no cap on python-ironicclient so I am left in a doubt as versions on different mirrors can be quite outdated, thus it looks like we have to support the earliest version available on PYPI. If you are part of Ironic community could you please investigate the usages of ironicclien | 06:04 |
| dtantsur | t and propose a reasonable minimal version to the openstack/requirements project?" | 06:04 |
| *** eguz has quit IRC | 06:05 | |
| *** jasondotstar has joined #openstack-ironic | 06:06 | |
| *** matty_dubs|gone has joined #openstack-ironic | 06:09 | |
| devananda | mrda: right. sure thing | 06:09 |
| *** sabah has joined #openstack-ironic | 06:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/113075 | 06:10 |
| devananda | dtantsur: wait - why is heat adding resources for Ironic at all? | 06:11 |
| dtantsur | devananda, I'm not sure, I remember reading somewhere that it's for using Ironic w/o Nova | 06:12 |
| dtantsur | devananda, wow you still awake Oo what's the time for you? | 06:12 |
| devananda | dtantsur: teh followign 3 patches add our resource classes -- chassis, node, port | 06:13 |
| devananda | nothing there about Nova. because if you're using Nova, you DONT need to talk to ironic. | 06:13 |
| *** lazy_prif has joined #openstack-ironic | 06:13 | |
| *** lazy_prif is now known as lazy_prince | 06:13 | |
| devananda | dtantsur: eleventy something? | 06:13 |
| dtantsur | devananda, IIRC they want to support Ironic on it's own as well, without touching Nova | 06:14 |
| dtantsur | can't find where I git this information... | 06:14 |
| dtantsur | lol git=got | 06:14 |
| devananda | that doesn't make sense to me | 06:14 |
| mrda | devananda: thanks | 06:14 |
| devananda | I mean, I want OTHER systems, not part of openstack,to support ironic w/o nova | 06:15 |
| devananda | like salt or ansible or chef | 06:15 |
| devananda | but heat? it's part of openstack. so is nova. | 06:15 |
| devananda | why would you use heat w/o nova | 06:15 |
| dtantsur | no idea. after this discussion it also surprises me. I can try to get answer from them | 06:16 |
| dtantsur | devananda, https://blueprints.launchpad.net/heat/+spec/ironic-resource that's all I can find | 06:18 |
| devananda | yea, saw that. no real info | 06:18 |
| dtantsur | don't they follow the spec process? real spec would explain much more... | 06:19 |
| dtantsur | brb | 06:20 |
| *** pradipta_away is now known as pradipta | 06:23 | |
| devananda | yea, they do use specs, but i dont see one for this | 06:26 |
| devananda | http://specs.openstack.org/openstack/heat-specs/ | 06:26 |
| openstackgerrit | A change was merged to openstack/ironic: Add method for deallocating networks on reschedule https://review.openstack.org/113047 | 06:47 |
| *** killer_prince has quit IRC | 07:11 | |
| *** jcoufal has joined #openstack-ironic | 07:20 | |
| *** jistr has joined #openstack-ironic | 07:36 | |
| openstackgerrit | Ghe Rivero proposed a change to openstack/ironic: Raise MissingParameterValue instead of Invalid https://review.openstack.org/108455 | 07:41 |
| mrda | night all | 07:49 |
| *** mrda is now known as mrda-away | 07:49 | |
| *** Krast has joined #openstack-ironic | 07:55 | |
| *** Krast has quit IRC | 08:02 | |
| *** lazy_prince has quit IRC | 08:06 | |
| *** Krast has joined #openstack-ironic | 08:06 | |
| *** derekh has joined #openstack-ironic | 08:15 | |
| *** ndipanov_gone is now known as ndipanov | 08:20 | |
| *** lucasagomes has joined #openstack-ironic | 08:20 | |
| *** foexle has joined #openstack-ironic | 08:36 | |
| *** Krast has quit IRC | 08:40 | |
| *** Krast has joined #openstack-ironic | 08:40 | |
| *** dtantsur is now known as dtantsur|lunch | 08:45 | |
| *** pradipta is now known as pradipta_away | 08:51 | |
| *** MattMan has joined #openstack-ironic | 09:01 | |
| *** mkerrin has quit IRC | 09:07 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Show port by MAC address https://review.openstack.org/113252 | 09:12 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/python-ironicclient: Optimize get_by_instance_uuid https://review.openstack.org/113469 | 09:26 |
| *** rameshg87 has joined #openstack-ironic | 09:33 | |
| *** pelix has joined #openstack-ironic | 09:38 | |
| *** victor_lowther has quit IRC | 09:48 | |
| *** Ng has quit IRC | 09:49 | |
| openstackgerrit | A change was merged to openstack/ironic: Make swift tempurl key secret https://review.openstack.org/113390 | 09:50 |
| *** LiveOne has quit IRC | 09:50 | |
| *** aweeks has quit IRC | 09:51 | |
| *** aweeks has joined #openstack-ironic | 09:55 | |
| *** LiveOne_ has joined #openstack-ironic | 09:58 | |
| *** victor_lowther has joined #openstack-ironic | 09:59 | |
| *** Ng has joined #openstack-ironic | 10:00 | |
| *** vinbs has quit IRC | 10:02 | |
| *** mkerrin has joined #openstack-ironic | 10:11 | |
| *** chenglch has quit IRC | 10:39 | |
| *** Krast has quit IRC | 10:50 | |
| *** sabah has quit IRC | 10:50 | |
| *** ramineni has quit IRC | 10:57 | |
| *** vinbs has joined #openstack-ironic | 11:04 | |
| *** rameshg87 has quit IRC | 11:12 | |
| *** jasondotstar has quit IRC | 11:18 | |
| *** rameshg87 has joined #openstack-ironic | 11:20 | |
| *** Poornima has quit IRC | 11:31 | |
| openstackgerrit | Rakesh H S proposed a change to openstack/ironic: ipmi double bridging functionality https://review.openstack.org/95775 | 11:39 |
| openstackgerrit | Rakesh H S proposed a change to openstack/ironic: Raise MissingParameterValue instead of Invalid https://review.openstack.org/108455 | 11:39 |
| *** dtantsur|lunch is now known as dtantsur | 11:44 | |
| openstackgerrit | Ghe Rivero proposed a change to openstack/ironic: Raise MissingParameterValue when validating glance info https://review.openstack.org/108456 | 11:50 |
| *** aswadr has joined #openstack-ironic | 11:50 | |
| *** rameshg87 has quit IRC | 11:52 | |
| *** killer_prince has joined #openstack-ironic | 12:00 | |
| *** killer_prince is now known as lazy_prince | 12:00 | |
| *** vinbs has quit IRC | 12:01 | |
| *** lucasagomes is now known as lucas-hungry | 12:05 | |
| Zerpex | Hi people - when I try to restart the nova-scheduler I get the error http://snaps.lucasrolff.com/fig654krot4ntgt.png after I enabled ironic (I use RDO and installed ironic afterwards) | 12:14 |
| dtantsur | Zerpex, hi! If you're using Icehouse Nova with Juno Ironic it's unlikely to work | 12:24 |
| Zerpex | dtantsur: I just used the ironic that was in git for a few weeks back | 12:25 |
| dtantsur | Zerpex, the problem is: Ironic contains the Nova driver which depends on Nova private interfaces. Until we merge driver into Nova (likely to happen in Juno), you should use the same version of Nova and Ironic | 12:26 |
| dtantsur | Zerpex, internal interfaces are not backward-compatible | 12:26 |
| Zerpex | how easy is it to downgrade the ironic thingy then? | 12:26 |
| dtantsur | Zerpex, it should be possible to just install ironic Icehouse release. I'm not sure we did something critical to database. But! Note that Ironic got a lot of important features and fixes during J cycle | 12:28 |
| dtantsur | Zerpex, you may want to ask jroll and JayF how they solve this problem for them :) | 12:29 |
| Zerpex | The only thing I've been trying for for 1 week+ is to get a POC of 1 machine getting installed :( | 12:29 |
| *** lazy_prince is now known as killer_prince | 12:51 | |
| *** k4n0 has quit IRC | 12:53 | |
| *** jistr has quit IRC | 12:56 | |
| *** jistr has joined #openstack-ironic | 12:57 | |
| Shrews | morning all | 12:58 |
| *** jcoufal has quit IRC | 13:00 | |
| *** gentlesaurus is now known as annegentle | 13:02 | |
| *** andreykurilin has left #openstack-ironic | 13:03 | |
| *** jcoufal has joined #openstack-ironic | 13:03 | |
| dtantsur | Shrews, morning | 13:05 |
| *** nosnos has quit IRC | 13:13 | |
| *** matty_dubs|gone is now known as matty_dubs | 13:15 | |
| jroll | Zerpex, dtantsur, the "easy" answer is, we run as close to master as we can... the more realistic answer is pull in upstream changes as necessary | 13:23 |
| jroll | :| | 13:23 |
| jroll | good morning ironic :) | 13:23 |
| *** lucas-hungry is now known as lucasagomes | 13:23 | |
| dtantsur | jroll, morning | 13:23 |
| lucasagomes | morning jroll Shrews | 13:23 |
| *** pcrews has joined #openstack-ironic | 13:25 | |
| *** rloo has joined #openstack-ironic | 13:27 | |
| jroll | lucasagomes, devananda, revisit this when you have a chance? tests are passing etc now :) https://review.openstack.org/#/c/105590/ | 13:30 |
| lucasagomes | jroll, will do | 13:30 |
| jroll | ty! | 13:30 |
| *** bmahalakshmi has quit IRC | 13:31 | |
| lucasagomes | jroll, this was the client patch right? to strip the v1/ from the url etc | 13:31 |
| lucasagomes | ? | 13:31 |
| jroll | lucasagomes: yeah | 13:32 |
| lucasagomes | jroll, so, I think we should pin the version of the client | 13:32 |
| jroll | lucasagomes: well, that patch landed, this is the one based on that bug | 13:32 |
| lucasagomes | because that wouldn't work with old versions | 13:32 |
| jroll | yeah was wondering that | 13:32 |
| jroll | want that in the same patch or separate? | 13:32 |
| lucasagomes | jroll, you can do in the same patch, no problem | 13:32 |
| *** jasondotstar has joined #openstack-ironic | 13:32 | |
| jroll | k, one sec | 13:32 |
| lucasagomes | but, it needs to go to global requirements I think no? | 13:32 |
| jroll | oh god | 13:32 |
| jroll | yeah | 13:33 |
| lucasagomes | :( | 13:33 |
| jroll | ok, give me a couple hours then | 13:33 |
| jroll | :P | 13:33 |
| lucasagomes | I know it bureaucratic, but otherwise things may start failing because we say it works with all version of client when it doesn't | 13:33 |
| lucasagomes | so it's bad form | 13:33 |
| lucasagomes | jroll, other than that, it lgtm! | 13:33 |
| jroll | lucasagomes: hmm, it's not in our requirements.txt :P | 13:35 |
| jroll | oh because it's a nova thing | 13:35 |
| lucasagomes | jroll, ouch... yeah it should go to nova | 13:35 |
| lucasagomes | alright, let's keep in mind that then and add to nova | 13:35 |
| jroll | well | 13:35 |
| jroll | I think the plan was not to put it in nova's requirements | 13:36 |
| jroll | I know we've been using try_import etc | 13:36 |
| jroll | mrda-away devananda ^^ ? | 13:36 |
| lucasagomes | oh true | 13:36 |
| lucasagomes | >.<... maybe we should check the version if we detect it's installed | 13:36 |
| jroll | :| | 13:36 |
| jroll | probably | 13:36 |
| lucasagomes | jroll, do you think a bug would be good to track that ^ ? | 13:36 |
| jroll | likely | 13:37 |
| jroll | let me make sure we're not doing that already | 13:37 |
| jroll | ok, yeah, I'll file a bug | 13:38 |
| lucasagomes | ack, jroll thanks! | 13:38 |
| jroll | https://bugs.launchpad.net/ironic/+bug/1355820 | 13:39 |
| jroll | no problem :) | 13:39 |
| jroll | mrda-away devananda: https://bugs.launchpad.net/ironic/+bug/1355820 is a thing :/ | 13:39 |
| *** reaper has joined #openstack-ironic | 13:40 | |
| *** reaper has quit IRC | 13:41 | |
| lucasagomes | jroll, thanks for that, changed my vote on that review | 13:41 |
| *** rameshg87 has joined #openstack-ironic | 13:41 | |
| jroll | you're welcome sir | 13:41 |
| openstackgerrit | Ramakrishnan G proposed a change to openstack/ironic: Move code to cleanup ImageCache to a common place https://review.openstack.org/110560 | 13:45 |
| *** jistr has quit IRC | 13:49 | |
| *** jistr has joined #openstack-ironic | 13:50 | |
| rameshg87 | dtantsur, hi | 14:08 |
| dtantsur | rameshg87, hi! | 14:08 |
| rameshg87 | dtantsur, regarding https://review.openstack.org/#/c/110568/, i thought it was part of process to begin features with a zero line initial commit | 14:09 |
| rameshg87 | dtantsur, so that first commit can be approved in the end to approve the entire feature. isn't it so ? | 14:09 |
| jroll | I do like that for long chains | 14:10 |
| dtantsur | rameshg87, I've never heard about such process | 14:10 |
| dtantsur | rameshg87, my problem is that following patches are not actually based on it | 14:10 |
| jroll | I don't think it's an official process | 14:10 |
| NobodyCam | good morning Ironic | 14:10 |
| dtantsur | NobodyCam, morning | 14:10 |
| rameshg87 | jroll, dtantsur, i have 3 patches following it. not a long chain :-) | 14:10 |
| jroll | but if you want the whole chain to land in one go, it's a good way to do it | 14:10 |
| *** jasondotstar has quit IRC | 14:10 | |
| jroll | rameshg87: long enough for me :P | 14:10 |
| jroll | morning NobodyCam! :) | 14:10 |
| rameshg87 | jroll, :-) | 14:11 |
| openstackgerrit | A change was merged to openstack/ironic: Use auth_token from keystonemiddleware https://review.openstack.org/107197 | 14:11 |
| rameshg87 | dtantsur, i just didn't post any following patches after that. i am planning to base the 3 patches on that "initial commit" patch | 14:11 |
| dtantsur | rameshg87, jroll: will be resonable if all the chain touched the same file. actually the empty patch not is the only patch touching this file - that's why I object | 14:11 |
| dtantsur | rameshg87, well, to me every patch must add specific value to the code base | 14:12 |
| dtantsur | anyway, I can revoke my -1, if that's how you want it to land | 14:12 |
| rameshg87 | dtantsur, agree. i won't break anything if 1 and 2 goes in and 3 doesn't go in soon. | 14:12 |
| NobodyCam | morning dtantsur jroll rameshg87 | 14:13 |
| rameshg87 | NobodyCam, good morning :) | 14:13 |
| dtantsur | rameshg87, yes, these 2 patches may be landed earlier | 14:13 |
| rameshg87 | dtantsur, i want the patches to land as soon as possilble | 14:13 |
| rameshg87 | dtantsur, :-) | 14:13 |
| jroll | hmmm | 14:13 |
| jroll | rameshg87: why is there an empty deploy.py at all? :/ | 14:14 |
| dtantsur | that was my question :) | 14:14 |
| rameshg87 | jroll, the 3rd patch will contain the contents of deploy.py, not 1 and 2 | 14:14 |
| jroll | yeah | 14:14 |
| jroll | I assumed code would be there | 14:14 |
| jroll | ah | 14:14 |
| rameshg87 | jroll, i just wanted some artifact in git to record it as a commit. that's why i chose empty deploy.py | 14:14 |
| jroll | I mean, if you want everything to land at the same time, this is fine... I might go without, myself | 14:14 |
| *** jistr has quit IRC | 14:14 | |
| jroll | rameshg87: right, it's just weird without the rest of the code there :P | 14:15 |
| *** jasondotstar has joined #openstack-ironic | 14:15 | |
| rameshg87 | jroll, dtantsur, i can take off that commit. i mistook it was a process to do so from now on. | 14:15 |
| *** jistr has joined #openstack-ironic | 14:15 | |
| jroll | it's not, it can help but there's nothing official about it | 14:16 |
| rameshg87 | jroll, okay. i better take out it doesn't make sense and would super-like if 1 and 2 goes in before 3, instead of 1 and 2 have to wait for 3 :) | 14:17 |
| jroll | ++ | 14:17 |
| jroll | agree | 14:17 |
| jroll | good catch dtantsur :P | 14:17 |
| rameshg87 | jroll, dtantsur, thanks | 14:17 |
| jroll | dtantsur: want another +A in your stats? :) https://review.openstack.org/#/c/105590/ | 14:19 |
| jroll | oh wait that's nova | 14:19 |
| jroll | ignore me, deva should approve that | 14:19 |
| dtantsur | yeah | 14:20 |
| *** jistr has quit IRC | 14:21 | |
| *** jistr has joined #openstack-ironic | 14:21 | |
| *** rameshg87 has quit IRC | 14:31 | |
| *** rameshg87 has joined #openstack-ironic | 14:31 | |
| rameshg87 | dtantsur, just need a little bit of time more if you are free. for the comment on https://review.openstack.org/#/c/111232/6/ironic/drivers/modules/iscsi_deploy.py | 14:33 |
| dtantsur | rameshg87, I'll be on call very soon, but free right now | 14:34 |
| rameshg87 | dtantsur, won't it be enough if module import iscsi_deploy import those opts (like ilo deploy module importing the opts) ? we could document that in iscsi_deploy. i thought it was okay as it was only a temporary adjustment | 14:35 |
| rameshg87 | dtantsur, those opts anyway don't belong to pxe :-) | 14:35 |
| rameshg87 | jroll, you also had some thoughts about it yesterday ^^^ | 14:35 |
| dtantsur | rameshg87, as a workaround you can import `pxe` from `iscsi_utils` (with #noqa) | 14:36 |
| rameshg87 | dtantsur, "#noqa" ? what does that mean ? | 14:36 |
| jroll | mmmmmm | 14:37 |
| *** linggao has joined #openstack-ironic | 14:37 | |
| jroll | hate circular imports | 14:37 |
| dtantsur | rameshg87, it asks flake8 not to complain about unused import | 14:39 |
| jroll | rameshg87: #noqa means pep8 won't look at it, but idk how that will help | 14:39 |
| jroll | oh | 14:39 |
| dtantsur | rameshg87, should be placed in the end of the line | 14:39 |
| jroll | dtantsur: that would be a circular import, though :/ | 14:39 |
| dtantsur | jroll, circular import is a problem only when top-pevel code in both modules use each other. iscsi_deploy won't actually use pxe | 14:40 |
| jroll | it will import it though | 14:40 |
| jroll | which will import iscsi_deploy | 14:40 |
| jroll | which will import pxe | 14:40 |
| jroll | which will import iscsi_deploy | 14:40 |
| jroll | etc | 14:40 |
| dtantsur | jroll, no, that is not C++ | 14:41 |
| dtantsur | :) | 14:41 |
| jroll | what | 14:41 |
| dtantsur | IIRC | 14:41 |
| jroll | you would have to do one of the imports inside a function | 14:41 |
| dtantsur | import won;t happen the 2nd time | 14:41 |
| jroll | or something | 14:41 |
| jroll | right, because python will raise an exception :P | 14:41 |
| jroll | I might be wrong, but | 14:41 |
| jroll | fairly certain | 14:41 |
| devananda | morning, all | 14:41 |
| jroll | anyway, "Is this required as it is guaranteed that pxe config options will be imported as iscsi_deploy is imported in pxe.py ?" | 14:42 |
| jroll | it might be ok | 14:42 |
| jroll | morning devananda :) | 14:42 |
| * jroll throws reviews at devananda right away | 14:42 | |
| dtantsur | jroll, you can check with 2 files importing each other - it works :) | 14:42 |
| dtantsur | devananda, morning | 14:42 |
| rloo | morning devananda! | 14:43 |
| *** rameshg87 has quit IRC | 14:43 | |
| jroll | huh. | 14:43 |
| NobodyCam | good morning devananda | 14:43 |
| NobodyCam | mornign rloo | 14:43 |
| NobodyCam | morning even | 14:43 |
| devananda | jroll: min version of client proposed : https://review.openstack.org/113542 | 14:43 |
| rloo | Mornin' NobodyCam. No worries, I understood you :-) | 14:43 |
| NobodyCam | :) | 14:44 |
| jroll | devananda: do we not want 0.2.1? | 14:44 |
| jroll | as we have bug fixes relying on that? | 14:44 |
| devananda | jroll: also, why should the virt driver set that? | 14:44 |
| jroll | devananda: there is code in the virt driver that depends on a particular version of ironicclient | 14:44 |
| jroll | devananda: and no requirements.txt specifies that version | 14:44 |
| devananda | right | 14:45 |
| devananda | which is dumb, but nova doesn't want the dependency in requirements.txt | 14:45 |
| jroll | right | 14:45 |
| devananda | they want it in test-requirements.txt | 14:45 |
| jroll | and I agree that is dumb, but | 14:45 |
| devananda | so we can still set it there | 14:45 |
| jroll | still need to check it | 14:45 |
| jroll | so our deploy docs are going to say `pip install -r nova/test-requirements.txt`? :/ | 14:45 |
| devananda | no | 14:46 |
| devananda | ok, i see that libvirt has a bunch of versioning bits | 14:46 |
| devananda | ugh | 14:46 |
| devananda | min_version_for_this_feature | 14:46 |
| devananda | etc | 14:46 |
| jroll | oh god | 14:46 |
| devananda | right? | 14:47 |
| jroll | idk about all that | 14:47 |
| jroll | just... min_version_for_this_driver | 14:47 |
| devananda | so what I don't want is to have to bump the global requrements min_version for pythonironicclient every time we patch it | 14:47 |
| devananda | if there's a critical fix or non-backwards-compat change -- yes, of course | 14:48 |
| devananda | even major and minor release points | 14:48 |
| jroll | yeah, that's fair | 14:48 |
| devananda | which is why i did 0.2.0 | 14:49 |
| jroll | hmm | 14:49 |
| jroll | and then you're going to land changes that require 0.2.1? | 14:49 |
| devananda | but -- you're right. /nodes/detail is a pretty important thing | 14:49 |
| jroll | yeah, agree | 14:50 |
| jroll | so there's three nova driver patches I have here: https://review.openstack.org/105590 https://review.openstack.org/108545 and https://review.openstack.org/113036 | 14:51 |
| jroll | oh wait, one has comments | 14:51 |
| devananda | re-proposed to 0.2.1 | 14:52 |
| jroll | cool | 14:52 |
| jroll | lucasagomes: thanks for comments on 108545, will address sometime this morning | 14:53 |
| lucasagomes | jroll, np | 14:55 |
| devananda | jroll: mrda-away is going to poke you with sharp sticks | 14:55 |
| jroll | I know :| | 14:57 |
| NobodyCam | morning lucasagomes | 14:57 |
| lucasagomes | NobodyCam, morning | 14:57 |
| lucasagomes | devananda, morning | 14:58 |
| devananda | jroll: https://review.openstack.org/#/c/108545/2/ironic/nova/virt/ironic/driver.py is also a fairly fundamental change -- are you guys running this already, or do we need to test it? | 14:58 |
| devananda | s/fundamental/hard to debug if something goes wrong/ | 14:59 |
| devananda | (i haven't had coffee yet) | 14:59 |
| * NobodyCam offers deva some coffee | 14:59 | |
| jroll | devananda: yeah, cherry-picked that from our downstream repo | 14:59 |
| devananda | k | 15:01 |
| devananda | jroll: so, merging https://review.openstack.org/#/c/105590/ into the nova driver patchset will mean wiping out two +2's on a patch | 15:06 |
| devananda | jroll: this is why we CAN'T keep doing this :( | 15:06 |
| jroll | devananda: ouch... | 15:07 |
| devananda | it's really hard to get nova cores to review things -- you think we've got a lot of review backlog ... | 15:07 |
| jroll | devananda: I can just like wait until it's in nova | 15:07 |
| jroll | idk, that's not a great solution but I understand | 15:07 |
| jroll | we can't just stop writing code either :( | 15:07 |
| devananda | sure | 15:07 |
| NobodyCam | would a dependent patch work? | 15:08 |
| devananda | yes | 15:08 |
| jroll | wait | 15:08 |
| devananda | NobodyCam: but that's what jroll already said (I can just like wait until it's in nova) | 15:09 |
| jroll | why would that wipe out +2's? which patch has two +2's beside the first one | 15:09 |
| devananda | jroll: the first one adds that section of client_wrapper.py | 15:09 |
| jroll | oh, was looking at the wrong file | 15:09 |
| jroll | yeah | 15:09 |
| * jroll flips tables and things | 15:10 | |
| devananda | jroll: y'know what'd help? getting nova cores to review our code | 15:11 |
| jroll | how do I do such a thing? :P | 15:11 |
| devananda | jroll: like comstud. I think he's a nova core | 15:11 |
| * jroll drives to comstud's house | 15:11 | |
| devananda | :) | 15:12 |
| jroll | I think he's like... staying away from +2'ing these | 15:12 |
| jroll | but yeah, +1 from him would still help | 15:12 |
| devananda | that's a shame. I think the nova team is expecting him to review them. but IMBW | 15:12 |
| jroll | hmm | 15:12 |
| jroll | imbw | 15:13 |
| * jroll will poke | 15:13 | |
| *** todd_dsm has joined #openstack-ironic | 15:13 | |
| jroll | man, we're getting absolutely nowhere with these reviews :( | 15:14 |
| *** rameshg87 has joined #openstack-ironic | 15:14 | |
| devananda | i know | 15:15 |
| devananda | jroll: you're welcome to try to wrangle a nova core or two into reviewing them. just be polite, please. | 15:17 |
| jroll | heh | 15:18 |
| Shrews | jroll: if that doesn't work, flip *their* tables! | 15:18 |
| devananda | lol | 15:18 |
| * Shrews cleans up jroll's mess in #ironic | 15:18 | |
| devananda | mornin, Shrews | 15:18 |
| jroll | when I said "tables and things" I meant "tables and nova cores" | 15:18 |
| jroll | :P | 15:18 |
| NobodyCam | morning Shrews :-p | 15:18 |
| devananda | lucasagomes: since you did a bunch of work on the patcher.py module recently, you may want to see dan's comment: https://review.openstack.org/#/c/111423/4/nova/virt/ironic/patcher.py | 15:19 |
| * jroll will bbl | 15:19 | |
| lucasagomes | devananda, will take a look (in a call now) | 15:19 |
| *** foexle has quit IRC | 15:20 | |
| jroll | devananda: actually, about https://review.openstack.org/#/c/105590/3/ironic/nova/virt/ironic/client_wrapper.py | 15:21 |
| jroll | I think it's fine to land... shouldn't be hard to get the +2's back | 15:22 |
| jroll | especially if we're landing everything in one shot, you have until everything is approved to get that back | 15:22 |
| Shrews | devananda: cross your fingers but *might* get the rebuild test landed today (at least get mtreinish's +2 on it) | 15:25 |
| devananda | >_< | 15:25 |
| devananda | wait, you said fingers | 15:25 |
| jroll | dude, devstack cores need to come home :( | 15:25 |
| Shrews | #BringBackOurDevstackCores | 15:26 |
| jroll | lol | 15:26 |
| lucasagomes | devananda, oh, sure I will prepare a patch to add/modify those tests | 15:27 |
| *** dlaube has joined #openstack-ironic | 15:29 | |
| *** todd_dsm has quit IRC | 15:32 | |
| *** todd_dsm has joined #openstack-ironic | 15:33 | |
| *** rwsu has joined #openstack-ironic | 15:35 | |
| *** dtantsur is now known as dtantsur|afk | 15:40 | |
| *** Mikhail_D_ltp has joined #openstack-ironic | 15:50 | |
| comstud | devananda: orly | 15:51 |
| comstud | i'll take a look today | 15:52 |
| comstud | it's kinda sketchy for me as i'm listed as co-author :) | 15:52 |
| lucasagomes | jroll, https://review.openstack.org/#/c/99677/ I've put a new version, when you have a time and want to try it out | 15:52 |
| comstud | (i don't think it's that big of a deal.) | 15:52 |
| lucasagomes | jroll, I looked at how keystone does with the apache, and they have that disable_apache_site on the stop_keystop and not cleanup_keystone | 15:53 |
| lucasagomes | so I moved the ironic as well | 15:53 |
| *** eghobo has joined #openstack-ironic | 15:56 | |
| *** jcoufal has quit IRC | 16:00 | |
| *** bvivek has quit IRC | 16:05 | |
| *** rameshg87 has quit IRC | 16:07 | |
| *** matty_dubs is now known as matty_dubs|lunch | 16:08 | |
| *** ellenh has joined #openstack-ironic | 16:15 | |
| *** vinbs has joined #openstack-ironic | 16:23 | |
| *** jistr has quit IRC | 16:25 | |
| *** vinbs has quit IRC | 16:39 | |
| *** derekh has quit IRC | 16:41 | |
| *** ndipanov is now known as ndipanov_gone | 16:59 | |
| *** matty_dubs|lunch is now known as matty_dubs | 17:06 | |
| *** krtaylor has quit IRC | 17:15 | |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/113589 | 17:15 |
| lucasagomes | devananda, ^ I think it's all covered now | 17:15 |
| devananda | awesome, thanks! | 17:16 |
| *** igordcard has joined #openstack-ironic | 17:21 | |
| lucasagomes | aight, going to call it a day | 17:22 |
| lucasagomes | have a great night everybody! | 17:22 |
| *** lucasagomes is now known as lucas-dinner | 17:22 | |
| jroll | night lucas | 17:25 |
| devananda | any cores want to give https://review.openstack.org/#/c/113589/ a check? | 17:31 |
| devananda | I'm merging it into the nova patches now | 17:31 |
| devananda | and then stepping AFK for a few hours | 17:32 |
| NobodyCam | :) | 17:32 |
| NobodyCam | devananda: just updates to tests | 17:32 |
| devananda | yep | 17:32 |
| NobodyCam | devananda: can preserve have another value then True/False? | 17:35 |
| devananda | None | 17:35 |
| NobodyCam | ahh | 17:35 |
| *** dwalleck has joined #openstack-ironic | 17:36 | |
| NobodyCam | devananda: +2'd but not +a'd | 17:38 |
| *** dwalleck has quit IRC | 17:49 | |
| *** bmahalakshmi has joined #openstack-ironic | 17:53 | |
| devananda | +A'd and merged to our driver proposal | 17:55 |
| *** dwalleck has joined #openstack-ironic | 18:05 | |
| *** penick has joined #openstack-ironic | 18:10 | |
| *** penick has quit IRC | 18:10 | |
| *** penick has joined #openstack-ironic | 18:10 | |
| *** eguz has joined #openstack-ironic | 18:14 | |
| devananda | bbiafh | 18:17 |
| *** eghobo has quit IRC | 18:17 | |
| *** eguz has quit IRC | 18:19 | |
| *** krtaylor has joined #openstack-ironic | 18:19 | |
| NobodyCam | ok enjoy | 18:21 |
| NobodyCam | I have to run to the cornor store real quick | 18:22 |
| *** pelix has quit IRC | 18:25 | |
| openstackgerrit | A change was merged to openstack/python-ironicclient: Show port by MAC address https://review.openstack.org/113252 | 18:29 |
| * NobodyCam is back | 18:35 | |
| *** ellenh has quit IRC | 18:42 | |
| *** penick has quit IRC | 19:00 | |
| *** igordcard has quit IRC | 19:06 | |
| * Shrews hates spending most of his day tracking down gate bugs | 19:23 | |
| *** aswadr has quit IRC | 19:32 | |
| NobodyCam | :( | 19:35 |
| *** dwalleck has quit IRC | 19:35 | |
| *** todd_dsm has quit IRC | 19:36 | |
| *** tatyana has joined #openstack-ironic | 19:49 | |
| *** ellenh has joined #openstack-ironic | 19:49 | |
| *** dwalleck has joined #openstack-ironic | 19:53 | |
| devananda | Shrews: welcome to openstack, where any problem is your problem (tm) | 19:55 |
| NobodyCam | :-p | 19:56 |
| *** bmahalakshmi has quit IRC | 19:57 | |
| * rloo thought that any problems were PTL problems | 20:02 | |
| *** dwalleck has quit IRC | 20:09 | |
| linggao | Hi devananda, is there a way to show where the ironic services are. (like nova service-list)? | 20:10 |
| linggao | I'd like find out how many ironic-conductors are and what hosts they are on. | 20:11 |
| NobodyCam | linggao: I think youd need to check the hartbeat table | 20:11 |
| NobodyCam | but ya I could see a conductor-list command | 20:12 |
| *** dwalleck has joined #openstack-ironic | 20:12 | |
| linggao | NobodyCam, you mean there is a heartbeat table in ironic db? | 20:12 |
| *** dwalleck has quit IRC | 20:13 | |
| linggao | "ironic driver-list" shows sothing like this: | 20:14 |
| linggao | +----------------+-------------------------------------------+ | 20:14 |
| linggao | | name | hosts | | 20:14 |
| linggao | +----------------+-------------------------------------------+ | 20:14 |
| linggao | | fake | virt06-234.pok.stglabs.ibm.com, localhost | | 20:14 |
| linggao | | pxe_ipminative | virt06-234.pok.stglabs.ibm.com, localhost | | 20:14 |
| linggao | | pxe_ipmitool | virt06-234.pok.stglabs.ibm.com, localhost | | 20:14 |
| linggao | | pxe_ssh | virt06-234.pok.stglabs.ibm.com, localhost | | 20:14 |
| linggao | | pxe_xcat | virt06-234.pok.stglabs.ibm.com | | 20:14 |
| linggao | +----------------+-------------------------------------------+ | 20:14 |
| linggao | maybe this is an idication that there are 2 conductors running. | 20:15 |
| JayF | oh absolutely driver-list lists all the drivers and conductors that support them | 20:16 |
| linggao | JayF, true. | 20:17 |
| linggao | With multi conductors, is there a concept of 'host' for each node registration? Or all the conductors share the same set of nodes. | 20:20 |
| jroll | yes, you can use driver-list | 20:23 |
| jroll | each conductor manages n nodes | 20:24 |
| jroll | where n = (number of nodes) / (number of conductors) | 20:24 |
| jroll | theoretically if a conductor starts or stops, it will rebalance that | 20:24 |
| jroll | in reality... questionable | 20:24 |
| linggao | :-) | 20:25 |
| linggao | thanks jroll | 20:25 |
| jroll | you're welcome | 20:26 |
| openstackgerrit | A change was merged to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/113075 | 20:30 |
| linggao | jroll, have you tried multi conductors? | 20:32 |
| linggao | and JayF. | 20:32 |
| jroll | linggao: yeah, we run 4 conductors in production | 20:32 |
| jroll | it seems to work fine | 20:32 |
| linggao | how does dhcp work? | 20:33 |
| JayF | With IPA driver <-- | 20:33 |
| JayF | and we do not run the Ironic DHCP configuration | 20:33 |
| jroll | ah yeah | 20:33 |
| linggao | do you have dnsmasq on wach conductor hsot? | 20:33 |
| JayF | We essentially noop all the dhcp calls and run a central dhcp server | 20:33 |
| linggao | wach -> each | 20:34 |
| linggao | are you using dnsmasq for dhcp? | 20:35 |
| jroll | no | 20:35 |
| linggao | dhcpd? | 20:35 |
| jroll | we're using isc-dhcp or whatever it's called | 20:35 |
| jroll | we use a static configuration | 20:36 |
| jroll | yeah | 20:36 |
| linggao | i'll see how dnsmaq works with multiple conductors. | 20:37 |
| openstackgerrit | A change was merged to openstack/ironic: Import fixes from the Nova driver reviews https://review.openstack.org/113589 | 20:38 |
| jroll | linggao: I'm fairly certain in "real ironic", dnsmasq runs on the neutron server | 20:38 |
| jroll | and when a conductor changes dhcp configs, the conductor IP is part of that | 20:39 |
| jroll | so the node knows which conductor to look at | 20:39 |
| jroll | if a conductor crashes while a node is getting ready to pxe boot, you may have problems | 20:39 |
| jroll | but I think takeover works in that case | 20:39 |
| linggao | jroll. I'll give it a try. | 20:40 |
| jroll | ok :) | 20:40 |
| ellenh | hey all, do i have to do anything special to make tox run newly-added unit test files? | 20:45 |
| ellenh | my tests seem to be passing, which is suspect because i have a few assert(False) in there... | 20:45 |
| rloo | ellen, by newly-added, did you add them to an existing test class? if so, you shouldn't have to do anything. but you can see the output/report, to see if the test is being run. | 20:46 |
| jroll | ellenh: there's some pattern that the test tools look for, what's your files/classes look like? | 20:46 |
| jroll | (the names, that is) | 20:47 |
| ellenh | I added a new file tests/dhcp/test_factory.py, which has class TestDHCPFactory | 20:48 |
| jroll | huh, that sounds reasonable... does tests/dhcp/__init__.py exist? | 20:48 |
| ellenh | uhhh no. | 20:48 |
| jroll | likely suspect :) | 20:49 |
| ellenh | yep, fixing. thanks! | 20:49 |
| jroll | np! | 20:49 |
| NobodyCam | :) brb | 20:49 |
| *** linggao has quit IRC | 20:52 | |
| *** tatyana has quit IRC | 20:58 | |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Add Node decommission interfaces https://review.openstack.org/102953 | 21:02 |
| *** jasondotstar has quit IRC | 21:06 | |
| *** mrda-away is now known as mrda | 21:18 | |
| mrda | Morning Ironic! | 21:18 |
| NobodyCam | morning mrda | 21:19 |
| openstackgerrit | Ghe Rivero proposed a change to openstack/ironic: Raise MissingParameterValue instead of Invalid https://review.openstack.org/108455 | 21:22 |
| jroll | heya mrda :) | 21:22 |
| *** matty_dubs is now known as matty_dubs|gone | 21:23 | |
| mrda | NobodyCam: jroll \o | 21:25 |
| mrda | jroll: (after reading scrollback) I can see I need to find some sharp sticks :) | 21:26 |
| jroll | mrda, I have some things you're going to want to stab me for | 21:26 |
| jroll | ha yeah | 21:26 |
| jroll | so I have like 3 patches that touch nova driver | 21:26 |
| jroll | one has +2 from deva and others... but will break our 2x+2 on your first patch | 21:26 |
| mrda | So what I'd like is a list of reviews you *need* added to the proposed nova ironic driver | 21:26 |
| NobodyCam | jroll: you see deva's comment on 105590 | 21:26 |
| jroll | ok | 21:27 |
| jroll | so that first one is https://review.openstack.org/105590 | 21:27 |
| jroll | NobodyCam: yep | 21:27 |
| mrda | I'm very tempted not to wipe out the +2's but add in some dependent patches at the end of the chain | 21:27 |
| jroll | mrda, so if we have to change the first nova patch, 105590 can go in as well | 21:27 |
| jroll | otherwise we'll take it on like you say | 21:27 |
| jroll | the others can go in but I have some feedback to deal with | 21:27 |
| mrda | We discussed this briefly in PDX, and at least sdague and mikal were amenable to that approach | 21:28 |
| mrda | (IIRC) | 21:28 |
| jroll | which are https://review.openstack.org/108545 and https://review.openstack.org/113036 | 21:28 |
| mrda | but just send me a list of reviews | 21:28 |
| mrda | ta | 21:28 |
| jroll | I can fix those up now, we can push them through ironic and then get them in? | 21:28 |
| * mrda looks first | 21:28 | |
| jroll | if you think we can get those in today, I'll do it real quick | 21:29 |
| mrda | jroll: Sure, so long as you get lucas-dinner and/or devananda to agree :) | 21:32 |
| mrda | ...then I'll propose as dependent patches 6 and 7 on the end of the chain in Nova | 21:32 |
| jroll | mrda: thanks, give me a few | 21:35 |
| jroll | mrda: any problem with rolling them into existing patches, though? | 21:35 |
| mrda | If I can merge I will, especially if the existing patch has a -1 | 21:38 |
| mrda | but if we have +2's and no negatives.... | 21:38 |
| mrda | ....I don't want to touch them | 21:39 |
| mrda | (less than 3 weeks to J3 and all that) | 21:39 |
| devananda | mrda: ++ | 21:39 |
| mrda | they will all get 2x +2, and then +A, then the head-patch will get unblocked and they will all merge in one bit hit anyway | 21:40 |
| mrda | (as fast as gate will allow, anyways :) | 21:41 |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Add Node decommission in conductor https://review.openstack.org/102984 | 21:44 |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Add Node decommission interfaces https://review.openstack.org/102953 | 21:44 |
| jroll | mrda: right, agree, the later patches won't touch that first review that has the +2's | 21:46 |
| mrda | jroll: so just poke me when those patches get reviewer approval, and I'll propose. | 21:53 |
| jroll | mrda, cool, thanks | 21:53 |
| *** eghobo has joined #openstack-ironic | 21:57 | |
| *** Mikhail_D_ltp has quit IRC | 21:58 | |
| * devananda afk's for the rest of the day | 22:06 | |
| jroll | noooooooooooooo | 22:06 |
| jroll | mrda: there goes that idea :P | 22:06 |
| mrda | jroll: don't believe it. He hangs around for a while longer normally :) typey typey :) | 22:07 |
| jroll | ok | 22:08 |
| dlaube | hehe | 22:08 |
| mrda | (i.e. you might be lucky :) | 22:08 |
| dlaube | good afternoon gents | 22:08 |
| * dlaube tips his hat | 22:08 | |
| jroll | hiya dlaube | 22:09 |
| mrda | \o | 22:18 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Query full node details and cache https://review.openstack.org/108545 | 22:31 |
| jroll | mrda: there's one, waiting on unit tests to run though ^ | 22:31 |
| *** penick has joined #openstack-ironic | 22:37 | |
| *** penick has quit IRC | 22:38 | |
| *** penick has joined #openstack-ironic | 22:41 | |
| jroll | aaaaaaand that's likely broken | 22:42 |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Add a decommission command for the agent https://review.openstack.org/103694 | 22:44 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Query full node details and cache https://review.openstack.org/108545 | 22:55 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Use cache in node_is_available() https://review.openstack.org/113036 | 22:55 |
| jroll | mrda: ^ should be good to go | 22:56 |
| jroll | devananda / NobodyCam / lucas-dinner pls to review | 22:56 |
| openstackgerrit | Ellen Hui proposed a change to openstack/ironic: Make DHCP provider pluggable https://review.openstack.org/112351 | 23:05 |
| NobodyCam | jroll: should https://review.openstack.org/#/c/102953 still be blocked? | 23:06 |
| JoshNang | NobodyCam: yeah, the spec will be in k. | 23:06 |
| NobodyCam | :) | 23:07 |
| JoshNang | though i'm updating that whole patch chain with our production code | 23:08 |
| NobodyCam | :) | 23:10 |
| JayF | How does our environment run? It's runs K. | 23:12 |
| NobodyCam | oh :-p | 23:12 |
| jroll | lol | 23:12 |
| NobodyCam | ok mr macky | 23:12 |
| JayF | mmmmm K | 23:12 |
| NobodyCam | lol | 23:12 |
| openstackgerrit | Josh Gachnang proposed a change to openstack/ironic: Nova fast deletes while decommissioning https://review.openstack.org/105614 | 23:25 |
| NobodyCam | jroll: would kill me if I asked for a log.debug("node %s not in cache fetching.." say at about line 450 of https://review.openstack.org/#/c/108545/4/ironic/nova/virt/ironic/driver.py | 23:49 |
| NobodyCam | s/would/would you/ | 23:50 |
| jroll | it's fine | 23:50 |
| jroll | but bundle it with any other concerns so I can do one iteration :) | 23:50 |
| NobodyCam | actually thats it, was going to +2 it but got to thinking about it might me nice to know when htere is a miss | 23:51 |
| jroll | sure, sec | 23:51 |
| adam_g | Shrews, i think this should do it https://review.openstack.org/#/c/113707/ | 23:51 |
| NobodyCam | though not seeing "using cached node" would mean its fetching but... | 23:52 |
| jroll | oh wow, I'm over 80 chars there too | 23:53 |
| jroll | huh | 23:53 |
| NobodyCam | where? | 23:53 |
| jroll | that log line | 23:56 |
| jroll | oh right, pep8 doesn't run there | 23:56 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Query full node details and cache https://review.openstack.org/108545 | 23:57 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Use cache in node_is_available() https://review.openstack.org/113036 | 23:57 |
| jroll | NobodyCam: ^^ | 23:57 |
| NobodyCam | :) ty :) | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
