*** shakamunyi has joined #openstack-ironic | 00:19 | |
*** shakamunyi has quit IRC | 00:35 | |
*** foexle has quit IRC | 00:42 | |
*** shakamunyi has joined #openstack-ironic | 00:50 | |
*** r-daneel has quit IRC | 00:53 | |
*** nosnos has joined #openstack-ironic | 01:03 | |
*** dlaube has quit IRC | 01:06 | |
*** shakamunyi has quit IRC | 01:09 | |
*** shakamunyi has joined #openstack-ironic | 01:21 | |
*** eguz has joined #openstack-ironic | 01:26 | |
*** shakamunyi has quit IRC | 01:29 | |
*** eghobo has quit IRC | 01:30 | |
*** datajerk has quit IRC | 01:32 | |
*** eghobo has joined #openstack-ironic | 01:44 | |
*** datajerk has joined #openstack-ironic | 01:44 | |
*** eguz has quit IRC | 01:47 | |
*** penick has joined #openstack-ironic | 02:03 | |
*** penick has quit IRC | 02:19 | |
*** nosnos has quit IRC | 02:48 | |
*** nosnos has joined #openstack-ironic | 02:49 | |
*** nosnos has quit IRC | 02:53 | |
*** harlowja_ is now known as harlowja_away | 02:58 | |
*** eghobo has joined #openstack-ironic | 03:03 | |
*** dlaube has joined #openstack-ironic | 03:19 | |
*** dlaube has quit IRC | 03:20 | |
*** jbjohnso__ has quit IRC | 03:20 | |
*** nosnos has joined #openstack-ironic | 03:44 | |
*** eghobo has quit IRC | 03:49 | |
*** eghobo has joined #openstack-ironic | 03:57 | |
*** eghobo has quit IRC | 04:04 | |
*** notq has quit IRC | 04:06 | |
*** yuanying has joined #openstack-ironic | 04:16 | |
*** eghobo has joined #openstack-ironic | 04:27 | |
*** shakamunyi has joined #openstack-ironic | 04:39 | |
*** pcrews has quit IRC | 04:47 | |
mrda | Hey ironic cores, I'm looking for some comment on https://review.openstack.org/#/c/111428/12/nova/virt/ironic/driver.py specifically alaski's comment on L504. I *think* we want to raise a different exception instead of a NovaException here. Your thoughts? | 04:52 |
---|---|---|
*** eghobo has quit IRC | 04:57 | |
*** shakamunyi has quit IRC | 04:58 | |
*** nosnos has quit IRC | 05:01 | |
*** nosnos has joined #openstack-ironic | 05:01 | |
*** nosnos_ has joined #openstack-ironic | 05:03 | |
*** nosnos has quit IRC | 05:04 | |
*** eghobo has joined #openstack-ironic | 05:07 | |
*** jbjohnso__ has joined #openstack-ironic | 05:10 | |
*** nosnos_ has quit IRC | 05:11 | |
*** nosnos has joined #openstack-ironic | 05:11 | |
*** killer_prince is now known as lazy_prince | 05:19 | |
*** chenglch has joined #openstack-ironic | 05:39 | |
*** nosnos has quit IRC | 05:42 | |
*** nosnos has joined #openstack-ironic | 05:44 | |
*** nosnos has quit IRC | 05:49 | |
*** nosnos has joined #openstack-ironic | 05:49 | |
*** nosnos has quit IRC | 05:53 | |
*** yuanying has quit IRC | 05:57 | |
*** nosnos_ has joined #openstack-ironic | 05:57 | |
*** notq has joined #openstack-ironic | 06:02 | |
*** penick has joined #openstack-ironic | 06:04 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Imported Translations from Transifex https://review.openstack.org/117698 | 06:11 |
*** rushiagr_away has quit IRC | 06:11 | |
*** rushiagr_away has joined #openstack-ironic | 06:13 | |
*** eghobo has quit IRC | 06:22 | |
*** Halacs has joined #openstack-ironic | 06:30 | |
*** Haomeng has quit IRC | 06:46 | |
*** zz_naotok is now known as naotok | 06:46 | |
*** Haomeng has joined #openstack-ironic | 06:47 | |
*** lazy_prince is now known as killer_prince | 06:53 | |
*** penick has quit IRC | 07:01 | |
*** jcoufal has joined #openstack-ironic | 07:11 | |
*** nosnos_ has quit IRC | 07:19 | |
*** nosnos has joined #openstack-ironic | 07:20 | |
*** nosnos has quit IRC | 07:24 | |
*** romcheg1 has joined #openstack-ironic | 07:25 | |
*** Halacs has left #openstack-ironic | 07:30 | |
*** dtantsur|afk is now known as dtantsur | 07:35 | |
dtantsur | Morning Ironic, TGIF! | 07:35 |
*** nosnos has joined #openstack-ironic | 07:42 | |
dtantsur | mrda, seems correct to me, yes, though I don't know nova | 07:46 |
dtantsur | mrda, and g'evening too :) | 07:46 |
romcheg1 | Morning dtantsur | 07:46 |
dtantsur | romcheg1, morning | 07:46 |
*** yuanying has joined #openstack-ironic | 07:53 | |
*** lsmola has joined #openstack-ironic | 07:54 | |
*** jistr has joined #openstack-ironic | 08:01 | |
*** athomas has quit IRC | 08:02 | |
*** athomas has joined #openstack-ironic | 08:02 | |
*** dguerri`afk is now known as dguerri | 08:03 | |
*** derekh has joined #openstack-ironic | 08:04 | |
*** lucasagomes has joined #openstack-ironic | 08:24 | |
*** yuanying has quit IRC | 08:24 | |
lucasagomes | https://review.openstack.org/#/c/112351/ needs another +2 (implements a spec in Ironic) | 08:50 |
*** yuanying has joined #openstack-ironic | 08:55 | |
*** MattMan has quit IRC | 08:58 | |
*** MattMan has joined #openstack-ironic | 08:58 | |
*** yuanying has quit IRC | 09:04 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Log ERROR power state in node_power_action() https://review.openstack.org/117499 | 09:07 |
*** pelix1 has joined #openstack-ironic | 09:10 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Check whether specified FS is supported https://review.openstack.org/98102 | 09:13 |
*** dtantsur is now known as dtantsur|brb | 09:14 | |
*** boris-42 has quit IRC | 09:16 | |
*** dhellmann_ has quit IRC | 09:16 | |
*** dvorak has quit IRC | 09:16 | |
*** boris-42 has joined #openstack-ironic | 09:17 | |
*** dhellmann_ has joined #openstack-ironic | 09:17 | |
*** dvorak has joined #openstack-ironic | 09:17 | |
*** athomas has quit IRC | 09:17 | |
*** notq has quit IRC | 09:17 | |
*** datajerk has quit IRC | 09:17 | |
*** annegentle has quit IRC | 09:17 | |
*** pleia2 has quit IRC | 09:17 | |
*** SpamapS has quit IRC | 09:17 | |
*** dividehex has quit IRC | 09:17 | |
*** antonym has quit IRC | 09:17 | |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Implement hardware discovery setup in PXE driver https://review.openstack.org/110031 | 09:21 |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Endpoint for accepting discovered data https://review.openstack.org/116003 | 09:21 |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: Add newly_discovered column to Node object https://review.openstack.org/107389 | 09:21 |
*** pleia2 has joined #openstack-ironic | 09:22 | |
*** SpamapS has joined #openstack-ironic | 09:22 | |
*** SpamapS has quit IRC | 09:22 | |
*** SpamapS has joined #openstack-ironic | 09:22 | |
*** viktors|afk is now known as viktors | 09:25 | |
*** Haomeng has quit IRC | 09:26 | |
*** Haomeng has joined #openstack-ironic | 09:27 | |
*** athomas has joined #openstack-ironic | 09:30 | |
*** notq has joined #openstack-ironic | 09:30 | |
*** datajerk has joined #openstack-ironic | 09:30 | |
*** annegentle has joined #openstack-ironic | 09:30 | |
*** dividehex has joined #openstack-ironic | 09:30 | |
*** antonym has joined #openstack-ironic | 09:30 | |
openstackgerrit | A change was merged to openstack/ironic: Script to migrate Nova BM data to Ironic https://review.openstack.org/112402 | 09:42 |
*** aweeks has quit IRC | 09:45 | |
*** aweeks has joined #openstack-ironic | 09:45 | |
*** anteaya has quit IRC | 09:46 | |
*** wendar_ has joined #openstack-ironic | 09:46 | |
*** anteaya has joined #openstack-ironic | 09:47 | |
*** marzif_ has joined #openstack-ironic | 09:48 | |
*** jeblair_ has joined #openstack-ironic | 09:48 | |
*** tonycoffman_ has joined #openstack-ironic | 09:50 | |
*** jeblair has quit IRC | 09:50 | |
*** wendar has quit IRC | 09:50 | |
*** marzif has quit IRC | 09:50 | |
*** yarker has quit IRC | 09:50 | |
*** tonycoffman has quit IRC | 09:50 | |
*** tonycoffman_ is now known as tonycoffman | 09:50 | |
*** russellb has quit IRC | 09:51 | |
*** russellb has joined #openstack-ironic | 09:51 | |
*** comstud has quit IRC | 09:51 | |
*** comstud has joined #openstack-ironic | 09:54 | |
*** ryanpetrello_ has joined #openstack-ironic | 09:54 | |
*** ryanpetrello has quit IRC | 09:54 | |
*** ryanpetrello_ is now known as ryanpetrello | 09:54 | |
*** Ng_ has joined #openstack-ironic | 09:55 | |
*** yuriyz|2 has joined #openstack-ironic | 09:55 | |
*** yuriyz|2 has quit IRC | 09:56 | |
*** yuriyz|2 has joined #openstack-ironic | 09:56 | |
*** yarker has joined #openstack-ironic | 09:56 | |
*** russell_h has quit IRC | 09:57 | |
*** Ng has quit IRC | 09:57 | |
*** Ng_ is now known as Ng | 09:57 | |
*** Ng is now known as Ng_ | 09:58 | |
*** lifeless1 has joined #openstack-ironic | 09:58 | |
*** Ng_ is now known as Ng | 10:00 | |
*** bigjools_ has joined #openstack-ironic | 10:00 | |
*** yuanying has joined #openstack-ironic | 10:00 | |
*** EmilienM_ has joined #openstack-ironic | 10:01 | |
*** victor_lowther_ has joined #openstack-ironic | 10:01 | |
*** aignatov2 has joined #openstack-ironic | 10:02 | |
*** mitz_ has joined #openstack-ironic | 10:03 | |
*** naotok_ has joined #openstack-ironic | 10:03 | |
*** chenglch has quit IRC | 10:09 | |
*** naotok has quit IRC | 10:09 | |
*** yuriyz has quit IRC | 10:09 | |
*** aignatov has quit IRC | 10:09 | |
*** victor_lowther has quit IRC | 10:09 | |
*** bigjools has quit IRC | 10:09 | |
*** early has quit IRC | 10:09 | |
*** mitz- has quit IRC | 10:09 | |
*** lifeless has quit IRC | 10:09 | |
*** EmilienM has quit IRC | 10:09 | |
*** aignatov2 is now known as aignatov | 10:09 | |
*** yuanying has quit IRC | 10:09 | |
*** EmilienM_ is now known as EmilienM | 10:10 | |
*** early has joined #openstack-ironic | 10:10 | |
*** russell_h has joined #openstack-ironic | 10:11 | |
*** victor_lowther_ is now known as victor_lowther | 10:12 | |
*** nosnos has quit IRC | 10:16 | |
*** nosnos has joined #openstack-ironic | 10:17 | |
*** nosnos has quit IRC | 10:21 | |
*** vdrok_ has joined #openstack-ironic | 10:26 | |
*** coolsvap has quit IRC | 10:34 | |
*** yarker has quit IRC | 10:34 | |
*** openstackgerrit has quit IRC | 10:34 | |
*** vdrok has quit IRC | 10:34 | |
*** sbadia has quit IRC | 10:34 | |
*** yarker has joined #openstack-ironic | 10:36 | |
*** sbadia has joined #openstack-ironic | 10:36 | |
*** coolsvap has joined #openstack-ironic | 10:41 | |
*** openstackgerrit has joined #openstack-ironic | 10:41 | |
*** boris-42 has quit IRC | 10:43 | |
openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Rewrite images tests with mock https://review.openstack.org/117549 | 10:50 |
*** NobodyCa1 has joined #openstack-ironic | 10:51 | |
*** dtantsur|brb is now known as dtantsur | 10:53 | |
*** NobodyCam has quit IRC | 10:55 | |
*** mrda has quit IRC | 10:55 | |
*** EmilienM has quit IRC | 10:55 | |
*** sirushti has quit IRC | 10:56 | |
*** EmilienM has joined #openstack-ironic | 10:56 | |
*** mrda has joined #openstack-ironic | 10:56 | |
*** sirushti has joined #openstack-ironic | 10:57 | |
*** vdrok_ has quit IRC | 11:02 | |
*** datajerk1 has joined #openstack-ironic | 11:05 | |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/python-ironicclient: Add sort_key and sort_dir parameters to *-list https://review.openstack.org/114555 | 11:05 |
*** yuanying has joined #openstack-ironic | 11:05 | |
*** datajerk has quit IRC | 11:07 | |
*** vdrok has joined #openstack-ironic | 11:09 | |
*** Dafna has joined #openstack-ironic | 11:13 | |
*** yuanying has quit IRC | 11:14 | |
*** kincl has quit IRC | 11:22 | |
*** kincl has joined #openstack-ironic | 11:22 | |
*** kincl has joined #openstack-ironic | 11:22 | |
*** dguerri has quit IRC | 11:27 | |
*** kylestev has quit IRC | 11:27 | |
*** mrda has quit IRC | 11:27 | |
*** kylestev- has joined #openstack-ironic | 11:27 | |
*** dguerri has joined #openstack-ironic | 11:27 | |
*** kincl_ has joined #openstack-ironic | 11:28 | |
*** tteggel_ has joined #openstack-ironic | 11:28 | |
*** naotok_ is now known as zz_naotok_ | 11:29 | |
*** kincl has quit IRC | 11:30 | |
*** tteggel has quit IRC | 11:30 | |
*** lucasagomes is now known as lucas-hungry | 11:33 | |
*** mrda has joined #openstack-ironic | 11:34 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Remove futures from requirements https://review.openstack.org/117762 | 11:52 |
*** Halacs has joined #openstack-ironic | 12:07 | |
*** HenryG has joined #openstack-ironic | 12:12 | |
*** yuanying has joined #openstack-ironic | 12:13 | |
*** GheRivero is now known as GheRivero_afk | 12:16 | |
*** yuanying has quit IRC | 12:19 | |
*** lucas-hungry is now known as lucasagomes | 12:37 | |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Endpoint for accepting discovered data https://review.openstack.org/116003 | 12:53 |
*** russellb is now known as rustlebee | 13:09 | |
openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Translator functions cleanup https://review.openstack.org/116303 | 13:10 |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Log ERROR power state in node_power_action() https://review.openstack.org/117499 | 13:12 |
*** yuanying has joined #openstack-ironic | 13:15 | |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Check whether specified FS is supported https://review.openstack.org/98102 | 13:24 |
*** yuanying has quit IRC | 13:24 | |
NobodyCa1 | good morning Ironic | 13:31 |
*** NobodyCa1 is now known as NobodyCam | 13:32 | |
NobodyCam | TGIF | 13:32 |
Shrews | morning NobodyCam | 13:32 |
lucasagomes | morning NobodyCam Shrews how you guys doing? | 13:34 |
lucasagomes | sorry start asking you guys in the morning, when you get a time mind taking a look at https://review.openstack.org/#/c/112351/ ? seems in good shape and is implementing a bp in Ironic and fixing a bug :) | 13:35 |
lucasagomes | take ur time, drink ur coffee before and all :) | 13:36 |
Shrews | lucasagomes: hi. and will look | 13:36 |
lucasagomes | thanks | 13:36 |
dtantsur | NobodyCam, Shrews, lucasagomes, morning :) | 13:36 |
Shrews | hi dtantsur | 13:36 |
Shrews | lucasagomes: only +1? | 13:37 |
lucasagomes | Shrews, i'm co-author | 13:37 |
Shrews | lucasagomes: oh, you co-authored :) | 13:37 |
lucasagomes | I mean I fixed a race condition on that patch | 13:37 |
lucasagomes | 95% of the work was ellen and jroll | 13:37 |
lucasagomes | but still I didn't want to +2 it because my name was there in the commit message | 13:38 |
NobodyCam | morning Shrews lucasagomes dtantsur :) | 13:38 |
* lucasagomes brb meeting | 13:38 | |
NobodyCam | is it execption or debug that we do not translate | 13:42 |
Shrews | debug i think | 13:43 |
NobodyCam | ok | 13:43 |
NobodyCam | :) TY | 13:43 |
*** pcrews has joined #openstack-ironic | 13:44 | |
NobodyCam | Shrews: blank line betewwn abc and six imports? | 13:46 |
Shrews | eh? | 13:46 |
*** bluex-pl has joined #openstack-ironic | 13:46 | |
Shrews | oh, yeah. that too | 13:46 |
NobodyCam | lines 20 - 22 of base.py | 13:46 |
Shrews | plus the unused LOG | 13:46 |
Shrews | test_neutron.py doesn't need the CONF either | 13:49 |
Shrews | ugh. several places | 13:50 |
NobodyCam | :( brb | 13:51 |
*** r-daneel has joined #openstack-ironic | 13:52 | |
jroll | morning all :) | 13:54 |
Shrews | jroll: sup? | 13:54 |
dtantsur | jroll, morning | 13:55 |
jroll | lucasagomes: I did like a 5 line patch for that, I should be able to +2 and not co-author | 13:55 |
jroll | hi Shrews dtantsur NobodyCam lucasagomes :) | 13:55 |
* jroll has lots of scrollback to read | 13:55 | |
Shrews | Anyone seen this error from the gate? "AttributeError: 'tuple' object has no attribute 'lower'" | 13:56 |
Shrews | http://logs.openstack.org/60/112660/13/check/check-grenade-dsvm-partial-ncpu-icehouse/9ca29df/console.html#_2014-08-29_01_14_55_081 | 13:56 |
jroll | 19:08:59 lifeless | jroll: what happens if a user makes the arch unnknown after instance is on a node <- not sure, but I would tell whoever mucked with the database to stop doing so :) why would one change the arch after registration? | 14:02 |
*** chuckC has quit IRC | 14:08 | |
jroll | so it looks like we never came to a consensus | 14:10 |
*** igordcard has joined #openstack-ironic | 14:11 | |
jroll | thing is, when the change to canonicalize() the image stuff lands, that's going to break ironic installs that *do* use that filter | 14:11 |
jroll | bluex-pl: hi! | 14:13 |
bluex-pl | hi | 14:13 |
bluex-pl | is https://bugs.launchpad.net/ironic main dashboard for ironic-python-agent bugs? | 14:14 |
jroll | yes, we use the same bug tracker | 14:14 |
*** Haomeng has quit IRC | 14:15 | |
NobodyCam | morning jroll | 14:15 |
jroll | morning :) | 14:15 |
bluex-pl | great, do you care about pep8 checking or not yet? | 14:15 |
jroll | happy friday! | 14:15 |
NobodyCam | hi bluex-pl yep | 14:15 |
jroll | bluex-pl: yes, that's why we run the test :P | 14:15 |
NobodyCam | yep | 14:15 |
NobodyCam | TGIF | 14:15 |
NobodyCam | SIDE NOTE: I will be heading out around 2 - 3 this afternoon | 14:16 |
jroll | cool | 14:16 |
jroll | I'm really bad about telling people these things, I think I forgot to tell y'all I took yesterday off | 14:16 |
Shrews | jroll: that's ok. you can work saturday to make up for it :) | 14:17 |
*** igordcard has quit IRC | 14:17 | |
bluex-pl | because during fixing of https://review.openstack.org/#/c/117529/ I find out that project uses old hacking lib (v0.8) which crashes during checking | 14:17 |
jroll | Shrews: shh | 14:17 |
jroll | orly | 14:17 |
bluex-pl | and when I updated test-requirements to use new version it found a lot of warnings | 14:18 |
jroll | that's been working in the past, might be transient | 14:18 |
jroll | O.o | 14:18 |
jroll | bluex-pl: can you paste this somewhere for me? | 14:20 |
*** yuanying has joined #openstack-ironic | 14:20 | |
bluex-pl | http://pastebin.com/YQ4y3qhT | 14:21 |
*** Haomeng has joined #openstack-ironic | 14:21 | |
jroll | ... great | 14:24 |
jroll | I could fix that today unless you want to? :) | 14:24 |
* jroll checks what version ironic uses | 14:24 | |
bluex-pl | I can fix it during next week as a procject I currently working on (horizon widget) is almost finished | 14:24 |
jroll | we use same version as ironic | 14:25 |
jroll | https://github.com/openstack/ironic-python-agent/blob/master/test-requirements.txt#L1 | 14:25 |
jroll | https://github.com/openstack/ironic/blob/master/test-requirements.txt#L1 | 14:25 |
jroll | bluex-pl: ... you're working on the ironic horizon dashboard? | 14:25 |
bluex-pl | jroll: no, I'm working mainly on https://review.openstack.org/#/c/104956 | 14:26 |
jroll | ah, ok | 14:27 |
jroll | cool | 14:27 |
bluex-pl | horizon use v0.9.2 - https://github.com/openstack/horizon/blob/master/test-requirements.txt | 14:28 |
jroll | bluex-pl: I think how pep8 currently is is fine | 14:28 |
jroll | I think you hit a transient bug in jenkins | 14:28 |
jroll | might need a recheck | 14:28 |
* jroll promises to review all the IPA code today | 14:28 | |
*** yuanying has quit IRC | 14:29 | |
bluex-pl | jroll: it's know bug in hacking lib - https://bugs.launchpad.net/hacking/+bug/1305027 | 14:30 |
jroll | I mean... it's been running fine | 14:30 |
*** igordcard has joined #openstack-ironic | 14:32 | |
jroll | it worked two days ago | 14:33 |
bluex-pl | hmm, ok | 14:35 |
jroll | I'm going to issue a recheck | 14:36 |
*** igordcard has quit IRC | 14:38 | |
*** ZackaryDoyle has quit IRC | 14:38 | |
NobodyCam | whats left on our need to land list? | 14:42 |
jroll | everything | 14:43 |
jroll | eesh https://launchpad.net/ironic/+milestone/juno-3 | 14:43 |
bluex-pl | I would also like to make small optimizations - for example change from checking to exception handling ( http://pastebin.com/0evD9mE4 ) | 14:43 |
jroll | NobodyCam: lemme fix up this real quick and you can land it :P https://review.openstack.org/#/c/112351/ | 14:43 |
jroll | bluex-pl: I don't see the point :| | 14:44 |
bluex-pl | value in dictionary is searched only once | 14:45 |
lucasagomes | jroll, :) gotcha | 14:45 |
lucasagomes | Shrews, thanks for the review, will address those | 14:46 |
bluex-pl | (rather than two: key in dict & dict[key]) | 14:46 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Make DHCP provider pluggable https://review.openstack.org/112351 | 14:47 |
jroll | Shrews NobodyCam ^^ | 14:47 |
lucasagomes | ty jroll :) | 14:47 |
jroll | bluex-pl: sure, but that's unlikely to be called often... | 14:47 |
jroll | or often enough for an extra __getitem__ to matter | 14:48 |
Shrews | jroll: you missed NobodyCam's suggestion on the dhcp review | 14:48 |
jroll | Shrews: I responded to it, there should be an empty line there | 14:49 |
jroll | abc is stdlib, six is third party | 14:49 |
Shrews | ah, ok | 14:49 |
jroll | :) | 14:49 |
NobodyCam | oh fiddle sixs | 14:52 |
NobodyCam | lol | 14:52 |
jroll | hehehe | 14:52 |
Shrews | such language | 14:52 |
NobodyCam | :p | 14:52 |
*** lsmola has quit IRC | 14:54 | |
NobodyCam | lucasagomes: you now have 2 +2's | 14:55 |
lucasagomes | o | 14:55 |
NobodyCam | will +a after mr J | 14:55 |
lucasagomes | o/* | 14:55 |
lucasagomes | NobodyCam, awesome! thanks for that | 14:55 |
lucasagomes | +1 bp implemented :) | 14:55 |
NobodyCam | :) | 14:56 |
bluex-pl | jroll: I just prefer to use EAFP paradigm :) | 14:58 |
lucasagomes | bluex-pl, +1 | 14:59 |
*** chuckC has joined #openstack-ironic | 15:00 | |
jroll | EAFP? | 15:00 |
jroll | NobodyCam: \o/ thanks! | 15:00 |
lucasagomes | jroll, easier to ask forgiveness than permission | 15:01 |
jroll | heh | 15:01 |
lucasagomes | vs LBYL (look before you leap) | 15:01 |
jroll | bluex-pl: btw, I'll totally take the patch, just saying there are more interesting places for improvement than that :) | 15:01 |
NobodyCam | FYI: Ironicers please review: https://review.openstack.org/#/c/111425 | 15:02 |
*** russell_h has quit IRC | 15:02 | |
*** russell_h has joined #openstack-ironic | 15:02 | |
lucasagomes | NobodyCam, idk if I should vote or not... I've been looking at the driver patches | 15:03 |
jroll | interested to see what nova thinks about the arch thing | 15:03 |
lucasagomes | jroll, do we have a consensus now? | 15:03 |
lucasagomes | sorta? | 15:03 |
jroll | idk | 15:03 |
jroll | I didn't see one | 15:03 |
jroll | but apparently someone decided something :P | 15:03 |
lucasagomes | heh | 15:04 |
lucasagomes | well someone has to | 15:04 |
lucasagomes | :D | 15:04 |
jroll | yeah | 15:04 |
NobodyCam | * see scroll back from about 22:00 (gmt) in this channel | 15:04 |
jroll | I don't love it, but I don't think I would love any solution | 15:04 |
jroll | yeah, I read back earlier | 15:05 |
NobodyCam | jroll: ++ | 15:05 |
*** lsmola has joined #openstack-ironic | 15:09 | |
*** igordcard has joined #openstack-ironic | 15:10 | |
*** ifarkas has quit IRC | 15:11 | |
NobodyCam | oh looks like 114357 is so close! | 15:15 |
lucasagomes | yeah | 15:17 |
*** jeblair_ is now known as jeblair | 15:17 | |
lucasagomes | ppl may want to look at the DRAC stuff as well :) ? https://review.openstack.org/#/c/116871/ (some related plumbing) and https://review.openstack.org/#/c/116913/ (main one) | 15:18 |
NobodyCam | anyone know syed's Irc Nick? | 15:18 |
lucasagomes | nop :( | 15:19 |
NobodyCam | should we just push up a new so we can land it? | 15:20 |
*** igordcard has quit IRC | 15:21 | |
JayF | NobodyCam: the code belongs to everyone and does nobody any good until it's merged | 15:21 |
JayF | NobodyCam: so I'd say to always push something if it means it can land :) | 15:21 |
lucasagomes | NobodyCam, yeah sounds good to me | 15:21 |
lucasagomes | it's 3 quick nits | 15:21 |
lucasagomes | JayF, ^ +1 | 15:22 |
lucasagomes | NobodyCam, mind doing that? | 15:22 |
NobodyCam | on it | 15:23 |
lucasagomes | NobodyCam, u rock :) | 15:23 |
*** rakesh_hs has joined #openstack-ironic | 15:25 | |
*** shakamunyi has joined #openstack-ironic | 15:25 | |
*** yuanying has joined #openstack-ironic | 15:25 | |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Add UEFI based deployment support in Ironic https://review.openstack.org/114357 | 15:28 |
NobodyCam | JayF: lucasagomes jroll ^^^^^ | 15:28 |
lucasagomes | NobodyCam, awesome +2 | 15:30 |
*** yuanying has quit IRC | 15:34 | |
*** igordcard has joined #openstack-ironic | 15:37 | |
NobodyCam | lucasagomes: looking at 116871.. is triple check broken? | 15:39 |
NobodyCam | TripleO | 15:39 |
lucasagomes | NobodyCam, something may have gone wrong on that run | 15:40 |
lucasagomes | we can recheck | 15:40 |
lucasagomes | that patch should not have affected it because it doesn't use the drac driver | 15:41 |
NobodyCam | :) | 15:41 |
* NobodyCam wants to land everyting Now... | 15:41 | |
*** igordcard has quit IRC | 15:41 | |
*** bluex-pl has quit IRC | 15:42 | |
NobodyCam | oh-gawd now /me has an old queen song stuck in is head | 15:42 |
lucasagomes | NobodyCam, I will recheck it | 15:43 |
NobodyCam | https://www.youtube.com/watch?v=1pm4fQRl72k <- /me sharing stuck song | 15:43 |
*** igordcard has joined #openstack-ironic | 15:43 | |
lucasagomes | The uploader has not made this video available in your country. | 15:43 |
lucasagomes | :( | 15:44 |
lucasagomes | ppl don't like Ireland | 15:44 |
NobodyCam | really | 15:44 |
NobodyCam | wow | 15:44 |
NobodyCam | lucasagomes: why blank line at #26 on https://review.openstack.org/#/c/116913/7/ironic/drivers/drac.py | 15:47 |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Log ERROR power state in node_power_action() https://review.openstack.org/117499 | 15:47 |
lucasagomes | NobodyCam, :( no reason really | 15:47 |
NobodyCam | lol | 15:47 |
openstackgerrit | Yuriy Zveryanskyy proposed a change to openstack/ironic: Log ERROR power state in node_power_action() https://review.openstack.org/117499 | 15:47 |
lucasagomes | it came from the previous patch | 15:47 |
lucasagomes | I just changed the message | 15:47 |
lucasagomes | from the class docstring | 15:48 |
lucasagomes | that code was introduced by the drac power driver | 15:48 |
lucasagomes | (I can remove that line if needed) | 15:48 |
NobodyCam | still looking | 15:48 |
NobodyCam | oh and lots of blank lines in the doc strings of https://review.openstack.org/#/c/116913/7/ironic/drivers/modules/drac/management.py | 15:49 |
lucasagomes | NobodyCam, ending the docstring with a blank line is proposital | 15:51 |
lucasagomes | it's optional but in the pep 257 they mention it | 15:51 |
NobodyCam | ya I didn't comment on any of them | 15:51 |
NobodyCam | just looks odd to me | 15:51 |
lucasagomes | :) | 15:53 |
NobodyCam | lucasagomes: +2'd (and left one nit) | 15:55 |
lucasagomes | \o/ | 15:55 |
lucasagomes | ack will fix if need another patch-set | 15:55 |
lucasagomes | ta much! | 15:55 |
*** jistr is now known as jistr|afk | 15:55 | |
Shrews | 116871 leaves me scratching my head a bit. | 15:58 |
NobodyCam | Shrews: where? | 15:59 |
Shrews | would just be helpful if i could envision the xml it's parsing | 15:59 |
lucasagomes | :( yeah the XML is pain | 15:59 |
Shrews | lucasagomes: https://review.openstack.org/#/c/116871/6/ironic/tests/drivers/drac/utils.py, line 32... | 15:59 |
lucasagomes | SOAP sucks big time | 16:00 |
Shrews | should that be "Envelope" instead of "Envelop"? | 16:00 |
NobodyCam | lucasagomes: +++ i was using that back in the 90's | 16:00 |
lucasagomes | Shrews, :( yes | 16:00 |
lucasagomes | that's just for tests, but yeah mistyped it | 16:00 |
*** dlaube has joined #openstack-ironic | 16:00 | |
lucasagomes | Shrews, will fix it | 16:01 |
lucasagomes | after the full review | 16:01 |
* NobodyCam brb... quick run to grab smokes and maybe starbucks | 16:02 | |
* Shrews notes several workers from the water company in front of his house with a backhoe digger and suspects he is about to lose access to water | 16:03 | |
*** todd_dsm has joined #openstack-ironic | 16:03 | |
JayF | either that or you're about to get a free lake | 16:04 |
Shrews | lake, or a pool. the lake would be good for me | 16:04 |
Shrews | Caddieshack anyone??? | 16:04 |
JayF | YOU'LL GET NOTHING AND LIKE IT! | 16:04 |
Shrews | lol | 16:05 |
lucasagomes | hah | 16:06 |
*** r-daneel has quit IRC | 16:06 | |
openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Endpoint for accepting discovered data https://review.openstack.org/116003 | 16:10 |
*** igordcard has quit IRC | 16:11 | |
*** bandicot has joined #openstack-ironic | 16:12 | |
*** penick has joined #openstack-ironic | 16:16 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: DRAC wsman_{enumerate, invoke}() to return an ElementTree object https://review.openstack.org/116871 | 16:20 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Implements the DRAC ManagementInterface for get/set boot device https://review.openstack.org/116913 | 16:20 |
*** todd_dsm has quit IRC | 16:21 | |
NobodyCam | oh I've vote for a hottub | 16:22 |
lucasagomes | aight I will call it a dya | 16:29 |
lucasagomes | day* | 16:29 |
lucasagomes | have a good night everybody, enjoy the weekend! | 16:29 |
NobodyCam | have a grreat weekend lucasagomes | 16:29 |
NobodyCam | lucasagomes: you running the meeting monday? | 16:29 |
NobodyCam | As I will have no internets | 16:29 |
lucasagomes | NobodyCam, yes, it's holidays there right? | 16:30 |
lucasagomes | holiday* | 16:30 |
lucasagomes | np :) | 16:30 |
NobodyCam | yeppers | 16:30 |
NobodyCam | TY | 16:30 |
lucasagomes | yvw | 16:30 |
NobodyCam | have a good weekend ... drink a lot for me | 16:30 |
lucasagomes | haha will do! | 16:30 |
lucasagomes | enjoy it as well | 16:30 |
NobodyCam | :) | 16:30 |
*** lucasagomes is now known as lucas-dinner | 16:30 | |
*** yuanying has joined #openstack-ironic | 16:31 | |
*** jistr|afk is now known as jistr | 16:32 | |
Shrews | yup, no water :( | 16:32 |
NobodyCam | Shrews: do I I do.. bring your own water :) | 16:33 |
NobodyCam | gah | 16:33 |
NobodyCam | Do like I do.... | 16:33 |
* Shrews steals NobodyCam's water | 16:35 | |
Shrews | NobodyCam: my house is not as portable | 16:36 |
*** Dafna has quit IRC | 16:36 | |
Shrews | eh, lunch time anyway. maybe i'll change locations | 16:36 |
NobodyCam | lol | 16:38 |
dtantsur | have a nice weekend folks! | 16:38 |
NobodyCam | :) | 16:38 |
*** dtantsur is now known as dtantsur|afk | 16:38 | |
JayF | Enjoy the weekend :) | 16:38 |
JayF | Don't forget those of us in 'murica get Monday off | 16:38 |
NobodyCam | dtantsur|afk: have a good one! | 16:38 |
JayF | to celebrate our Labor | 16:38 |
JayF | aka the most Ironic holiday ever | 16:38 |
NobodyCam | lol | 16:38 |
NobodyCam | we should rename it | 16:39 |
JayF | my mom had me convinced as a kid | 16:39 |
NobodyCam | "the iRonic Holiday" | 16:39 |
JayF | it was named after the LABOR that a woman has when having a baby | 16:39 |
NobodyCam | hehhehehhee | 16:39 |
JayF | aka I should be extra nice to her on "Labor" day | 16:39 |
NobodyCam | :) | 16:39 |
*** yuanying has quit IRC | 16:39 | |
*** derekh has quit IRC | 16:40 | |
*** lsmola has quit IRC | 16:45 | |
*** rakesh_hs has quit IRC | 16:47 | |
*** jcoufal has quit IRC | 16:47 | |
*** MattMan has left #openstack-ironic | 16:51 | |
*** dguerri is now known as dguerri`afk | 16:54 | |
*** eghobo has joined #openstack-ironic | 16:58 | |
*** igordcard has joined #openstack-ironic | 17:06 | |
*** jistr has quit IRC | 17:13 | |
*** rustlebee is now known as russellb | 17:14 | |
*** harlowja_away is now known as harlowja_ | 17:15 | |
NobodyCam | lol :( 112351 now has pep8 failure? | 17:16 |
NobodyCam | any cores @HERE want to give 114357 a little look over? | 17:19 |
NobodyCam | lol too much hipchat usage | 17:20 |
*** harlowja has joined #openstack-ironic | 17:24 | |
*** harlowja_ has quit IRC | 17:26 | |
openstackgerrit | Chris Krelle proposed a change to openstack/ironic: Make DHCP provider pluggable https://review.openstack.org/112351 | 17:26 |
NobodyCam | just fixing minor pep8 errors ^^^ | 17:26 |
*** bandicot has quit IRC | 17:32 | |
*** bandicot has joined #openstack-ironic | 17:33 | |
*** yuanying has joined #openstack-ironic | 17:36 | |
*** boris-42 has joined #openstack-ironic | 17:36 | |
*** viktors is now known as viktors|afk | 17:39 | |
openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic: Add implementation of ZooKeeper SyncManager https://review.openstack.org/117576 | 17:41 |
jroll | NobodyCam: oops, thanks for that | 17:42 |
* jroll looks at uefi things | 17:42 | |
jroll | russell_h: https://review.openstack.org/#/c/117529/ | 17:43 |
jroll | russell_h: check out my comment there, I can't remember why we did this | 17:43 |
*** yuanying has quit IRC | 17:44 | |
russell_h | jroll: separation of public and private interfaces | 17:45 |
russell_h | jroll: we should be able to rename a function internally without needing to change the API | 17:45 |
jroll | right, so not restricting ourselves to... yeah that | 17:46 |
jroll | thanks | 17:46 |
* jroll thinks every developer should have access to a bouncer | 17:47 | |
JayF | make sure to update that bug as INVALID if that's not a bug (since Szymon filed a bug about that behavior) | 17:48 |
NobodyCam | jroll: check yellow pages http://www.yellowpages.com/houston-tx/mip/rent-a-thug-inc-473322235 | 17:49 |
jroll | LOL | 17:49 |
JayF | Wow, that's really amazing | 17:49 |
JayF | I didn't know people used yellowpages anymore | 17:49 |
* jroll tries to stop laughing | 17:50 | |
NobodyCam | lol | 17:50 |
jroll | to be clear, I mean an irc bouncer :P | 17:50 |
NobodyCam | oh https://www.youtube.com/watch?v=V3FnpaWQJO0 | 17:51 |
*** dlaube has quit IRC | 17:51 | |
jroll | heh | 17:52 |
*** dlaube has joined #openstack-ironic | 17:52 | |
NobodyCam | brb | 17:57 |
jroll | "nova allocates only one fixed_ip for the instance" <-- is this true? | 17:59 |
jroll | I'm inclined to believe it, but not completely sure | 18:00 |
*** kincl_ is now known as kincl | 18:00 | |
*** kincl has quit IRC | 18:00 | |
*** kincl has joined #openstack-ironic | 18:00 | |
jroll | probably fine | 18:00 |
Shrews | 1 pvt, 1 public, N floating, no? | 18:01 |
jroll | gah, this is going to conflict with the dhcp changes :| | 18:01 |
jroll | Shrews: this seems like for a single neutron port | 18:02 |
jroll | NobodyCam: fine with me just re-approving dhcp stuff? | 18:02 |
jroll | and/or Shrews could | 18:03 |
jroll | we'll need to rebase uefi patch on top of tht | 18:03 |
*** pelix1 is now known as pelix | 18:04 | |
*** pelix is now known as 21WAA5HXD | 18:04 | |
Shrews | doh, i should have caught that import fail | 18:05 |
jroll | meh | 18:05 |
Shrews | +2'd again | 18:05 |
jroll | ok | 18:06 |
JayF | Shrews: YOU'RE pep8!? So nice to meet you, you much be so famous in python :P | 18:06 |
jroll | I wish my name wasn't on the commit | 18:06 |
jroll | UGH | 18:06 |
jroll | idk if I feel comfortable landing it with my name there | 18:06 |
Shrews | JayF: I am many things | 18:06 |
JayF | Shrews: (I never feel bad for catching things we have software to catch) | 18:06 |
Shrews | JayF: well, when I -1'd the previous set because of something closely tied to it... yeah, i failed | 18:07 |
jroll | I +2'd | 18:07 |
jroll | need jenkins | 18:07 |
jroll | :( | 18:07 |
NobodyCam | lol I'm good with it :) | 18:14 |
NobodyCam | hehehehe | 18:14 |
jroll | NobodyCam: we need to rebase uefi on top of thi | 18:15 |
jroll | s | 18:15 |
jroll | and abstract some things maybe :| | 18:15 |
*** todd_dsm has joined #openstack-ironic | 18:18 | |
NobodyCam | :-p | 18:21 |
NobodyCam | gah still no comments on 111425 :( | 18:22 |
jroll | NobodyCam: trying to figure out if these functions belong in dhcp provider thing: https://review.openstack.org/#/c/114357/10/ironic/common/neutron.py | 18:23 |
jroll | also, what should happen for the 'noop' provider | 18:23 |
jroll | like just return None? | 18:23 |
jroll | idk. | 18:24 |
*** 21WAA5HXD is now known as pelix | 18:24 | |
NobodyCam | jroll: ya. or empty what ever, ie. [],{}, '', blah | 18:25 |
jroll | right | 18:25 |
jroll | ok | 18:25 |
jroll | thanks | 18:25 |
jroll | I'm going to get lunch and then I'll rebase that | 18:25 |
jroll | and then we can land the heck out of it | 18:25 |
jroll | and be down to... 3 specs left? | 18:25 |
jroll | and 3 work days to complete them >:D | 18:25 |
NobodyCam | jroll: awesome | 18:27 |
NobodyCam | I will have no internets this weekend | 18:27 |
NobodyCam | please LAND what we need to :) (by hook or crook) | 18:27 |
jroll | I will be choosing to not use internet this weekend :) | 18:27 |
NobodyCam | :-p | 18:27 |
NobodyCam | 116871 looks good to go? | 18:29 |
NobodyCam | any objections to landing? | 18:29 |
* Shrews currently going over the drac reviews | 18:29 | |
NobodyCam | you already +2 it | 18:29 |
NobodyCam | lol | 18:29 |
Shrews | NobodyCam: there's another | 18:29 |
NobodyCam | yep! | 18:30 |
Shrews | nice to see our "Needs Approval" section growing today, though | 18:30 |
NobodyCam | :) | 18:31 |
NobodyCam | ahh the drac test are using mock_root = mock.Mock() | 18:37 |
NobodyCam | thou I'm okay with that for now, we can add decarator later (in another patch) | 18:38 |
*** todd_dsm has quit IRC | 18:39 | |
*** yuanying has joined #openstack-ironic | 18:41 | |
*** pelix has quit IRC | 18:42 | |
Shrews | reviewing unit tests makes my head hurt | 18:45 |
NobodyCam | esp xml based tests | 18:47 |
NobodyCam | tests that test xml really | 18:47 |
NobodyCam | :-p | 18:47 |
*** yuanying has quit IRC | 18:49 | |
*** eghobo has quit IRC | 18:54 | |
*** eghobo has joined #openstack-ironic | 18:54 | |
*** athomas has quit IRC | 18:56 | |
NobodyCam | brb | 18:56 |
NobodyCam | 112351 +a'd .... | 19:06 |
jroll | yesssssssss | 19:24 |
*** romcheg1 has quit IRC | 19:26 | |
openstackgerrit | A change was merged to openstack/ironic: DRAC wsman_{enumerate, invoke}() to return an ElementTree object https://review.openstack.org/116871 | 19:38 |
NobodyCam | And One Down! | 19:38 |
jroll | \o/ | 19:38 |
NobodyCam | :) so when will you have that rebase ready | 19:38 |
NobodyCam | I'll prob be heading out some time between 2 and 3 | 19:39 |
NobodyCam | would love to +a it before heading out | 19:39 |
NobodyCam | lol | 19:39 |
NobodyCam | :) | 19:39 |
jroll | heh, yeah | 19:39 |
jroll | going to step outside for a moment | 19:39 |
jroll | and then I'll take care of that | 19:39 |
jroll | got distracted for a bit | 19:39 |
NobodyCam | :) /e just got fresh batch of e juice | 19:39 |
NobodyCam | :) | 19:39 |
jroll | me too :D | 19:40 |
jroll | NobodyCam: before I go /me points you at http://www.vaportrailsnw.com/crunch-addict/ | 19:44 |
kylestev- | http://logs.openstack.org/76/117576/4/check/check-tempest-dsvm-ironic/0471daa/console.html#_2014-08-29_18_31_17_877 :( | 19:44 |
*** yuanying has joined #openstack-ironic | 19:46 | |
openstackgerrit | A change was merged to openstack/ironic: Make DHCP provider pluggable https://review.openstack.org/112351 | 19:48 |
kylestev- | looks like https://bugs.launchpad.net/openstack-ci/+bug/1352987 ugh time to recheck | 19:48 |
*** igordcard has quit IRC | 19:49 | |
NobodyCam | kylestev-: Welcome to the fun world of recheckes...lol :-p | 19:50 |
kylestev- | it's happened before | 19:50 |
kylestev- | so sad | 19:51 |
NobodyCam | jroll: thats not Captn crunch is it? really ...lol | 19:51 |
kylestev- | NobodyCam: it smells like it apparently | 19:52 |
NobodyCam | :-p | 19:52 |
NobodyCam | jroll: kylestev-: I like http://www.ecblendflavors.com | 19:53 |
*** yuanying has quit IRC | 19:55 | |
*** kylestev- has quit IRC | 20:02 | |
*** kylestev has joined #openstack-ironic | 20:03 | |
NobodyCam | I don't think its needed but any harm in line #46 of https://review.openstack.org/#/c/113865/14/ironic/drivers/ilo.py | 20:03 |
kylestev | there we go -- got my nick back lol | 20:03 |
NobodyCam | lol ya reconnects been waco this week | 20:03 |
NobodyCam | lost mine to myself twice | 20:03 |
kylestev | my bouncer wasn't relaying my ghost messages to freenode | 20:03 |
jroll | NobodyCam: it tastes just like crunchberries | 20:06 |
jroll | NobodyCam: I wouldn't -1 that line, but I would nit it for next patch | 20:06 |
NobodyCam | :( will -1 for in-consistent code | 20:13 |
*** Hefeweizin has quit IRC | 20:21 | |
NobodyCam | jroll: you thoughts on tests making changes to your local file system (in tmp)? I'm agenst it, and would be in favor of with a mock and check things are called correctly??? | 20:26 |
jroll | NobodyCam: +1, don't touch my filesystem | 20:27 |
NobodyCam | this is in ref to: https://review.openstack.org/#/c/113865/14/ironic/tests/test_utils.py | 20:27 |
NobodyCam | which will create and remove a temp dir | 20:27 |
jroll | yeah, don't do that :) | 20:27 |
NobodyCam | but I've been on systems where I couldn't create files in /tmp | 20:28 |
jroll | right | 20:28 |
jroll | totally agree | 20:28 |
*** romcheg1 has joined #openstack-ironic | 20:29 | |
jroll | NobodyCam: this is a heck of a rebase | 20:44 |
NobodyCam | :( | 20:45 |
jroll | I hope this all works | 20:46 |
jroll | tests pass so everything is fine, right? :P | 20:46 |
NobodyCam | lol :/ | 20:46 |
jroll | I'll make sure it works | 20:46 |
jroll | just had to bring two new functions into the dhcp factory thing | 20:47 |
*** yuanying has joined #openstack-ironic | 20:51 | |
jroll | NobodyCam: https://review.openstack.org/#/c/114357/10/ironic/common/pxe_utils.py | 20:52 |
jroll | NobodyCam: these rely on a good IP address, I think | 20:52 |
jroll | so for the noop provider, should I return '0.0.0.0' or something, rather than None? | 20:53 |
jroll | JayF: ^^ if you have a sec | 20:53 |
NobodyCam | jroll: yes, return a valid nothing | 20:53 |
jroll | ok, cool | 20:54 |
NobodyCam | thou 0.0.0.0 could be all ips | 20:54 |
jroll | this might still need more tests but I'm going to upload it now | 20:54 |
JayF | Um. | 20:54 |
JayF | Very no | 20:54 |
JayF | return 255.255.255.255 | 20:54 |
JayF | or nothing at all | 20:54 |
jroll | it's not a mask | 20:55 |
jroll | but... ok | 20:55 |
JayF | preferably lets not pass around invalid IPs? Just handle it properly? | 20:55 |
jroll | it's more like a dummy IP | 20:55 |
JayF | Like why shouldn't it return None or something similar if that's the truth? | 20:55 |
JayF | Then use something in the documentation prefix | 20:55 |
jroll | now this makes me curious, what if there is no assigned ip | 20:55 |
jroll | how does this blow up | 20:55 |
JayF | yeah exactly | 20:55 |
* jroll sigh | 20:55 | |
JayF | None should be a valid return, even if it breaks the uefi boot | 20:55 |
JayF | like the UEFI boot stuff should know not to put down an elilo config if dhcp provider is noop, right? | 20:56 |
jroll | yeah, probably | 20:56 |
* jroll adds a test for None | 20:56 | |
*** shakamunyi has quit IRC | 20:58 | |
NobodyCam | hummm... does CONF.conductor.api_url need to be imported for line #198 | 20:59 |
*** yuanying has quit IRC | 20:59 | |
NobodyCam | of https://review.openstack.org/#/c/115885/5/ironic/drivers/modules/ilo/deploy.py | 21:00 |
NobodyCam | oh guess I should actually hit <enter> | 21:01 |
NobodyCam | lol | 21:01 |
jroll | lol | 21:02 |
*** romcheg1 has quit IRC | 21:03 | |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Add UEFI based deployment support in Ironic https://review.openstack.org/114357 | 21:16 |
jroll | NobodyCam: ^^ | 21:16 |
jroll | don't approve that yet, going to -1 | 21:16 |
jroll | pretty sure it will fail miserably on noop dhcp provider | 21:16 |
jroll | but please do review, otherwise | 21:16 |
NobodyCam | want to add :param task: A TaskManager instance. to doc string of def dhcp_options_for_instance(task): | 21:33 |
*** bandicot has quit IRC | 21:33 | |
jroll | NobodyCam: yeah | 21:34 |
jroll | also, cleaned some stuff up, this should work now | 21:34 |
jroll | maybe | 21:34 |
* jroll checks one more thing | 21:34 | |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Add UEFI based deployment support in Ironic https://review.openstack.org/114357 | 21:36 |
jroll | NobodyCam: ^^ fixed up | 21:37 |
* jroll brb | 21:37 | |
NobodyCam | gah wasn't even done with the last rev ...lol | 21:37 |
jroll | ha, it's pretty close | 21:37 |
jroll | I just made `get_fixed_ip_address` a private method for neutron only | 21:37 |
jroll | and return None for noop provider | 21:37 |
jroll | the unlink_without_raise stuff sohuld handle that ok | 21:38 |
jroll | please tell me otherwise if Im' crazy | 21:38 |
*** penick has quit IRC | 21:40 | |
*** lucas-dinner has quit IRC | 21:43 | |
NobodyCam | Quick read looks ok but I think I need to understand the tests better... | 21:44 |
*** penick has joined #openstack-ironic | 21:45 | |
NobodyCam | Not sure I'll be able to get a good review done in time | 21:45 |
*** marzif__ has joined #openstack-ironic | 21:45 | |
*** penick has quit IRC | 21:45 | |
*** eguz has joined #openstack-ironic | 21:47 | |
*** dlaube1 has joined #openstack-ironic | 21:49 | |
*** eghobo has quit IRC | 21:50 | |
*** penick has joined #openstack-ironic | 21:51 | |
*** boris-42_ has joined #openstack-ironic | 21:51 | |
*** dividebin has joined #openstack-ironic | 21:51 | |
*** sirushti_ has joined #openstack-ironic | 21:51 | |
*** dlaube has quit IRC | 21:52 | |
*** boris-42 has quit IRC | 21:52 | |
*** sirushti has quit IRC | 21:52 | |
*** marzif_ has quit IRC | 21:52 | |
*** notq has quit IRC | 21:52 | |
*** annegentle has quit IRC | 21:52 | |
*** dividehex has quit IRC | 21:52 | |
*** antonym has quit IRC | 21:52 | |
*** sirushti_ is now known as sirushti | 21:52 | |
*** yuanying has joined #openstack-ironic | 21:56 | |
jroll | NobodyCam: no worries if you can't, I suspect we won't get a second +2 today | 22:00 |
NobodyCam | :) | 22:03 |
NobodyCam | starting to the get ready to go things. so will be signing off shortly | 22:04 |
jroll | ok :) | 22:04 |
jroll | if I step away or something, have a great weekend :) | 22:04 |
NobodyCam | If you can land the things we need, | 22:04 |
*** Haomeng|2 has joined #openstack-ironic | 22:04 | |
NobodyCam | you too jroll | 22:04 |
*** yuanying has quit IRC | 22:04 | |
NobodyCam | lucas has hte monday meeting | 22:04 |
*** Haomeng has quit IRC | 22:05 | |
NobodyCam | if I am able to get internets I will prob log in but that is in question atm | 22:05 |
jroll | yeah, I may or may not join, depends what $SO wants to do :) | 22:06 |
*** annegentle has joined #openstack-ironic | 22:11 | |
*** dlaube has joined #openstack-ironic | 22:11 | |
*** 17SAA2D8D has joined #openstack-ironic | 22:11 | |
*** notq has joined #openstack-ironic | 22:11 | |
*** antonym has joined #openstack-ironic | 22:11 | |
*** dlaube has quit IRC | 22:12 | |
*** 17SAA2D8D has quit IRC | 22:12 | |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Remove gettextutils _ injection https://review.openstack.org/110634 | 22:37 |
*** penick has quit IRC | 22:40 | |
*** penick has joined #openstack-ironic | 22:46 | |
*** igordcard has joined #openstack-ironic | 22:47 | |
*** lifeless1 is now known as lifeless | 22:56 | |
*** penick has quit IRC | 22:58 | |
jroll | need to update this to implemented: https://blueprints.launchpad.net/ironic/+spec/support-external-dhcp | 23:00 |
*** yuanying has joined #openstack-ironic | 23:01 | |
*** penick has joined #openstack-ironic | 23:06 | |
*** yuanying has quit IRC | 23:09 | |
*** penick has quit IRC | 23:22 | |
*** igordcard has quit IRC | 23:30 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!