| jroll | mrda: np :) | 00:04 |
|---|---|---|
| *** todd_dsm has quit IRC | 00:05 | |
| *** eghobo has quit IRC | 00:07 | |
| *** aswadr has joined #openstack-ironic | 00:10 | |
| jroll | aweeks: did you want me to WIP that horizon patch that's in my name? | 00:11 |
| aweeks | jroll: yeah, that would be good | 00:12 |
| aweeks | jroll: it doesn't look like its possible to change the owner of a patch in gerrit | 00:12 |
| aweeks | perhaps I should just create a new one | 00:12 |
| jroll | done | 00:12 |
| jroll | it doesn't :( | 00:12 |
| jroll | if you want, go ahead, it's up to you | 00:12 |
| aweeks | to avoid this happening in the future | 00:12 |
| jroll | I'm happy to help as well | 00:12 |
| aweeks | think I'll do that, but thanks anyways | 00:12 |
| jroll | mmmkay | 00:12 |
| openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic: Improve IPA client library https://review.openstack.org/111118 | 00:38 |
| *** russellb has quit IRC | 00:46 | |
| *** wendar has quit IRC | 00:47 | |
| JayF | JoshNang: kylestev https://review.openstack.org/#/c/111118/7/ironic/drivers/modules/agent.py,cm | 00:47 |
| JayF | is what I'm talking about :) | 00:47 |
| *** wendar has joined #openstack-ironic | 00:47 | |
| *** russellb has joined #openstack-ironic | 00:49 | |
| *** Haomeng|2 has quit IRC | 01:22 | |
| *** todd_dsm has joined #openstack-ironic | 01:24 | |
| *** rloo has quit IRC | 01:32 | |
| *** lazy_prince has quit IRC | 01:33 | |
| *** Haomeng has joined #openstack-ironic | 01:47 | |
| *** nosnos has joined #openstack-ironic | 01:54 | |
| *** todd_dsm has quit IRC | 01:58 | |
| *** r-daneel has quit IRC | 02:02 | |
| *** yuanying has quit IRC | 02:02 | |
| *** yuanying has joined #openstack-ironic | 02:02 | |
| *** harlowja is now known as harlowja_away | 02:25 | |
| *** pcrews has quit IRC | 02:36 | |
| openstackgerrit | A change was merged to openstack/ironic: Translator functions cleanup part 4 https://review.openstack.org/118591 | 02:46 |
| *** Poornima has joined #openstack-ironic | 02:47 | |
| *** ramineni has joined #openstack-ironic | 02:57 | |
| *** chenglch|2 has joined #openstack-ironic | 03:06 | |
| *** anderbubble has quit IRC | 03:23 | |
| openstackgerrit | A change was merged to openstack/ironic: Fix compute_driver and scheduler_host_manager in install-guide https://review.openstack.org/119937 | 03:27 |
| *** killer_prince has joined #openstack-ironic | 03:48 | |
| *** killer_prince is now known as lazy_prince | 03:48 | |
| openstackgerrit | Yuiko Takada proposed a change to openstack/python-ironicclient: Add unit tests for "ironic node-create" shell cmd https://review.openstack.org/120312 | 04:01 |
| *** rushiagr_away is now known as rushiagr | 04:40 | |
| *** Poornima has quit IRC | 04:45 | |
| *** Nisha has joined #openstack-ironic | 05:03 | |
| *** nikunj2512 has joined #openstack-ironic | 05:15 | |
| *** Poornima has joined #openstack-ironic | 05:16 | |
| *** lazy_prince has quit IRC | 05:22 | |
| *** lazy_prince has joined #openstack-ironic | 05:23 | |
| *** jcoufal has joined #openstack-ironic | 05:39 | |
| *** k4n0 has joined #openstack-ironic | 05:45 | |
| *** rakesh_hs has joined #openstack-ironic | 05:59 | |
| *** pradipta_away is now known as pradipta | 06:03 | |
| *** chenglch|4 has joined #openstack-ironic | 06:04 | |
| *** chenglch|2 has quit IRC | 06:04 | |
| *** pradipta is now known as pradipta_away | 06:16 | |
| *** rushiagr is now known as rushiagr_away | 06:48 | |
| *** rushiagr_away is now known as rushiagr | 06:49 | |
| *** athomas has joined #openstack-ironic | 06:51 | |
| *** ifarkas has joined #openstack-ironic | 06:53 | |
| mrda | Night Ironic. TTY mid-October :) | 06:58 |
| *** mrda is now known as mrda-vacation | 06:58 | |
| *** k4n0 has quit IRC | 07:07 | |
| Haomeng | mrda: night:) | 07:12 |
| *** dtantsur|afk is now known as dtantsur | 07:13 | |
| dtantsur | Morning Ironic | 07:14 |
| *** k4n0 has joined #openstack-ironic | 07:22 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/120326 | 07:26 |
| *** bluex-pl has joined #openstack-ironic | 07:28 | |
| Haomeng | dtantsur: morning:) | 07:29 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic: Updated from global requirements https://review.openstack.org/120326 | 07:34 |
| *** ndipanov_gone is now known as ndipanov | 07:39 | |
| *** jistr has joined #openstack-ironic | 07:39 | |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Implement hardware discovery in PXE driver https://review.openstack.org/110031 | 07:47 |
| *** bluex-pl has quit IRC | 08:04 | |
| *** derekh has joined #openstack-ironic | 08:07 | |
| *** bluex-pl has joined #openstack-ironic | 08:19 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Unify the sensor data format https://review.openstack.org/120339 | 08:20 |
| *** lucasagomes has joined #openstack-ironic | 08:20 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Unify the sensor data format https://review.openstack.org/120339 | 08:23 |
| *** igordcard has joined #openstack-ironic | 08:36 | |
| *** lazy_prince is now known as killer_prince | 08:56 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Sync the document with current implements https://review.openstack.org/120346 | 08:58 |
| *** killer_prince has quit IRC | 08:58 | |
| *** lazy_prince has joined #openstack-ironic | 08:58 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Sync the document with current implements https://review.openstack.org/120346 | 08:59 |
| *** rushiagr is now known as rushiagr_away | 09:18 | |
| *** rushiagr_away is now known as rushiagr | 09:18 | |
| *** pelix has joined #openstack-ironic | 09:32 | |
| *** MattMan has joined #openstack-ironic | 09:33 | |
| *** nosnos has quit IRC | 09:41 | |
| *** nosnos has joined #openstack-ironic | 09:42 | |
| *** nosnos has quit IRC | 09:47 | |
| *** andreykurilin has joined #openstack-ironic | 09:47 | |
| *** bluex-pl has quit IRC | 09:47 | |
| *** dtantsur is now known as dtantsur|brb | 10:00 | |
| *** bluex-pl has joined #openstack-ironic | 10:03 | |
| *** Nisha has quit IRC | 10:08 | |
| *** chenglch|4 has quit IRC | 10:24 | |
| *** lazy_prince is now known as killer_prince | 10:38 | |
| mrda-vacation | yay! 119944 merged! | 10:51 |
| * mrda-vacation is hoping that ironic via the nova driver now works | 10:51 | |
| *** killer_prince is now known as lazy_prince | 10:55 | |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Unify the sensor data format https://review.openstack.org/120339 | 10:56 |
| openstackgerrit | Haomeng,Wang proposed a change to openstack/ironic: Sync the document with the current implementation https://review.openstack.org/120346 | 11:01 |
| *** Poornima has quit IRC | 11:02 | |
| *** ramineni has quit IRC | 11:06 | |
| *** viktors|afk is now known as viktors | 11:09 | |
| *** nikunj2512 has quit IRC | 11:09 | |
| *** lucasagomes is now known as lucas-hungry | 11:22 | |
| *** lazy_prince is now known as killer_prince | 11:23 | |
| *** Poornima has joined #openstack-ironic | 11:26 | |
| *** vdrok_afk is now known as vdrok | 11:29 | |
| openstackgerrit | Vladyslav Drok proposed a change to openstack/ironic: Remove unused modules from openstack-common.conf https://review.openstack.org/120098 | 11:32 |
| *** ekarlso- has quit IRC | 11:37 | |
| *** ekarlso- has joined #openstack-ironic | 11:37 | |
| *** bluex-pl has quit IRC | 11:55 | |
| *** dprince has joined #openstack-ironic | 12:02 | |
| *** killer_prince is now known as lazy_prince | 12:11 | |
| *** lazy_prince has quit IRC | 12:17 | |
| *** lazy_prince has joined #openstack-ironic | 12:18 | |
| *** lazy_prince has joined #openstack-ironic | 12:18 | |
| *** linggao has joined #openstack-ironic | 12:30 | |
| *** linggao_ has joined #openstack-ironic | 12:30 | |
| *** linggao has quit IRC | 12:30 | |
| *** lucas-hungry is now known as lucasagomes | 12:32 | |
| *** jcoufal has quit IRC | 12:35 | |
| *** jcoufal has joined #openstack-ironic | 12:36 | |
| *** jcoufal_ has joined #openstack-ironic | 12:38 | |
| *** jcoufal has quit IRC | 12:38 | |
| *** rainya has joined #openstack-ironic | 12:39 | |
| *** rainya has quit IRC | 12:39 | |
| *** bluex-pl has joined #openstack-ironic | 12:39 | |
| *** jcoufal_ has quit IRC | 12:39 | |
| *** jcoufal has joined #openstack-ironic | 12:40 | |
| *** rainya has joined #openstack-ironic | 12:40 | |
| *** rainya has quit IRC | 12:42 | |
| *** rainya has joined #openstack-ironic | 12:42 | |
| *** rainya has quit IRC | 12:43 | |
| *** jcoufal has quit IRC | 12:45 | |
| *** jcoufal has joined #openstack-ironic | 12:45 | |
| *** athomas has quit IRC | 12:46 | |
| *** athomas has joined #openstack-ironic | 12:46 | |
| *** ifarkas has quit IRC | 12:57 | |
| *** dtantsur|brb is now known as dtantsur | 13:02 | |
| *** ifarkas has joined #openstack-ironic | 13:05 | |
| openstackgerrit | Mike Durnosvistov proposed a change to openstack/ironic: Check whether specified FS is supported https://review.openstack.org/98102 | 13:08 |
| jroll | morning ironic :) | 13:22 |
| jroll | mrda-vacation: have a blast dude :D | 13:22 |
| NobodyCam | goot en morgen taug Ironic | 13:24 |
| jroll | NobodyCam: we need to be practicing french, not german | 13:25 |
| jroll | and good morning :) | 13:25 |
| lucasagomes | morning jroll NobodyCam | 13:25 |
| NobodyCam | lol | 13:25 |
| NobodyCam | morning jroll and lucasagomes | 13:25 |
| jroll | heya lucas :) | 13:26 |
| lucasagomes | my french sucks as well | 13:26 |
| lucasagomes | maidin mhaith NobodyCam :) | 13:26 |
| jroll | don't feel bad, I know all of like 3 phrases | 13:26 |
| lucasagomes | heh, it's not needed anyway people speak english over there | 13:27 |
| lucasagomes | well mostly young ppl | 13:27 |
| *** lazy_prince is now known as killer_prince | 13:28 | |
| jroll | ye | 13:28 |
| NobodyCam | so google says I should be saying bonjour | 13:28 |
| lucasagomes | heh yeah that's irish not french | 13:28 |
| jroll | lol | 13:28 |
| lucasagomes | NobodyCam, jroll btw, next week we are going to know whether we graduated or not | 13:29 |
| lucasagomes | maybe we should come up with some hoodies in case we _do_ graduate? | 13:30 |
| NobodyCam | lol | 13:30 |
| NobodyCam | I was just reading the thread about the api proxy. | 13:30 |
| lucasagomes | yeah, we might not need it | 13:30 |
| lucasagomes | which is good, less work | 13:30 |
| *** Nisha has joined #openstack-ironic | 13:30 | |
| jroll | lucasagomes: I'm happy to find any reason to have a new hoodie :D | 13:31 |
| lucasagomes | NobodyCam, but maybe propose the code to nova and post the link on the ML just to show good faith idk | 13:31 |
| lucasagomes | we have the code already so | 13:31 |
| lucasagomes | jroll, heh +1, idk how it would be if we don't graduate thou | 13:31 |
| Nisha | Hi Luca | 13:31 |
| Nisha | lucasagomes: | 13:31 |
| lucasagomes | sometihng like "F*ck TC and I'm not being Ironic" | 13:31 |
| Nisha | * | 13:31 |
| NobodyCam | lol ya, anyone able to get the nova unit test to un on a MAC? | 13:32 |
| jroll | LOL | 13:32 |
| dtantsur | morning jroll, NobodyCam, Nisha | 13:32 |
| lucasagomes | Nisha, hey there | 13:32 |
| NobodyCam | morning dtantsur | 13:32 |
| jroll | NobodyCam: I personally wouldn't even bother trying | 13:32 |
| NobodyCam | and Nisha | 13:32 |
| dtantsur | folks, where do we store deploy kernel/ramdisk ID's now? | 13:32 |
| NobodyCam | I cant seem to get them to run | 13:32 |
| jroll | morning Nisha dtantsur | 13:33 |
| jroll | dtantsur: driver_info | 13:33 |
| NobodyCam | I tried for a hour last night and even pinged in -nova | 13:33 |
| lucasagomes | dtantsur, driver_info | 13:33 |
| lucasagomes | before was in the flavor | 13:33 |
| dtantsur | thanks. so https://review.openstack.org/#/c/118614/4/doc/source/deploy/install-guide.rst is wrong right now, will let know | 13:33 |
| lucasagomes | dtantsur, yeah, well there's a backward compat layer | 13:34 |
| lucasagomes | but I would prefer to point to driver_info | 13:34 |
| lucasagomes | because that compat layer may go away in K | 13:34 |
| dtantsur | lucasagomes, I'd prefer our new shine docs to mention the right way :) | 13:34 |
| lucasagomes | yup | 13:34 |
| jroll | +1 | 13:35 |
| Nisha | yes | 13:35 |
| Nisha | lucasagomes: dtantsur I was going through the comments | 13:35 |
| Nisha | on https://review.openstack.org/#/c/116561/ | 13:35 |
| dtantsur | right | 13:36 |
| openstackgerrit | David Shrewsbury proposed a change to openstack/ironic: (EXPERIMENTAL) Add support for dox https://review.openstack.org/120413 | 13:36 |
| Shrews | jroll: ^^^^ | 13:36 |
| jroll | \o/ | 13:37 |
| * jroll plays | 13:37 | |
| Shrews | jroll: problem right now is dox logs you in as non-root, so those commands fail | 13:37 |
| JoshNang | Shrews: :O sweeeeeeet | 13:37 |
| jroll | Shrews: isn't there a `setup` section for that? | 13:37 |
| lucasagomes | dox?! | 13:37 |
| Shrews | jroll: there is a 'prep' section for building the container | 13:37 |
| * lucasagomes reads | 13:37 | |
| dtantsur | oh what is it? | 13:38 |
| jroll | Shrews: ah, yeah, https://github.com/openstack/zaqar/blob/master/dox.yml#L8 | 13:38 |
| jroll | dtantsur: dox is tox but s/virtualenv/docker/ | 13:38 |
| jroll | (or that's the goal, it's super early) | 13:38 |
| dtantsur | wow never heard | 13:38 |
| *** rainya has joined #openstack-ironic | 13:38 | |
| Shrews | jroll: but the source directory for ironic is not yet mounted during prep | 13:38 |
| lucasagomes | heh | 13:39 |
| jroll | dtantsur: super new | 13:39 |
| JoshNang | dtantsur: one of the goals seems to be avoiding "recreating virtualenv, come back in 15 mins" | 13:39 |
| jroll | Shrews: so how does that work for zaqar | 13:39 |
| *** Nisha_ has joined #openstack-ironic | 13:39 | |
| lucasagomes | JoshNang, pip cache? | 13:39 |
| Shrews | jroll: i don't think they're running unit tests | 13:39 |
| Nisha_ | I was thinking it would be better to add mkisofs as a requirement in the global requirements.txt file rather than handling it in exception | 13:39 |
| lucasagomes | I mean I'm not against it, it sounds cool | 13:39 |
| jroll | JoshNang: PIP_DOWNLOAD_CACHE ftw | 13:39 |
| lucasagomes | but pip cache helps a lot :) | 13:39 |
| dtantsur | would be nice, though I don't like these 'apt-get install' :) | 13:39 |
| jroll | Shrews: oh. | 13:39 |
| jroll | dtantsur: that's done in the docker container | 13:39 |
| Shrews | jroll: at least, not what i could discern from their .yml | 13:39 |
| JoshNang | lucasagomes: jroll definitely. but this skips all installs too | 13:39 |
| NobodyCam | morning Shrews | 13:40 |
| NobodyCam | and JoshNang | 13:40 |
| Shrews | NobodyCam: morning | 13:40 |
| * jroll hrm | 13:40 | |
| JoshNang | NobodyCam: morning! | 13:40 |
| *** Nisha has quit IRC | 13:40 | |
| Nisha_ | NobodyCam: morning | 13:40 |
| jroll | Shrews: commands: python setup.py testr --slowest | 13:40 |
| Shrews | jroll: ?? | 13:40 |
| NobodyCam | Shrews: you run on a mac don't you? | 13:40 |
| lucasagomes | Nisha_, I don't know if that's possible tho | 13:40 |
| jroll | that's in zaqar's dockerfile | 13:40 |
| jroll | Shrews: ^ | 13:40 |
| Nisha_ | lucasagomes: do you see any issue with that | 13:41 |
| lucasagomes | Nisha_, there's no way to install mkisofs via pip | 13:41 |
| lucasagomes | which is what global requirements does | 13:41 |
| Nisha_ | i can handle it in exception but then we actually dont provide uefi support | 13:41 |
| Nisha_ | because image will not have uefi support | 13:42 |
| lucasagomes | Nisha_, you need a specific version of mkisofs? | 13:42 |
| lucasagomes | yeah we can test it in code see if the mkisofs supports the UEFI option and fail if it does | 13:42 |
| lucasagomes | but also document it | 13:42 |
| Nisha_ | lucasagomes: understood...but then how do we handle it | 13:42 |
| lucasagomes | Nisha_, we have something similar to ipmitool AFAIK | 13:43 |
| * lucasagomes lemme find | 13:43 | |
| Nisha_ | do you mean we should handle it in exception? | 13:43 |
| Nisha_ | hmmm | 13:43 |
| Nisha_ | ok | 13:43 |
| lucasagomes | Nisha_, https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L116-L137 | 13:43 |
| lucasagomes | Shrews, cool was mordred that started dox then | 13:45 |
| lucasagomes | ? | 13:45 |
| Shrews | lucasagomes: yes | 13:45 |
| lucasagomes | yeah handling other stuff apart from pip installs (e.g packages) sounds pretty good | 13:46 |
| Shrews | NobodyCam: yes, i use mac's too. neat thing is, we'd be able to use dox to run the unit tests on macs now! | 13:46 |
| Nisha_ | lucasgomes: Ok i would try to do this way. But then if option is not supported, then it should raise an exception | 13:46 |
| Nisha_ | ? | 13:46 |
| jroll | lucasagomes: http://blog.chmouel.com/2014/09/08/dox-a-tool-that-run-python-or-others-tests-in-a-docker-container/ | 13:46 |
| lucasagomes | jroll, ty | 13:46 |
| *** rainya has quit IRC | 13:47 | |
| lucasagomes | Nisha_, yeah... well we can do it on the validate, if it's uefi and the mkisofs doesn't support it | 13:47 |
| lucasagomes | we can capture the problem before trying to deploy the node | 13:47 |
| Nisha_ | ok. | 13:47 |
| Nisha_ | Thanks. I will address the comments and post the patch for review asapp | 13:48 |
| lucasagomes | Nisha_, ta much | 13:48 |
| *** killer_prince has quit IRC | 13:49 | |
| *** lazy_prince has joined #openstack-ironic | 13:49 | |
| NobodyCam | Shrews: dox? | 13:49 |
| openstackgerrit | A change was merged to openstack/ironic: Remove unused modules from openstack-common.conf https://review.openstack.org/120098 | 13:50 |
| openstackgerrit | A change was merged to openstack/python-ironicclient: Work toward Python 3.4 support and testing https://review.openstack.org/118801 | 13:50 |
| jroll | NobodyCam: http://blog.chmouel.com/2014/09/08/dox-a-tool-that-run-python-or-others-tests-in-a-docker-container/ | 13:50 |
| NobodyCam | Shrews: the game emulator | 13:50 |
| NobodyCam | oh docker | 13:51 |
| NobodyCam | lol | 13:51 |
| NobodyCam | there is a dox too | 13:51 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add list_by_node_id() to Port object https://review.openstack.org/120422 | 13:54 |
| lucasagomes | NobodyCam, jroll who is working on the migration docs? | 13:55 |
| lucasagomes | I mean, there's someone already working on it? | 13:56 |
| NobodyCam | lucasagomes: https://etherpad.openstack.org/p/IronicMigration | 13:56 |
| lucasagomes | I c | 13:57 |
| NobodyCam | adam_g: and devananda started working on it lastnight | 13:57 |
| lucasagomes | ty | 13:57 |
| * NobodyCam hates what his employeer is doing to their vpn sign on process :-p | 13:58 | |
| jroll | NobodyCam: :( | 13:59 |
| NobodyCam | lol it just doesn't work | 13:59 |
| jroll | yeah | 13:59 |
| jroll | internal security things almost never work, in my experience | 14:00 |
| *** athomas has quit IRC | 14:00 | |
| NobodyCam | lucasagomes: may be worth adding link to ML thread | 14:00 |
| lucasagomes | NobodyCam, nice, yah will do | 14:00 |
| *** Nisha_ has quit IRC | 14:02 | |
| lucasagomes | heh https://lh3.googleusercontent.com/-b5EWJrw9QHo/VBBNC-I6CVI/AAAAAAAALLQ/C17OA9768WY/w1250-h853-no/iphone-troll.jpg | 14:04 |
| dtantsur | lol just tweeted this one :) | 14:05 |
| Shrews | that's so trending on reddit | 14:05 |
| lucasagomes | heh just saw now on g+ | 14:05 |
| NobodyCam | lol | 14:06 |
| *** athomas has joined #openstack-ironic | 14:09 | |
| *** pcrews has joined #openstack-ironic | 14:15 | |
| jroll | shall we go ahead and land this? :) https://review.openstack.org/#/c/119892/ | 14:15 |
| *** linggao has joined #openstack-ironic | 14:16 | |
| Shrews | ummm... no | 14:17 |
| Shrews | we need to give tripleo time to adjust, no? | 14:17 |
| jroll | no, that's why that patch does what it does | 14:18 |
| jroll | it basically proxies the driver in ironic's tree to the driver in nova's tree | 14:18 |
| Shrews | oh. /me is behind | 14:19 |
| jroll | :) | 14:19 |
| jroll | would be nice to have tripleo passing tests though | 14:20 |
| jroll | no idea how to debug tripleo fails | 14:20 |
| NobodyCam | lucasagomes: https://review.openstack.org/#/c/120433 | 14:27 |
| *** rwsu has joined #openstack-ironic | 14:30 | |
| openstackgerrit | A change was merged to openstack/ironic: Unify the sensor data format https://review.openstack.org/120339 | 14:33 |
| openstackgerrit | Dmitry Tantsur proposed a change to openstack/ironic: EXPERIMENTAL Implement hardware discovery in PXE driver https://review.openstack.org/110031 | 14:33 |
| lucasagomes | NobodyCam, nice | 14:35 |
| lucasagomes | NobodyCam, sent to the ML so ppl can take a look? | 14:36 |
| lucasagomes | NobodyCam, ah sean just did it | 14:36 |
| lucasagomes | :) | 14:36 |
| NobodyCam | lol | 14:36 |
| NobodyCam | i must just be slow this morning ..hehehe | 14:37 |
| *** dhellmann is now known as dhellmann_ | 14:39 | |
| *** dhellmann_ is now known as dhellmann | 14:40 | |
| bluex-pl | jroll: hi, made changes and tests as requested in https://review.openstack.org/#/c/117529/ | 14:43 |
| bluex-pl | I would be glad if you could take a look :) | 14:44 |
| jroll | bluex-pl: will do today | 14:46 |
| *** rwsu has quit IRC | 14:48 | |
| *** Nisha has joined #openstack-ironic | 14:50 | |
| bluex-pl | thanks | 14:50 |
| *** bluex-pl has quit IRC | 14:55 | |
| *** rakesh_hs has quit IRC | 15:00 | |
| *** andreykurilin has quit IRC | 15:04 | |
| NobodyCam | lucasagomes: ack and thank you for the comments I will address them shortly | 15:04 |
| *** rainya has joined #openstack-ironic | 15:05 | |
| lucasagomes | NobodyCam, yvw, np | 15:05 |
| *** rainya has quit IRC | 15:05 | |
| NobodyCam | brb | 15:20 |
| *** dtantsur is now known as dtantsur|brb | 15:22 | |
| *** rainya has joined #openstack-ironic | 15:23 | |
| *** k4n0 has quit IRC | 15:34 | |
| *** Poornima has quit IRC | 15:35 | |
| *** ramineni has joined #openstack-ironic | 15:36 | |
| *** andreykurilin has joined #openstack-ironic | 15:40 | |
| *** ifarkas has quit IRC | 15:44 | |
| lazy_prince | morgabra: ping | 15:50 |
| devananda | mornin, all | 15:54 |
| NobodyCam | good morning mr devananda | 15:56 |
| *** rloo has joined #openstack-ironic | 15:57 | |
| devananda | NobodyCam: would it be fair to say your nova patch to proxy the API is an untested initial draft? | 16:06 |
| devananda | NobodyCam: also - have you tested it? | 16:06 |
| *** datajerk has joined #openstack-ironic | 16:07 | |
| *** jistr has quit IRC | 16:07 | |
| NobodyCam | I tested the first versions of it | 16:08 |
| NobodyCam | this latest one I have not | 16:08 |
| NobodyCam | I am addressing the comments on it now | 16:08 |
| devananda | ah, k | 16:09 |
| lucasagomes | devananda, morning | 16:09 |
| devananda | lucasagomes: evening! :) | 16:09 |
| devananda | NobodyCam: fwiw, I'm in favor of not adding it to Nova, but let's just see what they decide | 16:09 |
| NobodyCam | devananda: http://paste.openstack.org/show/HIV6fjsAEO6YFa14BgWs/ | 16:10 |
| NobodyCam | devananda: ack... thats my hope as well | 16:10 |
| *** rwsu has joined #openstack-ironic | 16:12 | |
| NobodyCam | sorry that was a bad link I just pasted: see http://paste.openstack.org/show/Em861wMwFvrFlsWkugfX | 16:12 |
| devananda | NobodyCam: awesome. also - I hate that we store SSH keys | 16:15 |
| devananda | *private keys | 16:16 |
| devananda | *in plain text | 16:16 |
| NobodyCam | :( this patch will not address that issue :- | 16:16 |
| devananda | NobodyCam: I think it's worth replying to the thread with an example of the output -- do you want to do that, or shall I ? | 16:16 |
| devananda | I know - just griping about it | 16:17 |
| *** ndipanov has quit IRC | 16:17 | |
| NobodyCam | hehe I can do that | 16:18 |
| devananda | NobodyCam: also, what about interfaces? I don't see any proxying of those | 16:20 |
| devananda | NobodyCam: eg, "nova baremetal-interface-list" | 16:20 |
| NobodyCam | oh I didn't do that one.. only node [list|show] I can add that fairly quickly... please post a comment on the nova review for that | 16:23 |
| NobodyCam | and I'll add it | 16:23 |
| NobodyCam | (asking for the comment so others can also see it is requested) | 16:23 |
| *** ramineni has quit IRC | 16:24 | |
| *** todd_dsm has joined #openstack-ironic | 16:24 | |
| *** viktors is now known as viktors|afk | 16:28 | |
| *** todd_dsm has quit IRC | 16:35 | |
| Nisha | lucasagomes: hi | 16:36 |
| *** todd_dsm has joined #openstack-ironic | 16:36 | |
| lucasagomes | Nisha, hi there | 16:40 |
| devananda | NobodyCam: oh. maybe it's not requested? just seems to be missing, to me | 16:43 |
| Nisha | I was trying to check if the option supported could be validated in validate() but it would require to run the mkisofs() with valid arguments, which are populated in create_isolinux_image() | 16:44 |
| NobodyCam | I thought it was only the node comamnds but Iam happy to add it | 16:44 |
| Nisha | where already we catch the exception | 16:44 |
| *** jcoufal has quit IRC | 16:45 | |
| *** todd_dsm has quit IRC | 16:45 | |
| lucasagomes | Nisha, hmm I see | 16:46 |
| lucasagomes | Nisha, well we can add a comment explaining | 16:46 |
| lucasagomes | Nisha, but and if u check the version of it? | 16:46 |
| lucasagomes | Nisha, or --help to find whether the option you're looking for is present | 16:47 |
| Nisha | lucasagomes: you mean in code i check with the --help? | 16:47 |
| dprince | send me https://review.openstack.org/#/c/119892/ | 16:47 |
| lucasagomes | Nisha, yup | 16:48 |
| dprince | ^^^ DO IT! | 16:48 |
| Nisha | lucasagomes: that can be done | 16:48 |
| Nisha | lucasagomes: thanks | 16:48 |
| jroll | dprince: you want that landed? :) | 16:48 |
| * jroll is happy to push buttons | 16:48 | |
| dprince | jroll: yes! | 16:48 |
| jroll | dprince: or you want tripleo to pass | 16:48 |
| jroll | heh | 16:48 |
| jroll | ok | 16:48 |
| jroll | dprince: you're sure that tripleo failure is ok? | 16:49 |
| lucasagomes | dprince,ohh yeah | 16:49 |
| jroll | I don't want to break y'all again :( | 16:49 |
| dprince | jroll: also, once that lands can you remove your -1 here https://review.openstack.org/#/c/120099/ | 16:49 |
| jroll | yep, will do | 16:49 |
| dprince | jroll: I can double check tripleO. | 16:50 |
| jroll | gah | 16:50 |
| dprince | jroll: but we are already broken anyways, | 16:50 |
| jroll | too late :P | 16:50 |
| jroll | ohhh | 16:50 |
| jroll | ok, then | 16:50 |
| dprince | jroll: using the nova driver is the only way forward cause you guys blocked everything (and we forced Ironic to break itself during the Nova review process) | 16:51 |
| jroll | +a'd 119892, +1'd 120099 | 16:51 |
| * dprince blames nova for all of this really | 16:51 | |
| jroll | I didn't block everything :( | 16:51 |
| jroll | my -1 was just my opinion, people could have overridden | 16:51 |
| lucasagomes | dprince, are you going to +2/+a https://review.openstack.org/#/c/120099/ ? | 16:51 |
| dprince | jroll: not you specifically, there were several Ironic changes (reverts, etc) that may have helped... | 16:51 |
| jroll | dprince: yeah, but I was also involved in those :P | 16:52 |
| dprince | lucasagomes: so here's the deal sir. I'm not really supposed to +2 my own | 16:52 |
| lucasagomes | oh that's ur patch | 16:52 |
| dprince | lucasagomes: ;) | 16:52 |
| lucasagomes | yeah just noticed it now :) | 16:52 |
| lucasagomes | dprince, boom :( | 16:52 |
| jroll | dprince is probably capable of poking the heck out of nova folks :P | 16:52 |
| rloo | dprince, in the future, have some non-core submit the patch! | 16:52 |
| NobodyCam | morning rloo | 16:53 |
| dprince | rloo: oh, I may have done that before | 16:53 |
| rloo | dprince: ;) | 16:53 |
| rloo | NobodyCam: bonjour! | 16:53 |
| NobodyCam | hehehe | 16:53 |
| *** MattMan has quit IRC | 16:54 | |
| jroll | oh lucasagomes, mind looking at this? https://review.openstack.org/#/c/117529/4..6/ironic_python_agent/tests/extensions/base.py | 16:54 |
| lucasagomes | jroll, oh sorry I forgot that, will do now | 16:55 |
| jroll | lucasagomes: it looks fine and like it will work, but wondering if it's too complex, it's kind of hard to read | 16:55 |
| *** derekh has quit IRC | 16:55 | |
| *** dlaube has joined #openstack-ironic | 16:56 | |
| *** harlowja_away is now known as harlowja | 16:58 | |
| JayF | jroll: yeah I read that and don't feel qualified to give it a proper review | 17:01 |
| JayF | jroll: I'd love if in meatspace later you'd walk me through it so I can get how it works (although I know what it's supposed to do) | 17:01 |
| jroll | JayF: more like, can you figure it out? | 17:01 |
| JayF | wdym? | 17:03 |
| lucasagomes | jroll, one thing is, if it's already introspecting the thing why you have to pass the "command_name" (which is really the method/function name) for that decorator | 17:04 |
| jroll | JayF: sounds like you get what it's supposed to do | 17:04 |
| lucasagomes | you can get it __name__ | 17:04 |
| lucasagomes | func.__name__ in the decorator | 17:04 |
| jroll | my main thing is, can people understand it | 17:04 |
| lucasagomes | but yeah it looks hmm complicated | 17:04 |
| jroll | lucasagomes: should have flexibility to change the underlying implementation without changing the API | 17:04 |
| *** lazy_prince has quit IRC | 17:06 | |
| lucasagomes | jroll, right, I don't know much how it all work in the IPA. But basicaly the api has a /command endpoint | 17:06 |
| lucasagomes | and with this patch when you add the decorator to the method it already get exposed to that api right? | 17:06 |
| jroll | lucasagomes: there's a /command endpoint, body must contain e.g. {"name": "prepare_image"} | 17:07 |
| jroll | I should be able to link the 'prepare_image' command to a function named something other than 'prepare_image' | 17:07 |
| jroll | without changing the name passed by the client | 17:07 |
| jroll | does that make sense? | 17:08 |
| jroll | lucasagomes: I'm more just trying to make sure folks can grok the test code I linked, or if it's too complicated.. the rest of that patch lgtm | 17:08 |
| lucasagomes | jroll, ah so that's why you pass the command name | 17:08 |
| lucasagomes | I see | 17:08 |
| lucasagomes | well it def looks useful | 17:08 |
| jroll | yeah, I suppose it's fine | 17:09 |
| jroll | dunno, might see if I can make that test code better | 17:09 |
| lucasagomes | jroll, yeah I don't see any tests actually testing that use case you just told me | 17:11 |
| lucasagomes | even in the tests the command_name is the same name as the method/function | 17:12 |
| lucasagomes | and I didn't understand complete that command_map on the base class | 17:12 |
| lucasagomes | because it checks for hasattr | 17:12 |
| jroll | right, going to post that comment too | 17:12 |
| lucasagomes | so I dunno if that works or not | 17:12 |
| *** rushiagr is now known as rushiagr_away | 17:13 | |
| jroll | lucasagomes: which hasattr thing? | 17:13 |
| *** andreykurilin has quit IRC | 17:13 | |
| lucasagomes | jroll, oh I see now | 17:13 |
| lucasagomes | https://review.openstack.org/#/c/117529/6/ironic_python_agent/extensions/base.py | 17:14 |
| lucasagomes | ah it's not that hard seems | 17:14 |
| jroll | oh, the dict(inspect... thing | 17:14 |
| lucasagomes | so the decorator will set that attribute to the function | 17:14 |
| jroll | yeah, it's weird, but it works I think | 17:14 |
| lucasagomes | L193 func.command_name = command_name | 17:14 |
| jroll | yeah | 17:14 |
| lucasagomes | and then in the map thing (l115) when the class is being constructed | 17:14 |
| lucasagomes | it checks for all the members of that class, and check if they have a command_name attribute if so it adds to the map | 17:15 |
| jroll | yeah | 17:15 |
| lucasagomes | and that's it really | 17:15 |
| lucasagomes | and that predicate= if False remove the member for the list | 17:17 |
| lucasagomes | In [8]: inspect.getmembers(Oi, predicate=lambda _: False) | 17:17 |
| lucasagomes | Out[8]: [] | 17:17 |
| openstackgerrit | A change was merged to openstack/python-ironicclient: Fix column headings regression due to switch to cliutils https://review.openstack.org/114252 | 17:18 |
| openstackgerrit | A change was merged to openstack/ironic: Updated from global requirements https://review.openstack.org/120326 | 17:18 |
| lucasagomes | jroll, yeah, well if it adds more tests etc, it looks good | 17:18 |
| jroll | yeah, it could still be fragile but I think it's ok | 17:18 |
| jroll | +1 | 17:18 |
| lucasagomes | maybe add some comment as well | 17:19 |
| jroll | I left a comment about the tests | 17:19 |
| lucasagomes | just explaning what's going on there | 17:19 |
| jroll | I think they can just make an expected command map | 17:19 |
| jroll | and just compare the two | 17:19 |
| jroll | no reason to do all this craziness | 17:19 |
| lucasagomes | jroll, that's true as well | 17:19 |
| lucasagomes | jroll, to be honest the way it was before seems pretty straight forward | 17:20 |
| lucasagomes | a simple dict of maps | 17:20 |
| jroll | yeah | 17:20 |
| lucasagomes | I mean dict doing the mappings | 17:20 |
| jroll | this initially came up because the decorator changed the method signature | 17:21 |
| jroll | which is wrong, but definitely not the hackiest part of ironic :P | 17:21 |
| lucasagomes | jroll, and even the thing about having a command name mapped to a method with a different name was possible before now? | 17:22 |
| lucasagomes | no* | 17:22 |
| lucasagomes | self.command_map['start_flow'] = self.something_else | 17:22 |
| lucasagomes | jroll, yeah to be honest, looking at how it was before and not the new, idk, before looks simpler/better?! | 17:23 |
| * lucasagomes is not expert in IPA code | 17:23 | |
| jroll | lucasagomes: yeah, but was redundant, https://github.com/openstack/ironic-python-agent/blob/992c4b745dcc2eace9f8fa79d145bd8c12480d2a/ironic_python_agent/extensions/base.py#L121 | 17:24 |
| jroll | the person writing this patch didn't like the decorator chaning method sig | 17:24 |
| jroll | but I think it is simpler | 17:24 |
| lucasagomes | yeah I understand ur adding a new parameter for that mapped function | 17:24 |
| lucasagomes | yeah | 17:25 |
| jroll | idk, I think it's fine | 17:25 |
| jroll | we've already been through this internally before it hit openstack :P | 17:25 |
| lucasagomes | heh I c | 17:27 |
| *** lazy_prince has joined #openstack-ironic | 17:29 | |
| *** lazy_prince has quit IRC | 17:29 | |
| lucasagomes | jroll, you can also take a look at https://pypi.python.org/pypi/decorator/ | 17:29 |
| *** lazy_prince has joined #openstack-ironic | 17:29 | |
| lucasagomes | it's in the global-requirements of openstack already | 17:29 |
| *** dtantsur|brb is now known as dtantsur | 17:30 | |
| lucasagomes | jroll, http://stackoverflow.com/questions/147816/preserving-signatures-of-decorated-functions | 17:30 |
| jroll | meh :) | 17:30 |
| lucasagomes | idk if that covers all cases but maybe worth looking | 17:31 |
| lucasagomes | heh yeah | 17:31 |
| openstackgerrit | A change was merged to openstack/ironic: Deprecate Ironic compute driver and sched manager https://review.openstack.org/119892 | 17:33 |
| openstackgerrit | A change was merged to openstack/ironic: Sync the document with the current implementation https://review.openstack.org/120346 | 17:33 |
| jroll | \o/ | 17:33 |
| lucasagomes | nice :D | 17:34 |
| dtantsur | \o/ | 17:34 |
| devananda | woooot! | 17:34 |
| NobodyCam | w00t \o/ A change was merged to openstack/ironic: Deprecate Ironic compute driver and sched manager | 17:35 |
| NobodyCam | thank you everyone!!!! awesome work! | 17:36 |
| dtantsur | we need to celebrate removing >3000 lines of our code :) | 17:36 |
| *** rushiagr_away is now known as rushiagr | 17:36 | |
| NobodyCam | :) | 17:36 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add reserve() and release() to Node object https://review.openstack.org/120488 | 17:44 |
| openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Remove the objectify decorator https://review.openstack.org/120489 | 17:44 |
| lucasagomes | and I'll call it a day | 17:45 |
| lucasagomes | have a good night everybody! | 17:45 |
| *** eghobo has joined #openstack-ironic | 17:45 | |
| NobodyCam | night lucasagomes | 17:46 |
| *** lucasagomes is now known as lucas-dinner | 17:46 | |
| lucas-dinner | see ye tomorrow | 17:46 |
| *** igordcard has quit IRC | 17:47 | |
| *** athomas has quit IRC | 17:47 | |
| NobodyCam | :) | 17:48 |
| *** rushiagr is now known as rushiagr_away | 17:51 | |
| lazy_prince | jroll: do you know if morgabra will here today..? | 17:53 |
| morgabra | lazy_prince: sorry, I'm here. What's up? | 17:54 |
| lazy_prince | morgabra: oh.. thanks god that you are here.. so i was trying to use the ironic plugin.. byt seems like the db is not getting updated for some reason.. | 17:55 |
| lazy_prince | s/byt/but/ | 17:55 |
| morgabra | lazy_prince: no tables? | 17:55 |
| lazy_prince | yes.. | 17:55 |
| lazy_prince | any clue why thats not getting created.. | 17:55 |
| morgabra | neutron-db-manage --config-file <path to neutron.conf> upgrade head | 17:55 |
| morgabra | will force it | 17:56 |
| lazy_prince | used it.. still same error.. | 17:56 |
| lazy_prince | i aslo tried addidg a switch but that also resulted in same error.. | 17:56 |
| lazy_prince | s/addidg/adding/ | 17:57 |
| lazy_prince | http://paste.openstack.org/show/106636/ | 17:58 |
| lazy_prince | do you know if there is a db schema somewhere in the git repo that i can use to create the tables manually..? | 17:59 |
| NobodyCam | brb | 18:09 |
| *** todd_dsm has joined #openstack-ironic | 18:30 | |
| *** rushiagr_away is now known as rushiagr | 18:33 | |
| *** todd_dsm has quit IRC | 18:34 | |
| *** todd_dsm has joined #openstack-ironic | 18:35 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/ironic-specs: Add RSS feed https://review.openstack.org/120516 | 18:36 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/ironic-specs: Remove templates from toctrees https://review.openstack.org/120517 | 18:36 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/ironic-specs: Use the current date for the copyright statement https://review.openstack.org/120518 | 18:36 |
| *** rainya has quit IRC | 18:44 | |
| *** rainya has joined #openstack-ironic | 18:45 | |
| *** pelix has quit IRC | 18:49 | |
| *** todd_dsm has quit IRC | 18:51 | |
| *** eghobo has quit IRC | 18:59 | |
| *** rushiagr is now known as rushiagr_away | 19:02 | |
| *** dtantsur is now known as dtantsur|afk | 19:02 | |
| *** derekh has joined #openstack-ironic | 19:03 | |
| *** lazy_prince is now known as killer_prince | 19:03 | |
| *** mgagne has quit IRC | 19:18 | |
| *** mgagne has joined #openstack-ironic | 19:19 | |
| *** mgagne is now known as Guest75250 | 19:19 | |
| * NobodyCam looks for some food stuffs | 19:20 | |
| *** killer_prince has quit IRC | 19:21 | |
| *** lazy_prince has joined #openstack-ironic | 19:21 | |
| JayF | rloo: I want to setup a docs job for IPA. Something simple to start... like parsing the docstrings and putting them in a place. Do you know how / point me at a place where I can learn? I'm looking for a starting point | 19:28 |
| *** lazy_prince is now known as killer_prince | 19:30 | |
| jroll | NobodyCam: can you abandon https://review.openstack.org/#/c/116316/ please? :) | 19:36 |
| NobodyCam | oh golly geee | 19:36 |
| NobodyCam | I guess | 19:36 |
| NobodyCam | hehehehe | 19:36 |
| jroll | :P | 19:36 |
| jroll | thanks | 19:36 |
| NobodyCam | is done | 19:37 |
| *** derekh has quit IRC | 19:42 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/ironic-specs: Remove templates from toctrees https://review.openstack.org/120517 | 19:46 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/ironic-specs: Use the current date for the copyright statement https://review.openstack.org/120518 | 19:46 |
| *** dprince has quit IRC | 19:48 | |
| *** aswadr has quit IRC | 19:53 | |
| *** lucas-dinner has quit IRC | 19:58 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/ironic-specs: Remove templates from toctrees https://review.openstack.org/120517 | 20:03 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/ironic-specs: Add RSS feed https://review.openstack.org/120516 | 20:03 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/ironic-specs: Use the current date for the copyright statement https://review.openstack.org/120518 | 20:03 |
| kylestev | wow. many changes. such effort. | 20:03 |
| Shrews | umm, anyone else seeing this? | 20:13 |
| Shrews | ImportError: <module 'ironic.drivers.pxe' from '/home/shrews/Devel/git/ironic/ironic/drivers/pxe.pyc'> has no 'PXEAndSNMPDriver' attribute | 20:13 |
| Shrews | trying to run the conductor locally (via our quickstart guide instructions) | 20:13 |
| Shrews | from current master | 20:14 |
| Shrews | oh, maybe i need to cleanup .pyc files | 20:14 |
| NobodyCam | Shrews: :-p | 20:15 |
| NobodyCam | but that seems odd to me, that you'd have to do that | 20:16 |
| jroll | kylestev: oh, neat | 20:16 |
| Shrews | NobodyCam: that's not it... but this isn't off master branch. something probably broken with the change i'm testing | 20:17 |
| jroll | it's definitely there in master | 20:17 |
| jroll | what change are you testing? | 20:17 |
| Shrews | greghaynes: i think something is bad wrong with your change | 20:18 |
| Shrews | master is fine | 20:18 |
| Shrews | jroll: 109688 | 20:18 |
| rloo | JayF: I suppose I could help you ;) | 20:19 |
| JayF | rloo: me and jroll are working on writing docstrings for IPA | 20:19 |
| JayF | rloo: if you wanted to be a superhero, you could just work on docs generation for us simultaneously :) | 20:19 |
| rloo | JayF: is it the sphinx part, or the actual jenkins etc stuff or all of it? | 20:19 |
| JayF | rloo: I'll take knowledge as an optional fallback :P | 20:19 |
| * rloo is not a superhero and doesn't aspire to be | 20:19 | |
| * rloo in fact, is close to hating docn | 20:20 | |
| JayF | rloo: I don't think we generate *any* docs for IPA right now... I'd want to start with generating docs off docstrings then go from there | 20:20 |
| jroll | Shrews: that change needs to be rebased, it's based on a super old change | 20:20 |
| JayF | rloo: if you can point me in a direction I'll look into it after we get all these docs written | 20:20 |
| Shrews | jroll: ah. yeah | 20:20 |
| rloo | JayF: I'm not sure how to do it from scratch since it was set up already in ironic, but look at the doc directory | 20:20 |
| JayF | rloo: aight, I can dig then :) thought you'd be a good person to start with askin' | 20:20 |
| rloo | JayF: maybe devananda set it up? but you can copy/paste. I think most groups/projects do a similar thing. | 20:21 |
| jroll | yeah, it looks pretty straightforward | 20:21 |
| JayF | That sounds easy then. I'll work on getting anything to generate then toss up an infra patch | 20:21 |
| rloo | JayF: yeah, then there's the infra stuff. I think I figured it out how to do that part for python-ironicclient. You are doing dev docn, right? | 20:22 |
| JayF | rloo: that's the intention for starters | 20:23 |
| rloo | JayF: so the stuff in this etherpad may help. https://etherpad.openstack.org/p/IronicDocumentationTasks | 20:24 |
| rloo | JayF: the part for python-ironicclient | 20:24 |
| JayF | ack | 20:24 |
| rloo | JayF: jenkins/zuul jobs: https://review.openstack.org/#/c/86390/ | 20:24 |
| rloo | JayF: you'll want something similar, but if you look at those files, maybe ironic might be a better model. the docn for client packages only get pushed out when a client package is released, whereas for ironic, it is pushed out when a change is merged. | 20:25 |
| JayF | nice, thanks | 20:27 |
| greghaynes | Shrews: hrm? | 20:27 |
| greghaynes | Shrews: Are you saying in reguards to a test fail? | 20:27 |
| JayF | Yeah I saw it was a special job, I think it'll be easy to figure out with your pointers | 20:27 |
| Shrews | greghaynes: nm. i rebased your change and all is well | 20:27 |
| greghaynes | ah, ok | 20:27 |
| Shrews | greghaynes: however... i'm not seeing the conductor_id get set for a node when i create it | 20:27 |
| greghaynes | well, that is less than ideal | 20:28 |
| Shrews | a tad | 20:28 |
| greghaynes | how are you testing that? | 20:28 |
| Shrews | umm, 'ironic node-create' ??? :) | 20:28 |
| Shrews | greghaynes: following the quickstart example | 20:28 |
| Shrews | greghaynes: http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html | 20:29 |
| Shrews | just to see stuff work | 20:29 |
| Shrews | and check the db | 20:29 |
| greghaynes | ok, asking because thats obviously a testing path I missed | 20:29 |
| greghaynes | so, ill try to repro / add a test | 20:29 |
| Shrews | greghaynes: yay! th | 20:29 |
| Shrews | thx | 20:29 |
| NobodyCam | oh rloo I sure I will be asking for your help as I get more into : https://wiki.openstack.org/wiki/Ironic/NovaBaremetalIronicMigration | 20:32 |
| NobodyCam | also everyone else ^^^^^ | 20:33 |
| rloo | NobodyCam: is that the thing we need done (or have something that looks real) by next Tues? | 20:33 |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed a change to openstack/ironic: Add uefi boot mode support in IloVirtualMediaIscsiDeploy https://review.openstack.org/116561 | 20:36 |
| NobodyCam | rloo: ?? | 20:37 |
| NobodyCam | we need nore then https://etherpad.openstack.org/p/IronicMigration | 20:37 |
| *** JayF has quit IRC | 20:40 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed a change to openstack/ironic: Support for setting boot mode in pxe_ilo driver https://review.openstack.org/118578 | 20:42 |
| *** krtaylor has quit IRC | 20:42 | |
| *** JayF has joined #openstack-ironic | 20:42 | |
| Nisha | NobodyCam: rloo Just reposted the UEFI patches after addressing all the comments. https://review.openstack.org/116561 https://review.openstack.org/118578 | 20:43 |
| JayF | jroll: https://bugs.launchpad.net/ironic/+bug/1367915 | 20:45 |
| JayF | jroll: jfyi; the bug about us not having docs | 20:45 |
| jroll | thanks | 20:45 |
| rloo | NobodyCam: so is the idea to put the stuff from the etherpad, into that wiki? | 20:49 |
| NobodyCam | rloo: thats what I'm starting on now! | 20:50 |
| rloo | NobodyCam: ahh, thanks for doing it ;) | 20:51 |
| NobodyCam | I'll also be looking for help with some actual samples | 20:51 |
| NobodyCam | lol finally py27: commands succeeded | 20:52 |
| rloo | Nisha: do you work with Syed? cuz 118578 depends on 116561, and I'm not yet happy with 116561 | 20:52 |
| Nisha | Yes | 20:58 |
| Nisha | rloo let me know the comments on 116561 | 20:59 |
| openstackgerrit | A change was merged to openstack/ironic: Translator functions cleanup part 3 https://review.openstack.org/118588 | 21:00 |
| rloo | Nisha: I didn't see any replies from Syed, so I don't know if my comments were addressed or not. I see that there is a new revision. | 21:00 |
| rloo | Nisha: should I spend my time trying to figure out if Syed addressed my comments or not? I have other work to do too. | 21:00 |
| Nisha | rloo: i posted the patches after addressing all your comments | 21:01 |
| rloo | Nisha: are you Syed? | 21:01 |
| Nisha | No | 21:01 |
| rloo | Nisha: but Syed posted patch set 13. Did you do it or did Syed do it? | 21:02 |
| Nisha | I am not Syed but i am doing from his stack | 21:02 |
| Nisha | i did | 21:02 |
| Nisha | as my stack is not coming up | 21:02 |
| openstackgerrit | A change was merged to openstack/ironic: Log ERROR power state in node_power_action() https://review.openstack.org/117499 | 21:02 |
| rloo | Nisha: sigh. Ok, I'll look... | 21:03 |
| rloo | Nisha: actually, 116561 didn't pass a test. Maybe you can look into that first. | 21:03 |
| Nisha | in my stack there is some oslo.config version issue with latest devstack :( | 21:03 |
| Nisha | which one? | 21:03 |
| Nisha | i ran tests in venv | 21:04 |
| rloo | Nisha: https://review.openstack.org/#/c/116561/13. sounds like you may have to rebase? I'm not familiar with IBM xCAT CI, must be new. | 21:04 |
| jroll | rloo: xcat failed that way on a good patch | 21:05 |
| jroll | I don't think it's working | 21:05 |
| Nisha | rloo: but where are you seeing the failure logs | 21:05 |
| * jroll is ignoring it | 21:05 | |
| jroll | Nisha: click "toggle CI", maybe? | 21:05 |
| Nisha | rloo: unable to find :( i refreshed the review | 21:07 |
| Nisha | rloo: did you gave some more comments just some time back? | 21:08 |
| jroll | Nisha: scroll to the bottom, click "toggle CI", see the last comment | 21:08 |
| jroll | Nisha: but you can ignore it, I think IBM xCAT isn't working yet | 21:08 |
| Nisha | jroll: Ok. But will try to rebase if error goes off with rebasing. | 21:10 |
| jroll | no, xCAT apparently does not know how to rebase | 21:11 |
| *** andreykurilin has joined #openstack-ironic | 21:14 | |
| Nisha | rloo: i didnt see your new comments till now. When you mentioned it here, i saw that there are some more comments from you | 21:14 |
| Nisha | i will address them and post the patches | 21:15 |
| Nisha | Regarding one comment, "Do we always want to put the efi boot image in?" is something a choice | 21:15 |
| openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic: Add implementation of pluggable distributed sync https://review.openstack.org/115148 | 21:15 |
| Nisha | as of now it creates an image which is capable to boot up in both bios and uefi mode | 21:16 |
| Nisha | rloo: if we dont want that, we can make it optional | 21:17 |
| *** rainya has quit IRC | 21:18 | |
| *** igordcard has joined #openstack-ironic | 21:18 | |
| *** krtaylor has joined #openstack-ironic | 21:20 | |
| *** todd_dsm has joined #openstack-ironic | 21:20 | |
| Nisha | rloo: there | 21:22 |
| Nisha | ? | 21:22 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Fix exception that is not properly raised https://review.openstack.org/120586 | 21:23 |
| jroll | russell_h: ^ that fixes that lolbad exception | 21:24 |
| jroll | if you're interested in a quick +2 | 21:24 |
| jroll | (or a quick bash of my abilities) | 21:24 |
| kylestev | jroll: what about a test case for it? ;) | 21:24 |
| jroll | omg | 21:25 |
| jroll | you're completely right, though | 21:25 |
| * jroll fixes | 21:25 | |
| russell_h | jroll: can that exception have a hardcoded message? | 21:25 |
| jroll | I thought about that | 21:25 |
| jroll | I wish we had a good base exception class | 21:25 |
| jroll | that isn't resterror | 21:25 |
| jroll | but yeah, will do | 21:25 |
| russell_h | right | 21:26 |
| kylestev | I find it unfortunate that I have to leave another comment to -1 a patch instead of being able to edit my previous comment. damn my adhd reviewing | 21:26 |
| jroll | kylestev: I left three comments in 2 minutes this morning :P | 21:26 |
| kylestev | jroll: okay I feel less bad then. 3 comments in 3 minutes :P | 21:27 |
| JayF | dtantsur|afk: https://review.openstack.org/#/c/120516/2 -- once you look back over that, you can land it. I already +2+A'd the two dependant packages | 21:27 |
| *** rainya has joined #openstack-ironic | 21:28 | |
| jroll | hrm | 21:30 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Fix exception that is not properly raised https://review.openstack.org/120586 | 21:31 |
| jroll | russell_h: I'd like to factor this out better later, similar to ironic's base exception | 21:31 |
| jroll | but how does that look for now | 21:31 |
| jroll | something feels off about it | 21:31 |
| russell_h | hmm | 21:32 |
| russell_h | I mean, its fine | 21:32 |
| russell_h | it sucks needing to check for the passed message | 21:32 |
| jroll | I mean, I don't have to | 21:32 |
| jroll | I'm not passing it one | 21:32 |
| russell_h | right | 21:32 |
| russell_h | I'm not convinced you would ever need to | 21:33 |
| jroll | leaving it flexible | 21:33 |
| jroll | that should be in a base exception | 21:33 |
| russell_h | yeah, I think its fine | 21:33 |
| russell_h | right | 21:33 |
| jroll | cool, thanks | 21:33 |
| russell_h | you doing tests too? | 21:33 |
| jroll | oh, right, tests | 21:33 |
| jroll | bah | 21:33 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Fix exception that is not properly raised https://review.openstack.org/120586 | 21:37 |
| openstackgerrit | Kyle Stevenson proposed a change to openstack/ironic: Add implementation of pluggable distributed sync https://review.openstack.org/115148 | 21:46 |
| * kylestev hopes jenkins doesn' | 21:46 | |
| * kylestev ...t fail pep8 again for non up-to-date config even though it is updated | 21:46 | |
| jroll | kylestev: rebase, yo | 21:47 |
| kylestev | jroll: I did. and ran the config tools | 21:47 |
| jroll | huh. | 21:47 |
| kylestev | https://gist.github.com/kylestev/1ca5008d7272b1f0efe3 | 21:49 |
| kylestev | yeah | 21:49 |
| kylestev | if it fails again I will be very disappoint | 21:49 |
| jroll | I mean | 21:50 |
| jroll | don't worry about it | 21:50 |
| jroll | by the time that patch lands we'll probably have pulled that job | 21:50 |
| kylestev | lol | 21:50 |
| rloo | Nisha. Do you think it makes sense for the efi boot image to be optional? | 21:51 |
| JayF | rloo: Nisha: IMO; if the operator explicitly chooses bios vs efi boot, we should only provide the bootloader they request | 21:52 |
| JayF | rloo: Nisha: lots of hardware around that doesn't allow you via ipmi to force it one way or the other, and will prefer one type of bootloader over the other | 21:52 |
| openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-python-agent: Fix exception that is not properly raised https://review.openstack.org/120586 | 21:54 |
| jroll | ughhhhhhhh | 21:54 |
| jroll | kylestev: this one actually passes py27 | 21:54 |
| jroll | and fixes a related bug | 21:54 |
| rloo | JayF: might be good for you to take a look at https://review.openstack.org/#/c/116561/ | 21:55 |
| kylestev | jroll: honest question, is it worth copying and pasting the test_get_node_uuid_invalid_node test case to make sure the exception is raised when agent.node is None? | 21:56 |
| JayF | rloo: I can queue it for tomorrow, but right now trying to stay focused on writing IPA dev docs and not succeeding very well | 21:57 |
| jroll | kylestev: agent.node is None at agent initialization | 21:57 |
| rloo | JayF: queue away :-). I think they may want the uefi stuff in by Fri. | 21:57 |
| jroll | yeah, uefi is ffe'd | 21:57 |
| JayF | That's the deadline for it, for sure | 21:57 |
| jroll | needs to land by friday | 21:57 |
| jroll | and might need work | 21:57 |
| * jroll admittedly has not done his part with it | 21:58 | |
| rloo | I wonder/think maybe we should go with a similar model as nova, and ask for 2 (or 3) cores to sponsor a FFE request. | 21:59 |
| jroll | well, a bunch of cores said the ffe was fine | 21:59 |
| JayF | I think we should appreciate that we're a smaller project and can avoid such policies for a little bit :) | 21:59 |
| jroll | that likely wouldn't have changed anything | 21:59 |
| jroll | but accountability is cool | 22:00 |
| rloo | well, it would have for me. I wouldn't have volunteered and wouldn't feel bad not looking/reviewing them now ;) | 22:00 |
| *** igordcard has quit IRC | 22:04 | |
| *** krtaylor has quit IRC | 22:04 | |
| *** linggao has quit IRC | 22:10 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed a change to openstack/ironic: Add uefi boot mode support in IloVirtualMediaIscsiDeploy https://review.openstack.org/116561 | 22:14 |
| Nisha | rloo: Hmmm not very sure about that. I have addressed rest of the comments in patch set 14 now except this one whether UEFI image should be optional or not | 22:16 |
| Nisha | i think we can argue both ways | 22:16 |
| Nisha | but may be it may make sense to make it optional but i think that means retesting..... | 22:17 |
| rloo | Nisha: even if it is optional, that can probably be done in another patch. Unless others disagree. | 22:17 |
| Nisha | I would leave that comment to be answered by Syed | 22:17 |
| Nisha | rloo: yes, thanks | 22:17 |
| rloo | Nisha: but i noticed that jenkins complained, the unit test failed. | 22:18 |
| Nisha | which unit test, let me see | 22:18 |
| rloo | Nisha: I didn't look. It just don't like reviewing when tests fail. I'll probably look at both patches tomorrow (morning). | 22:18 |
| *** igordcard has joined #openstack-ironic | 22:19 | |
| Nisha | You are correct but i ran the tests in my venv and there are no failures | 22:19 |
| Nisha | i posted the patches after that only | 22:19 |
| *** andreykurilin has quit IRC | 22:20 | |
| jroll | Nisha: your tests are running mkisofs on the test system | 22:20 |
| jroll | Nisha: you should mock that out | 22:20 |
| jroll | Nisha: (see also http://logs.openstack.org/61/116561/13/check/gate-ironic-python27/0d52933/console.html ) | 22:20 |
| *** todd_dsm has quit IRC | 22:20 | |
| Nisha | oh may be bec i added it whether the option is supported or not | 22:22 |
| Nisha | I will address it. Thanks rloo | 22:22 |
| Nisha | I will also go now. Its now early morning here so need some sleep before going to office | 22:23 |
| rloo | thx Nisha. Sorry about all this; there's quite a learning curve :-( | 22:23 |
| Nisha | already 4 am | 22:23 |
| rloo | g'night Nisha | 22:23 |
| Nisha | rloo thats fine, we just want that the patches land | 22:23 |
| Nisha | in Juno | 22:23 |
| Nisha | :) | 22:23 |
| Nisha | yes thanks | 22:24 |
| *** todd_dsm has joined #openstack-ironic | 22:26 | |
| *** rainya has quit IRC | 22:33 | |
| *** rainya has joined #openstack-ironic | 22:33 | |
| *** igordcard has quit IRC | 22:39 | |
| NobodyCam | ok a little more detail add to https://wiki.openstack.org/wiki/Ironic/NovaBaremetalIronicMigration#Nova_Bare-metal_to_Ironic_migration | 22:59 |
| NobodyCam | https://wiki.openstack.org/wiki/Ironic/NovaBaremetalIronicMigration even | 23:00 |
| JayF | NobodyCam: something seems off about that | 23:00 |
| JayF | NobodyCam: you say in prereqs/assumptions that deploy-ironic kernel+ramdisk need to be in glance | 23:01 |
| JayF | but then here: https://wiki.openstack.org/wiki/Ironic/NovaBaremetalIronicMigration#Update_flavor it looks like we run glance-image-create | 23:01 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/114058 | 23:04 |
| *** todd_dsm has quit IRC | 23:04 | |
| * JayF afk | 23:04 | |
| *** todd_dsm has joined #openstack-ironic | 23:05 | |
| *** todd_dsm has quit IRC | 23:06 | |
| NobodyCam | JayF: you are correct | 23:09 |
| NobodyCam | I will correct that | 23:09 |
| *** dprince has joined #openstack-ironic | 23:10 | |
| * NobodyCam luv's that wiki has a save button and not a review button :p | 23:13 | |
| jroll | lol | 23:13 |
| *** todd_dsm has joined #openstack-ironic | 23:14 | |
| *** dprince has quit IRC | 23:17 | |
| *** todd_dsm has quit IRC | 23:20 | |
| *** rainya has quit IRC | 23:23 | |
| *** todd_dsm has joined #openstack-ironic | 23:40 | |
| *** harlowja has quit IRC | 23:48 | |
| *** harlowja_ has joined #openstack-ironic | 23:48 | |
| *** rainya has joined #openstack-ironic | 23:51 | |
| *** Haomeng has quit IRC | 23:54 | |
| *** Haomeng has joined #openstack-ironic | 23:55 | |
| NobodyCam | do we have examples of the migrate_db.py script (with all command line options) | 23:57 |
| *** todd_dsm has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
