*** Haomeng|2 has joined #openstack-ironic | 00:08 | |
*** Haomeng has quit IRC | 00:08 | |
*** mitz_ has joined #openstack-ironic | 00:33 | |
Haomeng|2 | mrda: morning:) | 00:38 |
---|---|---|
*** spandhe___ has joined #openstack-ironic | 01:32 | |
*** spandhe_ has quit IRC | 01:34 | |
spandhe___ | Hi everyone! I have a question. if dhcp_provider config option in ironic.conf is set to None, does that mean Neutron is not used at all? | 01:45 |
*** praneshp has joined #openstack-ironic | 01:50 | |
*** spandhe___ has quit IRC | 01:53 | |
*** nosnos has joined #openstack-ironic | 01:54 | |
*** pcrews has joined #openstack-ironic | 01:55 | |
*** spandhe has joined #openstack-ironic | 01:57 | |
*** praneshp_ has joined #openstack-ironic | 01:59 | |
*** praneshp has quit IRC | 02:02 | |
*** praneshp_ is now known as praneshp | 02:02 | |
*** kongfy has joined #openstack-ironic | 02:05 | |
*** takadayuiko has joined #openstack-ironic | 02:26 | |
*** takadayu_ has joined #openstack-ironic | 02:26 | |
*** takadayu_ has quit IRC | 02:27 | |
*** dlaube has joined #openstack-ironic | 02:37 | |
*** ramineni has joined #openstack-ironic | 02:49 | |
*** Poornima has joined #openstack-ironic | 03:05 | |
*** Poornima has quit IRC | 03:05 | |
*** kongfy has quit IRC | 03:09 | |
*** pcrews has quit IRC | 03:12 | |
*** dlaube has quit IRC | 03:12 | |
*** nosnos has quit IRC | 03:24 | |
*** nosnos has joined #openstack-ironic | 03:25 | |
*** nosnos has quit IRC | 03:29 | |
*** ryanpetrello has quit IRC | 03:40 | |
*** ryanpetrello has joined #openstack-ironic | 03:41 | |
openstackgerrit | Anusha Ramineni proposed a change to openstack/ironic: Update node-validate error messages https://review.openstack.org/128862 | 03:44 |
*** nosnos has joined #openstack-ironic | 03:48 | |
*** HenryG has quit IRC | 03:49 | |
*** rameshg87 has joined #openstack-ironic | 04:10 | |
*** andreykurilin_ has joined #openstack-ironic | 04:17 | |
*** lazy_prince is now known as killer_prince | 04:23 | |
*** andreykurilin_ has quit IRC | 04:29 | |
Haomeng|2 | spandhe___: I understand it is, but need to be confirmed from neutron guys | 04:35 |
*** dlaube has joined #openstack-ironic | 04:51 | |
*** dlaube has quit IRC | 04:52 | |
*** yarker has quit IRC | 04:57 | |
*** pensu has joined #openstack-ironic | 04:59 | |
*** yarker has joined #openstack-ironic | 05:00 | |
*** Haomeng|2 has quit IRC | 05:03 | |
*** Haomeng|2 has joined #openstack-ironic | 05:08 | |
*** krtaylor has quit IRC | 05:09 | |
*** krtaylor has joined #openstack-ironic | 05:13 | |
*** kongfy has joined #openstack-ironic | 05:15 | |
*** killer_prince has quit IRC | 05:31 | |
*** spandhe has quit IRC | 05:42 | |
*** pradipta_away is now known as pradipta | 05:43 | |
*** loki184 has joined #openstack-ironic | 05:58 | |
*** nosnos has quit IRC | 05:59 | |
*** nosnos has joined #openstack-ironic | 06:00 | |
*** killer_prince has joined #openstack-ironic | 06:01 | |
*** killer_prince is now known as lazy_prince | 06:01 | |
*** praneshp has quit IRC | 06:09 | |
*** takadayuiko has quit IRC | 06:10 | |
*** vinbs has joined #openstack-ironic | 06:10 | |
*** k4n0 has joined #openstack-ironic | 06:11 | |
*** nosnos has quit IRC | 06:39 | |
*** nosnos has joined #openstack-ironic | 06:39 | |
*** kongfy has quit IRC | 06:45 | |
openstackgerrit | Anusha Ramineni proposed a change to openstack/ironic-specs: Add get/set boot mode to Management Interface https://review.openstack.org/129529 | 06:50 |
*** kongfy has joined #openstack-ironic | 07:09 | |
*** rushiagr_away is now known as rushiagr | 07:10 | |
*** pradipta is now known as pradipta_away | 07:10 | |
*** pensu has quit IRC | 07:15 | |
*** kongfy has quit IRC | 07:17 | |
*** ndipanov has joined #openstack-ironic | 07:23 | |
*** jcoufal has joined #openstack-ironic | 07:28 | |
*** foexle has joined #openstack-ironic | 07:31 | |
*** viktors|afk is now known as viktors | 07:57 | |
*** leopoldj has joined #openstack-ironic | 08:01 | |
*** lazy_prince is now known as killer_prince | 08:04 | |
*** dtantsur has joined #openstack-ironic | 08:06 | |
openstackgerrit | Motohiro/Yuanying Otsuka proposed a change to openstack/python-ironicclient: Switch to oslo.i18n https://review.openstack.org/129540 | 08:06 |
dtantsur | Morning Ironic | 08:06 |
dtantsur | My IRC proxy was down since Fri evening, so if you wanted to tell me something - do it now please :) | 08:07 |
yuriyz | morning dtantsur and Ironic | 08:07 |
*** rameshg87_ has joined #openstack-ironic | 08:11 | |
*** athomas has joined #openstack-ironic | 08:11 | |
*** romcheg has joined #openstack-ironic | 08:12 | |
*** jistr has joined #openstack-ironic | 08:12 | |
*** derekh has joined #openstack-ironic | 08:12 | |
*** lucasagomes has joined #openstack-ironic | 08:35 | |
*** rushiagr is now known as rushiagr_away | 08:38 | |
*** sambetts has joined #openstack-ironic | 08:48 | |
*** Epistemic has joined #openstack-ironic | 08:49 | |
*** kbyrne has joined #openstack-ironic | 08:51 | |
openstackgerrit | A change was merged to openstack/ironic: Put a cap on our cyclomatic complexity https://review.openstack.org/129132 | 08:51 |
openstackgerrit | A change was merged to openstack/ironic: Continue heartbeating after DB connection failure https://review.openstack.org/129301 | 08:53 |
*** rushiagr_away is now known as rushiagr | 08:57 | |
openstackgerrit | Roman Dashevsky proposed a change to openstack/ironic: Closes-Bug: #1383162 https://review.openstack.org/129554 | 09:02 |
*** pelix has joined #openstack-ironic | 09:05 | |
GheRivero | morning all | 09:08 |
*** killer_prince has quit IRC | 09:09 | |
*** lazy_prince has joined #openstack-ironic | 09:09 | |
*** rameshg87_ has quit IRC | 09:10 | |
dtantsur | GheRivero, yuriyz, morning! | 09:14 |
*** Epistemic has quit IRC | 09:29 | |
*** k4n0 has quit IRC | 09:32 | |
*** k4n0 has joined #openstack-ironic | 09:35 | |
openstackgerrit | Roman Dashevsky proposed a change to openstack/ironic: Closes-Bug: #1383162 https://review.openstack.org/129558 | 09:37 |
openstackgerrit | Roman Dashevsky proposed a change to openstack/ironic: Closes-Bug: #1383162 https://review.openstack.org/129174 | 09:39 |
openstackgerrit | A change was merged to openstack/ironic: Update node-validate error messages https://review.openstack.org/128862 | 09:40 |
openstackgerrit | Roman Dashevsky proposed a change to openstack/ironic: Add SNMP driver for Aten PDU's. Closes-Bug: #1383162 https://review.openstack.org/129174 | 09:41 |
*** ifarkas has joined #openstack-ironic | 09:43 | |
*** Haomeng has joined #openstack-ironic | 10:02 | |
*** Haomeng|2 has quit IRC | 10:03 | |
openstackgerrit | Roman Dashevsky proposed a change to openstack/ironic: Add SNMP driver for Aten PDU's. https://review.openstack.org/129174 | 10:05 |
*** pensu has joined #openstack-ironic | 10:06 | |
*** rushiagr is now known as rushiagr_away | 10:17 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add a basic mechanism to route and validate vendor methods https://review.openstack.org/129261 | 10:28 |
*** ramineni has quit IRC | 11:04 | |
*** lazy_prince has quit IRC | 11:09 | |
*** slagle has joined #openstack-ironic | 11:09 | |
*** lazy_prince has joined #openstack-ironic | 11:10 | |
*** Poornima has joined #openstack-ironic | 11:11 | |
*** Poornima has quit IRC | 11:13 | |
*** Poornima has joined #openstack-ironic | 11:13 | |
*** Poornima has quit IRC | 11:15 | |
*** Poornima has joined #openstack-ironic | 11:15 | |
*** Poornima has quit IRC | 11:17 | |
*** rushiagr_away is now known as rushiagr | 11:21 | |
*** loki184 has quit IRC | 11:24 | |
*** romcheg has left #openstack-ironic | 11:24 | |
*** killer_prince has joined #openstack-ironic | 11:32 | |
*** Poornima has joined #openstack-ironic | 11:34 | |
*** HenryG has joined #openstack-ironic | 11:39 | |
*** lucasagomes is now known as lucas-hungry | 11:50 | |
*** killer_prince has quit IRC | 11:52 | |
*** vinbs has quit IRC | 11:52 | |
*** lazy_prince has quit IRC | 11:52 | |
*** lazy_pri- has joined #openstack-ironic | 11:52 | |
*** lazy_pri- is now known as lazy_prince | 11:53 | |
*** Poornima has quit IRC | 11:58 | |
*** rameshg87 has quit IRC | 11:59 | |
*** romcheg has joined #openstack-ironic | 12:03 | |
*** romcheg has left #openstack-ironic | 12:03 | |
*** romcheg has joined #openstack-ironic | 12:04 | |
*** romcheg has left #openstack-ironic | 12:04 | |
*** romcheg has joined #openstack-ironic | 12:04 | |
*** marck has joined #openstack-ironic | 12:09 | |
*** dprince has joined #openstack-ironic | 12:16 | |
*** tatyana has joined #openstack-ironic | 12:30 | |
*** rakesh_hs has joined #openstack-ironic | 12:30 | |
openstackgerrit | Roman Dashevsky proposed a change to openstack/ironic: Add SNMP driver for Aten PDU's https://review.openstack.org/129174 | 12:32 |
*** Haomeng|2 has joined #openstack-ironic | 12:34 | |
*** Haomeng has quit IRC | 12:35 | |
*** lucas-hungry is now known as lucasagomes | 12:51 | |
*** bradjones has joined #openstack-ironic | 12:52 | |
*** pensu has quit IRC | 13:03 | |
*** jjohnson2 has joined #openstack-ironic | 13:07 | |
*** dprince has quit IRC | 13:13 | |
*** rloo has joined #openstack-ironic | 13:13 | |
*** lazy_prince has quit IRC | 13:18 | |
*** dprince has joined #openstack-ironic | 13:19 | |
*** romcheg has quit IRC | 13:23 | |
*** romcheg has joined #openstack-ironic | 13:26 | |
*** dprince has quit IRC | 13:29 | |
*** dprince has joined #openstack-ironic | 13:30 | |
jroll | morning ironic :) | 13:36 |
*** killer_prince has joined #openstack-ironic | 13:37 | |
*** killer_prince is now known as lazy_prince | 13:37 | |
jroll | lucasagomes: I'm going to write that spec now | 13:38 |
lucasagomes | jroll, oh crap! I forgot that | 13:39 |
lucasagomes | jroll, right I cna write the API part if u want | 13:39 |
lucasagomes | jroll, morning... | 13:40 |
jroll | heh no it's fine :) | 13:41 |
jroll | I didn't get to it friday | 13:41 |
jroll | I'm just going to knock it out real quick before I get distracted :P | 13:41 |
lucasagomes | right, yeah I woke up and started working on the vendor_passthru stuff | 13:41 |
lucasagomes | I'm trying to add support of running methods in sync and async | 13:42 |
lucasagomes | on both driver_vendor_passthru and vendor_passthru | 13:42 |
lucasagomes | let's see, it seems to work | 13:42 |
jroll | lucasagomes: you think this should be an internal attribute, so only the new API can modify it? | 13:42 |
jroll | I'm thinking so | 13:43 |
lucasagomes | jroll, yeah... I think so too | 13:43 |
lucasagomes | the thing is... right now we are only changing the db values | 13:44 |
lucasagomes | so it's not a big problem, we may want to support both | 13:44 |
lucasagomes | but once we start doing more things like talking to other services we def need to do that | 13:44 |
jroll | hmm | 13:46 |
jroll | I mean, other services can use the new endpoint, I don't see the issue | 13:46 |
jroll | unless I'm misunderstanding | 13:46 |
lucasagomes | jroll, right, no I think it's fine | 13:47 |
jroll | ok :) | 13:47 |
*** k4n0 has quit IRC | 13:55 | |
*** rushiagr is now known as rushiagr_away | 13:58 | |
*** lucasagomes has quit IRC | 14:01 | |
*** tatyana has quit IRC | 14:06 | |
*** tatyana has joined #openstack-ironic | 14:08 | |
*** nosnos has quit IRC | 14:09 | |
*** nosnos has joined #openstack-ironic | 14:09 | |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-specs: Add maintenance reason field https://review.openstack.org/129629 | 14:13 |
jroll | luca^ :) | 14:14 |
jroll | ugh | 14:14 |
*** nosnos has quit IRC | 14:14 | |
jroll | oh we lost him :( | 14:14 |
*** lucasagomes has joined #openstack-ironic | 14:16 | |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Add Node.maintenance_reason https://review.openstack.org/128645 | 14:17 |
lucasagomes | and back | 14:18 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Add maintenance_reason when setting maintenance mode https://review.openstack.org/128646 | 14:18 |
jroll | lucasagomes: https://review.openstack.org/#/q/status:open+branch:master+topic:bp/maintenance-reason,n,z | 14:18 |
jroll | spec is in there too | 14:19 |
jroll | should tag your api thing :) | 14:19 |
lucasagomes | jroll, awesome will take a look | 14:19 |
lucasagomes | jroll, will do, ta much! | 14:19 |
NobodyCam | good morning Ironic | 14:19 |
NobodyCam | morning jroll and lucasagomes :) | 14:20 |
lucasagomes | NobodyCam, morning | 14:20 |
NobodyCam | have a good weekend? | 14:20 |
jroll | heya NobodyCam :) | 14:20 |
NobodyCam | :) | 14:20 |
rloo | morning NobodyCam, jroll, lucasagomes :) | 14:21 |
lucasagomes | rloo, hey ya! morning | 14:21 |
NobodyCam | morning rloo :) | 14:21 |
*** pcrews has joined #openstack-ironic | 14:24 | |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add API endpoint to set/unset the node maintenance mode https://review.openstack.org/128925 | 14:24 |
openstackgerrit | Mathieu Mitchell proposed a change to openstack/ironic-python-agent: Write image directly to disk https://review.openstack.org/129046 | 14:27 |
*** jgrimm is now known as zz_jgrimm | 14:27 | |
*** rwsu has joined #openstack-ironic | 14:30 | |
jroll | lucasagomes: did you catch my comments on patchset 5? https://review.openstack.org/#/c/128925/ | 14:34 |
lucasagomes | jroll, oh no, I just rebased, lemme mark it as WIP and address that | 14:34 |
jroll | cool | 14:34 |
jroll | not sure if they're valid comments, but I think so :P | 14:35 |
lucasagomes | jroll, sorry, it's because I'm looking at the vendor thing so I don't wanna stop and start fixing other things | 14:35 |
lucasagomes | or I will lose the track | 14:35 |
jroll | no worries, I can wait :P | 14:36 |
*** pensu has joined #openstack-ironic | 14:41 | |
NobodyCam | brb | 14:46 |
*** ndipanov has quit IRC | 14:54 | |
*** jistr has quit IRC | 14:59 | |
dtantsur | jroll, NobodyCam, morning | 14:59 |
dtantsur | and rloo :) | 14:59 |
jroll | good afternoon dtantsur :) | 14:59 |
jroll | and rloo :) | 14:59 |
rloo | hi, afternoon dtantsur | 15:00 |
jroll | dtantsur, rloo, I has a spec for you :) https://review.openstack.org/#/c/129629/ | 15:00 |
dtantsur | jroll, already reading :) | 15:01 |
*** jistr has joined #openstack-ironic | 15:01 | |
jroll | perfect | 15:01 |
rloo | thx jroll. Why did I ask for it? Now I'll have to read it :-) | 15:01 |
jroll | hehe, you did ask for it | 15:02 |
NobodyCam | morning dtantsur | 15:02 |
romcheg | Hey hey everyone! | 15:02 |
dtantsur | romcheg, hi! | 15:03 |
NobodyCam | morning romcheg :) | 15:03 |
rloo | afternoon romcheg! | 15:03 |
jroll | hiya romcheg :) | 15:04 |
* NobodyCam makes his standard monday morning call for agenda Items | 15:09 | |
devananda | morning, all | 15:11 |
jroll | morning devananda | 15:12 |
lucasagomes | devananda, morning | 15:12 |
*** jjohnson2 has quit IRC | 15:13 | |
NobodyCam | morning devananda | 15:15 |
yuriyz | morning/evening all | 15:15 |
*** zz_jgrimm is now known as jgrimm | 15:19 | |
rloo | morning devananda, evening yuriyz | 15:22 |
rloo | devananda, now that juno has been released, were you/we (not me) going to put together release notes ala https://wiki.openstack.org/wiki/Ironic/ReleaseNotes/Icehouse? | 15:23 |
rloo | NobodyCam: I was going to say that I sometimes think of agenda items but then I forget them when Monday rolls around. | 15:25 |
NobodyCam | :-p | 15:25 |
rloo | NobodyCam: but I just remembered something I had asked on IRC a while ago. what s/w to use for generating diagrams etc for our docn. Was that ever resolved/decided? | 15:26 |
NobodyCam | I thouhgt we came up with (thinks) asciichat.net | 15:27 |
rloo | NobodyCam: that doesn't exist? I see asciichart.net? | 15:28 |
NobodyCam | ahh thats it I think.. | 15:28 |
*** mitz has quit IRC | 15:29 | |
*** mitz has joined #openstack-ironic | 15:29 | |
devananda | rloo: yep, we need to do that | 15:30 |
rloo | devananda: did you mention http://asciiflow.com/? | 15:30 |
rloo | NobodyCam, devananda: basically, the source needs to be ascii? | 15:31 |
devananda | I believe I had suggested asciiflow -- that's in our spec template as a requirement, in fact | 15:31 |
*** leopoldj has quit IRC | 15:31 | |
rloo | devananda: ok, asciiflow it is I guess ;) | 15:32 |
NobodyCam | thats the onE!!!! Ty devananda for correcting /me | 15:33 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-specs: Add maintenance reason field https://review.openstack.org/129629 | 15:35 |
jroll | JayF, dtantsur, updated ^ | 15:35 |
openstackgerrit | A change was merged to openstack/ironic: Add SNMP driver for Aten PDU's https://review.openstack.org/129174 | 15:35 |
dtantsur | jroll, still not clear, what do to with clearing maintenance mode via old API | 15:36 |
*** ndipanov has joined #openstack-ironic | 15:37 | |
JayF | dtantsur: it's supported; but doesn't touch maintenance_reason | 15:37 |
JayF | dtantsur: I thought he was fairly explicit about it :x | 15:37 |
dtantsur | JayF, that's bad IMO | 15:37 |
NobodyCam | morning JayF :) | 15:37 |
dtantsur | JayF, so we'll easily leave outdated maintenance reason, if someone uses old API, right? | 15:37 |
JayF | I disagree; if you're calilng node.update you want to update fields of the node directly, and that shouldn't clear out potentially valuable information | 15:37 |
JayF | last_error, for instance, isn't cleared just because you reset a provision state | 15:38 |
*** dlaube has joined #openstack-ironic | 15:38 | |
JayF | morning NobodyCam | 15:38 |
jroll | dtantsur: if you want to clear it, use the new api | 15:38 |
JayF | jroll: or call node.update maintenance-reason=null, right? | 15:38 |
jroll | eh | 15:38 |
jroll | I was thinking on making that internal | 15:38 |
JayF | jroll: or something like that; since you said maintenance_reason should be added to node update api | 15:38 |
jroll | so you can't edit directly | 15:38 |
dtantsur | jroll, we're talking about backward compatibility. thus you can't trust the value, because someone might have used the old API | 15:38 |
jroll | dtantsur: I mean, do you want to make it not backward compatible? | 15:39 |
jroll | dtantsur: I prefer my tooling to keep working | 15:39 |
JayF | dtantsur: I think it's OK as long as jroll keeps the support for clearing maintenance_reason in the node update api | 15:39 |
dtantsur | jroll, yes with cleaning automagically on old API | 15:39 |
NobodyCam | hey JayF just checking 103105, do you happen to have a chance to take a look at that one? | 15:39 |
jroll | dtantsur: hmm, maybe | 15:39 |
rloo | updated to mention using asciiflow: https://wiki.openstack.org/wiki/Ironic/Developer_guidelines#diagrams | 15:39 |
jroll | I mean this is why we have specs | 15:39 |
JayF | NobodyCam: I don't have time to test it today; I can look at the changes and help troubleshoot any problems not sure I can give a great review on DIB anything | 15:40 |
dtantsur | jroll, JayF, my point is: if we're in environment, where some tools use old API, some - new, we can't trust this value, if it's not cleaned on unsetting maintenance mode whichever way | 15:40 |
JayF | jroll: dtantsur: I'm OK with either method; if we have maintenance_reason clear if maintenance=false via node-update api, lets not expose maintenance_reason via node update api then | 15:40 |
jroll | ok | 15:41 |
JayF | dtantsur: I guess so; but I feel like we already have that bucket of pain with last_error | 15:41 |
JayF | dtantsur: honestly regardless of how it works it's better than what we have now; which is a bucket of nothing :) | 15:41 |
dtantsur | JayF, last_error is at least cleared on any operation touching last_error IIRC :) but yeah, anything is better | 15:42 |
Shrews | dtantsur: when you have a moment, i can't seem to get your mock suggestion to work :( | 15:42 |
JayF | dtantsur: except an oper calling node-set-provision-state to unbreak his last_error :P | 15:42 |
JayF | jroll: http://logs.openstack.org/46/129046/2/check/check-tempest-dsvm-ironic-agent_ssh-src-nv/d853790/logs/devstacklog.txt.gz looks like we have to set SWIFT_TEMPURL_KEY :( | 15:42 |
dtantsur | Shrews, what happens? | 15:42 |
Shrews | dtantsur: http://paste.openstack.org/show/122238/ | 15:43 |
jroll | JayF: gogogo | 15:43 |
JayF | jroll: what should I set it to? Anything? lol | 15:43 |
jroll | yeah | 15:43 |
jroll | set it to 'namesarehard' | 15:43 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic-specs: Add maintenance reason field https://review.openstack.org/129629 | 15:44 |
jroll | dtantsur: updated again, I think this should handle the concerns here | 15:44 |
dtantsur | Shrews, lemme see | 15:44 |
*** todd_dsm has joined #openstack-ironic | 15:45 | |
*** jistr has quit IRC | 15:45 | |
dtantsur | Shrews, set CONF.hash_partition_exponent to 0 for this test. anyway we mock md5. | 15:46 |
dtantsur | brb | 15:47 |
Shrews | dtantsur: ah, yep. thx. that was driving me nuts | 15:48 |
openstackgerrit | David Shrewsbury proposed a change to openstack/ironic: Improve hash ring value conversion https://review.openstack.org/129031 | 15:53 |
*** eghobo has joined #openstack-ironic | 15:58 | |
*** ndipanov has quit IRC | 16:00 | |
JayF | jroll: https://review.openstack.org/#/c/129653/ | 16:00 |
rloo | devananda: if you have a minute to discuss 118733. Seems like we should -2 or give more direction, cuz I think more time is being spent here by reviewers than is warranted. | 16:01 |
devananda | rloo: /me looks | 16:01 |
jroll | JayF: so on this change... I'd almost rather just set it globally like ADMIN_PASSWORD etc | 16:03 |
jroll | "globally" | 16:03 |
jroll | like... for everything. can't hurt. | 16:03 |
JayF | jroll: Eh. I would rather my change by scoped to only modify things in agent runs | 16:03 |
jroll | idk, I'd see what reviewers think I guess | 16:04 |
devananda | rloo: so, I left some detailed comments there almost a month ago, and there has been no activity since -- I'm not sure what your concern is? | 16:04 |
jroll | JayF: seems like it should work | 16:04 |
rloo | devananda: so if they update the commit and do whatever other suggestions people are making, it is ok to approve it? there's already a +2 and lucasagomes awhile ago almost approved it. | 16:05 |
NobodyCam | devananda: just a question hve the votes been counted for our sessions? | 16:06 |
devananda | NobodyCam: yes | 16:06 |
NobodyCam | :) | 16:07 |
devananda | I've got a proposed schedule to go over | 16:07 |
devananda | rloo: let me answer that by asking a question - how do you feel about us abandoning patches that have -1's with constructive feedback that go ignored by their original authors after, say, a month? | 16:08 |
devananda | gerrit used to auto-abandon such things, but for reasons, that feature was disabled a while back | 16:09 |
rloo | devananda: something that is abandoned can be 'resumed' or whatever again, so yes, after some period of time, I think that makes sense. | 16:09 |
devananda | great. I'll do a round of abandoning things | 16:10 |
rloo | devananda: thx. Is 4 weeks a good time frame? How long was mrda on vacation? | 16:10 |
rloo | those australians take long vacations ;) | 16:10 |
devananda | lucasagomes, dtantsur: since you had +A'd 118733, but didn't respond to my comments on it, I'd like to check that we agree on whether to approve or abandon it | 16:11 |
lucasagomes | devananda, lemme check | 16:11 |
*** jgrimm is now known as zz_jgrimm | 16:12 | |
*** Hefeweizen has joined #openstack-ironic | 16:12 | |
dtantsur | 118733? | 16:12 |
*** ndipanov has joined #openstack-ironic | 16:12 | |
devananda | yes | 16:12 |
dtantsur | oh, I barely remembered | 16:13 |
devananda | rloo: I think 4 weeks is a good length of time. after that, the codebase has probably changed enough that it would have to be rebased anyway | 16:13 |
rloo | devananda: true enough. At least, I would hope that it would have to be rebased by then ;) | 16:13 |
dtantsur | devananda, I'm neutral here. And as I guess now it will require rebasing, I think we have to abandon it | 16:14 |
lucasagomes | devananda, I agree that fixing typos on comments or private methods is not a bug. Tho I'm fine with that change when he improves the commit message and remove the bug tag | 16:15 |
JayF | This https://review.openstack.org/#/c/129629/3 has 2x +2s. I'm going to land it before the meeting (in an hour or two) if nobody wants a look at it first. | 16:15 |
devananda | lucasagomes: exactly | 16:15 |
lucasagomes | devananda, sorry for not answering before | 16:15 |
lucasagomes | I will add it there | 16:15 |
devananda | JayF: /me looks | 16:16 |
rloo | JayF: the pressure is on :-). looking since I asked for it... | 16:16 |
rloo | JayF: isn't there jenkins for the specs? I wanted to read the beautifully formatted version. | 16:17 |
JayF | rloo: looks like CI hasn't run on the last patchset yet | 16:18 |
rloo | JayF: yeah. looking at the previous times, it could be sooner or later. oh well. | 16:19 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add a basic mechanism to route and validate vendor methods https://review.openstack.org/129261 | 16:19 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add sync and async support for [driver_]vendor_passthru https://review.openstack.org/129662 | 16:19 |
devananda | JayF: approved | 16:19 |
lucasagomes | devananda, ^ do you think I need a spec for those vendor passthru refactoring/enhancements? | 16:19 |
* lucasagomes wants to add support for diff HTTP methods as well | 16:20 | |
*** igordcard has joined #openstack-ironic | 16:20 | |
devananda | lucasagomes: I think that's something I'd like to talk about at the summit | 16:21 |
NobodyCam | lol .. devananda beets /me to the click again | 16:21 |
sambetts | lucasagomes: Did you have a chance to look at the patch that I put up for the passthru logging?? | 16:21 |
devananda | lucasagomes: namely, how and how much we expand support for vendor passthru | 16:21 |
lucasagomes | sambetts, yeah I did :/ but the logs are the same I was adding there already :/ | 16:21 |
lucasagomes | devananda, yeah, right... these 2 patchs I put up now is mostly for making it consistent, instead of having driver_vendor_passthru to always runs sync and node vendor_passthru to always runs async | 16:22 |
lucasagomes | devananda, I also need GET support for the iPXE driver | 16:22 |
lucasagomes | that's why I was working on that | 16:22 |
lucasagomes | I'm* | 16:22 |
*** eghobo has quit IRC | 16:23 | |
sambetts | lucasagomes: didn't know if my function could be extended to reduce the duplication of the try catches used in your patch? | 16:24 |
lucasagomes | sambetts, oh, hmm lemme take a look I guess it could | 16:25 |
openstackgerrit | A change was merged to openstack/ironic-specs: Add maintenance reason field https://review.openstack.org/129629 | 16:25 |
sambetts | lucasagomes: Its ok if you don't think its nessessary its just a suggestion :-) | 16:26 |
NobodyCam | was that our first K spec? | 16:26 |
NobodyCam | congratz!! | 16:26 |
NobodyCam | :) | 16:26 |
lucasagomes | sambetts, aight, yeah but worth taking a look anyway, removing duplication is good :) | 16:27 |
*** enikanorov has quit IRC | 16:32 | |
openstackgerrit | Ruby Loo proposed a change to openstack/ironic-specs: Delete the placeholder file: example.rst https://review.openstack.org/129665 | 16:33 |
dlaube | g'morning guys | 16:35 |
openstackgerrit | Lucas Alvares Gomes proposed a change to openstack/ironic: Add sync and async support for [driver_]vendor_passthru https://review.openstack.org/129662 | 16:35 |
*** marcoemorais has joined #openstack-ironic | 16:36 | |
NobodyCam | morning dlaube | 16:38 |
*** andreykurilin_ has joined #openstack-ironic | 16:41 | |
*** todd_dsm has quit IRC | 16:42 | |
dlaube | anyone using contrail plugin with neutron/ironic? | 16:46 |
NobodyCam | ruby landing 129665 | 16:47 |
NobodyCam | s/ruby/rloo/ | 16:48 |
rloo | thx NobodyCam ;) | 16:48 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Add maintenance_reason when setting maintenance mode https://review.openstack.org/128646 | 16:48 |
jroll | whee, thanks for approving that spec quickly folks :) | 16:48 |
jroll | now let's get the code through :) | 16:49 |
* jroll heads out to commute | 16:49 | |
*** spandhe has joined #openstack-ironic | 16:49 | |
lucasagomes | jroll, w00t | 16:51 |
lucasagomes | devananda, on the scheduling official slots tab, "exposing capabilities to Nova" we already do that no? | 16:52 |
lucasagomes | ohh or it's about driver capabilities? | 16:52 |
devananda | lucasagomes: right. both. | 16:52 |
lucasagomes | right ok | 16:53 |
*** tatyana has quit IRC | 16:57 | |
*** igordcard has quit IRC | 16:58 | |
openstackgerrit | A change was merged to openstack/ironic-specs: Delete the placeholder file: example.rst https://review.openstack.org/129665 | 16:59 |
*** marcoemorais has quit IRC | 17:00 | |
*** igordcard has joined #openstack-ironic | 17:00 | |
devananda | lucasagomes: there are also some things we should talk about with Nova... adding those now | 17:02 |
lucasagomes | devananda, will take a look | 17:02 |
*** marcoemorais has joined #openstack-ironic | 17:03 | |
*** athomas has quit IRC | 17:03 | |
*** derekh has quit IRC | 17:09 | |
*** ifarkas has quit IRC | 17:10 | |
dlaube | can anyone tell me if official juno packages for ubuntu have dropped yet? | 17:12 |
NobodyCam | Shrews: wow I've never seen a pep8 error like that one F811 | 17:12 |
NobodyCam | wait thats in a file your not modifying | 17:13 |
NobodyCam | ./ironic/tests/conductor/test_rpcapi.py:131:5: F811 redefinition of unused 'test_get_topic_for_driver_doesnt_cache' from line 116 | 17:13 |
*** bradjones has quit IRC | 17:14 | |
*** harlowja_away is now known as harlowja | 17:14 | |
*** zz_jgrimm is now known as jgrimm | 17:14 | |
*** dtantsur is now known as dtantsur|afk | 17:15 | |
*** bradjones has joined #openstack-ironic | 17:16 | |
devananda | dlaube: http://packages.ubuntu.com/search?suite=utopic&searchon=names&keywords=ironic | 17:19 |
devananda | dlaube: they are not (and probably will not be) in Trusty, but they are in utopic | 17:19 |
*** Haomeng|2 has quit IRC | 17:21 | |
NobodyCam | brb | 17:22 |
*** Haomeng|2 has joined #openstack-ironic | 17:23 | |
lucasagomes | I will call it a day... see you guys at the meeting :) | 17:27 |
*** lucasagomes is now known as lucas-dinner | 17:27 | |
NobodyCam | have a good night lucas-dinner see at the meeting | 17:29 |
NobodyCam | gah... see *you* at the ... | 17:29 |
*** yjiang5 has quit IRC | 17:32 | |
*** yjiang5 has joined #openstack-ironic | 17:32 | |
*** marcoemorais has quit IRC | 17:32 | |
*** yjiang5 has left #openstack-ironic | 17:34 | |
*** yjiang5 has joined #openstack-ironic | 17:37 | |
*** tonycoffman has left #openstack-ironic | 17:37 | |
NobodyCam | devananda: I recall you haveing questions on https://review.openstack.org/#/c/111175 but don't see them in the comments. am I just wrong? | 17:37 |
*** yjiang5 has quit IRC | 17:38 | |
dlaube | devananda: ok, thanks for confirming | 17:38 |
*** marcoemorais has joined #openstack-ironic | 17:38 | |
devananda | NobodyCam: hm. I remember discussing that, but apparently I didn't comment on it | 17:38 |
devananda | I think my objection was that ironic doesn't support associating resources to tenants/projects | 17:39 |
*** yjiang5 has joined #openstack-ironic | 17:40 | |
NobodyCam | ahh | 17:40 |
*** igordcard has quit IRC | 17:49 | |
*** ndipanov is now known as ndipanov_gone | 17:58 | |
*** sambetts has quit IRC | 18:02 | |
Shrews | NobodyCam: umm... jenkins hates me? dunno where that came from | 18:03 |
*** todd_dsm has joined #openstack-ironic | 18:05 | |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/python-ironicclient: Add node-set-maintenance command https://review.openstack.org/129693 | 18:10 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Clear maintenance_reason when setting maintenance=False https://review.openstack.org/129694 | 18:11 |
*** ifarkas has joined #openstack-ironic | 18:13 | |
jroll | lucas-dinner: ^ you should poke at those | 18:17 |
devananda | jroll: just tossing this out there -- right now, using a newer version of our client against an older version of the API service results in 404 NOT FOUND | 18:17 |
devananda | jroll: which is the same error it generates if the node doesn't exist | 18:17 |
devananda | our client does not support endpoint capability discovery -- in short, the API is not versioned | 18:18 |
NobodyCam | jroll: fyi on 129693 : TypeError: set_maintenance() takes exactly 4 arguments (3 given) | 18:19 |
jroll | NobodyCam: yeah, couldn't run tests offline, fixing things now :) | 18:20 |
jroll | devananda: hmm | 18:20 |
NobodyCam | :-p | 18:20 |
jroll | devananda: wtb micro versions :) | 18:20 |
*** tatyana has joined #openstack-ironic | 18:22 | |
*** pelix has quit IRC | 18:22 | |
*** pelix has joined #openstack-ironic | 18:26 | |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/python-ironicclient: Add node-set-maintenance command https://review.openstack.org/129693 | 18:33 |
jroll | NobodyCam: fixed :) | 18:33 |
NobodyCam | :) | 18:33 |
jroll | um. http://logs.openstack.org/46/128646/7/check/gate-ironic-pep8/78c4a82/console.html | 18:34 |
*** tatyana has quit IRC | 18:34 | |
jroll | I didn't touch that | 18:34 |
jroll | is our pep8 suddenly broken? :) | 18:34 |
NobodyCam | jroll: thats the eact same Shrews encountered | 18:34 |
jroll | all I did there was rebase 128646 on 128645 | 18:35 |
jroll | yeah... not good | 18:35 |
NobodyCam | Shrews: seem Mr. Jenkins dislikes more then you | 18:35 |
NobodyCam | s/seem/seems/ | 18:35 |
jroll | I remember the tag juno final review was weird | 18:35 |
jroll | with that method | 18:35 |
Shrews | hrm | 18:35 |
jroll | why can't I find this | 18:37 |
jroll | ugh. | 18:37 |
NobodyCam | brb befor meeting | 18:38 |
jroll | ^ | 18:39 |
jroll | here it is: https://github.com/openstack/ironic/blob/master/ironic/tests/conductor/test_rpcapi.py#L116-144 | 18:40 |
jroll | this broke it: https://review.openstack.org/#/c/129174/ | 18:41 |
jroll | not sure how | 18:41 |
jroll | wait wtf | 18:41 |
jroll | so this merge commit added it https://github.com/openstack/ironic/commit/deb21ef7067a157a632799a5783fe69e6de468da | 18:41 |
*** Guest52830 is now known as mgagne | 18:42 | |
*** mgagne has joined #openstack-ironic | 18:42 | |
jroll | but the parent did not | 18:42 |
jroll | this ain't good | 18:42 |
devananda | ?? | 18:42 |
jroll | right. | 18:42 |
*** pelix has quit IRC | 18:42 | |
jroll | devananda: you want to poke infra folks, I'll make the fix commit? | 18:42 |
devananda | F811 error, yes? | 18:43 |
devananda | wow | 18:43 |
jroll | yes, F811 | 18:43 |
devananda | jroll: I'm not quite sure I understand the cause yet. feel free to poke -infra and I'll follow / jump in when I get it | 18:43 |
jroll | devananda: I don't understand it either, I was going to delegate that to infra | 18:43 |
jroll | all I know is a merge commit added code that was not in the commit it was merging | 18:44 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Clear maintenance_reason when setting maintenance=False https://review.openstack.org/129694 | 18:44 |
*** andreykurilin_ has quit IRC | 18:45 | |
lucas-dinner | jroll, awesome! will do | 18:46 |
jroll | devananda: making a bug at least | 18:46 |
devananda | serious wtf | 18:46 |
devananda | the git log attributes the COMMIT to jenkins | 18:46 |
Shrews | jroll: so, that parent was for proposed/juno, and the snmp one was on master | 18:46 |
Shrews | now, i'm not sure how that happened, or what that means, but doesn't seem good | 18:46 |
jroll | huh | 18:46 |
devananda | git blame ironic/tests/conductor/test_rpcapi.py | grep "131)" | 18:46 |
devananda | deb21ef7 ironic/tests/conductor/test_rpcapi.py (Jenkins 2014-10-20 15:35:46 +0000 131) def test_get_topic_for_driver_doesnt_cache(self): | 18:46 |
jroll | Shrews: ttx added a default branch of proposed/juno | 18:46 |
jroll | I thought | 18:47 |
jroll | maybe not | 18:47 |
Shrews | i mean, it seems like 129174 was branched off a non-master branch | 18:47 |
Shrews | but proposed (and merged) to master | 18:48 |
jroll | oh | 18:48 |
* Shrews throwing out possibilites | 18:48 | |
jroll | strange that unit test didn't make proposed/juno | 18:48 |
jroll | but I remember a wtf proposal for stable juno that removed that | 18:48 |
NobodyCam | jroll: you happen to have a link for that? | 18:49 |
jroll | NobodyCam: for what? | 18:49 |
NobodyCam | the "wtf proposal for stable juno" | 18:50 |
NobodyCam | :0p | 18:50 |
jroll | NobodyCam: no, I can't find it :( | 18:50 |
openstackgerrit | Jim Rollenhagen proposed a change to openstack/ironic: Fix F811 error in pep8 https://review.openstack.org/129702 | 18:50 |
*** BertieFulton has joined #openstack-ironic | 18:50 | |
jroll | oh wait | 18:50 |
jroll | https://review.openstack.org/#/c/128965/ | 18:50 |
jroll | but that didn't merge | 18:51 |
jroll | might be related though | 18:51 |
jroll | anyway, I have to brb | 18:51 |
jroll | https://review.openstack.org/129702 will fix the gate at least | 18:51 |
Shrews | +2'd | 18:51 |
Shrews | oh, so did lucas-dinner | 18:51 |
lucas-dinner | yeah just bumped inot it | 18:52 |
lucas-dinner | into it* | 18:52 |
*** lucas-dinner is now known as lucasagomes | 18:52 | |
Shrews | lucasagomes: i didn't +A it. doing so now | 18:52 |
*** jgrimm is now known as zz_jgrimm | 18:52 | |
lucasagomes | :) | 18:52 |
NobodyCam | Shrews: not waiting for jenkins? | 18:52 |
Shrews | NobodyCam: of course i am | 18:53 |
Shrews | now... | 18:53 |
Shrews | :-P | 18:53 |
NobodyCam | lol | 18:53 |
Shrews | he wouldn't merge it anyway if was still broke, but i don't trust him now | 18:54 |
*** pensu has quit IRC | 18:54 | |
Shrews | Mr. J, that is | 18:54 |
*** jcoufal has quit IRC | 18:55 | |
*** rushiagr_away is now known as rushiagr | 18:57 | |
*** praneshp has joined #openstack-ironic | 18:58 | |
mrda | Morning Ironic | 18:58 |
NobodyCam | morning mrda | 18:58 |
mrda | \o | 18:58 |
*** dtantsur|afk is now known as dtantsur | 19:00 | |
*** linggao has joined #openstack-ironic | 19:00 | |
NobodyCam | meet'n time | 19:01 |
mrda | rloo: This year was an especially long holiday. It isn't normal :) | 19:01 |
rloo | mrda: ohh, too bad :-) | 19:02 |
rloo | mrda: that it isn't normal ;) | 19:02 |
mrda | :) | 19:02 |
*** zz_jgrimm is now known as jgrimm | 19:08 | |
*** rushiagr is now known as rushiagr_away | 19:13 | |
*** andreykurilin_ has joined #openstack-ironic | 19:23 | |
*** ifarkas has quit IRC | 19:24 | |
*** pensu has joined #openstack-ironic | 19:26 | |
*** rakesh_hs has quit IRC | 19:44 | |
*** igordcard has joined #openstack-ironic | 19:50 | |
*** dprince has quit IRC | 19:58 | |
lucasagomes | devananda, I will def do the spec for the ipxe... but I was thinking about extending the vendor_passthru as a separated feature, like a plumbing work to pave the way to do the iPXE stuff | 20:00 |
*** linggao has quit IRC | 20:00 | |
lucasagomes | so 2 specs? | 20:00 |
NobodyCam | lucasagomes: I think that would be a great help | 20:00 |
jroll | lucasagomes: yeah, I think there's going to be enough change/contention to get a spec up | 20:01 |
mrda | rloo: fwiw, I'm also interested in async api | 20:01 |
lucasagomes | NobodyCam, alright :) | 20:01 |
NobodyCam | lucasagomes: I'm ok with one spec and maybe two patches | 20:01 |
jroll | if you had to convince deva it's reasonable, probably needs a spec :P | 20:01 |
lucasagomes | jroll, NobodyCam right, thanks... i will put 2 specs one for each feature | 20:01 |
jroll | cool, thanks man | 20:01 |
lucasagomes | heh true | 20:01 |
* jroll bbiab | 20:01 | |
NobodyCam | :) sweet | 20:01 |
devananda | jroll: lol, now i'm your litmus test for specs? :p | 20:01 |
jroll | devananda: one of many | 20:01 |
jroll | :D | 20:01 |
lucasagomes | I mean, I know it can be misused, but I don't want to also not allow it because people can do good things with that | 20:02 |
rloo | mrda: i can't even remember why that stalled, but if things need to be discussed, we should try to do at the summit. | 20:02 |
devananda | lucasagomes: so in general, I have a lot of concerns for the future of vendor passthru | 20:02 |
lucasagomes | devananda, right... for the v2 api u mean? | 20:02 |
lucasagomes | or right now in v1? | 20:02 |
devananda | they might be ungrounded - after all, we can't be responsible for what a downstream driver does, but we are responsible for maintaining backwards compatibility | 20:03 |
NobodyCam | oh gawd v2 api... that needs a slot :-p | 20:03 |
devananda | and that API endpoint is opaque | 20:03 |
lucasagomes | devananda, yeah, but it was designed like that | 20:03 |
devananda | like, there's currently no way to discover what methods a driver supports | 20:03 |
devananda | exactly | 20:03 |
devananda | the intent was: let drivers add new things that should become part of the standard | 20:03 |
mrda | NobodyCam: we have a pod right? There can be more discussions | 20:04 |
devananda | what you're proposing here is never going to be part of the standard AIUI | 20:04 |
lucasagomes | devananda, yeah... right now, if we add that basic mechanism that exposes the routes for the vendor methods we could make it discoverable | 20:04 |
devananda | mrda: yes | 20:04 |
Shrews | rloo: it stalled b/c the need for it was somewhat alleviated since we added the node lock retry logic. i honestly don't know if we still want it or not. | 20:04 |
lucasagomes | https://review.openstack.org/#/c/129261/ | 20:04 |
NobodyCam | mrda: YES!!!!! | 20:04 |
devananda | lucasagomes: i mean, any sort of "get the ipxe config" request is, by definition, not generalizable | 20:04 |
devananda | lucasagomes: it's specific to that driver and always will be | 20:04 |
lucasagomes | devananda, yes, that's why it goes to the driver vendor passthru | 20:04 |
lucasagomes | cause it's a unique capability | 20:05 |
lucasagomes | it's not part of the general abstraction | 20:05 |
lucasagomes | just like the pass_deploy_info for pxe right now | 20:05 |
NobodyCam | devananda: the goal was to consolidate the vender pass thru based on a majority of the drivers having the "same" function in VPT | 20:05 |
devananda | lucasagomes: pass deploy info is a node vendor-passthru, not driver | 20:06 |
lucasagomes | devananda, right yeah, that's correct... but it comes with the pxe driver | 20:06 |
lucasagomes | this is another thing that I have in mind, this separation of driver vendor passthru or node vendor passthru makes little sense | 20:06 |
devananda | actually yes, it falls into the same category of never going to becmoe standardized | 20:06 |
lucasagomes | maybe "node" should be only a parameter for the driver vendor passthru | 20:06 |
lucasagomes | but the idea is, if a driver needs something that is not possible to abstract, it goes to one of those vendor endpoints, which sounds like a good approach to me | 20:07 |
NobodyCam | brb | 20:08 |
*** BertieFulton has quit IRC | 20:09 | |
*** harlowja is now known as harlowja_away | 20:10 | |
devananda | lucasagomes: looking at ilo and drac, which is where I'd expect to see vendor_passthru do something truly unique, I don't | 20:11 |
lucasagomes | devananda, right, well for drac at least we wanted to have things like RAID config etc | 20:11 |
lucasagomes | we had specs for it but wasn't the right time | 20:11 |
devananda | right | 20:11 |
lucasagomes | we also have ideas like the ready state to do using the vendor passthru | 20:11 |
lucasagomes | which is talking to the BMC and populating things in Ironic | 20:12 |
devananda | I believe HP plans to do more unique things there with iLO as well | 20:12 |
lucasagomes | but last cycle we only could add the base driver | 20:12 |
lucasagomes | I'm sure things will come | 20:12 |
devananda | and seamicro did a while back (attach volume, for example) | 20:12 |
lucasagomes | yeah, exactly | 20:12 |
devananda | so from an API perspective, what differentiates these? | 20:12 |
lucasagomes | devananda, these are the things that I think that, once more than 1 driver starts implementing it | 20:12 |
lucasagomes | we should promote to the normal api | 20:13 |
lucasagomes | cause they are common across multiple driver as I see it | 20:13 |
lucasagomes | but as a first stage, I think that having it on the vendor_passthru is fine | 20:13 |
devananda | sure | 20:13 |
lucasagomes | when no one else expose that capability | 20:13 |
devananda | sorry, i'm not doing a good job explaining my POV | 20:14 |
devananda | it seems like two categories of methods have emerged within vendor_passthru: 1. cool hardware stuff that we want to become standardized, 2. driver idiosyncracies | 20:16 |
lucasagomes | right, yeah | 20:17 |
jroll | I mean, reality is that drivers may need API endpoints that are not generalizable | 20:19 |
jroll | PXE driver has one | 20:19 |
jroll | IPA has one | 20:19 |
jroll | iPXE driver will have one | 20:19 |
jroll | IPA actually has multiple now that I think about it, but my point still stands | 20:19 |
devananda | jroll: indeed, but should those endpoints be lumped together with generalizable ones? | 20:20 |
lucasagomes | jroll, right, and things like lookup and heartbeat is very specific for the IPA right? | 20:21 |
devananda | what makes POST /v1/node/NNNN/vendor_passthru?method=attach_volume | 20:21 |
devananda | different from /v1/node/NNNN/vendor_passthru?method=continue_deploy | 20:21 |
dtantsur | so we have "technical" endpoints that are never exposed to the end user | 20:21 |
jroll | lucasagomes: yes | 20:21 |
dtantsur | and "public" that just provide additional functionality, that is not general | 20:21 |
devananda | dtantsur: right | 20:21 |
jroll | devananda: I don't see your point | 20:22 |
dtantsur | devananda, btw all these "technical" endpoints are node-less now, right? | 20:22 |
devananda | jroll: attach_volume is a hardware capability, enabled by one driver today, which more drivers will hopefully soon also support, at which point it completes the intended purpose of vendor_passthru and migrates to a common interface | 20:22 |
*** HenryG has quit IRC | 20:23 | |
devananda | jroll: continue_deploy exists for a different purpose. it has nothing to do with vendor support | 20:23 |
dtantsur | hell, I feel like I'm close to some idea, but I'm too tired to do it :( It would be really nice to discuss f2f. and g'night for now. | 20:23 |
*** dtantsur is now known as dtantsur|afk | 20:23 | |
jroll | devananda: ok, sure. what's your point? should we add /v1/node/NNNN/driver_weirdness? | 20:23 |
lucasagomes | dtantsur, no, heartbeat and continue_deploy is node vendor passthru | 20:23 |
devananda | jroll: ditto for agent heartbeat and so on. the reason those endpoints exist has nothing to do with enabling unique hardware or standardizing common functions across drivers | 20:23 |
NobodyCam | night dtantsur|afk | 20:23 |
lucasagomes | dtantsur|afk, night | 20:24 |
jroll | devananda: right, but we need them. what do you suggest? | 20:24 |
jroll | night dtantsur|afk | 20:24 |
devananda | dtantsur|afk: cheers. I think you're close to it, but I dont quite hve it either yet. looking forward to Paris! | 20:24 |
lucasagomes | devananda, oh I think I see where it's leading... maybe we should have another endpoint for it? | 20:24 |
devananda | these are essentially remote procedure calls, right? | 20:25 |
lucasagomes | or extending the scope of the vendor_passthru | 20:25 |
devananda | not a user or operator facing API endpoint | 20:25 |
lucasagomes | maybe even renaming it to only "passthru" | 20:25 |
lucasagomes | right | 20:25 |
devananda | "continue deploy" is not a verb in our API | 20:25 |
devananda | it's an RPC call | 20:25 |
devananda | heartbeat is much closer to a verb, fwiw, so I"m not sure where that falls in my thinking yet | 20:26 |
jroll | "lookup" is not an rpc call, fwiw | 20:26 |
jroll | (imo) | 20:26 |
devananda | jroll: indeed. and I think I wanted that to be done by searching | 20:26 |
jroll | right, but then we're going to end up with some endpoint | 20:26 |
devananda | jroll: but ya'll had a reason not to use GET /v1/nodes for that | 20:26 |
devananda | I dont remember why | 20:27 |
jroll | "lookup" is a little overloaded in that it returns some configuration | 20:27 |
jroll | heartbeat timeout configs, etc | 20:27 |
devananda | oh, right | 20:27 |
jroll | I'm going to +A https://review.openstack.org/#/c/129702/ btw | 20:27 |
devananda | retrieve some driver-specific config bits | 20:27 |
jroll | right, which is the same thing ipxe is doing | 20:27 |
devananda | jroll: /me looks | 20:27 |
jroll | adam_g: https://review.openstack.org/#/c/129702/ failed parallel tests btw | 20:27 |
adam_g | jroll, thanks | 20:28 |
jroll | adam_g: all I did was remove a duplicate unit test, so that's not a real failure | 20:28 |
devananda | +A'd | 20:28 |
jroll | oh I already did | 20:28 |
lucasagomes | yeah I'm good +a that | 20:28 |
jroll | but thanks :P | 20:28 |
adam_g | jroll, yeah.. one common thing ive found with failures is one of the VMs never reboots out of the deploy ramdisk: http://logs.openstack.org/02/129702/1/check/check-tempest-dsvm-ironic-parallel-nv/3e35154/logs/ironic-bm-logs/baremetalbrbm_0_console.txt.gz | 20:28 |
jroll | adam_g: odd | 20:29 |
adam_g | hard to say if thats a libvirt/host issue or something in our ramdisk | 20:29 |
NobodyCam | strange | 20:29 |
adam_g | i have a stack of devstack patches up to better monitor console logs | 20:29 |
adam_g | right now they get truncated with every power cycle | 20:29 |
NobodyCam | adam_g: are they by change running exec ? | 20:29 |
adam_g | NobodyCam, huh? kexec? | 20:30 |
NobodyCam | yea that too :-p | 20:30 |
jroll | adam_g: wait... | 20:30 |
jroll | adam_g: aren't we just calling libvirt power off/on | 20:30 |
adam_g | NobodyCam, nah, just a regular reboot | 20:30 |
jroll | or libvirt reboot | 20:31 |
* jroll looks | 20:31 | |
lucasagomes | devananda, jroll right it's a bit late here, I'll call it a day. Thanks for the discussion | 20:31 |
adam_g | jroll, not there, IIRC the deploy ramdisk is rebooting itself | 20:31 |
NobodyCam | https://github.com/openstack/diskimage-builder/tree/master/elements/deploy-kexec | 20:31 |
jroll | lucasagomes: cheers, have a good one | 20:31 |
devananda | lucasagomes: cheers, g'night | 20:31 |
NobodyCam | night lucasagomes | 20:31 |
jroll | adam_g: I don't think that's a thing? | 20:31 |
jroll | adam_g: how would it know when to reboot? | 20:31 |
jroll | I think it's https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ssh.py#L157 | 20:31 |
lucasagomes | devananda, I see ur point that we may be missusing the vendor_passthru, maybe we should think about extending it's scope for the idiosyncracies part too | 20:32 |
lucasagomes | but we can talk about it later | 20:32 |
adam_g | jroll, ah, right | 20:32 |
jroll | I think I'd blame libvirt but idk | 20:33 |
jroll | oh | 20:33 |
jroll | maybe it's like an ACPI reboot | 20:33 |
*** lucasagomes is now known as lucas-zZz | 20:33 | |
jroll | and disks aren't unmounting cleanly or something | 20:33 |
adam_g | i dont think there are any disks mounted other than the ramfs | 20:35 |
adam_g | and it looks liek the ACPI reboot is servied completely, [ 52.315117] reboot: machine restart | 20:35 |
adam_g | libvirt wonkiness isn't unusual so its possible we're just tickling something occasionally | 20:36 |
jroll | I see | 20:36 |
adam_g | wish there was something we could match on for an elastick-recheck query | 20:37 |
*** pensu has quit IRC | 20:39 | |
*** foexle has quit IRC | 20:52 | |
NobodyCam | how specific should our operator questions be? I am attempting to keep them mostly general (see: https://etherpad.openstack.org/p/Ironic_Questions) | 21:00 |
NobodyCam | j* do you have any IPA feed back you looking to get for the Operators? | 21:01 |
NobodyCam | gah | 21:01 |
*** andreykurilin_ has quit IRC | 21:01 | |
NobodyCam | s/you/your/ : s/for/from | 21:02 |
*** andreykurilin_ has joined #openstack-ironic | 21:04 | |
jroll | NobodyCam: nothing specific | 21:07 |
NobodyCam | :) | 21:08 |
*** andreykurilin_ has quit IRC | 21:13 | |
*** andreykurilin_ has joined #openstack-ironic | 21:14 | |
-openstackstatus- NOTICE: Zuul erroneously marked some changes as having merge conflicts. Those changes have been added to the check queue to be rechecked and will be automatically updated when complete. | 21:21 | |
NobodyCam | ok dumb question.. this is our offical mission statment? http://git.openstack.org/cgit/openstack/governance/tree/reference/programs.yaml#n146 | 21:26 |
NobodyCam | devananda: are those along the lines of the types of questions your thinking of? /me notes they not ordered at this point their just a breain dump | 21:32 |
NobodyCam | brain dump even :-p | 21:33 |
devananda | NobodyCam: yes, that's the official mission statement | 21:33 |
devananda | NobodyCam: sort of. I'll add a few | 21:33 |
NobodyCam | :) fire away | 21:33 |
*** spandhe has quit IRC | 21:34 | |
*** spandhe has joined #openstack-ironic | 21:36 | |
*** openstackgerrit has quit IRC | 21:40 | |
NobodyCam | brb... quick walkies :) | 21:46 |
*** todd_dsm has quit IRC | 21:46 | |
*** jmank has joined #openstack-ironic | 21:48 | |
*** marcoemorais has quit IRC | 21:48 | |
*** marcoemorais has joined #openstack-ironic | 21:49 | |
*** todd_dsm has joined #openstack-ironic | 21:52 | |
* NobodyCam is back | 21:55 | |
*** marcoemorais has quit IRC | 21:58 | |
*** marcoemorais has joined #openstack-ironic | 21:59 | |
*** marcoemorais has quit IRC | 21:59 | |
*** marcoemorais has joined #openstack-ironic | 21:59 | |
devananda | JayF: any followup to our chat last week // https://etherpad.openstack.org/p/hardware-capabilities-spec ? | 22:04 |
JayF | devananda: it's on my list for today, but tbh haven't had a productive day. It's close to the top of my list right now though | 22:05 |
devananda | JayF: np, just checkin | 22:05 |
* devananda heads out to a cafe for a bit | 22:06 | |
NobodyCam | enjoy | 22:09 |
*** marcoemorais has quit IRC | 22:10 | |
*** igordcard has quit IRC | 22:15 | |
*** HenryG has joined #openstack-ironic | 22:16 | |
*** lucas-zZz has quit IRC | 22:20 | |
*** eghobo has joined #openstack-ironic | 22:22 | |
*** eghobo has quit IRC | 22:29 | |
*** eghobo has joined #openstack-ironic | 22:32 | |
*** jgrimm is now known as zz_jgrimm | 22:37 | |
*** jmank has quit IRC | 22:40 | |
*** openstackgerrit has joined #openstack-ironic | 22:43 | |
*** marcoemorais has joined #openstack-ironic | 22:43 | |
*** eghobo has quit IRC | 22:44 | |
openstackgerrit | A change was merged to openstack/ironic: Fix F811 error in pep8 https://review.openstack.org/129702 | 22:46 |
*** harlowja_away is now known as harlowja | 22:48 | |
*** eghobo has joined #openstack-ironic | 22:48 | |
*** andreykurilin_ has quit IRC | 22:49 | |
*** eghobo has quit IRC | 22:49 | |
yjiang5 | NobodyCam: hi | 22:51 |
NobodyCam | hi yjiang5 :) | 22:51 |
*** eghobo has joined #openstack-ironic | 22:53 | |
yjiang5 | I'm checking https://bugs.launchpad.net/ironic/+bug/1382164 and seems Dmitry is right that the check_image_size() is using the converted_image to compare, thus should be ok. According to your log, seems the error happens in converting to raw image? | 22:53 |
NobodyCam | yea | 22:53 |
NobodyCam | so we had the space when the image was downloaded but then lost it | 22:54 |
*** marcoemorais has quit IRC | 22:55 | |
NobodyCam | checking with the folks who actually had the issue. it seems that another service (sphinx, or another indxer thing) started and sucked up the disk space | 22:56 |
yjiang5 | NobodyCam: Yes, is your machine (or the partition holding the image cache) already very crowded already (not sure if 'crowd' is correct, not well on english). Is it possible that during the check cache size and the real convert, something wrong to occupy the disk. | 22:56 |
yjiang5 | NobodyCam: yes, currently the image_cache does not gurantee/reserve any disk space. | 22:56 |
NobodyCam | ya | 22:57 |
yjiang5 | NobodyCam: Just wondering if force_raw_images is rquired to be True if we are using iscsi deploy? | 22:58 |
NobodyCam | might be worth adding a check for diskspace right before we actually do the convert to raw. but even that is no gurantee | 22:59 |
NobodyCam | yjiang5: I'm not sure there, I think there was a reason for that. | 23:00 |
yjiang5 | NobodyCam: The window still exists, unless we can reserve the space , I will try to check if such tools on linux side. Another questioin is, would it be possible to avoid the convert at all. Convert the image is really not so good because it's assumed that the ironic-conductor machine is sure to have bigger disk size than the converted image, or the compute node disk in some situation. | 23:01 |
NobodyCam | yjiang5: yes. I think attempting to reserve the space is the wrong way to go, I would love to remove that convert or do the convert on the fly when we are writting the image to the node | 23:04 |
yjiang5 | NobodyCam: Yes, I will try to check if that's possible. | 23:04 |
NobodyCam | awesome Thank you yjiang5 :) | 23:05 |
*** marcoemorais has joined #openstack-ironic | 23:05 | |
yjiang5 | NobodyCam: :) | 23:07 |
*** praneshp has quit IRC | 23:08 | |
*** todd_dsm has quit IRC | 23:24 | |
devananda | dtantsur|afk: I'm reading the code for discoverd and I'm pretty excited that you were able to do this in a separate service | 23:27 |
NobodyCam | devananda: On the question you added is "it" in the last part in refference to Ironic or the pxe deploy ? | 23:30 |
*** praneshp has joined #openstack-ironic | 23:47 | |
*** todd_dsm has joined #openstack-ironic | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!