| *** Masahiro has quit IRC | 00:01 | |
| *** david-lyle is now known as david-lyle_afk | 00:06 | |
| *** andreykurilin has quit IRC | 00:26 | |
| *** Masahiro has joined #openstack-ironic | 00:57 | |
| jiangfei|2 | good morning mrda, jroll | 00:59 |
|---|---|---|
| jroll | hiya jiangfei|2 :) | 01:00 |
| jiangfei|2 | Envy you have holidays :) | 01:00 |
| *** Masahiro has quit IRC | 01:02 | |
| mrda | hi jiangfei|2 | 01:04 |
| jiangfei|2 | :) | 01:05 |
| *** chenglch has joined #openstack-ironic | 01:23 | |
| *** ryanpetrello has quit IRC | 01:27 | |
| *** Haomeng has joined #openstack-ironic | 01:31 | |
| *** Haomeng|2 has quit IRC | 01:32 | |
| *** jerryz has joined #openstack-ironic | 01:36 | |
| *** eghobo has quit IRC | 02:38 | |
| *** Masahiro has joined #openstack-ironic | 02:46 | |
| *** Masahiro has quit IRC | 02:50 | |
| *** ryanpetrello has joined #openstack-ironic | 03:11 | |
| *** ryanpetrello has quit IRC | 03:16 | |
| *** dlaube has quit IRC | 03:19 | |
| *** dlaube1 has joined #openstack-ironic | 03:19 | |
| *** dlaube1 has quit IRC | 03:20 | |
| *** aweeks has quit IRC | 03:20 | |
| *** bigjools has quit IRC | 03:21 | |
| *** aweeks has joined #openstack-ironic | 03:22 | |
| *** bigjools has joined #openstack-ironic | 03:25 | |
| *** Masahiro has joined #openstack-ironic | 03:47 | |
| *** Masahiro has quit IRC | 03:51 | |
| *** dlaube has joined #openstack-ironic | 03:52 | |
| *** dlaube has quit IRC | 04:22 | |
| *** pcrews has quit IRC | 04:43 | |
| openstackgerrit | Haomeng,Wang proposed openstack/ironic: call set_failed_state if can not get root_uuid https://review.openstack.org/143919 | 05:07 |
| *** Marga_ has joined #openstack-ironic | 05:27 | |
| *** Marga_ has quit IRC | 05:30 | |
| *** Marga_ has joined #openstack-ironic | 05:31 | |
| *** Masahiro has joined #openstack-ironic | 05:35 | |
| *** Masahiro has quit IRC | 05:39 | |
| *** killer_prince has quit IRC | 05:44 | |
| *** pcrews has joined #openstack-ironic | 05:48 | |
| *** Marga_ has quit IRC | 05:50 | |
| *** Marga_ has joined #openstack-ironic | 05:54 | |
| *** killer_prince has joined #openstack-ironic | 06:02 | |
| *** killer_prince is now known as lazy_prince | 06:02 | |
| *** pensu has joined #openstack-ironic | 06:05 | |
| *** Marga_ has quit IRC | 06:06 | |
| *** Marga_ has joined #openstack-ironic | 06:09 | |
| *** Marga_ has quit IRC | 06:09 | |
| *** Marga_ has joined #openstack-ironic | 06:10 | |
| *** Haomeng|2 has joined #openstack-ironic | 06:17 | |
| *** Haomeng has quit IRC | 06:18 | |
| *** Marga_ has quit IRC | 06:24 | |
| *** Marga_ has joined #openstack-ironic | 06:25 | |
| *** enikanorov has quit IRC | 06:31 | |
| *** pcrews has quit IRC | 06:32 | |
| *** Masahiro has joined #openstack-ironic | 06:36 | |
| *** achanda has joined #openstack-ironic | 06:39 | |
| *** Masahiro has quit IRC | 06:40 | |
| *** mrda is now known as mrda-away | 06:58 | |
| *** achanda has quit IRC | 07:06 | |
| *** achanda has joined #openstack-ironic | 07:44 | |
| *** achanda has quit IRC | 08:01 | |
| *** wanghua has joined #openstack-ironic | 08:22 | |
| *** Masahiro has joined #openstack-ironic | 08:25 | |
| *** jerryz has quit IRC | 08:27 | |
| *** Masahiro has quit IRC | 08:29 | |
| *** achanda has joined #openstack-ironic | 08:31 | |
| *** Marga_ has quit IRC | 08:36 | |
| *** achanda has quit IRC | 08:36 | |
| *** Marga_ has joined #openstack-ironic | 08:44 | |
| *** achanda has joined #openstack-ironic | 08:47 | |
| *** Marga_ has quit IRC | 08:50 | |
| *** Marga_ has joined #openstack-ironic | 08:53 | |
| *** Marga_ has quit IRC | 08:54 | |
| *** andreykurilin has joined #openstack-ironic | 09:00 | |
| *** Marga_ has joined #openstack-ironic | 09:04 | |
| *** andreykurilin has quit IRC | 09:10 | |
| *** andreykurilin has joined #openstack-ironic | 09:11 | |
| *** achanda has quit IRC | 09:13 | |
| *** Marga_ has quit IRC | 09:16 | |
| *** Marga_ has joined #openstack-ironic | 09:16 | |
| *** romcheg has joined #openstack-ironic | 09:22 | |
| *** foexle has joined #openstack-ironic | 09:22 | |
| *** Haomeng has joined #openstack-ironic | 09:24 | |
| *** pcaruana has joined #openstack-ironic | 09:24 | |
| *** Haomeng|2 has quit IRC | 09:24 | |
| *** krtaylor has quit IRC | 09:24 | |
| *** krtaylor has joined #openstack-ironic | 09:26 | |
| *** andreykurilin has quit IRC | 09:30 | |
| *** andreykurilin has joined #openstack-ironic | 09:31 | |
| *** andreykurilin has quit IRC | 09:41 | |
| *** Marga_ has quit IRC | 09:44 | |
| *** bradjones has quit IRC | 10:12 | |
| *** bradjones has joined #openstack-ironic | 10:13 | |
| *** Masahiro has joined #openstack-ironic | 10:14 | |
| *** wanghua has quit IRC | 10:17 | |
| *** Masahiro has quit IRC | 10:18 | |
| *** chenglch has quit IRC | 10:48 | |
| *** achanda has joined #openstack-ironic | 10:53 | |
| *** Haomeng has quit IRC | 11:06 | |
| *** Haomeng has joined #openstack-ironic | 11:07 | |
| *** achanda has quit IRC | 11:19 | |
| *** achanda has joined #openstack-ironic | 11:33 | |
| *** Marga_ has joined #openstack-ironic | 11:36 | |
| *** Masahiro has joined #openstack-ironic | 12:02 | |
| *** Marga_ has quit IRC | 12:03 | |
| *** Marga_ has joined #openstack-ironic | 12:03 | |
| *** Masahiro has quit IRC | 12:07 | |
| *** Marga_ has quit IRC | 12:18 | |
| *** romcheg has quit IRC | 12:25 | |
| *** pcaruana has quit IRC | 12:36 | |
| *** romcheg has joined #openstack-ironic | 12:41 | |
| *** achanda has quit IRC | 12:45 | |
| *** pcaruana has joined #openstack-ironic | 12:47 | |
| *** openstack has joined #openstack-ironic | 13:07 | |
| *** achanda has joined #openstack-ironic | 13:09 | |
| *** pensu has quit IRC | 13:31 | |
| *** pensu has joined #openstack-ironic | 13:32 | |
| *** pensu has quit IRC | 13:40 | |
| *** jerryz has joined #openstack-ironic | 13:41 | |
| *** achanda has quit IRC | 13:46 | |
| *** achanda has joined #openstack-ironic | 13:47 | |
| *** Masahiro has joined #openstack-ironic | 13:51 | |
| *** achanda has quit IRC | 13:52 | |
| *** Masahiro has quit IRC | 13:55 | |
| *** ryanpetrello has joined #openstack-ironic | 13:59 | |
| *** EmilienM is now known as EmilienM|afk | 14:03 | |
| *** trown has quit IRC | 14:08 | |
| *** trown has joined #openstack-ironic | 14:09 | |
| *** EmilienM|afk is now known as EmilienM | 14:15 | |
| *** achanda has joined #openstack-ironic | 15:14 | |
| *** sambetts has joined #openstack-ironic | 15:24 | |
| *** Masahiro has joined #openstack-ironic | 15:40 | |
| NobodyCam | morning Ironic | 15:44 |
| *** Masahiro has quit IRC | 15:44 | |
| *** jerryz has quit IRC | 15:51 | |
| *** vdrok has quit IRC | 15:51 | |
| jroll | morning NobodyCam :) | 16:05 |
| jroll | http://www.slideshare.net/codeblue_jp/igor-skochinsky-enpub | 16:05 |
| jroll | awesome slide deck about intel ME | 16:05 |
| victor_lowther | Yeah, that was pretty neat. | 16:12 |
| victor_lowther | And a testament on not giving untrusted actors access to your systems. | 16:12 |
| jroll | heh | 16:12 |
| jroll | >.> | 16:13 |
| victor_lowther | getting a rootkit in ME would be nearly impossible to detect or clean without reflashing the hard way | 16:13 |
| *** vdrok has joined #openstack-ironic | 16:18 | |
| *** pcrews has joined #openstack-ironic | 16:23 | |
| NobodyCam | ya I tend to not like things that allow Poison Pill type attacks | 17:03 |
| *** sirushti has quit IRC | 17:11 | |
| *** romcheg has quit IRC | 17:13 | |
| *** romcheg has joined #openstack-ironic | 17:13 | |
| *** sirushti has joined #openstack-ironic | 17:13 | |
| *** romcheg has quit IRC | 17:17 | |
| *** achanda_ has joined #openstack-ironic | 17:21 | |
| *** achanda_ has quit IRC | 17:22 | |
| *** achanda_ has joined #openstack-ironic | 17:22 | |
| *** achanda has quit IRC | 17:24 | |
| *** Masahiro has joined #openstack-ironic | 17:29 | |
| *** foexle has quit IRC | 17:29 | |
| *** achanda_ has quit IRC | 17:32 | |
| *** achanda has joined #openstack-ironic | 17:33 | |
| *** Masahiro has quit IRC | 17:33 | |
| *** achanda_ has joined #openstack-ironic | 17:35 | |
| *** achanda has quit IRC | 17:36 | |
| *** ryanpetrello_ has joined #openstack-ironic | 17:38 | |
| *** ryanpetrello has quit IRC | 17:38 | |
| *** ryanpetrello_ is now known as ryanpetrello | 17:38 | |
| *** achanda_ has quit IRC | 17:41 | |
| *** achanda has joined #openstack-ironic | 17:42 | |
| *** dlaube has joined #openstack-ironic | 17:45 | |
| *** achanda has quit IRC | 17:46 | |
| *** harlowja has joined #openstack-ironic | 18:13 | |
| *** romcheg has joined #openstack-ironic | 18:13 | |
| devananda | morning, folks | 18:19 |
| jroll | heya devananda | 18:21 |
| *** EmilienM is now known as EmilienM|food | 18:24 | |
| *** EmilienM|food is now known as EmilienM|afk | 18:25 | |
| *** achanda has joined #openstack-ironic | 18:35 | |
| *** coolsvap has quit IRC | 18:36 | |
| *** coolsvap has joined #openstack-ironic | 18:39 | |
| *** ijw has joined #openstack-ironic | 18:51 | |
| * jroll plugs some reviews | 18:53 | |
| jroll | https://review.openstack.org/#/c/143167/ | 18:53 |
| jroll | https://review.openstack.org/#/c/143168/ | 18:53 |
| jroll | https://review.openstack.org/#/c/143480/ | 18:53 |
| JayF | that spec is in my queue for review today | 18:56 |
| jroll | woot | 18:58 |
| *** pcaruana has quit IRC | 19:00 | |
| *** pensu has joined #openstack-ironic | 19:06 | |
| *** datajerk has quit IRC | 19:09 | |
| *** afaranha has joined #openstack-ironic | 19:13 | |
| *** romcheg has quit IRC | 19:13 | |
| *** Masahiro has joined #openstack-ironic | 19:17 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic-specs: Implement Cleaning States https://review.openstack.org/102685 | 19:19 |
| *** Masahiro has quit IRC | 19:21 | |
| JayF | I just put the first +2 on https://review.openstack.org/#/c/102685 if someone else wants to take a look. | 19:23 |
| JayF | JoshNang: ^ great job | 19:23 |
| JoshNang | JayF: thanks! | 19:23 |
| *** Haomeng|2 has joined #openstack-ironic | 19:31 | |
| *** Haomeng has quit IRC | 19:32 | |
| *** afaranha has quit IRC | 20:18 | |
| *** ryanpetrello has quit IRC | 20:45 | |
| *** ryanpetrello has joined #openstack-ironic | 20:50 | |
| *** david-lyle_afk is now known as david-lyle | 20:58 | |
| *** pensu has quit IRC | 21:00 | |
| *** Masahiro has joined #openstack-ironic | 21:06 | |
| *** Masahiro has quit IRC | 21:10 | |
| *** achanda has quit IRC | 21:13 | |
| *** mrda-away is now known as mrda | 21:17 | |
| mrda | Morning Ironic | 21:17 |
| *** EmilienM|afk is now known as EmilienM | 21:19 | |
| *** ijw has quit IRC | 21:28 | |
| *** Marga_ has joined #openstack-ironic | 21:32 | |
| *** Marga_ has quit IRC | 21:35 | |
| *** andreykurilin has joined #openstack-ironic | 21:43 | |
| devananda | g'morning, mrda | 22:07 |
| mrda | hey devananda | 22:11 |
| mrda | devananda: have you had a nice holiday break? | 22:12 |
| *** harlowja is now known as harlowja_away | 22:17 | |
| *** ryanpetrello has quit IRC | 22:25 | |
| *** ryanpetrello has joined #openstack-ironic | 22:26 | |
| *** romcheg has joined #openstack-ironic | 22:35 | |
| JayF | devananda: I'm going to get tests passing + a new test case for https://review.openstack.org/#/c/143193/ --- but WDYT about "internal" API breakage for IPA? I'm thinking I should toss something out to the mailing list, but in reality, the existing behavior isn't very useful and the new behavior is pretty much how we've been telling people it worked all along | 22:39 |
| * devananda slogs into the third hour of filing expense reports, and continues to ignore IRC | 22:44 | |
| *** andreykurilin has quit IRC | 22:52 | |
| *** andreykurilin has joined #openstack-ironic | 22:52 | |
| *** Masahiro has joined #openstack-ironic | 22:55 | |
| *** pcm has joined #openstack-ironic | 22:58 | |
| *** ryanpetrello has quit IRC | 22:58 | |
| *** Masahiro has quit IRC | 22:59 | |
| clif_h | Can someone check my thinking here? It seems like the RPCService object in ironic/common/service.py tears down things in the wrong order. If I initialize things in an order-dependent way, as in I init A, then B, then C, should I tear down in this order: C, then B, then A, right? | 23:01 |
| clif_h | RPCService tears down the service before stopping the server | 23:01 |
| clif_h | Shouldn't it tear down the server before stopping the service? | 23:02 |
| clif_h | we should stop accepting new requests before trying to stop the service | 23:02 |
| clif_h | otherwise a request could come in but the service is already down | 23:03 |
| JayF | That makes sense to me, but I haven't looked at the code for that yet | 23:05 |
| jroll | ^ | 23:06 |
| clif_h | at least it makes sense | 23:06 |
| pcm | Anyone here interested in pyghmi? I pushed a very small patch up for review and so I can figure out the general process before I try anything bigger, and I'm eager for feedback on anything I did wrong or should have done, etc | 23:14 |
| jroll | pcm: link to review? there's only a couple folks that work on pyghmi here, they may be on holiday | 23:15 |
| pcm | https://review.openstack.org/#/c/144181/ | 23:16 |
| JayF | Hey pcm, are you Peter? | 23:16 |
| *** romcheg has quit IRC | 23:17 | |
| pcm | Hehe yep. pcm is Peter C Martini | 23:17 |
| jroll | ohai | 23:17 |
| jroll | :D | 23:17 |
| JayF | Welcome :) me + jroll + clif_h + JoshNang + russell_h + aweeks + morgabra are all your partners in OCP-crime at Rackspace :) | 23:17 |
| JoshNang | o/ | 23:18 |
| * aweeks waves | 23:18 | |
| clif_h | OCP? | 23:18 |
| jroll | open compute | 23:18 |
| pcm | Hi! jroll, JayF, and russell_h I guessed, glad to see a few names I didn't recall or didn't yet know too. Nice to meet y'all | 23:19 |
| jroll | cool :) | 23:20 |
| jroll | pcm: so one thing to note, you don't need to / shouldn't vote on your own patches | 23:20 |
| clif_h | Open ComPute? | 23:20 |
| JayF | clif_h: Open Compute Project | 23:20 |
| clif_h | oh yeah | 23:20 |
| jroll | TIL :P | 23:20 |
| pcm | heh, whoops, sorry | 23:20 |
| pcm | Can I undo that? | 23:21 |
| JayF | Reply -> select 0 as the vote | 23:21 |
| JayF | or just don't worry about it :) | 23:21 |
| clif_h | OCP is from robocop | 23:21 |
| clif_h | that's what I thought of when I saw that acronym | 23:22 |
| pcm | I hadn't remembered that the acronym was in Robocop until I saw the remake. Then OpenCompute got a whole lot funnier | 23:22 |
| jroll | pcm: threw a review on there | 23:22 |
| jroll | and yes, you can hit "add comment" again and change your vote to 0 | 23:22 |
| clif_h | jroll: the pep8 check on that review seems to have passed | 23:23 |
| clif_h | unless it just didn't do anything | 23:23 |
| jroll | clif_h: yeah :| | 23:24 |
| jroll | I think it's not using the hacking package | 23:24 |
| jroll | which is some addons to flake | 23:24 |
| pcm | So the -1 basically means split out that change to a separate thing to handle the pep8 cleanliness? | 23:24 |
| jroll | oh, it is | 23:24 |
| jroll | wtf | 23:24 |
| jroll | pcm: no, just don't delete those lines | 23:25 |
| jroll | pcm: to push a fixed patch, just amend your previous commit (git commit --amend) and run git review again | 23:25 |
| pcm | oh, my bad. Can you point me to why that makes a difference? | 23:25 |
| jroll | well | 23:25 |
| jroll | 1) it's unrelated to your change | 23:26 |
| jroll | 2) it's a common style rule in most openstack projects, not sure why pep8 isn't picking it up here though | 23:26 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Allow use of multiple simultaneous HW managers https://review.openstack.org/143193 | 23:29 |
| pcm | k, 1 makes perfect sense, though I'm not clear on where the style rule comes into play. Can you explain what that rule is or point me to something? Or better yet, let me know where I can find the test that should have failed so I can dig deeper :-) | 23:29 |
| JayF | I suspect the pep8 on that repo is configured less aggressively for reasons that are completely irrelevent to your change :) | 23:30 |
| jroll | yeah, that | 23:30 |
| pcm | I'm happy to go through and clean up style stuff too (if that's something worthwhile), and obviously as a separate bit of work | 23:30 |
| jroll | there's a rule where imports go: stdlib, third-party, project modules, in alphabetical order, with a blank line between each | 23:31 |
| jroll | there's another where something something two blank lines between things at the outmost indent | 23:31 |
| JayF | and three lines between classes, right? | 23:32 |
| jroll | CI should catch these for you, you shouldn't need to worry about them with your own brain | 23:32 |
| jroll | I just... tend to do that | 23:32 |
| jroll | JayF: two blanks | 23:32 |
| jroll | so three returns | 23:32 |
| JayF | three-ent... yeah | 23:32 |
| JoshNang | from the docs: https://www.python.org/dev/peps/pep-0008/#blank-lines | 23:32 |
| jroll | :P | 23:32 |
| *** andreykurilin has quit IRC | 23:32 | |
| jroll | ah, yeah | 23:32 |
| jroll | OH | 23:33 |
| jroll | that file doesn't have a .py | 23:33 |
| JayF | pcm: most likely the change you'd make if you wanted CI to be happier would be to look at the tox.ini, see how the hacking configuration differs from Ironic (maybe even the version in requirements), change it to match and then fix things until it passes :) | 23:33 |
| jroll | I bet that's why pep8 doesn't see it | 23:33 |
| *** romcheg has joined #openstack-ironic | 23:33 | |
| JayF | aha | 23:33 |
| JayF | good call jroll | 23:33 |
| JayF | that should be fixed in the tox.ini as well :) | 23:33 |
| jroll | so like... that's a way bigger change | 23:33 |
| jroll | I mean | 23:33 |
| pcm | Thanks for the link! | 23:33 |
| JayF | no it's not | 23:33 |
| jroll | that's just how pep8 works, I think | 23:33 |
| JayF | aha, https://github.com/openstack/ironic-python-agent/blob/master/tox.ini#L20 | 23:33 |
| JayF | I thought we specified a filename there, but only a dir :( | 23:34 |
| jroll | yeah | 23:34 |
| JayF | that file should probably have a .py added and the non-.py version could be symlinked back | 23:34 |
| JayF | but that's a different change and possibly picking a fight :) | 23:34 |
| jroll | yeah | 23:34 |
| jroll | I mean, I would go all the way to using setup.cfg things | 23:34 |
| jroll | anyway, we digress | 23:34 |
| JayF | btw, welcome to irc pcm :) | 23:35 |
| JayF | you'll find us here most business hours PST, and usually the channel is hopping with more than just us even now | 23:35 |
| JayF | Only Rackers have the, uh, dedication to work the last two days of the year :P | 23:36 |
| jroll | pcm: I think you should fix those... as far as getting it through, devananda and jjohnso (who is on holiday) have core reviewer status on that project | 23:36 |
| pcm | I'm at work now, and its EST (EDT? always forget that ...) | 23:36 |
| jroll | lol | 23:36 |
| jroll | s/business hours/all hours/ | 23:36 |
| pcm | Yep, will do later tonight. Going to poke at this a bit more at home | 23:38 |
| victor_lowther | heh. I was shocked to see so much activity in the channel. | 23:38 |
| jroll | :P | 23:38 |
| victor_lowther | This morning was D E D dead. | 23:38 |
| jroll | same yesterday | 23:38 |
| JayF | What'd you get for christmas victor_lowther? Did your $close_family_or_friend tell you "Dude, you're getting a DELL" perhaps? | 23:38 |
| * jroll cringes | 23:39 | |
| JayF | yeah, had to work too hard for that one :P | 23:39 |
| victor_lowther | I got a lollipop made of hairbands from my hairband-stealing wife, a wallet from same, a cut-down tree, and a new fence. | 23:39 |
| * JayF got mostly gift cards which he used to buy nice seats to tonight's hockey game | 23:40 | |
| victor_lowther | My wife got a new Alienware desktop to replace her dead XPS laptop and my aged D830 she was using in the interim. | 23:40 |
| JayF | I deployed a bunch of D{6,8}{2,3}0 laptops around 8 years ago | 23:40 |
| JayF | you aren't kidding it was aged | 23:40 |
| victor_lowther | Mussing several keys on the keyboard due to random act of toddler | 23:41 |
| victor_lowther | but it still ran. | 23:41 |
| victor_lowther | The kids got all the awesome presents, of course. | 23:41 |
| JayF | So I got my Bro-in-law a chromebook for Christmas. First one we got, pulled it out of the box to check it (family is on the east coast so wanted to make sure it worked before flying) and it had a broken key on it | 23:41 |
| JayF | IDK how you break a keyboard on a laptop before it gets into a sealed box | 23:42 |
| victor_lowther | Chiclet keys are real easy to break. I have gotten good at fixing them. :) | 23:42 |
| JayF | this one the plastic hook on the chicklet was busted out | 23:43 |
| JayF | so no repair without the replacement key | 23:43 |
| *** pcrews has quit IRC | 23:45 | |
| victor_lowther | There is that. | 23:49 |
| *** bradjones_ has joined #openstack-ironic | 23:49 | |
| *** bradjones has quit IRC | 23:51 | |
| *** bradjones_ is now known as bradjones | 23:51 | |
| *** bradjones has joined #openstack-ironic | 23:51 | |
| *** bradjones has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!