| naohirot | mrda: I think rain is rare in summer Australia right? | 00:01 |
|---|---|---|
| *** chlong has quit IRC | 00:01 | |
| *** chlong has joined #openstack-ironic | 00:02 | |
| mrda | naohirot: we get little summer rain, except for the occasional big storm and downpour. | 00:04 |
| naohirot | mrda: I see, here typhoon brings a lot of rain which cause a problem :) | 00:05 |
| *** chlong has quit IRC | 00:06 | |
| mrda | we don't get typhoons here fortunately. | 00:06 |
| naohirot | mrda: no hurricane too? | 00:07 |
| *** Marga_ has quit IRC | 00:08 | |
| naohirot | mrda: cyclone is more accurate, I think. | 00:08 |
| *** Marga_ has joined #openstack-ironic | 00:08 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Allow use of multiple simultaneous HW managers https://review.openstack.org/143193 | 00:09 |
| JayF | NobodyCam: ^ added docstrings for those two tests to make it more clear | 00:09 |
| JayF | NobodyCam: fwiw you do have the big hammer in IPA as well ;) | 00:09 |
| NobodyCam | :) | 00:10 |
| NobodyCam | JayF: thank you | 00:10 |
| *** Marga_ has quit IRC | 00:10 | |
| NobodyCam | that actually helps (me) | 00:10 |
| JayF | np at all | 00:10 |
| *** Marga_ has joined #openstack-ironic | 00:10 | |
| JayF | It should be clear what's going on, if not, and not commented, that's as bad as the code failing | 00:10 |
| JayF | because the tests should model for people how their hardware managers will work together | 00:10 |
| * JayF out for a bit | 00:10 | |
| openstackgerrit | Alex Weeks proposed openstack/ironic-python-agent: Added extension to support rescue mode https://review.openstack.org/145385 | 00:10 |
| JayF | ty for the review | 00:10 |
| NobodyCam | :0 | 00:10 |
| NobodyCam | :) | 00:10 |
| *** Marga_ has quit IRC | 00:11 | |
| *** Marga_ has joined #openstack-ironic | 00:11 | |
| Haomeng|2 | morning ironic:) | 00:15 |
| mrda | naohirot: we only get cyclones in the northern half of the country. Where I am we're safe from such things. | 00:15 |
| naohirot | Haomeng|2: good morning | 00:15 |
| mrda | Hi Haomeng|2 | 00:15 |
| Haomeng|2 | naohirot::) | 00:15 |
| Haomeng|2 | mrda: :) | 00:16 |
| Haomeng|2 | one question, if that is possible, ironic can support overlay networking, such as gre and vxlan? | 00:16 |
| Haomeng|2 | mrda: I test our ironic with flat networking, that is fine | 00:16 |
| Haomeng|2 | but not sure if ironic support vlan, I think so, just depends on the networking configurations | 00:16 |
| jroll | Haomeng|2: not today, give this a look, we're getting there: https://review.openstack.org/#/c/143480/ | 00:16 |
| jroll | Haomeng|2: maybe ironic could support one vlan today, if everything is in that vlan, I'm not sure | 00:17 |
| Haomeng|2 | jroll: thanks | 00:17 |
| Haomeng|2 | jroll: yes we support flat and vlan today | 00:17 |
| Haomeng|2 | jroll: our IPA will support overlay networking with the 'pluggable network provider spec', right? that is cool! | 00:18 |
| jroll | Haomeng|2: the goal is everything, but I don't think pxe booting the instance will work | 00:18 |
| Haomeng|2 | jroll: yes:) | 00:19 |
| jroll | so once pxe driver has local boot, it should work | 00:19 |
| Haomeng|2 | jroll: pxe does not support overlay | 00:19 |
| *** ijw has quit IRC | 00:19 | |
| Haomeng|2 | jroll: you mean we run local bootloader in local hd, right? | 00:20 |
| *** Masahiro has joined #openstack-ironic | 00:20 | |
| jroll | Haomeng|2: yes | 00:20 |
| Haomeng|2 | jroll: our IPA can create local bootloader in the harddisk now? | 00:20 |
| jroll | Haomeng|2: IPA only does full disk images (and so only does local boot) | 00:20 |
| Haomeng|2 | jroll: yes, IPA is cool! | 00:20 |
| jroll | Haomeng|2: this is the spec for local boot for pxe https://review.openstack.org/#/c/143636/ | 00:21 |
| Haomeng|2 | jroll: ok, thanks | 00:22 |
| jroll | Haomeng|2: I know it's cool, I run it in production :P | 00:22 |
| Haomeng|2 | jroll: yes! | 00:22 |
| Haomeng|2 | jroll: IPA has production quality and function supporting | 00:22 |
| Haomeng|2 | jroll: ++ for IPA :) | 00:22 |
| jroll | yep :) | 00:22 |
| *** Masahiro has quit IRC | 00:24 | |
| *** Marga_ has quit IRC | 00:25 | |
| *** Marga_ has joined #openstack-ironic | 00:26 | |
| naohirot | NobodyCam: I have to leave at 00:45UTC for a meeting | 00:28 |
| NobodyCam | ok | 00:28 |
| naohirot | NobodyCam: did you have a chance to look at it? maybe not. | 00:29 |
| *** chlong has joined #openstack-ironic | 00:29 | |
| *** Marga__ has joined #openstack-ironic | 00:30 | |
| *** Marga_ has quit IRC | 00:30 | |
| *** Marga__ has quit IRC | 00:30 | |
| *** Marga_ has joined #openstack-ironic | 00:30 | |
| NobodyCam | naohirot: just looked at 136020 | 00:31 |
| NobodyCam | needs to have the request lib ref removed. there are three you marked two of them already :) | 00:31 |
| *** Marga_ has quit IRC | 00:31 | |
| *** Marga_ has joined #openstack-ironic | 00:32 | |
| naohirot | NobodyCam: thanks. The point I'd like to hear your opinion is whether or not I have to separate out the scci module to a external library. | 00:33 |
| *** smoriya has joined #openstack-ironic | 00:34 | |
| *** Marga_ has quit IRC | 00:35 | |
| *** Marga_ has joined #openstack-ironic | 00:35 | |
| NobodyCam | is it already on pypi? I have not searched | 00:36 |
| *** Marga_ has quit IRC | 00:37 | |
| NobodyCam | or are you planing on just having it as part of the patch | 00:37 |
| *** Marga_ has joined #openstack-ironic | 00:37 | |
| naohirot | NobodyCam: No, yesterday I had a conversation with rameshg87, and I got the comment to do so. | 00:38 |
| naohirot | NobodyCam: I think it's better to include necessary module within Ironic from customer's point of view | 00:39 |
| naohirot | NobodyCam: so I have to create PyPI if I take the way to separate out. | 00:40 |
| NobodyCam | naohirot: for me that depends on size .. if its only used for one driver then there is not a neet to include it in the tree, when folks using that driver can easily pip install it | 00:41 |
| naohirot | NobodyCam: you can see the size https://review.openstack.org/#/c/144901/ | 00:42 |
| jroll | +1 for that library being out of tree | 00:42 |
| jroll | oh | 00:42 |
| * jroll looks | 00:42 | |
| NobodyCam | but it makes good sense to me to split it out | 00:42 |
| jroll | naohirot: where is the scciclient package today? | 00:42 |
| *** Marga_ has quit IRC | 00:42 | |
| *** Marga_ has joined #openstack-ironic | 00:43 | |
| naohirot | jroll: at this moment no package exist. there is source code in my dev env, that's all. | 00:43 |
| jroll | naohirot: I see. it's super easy to put a thing on stackforge and pypi, I'd rather go that route | 00:44 |
| *** jerryz has joined #openstack-ironic | 00:44 | |
| NobodyCam | naohirot: yea I have to agree with jroll | 00:44 |
| naohirot | NobodyCam: you can see the size patch set 4 which all included 4,000 including test data(xml) | 00:44 |
| NobodyCam | ya | 00:45 |
| *** Marga_ has quit IRC | 00:45 | |
| naohirot | NobodyCam: jroll: Okay I'm going to proceed to create the external package. | 00:45 |
| NobodyCam | naohirot: awesome... and as jroll said its not all that hard | 00:45 |
| jroll | naohirot: cool, thanks | 00:46 |
| *** Marga_ has joined #openstack-ironic | 00:46 | |
| NobodyCam | naohirot: I think this is a pretty good over view: http://peterdowns.com/posts/first-time-with-pypi.html | 00:46 |
| naohirot | NobodyCam: jroll: I'm investigation how to create PyPi package. | 00:46 |
| *** Marga_ has quit IRC | 00:47 | |
| jroll | NobodyCam: https://twitter.com/bcantrill/status/552551004114534403 | 00:47 |
| NobodyCam | lol | 00:47 |
| NobodyCam | nice | 00:47 |
| jroll | naohirot: you should see this https://github.com/openstack-dev/cookiecutter | 00:47 |
| *** Marga_ has joined #openstack-ironic | 00:48 | |
| NobodyCam | jroll: oh yea ++ | 00:48 |
| naohirot | NobodyCam: jroll: Thanks, I have to leave for a meeting | 00:48 |
| NobodyCam | I forgot thatone | 00:48 |
| *** Marga_ has quit IRC | 00:49 | |
| *** Marga_ has joined #openstack-ironic | 00:50 | |
| *** Marga__ has joined #openstack-ironic | 00:50 | |
| *** Marga_ has quit IRC | 00:51 | |
| *** Marga__ has quit IRC | 00:52 | |
| *** Marga__ has joined #openstack-ironic | 00:53 | |
| NobodyCam | JayF: reviewed :) | 00:53 |
| *** Marga__ has quit IRC | 00:54 | |
| * NobodyCam steps afk for a bit | 00:54 | |
| *** Marga_ has joined #openstack-ironic | 00:55 | |
| *** bradjones has quit IRC | 00:55 | |
| *** Marga_ has quit IRC | 00:55 | |
| *** Marga_ has joined #openstack-ironic | 00:56 | |
| *** Marga_ has quit IRC | 00:58 | |
| *** bradjones has joined #openstack-ironic | 00:58 | |
| *** bradjones has quit IRC | 00:58 | |
| *** bradjones has joined #openstack-ironic | 00:58 | |
| *** Marga_ has joined #openstack-ironic | 00:58 | |
| *** Marga_ has quit IRC | 00:58 | |
| *** Marga_ has joined #openstack-ironic | 00:59 | |
| *** Marga_ has quit IRC | 01:00 | |
| *** Marga_ has joined #openstack-ironic | 01:00 | |
| *** Marga_ has quit IRC | 01:02 | |
| *** Marga_ has joined #openstack-ironic | 01:03 | |
| *** Marga_ has quit IRC | 01:04 | |
| *** Marga_ has joined #openstack-ironic | 01:04 | |
| *** dank has quit IRC | 01:04 | |
| smoriya | morning, ironic | 01:06 |
| smoriya | devananda: I have a question about your commit a0a013c | 01:07 |
| *** Marga_ has quit IRC | 01:07 | |
| *** Marga_ has joined #openstack-ironic | 01:07 | |
| *** Marga_ has quit IRC | 01:07 | |
| jroll | smoriya: ask your question, maybe someone else can help | 01:08 |
| *** alexpilotti has quit IRC | 01:08 | |
| *** Marga_ has joined #openstack-ironic | 01:08 | |
| smoriya | OK. | 01:08 |
| *** Marga_ has quit IRC | 01:08 | |
| *** Marga_ has joined #openstack-ironic | 01:09 | |
| *** Marga_ has quit IRC | 01:09 | |
| smoriya | In that commit, devananda remove api.rst and conductor.rst from index.rst | 01:09 |
| smoriya | I'd like to know the reason | 01:09 |
| *** Marga_ has joined #openstack-ironic | 01:09 | |
| smoriya | I introduces build warning which I tried to fix in https://bugs.launchpad.net/ironic/+bug/1277282 | 01:10 |
| smoriya | Should we keep these documents or can remove them? | 01:11 |
| jroll | smoriya: that commit is from nine months ago... | 01:11 |
| jroll | the docs have changed a lot since then | 01:12 |
| smoriya | right | 01:12 |
| jroll | are there still build warnings when you build the docs on master? | 01:14 |
| devananda | I think we can delete conductor, db, common, and api .rst files from ironic/doc/source/dev/ | 01:14 |
| *** Marga_ has quit IRC | 01:14 | |
| devananda | they look like just TOC files. there's no content in them ... | 01:15 |
| smoriya | jroll: yes | 01:15 |
| jroll | there's your answer, I suppose ^ | 01:15 |
| *** Marga_ has joined #openstack-ironic | 01:15 | |
| smoriya | devananda: Thank you for your comments! | 01:15 |
| smoriya | devananda: one more question | 01:16 |
| *** Marga_ has quit IRC | 01:16 | |
| smoriya | devananda: do we need autodoc.rst? I got some warnings related to autodoc | 01:17 |
| *** Marga_ has joined #openstack-ironic | 01:17 | |
| devananda | smoriya: where is that file? | 01:18 |
| smoriya | it is generated by pbr | 01:18 |
| *** Marga_ has quit IRC | 01:19 | |
| devananda | we use the sphinx autodoc extension ... | 01:19 |
| devananda | and yes, we need to use that extension | 01:19 |
| *** Marga_ has joined #openstack-ironic | 01:19 | |
| *** Marga_ has quit IRC | 01:20 | |
| *** Marga__ has joined #openstack-ironic | 01:20 | |
| *** Marga__ has quit IRC | 01:20 | |
| smoriya | devananda: I got it. I'll find other solution for those warnings :) | 01:21 |
| *** Marga_ has joined #openstack-ironic | 01:21 | |
| *** chenglch has joined #openstack-ironic | 01:21 | |
| *** Marga_ has quit IRC | 01:22 | |
| *** Marga_ has joined #openstack-ironic | 01:22 | |
| *** Marga_ has quit IRC | 01:23 | |
| *** Marga__ has joined #openstack-ironic | 01:23 | |
| *** Marga__ has quit IRC | 01:23 | |
| *** Marga_ has joined #openstack-ironic | 01:24 | |
| *** Marga_ has quit IRC | 01:25 | |
| rloo_afk | hi naohirot, I don't have an opinion regarding python-scciclient. You're the one that wants to use it so I wanted to know why. | 01:25 |
| *** GheRivero has joined #openstack-ironic | 01:49 | |
| *** nosnos has joined #openstack-ironic | 01:54 | |
| *** rloo_afk has quit IRC | 02:06 | |
| *** ryanpetrello has quit IRC | 02:08 | |
| *** Masahiro has joined #openstack-ironic | 02:09 | |
| *** Haomeng|2 has quit IRC | 02:11 | |
| *** chlong has quit IRC | 02:11 | |
| openstackgerrit | John Trowbridge proposed stackforge/ironic-discoverd: Adds tenant argument to the keystone client constructor https://review.openstack.org/145657 | 02:16 |
| openstackgerrit | John Trowbridge proposed stackforge/ironic-discoverd: Adds tenant argument to the keystone client constructor https://review.openstack.org/145657 | 02:18 |
| *** pcrews has quit IRC | 02:22 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/145665 | 02:29 |
| openstackgerrit | John Trowbridge proposed stackforge/ironic-discoverd: Adds tenant_name argument to the keystone client constructor https://review.openstack.org/145657 | 02:31 |
| *** ramineni has joined #openstack-ironic | 02:39 | |
| *** ryanpetrello has joined #openstack-ironic | 02:53 | |
| *** Marga_ has joined #openstack-ironic | 03:09 | |
| *** Marga_ has quit IRC | 03:14 | |
| *** Marga_ has joined #openstack-ironic | 03:14 | |
| *** Marga_ has quit IRC | 03:15 | |
| *** Marga_ has joined #openstack-ironic | 03:15 | |
| *** rlr0329 has quit IRC | 03:21 | |
| *** pcrews has joined #openstack-ironic | 03:29 | |
| *** Marga_ has quit IRC | 03:41 | |
| *** nosnos has quit IRC | 03:43 | |
| *** naohirot has quit IRC | 03:43 | |
| openstackgerrit | Steven Dake proposed openstack/ironic: Add documentation to create in RegionOne https://review.openstack.org/139842 | 03:44 |
| *** dlaube has quit IRC | 03:45 | |
| *** ryanpetrello has quit IRC | 03:49 | |
| *** pensu has joined #openstack-ironic | 03:56 | |
| *** chlong has joined #openstack-ironic | 03:57 | |
| *** chlong has quit IRC | 04:02 | |
| *** naohirot has joined #openstack-ironic | 04:09 | |
| naohirot | rloo: thanks for the reply. I understood your intention. I'll reply to you via gerrit. thanks. | 04:12 |
| *** sdake has quit IRC | 04:13 | |
| *** chlong has joined #openstack-ironic | 04:18 | |
| *** pensu has quit IRC | 04:21 | |
| *** jerryz has quit IRC | 04:26 | |
| *** rameshg87 has joined #openstack-ironic | 04:33 | |
| *** nosnos has joined #openstack-ironic | 04:36 | |
| *** naohirot has quit IRC | 04:40 | |
| *** Nisha has joined #openstack-ironic | 04:42 | |
| *** Nisha_away has joined #openstack-ironic | 04:44 | |
| *** Nisha has quit IRC | 04:47 | |
| *** pensu has joined #openstack-ironic | 04:48 | |
| *** naohirot has joined #openstack-ironic | 04:49 | |
| *** david-lyle has quit IRC | 04:50 | |
| *** subscope has joined #openstack-ironic | 04:52 | |
| *** eghobo has joined #openstack-ironic | 05:45 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Discover node properties for iLO drivers https://review.openstack.org/103007 | 06:00 |
| openstackgerrit | Tan Lin proposed openstack/ironic: Correct dev-quickstart https://review.openstack.org/145690 | 06:03 |
| *** killer_prince is now known as lazy_prince | 06:03 | |
| *** eghobo has quit IRC | 06:04 | |
| openstackgerrit | Tan Lin proposed openstack/ironic: Correct dev-quickstart https://review.openstack.org/145690 | 06:05 |
| *** jerryz has joined #openstack-ironic | 06:06 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Discover node properties for iLO drivers https://review.openstack.org/103007 | 06:06 |
| *** subscope has quit IRC | 06:08 | |
| *** rakesh_hs has joined #openstack-ironic | 06:19 | |
| *** pcrews has quit IRC | 06:45 | |
| *** zhidong has joined #openstack-ironic | 06:47 | |
| *** pradipta_away is now known as pradipta | 06:52 | |
| openstackgerrit | Satoru Moriya proposed openstack/ironic: Delete unnecessary document files https://review.openstack.org/145699 | 06:56 |
| *** Marga_ has joined #openstack-ironic | 07:03 | |
| openstackgerrit | Satoru Moriya proposed openstack/ironic: Delete unnecessary document files https://review.openstack.org/145699 | 07:03 |
| rameshg87 | lintan_, hi | 07:04 |
| *** coolsvap|afk is now known as coolsvap | 07:08 | |
| *** jiangfei has quit IRC | 07:08 | |
| *** jiangfei has joined #openstack-ironic | 07:12 | |
| *** dlpartain has joined #openstack-ironic | 07:16 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: New driver interface for RAID configuration https://review.openstack.org/135899 | 07:20 |
| lintan_ | Hi rameshg87 | 07:23 |
| rameshg87 | lintan_, related to https://review.openstack.org/#/c/145690/2, why should we provide --nic option in nova boot command | 07:23 |
| rameshg87 | lintan_, Manual of nova boot says without specifying --nic option, it connects all the networks that are accessible to the tenant. | 07:24 |
| rameshg87 | lintan_, http://docs.openstack.org/admin-guide-cloud/content/advanced_vm_creation.html | 07:24 |
| rameshg87 | lintan_, is it because the bare metal vms created by ironic have only one nic ? | 07:24 |
| lintan_ | rameshg87, yes you are right about this | 07:25 |
| *** dlpartain has left #openstack-ironic | 07:26 | |
| rameshg87 | lintan_, can you please add a sentence about it somewhere ? because for a person looking at this newly, it's not obvious | 07:26 |
| rameshg87 | lintan_, it's not obvious why we need to specify only private network id | 07:27 |
| lintan_ | rameshg87: Once you have multiple neutron networks, you have to choose one | 07:27 |
| rameshg87 | lintan_, yeah | 07:27 |
| rameshg87 | lintan_, but may be sentence on why we are choosing only one might help | 07:28 |
| lintan_ | rameshg87: OK it make sense | 07:29 |
| rameshg87 | lintan_, thanks | 07:33 |
| lintan_ | rameshg87: Thank you :) | 07:33 |
| openstackgerrit | Tan Lin proposed openstack/ironic: Correct dev-quickstart https://review.openstack.org/145690 | 07:37 |
| *** k4n0 has joined #openstack-ironic | 07:38 | |
| *** k4n0 has quit IRC | 07:42 | |
| *** chlong has quit IRC | 07:47 | |
| *** ifarkas has joined #openstack-ironic | 07:56 | |
| *** mrda is now known as mrda-away | 08:18 | |
| *** Marga_ has quit IRC | 08:26 | |
| *** ndipanov has joined #openstack-ironic | 08:29 | |
| *** pradipta is now known as pradipta_away | 08:31 | |
| *** alexpilotti has joined #openstack-ironic | 08:38 | |
| *** andreykurilin has joined #openstack-ironic | 09:01 | |
| *** dtantsur|afk is now known as dtantsur | 09:01 | |
| dtantsur | Morning Ironic | 09:01 |
| naohirot | dtantsur: good morning | 09:07 |
| dtantsur | o/ | 09:07 |
| naohirot | dtantsur: I'd like you to advice me about this heatclient bug https://review.openstack.org/#/c/143059/ which is the same problem I reported to ironiclient. | 09:09 |
| dtantsur | sure | 09:09 |
| naohirot | dtantsur: s/I'd like you to/I'd like ask you to advice me/ | 09:09 |
| dtantsur | what's your problem? | 09:09 |
| *** jistr has joined #openstack-ironic | 09:10 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Add 'default' argument to conf.get* functions https://review.openstack.org/145536 | 09:10 |
| naohirot | dtantsur: The problem is that heat team's review is slow, I jumped into heat IRC channel and asked review a couple of times. | 09:11 |
| *** romcheg has joined #openstack-ironic | 09:11 | |
| naohirot | dtantsur: One thing I'd like to know is that is it possible for you to review it? | 09:12 |
| dtantsur | naohirot, well, it's a known problem in some communities. Unfortunately, there isn't much I can help: I'm not a member of heat team, so my voice means nothing there | 09:12 |
| dtantsur | naohirot, did you try to bring this bug to the attention on the regular meeting (I guess they have one) | 09:13 |
| naohirot | dtantsur: or do you have acquaintance in heat core team? | 09:13 |
| *** lintan_ has quit IRC | 09:13 | |
| dtantsur | naohirot, meeting should do a better job. people tend to dislike when someone they're not related to pings them directly. | 09:14 |
| *** zhidong has quit IRC | 09:14 | |
| naohirot | dtantsur: Yeah, this is the way I can do as a last resort, but considering fixing heat team's problem is not high priority for me :) | 09:15 |
| dtantsur | right :) | 09:15 |
| dtantsur | so you can just wait until they do some bug/patches review day and come across you patch | 09:15 |
| naohirot | dtantsur: Yes, I understood that "people tend to dislike when someone they're not related to pings them directly" | 09:16 |
| *** athomas has joined #openstack-ironic | 09:16 | |
| *** derekh has joined #openstack-ironic | 09:17 | |
| naohirot | dtantsur: Yeah, you are right. just wait for more and see seems better choice at this moment. | 09:17 |
| naohirot | dtantsur: thanks! | 09:17 |
| dtantsur | you're welcome :) | 09:18 |
| naohirot | dtantsur: :) | 09:18 |
| *** jcoufal has joined #openstack-ironic | 09:29 | |
| *** Nisha_away has quit IRC | 09:34 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Remaining changes from making database a required option https://review.openstack.org/145732 | 09:37 |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Add 'default' argument to conf.get* functions https://review.openstack.org/145536 | 09:39 |
| *** Nisha has joined #openstack-ironic | 09:40 | |
| *** andreykurilin has quit IRC | 09:45 | |
| *** MattMan has quit IRC | 10:00 | |
| *** MattMan has joined #openstack-ironic | 10:01 | |
| *** jiangfei has quit IRC | 10:11 | |
| *** jiangfei has joined #openstack-ironic | 10:12 | |
| *** naohirot has quit IRC | 10:17 | |
| openstackgerrit | Merged openstack/ironic: display error logging should be improved https://review.openstack.org/144771 | 10:18 |
| *** rameshg87 has quit IRC | 10:25 | |
| *** yuanying has quit IRC | 10:26 | |
| *** Masahiro has quit IRC | 10:27 | |
| *** Marga_ has joined #openstack-ironic | 10:40 | |
| *** yuanying has joined #openstack-ironic | 10:42 | |
| *** smoriya has quit IRC | 10:42 | |
| *** jiangfei has quit IRC | 10:47 | |
| *** jiangfei has joined #openstack-ironic | 10:48 | |
| * dtantsur brb | 11:00 | |
| *** ramineni has quit IRC | 11:08 | |
| *** pelix has joined #openstack-ironic | 11:10 | |
| *** chenglch has quit IRC | 11:23 | |
| *** naohirot has joined #openstack-ironic | 11:25 | |
| *** Nisha has quit IRC | 11:26 | |
| *** chlong has joined #openstack-ironic | 11:43 | |
| *** lucasagomes has joined #openstack-ironic | 11:55 | |
| *** pensu has quit IRC | 12:06 | |
| *** Masahiro has joined #openstack-ironic | 12:16 | |
| *** Marga_ has quit IRC | 12:16 | |
| *** Marga_ has joined #openstack-ironic | 12:17 | |
| *** Masahiro has quit IRC | 12:20 | |
| *** lucasagomes has quit IRC | 12:23 | |
| *** lucasagomes has joined #openstack-ironic | 12:24 | |
| *** nosnos has quit IRC | 12:30 | |
| *** lucasagomes has quit IRC | 12:33 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add iRMC Driver and its iRMC Power module https://review.openstack.org/144901 | 12:33 |
| *** lucasagomes has joined #openstack-ironic | 12:34 | |
| *** jiangfei has quit IRC | 12:37 | |
| *** derekh has quit IRC | 12:38 | |
| *** jiangfei has joined #openstack-ironic | 12:39 | |
| *** pensu has joined #openstack-ironic | 12:45 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic-specs: iRMC Management Driver for Ironic https://review.openstack.org/136020 | 12:47 |
| *** derekh has joined #openstack-ironic | 12:52 | |
| *** ryanpetrello has joined #openstack-ironic | 12:54 | |
| *** jiangfei has quit IRC | 12:59 | |
| *** jiangfei has joined #openstack-ironic | 13:00 | |
| *** dprince has joined #openstack-ironic | 13:10 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Disable setting IPMI credentials by default https://review.openstack.org/145776 | 13:12 |
| *** ryanpetrello has quit IRC | 13:16 | |
| *** ryanpetrello has joined #openstack-ironic | 13:17 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Functional test for setting IPMI credentials https://review.openstack.org/142823 | 13:18 |
| dtantsur | ifarkas, when you have some time, could you review discoverd patches https://review.openstack.org/#/c/145732 https://review.openstack.org/#/c/145536/ and https://review.openstack.org/#/c/145776/ ? (all pretty small) | 13:20 |
| ifarkas | dtantsur, sure, I put it on my list (although it's a pretty long one now) | 13:21 |
| dtantsur | ack thanks | 13:21 |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic-specs: iRMC Virtual Media Deploy Driver for Ironic https://review.openstack.org/134865 | 13:25 |
| *** alexpilotti has quit IRC | 13:26 | |
| *** romcheg has quit IRC | 13:34 | |
| *** romcheg has joined #openstack-ironic | 13:35 | |
| Shrews | adam_g: devananda: if either of you are still using an hp cloud instance for devstack testing, could you please paste me your localrc? | 13:36 |
| *** jcoufal_ has joined #openstack-ironic | 13:49 | |
| Shrews | adam_g: devananda: nevermind. got it working | 13:49 |
| *** ryanpetrello has quit IRC | 13:50 | |
| *** jcoufal has quit IRC | 13:52 | |
| *** rloo has joined #openstack-ironic | 13:54 | |
| rloo | morning everyone. Anyone know if Steven Dake is around (and what his nick might be?) | 13:58 |
| lucasagomes | rloo, morning, sdake | 14:00 |
| lucasagomes | but I think he's not around | 14:00 |
| lucasagomes | Shrews, morning | 14:00 |
| lucasagomes | rloo, about the commit message, I think we cna update it ourselfs | 14:00 |
| lucasagomes | it's just a nit | 14:00 |
| rloo | lucasagomes: thx. I was just about to ask you that. I'll update it. | 14:01 |
| Shrews | lucasagomes: rloo: morning | 14:01 |
| rloo | morning Shrews | 14:01 |
| rloo | and afternoon lucasagomes ;) | 14:01 |
| lucasagomes | rloo, ack thanks! | 14:02 |
| lucasagomes | afternoon | 14:02 |
| lucasagomes | :) | 14:02 |
| *** Nisha has joined #openstack-ironic | 14:03 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Add documentation to create in RegionOne https://review.openstack.org/139842 | 14:04 |
| *** Masahiro has joined #openstack-ironic | 14:05 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Add documentation to create in RegionOne https://review.openstack.org/139842 | 14:06 |
| *** Masahiro has quit IRC | 14:09 | |
| dtantsur | morning Shrews, rloo | 14:09 |
| Shrews | morning dtantsur | 14:10 |
| BadCub_ | morning Ironic | 14:11 |
| dtantsur | BadCub_, morning | 14:12 |
| rloo | afternoon dtantsur, hi BadCub_ | 14:15 |
| *** pensu has quit IRC | 14:15 | |
| *** ndipanov has quit IRC | 14:19 | |
| *** ndipanov has joined #openstack-ironic | 14:21 | |
| NobodyCam | good morning Ironic | 14:23 |
| NobodyCam | morning rloo, dtantsur, Shrews and lucasagomes | 14:23 |
| dtantsur | NobodyCam, o/ | 14:23 |
| lucasagomes | NobodyCam, mornig :D | 14:23 |
| BadCub_ | Morning dtantsur, rloo and NobodyCam | 14:24 |
| NobodyCam | morning BadCub_ | 14:24 |
| rloo | morning NobodyCam | 14:24 |
| NobodyCam | :) | 14:24 |
| lucasagomes | rloo, thanks for updating the commit message, +2'd | 14:24 |
| *** pensu has joined #openstack-ironic | 14:24 | |
| *** jiangfei has quit IRC | 14:25 | |
| rloo | lucasagomes: you're fast. I was waiting for Jenkins, but maybe I'll just approve it and see what happens ;) | 14:25 |
| openstackgerrit | Tan Lin proposed openstack/ironic: Make 'method' explicit for VendorInterface.validate() https://review.openstack.org/144265 | 14:26 |
| *** jiangfei has joined #openstack-ironic | 14:26 | |
| lucasagomes | rloo, yeah it doesn't get merged if it doesn't pass tests | 14:27 |
| lucasagomes | and as it was only the commit message updated, I think we are grand | 14:28 |
| *** rameshg87 has joined #openstack-ironic | 14:28 | |
| rloo | lucasagomes: +1 | 14:28 |
| *** jcoufal_ is now known as jcoufal | 14:29 | |
| *** alexpilotti has joined #openstack-ironic | 14:30 | |
| lucasagomes | someone knows "Syed Ismail Faizan Barmawer" IRC name? | 14:31 |
| Nisha | sfaian | 14:32 |
| Nisha | sfaizan | 14:32 |
| Nisha | lucasagomes, ^^^ | 14:32 |
| lucasagomes | Nisha, awesome, ta much! | 14:32 |
| Nisha | lucasagomes, wc | 14:32 |
| Nisha | rloo, regarding comment on https://review.openstack.org/#/c/103007/30/specs/kilo/ilo-properties-capabilities-discovery.rst, the methods validate and get_properties in InspectInterface will be implemented for the generic spec. It shouldnt require any change to these functions for additional properties which are planned to be discovered only for ilo | 14:35 |
| rloo | Nisha: ok, if you're sure. Since the other stuff hasn't been implemented yet, I have no idea whether that's true or not. I suppose you could add a note about it. | 14:37 |
| dtantsur | Nisha, validate() should be vendor-specific, i.e. checking ilo_username etc | 14:37 |
| Nisha | rloo, dtantsur ok i will add | 14:39 |
| Nisha | dtantsur, i saw ur comment | 14:39 |
| rloo | thx Nisha (and dtantsur) | 14:39 |
| rloo | Nisha: the reason for adding is to make sure as a reviewer of the code, I don't forget to make sure that validate() etc are implemented if they need to be ;) | 14:39 |
| Nisha | the properties which are listed do not require any action from driver | 14:39 |
| Nisha | rloo, thanks | 14:40 |
| Nisha | i will add | 14:40 |
| Nisha | dtantsur, the properties which are listed do not require any action from driver | 14:40 |
| Nisha | i.e. they are simply hardware properties | 14:40 |
| Nisha | so they may not apply to all the hardwares (even in proliant also) | 14:41 |
| dtantsur | Nisha, what do you mean? I was talking about capabilities and I don't want e.g. ilo become incompatible with drac (in the future) if they call the same thing differently | 14:41 |
| Nisha | these properties can be used by nova for scheduling | 14:41 |
| Nisha | i agree | 14:41 |
| Nisha | dtantsur, do u want me to name the capabilities which will be used in code? | 14:42 |
| *** rloo is now known as rloo_afk | 14:42 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: New driver interface for RAID configuration https://review.openstack.org/135899 | 14:42 |
| dtantsur | Nisha, yeah, the least thing you can do is do list capabilities - their names and possible values (or where these values come from, if they're standard) | 14:42 |
| rloo_afk | will be back in 1-2 hours | 14:42 |
| Nisha | dtantsur, i may not be able to populate all the possible values but can provide the names.... | 14:43 |
| dtantsur | Nisha, though devananda was in favor of delaying any capabilities work, so don't know... | 14:43 |
| Nisha | but this is just simply inspecting the hardware and populating them | 14:43 |
| dtantsur | Nisha, if you call virtualization vt-x and drac calls it VTx, it's a problem | 14:44 |
| Nisha | dtantsur, what i understood from earlier discussions was that he was not in favor to do capabilities work which require actions from driver | 14:44 |
| Nisha | dtantsur, i will update the same in the spec | 14:44 |
| *** lucasagomes is now known as lucas-hungry | 14:46 | |
| devananda | g'morning, all | 14:53 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: Update VirtualBox spec https://review.openstack.org/145800 | 14:53 |
| NobodyCam | morning devananda | 14:55 |
| NobodyCam | you up earily | 14:55 |
| devananda | ya | 14:55 |
| *** pensu has quit IRC | 14:56 | |
| dtantsur | devananda, morning | 14:59 |
| NobodyCam | :) | 15:00 |
| *** jiangfei has quit IRC | 15:01 | |
| *** jiangfei has joined #openstack-ironic | 15:02 | |
| *** ChuckC has joined #openstack-ironic | 15:05 | |
| *** ndipanov has quit IRC | 15:05 | |
| *** ryanpetrello has joined #openstack-ironic | 15:11 | |
| *** rakesh_hs has quit IRC | 15:14 | |
| *** subscope has joined #openstack-ironic | 15:17 | |
| *** ndipanov has joined #openstack-ironic | 15:18 | |
| NobodyCam | Nisha: did you manually create the ironic.conf.sample in 144901? | 15:26 |
| dtantsur | folks, could someone review discoverd inspection spec https://review.openstack.org/#/c/135605/ please? Got 1x +2 already. | 15:28 |
| *** lazy_prince is now known as killer_prince | 15:28 | |
| Nisha | NobodyCam, I think u meant naohirot | 15:28 |
| NobodyCam | doh | 15:29 |
| NobodyCam | I did | 15:29 |
| NobodyCam | tab fail | 15:29 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Minor fixes to state model https://review.openstack.org/145389 | 15:29 |
| NobodyCam | sorry Nisha | 15:29 |
| devananda | NobodyCam: now with good commit message ^ :) | 15:29 |
| Nisha | NobodyCam, u r wc | 15:29 |
| NobodyCam | devananda: will take a look in a minute :) | 15:29 |
| NobodyCam | naohirot: did you manually create the ironic.conf.sample in 144901? | 15:30 |
| * devananda notes that https://review.openstack.org/#/c/145569/ now has 3 +2's | 15:30 | |
| dtantsur | devananda, want someone to press The Button? | 15:30 |
| devananda | dtantsur: maybe? ;) | 15:31 |
| *** lucas-hungry is now known as lucasagomes | 15:32 | |
| NobodyCam | dtantsur: do it :) | 15:32 |
| dtantsur | I DID IT | 15:32 |
| NobodyCam | :) | 15:32 |
| naohirot | NobodyCam: Hi good morning :) | 15:32 |
| devananda | hehehe | 15:32 |
| NobodyCam | hi naohirot | 15:32 |
| BadCub_ | lol | 15:32 |
| naohirot | NobodyCam: Yes, I inserted by editor. | 15:33 |
| NobodyCam | ahh | 15:33 |
| NobodyCam | there is a script to generate it | 15:33 |
| *** dlpartain has joined #openstack-ironic | 15:33 | |
| naohirot | NobodyCam: Ok, it is by-product file. | 15:33 |
| NobodyCam | naohirot: see https://github.com/openstack/ironic/blob/master/tools/config/generate_sample.sh | 15:33 |
| *** dlpartain has left #openstack-ironic | 15:34 | |
| NobodyCam | naohirot: see pm for command example | 15:35 |
| openstackgerrit | Merged openstack/ironic-specs: Correct the diagram for the "current" state machine https://review.openstack.org/145569 | 15:35 |
| *** erwan_taf has quit IRC | 15:36 | |
| naohirot | NobodyCam: what does "pm" stand for? | 15:36 |
| NobodyCam | private message | 15:36 |
| naohirot | NobodyCam: I got it, still I'm not accustomed to IRC :) | 15:37 |
| NobodyCam | :) | 15:37 |
| NobodyCam | ahh TY for removing the commented out lines from states.py :) | 15:39 |
| naohirot | NobodyCam: so it seems the gererate_sample.sh create [iRMC] part automatically form source code, right? | 15:40 |
| NobodyCam | anyone got a second to take a look at https://review.openstack.org/#/c/145389 | 15:41 |
| NobodyCam | naohirot: yep | 15:41 |
| naohirot | NobodyCam: Okay, thanks. I'll fix that tomorrow. good night! | 15:42 |
| NobodyCam | have a good night naohirot | 15:42 |
| *** naohirot has quit IRC | 15:42 | |
| *** erwan_taf has joined #openstack-ironic | 15:50 | |
| NobodyCam | brb | 15:53 |
| *** Masahiro has joined #openstack-ironic | 15:53 | |
| openstackgerrit | Merged stackforge/ironic-discoverd: Remaining changes from making database a required option https://review.openstack.org/145732 | 15:55 |
| *** coolsvap is now known as coolsvap|afk | 15:55 | |
| *** zz_jgrimm is now known as jgrimm | 15:56 | |
| openstackgerrit | Merged stackforge/ironic-discoverd: Add 'default' argument to conf.get* functions https://review.openstack.org/145536 | 15:57 |
| *** Masahiro has quit IRC | 15:58 | |
| *** jerryz has quit IRC | 15:58 | |
| openstackgerrit | Merged stackforge/ironic-discoverd: Disable setting IPMI credentials by default https://review.openstack.org/145776 | 16:00 |
| * dtantsur likes when it takes minutes for a change to pass the gate :) | 16:00 | |
| dtantsur | this http://logs.openstack.org/89/145389/3/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/db570e3/console.html is from the last FSM patch and it bothers me | 16:02 |
| dtantsur | did that change cause it? | 16:02 |
| * dtantsur should have looked before +A'ing obviously | 16:03 | |
| dtantsur | devananda, ^^^ | 16:03 |
| NobodyCam | dtantsur: http://logs.openstack.org/89/145389/3/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/db570e3/console.html#_2015-01-08_16_00_07_404 | 16:04 |
| dtantsur | and before: BadRequest: No valid host was found. Reason: No conductor service registered which supports driver pxe_ssh. (HTTP 400) | 16:04 |
| NobodyCam | ahh yep see it now | 16:05 |
| dtantsur | oh http://logs.openstack.org/89/145389/3/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/db570e3/logs/seed_logs/ironic-conductor.txt.gz | 16:05 |
| NobodyCam | oh | 16:06 |
| *** pcrews has joined #openstack-ironic | 16:06 | |
| dtantsur | but why pxe_ilo? Oo It should be pxe_ssh... | 16:06 |
| *** rloo_afk is now known as rloo | 16:07 | |
| openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/145665 | 16:10 |
| NobodyCam | rloo: lucasagomes: happen to have a free minute to look over https://review.openstack.org/145389 | 16:11 |
| NobodyCam | it has two +2's already | 16:11 |
| devananda | rloo: reading your comments on https://review.openstack.org/#/c/140869/6/ironic/conductor/manager.py | 16:12 |
| devananda | rloo: if that call "fails to fail" then shouldn't we revert the states, so it tries to fail again on the next pass? | 16:13 |
| lucasagomes | will do | 16:13 |
| lucasagomes | devananda, morning | 16:13 |
| NobodyCam | :) | 16:13 |
| devananda | mornin, lucasagomes | 16:13 |
| rloo | NobodyCam: will look at 145665 soon | 16:14 |
| rloo | devananda: looking... | 16:15 |
| dtantsur | I must admit, I don't know what to do with this job failure. Maybe we have ilo driver broken right now... | 16:16 |
| lucasagomes | NobodyCam, this patch is a based on the new state machine? | 16:18 |
| *** ChuckC_ has joined #openstack-ironic | 16:21 | |
| *** ChuckC has quit IRC | 16:22 | |
| devananda | rloo: replied on patch set 6 | 16:26 |
| rloo | devananda: wrt my comment in 140869. the original code didn't use an error handler, so using it changes the behaviour. I didn't think through all the ramifications, but eg. if NoFreeConductorWorker is raised, provisioning_error_handler will take care of it and it won't be raised here, so the 'except exception.NoFreeConductorWorker' part doesn't make sense. (and so the code won't 'break' which will cause workers_count to be w | 16:26 |
| rloo | rong. | 16:26 |
| devananda | rloo: NoFreeConductorWorker is reraised from TaskManager.__exit__ | 16:27 |
| devananda | so it is still necessary to catch and "break" here | 16:27 |
| rloo | devananda: ah. I didn't realize that. Then that is fine. | 16:28 |
| *** ChuckC_ has quit IRC | 16:28 | |
| rloo | devananda: am thinking about the 2nd point... | 16:28 |
| lucasagomes | devananda, re 145389 , in the new state machine isn't the target_provision_state -ED states? for e.g... DEPLOYING->DEPLOYED | 16:29 |
| lucasagomes | and after that the final state is ACTIVE | 16:29 |
| * lucasagomes might be confused | 16:30 | |
| devananda | lucasagomes: target state is ACTIVE the whole time | 16:30 |
| devananda | lucasagomes: current state goes from DEPLOYING -> DEPLOYED -> ACTIVE | 16:30 |
| devananda | right? | 16:30 |
| lucasagomes | I see, I might have confused that part a bit | 16:31 |
| devananda | or maybe I have? | 16:31 |
| *** Marga_ has quit IRC | 16:31 | |
| devananda | hrmm | 16:31 |
| lucasagomes | not sure... I thought that it would be always the transitioning states | 16:31 |
| lucasagomes | the -ING for current | 16:31 |
| lucasagomes | and -ED for target | 16:31 |
| lucasagomes | and after that we would have a final state which in the deploy case would be ACTIVE | 16:31 |
| * devananda looks at the spec | 16:32 | |
| * lucasagomes reopens the spec | 16:32 | |
| devananda | [STATE*/TARGET] STATE* indicates an active state, a momentary state, and a fail state. .... TARGET indicates the target state that Ironic will try to transition the node to ... TARGET must be a passive state. | 16:32 |
| *** chlong has quit IRC | 16:34 | |
| NobodyCam | dtantsur: I'm not sure where that interface var is comming from | 16:34 |
| dtantsur | NobodyCam, me too. I can't find it. | 16:34 |
| lucasagomes | devananda, a-ha, yeah thanks | 16:35 |
| *** erwan_taf has quit IRC | 16:40 | |
| dtantsur | have to go now, see you tomorrow | 16:41 |
| *** dtantsur is now known as dtantsur|afk | 16:42 | |
| Shrews | anyone know Tan Lin's irc nick? | 16:42 |
| NobodyCam | night dtantsur|afk | 16:42 |
| devananda | Shrews: lintan? | 16:43 |
| lucasagomes | Shrews, I think it's lintan | 16:43 |
| lucasagomes | yeah in the logs lintan | 16:43 |
| devananda | hmm, battery is about to die, and I need more coffee. bbiab | 16:43 |
| Shrews | thx. not in channel :( | 16:43 |
| Shrews | devananda: when you return, do you need to specify '--nic net-id=blah' when booting a from devstack? I'm not seeing the need for that (from this review -- https://review.openstack.org/145690) | 16:45 |
| Shrews | works for me w/o that | 16:45 |
| Shrews | i wonder if older versions of devstack required it... | 16:45 |
| lucasagomes | NobodyCam, added a comment on that patch, not voting yet | 16:53 |
| lucasagomes | cause I need some study on the new state machine model | 16:53 |
| *** lxsli has joined #openstack-ironic | 16:53 | |
| NobodyCam | :) oh good catch on the delete[d] thing | 16:54 |
| NobodyCam | brb | 16:55 |
| *** ChuckC_ has joined #openstack-ironic | 16:58 | |
| *** erwan_taf has joined #openstack-ironic | 16:59 | |
| *** ChuckC_ has quit IRC | 16:59 | |
| *** ChuckC_ has joined #openstack-ironic | 16:59 | |
| SpamapS | Is anyone in here aware that we are looking at needing to revert https://review.openstack.org/#/c/139217/ in TripleO? | 16:59 |
| Shrews | SpamapS: oh my. what's the problem? | 17:00 |
| SpamapS | Shrews: ironic won't start sometimes... let me find an example | 17:01 |
| rloo | SpamapS: is there a bug open on that? | 17:01 |
| *** ChuckC_ has quit IRC | 17:01 | |
| *** ChuckC_ has joined #openstack-ironic | 17:01 | |
| SpamapS | https://bugs.launchpad.net/tripleo/+bug/1408701 | 17:01 |
| *** bnemec has joined #openstack-ironic | 17:01 | |
| rloo | I wonder if is the syn-power-state stuff... | 17:02 |
| SpamapS | Driver pxe_ilo could not be loaded. Reason: local variable 'interface' referenced before assignment. | 17:02 |
| *** ChuckC_ is now known as ChuckC | 17:02 | |
| rloo | I think that's the stuff that dtantsur|afk was mentioning in irc earlier | 17:02 |
| *** ChuckC has quit IRC | 17:03 | |
| NobodyCam | ya | 17:03 |
| rloo | I don't see how that could be due to 139217 though | 17:03 |
| SpamapS | rloo: it was bnemec's best guess. :) | 17:03 |
| *** chuckC_ has joined #openstack-ironic | 17:04 | |
| SpamapS | as a recent thing that merged | 17:04 |
| SpamapS | that said, we also only just now enabled pxe_ilo | 17:04 |
| rloo | SpamapS: if you disable pxe_ilo, does it work? | 17:04 |
| Shrews | LP really needs to learn to keep formatting | 17:04 |
| rloo | SpamapS: maybe it has to do with pxe_ilo. I've never used that. let me see if I can test it somehow... | 17:05 |
| SpamapS | rloo: does the Ironic gate not enable all in-tree drivers? | 17:09 |
| rloo | SpamapS: No, not if they require 3rd party libraries. (I think. Or maybe some of them. Not all in-tree anyway.) | 17:10 |
| lucasagomes | SpamapS, nop :( cause we would need to have access to specific hardwares to test it | 17:10 |
| rloo | SpamapS: do you know if proliantutils.ilo.ribcl is installed? | 17:11 |
| *** trown has quit IRC | 17:12 | |
| bnemec | rloo: I think it should be: https://review.openstack.org/#/c/139070/2/elements/ironic/install.d/ironic-source-install/68-ironic | 17:12 |
| NobodyCam | SpamapS: the node is configured for pxe_ssh driver | 17:12 |
| NobodyCam | ? | 17:12 |
| SpamapS | NobodyCam: yeah we only do pxe_ssh | 17:13 |
| SpamapS | lucasagomes: just enabling the driver doesn't require the hardware. | 17:13 |
| bnemec | But we enable more: enabled_drivers = pxe_ssh,pxe_ipmitool,pxe_ilo | 17:13 |
| SpamapS | rloo: yeah proliantutils is being installed | 17:13 |
| SpamapS | ilo just requires a pip installable library | 17:14 |
| rloo | NobodyCam: it shouldn't matter if the node is configured for pxe_ssh. The problem seems to be when the conductor starts up, it doesn't have whatever it needs to load pxe_ilo | 17:14 |
| lucasagomes | oh, right yeah to just enable it is ok | 17:14 |
| bnemec | temprevert didn't fix the problem, so that wasn't it. | 17:14 |
| rloo | bnemec: you mean you removed pxe_ilo from enabled_drivers, and you still get the same error? | 17:15 |
| *** EmilienM is now known as EmilienM|afk | 17:15 | |
| Shrews | it looks a bit like a stevedore issue | 17:16 |
| rloo | hmm, did we get a new version of stevedore? | 17:16 |
| Shrews | either we misconfigured a plugin, or a bug in stevedore itself | 17:16 |
| rloo | looks like stevedore 1.2.0 was released Jan 6 | 17:17 |
| bnemec | stevedore was last updated on the 6th, but it's possible it didn't get synced to the mirror until today. | 17:17 |
| bnemec | Looks like the same stevedore version on passing and failing jobs. | 17:19 |
| *** trown has joined #openstack-ironic | 17:21 | |
| rloo | bnemec: I don't have a problem starting the conductor with pxe_ilo after I installed proliantutils. what stevedore version are you using when it fails? | 17:27 |
| *** rameshg87 has quit IRC | 17:28 | |
| bnemec | rloo: 1.2.0 | 17:28 |
| Shrews | odd. the only references that i can find in our driver code to an 'interface' variable are all within loops that specifically define that variable | 17:30 |
| NobodyCam | some ref in the agent driver but thats not our issue here | 17:31 |
| Shrews | NobodyCam: yeah, that one too, but not relevent | 17:31 |
| rloo | I just tried with stevedore 1.2.0 and it worked too. unless there's some other package that is causing the problem. | 17:32 |
| bnemec | Hmm, I wonder if this is oslo.utils. | 17:34 |
| bnemec | Just released this morning and different versions between passing and failing runs. | 17:34 |
| SpamapS | Shrews: you may be getting eventlet-ed. | 17:34 |
| SpamapS | Shrews: this happened in nova too.. needs to be thread local. | 17:34 |
| NobodyCam | shouldn't stevedore be in http://logs.openstack.org/89/145389/3/check-tripleo/check-tripleo-ironic-undercloud-precise-nonha/db570e3/logs/pip-freeze.txt.gz | 17:35 |
| *** Marga_ has joined #openstack-ironic | 17:35 | |
| *** derekh has quit IRC | 17:35 | |
| bnemec | Oh, I bet this is it: https://review.openstack.org/#/c/143691/ | 17:39 |
| bnemec | Unbound local interface | 17:39 |
| *** eghobo has joined #openstack-ironic | 17:39 | |
| bnemec | So we just need to get that merged and released. | 17:39 |
| rloo | damn. I didn't think that would happen to us. | 17:40 |
| Shrews | bnemec: that linked bug certainly seems to fit | 17:40 |
| rloo | I thought that I thought about that, when we approved a patch that upgraded to using that netutils code. | 17:41 |
| rloo | maybe I thought that bug would be fixed before a new release :-( | 17:41 |
| *** jistr has quit IRC | 17:43 | |
| *** Masahiro has joined #openstack-ironic | 17:43 | |
| *** dlaube has joined #openstack-ironic | 17:43 | |
| bnemec | It should have been, but because the namespace change also happened this release it never got merged because I didn't want to merge conflict the massive namespace patch again. | 17:44 |
| *** romcheg has quit IRC | 17:44 | |
| *** jcoufal has quit IRC | 17:44 | |
| *** romcheg has joined #openstack-ironic | 17:44 | |
| *** romcheg has quit IRC | 17:45 | |
| SpamapS | bnemec: well spotted. | 17:45 |
| NobodyCam | :) nice catch | 17:45 |
| bnemec | It helps that I reviewed the fix. :-) | 17:45 |
| bnemec | rloo: So can you get the fix updated for the new namespace? | 17:46 |
| rloo | although i still don't see how that code got triggered. maybe stevedore calls it. | 17:46 |
| rloo | bnemec: i noticed and fixed it and it never even occurred to me! | 17:46 |
| *** erwan_taf has quit IRC | 17:47 | |
| rloo | bnemec: I don't know. I haven't been paying attention to the new namespace stuff. I suppose it is probably easy to do? You're welcome to fix it. | 17:47 |
| bnemec | I'm betting it's triggered by this: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L60 | 17:48 |
| *** Masahiro has quit IRC | 17:48 | |
| bnemec | rloo: The problem is if I fix it then I can't +2 it. | 17:48 |
| rloo | bnemec: oh. yeah, let's save you for the +2 ! | 17:48 |
| bnemec | Basically all that changed is netutils moved from oslo/utils/netutils to oslo_utils/netutils | 17:48 |
| bnemec | And the tests moved from a top-level tests directory to oslo_utils/tests | 17:48 |
| rloo | ohh... should i just submit a new patch then? | 17:49 |
| rloo | vs a new revision to that patch? | 17:49 |
| bnemec | You can try rebasing the existing one. I'm not sure how smart git is about the file moves. | 17:50 |
| rloo | bnemec: ok. can't do it right away, looks like i have a 2hr meeting starting and i need to grab lunch. | 17:50 |
| bnemec | rloo: Okay, I might just do it then. I can probably wrangle up some other oslo cores for something like this. | 17:51 |
| NobodyCam | bnemec: :) | 17:52 |
| bnemec | Okay, yeah, ugly rebase. Just going to copy-paste to a new change. :-) | 17:54 |
| rloo | thx bnemec | 17:57 |
| *** penick has joined #openstack-ironic | 18:04 | |
| * devananda is back | 18:10 | |
| bnemec | As expected, removing the pxe_ilo driver didn't help either: https://review.openstack.org/#/c/145846/ | 18:12 |
| bnemec | The oslo.utils fix is approved, so once that merges we can get it released and this should go away. | 18:12 |
| rloo | thx bnemec. that was fast! | 18:13 |
| rloo | bnemec: any way to test that it fixes it? | 18:14 |
| rloo | bnemec: 'easy' way, cuz of course we can wait til it is released. | 18:14 |
| *** EmilienM|afk is now known as EmilienM | 18:14 | |
| * Shrews has to run an errand. back in an hour or so | 18:18 | |
| NobodyCam | wb devananda | 18:19 |
| bnemec | rloo: Doesn't look like it. I don't think we're set up to run against arbitrary source versions of projects. | 18:22 |
| rloo | bnemec: ok. I'm still wondering how that could have caused things to break, esp in stevedore. | 18:23 |
| openstackgerrit | Merged openstack/ironic: Add documentation to create in RegionOne https://review.openstack.org/139842 | 18:23 |
| *** martini_ has joined #openstack-ironic | 18:24 | |
| bnemec | rloo: I think it's probably being triggered by this: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L60 | 18:25 |
| bnemec | netconf calls the oslo.utils function with the bug. | 18:26 |
| bnemec | Our CI environment must be set up in such a way as to trigger the bad code path. | 18:26 |
| rloo | bnemec: but i don't see how that agent code gets invoked by stevedore if you didn't configure for it. | 18:26 |
| *** yjiang5 has joined #openstack-ironic | 18:27 | |
| bnemec | rloo: I think stevedore is incidental. It looks like the ilo driver imports the agent module, which would call into the bad oslo.utils code: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L33 | 18:28 |
| bnemec | So when stevedore tries to load the driver, it triggers the error. | 18:28 |
| rloo | bnemec: hmmm. I'm going to see if I can reproduce the bug. | 18:29 |
| NobodyCam | brb | 18:34 |
| *** pelix has quit IRC | 18:37 | |
| *** ifarkas has quit IRC | 18:38 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/145884 | 18:43 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/145885 | 18:43 |
| NobodyCam | TheJulia: are you in channel? | 18:45 |
| *** dprince has quit IRC | 18:50 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Convert drivers to use process_event() https://review.openstack.org/140883 | 18:51 |
| NobodyCam | bnemec: is that you? ^^^^ ? | 18:52 |
| NobodyCam | (the requirments patch) | 18:52 |
| bnemec | NobodyCam: No, I don't think my fix has merged yet. | 18:53 |
| devananda | rloo: are you working on 142303? | 18:53 |
| NobodyCam | ack | 18:53 |
| TheJulia | NobodyCam: I am | 18:54 |
| NobodyCam | hi TheJulia | 18:54 |
| rloo | devananda: no | 18:54 |
| NobodyCam | I wanted to put you intouch with devananda about the ansible code base | 18:54 |
| NobodyCam | devananda: meet TheJulia ... TheJulia meet devananda | 18:54 |
| devananda | rloo: k. I'll take another look // rebase it and see what's left | 18:54 |
| NobodyCam | lol | 18:54 |
| rloo | devananda: wasn't going to update that until after i looked at your patch 145389. started, but in a meeting now. | 18:55 |
| TheJulia | lol | 18:55 |
| devananda | TheJulia: lol, hi there | 18:55 |
| TheJulia | NobodyCam: devananda and I have met... in person even! | 18:55 |
| TheJulia | yes, that whole in person meeting thing, so weird..... ;) | 18:55 |
| NobodyCam | devananda: I have been chatting with TheJulia about the ansible work you started on before the holidays | 18:55 |
| NobodyCam | yes I know you have meet in RL | 18:56 |
| NobodyCam | :-p | 18:56 |
| devananda | TheJulia: so a few months ago, I started working on an ansible module for ironic with two goals | 18:56 |
| BadCub_ | *ears perk up* | 18:56 |
| devananda | TheJulia: - make it easier to script inventory things (add, update, remove nodes) | 18:57 |
| devananda | TheJulia: - do small deploys w/o nova or neutron | 18:57 |
| TheJulia | Interesting... | 18:58 |
| devananda | that work is probably bit rotted by now, but it's here: https://github.com/emonty/shade-ansible/blob/master/shade_ansible/modules/os_baremetal.py and here https://github.com/emonty/shade/blob/master/shade/__init__.py#L636 | 18:58 |
| devananda | TheJulia: also, I didn't finish it. because reasons. | 19:00 |
| * TheJulia makes note since she has to step away for a few hours in a little bit | 19:00 | |
| TheJulia | devananda: stuff happens :) | 19:00 |
| * Shrews is back | 19:01 | |
| NobodyCam | wb Shrews | 19:01 |
| Shrews | actually, at the car shop, but same difference :) | 19:01 |
| NobodyCam | shopping for a new car | 19:02 |
| NobodyCam | lol | 19:02 |
| Shrews | hardly | 19:02 |
| devananda | TheJulia: it's at the point where I can define ironic nodes in a .yaml file and use ansible to add/update/remove and change power state | 19:04 |
| devananda | TheJulia: it does not yet: update JSON fields (like driver_info) very well. or do anything with provision state. | 19:04 |
| TheJulia | Looks like it is off to a good start :) | 19:11 |
| jroll | devananda: ansible, orly | 19:13 |
| jroll | JayF: this is relevant to our interests | 19:13 |
| jroll | (maybe) | 19:13 |
| JayF | You want to use ansible to drive Ironic without nova? | 19:13 |
| devananda | JayF: yah. for small non-cloudy things. like automating my house. | 19:14 |
| jroll | JayF: no, for like, adding nodes etc | 19:14 |
| JayF | devananda: that was more aimed at jroll :) I get why some folks would want to do it | 19:14 |
| *** alexpilotti has quit IRC | 19:14 | |
| devananda | also: I want to use ansible to automate inventory mgmt | 19:14 |
| JayF | jroll: why would we replace working, simple bootstrap scripts with ansible? | 19:14 |
| jroll | JayF: it's just a thought | 19:14 |
| NobodyCam | morning j* | 19:15 |
| devananda | dump inventory from CMDB into yaml, use ansible to sync it into ironic. or something. | 19:15 |
| jroll | morning NobodyCam :) | 19:15 |
| jroll | devananda: yeah, we do that today but s/yaml/json/ and s/ansible/janky python scripts/ | 19:15 |
| jroll | :P | 19:15 |
| devananda | heh | 19:15 |
| JayF | I wouldn't characterize them as janky | 19:15 |
| NobodyCam | on the new FSM are nodes lock when switching states? | 19:16 |
| NobodyCam | i'm missing some pice of the pie. | 19:17 |
| NobodyCam | looking at discoverd spec. how are nodes in managed state getting locked? | 19:17 |
| Shrews | NobodyCam: it should be locked when callling task.process_event(SOME_EVENT) | 19:18 |
| Shrews | which causes the transition | 19:18 |
| NobodyCam | ah ha... thats the pice I was missing | 19:19 |
| Shrews | though i wonder if we should guarantee that somehow | 19:19 |
| NobodyCam | in the discoverd spec dt is releasing conductor locks | 19:20 |
| Shrews | should we have task.process_event() raise an exception if self.shared == True??? | 19:22 |
| Shrews | to prevent nasty programming errors | 19:22 |
| Shrews | that might be overly cautious | 19:23 |
| devananda | IIRC, some things need to allow shared=True | 19:23 |
| devananda | like setting console state or validating things | 19:23 |
| rloo | NobodyCam: my understanding is that the discoverd will release the lock while in INSPECTING State, not managed state. | 19:23 |
| devananda | but I don't know offhand about the new states ... | 19:24 |
| *** chuckC__ has joined #openstack-ironic | 19:29 | |
| *** chuckC_ has quit IRC | 19:30 | |
| *** Masahiro has joined #openstack-ironic | 19:31 | |
| *** chuckC_ has joined #openstack-ironic | 19:33 | |
| NobodyCam | rloo: yes thats how I read the spec too | 19:33 |
| NobodyCam | but my concern is power polling locks the node | 19:34 |
| rloo | NobodyCam: I'm a bit concerned about releasing the lock and what that might mean, but I also didn't want to think through it all just yet | 19:34 |
| NobodyCam | how will that react if its lock is released mid check | 19:34 |
| *** chuckC__ has quit IRC | 19:34 | |
| rloo | NobodyCam: so when do we power a node? I suspect we wouldn't do it in inspect* state | 19:34 |
| NobodyCam | power check is a perodic task | 19:35 |
| rloo | NobodyCam: yeah, but we can check in that task, what state the node is in. | 19:35 |
| *** Masahiro has quit IRC | 19:35 | |
| rloo | NobodyCam: just looked. the power sync skips nodes in maint or DEPLOYWAIT or locked. I think we'll need to think about what other states we want to include. | 19:37 |
| *** chuckC_ has quit IRC | 19:38 | |
| NobodyCam | humm.. so add inspect[ed|ing] | 19:39 |
| *** chuckC_ has joined #openstack-ironic | 19:39 | |
| *** ChuckC has joined #openstack-ironic | 19:39 | |
| rloo | NobodyCam: maybe. I don't know yet. Just throwing it out there. I figured dmitry would figure it out ;) | 19:39 |
| NobodyCam | :) | 19:40 |
| rloo | NobodyCam: I'm not even sure it'll be easy for ironic-discoverd to issue commands to ironic while in inspect state. depends on the commands, and would a command cause the node state to change... am waiting to see what happens. | 19:41 |
| NobodyCam | I added a comment on the spec :) | 19:45 |
| NobodyCam | ok brb.... | 19:46 |
| *** Marga_ has quit IRC | 19:48 | |
| *** Marga_ has joined #openstack-ironic | 19:49 | |
| *** Marga_ has quit IRC | 19:53 | |
| NobodyCam | devananda: have you seen lucasagomes and Shrews commentes on 145389? | 19:58 |
| Shrews | devananda: if you agree to our comments on that, i'm happy to move that forward for you if you're swamped | 20:00 |
| NobodyCam | Shrews: reading it I think the comments are correct | 20:01 |
| Shrews | hrm, why isn't my public key getting installed on the devstack images? *grrrr* | 20:03 |
| Shrews | computers hate me lately | 20:03 |
| Shrews | s/lately/even more than usual/ | 20:04 |
| NobodyCam | lol | 20:05 |
| devananda | Shrews: commented on review. | 20:06 |
| devananda | you're both correct. but I'll update it, as I have another patch about to go up, too | 20:06 |
| Shrews | coolio | 20:07 |
| *** Nisha has quit IRC | 20:07 | |
| lucasagomes | alright folks, I will call it a day | 20:13 |
| lucasagomes | have a great night everyone! | 20:13 |
| lucasagomes | see y'all online soon :) | 20:13 |
| JayF | night lucas | 20:13 |
| rloo | night lucasagomes | 20:13 |
| *** lucasagomes is now known as lucas-dinner | 20:13 | |
| NobodyCam | night lucas-dinner | 20:14 |
| *** subscope_ has joined #openstack-ironic | 20:16 | |
| *** Marga_ has joined #openstack-ironic | 20:19 | |
| *** Marga_ has quit IRC | 20:24 | |
| *** subscope_ has quit IRC | 20:28 | |
| *** ijw has joined #openstack-ironic | 20:31 | |
| NobodyCam | gilliard: are you in channel? | 20:33 |
| *** harlowja_away is now known as harlowja | 20:37 | |
| devananda | rloo: ok - I think I've grokked all the changes in your DONOTMERGE patch | 20:40 |
| devananda | rloo: found another issue, thanks to that. which I'm almost done porting into 145389 | 20:41 |
| rloo | devananda: good. Glad it helped. Now to see if I can remember it all ;) | 20:41 |
| devananda | rloo: do you mind if I cannibalize your patch? a few bits will end up in 145389, and the rest I'll turn into another patch with all the new unit tests (co-author you) | 20:42 |
| rloo | devananda: go whatever works for you. | 20:42 |
| rloo | s/go/do/ | 20:42 |
| devananda | cheers | 20:42 |
| rloo | devananda: I'll wait to look at 145389 after your changes, but I did just add a comment wrt DEPLOYFAIL/ACTIVE. Want to make sure that we're ok changing the behavior from DEPLOYFAIL/NOSTATE to DEPLOYFAIL/ACTIVE. | 20:45 |
| devananda | rloo: I am. this is what the new state machine says we should have | 20:46 |
| *** pensu has joined #openstack-ironic | 20:47 | |
| rloo | devananda: good thing we have a spec:-) Ok, I'm satisfied with that answer. | 20:47 |
| rloo | but maybe mention in the commit. i'll add a comment. | 20:48 |
| *** pensu has quit IRC | 20:50 | |
| *** pensu has joined #openstack-ironic | 20:52 | |
| *** david-lyle has joined #openstack-ironic | 20:54 | |
| devananda | patch bomb inc | 20:54 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Convert drivers to use process_event() https://review.openstack.org/140883 | 20:54 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Enable async callbacks from task.process_event() https://review.openstack.org/140868 | 20:54 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Convert check_deploy_timeout to use process_event https://review.openstack.org/140869 | 20:54 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Minor changes to state model https://review.openstack.org/145389 | 20:54 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Improve testing of state transitions https://review.openstack.org/145929 | 20:54 |
| devananda | Shrews: the changes you requested should be in there ^ now | 20:54 |
| devananda | rloo: oh good. it kept you as the author of that last patch | 20:55 |
| rloo | devananda: :-) | 20:55 |
| devananda | rloo: it's your DONOTMERGE patch, with comments removed (since tests are now passing), but very few tests changed (only those necessary for the above discussion, which got rolled into 145389) | 20:56 |
| rloo | devananda: ok, i'll take a look at it after I look at your updated 145389. | 20:58 |
| * devananda steps afk for a while | 21:02 | |
| NobodyCam | :) | 21:02 |
| *** mrda-away is now known as mrda | 21:04 | |
| mrda | Morning Ironic! | 21:04 |
| NobodyCam | morning mrda | 21:04 |
| mrda | NobodyCam: \o | 21:05 |
| *** chuckC_ has quit IRC | 21:11 | |
| *** Marga_ has joined #openstack-ironic | 21:15 | |
| *** Marga_ has quit IRC | 21:17 | |
| *** Marga_ has joined #openstack-ironic | 21:17 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Remove python 2.6 from tox.ini https://review.openstack.org/145631 | 21:17 |
| *** Marga_ has quit IRC | 21:19 | |
| *** Masahiro has joined #openstack-ironic | 21:20 | |
| *** Marga_ has joined #openstack-ironic | 21:20 | |
| *** Marga_ has quit IRC | 21:20 | |
| *** Marga_ has joined #openstack-ironic | 21:21 | |
| *** Marga_ has quit IRC | 21:22 | |
| *** Marga_ has joined #openstack-ironic | 21:22 | |
| *** andreykurilin has joined #openstack-ironic | 21:23 | |
| *** Masahiro has quit IRC | 21:25 | |
| *** PaulCzar has joined #openstack-ironic | 21:25 | |
| NobodyCam | bnemec: any updates on that gate fix? | 21:27 |
| bnemec | NobodyCam: Yeah, the fix merged. I'm looking at doing the release now. | 21:28 |
| NobodyCam | sweet :) https://bugs.launchpad.net/bugs/1408701 still the bug #? | 21:30 |
| NobodyCam | updating our whiteboard | 21:30 |
| Shrews | rloo: i don't think the workaround in manager.py to set target state to None can be removed yet | 21:31 |
| Shrews | fwiw | 21:31 |
| rloo | Shrews: I just tried it and it looks like it worked w/o that workaround. | 21:31 |
| rloo | Shrews: maybe I'll try to make sure some how... | 21:32 |
| Shrews | rloo: ORLY? hrm | 21:32 |
| rloo | Shrews: by 'worked' I mean the unit tests passed. So... need to make sure it got exercised, although I thought it did. | 21:32 |
| NobodyCam | white board updated with current gate status | 21:33 |
| Shrews | rloo: oh. our tests may be inadequate then. i was going by this bit of code: https://github.com/openstack/ironic/blob/master/ironic/common/fsm.py#L148-L150 | 21:33 |
| Shrews | rloo: i may also be totally off my rocker :-P | 21:34 |
| Shrews | i walked through the code in my head, but IANAC :) | 21:34 |
| rloo | Shrews: yeah, that's also what is confusing me. I remember seeing that fsm code and recall thinking that's why there were issues. but then thought that wasn't a problem. hard to get back/remember ... | 21:35 |
| * Shrews makes a Bailey's tainted cup of afternoon coffee | 21:35 | |
| NobodyCam | ianac == I Am Not A Crook | 21:36 |
| NobodyCam | ??? | 21:36 |
| Shrews | lol | 21:36 |
| Shrews | Computer | 21:36 |
| NobodyCam | http://www.netlingo.com/word/ianac.php | 21:36 |
| Shrews | b/c i'm *definitely* a crook | 21:36 |
| JayF | Is there a place to see a pydoc for the actual signature of the Exception class? https://docs.python.org/2/library/exceptions.html#exceptions.Exception is not very enlightening | 21:37 |
| NobodyCam | oh thats a night time coffee for /me | 21:37 |
| JayF | (I'm in ironic_python_agent/errors.py line 26 -> trying to see what happens with those args and kwargs) | 21:37 |
| rloo | JayF: forgot to get back to that. I think what I did was created a variable with one of those RESTwhatever errors, and did serialize, and the detailed whatever didn't show up; just used the default one from RESTwhatever. | 21:38 |
| rloo | JayF: which makes sense, cuz it is looking for self.detailed not detailed or whatever it is called | 21:38 |
| JayF | Yeah; I saw a clear place where I was erroring | 21:39 |
| JayF | but now it's not sufficient to make it work | 21:39 |
| JayF | I gotta know why it works now, because I don't understand | 21:39 |
| NobodyCam | lol j* love the new raq space slogan ... "The people powered cloud" | 21:39 |
| JayF | We have a new slogan? | 21:39 |
| JayF | lol | 21:39 |
| * Shrews imagines hundreds of engineers on stationary bikes wired to the computer room | 21:40 | |
| NobodyCam | at least thats what i'm seeing on the google adds that follow one around the internets | 21:40 |
| NobodyCam | lol | 21:40 |
| JayF | They follow me around the internet to | 21:40 |
| JayF | nice to know we target the right folks, and not only Rackers :P | 21:40 |
| mrda | :) | 21:41 |
| NobodyCam | :) | 21:41 |
| NobodyCam | i get cloud ads and ads for performence car parts | 21:42 |
| NobodyCam | brb | 21:43 |
| *** ryanpetrello has quit IRC | 21:53 | |
| rloo | Shrews: ok, so None is so magical. when process_even('done') is called, self._target_state is already None/NOSTATE, so it stays None (cuz as you pointed out it doesn't get changed), which is what we want. | 21:55 |
| *** penick has quit IRC | 21:56 | |
| Shrews | rloo: awesome-sauce | 21:56 |
| * NobodyCam hands Shrews his "discover" card | 21:56 | |
| rloo | Shrews: I didn't think of it that way, but umm, yeah... | 21:56 |
| *** dprince has joined #openstack-ironic | 21:57 | |
| JayF | rloo: been looking and talking about this, and the tl;dr is that the use of things in error.py is really inconsistent, and confused me. I'm going to use it correctly in my patch and make a low-hanging-fruit bug to cleanup how errors are handled in IPA | 21:57 |
| *** ijw has quit IRC | 21:57 | |
| JayF | rloo: thanks for being persistent on this too, I appreciate it because I genuinely misunderstood what was going on | 21:58 |
| rloo | JayF: yup, I think that's a good approach. | 21:58 |
| *** ijw has joined #openstack-ironic | 21:58 | |
| rloo | JayF: so I wasn't sure if someone wanted to add code to set self.detail higher up, if detail was passed as a parameter. which is partially why i didn't want to touch that file. | 21:58 |
| *** penick has joined #openstack-ironic | 21:59 | |
| rloo | JayF: also, while you're at it, I noticed that for some of the error classes, they were making super() calls, but skipping their class. eg, look at class LookupAgentIPError | 22:01 |
| JayF | heh, wow | 22:01 |
| rloo | JayF: it is super(IronicAPIError...), not super(LookupAgentIPError...). | 22:01 |
| JayF | Do you wanna write that bug about errors.py and include that? | 22:02 |
| JayF | if not I will once I finish fixing the code I added | 22:02 |
| rloo | JayF: ok, i'lll write a bug about the latter one. You can write a bug about the one you're working on. | 22:02 |
| JayF | well it's the same bug | 22:02 |
| JayF | the file is just inconsistent and apparently in some places wrong | 22:03 |
| rloo | they're two different bugs, but in the same file. | 22:03 |
| rloo | ah. ok, in that case, they're the same bug :-) | 22:03 |
| rloo | JayF: I'm not going to look to see if there other issues. I might do them as two bugs, two nice juicy low-hanging-rotting bugs. | 22:03 |
| NobodyCam | rloo: be careful with that rotting fruit: https://www.youtube.com/watch?v=e12y8alpApg | 22:07 |
| rloo | NobodyCam: isn't that why it's called IPA? | 22:08 |
| NobodyCam | lol | 22:08 |
| JayF | man, everyone really is starting to hop on the pun bandwagon | 22:10 |
| NobodyCam | Ironic that | 22:10 |
| * NobodyCam ducks | 22:11 | |
| jroll | lol | 22:12 |
| *** EmilienM is now known as EmilienM|afk | 22:17 | |
| mrda | Noticed that Intel released a new set of NUCs, unfortunately still no IPMI (otherwise they'd make a great Ironic test network) | 22:23 |
| *** Marga_ has quit IRC | 22:23 | |
| NobodyCam | mrda: thats what the ATM power driver :) | 22:23 |
| NobodyCam | is for | 22:24 |
| mrda | :) | 22:24 |
| *** Marga_ has joined #openstack-ironic | 22:24 | |
| *** Marga_ has quit IRC | 22:24 | |
| * mrda knows nothing of ATM | 22:24 | |
| jroll | AMT | 22:24 |
| *** Marga_ has joined #openstack-ironic | 22:25 | |
| NobodyCam | doh | 22:25 |
| * mrda googles | 22:25 | |
| *** Marga_ has quit IRC | 22:25 | |
| NobodyCam | https://review.openstack.org/#/c/141269/6/specs/kilo/amt-pxe-driver.rst | 22:25 |
| jroll | mrda: it's a less featureful version of ipmi for consumer-grade machines afaict | 22:26 |
| mrda | cool, sounds interesting... | 22:26 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Allow use of multiple simultaneous HW managers https://review.openstack.org/143193 | 22:27 |
| *** Marga_ has joined #openstack-ironic | 22:27 | |
| *** david-lyle has quit IRC | 22:28 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Allow use of multiple simultaneous HW managers https://review.openstack.org/143193 | 22:28 |
| JayF | fixed all of rloo's concerns with the exceptions I added ^ | 22:30 |
| JayF | NobodyCam: ^ would be awesome if you made sure this still passed muster and put your +2 back on it | 22:30 |
| NobodyCam | JayF: will put it next on the list of things to lok at | 22:30 |
| NobodyCam | any care if I start to crack down on the "this should be documented" spec comments.. like asking what doc files will be updated? | 22:36 |
| JayF | I think that's a little overkill | 22:36 |
| JayF | if you want to crack down | 22:36 |
| JayF | don't let the patch in until the accompanying docs are up | 22:36 |
| NobodyCam | I just have this fear that we going to start to lose track of the things that need documenting | 22:37 |
| *** Marga_ has quit IRC | 22:37 | |
| *** Marga__ has joined #openstack-ironic | 22:37 | |
| *** Marga__ has quit IRC | 22:37 | |
| NobodyCam | I'm good with enfourcing on the patch side | 22:37 |
| JayF | Just when you're reviewing a thing that implements a blueprint; enforce that they obey or update the spec | 22:37 |
| *** Marga_ has joined #openstack-ironic | 22:37 | |
| JayF | I just think asking people what they're going to document before the implementation is done is a bit difficult | 22:37 |
| NobodyCam | oh not what just where are you going to add the docs | 22:38 |
| NobodyCam | like uodate instal-guide | 22:38 |
| NobodyCam | or driver page | 22:38 |
| NobodyCam | not the actual content of the update | 22:39 |
| NobodyCam | side note: neat -> http://www.mnn.com/earth-matters/space/photos/10-nasa-images-of-planets-like-earth/a-new-earth | 22:48 |
| *** Marga_ has quit IRC | 22:48 | |
| *** Marga_ has joined #openstack-ironic | 22:49 | |
| *** Marga_ has quit IRC | 22:49 | |
| NobodyCam | JayF: just starting on 143193 my first question reading the commit message is "what is IT" | 22:50 |
| NobodyCam | lol | 22:50 |
| JayF | NobodyCam: s/it/the call/ ? | 22:50 |
| JayF | NobodyCam: I can fix it if you think that's clearer, still have the branch up so it's nbd | 22:50 |
| *** Marga_ has joined #openstack-ironic | 22:51 | |
| *** penick has quit IRC | 22:51 | |
| NobodyCam | JayF: ... and consider it successful if it exists and doesn't throw ... | 22:51 |
| *** Marga_ has quit IRC | 22:51 | |
| JayF | and consider it successful if the method exists and doesn't throw | 22:52 |
| NobodyCam | ++ | 22:52 |
| *** Marga_ has joined #openstack-ironic | 22:52 | |
| *** penick has joined #openstack-ironic | 22:52 | |
| NobodyCam | but wait let me look the rest of it over | 22:52 |
| JayF | YOLO | 22:52 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Allow use of multiple simultaneous HW managers https://review.openstack.org/143193 | 22:52 |
| JayF | :P | 22:52 |
| NobodyCam | lol | 22:52 |
| NobodyCam | TY JayF :p | 22:52 |
| NobodyCam | hehehehe | 22:53 |
| *** Marga__ has joined #openstack-ironic | 22:54 | |
| *** Marga__ has quit IRC | 22:54 | |
| *** Marga_ has quit IRC | 22:54 | |
| *** martini_ has quit IRC | 22:55 | |
| *** dprince has quit IRC | 22:55 | |
| *** Marga_ has joined #openstack-ironic | 22:55 | |
| *** Marga_ has quit IRC | 22:55 | |
| *** Marga_ has joined #openstack-ironic | 22:56 | |
| *** Marga_ has quit IRC | 22:57 | |
| *** Marga_ has joined #openstack-ironic | 22:57 | |
| *** ijw has quit IRC | 22:58 | |
| *** arif-ali has quit IRC | 22:58 | |
| *** ijw has joined #openstack-ironic | 22:59 | |
| *** pensu has quit IRC | 23:01 | |
| *** Marga_ has quit IRC | 23:02 | |
| *** Marga_ has joined #openstack-ironic | 23:03 | |
| NobodyCam | JayF: only a +1 this review | 23:04 |
| *** Marga_ has quit IRC | 23:05 | |
| NobodyCam | :-p | 23:05 |
| NobodyCam | just a couple of logging comments | 23:05 |
| *** Marga_ has joined #openstack-ironic | 23:05 | |
| NobodyCam | I know one sees the ipa logs | 23:05 |
| *** Marga__ has joined #openstack-ironic | 23:06 | |
| *** Marga__ has quit IRC | 23:06 | |
| NobodyCam | JayF: the code still LGTM | 23:07 |
| JayF | NobodyCam: responded, one you're right, one you're not, but it's good that you asked so I can clarify how it's supposed to work | 23:07 |
| *** Marga__ has joined #openstack-ironic | 23:07 | |
| JayF | NobodyCam: wanna look at the comments and see if you want me to put more comments on that method to make it clearer? | 23:08 |
| NobodyCam | looking | 23:08 |
| *** Masahiro has joined #openstack-ironic | 23:09 | |
| *** Marga_ has quit IRC | 23:10 | |
| NobodyCam | no I think the method is good. I was not thinking about a manager with only one function in it.... that makes sense now that you point it out | 23:11 |
| JayF | Yeah; the entire reason I started refactoring this | 23:12 |
| JayF | is because I want to break up the hardware manager we use into smaller pieces that others could consume | 23:12 |
| JayF | tl;dr: you might see a WarpDriveIOCardHardwareManager() soon :) | 23:12 |
| *** Masahiro has quit IRC | 23:13 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Allow use of multiple simultaneous HW managers https://review.openstack.org/143193 | 23:15 |
| JayF | NobodyCam: ^ that one log message is error now, as per your comment | 23:15 |
| NobodyCam | JayF: reviewed :) | 23:22 |
| JayF | ty | 23:22 |
| NobodyCam | :) | 23:22 |
| NobodyCam | thank you | 23:22 |
| *** ijw_ has joined #openstack-ironic | 23:28 | |
| *** ijw has quit IRC | 23:31 | |
| *** penick has quit IRC | 23:37 | |
| *** krtaylor has quit IRC | 23:39 | |
| *** ijw_ has quit IRC | 23:40 | |
| *** ijw has joined #openstack-ironic | 23:41 | |
| openstackgerrit | Adam Gandelman proposed openstack/ironic: Fix policy enforcement to properly detect admin https://review.openstack.org/145973 | 23:46 |
| openstackgerrit | Adam Gandelman proposed openstack/ironic: Fix policy enforcement to properly detect admin https://review.openstack.org/145973 | 23:46 |
| adam_g | jroll, ^ looks like you spotted that in review but it slipped through: https://review.openstack.org/#/c/126265/1..3/ironic/api/hooks.py | 23:47 |
| jroll | adam_g: people don't listen to me :( | 23:50 |
| *** mjturek has quit IRC | 23:50 | |
| *** krtaylor has joined #openstack-ironic | 23:52 | |
| *** arif-ali has joined #openstack-ironic | 23:53 | |
| *** smoriya has joined #openstack-ironic | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!