| *** naohirot has joined #openstack-ironic | 00:05 | |
| *** dkingshott has quit IRC | 00:05 | |
| openstackgerrit | wei du proposed openstack/ironic: Fix argument value for work_on_disk() in unit test https://review.openstack.org/153072 | 00:05 |
|---|---|---|
| naohirot | good morning ironic | 00:06 |
| *** yuanying_ has joined #openstack-ironic | 00:08 | |
| mrda | hi naohirot | 00:08 |
| naohirot | hi mrda :) | 00:08 |
| *** yuanying has quit IRC | 00:10 | |
| NobodyCam | morning naohirot | 00:10 |
| NobodyCam | morning mrda (if I missed you earlier) | 00:11 |
| NobodyCam | :p | 00:11 |
| naohirot | NobodyCam: good evening :) | 00:11 |
| mrda | hey NobodyCam | 00:13 |
| openstackgerrit | Merged openstack/ironic: Documentation: Describe the 'spacing' argument https://review.openstack.org/153056 | 00:14 |
| openstackgerrit | Merged openstack/ironic: update docstring for driver_periodic_task's parallel param https://review.openstack.org/152956 | 00:14 |
| NobodyCam | :) | 00:16 |
| *** Marga_ has quit IRC | 00:22 | |
| *** Marga_ has joined #openstack-ironic | 00:23 | |
| *** Marga_ has quit IRC | 00:27 | |
| *** achanda has quit IRC | 00:37 | |
| *** achanda has joined #openstack-ironic | 00:43 | |
| *** ChuckC_ has joined #openstack-ironic | 00:44 | |
| *** ChuckC has quit IRC | 00:45 | |
| *** korekhov has quit IRC | 00:46 | |
| *** korekhov_ has joined #openstack-ironic | 00:46 | |
| *** korekhov_ has quit IRC | 00:50 | |
| *** BadCub_ has quit IRC | 00:51 | |
| *** Marga_ has joined #openstack-ironic | 00:52 | |
| *** Marga_ has quit IRC | 00:52 | |
| *** Marga_ has joined #openstack-ironic | 00:53 | |
| *** achanda has quit IRC | 00:53 | |
| *** lynxman has quit IRC | 00:54 | |
| *** lynxman has joined #openstack-ironic | 00:55 | |
| *** yuanying_ has quit IRC | 01:03 | |
| *** penick has quit IRC | 01:03 | |
| *** chlong has joined #openstack-ironic | 01:05 | |
| *** yuanying has joined #openstack-ironic | 01:09 | |
| *** bradjones has quit IRC | 01:17 | |
| *** david-lyle is now known as david-lyle_afk | 01:18 | |
| *** andreykurilin_ has quit IRC | 01:19 | |
| *** bradjones has joined #openstack-ironic | 01:19 | |
| *** chlong has quit IRC | 01:22 | |
| *** ChuckC has joined #openstack-ironic | 01:23 | |
| *** ChuckC_ has quit IRC | 01:26 | |
| *** chenglch has joined #openstack-ironic | 01:33 | |
| *** rwsu is now known as rwsu-afk | 01:43 | |
| openstackgerrit | Kyle Stevenson proposed openstack/ironic-python-agent: Correct inline comment in sync_command decorator https://review.openstack.org/153104 | 01:45 |
| kylestev | one-liner ^ | 01:47 |
| *** imtiaz_ has quit IRC | 01:48 | |
| *** ijw_ has quit IRC | 01:52 | |
| *** achanda has joined #openstack-ironic | 01:53 | |
| *** EmilienM is now known as EmilienM|afk | 01:55 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add list of python driver packages https://review.openstack.org/153109 | 01:57 |
| openstackgerrit | Tan Lin proposed openstack/ironic: Correct typo in agent_client https://review.openstack.org/153110 | 01:58 |
| *** achanda has quit IRC | 01:59 | |
| *** ijw has joined #openstack-ironic | 02:04 | |
| *** rloo has quit IRC | 02:09 | |
| openstackgerrit | Tan Lin proposed openstack/ironic: Add AMT-PXE driver doc https://review.openstack.org/152859 | 02:12 |
| openstackgerrit | Kyle Stevenson proposed openstack/ironic-python-agent: Add additional logging and return results for IPA extensions https://review.openstack.org/152755 | 02:18 |
| openstackgerrit | Michael Davies proposed openstack/ironic-specs: Update logical-name spec for uuid/name clash https://review.openstack.org/153115 | 02:19 |
| *** yog_ has quit IRC | 02:24 | |
| *** chlong has joined #openstack-ironic | 02:26 | |
| *** spandhe has quit IRC | 02:27 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Raise minimum API version to 1.1 https://review.openstack.org/152527 | 02:30 |
| *** penick has joined #openstack-ironic | 02:31 | |
| *** penick_ has joined #openstack-ironic | 02:32 | |
| *** penick has quit IRC | 02:36 | |
| *** penick_ is now known as penick | 02:36 | |
| *** ijw_ has joined #openstack-ironic | 02:37 | |
| *** ijw has quit IRC | 02:40 | |
| *** chlong has quit IRC | 02:40 | |
| *** chenleji has joined #openstack-ironic | 02:44 | |
| *** korekhov_ has joined #openstack-ironic | 02:47 | |
| *** yuanying_ has joined #openstack-ironic | 02:47 | |
| *** ramineni has joined #openstack-ironic | 02:49 | |
| *** yuanying has quit IRC | 02:50 | |
| *** achanda has joined #openstack-ironic | 02:51 | |
| *** korekhov_ has quit IRC | 02:52 | |
| *** stendulker has quit IRC | 02:56 | |
| *** zhenzanz has joined #openstack-ironic | 02:56 | |
| *** korekhov_ has joined #openstack-ironic | 02:59 | |
| *** eghobo has quit IRC | 03:02 | |
| *** korekhov_ has quit IRC | 03:04 | |
| *** yog_ has joined #openstack-ironic | 03:04 | |
| *** ijw has joined #openstack-ironic | 03:06 | |
| openstackgerrit | Zhenzan Zhou proposed openstack/ironic: Add policy show_password to mask passwords in driver_info https://review.openstack.org/150688 | 03:08 |
| *** ijw_ has quit IRC | 03:08 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Correct inline comment in sync_command decorator https://review.openstack.org/153104 | 03:09 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add MANAGEABLE state and associated transitions https://review.openstack.org/150073 | 03:13 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Conductor errors if enabled_drivers are not found https://review.openstack.org/152844 | 03:19 |
| jroll | morning devananda :P | 03:21 |
| *** korekhov_ has joined #openstack-ironic | 03:21 | |
| devananda | jroll: shh. i should be sleeping :p | 03:22 |
| devananda | i mean, it's 4am, or something | 03:22 |
| jroll | heh | 03:22 |
| devananda | that's the time one is supposed to sleep, right? | 03:22 |
| mrda | The problem is that gerrit doesn't lie :) | 03:22 |
| jroll | idk | 03:22 |
| jroll | seems almost reasonable to be awake | 03:22 |
| *** korekho__ has joined #openstack-ironic | 03:22 | |
| devananda | jroll: since you're here, on the password mask | 03:23 |
| devananda | jroll: that's a policy change now, not an api change | 03:23 |
| devananda | jroll: i'm thinking that that is not something we bump versions for | 03:23 |
| jroll | devananda: but the api response changes | 03:23 |
| jroll | idk | 03:23 |
| devananda | otherwise, we should bump the version for every policy ... | 03:24 |
| jroll | I can deal with changing it or not changing it | 03:24 |
| devananda | no, the content in the body is masked | 03:24 |
| devananda | a deployer can totally override that policy locally | 03:24 |
| devananda | so then what does the microversion mean? | 03:24 |
| jroll | yeah, I suppose that's true | 03:24 |
| devananda | different users get different behavior from teh same version -- therefor it's not a version difference :) | 03:24 |
| jroll | right, I guess ignore me | 03:25 |
| *** korekhov_ has quit IRC | 03:26 | |
| mrda | devananda: just to verify, we want your microversion patch (152527) to land before any more changes? Then all the other backlog, such as logical names, can try and merge? (assuming they are ready for merge :) | 03:27 |
| devananda | mrda: yes pls | 03:27 |
| mrda | if so, we should be nagging cores to get eyeballs on 152527 | 03:27 |
| mrda | ? | 03:28 |
| devananda | I just fixed the last round of comments | 03:28 |
| devananda | ALSO | 03:28 |
| devananda | kilo-2 is going to be tagged in approximately 12 hours | 03:28 |
| mrda | O_o | 03:28 |
| devananda | it's just a milestone, but it'd be great to have a bunch of the BP's closed | 03:28 |
| mrda | I got a great candidate for that! | 03:28 |
| mrda | :P | 03:28 |
| devananda | mrda: it looks like logical names is just about done :) | 03:28 |
| devananda | yep! | 03:28 |
| mrda | Well, I got a +2 from rloo, so it _must_ be close :) | 03:29 |
| devananda | :) | 03:30 |
| *** chlong has joined #openstack-ironic | 03:30 | |
| devananda | we should also land 153109 asap | 03:30 |
| devananda | it's trivial and i'm almost tempted to self-approve ... | 03:30 |
| * mrda looks | 03:30 | |
| devananda | it is a list of things that zigo needs to know | 03:31 |
| devananda | for building debian packages fo rus | 03:31 |
| jroll | devananda: lemme look at that | 03:33 |
| jroll | devananda: these are pypi packages | 03:34 |
| jroll | ? | 03:34 |
| mrda | jroll: I don't think all of them are | 03:34 |
| jroll | or what | 03:34 |
| jroll | yeah, they aren't, that's why I ask :) | 03:34 |
| devananda | they are python project names and SHOULD be pypi packages | 03:34 |
| devananda | oh | 03:35 |
| jroll | well, pip search $dep doesn't have results for some of them | 03:35 |
| devananda | in my sleepiness i might have used the wrong names | 03:35 |
| * devananda fixes | 03:35 | |
| mrda | iboot, pywsman, scsiclient aren't | 03:35 |
| jroll | MINUS TWO | 03:35 |
| jroll | also seamicroclient | 03:35 |
| mrda | hey hey hey, back off jroll. I found the discepency first :-P | 03:36 |
| mrda | s/seamicroclient/python-seamicroclient/ | 03:36 |
| jroll | idk about that, I was running things when you mentioned it | 03:36 |
| jroll | $ for thing in $(cat driver-requirements.txt| grep -v '^$' | grep -v '^#'); do pip search $thing; done | 03:36 |
| mrda | So was I :P | 03:36 |
| *** killer_prince is now known as lazy_prince | 03:37 | |
| *** chlong has quit IRC | 03:37 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add policy show_password to mask passwords in driver_info https://review.openstack.org/150688 | 03:39 |
| devananda | jroll: ^ is good now | 03:39 |
| jroll | cool | 03:40 |
| jroll | devananda: if show_password policy default is false, should it be true in all these kwargs? | 03:44 |
| jroll | it's probably fine | 03:45 |
| jroll | devananda: +2'd | 03:46 |
| devananda | oh. meh. | 03:47 |
| jroll | yeah | 03:47 |
| jroll | I'll let you +A when jenkins is done | 03:47 |
| *** ijw has quit IRC | 03:47 | |
| devananda | also, i think the dell driver is broken. except i know folks are wokring on it ... | 03:47 |
| devananda | pip search wsman -- and there it is | 03:47 |
| *** ijw has joined #openstack-ironic | 03:48 | |
| devananda | it's not called pywsman though | 03:48 |
| devananda | and it doesn't create a pywsman module (which would be awkward since it's not called that) | 03:48 |
| devananda | but all the drac driver code imports pywsman | 03:48 |
| devananda | :-/ | 03:48 |
| devananda | dtantsur|afk: ^ | 03:48 |
| jroll | uhh | 03:48 |
| jroll | that's interesting | 03:48 |
| jroll | I love when code is put in that people don't run :P | 03:49 |
| devananda | so do i ... | 03:49 |
| mrda | not confusing at all :S | 03:49 |
| jroll | >>> import pywsman | 03:50 |
| jroll | ImportError: No module named pywsman | 03:50 |
| jroll | yay. | 03:50 |
| jroll | how does that even happen | 03:50 |
| jroll | devananda: was 152527 the other one you needed reviewed? | 03:51 |
| jroll | I'll get that in a few, brb | 03:51 |
| devananda | this is lame: https://github.com/Openwsman/openwsman/blob/master/bindings/python/Makefile.am#L29 | 03:52 |
| devananda | the RPM is called openwsman-python | 03:52 |
| devananda | it installs a module called pywsman | 03:52 |
| * devananda is sad for the world | 03:52 | |
| mrda | le sigh | 03:53 |
| mrda | and ubuntu: http://packages.ubuntu.com/trusty-updates/i386/python-openwsman/filelist | 03:55 |
| *** harlowja is now known as harlowja_away | 03:56 | |
| *** jerryz has joined #openstack-ironic | 03:57 | |
| openstackgerrit | Merged openstack/ironic: Move oslo.config references to oslo_config https://review.openstack.org/151957 | 04:00 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add list of python driver packages https://review.openstack.org/153109 | 04:01 |
| *** absubram has joined #openstack-ironic | 04:06 | |
| jroll | mrda: devananda: that's just... wow | 04:06 |
| *** absubram has quit IRC | 04:06 | |
| jroll | +2'd 152527 btw | 04:06 |
| devananda | oh .. .wow | 04:08 |
| devananda | actually i think that's normal | 04:08 |
| devananda | been a whiel since I used RHEL, but I recall the package names being like that | 04:09 |
| jroll | the names are whatever | 04:09 |
| jroll | just python packages not on pypi makes me sad | 04:09 |
| mrda | It's not hard to get them added | 04:09 |
| mrda | One of my colleagues manages packaging.python.org | 04:10 |
| devananda | think i'm done fixing things for now | 04:10 |
| * devananda signs off for the morning, tries to get a little mroe sleep | 04:10 | |
| jroll | mrda: you mean one of my colleagues >:P | 04:11 |
| jroll | mrda: you mean an aussie or a racker in general? | 04:11 |
| mrda | umm no, jroll :) | 04:11 |
| mrda | An oz-zee | 04:11 |
| jroll | orly | 04:11 |
| jroll | who's that? | 04:11 |
| mrda | Richard Jones | 04:12 |
| jroll | there's also dstufft, who's in PA and I did rookie-o with him :P | 04:12 |
| mrda | huh | 04:12 |
| mrda | We haz all the python packaging people | 04:12 |
| jroll | aha | 04:12 |
| mrda | but, you can tell people how to package, but you can't make them do it | 04:12 |
| jroll | who wrote this iboot stuff? | 04:13 |
| jroll | dprince? | 04:13 |
| jroll | I see https://github.com/dprince/python-iboot_specs/blob/master/python-iboot.spec | 04:14 |
| *** lazy_prince is now known as killer_prince | 04:15 | |
| *** anderbubble has joined #openstack-ironic | 04:19 | |
| *** penick has quit IRC | 04:25 | |
| openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/152713 | 04:32 |
| *** rameshg87 has joined #openstack-ironic | 04:35 | |
| *** chlong has joined #openstack-ironic | 04:35 | |
| *** yog_ has quit IRC | 04:36 | |
| *** Nisha has joined #openstack-ironic | 04:38 | |
| *** killer_prince is now known as lazy_prince | 04:43 | |
| mrda | Should the drac driver try to load the wsman driver if pywsman doesn't exist? | 04:51 |
| mrda | i.e. if someone is built the wsman package from source rather than the distro version? | 04:52 |
| *** yog_ has joined #openstack-ironic | 04:52 | |
| *** achanda has quit IRC | 04:52 | |
| *** chlong has quit IRC | 04:54 | |
| *** achanda has joined #openstack-ironic | 05:01 | |
| *** chlong has joined #openstack-ironic | 05:03 | |
| *** eghobo has joined #openstack-ironic | 05:04 | |
| *** korekhov_ has joined #openstack-ironic | 05:07 | |
| *** korekho__ has quit IRC | 05:10 | |
| *** korekhov_ has quit IRC | 05:11 | |
| *** jerryz has quit IRC | 05:26 | |
| *** jlvillal_wfh has joined #openstack-ironic | 05:34 | |
| *** dguerri has quit IRC | 05:44 | |
| *** dguerri has joined #openstack-ironic | 05:45 | |
| *** yog_ has quit IRC | 05:48 | |
| *** coolsvap_ is now known as coolsvap | 05:49 | |
| *** Marga_ has quit IRC | 05:54 | |
| *** achanda has quit IRC | 06:00 | |
| openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 06:00 |
| *** jlvillal_wfh has quit IRC | 06:01 | |
| *** jerryz has joined #openstack-ironic | 06:10 | |
| *** imtiaz has joined #openstack-ironic | 06:12 | |
| *** ijw has quit IRC | 06:13 | |
| *** ijw has joined #openstack-ironic | 06:13 | |
| *** ijw has quit IRC | 06:17 | |
| *** ijw has joined #openstack-ironic | 06:17 | |
| *** achanda has joined #openstack-ironic | 06:24 | |
| *** achanda has quit IRC | 06:41 | |
| *** yog_ has joined #openstack-ironic | 06:43 | |
| *** Nisha has quit IRC | 06:44 | |
| *** imtiaz has quit IRC | 06:46 | |
| *** korekhov_ has joined #openstack-ironic | 06:52 | |
| *** ijw has quit IRC | 06:57 | |
| *** Nisha has joined #openstack-ironic | 07:00 | |
| *** korekhov_ has quit IRC | 07:09 | |
| *** korekhov_ has joined #openstack-ironic | 07:10 | |
| *** korekhov_ has quit IRC | 07:14 | |
| *** jmanko has joined #openstack-ironic | 07:17 | |
| *** dlpartain has joined #openstack-ironic | 07:18 | |
| *** dlpartain has left #openstack-ironic | 07:18 | |
| *** jmank has quit IRC | 07:20 | |
| *** harlowja_away has quit IRC | 07:23 | |
| *** anderbubble has quit IRC | 07:26 | |
| *** subscope has quit IRC | 07:29 | |
| *** jcoufal has joined #openstack-ironic | 07:38 | |
| *** chlong has quit IRC | 07:39 | |
| *** achanda has joined #openstack-ironic | 07:41 | |
| *** subscope has joined #openstack-ironic | 07:44 | |
| *** achanda has quit IRC | 07:47 | |
| openstackgerrit | jiangfei proposed openstack/python-ironicclient: Encode exception on cli for UnicodeDecodeError https://review.openstack.org/153155 | 07:53 |
| *** achanda has joined #openstack-ironic | 07:54 | |
| *** erwan_taf has joined #openstack-ironic | 07:56 | |
| *** eghobo has quit IRC | 08:03 | |
| *** lsmola has quit IRC | 08:05 | |
| *** ifarkas has joined #openstack-ironic | 08:06 | |
| *** chenleji has quit IRC | 08:15 | |
| *** lsmola has joined #openstack-ironic | 08:22 | |
| *** ndipanov has quit IRC | 08:28 | |
| *** subscope has quit IRC | 08:29 | |
| *** mgoddard has joined #openstack-ironic | 08:29 | |
| *** achanda has quit IRC | 08:29 | |
| devananda | morning, all | 08:31 |
| *** mgoddard1 has joined #openstack-ironic | 08:34 | |
| *** mgoddard has quit IRC | 08:34 | |
| *** achanda has joined #openstack-ironic | 08:34 | |
| *** lsmola has quit IRC | 08:36 | |
| *** lsmola has joined #openstack-ironic | 08:38 | |
| Nisha | devananda, morning | 08:40 |
| Nisha | devananda, needed help on https://review.openstack.org/149823 | 08:41 |
| Nisha | devananda, i am getting following error while testing ""Endpoint does not support RPC method inspect_hardware"." Could you help what is missing? | 08:42 |
| *** subscope has joined #openstack-ironic | 08:45 | |
| openstackgerrit | Devananda van der Veen proposed openstack/python-ironicclient: Update requirements.txt https://review.openstack.org/153163 | 08:45 |
| mgoddard1 | nisha: You use version 1.22 in rpcapi.py, should this be 1.24 to use the inspect_hardware method? I don't know how the RPC code works internally but this is jumping out at me. | 08:47 |
| *** yog_ has quit IRC | 08:47 | |
| Nisha | mgoddard1, i had actually made it as 1.24 then also it was giving same error | 08:48 |
| mgoddard1 | nisha: ok | 08:48 |
| Nisha | mgoddard1, while committing i guess i forgot to add the change. | 08:49 |
| mgoddard1 | nisha: Have you fixed the issue with the method being outside the class due to the merge error? | 08:50 |
| mgoddard1 | nisha: i.e. move inspect_hardware() above get_vendor_passthru_metadata() | 08:51 |
| Nisha | mgoddard1, i didnt get | 08:51 |
| Nisha | which file? | 08:53 |
| *** achanda has quit IRC | 08:53 | |
| mgoddard1 | nisha: Several of the ConductorManager methods were moved outside the class in a change that you rebased onto. Your method is below those global functions, making it also a global function rather than a method on ConductorManager | 08:54 |
| mgoddard1 | nisha: in ironic/conductor/manager.py | 08:54 |
| mgoddard1 | nisha: I'll try to find the change that introduced this | 08:54 |
| Nisha | okk. i think it may be the cause. i will just try in test branch and check | 08:54 |
| *** achanda has joined #openstack-ironic | 08:55 | |
| mgoddard1 | nisha: https://github.com/openstack/ironic/commit/13aee6165a21751105aa87dc6e6aecb4cb89b0e6 | 08:55 |
| Nisha | mgoddard1, thanks. will update after testing....i didnt realize it has become global function | 08:57 |
| *** mrda is now known as mrda-away | 08:57 | |
| *** zhenzanz has quit IRC | 09:03 | |
| *** yog_ has joined #openstack-ironic | 09:04 | |
| devananda | Nisha: RPC version on ir-api and ir-cond processes | 09:05 |
| devananda | Nisha: when you implement a new RPC method, you must raise the version. that allows the api and conductor to negotiate -- and when they are different versions, taht error is the result | 09:06 |
| *** jistr has joined #openstack-ironic | 09:07 | |
| ifarkas | rameshg87, hi | 09:09 |
| rameshg87 | ifarkas, hi | 09:09 |
| ifarkas | rameshg87, I just read the discussion from yesterday | 09:09 |
| jiangfei | devananda: hi devananda | 09:09 |
| rameshg87 | ifarkas, yesterday i was looking out for you when i was discussing about raid with rackspace folks | 09:09 |
| *** achanda has quit IRC | 09:09 | |
| ifarkas | rameshg87, I disagree with moving dumping the methods to management interface but I will reply on the spec | 09:09 |
| devananda | jiangfei: hi! we were just discussing your client patches | 09:10 |
| rameshg87 | ifarkas, yeah may be if there is a disagreement we can sort it out on next meeting | 09:10 |
| ifarkas | rameshg87, yeah | 09:11 |
| jiangfei | devananda: thank you for review https://review.openstack.org/151864. i have some question, In my opinion get / v1 / node is the corresponding node-list, get / v1 / node / uuid is the corresponding node-show, although the get-node-by-instance is returned node, he should also be a node-list. | 09:11 |
| *** achanda has joined #openstack-ironic | 09:11 | |
| rameshg87 | ifarkas, another comment was to have only 2 methods in total | 09:12 |
| rameshg87 | ifarkas, one for apply and one for delete | 09:12 |
| *** lucasagomes has joined #openstack-ironic | 09:13 | |
| rameshg87 | ifarkas, both of them can be made as separate zap tasks | 09:13 |
| ifarkas | rameshg87, and create | 09:13 |
| ifarkas | rameshg87, and update | 09:13 |
| rameshg87 | ifarkas, so how many zap tasks ? | 09:14 |
| ifarkas | rameshg87, ahh, as for zapping, we have basically 1: apply which is called twice: one for root device and then for the rest | 09:15 |
| rameshg87 | ifarkas, yeah for now we have only one zap task | 09:15 |
| ifarkas | rameshg87, what do you mean? we apply the configuration in 2 steps | 09:16 |
| devananda | jiangfei: I realize the REST API currently exposes two ways to perform the same function: "find thing related to other-thing" | 09:16 |
| devananda | jiangfei: eg, "find node(s) related to chassis-id" or "find port(s) related to node-id" | 09:16 |
| rameshg87 | ifarkas, yeah i think for your case first node.raid.apply_configuration (root=True) and then node.raid.apply_configuration (root=False) | 09:17 |
| devananda | jiangfei: I don't think the REST API *should* expose two mechanisms to perform the same function. that's unnecessary, and probably confusing for users | 09:17 |
| rameshg87 | ifarkas, correct ? that's what we were planning for, right ? | 09:17 |
| ifarkas | rameshg87, yes | 09:17 |
| rameshg87 | ifarkas, apply() and create() can be merged if delete is a separate zap task | 09:18 |
| jiangfei | devananda: ok | 09:18 |
| *** achanda has quit IRC | 09:19 | |
| rameshg87 | ifarkas, we can have 2 zap tasks node.raid.delete_configuration which deletes the raid on the machine | 09:19 |
| rameshg87 | ifarkas, another one is node.raid.apply_configuration which creates a configuration | 09:19 |
| rameshg87 | ifarkas, so infact create can be same as apply | 09:19 |
| ifarkas | rameshg87, yeah, we will have 2 methods which will be called during zapping | 09:20 |
| rameshg87 | ifarkas, so DELETE /nodes/<uuid>/raid/configuration is no longer required, right ? | 09:20 |
| *** andreykurilin_ has joined #openstack-ironic | 09:21 | |
| rameshg87 | ifarkas, because if operator wants to delete raid configuration, they don't need to call this api | 09:21 |
| ifarkas | rameshg87, yeah | 09:21 |
| rameshg87 | ifarkas, they can directly do the zap step node.raid.delete_configuration | 09:21 |
| *** dtantsur|afk is now known as dtantsur | 09:22 | |
| devananda | jiangfei: thank you for the proposals -- you have highlighted that our REST API duplicates functionality. I am filing a bug about it, and will propose that we deprecate | 09:24 |
| ifarkas | rameshg87, +1 for merging create and apply | 09:24 |
| devananda | jiangfei: support for queries like GET /v1/nodes?chassis_uuid=UUUU | 09:24 |
| rameshg87 | ifarkas, okay | 09:24 |
| *** derekh has joined #openstack-ironic | 09:24 | |
| devananda | this is better expressed as GET /v1/chassis/UUUU/nodes | 09:24 |
| jiangfei | devananda: ok, thank you. | 09:25 |
| rameshg87 | ifarkas, do you want to correct the spec or shall i take it up ? | 09:25 |
| ifarkas | rameshg87, I can do that possibly tomorrow but feel free to take it | 09:26 |
| rameshg87 | ifarkas, okay i will take it up today | 09:26 |
| rameshg87 | ifarkas, please post your opinion on RAIDInterface vs ManagementInterface | 09:26 |
| rameshg87 | ifarkas, let's discuss on next meeting .. | 09:26 |
| ifarkas | rameshg87, will do | 09:26 |
| jiangfei | devananda: do you mean get-node-from-chassis-id is not useful? | 09:27 |
| jiangfei | devananda: should we use get v1/nodes/detail?chassis_uuid={uuid}, not use GET /v1/nodes?chassis_uuid=UUUU | 09:29 |
| jiangfei | . is right? | 09:29 |
| jiangfei | devananda: i got it, GET /v1/chassis/UUUU/nodes is better, thank you. | 09:36 |
| *** yog_ has quit IRC | 09:41 | |
| *** ndipanov has joined #openstack-ironic | 09:41 | |
| *** yog_ has joined #openstack-ironic | 09:43 | |
| zigo | devananda: https://kilo-jessie.pkgs.mirantis.com/job/ironic/5/console | 09:43 |
| *** MattMan has quit IRC | 09:49 | |
| *** jiangfei has quit IRC | 09:56 | |
| *** erwan_taf has quit IRC | 09:58 | |
| *** MattMan has joined #openstack-ironic | 09:58 | |
| devananda | lucasagomes: https://bugs.launchpad.net/ironic/+bug/1418443 | 10:02 |
| devananda | jiangfei: ^ | 10:02 |
| *** dtantsur is now known as dtantsur|bbl | 10:03 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add list of python driver packages https://review.openstack.org/153109 | 10:08 |
| *** chenglch has quit IRC | 10:11 | |
| *** coolsvap is now known as coolsvap_ | 10:29 | |
| lucasagomes | yuriyz, thanks for the comments about being possible to change capabilities after deployment, I replied to that. There's also another problem we are aware of which we can change the properties of the node after deployment and that will count as available resource in Nova | 10:30 |
| lucasagomes | yuriyz, would be good to talk about it today, whether we should allow updates to node.properties after the node is deploy{ing,ed} or not | 10:31 |
| lucasagomes | devananda, ^ | 10:31 |
| openstackgerrit | Merged openstack/ironic: Add policy show_password to mask passwords in driver_info https://review.openstack.org/150688 | 10:36 |
| *** chlong has joined #openstack-ironic | 10:50 | |
| *** alexpilotti has joined #openstack-ironic | 10:56 | |
| *** Nisha has quit IRC | 10:56 | |
| *** pelix has joined #openstack-ironic | 11:02 | |
| *** dtantsur|bbl is now known as dtantsur | 11:03 | |
| mgoddard1 | devananda: Could you take a look at https://bugs.launchpad.net/ironic/+bug/1418474 just to make sure I've got the right end of the stick | 11:03 |
| *** ramineni has quit IRC | 11:04 | |
| *** pcrews has quit IRC | 11:08 | |
| *** yog_ has quit IRC | 11:11 | |
| *** pcrews has joined #openstack-ironic | 11:11 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add support for local boot https://review.openstack.org/146189 | 11:11 |
| *** andreykurilin_ has quit IRC | 11:12 | |
| devananda | jroll: 150724 needs you to lift the -2 | 11:12 |
| *** Marga_ has joined #openstack-ironic | 11:14 | |
| *** afaranha has joined #openstack-ironic | 11:16 | |
| ifarkas | dtantsur, hey | 11:21 |
| dtantsur | ifarkas, o/ | 11:21 |
| *** rameshg87 has quit IRC | 11:22 | |
| ifarkas | dtantsur, I had some crazy time trying out the deploy plugin with discoverd :-) | 11:22 |
| ifarkas | dtantsur, the issue was that the hardware library wasn't installed | 11:22 |
| *** jiangfei has joined #openstack-ironic | 11:22 | |
| ifarkas | dtantsur, I was thinking whether the plugins should add at least some documentation on installation/usage. What do you think? | 11:23 |
| dtantsur | ifarkas, I'm waiting for some documentation to be added to the blueprint... | 11:24 |
| ifarkas | dtantsur, shouldn't it be rather in the repo? | 11:25 |
| dtantsur | ifarkas, maybe, but I don't have docs in repo at all, only large readme :) | 11:25 |
| *** vdrok_ has joined #openstack-ironic | 11:27 | |
| jiangfei | devananda: hi, I looked back and thought for a moment, if we want get nodes by chassis_id and maintenance( or associated ), may be we can use 'get /v1/nodes/?associated=true&chassis_uuid=UUID' | 11:29 |
| *** Haomeng|2 has joined #openstack-ironic | 11:43 | |
| openstackgerrit | Merged openstack/ironic: Refactor ilo.deploy._get_single_nic_with_vif_port_id() https://review.openstack.org/152506 | 11:43 |
| *** Haomeng has quit IRC | 11:43 | |
| naohirot | dtantsur: rloo: devananda: ^^^ thanks! | 11:45 |
| dtantsur | you're welcome :) | 11:45 |
| naohirot | dtantsur: :) | 11:45 |
| *** coolsvap_ is now known as coolsvap | 11:46 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Support for non-Glance image references https://review.openstack.org/136741 | 12:01 |
| *** coolsvap is now known as coolsvap_ | 12:01 | |
| *** EmilienM|afk is now known as EmilienM | 12:02 | |
| *** Marga_ has quit IRC | 12:02 | |
| *** Marga_ has joined #openstack-ironic | 12:04 | |
| openstackgerrit | Merged openstack/ironic: Add list of python driver packages https://review.openstack.org/153109 | 12:06 |
| openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 12:09 |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add iRMC Management module for iRMC Driver https://review.openstack.org/146803 | 12:12 |
| openstackgerrit | Merged openstack/ironic: Raise minimum API version to 1.1 https://review.openstack.org/152527 | 12:13 |
| *** chlong has quit IRC | 12:38 | |
| *** lucasagomes_ has joined #openstack-ironic | 12:47 | |
| *** Marga_ has quit IRC | 12:53 | |
| *** subscope has quit IRC | 12:55 | |
| *** Marga_ has joined #openstack-ironic | 12:56 | |
| *** Marga_ has quit IRC | 13:08 | |
| *** erwan_taf has joined #openstack-ironic | 13:08 | |
| *** subscope has joined #openstack-ironic | 13:11 | |
| devananda | jroll: ping | 13:13 |
| naohirot | devananda: It passed jenkins https://review.openstack.org/146803, is the door still open? :) | 13:13 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Remove min and max from base.Version https://review.openstack.org/153221 | 13:14 |
| *** lucasagomes has quit IRC | 13:14 | |
| *** lucasagomes_ is now known as lucasagomes | 13:14 | |
| *** enikanorov_ has quit IRC | 13:16 | |
| *** jerryz has quit IRC | 13:18 | |
| *** dprince has joined #openstack-ironic | 13:18 | |
| *** jerryz has joined #openstack-ironic | 13:31 | |
| *** mjturek1 has joined #openstack-ironic | 13:32 | |
| *** jerryz has quit IRC | 13:36 | |
| *** jjohnson2 has joined #openstack-ironic | 13:40 | |
| *** ndipanov has quit IRC | 13:40 | |
| jroll | morning all | 13:41 |
| jroll | devananda: hi | 13:41 |
| lucasagomes | (venv)[lucasagomes@lucasagomes ironic]$ grep -R meow ironic/tests/* | grep -v Binary | wc -l | 13:42 |
| lucasagomes | 24 | 13:42 |
| lucasagomes | ^_^ | 13:42 |
| lucasagomes | :P | 13:42 |
| jroll | devananda: +A 150724 | 13:42 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add logical name support to Ironic https://review.openstack.org/141737 | 13:47 |
| trown | need more meows | 13:47 |
| dtantsur | ++ | 13:47 |
| devananda | jroll: morning | 13:47 |
| jroll | \o | 13:47 |
| dtantsur | jroll, o/ | 13:47 |
| jroll | morning dtantsur trown lucasagomes :) | 13:48 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add logical name support to Ironic https://review.openstack.org/141737 | 13:49 |
| devananda | lucasagomes: done ^ | 13:49 |
| lucasagomes | devananda, \o/ | 13:50 |
| lucasagomes | jroll, yo, g'morning | 13:50 |
| lucasagomes | trown, morning :D +1 for more meows | 13:50 |
| jroll | devananda: so what all are we reviewing before we tag kilo 2? | 13:50 |
| * jroll looks at names thing | 13:51 | |
| openstackgerrit | Devananda van der Veen proposed openstack/python-ironicclient: Update requirements.txt https://review.openstack.org/153163 | 13:52 |
| devananda | jroll: thoguhts on 151868 ? | 13:53 |
| jroll | devananda: is mac address unique in our db? | 13:54 |
| devananda | yes | 13:54 |
| devananda | I also filed https://bugs.launchpad.net/ironic/+bug/1418443 -- but that's not for today | 13:55 |
| *** subscope has quit IRC | 13:55 | |
| devananda | jroll: https://launchpad.net/ironic/+milestone/kilo-2 only lists logical-names right now | 13:55 |
| jroll | devananda: if it's unique, I don't see the point | 13:55 |
| jroll | unless you only want to land it because our API exposes that | 13:55 |
| devananda | jroll: right. see my first comment and -1 | 13:56 |
| devananda | jroll: then I thought about it from POV of "what functionality does it give" and they are very slightly different | 13:56 |
| jroll | aha | 13:57 |
| jroll | silly api | 13:57 |
| devananda | jroll: one returns a collection of short objects | 13:57 |
| devananda | jroll: the other retrns a collection of detail objects | 13:58 |
| jroll | right | 13:58 |
| devananda | so yah. silly API. but I could see both being reasonably used in different ways | 13:58 |
| jroll | yeah | 13:59 |
| jroll | gimme a few, I'll review that and logical names | 13:59 |
| * jroll gets pulled around in five directions | 13:59 | |
| devananda | hehe | 13:59 |
| * devananda steps away for a tour of latest Moonshot hardware | 14:00 | |
| naohirot | devananda: thank you for your hard work! | 14:00 |
| naohirot | devananda: have a good rest, and have a nice day | 14:01 |
| devananda | jroll: I'm sure naohirot would like some reviews on the driver. Ihaven't gotten to those yet... 've bumped the BP so it doesn't block the milestone | 14:01 |
| devananda | BUT if you get around to reviewing/approving it ... and it gets in .. ;) | 14:01 |
| jroll | :P | 14:01 |
| naohirot | devananda: jroll: good night :) | 14:01 |
| *** naohirot has quit IRC | 14:02 | |
| * devananda decides not to step away after all... dont wnt to walk in the snow | 14:03 | |
| jroll | ... says the guy going skiing tomorrow | 14:03 |
| devananda | heh | 14:04 |
| jroll | devananda: lucasagomes: did one of you actually test this client patcH? | 14:05 |
| devananda | jroll: which one? | 14:06 |
| jroll | also, we manually build the query string in the client? :| | 14:06 |
| jroll | the ports?address= | 14:06 |
| devananda | jroll: we do that in the mocks. ... | 14:07 |
| devananda | not in the actual client lib or CLI | 14:07 |
| jroll | devananda: https://review.openstack.org/#/c/151868/2/ironicclient/v1/port.py | 14:08 |
| jroll | line 76 | 14:08 |
| devananda | oh. apparently we do | 14:08 |
| devananda | also L34 | 14:08 |
| jroll | yeah | 14:08 |
| * jroll testing this patch real quick | 14:09 | |
| jroll | surprise, it works | 14:09 |
| jroll | I'm going to push a nit fix | 14:09 |
| afaranha | Hello | 14:09 |
| afaranha | devananda, could you tell me how can I configure the Neutron DHCP to provide IP for external machines? | 14:09 |
| openstackgerrit | Jim Rollenhagen proposed openstack/python-ironicclient: port-list support get-port-from-mac https://review.openstack.org/151868 | 14:10 |
| jroll | devananda: lucasagomes ^ | 14:10 |
| *** subscope has joined #openstack-ironic | 14:10 | |
| devananda | NobodyCam: any progress on https://bugs.launchpad.net/ironic/+bug/1417307? | 14:14 |
| devananda | afaranha: http://docs.openstack.org/developer/ironic/deploy/install-guide.html#configure-neutron-to-communicate-with-the-bare-metal-server | 14:14 |
| *** mlsoule has joined #openstack-ironic | 14:15 | |
| jroll | devananda: there's a patch for 1417307 that dprince was going to test | 14:15 |
| devananda | that's marked critical, so I'm targeting to k2 to block the release until we fix or reclassify it | 14:16 |
| afaranha | I thought this was configure by devstack, I didn't pay attetion to it | 14:16 |
| afaranha | thanks :) | 14:16 |
| devananda | afaranha: devstack defaults to configure for a single machine test environment | 14:16 |
| devananda | afaranha: you're trying to use external machines -- s oyou need to change from teh defaults | 14:17 |
| jroll | devananda: so on this logical names thing... we're bumping the api version, but also allowing names to be used for < 1.5 | 14:18 |
| jroll | devananda: you're ok with that | 14:18 |
| jroll | ? | 14:18 |
| *** dtantsur has left #openstack-ironic | 14:18 | |
| *** dtantsur has joined #openstack-ironic | 14:19 | |
| devananda | afaranha: this may also help - https://software.intel.com/en-us/blogs/2014/12/22/physical-server-provisioning-with-openstack | 14:19 |
| devananda | jroll: ehhh. no :( | 14:19 |
| jroll | that's what I was thinking :/ | 14:20 |
| jroll | devananda: -1'd for that, added another comment as well | 14:26 |
| NobodyCam | good morning Ironic | 14:28 |
| devananda | jroll: ima fix eet | 14:28 |
| jroll | devananda: cool, I'm stepping away for a bit | 14:28 |
| jroll | morning NobodyCam :) | 14:29 |
| * jroll passes the coffee | 14:29 | |
| NobodyCam | :) morning jroll ... | 14:29 |
| * NobodyCam takes a sip of the warn nector | 14:29 | |
| *** BadCub_ has joined #openstack-ironic | 14:29 | |
| BadCub_ | morning Ironic folk | 14:30 |
| NobodyCam | morning BadCub_ :) | 14:30 |
| *** jcoufal_ has joined #openstack-ironic | 14:30 | |
| *** rloo has joined #openstack-ironic | 14:31 | |
| *** jcoufal has quit IRC | 14:33 | |
| *** enikanorov_ has joined #openstack-ironic | 14:35 | |
| *** ndipanov has joined #openstack-ironic | 14:36 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Refactor ValidateInterfaces plugin https://review.openstack.org/153240 | 14:46 |
| *** absubram has joined #openstack-ironic | 14:47 | |
| rloo | morning everyone | 14:56 |
| rloo | dtantsur: did you see this? https://review.openstack.org/#/c/150073/15..16/ironic/tests/conductor/test_manager.py | 14:56 |
| rloo | dtantsur: didn't you add those tests? | 14:57 |
| dtantsur | rloo, I did | 14:57 |
| rloo | dtantsur: it looks like they are going to be deleted | 14:57 |
| NobodyCam | good morning rloo :) | 14:57 |
| rloo | hey, morning NobodyCam | 14:57 |
| dtantsur | lucasagomes, mind dropping W+1? | 14:57 |
| dtantsur | oh stop, no | 14:58 |
| dtantsur | disregard | 14:58 |
| dtantsur | rloo, patch itself does not delete anything https://review.openstack.org/#/c/150073/16/ironic/tests/conductor/test_manager.py | 14:58 |
| dtantsur | rloo, what you see if probably due to constant rebases | 14:59 |
| NobodyCam | dprince: Thank you for the test!!! | 14:59 |
| rloo | dtantsur: phew. thx. that was odd. | 14:59 |
| dtantsur | NobodyCam, morning | 14:59 |
| NobodyCam | morning dtantsur :) | 14:59 |
| dtantsur | rloo, I already though I was mad by +2ing that :D | 14:59 |
| rloo | dtantsur: so the rebasing confused gerrit? (or confused me anyway) | 15:00 |
| dprince | NobodyCam: np | 15:00 |
| dtantsur | rloo, yeah, for these diffs it shows everything that changes. and as that patch was one rebased backward, we got this result | 15:00 |
| rloo | dtantsur: eeks, I'm going to have to be more careful reviewing diffs ... | 15:01 |
| dtantsur | yeah. it's a convenient tool, but it's not without weirdness | 15:02 |
| lucasagomes | dtantsur, checking | 15:02 |
| dtantsur | lucasagomes, no, it's ok | 15:02 |
| dtantsur | nevermind | 15:02 |
| lucasagomes | ok cool | 15:02 |
| dtantsur | we were confused by Gerrit :) | 15:03 |
| NobodyCam | morning lucasagomes :) | 15:10 |
| lucasagomes | NobodyCam, morning | 15:11 |
| NobodyCam | :) | 15:11 |
| openstackgerrit | Merged openstack/ironic: Add MANAGEABLE state and associated transitions https://review.openstack.org/150073 | 15:11 |
| *** ijw has joined #openstack-ironic | 15:15 | |
| *** ijw has quit IRC | 15:15 | |
| *** ijw has joined #openstack-ironic | 15:16 | |
| openstackgerrit | Merged openstack/python-ironicclient: Add driver_internal_info to node-show output https://review.openstack.org/150724 | 15:19 |
| *** david-lyle_afk is now known as david-lyle | 15:23 | |
| NobodyCam | dtantsur: did you happen to have any thoughts on dan comment on 152734 about bumpping the time out to ten seconds? | 15:24 |
| NobodyCam | s/dan/Dan's/ | 15:24 |
| *** anderbubble has joined #openstack-ironic | 15:25 | |
| dtantsur | now we have 3, right? hmm... do not think I have any opinion on this, but I generally prefer larger timeouts (rather than risking failing a correct deployment) | 15:25 |
| NobodyCam | ok the code will exit earily so its not like a sleep | 15:27 |
| NobodyCam | :) | 15:27 |
| dtantsur | exactly :) | 15:27 |
| NobodyCam | Ty :) | 15:27 |
| *** Marga_ has joined #openstack-ironic | 15:28 | |
| openstackgerrit | Merged openstack/ironic: Remove min and max from base.Version https://review.openstack.org/153221 | 15:31 |
| *** jcoufal_ has quit IRC | 15:33 | |
| *** jcoufal has joined #openstack-ironic | 15:34 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Allow ramdisk to specify PXE boot interface https://review.openstack.org/153261 | 15:44 |
| *** jcoufal has quit IRC | 15:45 | |
| *** jcoufal has joined #openstack-ironic | 15:46 | |
| *** jcoufal_ has joined #openstack-ironic | 15:47 | |
| *** jcoufal has quit IRC | 15:50 | |
| *** achanda has joined #openstack-ironic | 15:53 | |
| mjturek1 | quick question, how complete is the install guide in regards to neutron setup? I noticed that there's no step for creating the subnet in neutron (which I believe is necessary) and was wondering if there are any other missing pieces | 15:55 |
| openstackgerrit | Merged openstack/python-ironicclient: Update requirements.txt https://review.openstack.org/153163 | 16:01 |
| NobodyCam | mjturek1: you would be the second person I have heard that from; but I have not had a chance to look in to that | 16:01 |
| openstackgerrit | Merged openstack/python-ironicclient: port-list support get-port-from-mac https://review.openstack.org/151868 | 16:01 |
| mjturek1 | NobodyCam, okay no worries! | 16:01 |
| NobodyCam | <shamelessPlug> would be very happy to review a doc patch for that :) | 16:02 |
| *** Marga_ has quit IRC | 16:02 | |
| mjturek1 | NobodyCam absolutely! I can throw one up for the subnet creation step today. Still not sure what else is needed as I've been having trouble getting dnsmasq to handle requests | 16:03 |
| *** anderbubble has quit IRC | 16:04 | |
| *** Marga_ has joined #openstack-ironic | 16:04 | |
| *** achanda has quit IRC | 16:05 | |
| *** vdrok_ has quit IRC | 16:05 | |
| mjturek1 | NobodyCam, maybe it's something we can discuss during next week's meeting as well. | 16:05 |
| NobodyCam | :) awesome ... thats all I've heard about (the subnet thing) | 16:05 |
| NobodyCam | yea! | 16:05 |
| mjturek1 | okay cool, I'd be glad to throw that on the agenda | 16:06 |
| NobodyCam | thank you :) | 16:06 |
| mjturek1 | no problem! | 16:06 |
| *** yog_ has joined #openstack-ironic | 16:11 | |
| *** rameshg87 has joined #openstack-ironic | 16:11 | |
| dtantsur | calling it a day, see you on Monday (tomorrow is a local conference, where I'll be talking about Ironic :) | 16:17 |
| *** jcoufal_ has quit IRC | 16:17 | |
| *** mjturek1 has quit IRC | 16:17 | |
| NobodyCam | have a great weekend dtantsur | 16:17 |
| *** jcoufal has joined #openstack-ironic | 16:17 | |
| jlvillal | dtantsur: Good night | 16:17 |
| rloo | bye dtantsur. if you have a sec, just saw your comment on names | 16:17 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add support for local boot https://review.openstack.org/146189 | 16:18 |
| rloo | dtantsur: so you think it should not allow uuid as name? | 16:18 |
| dtantsur | rloo, yeah. this part of spec was added by my request | 16:18 |
| dtantsur | rloo, or we should change logic of detecting, what is supplied | 16:18 |
| rloo | dtantsur: ok, then the coding needs to be changed. | 16:18 |
| *** Nisha has joined #openstack-ironic | 16:19 | |
| rloo | dtantsur: you can discuss with mrda ;) | 16:19 |
| *** mlsoule has quit IRC | 16:19 | |
| dtantsur | heh, at least not now :) | 16:19 |
| *** dtantsur is now known as dtantsur|afk | 16:19 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: improve iSCSI connection check https://review.openstack.org/152734 | 16:21 |
| NobodyCam | dprince: I'll do the timeout bump in another patch | 16:22 |
| dprince | NobodyCam: yep, sounds good | 16:24 |
| *** afaranha has quit IRC | 16:25 | |
| *** rwsu-afk is now known as rwsu | 16:28 | |
| * jlvillal wonders if the people in Grenoble have seen any Toyota i-Drive vehicles. Had saw that Grenoble was a test market for them :) | 16:30 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Fix help string for port-list https://review.openstack.org/153284 | 16:31 |
| NobodyCam | jlvillal: are they making it. I thought it was just a concept | 16:32 |
| *** ndipanov has quit IRC | 16:32 | |
| rloo | lucasagomes, devananda: ^^ if you want to get that into the client (minor cleanup) | 16:32 |
| jlvillal | NobodyCam: I think still in testing phase. But I had saw a CNET video that said Grenoble was a testing market. So some people got to drive them around. They look cool :) | 16:33 |
| NobodyCam | they are odd looking :) but kinda neet | 16:33 |
| jlvillal | rloo: You got my +1 :D | 16:33 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-specs: Remove UUID from root device hints https://review.openstack.org/153287 | 16:34 |
| rloo | thx jlvillal ;) | 16:34 |
| lucasagomes | rloo, cool /me checks | 16:35 |
| *** ijw has quit IRC | 16:35 | |
| devananda | jroll: got the new version of logical names, about to push | 16:35 |
| devananda | we will need to add support to the client for it. but meh. later. | 16:36 |
| rloo | devananda: don't know if you saw dtantsur|afk comment about not wanting logical names == uuid. I figure it can be fixed (if we want it) later. | 16:36 |
| devananda | didn't see. what's up? | 16:37 |
| openstackgerrit | Merged openstack/ironic: Correct typo in agent_client https://review.openstack.org/153110 | 16:37 |
| rloo | devananda: in the spec, it sez that we won't allow logical names to have a uuid string. | 16:38 |
| rloo | devananda: but the code allows that, so i asked mrda to update the spec | 16:38 |
| NobodyCam | lucasagomes: rloo: if you happen to have a free minute would you mind taking a quick look at 152734 | 16:38 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Add states required for node-inspection https://review.openstack.org/147857 | 16:38 |
| devananda | oh yah | 16:39 |
| devananda | that shoud be an easy fix to the spec, right? | 16:39 |
| rloo | devananda: but dtantsur|afk wants that fixed | 16:39 |
| devananda | or does dtantsur|afk object to the implementation? | 16:39 |
| rloo | devananda: dtantsur|afk doesn't want names to have uuid strings | 16:39 |
| devananda | so even though a UUID is a valid hostname accd to the RFC on host names | 16:39 |
| devananda | we'll reject it? | 16:39 |
| rloo | devananda: we don't reject it now, but it should be rejected | 16:40 |
| devananda | I mean, if someone wants to store a uuid in the host name field, why do we care? | 16:40 |
| rloo | devananda: so i see that as a bug. or whatever. | 16:40 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: New driver interface for RAID configuration https://review.openstack.org/135899 | 16:40 |
| devananda | rloo: I dont understand the problem | 16:40 |
| rloo | devananda: i suspect there may be some things that can't be done with a name like that, but i haven't thought it through. | 16:40 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add logical name support to Ironic https://review.openstack.org/141737 | 16:41 |
| lucasagomes | rloo, devananda we are allowing operators to name their node as they want | 16:41 |
| lucasagomes | idk their use case, but if they want to name it as an UUID | 16:42 |
| lucasagomes | I mean, I'm fine with that | 16:42 |
| rloo | lucasagomes: no, the name hsa to conform to hostname blah blah stuff. | 16:42 |
| lucasagomes | sure | 16:42 |
| devananda | jroll: ^ now with 20 lines more code and 100 lines more unit tests :-D | 16:42 |
| lucasagomes | yeah that's the RFC, but it's hard to say | 16:42 |
| *** mlsoule has joined #openstack-ironic | 16:42 | |
| lucasagomes | names should follow RFC X, *BUT* ... | 16:42 |
| lucasagomes | I would rather say, names should follow RFC X and that's it | 16:43 |
| devananda | lucasagomes: ++ "and that's it" | 16:43 |
| devananda | let operators choose. if they want to overload the human-readable name with another non-human-readable field, so be it | 16:43 |
| rloo | dtantsur|afk: sez "If we allow such names, we won't be able to use them, because they'll be interpreted as (non-existing) UUID's, not as names." | 16:44 |
| devananda | ironic should always look for a node with the uuid first. then fall back to hostname. then error with not found. | 16:44 |
| devananda | which is exatly what this patch does | 16:44 |
| rloo | i'd need to look at the code to see if/what the behaviour is. | 16:44 |
| devananda | oh | 16:44 |
| devananda | I see | 16:44 |
| * devananda fixes | 16:44 | |
| rloo | devananda: ahh, _get_rpc_node() doesn't try the hostname if it thinks it is a uuid | 16:45 |
| lucasagomes | yeah that's a good catch by dtantsur|afk | 16:46 |
| lucasagomes | can be fixed with fallback, or by checking the name first then UUID | 16:46 |
| devananda | rloo: right. I'm fixing that now | 16:47 |
| lucasagomes | NobodyCam, +1... we are almost leaving but I will take a look soonish | 16:47 |
| NobodyCam | :) Thank you lucasagomes | 16:48 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: Inband RAID configuration using agent ramdisk https://review.openstack.org/147803 | 16:48 |
| NobodyCam | jroll: quick question: this looks like a external error but as I have not done a whole bunch of agent debugging I wanted to ask if your seen this much: http://logs.openstack.org/96/150096/1/check/check-tempest-dsvm-ironic-agent_ssh/ef66637/logs/screen-ir-cond.txt.gz#_2015-02-05_13_28_00_723 | 16:50 |
| *** mjturek1 has joined #openstack-ironic | 16:52 | |
| jlvillal | Quick question for anyone who would like to give input :) Is DevStack what most people are using for development/testing? Use it virtualized? What about the nodes are they also virtualized or small NUC like systems? I have the virtualenv developer setup for Ironic, but want to get an OpenStack setup working. | 16:54 |
| jlvillal | I have been reading this: http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html | 16:55 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Add InspectInterface for node-introspection https://review.openstack.org/149817 | 16:57 |
| *** ijw has joined #openstack-ironic | 17:00 | |
| adam_g | jlvillal, yes, that gives you an all-in-one virtualized environment | 17:00 |
| adam_g | with some VMs acting as physical nodes | 17:00 |
| jlvillal | adam_g: Thanks! | 17:00 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add logical name support to Ironic https://review.openstack.org/141737 | 17:02 |
| devananda | jroll: ^ | 17:03 |
| devananda | rloo: i meant ^ | 17:03 |
| rloo | devananda: thx | 17:03 |
| devananda | time fo rme to go afk | 17:05 |
| NobodyCam | have a good night devananda :) | 17:05 |
| rloo | bye devananda. | 17:05 |
| rloo | devananda: when were you thinking of pushing a kilo-2 release? | 17:05 |
| *** imtiaz has joined #openstack-ironic | 17:08 | |
| devananda | rloo: ttx is watching https://launchpad.net/ironic/+milestone/kilo-2 | 17:08 |
| devananda | rloo: so once the logical-names patch lands, I'll mark that BP done,a nd he'll tag it | 17:09 |
| rloo | devananda: good to know. am reviewing now ... | 17:11 |
| *** lucasagomes has quit IRC | 17:14 | |
| * devananda comments on review | 17:14 | |
| devananda | and goes afk for a few hours to find dinner | 17:14 |
| *** mgoddard1 has quit IRC | 17:17 | |
| *** ifarkas has quit IRC | 17:18 | |
| *** anderbubble has joined #openstack-ironic | 17:21 | |
| *** lazy_prince is now known as killer_prince | 17:26 | |
| *** rameshg87 has quit IRC | 17:32 | |
| *** Marga_ has quit IRC | 17:43 | |
| jroll | NobodyCam: I have seen that, a long time ago, this should have fixed it: https://github.com/openstack-dev/devstack/blob/master/lib/ironic#L618 | 17:44 |
| *** Haomeng has joined #openstack-ironic | 17:44 | |
| *** Haomeng|2 has quit IRC | 17:45 | |
| NobodyCam | ok I'll blame gerrit and recheck : | 17:45 |
| NobodyCam | :) | 17:45 |
| NobodyCam | jroll: thank you :) | 17:45 |
| *** Marga_ has joined #openstack-ironic | 17:50 | |
| *** dkingshott has joined #openstack-ironic | 17:51 | |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add the subnet creation step to the install guide https://review.openstack.org/153312 | 17:51 |
| mjturek1 | NobodyCam here's my proposed change if you have a chance to look! | 17:52 |
| rloo | jroll, NobodyCam. I just reviewed 141737 -- do you think we (I?) should update?? | 17:53 |
| NobodyCam | mjturek1: awesome... will look in a few | 17:54 |
| NobodyCam | rloo: looking | 17:54 |
| jroll | rloo: yes, we should update it, k2 is just waiting on this patch | 17:55 |
| NobodyCam | rloo: yes please | 17:55 |
| rloo | jroll, NobodyCam. Ok, I'll do it unless one of you want to ;) | 17:55 |
| *** Marga_ has quit IRC | 17:55 | |
| jroll | rloo: I could but have other things to do first | 17:55 |
| rloo | jroll: I have nothing better to do ha ha. | 17:56 |
| jroll | :P | 17:56 |
| NobodyCam | :) rloo thank you :) | 17:56 |
| *** anderbubble has quit IRC | 17:58 | |
| *** mgoddard has joined #openstack-ironic | 17:59 | |
| *** anderbubble has joined #openstack-ironic | 18:01 | |
| *** derekh has quit IRC | 18:03 | |
| *** spandhe has joined #openstack-ironic | 18:04 | |
| *** MattMan has quit IRC | 18:08 | |
| *** imtiaz has quit IRC | 18:08 | |
| *** jistr has quit IRC | 18:09 | |
| *** mgoddard has quit IRC | 18:09 | |
| *** jistr has joined #openstack-ironic | 18:10 | |
| *** korekhov has joined #openstack-ironic | 18:12 | |
| jmanko | jroll, are you going to get some time to review my spec that we talked about at Mondays meeting? https://review.openstack.org/#/c/127378/ | 18:14 |
| jroll | jmanko: yes, thanks for the reminder | 18:15 |
| jmanko | np | 18:15 |
| *** Marga_ has joined #openstack-ironic | 18:16 | |
| harmw | can I pass any parameters to discovery.ramdisk to start a shell when it completes? | 18:20 |
| *** jcoufal has quit IRC | 18:22 | |
| *** jistr has quit IRC | 18:22 | |
| *** ChuckC_ has joined #openstack-ironic | 18:25 | |
| *** achanda has joined #openstack-ironic | 18:25 | |
| *** ChuckC has quit IRC | 18:29 | |
| *** harlowja has joined #openstack-ironic | 18:30 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Add logical name support to Ironic https://review.openstack.org/141737 | 18:38 |
| *** Nisha has quit IRC | 18:38 | |
| *** Nisha has joined #openstack-ironic | 18:38 | |
| *** korekhov_ has joined #openstack-ironic | 18:44 | |
| *** Shrews has quit IRC | 18:46 | |
| *** korekhov has quit IRC | 18:46 | |
| *** dkingshott has quit IRC | 18:47 | |
| *** Shrews has joined #openstack-ironic | 18:48 | |
| *** ukalifon has joined #openstack-ironic | 18:51 | |
| *** dan_ has joined #openstack-ironic | 18:52 | |
| *** rloo has quit IRC | 18:55 | |
| *** pelix has quit IRC | 19:01 | |
| *** ChuckC has joined #openstack-ironic | 19:13 | |
| *** ChuckC_ has quit IRC | 19:17 | |
| *** Shrews has quit IRC | 19:20 | |
| harmw | NobodyCam: mind if I bother you with some ironic questions? | 19:23 |
| NobodyCam | harmw: I can only do my best to answer :) | 19:24 |
| harmw | :) | 19:24 |
| NobodyCam | :p | 19:24 |
| harmw | I'm running a vm that's supposed to be discovered | 19:25 |
| harmw | so this vm boots, and grabs kernel+ramdisk through pxe | 19:25 |
| harmw | so far, greta | 19:25 |
| harmw | but it ends with 'discovery completed!', though prints an error before that | 19:26 |
| harmw | http/400 | 19:26 |
| harmw | and the node's specs didn't get updated in ironic/tuskar-ui | 19:26 |
| harmw | it tells me I can press 't' to debug | 19:26 |
| harmw | but that does nothing | 19:26 |
| harmw | is thre some way of triggering this shell from pxelinux.cfg/default? | 19:27 |
| harmw | (I noticed rh.shell but that does nothing, apparently) | 19:27 |
| NobodyCam | harmw: your using ironic-discoverd? | 19:28 |
| harmw | yup | 19:28 |
| harmw | the node is added with ironic-cli, using fake_pxe driver | 19:28 |
| *** andreykurilin_ has joined #openstack-ironic | 19:31 | |
| NobodyCam | harmw: and your manually hitting power button? | 19:31 |
| NobodyCam | have you set base_url in your discoverd conf file? | 19:32 |
| harmw | it's installed through instack, but yes | 19:32 |
| harmw | and yes, this node is a virtualbox vm which i manually poweron | 19:32 |
| harmw | I can see it hits ironic at 5050, but receives a HTTP/400 | 19:33 |
| NobodyCam | harmw: we have power support for virtual box | 19:33 |
| NobodyCam | 5050 is the discoverd port | 19:33 |
| harmw | haha ok, well, Im just using it as temp setup | 19:33 |
| harmw | ya, is it hitting the wrong service? | 19:34 |
| harmw | append initrd=discovery.ramdisk ironic_callback_url=http://192.0.2.1:5050/v1/continue rd.shell=1 | 19:34 |
| harmw | thts from pxeboot | 19:34 |
| NobodyCam | I think your looking for 6385 to hit ironic | 19:36 |
| NobodyCam | is https://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L505 set correctly? | 19:37 |
| harmw | hm lets see | 19:39 |
| harmw | I have 2 configs, one ironic and one ironic-discoverd | 19:42 |
| NobodyCam | the reff I pasted was for ironic.conf | 19:42 |
| harmw | yea I noticed | 19:42 |
| harmw | ironic-api is listening on that port btw | 19:43 |
| harmw | 6385 | 19:43 |
| NobodyCam | ok thats good | 19:43 |
| harmw | and discoverd is at 5050 | 19:43 |
| harmw | and you're saying the discovery should report back to 6385? | 19:44 |
| *** r-daneel has joined #openstack-ironic | 19:44 | |
| NobodyCam | well only because the param is ironic_callback_url | 19:46 |
| NobodyCam | so I attempting to see how that is set | 19:47 |
| harmw | well 6385 is rquiring authentication | 19:47 |
| harmw | could've guessed that myself | 19:47 |
| NobodyCam | harmw: you've seen: https://github.com/stackforge/ironic-discoverd/blob/master/README.rst | 19:48 |
| harmw | nope, I've only been using instack to do all the labor :) | 19:49 |
| harmw | lets read | 19:49 |
| mjturek1 | another question, is use of the ML2 plugin required for ironic or can plain OVS be used as well? | 19:50 |
| harmw | "On receiving data from the discovery ramdisk, ironic-discoverd:" | 19:50 |
| harmw | its going wrong at that stage, given the 400 I receive | 19:50 |
| *** ijw has quit IRC | 19:51 | |
| NobodyCam | mjturek1: I run ovs for my test env (tripleO devtest based) | 19:52 |
| mjturek1 | NobodyCam, okay cool thanks | 19:52 |
| harmw | # python -m ironic_discoverd.client.introspect $nodeid --auth-token $token | 19:53 |
| harmw | /bin/python: No module named ironic_discoverd.client.introspect | 19:53 |
| harmw | (i was going without the introspect) | 19:53 |
| *** rloo has joined #openstack-ironic | 19:53 | |
| harmw | uhm: # python -m ironic_discoverd.client $nodeid introspect --auth-token $token | 19:54 |
| harmw | but that yields a 400 as well, from the undercloud machine | 19:54 |
| NobodyCam | any thing in the discoverd logs? | 19:55 |
| harmw | ironic-discoverd: BadRequest: Invalid input for field/attribute node_uuid. Value: 'introspect'. unable to convert to uuid (HTTP 400) | 19:56 |
| harmw | # python -m ironic_discoverd.client --auth-token $token introspect $nodeid | 19:56 |
| *** ukalifon has quit IRC | 19:57 | |
| harmw | my client apparently doesn't support introspect or status | 19:59 |
| harmw | python-ironicclient-0.3.1-1.el7.centos.noarch | 19:59 |
| NobodyCam | ahh | 20:00 |
| harmw | (but thats in the undercloud, not the discovery image) | 20:01 |
| *** spandhe has quit IRC | 20:01 | |
| harmw | for completeness-sake I'm using RDO as base on CentOS7, trying to deploy /discover a Fedora cloud :) | 20:02 |
| *** Marga_ has quit IRC | 20:03 | |
| *** Marga_ has joined #openstack-ironic | 20:03 | |
| *** spandhe has joined #openstack-ironic | 20:04 | |
| *** Marga_ has quit IRC | 20:08 | |
| *** spandhe has quit IRC | 20:08 | |
| NobodyCam | jroll: I wounder if that agent error is becuse its a stable branch patch | 20:09 |
| jroll | NobodyCam: oh! | 20:09 |
| jroll | probably | 20:09 |
| jroll | and agent is voting now... ffffffffff | 20:09 |
| jroll | that's annoying | 20:09 |
| NobodyCam | lol :( | 20:09 |
| jroll | NobodyCam: let me look | 20:11 |
| NobodyCam | jroll: yeppers https://github.com/openstack-dev/devstack/blob/stable/juno/lib/ironic | 20:11 |
| NobodyCam | not there | 20:11 |
| jroll | bah | 20:11 |
| jroll | I can't checkout stable/juno | 20:11 |
| jroll | wth | 20:11 |
| NobodyCam | if the stable test are using stable devstack | 20:11 |
| jroll | right, I'm sure they are | 20:12 |
| jroll | ok, fixing | 20:13 |
| NobodyCam | your awesome jroll TY | 20:14 |
| harmw | NobodyCam: does this concern my issue or am I way off :) | 20:14 |
| NobodyCam | harmw: ahh sorry thats not you | 20:15 |
| harmw | hehe | 20:15 |
| NobodyCam | harmw: can you paste your discoverd and ironic logs for me to look at | 20:15 |
| NobodyCam | brb | 20:16 |
| harmw | oh sure | 20:16 |
| jroll | NobodyCam: https://review.openstack.org/#/c/153358/ | 20:17 |
| *** korekhov_ has quit IRC | 20:18 | |
| *** korekhov has joined #openstack-ironic | 20:18 | |
| *** dprince has quit IRC | 20:19 | |
| *** spandhe has joined #openstack-ironic | 20:21 | |
| harmw | NobodyCam: not very usefull I'm afraid: http://paste.debian.net/144154/ | 20:25 |
| *** ijw has joined #openstack-ironic | 20:28 | |
| harmw | iptables is heavily spamming anyway | 20:28 |
| NobodyCam | ya | 20:29 |
| NobodyCam | but nothing jumps | 20:29 |
| NobodyCam | harmw: I may reffer you to dtantsur|afk for help on this... | 20:30 |
| harmw | sure, cool | 20:31 |
| harmw | btw, discovery is sending some json - ironic just cant handle it, or so it seems | 20:32 |
| jroll | so I also put this up because I can't guarantee that devstack patch actually fixes things: https://review.openstack.org/#/c/153363/ | 20:32 |
| *** Marga_ has joined #openstack-ironic | 20:34 | |
| *** mrda-away is now known as mrda | 20:35 | |
| mrda | Morning Ironic | 20:35 |
| openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 20:36 |
| mrda | Oh, the logical name patch has been busy it seems :) | 20:38 |
| *** Marga_ has quit IRC | 20:38 | |
| rloo | mrda: morning. fwiw I saw that gate-ironic-docs error yesterday wrt another patch. | 20:45 |
| mrda | is it a real thing? | 20:45 |
| mrda | (I'm just trawling through the changes that have been made. Haven't got to the error yet) | 20:46 |
| rloo | mrda: dunno. I didn't spend any time looking at it (hoped it would go away). i was wondering if it was due to some package, different version on some machine. | 20:46 |
| mrda | oh, one of these. Great timing for k-2 :) | 20:47 |
| NobodyCam | brb starbucks run! | 20:47 |
| rloo | mrda: i could be wrong... just trying to blame something outside our code ;) | 20:47 |
| mrda | Grande White Mocha please NobodyCam | 20:47 |
| NobodyCam | hehehe :) | 20:47 |
| mrda | rloo: I'm also confused by all the tempest failures | 20:47 |
| NobodyCam | mrda: it might get cold in shipping | 20:47 |
| mrda | only pep8 and py27 passed | 20:48 |
| rloo | mrda: am in a meeting so haven't had time to look into them. the first one looked like a time out. | 20:48 |
| jroll | mrda, I thought you didn't drink crappy coffee :P | 20:48 |
| mrda | NobodyCam: I'll be in SFO on Saturday, can you keep it warm until then? | 20:48 |
| NobodyCam | lol | 20:48 |
| mrda | jroll: that's not coffee, it's hot corn syrup | 20:48 |
| jroll | mrda: btw, you're welcome to come hang out here monday and tuesday | 20:49 |
| jroll | lol | 20:49 |
| jroll | true | 20:49 |
| mrda | jroll: yeah, spoke with russell_h, will be in the office Mon/Tues | 20:49 |
| jroll | awesome | 20:49 |
| rloo | mrda: I see "UnexpectedResponseCode: Unexpected response code received" | 20:53 |
| rloo | mrda: "Details: 406" | 20:53 |
| JayF | FWIW; we're having crap weather for the mid-cycle | 20:53 |
| JayF | all the rain | 20:53 |
| rloo | mrda: in the last revision, i changed some exceptions. to return 406 instead of i'm not sure (400 or 409). am wondering if that is the problem although the 406 should be cuz the logical names is being used. | 20:54 |
| rloo | mrda: and shouldn't be used unless version 1.5 is specified. | 20:55 |
| mrda | ok, I can't do this on an empty stomach. I need breakfast and coffee. | 20:56 |
| *** Marga_ has joined #openstack-ironic | 20:56 | |
| *** andreykurilin_ has quit IRC | 20:57 | |
| mrda | JayF: You have 48 hours to fix this :) | 21:01 |
| *** spandhe has quit IRC | 21:03 | |
| *** spandhe has joined #openstack-ironic | 21:05 | |
| * NobodyCam is back | 21:07 | |
| mrda | rloo: it is the microversioning guards that are causing pain | 21:10 |
| *** ijw has quit IRC | 21:10 | |
| rloo | mrda: what in tempest is testing/tickling that though? | 21:10 |
| *** Marga_ has quit IRC | 21:10 | |
| mrda | so the addition of the guards on validate are incorrect | 21:11 |
| *** Marga_ has joined #openstack-ironic | 21:11 | |
| mrda | we tried to be tricky and add the new param node ahead of the old param 'node_uuid' on validate | 21:11 |
| mrda | but, if node and not allow_logical_names(): | 21:12 |
| mrda | raise exception.NotAcceptable() | 21:12 |
| rloo | mrda: i was thinking that was the only change I added (to raise an exception) that might have caused the problem but I'm not sure why. | 21:12 |
| mrda | so it gets tickled everytime, since node is specified everytime | 21:12 |
| rloo | mrda: it is? specified every time? | 21:12 |
| mrda | first parameter | 21:12 |
| mrda | wsme black magic | 21:13 |
| rloo | mrda: %#$$@ | 21:13 |
| mrda | where's lucas when I need him :) | 21:13 |
| mrda | I'll change it | 21:13 |
| mrda | but the guard needs to be more complex | 21:13 |
| rloo | mrda: thx | 21:14 |
| mrda | if node: if not allow_logical_names() and not is_uuid_like(): # we're doing something that is a 1.5ism | 21:14 |
| *** Marga__ has joined #openstack-ironic | 21:15 | |
| *** Marga_ has quit IRC | 21:15 | |
| rloo | mrda: whatever you say. I thought that 'node' parameter was mapped to the 'node=xxx' in the request | 21:15 |
| rloo | mrda: and the node_uuid parameter was mapped to the 'node_uuid=xx' in the request | 21:16 |
| mrda | it is, but if we don't specify the param the first one is used | 21:16 |
| mrda | since they both are optional | 21:17 |
| *** Marga__ has quit IRC | 21:17 | |
| *** Shrews has joined #openstack-ironic | 21:17 | |
| *** eghobo has joined #openstack-ironic | 21:17 | |
| rloo | mrda: ouch. I didn't realize there was a way to do the request w/o explicitly specifying node or node_uuid. | 21:17 |
| *** Marga_ has joined #openstack-ironic | 21:18 | |
| rloo | mrda: i'm fine with your fix cuz I can't think of anything else right now. it'll allow validate?node=<uuid> but oh well. | 21:19 |
| mrda | I actually don't like what's happenned with _get_rpc_node() either. | 21:20 |
| mrda | But one problem at a time | 21:20 |
| mrda | :) | 21:20 |
| rloo | mrda: you can fix it now? | 21:20 |
| mrda | Just working thru the logic | 21:21 |
| mrda | (i.e. I am working on it. Just hoping I can get a useful solution) | 21:21 |
| *** achanda has quit IRC | 21:22 | |
| *** ijw has joined #openstack-ironic | 21:23 | |
| *** ijw has quit IRC | 21:27 | |
| openstackgerrit | Michael Davies proposed openstack/ironic: Add logical name support to Ironic https://review.openstack.org/141737 | 21:30 |
| *** absubram has left #openstack-ironic | 21:39 | |
| *** krtaylor has quit IRC | 21:40 | |
| *** ijw has joined #openstack-ironic | 21:41 | |
| *** ijw_ has joined #openstack-ironic | 21:44 | |
| *** rloo has quit IRC | 21:46 | |
| *** ijw has quit IRC | 21:46 | |
| *** rloo has joined #openstack-ironic | 21:47 | |
| *** ijw_ has quit IRC | 21:48 | |
| *** jmankov has joined #openstack-ironic | 21:49 | |
| *** achanda has joined #openstack-ironic | 21:50 | |
| *** jmanko has quit IRC | 21:51 | |
| *** dhellmann_ has joined #openstack-ironic | 21:51 | |
| *** krtaylor has joined #openstack-ironic | 21:53 | |
| *** dhellmann_ has quit IRC | 21:55 | |
| *** dhellmann_ has joined #openstack-ironic | 21:57 | |
| *** dhellmann_ has quit IRC | 21:58 | |
| *** Marga_ has quit IRC | 21:59 | |
| *** Marga_ has joined #openstack-ironic | 21:59 | |
| NobodyCam | spec for a tools script for chassis level discovery (1 +2 ans a rloo +1) :) | 22:01 |
| NobodyCam | https://review.openstack.org/#/c/134866 | 22:01 |
| rloo | NobodyCam: ha ha. I see other +1's too. My +1s on the specs are somewhat weak I think. I think my votes mean more in code reviews ;) | 22:02 |
| rloo | btw, kilo-2 was cut: https://launchpad.net/ironic/+milestone/kilo-2 | 22:02 |
| mrda | gah, still have a docs failure on logical name | 22:03 |
| mrda | double gah, missed the vut | 22:03 |
| mrda | s/vut/cut/ | 22:03 |
| *** dhellmann_ has joined #openstack-ironic | 22:03 | |
| NobodyCam | :( | 22:03 |
| * mrda wonders where the nearest pub is | 22:03 | |
| rloo | mrda: yeah, sorry about that. maybe I should have +2'd it regardless... | 22:03 |
| mrda | nah, it's fine rloo. I appreciate all your help. | 22:04 |
| *** Marga_ has quit IRC | 22:04 | |
| rloo | mrda: damn that microversioning! | 22:05 |
| * mrda goes off to work out why the docs job is failing | 22:05 | |
| rloo | thx mrda. | 22:05 |
| mrda | I will say that our code is going to look pretty aweful going down this microversion path as is | 22:05 |
| *** spandhe has quit IRC | 22:06 | |
| *** spandhe has joined #openstack-ironic | 22:07 | |
| *** dhellmann_ has quit IRC | 22:08 | |
| rloo | mrda: yeah, I am wondering about that... | 22:08 |
| rloo | mrda: fwiw, I saw that error yesterday on this patch (revision 9): https://review.openstack.org/#/c/150688/ | 22:08 |
| Nisha | devananda, around? | 22:09 |
| Nisha | NobodyCam, nova FF date was today. they have put https://blueprints.launchpad.net/nova/+spec/pass-flavor-capabilities-to-ironic-virt-driver for L release...we need to get it through FFE | 22:11 |
| openstackgerrit | Jarrod Johnson proposed stackforge/pyghmi: Configure UEFI settings on Lenovo servers (WIP) https://review.openstack.org/153402 | 22:12 |
| *** Marga_ has joined #openstack-ironic | 22:16 | |
| *** Marga_ has quit IRC | 22:16 | |
| *** Marga_ has joined #openstack-ironic | 22:17 | |
| NobodyCam | Nisha: devananda's in Grenoble now for the meetup. ack. have you started the FFE process? | 22:18 |
| Nisha | No, i need to mail on mailing list? | 22:18 |
| *** ijw has joined #openstack-ironic | 22:19 | |
| *** dhellmann_ has joined #openstack-ironic | 22:20 | |
| NobodyCam | I believe that is the way to start teh process | 22:20 |
| *** ijw_ has joined #openstack-ironic | 22:21 | |
| *** mjturek1 has quit IRC | 22:22 | |
| *** ijw has quit IRC | 22:24 | |
| *** ijw_ has quit IRC | 22:25 | |
| *** jjohnson2 has quit IRC | 22:27 | |
| *** mgoddard has joined #openstack-ironic | 22:32 | |
| openstackgerrit | Kyle Stevenson proposed openstack/ironic-python-agent: Add additional logging and return results for IPA extensions https://review.openstack.org/152755 | 22:35 |
| *** Nisha has quit IRC | 22:38 | |
| *** eghobo has quit IRC | 22:38 | |
| *** Nisha has joined #openstack-ironic | 22:38 | |
| devananda | Nisha: you haev a white space error on line 88: https://review.openstack.org/#/c/141012/14/nova/virt/ironic/patcher.py,cm | 22:38 |
| devananda | Nisha: the last thing you want is another -1 for that ... | 22:39 |
| Nisha | devananda, oh...:( i will just repost the patch | 22:40 |
| *** eghobo has joined #openstack-ironic | 22:41 | |
| *** erwan_taf has quit IRC | 22:42 | |
| *** ijw has joined #openstack-ironic | 22:44 | |
| jlvillal | Nisha: On https://review.openstack.org/#/c/141012/14/nova/virt/ironic/patcher.py Is there a test for reaching line 94? | 22:45 |
| jlvillal | I only asked because I didn't understand why it was [1] vs [0] | 22:46 |
| Nisha | yes | 22:46 |
| Nisha | jlvillal, the test case test_generic_get_deploy_patch_capabilities_op handles true part of len > 1 | 22:47 |
| jlvillal | Nisha: I thought to get to line 94 it would have to be something like 'capabilities:foo egg spam' | 22:47 |
| Nisha | and test_generic_get_deploy_patch_capabilities tests for exact match | 22:47 |
| jlvillal | looking... | 22:47 |
| Nisha | the split is done on extra_specs | 22:48 |
| Nisha | not on node capabilities | 22:48 |
| *** ijw has quit IRC | 22:49 | |
| jlvillal | Nisha: ah, okay! Thanks! I understand now :) | 22:50 |
| rloo | Nisha: I think it could use some comments, maybe examples of what the capabilities strings look like. | 22:50 |
| Nisha | in code? | 22:50 |
| Nisha | rloo, capabilities in flavor supports many operators | 22:51 |
| Nisha | devananda, FYI posted the new patch for it | 22:52 |
| rloo | Nisha: comment in the code. cuz people keep asking what you're parsing there. | 22:52 |
| Nisha | ok i will just add | 22:52 |
| rloo | Nisha: and then that operator stuff showed up? <in>? So I am not reviewing/voting, cuz I don't know what is meant to be there. | 22:52 |
| Nisha | it is required for supporting uefi deploy when node gets list of values | 22:54 |
| Nisha | Flavor : extra_specs = {'capabilities:boot_mode' : '<in> uefi'} | 22:55 |
| *** mgoddard has quit IRC | 22:55 | |
| *** mgoddard has joined #openstack-ironic | 22:55 | |
| Nisha | Node : properties = {'capabilities' : 'boot_mode:bios uefi' | 22:55 |
| Nisha | Node : properties = {'capabilities' : 'boot_mode:bios uefi'} | 22:55 |
| Nisha | now the <in> operator at flavor (compute capabilities filter) searches the requested boot_mode i.e. uefi in the list of supported boot_modes on the hardware | 22:56 |
| Nisha | so basically it does | 22:57 |
| Nisha | if flavor value <in> Node capability values | 22:57 |
| rloo | NIsha: is all that stuff described in a spec? | 22:59 |
| devananda | anyone want to review 152844 ? | 22:59 |
| jroll | Nisha: so I'm a little late on this, but what happens if I don't have boot_mode in a node capabilities at all | 22:59 |
| Nisha | and flavor has? | 22:59 |
| rloo | devananda: depends on what that is. looking... | 22:59 |
| *** mgoddard has quit IRC | 22:59 | |
| jroll | Nisha: flavor has nothing | 23:00 |
| rloo | devananda: oh yeah, that was on my list. hmm, except I have only a few minutes before I have to go. will try... | 23:00 |
| devananda | rloo: cheers | 23:00 |
| Nisha | if flavor and node both doesnt has the boot_mode, then driver tries to get the pending boot mode of the system and deploys in that. if that is not set, try in uefi. if fails deploy in bios | 23:01 |
| Nisha | i.e. order is | 23:01 |
| Nisha | 1. pending boot mode | 23:01 |
| Nisha | 2. uefi | 23:01 |
| Nisha | 3. bios | 23:01 |
| jroll | huh | 23:04 |
| jroll | Nisha: is this just for ilo? | 23:04 |
| devananda | NobodyCam: you still use vbox for testing things? | 23:04 |
| jroll | devananda: I do, sometimes | 23:04 |
| openstackgerrit | Clif Houck proposed openstack/ironic-python-agent: Added support for --secure-erase-enhanced when doing an ATA secure erase https://review.openstack.org/153417 | 23:04 |
| devananda | jroll: http://docs-draft.openstack.org/07/146307/2/check/gate-ironic-docs/1970b4b//doc/build/html/drivers/vbox.html | 23:04 |
| devananda | wnodering how sane that all looks, and I dont have much experience with vbox | 23:05 |
| jroll | devananda: what about it? I don't want to set all that up | 23:05 |
| Nisha | the code changes for passing to instance info? | 23:05 |
| jroll | oh, I think I reviewed it, it seemed fine | 23:05 |
| Nisha | or the query above for boot_mode? | 23:05 |
| devananda | jroll: haha. ok, cool | 23:05 |
| devananda | I think stelfter was also interested in testing it | 23:05 |
| jroll | Nisha: what I want to know is: if I deploy this code, without changing flavors, node.properties, etc, what boot mode will ironic try to use | 23:05 |
| jroll | devananda: yeah, I just use virsh inside a virtualbox vm | 23:06 |
| Nisha | this code means here? | 23:06 |
| NobodyCam | devananda: I have switched to virsh | 23:06 |
| jroll | "this code" being all of this boot mode capabilities stuff | 23:06 |
| NobodyCam | devananda: looking | 23:07 |
| Nisha | jroll, currently boot_mode has to be configured manually | 23:07 |
| Nisha | on the node | 23:07 |
| jroll | Nisha: what is the default? | 23:07 |
| jroll | Nisha: can you point me at the code? | 23:07 |
| jroll | ironic code, that is | 23:07 |
| *** mgoddard has joined #openstack-ironic | 23:08 | |
| Nisha | jroll, https://review.openstack.org/#/c/141012 this was in discussion when you pinged | 23:08 |
| Nisha | it is just to populate the flavor capabilities to instance_info | 23:08 |
| *** mgoddard has quit IRC | 23:08 | |
| jroll | Nisha: can you point me at the ironic code that reads this? | 23:09 |
| NobodyCam | devananda: you have to set the vmname? (vbox_vmname='baremetal') | 23:09 |
| NobodyCam | I don't recall that fromthe spec ... | 23:09 |
| * NobodyCam refreshes his brain | 23:09 | |
| jroll | yeah, that was there before iirc | 23:09 |
| jroll | I think you have to do that with ssh/vbox | 23:09 |
| Nisha | from instance_info? | 23:09 |
| NobodyCam | should find the mac from the port | 23:09 |
| jroll | Nisha: yes. | 23:10 |
| Nisha | jroll, that is desired behavior correct | 23:10 |
| jroll | what | 23:10 |
| rloo | devananda: done. I don't usually review this quickly; that code better be correct :D gotta go. | 23:10 |
| Nisha | but it doesnt exist because nova doesnt populate instance_info | 23:10 |
| jroll | Nisha: where is the ironic side code for this | 23:10 |
| NobodyCam | have a good weekend rloo | 23:10 |
| *** rloo is now known as rloo_afk | 23:10 | |
| rloo_afk | thx NobodyCam, you too! | 23:11 |
| jroll | Nisha: or let me back up | 23:11 |
| JayF | I have a ... strange question | 23:11 |
| JayF | Can those who have access to physical hardware run an `hdparm -I /dev/$your_disk` | 23:11 |
| NobodyCam | I have a bazar answer | 23:11 |
| jroll | Nisha: is this to make the boot mode come from the flavor, rather than the operator? | 23:11 |
| JayF | and grep -i 'security' | 23:11 |
| Nisha | jroll, yes | 23:11 |
| JayF | then gist the result? | 23:11 |
| Nisha | boot_mode, secure_boot | 23:11 |
| jroll | Nisha: ok, is there an ironic spec for this? or code? | 23:11 |
| JayF | trying to gather data for clif_h's https://review.openstack.org/#/c/153417/1, and we don't have any disks that don't support enhanced secure erase | 23:12 |
| Nisha | rather you can say ironic would know what is being given in flavor and ironic drivers take appropriate action based on that | 23:12 |
| NobodyCam | JayF: if I have access and can boot to a usb stick I could do a lot more then that | 23:12 |
| Nisha | secure_boot is already there | 23:12 |
| Nisha | i think even lucas has local_boot depending on this | 23:12 |
| jroll | Nisha: spec/code for the instance part | 23:12 |
| Nisha | ironic side? or nova side? | 23:13 |
| Nisha | nova side i have | 23:13 |
| jroll | ironic side | 23:13 |
| jroll | is there a spec for the ironic side | 23:13 |
| JayF | NobodyCam: wdym? | 23:13 |
| jroll | JayF: https://gist.github.com/jimrollenhagen/402bb15a14483f2efad0 | 23:14 |
| Nisha | ironc side we have secure boot...atleast i can figure out link for that | 23:14 |
| jroll | JayF: that's an old crappy 10k rpm hdd | 23:14 |
| jroll | Nisha: for reading it from instance info? | 23:14 |
| NobodyCam | ahh that was on the vbox spec | 23:15 |
| JayF | jroll: mind gisting the full output for me? | 23:15 |
| Nisha | yes | 23:15 |
| jroll | JayF: https://gist.github.com/jimrollenhagen/2ecedfbbb68d97d02381 | 23:15 |
| jroll | Nisha: is it https://review.openstack.org/#/c/135845/16/specs/kilo/uefi-secure-boot-management-interfaces.rst | 23:16 |
| Nisha | https://review.openstack.org/#/c/135228/6/specs/kilo/uefi-secure-boot.rst | 23:17 |
| *** nosleep77 has quit IRC | 23:17 | |
| jroll | ok, thank you | 23:17 |
| JayF | clif_h: ^ jroll's results look like they'd be good for your patch | 23:17 |
| clif_h | its nice when assumptions work out | 23:17 |
| Nisha | Line 190 | 23:17 |
| JayF | lol | 23:17 |
| JayF | I'd love to have more data still :) | 23:17 |
| NobodyCam | devananda: that doc page is ok may be a few nits and wanting for more detail .. but all can be addressed later with another patch | 23:17 |
| devananda | NobodyCam: neat! | 23:18 |
| *** anderbubble has quit IRC | 23:20 | |
| *** chlong has joined #openstack-ironic | 23:23 | |
| *** mlsoule has quit IRC | 23:25 | |
| *** alexpilotti has quit IRC | 23:25 | |
| mrda | devananda: logical name missing K-2. Do I have to do anything for this to be accepted for K-3 now? | 23:25 |
| mrda | Nova considers K-2 feature freeze. What do we do? | 23:26 |
| devananda | mrda: it's approved, almost done, and targeted to k3 | 23:27 |
| devananda | mrda: I would be delighted if it lands, you know ,tonight or tomorrow too | 23:27 |
| devananda | slightly sad that it didn't make k2 -- that would have been cool. but it'll still be in kilo | 23:28 |
| mrda | As soon as I can work out this doc bug that is somehow related to the microversions changes made in this patch, it should land | 23:28 |
| devananda | also -- Kilo-2 is up. woot | 23:28 |
| mrda | \o/ | 23:29 |
| NobodyCam | nice | 23:29 |
| * devananda tries to digest up a change log or something | 23:29 | |
| devananda | mrda: if you're going to continue with the logical-names patch now, I'll stop poking at it | 23:30 |
| devananda | also, I share the concern that we may start seeing the code littered with little bits of versioning checks | 23:31 |
| devananda | but i haven't had the brainspace to think of a cleaner way to do that yet | 23:31 |
| mrda | let's discuss this next week :) | 23:31 |
| devananda | ++ | 23:32 |
| mrda | I'm just reviewing the 8 or so revisions pushed overnight in my absence to try and work out how the docs job broke | 23:32 |
| mrda | (and then I jump on a plane to SFO later today \o/) | 23:32 |
| *** ijw has joined #openstack-ironic | 23:33 | |
| *** EmilienM is now known as EmilienM|afk | 23:33 | |
| *** spandhe has quit IRC | 23:40 | |
| *** david-lyle is now known as david-lyle_afk | 23:41 | |
| *** spandhe has joined #openstack-ironic | 23:42 | |
| *** jmanko has joined #openstack-ironic | 23:43 | |
| NobodyCam | wow really bad lag today | 23:44 |
| NobodyCam | devananda: you still here? | 23:45 |
| devananda | NobodyCam: ya | 23:45 |
| NobodyCam | :) got a second for a spec review? you've looked at before the chassis discovery tool? https://review.openstack.org/#/c/134866 | 23:46 |
| *** jmankov has quit IRC | 23:46 | |
| *** PaulCzar has quit IRC | 23:47 | |
| *** naohirot has joined #openstack-ironic | 23:55 | |
| devananda | mrda: oh - we need support in the client for logical names, too | 23:56 |
| *** smoriya has joined #openstack-ironic | 23:56 | |
| *** openstack has joined #openstack-ironic | 23:57 | |
| NobodyCam | :) | 23:58 |
| naohirot | NobodyCam: devananda: I'm ready to fix any review comments for the next week sprint :) | 23:59 |
| NobodyCam | :) | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!