*** kragniz_ is now known as kragniz | 00:00 | |
*** smoriya has joined #openstack-ironic | 00:02 | |
*** romcheg has quit IRC | 00:13 | |
*** naohirot has joined #openstack-ironic | 00:27 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Fix ml2_conf.ini settings https://review.openstack.org/156092 | 00:29 |
---|---|---|
*** Marga_ has joined #openstack-ironic | 01:12 | |
*** maurosr has quit IRC | 01:27 | |
*** zz_jgrimm has quit IRC | 01:27 | |
*** oomichi has joined #openstack-ironic | 01:28 | |
*** achanda has joined #openstack-ironic | 01:28 | |
*** zz_jgrimm has joined #openstack-ironic | 01:31 | |
*** maurosr has joined #openstack-ironic | 01:32 | |
*** achanda has quit IRC | 01:33 | |
*** Marga__ has joined #openstack-ironic | 01:52 | |
*** Marga_ has quit IRC | 01:55 | |
*** lazy_prince has quit IRC | 02:00 | |
*** anderbubble has joined #openstack-ironic | 02:06 | |
*** anderbubble has quit IRC | 02:28 | |
openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Support i18n https://review.openstack.org/156104 | 02:37 |
*** ramineni has joined #openstack-ironic | 02:42 | |
*** achanda has joined #openstack-ironic | 02:52 | |
*** jerryz has joined #openstack-ironic | 03:09 | |
*** lazy_prince has joined #openstack-ironic | 03:15 | |
*** mjturek1 has quit IRC | 03:19 | |
*** achanda has quit IRC | 04:00 | |
openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Support i18n part2 https://review.openstack.org/156115 | 04:07 |
openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Support i18n part3 https://review.openstack.org/156119 | 04:30 |
*** pradipta has joined #openstack-ironic | 04:40 | |
*** pensu has joined #openstack-ironic | 04:54 | |
*** achanda has joined #openstack-ironic | 05:00 | |
*** achanda has quit IRC | 05:06 | |
openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Support i18n part2 https://review.openstack.org/156115 | 05:45 |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: Automate boot iso creation with in ironic for iscsi-ilo https://review.openstack.org/155900 | 05:58 |
openstackgerrit | Merged stackforge/proliantutils: Add hpssa module to proliantutils https://review.openstack.org/153519 | 06:02 |
*** oomichi has quit IRC | 06:13 | |
*** achanda has joined #openstack-ironic | 06:13 | |
*** marios_ has joined #openstack-ironic | 06:27 | |
*** rameshg87 has joined #openstack-ironic | 06:32 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Imported Translations from Transifex https://review.openstack.org/155970 | 06:32 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 06:32 |
*** faizan has joined #openstack-ironic | 06:33 | |
openstackgerrit | Nisha Agarwal proposed openstack/python-ironicclient: enhanced node-set-provision-state https://review.openstack.org/148804 | 06:42 |
*** yog__ has joined #openstack-ironic | 06:42 | |
*** achanda has quit IRC | 06:45 | |
*** lazy_prince has quit IRC | 06:49 | |
*** dlpartain has joined #openstack-ironic | 06:49 | |
dtantsur | Morning Ironic! | 06:49 |
*** killer_prince has joined #openstack-ironic | 06:50 | |
*** killer_prince is now known as lazy_prince | 06:50 | |
*** dlpartain has left #openstack-ironic | 06:53 | |
*** achanda has joined #openstack-ironic | 07:04 | |
*** andreykurilin_ has joined #openstack-ironic | 07:13 | |
*** Marga__ has quit IRC | 07:17 | |
*** pradipta has quit IRC | 07:31 | |
*** andreykurilin_ has quit IRC | 07:35 | |
openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Don't wait for too long for IPMI credentials update https://review.openstack.org/156144 | 07:51 |
*** chlong has quit IRC | 07:51 | |
*** yog__ has quit IRC | 07:57 | |
*** kbs has quit IRC | 08:07 | |
*** jistr has joined #openstack-ironic | 08:08 | |
*** jcoufal has joined #openstack-ironic | 08:10 | |
*** kbs has joined #openstack-ironic | 08:10 | |
*** yog__ has joined #openstack-ironic | 08:11 | |
*** achanda has quit IRC | 08:18 | |
*** gillllliard is now known as gilliard | 08:18 | |
*** yuanying has quit IRC | 08:24 | |
*** kbs has quit IRC | 08:27 | |
*** achanda has joined #openstack-ironic | 08:28 | |
*** achanda has quit IRC | 08:35 | |
*** vdrok_afk is now known as vdrok | 08:36 | |
vdrok | morning ironic | 08:36 |
vdrok | morning dtantsur | 08:36 |
*** kbs has joined #openstack-ironic | 08:38 | |
yuriyz | morning Ironic | 08:39 |
*** achanda has joined #openstack-ironic | 08:40 | |
*** ifarkas has joined #openstack-ironic | 08:47 | |
openstackgerrit | Anusha Ramineni proposed openstack/ironic: Update Ilo drivers to use REST API interface to iLO https://review.openstack.org/154403 | 08:50 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Support for non-Glance image references https://review.openstack.org/136741 | 08:52 |
openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Also set IPMI address if it's not set already https://review.openstack.org/156156 | 08:55 |
*** jiangfei has quit IRC | 08:57 | |
dtantsur | ifarkas, hey, could you review this patch chain ^^^ ? | 08:57 |
*** openstackgerrit has quit IRC | 08:57 | |
*** openstackgerrit has joined #openstack-ironic | 08:58 | |
ifarkas | dtantsur, hi, sure, I will do it probably later today | 08:58 |
*** viktors has joined #openstack-ironic | 08:58 | |
*** ndipanov has joined #openstack-ironic | 08:59 | |
*** jistr has quit IRC | 08:59 | |
*** lucasagomes has joined #openstack-ironic | 09:01 | |
*** achanda has quit IRC | 09:02 | |
*** zhenzanz has quit IRC | 09:02 | |
*** romcheg has joined #openstack-ironic | 09:04 | |
*** kbs1 has joined #openstack-ironic | 09:07 | |
dtantsur | ack | 09:08 |
*** kbs has quit IRC | 09:08 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add driver interface for RAID configuration https://review.openstack.org/155230 | 09:09 |
*** lazy_prince is now known as killer_prince | 09:12 | |
*** kbs1 has quit IRC | 09:12 | |
*** achanda has joined #openstack-ironic | 09:12 | |
*** kbs has joined #openstack-ironic | 09:16 | |
*** lsmola has joined #openstack-ironic | 09:20 | |
*** achanda has quit IRC | 09:23 | |
*** kbs has quit IRC | 09:26 | |
*** mgoddard has joined #openstack-ironic | 09:31 | |
*** pas-ha has joined #openstack-ironic | 09:37 | |
*** erwan_taf has quit IRC | 09:43 | |
*** erwan_taf has joined #openstack-ironic | 09:43 | |
*** kbs has joined #openstack-ironic | 09:44 | |
*** athomas has joined #openstack-ironic | 09:46 | |
*** pas-ha has quit IRC | 09:50 | |
openstackgerrit | Anusha Ramineni proposed openstack/ironic: Add tests for ilo_deploy driver https://review.openstack.org/142985 | 09:52 |
*** sambetts has joined #openstack-ironic | 09:53 | |
*** erwan_taf has quit IRC | 10:03 | |
*** pas-ha has joined #openstack-ironic | 10:05 | |
*** Nisha has joined #openstack-ironic | 10:08 | |
Nisha | dtantsur, hi | 10:08 |
dtantsur | o/ | 10:08 |
Nisha | dtantsur, regarding InspectInterface's method inspect_hardware() return value | 10:10 |
dtantsur | Nisha, https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1502-L1508 may answer your question :) | 10:10 |
dtantsur | that's what we do when we need to handle both in-band and OOB | 10:11 |
*** ifarkas has quit IRC | 10:11 | |
Nisha | dtantsur, but in case is it INSPECTING, we dont have a wait state? | 10:12 |
dtantsur | Nisha, we can use INSPECTING for that. So if new_state == INSPECTING, just wait | 10:12 |
Nisha | dtantsur, means to say we dont have any verb as wait | 10:13 |
Nisha | what action shall i do when it is inspecting | 10:13 |
dtantsur | Nisha, just return | 10:13 |
dtantsur | and then either driver will handle finishing or it will time out eventually | 10:13 |
*** ifarkas has joined #openstack-ironic | 10:14 | |
Nisha | plus it means that we will either have to remove the transition from INSPECTED -> INSPECTING or add a transition from INSPECTING->MANAGEABLE | 10:14 |
Nisha | how does conductor knows and put the state correctly in provision_state | 10:15 |
Nisha | say if driver handles it, then conductor must know that it has successfully done | 10:16 |
Nisha | to correctly reflect the state | 10:16 |
dtantsur | Nisha, why& | 10:16 |
dtantsur | ? | 10:16 |
dtantsur | (and there should not be transition from INSPECTED -> INSPECTING, only the opposite) | 10:17 |
Nisha | sorry that was a typo.... | 10:17 |
Nisha | ok if conductor just returns in case it is inband, what it shall set in provision state and target provision state | 10:18 |
*** erwan_taf has joined #openstack-ironic | 10:18 | |
Nisha | or it should leave the states as it is? | 10:18 |
dtantsur | Nisha, yes, please leave them. Driver must handle transitions in this case. | 10:19 |
Nisha | ohk. and i was updating the last_inspected in case of successful inspection when transiting from INSPECTING to INSPECTED | 10:20 |
Nisha | will the driver take care of it also? | 10:21 |
dtantsur | yes, it has to | 10:22 |
*** pradipta has joined #openstack-ironic | 10:25 | |
*** MattMan has joined #openstack-ironic | 10:29 | |
*** killer_prince is now known as lazy_prince | 10:30 | |
*** pelix has joined #openstack-ironic | 10:41 | |
*** Nisha has quit IRC | 10:45 | |
openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Update functest to new ramdisk code https://review.openstack.org/156179 | 10:49 |
rameshg87 | dtantsur, hi, one question | 10:58 |
dtantsur | yep | 10:58 |
rameshg87 | dtantsur, https://review.openstack.org/#/c/155230/4/ironic/api/controllers/v1/node.py | 10:58 |
rameshg87 | dtantsur, why not use body=types.jsontype instead of body={wtypes.text: types.jsontype} | 10:59 |
rameshg87 | dtantsur, is body={wtypes.text: types.jsontype} better than body=types.jsontype ? | 10:59 |
dtantsur | rameshg87, if you're ok with body being e.g. a list - yes :) | 10:59 |
rameshg87 | dtantsur, oh | 11:00 |
rameshg87 | dtantsur, okay .. got it | 11:00 |
rameshg87 | dtantsur, thanks .. :) | 11:00 |
dtantsur | np) | 11:00 |
rameshg87 | dtantsur, to a certain level schema does the same validation too | 11:01 |
dtantsur | yeah, you can rely on it too | 11:01 |
rameshg87 | dtantsur, don't know how much we want to catch the error in wsme | 11:01 |
rameshg87 | dtantsur, because schema error messages seem to make more sense | 11:01 |
rameshg87 | dtantsur, schema can call out 'logical_disks' is missing :) | 11:02 |
dtantsur | I'm find with both, though assumption that top-level is a dict sounds fine to me too | 11:02 |
rameshg87 | dtantsur, okay. i think i will go with body=types.jsontypes for now .. | 11:02 |
dtantsur | I mean, if user provides a list, it's useless to do schema validation at all :) | 11:02 |
dtantsur | ack | 11:02 |
rameshg87 | dtantsur, yeah it would require conductor to do it for you | 11:03 |
rameshg87 | dtantsur, instead of catching it in api | 11:03 |
rameshg87 | dtantsur, that's a difference | 11:03 |
dtantsur | ok | 11:03 |
*** pensu has quit IRC | 11:04 | |
*** marios has quit IRC | 11:06 | |
*** ramineni has quit IRC | 11:10 | |
rameshg87 | lucasagomes, can you please have a look at inband raid configuration spec: https://review.openstack.org/#/c/147803/ | 11:14 |
*** marios has joined #openstack-ironic | 11:16 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add driver interface for RAID configuration https://review.openstack.org/155230 | 11:17 |
*** rameshg87 has quit IRC | 11:18 | |
*** athomas has quit IRC | 11:23 | |
*** derekh has joined #openstack-ironic | 11:23 | |
*** yuikotakada has joined #openstack-ironic | 11:29 | |
yuikotakada | Good evening, Ironic :) | 11:30 |
openstackgerrit | Victor Sergeyev proposed openstack/ironic: Run tests in py33 environment https://review.openstack.org/156192 | 11:33 |
lucasagomes | yuikotakada, g'evening | 11:38 |
yuikotakada | lucasagomes, Hi, long time no see :D | 11:41 |
lucasagomes | yuikotakada, long time indeed! How are you? | 11:44 |
*** athomas has joined #openstack-ironic | 11:45 | |
dtantsur | yuikotakada, g'evening! | 11:48 |
yuikotakada | lucasagomes, so fine! and you?? you also look fine because you're contributing active! | 11:49 |
yuikotakada | dtantsur, Hi! good evening! And thank you for reviewing my patch, I'm fixing now :D | 11:50 |
dtantsur | yeah, thanks a lot for working on it. I would never find time :) | 11:50 |
sambetts | Morning dtantsur, lucasagomes | 11:52 |
dtantsur | morning! | 11:53 |
lucasagomes | yuikotakada, all is well over there (: | 11:53 |
lucasagomes | sambetts, yo, morning | 11:53 |
lucasagomes | s/there/here | 11:53 |
yuikotakada | dtantsur, I will contribute more and more, so let's work hard together ;) | 11:54 |
yuikotakada | lucasagomes, nice :) Don't you have any other job except for OpenStack contribution? | 11:57 |
*** andreykurilin_ has joined #openstack-ironic | 11:59 | |
lucasagomes | yuikotakada, I work mostly upstream on openstack, like 80% of the time I'd say | 11:59 |
dtantsur | yuikotakada, awesome \o/ | 12:01 |
dtantsur | :) | 12:01 |
yuikotakada | lucasagomes, Do you find your task by yourself? Or assigned by your company? | 12:04 |
lucasagomes | yuikotakada, hmm both I would say, I try to align what needs to be done upstream to what the company needs too | 12:05 |
yuikotakada | dtantsur, there are a lot of things which are first time to me, so I might trouble you, but I'll do my best | 12:05 |
dtantsur | no problem at all :) | 12:08 |
yuikotakada | lucasagomes, it's ideal :) I want to be so | 12:11 |
lucasagomes | yuikotakada, yeah, sometimes can be trick too. But overall it's working fine | 12:12 |
yuikotakada | dtantsur, is there any plan to merge ironic-discoverd to Ironic? I don't know the circumstances why ironic-discoverd is an independent stackforge project. | 12:14 |
dtantsur | yuikotakada, I think people are pretty ok with them being separate. It's like that because back in Juno cycle we decided that it's too tricky to implement it in Ironic tree. Now we have plans to _use_ ironic-discoverd from within Ironic: http://specs.openstack.org/openstack/ironic-specs/specs/kilo/inband-properties-discovery.html | 12:15 |
*** pensu has joined #openstack-ironic | 12:17 | |
dtantsur | it's like Ironic was separated from Nova (it used to be nova-baremetal thingy): it's too complex on it's own already :) | 12:17 |
dtantsur | lucasagomes, wdyt on ^^^ | 12:17 |
lucasagomes | dtantsur, hmm, haven't thought much about it. For now at least I think it's fine being a separated project (perhaps we should move it under openstack/ later on) | 12:20 |
dtantsur | yeah, people tend to think too much about stackforge/ prefix :( while actually it has 0 essential difference from openstack/ one | 12:20 |
dtantsur | anyway we have to ask devananda :) | 12:21 |
lucasagomes | yeah, just a namespace | 12:24 |
*** smoriya has quit IRC | 12:25 | |
*** andreykurilin_ has quit IRC | 12:25 | |
*** andreykurilin_ has joined #openstack-ironic | 12:26 | |
sambetts | right now I think that the stackforge is being overused for some things tbh its getting pretty full, for instance the neutron plugin/driver decomposition things, I think should have a different namespace | 12:26 |
yuikotakada | dtantsur, I'm not sure weather implementing ironic-discoverd in Ironic tree is tricky or not... but it looks like a plugin :) | 12:26 |
dtantsur | sambetts, do you think discoverd belongs to openstack/ or stackforge/ ? | 12:27 |
dtantsur | yuikotakada, I guess the biggest concern was a way how discoverd enables PXE booting. Ironic is using Neutron, discoverd can't use Neutron here and uses firewall to rule statically configured DHCP. | 12:28 |
dtantsur | yuikotakada, also now discoverd has it's own plugins, so it would be plugin with plugins :D | 12:28 |
sambetts | dtantsur: I would like to see a different namespace tbh, like a related projects one if its not core but also not a experimental project either | 12:31 |
dtantsur | sambetts, I think it's exactly what stackforge is about :) experimental projects should leave in their author's github IMO | 12:32 |
yuikotakada | does "experimental" mean "not stable"? if so, I understand. This feature itself is very useful and attractive, so everyone who are using Ironic want to use | 12:35 |
*** kbyrne has joined #openstack-ironic | 12:37 | |
dtantsur | right, a lot of people requested it to be implemented. anyway, OpenStack governance rules are being changed this cycle, we'll see how it ends up. | 12:38 |
sambetts | the stackforge is full of young/undeveloped projects around OpenStack, which I think make it difficult to find projects like ironic-discoverd | 12:38 |
dtantsur | hmm... maybe. though e.g. Fuel lives in stackforge as well, and it must be a pretty mature project | 12:39 |
sambetts | yeah, thinks like that I personally feel need a non-core but graduated namespace to live in | 12:41 |
sambetts | s/thinks/things | 12:41 |
sambetts | but I guess having one big area makes it much easier on infra | 12:42 |
*** dprince has joined #openstack-ironic | 12:42 | |
dtantsur | it's also a good point | 12:42 |
*** derekh has quit IRC | 12:46 | |
*** derekh has joined #openstack-ironic | 12:46 | |
*** dprince_ has joined #openstack-ironic | 12:47 | |
*** Marga_ has joined #openstack-ironic | 12:47 | |
*** dprince has quit IRC | 12:47 | |
*** humble_ has joined #openstack-ironic | 12:51 | |
*** pas-ha has quit IRC | 12:57 | |
*** lazy_prince is now known as killer_prince | 13:03 | |
*** pas-ha has joined #openstack-ironic | 13:09 | |
*** jcoufal_ has joined #openstack-ironic | 13:10 | |
*** lucasagomes is now known as lucas-hungry | 13:10 | |
*** jcoufal has quit IRC | 13:13 | |
openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Adds support for deploying whole disk images https://review.openstack.org/150142 | 13:14 |
*** dprince_ has quit IRC | 13:14 | |
*** dprince has joined #openstack-ironic | 13:14 | |
*** EmilienM is now known as EmilienM|afk | 13:20 | |
*** mlsoule has joined #openstack-ironic | 13:21 | |
*** yog__ has quit IRC | 13:27 | |
*** coolsvap- is now known as coolsvap | 13:27 | |
*** mlsoule has left #openstack-ironic | 13:34 | |
*** mjturek1 has joined #openstack-ironic | 13:44 | |
*** lucas-hungry is now known as lucasagomes | 13:50 | |
*** mjturek1 has quit IRC | 13:51 | |
*** mjturek1 has joined #openstack-ironic | 13:52 | |
openstackgerrit | Victor Sergeyev proposed openstack/ironic: Run tests in py33 environment https://review.openstack.org/156192 | 13:54 |
*** andreykurilin_ has quit IRC | 13:56 | |
*** andreykurilin_ has joined #openstack-ironic | 13:56 | |
*** Marga_ has quit IRC | 13:59 | |
*** pensu has quit IRC | 14:03 | |
*** dprince has quit IRC | 14:08 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 14:11 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 14:14 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 14:17 |
*** faizan has quit IRC | 14:18 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 14:20 |
*** rameshg87 has joined #openstack-ironic | 14:23 | |
*** vdrok is now known as vdrok_afk | 14:27 | |
*** yuikotakada has quit IRC | 14:33 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: BaseAgentVendor: Invoke the driver vendor interface from task https://review.openstack.org/156233 | 14:34 |
rameshg87 | lucasagomes, hi | 14:42 |
rameshg87 | lucasagomes, regarding https://review.openstack.org/#/c/156233/1 | 14:42 |
lucasagomes | rameshg87, hi there | 14:43 |
lucasagomes | what's up? | 14:43 |
rameshg87 | lucasagomes, i had noticed some kind of a problem like this when calling passthrus | 14:44 |
rameshg87 | lucasagomes, i could find this part of the code had some problem | 14:44 |
rameshg87 | lucasagomes, https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L445-L457 | 14:44 |
rameshg87 | lucasagomes, specifically https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L456-L457 | 14:45 |
lucasagomes | rameshg87, right, you found it out when working on some iLO passthrus? like 2 methods with the same name ? | 14:45 |
* rameshg87 is figuring out the code .. | 14:47 | |
lucasagomes | yeah, it took me 2 hours + to figure that out | 14:47 |
lucasagomes | maybe it's something we can fix on the @passthru | 14:48 |
* lucasagomes looks more into it | 14:48 | |
rameshg87 | lucasagomes, yes, i actually know some sort of a fix .. even i took a long time figuring out | 14:48 |
lucasagomes | rameshg87, ah, if you can point me I can test it here | 14:48 |
rameshg87 | lucasagomes, we were trying to have an extended version of AgentVendorInterface for some reason | 14:49 |
*** dprince has joined #openstack-ironic | 14:49 | |
rameshg87 | lucasagomes, we were trying to extend the method reboot_to_instance() in our IloAgentVendorInterface | 14:49 |
lucasagomes | rameshg87, yeah, that's what I'm trying to do with the BaseAgentVendor | 14:49 |
lucasagomes | rameshg87, I see | 14:49 |
rameshg87 | lucasagomes, we wanted heartbeat() to call IloAgentVendorInterface.reboot_to_instance() | 14:50 |
rameshg87 | lucasagomes, but instead it was always calling AgentVendorInterface.reboot_to_instance() because 'self' was actually wrong | 14:50 |
lucasagomes | yeah that's exactly what I'm doing... reboot_to_instance(), continue_deploy() and deploy_is_done() is overwrittable | 14:50 |
rameshg87 | lucasagomes, okay | 14:51 |
lucasagomes | rameshg87, yeah, exactly | 14:51 |
rameshg87 | lucasagomes, let me see if i can dig up that patch | 14:51 |
rameshg87 | lucasagomes, i have it somewhere | 14:51 |
lucasagomes | rameshg87, cool, I will take a look too | 14:51 |
rameshg87 | lucasagomes, i wanted to a file a bug, but then i lost it | 14:51 |
lucasagomes | :( | 14:51 |
rameshg87 | lucasagomes, i mean i forgot to do it | 14:51 |
rameshg87 | lucasagomes, it was last week or something | 14:51 |
lucasagomes | I see, yeah it's super tricky | 14:52 |
lucasagomes | I spend my morning trying to figure out what was going on | 14:52 |
jroll | I mean, that's just python | 14:52 |
jroll | right? | 14:52 |
lucasagomes | pretty much | 14:52 |
lucasagomes | we are overwritten __new__ which is a bit blackmagicish | 14:53 |
jroll | like, you can't make a thing call into it's subclass without a giant hack | 14:53 |
lucasagomes | yeah | 14:53 |
rameshg87 | lucasagomes, just give me some time, let me see if i can get a patch which worked for me .. | 14:53 |
lucasagomes | rameshg87, no worries | 14:55 |
lucasagomes | to be honest I wasn't expecting people would inherit from other's driver's vendor interface | 14:55 |
lucasagomes | but yeah... | 14:55 |
lucasagomes | jroll, morning btw | 14:56 |
*** killer_prince is now known as lazy_prince | 14:56 | |
*** yog__ has joined #openstack-ironic | 14:56 | |
jroll | oh hey morning lucasagomes :D | 14:56 |
*** jjohnson2 has joined #openstack-ironic | 15:01 | |
dtantsur | jroll, o/ | 15:01 |
jroll | morning dtantsur rameshg87 :) | 15:02 |
rameshg87 | jroll, o/ | 15:02 |
*** humble_ has quit IRC | 15:03 | |
*** zz_jgrimm is now known as jgrimm | 15:04 | |
*** ukalifon1 has joined #openstack-ironic | 15:08 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Vendorpassthru doesn't get correct 'self' https://review.openstack.org/156244 | 15:10 |
rameshg87 | lucasagomes, ^^^ | 15:10 |
rameshg87 | lucasagomes, let me know what you think and if it solves the problem that you were facing | 15:10 |
lucasagomes | rameshg87, cool, lemme test it | 15:11 |
rameshg87 | lucasagomes, the problem i found was that metadata['func'] was getting overwritten at some point later that is not in Ironic's control because (i think) we used up the reference that functools gave | 15:11 |
rameshg87 | lucasagomes, i just copied the dict to my own and modified that, and it seemed to solve the problem | 15:12 |
*** Nisha has joined #openstack-ironic | 15:12 | |
rameshg87 | lucasagomes, but i am not sure why/where it was getting modified (again not inside Ironic, that's what i was able to find) | 15:13 |
*** beekneemech is now known as bnemec | 15:13 | |
lucasagomes | rameshg87, right, thanks for that :D | 15:13 |
jroll | man, bmcs are the worst | 15:13 |
*** rameshg87 is now known as rameshg87-dinner | 15:14 | |
lucasagomes | jroll, lol whats up? | 15:15 |
jroll | lucasagomes: not this BMC :D | 15:15 |
NobodyCam | Good mornig Ironicer | 15:15 |
NobodyCam | lol Ironicers even | 15:15 |
lucasagomes | NobodyCam, yo | 15:15 |
NobodyCam | morning lucasagomes :) | 15:15 |
jroll | morning NobodyCam | 15:15 |
NobodyCam | morning jroll | 15:15 |
*** EmilienM|afk is now known as EmilienM | 15:16 | |
Nisha | NobodyCam, morning | 15:16 |
NobodyCam | morning Nisha :) | 15:16 |
lucasagomes | rameshg87-dinner, as a first stab, ur patch seems to fix the problem yes | 15:17 |
lucasagomes | rameshg87-dinner, it makes sense, because on the base class the _vendor_metadata will exist on the second time it's being instantiate | 15:19 |
lucasagomes | so it will add that metadata on the new instance | 15:19 |
lucasagomes | rameshg87-dinner, I will abandon my patch in favor of ur's | 15:20 |
*** rameshg87-dinner is now known as rameshg87 | 15:22 | |
lucasagomes | but the metadata comes from the first instance | 15:22 |
rameshg87 | lucasagomes, but this seems to handle that https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L456 | 15:23 |
rameshg87 | lucasagomes, pointing 'func' to the correct inherited method | 15:23 |
lucasagomes | rameshg87, metadata is a dict | 15:24 |
lucasagomes | we are passing the reference inst.vendor_routes.update({vmeta.method: vmeta.metadata}) | 15:24 |
lucasagomes | so if later on that dict is modified, it will modify it across all instances | 15:24 |
lucasagomes | that's why copy() makes sense | 15:24 |
*** naohirot has quit IRC | 15:24 | |
lucasagomes | so each vendor_routes will get a different copy | 15:24 |
rameshg87 | lucasagomes, but when is vmeta.metadata dict modified ? | 15:25 |
lucasagomes | rameshg87, when the class is instantiated for the second time | 15:25 |
rameshg87 | lucasagomes, okay. | 15:26 |
rameshg87 | lucasagomes, correct me if i am wrong | 15:26 |
rameshg87 | lucasagomes, this is the first time we instantiate it, right ? - https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L446 | 15:26 |
openstackgerrit | Ryan Moore proposed openstack/ironic: Correctly rebuild the PXE file during takeover of ACTIVE nodes https://review.openstack.org/155460 | 15:26 |
openstackgerrit | Ryan Moore proposed openstack/ironic: Don't write PXE config file during takeover https://review.openstack.org/156250 | 15:26 |
lucasagomes | rameshg87, https://github.com/openstack/ironic/blob/master/ironic/drivers/agent.py#L43 | 15:27 |
lucasagomes | we instantiate the same class many times when building the drivers | 15:27 |
rameshg87 | lucasagomes, oh | 15:27 |
lucasagomes | but, since they were always using the same func for all drivers | 15:27 |
lucasagomes | we never detected that | 15:27 |
rameshg87 | lucasagomes, so this was getting overwritten back to parent's func when it was instantiated next time | 15:28 |
lucasagomes | but in reallity they were all pointing to the func of the last instantiated object | 15:28 |
lucasagomes | rameshg87, yes | 15:28 |
lucasagomes | now that we inherited from a base class | 15:28 |
lucasagomes | we can get that unexpected behavior | 15:28 |
lucasagomes | because the func's are not the same anymore | 15:28 |
rameshg87 | lucasagomes, yeah, may be we need a strong test case for this .. | 15:29 |
rameshg87 | :) | 15:29 |
lucasagomes | that's why you could be accessing a func ref from driver X on driver Y | 15:29 |
lucasagomes | rameshg87, yeah, that would be good | 15:29 |
rameshg87 | i mean unit test .. | 15:29 |
lucasagomes | right, yeah, that would help | 15:29 |
lucasagomes | if we instantiate a class twice, make sure the maps point to different references | 15:29 |
rameshg87 | lucasagomes, yeah .. and when we inherit checking if we actually call child's method (as opposed to parent's method) | 15:30 |
lucasagomes | yeah | 15:30 |
rameshg87 | lucasagomes, i mean child's method gets called | 15:30 |
lucasagomes | very tricky :) | 15:30 |
rameshg87 | lucasagomes, indeed | 15:30 |
rameshg87 | :) | 15:30 |
lucasagomes | but cool to find those very hidden bugs :D | 15:30 |
*** anderbubble has joined #openstack-ironic | 15:31 | |
lucasagomes | apart from the part that I was thinking I was crazy | 15:31 |
rameshg87 | :) | 15:31 |
rameshg87 | lucasagomes, i will pursue this tomorrow then .. you are welcome to take over if you want to get something merged before that :) | 15:32 |
lucasagomes | rameshg87, cool, yeah I'm still working on the IPA part. If I finish the tests etc for that today I take over | 15:32 |
lucasagomes | rameshg87, thanks | 15:33 |
rameshg87 | lucasagomes, sure..thanks .. | 15:33 |
lucasagomes | I will put a dependency on that patch anyway | 15:33 |
lucasagomes | as a dependency* | 15:33 |
rameshg87 | okay | 15:34 |
rameshg87 | lucasagomes, NobodyCam, if you get some time, please have a look at inband raid configuration spec: https://review.openstack.org/#/c/147803/. it's parent got merged, waiting for the implementation of that interface :) | 15:37 |
*** Nisha has quit IRC | 15:38 | |
*** rameshg87 has quit IRC | 15:47 | |
*** Nisha has joined #openstack-ironic | 15:50 | |
NobodyCam | will have a look.. but have to run and pick up the kids | 15:55 |
NobodyCam | bbiafm | 15:55 |
Nisha | jroll, hi | 15:56 |
jroll | hey Nisha :) | 15:56 |
Nisha | :) | 15:56 |
Nisha | jroll, please check this http://logs.openstack.org/04/148804/3/check/gate-python-ironicclient-python26/2485e51/console.html | 15:56 |
Nisha | I am sure this has nothing to do with my patch but my jenkins are failing even on latest branch. | 15:57 |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add driver interface for RAID configuration https://review.openstack.org/155230 | 15:58 |
*** jistr has joined #openstack-ironic | 15:58 | |
jroll | Nisha: hrm | 15:58 |
* jroll takes a look | 15:59 | |
*** david-lyle_afk is now known as david-lyle | 16:01 | |
jroll | Nisha: only your new test is failing, you need to set args.config_drive = None in your test | 16:02 |
jroll | Nisha: otherwise args.config_drive is an instance of mock.Mock, which will pass the "if args.config_drive" check | 16:03 |
Nisha | ok | 16:04 |
Nisha | but by defauly config_drive shall be none correct | 16:06 |
jroll | in normal usage, yes, but since args is a mock it doesn't work that way | 16:07 |
*** jerryz has quit IRC | 16:08 | |
*** pradipta has quit IRC | 16:09 | |
*** jgrimm is now known as zz_jgrimm | 16:11 | |
*** zz_jgrimm is now known as jgrimm | 16:12 | |
lucasagomes | check-tempest-dsvm-ironic-parallel-nv is now voting!?! | 16:22 |
jroll | o.o | 16:22 |
lucasagomes | wtf | 16:22 |
lucasagomes | https://review.openstack.org/#/c/156244/ | 16:23 |
lucasagomes | it has been failing for a long time, it def should be non-voting | 16:23 |
openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Getting ready for inclusion into projects.yaml https://review.openstack.org/156265 | 16:26 |
jroll | I don't see why it would be voting in project-config :/ | 16:26 |
*** zigo has quit IRC | 16:26 | |
*** lazy_prince is now known as killer_prince | 16:28 | |
*** zigo has joined #openstack-ironic | 16:31 | |
*** jistr has quit IRC | 16:32 | |
openstackgerrit | Merged stackforge/ironic-discoverd: Getting ready for inclusion into projects.yaml https://review.openstack.org/156265 | 16:37 |
*** Marga_ has joined #openstack-ironic | 16:37 | |
lucasagomes | jroll, using regex to determine what votes and what not across all projects sounds dangerous | 16:41 |
lucasagomes | lol | 16:41 |
jroll | :P | 16:41 |
* jroll bbl | 16:41 | |
victor_lowther | Good morning, Ironic. | 16:44 |
*** pensu has joined #openstack-ironic | 16:45 | |
*** absubram has joined #openstack-ironic | 16:46 | |
*** davideagnello has joined #openstack-ironic | 16:46 | |
openstackgerrit | Nisha Agarwal proposed openstack/python-ironicclient: enhanced node-set-provision-state https://review.openstack.org/148804 | 16:47 |
victor_lowther | So, I have this problem with node vendor passthru methods. | 16:48 |
victor_lowther | Namely, that there does not seem to be a way to have them return the HTTP status code of my choosing | 16:49 |
NobodyCam | mornign victor_lowther :) | 16:49 |
victor_lowther | This is slightly annoying when I have to deal with an operation that can operate either synchronusly or asynchronusly debelding on the exact values it is operating on. | 16:50 |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: Add InspectInterface for node-introspection https://review.openstack.org/149817 | 16:50 |
victor_lowther | er, depending. | 16:50 |
Nisha | Need reviews on inspection patches | 16:51 |
Nisha | :( | 16:51 |
victor_lowther | ifarkas: if you could give a review of https://review.openstack.org/#/c/150488/, that would be awesome. | 16:52 |
ifarkas | victor_lowther, will do! | 16:52 |
lucasagomes | victor_lowther, that may need some work, right now I think it only returns 200 or 202 depending if it's sync or async | 16:52 |
lucasagomes | victor_lowther, we could include another metadata on the @passthru decorators | 16:53 |
lucasagomes | including the return code if success | 16:53 |
lucasagomes | victor_lowther, and morning :) | 16:53 |
victor_lowther | That only gets me part of the way there | 16:55 |
lucasagomes | victor_lowther, https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L725 | 16:55 |
lucasagomes | victor_lowther, https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L485 | 16:56 |
*** ukalifon1 has quit IRC | 16:56 | |
victor_lowther | My specific issue is that some BIOS settings on Dell systems require a reboot (and hence require creating a config job to acutally set), and some can be set immediately. | 16:58 |
victor_lowther | So the set_config function in https://review.openstack.org/#/c/150488/13/ironic/drivers/modules/drac/bios.py,unified needs to be able to indicate both conditions | 16:58 |
victor_lowther | I am doing that with a boolean that indicates whether a BIOS config job needs to be scheduled or not. | 16:59 |
victor_lowther | I would rather do it with real HTTP status codes | 17:00 |
lucasagomes | right | 17:02 |
*** coolsvap is now known as coolsvap_ | 17:14 | |
*** athomas has quit IRC | 17:25 | |
*** kbs has quit IRC | 17:25 | |
*** pcrews has quit IRC | 17:25 | |
*** dtantsur has quit IRC | 17:25 | |
*** tonyb has quit IRC | 17:25 | |
*** vdrok_afk has quit IRC | 17:25 | |
*** Madasi has quit IRC | 17:25 | |
*** JoshNang has quit IRC | 17:25 | |
*** keekz has quit IRC | 17:25 | |
*** Marga_ has quit IRC | 17:31 | |
*** athomas has joined #openstack-ironic | 17:31 | |
*** kbs has joined #openstack-ironic | 17:31 | |
*** pcrews has joined #openstack-ironic | 17:31 | |
*** dtantsur has joined #openstack-ironic | 17:31 | |
*** tonyb has joined #openstack-ironic | 17:31 | |
*** vdrok_afk has joined #openstack-ironic | 17:31 | |
*** Madasi has joined #openstack-ironic | 17:31 | |
*** JoshNang has joined #openstack-ironic | 17:31 | |
*** keekz has joined #openstack-ironic | 17:31 | |
*** mkerrin has quit IRC | 17:39 | |
*** andreykurilin_ has quit IRC | 17:40 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: Generic changes for Node Inspection https://review.openstack.org/149823 | 17:42 |
*** jrist has quit IRC | 17:46 | |
*** romcheg has quit IRC | 17:49 | |
*** romcheg has joined #openstack-ironic | 17:49 | |
openstackgerrit | Chris Krelle proposed openstack/ironic: Correctly rebuild the PXE file during takeover of ACTIVE nodes https://review.openstack.org/155460 | 17:51 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Fix file permissions in project https://review.openstack.org/156305 | 17:52 |
Shrews | NobodyCam: anyone had a chance to test 155460 yet? | 17:54 |
*** pas-ha has quit IRC | 17:56 | |
*** dtantsur is now known as dtantsur|afk | 17:56 | |
*** jcoufal_ has quit IRC | 17:57 | |
*** jrist has joined #openstack-ironic | 17:59 | |
*** MattMan has left #openstack-ironic | 18:01 | |
*** Marga_ has joined #openstack-ironic | 18:03 | |
*** athomas has quit IRC | 18:05 | |
*** EmilienM is now known as EmilienM|afk | 18:07 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add AgentVendorPasshtru for the PXE driver https://review.openstack.org/155728 | 18:14 |
*** coolsvap_ is now known as coolsvap | 18:25 | |
*** romcheg has joined #openstack-ironic | 18:28 | |
*** pensu has quit IRC | 18:29 | |
sambetts | night ironic | 18:35 |
lucasagomes | sambetts, night | 18:36 |
lucasagomes | I'm going too, see y'all tomorrow | 18:36 |
*** lucasagomes is now known as lucas-dinner | 18:36 | |
NobodyCam | night lucas-dinner | 18:39 |
NobodyCam | :) | 18:40 |
*** andreykurilin_ has joined #openstack-ironic | 18:46 | |
*** ifarkas has quit IRC | 18:49 | |
openstackgerrit | Jarrod Johnson proposed stackforge/pyghmi: Handle concurrent session requests https://review.openstack.org/156327 | 18:50 |
*** anderbubble has quit IRC | 18:52 | |
openstackgerrit | Merged stackforge/pyghmi: Handle concurrent session requests https://review.openstack.org/156327 | 18:54 |
*** anderbubble has joined #openstack-ironic | 18:56 | |
NobodyCam | Shrews: fyi https://review.openstack.org/#/c/156250 | 18:59 |
Shrews | NobodyCam: eh? | 19:03 |
Nisha | NobodyCam, hi | 19:08 |
Nisha | NobodyCam, i reposted https://review.openstack.org/#/c/141012/ after comment from nova reviewer. Could you rereview it? | 19:08 |
NobodyCam | hi Nisha :) | 19:10 |
NobodyCam | will have a look | 19:10 |
Nisha | NobodyCam, thanks. | 19:10 |
NobodyCam | Shrews: thats related to 155460 | 19:10 |
NobodyCam | :) | 19:10 |
Nisha | NobodyCam, i need reviews on inspection patches also :) | 19:10 |
*** pelix has quit IRC | 19:24 | |
*** coolsvap is now known as coolsvap_ | 19:31 | |
*** lucas-dinner has quit IRC | 19:36 | |
*** sdake is now known as sdake_ws | 19:37 | |
openstackgerrit | Adam Gandelman proposed openstack/ironic: Use separate set of credentials for keystone service user https://review.openstack.org/156344 | 19:38 |
openstackgerrit | Nisha Agarwal proposed openstack/python-ironicclient: enhanced node-set-provision-state https://review.openstack.org/148804 | 19:40 |
*** romcheg1 has joined #openstack-ironic | 19:53 | |
*** romcheg has quit IRC | 19:54 | |
*** achanda has joined #openstack-ironic | 19:58 | |
NobodyCam | Nisha: did you see your nova patch was blocked? | 20:02 |
Nisha | is it? | 20:03 |
*** dprince has quit IRC | 20:03 | |
NobodyCam | John Garbutt -2'd it | 20:03 |
*** EmilienM|afk is now known as EmilienM | 20:04 | |
Nisha | :( | 20:04 |
Nisha | is there no way we can get that in? | 20:05 |
Nisha | it is such a simple patch | 20:05 |
Nisha | they are running thru the list now | 20:08 |
Nisha | on irc | 20:08 |
Nisha | :( | 20:08 |
*** achanda has quit IRC | 20:09 | |
NobodyCam | :( | 20:13 |
*** dprince has joined #openstack-ironic | 20:15 | |
NobodyCam | brb | 20:21 |
*** andreykurilin_ has quit IRC | 20:21 | |
*** andreykurilin_ has joined #openstack-ironic | 20:21 | |
mrda | Morning Ironic | 20:27 |
*** andreykurilin_ has quit IRC | 20:30 | |
*** andreykurilin_ has joined #openstack-ironic | 20:31 | |
*** achanda has joined #openstack-ironic | 20:45 | |
*** devlaps has joined #openstack-ironic | 21:01 | |
*** hongbin has joined #openstack-ironic | 21:05 | |
hongbin | Hi, is anyone here familiar with the ironic nova scheduler? | 21:06 |
*** achanda has quit IRC | 21:06 | |
jroll | hongbin: someone surely is, ask your questions | 21:06 |
jroll | morning mrda :) | 21:06 |
mrda | hey jroll | 21:07 |
hongbin | jroll: I have a nova setup with several nova-compute. With one dedicated nova-compute for Ironic, the rest for VM | 21:08 |
hongbin | I saw a VM request was unexpectedly scheduler to the Ironic host | 21:08 |
jroll | hongbin: there's a thing you can do with host aggregates, but I don't know it well | 21:09 |
hongbin | I checked the host aggregation filter | 21:09 |
hongbin | It seems I need to set the key of all flavors, which is suboptimal | 21:09 |
hongbin | I wonder if there is a better way to achieve that | 21:10 |
jroll | yeah, I'm not sure, sorry :( | 21:11 |
*** jgrimm is now known as zz_jgrimm | 21:12 | |
hongbin | jroll: NP :), Thanks for your response. I am awaiting for potential response from others | 21:12 |
jroll | welcome :) | 21:13 |
*** Nisha has quit IRC | 21:22 | |
*** jcoufal has joined #openstack-ironic | 21:29 | |
jroll | whee, nisha's thing got an ffe | 21:48 |
NobodyCam | :) nice... jroll if it got a ffe you want to toss a +1 it way: https://review.openstack.org/#/c/141012 | 21:52 |
jroll | lol | 21:52 |
jroll | I'll think about it :P | 21:52 |
NobodyCam | hehehehe | 21:52 |
NobodyCam | :-p | 21:52 |
*** andreykurilin_ has quit IRC | 21:56 | |
*** achanda has joined #openstack-ironic | 22:34 | |
openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement Cleaning States https://review.openstack.org/153444 | 22:46 |
*** dprince has quit IRC | 22:47 | |
*** absubram has quit IRC | 22:48 | |
*** trown is now known as trown|outttypeww | 22:52 | |
*** datajerk has quit IRC | 23:06 | |
*** chlong has joined #openstack-ironic | 23:09 | |
*** achanda has quit IRC | 23:21 | |
NobodyCam | JoshNang: jroll question? Was I wrong in thinking we were keeping deleted as a noop for k? | 23:26 |
JoshNang | NobodyCam: heh i've heard both. i asked devananda and he said (correct me if i'm wrong) we'll implement them in L | 23:27 |
NobodyCam | :/ | 23:28 |
*** Marga_ has quit IRC | 23:28 | |
NobodyCam | I recall use chatting at the office | 23:28 |
*** Marga_ has joined #openstack-ironic | 23:28 | |
NobodyCam | I thought it was keep as noop.. but I'll try ask at deva at the meeting tonight (if he makes it)... he is still recovering from travel plage as i understand it | 23:30 |
*** anderbubble has quit IRC | 23:30 | |
*** hongbin has left #openstack-ironic | 23:30 | |
JoshNang | :( ugh travel plague | 23:30 |
JoshNang | but ok! no-op'ing it is as easy as adding some more process_event()'s and adding to states.py | 23:31 |
NobodyCam | before you do it lets ask | 23:31 |
JoshNang | definitely | 23:32 |
NobodyCam | but good to know its a easy one ot add | 23:32 |
JoshNang | yup! i had it in the cleaning review at one point :P | 23:32 |
NobodyCam | :( | 23:33 |
NobodyCam | :-p | 23:33 |
*** Marga_ has quit IRC | 23:35 | |
*** Marga_ has joined #openstack-ironic | 23:35 | |
*** romcheg has joined #openstack-ironic | 23:38 | |
*** romcheg1 has quit IRC | 23:42 | |
NobodyCam | JoshNang: added as an agenda item | 23:52 |
*** Marga_ has quit IRC | 23:52 | |
*** Marga_ has joined #openstack-ironic | 23:53 | |
JoshNang | NobodyCam: thanks! | 23:54 |
JoshNang | i'll be there | 23:54 |
* NobodyCam hopes to be awake for it ... lol... | 23:55 | |
*** jcoufal_ has joined #openstack-ironic | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!