| *** hj-hp has joined #openstack-ironic | 00:01 | |
| *** hj-hp has quit IRC | 00:01 | |
| mrda | Does Depends-On actually do anything jroll? | 00:03 |
|---|---|---|
| mrda | ...because if it does, it must be a new thing | 00:04 |
| jroll | mrda: yes, it applies changes across projects in order | 00:04 |
| jroll | it is new | 00:04 |
| jroll | as of last week or two | 00:04 |
| mrda | huh | 00:05 |
| * mrda wonders why his infra core friend didn't tell him | 00:05 | |
| jroll | dunno | 00:07 |
| jroll | it was on the ML | 00:07 |
| rfchapman | NobodyCam: is there a way to lessen the timeout for a deployment? Each time the deploy fails it waits 30 mins before deleting the instance | 00:08 |
| mrda | who has time for reading *that* :) | 00:08 |
| *** Marga_ has quit IRC | 00:08 | |
| jlvillal | jroll: I updated the wiki about Depends-On: https://wiki.openstack.org/wiki/Gerrit_Workflow#Add_dependency | 00:10 |
| NobodyCam | rfchapman: https://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L552 | 00:11 |
| mrda | jlvillal: great! | 00:12 |
| jlvillal | mrda: Thanks. And feel free to ignore my nit on your patch! :) | 00:13 |
| * jlvillal wonders what time it is in Australia | 00:13 | |
| rfchapman | NobodyCam: thanks | 00:13 |
| mrda | 10:45am here jlvillal | 00:14 |
| *** naohirot has joined #openstack-ironic | 00:14 | |
| jlvillal | mrda: Ah, not the middle of the night. Great :) | 00:14 |
| NobodyCam | lol | 00:16 |
| * mrda thinks about the nit | 00:16 | |
| mrda | jlvillal: thanks for the review btw | 00:16 |
| *** Marga_ has joined #openstack-ironic | 00:16 | |
| jlvillal | mrda: You're welcome. Feel free to ignore the nit part. | 00:17 |
| naohirot | good morning all, NobodyCam, jlvillal, mrda | 00:20 |
| jlvillal | naohirot: おはよう | 00:22 |
| jlvillal | Ohayō | 00:22 |
| naohirot | jlvillal: good evening, Konbanwa :) | 00:23 |
| mrda | morning naohirot | 00:24 |
| naohirot | good morning, mrda :) | 00:24 |
| *** david-lyle is now known as david-lyle_afk | 00:25 | |
| openstackgerrit | Michael Davies proposed openstack/ironic: Add support for 'latest' in microversion header https://review.openstack.org/158601 | 00:33 |
| mrda | This time for sure :-P | 00:35 |
| jlvillal | mrda: What about my request for explanation for *_VER vs *_VERSION? | 00:36 |
| jlvillal | mrda: Maybe I'm being dense, but I don't quite understand the difference of them. What one is used for vs the other. | 00:37 |
| mrda | oh | 00:39 |
| mrda | sorry, just spilled coffee over my keyboard :( | 00:39 |
| mrda | So one is just a string representation of the version (i.e. "1.5") and the other, is a Version object which can be used for comparisons | 00:40 |
| mrda | jlvillal: ^^^ | 00:40 |
| jlvillal | mrda: Sorry about the coffee :( | 00:40 |
| * jlvillal may or may have not done that himself... | 00:40 | |
| mrda | jlvillal: Does that answer your question? Or do you still have concerns? | 00:42 |
| jlvillal | mrda: https://review.openstack.org/#/c/158601/6/ironic/api/controllers/v1/__init__.py Line 173? Should those be *_VERSION? | 00:43 |
| jlvillal | mrda: nevermind | 00:44 |
| jlvillal | mrda: I guess I find it somewhat confusing as sometimes *_VER is used and sometimes *_VERSION. And it isn't obvious which one is which | 00:44 |
| jlvillal | mrda: Would it be bad if one was: *_VER_STRING ? | 00:45 |
| mrda | MIN_VERSION_STR vs MIN_VER would that be a better indication? | 00:45 |
| mrda | snap | 00:45 |
| jlvillal | mrda: I think something like that would help make it clear to me. | 00:46 |
| mrda | Please hold, your call is important to us (while I upload the fixed version) | 00:46 |
| jlvillal | :) | 00:47 |
| *** yuanying has joined #openstack-ironic | 00:48 | |
| *** Marga_ has quit IRC | 00:48 | |
| * mrda cleans his keyboard while tox runs | 00:49 | |
| openstackgerrit | Michael Davies proposed openstack/ironic: Add support for 'latest' in microversion header https://review.openstack.org/158601 | 00:50 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Improve last_error for async exceptions https://review.openstack.org/158938 | 00:51 |
| jroll | more easy reviews ^ | 00:51 |
| mrda | jroll: mine too! | 00:51 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Remove unused code from agent vendor lookup() https://review.openstack.org/158912 | 00:52 |
| jroll | mrda: :D | 00:52 |
| jroll | I hope to review all the things tomorrow | 00:52 |
| jlvillal | mrda: Looks good to me. Thanks. | 00:52 |
| mrda | jroll: you don't need sleep - just wrap around tonight | 00:52 |
| * mrda argues for something he doesn't do | 00:53 | |
| *** yuanying has quit IRC | 00:53 | |
| jroll | mrda: seems painful | 00:56 |
| *** yuanying has joined #openstack-ironic | 01:02 | |
| *** ParsectiX has quit IRC | 01:02 | |
| jlvillal | rloo: Thanks for the review. I abandoned the patch since the change should come in via global-requirements once that patch gets merged. | 01:03 |
| rloo | thx jlvillal | 01:03 |
| *** Parsecti_ has joined #openstack-ironic | 01:04 | |
| jroll | jlvillal: it never hurts to update ahead of time though | 01:05 |
| jroll | when tests are completely broken | 01:05 |
| jlvillal | jroll: But changing the requirements causes the gate test to fail :( | 01:06 |
| jlvillal | So it seems like a catch-22 | 01:06 |
| *** lsmola has quit IRC | 01:07 | |
| *** aignatov has quit IRC | 01:08 | |
| *** arif-ali has quit IRC | 01:08 | |
| *** pleia2 has quit IRC | 01:08 | |
| *** oomichi has joined #openstack-ironic | 01:08 | |
| *** pleia2 has joined #openstack-ironic | 01:08 | |
| *** lsmola has joined #openstack-ironic | 01:09 | |
| *** aignatov has joined #openstack-ironic | 01:09 | |
| jroll | jlvillal: we still gate on that? lame | 01:09 |
| jlvillal | jroll: Appears to be | 01:09 |
| *** achanda has quit IRC | 01:10 | |
| *** openstack has joined #openstack-ironic | 01:12 | |
| jlvillal | jroll: Me too :) | 01:12 |
| jlvillal | jroll: If you have contacts over in infra, other than clarkb, maybe you can poke them :) | 01:13 |
| jlvillal | jroll: clarkb gave it a +2 | 01:13 |
| *** achanda has joined #openstack-ironic | 01:13 | |
| jroll | mordred: mind unbreaking our client's gate? :) https://review.openstack.org/#/c/158897/ | 01:13 |
| NobodyCam | thank you mordred :) | 01:16 |
| *** gabrielbezerra has joined #openstack-ironic | 01:16 | |
| *** kbyrne has quit IRC | 01:16 | |
| *** mdbooth has quit IRC | 01:16 | |
| *** bnemec has quit IRC | 01:16 | |
| *** JayF has quit IRC | 01:16 | |
| *** lifeless has quit IRC | 01:16 | |
| *** harmw has quit IRC | 01:16 | |
| *** gabriel-bezerra has quit IRC | 01:16 | |
| mordred | jroll: doe | 01:16 |
| mordred | done | 01:16 |
| jroll | indeed, thanks mordred :D | 01:17 |
| jroll | jlvillal: now unabandon that other patch or wait a day :P | 01:17 |
| jlvillal | jroll: Oh, okay :) | 01:17 |
| *** mmorais has quit IRC | 01:18 | |
| JoshNang | jroll: on that async exception patch, do you need to wrap the last error string in _()? just came across the same thing in cleaning | 01:18 |
| jroll | ehhhhh | 01:18 |
| jroll | idk, you wrote the patch, you tell me | 01:18 |
| jroll | :D | 01:18 |
| JoshNang | :D | 01:18 |
| rloo | jlvillal: I have to run but I just realized that we should update the etherpad | 01:18 |
| rloo | jlvillal: https://etherpad.openstack.org/p/IronicWhiteBoard | 01:18 |
| jlvillal | rloo: With....? | 01:19 |
| rloo | with the status for python-ironicclient. cuz others might wonder why it is failing | 01:19 |
| rloo | jlvillal: and it is useless for them to recheck | 01:19 |
| jlvillal | ah! | 01:19 |
| jroll | JoshNang: I don't think we translate db columns, do we? | 01:19 |
| rloo | jlvillal: put in the reason/link to patch, whatever you think might help. if anyone reads it ;) | 01:19 |
| rloo | thx jlvillal | 01:19 |
| jlvillal | rloo: Okay | 01:19 |
| JoshNang | jroll: i saw a couple in manager.py that do | 01:20 |
| *** arif-ali has joined #openstack-ironic | 01:20 | |
| *** mdbooth has joined #openstack-ironic | 01:20 | |
| *** harmw has joined #openstack-ironic | 01:20 | |
| *** bnemec has joined #openstack-ironic | 01:20 | |
| *** JayF has joined #openstack-ironic | 01:20 | |
| *** lifeless has joined #openstack-ironic | 01:20 | |
| *** lifeless has quit IRC | 01:20 | |
| jroll | JoshNang: hrm. | 01:20 |
| *** lifeless has joined #openstack-ironic | 01:21 | |
| jroll | I'm gonig to sign off for the night and look again tomorrow | 01:21 |
| JoshNang | sounds good | 01:22 |
| *** rloo has quit IRC | 01:24 | |
| *** yog_ has quit IRC | 01:24 | |
| *** mmorais has joined #openstack-ironic | 01:24 | |
| jlvillal | jroll: Good night | 01:27 |
| jlvillal | And I am also going to call it a day :) | 01:27 |
| jlvillal | Good night all! | 01:27 |
| *** pleia2_ has joined #openstack-ironic | 01:28 | |
| *** jlvillal is now known as jlvillal|afk | 01:32 | |
| *** pleia2 has quit IRC | 01:35 | |
| *** oomichi has quit IRC | 01:35 | |
| *** mjturek1 has quit IRC | 01:35 | |
| *** ekarlso has quit IRC | 01:35 | |
| *** SpamapS has quit IRC | 01:35 | |
| *** mordred has quit IRC | 01:35 | |
| *** anteaya has quit IRC | 01:35 | |
| *** jogo has quit IRC | 01:35 | |
| *** mmorais has quit IRC | 01:35 | |
| *** Parsecti_ has quit IRC | 01:35 | |
| *** GheRivero has quit IRC | 01:35 | |
| *** greghaynes has quit IRC | 01:35 | |
| *** mrda has quit IRC | 01:35 | |
| *** sambetts has quit IRC | 01:35 | |
| *** dank_ has quit IRC | 01:35 | |
| *** coolsvap_ has quit IRC | 01:35 | |
| *** slagle has quit IRC | 01:35 | |
| *** kevinbenton has quit IRC | 01:35 | |
| *** devananda has quit IRC | 01:35 | |
| *** davidlenwell has quit IRC | 01:35 | |
| *** naotokl has quit IRC | 01:35 | |
| *** yog_ has joined #openstack-ironic | 01:37 | |
| *** kbyrne has joined #openstack-ironic | 01:39 | |
| *** mmorais has joined #openstack-ironic | 01:39 | |
| *** oomichi has joined #openstack-ironic | 01:39 | |
| *** Parsecti_ has joined #openstack-ironic | 01:39 | |
| *** GheRivero has joined #openstack-ironic | 01:39 | |
| *** mjturek1 has joined #openstack-ironic | 01:39 | |
| *** ekarlso has joined #openstack-ironic | 01:39 | |
| *** greghaynes has joined #openstack-ironic | 01:39 | |
| *** mrda has joined #openstack-ironic | 01:39 | |
| *** SpamapS has joined #openstack-ironic | 01:39 | |
| *** sambetts has joined #openstack-ironic | 01:39 | |
| *** 92AAALG4Y has joined #openstack-ironic | 01:39 | |
| *** coolsvap_ has joined #openstack-ironic | 01:39 | |
| *** slagle has joined #openstack-ironic | 01:39 | |
| *** jogo has joined #openstack-ironic | 01:39 | |
| *** mordred has joined #openstack-ironic | 01:39 | |
| *** anteaya has joined #openstack-ironic | 01:39 | |
| *** kevinbenton has joined #openstack-ironic | 01:39 | |
| *** devananda has joined #openstack-ironic | 01:39 | |
| *** davidlenwell has joined #openstack-ironic | 01:39 | |
| *** naotokl has joined #openstack-ironic | 01:39 | |
| *** oomichi has quit IRC | 01:40 | |
| *** mjturek1 has quit IRC | 01:40 | |
| *** ekarlso has quit IRC | 01:40 | |
| *** SpamapS has quit IRC | 01:40 | |
| *** mordred has quit IRC | 01:40 | |
| *** anteaya has quit IRC | 01:40 | |
| *** jogo has quit IRC | 01:40 | |
| *** kbyrne has quit IRC | 01:40 | |
| *** mmorais has quit IRC | 01:40 | |
| *** Parsecti_ has quit IRC | 01:40 | |
| *** GheRivero has quit IRC | 01:40 | |
| *** greghaynes has quit IRC | 01:40 | |
| *** mrda has quit IRC | 01:40 | |
| *** sambetts has quit IRC | 01:40 | |
| *** 92AAALG4Y has quit IRC | 01:40 | |
| *** coolsvap_ has quit IRC | 01:40 | |
| *** slagle has quit IRC | 01:40 | |
| *** kevinbenton has quit IRC | 01:40 | |
| *** devananda has quit IRC | 01:40 | |
| *** davidlenwell has quit IRC | 01:40 | |
| *** naotokl has quit IRC | 01:40 | |
| *** pcrews has quit IRC | 01:40 | |
| *** logan2_ has quit IRC | 01:40 | |
| *** david-lyle_afk has quit IRC | 01:40 | |
| *** jrist has quit IRC | 01:40 | |
| *** BadCub has quit IRC | 01:40 | |
| *** kbyrne has joined #openstack-ironic | 01:41 | |
| *** mmorais has joined #openstack-ironic | 01:41 | |
| *** oomichi has joined #openstack-ironic | 01:41 | |
| *** Parsecti_ has joined #openstack-ironic | 01:41 | |
| *** GheRivero has joined #openstack-ironic | 01:41 | |
| *** mjturek1 has joined #openstack-ironic | 01:41 | |
| *** ekarlso has joined #openstack-ironic | 01:41 | |
| *** greghaynes has joined #openstack-ironic | 01:41 | |
| *** mrda has joined #openstack-ironic | 01:41 | |
| *** SpamapS has joined #openstack-ironic | 01:41 | |
| *** sambetts has joined #openstack-ironic | 01:41 | |
| *** 92AAALG4Y has joined #openstack-ironic | 01:41 | |
| *** coolsvap_ has joined #openstack-ironic | 01:41 | |
| *** slagle has joined #openstack-ironic | 01:41 | |
| *** jogo has joined #openstack-ironic | 01:41 | |
| *** mordred has joined #openstack-ironic | 01:41 | |
| *** anteaya has joined #openstack-ironic | 01:41 | |
| *** kevinbenton has joined #openstack-ironic | 01:41 | |
| *** devananda has joined #openstack-ironic | 01:41 | |
| *** davidlenwell has joined #openstack-ironic | 01:41 | |
| *** naotokl has joined #openstack-ironic | 01:41 | |
| *** yog_ has quit IRC | 01:43 | |
| *** dhp has joined #openstack-ironic | 01:48 | |
| *** pleia2_ is now known as pleia2 | 01:48 | |
| *** killer_prince is now known as lazy_prince | 01:50 | |
| *** achanda has quit IRC | 01:51 | |
| *** achanda has joined #openstack-ironic | 01:53 | |
| *** logan2_ has joined #openstack-ironic | 01:59 | |
| *** david-lyle_afk has joined #openstack-ironic | 01:59 | |
| *** jrist has joined #openstack-ironic | 01:59 | |
| *** yog_ has joined #openstack-ironic | 02:03 | |
| *** pcrews has joined #openstack-ironic | 02:04 | |
| openstackgerrit | Michael Davies proposed openstack/ironic: Add support for 'latest' in microversion header https://review.openstack.org/158601 | 02:06 |
| *** harlowja has quit IRC | 02:07 | |
| *** harlowja_ has joined #openstack-ironic | 02:07 | |
| *** logan2_ has quit IRC | 02:10 | |
| *** david-lyle_afk has quit IRC | 02:10 | |
| *** jrist has quit IRC | 02:10 | |
| *** logan2_ has joined #openstack-ironic | 02:16 | |
| *** david-lyle_afk has joined #openstack-ironic | 02:16 | |
| *** jrist has joined #openstack-ironic | 02:16 | |
| *** ChuckC has quit IRC | 02:23 | |
| *** kbs has joined #openstack-ironic | 02:26 | |
| *** kbs has quit IRC | 02:31 | |
| *** yog_ has quit IRC | 02:37 | |
| *** ramineni has joined #openstack-ironic | 02:41 | |
| *** achanda has quit IRC | 02:44 | |
| *** achanda has joined #openstack-ironic | 03:03 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 03:04 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 03:08 |
| *** alex_xu has quit IRC | 03:10 | |
| *** alex_xu has joined #openstack-ironic | 03:13 | |
| *** devlaps has joined #openstack-ironic | 03:14 | |
| *** yog_ has joined #openstack-ironic | 03:18 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 03:19 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 03:22 |
| openstackgerrit | Bernard Van De Walle proposed openstack/ironic: Spelling error in Comment https://review.openstack.org/158970 | 03:22 |
| *** lazy_prince is now known as killer_prince | 03:24 | |
| *** devlaps has quit IRC | 03:40 | |
| *** achanda has quit IRC | 03:41 | |
| *** achanda has joined #openstack-ironic | 03:42 | |
| *** sdake has quit IRC | 03:56 | |
| *** achanda has quit IRC | 03:57 | |
| *** achanda has joined #openstack-ironic | 04:02 | |
| *** achanda has quit IRC | 04:04 | |
| *** ChuckC has joined #openstack-ironic | 04:05 | |
| *** harlowja_ is now known as harlowja_away | 04:06 | |
| *** achanda has joined #openstack-ironic | 04:12 | |
| openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Add scripts to manage translations https://review.openstack.org/158981 | 04:15 |
| *** coolsvap_ is now known as coolsvap | 04:16 | |
| *** rameshg87 has joined #openstack-ironic | 04:23 | |
| *** krtaylor has quit IRC | 04:51 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 04:53 |
| *** Nisha has joined #openstack-ironic | 04:54 | |
| *** Marga_ has joined #openstack-ironic | 04:57 | |
| *** krtaylor has joined #openstack-ironic | 05:03 | |
| *** krtaylor has quit IRC | 05:04 | |
| *** Marga_ has quit IRC | 05:06 | |
| *** Marga_ has joined #openstack-ironic | 05:07 | |
| *** pensu has joined #openstack-ironic | 05:08 | |
| *** krtaylor has joined #openstack-ironic | 05:09 | |
| *** achanda has quit IRC | 05:12 | |
| *** jlvllal_rem has joined #openstack-ironic | 05:17 | |
| jlvllal_rem | Nisha: Sorry. Sometimes I have the feeling that I am the bearer of bad news. | 05:18 |
| jlvllal_rem | Nisha: But I think the patch is close as far as I can tell. | 05:18 |
| Nisha | jlvllal_rem, ??? | 05:18 |
| Nisha | means? | 05:18 |
| jlvllal_rem | Nisha: I left a review on your patch | 05:19 |
| jlvllal_rem | :) | 05:19 |
| jlvllal_rem | rem = remote. aka I'm at home | 05:19 |
| Nisha | jlvllal_rem, but thats not a bug | 05:19 |
| jlvllal_rem | It isn't? I'm confused. | 05:20 |
| Nisha | jlvllal_rem, oh i got the issue | 05:20 |
| jlvllal_rem | Looks like a bug | 05:20 |
| Nisha | condition is wrong | 05:20 |
| jlvllal_rem | It doesn't do additional add. It keeps over-writing variable, I think | 05:20 |
| *** pradipta has joined #openstack-ironic | 05:20 | |
| jlvllal_rem | Nisha: Or did I read that wrong | 05:21 |
| Nisha | no actually the condition is wrong | 05:21 |
| openstackgerrit | Ramakrishnan G proposed stackforge/proliantutils: HPSSA: Add support for nested RAID levels https://review.openstack.org/158994 | 05:21 |
| rameshg87 | ramineni, ^^ | 05:21 |
| jlvllal_rem | Nisha: I did read that wrong. | 05:21 |
| jlvllal_rem | Never mind!! | 05:21 |
| rameshg87 | ramineni, one more to the patch chain :) | 05:21 |
| Nisha | not exactly, the point here is that i shouldnt be overwriting the already existing capabilities in the node | 05:21 |
| rameshg87 | and Nisha too :) ^^^ | 05:21 |
| Nisha | so i think i need to change condition there | 05:21 |
| Nisha | rameshg87, :) | 05:22 |
| Nisha | jlvllal_rem, i will address the comments and post the patch soon | 05:22 |
| *** eghobo has joined #openstack-ironic | 05:22 | |
| jlvllal_rem | Nisha: Okay. Please peek at my comment in patch 19. | 05:23 |
| jlvllal_rem | I think slightly cleaner way to do it. | 05:23 |
| ramineni | rameshg87: will have a look :) | 05:23 |
| Nisha | jlvllal_rem, i saw it but i thought i have covered it | 05:23 |
| jlvllal_rem | Nisha: I think your unittest for that could check two types of values. 1 item and 3 items. can be in same function. | 05:23 |
| jlvllal_rem | Nisha: I added new comment to 19 | 05:24 |
| jlvllal_rem | Nisha: about 5 minutes ago. | 05:24 |
| Nisha | jlvllal_rem, ok just a min | 05:24 |
| jlvllal_rem | But my new comment in Patch 19 is not something I would -1 if you didn't do it. Just a tip, which I hope is useful. | 05:24 |
| *** killer_prince is now known as lazy_prince | 05:30 | |
| Nisha | jlvllal_rem, well the scenario i was talking about is covered in 258 | 05:33 |
| Nisha | jlvllal_rem, yes its useful. if i create a new patch then i will try to leverage it. :) | 05:34 |
| jlvllal_rem | Nisha: Sorry for saying bug :( My mistake. | 05:34 |
| Nisha | jlvllal_rem, no i found a issue in code. i will post the new patch | 05:35 |
| jlvllal_rem | Nisha: Glad it is useful. Have a good day. Time to get ready for bed over here. Though I may take a look again before I actually go to sleep :) | 05:35 |
| Nisha | jlvllal_rem, thanks :) | 05:35 |
| *** achanda has joined #openstack-ironic | 05:35 | |
| jlvllal_rem | Nisha: If you find bug in code. It is great if you can make unittest to catch it :) | 05:36 |
| Nisha | jlvllal_rem, :) | 05:36 |
| Nisha | jlvllal_rem, that condition is correct . it is required for the first time | 05:38 |
| Nisha | first time the cap_string is empty | 05:38 |
| jlvllal_rem | Nisha: Which condition? | 05:38 |
| Nisha | if cap_string: | 05:38 |
| jlvllal_rem | Uh, I think my comment showed a way to do it without. | 05:39 |
| jlvllal_rem | Using join() | 05:39 |
| jlvllal_rem | Nisha: Does that not work? | 05:39 |
| Nisha | let me try ur code | 05:39 |
| Nisha | jlvllal_rem, not yet tried your code. | 05:39 |
| jlvllal_rem | Nisha: You might like 2nd version better. As a little more readable. | 05:39 |
| jlvllal_rem | Nisha: The list comprehension stuff can become too much in my opinion. | 05:40 |
| Nisha | jlvllal_rem, yeah by reading only i liked second one | 05:40 |
| jlvllal_rem | Nisha: Me too! :) | 05:40 |
| mrda | jlvllal_rem: Should you not be sleeping by now? | 05:43 |
| jlvllal_rem | mrda: Soon. Very soon ;) | 05:43 |
| mrda | :) | 05:43 |
| *** Parsecti_ has quit IRC | 05:46 | |
| *** ParsectiX has joined #openstack-ironic | 05:46 | |
| *** jcoufal has joined #openstack-ironic | 05:46 | |
| openstackgerrit | Ramakrishnan G proposed stackforge/proliantutils: HPSSA: Handle all storage units https://review.openstack.org/159001 | 05:46 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 05:47 |
| Nisha | jlvllal_rem, ^^^ | 05:47 |
| jlvllal_rem | Nisha: I will look in a few minutes... | 05:50 |
| Nisha | jlvllal_rem, sure | 05:50 |
| Nisha | :) | 05:50 |
| *** eghobo has quit IRC | 05:56 | |
| *** jcoufal has quit IRC | 05:59 | |
| jlvllal_rem | Nisha: +1, but I still think the unittest should be expanded. I left two comments. | 06:02 |
| Nisha | jlvllal_rem, i didnt used iteritems because then you have to use six.iteritems for python compatibility between py27 , py3 | 06:04 |
| Nisha | i have seen people using it | 06:04 |
| jlvllal_rem | Nisha: Oh, I didn't know that. Yuck! | 06:04 |
| jlvllal_rem | Nisha: Thanks for the info! | 06:04 |
| Nisha | jlvllal_rem, welcome | 06:05 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Automate boot iso creation with in ironic for iscsi-ilo https://review.openstack.org/155900 | 06:06 |
| *** ParsectiX has quit IRC | 06:09 | |
| *** rwsu is now known as rwsu-afk | 06:25 | |
| *** pensu has left #openstack-ironic | 06:34 | |
| *** Nisha has quit IRC | 06:40 | |
| *** Nisha has joined #openstack-ironic | 06:58 | |
| *** jcoufal has joined #openstack-ironic | 07:01 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add iRMC Management module for iRMC Driver https://review.openstack.org/146803 | 07:09 |
| *** jcoufal has quit IRC | 07:17 | |
| *** jcoufal has joined #openstack-ironic | 07:18 | |
| *** mrda is now known as mrda-away | 07:32 | |
| *** pas-ha has joined #openstack-ironic | 07:38 | |
| *** ekarlso has quit IRC | 07:48 | |
| *** Marga_ has quit IRC | 08:00 | |
| *** Marga_ has joined #openstack-ironic | 08:00 | |
| *** mgoddard has joined #openstack-ironic | 08:08 | |
| *** oomichi has quit IRC | 08:13 | |
| *** pas-ha has quit IRC | 08:14 | |
| *** ifarkas has joined #openstack-ironic | 08:14 | |
| *** pas-ha has joined #openstack-ironic | 08:16 | |
| *** Nisha has quit IRC | 08:17 | |
| *** achanda has quit IRC | 08:22 | |
| *** Marga_ has quit IRC | 08:22 | |
| *** achanda has joined #openstack-ironic | 08:22 | |
| dtantsur|afk | Morning | 08:29 |
| *** dtantsur|afk is now known as dtantsur | 08:30 | |
| *** Nisha has joined #openstack-ironic | 08:30 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/158750 | 08:41 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/157768 | 08:41 |
| rameshg87 | dtantsur, o/ | 08:42 |
| dtantsur | rameshg87, o/ | 08:42 |
| *** lazy_prince has quit IRC | 08:42 | |
| GheRivero | morning all | 08:42 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/159038 | 08:47 |
| *** yuanying has quit IRC | 08:47 | |
| *** yuanying has joined #openstack-ironic | 08:48 | |
| rameshg87 | GheRivero, o/ :) | 08:48 |
| *** killer_prince has joined #openstack-ironic | 08:52 | |
| *** killer_prince is now known as lazy_prince | 08:52 | |
| *** ekarlso has joined #openstack-ironic | 08:52 | |
| *** jistr has joined #openstack-ironic | 08:53 | |
| *** erwan_taf has joined #openstack-ironic | 08:54 | |
| *** romcheg has joined #openstack-ironic | 08:59 | |
| *** athomas has joined #openstack-ironic | 09:01 | |
| *** achanda has quit IRC | 09:02 | |
| *** achanda has joined #openstack-ironic | 09:04 | |
| *** achanda has quit IRC | 09:08 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Root partition should be bootable for localboot https://review.openstack.org/156587 | 09:15 |
| *** lucasagomes has joined #openstack-ironic | 09:17 | |
| *** andreykurilin_ has joined #openstack-ironic | 09:17 | |
| rameshg87 | lucasagomes, dtantsur, ^^^ | 09:18 |
| rameshg87 | lucasagomes, dtantsur, please have a look at when you get some time | 09:19 |
| rameshg87 | lucasagomes, Root partition should be bootable for localboot https://review.openstack.org/156587 | 09:19 |
| dtantsur | sure thing | 09:25 |
| *** derekh has joined #openstack-ironic | 09:25 | |
| *** viktors|afk is now known as viktors | 09:25 | |
| lucasagomes | rameshg87, +1 | 09:29 |
| rameshg87 | thanks | 09:30 |
| rameshg87 | ifarkas, dtantsur, https://review.openstack.org/#/c/150488/16 | 09:32 |
| rameshg87 | there is too much drac-specific code in there, right ? | 09:32 |
| rameshg87 | can't it be just put into an external python module and let ironic call only some public method exposed from that module | 09:32 |
| rameshg87 | something like python-dracclient | 09:33 |
| ifarkas | rameshg87, that's a possibility but I don't really see any reason to do that. This code is used in ironic only | 09:34 |
| ifarkas | rameshg87, we can move every piece of ironic to an external python module... | 09:34 |
| rameshg87 | ifarkas, not exactly | 09:34 |
| rameshg87 | ifarkas, i meant the hardware specific code | 09:34 |
| rameshg87 | ifarkas, we can have it in a separate module | 09:35 |
| rameshg87 | ifarkas, the code in there is mostly drac-specific | 09:35 |
| ifarkas | rameshg87, yes because that's the drac vendor passthru interface | 09:35 |
| rameshg87 | ifarkas, i agree, but ironic just needs to know the methods to call in such a client | 09:36 |
| rameshg87 | ifarkas, makes the ironic code much simpler | 09:36 |
| rameshg87 | ifarkas, and the python-dracclient much easier to maintain | 09:36 |
| rameshg87 | ifarkas, if there is some bug/fixes for some specific hardware or something, you don't need to change code in ironic | 09:36 |
| rameshg87 | ifarkas, that's how we can break things into different pieces :) | 09:37 |
| rameshg87 | ifarkas, we need a vendor-passthru, that's the use-case | 09:37 |
| rameshg87 | ifarkas, but needn't be in ironic | 09:38 |
| rameshg87 | ifarkas, and if in separate module, it can be used out of ironic too :) | 09:38 |
| *** mgoddard has quit IRC | 09:39 | |
| rameshg87 | ifarkas, another example was the amt driver | 09:40 |
| rameshg87 | ifarkas, https://review.openstack.org/#/c/152857/5/ironic/drivers/modules/amt/power.py | 09:40 |
| rameshg87 | ifarkas, it's hard to know for anyone outside what's going on unless they know the hardware | 09:41 |
| ifarkas | rameshg87, having thought about it might not be a terrible idea long term | 09:43 |
| ifarkas | rameshg87, but it won't help with understanding what's going on | 09:44 |
| ifarkas | rameshg87, we can do the same today just blindly +2-ing the patches :-) | 09:44 |
| rameshg87 | ifarkas, hmm, yeah but we can make the ironic code much simpler .. | 09:47 |
| ifarkas | rameshg87, yeah. the more I am thinking about it, the more I like the idea ;-) | 09:50 |
| rameshg87 | ifarkas, :) | 09:51 |
| rameshg87 | ifarkas, i seriously like it | 09:51 |
| rameshg87 | ifarkas, make the module as a stackforge module. we did this some time back | 09:51 |
| rameshg87 | ifarkas, configure tox for the module | 09:51 |
| rameshg87 | ifarkas, openstack ci can run unit tests/pep8 on every submittal, and even do a release for us | 09:52 |
| rameshg87 | ifarkas, i mean pypi release | 09:52 |
| *** andreykurilin_ has quit IRC | 09:53 | |
| *** andreykurilin_ has joined #openstack-ironic | 09:54 | |
| ifarkas | rameshg87, right. I will do some investigation on this option | 09:56 |
| rameshg87 | ifarkas, great ... | 09:56 |
| ifarkas | rameshg87, thanks for the idea! | 09:56 |
| rameshg87 | wc | 09:56 |
| rameshg87 | lucasagomes, regarding https://review.openstack.org/#/c/156587/5/ironic/drivers/modules/deploy_utils.py | 09:57 |
| rameshg87 | lucasagomes, i thought about it | 09:57 |
| rameshg87 | lucasagomes, there is ongoing work on bringing most of the contents in deploy_utils into a separate common module to be used by ipa and ironic | 09:57 |
| lucasagomes | rameshg87, yeah, I put in th comment it just a thought and nothing to be done there | 09:58 |
| lucasagomes | I just wnated to document it :) | 09:58 |
| lucasagomes | (I +2'd it too) | 09:58 |
| lucasagomes | rameshg87, but yeah, a common module sounds good | 09:58 |
| *** dlpartain has joined #openstack-ironic | 09:58 | |
| lucasagomes | rameshg87, will that be a external library or something? since it will be shared with both projects | 09:59 |
| lucasagomes | oslo perhaps?! | 09:59 |
| *** andreykurilin_ has quit IRC | 09:59 | |
| *** andreykurilin_ has joined #openstack-ironic | 09:59 | |
| rameshg87 | lucasagomes, yeah | 10:00 |
| rameshg87 | lucasagomes, there is already work going on | 10:00 |
| lucasagomes | rameshg87, ah nice one | 10:00 |
| rameshg87 | lucasagomes, https://review.openstack.org/#/c/157636/ | 10:01 |
| *** dlpartain has left #openstack-ironic | 10:01 | |
| dtantsur | ifarkas, I can help you with stackforge, if you decide to go that way | 10:02 |
| ifarkas | dtantsur, yeah, thanks. I might ask for your help later on | 10:03 |
| lucasagomes | rameshg87, nice one! | 10:04 |
| *** andreykurilin_ has quit IRC | 10:05 | |
| *** andreykurilin_ has joined #openstack-ironic | 10:05 | |
| *** lazy_prince has quit IRC | 10:07 | |
| openstackgerrit | Anusha Ramineni proposed openstack/ironic: Add Cleaning Operations for iLO drivers https://review.openstack.org/157715 | 10:11 |
| ramineni | rameshg87: ^^^ | 10:13 |
| rameshg87 | ramineni, sure :) | 10:13 |
| *** dtantsur is now known as dtantsur|bbl | 10:13 | |
| *** pelix has joined #openstack-ironic | 10:18 | |
| *** killer_prince has joined #openstack-ironic | 10:20 | |
| *** killer_prince is now known as lazy_prince | 10:20 | |
| openstackgerrit | Lucas Alvares Gomes proposed stackforge/ironic-discoverd: eDeploy plugin to not overwrite node's capabilities https://review.openstack.org/158757 | 10:20 |
| *** yuanying has quit IRC | 10:22 | |
| *** yog_ has quit IRC | 10:23 | |
| *** Nisha has quit IRC | 10:30 | |
| openstackgerrit | Ramakrishnan G proposed stackforge/proliantutils: HPSSA: Add support for nested RAID levels https://review.openstack.org/158994 | 10:37 |
| *** lazy_prince has quit IRC | 10:40 | |
| *** ramineni has quit IRC | 10:53 | |
| *** killer_prince has joined #openstack-ironic | 10:56 | |
| *** killer_prince is now known as lazy_prince | 10:56 | |
| *** andreykurilin_ has quit IRC | 10:59 | |
| *** rameshg87 has quit IRC | 11:10 | |
| *** pradipta has quit IRC | 11:13 | |
| *** jlvllal_rem has quit IRC | 11:15 | |
| *** dtantsur|bbl is now known as dtantsur | 11:21 | |
| *** erwan_taf has quit IRC | 11:21 | |
| *** mgoddard has joined #openstack-ironic | 11:34 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: PXE drivers support for IPA https://review.openstack.org/155728 | 11:36 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: PXE driver: Deprecate pxe_deploy_{ramdisk, kernel} https://review.openstack.org/158644 | 11:36 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Local boot support for IPA https://review.openstack.org/157723 | 11:36 |
| openstackgerrit | Merged stackforge/ironic-discoverd: eDeploy plugin to not overwrite node's capabilities https://review.openstack.org/158757 | 11:36 |
| *** EmilienM is now known as EmilienM|afk | 11:39 | |
| *** pensu has joined #openstack-ironic | 11:39 | |
| *** mdbooth has quit IRC | 11:40 | |
| *** mdbooth has joined #openstack-ironic | 11:41 | |
| *** kbs has joined #openstack-ironic | 12:08 | |
| *** oomichi has joined #openstack-ironic | 12:14 | |
| *** yuriyz has quit IRC | 12:18 | |
| dtantsur | lucasagomes, hey, mind reviewing https://review.openstack.org/#/c/149823/ ? I'm pretty tired of it and want it to move forward finally :) | 12:29 |
| lucasagomes | dtantsur, +1 will do in a few | 12:29 |
| dtantsur | (you can leave approval for someone else, just want to have more eyes on it) | 12:29 |
| lucasagomes | dtantsur, ack, I will grab some quick lunch and will look at it as soon as I come back | 12:41 |
| dtantsur | ok | 12:42 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add find_nodes() helper to the conductor manager https://review.openstack.org/159100 | 12:43 |
| *** lucasagomes is now known as lucas-hungry | 12:46 | |
| *** rameshg87 has joined #openstack-ironic | 12:48 | |
| *** EmilienM|afk is now known as EmilienM | 13:03 | |
| *** erwan_taf has joined #openstack-ironic | 13:07 | |
| *** naohirot has quit IRC | 13:08 | |
| openstackgerrit | Merged openstack/ironic: Remove unused code from agent vendor lookup() https://review.openstack.org/158912 | 13:11 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add module for in-band inspection using ironic-discoverd https://review.openstack.org/156562 | 13:15 |
| *** oomichi has quit IRC | 13:21 | |
| *** yuriyz has joined #openstack-ironic | 13:22 | |
| *** lucas-hungry is now known as lucasagomes | 13:39 | |
| *** derekh has quit IRC | 13:44 | |
| *** derekh has joined #openstack-ironic | 13:53 | |
| *** pensu has quit IRC | 13:59 | |
| *** rloo has joined #openstack-ironic | 14:02 | |
| *** jlvllal_rem has joined #openstack-ironic | 14:04 | |
| jlvllal_rem | lucasagomes: Can you look at: https://review.openstack.org/#/c/159038/ That fix is needed to unblock the gate for the python-ironicclient | 14:05 |
| jlvllal_rem | basically httpretty 0.8.7 is broken with Python 3.4 | 14:05 |
| lucasagomes | jlvllal_rem, will do, gimme 1 min | 14:06 |
| jlvllal_rem | lucasagomes: Thank you | 14:07 |
| lucasagomes | jlvllal_rem, +a | 14:08 |
| jlvllal_rem | lucasagomes: Thank you :) | 14:08 |
| *** dprince has joined #openstack-ironic | 14:18 | |
| jroll | woot | 14:19 |
| jroll | morning all :) | 14:19 |
| lucasagomes | jroll, yo morning | 14:20 |
| jroll | hey lucasagomes | 14:20 |
| *** akrivoka has joined #openstack-ironic | 14:20 | |
| jroll | should last_error just be _() or _LE() | 14:20 |
| rloo | morning jroll, jlvllal_rem. hi lucasagomes | 14:21 |
| rloo | jroll: good question. Do we want it translated? | 14:21 |
| jroll | rloo: morning :) seems so.https://review.openstack.org/#/c/158938/ | 14:22 |
| jroll | err | 14:22 |
| jroll | seems so. https://review.openstack.org/#/c/158938/ | 14:22 |
| rloo | jroll: if they say so :-) | 14:22 |
| rloo | jroll: a quick grep shows that we seem to use _() | 14:23 |
| rloo | jroll: if the same string is used for logging an error and it has _LE() already, that would be fine. but i see you are using different strings ;) | 14:25 |
| jroll | ya, ok | 14:25 |
| * jroll will update | 14:25 | |
| lucasagomes | rloo, morning there | 14:25 |
| rloo | jroll: I think we're not supposed to abbreviate things that are user facing ('async') but I didn't say anything | 14:26 |
| jroll | mmm | 14:28 |
| jroll | I can change it | 14:28 |
| jroll | rloo: ^ would that be preferred? | 14:28 |
| rloo | jroll: dunno. do you think the user will understand? | 14:29 |
| rloo | jroll: i was just spouting some maybe official line. | 14:29 |
| jroll | the only users I know will understand :P | 14:29 |
| jroll | ha | 14:29 |
| rloo | jroll: that would be fine then. | 14:30 |
| rloo | jroll: i think you could combine the two strings into one, but i don't know that it is worth it. you know, have a placeholder for 'for %(node)s' blah blah | 14:30 |
| jroll | my main problem is that I'm not sure if asynchronous is spelled correctly | 14:30 |
| jroll | seems right | 14:31 |
| rloo | jroll: i was thinking of adding many more comments there. you might win the record for most comments for one line change. | 14:31 |
| jroll | lol | 14:31 |
| jroll | maybe I could clean it up | 14:31 |
| * jroll does it | 14:31 | |
| dtantsur | jroll, o/ | 14:31 |
| jroll | heya dtantsur :) | 14:31 |
| rloo | nice that people are thinking about things. | 14:31 |
| dtantsur | rloo, morning | 14:32 |
| rloo | hi dtantsur | 14:32 |
| NobodyCam | Good Morning Ironic, says the man waiting for the coffee pot | 14:34 |
| dtantsur | NobodyCam, morning! | 14:34 |
| NobodyCam | moring dtantsur :) | 14:34 |
| rloo | gooooood morning NobodyCam | 14:34 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Improve last_error for async exceptions https://review.openstack.org/158938 | 14:34 |
| jroll | I wonder if this is actually any better | 14:34 |
| NobodyCam | heheh morning rloo :) | 14:34 |
| jroll | but there you are folks | 14:35 |
| jroll | morning NobodyCam :) | 14:35 |
| NobodyCam | morning jroll :) | 14:35 |
| *** akrivoka has left #openstack-ironic | 14:36 | |
| *** erwan_taf has quit IRC | 14:42 | |
| *** Nisha has joined #openstack-ironic | 14:43 | |
| *** BadCub has joined #openstack-ironic | 14:46 | |
| BadCub | Morning Ironic | 14:46 |
| NobodyCam | good morning BadCub :) | 14:46 |
| GheRivero | afternoon all | 14:47 |
| jroll | dtantsur: that message goes to a user and log.exception... so it should be _() ? | 14:48 |
| NobodyCam | morning . afternoon GheRivero :) | 14:48 |
| jroll | I was going off of 14:25:09 rloo | jroll: if the same string is used for logging an error and it has _LE() already, that would be fine. but i see you are using different strings ;) | 14:48 |
| *** david-lyle_afk is now known as david-lyle | 14:48 | |
| jroll | I'm fine with it either way I guess | 14:48 |
| dtantsur | jroll, yep. we always use _() when string is visible to a user outside of the logs | 14:48 |
| dtantsur | _LE is for errors that go only to the log | 14:48 |
| jroll | welp | 14:49 |
| jroll | ok | 14:49 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Improve last_error for async exceptions https://review.openstack.org/158938 | 14:49 |
| jroll | dtantsur: there you go sir | 14:49 |
| * dtantsur wonder if jroll is gonna kill him for spotting another small issue... | 14:50 | |
| NobodyCam | doh | 14:50 |
| dtantsur | " exception%(node_str)s:" should probably be " exception for %(node_str)s:" | 14:50 |
| jroll | dtantsur: well, node isn't included in last_error | 14:51 |
| rloo | jroll: my bad (I hate this stuff): http://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function | 14:51 |
| jroll | that's why I have node_str: ' for node %s' | 14:51 |
| rloo | jroll: _() is preferred for any user facing message, even if it is also going to a log file. This ensures that the translated version of the message will be available to the user. | 14:51 |
| dtantsur | aaaa, my bad, sorry jroll | 14:51 |
| rloo | jroll: I don't understand why it can't be _LE() to the user. | 14:51 |
| jroll | rloo: it's ok, maybe I'll start reading for myself :) | 14:51 |
| jroll | rloo: maybe they don't translate as well for _LE() or something. "close enough". | 14:52 |
| openstackgerrit | Ana Krivokapic proposed openstack/ironic: Fix IPMI support documentation https://review.openstack.org/159153 | 14:52 |
| * dtantsur prepares to finally be killed | 14:52 | |
| dtantsur | jroll, ' for node %s'should also be _LE() | 14:52 |
| jlvllal_rem | rloo: Morning! | 14:52 |
| * dtantsur hides | 14:52 | |
| jroll | .......... | 14:52 |
| rloo | jroll: it is good to 'get it right'. one day, ironic too, will have lots of translated strings ;) | 14:52 |
| jlvllal_rem | And good morning to everyone else :) dtantsur lucasagomes jroll Nisha NobodyCam and anyone I missed :) | 14:53 |
| dtantsur | jlvllal_rem, morning :) | 14:53 |
| jroll | morning jlvllal_rem :) | 14:53 |
| Nisha | jlvllal_rem morning :) | 14:53 |
| lucasagomes | morning | 14:54 |
| * jlvllal_rem is humming I'm Going Back to Cali... Trip to Santa Clara today and back this evening. | 14:54 | |
| openstackgerrit | Ana Krivokapic proposed openstack/ironic: Fix IPMI support documentation https://review.openstack.org/159153 | 14:54 |
| jroll | jlvllal_rem: wow, gonna be a long day | 14:54 |
| * jroll is done | 14:55 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Improve last_error for async exceptions https://review.openstack.org/158938 | 14:55 |
| jlvllal_rem | jroll: Yeah. Luckily Intel has a private shuttle plane. Hillsboro airport is 5 minutes from my house. And very little security. So I get to the airport 30 minutes before the flight. | 14:55 |
| jroll | nice | 14:56 |
| Nisha | hi question regarding @messaging.expected_exceptions | 14:56 |
| Nisha | If the method is to expect an exception should it be listed as @messaging.expected_exceptions? | 14:57 |
| Nisha | it may raise another exception after catching that exception | 14:57 |
| jroll | Nisha: that's for RPC methods only | 14:57 |
| Nisha | yes, i am asking for that | 14:57 |
| jroll | ok, those are exceptions that the RPC method may raise | 14:58 |
| jroll | to be sent back to the rpc client | 14:58 |
| Nisha | jroll, for example deploy will first validate power and deploy before starting the actual deploy | 14:59 |
| Nisha | ohk i see | 15:00 |
| *** mgoddard1 has joined #openstack-ironic | 15:01 | |
| jroll | bbiab | 15:02 |
| *** mgoddard has quit IRC | 15:03 | |
| rameshg87 | rloo, hey | 15:04 |
| rloo | hi rameshg87 | 15:04 |
| rameshg87 | rloo, got some time for https://review.openstack.org/#/c/158243/2/specs/kilo/capabilties.rst ? | 15:04 |
| rloo | rameshg87: no. | 15:05 |
| rameshg87 | rloo, i just want to discuss why you ran out of steam reading this ? if i can understand why is that | 15:05 |
| rloo | rameshg87: sort of joking. I don't know yet. | 15:05 |
| rloo | rameshg87: I feel like I'm behind in reviewing code patches. | 15:05 |
| rameshg87 | rloo, okay, but is it the writing that is causing confusion there ? | 15:05 |
| rloo | rameshg87: i have a problem with reading. I read and try to understand every line. (grammatical etc). | 15:06 |
| rloo | rameshg87: which is a bad thing | 15:06 |
| NobodyCam | morning rameshg87 .. I wanted to let you know I resased a couple of your patches yesterday | 15:06 |
| rameshg87 | rloo, most of the stuff in there is just gonna be documentation | 15:06 |
| rloo | rameshg87: so when i find myself getting frustrated trying to understand something | 15:06 |
| NobodyCam | :-p | 15:06 |
| rloo | rameshg87: i give up | 15:06 |
| rameshg87 | NobodyCam, i saw, thanks. i just addressed some nits like commit msg there today | 15:06 |
| NobodyCam | rloo: rameshg87: I read that last night | 15:07 |
| rloo | rameshg87: it has to do with writing, logical flow of ideas, etc. which i don't think we/i want to impose and people would kill me if I did | 15:07 |
| NobodyCam | and for me it boils down to "Change ``boot_option`` to ``localboot``." | 15:07 |
| rloo | rameshg87: it is just 'me' I think | 15:07 |
| rloo | rameshg87: see. NobodyCam was able to figure it out | 15:07 |
| rameshg87 | rloo, if it's something i can improve in the writing, i am open to hear that. but i didn't get that from you. | 15:07 |
| rameshg87 | rloo, okay. | 15:07 |
| rameshg87 | NobodyCam, yes | 15:08 |
| rameshg87 | NobodyCam, just wanted to hear opinions on changing boot_option to localboot | 15:08 |
| *** openstackgerrit has quit IRC | 15:08 | |
| rameshg87 | NobodyCam, are we gonna have a third boot_option some day | 15:08 |
| rloo | rameshg87: that's cuz when i read, i dive into each sentence (so i don't see the forest for the trees) | 15:08 |
| NobodyCam | I think that is ok, but the spec is confusing I musy say | 15:08 |
| rameshg87 | :D | 15:08 |
| NobodyCam | :) | 15:08 |
| *** Nisha_away has joined #openstack-ironic | 15:08 | |
| *** openstackgerrit has joined #openstack-ironic | 15:08 | |
| rameshg87 | lucasagomes, don't know if you want to pitch in here | 15:09 |
| * lucasagomes is in a call | 15:09 | |
| *** Nisha has quit IRC | 15:09 | |
| rameshg87 | NobodyCam, lucasagomes didn't want to change the capabilities parameter boot_option to localboot to allow for a third boot_option (other than "netboot" or "local" to come in some other day) | 15:09 |
| NobodyCam | rameshg87: am I correct that this is change boot_option to localboot and a bunch of documataion improvements? | 15:09 |
| rameshg87 | NobodyCam, exactly | 15:09 |
| rameshg87 | rloo, ^^^ this is all :) | 15:10 |
| NobodyCam | :) | 15:10 |
| openstackgerrit | Merged openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/159038 | 15:10 |
| NobodyCam | I need a couple of minutes here.. and will brb. lets chat in like 10 min.. | 15:10 |
| rameshg87 | NobodyCam, rloo, what do you think about changing (boot_option="local" or "netboot") to (localboot="true" or "false") ? | 15:11 |
| rameshg87 | sure .. | 15:11 |
| NobodyCam | but I want to include lucasagomes :) | 15:11 |
| NobodyCam | ok brb | 15:11 |
| rloo | rameshg87: oh. I don't have any opinion right now. does the spec provide a rationale for changing it? | 15:11 |
| rameshg87 | rloo, just the term being more friendly for the end-user | 15:12 |
| rloo | rameshg87: end-user == operator? | 15:12 |
| rameshg87 | rloo, someone saying "i need a node with boot_option=local" | 15:13 |
| rameshg87 | rloo, as against saying "i need a node with localboot=true" | 15:13 |
| rameshg87 | rloo, this requires configuration from both nova user (who writes flavor properties) and ironic operator (who adds node.properties/capbilities for node) | 15:13 |
| rloo | rameshg87: so if there was some third option in the future, 'fooboot', you'd have localboot=false netboot=false fooboot=true? | 15:14 |
| rameshg87 | rloo, for the nova user, it's just fooboot=true | 15:15 |
| rloo | rameshg87: ie, it makes sense to have localboot=true if there are only two options; true/false. | 15:15 |
| *** Nisha has joined #openstack-ironic | 15:15 | |
| rloo | rameshg87: what if they specified localboot=true too? | 15:15 |
| rloo | rameshg87: vs boot_option=value. no way they can mess that up. | 15:15 |
| rameshg87 | rloo, ah error :) | 15:15 |
| rameshg87 | rloo, yeah that's upto whether we will have fooboot someday | 15:16 |
| *** Nisha_away has quit IRC | 15:16 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Support for non-Glance image references https://review.openstack.org/136741 | 15:16 |
| rameshg87 | rloo, for now with netboot being default, don't provide anything | 15:16 |
| rameshg87 | rloo, you want something different, a node that boots locally (as opposed what is being done normally), give localboot=true | 15:16 |
| rloo | rameshg87: it is a good question, because it seems like other capabilities will be similar. do we go with CapabilityX: true/false, or CapabilityX:<some value> | 15:17 |
| rameshg87 | rloo, yeah | 15:17 |
| rameshg87 | rloo, every capability cannot be like CapabilityX: true/false | 15:17 |
| rameshg87 | rloo, for example raid_level | 15:18 |
| rloo | rameshg87: not every capability. some others maybe. | 15:18 |
| rameshg87 | rloo, yeah | 15:18 |
| rloo | rameshg87: eg, if capX can have values V1, V2, V3. You could change it to 3 capabilities: capV1:true/false, capV2:true/false, capV3:true/false | 15:19 |
| rameshg87 | rloo, again, all capabilities or only *some* capabilities ? | 15:20 |
| rloo | rameshg87: huh? depends on a particular capability. | 15:20 |
| trown | true/false for something that is not binary is a bit odd to me | 15:20 |
| *** ChuckC has quit IRC | 15:20 | |
| *** ChuckC has joined #openstack-ironic | 15:21 | |
| rameshg87 | rloo, okay. | 15:21 |
| trown | especially if there is no case where more than one would be true | 15:21 |
| rameshg87 | rloo, if there's a lot of uncertainitly in changing boot_option to localboot, i think rather think we leave it | 15:21 |
| lucasagomes | I the reason why boot_option=value was picked was to be open ground, idk there's weird stuff going on when booting a OS | 15:22 |
| lucasagomes | for e.g | 15:22 |
| rloo | rameshg87: I don't think I answered your original question cuz I still don't have an opinion. You could be right. | 15:22 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Support for non-Glance image references https://review.openstack.org/136741 | 15:22 |
| lucasagomes | you can have netboot but actually boot from local (for windows) | 15:22 |
| lucasagomes | the PXE will just chainload to the local bootloader | 15:22 |
| lucasagomes | but still need to pxe | 15:22 |
| JayF | lucasagomes: happy birthday | 15:22 |
| lucasagomes | JayF, thanks man :) | 15:22 |
| rameshg87 | lucasagomes, but it's still netboot | 15:22 |
| trown | whoa. happy birthday lucasagomes | 15:22 |
| BadCub | Happy Sapwning Day lucasagomes | 15:22 |
| rameshg87 | oh .. happy birthday lucasagomes | 15:22 |
| lucasagomes | rameshg87, right, but it would boot from local too (if powered on manually) | 15:22 |
| BadCub | SPAWNING that is | 15:22 |
| *** mordred has quit IRC | 15:22 | |
| *** mordred has joined #openstack-ironic | 15:22 | |
| rloo | oh, happy birthday lucasagomes! | 15:22 |
| rameshg87 | lucasagomes, ah correct | 15:23 |
| lucasagomes | hah thank you all :) | 15:23 |
| trown | SPAWN* | 15:23 |
| rameshg87 | lucasagomes, then it's local and netboot. what would you call that ? | 15:23 |
| rameshg87 | :D | 15:23 |
| rameshg87 | rloo, there you go, you can have a node with both localboot=true and netboot=true :D | 15:23 |
| lucasagomes | rameshg87, idk, it's more about being conservative. I also don't have a strong opnion about it, and maybe leaving the value open can be a bit of overengineering | 15:23 |
| lucasagomes | but you know, it may be used in the future | 15:24 |
| lucasagomes | rameshg87, ive no clue how I would call that | 15:24 |
| rloo | rameshg87: ha ha. that can be done as well by boot_option = [localboot, netboot] | 15:24 |
| lucasagomes | but that's why I left it open, people have odd stuff when booting machines | 15:24 |
| rloo | rameshg87: and if order is important, you can list them in the desired order ;) | 15:24 |
| rameshg87 | rloo, ha ha :) | 15:25 |
| lucasagomes | that's not bad actually. Since flavors can use "<in>" operator. We may be able to say this node can either boot from local or netboot | 15:25 |
| rameshg87 | lucasagomes, <in> operator is very dangerous | 15:26 |
| lucasagomes | and it will depend on the flavor | 15:26 |
| rameshg87 | lucasagomes, it is actually a substring match | 15:26 |
| rloo | rameshg87: i think if we go with something can we can easily change and provide backwards compatibility, we'll be ok. (but we should minimize any changes needed to nova.virt.ironic driver) | 15:26 |
| lucasagomes | rameshg87, yeah, all that computecapabilitiesfilter looks a bit obscure to me | 15:26 |
| rameshg87 | lucasagomes, you can give "<in> lo" as well | 15:26 |
| lucasagomes | damn hah | 15:26 |
| rameshg87 | lucasagomes, node will get selected by nova scheduler and will fail at ironic's node-validate | 15:27 |
| lucasagomes | right | 15:27 |
| lucasagomes | so we are a bit off topic | 15:27 |
| lucasagomes | I'm +0 on the localboot=True/False | 15:28 |
| rameshg87 | +0 i assume leave the code now as it is | 15:28 |
| rameshg87 | correct ? | 15:28 |
| rameshg87 | that's an opinion :) | 15:28 |
| lucasagomes | I don't have any other alternative in mind for boot_option=value, but I see someone might finding use for it in the future | 15:28 |
| lucasagomes | rameshg87, heh yeah, I'm happy either keeping as-is or changing to localboot=True/False. The majority wins | 15:28 |
| rameshg87 | rloo, trown, NobodyCam, folks who were talking - +0, +1, -1 ??? | 15:29 |
| rameshg87 | not a vote count here, but wanted to know quick thoughts | 15:29 |
| rloo | rameshg87: no opinion still. sorry. | 15:29 |
| rameshg87 | okay | 15:29 |
| rameshg87 | i will do one thing, i will remove the change of boot_option to localboot from proposed change | 15:30 |
| rameshg87 | and put it in alternatives in spec if someone still wants to look at it | 15:30 |
| rameshg87 | and then the rest is documentation on how to use it. i will keep it open for a day or two. | 15:31 |
| trown | rameshg87: I do not have an opinion either, as there is an example where multiple True options could be valid | 15:31 |
| rameshg87 | trown, okay | 15:31 |
| rameshg87 | and then i will raise a change in our docs | 15:31 |
| rameshg87 | lucasagomes, rloo, looks fine ? ^^^ | 15:31 |
| lucasagomes | rameshg87, sure | 15:32 |
| rameshg87 | okay. thanks... | 15:32 |
| rloo | rameshg87: well, that is fine with me, although it seems like you could just delete all that stuff in the spec wrt documentation, and put up a documentation patch. just leave the proposal about localboot, bootoption there. | 15:33 |
| * NobodyCam is back | 15:33 | |
| rameshg87 | rloo, okay, that seems better to me. just doc patch. | 15:33 |
| rloo | rameshg87: so I don't have to review the spec wrt documentaiton, and then review the actual documentation patch ;) | 15:34 |
| rameshg87 | rloo, okay | 15:34 |
| *** anderbubble has joined #openstack-ironic | 15:34 | |
| rameshg87 | NobodyCam, you might need to scroll up a little :) | 15:34 |
| NobodyCam | lucasagomes: your okay with changing boot_option to localboot? I think rameshg87 makes a good case for compatiably with nova | 15:35 |
| rameshg87 | NobodyCam, lucasagomes was +0 on it. no opinion. :) | 15:36 |
| lucasagomes | NobodyCam, I'm +0 on it | 15:36 |
| jroll | lucasagomes: happy birthday, apparently :D /me passes the beer | 15:37 |
| jroll | rameshg87: I'm -1 on localboot=true, I don't see much value in that | 15:37 |
| lucasagomes | NobodyCam, like I don't have a strong use case to keep boot_option=value, but I think that someone might do | 15:37 |
| NobodyCam | oh yes happy birthday lucasagomes | 15:37 |
| rameshg87 | jroll, okay .. | 15:37 |
| lucasagomes | NobodyCam, cause booting a machine is complex today, and even local boot can have it's own flavors | 15:37 |
| jroll | rameshg87: I haven't read the full spec, though, what's the case NobodyCam mentioned about nova compatibility? | 15:38 |
| *** rameshg87 is now known as rameshg87-brb | 15:38 | |
| lucasagomes | localboot checking keys, localboot insecure local boot etc | 15:38 |
| *** rameshg87-brb has quit IRC | 15:38 | |
| lucasagomes | netboot and localboot | 15:38 |
| lucasagomes | idk | 15:38 |
| lucasagomes | NobodyCam, thank you :) | 15:38 |
| *** hj-hp has joined #openstack-ironic | 15:39 | |
| lucasagomes | NobodyCam, leaving it open, at least when I first thought about it, sounded correct to me. Cause people might want to have differentiate types of localboot's | netboot's | other's | 15:39 |
| jroll | yeah, I think we're going to end up with a third option | 15:40 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: PXE drivers support for IPA https://review.openstack.org/155728 | 15:40 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: PXE driver: Deprecate pxe_deploy_{ramdisk, kernel} https://review.openstack.org/158644 | 15:40 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Local boot support for IPA https://review.openstack.org/157723 | 15:40 |
| jroll | and I don't see much gain from changing it | 15:40 |
| NobodyCam | jroll: what do you see as thrid option? | 15:40 |
| jroll | NobodyCam: I'm not sure, but I know someone will come up with something crazy | 15:40 |
| jroll | dvd-boot | 15:41 |
| jroll | vmedia-boot | 15:41 |
| jroll | usb-boot | 15:41 |
| JayF | jroll: pxe-pxe | 15:41 |
| JayF | lol | 15:41 |
| dtantsur | torrent-boot Oo | 15:41 |
| jroll | embedded-ramdisk-boot | 15:41 |
| jroll | dtantsur: ++ | 15:41 |
| dtantsur | torrent boot is a nice feature for windows support! :D | 15:41 |
| JayF | There's a guy internal rackspace | 15:41 |
| JayF | who wants to push out ephemeral OSes | 15:42 |
| JayF | using a bootable Configdrive | 15:42 |
| NobodyCam | all valid! | 15:42 |
| jroll | ya | 15:42 |
| JayF | I'm generally against it mainly b/c of the engineering problems it causes our implementation of Configdrive :P | 15:42 |
| lucasagomes | hah | 15:42 |
| JayF | but we should be careful not to assume we know all the clever things folks will come up with later, lol | 15:42 |
| lucasagomes | JayF, +1 yeah, that's was my assumption when I made it multiple values instead of boolean | 15:43 |
| NobodyCam | but a localboot=bool would not support that unless we have like several options and I'm not super fond of that | 15:43 |
| lucasagomes | cause I really don't know what people might come up with | 15:43 |
| NobodyCam | did we loose rameshg87 | 15:44 |
| *** lazy_prince is now known as killer_prince | 15:44 | |
| jroll | apparently | 15:44 |
| NobodyCam | :( | 15:44 |
| jroll | I guess I'll have to leave a note on gerrit :P | 15:45 |
| *** erwan_taf has joined #openstack-ironic | 15:45 | |
| NobodyCam | :) | 15:46 |
| jroll | mmmkay, done | 15:53 |
| *** rameshg87 has joined #openstack-ironic | 15:57 | |
| Nisha | happy birthday lucasagomes | 15:58 |
| lucasagomes | thank you very much Nisha :) | 15:59 |
| *** rameshg87_ has joined #openstack-ironic | 15:59 | |
| rameshg87_ | jroll, NobodyCam, can you please have a look at if you have some time https://review.openstack.org/#/c/156587/ | 16:02 |
| *** rameshg87 has quit IRC | 16:03 | |
| NobodyCam | rameshg87_: will do | 16:04 |
| jroll | NobodyCam: do you want to look before I +A that? | 16:07 |
| *** rameshg87_ has quit IRC | 16:08 | |
| NobodyCam | jroll: I'm about to +2 want me to +a at the same time | 16:08 |
| jroll | ya, I already +2 | 16:09 |
| *** jcoufal has quit IRC | 16:09 | |
| NobodyCam | come on down 156587 | 16:09 |
| *** jcoufal has joined #openstack-ironic | 16:09 | |
| NobodyCam | your the patch on Ironic is right | 16:09 |
| jroll | lol | 16:10 |
| NobodyCam | :) | 16:10 |
| *** ChuckC has quit IRC | 16:13 | |
| *** ChuckC has joined #openstack-ironic | 16:13 | |
| *** MattMan has joined #openstack-ironic | 16:16 | |
| openstackgerrit | Merged openstack/ironic: Add support for 'latest' in microversion header https://review.openstack.org/158601 | 16:20 |
| *** achanda has joined #openstack-ironic | 16:24 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add find_nodes() helper to the conductor manager https://review.openstack.org/159100 | 16:26 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add module for in-band inspection using ironic-discoverd https://review.openstack.org/156562 | 16:26 |
| NobodyCam | anyone know if there is a spec for : https://blueprints.launchpad.net/ironic/+spec/uefi-secure-boot-management-interfaces | 16:26 |
| lucasagomes | can I have multiple Depends-On in the commit message? | 16:27 |
| NobodyCam | lucasagomes: yes as I understand it | 16:27 |
| lucasagomes | cool | 16:27 |
| *** coolsvap is now known as coolsvap_ | 16:28 | |
| lucasagomes | IPA + iSCSI support for devstack https://review.openstack.org/#/c/159178/ | 16:28 |
| lucasagomes | pretty small changes :) | 16:28 |
| lucasagomes | not sure if the best name for that option too tho | 16:29 |
| lucasagomes | jroll, when you get a time mind taking a look at the iscsi extension for IPA? If we get that merged and the first patch of the series in Ironic also merged, we can go ahead and create a new job in gate | 16:31 |
| lucasagomes | well devstack as well needs to get merged | 16:31 |
| jroll | lucasagomes: yeah, going to try to get some reviews in today | 16:31 |
| JayF | I'm looking at the devstack patch now :) | 16:31 |
| lucasagomes | cool thank you | 16:31 |
| *** rwsu-afk has quit IRC | 16:31 | |
| lucasagomes | JayF, it's tiny :) if u wanna try locally | 16:31 |
| *** enpicket1 has left #openstack-ironic | 16:31 | |
| lucasagomes | JayF, you need to apply https://review.openstack.org/155728 in Ironic and the iscsi extension on IPA (what I do here is, I clone ironic-python-agent under /opt/stack/ironic-python-agent and apply the patch there) | 16:32 |
| lucasagomes | so devstack can run and create the image for me | 16:32 |
| lucasagomes | and the rest is the same | 16:33 |
| JayF | I'm just reading the code now :) | 16:33 |
| JayF | at an internal conference | 16:33 |
| JayF | just generally wondering if we need to refactor how that stuff works in devstack | 16:33 |
| JayF | we talk about the agent both as a ramdisk and a driver in kinda the "same way" in devstack | 16:33 |
| jroll | what, you don't want to run devstack on conference wifi | 16:33 |
| jroll | ? | 16:33 |
| JayF | I don't want to run devstack ever | 16:34 |
| JayF | lol | 16:34 |
| jroll | :| | 16:34 |
| *** purp has quit IRC | 16:34 | |
| JayF | I'm wondering if we should have something like USE_AGENT that is set for pxe_ssh via agent and agent_ssh | 16:34 |
| JayF | and key off that | 16:34 |
| *** ParsectiX has joined #openstack-ironic | 16:34 | |
| *** mgoddard1 has quit IRC | 16:35 | |
| *** achanda has quit IRC | 16:36 | |
| *** mgoddard has joined #openstack-ironic | 16:36 | |
| *** Marga_ has joined #openstack-ironic | 16:38 | |
| *** Marga__ has joined #openstack-ironic | 16:38 | |
| lucasagomes | JayF, yeah I think that later we will want to have devstack using IPA for all both drivers by default. Then we can refactor some stuff there | 16:41 |
| *** Marga_ has quit IRC | 16:42 | |
| lucasagomes | now in Ironic, yeah idk what we can do in the future, but it would be even possible to have 1 driver that does different types of deployments if we want :) | 16:42 |
| lucasagomes | same ramdisk, different stuff | 16:42 |
| JayF | exactly | 16:42 |
| *** openstackstatus has joined #openstack-ironic | 16:42 | |
| *** ChanServ sets mode: +v openstackstatus | 16:42 | |
| JayF | your approach is better though, no need to make this better if we can just eliminate the old ramdisk | 16:42 |
| lucasagomes | JayF, yeah, I think that's the idea, but we should support it for a while to be backwards compat | 16:43 |
| lucasagomes | I mean the bash ramdisk | 16:43 |
| JayF | bash ramdisk is a good thing to call it | 16:44 |
| JayF | because I enjoy bashing it | 16:44 |
| JayF | :P | 16:44 |
| *** jcoufal has quit IRC | 16:44 | |
| lucasagomes | lol | 16:51 |
| lucasagomes | JayF, we said default before, but I want that to change | 16:51 |
| JayF | +9001 | 16:51 |
| *** rwsu has joined #openstack-ironic | 16:52 | |
| NobodyCam | JayF: is that like ISO-9001? | 16:53 |
| JayF | it's over 9000 | 16:54 |
| JayF | if you don't get the reference I can link the video when I'm not in the 3rd row of a conference :P | 16:55 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: PXE drivers support for IPA https://review.openstack.org/155728 | 16:59 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: PXE driver: Deprecate pxe_deploy_{ramdisk, kernel} https://review.openstack.org/158644 | 16:59 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Local boot support for IPA https://review.openstack.org/157723 | 16:59 |
| *** mgoddard1 has joined #openstack-ironic | 17:00 | |
| lucasagomes | rebasing hell! | 17:00 |
| jgrimm | lucasagomes, i was trying out boot_option:local with the pxe driver.. not successful yet, but feels like i'm close.. | 17:01 |
| jroll | lucasagomes: welcome to my world :D | 17:01 |
| lucasagomes | jgrimm, right, keep in mind that the image needs to include grub2 | 17:01 |
| jgrimm | lucasagomes, failing at grub-install in the deploy.. | 17:01 |
| lucasagomes | jgrimm, I need to document stuff yet | 17:01 |
| jgrimm | lucasagomes, yeah, that's what i was going to ask about.. what images are you testing with | 17:01 |
| *** mgoddard has quit IRC | 17:02 | |
| lucasagomes | jgrimm, I used a fedora image I had, mounted it and installed grub2 on it | 17:02 |
| jgrimm | lucasagomes, i was trying DIB generated ubuntu and fedora (ubuntu didn't have it installed, fedora seems misconfigured) | 17:02 |
| jgrimm | lucasagomes, ok, whew.. thought i was missing something | 17:02 |
| lucasagomes | jgrimm, right, not sure they install grub2 by default on those images tho. ramesh was looking into it I think | 17:02 |
| *** dtantsur is now known as dtantsur|afk | 17:02 | |
| *** hj-hp has quit IRC | 17:02 | |
| jgrimm | lucasagomes, thanks for confirmation! | 17:03 |
| *** hj-hp has joined #openstack-ironic | 17:03 | |
| lucasagomes | np :) | 17:03 |
| *** romcheg has quit IRC | 17:11 | |
| *** Hefeweizen has joined #openstack-ironic | 17:12 | |
| *** Marga__ has quit IRC | 17:12 | |
| jgrimm | lucasagomes, oh.. another question, should netboot work? any gotchas to watch out for? i have a colleague about ready to try that, so thought i'd ask | 17:16 |
| lucasagomes | jgrimm, netboot? that's the default so yes it should work fine | 17:16 |
| jgrimm | ok, thanks | 17:17 |
| *** pas-ha has quit IRC | 17:18 | |
| lucasagomes | np | 17:18 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement execute clean steps https://review.openstack.org/155561 | 17:19 |
| *** jistr has quit IRC | 17:22 | |
| *** erwan_taf has quit IRC | 17:25 | |
| *** rwsu has quit IRC | 17:29 | |
| *** viktors is now known as viktors|afk | 17:29 | |
| *** trown is now known as trown|lunch | 17:31 | |
| NobodyCam | jroll: have yoy seen 158938 fails on test_heartbeat_deploy_done_fails test? | 17:32 |
| *** rwsu has joined #openstack-ironic | 17:34 | |
| *** Nisha has quit IRC | 17:34 | |
| NobodyCam | lucasagomes: quick question: https://review.openstack.org/#/c/155727/4/ironic_python_agent/extensions/iscsi.py your using import uuid any reason you didn't use oslo_utils.uuidutils? | 17:37 |
| lucasagomes | NobodyCam, sure | 17:37 |
| lucasagomes | NobodyCam, hmm no reason... maybe I should use oslo? | 17:38 |
| lucasagomes | will check uuidutils from oslo | 17:38 |
| jroll | NobodyCam: lame, will fix soonish | 17:38 |
| NobodyCam | :-p | 17:38 |
| lucasagomes | https://github.com/openstack/oslo.utils/blob/master/oslo_utils/uuidutils.py | 17:39 |
| lucasagomes | heh well, it doesn't do much, but yeah I can use it | 17:39 |
| NobodyCam | yea but I've seen it in use more then just uuid | 17:40 |
| lucasagomes | NobodyCam, right, I will add a new patch-set using oslo | 17:40 |
| lucasagomes | NobodyCam, that's the only fix? | 17:41 |
| devananda | g'morning, all | 17:41 |
| lucasagomes | devananda, mornig | 17:41 |
| lucasagomes | morning* | 17:41 |
| NobodyCam | good morning devananda :) | 17:41 |
| NobodyCam | lucasagomes: still looking | 17:41 |
| lucasagomes | NobodyCam, ack thanks :) I will fix it after comments | 17:42 |
| NobodyCam | :) | 17:42 |
| NobodyCam | i'll post on the review | 17:42 |
| lucasagomes | NobodyCam, thanks | 17:44 |
| *** Marga_ has joined #openstack-ironic | 17:47 | |
| *** Marga_ has quit IRC | 17:48 | |
| *** Marga_ has joined #openstack-ironic | 17:48 | |
| *** EmilienM is now known as EmilienM|afk | 17:49 | |
| openstackgerrit | Merged openstack/ironic: Root partition should be bootable for localboot https://review.openstack.org/156587 | 17:49 |
| NobodyCam | lucasagomes: reviewed | 17:50 |
| lucasagomes | NobodyCam, thanks much | 17:50 |
| lucasagomes | NobodyCam, ok if needed I push a new patch with the uuidutils :) | 17:51 |
| *** mgoddard1 has quit IRC | 17:52 | |
| NobodyCam | :) ya thats a super minor thing. | 17:53 |
| *** yog_ has joined #openstack-ironic | 17:53 | |
| lucasagomes | right | 17:54 |
| *** mgoddard has joined #openstack-ironic | 17:54 | |
| *** derekh has quit IRC | 17:56 | |
| *** ijw has joined #openstack-ironic | 17:59 | |
| openstackgerrit | Merged openstack/ironic: Fix IPMI support documentation https://review.openstack.org/159153 | 18:01 |
| openstackgerrit | Merged openstack/ironic: Add documentation for VirtualBox drivers https://review.openstack.org/146307 | 18:03 |
| dhellmann | devananda: I saw in yesterday's tc meeting that you wanted to chat about ironic-lib? | 18:05 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Improve last_error for async exceptions https://review.openstack.org/158938 | 18:05 |
| *** hj-hp has quit IRC | 18:05 | |
| devananda | dhellmann: hi! yep. we have some code tht we want to share between projects in ironic | 18:06 |
| devananda | dhellmann: and some folks (jroll?) have strong opinions on where it should go | 18:06 |
| dhellmann | ok | 18:06 |
| devananda | I do not. I think my first suggestion was oslo-incubator | 18:06 |
| dhellmann | is it useful to projects outside of ironic? | 18:06 |
| devananda | because that's what we used to do | 18:06 |
| devananda | dhellmann: probably not. at lesat not that we know of | 18:06 |
| dhellmann | ok, it probably doesn't need to go through the incubator then | 18:06 |
| devananda | code in question is a wrapper for partition creation and management | 18:07 |
| jroll | my proposal: make an ironic-lib. put it under ironic program. if we decide that other projects should use it, put it in the oslo program with the same name. | 18:07 |
| jroll | I think we tend to stuff too many things into oslo-incubator, in general | 18:07 |
| dhellmann | jroll: it's entirely possible for the ironic team to own a lib used by other projects, too | 18:07 |
| jroll | dhellmann: sure :) | 18:08 |
| jroll | jogo also had opinions on this iirc | 18:08 |
| dhellmann | devananda: so if it's really just a lib for ironic for now, I would look at filter_git_history.sh in oslo-incubator/tools as a way to export the history for the subset of the files you care about, and then clean up the results to create the library | 18:08 |
| lucasagomes | folks I will call it a day :) | 18:08 |
| lucasagomes | have a good night everyone | 18:09 |
| devananda | g'night, lucasagomes o/ | 18:09 |
| * lucasagomes go for beers to celebrate his bd | 18:09 | |
| lucasagomes | devananda, night! | 18:09 |
| *** lucasagomes is now known as lucas-beer | 18:09 | |
| devananda | lucasagomes: ooh! happy bday! | 18:09 |
| lucas-beer | devananda, :D thank you! | 18:09 |
| devananda | dhellmann: filterbranch ++ | 18:09 |
| NobodyCam | lucas-beer: have a pint for /me | 18:09 |
| jogo | jroll: ++ to not going into oslo-incubator | 18:09 |
| *** Marga_ has quit IRC | 18:10 | |
| jroll | night lucas-beer, happy birthday :) | 18:10 |
| *** Marga_ has joined #openstack-ironic | 18:10 | |
| *** pas-ha has joined #openstack-ironic | 18:16 | |
| *** athomas has quit IRC | 18:18 | |
| *** jlvllal_sfo has joined #openstack-ironic | 18:20 | |
| *** jlvllal_sfo is now known as jlvillal_30k_ft | 18:20 | |
| *** hj-hp has joined #openstack-ironic | 18:21 | |
| *** jlvillal_30k_ft has quit IRC | 18:26 | |
| *** jlvillal_30k_ft has joined #openstack-ironic | 18:27 | |
| *** hj-hp has quit IRC | 18:32 | |
| *** BertieFulton has joined #openstack-ironic | 18:32 | |
| *** kejiahu has quit IRC | 18:37 | |
| *** jlvillal_30k_ft has quit IRC | 18:38 | |
| *** pas-ha has quit IRC | 18:43 | |
| *** achanda has joined #openstack-ironic | 18:47 | |
| *** kbs has quit IRC | 18:47 | |
| *** jlvillal_30k_ft has joined #openstack-ironic | 18:49 | |
| *** ChuckC has quit IRC | 18:49 | |
| *** kbs has joined #openstack-ironic | 18:50 | |
| *** kbs has quit IRC | 18:53 | |
| *** jlvillal_30k_ft has quit IRC | 18:54 | |
| *** ParsectiX has quit IRC | 18:54 | |
| *** ParsectiX has joined #openstack-ironic | 18:54 | |
| *** ParsectiX has quit IRC | 18:55 | |
| *** pelix has quit IRC | 18:55 | |
| *** pas-ha has joined #openstack-ironic | 18:55 | |
| *** ParsectiX has joined #openstack-ironic | 18:55 | |
| *** romcheg has joined #openstack-ironic | 18:56 | |
| *** Marga_ has quit IRC | 18:58 | |
| *** Marga_ has joined #openstack-ironic | 18:58 | |
| NobodyCam | devananda: are you around? | 19:01 |
| *** romcheg has quit IRC | 19:03 | |
| *** chuckC_ has joined #openstack-ironic | 19:14 | |
| *** ijw has quit IRC | 19:15 | |
| *** ijw has joined #openstack-ironic | 19:15 | |
| *** andreykurilin_ has joined #openstack-ironic | 19:15 | |
| *** romcheg has joined #openstack-ironic | 19:18 | |
| *** BadCub is now known as BadCub_Lunch-y_T | 19:19 | |
| *** ifarkas has quit IRC | 19:19 | |
| *** Marga_ has quit IRC | 19:20 | |
| *** Marga_ has joined #openstack-ironic | 19:20 | |
| *** trown|lunch is now known as trown | 19:24 | |
| *** sdake has joined #openstack-ironic | 19:24 | |
| *** sdake has joined #openstack-ironic | 19:24 | |
| *** achanda has quit IRC | 19:27 | |
| *** achanda has joined #openstack-ironic | 19:27 | |
| *** dprince has quit IRC | 19:34 | |
| *** absubram has joined #openstack-ironic | 19:50 | |
| *** dprince has joined #openstack-ironic | 19:54 | |
| *** achanda has quit IRC | 20:00 | |
| *** pcrews has quit IRC | 20:02 | |
| *** ChuckC has joined #openstack-ironic | 20:07 | |
| *** achanda has joined #openstack-ironic | 20:08 | |
| *** chuckC_ has quit IRC | 20:08 | |
| NobodyCam | gah dumb question (and i know has been asked before) do we need "_()" for log messages? | 20:08 |
| rloo | NobodyCam: yes. or one of the variations of that. | 20:08 |
| NobodyCam | ref: line 136 of https://review.openstack.org/#/c/151596/21/ironic/drivers/modules/ilo/inspect.py | 20:08 |
| *** ijw has quit IRC | 20:08 | |
| NobodyCam | and line 148 ... etc | 20:08 |
| rloo | Nohttp://docs.openstack.org/developer/oslo.i18n/guidelines.html | 20:09 |
| rloo | NobodyCam: I suppose you could give them the link to the guidelines | 20:10 |
| rloo | NobodyCam: for exceptions, it should be _LE(). | 20:11 |
| NobodyCam | rloo: ack | 20:11 |
| rloo | NobodyCam: sorry, for LOG.exception, use _LE(). For raising exceptions, use _(). | 20:11 |
| NobodyCam | thou it seems by the guide you linked _() would also work | 20:11 |
| NobodyCam | ya | 20:11 |
| openstackgerrit | Merged openstack/python-ironicclient: For flake8 check, make the 'E12' ignore be more granular https://review.openstack.org/157929 | 20:11 |
| NobodyCam | :) | 20:11 |
| rfchapman | NobodyCam: How ya doin'? I swapped out the initrd and kernel and still have the issue with the USB controller locking up during boot. I have tried three machines and all are doing it. I don't know what changed as all I changed was the disk size on the "flavor". | 20:12 |
| NobodyCam | will comment on the review... Thank you rloo :) | 20:12 |
| rloo | yw NobodyCam | 20:12 |
| NobodyCam | rfchapman: and the node properites too? | 20:12 |
| NobodyCam | rfchapman: give me a minute to wrap up the review I'm on atm | 20:13 |
| rfchapman | Hummm, let me check | 20:13 |
| rfchapman | Thanks | 20:13 |
| NobodyCam | rfchapman: almost ready.. need a couple more min. going to run outside for a quick smoke :) | 20:24 |
| * NobodyCam is back | 20:31 | |
| *** marzif_ has joined #openstack-ironic | 20:33 | |
| *** pcrews has joined #openstack-ironic | 20:34 | |
| NobodyCam | gah... brb | 20:46 |
| *** achanda has quit IRC | 20:47 | |
| *** achanda has joined #openstack-ironic | 20:47 | |
| NobodyCam | and back again :-p | 20:50 |
| *** marzif_ has quit IRC | 20:51 | |
| *** dprince has quit IRC | 20:54 | |
| *** spandhe has joined #openstack-ironic | 20:55 | |
| *** BertieFulton has quit IRC | 20:57 | |
| *** romcheg has quit IRC | 20:59 | |
| *** hj-hp has joined #openstack-ironic | 21:01 | |
| *** pas-ha has quit IRC | 21:01 | |
| NobodyCam | lol: command_error = 'Gotham city is in danger!' | 21:02 |
| *** 92AAALG4Y is now known as dank_ | 21:05 | |
| *** romcheg has joined #openstack-ironic | 21:08 | |
| rfchapman | NobodyCam: I'm running to a meeting, I'll see if your around after... thanks.. | 21:12 |
| NobodyCam | ack:) | 21:12 |
| *** lucas-beer has quit IRC | 21:12 | |
| *** pcrews has quit IRC | 21:23 | |
| *** BadCub_Lunch-y_T is now known as BadCub | 21:31 | |
| NobodyCam | brb | 21:34 |
| *** ijw has joined #openstack-ironic | 21:40 | |
| *** jlvillal_30k_ft has joined #openstack-ironic | 21:43 | |
| *** jlvillal_30k_ft is now known as jlvillal_santacl | 21:43 | |
| *** jlvillal_santacl is now known as jlvillal_sc | 21:43 | |
| *** Marga_ has quit IRC | 21:53 | |
| NobodyCam | doh I have been back for awhile now :-p | 21:54 |
| *** romcheg has quit IRC | 22:09 | |
| *** pcrews has joined #openstack-ironic | 22:11 | |
| *** Marga_ has joined #openstack-ironic | 22:11 | |
| *** anderbubble has quit IRC | 22:16 | |
| *** Marga_ has quit IRC | 22:17 | |
| *** mrda-away is now known as mrda | 22:24 | |
| mrda | Morning Ironic | 22:25 |
| NobodyCam | morning mrda :) | 22:26 |
| jroll | morning mrda :) | 22:26 |
| mrda | hey all | 22:29 |
| NobodyCam | jroll: just checking on lucas' patch 155728, your good with removing rootfstype=ramfs from the pxe templates. | 22:31 |
| jroll | NobodyCam: agent uses a different pxe config | 22:31 |
| jroll | NobodyCam: though now I don't see it... | 22:33 |
| NobodyCam | https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent_config.template | 22:33 |
| NobodyCam | :-p | 22:33 |
| jroll | ah | 22:34 |
| jroll | no pxe in the name | 22:34 |
| jroll | thanks | 22:34 |
| NobodyCam | :-p | 22:34 |
| NobodyCam | yep | 22:34 |
| jroll | so ya shouldn't affect agent deploy | 22:34 |
| *** ParsectiX has quit IRC | 22:36 | |
| *** ParsectiX has joined #openstack-ironic | 22:37 | |
| *** hj-hp has quit IRC | 22:37 | |
| *** ParsectiX has quit IRC | 22:38 | |
| *** ParsectiX has joined #openstack-ironic | 22:39 | |
| *** hj-hp has joined #openstack-ironic | 22:39 | |
| *** ChuckC has quit IRC | 22:43 | |
| openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Fix PEP8 E121,E122,E123,E124,E125,E129 errors https://review.openstack.org/159279 | 22:44 |
| *** Marga_ has joined #openstack-ironic | 22:48 | |
| *** hj-hp has quit IRC | 22:49 | |
| *** jcoufal has joined #openstack-ironic | 22:50 | |
| *** Marga__ has joined #openstack-ironic | 22:51 | |
| *** Marga_ has quit IRC | 22:52 | |
| *** kbs has joined #openstack-ironic | 22:55 | |
| *** ChuckC has joined #openstack-ironic | 22:58 | |
| *** hj-hp has joined #openstack-ironic | 23:00 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Improve last_error for async exceptions https://review.openstack.org/158938 | 23:00 |
| jlvillal_sc | jroll: Can you take a peek at ^^^^ | 23:01 |
| jlvillal_sc | I added to the unit test. Hopefully that is useful... | 23:01 |
| NobodyCam | hey hey jlvillal_sc wow you have a lot of nicks to day | 23:01 |
| NobodyCam | jroll: LOL... I gave up caring about trying to keep the node id out of node.last_error | 23:02 |
| jlvillal_sc | NobodyCam: I know! remote (aka home). 30k_ft (on the Intel shuttle) and now in Santa Clara ;) | 23:02 |
| NobodyCam | :) | 23:02 |
| NobodyCam | how long are you in cali? | 23:02 |
| jlvillal_sc | NobodyCam: I forgot my laptop charger :( 47 minutes left... | 23:02 |
| NobodyCam | doh | 23:02 |
| jlvillal_sc | NobodyCam: Leave at 6;30 tonight. | 23:02 |
| jroll | we're adding unit tests for logs now | 23:02 |
| jroll | awesome | 23:02 |
| NobodyCam | :) nice | 23:02 |
| jlvillal_sc | jroll: I'm not sure if that is sarcasm or not :) | 23:03 |
| jroll | I'm not sure either :) | 23:03 |
| NobodyCam | :-p | 23:03 |
| NobodyCam | jroll: ack :) | 23:03 |
| jroll | jlvillal_sc: looks fine except: ; exception: ' | 23:03 |
| jlvillal_sc | jroll: it didn't output anything for the exception portion in the unit test. The value of the exception that is. maybe a weakness in the unittest | 23:04 |
| jlvillal_sc | LOL | 23:04 |
| jroll | there's no exception there? | 23:04 |
| jroll | hrm | 23:04 |
| jlvillal_sc | I noticed that | 23:04 |
| jlvillal_sc | See unittest maybe exposed something... Or maybe not | 23:04 |
| jlvillal_sc | I wasn't sure | 23:04 |
| NobodyCam | jlvillal_sc: remove line 157 if you push another rev | 23:05 |
| jroll | jlvillal_sc: oh, line 272 | 23:05 |
| jroll | jlvillal_sc: can do done_mock.side_effect = Exception('message!') | 23:05 |
| *** kbs has quit IRC | 23:05 | |
| jlvillal_sc | jroll: NobodyCam: Okay. | 23:06 |
| jroll | NobodyCam: jlvillal_sc don't remove line 157 :| | 23:06 |
| NobodyCam | no | 23:06 |
| jlvillal_sc | Hmmm. | 23:06 |
| jroll | that's there for a reason, git blame it if you want to know | 23:06 |
| NobodyCam | ack | 23:06 |
| jroll | tl;dr if deploy_is_done() fails in the if statement msg won't get set, without line 157 | 23:06 |
| jroll | I think there may be a unit test for this though | 23:06 |
| jroll | actually, that's the unit test being changed :D | 23:07 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Improve last_error for async exceptions https://review.openstack.org/158938 | 23:08 |
| jlvillal_sc | jroll: Fixed exception message. | 23:09 |
| jroll | thanks :) | 23:09 |
| jlvillal_sc | jroll: I hope it helps. | 23:09 |
| *** hj-hp has quit IRC | 23:10 | |
| jroll | all of the msg definitions end with a period; we can probably remove the semi-colon after %(msg)s | 23:10 |
| jroll | but it's fine | 23:10 |
| jroll | if you get really bored, feel free :P | 23:10 |
| jlvillal_sc | jroll: Sure, why not... :) | 23:11 |
| jroll | ok, I'll wait and then +1 | 23:11 |
| jroll | 3 authors and 8 patchsets on a log message change \o/ | 23:11 |
| NobodyCam | lol its been there for ever | 23:12 |
| NobodyCam | traced it back to : https://github.com/openstack/ironic/commit/3e568fbbbcc5748035c1448a0bdb26306470797c | 23:12 |
| jroll | lol | 23:12 |
| jroll | literally forever | 23:12 |
| NobodyCam | then gave up | 23:12 |
| NobodyCam | lol | 23:12 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Improve last_error for async exceptions https://review.openstack.org/158938 | 23:13 |
| jroll | NobodyCam: that was the first agent driver patch | 23:13 |
| jroll | NobodyCam: look at the AuthorDate https://review.openstack.org/#/c/158938/5..7//COMMIT_MSG | 23:13 |
| NobodyCam | yep line 412 | 23:13 |
| * jlvillal_sc goes to find a charger.... | 23:14 | |
| jroll | we've had this downstream since july :x | 23:15 |
| NobodyCam | oh | 23:15 |
| jroll | jlvillal_sc: +1'd | 23:16 |
| *** spandhe has quit IRC | 23:16 | |
| jlvillal_sc | jroll: Cool :) | 23:18 |
| *** absubram has quit IRC | 23:19 | |
| *** andreykurilin_ has quit IRC | 23:24 | |
| *** achanda has quit IRC | 23:26 | |
| *** ParsectiX has quit IRC | 23:28 | |
| *** ParsectiX has joined #openstack-ironic | 23:29 | |
| *** anderbubble has joined #openstack-ironic | 23:30 | |
| *** achanda has joined #openstack-ironic | 23:36 | |
| *** chlong has quit IRC | 23:43 | |
| *** chlong_ has quit IRC | 23:44 | |
| *** chlong has joined #openstack-ironic | 23:48 | |
| *** jlvillal_sc has quit IRC | 23:48 | |
| rfchapman | NobodyCam: OK, I'm back. | 23:51 |
| NobodyCam | rfchapman: and its all working great right ;) | 23:51 |
| NobodyCam | :-p | 23:51 |
| NobodyCam | hehehe | 23:51 |
| rfchapman | NobodyCam: :-) I wish. | 23:52 |
| NobodyCam | so If I recall correctly your getting stuck when booting the deployment ramdisk with somehting about USB? | 23:52 |
| rfchapman | NobodyCam: Yes, It stops at the USB controller reset and halts the boot. | 23:54 |
| rfchapman | I have tried three machines and all do the same thing. I have also reloaded the images. | 23:54 |
| NobodyCam | rfchapman: how much control of the hardware do you have.. like have you tried to enable or disable the usb ports on the node? | 23:55 |
| NobodyCam | because It [the deployment ramdisk] has booted before ? | 23:55 |
| rfchapman | NobodyCam: I have full control of the hardware. I havn't tried disabling it yet, primarily because it was working prior to the re-sizing of the disk in the flavor. | 23:56 |
| rfchapman | Yes | 23:56 |
| NobodyCam | ack... can you paste the nodes console errors? I have not seen this before in our deploys | 23:57 |
| rfchapman | I also created another flavor with the proper specs and that didn't work either. | 23:57 |
| NobodyCam | so I'm not 100% sure where to start, But I expect the nodes console would be as good a place as any | 23:58 |
| *** jcoufal has quit IRC | 23:58 | |
| rfchapman | OK, I'll give it a go... Also I currently have last nights deploy stuck in nova and I did the reset and delete, but it still is sticking. | 23:58 |
| NobodyCam | humm | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!