| NobodyCam | brb | 00:03 |
|---|---|---|
| devananda | jroll: looks like a real failure on stable/juno | 00:03 |
| *** oomichi has joined #openstack-ironic | 00:05 | |
| *** rodrigods is now known as rodrigod` | 00:08 | |
| *** rodrigod` is now known as rodrigods | 00:08 | |
| *** rodrigods has quit IRC | 00:09 | |
| devananda | jroll: http://logs.openstack.org/88/159588/1/check/check-grenade-dsvm-ironic-sideways/e344de7/logs/new/screen-n-api.txt.gz?level=DEBUG#_2015-02-26_22_09_39_382 | 00:09 |
| devananda | same error as on the previous run | 00:09 |
| devananda | I'm not sure why | 00:09 |
| *** naohirot has joined #openstack-ironic | 00:09 | |
| naohirot | good morning Ironic | 00:15 |
| NobodyCam | morning naohirot | 00:15 |
| mrda | hi naohirot | 00:15 |
| rfchapman | NobodyCam: Sorry I didn't make it in this morning, Had a rogue interupt that took me off into the weeds... | 00:16 |
| naohirot | good evening NobodyCam :) | 00:16 |
| naohirot | hi mrda :) | 00:16 |
| NobodyCam | rfchapman: lol NP life happens | 00:17 |
| rfchapman | Yea, it happens to the best of us :-) any how I'm starting out my day with a bit of creating a new fedora image and see what I get. | 00:18 |
| rfchapman | I don't know how the image would become corrupt, but, one three machines it has the same problem. | 00:19 |
| naohirot | devananda: Ironic team: thanks for the approval, I'm still beginner of Ironic, but I try to contribute to review towards kilo-3. | 00:20 |
| *** romcheg1 has quit IRC | 00:20 | |
| *** david-lyle is now known as david-lyle_Afk | 00:22 | |
| *** david-lyle_Afk is now known as david-lyle_afk | 00:22 | |
| NobodyCam | rfchapman: and what I found on that error you posted was all reports of actual usb hardware failures | 00:26 |
| NobodyCam | naohirot: Your no longer a beginer your a "Contributor" | 00:27 |
| rfchapman | NobodyCam: Yes, that was what I found as well.. but three machines? Also, If I hand install it gets past that spot. | 00:27 |
| NobodyCam | so I agree regen the images | 00:27 |
| NobodyCam | :) | 00:27 |
| devananda | JayF, jroll: random question -- is there still value in having a separate ironic-python-agent-core gerrit group? | 00:28 |
| NobodyCam | that sounds like a TC hat question :-p | 00:29 |
| devananda | it includes two members who are not ironic-core: russell_h and JoshNang | 00:29 |
| devananda | NobodyCam: nope. totally an ironic PTL hat question | 00:29 |
| NobodyCam | :) | 00:29 |
| devananda | how we organize our review groups is totally up to us | 00:29 |
| *** EmilienM|afk has quit IRC | 00:29 | |
| *** EmilienM has joined #openstack-ironic | 00:30 | |
| * naohirot thank for saying that :). I need to read more upper side of codes | 00:31 | |
| devananda | naohirot: i second that - you're definitely a contributor. also, are you coming to vancouver? | 00:33 |
| rfchapman | NobodyCam: how can I get ironic to give me console output during deploy? I would like to capture all of the output and not just the screen capture that I gave you yesterday. | 00:33 |
| NobodyCam | devananda: did you see this error : http://logs.openstack.org/88/159588/1/check/check-grenade-dsvm-ironic-sideways/e344de7/logs/new/screen-ir-api.txt.gz#_2015-02-26_22_09_37_566 | 00:34 |
| devananda | NobodyCam: yes. but i dont know why that's happening | 00:36 |
| naohirot | devananda: thanks devananda, regarding vancouver, I really want to attend on the spot, but likely to attend via IRC :< | 00:36 |
| devananda | oooh | 00:36 |
| devananda | 10021 WARNING wsme.api [-] Client-side error: Invalid input for field/attribute node_uuid. Value: 'None'. Mandatory field missing. | 00:36 |
| devananda | NobodyCam: this looks like the negative testing portion of tempest | 00:37 |
| naohirot | devananda: I'll be definitely on the spot in Toyoko, next to vancouver :) | 00:37 |
| devananda | which is fine - these errors are expected | 00:37 |
| devananda | naohirot: ah, of course! I'm very excited about that -- I haven't been to Tokyo before | 00:38 |
| devananda | (narita airport doesn't count) | 00:38 |
| NobodyCam | rfchapman: you'll need to set up shellinabox and set these values in the conf file: https://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L608-L631 | 00:38 |
| naohirot | devananda: I see :) | 00:38 |
| * NobodyCam is scared of Tokyo | 00:39 | |
| mrda | Tokyo is cool! Looking forward to returning (and this time with a smartphone that has GPS built in :) | 00:40 |
| naohirot | NobodyCam: oh, why? | 00:40 |
| * NobodyCam gets lost easly | 00:40 | |
| NobodyCam | hehehe | 00:40 |
| jroll | devananda: JayF if not ironic core either | 00:40 |
| naohirot | NobodyCam: yeah | 00:41 |
| mrda | (Last time I got lost, at night, in the snow, and couldn't find anyone who spoke English. But now with a GPS phone I'll feel much more comfortable!) | 00:41 |
| *** mmorais has quit IRC | 00:41 | |
| NobodyCam | lol last time /me was lost it cost him $250.00 | 00:41 |
| rfchapman | NobodyCam: Awesome, thanks I'll let you know what I find. | 00:41 |
| NobodyCam | rfchapman: :) | 00:41 |
| mrda | NobodyCam: I felt very safe in Tokyo | 00:42 |
| jroll | devananda: I certainly want JayF and JoshNang to have +2 on the agent, but otherwise I don't see a ton of value with that group | 00:42 |
| naohirot | mrda: yeah, GPS is really convenient | 00:42 |
| devananda | jroll: ack | 00:42 |
| jroll | and now I'm off to watch the red wings :D | 00:42 |
| jroll | have a good night everyone | 00:42 |
| jroll | :) | 00:42 |
| naohirot | mrda: we can go to anywhere if GPS is available | 00:42 |
| mrda | Last time I got around with just a Lonely Planet guide and had no issue, so now it will be a much better experience | 00:43 |
| * NobodyCam packs a towel and feels safe | 00:44 | |
| mrda | lol | 00:44 |
| NobodyCam | ;) | 00:44 |
| * naohirot looks nice http://www.lonelyplanet.com/ | 00:45 | |
| mrda | It was the way to visit new places before smartphones :) | 00:47 |
| naohirot | mrda: I thought you look up the site via smartphone :) | 00:48 |
| * devananda pushes a much-overdue set of changes to reviewstats | 00:48 | |
| devananda | https://review.openstack.org/159680 | 00:49 |
| devananda | taking off for a bit ... back later, or tomorrow | 00:49 |
| NobodyCam | night devananda | 00:53 |
| BadCub | gn devananda | 00:55 |
| *** achanda has quit IRC | 00:58 | |
| *** lazy_prince has quit IRC | 01:01 | |
| *** yog_ has quit IRC | 01:01 | |
| *** jmccrory has quit IRC | 01:10 | |
| * NobodyCam steps away to go to the gym.. g'night ya all | 01:10 | |
| *** BadCub has quit IRC | 01:10 | |
| *** rloo has quit IRC | 01:20 | |
| *** Marga_ has quit IRC | 01:21 | |
| *** Marga_ has joined #openstack-ironic | 01:23 | |
| *** ChuckC has quit IRC | 01:33 | |
| *** jmccrory has joined #openstack-ironic | 01:35 | |
| *** jmccrory has quit IRC | 01:36 | |
| *** jmccrory1 has joined #openstack-ironic | 01:37 | |
| *** jmccrory1 has quit IRC | 01:37 | |
| *** Marga_ has quit IRC | 01:40 | |
| *** achanda has joined #openstack-ironic | 01:58 | |
| *** rwsu is now known as rwsu-afk | 02:26 | |
| *** killer_prince has joined #openstack-ironic | 02:41 | |
| *** killer_prince is now known as lazy_prince | 02:42 | |
| *** ramineni has joined #openstack-ironic | 02:43 | |
| *** spandhe has quit IRC | 02:44 | |
| *** yuanying has quit IRC | 02:52 | |
| *** zer0c00l has quit IRC | 03:01 | |
| *** zer0c00l has joined #openstack-ironic | 03:01 | |
| *** achanda has quit IRC | 03:05 | |
| *** achanda has joined #openstack-ironic | 03:08 | |
| *** datajerk1 has quit IRC | 03:15 | |
| *** datajerk has joined #openstack-ironic | 03:22 | |
| *** yuanying has joined #openstack-ironic | 03:38 | |
| *** achanda has quit IRC | 03:40 | |
| *** huangkai2 has joined #openstack-ironic | 03:53 | |
| *** achanda has joined #openstack-ironic | 03:59 | |
| *** achanda has quit IRC | 04:07 | |
| *** yog_ has joined #openstack-ironic | 04:13 | |
| *** pradipta has joined #openstack-ironic | 04:21 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 04:21 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 04:24 |
| *** saripurigopi has joined #openstack-ironic | 04:43 | |
| *** spandhe has joined #openstack-ironic | 04:46 | |
| *** mrda is now known as mrda-away | 04:50 | |
| *** yuanying has quit IRC | 04:54 | |
| *** achanda has joined #openstack-ironic | 04:55 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 04:57 |
| *** achanda has quit IRC | 04:59 | |
| *** pensu has joined #openstack-ironic | 05:00 | |
| *** Marga_ has joined #openstack-ironic | 05:00 | |
| *** Marga_ has quit IRC | 05:01 | |
| *** Marga_ has joined #openstack-ironic | 05:01 | |
| *** pradipta has quit IRC | 05:04 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 05:07 |
| *** coolsvap_ is now known as coolsvap | 05:08 | |
| *** rameshg87 has joined #openstack-ironic | 05:11 | |
| rameshg87 | good morning ironic | 05:11 |
| *** achanda has joined #openstack-ironic | 05:11 | |
| *** pradipta has joined #openstack-ironic | 05:16 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 05:18 |
| *** pradipta has quit IRC | 05:24 | |
| *** lazy_prince has quit IRC | 05:26 | |
| *** achanda has quit IRC | 05:28 | |
| *** killer_prince has joined #openstack-ironic | 05:29 | |
| *** killer_prince is now known as lazy_prince | 05:29 | |
| *** spandhe has quit IRC | 05:44 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add driver interface for RAID configuration https://review.openstack.org/155230 | 05:52 |
| *** Krast has joined #openstack-ironic | 05:52 | |
| *** huangkai2 has quit IRC | 05:56 | |
| *** achanda has joined #openstack-ironic | 05:59 | |
| *** jerryz_ has joined #openstack-ironic | 06:00 | |
| *** oomichi has quit IRC | 06:13 | |
| *** Marga_ has quit IRC | 06:21 | |
| saripurigopi | I'm submitting changes of new driver for review, How to specify these changes are related to the corresponding BP.? | 06:38 |
| *** pensu has quit IRC | 06:47 | |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic: Fix typo in "Enabling Drivers" Fies bug 1426239. https://review.openstack.org/159731 | 06:51 |
| openstack | bug 1426239 in Ironic "Fix typo in "Enabling Drivers"" [Undecided,New] https://launchpad.net/bugs/1426239 - Assigned to SHIGEMATSU Mitsuhiro (pshige) | 06:51 |
| *** pensu has joined #openstack-ironic | 06:51 | |
| openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Verify input uuid https://review.openstack.org/159732 | 07:01 |
| *** spandhe has joined #openstack-ironic | 07:10 | |
| *** dlpartain has joined #openstack-ironic | 07:12 | |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers using pxe_ucs driver. https://review.openstack.org/159734 | 07:18 |
| *** dlpartain has left #openstack-ironic | 07:25 | |
| *** achanda has quit IRC | 07:38 | |
| *** achanda has joined #openstack-ironic | 07:45 | |
| *** achanda has quit IRC | 07:50 | |
| *** dmellado has quit IRC | 07:52 | |
| *** dmellado has joined #openstack-ironic | 07:54 | |
| *** takadayuiko has joined #openstack-ironic | 08:05 | |
| *** dtantsur|afk is now known as dtantsur | 08:07 | |
| dtantsur | Morning Ironic, TGIF today :) | 08:07 |
| takadayuiko | dtantsur, Hi, here is Friday evening :D | 08:09 |
| openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/ironic: Fix typo in "Enabling Drivers" https://review.openstack.org/159731 | 08:09 |
| dtantsur | takadayuiko, oh, that's awesome :) ready to enjoy the weekend? | 08:09 |
| *** jcoufal has joined #openstack-ironic | 08:10 | |
| takadayuiko | dtantsur, sure! I'm going to drink soon :) | 08:11 |
| dtantsur | enjoy then :) | 08:11 |
| takadayuiko | dtantsur, BTW, I wonder about ironic-discoverd's workflow, can I ask a question? | 08:12 |
| dtantsur | sure | 08:12 |
| takadayuiko | Can we use ironic-discoverd with nova? | 08:12 |
| takadayuiko | Because, ironic-discoverd sends reboot request to physical server, and nova(-> ironic-conductor) does do it, too. Right? | 08:13 |
| dtantsur | takadayuiko, depending on what you mean by "use with nova". here at Red Hat we start with inspecting node with discoverd, then we deploy on them using nova | 08:13 |
| dtantsur | takadayuiko, hmm nova does not send reboot request to Ironic, nova sends provision request (node-set-provision-state). | 08:14 |
| dtantsur | takadayuiko, discoverd uses Ironic API to reboot stuff | 08:14 |
| takadayuiko | "use with nova" means like...mmm.. "nova boot" | 08:14 |
| dtantsur | takadayuiko, that's the primary purpose of discoverd: to find out node data required for doing nova boot later | 08:16 |
| *** ifarkas has joined #openstack-ironic | 08:16 | |
| takadayuiko | Right, I think so, too | 08:16 |
| takadayuiko | But now ironic-discoverd itself send reboot request to ironic, so that nova seems to be unnecessary | 08:17 |
| dtantsur | btw, one more thing people think about is _creating_ nova flavors based on discovered data. that makes sense for bare metals | 08:17 |
| takadayuiko | Ah, yeah! | 08:17 |
| dtantsur | takadayuiko, yes. Nova can't reboot baremetals on it's own, so it always asks Ironic to do the job. In this sense nova is unrelated to discoverd, because Ironic API is more than enough for discoverd to do it's job. | 08:18 |
| *** spandhe has quit IRC | 08:18 | |
| dtantsur | takadayuiko, so 'nova boot' is a confusing command name, it should have been 'nova deploy' :) | 08:18 |
| dtantsur | even worse: 'nova boot' does not boot a particular node, it's deploying a flavor to _some_ node in the cloud. | 08:21 |
| *** athomas has joined #openstack-ironic | 08:22 | |
| takadayuiko | Ah, booted server with pxeboot mode sends API request to ironic-discoverd's continue API, so, in that time, deployment(like making partition or copying image) is not done. | 08:22 |
| dtantsur | right | 08:23 |
| takadayuiko | thank you, understand perfectly(maybe ;) | 08:23 |
| dtantsur | you're welcome :) | 08:23 |
| takadayuiko | I can go to drink comfortably ;D | 08:24 |
| dtantsur | takadayuiko, enjoy! have a glass for us only starting the work day :) | 08:25 |
| takadayuiko | yeah, thx :) | 08:26 |
| *** ChuckC has joined #openstack-ironic | 08:27 | |
| openstackgerrit | Anusha Ramineni proposed openstack/ironic: Add Cleaning Operations for iLO drivers https://review.openstack.org/157715 | 08:32 |
| ramineni | rameshg87:^^^ | 08:35 |
| *** rameshg87 has quit IRC | 08:42 | |
| yog_ | hi, tried ironic-python-agent with fedora ramdisk, but during deploying gave error "append a correct "root=", so tried again with rootfstype=ramfs.. but got call related to out of memory .. how do i use ramdkisk from ironic-agent element with ssh_agent (python ironic agent) | 08:42 |
| *** dtantsur is now known as dtantsur|bbl | 08:43 | |
| *** rameshg87 has joined #openstack-ironic | 08:43 | |
| rameshg87 | ramineni: ack :) | 08:44 |
| *** chlong has quit IRC | 08:44 | |
| *** foexle has joined #openstack-ironic | 08:46 | |
| *** takadayuiko has quit IRC | 08:46 | |
| *** erwan_taf has joined #openstack-ironic | 08:48 | |
| *** jistr has joined #openstack-ironic | 08:56 | |
| rameshg87 | ramineni: just some nits to address when you throw in a new patch, other than that lgtm | 08:57 |
| yog_ | is there any additional cmd line parameters that must be passed to ramdisk created with ironic-agent element when python ironic agent(ssh_agent) | 08:58 |
| rameshg87 | yog_: do you mean kernel cmdline parameters while booting the agent kernel/ramdisk ? | 08:59 |
| yog_ | rameshg87, yeah .. the default parameters does not specify a root ..so it gave... "append a correct "root=" | 09:00 |
| yog_ | so tried passing rootfstype=ramf ..but got call trace related to out of memory | 09:01 |
| yog_ | this the cmd line parameters passed by default text nofb nomodeset vga=normal console=ttyS0 systemd.journald.forward_to_console=yes ipa-api-url=http://192.168.122.58:6385 ipa-driver-name=agent_ssh | 09:02 |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers using pxe_ucs driver https://review.openstack.org/159734 | 09:06 |
| rameshg87 | yog_: the while booting agent kernel/ramdisk we don't need root= parameter | 09:06 |
| rameshg87 | yog_: your list seems complete to me | 09:06 |
| rameshg87 | yog_: the ramdisk itself has systemd init and the required stuffs | 09:07 |
| *** andreykurilin_ has joined #openstack-ironic | 09:12 | |
| *** romcheg has joined #openstack-ironic | 09:15 | |
| yog_ | rameshg87, mm.. but with fedora ramdisk .. it throws call traces..VFS: Cannot open root device "(null)" or unknown-block(2,0): error -6 ... Please append a correct "root=" boot option; | 09:17 |
| rameshg87 | yog_: how much memory does the system have ? | 09:18 |
| rameshg87 | yog_: fedora ramdisk requires atleast 3G | 09:18 |
| yog_ | rameshg87, 1g.. using devstack with default vm.. configs.. | 09:19 |
| yog_ | rameshg87, aah will try with 3g then.. thanks | 09:19 |
| rameshg87 | yog_: yeah it requires atleast 3g of ram. if it throws same error, i recommend trying with 4G again :) | 09:20 |
| rameshg87 | before giving up | 09:20 |
| yog_ | ok :) | 09:20 |
| *** derekh has joined #openstack-ironic | 09:22 | |
| *** lucasagomes has joined #openstack-ironic | 09:22 | |
| *** pas-ha has joined #openstack-ironic | 09:22 | |
| *** rameshg87 is now known as rameshg87-brb | 09:27 | |
| *** saripurigopi has quit IRC | 09:29 | |
| *** dlpartain has joined #openstack-ironic | 09:30 | |
| *** dlpartain has left #openstack-ironic | 09:30 | |
| *** MattMan has quit IRC | 09:33 | |
| *** MattMan has joined #openstack-ironic | 09:40 | |
| yog_ | rameshg87-brb, awesome .. tried with 4G mem and it worked :D thanks again | 09:42 |
| openstackgerrit | Tan Lin proposed openstack/ironic: Add AMT-PXE-Driver Power&Management&Vendor Interface https://review.openstack.org/152858 | 09:51 |
| *** priteau has joined #openstack-ironic | 09:51 | |
| *** aignatov has quit IRC | 09:53 | |
| *** aignatov has joined #openstack-ironic | 09:53 | |
| *** rameshg87-brb is now known as rameshg87 | 10:04 | |
| rameshg87 | yog_: great ... | 10:04 |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add iRMC Virtual Media Deploy module for iRMC Driver https://review.openstack.org/151958 | 10:05 |
| *** pensu1 has joined #openstack-ironic | 10:09 | |
| *** pensu has quit IRC | 10:10 | |
| *** pas-ha has quit IRC | 10:11 | |
| *** pensu has joined #openstack-ironic | 10:12 | |
| *** pensu has joined #openstack-ironic | 10:13 | |
| *** moorryan has joined #openstack-ironic | 10:20 | |
| *** pas-ha has joined #openstack-ironic | 10:21 | |
| *** pas-ha has quit IRC | 10:21 | |
| *** pas-ha has joined #openstack-ironic | 10:22 | |
| *** pas-ha has quit IRC | 10:26 | |
| *** priteau has quit IRC | 10:27 | |
| *** priteau has joined #openstack-ironic | 10:27 | |
| *** pshchelo has joined #openstack-ironic | 10:28 | |
| *** priteau has quit IRC | 10:29 | |
| *** pshchelo is now known as pas-ha | 10:30 | |
| *** pelix has joined #openstack-ironic | 10:30 | |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers using pxe_ucs driver https://review.openstack.org/159734 | 10:38 |
| *** pas-ha has quit IRC | 10:40 | |
| *** pas-ha has joined #openstack-ironic | 10:41 | |
| *** andreykurilin_ has quit IRC | 10:49 | |
| *** yog_ has quit IRC | 10:50 | |
| *** ramineni has quit IRC | 11:02 | |
| *** PaulCzar has quit IRC | 11:07 | |
| *** Nisha has joined #openstack-ironic | 11:20 | |
| *** foexle_ has joined #openstack-ironic | 11:21 | |
| *** vdrok_afk is now known as vdrok | 11:21 | |
| vdrok | morning ironic | 11:21 |
| rameshg87 | vdrok: o/ | 11:22 |
| vdrok | rameshg87, afternoon :) | 11:23 |
| rameshg87 | morning vdrok :) | 11:23 |
| *** foexle has quit IRC | 11:24 | |
| rameshg87 | lucasagomes: hi | 11:24 |
| lucasagomes | rameshg87, hi there | 11:25 |
| *** coolsvap is now known as coolsvap_ | 11:30 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Generic changes for Node Inspection https://review.openstack.org/149823 | 11:31 |
| rameshg87 | lucasagomes: i was able to get the localboot working for uefi | 11:31 |
| *** lxsli is now known as thelexx | 11:31 | |
| lucasagomes | rameshg87, ah nice one! | 11:31 |
| rameshg87 | lucasagomes: but i needed to switch the partition table to gpt for that | 11:31 |
| lucasagomes | oh yeah | 11:32 |
| rameshg87 | lucasagomes: it's not booting with bios partition table in atleast hp machines | 11:32 |
| lucasagomes | I see, yeah it makes sense | 11:32 |
| lucasagomes | not sure if our libs allow you to create gpt partitions | 11:32 |
| lucasagomes | I think it does | 11:32 |
| rameshg87 | lucasagomes: yeah it does | 11:32 |
| lucasagomes | my have a switch there | 11:32 |
| lucasagomes | yeah | 11:32 |
| rameshg87 | lucasagomes: i infact created gpt with parted only | 11:33 |
| lucasagomes | yeah | 11:33 |
| lucasagomes | nice one | 11:33 |
| rameshg87 | lucasagomes: for that uefi system partition should be the first partition | 11:33 |
| rameshg87 | lucasagomes: so that's within the scope of this spec, right ? | 11:33 |
| lucasagomes | the EFI partition should be the first? | 11:33 |
| rameshg87 | lucasagomes: i mean the localboot spec | 11:33 |
| rameshg87 | lucasagomes: yeah | 11:33 |
| rameshg87 | lucasagomes: because that's where grub expects it to be while adding the efi boot entry | 11:33 |
| lucasagomes | rameshg87, not really :( I didn't include uefi because I don't have the means to test it | 11:33 |
| rameshg87 | lucasagomes: can i raise a review for that ? | 11:34 |
| lucasagomes | rameshg87, interesting, I thought you could just have the partition anywhere | 11:34 |
| lucasagomes | rameshg87, I don't see any harm proposing anything anytime :) | 11:34 |
| rameshg87 | lucasagomes: it will hardly 20 lines change in ironic applicable only for uefi | 11:34 |
| lucasagomes | since you already got it working | 11:34 |
| lucasagomes | we can even update the spec for that | 11:34 |
| rameshg87 | lucasagomes: okay, let me see .. | 11:34 |
| rameshg87 | lucasagomes: will keep you posted ... | 11:35 |
| lucasagomes | rameshg87, thanks | 11:35 |
| openstackgerrit | Shivanand Tendulker proposed stackforge/proliantutils: Support CDROM in get/set persistent boot methods https://review.openstack.org/159799 | 11:38 |
| *** pensu has quit IRC | 11:38 | |
| *** BManojlovic has joined #openstack-ironic | 11:42 | |
| *** dtantsur|bbl is now known as dtantsur | 11:49 | |
| *** foexle_ has quit IRC | 12:01 | |
| *** coolsvap_ is now known as coolsvap | 12:02 | |
| *** foexle has joined #openstack-ironic | 12:03 | |
| *** vdrok has quit IRC | 12:12 | |
| *** vdrok has joined #openstack-ironic | 12:15 | |
| Nisha | dtantsur, | 12:16 |
| Nisha | dtantsur, hi | 12:16 |
| dtantsur | o/ | 12:16 |
| Nisha | dtantsur, in in-band discovery how do u create the port. I can find out the code where it returns valid ports https://github.com/stackforge/ironic-discoverd/blob/master/ironic_discoverd/plugins/standard.py#L54-L108 | 12:18 |
| dtantsur | Nisha, https://github.com/stackforge/ironic-discoverd/blob/master/ironic_discoverd/process.py#L94-L102 | 12:19 |
| Nisha | and how do u delete the ports for the same node if the mac is not existng | 12:20 |
| Nisha | oh u call the ironic api... | 12:21 |
| Nisha | but for OOB also is it fine to call the ironic api directly? | 12:21 |
| Nisha | dtantsur, in your case i dont see port.delete being called | 12:22 |
| dtantsur | it's not done for now | 12:22 |
| dtantsur | I think I have a bug reported, but I don't see it as priority | 12:23 |
| *** lazy_prince is now known as killer_prince | 12:23 | |
| Nisha | dtantsur, which one | 12:24 |
| dtantsur | https://bugs.launchpad.net/ironic-discoverd/+bug/1404279 | 12:25 |
| openstack | Launchpad bug 1404279 in ironic-discoverd "If overwrite is enabled, also delete non-matching ports" [Low,Triaged] | 12:25 |
| *** lucasagomes is now known as lucas-hungry | 12:27 | |
| rameshg87 | dtantsur: Nisha is not able to use dbapi.destroy_port() once she has locked the node for inspection | 12:32 |
| dtantsur | what's an error? | 12:32 |
| rameshg87 | dtantsur: because of some strange (i can't get the reason) code in sqlalchemy implementation | 12:32 |
| rameshg87 | dtantsur: sqlalchemy implementation is here: https://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/api.py#L443-L455 | 12:32 |
| rameshg87 | dtantsur: the problem is here: https://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/api.py#L142-L144 | 12:33 |
| rameshg87 | dtantsur: it disallows deletion of port if the node is reserved by a conductor | 12:33 |
| dtantsur | wow, pretty bad | 12:33 |
| rameshg87 | dtantsur: i can't get the reason why it should disallow | 12:33 |
| rameshg87 | dtantsur: get any idea looking around at code why it is disallowing ? | 12:34 |
| dtantsur | https://github.com/openstack/ironic/commit/8e7e4ddcf32558278570f6b23d23b9d3b848d707 introduced by yuriyz... | 12:34 |
| rameshg87 | dtantsur: oh i didn't think of checking commit log ;-) | 12:35 |
| dtantsur | my gut feeling that it's a wrong place for doing lock checks, that's a layer violation | 12:35 |
| rameshg87 | dtantsur: the funnier part is it itself has locked the node | 12:35 |
| rameshg87 | dtantsur: but it doesn't know :( | 12:35 |
| rameshg87 | no bug as well | 12:36 |
| dtantsur | oh god... | 12:36 |
| rameshg87 | yuriyz: you around here ? | 12:36 |
| yuriyz | morning Ironic | 12:36 |
| dtantsur | rameshg87, I think it should be changed to using locks on upper level | 12:36 |
| dtantsur | yuriyz, morning | 12:36 |
| rameshg87 | yuriyz: morning :) | 12:37 |
| rameshg87 | yuriyz: we were talking about one of your commits | 12:37 |
| Nisha | yuriyz, morning | 12:37 |
| rameshg87 | yuriyz: https://review.openstack.org/#/c/40219/ | 12:37 |
| rameshg87 | yuriyz: Nisha is facing an issue because of it :) | 12:37 |
| rameshg87 | yuriyz: she is not able to delete the ports even after acquire a lock on the node by herself | 12:38 |
| rameshg87 | yuriyz: by calling dbapi.destroy_port() | 12:38 |
| rameshg87 | yuriyz: why was this change done ? | 12:39 |
| yuriyz | It was a lot of time ago. Agree, this should not be on this layer | 12:41 |
| rameshg87 | oh 2012 :) | 12:41 |
| rameshg87 | 2013 | 12:41 |
| rameshg87 | i didn't notice that | 12:41 |
| rameshg87 | remember what was the reason for this change ? | 12:42 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add iter_nodes() helper to the conductor manager https://review.openstack.org/159100 | 12:42 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add module for in-band inspection using ironic-discoverd https://review.openstack.org/156562 | 12:42 |
| rameshg87 | so that if we put this check somewhere else, we know why we are putting it ... | 12:42 |
| dtantsur | rameshg87 updated ^^^ | 12:42 |
| rameshg87 | dtantsur: ack ;) | 12:42 |
| rameshg87 | okay since we feel that check shouldn't be at that place (not sure we need that check or not) | 12:44 |
| rameshg87 | Nisha: may be you can comment out that for now and try to use dbapi.destory_port() | 12:44 |
| rameshg87 | Nisha: may be meanwhile we can figure out why/where it is required and fix it | 12:44 |
| rameshg87 | Nisha: max, may be you will need another patch which solves this issue and then put your patch as dependent of this | 12:45 |
| Nisha | rameshg87, i can do that for testing but it will not worth to submit the patch for ilo implementation | 12:45 |
| rameshg87 | Nisha: yeah so in the meanwhile we don't figure out why that check is required, i say let's propose to remove it :) | 12:45 |
| Nisha | rameshg87, i will say meanwhile we dont know the fix, let me use the curent implementation and when we have the fix in place may be i can use the correct way | 12:46 |
| rameshg87 | Nisha: no, we can't use sqlalchemy directly | 12:46 |
| rameshg87 | Nisha: we have to use the dbapi abstraction | 12:47 |
| rameshg87 | dtantsur: just quick question | 12:47 |
| dtantsur | Nisha, you can leave a #TODO in you current ilo patch, and work on destroying nodes in the follow-ups | 12:47 |
| rameshg87 | dtantsur: https://review.openstack.org/#/c/151596/21/ironic/drivers/modules/ilo/inspect.py | 12:47 |
| rameshg87 | dtantsur: we can't use sqlalchemy directly if i am not wrong | 12:47 |
| rameshg87 | dtantsur: correct ? | 12:48 |
| rameshg87 | dtantsur: we have to use the dbapi abstraction, right ? | 12:48 |
| dtantsur | correct. because dbapi is an abstract interface | 12:48 |
| dtantsur | there may be different implementations | 12:48 |
| rameshg87 | yeah exactly | 12:48 |
| * dtantsur goes food-hunting | 12:48 | |
| *** dtantsur is now known as dtantsur|lunch | 12:49 | |
| rameshg87 | dtantsur|lunch: lucas-hungry: please have a look at https://review.openstack.org/#/c/155230/ when you get some time | 12:51 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Do not save auth token on TFTP serfer in PXE driver https://review.openstack.org/159819 | 12:54 |
| *** pas-ha has quit IRC | 13:13 | |
| *** pas-ha has joined #openstack-ironic | 13:28 | |
| *** dtantsur|lunch is now known as dtantsur | 13:29 | |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Do not save auth token on TFTP serfer in PXE driver https://review.openstack.org/159819 | 13:31 |
| *** bauzas is now known as bauwser | 13:39 | |
| *** mgoddard1 has joined #openstack-ironic | 13:41 | |
| *** mgoddard has quit IRC | 13:45 | |
| *** pas-ha has quit IRC | 13:47 | |
| *** pas-ha has joined #openstack-ironic | 13:54 | |
| *** athomas has quit IRC | 13:59 | |
| *** jcoufal_ has joined #openstack-ironic | 13:59 | |
| *** jcoufal has quit IRC | 14:02 | |
| *** athomas has joined #openstack-ironic | 14:10 | |
| *** jcoufal_ has quit IRC | 14:12 | |
| *** jcoufal has joined #openstack-ironic | 14:12 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add module for in-band inspection using ironic-discoverd https://review.openstack.org/156562 | 14:14 |
| openstackgerrit | Merged openstack/ironic: Fix typo in "Enabling Drivers" https://review.openstack.org/159731 | 14:16 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add localboot support for uefi boot mode. https://review.openstack.org/159855 | 14:16 |
| rameshg87 | lucas-hungry: ^^^ open for quick review. will add tests | 14:18 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Check UUID correctness for Glance images https://review.openstack.org/151951 | 14:20 |
| * rameshg87 wonders why was ironic.conf.sample check stopped in gate | 14:20 | |
| *** trown|outttypeww is now known as trown | 14:22 | |
| *** rameshg87 has left #openstack-ironic | 14:23 | |
| *** lucas-hungry is now known as lucasagomes | 14:29 | |
| *** coolsvap is now known as coolsvap_ | 14:31 | |
| *** logan2 has quit IRC | 14:32 | |
| *** Nisha has quit IRC | 14:37 | |
| *** logan2 has joined #openstack-ironic | 14:45 | |
| *** BadCub has joined #openstack-ironic | 14:49 | |
| BadCub | Morning Ironic | 14:56 |
| TheJulia | Good morning! | 15:00 |
| jroll | morning BadCub TheJulia and everyone else :) | 15:06 |
| dtantsur | jroll, TheJulia, BadCub, morning | 15:06 |
| jroll | heya dtantsur :) | 15:07 |
| lucasagomes | BadCub, TheJulia jroll morning :) | 15:07 |
| jroll | morning lucasagomes :) | 15:07 |
| jroll | oh and happy friday \o/ | 15:08 |
| BadCub | Happy Friday!!!!! | 15:08 |
| lucasagomes | 2+2 https://review.openstack.org/#/c/155728/ someone want's to +a it? | 15:08 |
| lucasagomes | :) | 15:08 |
| lucasagomes | jroll, happy friday! | 15:08 |
| lucasagomes | BadCub, ^ u too | 15:08 |
| * jroll looks | 15:09 | |
| NobodyCam | good morning Ironic.. and ...... | 15:10 |
| NobodyCam | TGIF!!!!! | 15:10 |
| NobodyCam | morning BadCub jroll and lucasagomes | 15:10 |
| jroll | morning NobodyCam :D | 15:10 |
| NobodyCam | :) | 15:10 |
| dtantsur | NobodyCam, oh the most TGIF of all TGIF... morning! | 15:11 |
| * dtantsur is still fighting with authentication, could some one have a look at http://lists.openstack.org/pipermail/openstack-dev/2015-February/057974.html ? | 15:11 | |
| *** zz_jgrimm is now known as jgrimm | 15:12 | |
| NobodyCam | morning dtantsur .. Looking | 15:12 |
| Shrews | Hey all. I'm baaaaaack | 15:18 |
| * Shrews falls behind on EVERYTHING | 15:19 | |
| NobodyCam | welcome back Shrews :) and good Morning | 15:19 |
| jroll | O.O | 15:19 |
| jroll | wb Shrews :) | 15:19 |
| Shrews | o/ | 15:19 |
| Shrews | https://twitter.com/dshrews/status/571327772624330753 | 15:22 |
| NobodyCam | Shrews: very nice | 15:23 |
| Shrews | oh, that was meant for a different window, but you guys can look too :-P | 15:23 |
| *** ChuckC has quit IRC | 15:23 | |
| lucasagomes | Shrews, aewsome | 15:25 |
| lucasagomes | awesome* | 15:25 |
| NobodyCam | lol | 15:25 |
| jroll | lucasagomes: +A on that pxe/agent thing | 15:26 |
| dtantsur | Shrews, morning and nice pic :) | 15:26 |
| jroll | Shrews: sick | 15:26 |
| lucasagomes | o/! | 15:26 |
| jroll | it's been way too long since I've been snowboarding | 15:26 |
| lucasagomes | jroll, now I will fix the devstack one and we are all set to start tests on gate | 15:26 |
| lucasagomes | (new job ofc) | 15:26 |
| jroll | nice | 15:27 |
| *** datajerk has left #openstack-ironic | 15:28 | |
| NobodyCam | lucasagomes: awesome :) | 15:29 |
| NobodyCam | dtantsur: where are you gettig the token? | 15:29 |
| dtantsur | NobodyCam, in Ironic? https://github.com/openstack/ironic/blob/master/ironic/common/keystone.py#L125 | 15:30 |
| *** achanda has joined #openstack-ironic | 15:31 | |
| *** hemna has joined #openstack-ironic | 15:31 | |
| *** anderbubble has joined #openstack-ironic | 15:32 | |
| NobodyCam | humm | 15:33 |
| *** achanda has quit IRC | 15:36 | |
| NobodyCam | dtantsur: just a question have you tried to manually execute a validation? http://docs.openstack.org/developer/keystone/api_curl_examples.html#id3 | 15:47 |
| *** hj-hp has joined #openstack-ironic | 15:47 | |
| dtantsur | NobodyCam, this is about credentials, and I have a token | 15:48 |
| *** hj-hp has quit IRC | 15:49 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Use mock instead of fixtures when appropriate https://review.openstack.org/159898 | 15:49 |
| NobodyCam | any one have time for a largeish review? | 15:50 |
| NobodyCam | https://review.openstack.org/#/c/136741 | 15:50 |
| * naohirot have a nice week all, good night :) | 15:52 | |
| *** naohirot has quit IRC | 15:52 | |
| *** hj-hp has joined #openstack-ironic | 15:52 | |
| *** ndipanov has quit IRC | 15:54 | |
| pas-ha | noob question - is there any possibility to attach a cinder volume to baremetal instance? | 15:56 |
| NobodyCam | night naohirot | 15:59 |
| NobodyCam | pas-ha: welcome to Ironic | 16:00 |
| NobodyCam | night just yet but we have this: https://review.openstack.org/#/c/149606 | 16:01 |
| NobodyCam | s/night/not/ | 16:01 |
| *** BadCub has quit IRC | 16:01 | |
| *** Marga_ has joined #openstack-ironic | 16:03 | |
| *** vdrok is now known as vdrok_afk | 16:06 | |
| *** BadCub has joined #openstack-ironic | 16:14 | |
| *** ChuckC has joined #openstack-ironic | 16:16 | |
| *** ChuckC has quit IRC | 16:17 | |
| *** ChuckC has joined #openstack-ironic | 16:17 | |
| *** david-lyle_afk is now known as david-lyle | 16:19 | |
| *** ChuckC has quit IRC | 16:20 | |
| *** BManojlovic has quit IRC | 16:20 | |
| NobodyCam | jroll: JayF: happen to have a free minute for a quick look at JoshNang's next cleaning patch: https://review.openstack.org/#/c/157208? | 16:21 |
| *** ChuckC has joined #openstack-ironic | 16:21 | |
| jroll | NobodyCam: yes, that was next on my list :) | 16:22 |
| NobodyCam | w00 h00 :) | 16:22 |
| JoshNang | \o/ | 16:22 |
| *** hj-hp has quit IRC | 16:29 | |
| *** romcheg has quit IRC | 16:30 | |
| *** hj-hp has joined #openstack-ironic | 16:30 | |
| *** romcheg has joined #openstack-ironic | 16:32 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Update install-guide for Ubuntu 14.10 package changes https://review.openstack.org/159597 | 16:32 |
| NobodyCam | easy doc patch ^^^ :-p | 16:32 |
| *** jcoufal has quit IRC | 16:33 | |
| jlvillal | devananda: Thanks for the info on virt-manager. It worked :) uvt-kvm never seemed to work for me. I am now able to start a baremetal node. | 16:35 |
| *** david-lyle is now known as david-lyle_Afk | 16:35 | |
| *** david-lyle_Afk is now known as david-lyle_afk | 16:35 | |
| jlvillal | NobodyCam: ^^^^ My problems I think were because I was using uvt-kvm. Not sure why and don't feel like spending the time trying to figure it out... | 16:35 |
| NobodyCam | jlvillal: nice | 16:35 |
| jlvillal | NobodyCam: Thanks for the assistance before. | 16:35 |
| NobodyCam | jlvillal: anytime .. :) | 16:36 |
| *** bnemec is now known as beekneemech | 16:37 | |
| *** rwsu-afk is now known as rwsu | 16:39 | |
| jlvillal | NobodyCam: I gave some minor feedback on the patch. | 16:42 |
| NobodyCam | jlvillal: I like the higher versions on the bottom, are you okay if I leave the order as is? | 16:44 |
| jlvillal | NobodyCam: Uh, I'm not sure what that means. I'm fine with the ordering. Not sure what bottom means. | 16:45 |
| jlvillal | NobodyCam: I was trying to be clear that the first part included 14.04. | 16:45 |
| jlvillal | NobodyCam: When I was saying swap | 16:45 |
| NobodyCam | jlvillal: the comment on line 597 | 16:45 |
| jlvillal | I meant. | 16:45 |
| jlvillal | sudo apt-get install tftpd-hpa syslinux syslinux-common | 16:45 |
| jlvillal | sudo apt-get install tftpd-hpa syslinux-common syslinux | 16:46 |
| NobodyCam | oh | 16:46 |
| NobodyCam | doh | 16:46 |
| NobodyCam | sure | 16:46 |
| jlvillal | Then the first two packages are identical and only the third package is different | 16:46 |
| jlvillal | If that makes sense | 16:46 |
| NobodyCam | thank you... yep | 16:46 |
| NobodyCam | can do | 16:46 |
| jlvillal | NobodyCam: Thanks! | 16:46 |
| NobodyCam | thank you:) | 16:47 |
| * jlvillal hopes he isn't bikeshedding.... | 16:47 | |
| *** Marga_ has quit IRC | 16:51 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Update install-guide for Ubuntu 14.10 package changes https://review.openstack.org/159597 | 16:51 |
| NobodyCam | jlvillal: ^^^ :-p | 16:51 |
| *** Marga_ has joined #openstack-ironic | 16:51 | |
| jlvillal | NobodyCam: +1! :) | 16:52 |
| NobodyCam | :) | 16:52 |
| *** romcheg has quit IRC | 16:57 | |
| jroll | JoshNang: I hate to do this but I'm going to -1 that cleaning thing | 17:01 |
| JoshNang | jroll: :O | 17:01 |
| jroll | I'd like a test that has multiple interfaces | 17:01 |
| jroll | to make sure they group/sort properly | 17:01 |
| JoshNang | jroll: np, totally reasonable | 17:01 |
| jroll | just a heads up in case you want to get started :) | 17:01 |
| JoshNang | heh i will | 17:01 |
| *** Marga_ has quit IRC | 17:01 | |
| jroll | JoshNang: also... | 17:02 |
| jroll | the decorator says priority > 1 | 17:02 |
| jroll | but the test has a step with priority 0 | 17:02 |
| jroll | and I don't see any code that checks priority > 1 unless I missed something | 17:02 |
| jroll | OH | 17:03 |
| jroll | I see the zapping thing | 17:03 |
| JoshNang | jroll: hmm lemme look. priority > 1 == clean step, priority 0 == disabled, allowed for zapp | 17:03 |
| jroll | yeah | 17:03 |
| jroll | you're right, ignore me | 17:03 |
| JoshNang | yeah. and for the check, that's the callers duty | 17:03 |
| jroll | and then the executor will check it? | 17:03 |
| jroll | ok | 17:03 |
| jroll | yeah | 17:03 |
| JoshNang | yup. doing everything i can to keep the differences in zap and clean to like an api call and a flag | 17:03 |
| jroll | sweet | 17:04 |
| jroll | commented, ping me whenever you get to it :) | 17:04 |
| JoshNang | thanks for reviewing! | 17:04 |
| jlvillal | JoshNang: What is priority 1. Just reading the scroll back. And saw priority > 1 == clean step. Is that priority >= 1? | 17:05 |
| JoshNang | yeah sorry, >=1 | 17:05 |
| jlvillal | JoshNang: Okay :) | 17:06 |
| jroll | oh good point | 17:06 |
| * jroll nits on review | 17:06 | |
| JoshNang | jlvillal: you are technically correct, the best kind of correct! | 17:06 |
| jroll | there's a few other nits too, if you want to pick them up :) | 17:06 |
| jlvillal | JoshNang: LOL | 17:06 |
| jroll | (not from me) | 17:06 |
| JoshNang | jroll: yup i already had those started | 17:07 |
| jroll | I shouldn't have expected any less | 17:07 |
| dtantsur | have a nice weekend! | 17:08 |
| *** dtantsur is now known as dtantsur|afk | 17:08 | |
| NobodyCam | night dtantsur|afk | 17:08 |
| jroll | dtantsur|afk: you too :) | 17:08 |
| NobodyCam | have a good weekend | 17:08 |
| jroll | JoshNang: how do you see the "clean steps calling back to conductor via RPC" stuff working? the step in the driver will call rpcapi.continue_node_clean() or somethign? | 17:15 |
| jroll | or is there an API endpoint for OOB tasks? | 17:15 |
| jroll | both? | 17:16 |
| JoshNang | jroll: both | 17:16 |
| JoshNang | though the api would be like a vendor passthru or something | 17:16 |
| jroll | ok | 17:16 |
| jroll | it wouldn't have to be, would it? | 17:16 |
| jroll | I guess it needs to know the step | 17:16 |
| jroll | ok | 17:16 |
| jroll | just trying to think how everything fits together | 17:16 |
| JoshNang | i mean, it could be a generic "i'm done, continue" api | 17:17 |
| JoshNang | vendor passthru knows the node, node knows the current step | 17:17 |
| jroll | yeah, though you need to get to the drivers to get to the next step | 17:17 |
| jroll | so it would have to be vendor passthru I think | 17:17 |
| JoshNang | when a step is done, it goes back to the conductor and the conductor calls out to the driver for the next step | 17:18 |
| jroll | yeah | 17:18 |
| jroll | ok, this makes sense | 17:18 |
| JoshNang | the continue clean rpc wasn't my favorite system, but the only one i could figure out that would work async and sync and let the conductor drive the bus | 17:19 |
| jroll | yeah, it's probably fine | 17:20 |
| *** ifarkas has quit IRC | 17:22 | |
| JoshNang | i'm gonna add these bits to the @clean_step docs | 17:23 |
| *** jogo is now known as flashgordon | 17:25 | |
| *** jistr has quit IRC | 17:25 | |
| NobodyCam | brb..bbt | 17:27 |
| *** penick has joined #openstack-ironic | 17:27 | |
| *** derekh has quit IRC | 17:29 | |
| *** pas-ha has quit IRC | 17:30 | |
| * NobodyCam also makes some food stuffs | 17:38 | |
| NobodyCam | ahh Spock died :( | 17:40 |
| jlvillal | NobodyCam: How do you prioritize what patches to review? Or do you just review them all? | 17:40 |
| jlvillal | Really? | 17:40 |
| NobodyCam | http://www.nytimes.com/2015/02/27/arts/television/leonard-nimoy-spock-of-star-trek-dies-at-83.html?_r=0 | 17:40 |
| NobodyCam | jlvillal: https://docs.google.com/spreadsheets/d/1Hxyfy60hN_Fit0b-plsPzK6yW3ePQC5IfwuzJwltlbo | 17:41 |
| jlvillal | NobodyCam: Thanks! | 17:41 |
| jroll | jlvillal: the gold source is https://launchpad.net/ironic/+milestone/kilo-3 btw | 17:45 |
| jroll | but that spreadsheet is mostly in line | 17:45 |
| jlvillal | jroll: Bookmarking both :) | 17:45 |
| jroll | :) | 17:46 |
| NobodyCam | way does no-one ever mention "In Search of..." /me loved that series | 17:47 |
| lucasagomes | NobodyCam, :( | 17:50 |
| NobodyCam | ya | 17:50 |
| jroll | JoshNang: this cleaning stuff is looking good, I think I reviewed the whole series | 17:53 |
| JoshNang | jroll: thanks! | 17:54 |
| jroll | :) | 17:54 |
| * jroll moves on to the big one... https://review.openstack.org/#/c/136741 | 17:54 | |
| JoshNang | i think this might cover all of the main ironic bits. next up is nova and drivers | 17:54 |
| jroll | nice | 17:55 |
| *** romcheg has joined #openstack-ironic | 17:55 | |
| NobodyCam | jroll: ++ | 17:55 |
| jroll | NobodyCam: oI'm scared | 17:55 |
| jroll | -o | 17:55 |
| NobodyCam | jroll: thats the 1100+ line patch | 17:56 |
| jroll | ya | 17:56 |
| NobodyCam | :) | 17:56 |
| jroll | oh man | 17:56 |
| jroll | I want to -1 already for the first line of the docs | 17:56 |
| jroll | :P | 17:57 |
| jroll | oh right, noauth allows not using keystone | 17:57 |
| openstackgerrit | Victor Lowther proposed openstack/ironic: Add DRAC BIOS config vendor passthru API -- DO NOT MERGE https://review.openstack.org/150488 | 18:01 |
| *** Marga_ has joined #openstack-ironic | 18:01 | |
| *** jerryz_ has quit IRC | 18:04 | |
| *** chlong has joined #openstack-ironic | 18:04 | |
| *** anderbubble has quit IRC | 18:09 | |
| *** athomas has quit IRC | 18:09 | |
| *** chlong has quit IRC | 18:11 | |
| *** spandhe has joined #openstack-ironic | 18:11 | |
| *** spandhe has quit IRC | 18:11 | |
| *** achanda has joined #openstack-ironic | 18:16 | |
| *** krtaylor has quit IRC | 18:16 | |
| *** achanda has quit IRC | 18:17 | |
| *** achanda has joined #openstack-ironic | 18:17 | |
| *** killer_prince has quit IRC | 18:20 | |
| openstackgerrit | Merged openstack/ironic: PXE drivers support for IPA https://review.openstack.org/155728 | 18:20 |
| *** killer_prince has joined #openstack-ironic | 18:22 | |
| *** killer_prince is now known as lazy_prince | 18:22 | |
| JoshNang | \o/ | 18:22 |
| NobodyCam | lol :) | 18:22 |
| *** spandhe has joined #openstack-ironic | 18:23 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement Cleaning in DriverInterfaces https://review.openstack.org/157208 | 18:27 |
| *** romcheg1 has joined #openstack-ironic | 18:27 | |
| *** chlong has joined #openstack-ironic | 18:28 | |
| *** romcheg has quit IRC | 18:28 | |
| *** krtaylor has joined #openstack-ironic | 18:28 | |
| lucasagomes | Merged openstack/ironic: PXE drivers support for IPA | 18:29 |
| lucasagomes | \o/ JoshNang +1 | 18:29 |
| NobodyCam | :) | 18:29 |
| JoshNang | lucasagomes: i'm very excited. thanks for working on that | 18:29 |
| lucasagomes | the devstack patch https://review.openstack.org/#/c/159178/ | 18:30 |
| lucasagomes | JoshNang, np :) | 18:30 |
| lucasagomes | this is just the forklift, I want to see if in the future we may even be able to have a driver that support multiples way of deploying a node | 18:30 |
| lucasagomes | that would be awesome | 18:30 |
| JoshNang | that'd be pretty sweet | 18:31 |
| * JoshNang adds the devstack patch to his review queue | 18:31 | |
| lucasagomes | ty :) | 18:32 |
| lucasagomes | I will call it a day here | 18:32 |
| lucasagomes | I will be off on monday and tuesday | 18:33 |
| lucasagomes | so I see y'all on wednesday :) | 18:33 |
| lucasagomes | have a good night, enjoy the weekend | 18:33 |
| JoshNang | lucasagomes: have a good weekend! | 18:33 |
| trown | have a good weekend lucasagomes | 18:33 |
| lucasagomes | ty guys, you too enjoy | 18:33 |
| *** lucasagomes is now known as lucas-beer | 18:33 | |
| NobodyCam | lucasagomes: one quick question | 18:33 |
| lucas-beer | NobodyCam, sure | 18:33 |
| NobodyCam | never mind -p soory just found my own answer | 18:34 |
| NobodyCam | :-p | 18:34 |
| NobodyCam | have a great weekend | 18:34 |
| NobodyCam | :) | 18:34 |
| lucas-beer | hah ok | 18:35 |
| lucas-beer | see you, enjoy the weekend | 18:35 |
| NobodyCam | you too | 18:35 |
| *** david-lyle_afk is now known as david-lyle | 18:35 | |
| jroll | https://review.openstack.org/#/c/136741/ +A | 18:35 |
| jroll | wooooooot | 18:35 |
| NobodyCam | wow | 18:35 |
| NobodyCam | :) | 18:36 |
| jroll | that was rough | 18:36 |
| jroll | have a nice long weekend lucas-beer :D | 18:36 |
| NobodyCam | long... is monday a holiday? | 18:36 |
| *** Marga_ has quit IRC | 18:37 | |
| *** Marga_ has joined #openstack-ironic | 18:38 | |
| *** chlong has quit IRC | 18:38 | |
| *** mgoddard1 has quit IRC | 18:43 | |
| jroll | NobodyCam: he said he's off monday/tuesday :P | 18:45 |
| NobodyCam | oh nice!!!! | 18:45 |
| jroll | JoshNang: left a thing inline, I'd like other people to chime in there. | 18:45 |
| JoshNang | jroll: actually, exception makes sense, and i might pull this check out into another patch | 18:48 |
| JoshNang | jroll: because i'd like to do some checks on startup to ensure there isn't conflicting priority + interface. like if an op accidently sets a step to 20, and another defaults to 20 on the same interface, we should blow up the conductor when it starts | 18:49 |
| JoshNang | otherwise we have undefined behavior. and that's Real Bad (TM). | 18:50 |
| jroll | JoshNang: yeah +1 | 18:52 |
| * JoshNang does it | 18:52 | |
| *** Marga_ has quit IRC | 18:52 | |
| JoshNang | jlvillal: ^ in response to your suggestion on cleaning | 18:52 |
| jlvillal | JoshNang: :) | 18:53 |
| *** Marga_ has joined #openstack-ironic | 18:53 | |
| *** Marga_ has quit IRC | 18:53 | |
| *** Nisha has joined #openstack-ironic | 18:54 | |
| *** Marga_ has joined #openstack-ironic | 18:55 | |
| *** mgoddard has joined #openstack-ironic | 18:55 | |
| NobodyCam | merge conflicts in untouched files hummmm.... | 19:07 |
| jroll | O.o | 19:08 |
| NobodyCam | ahh ha | 19:09 |
| *** Nisha has quit IRC | 19:10 | |
| NobodyCam | error is in one if the Dependencies | 19:11 |
| NobodyCam | :-p | 19:11 |
| *** Nisha has joined #openstack-ironic | 19:11 | |
| *** anderbubble has joined #openstack-ironic | 19:14 | |
| *** erwan_taf has quit IRC | 19:16 | |
| devananda | jroll: do ya'll use static pxe configs, or does agent.py dynamically generate your pxe config file per-instance? | 19:18 |
| jroll | devananda: we have static configs | 19:19 |
| NobodyCam | morning devananda :) | 19:19 |
| jroll | devananda: you're talking deploy pxe configs yes? | 19:19 |
| devananda | jroll: that's what I thought. so I'm confused by looking at drivers/modules/agent.py | 19:19 |
| devananda | yes | 19:19 |
| jroll | devananda: what's confusing? | 19:19 |
| devananda | REQUIRED_PROPERTIES = { deploy_kernel, deploy-ramdisk } | 19:19 |
| devananda | validate ensures those are present, but they're not necessary if using static pxe config | 19:20 |
| jroll | yeah, that's something that could improve | 19:20 |
| jroll | I think those were added recently though | 19:20 |
| jroll | devananda: however they don't hurt to have there, and honestly you could still use those as a reference to something else | 19:21 |
| jroll | e.g. deploy_kernel=http://image-host.com/kernel | 19:21 |
| jroll | or better yet kernel.sha1 | 19:22 |
| jroll | even if they're only used for operator consumption | 19:22 |
| jroll | (we don't do this, just saying) | 19:22 |
| devananda | gotcha. so just pad them to make validate happy, and create a bogus local pxe config | 19:23 |
| devananda | <sadface> | 19:23 |
| *** openstackgerrit has quit IRC | 19:24 | |
| jroll | right... we actually have this hacked downstream to just remove the pxe config creation | 19:24 |
| *** openstackgerrit has joined #openstack-ironic | 19:24 | |
| devananda | hah | 19:24 |
| jroll | I expect I'll remove that hack next week, cleaning up other things right now as well | 19:24 |
| jroll | however; I was thinking about this the other day... I don't necessarily love "if dhcp_driver == neutron: require these configs" | 19:25 |
| devananda | jroll: so some of us are about to start using IPA in anger. little things like this that probably annoyed you, and you fixed downstream, are about to annoy me | 19:25 |
| jroll | and was thinking on if dhcp should be part of the driver matrix, as much as I hate that | 19:25 |
| devananda | jroll: which means I'm going to pester you to upstream them :) | 19:25 |
| jroll | aha :D" | 19:25 |
| jroll | we didn't necessarily "fix" them downstream but yeah | 19:25 |
| *** BadCub has quit IRC | 19:26 | |
| jroll | I've spent over half of this week rebasing the hell out of our downstream and cutting the fat | 19:26 |
| jroll | slimmed down from ~70 commits to 18 so far... some squashing, some removing things that landed upstream | 19:26 |
| jroll | so yeah, working on it | 19:27 |
| *** mtanino has joined #openstack-ironic | 19:27 | |
| devananda | TheJulia: you may also want to start a habit of pestering jroll for things that don't make sense in the agent_* drivers. #justsayin | 19:27 |
| jroll | mostly just have networks/cleaning/rescue/metrics downstream | 19:27 |
| devananda | jroll: that's fantastic. really :) | 19:27 |
| jroll | devananda: TheJulia: complaints welcome | 19:27 |
| TheJulia | lol | 19:28 |
| devananda | amongst the things I need to find time for - reviewing JoshNang's cleaning patches, which I presume are coming out of said rebasing and cleanup ? | 19:28 |
| jroll | they're coming out separately | 19:28 |
| JoshNang | ^ | 19:28 |
| jroll | I actually stopped grabbing upstream right before where his stuff started landing | 19:28 |
| jroll | and going to grab again and drop the downstream when it all lands | 19:28 |
| JoshNang | the upstream cleaning is way better than our downstream decom | 19:29 |
| jroll | and 100% different | 19:29 |
| jroll | my git binary is crying | 19:29 |
| devananda | JoshNang: I skimmed the cleaning base class work - not enough to really review it, but i'm curious | 19:34 |
| devananda | JoshNang: is your plan to do the same sort of decorator for other state changes? | 19:34 |
| *** BadCub has joined #openstack-ironic | 19:34 | |
| jroll | devananda: so we need to drop swift? | 19:34 |
| devananda | jroll: eh? | 19:35 |
| * BadCub grumbles at internets | 19:35 | |
| jroll | er | 19:35 |
| jroll | ignore that | 19:35 |
| JoshNang | devananda: what do you mean? | 19:35 |
| * jroll too many thoughts atm | 19:35 | |
| *** jmccrory has joined #openstack-ironic | 19:39 | |
| * devananda lunches | 19:40 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement Cleaning in DriverInterfaces https://review.openstack.org/157208 | 19:40 |
| *** lucas-beer has quit IRC | 19:42 | |
| *** barra204 has joined #openstack-ironic | 19:50 | |
| *** Marga_ has quit IRC | 19:52 | |
| *** romcheg has joined #openstack-ironic | 19:52 | |
| *** Marga_ has joined #openstack-ironic | 19:52 | |
| *** Marga_ has quit IRC | 19:53 | |
| *** achanda has quit IRC | 19:53 | |
| *** romcheg1 has quit IRC | 19:55 | |
| *** barra204 is now known as shakamunyi | 19:56 | |
| NobodyCam | amt driver patch. has several nit's but I believe they can be addressed with a follow up patch. any one have time to see if they agree: https://review.openstack.org/#/c/152858 | 19:57 |
| *** anderbubble_ has joined #openstack-ironic | 19:57 | |
| * NobodyCam heads off to a hour long brown bag session | 19:58 | |
| *** anderbubble has quit IRC | 19:58 | |
| *** anderbubble_ is now known as anderbubble | 19:58 | |
| *** ChuckC has quit IRC | 20:02 | |
| *** ChuckC has joined #openstack-ironic | 20:03 | |
| * BadCub goes brown bagging too | 20:04 | |
| *** Nisha has quit IRC | 20:04 | |
| *** jmccrory has quit IRC | 20:05 | |
| openstackgerrit | Merged openstack/ironic: Support for non-Glance image references https://review.openstack.org/136741 | 20:09 |
| devananda | jroll: agent.py build_instance_info_for_deploy() requires glance, and builds a swift tempurl to pass to IPA, overwriting node.instance_info with this | 20:19 |
| devananda | jroll: if I were to set instance_info outside of driver/module/agent.py, is there a nice / existing way to skip prepare()? or shall i add such a check? | 20:19 |
| jlvillal | NobodyCam: I only have some nits so far in my review of https://review.openstack.org/#/c/152858 Still working my way through it. I started before lunch... | 20:21 |
| *** achanda has joined #openstack-ironic | 20:23 | |
| *** PaulCzar has joined #openstack-ironic | 20:25 | |
| openstackgerrit | Merged openstack/python-ironicclient: Fix PEP8 E121,E122,E123,E124,E125,E129 errors https://review.openstack.org/159279 | 20:26 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Enable setting standalone mode via APARAMS https://review.openstack.org/159986 | 20:27 |
| JayF | sshhh openstackgerrit I'm in stealth mode | 20:27 |
| NobodyCam | lol | 20:27 |
| NobodyCam | MORNING JAYF :) | 20:27 |
| JayF | lol | 20:28 |
| NobodyCam | hehehe | 20:28 |
| * JayF sitting in San Antonio airport, plane boards in 50m | 20:28 | |
| NobodyCam | jlvillal: cool! | 20:28 |
| JayF | which is enough time to talk a little in IRC | 20:28 |
| JayF | or actually do a thing or two | 20:28 |
| JayF | I picked the latter P: | 20:28 |
| openstackgerrit | Merged openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/157768 | 20:28 |
| NobodyCam | :) | 20:28 |
| * NobodyCam is attending a brown bag meeting | 20:29 | |
| *** achanda has quit IRC | 20:30 | |
| *** ChuckC has quit IRC | 20:31 | |
| *** ChuckC has joined #openstack-ironic | 20:32 | |
| *** jmccrory has joined #openstack-ironic | 21:00 | |
| *** achanda has joined #openstack-ironic | 21:03 | |
| *** pelix has quit IRC | 21:04 | |
| *** achanda has quit IRC | 21:05 | |
| * NobodyCam call over... takeing a quick break | 21:07 | |
| jlvillal | NobodyCam: When you get back I have a question... | 21:09 |
| *** achanda has joined #openstack-ironic | 21:10 | |
| NobodyCam | ok give me about 10 min | 21:12 |
| NobodyCam | :) | 21:12 |
| jlvillal | okay | 21:15 |
| *** hj-hp has quit IRC | 21:22 | |
| * NobodyCam is back | 21:24 | |
| *** hj-hp has joined #openstack-ironic | 21:25 | |
| NobodyCam | jlvillal: ??? | 21:27 |
| jlvillal | NobodyCam: https://review.openstack.org/#/c/152858/8/ironic/tests/drivers/amt/test_management.py line 67 | 21:27 |
| * NobodyCam clicks | 21:27 | |
| jlvillal | and https://review.openstack.org/#/c/152858/8/ironic/drivers/modules/amt/management.py | 21:28 |
| *** sambetts has quit IRC | 21:28 | |
| jlvillal | I see "Client" in the test. But "ClientOptions" in the management.py | 21:28 |
| jlvillal | So I am confused... | 21:28 |
| jlvillal | I thought you might help my confusion :) | 21:28 |
| NobodyCam | lookin | 21:29 |
| *** sambetts has joined #openstack-ironic | 21:30 | |
| jlvillal | On another note. I think a patch that has been merged since that has broken the unittests. At least it is failing on my tox. My tox works without the patch. | 21:32 |
| *** hemna has quit IRC | 21:32 | |
| * jlvillal will be back in 3 minutes... | 21:33 | |
| JoshNang | jlvillal: have you tried rebuilding tox? could be update dependency | 21:33 |
| JoshNang | *updated. 'tox -r' to give it a try | 21:33 |
| NobodyCam | jlvillal: you may be correct there that looks like a issue | 21:34 |
| NobodyCam | it also mocking a mocked object | 21:35 |
| jlvillal | JoshNang: Okay. I will try. Without cherry-picking the patch it worked. | 21:36 |
| jlvillal | NobodyCam: Thanks. I will post it as a question | 21:37 |
| *** jjohnson2 has joined #openstack-ironic | 21:40 | |
| devananda | oh. new bug in the power state sync loop | 21:43 |
| devananda | node state None does not match expected state 'None'. Updating DB state to 'None' Switching node to maintenance mode. | 21:43 |
| *** achanda has quit IRC | 21:43 | |
| NobodyCam | oh thats not good | 21:44 |
| *** achanda has joined #openstack-ironic | 21:44 | |
| NobodyCam | ipmi or ssh driver? | 21:44 |
| devananda | ipmitool | 21:44 |
| *** hemna has joined #openstack-ironic | 21:46 | |
| devananda | NobodyCam: http://paste.openstack.org/show/Wg1aaQGqjF1PmfkTQSmL/ | 21:46 |
| *** hj-hp has quit IRC | 21:46 | |
| NobodyCam | so its from a premission issue? Failed to create the password file | 21:47 |
| jlvillal | JoshNang: Tried the 'tox -r' still failed. So I added a 'recheck' to the patch. I think some merged patches have broken this patch, would be my guess. | 21:47 |
| jlvillal | JoshNang: Thanks for the info on 'tox -r'. I hadn't known about that. | 21:48 |
| JoshNang | jlvillal: yup, probably just broken then. tox -r is good any time global requirements patches land | 21:48 |
| JoshNang | there's an article on how to massively speed it up i saw yesterday...sec | 21:48 |
| JoshNang | https://www.berrange.com/posts/2014/11/14/faster-rebuilds-for-python-virtualenv-trees/ | 21:49 |
| * jlvillal has created a mirror of a sub-set of pypi locally. To help speed things up. Updated every morning before he gets to work. | 21:49 | |
| jroll | devananda: the glance change that just landed should cover the instance_info thing | 21:49 |
| jlvillal | JoshNang: Thanks! | 21:49 |
| JoshNang | jlvillal: ha that works too :) | 21:50 |
| jroll | devananda: er, the don't-require-glance change | 21:50 |
| devananda | jroll: oh, it landed? | 21:50 |
| jlvillal | JoshNang: That looks cool as it saves the re-compile portion too. | 21:50 |
| jroll | devananda: dunno, but I +A'd it earlier today | 21:50 |
| jlvillal | devananda: It landed | 21:50 |
| devananda | neat. I was meaning to test it | 21:50 |
| jlvillal | Last commit | 21:50 |
| * devananda needs less to do | 21:51 | |
| jlvillal | Support for non-Glance image references | 21:51 |
| JoshNang | jlvillal: yup. super handy for nova. though you still have to wait 20 mins for their test suite to run :P | 21:51 |
| jlvillal | Ouch. I haven't run it yet... | 21:51 |
| devananda | jroll: tell me you tested it? | 21:51 |
| devananda | there's no tempest coverage for it yet, and as they say, if we dont test it, it's broken as soon as it lands | 21:52 |
| * devananda wants to see tempest tests that don't use glance, or swift, or keystone, or neutron, or nova -- and live in our tree | 21:52 | |
| jroll | devananda: I did not :x | 21:52 |
| devananda | jroll: :-( | 21:52 |
| jlvillal | JoshNang: Sweet on devpi. It is sort of what I was trying to do, but better :) | 21:52 |
| jroll | devananda: one manual test doesn't equal tested anyway, I'd still consider it broken | 21:53 |
| devananda | vdrok_afk: have you created tempest tests to exercise the non-glance image refs feature? | 21:53 |
| jroll | but I could test it quick | 21:53 |
| devananda | vdrok_afk: if not, please consider doing so | 21:53 |
| devananda | jroll: cool. if youve got an env for it, thta'd be great. | 21:53 |
| devananda | I have to jump on a call w/ a customer | 21:54 |
| * jroll makes one | 21:54 | |
| *** mgoddard has quit IRC | 21:55 | |
| NobodyCam | devananda: what would you think about validate checking that it can indeed create a temp file? | 21:57 |
| devananda | oh right | 21:58 |
| devananda | NobodyCam: not in validate. in __init__ | 21:58 |
| NobodyCam | params can change on file systems | 21:59 |
| NobodyCam | would that only check at startup? | 21:59 |
| devananda | yes | 21:59 |
| devananda | we need to handle the error if it happens during deploy | 21:59 |
| devananda | but a sanity check at __init__ and subsequently refusing to start if the environment would prevent functioning is good | 22:00 |
| NobodyCam | I am thinking its a low cost check to look at os.stat for the dir is writable | 22:00 |
| devananda | on every call? | 22:00 |
| devananda | also - and do what? | 22:00 |
| devananda | I agree tht we should have beter error checking there | 22:00 |
| NobodyCam | for the error. just check that we can still create a file | 22:00 |
| devananda | also the error status is wrong | 22:00 |
| NobodyCam | I would say yes on every call to validate | 22:01 |
| devananda | "Failed to create the password file" is an ERROR, not a warning. because the service failed in an unexpected and unrecoverable way | 22:01 |
| NobodyCam | yes | 22:01 |
| devananda | "During sync_power_state, max retries exceeded for node" is NOT AN ERROR | 22:01 |
| devananda | that is totally expected normal behavior | 22:01 |
| devananda | that ironic is handling approrpiately. it's a NOTICE or WARNING at best | 22:01 |
| NobodyCam | ya | 22:02 |
| devananda | because omg the hardware just died is a thing that happens, and good software handles that gracefully, and LOG.error() indicates software failure | 22:02 |
| devananda | ok - me really jumps on a call now | 22:02 |
| NobodyCam | ack | 22:02 |
| *** barra204_ has joined #openstack-ironic | 22:03 | |
| *** shakamunyi has quit IRC | 22:03 | |
| jlvillal | NobodyCam: Maybe os.access() https://docs.python.org/2/library/os.html#files-and-directories | 22:05 |
| *** chuckC_ has joined #openstack-ironic | 22:06 | |
| *** barra204_ has quit IRC | 22:07 | |
| *** barra204_ has joined #openstack-ironic | 22:08 | |
| JoshNang | jroll: re: namedtuples in cleaning, i'm inclined to just use dicts | 22:08 |
| jroll | JoshNang: ya | 22:08 |
| jroll | dunno what namedtuples bring except a little speed | 22:09 |
| JoshNang | slightly nicer interface. i originally had it as dicts, but it was suggested to use namedtuples. other than this they were fine | 22:09 |
| jroll | if you want dots why not use objects :P | 22:10 |
| JoshNang | jroll: ++ | 22:10 |
| * JoshNang uses dicts | 22:10 | |
| jroll | awesome | 22:11 |
| JoshNang | blah i'll have to update the spec :/ | 22:11 |
| JoshNang | oh well | 22:11 |
| JoshNang | but nice catch, thanks | 22:11 |
| jroll | ugh | 22:12 |
| jroll | I think there's some updates needed anyway like s/driver/interface/ | 22:13 |
| *** BadCub is now known as BadCub_Away | 22:13 | |
| *** jjohnson2 has quit IRC | 22:13 | |
| NobodyCam | any thoughts on in _init) or Validate()? | 22:13 |
| jroll | ? | 22:13 |
| jroll | oh the ipmi thing | 22:13 |
| NobodyCam | oh the chat deva and I had | 22:13 |
| NobodyCam | yes | 22:13 |
| NobodyCam | I'm fond of in validate() | 22:14 |
| jroll | no reason to do it before the call, I think, that's only going to catch it one line sooner | 22:14 |
| JoshNang | jroll: oh yah, probably. | 22:14 |
| jroll | NobodyCam: although validate() has an api eh | 22:14 |
| jroll | hrm | 22:14 |
| NobodyCam | devananda's suggestion was in __INIT__ | 22:14 |
| NobodyCam | thou it super easy to chmod -w /tftpboot | 22:15 |
| NobodyCam | so I was thinking in each call to power validate | 22:15 |
| jroll | right, so there's three times we could run it here: 1) startup, 2) validate api call, 3) before each ipmi call | 22:15 |
| jroll | I think validate() covers both 2 and 3 | 22:15 |
| jroll | but imbw | 22:15 |
| *** mjturek1 has quit IRC | 22:17 | |
| NobodyCam | at startup would miss any change to a runing system, ie bad puppet /salt/cf engine rule, operator error | 22:18 |
| NobodyCam | 2 & 3 would cover that | 22:18 |
| jlvillal | JoshNang: jroll : Named tuples vs dict? I guess I think my_object.clean is cleaner than my_object['clean'], especially if we don't really care about what is the value of my_object['clean'] other than it is a unique identifier. | 22:19 |
| jroll | jlvillal: even if you have to have code to convert it to a dict? | 22:19 |
| * jlvillal might have been the person who suggested namedtuples ;) But I thought it was for states.py. But never got around to working on it. | 22:20 | |
| jlvillal | jroll: I don't understand. | 22:20 |
| jlvillal | Also a pointer to the patch under question might be nice :) As I don't know the specifics. | 22:20 |
| jroll | jlvillal: we have to put the data that's in this namedtuple into a dict later. | 22:20 |
| jroll | or at some point, I should say | 22:21 |
| JoshNang | jlvillal: nah this was way back in spec that it was proposed. | 22:21 |
| JoshNang | https://review.openstack.org/#/c/157208/ is the patch | 22:21 |
| devananda | also, my_object.get('clean') is nice, because I dont have to try: except KeyError: | 22:22 |
| jlvillal | jroll: JoshNang: maybe https://docs.python.org/2/library/collections.html#collections.namedtuple Look at the bottom where they say to make an enum it is better to do .... | 22:22 |
| JoshNang | it'll get stuffed in the db as json. json.dumps(namedtuple) gives you a list | 22:22 |
| devananda | also, defaultdict is great for that | 22:22 |
| JoshNang | devananda: ++ | 22:22 |
| devananda | and this is why I don't like tuples for things that are not absolutely static | 22:22 |
| devananda | states.py is a fair example where a tuple makes sense | 22:22 |
| jlvillal | class Status: | 22:23 |
| jlvillal | open, pending, closed = range(3) | 22:23 |
| devananda | the code always knows what the values should be. unless you've REALLY broken something | 22:23 |
| jlvillal | class Status: | 22:23 |
| jlvillal | open, pending, closed = ('open', 'pending', 'closed') | 22:23 |
| jlvillal | Maybe :) | 22:23 |
| devananda | jlvillal: why is this a class? | 22:23 |
| openstackgerrit | Victor Lowther proposed openstack/ironic: Add DRAC BIOS config vendor passthru API -- DO NOT MERGE https://review.openstack.org/150488 | 22:23 |
| jlvillal | devananda: https://docs.python.org/2/library/collections.html#collections.namedtuple They suggest to use a class if all you are trying to do is make an enum | 22:24 |
| jlvillal | Instead of using namedtuple | 22:24 |
| * jlvillal only learned that last week. | 22:24 | |
| devananda | jlvillal: uh, ok. why? | 22:24 |
| jlvillal | devananda: I think because it is simpler. | 22:24 |
| jlvillal | That class does look simple | 22:24 |
| jlvillal | That is my best guess why | 22:25 |
| devananda | jlvillal: this looks nothing like what we do in states.py | 22:26 |
| devananda | "Named tuples assign meaning to each position in a tuple" | 22:26 |
| devananda | that is not an enum | 22:26 |
| devananda | it is an array of fixed length where different positions have different semantic meaning. and rather than referring to the array index, you can use a name | 22:27 |
| devananda | an enum is a variable with a single value that comes from a fixed set of potential values | 22:27 |
| jlvillal | devananda: Agreed. I was just looking at namedtuples and saw that about enum. In states.py I was looking at VERBS. | 22:27 |
| jlvillal | devananda: I think you are talking about all the state variables. Like MANAGED ='', CLEANED = '' ??? | 22:28 |
| jlvillal | devananda: I never pursued it though. I was just looking. I'm unsure what is best method. | 22:28 |
| *** chuckC_ has quit IRC | 22:41 | |
| NobodyCam | wind picking up.. /me runs outside to put the awning up! | 22:44 |
| *** ijw has quit IRC | 22:50 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement Cleaning in DriverInterfaces https://review.openstack.org/157208 | 22:57 |
| *** barra204_ has quit IRC | 22:57 | |
| *** spandhe has quit IRC | 22:58 | |
| *** BadCub_Away is now known as BadCub | 22:59 | |
| *** jgrimm is now known as zz_jgrimm | 23:01 | |
| *** spandhe has joined #openstack-ironic | 23:02 | |
| *** romcheg has quit IRC | 23:04 | |
| *** romcheg has joined #openstack-ironic | 23:05 | |
| jroll | devananda: using ironic without nova is a pain | 23:10 |
| jroll | rather, TIL how to manually create and plug vifs | 23:10 |
| devananda | jroll: flat network, trusted single tenant | 23:11 |
| jlvillal | JoshNang: Thanks for the devpi and wheel info. I think it is faster. 26 seconds to create the environment. | 23:11 |
| jroll | devananda: eh? | 23:11 |
| jroll | devananda: even with those facts, it was painful | 23:11 |
| devananda | jroll: did you use neutron? | 23:12 |
| *** andreykurilin_ has joined #openstack-ironic | 23:12 | |
| devananda | i think i'm ,issing something | 23:12 |
| jroll | devananda: yes, plain devstack with pxe driver | 23:12 |
| JoshNang | jlvillal: nice | 23:12 |
| devananda | jroll: oooh | 23:12 |
| jroll | and even that didn't work. wth | 23:13 |
| devananda | jroll: try using ironic w/o nova OR neutron | 23:13 |
| jroll | devananda: really don't feel like configuring dhcp | 23:13 |
| jroll | and then *re*-configuring dhcp | 23:13 |
| devananda | jroll: static dhcp to the agent. local boot. | 23:13 |
| jroll | I guess I could use IPA | 23:13 |
| jroll | ya | 23:13 |
| devananda | right | 23:13 |
| jroll | still don't want to configure dhcp :P | 23:14 |
| *** anderbubble has quit IRC | 23:14 | |
| * jroll never claimed to know how to do that | 23:14 | |
| devananda | heh | 23:14 |
| *** anderbubble has joined #openstack-ironic | 23:15 | |
| *** achanda has quit IRC | 23:16 | |
| *** achanda has joined #openstack-ironic | 23:20 | |
| *** derekh has joined #openstack-ironic | 23:23 | |
| *** BadCub is now known as BadCub_Away | 23:23 | |
| jroll | BadCub_Away: it appears this might be done https://blueprints.launchpad.net/ironic/+spec/ironic-virtualbox-webservice-support | 23:38 |
| jroll | BadCub_Away: this one too https://blueprints.launchpad.net/ironic/+spec/irmc-management-driver | 23:39 |
| NobodyCam | jroll: he'll be back in a bit.. | 23:41 |
| jroll | NobodyCam: just leaving notes :) | 23:42 |
| jroll | he can update it next week for all I care :P | 23:42 |
| NobodyCam | devananda: jroll: thoughts on calling somehting like this from validate? http://paste.openstack.org/show/b4MwElxD2u7qITtj9doW | 23:43 |
| NobodyCam | ^^ is jsut ruff draft | 23:44 |
| jroll | NobodyCam: seems like overkill but probably fine | 23:44 |
| NobodyCam | I added space for temp_dir could be a diff file sysstem | 23:45 |
| NobodyCam | I added space CHECK for temp_dir as it could be a ... | 23:46 |
| jroll | ya | 23:46 |
| NobodyCam | is that to heavy to call from validate? | 23:46 |
| jroll | probably could make it 4k | 23:46 |
| jroll | the space check | 23:46 |
| NobodyCam | yea this was jsut me thinking | 23:46 |
| jroll | right | 23:47 |
| jroll | idk if it's too heavy | 23:47 |
| jroll | just seems like a lot of code | 23:47 |
| NobodyCam | lol have you looked at ipmitools _parse_driver_info | 23:50 |
| jroll | >.> | 23:51 |
| NobodyCam | :-p | 23:51 |
| *** chuckC_ has joined #openstack-ironic | 23:52 | |
| *** Marga_ has joined #openstack-ironic | 23:52 | |
| *** Marga_ has quit IRC | 23:53 | |
| *** Marga_ has joined #openstack-ironic | 23:53 | |
| *** romcheg has quit IRC | 23:56 | |
| jlvillal | NobodyCam: On your pastebin | 23:59 |
| jlvillal | Who deletes the tempdir? | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!