| devananda | k k | 00:00 |
|---|---|---|
| ramineni | jroll: right, updated, will check now again :) | 00:00 |
| * NobodyCam notes that it is 5 pm and thus time to start the yard work! | 00:00 | |
| devananda | NobodyCam: mmm yard work! | 00:00 |
| NobodyCam | lol | 00:00 |
| ramineni | jroll: https://review.openstack.org/#/c/157715/, review ? | 00:00 |
| BadCub | *groans* yard work = shoveling and sifting mounds of sand | 00:01 |
| jroll | ramineni: I'll try to get to it tonight, maybe tomorrow morning | 00:01 |
| NobodyCam | again everyone Great day.. thank you reviewers and devs alike! | 00:01 |
| BadCub | devananda: new category added/root device hints moved | 00:02 |
| ramineni | jroll: sure, thanks | 00:02 |
| *** r-daneel has joined #openstack-ironic | 00:02 | |
| jroll | np :) | 00:02 |
| devananda | anyone else get bumped from the pad just now? | 00:02 |
| BadCub | nope | 00:02 |
| JoshNang | ramineni: testing with creating the cleaning port with mac addrs | 00:03 |
| *** naohirot has joined #openstack-ironic | 00:03 | |
| ramineni | JoshNang: :), m doing the same | 00:04 |
| * BadCub goes heads off to yard work purgatory as punishment for his sins | 00:04 | |
| *** BadCub is now known as BadCub_Away | 00:04 | |
| BadCub_Away | be back for meeting tonight :-p | 00:04 |
| jroll | devananda: I did | 00:05 |
| devananda | proxy error. seems to be working now | 00:05 |
| *** igordcard_ has quit IRC | 00:10 | |
| mrda | devananda: that's review https://review.openstack.org/#/c/163730/ (New field 'name' not supported in port REST API) | 00:13 |
| devananda | mrda: cheers. added t omy review queue and targeted to RC1 | 00:14 |
| mrda | thanks devananda | 00:15 |
| openstackgerrit | Devananda van der Veen proposed openstack/python-ironicclient: Hide resources missing from server responses - POC - DO NOT MERGE https://review.openstack.org/162834 | 00:22 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add uefi support in image extension https://review.openstack.org/163739 | 00:25 |
| *** ijw has quit IRC | 00:27 | |
| stendulker | NobodyCam: Hi | 00:28 |
| *** rameshg87 has joined #openstack-ironic | 00:28 | |
| rameshg87 | good morning ironic :) | 00:28 |
| stendulker | rameshg87: good morning :) | 00:28 |
| rameshg87 | stendulker: morning | 00:28 |
| mrda | hi stendulker and rameshg87 | 00:29 |
| rameshg87 | hello mrda | 00:29 |
| stendulker | mrda : Hi | 00:29 |
| stendulker | Is tests broken on git master ? | 00:29 |
| stendulker | Upon refreshing to latest I get tox failures | 00:30 |
| stendulker | Related to import errors | 00:30 |
| stendulker | http://paste.openstack.org/show/192763/ | 00:30 |
| JayF | I kinda have a negative review for https://review.openstack.org/#/c/163857 but it already landed | 00:31 |
| JayF | we're using "root_device=" as the command line argument to the kernel | 00:31 |
| JayF | which is a pretty ... generic name to put in such a crowded namespace | 00:31 |
| JayF | and doesn't match up with the existing IPA config options (ipa-config-option vs ipa_config_option or config_option) | 00:31 |
| JayF | IDK if that's something preexisting, but I strongly suspect we're going to /really/ break an unsuspecting init one day | 00:32 |
| stendulker | these failure slooks looks like post merge of https://review.openstack.org/#/c/162501 | 00:32 |
| JoshNang | stendulker: either rebuild your tox venv with tox -r, or source the venv and do 'pip install -U -r requirements.txt' | 00:33 |
| JoshNang | i'd recommend the latter :) basically, a new package was added that your venv doesn't have | 00:33 |
| stendulker | JoshNang: Thanks, will try that | 00:34 |
| JoshNang | np! | 00:34 |
| *** r-daneel has quit IRC | 00:37 | |
| rameshg87 | mrda: hi | 00:46 |
| rameshg87 | mrda: i was just trying out your changes. | 00:46 |
| *** Marga_ has quit IRC | 00:46 | |
| rameshg87 | mrda: http://paste.openstack.org/show/192764/ | 00:46 |
| * mrda looks | 00:47 | |
| *** Marga_ has joined #openstack-ironic | 00:47 | |
| rameshg87 | mrda: it still looks like for an older micro api version, we will throw different error codes for different inputs | 00:47 |
| rameshg87 | mrda: now i haven't worked much on api, but i think we expect it to be the same | 00:47 |
| *** achanda_ has quit IRC | 00:48 | |
| rameshg87 | mrda: in case 1 (with input 1234), it gets caught in L93 of https://review.openstack.org/#/c/163730/4/ironic/api/controllers/v1/utils.py | 00:48 |
| mrda | rameshg87: What's '%1234' meant to represent? | 00:48 |
| rameshg87 | just a bad logical name :) | 00:48 |
| rameshg87 | mrda: in case 2 (with %1234), it gets caught in https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/types.py#L68 | 00:49 |
| rameshg87 | mrda: i mean still for older versions | 00:49 |
| rameshg87 | mrda: for hostname-like-names we throw 406, doesnt-look-like-hostname we throw 400 | 00:49 |
| rameshg87 | mrda: shouldn't that be consistent ? | 00:50 |
| *** jmccrory has joined #openstack-ironic | 00:50 | |
| * mrda looks | 00:51 | |
| mrda | So the comments through the review were that if we tried to access via a name, and it wasn't supported because the microversion wasn't > 1.5, we should throw a NotAcceptable | 00:54 |
| mrda | I guess what this comes back to what I said in https://review.openstack.org/#/c/163730/3..4/ironic/api/controllers/v1/utils.py regarding the 4 different use cases. | 00:55 |
| mrda | What is the expected behaviour? | 00:55 |
| *** jmccrory has quit IRC | 00:55 | |
| mrda | If this isn't where we want to throw a NotAcceptable, when would we ever throw that? Was it wrong to throw a 406 NotAcceptable back in https://review.openstack.org/#/c/141737/ ? | 00:57 |
| rameshg87 | mrda: yeah we used to do the same thing then and it was approved | 00:58 |
| rameshg87 | mrda: ah no | 00:58 |
| rameshg87 | mrda: ah yes sorry | 00:58 |
| rameshg87 | mrda: we did | 00:59 |
| mrda | I don't mind changing the behaviour, but for consistency I think what I'm proposing now is better. | 00:59 |
| rameshg87 | mrda: are different return codes for different input okay ? | 01:00 |
| mrda | Well, one is always an error "%1234" | 01:00 |
| rameshg87 | mrda: before we supported logical names, we always used to return 400 | 01:01 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: ilo_iscsi driver do not validate boot_option https://review.openstack.org/164414 | 01:01 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 01:01 |
| rameshg87 | mrda: may be i am confused .. :D | 01:01 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 01:01 |
| mrda | But using a logical name, when it is not supported, is an intersting case. Should we conform to existing behaviour? Or should we identify the fact that they are trying to access an API that is not available at this microversion? | 01:01 |
| mrda | rameshg87: I'm happy to say that we're both confused :) | 01:02 |
| rameshg87 | :) | 01:02 |
| rameshg87 | mrda: i think everyone on your first review agreed that we should "identify the fact that they are trying to access an API that is not available at this microversion" | 01:02 |
| rameshg87 | mrda: i assume | 01:03 |
| mrda | I will raise a comment on this code, and when devananda reviews it, he can join the debate | 01:03 |
| rameshg87 | yeah ideal :) | 01:03 |
| *** dmellado has quit IRC | 01:03 | |
| rameshg87 | i think we should anyway get this code before feature freeze | 01:03 |
| mrda | So if you look at https://review.openstack.org/#/c/141737/29/ironic/api/controllers/v1/node.py#L973 NotAcceptable was added by someone while I was away over a weekend | 01:03 |
| mrda | ...and approved. So I have assumed this is the will of the team :) | 01:04 |
| rameshg87 | oh okay .. | 01:05 |
| rameshg87 | even this is my first project i am working with REST APIs, so i don't have prior experience to judge the behaviour :) | 01:05 |
| rameshg87 | so let's check with devananda then when he is around | 01:06 |
| *** chenglch has joined #openstack-ironic | 01:06 | |
| mrda | rameshg87: microversions are new to us all | 01:06 |
| rameshg87 | :) | 01:06 |
| stendulker | JoshNang: your suggestion worked. thanks again :) | 01:06 |
| JoshNang | \o/ | 01:07 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 01:08 |
| *** kbs has joined #openstack-ironic | 01:08 | |
| mrda | rameshg87: Just added a comment to https://review.openstack.org/#/c/163730/ and will raise this at the meeting in a few hours | 01:09 |
| rameshg87 | mrda: thanks .. that will be great :) | 01:09 |
| mrda | np | 01:10 |
| rameshg87 | JoshNang: if you are around, can you please review https://review.openstack.org/#/c/162392/ | 01:16 |
| JoshNang | rameshg87: sure, might be a little bit though...working on getting the agent cleaning bits working | 01:18 |
| rameshg87 | JoshNang: sure .. thanks | 01:19 |
| openstackgerrit | Adam Gandelman proposed openstack/ironic: Migrate to using keystoneclient Sessions https://review.openstack.org/156344 | 01:22 |
| jamielennox | adam_g: is there a way we can do this without using the keystone_authtoken user | 01:23 |
| *** dmellado has joined #openstack-ironic | 01:26 | |
| *** PaulCzar has quit IRC | 01:27 | |
| *** kbs has quit IRC | 01:28 | |
| *** dmellado has quit IRC | 01:35 | |
| *** ramineni has quit IRC | 01:54 | |
| *** Marga_ has quit IRC | 01:55 | |
| *** Marga_ has joined #openstack-ironic | 01:58 | |
| *** dmellado has joined #openstack-ironic | 02:01 | |
| openstackgerrit | Merged openstack/ironic: Fixup log message for discoverd https://review.openstack.org/164792 | 02:03 |
| *** Marga_ has quit IRC | 02:08 | |
| *** Marga_ has joined #openstack-ironic | 02:10 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Fix nit in test_get_agent_params_from_cache https://review.openstack.org/164805 | 02:13 |
| *** Marga_ has quit IRC | 02:13 | |
| *** absubram has joined #openstack-ironic | 02:16 | |
| *** absubram has quit IRC | 02:20 | |
| *** absubram has joined #openstack-ironic | 02:20 | |
| *** coolsvap|afk is now known as coolsvap | 02:27 | |
| *** achanda has joined #openstack-ironic | 02:27 | |
| *** rloo_afk has quit IRC | 02:35 | |
| *** krtaylor has quit IRC | 02:38 | |
| *** ramineni has joined #openstack-ironic | 02:41 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add retry logic for lsblk after running partx https://review.openstack.org/164931 | 02:47 |
| *** rameshg87 has left #openstack-ironic | 02:48 | |
| adam_g | jamielennox, how do you mean? | 02:48 |
| jamielennox | adam_g: essentially the user specified in keystone_authtoken should be considered off limits | 02:49 |
| adam_g | jamielennox, that patch is probably not 100% there yet but the goal is to move away from the authtoken config | 02:49 |
| *** stendulker has quit IRC | 02:49 | |
| jamielennox | adam_g: excellent | 02:49 |
| jamielennox | i had a start on one: https://review.openstack.org/#/c/162037/ | 02:49 |
| jamielennox | but neutronclient isn't that hard, swift and glance are | 02:49 |
| *** krtaylor has joined #openstack-ironic | 02:50 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Use labels for virtual media dev in agent ramdisk https://review.openstack.org/162392 | 02:50 |
| adam_g | jamielennox, your feedback is welcome on 162392, was going to ping you tomorrow about it actually. i think i have most of the clients converted, but whether or not they are using KSC correctly is another story. :) | 02:51 |
| jamielennox | adam_g: i get caught up in the details when i don't know the project well | 02:51 |
| jamielennox | for example with swift, if it gets an unauthorized it would have tried to auth again, but with this it can't because it doens't have a user/pass | 02:52 |
| jamielennox | and there's essentially nothing i can see that can be done about it | 02:52 |
| *** achanda has quit IRC | 02:52 | |
| adam_g | jamielennox, i was hoping to wrap all that logic up in ironic.common.keystone.KeystoneSerssion in the patch i pushed earlier | 02:53 |
| *** yuanying has quit IRC | 02:54 | |
| adam_g | jamielennox, anyway, i gotta run. comments welcome, cya | 02:54 |
| jamielennox | adam_g: no problem - cya | 02:55 |
| openstackgerrit | Merged openstack/python-ironicclient: Metavar name should be hyphenated https://review.openstack.org/164781 | 03:10 |
| openstackgerrit | Merged openstack/ironic: IPA: Add support for root device hints https://review.openstack.org/163857 | 03:11 |
| openstackgerrit | Merged openstack/ironic: Update unittests and use NamedTemporaryFile https://review.openstack.org/162672 | 03:14 |
| *** harlowja is now known as harlowja_away | 03:15 | |
| *** kan__ has joined #openstack-ironic | 03:22 | |
| *** stendulker has joined #openstack-ironic | 03:24 | |
| *** Nisha has joined #openstack-ironic | 03:33 | |
| *** dmellado has quit IRC | 03:33 | |
| *** david-lyle is now known as david-lyle_afk | 03:35 | |
| *** yuanying has joined #openstack-ironic | 03:39 | |
| *** mitz has quit IRC | 03:40 | |
| *** dmellado has joined #openstack-ironic | 03:41 | |
| *** coolsvap is now known as coolsvap|afk | 03:48 | |
| *** penick has joined #openstack-ironic | 03:48 | |
| *** coolsvap|afk is now known as coolsvap | 03:55 | |
| JoshNang | \o/ got agent cleaning working, patch on the way :) | 03:59 |
| jlvillal | Woo hoo!! It was finally merged ^^^^^ :D | 03:59 |
| JoshNang | jlvillal: wooo! | 03:59 |
| JoshNang | celebration all around | 03:59 |
| jlvillal | JoshNang: Congrats to you also. Though my arm hurts from patting myself on my back ;) | 04:00 |
| JoshNang | lol thanks | 04:00 |
| jlvillal | Darn meeting is still another hour away.... | 04:01 |
| *** achanda has joined #openstack-ironic | 04:01 | |
| ramineni | JoshNang: great :) | 04:01 |
| ramineni | JoshNang: what was the issue? | 04:02 |
| *** subscope_ has joined #openstack-ironic | 04:04 | |
| JoshNang | part of it is the vif is cached on the ironic port object, and the dhcp update code uses that. the other part was getting some syntax correct | 04:05 |
| ramineni | JoshNang: ok | 04:05 |
| JoshNang | err, right set of keys from the port objects, i suppose | 04:05 |
| JoshNang | i'll put up a patch before the meeting, but i'm gonna take a break now | 04:06 |
| ramineni | JoshNang: thanks, will update my patch accordingly :) | 04:06 |
| JoshNang | ramineni: yay! and sorry this has taken forever :( | 04:06 |
| ramineni | JoshNang: np :) | 04:07 |
| jlvillal | Anybody bored and want to give me feedback on: https://review.openstack.org/164226 :) | 04:26 |
| *** mitz has joined #openstack-ironic | 04:34 | |
| openstackgerrit | Sirushti Murugesan proposed openstack/ironic: Raise exception for Agent Deploy driver when using partition images https://review.openstack.org/164440 | 04:40 |
| *** kalpase has joined #openstack-ironic | 04:40 | |
| *** rameshg87 has joined #openstack-ironic | 04:40 | |
| *** oomichi has joined #openstack-ironic | 04:41 | |
| *** oomichi has quit IRC | 04:41 | |
| jroll | JoshNang: sick | 04:42 |
| *** achanda has quit IRC | 04:46 | |
| *** achanda has joined #openstack-ironic | 04:49 | |
| *** achanda has quit IRC | 04:49 | |
| devananda | o/ | 04:56 |
| *** pradipta has joined #openstack-ironic | 04:57 | |
| jroll | \o | 04:58 |
| *** Marga_ has joined #openstack-ironic | 04:58 | |
| mrda | o/ | 04:58 |
| jlvillal | meeting time :) | 05:00 |
| jlvillal | jroll: Are you still going to be up reviewing patches at 6am? ;) | 05:02 |
| jlvillal | I'm impressed with how early you are online! | 05:02 |
| jroll | jlvillal: we shall see :) | 05:03 |
| jlvillal | :) | 05:03 |
| jroll | I'm an earlybird | 05:03 |
| *** Marga_ has quit IRC | 05:04 | |
| jroll | naohirot: so, it's nothing against you | 05:16 |
| jroll | naohirot: but being "graduated" is no mark of whether a project is good or production ready | 05:16 |
| jroll | naohirot: not to mention the entire concept of graduation is going away | 05:16 |
| openstackgerrit | Anusha Ramineni proposed stackforge/proliantutils: IPA_HW_MANAGER: Add support to get_clean_steps https://review.openstack.org/162870 | 05:25 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 05:33 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add uefi support for agent iscsi deploy https://review.openstack.org/164386 | 05:33 |
| * mrda gets ready to bug people to get https://review.openstack.org/#/c/163730 landed :) | 05:34 | |
| *** kalpase1 has joined #openstack-ironic | 05:40 | |
| *** kalpase has quit IRC | 05:41 | |
| *** kan__ has quit IRC | 05:42 | |
| *** subscope_ has quit IRC | 05:43 | |
| jroll | http://i.imgur.com/44YntFd.jpg hahaha | 05:43 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 05:43 |
| JoshNang | nova cleaning patches: https://review.openstack.org/#/c/161474/ and https://review.openstack.org/#/c/164313/ | 05:43 |
| JoshNang | (more eyes never hurt) | 05:43 |
| mrda | I'll bug some cores that I'm close with | 05:44 |
| mrda | thanks JoshNang | 05:44 |
| JoshNang | np! | 05:44 |
| JoshNang | and thanks for the help! | 05:44 |
| openstackgerrit | Merged openstack/ironic: Force LANGUAGE=en_US in test runs https://review.openstack.org/164226 | 05:44 |
| jroll | aw, my picture got overrun by real work | 05:44 |
| JoshNang | jroll: :O pretty sure you lose points when you fail to idle | 05:45 |
| jroll | no, you're missing it :D | 05:45 |
| jroll | it's subtle | 05:45 |
| JoshNang | oh lol /dev/null? | 05:45 |
| jroll | yes | 05:45 |
| jroll | :P | 05:45 |
| JoshNang | heh | 05:45 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 05:48 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 05:53 |
| *** takadayuiko has joined #openstack-ironic | 06:00 | |
| naohirot | devananda: jroll: regarding the Ironic project status, If you got the same question as mine many times, I think this is the one of main reasons | 06:01 |
| jroll | naohirot: what is one of the main reasons? | 06:01 |
| naohirot | jroll: https://wiki.openstack.org/wiki/Ironic | 06:01 |
| naohirot | jroll: the status said "ronic is officially Integrated with OpenStack beginning with the "Kilo" release. " | 06:02 |
| jroll | right. that's true. | 06:02 |
| devananda | oh | 06:02 |
| jroll | whyw ould that make people ask? | 06:02 |
| devananda | perhaps it's a language nuance? | 06:02 |
| naohirot | jroll: I think this is true from Ironic's developer's point of view | 06:02 |
| devananda | "beginning with" means, to us, at the start of the dev cycle | 06:02 |
| jroll | ah, I see | 06:03 |
| naohirot | jroll: but from customer's point of view, beginning of Kilo means the end of Kilo development cycle | 06:03 |
| jroll | I just wish people didn't care, and instead evaluated proejcts on their own merits. | 06:03 |
| devananda | how's this -- Ironic completed the project graduation review at the end of the "Juno" cycle, and began "Kilo" as an officially Integrated OpenStack project. | 06:04 |
| jroll | naohirot: kilo is the first release where Ironic ships as part of the "OpenStack integrated release", as I understand it | 06:04 |
| jroll | devananda: I think that could have the same implications, but may be better | 06:04 |
| devananda | jroll: ++ to just evaluating on merits. but also, soooo many operators want the TC to give them some guidance | 06:04 |
| jroll | devananda: yeah. I think the answer to that is the operator community needs to be more tightly-knit, and talk more. give each other guidance | 06:05 |
| devananda | jroll: yah. well. I hope tagging gives them the tools to do that | 06:05 |
| jroll | devananda: e.g. picking a web framework for a random project; I look at others' experiences, and the frameworks themselves, and evaluate that way | 06:05 |
| naohirot | devananda: how's this > that's good to me :) | 06:06 |
| * devananda updates wiki | 06:06 | |
| jroll | devananda: tagging may help but I think people may be hesitant to tag "production ready" etc which is what operators really want | 06:06 |
| devananda | jroll: heh. we wont use that tag | 06:06 |
| jroll | devananda: exactly, but that's what people want guidance on. | 06:06 |
| devananda | right | 06:07 |
| devananda | but everyone has different criteria for tht | 06:07 |
| jroll | indeed | 06:07 |
| jroll | I need to sleep | 06:07 |
| jroll | see y'all tomorrow :) | 06:07 |
| devananda | naohirot: also re: documentation, the openstack docs team has not committed to provide documentation for all projects | 06:08 |
| devananda | jroll: me too. g'night | 06:08 |
| naohirot | devananda: I see, so is somebody writing openstack manual for Ironic except doc team? | 06:09 |
| devananda | dtantsur|afk: oh hey, you should list discoverd on the wiki - https://wiki.openstack.org/wiki/Ironic | 06:09 |
| devananda | naohirot: not that i know of -- but someone should! | 06:09 |
| devananda | naohirot: if i could hire a doc writer to do that, believe me, i would have done that six months ago ... | 06:09 |
| naohirot | devananda: I see. | 06:10 |
| naohirot | devananda: right now luck of document makes us understand Ironic difficult. | 06:11 |
| naohirot | devananda: Still I couldn't figure out if one Ironic conductor can manage multiple of tenants or not | 06:11 |
| devananda | naohirot: we have been doing as much as we can with the in-tree docs, including an installation guide, operations manual, etc. but yea there is a lot still missing | 06:12 |
| *** Marga_ has joined #openstack-ironic | 06:12 | |
| devananda | naohirot: it can not. for multiple tenants, or for managing project quotas, you need nova | 06:12 |
| devananda | naohirot: that is to say, one ironic-conductor can service all the tenants, but ironic does not record the tenant information -- that is Nova's job | 06:12 |
| *** absubram has quit IRC | 06:12 | |
| devananda | they work together | 06:12 |
| devananda | see? we need docs ... i know ... | 06:13 |
| naohirot | devananda: can Ironic conductor manage multiple of flat subnets? | 06:13 |
| *** Marga_ has quit IRC | 06:15 | |
| naohirot | jroll: good night | 06:15 |
| *** Marga_ has joined #openstack-ironic | 06:15 | |
| devananda | naohirot: with or without neutron? | 06:17 |
| naohirot | devananda: with neutron | 06:17 |
| devananda | naohirot: it is possible to isolate tenant physical networks with ironic + neutron, yes, but it is not trivial. so far I only know of two companies who are doing it | 06:18 |
| devananda | naohirot: and both implementations depend on a neutron plugin for their specific switch hardware | 06:19 |
| naohirot | devananda: okay, so is the Ironic default network assumed one big flat subnet right now? | 06:20 |
| *** mtanino has quit IRC | 06:21 | |
| *** yog__ has joined #openstack-ironic | 06:24 | |
| *** achanda has joined #openstack-ironic | 06:26 | |
| naohirot | devananda: I got a feedback of Ironic/Openstack prospective customer, they said that if each baremetal's customer can snoop other baremetal's network communication, that is really a problem. | 06:33 |
| naohirot | devananda: this is a background of my question. | 06:34 |
| openstackgerrit | Anusha Ramineni proposed stackforge/proliantutils: IPA_HW_MANAGER: Add support to get_clean_steps https://review.openstack.org/162870 | 06:42 |
| mrda | devananda: rameshg87 and I have put together https://etherpad.openstack.org/p/ironic-microversion-handling to discuss API microversion behaviour. jroll, rloo, lintan, lucasgomes, jlvillal <-- This might be of interest to you since you've showed interest inthis previously | 06:49 |
| * mrda runs away :-) | 06:49 | |
| *** killer_prince is now known as lazy_prince | 06:52 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: ilo_iscsi driver do not validate boot_option https://review.openstack.org/164414 | 06:53 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 06:53 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 06:54 |
| *** kalpase1 has quit IRC | 06:55 | |
| *** mrda is now known as mrda-away | 07:00 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add retry logic for lsblk after running partx https://review.openstack.org/164931 | 07:07 |
| *** achanda has quit IRC | 07:31 | |
| *** yog__ has quit IRC | 07:34 | |
| *** Marga_ has quit IRC | 07:34 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement cleaning/zapping for the agent driver https://review.openstack.org/161453 | 07:34 |
| JoshNang | ramineni: ^ | 07:35 |
| JoshNang | i got as far as get_clean_steps, because I wasn't using the agent patch that adds 'get_clean_steps' to the api. i'll rebase that patch and we can see if jenkins can figure out a 3 patch depends-on chain to test it :D | 07:36 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic-python-agent: Add cleaning/zapping support to IPA https://review.openstack.org/161066 | 07:36 |
| * JoshNang finally sleeps | 07:37 | |
| *** yog__ has joined #openstack-ironic | 07:38 | |
| *** Nisha has quit IRC | 07:49 | |
| *** kalpase has joined #openstack-ironic | 07:56 | |
| *** oomichi_ has joined #openstack-ironic | 08:02 | |
| *** dtantsur|afk is now known as dtantsur | 08:03 | |
| dtantsur | Morning! | 08:03 |
| *** Nisha has joined #openstack-ironic | 08:10 | |
| GheRivero | morning | 08:13 |
| dtantsur | devananda, done | 08:14 |
| dtantsur | GheRivero, morning! | 08:14 |
| *** ifarkas has joined #openstack-ironic | 08:19 | |
| *** mgoddard has joined #openstack-ironic | 08:24 | |
| *** kalpase has quit IRC | 08:31 | |
| rameshg87 | dtantsur: GheRivero: o/ | 08:35 |
| dtantsur | o/ | 08:35 |
| *** dlpartain has joined #openstack-ironic | 08:36 | |
| *** kalpase has joined #openstack-ironic | 08:37 | |
| ramineni | JoshNang: thanks :) | 08:38 |
| *** rsalevsky has joined #openstack-ironic | 08:46 | |
| *** andreykurilin_ has joined #openstack-ironic | 08:53 | |
| ramineni | dtantsur: hi, morning | 08:58 |
| dtantsur | morning | 08:58 |
| ramineni | dtantsur: https://review.openstack.org/#/c/157715/, review please? | 08:58 |
| dtantsur | if I have time, can't make any promises | 08:59 |
| ramineni | dtantsur: sure,thanks | 08:59 |
| *** pradipta has quit IRC | 08:59 | |
| openstackgerrit | Ghe Rivero proposed openstack/ironic-python-agent: Use oslo_log lib https://review.openstack.org/162790 | 09:00 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic-python-agent: Sync from oslo.incubator https://review.openstack.org/162791 | 09:00 |
| *** dlpartain has left #openstack-ironic | 09:01 | |
| *** jistr has joined #openstack-ironic | 09:04 | |
| *** jcoufal has joined #openstack-ironic | 09:05 | |
| *** pas-ha has joined #openstack-ironic | 09:14 | |
| *** yuriyz has joined #openstack-ironic | 09:16 | |
| dtantsur | Nisha, hey, do you plan on working on https://bugs.launchpad.net/ironic/+bug/1432860 ? I was assigned by deva, but maybe you want to do it... | 09:17 |
| openstack | Launchpad bug 1432860 in Ironic "inspect_*_at fields present in responses to unversioned request" [Medium,Confirmed] - Assigned to Dmitry "Divius" Tantsur (divius) | 09:17 |
| Nisha | dtantsur, hi | 09:21 |
| Nisha | i can ...yesterday deva told that on irc | 09:22 |
| Nisha | i wil take it up | 09:22 |
| Nisha | dtantsur, request reviews on https://review.openstack.org/151596 https://review.openstack.org/155900 https://review.openstack.org/163572 | 09:23 |
| dtantsur | ok, so please assign for yourself | 09:23 |
| dtantsur | will have a look today as time allows, sure | 09:23 |
| Nisha | Chris reviewed them and i have +2 from him on these | 09:23 |
| *** saripurigopi has joined #openstack-ironic | 09:27 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 09:29 |
| *** chenglch has quit IRC | 09:30 | |
| *** Nisha has quit IRC | 09:37 | |
| *** andreykurilin_ has quit IRC | 09:48 | |
| *** vdrok_afk is now known as vdrok | 09:50 | |
| vdrok | morning ironic | 09:50 |
| *** athomas has joined #openstack-ironic | 09:52 | |
| *** naohirot has quit IRC | 09:56 | |
| *** andreykurilin_ has joined #openstack-ironic | 09:56 | |
| *** vdrok has quit IRC | 09:57 | |
| *** mgoddard has quit IRC | 09:58 | |
| *** vdrok has joined #openstack-ironic | 09:58 | |
| *** igordcard_ has joined #openstack-ironic | 09:59 | |
| *** andreykurilin_ has quit IRC | 10:01 | |
| *** rameshg871 has joined #openstack-ironic | 10:16 | |
| *** rameshg87 has quit IRC | 10:18 | |
| *** rameshg871 has quit IRC | 10:18 | |
| *** mgoddard has joined #openstack-ironic | 10:20 | |
| *** lazy_prince has quit IRC | 10:25 | |
| *** killer_prince has joined #openstack-ironic | 10:29 | |
| *** killer_prince is now known as lazy_prince | 10:29 | |
| *** achanda has joined #openstack-ironic | 10:31 | |
| *** yuanying has quit IRC | 10:31 | |
| *** romcheg has joined #openstack-ironic | 10:35 | |
| *** achanda has quit IRC | 10:36 | |
| *** dtantsur is now known as dtantsur|brb | 10:37 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 10:46 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 10:50 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 10:51 |
| *** coolsvap is now known as coolsvap|afk | 10:53 | |
| *** rameshg87 has joined #openstack-ironic | 11:02 | |
| *** ramineni has quit IRC | 11:04 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 11:07 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 11:12 |
| *** stendulker_ has joined #openstack-ironic | 11:17 | |
| *** stendulker has quit IRC | 11:19 | |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers https://review.openstack.org/159734 | 11:29 |
| *** Marga_ has joined #openstack-ironic | 11:29 | |
| *** mtanino has joined #openstack-ironic | 11:46 | |
| *** igordcard has quit IRC | 11:48 | |
| *** igordcard has joined #openstack-ironic | 11:49 | |
| *** kbs has joined #openstack-ironic | 11:50 | |
| *** dprince has joined #openstack-ironic | 12:01 | |
| *** subscope has quit IRC | 12:02 | |
| *** kbs has quit IRC | 12:04 | |
| *** coolsvap|afk is now known as coolsvap | 12:04 | |
| *** oomichi_ has quit IRC | 12:06 | |
| *** subscope has joined #openstack-ironic | 12:14 | |
| *** dtantsur|brb is now known as dtantsur | 12:18 | |
| *** jistr is now known as jistr|class | 12:26 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add uefi support for agent iscsi deploy https://review.openstack.org/164386 | 12:27 |
| *** kalpase has quit IRC | 12:35 | |
| *** rameshg87 has left #openstack-ironic | 12:35 | |
| *** Marga_ has quit IRC | 12:42 | |
| *** Marga_ has joined #openstack-ironic | 12:46 | |
| *** saripurigopi has quit IRC | 12:47 | |
| *** kbs has joined #openstack-ironic | 12:47 | |
| openstackgerrit | Merged openstack/ironic: Rename _continue_deploy() to pass_deploy_info() https://review.openstack.org/164783 | 12:50 |
| *** PaulCzar has joined #openstack-ironic | 12:52 | |
| *** ChuckC has quit IRC | 13:04 | |
| *** ChuckC_ has joined #openstack-ironic | 13:04 | |
| *** ChuckC has joined #openstack-ironic | 13:07 | |
| *** ChuckC_ has quit IRC | 13:07 | |
| *** igordcard_ has quit IRC | 13:10 | |
| *** rloo has joined #openstack-ironic | 13:10 | |
| *** ijw has joined #openstack-ironic | 13:11 | |
| *** ijw has quit IRC | 13:11 | |
| *** ijw has joined #openstack-ironic | 13:12 | |
| *** ChuckC has quit IRC | 13:12 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 13:14 |
| *** ijw_ has joined #openstack-ironic | 13:15 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Stop waiting for power off to happen after introspection https://review.openstack.org/165062 | 13:16 |
| *** ijw has quit IRC | 13:16 | |
| *** kkoski has joined #openstack-ironic | 13:18 | |
| *** pas-ha has quit IRC | 13:20 | |
| *** mtanino has quit IRC | 13:24 | |
| *** alexpilotti has joined #openstack-ironic | 13:27 | |
| *** ramineni has joined #openstack-ironic | 13:28 | |
| *** alexpilotti has quit IRC | 13:32 | |
| *** alexpilotti has joined #openstack-ironic | 13:32 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 13:32 |
| *** ChuckC has joined #openstack-ironic | 13:33 | |
| *** ramineni has quit IRC | 13:33 | |
| *** pas-ha has joined #openstack-ironic | 13:36 | |
| *** ramineni has joined #openstack-ironic | 13:40 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 13:42 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 13:43 |
| *** takadayuiko has quit IRC | 13:57 | |
| *** romcheg has quit IRC | 13:59 | |
| *** romcheg1 has joined #openstack-ironic | 13:59 | |
| jroll | morning all :) | 14:02 |
| jroll | JoshNang: I fixed up your devstack patch | 14:02 |
| *** subscope has quit IRC | 14:03 | |
| *** lsmola has quit IRC | 14:03 | |
| *** r-daneel has joined #openstack-ironic | 14:03 | |
| NobodyCam | jroll: awesome! | 14:04 |
| NobodyCam | and good morning Ironicers | 14:04 |
| jroll | hey NobodyCam :) | 14:04 |
| NobodyCam | :) | 14:05 |
| *** lsmola has joined #openstack-ironic | 14:05 | |
| *** jistr|class is now known as jistr | 14:05 | |
| rloo | good morning early birds jroll, NobodyCam, and everyone else :) | 14:06 |
| jroll | morning rloo :) | 14:06 |
| *** lsmola has quit IRC | 14:06 | |
| NobodyCam | morning rloo :) | 14:06 |
| *** lsmola has joined #openstack-ironic | 14:06 | |
| NobodyCam | I fell asleep befor the meeting :( | 14:06 |
| rloo | jroll: qq. It didn't look like the subteam status reports were looked at in last night's meeting. should i send email anyway? | 14:07 |
| jroll | rloo: oh, I guess they weren't, ha | 14:07 |
| jroll | are there updates there? | 14:07 |
| jroll | not really, just asks for reviews | 14:08 |
| rloo | jroll: there is stuff there, so yeah, I'm guessing they are updates, cuz I usually clear them all out. | 14:08 |
| jroll | I vote do what you feel best, I'm inclined to skip it :) | 14:08 |
| jroll | I mean, they're saying "this patch landed, this patch needs reviews" | 14:08 |
| dtantsur | jroll, rloo, NobodyCam, morning! | 14:08 |
| rloo | jroll: ok. i'll send out email saying it wasn't discussed then. | 14:08 |
| jroll | and we already have places that say that. | 14:08 |
| NobodyCam | morning dtantsur :) | 14:08 |
| rloo | hi dtantsur | 14:09 |
| jroll | hey dtantsur :) | 14:09 |
| *** lsmola has quit IRC | 14:10 | |
| *** mtanino has joined #openstack-ironic | 14:10 | |
| NobodyCam | I'm going to fix the pep8 error on https://review.openstack.org/#/c/158520 | 14:10 |
| *** lsmola has joined #openstack-ironic | 14:10 | |
| *** ramineni has quit IRC | 14:10 | |
| *** BadCub_Away is now known as BadCub | 14:16 | |
| BadCub | morning everyone | 14:17 |
| NobodyCam | morning BadCub | 14:17 |
| dtantsur | BadCub, morning | 14:17 |
| jroll | heya BadCub :) | 14:18 |
| *** subscope has joined #openstack-ironic | 14:18 | |
| BadCub | morning jroll dtantsur and NobodyCam | 14:19 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 14:19 |
| *** stendulker_ has quit IRC | 14:25 | |
| openstackgerrit | Chris Krelle proposed openstack/python-ironicclient: Add support for logical names https://review.openstack.org/158520 | 14:28 |
| NobodyCam | ok that should fix the pep8 errors | 14:29 |
| *** zz_jgrimm is now known as jgrimm | 14:33 | |
| NobodyCam | :( 159734 is over 1000 lines :( | 14:33 |
| * NobodyCam re-freshes coffee before starting | 14:33 | |
| *** achanda has joined #openstack-ironic | 14:34 | |
| jroll | we need to encourage smaller patches :/ | 14:35 |
| NobodyCam | yea | 14:38 |
| rloo | jroll: we can. just -1 it. | 14:38 |
| jroll | heh | 14:38 |
| jroll | -1 tl;dr | 14:38 |
| rloo | seriously. if you think it should be done in smaller patches. i've had that done to me before. | 14:38 |
| jroll | yeah | 14:38 |
| *** Marga_ has quit IRC | 14:38 | |
| rloo | i am fine with 1000 line patches if they are well written. but if they aren't, there will be many revisions before it gets approved... | 14:39 |
| NobodyCam | I have to see what its doing... I agree sometimes you just have to do a massive amount of work to make things work right | 14:40 |
| jroll | yeah, they just take hours to review properly | 14:40 |
| NobodyCam | breaking it up can be tricky | 14:40 |
| NobodyCam | yep! | 14:40 |
| jroll | yeah | 14:40 |
| NobodyCam | but I like 200 - 500 lines :-p | 14:41 |
| rloo | I like 10 lines ;) | 14:41 |
| NobodyCam | lol | 14:41 |
| *** yog__ has quit IRC | 14:42 | |
| rloo | I'm looking at the IronicReviewDay etherpad: https://etherpad.openstack.org/p/IronicReviewDay | 14:43 |
| rloo | are the 'important features' the ones we want to land for k-3? | 14:43 |
| NobodyCam | yep just got bumped | 14:43 |
| *** achanda has quit IRC | 14:43 | |
| rloo | can we defer client changes to after k-3? | 14:44 |
| *** pas-ha has quit IRC | 14:44 | |
| *** romcheg1 has quit IRC | 14:44 | |
| jroll | yes | 14:44 |
| jroll | (I believe so, anyway) | 14:45 |
| rloo | jroll: of all these features, not clear what is higher priority. if any. eenie meenie miney mo... | 14:46 |
| jroll | indeed | 14:46 |
| *** rsalevsky has quit IRC | 14:46 | |
| *** absubram has joined #openstack-ironic | 14:46 | |
| jroll | rloo: there's basically cleaning and uefi/secureboot left | 14:47 |
| BadCub | Ilo Discovery is pretty high on the priority list | 14:47 |
| jroll | oh and discovery | 14:47 |
| *** rsalevsky has joined #openstack-ironic | 14:47 | |
| jroll | discovery stuff has +2s already, I'll be looking at those shortly | 14:47 |
| openstackgerrit | Merged openstack/ironic: Enable agent_ilo for uefi-bios switching https://review.openstack.org/162043 | 14:47 |
| rloo | a discoverin' i will go... | 14:49 |
| BadCub | rloo: Thank ya kindly ma'am :-) | 14:49 |
| *** romcheg has joined #openstack-ironic | 14:49 | |
| *** saripurigopi has joined #openstack-ironic | 14:53 | |
| *** pas-ha has joined #openstack-ironic | 14:56 | |
| *** david-lyle_afk is now known as david-lyle | 14:57 | |
| *** penick has quit IRC | 15:02 | |
| *** romcheg1 has joined #openstack-ironic | 15:03 | |
| *** romcheg has quit IRC | 15:03 | |
| NobodyCam | any IPA folk have a minute for https://review.openstack.org/#/c/163739 ? | 15:14 |
| JoshNang | jroll: ahh good catch | 15:29 |
| *** stendulker has joined #openstack-ironic | 15:29 | |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: [WIP] Add DevStack plugin for ironic-discoverd https://review.openstack.org/164782 | 15:30 |
| *** Marga_ has joined #openstack-ironic | 15:31 | |
| JoshNang | NobodyCam: let me grab coffee and i'll review it | 15:33 |
| NobodyCam | JoshNang: awesome thank you.. and Good Morning :) | 15:33 |
| NobodyCam | ohh more coffee... sounds like a plan... brb too | 15:34 |
| * jlvillal starts drinking his coffee :) | 15:34 | |
| jlvillal | Good morning NobodyCam JoshNang BadCub rloo jroll and the rest of Ironic. | 15:34 |
| jroll | JoshNang: I'm looking at that too, going to -1 if you don't want to bother yet | 15:35 |
| jroll | morning jlvillal and JoshNang :) | 15:36 |
| NobodyCam | morning jlvillal :) | 15:36 |
| JoshNang | jroll: works for me :P | 15:36 |
| BadCub | morning jlvillal | 15:37 |
| JoshNang | jroll: so i have the ironic cleaning patch dependent on the devstack change, but its still failing that it can't find the network uuid. maybe cause i have the ipa patch depending on ironic, ironic depends on devstack? | 15:42 |
| jroll | JoshNang: did the recheck finish? | 15:43 |
| JoshNang | the ironic one did, same fail | 15:43 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Check temp dir is writable for ipmitool driver https://review.openstack.org/160383 | 15:43 |
| jroll | huh | 15:43 |
| * jroll looks | 15:43 | |
| JoshNang | i'm pulling down your change to test locally anyway | 15:44 |
| *** saripurigopi has quit IRC | 15:50 | |
| rloo | morning jlvillal | 15:52 |
| jlvillal | NobodyCam: Feel free to ignore my idea on a default value :) Random thought that popped into my head. | 15:53 |
| NobodyCam | huh | 15:53 |
| NobodyCam | :-p | 15:53 |
| jlvillal | NobodyCam: https://review.openstack.org/160383 | 15:53 |
| jlvillal | Just an idea. | 15:53 |
| NobodyCam | phumm | 15:54 |
| NobodyCam | humm | 15:54 |
| NobodyCam | even | 15:54 |
| jlvillal | NobodyCam: fee-fi-fo-fum ;) | 15:55 |
| NobodyCam | let me think :) what if we defaulted to conf.tempdir and if none then use tempfile.gettempdir | 15:55 |
| NobodyCam | hehe | 15:56 |
| *** Marga_ has quit IRC | 15:56 | |
| *** ramineni has joined #openstack-ironic | 15:57 | |
| jlvillal | NobodyCam: That should work... And sorry if I'm keeping this patch set going and going and going.... | 15:58 |
| *** Marga_ has joined #openstack-ironic | 15:58 | |
| jlvillal | NobodyCam: I felt like that with the unittests I added related to this! :) | 15:58 |
| NobodyCam | jlvillal: not a issue at all.. :) just make'n better code :) | 15:58 |
| jlvillal | NobodyCam: During initialization is there a check that makes sure the CONF.tempdir is a valid directory if it has been set? Initialization of Ironic that is. | 15:59 |
| *** ijw_ has quit IRC | 15:59 | |
| jlvillal | NobodyCam: Just curious how far into the program would it blow if if the user set an invalid directory. | 15:59 |
| jlvillal | s/blow if/blow up if/ | 16:00 |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: [WIP] Add DevStack plugin for ironic-discoverd https://review.openstack.org/164782 | 16:02 |
| *** mdbooth has quit IRC | 16:02 | |
| jroll | JoshNang: this is strange | 16:03 |
| *** Marga_ has quit IRC | 16:03 | |
| JoshNang | hmm? | 16:04 |
| jlvillal | hrmm. | 16:04 |
| *** athomas has quit IRC | 16:06 | |
| *** mdbooth has joined #openstack-ironic | 16:07 | |
| *** athomas has joined #openstack-ironic | 16:11 | |
| jroll | JoshNang: https://review.openstack.org/#/c/161453/ | 16:12 |
| *** absubram has quit IRC | 16:13 | |
| *** Nisha has joined #openstack-ironic | 16:13 | |
| NobodyCam | jlvillal: you can get all the way to stRTING A DEPLOY | 16:14 |
| NobodyCam | gah | 16:14 |
| jlvillal | NobodyCam: Oh.... | 16:14 |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: [WIP] Add DevStack plugin for ironic-discoverd https://review.openstack.org/164782 | 16:16 |
| * BadCub needs food | 16:16 | |
| jlvillal | dtantsur is doing it like Devo. WIP it good! Waits for the groans... :) | 16:16 |
| dtantsur | :) | 16:17 |
| jroll | JoshNang: dude. I don't understand why this is breaking at all. | 16:18 |
| *** rameshg87 has joined #openstack-ironic | 16:20 | |
| JoshNang | jroll: me either. | 16:22 |
| jroll | JoshNang: might be worth adding some debug logging | 16:23 |
| jroll | but idk what to log | 16:23 |
| jroll | this looks correct http://logs.openstack.org/53/161453/9/check/check-tempest-dsvm-ironic-agent_ssh/ca17335/logs/etc/ironic/ironic.conf.txt.gz | 16:23 |
| jroll | and this clearly says we did something wrong http://logs.openstack.org/53/161453/9/check/check-tempest-dsvm-ironic-agent_ssh/ca17335/logs/screen-q-svc.txt.gz#_2015-03-17_15_02_25_350 | 16:24 |
| JoshNang | yup, that's what i get locally too | 16:24 |
| jroll | does it break locally as well? | 16:24 |
| JoshNang | yeah it is. i'm really really confused | 16:24 |
| JoshNang | like, this was working fine last night | 16:25 |
| *** ifarkas has quit IRC | 16:25 | |
| JoshNang | i'll just pepper logging all over.. | 16:27 |
| NobodyCam | I have been known to add lots of print "line #" for some debugging :-p | 16:28 |
| JoshNang | heh i had a bunch last night | 16:28 |
| NobodyCam | :-p | 16:29 |
| *** ramineni has quit IRC | 16:30 | |
| *** saripurigopi has joined #openstack-ironic | 16:31 | |
| *** absubram has joined #openstack-ironic | 16:32 | |
| JoshNang | jroll: unstacked and restacked and it works (past the cleaning uuid) | 16:32 |
| jroll | ... weird | 16:33 |
| rameshg87 | NobodyCam: jroll: just posted replies to your comments on https://review.openstack.org/#/c/163739/7/ironic_python_agent/extensions/image.py | 16:33 |
| * jroll rechecks | 16:33 | |
| NobodyCam | morning rameshg87 :) looking | 16:33 |
| jroll | rameshg87: alright, I'll think on it, thanks | 16:33 |
| rameshg87 | jroll: NobodyCam: morning :) | 16:34 |
| JayF | rameshg87: the only reason the environment works in that case is that by passing a string to utils.execute, you make it work in shell mode | 16:35 |
| JayF | rameshg87: rather than passing in args and building a clean environment + command | 16:35 |
| *** absubram has quit IRC | 16:36 | |
| rameshg87 | JayF: ah okay, shell=True, i didn't realise that :) | 16:36 |
| JayF | I'd suggest passing in a list and being explicit about the environment variables | 16:37 |
| NobodyCam | morning JayF :) | 16:37 |
| JayF | but I'm not one to nack something that works :) | 16:37 |
| JayF | morning | 16:37 |
| rameshg87 | JayF: and that's why we give all arguments to command as string | 16:37 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic-python-agent: Use oslo_log lib https://review.openstack.org/162790 | 16:38 |
| openstackgerrit | Ghe Rivero proposed openstack/ironic-python-agent: Sync from oslo.incubator https://review.openstack.org/162791 | 16:38 |
| BadCub | hey rameshg87 did you see my comment/question on https://review.openstack.org/#/c/163739 ? | 16:39 |
| Shrews | jroll: hey, google says that you have seen this error message before: "systemctl[292]: Failed to switch root: Specified init binary /sysroot/usr/lib/systemd/systemd does not exist." | 16:40 |
| Shrews | jroll: do you remember what caused that? memory issue maybe? | 16:40 |
| jroll | Shrews: memory, yeah | 16:41 |
| Shrews | jroll: thx | 16:41 |
| jroll | np | 16:41 |
| rameshg87 | BadCub: checkign | 16:41 |
| devananda | g'morning | 16:42 |
| BadCub | rameshg87: awesomeness :-) Thank you! | 16:42 |
| NobodyCam | good morning devananda | 16:42 |
| BadCub | devananda: morning | 16:42 |
| BadCub | again | 16:42 |
| rameshg87 | BadCub: which "uefi" did you mean ? | 16:42 |
| rameshg87 | BadCub: it's not related to https://blueprints.launchpad.net/ironic/+spec/uefi-secure-boot or https://blueprints.launchpad.net/ironic/+spec/automate-uefi-bios-iso-creation actually .. | 16:42 |
| rameshg87 | BadCub: we are actually making these changes because we are doing the work of making ipa as default ramdisk - which should support localboot with uefi just like dib ramdisk does | 16:43 |
| rameshg87 | BadCub: that's why i tagged with both the blueprints :) | 16:43 |
| * jroll bbiab | 16:43 | |
| rameshg87 | BadCub: does that answer your question ? | 16:44 |
| BadCub | rameshg87: okay. I was following up on the BP because there was a question posed on that | 16:44 |
| BadCub | Thank you! :-) | 16:44 |
| NobodyCam | devananda: have you seen https://review.openstack.org/#/c/163730 this morning? ("New field 'name' not supported in port REST API") | 16:44 |
| devananda | NobodyCam: yes, though i haven't reviewed it. came up in the meeting last night | 16:44 |
| NobodyCam | rameshg87: are you reworking the execute stuff on that? | 16:44 |
| rameshg87 | NobodyCam: yeah i am working on that | 16:45 |
| rameshg87 | NobodyCam: just changing to env_variables of processutils | 16:45 |
| NobodyCam | rameshg87: awesome TY | 16:45 |
| rameshg87 | devananda: i can answer any questions that i know | 16:46 |
| rameshg87 | devananda: but when i check the current patch in detail | 16:46 |
| rameshg87 | devananda: i can see it changes the behaviour a little bit | 16:47 |
| rameshg87 | devananda: https://review.openstack.org/#/c/163730/4/ironic/api/controllers/v1/node.py | 16:47 |
| BadCub | brb | 16:47 |
| rameshg87 | devananda: without this patch, we never raise 406 for GET calls | 16:47 |
| rameshg87 | devananda: but with this patch, we will start giving 406 for GET calls | 16:47 |
| *** penick has joined #openstack-ironic | 16:47 | |
| rameshg87 | devananda: by GET i mean GET /v1/nodes/<> | 16:47 |
| *** absubram has joined #openstack-ironic | 16:48 | |
| devananda | rameshg87: I've reviewed the etherpad -- https://etherpad.openstack.org/p/ironic-microversion-handling | 16:49 |
| devananda | NobodyCam: have you seen ^ ? | 16:49 |
| *** harlowja_away is now known as harlowja | 16:49 | |
| *** absubram has quit IRC | 16:50 | |
| *** absubram has joined #openstack-ironic | 16:51 | |
| rameshg87 | yuriyz: are you around ? have a minute to discuss on https://review.openstack.org/#/c/151596/40/ironic/drivers/modules/ilo/inspect.py | 16:51 |
| rameshg87 | Nisha: are you here ? | 16:51 |
| yuriyz | hello ramesh87 I'm on the meeting now | 16:52 |
| Nisha | rameshg87, yes | 16:52 |
| rameshg87 | yuriyz: okay, can you please ping me/Nisha when you are free .. | 16:52 |
| *** alexpilotti has quit IRC | 16:53 | |
| BadCub | back | 16:56 |
| NobodyCam | rameshg87: is Nisha around this morning? | 17:01 |
| rameshg87 | NobodyCam: Nisha is here i guess | 17:01 |
| *** ParsectiX has joined #openstack-ironic | 17:01 | |
| *** vdrok is now known as vdrok_afk | 17:05 | |
| rameshg87 | NobodyCam: what do you think of line 54 of https://review.openstack.org/#/c/151596/40/ironic/drivers/modules/ilo/inspect.py ? | 17:10 |
| Nisha | yes NobodyCam | 17:10 |
| rameshg87 | NobodyCam: should we raise an error there ? or just log a warning | 17:10 |
| *** coolsvap is now known as coolsvap|afk | 17:11 | |
| NobodyCam | rameshg87: looking | 17:11 |
| rameshg87 | NobodyCam: my only concern in the previous patchset was what if the mac exists for some other node (by operator mistake most probably) | 17:11 |
| rameshg87 | NobodyCam: if we just log a warning and leave it, the operator might never know that the port wasn't created (because we report inspection as success) | 17:12 |
| NobodyCam | rameshg87: humm ya I comented on that, the raise seems a bit much. But I also understand your points | 17:13 |
| NobodyCam | I would just log it an expect the operator to verify the node was created correctly before attempting to deploy to it | 17:14 |
| *** jistr has quit IRC | 17:14 | |
| NobodyCam | but I think yuriyz raised a good point | 17:14 |
| rameshg87 | NobodyCam: my concern was just the operator not knowing at all that one port wasn't registered (unless they monitor conductor logs) | 17:15 |
| jroll | well, the node will go to manageable | 17:15 |
| jroll | where they should presumably do node-show and port-list --node to verify things | 17:15 |
| openstackgerrit | Gopi Krishna S proposed openstack/ironic: Add pxe_ucs driver to manage Cisco UCS servers https://review.openstack.org/159734 | 17:16 |
| NobodyCam | jroll: that was my thought process | 17:16 |
| jroll | you should see all the verification we do for new gear :P | 17:16 |
| *** dtantsur is now known as dtantsur|afk | 17:16 | |
| rameshg87 | jroll: NobodyCam: so do you feel it's worth just logging there and not raise an error ? | 17:17 |
| NobodyCam | what if we changed line 272 to say somethign like "inspection done, created x ports for node y" | 17:17 |
| jroll | rameshg87: I haven't looked at the change, really | 17:17 |
| jroll | I mean | 17:17 |
| jroll | if you're re-discovering a node, chances are you will hit a duplicate mac, right? | 17:17 |
| jroll | because presumably you replaced a single NIC or a disk | 17:18 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Common changes for secure boot support https://review.openstack.org/153974 | 17:18 |
| NobodyCam | jroll: this only worked with embedded nics | 17:18 |
| NobodyCam | not add-ons | 17:18 |
| jroll | uhhhh | 17:18 |
| rameshg87 | Nisha: do we create all ports on re-inspection ? | 17:18 |
| NobodyCam | so to replace a nic you'd have to replacea mother board | 17:18 |
| jroll | oh | 17:18 |
| jroll | ok, so you're probably replacing a disk | 17:19 |
| rameshg87 | Nisha: or just ones which are not existing ? | 17:19 |
| jroll | in which case you *will* hit existing macs | 17:19 |
| Nisha | rameshg87, we create ports for all the macs which are requested in inspect_ports | 17:19 |
| rameshg87 | Nisha: on re-inspection ? | 17:19 |
| rameshg87 | Nisha: we try to create all ports again ? | 17:19 |
| *** saripurigopi has quit IRC | 17:19 | |
| * rameshg87 checks the code | 17:19 | |
| Nisha | yeah | 17:19 |
| jroll | yeah, we can't blow up on duplicate MACs then | 17:19 |
| jroll | right? | 17:20 |
| Nisha | how will inspection know whether it is being executed second time | 17:20 |
| jroll | idk, maybe that situation is fine | 17:20 |
| jroll | if you can't replace the MACs anyway | 17:20 |
| jroll | err, if you can't replace the NICs anyway | 17:20 |
| Nisha | Embedded NICs cant be replaced in my opinion | 17:21 |
| jroll | right. | 17:21 |
| jroll | I guess this might be fine either way | 17:21 |
| rameshg87 | yeah, then logging should be fine .. even i am fine with it (i guess i was the only one who wanted to throw an error) | 17:21 |
| rameshg87 | Nisha: i am fine with logging it .. | 17:22 |
| NobodyCam | :) rameshg87 thats why we have several reviewers required per patch :) | 17:22 |
| Nisha | should i go ahead and change? | 17:22 |
| rameshg87 | :) | 17:22 |
| Nisha | jroll will just throw up inspection patch for review...it will be great if you could also review | 17:22 |
| jroll | Nisha: I'm trying to get to all reviews | 17:23 |
| NobodyCam | What I am / was attempting to avoid is a situation where the dev is pulled between two reviewers ideas | 17:23 |
| *** saripurigopi has joined #openstack-ironic | 17:24 | |
| NobodyCam | esp when we are in crunch mode :) | 17:24 |
| Nisha | NobodyCam, :) | 17:24 |
| Nisha | jroll thanks | 17:25 |
| Nisha | jroll, meanwhile could i request review for https://review.openstack.org/155900 | 17:25 |
| jroll | Nisha: I'm trying to get to all reviews | 17:25 |
| Nisha | NobodyCam, has reviewed it...i havent received any one else review comments on to the latest patch | 17:25 |
| devananda | mmmm. just finished the release meeting with ttx. | 17:26 |
| NobodyCam | and.... | 17:26 |
| jroll | Nisha: there are many reviews, I am trying to get to all of them | 17:26 |
| jroll | and also have things to do internally | 17:26 |
| devananda | JoshNang: how's the cleaning patch going? do we indeed need to land a change in devstack? | 17:26 |
| * jroll busy day | 17:26 | |
| NobodyCam | jroll: i hear that! | 17:26 |
| Nisha | jroll :) | 17:26 |
| devananda | ... very busy week | 17:27 |
| JoshNang | devananda: we do, it's up, and waiting on a recheck | 17:27 |
| devananda | JoshNang: link? | 17:27 |
| NobodyCam | busy and i'll add productive ! | 17:27 |
| JoshNang | https://review.openstack.org/#/c/164954/ | 17:27 |
| devananda | rameshg87: on https://review.openstack.org/#/c/163739 - why is this blocking the ipa-as-default-ramdisk BP? | 17:28 |
| devananda | rameshg87: I get that it's related to IPA -- LOTS of things are related -- but that BP is about making IPA able to be used by the pxe_* class of drivers, which it now is | 17:28 |
| devananda | JoshNang: ty. adding to the review board | 17:28 |
| *** rsalevsky has left #openstack-ironic | 17:29 | |
| JoshNang | there's something funky going on with the depends-on agent cleaning patch. it can't find the config option added in in the devstack patch, but it works locally | 17:29 |
| rameshg87 | devananda: ipa-as-default-ramdisk mentions only pxe* drivers, okay | 17:29 |
| BadCub | devananda: we added at same time | 17:29 |
| rameshg87 | devananda: then it isn't related, i can remove it | 17:29 |
| BadCub | removed mine | 17:29 |
| rameshg87 | devananda: i assumed it was applicable whereever we used dib ramdisk - we are replacing that to be able to work with ipa | 17:30 |
| devananda | rameshg87: ok. cool. so then ipa-as-default-ramdisk is done? <--- jroll ? | 17:30 |
| NobodyCam | Nisha: I'm updateing our etherpad. you'll be pushing up new revs of 151596 & 163572? | 17:30 |
| rameshg87 | devananda: that included the ilo driver as well | 17:30 |
| devananda | rameshg87: ooh | 17:30 |
| BadCub | nice | 17:30 |
| rameshg87 | devananda: isn't it correct ? :) | 17:30 |
| Nisha | yes | 17:30 |
| Nisha | i will push patches in few min | 17:31 |
| NobodyCam | Nisha: Ty :) | 17:31 |
| rameshg87 | pxe and ilo drivers were using dib ramdisk. | 17:31 |
| rameshg87 | initially | 17:31 |
| openstackgerrit | Adam Gandelman proposed openstack/ironic: Migrate to using keystoneclient Sessions https://review.openstack.org/156344 | 17:31 |
| devananda | rameshg87: so that functionality exists in iscsi_ilo when used with the DIB ramdisk, but not when the same driver is used with the agent ramdisk? | 17:31 |
| NobodyCam | rameshg87: a dib patch landed this morning | 17:31 |
| NobodyCam | I've losst the link atm | 17:32 |
| rameshg87 | (may be i am confusing people) | 17:32 |
| jroll | devananda: no idea, I guess so | 17:32 |
| rameshg87 | devananda: ilo driver support for agent ramdisk has landed - https://review.openstack.org/#/c/162449/ | 17:32 |
| devananda | rameshg87: this is the one I have marked on the whiteboard as holding up ipa-as-default-ramdisk: https://review.openstack.org/#/c/163739 | 17:33 |
| rameshg87 | devananda: it isn't now in my opinion | 17:33 |
| devananda | the commit message is "Add uefi support in image extension" -- and this is a change in IPA that is tagged to two blueprints (ipa-as-default-ramdisk and local-boot-support-with-partition-images) | 17:33 |
| rameshg87 | devananda: it should only be local-boot-support-with-partition-images | 17:33 |
| devananda | so I'm really confused as to what BP it should be related to | 17:33 |
| *** achanda has joined #openstack-ironic | 17:34 | |
| devananda | since we also have two BPs for UEFI support | 17:34 |
| devananda | and neither of those are tagged on that commit | 17:34 |
| rameshg87 | devananda: the two uefi blueprints are different - one is for automate boot iso (Nisha) and uefi secure boot (stendulker) | 17:34 |
| rameshg87 | devananda: this is related solely to localboot for uefi | 17:35 |
| *** ukalifon1 has joined #openstack-ironic | 17:35 | |
| devananda | rameshg87: gotcha | 17:35 |
| rameshg87 | i will remove off the ipa-as-default-ramdisk | 17:35 |
| rameshg87 | is that fine ? | 17:35 |
| devananda | yup. thanks much | 17:35 |
| BadCub | rameshg87: yes, please | 17:36 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add uefi support in image extension https://review.openstack.org/163739 | 17:36 |
| BadCub | devananda: will mark IPA BP closed | 17:36 |
| devananda | BadCub: cheers | 17:36 |
| jlvillal | Any opinions on a patch, where functions used to have multiple arguments per line, but now has been converted so that function declaration now has one argument per line. I wasn't sure if one way or another is preferred. And yes probably a nit... | 17:36 |
| rameshg87 | BadCub: devananda: done from my part | 17:37 |
| BadCub | rameshg87: thank ya kindly! :-) | 17:37 |
| devananda | jlvillal: yes, that's a nit. sometimes it is necessary to wrap lines (eg, because all the params will be > 80 chars) | 17:38 |
| jroll | jlvillal: style is something that should be checked by computers, not humans. | 17:38 |
| jroll | (imho) | 17:38 |
| devananda | also what jroll said | 17:38 |
| devananda | if someone is merely doing a style change, I'd really wonder why that should take up any reviewer time | 17:38 |
| devananda | if it's part of a larger code cleanup patch ... yeah, probably fine | 17:39 |
| devananda | also - I dont htink any of us are going to look at that sort of thing for a few weeks | 17:39 |
| BadCub | anyone available to throw some eyes on https://review.openstack.org/#/c/158520/ ? | 17:39 |
| jlvillal | devananda: jroll: Okay. Thanks. | 17:39 |
| devananda | because release | 17:39 |
| devananda | NobodyCam: thx for the pep fix | 17:40 |
| NobodyCam | :-p | 17:40 |
| devananda | BadCub: it helps to put a small description what it is :) ^^ is the client side of logical-names | 17:40 |
| BadCub | DOH | 17:40 |
| NobodyCam | brb... quick smoke break | 17:41 |
| BadCub | brb too. smoke and more tissue in nose | 17:43 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for pxe_ilo driver https://review.openstack.org/154808 | 17:43 |
| * devananda afk's for a few minutes | 17:44 | |
| rloo | devananda: does https://review.openstack.org/#/c/158520/ need to land for k-3? I was deferring all client patches til after k-3. | 17:45 |
| NobodyCam | rloo: thats logical name support for the client. | 17:49 |
| jroll | we don't do k-3 release for the client | 17:50 |
| rloo | NobodyCam: I know. But the k-3 deadline is only for ironic, isn't it? We can update the client after k-3? | 17:50 |
| rloo | NobodyCam: I'm trying to prioritize ;) | 17:50 |
| NobodyCam | rloo: I believe you are correct ;) | 17:50 |
| *** dprince has quit IRC | 17:51 | |
| *** ParsectiX has quit IRC | 17:51 | |
| *** ParsectiX has joined #openstack-ironic | 17:52 | |
| *** ParsectiX has quit IRC | 17:53 | |
| kkoski | comstud: What exactly is the "test_create_node_doesnt_contain_id" testing for? | 17:53 |
| *** ParsectiX has joined #openstack-ironic | 17:53 | |
| jroll | kkoski: comstud usually isn't around much anymore :( can you point me to the code and maybe I can explain? | 17:54 |
| kkoski | ah, sure | 17:55 |
| kkoski | https://github.com/openstack/ironic/blob/master/ironic/tests/api/v1/test_nodes.py#L1151 | 17:55 |
| *** penick has quit IRC | 17:56 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for iscsi_ilo driver https://review.openstack.org/154814 | 17:57 |
| jroll | kkoski: looks like it's to make sure 'id' doesn't get passed to create_node (and so id is generated) | 17:58 |
| *** ukalifon1 has quit IRC | 17:58 | |
| jroll | aha | 17:59 |
| jroll | kkoski: check out the commit message https://github.com/openstack/ironic/commit/3f49758c82619b424f623f71df1ef051e50dda4c | 17:59 |
| kkoski | ah, good idea, thanks! | 17:59 |
| jroll | :) | 17:59 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add uefi support in image extension https://review.openstack.org/163739 | 18:00 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add retry logic for lsblk after running partx https://review.openstack.org/164931 | 18:01 |
| NobodyCam | anyone know Anusha Ramineni's IRC nic? | 18:02 |
| *** alexpilotti has joined #openstack-ironic | 18:02 | |
| jroll | I believe it's ramineni or similar | 18:03 |
| jroll | yes, that's it | 18:03 |
| NobodyCam | ack! thank you jroll :) | 18:03 |
| *** dprince has joined #openstack-ironic | 18:12 | |
| devananda | rloo: you are correct - we can land the client after k3 and before rc1 | 18:14 |
| devananda | *land logical names in the client | 18:14 |
| rloo | devananda: good. I'll have something to review after k-3 :D | 18:14 |
| *** achanda has quit IRC | 18:16 | |
| *** ParsectiX has quit IRC | 18:16 | |
| *** ParsectiX has joined #openstack-ironic | 18:17 | |
| *** absubram has quit IRC | 18:17 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Secure boot support for agent_ilo driver https://review.openstack.org/154816 | 18:17 |
| *** penick has joined #openstack-ironic | 18:18 | |
| *** penick has left #openstack-ironic | 18:18 | |
| BadCub | is anyone available to review: agent_iscsi + UEFI https://review.openstack.org/#/c/164386/ ? | 18:21 |
| *** achanda has joined #openstack-ironic | 18:21 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add uefi support in image extension https://review.openstack.org/163739 | 18:21 |
| rameshg87 | rloo: ^^^ might need your +2 again :) | 18:22 |
| rloo | rameshg87: looking... | 18:22 |
| *** ijw has joined #openstack-ironic | 18:23 | |
| JoshNang | devananda: looks like the devstack gate is broken :/ | 18:23 |
| *** ParsectiX has quit IRC | 18:24 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Support the equivalent of the Juno API https://review.openstack.org/164369 | 18:24 |
| devananda | JoshNang: eh?? | 18:24 |
| *** ParsectiX has joined #openstack-ironic | 18:24 | |
| JoshNang | all the patches are failing at check-devstack-dsvm-cells, looks like its being worked on | 18:24 |
| NobodyCam | rameshg87: just checking on 163739 did you attempt to test with out the shell=True? | 18:25 |
| NobodyCam | fyi: new path looks much better | 18:25 |
| rameshg87 | NobodyCam: i think without shell=True, it might require to break down different arguments as different parameters | 18:26 |
| rameshg87 | NobodyCam: now we pass in a single-string-command to utils.execute | 18:26 |
| *** saripurigopi has quit IRC | 18:26 | |
| NobodyCam | oh, I see | 18:26 |
| rloo | JoshNang: thx for letting us know. | 18:27 |
| JoshNang | (just for patches to devstack, afaict) | 18:27 |
| NobodyCam | more coffee... brb | 18:28 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Add retry logic for lsblk after running partx https://review.openstack.org/164931 | 18:30 |
| *** romcheg1 has quit IRC | 18:31 | |
| *** absubram has joined #openstack-ironic | 18:31 | |
| *** Marga_ has joined #openstack-ironic | 18:31 | |
| yuriyz | rameshg87 now I see you agree with logging here https://review.openstack.org/#/c/151596/40/ironic/drivers/modules/ilo/inspect.py | 18:33 |
| rameshg87 | yuriyz: yeah i agreed, but still was afraid (earlier) if the mac was registered for some other node | 18:34 |
| rameshg87 | yuriyz: since we report inspection as successful, it might cause a problem (operator might not notice a missing port) | 18:34 |
| rameshg87 | yuriyz: but we discussed and decided that operator should perhaps verify after putting into manage state | 18:35 |
| devananda | JoshNang: any refs to the work being done on that cells failure? | 18:36 |
| devananda | JoshNang: I just raised it in #openstack-qa -- also, to get reviews on that devstack patch proiritized | 18:36 |
| * NobodyCam needs to remember IPA does not to i18n :-p | 18:36 | |
| stendulker | NobodyCam, Jroll, yuriy, jroll, devananda : Please review secure boot related 4 patches for ilo driver https://review.openstack.org/#/c/153974/ https://review.openstack.org/#/c/154808/ https://review.openstack.org/#/c/154814/ https://review.openstack.org/#/c/154816/ | 18:36 |
| *** kbs has quit IRC | 18:37 | |
| jroll | again: it's on the list | 18:37 |
| devananda | stendulker: these are already on the review day whiteboard ... | 18:37 |
| jroll | pinging people in irc isn't going to make things go faster | 18:37 |
| *** lazy_prince is now known as killer_prince | 18:37 | |
| JoshNang | devananda: i might be wrong. i was looking at what elastic recheck said the bug was, but that seems incorrect https://bugs.launchpad.net/openstack-ci/+bug/1265057 | 18:38 |
| openstack | Launchpad bug 1265057 in grenade "gate/check-grenade-dsvm: Horizon front page not functioning!" [Undecided,Confirmed] | 18:38 |
| stendulker | devananda, jroll: thank you. just little reminder from my side :) | 18:38 |
| jroll | JoshNang: no, that's the one | 18:39 |
| devananda | JoshNang: looks like the cells failure is from horizon, and a fix has been pushed | 18:39 |
| * JoshNang rechecks again | 18:40 | |
| devananda | JoshNang: that is correct. we can just recheck now | 18:40 |
| devananda | ya'll should get to know folks in #openstack-qa a bit :) | 18:40 |
| *** kbs has joined #openstack-ironic | 18:40 | |
| devananda | also, i should get lunch | 18:40 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: ilo_iscsi driver do not validate boot_option https://review.openstack.org/164414 | 18:41 |
| * jroll also lunches | 18:43 | |
| BadCub | got two +2s from non IPA folk on: Add UEFI Support in Image extension https://review.openstack.org/#/c/163739/ :😃 | 18:44 |
| NobodyCam | rameshg87: any reason to add a udevsettle around line 73 of https://review.openstack.org/#/c/164931/4/ironic_python_agent/extensions/image.py ? | 18:45 |
| rameshg87 | NobodyCam: udevsettle ? | 18:46 |
| * rameshg87 checks | 18:46 | |
| NobodyCam | :) | 18:46 |
| rameshg87 | NobodyCam: can't find udevsettle | 18:47 |
| NobodyCam | just saw all the looping logic | 18:47 |
| rameshg87 | NobodyCam: oh okay | 18:47 |
| NobodyCam | http://linux.die.net/man/8/udevsettle | 18:47 |
| rameshg87 | NobodyCam: oh hp hardware i tested, partx is not finishing re-reading the partition table | 18:47 |
| rameshg87 | NobodyCam: so we have empty uuids returned in the first attempt | 18:48 |
| rameshg87 | NobodyCam: i have posted paste link | 18:48 |
| rameshg87 | NobodyCam: shows this behaviour - http://paste.openstack.org/show/192820/ | 18:48 |
| NobodyCam | rameshg87: udevsettle may help with that too! | 18:49 |
| * rameshg87 checks | 18:50 | |
| rameshg87 | NobodyCam: looks like might help | 18:51 |
| rameshg87 | NobodyCam: i can try that out | 18:51 |
| jroll | BadCub: +A on 163739 | 18:51 |
| NobodyCam | :) | 18:51 |
| rameshg87 | NobodyCam: anyway it's a bug filed separately | 18:51 |
| BadCub | jroll awesomeness! Thanks ya kindly! | 18:51 |
| rameshg87 | NobodyCam: i will check tomorrw about that then, may be you can leave a comment :) | 18:51 |
| NobodyCam | will do | 18:51 |
| rameshg87 | NobodyCam: thanks | 18:52 |
| *** lsmola has quit IRC | 18:52 | |
| *** jcoufal has quit IRC | 18:53 | |
| * rameshg87 goes to sleep | 18:54 | |
| rameshg87 | good night all | 18:54 |
| NobodyCam | night rameshg87 | 18:54 |
| BadCub | g'night rameshg87 | 18:54 |
| *** rameshg87 has quit IRC | 18:54 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Ilo drivers sets capabilities:boot_mode in node https://review.openstack.org/155731 | 19:03 |
| * NobodyCam feels like this is a known error that he should know about, but doesn't | 19:04 | |
| NobodyCam | Failed to prepare node bbcb5a8a-5363-4649-86eb-99a3cbcd3f93 for cleaning: Invalid input for network_id. Reason: 'None' is not a valid UUID. | 19:04 |
| JoshNang | NobodyCam: that's what the devstack patch is fixing | 19:05 |
| NobodyCam | ahh :) Ty JoshNang | 19:05 |
| JoshNang | np! | 19:06 |
| Shrews | jroll: so... how much RAM does coreos need for an agent_ssh deploy? | 19:07 |
| Shrews | on the vm | 19:07 |
| *** kkoski has quit IRC | 19:07 | |
| *** kkoski has joined #openstack-ironic | 19:07 | |
| *** Marga_ has quit IRC | 19:08 | |
| NobodyCam | Shrews: I thought 1 Gb ... unless it was the dib built image which required 3 gb if I recall correctly | 19:10 |
| Shrews | TheJulia: ^^^^ | 19:10 |
| Shrews | NobodyCam: yup, dib image | 19:10 |
| Shrews | ugh | 19:11 |
| NobodyCam | yep :) | 19:11 |
| TheJulia | so 3 gb it is :) | 19:11 |
| NobodyCam | mornign TheJulia :) | 19:11 |
| * Shrews gets stabby on DiB | 19:11 | |
| *** romcheg has joined #openstack-ironic | 19:11 | |
| NobodyCam | lol | 19:11 |
| *** kkoski has quit IRC | 19:11 | |
| *** killer_prince has quit IRC | 19:11 | |
| BadCub | TheJulia: and Shrews : Hiya! | 19:12 |
| Shrews | hey BadCub | 19:12 |
| TheJulia | NobodyCam: Good afternoon :) | 19:12 |
| TheJulia | Shrews: Do you want to re-spin and retry with 3GB? | 19:13 |
| *** stendulker has quit IRC | 19:13 | |
| *** Nisha has quit IRC | 19:13 | |
| Shrews | TheJulia: yup | 19:13 |
| *** Nisha has joined #openstack-ironic | 19:13 | |
| NobodyCam | there is pre built image out there | 19:13 |
| *** killer_prince has joined #openstack-ironic | 19:13 | |
| *** killer_prince is now known as lazy_prince | 19:14 | |
| NobodyCam | somewhere around http://tarballs.openstack.org/ironic-python-agent/ | 19:14 |
| NobodyCam | :-p | 19:14 |
| *** kkoski has joined #openstack-ironic | 19:15 | |
| TheJulia | NobodyCam: we've got all the steps for our playbooks to build images with diskimage-builder, kind of nice actually :) | 19:15 |
| NobodyCam | TheJulia: w00t!!! | 19:15 |
| BadCub | brb | 19:16 |
| *** pas-ha has quit IRC | 19:16 | |
| *** kkoski has quit IRC | 19:16 | |
| *** kkoski has joined #openstack-ironic | 19:19 | |
| * Shrews needs this to work so he can catch up on reviewing stuff | 19:19 | |
| *** ukalifon1 has joined #openstack-ironic | 19:20 | |
| *** kkoski has quit IRC | 19:21 | |
| *** jcoufal has joined #openstack-ironic | 19:26 | |
| * BadCub is back | 19:27 | |
| *** ukalifon1 has quit IRC | 19:28 | |
| *** achanda has quit IRC | 19:33 | |
| *** ParsectiX has quit IRC | 19:33 | |
| *** ParsectiX has joined #openstack-ironic | 19:34 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 19:43 |
| *** andreykurilin_ has joined #openstack-ironic | 19:45 | |
| *** ParsectiX has quit IRC | 19:46 | |
| NobodyCam | oh JoshNang that recheck syntax works :) | 19:46 |
| *** ParsectiX has joined #openstack-ironic | 19:46 | |
| JoshNang | hmm? | 19:46 |
| NobodyCam | thats kewl | 19:47 |
| JoshNang | oh heh :D | 19:47 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 19:51 |
| rloo | devananda: what's the priority of https://review.openstack.org/#/c/164369/. Can that be landed after k-3? or is it a high for k-3? | 19:52 |
| * devananda returns from lunch, prepares for TC meeting | 19:53 | |
| Nisha | rloo, ^^^ | 19:53 |
| Nisha | adressed the comments and posted the patch | 19:53 |
| devananda | rloo: yes, I think we can reasonably call that a bug and land it eg. next week | 19:53 |
| devananda | rloo: along with https://review.openstack.org/#/c/163730/ | 19:53 |
| * devananda moves to bottom of etherpad | 19:54 | |
| rloo | devananda: good. thx | 19:54 |
| BadCub | rloo: thanks for the +2 on 164386 :-) | 19:54 |
| rloo | Nisha: I'm waiting for jenkins, and I feel like I should give some attention to some other patches. | 19:54 |
| Nisha | rloo, np | 19:55 |
| rloo | Nisha: if I recall, I think your stuff is close ;) | 19:55 |
| Nisha | rloo :) | 19:55 |
| Nisha | rloo, just hope so ;) | 19:56 |
| *** overlayer has joined #openstack-ironic | 19:56 | |
| BadCub | devananda: is the block on https://review.openstack.org/#/c/163738/ going to impact us closing https://blueprints.launchpad.net/ironic/+spec/local-boot-support-with-partition-images ? It doesn't appear to be the case to me, but wanted to be sure. | 19:58 |
| devananda | BadCub: no. that is specific to the irmc driver | 19:59 |
| BadCub | awesome, that is what I thought | 19:59 |
| devananda | BadCub: the dependent patch (https://review.openstack.org/#/c/151958/13) is blocked. let me edit the commit message on the one you linke d.... | 19:59 |
| *** overlayer has quit IRC | 19:59 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add localboot support for iscsi_irmc driver https://review.openstack.org/163738 | 19:59 |
| *** igordcard_ has joined #openstack-ironic | 20:00 | |
| *** absubram has quit IRC | 20:05 | |
| *** kkoski has joined #openstack-ironic | 20:06 | |
| *** jcoufal has quit IRC | 20:07 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO implementation for hardware inspection https://review.openstack.org/151596 | 20:08 |
| BadCub | when some IPA folks have time can I get a +A on agent_iscsi + UEFI https://review.openstack.org/#/c/164386/ ? | 20:09 |
| *** kkoski has quit IRC | 20:10 | |
| *** kkoski has joined #openstack-ironic | 20:13 | |
| JayF | ah, it's not IPA | 20:14 |
| JayF | I don't have the hammer on that one, sorry | 20:14 |
| JayF | I will review it real quick though | 20:14 |
| *** ParsectiX has quit IRC | 20:15 | |
| BadCub | JayF: thank ya kindly. :-) | 20:15 |
| *** kkoski has quit IRC | 20:15 | |
| NobodyCam | ahh prob because it had agent in the title | 20:16 |
| NobodyCam | :-p | 20:16 |
| * BadCub will happily accept any +a to close that BP :-) LOL | 20:17 | |
| *** mrda-away is now known as mrda | 20:18 | |
| mrda | Morning | 20:18 |
| JayF | I put a +1 on ^ that (164386) if that means someone feels more comfy +A'ing it | 20:19 |
| JayF | heh | 20:19 |
| BadCub | hehehe | 20:19 |
| *** achanda has joined #openstack-ironic | 20:19 | |
| *** kkoski has joined #openstack-ironic | 20:23 | |
| *** r-daneel has quit IRC | 20:25 | |
| *** kkoski has quit IRC | 20:26 | |
| *** kkoski has joined #openstack-ironic | 20:31 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Implement cleaning/zapping for the agent driver https://review.openstack.org/161453 | 20:32 |
| *** kkoski has quit IRC | 20:33 | |
| *** kkoski has joined #openstack-ironic | 20:35 | |
| NobodyCam | brb | 20:36 |
| *** kkoski has quit IRC | 20:39 | |
| *** kkoski has joined #openstack-ironic | 20:40 | |
| *** PaulCzar has left #openstack-ironic | 20:40 | |
| *** dprince has quit IRC | 20:41 | |
| TheJulia | So I'm running into an issue where IPA is being told to deploy a node with a config drive, but it is seemingly only working every other deployment I push out to the same host/vm. Has anyone seen this before? | 20:42 |
| JayF | what's the failure mode? Got some logs? | 20:42 |
| JayF | plus is this ipa-iscsi or ipa-local-imaging | 20:42 |
| JayF | I have no idea how we're going to talk about these things | 20:42 |
| JayF | lol | 20:42 |
| JayF | ipa_iscsi vs ipa_agent? idk | 20:42 |
| *** achanda has quit IRC | 20:44 | |
| TheJulia | JayF: no failure, just configdrive is missing upon reboot | 20:44 |
| *** kkoski has quit IRC | 20:45 | |
| *** achanda has joined #openstack-ironic | 20:45 | |
| JayF | does the conductor/agent have in the logs that it attempted to write a configdrive? | 20:45 |
| JayF | the code that actually writes it in the agent is dirt simple, actually a bash script | 20:45 |
| *** kkoski has joined #openstack-ironic | 20:45 | |
| TheJulia | I don't see anything in the conductor log, but possibly I need to monkey with something to get additional logging from the agent? | 20:46 |
| TheJulia | JayF: fyi, disk image deploys via the agent | 20:46 |
| JayF | TheJulia: you have any access to the image? like can you ssh into the image? | 20:47 |
| TheJulia | JayF: Access to the deployed machine, without the configdrive being deployed, right now I have no access. I likely need to just rebuild my image to include stackuser, but the fact I'm seeing the kernel boot output to console lacking the configdrive volume is what I'm going on right now. | 20:49 |
| JayF | Oh, you're using a DIB image? | 20:50 |
| JayF | not the CoreOS image? | 20:50 |
| JayF | that greatly limits the amount of things I know about it then :) | 20:50 |
| TheJulia | Which almost makes me think I need to short circuit the agent deploy process and injet an ssh key into coreos so I can take a look. | 20:50 |
| JayF | Yes, that's exactly what we do downstream | 20:50 |
| JayF | it's dirt simple, let me help | 20:50 |
| * TheJulia goes and makes coffee first | 20:51 | |
| JayF | TheJulia: https://coreos.com/docs/cluster-management/setup/cloudinit-cloud-config/ search for "ssh_authorized_keys" | 20:51 |
| TheJulia | JayF: seems like it would just be easier to update the ipxe boot config to include my ssh key :) | 20:53 |
| * NobodyCam waits for test results on 164369 :-p | 20:53 | |
| JayF | TheJulia: howso? specifying your own cloud-config-url= ? | 20:54 |
| JayF | TheJulia: also if you have console access, passing "coreos.autologin" on the kernel command line logs in the console | 20:54 |
| JayF | then just use the systemd journal to read the logs | 20:54 |
| TheJulia | JayF: there is a feature of coreos that is like a tiny footnote how you can inject a key to allow one to login to coreos it's self. The real key would be to just prevent ironic from rebooting the node once the image has been written out to disk | 20:57 |
| JayF | TheJulia: I'd ssh in as soon as the agent boots to start deploying, tail the logs so when it reboots you still have the logs | 20:57 |
| JayF | TheJulia: can you share that little bit of documentation? Would be super helpful for another project I have this week, actually :) | 20:57 |
| TheJulia | JayF: will do as soon as I find it | 20:58 |
| JayF | ty | 20:58 |
| JayF | you can pass in | 20:58 |
| JayF | cloud-config-url= on the kernel commandline | 20:58 |
| JayF | and just embed the ssh key in another cloud-config.yml | 20:58 |
| TheJulia | JayF: np, https://coreos.com/docs/running-coreos/bare-metal/booting-with-ipxe/ sshkey="ssh-rsa AAAA....." | 20:59 |
| JayF | nice | 20:59 |
| JayF | I was looking for a way to get extra keys into the image we run downstream for giving folks temp access to our lab | 20:59 |
| JayF | that will work perfectly | 21:00 |
| JayF | thanks | 21:00 |
| TheJulia | JayF: I already have systemd.journald.forward_to_console=yes set on the command line, but I don't get anything beyond the callback on the console :( | 21:00 |
| *** alexpilotti has quit IRC | 21:00 | |
| JayF | TheJulia: run IPA with --debug as well | 21:00 |
| JayF | TheJulia: get some debug output, that'll help with testing more | 21:01 |
| *** alexpilotti has joined #openstack-ironic | 21:02 | |
| *** harlowja has quit IRC | 21:03 | |
| *** alexpilotti has quit IRC | 21:03 | |
| *** harlowja_ has joined #openstack-ironic | 21:03 | |
| *** alexpilotti has joined #openstack-ironic | 21:06 | |
| *** alexpilotti has quit IRC | 21:06 | |
| TheJulia | JayF: Anyway to pass that in short of putting that in the coreos image that boots up? | 21:08 |
| JayF | not afaik :( | 21:08 |
| JayF | JoshNang: ^ we don't have a Kernel CLI way of turning debug on, right? | 21:09 |
| JayF | TheJulia: JoshNang: ^ we should add one of those. Very much so. | 21:09 |
| jroll | I don't believe we do, and yes, we should. | 21:09 |
| JoshNang | agreed | 21:10 |
| JoshNang | fighting with cleaning in devstack has brought up a couple things i wanna fix | 21:10 |
| *** dhp has quit IRC | 21:12 | |
| * TheJulia at least short circuits things for a few tests :) | 21:13 | |
| JayF | TheJulia: I strongly reccomend, long-term, building your own agents | 21:15 |
| JayF | for a number of reasons | 21:15 |
| * TheJulia makes note to put that in doc | 21:15 | |
| *** kkoski has quit IRC | 21:17 | |
| JayF | Putting in ssh keys, putting in some utilities, etc can be helpful | 21:18 |
| TheJulia | yeah | 21:18 |
| JayF | I'm going to upstream some number of these things we do downstream to make things easier | 21:18 |
| *** kkoski has joined #openstack-ironic | 21:18 | |
| JayF | just some aliases, like `ipashell` which gives you a bash shell in the agent container, `ipalogs` to print all IPA logs | 21:18 |
| devananda | JayF: jroll: so I know you've been dying to see the standalone thing we keep talking about ... https://github.com/juliakreger/bifrost | 21:21 |
| * TheJulia smiles | 21:22 | |
| *** kkoski has quit IRC | 21:22 | |
| * BadCub needs to go away for a while | 21:23 | |
| *** BadCub is now known as BadCub_Away | 21:23 | |
| jroll | devananda: yes, finally, ty :) | 21:23 |
| *** arif-ali has quit IRC | 21:28 | |
| *** Marga_ has joined #openstack-ironic | 21:31 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: iLO driver updates node capabilities during inspection https://review.openstack.org/163572 | 21:31 |
| *** hyakuhei has joined #openstack-ironic | 21:33 | |
| Nisha | devananda, NobodyCam rloo jroll JayF ^^^^^ | 21:33 |
| *** arif-ali has joined #openstack-ironic | 21:34 | |
| Nisha | and even https://review.openstack.org/151596 | 21:35 |
| * NobodyCam love when distros add a securty setting and enable it before anyone has a chance to add support for it | 21:35 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Add uefi support in image extension https://review.openstack.org/163739 | 21:35 |
| devananda | NobodyCam: you approved https://review.openstack.org/#/c/164386/ ... but i dont see it in th gate ?? | 21:38 |
| BadCub_Away | devananda: I noticed that too | 21:39 |
| NobodyCam | humm | 21:40 |
| devananda | there we go | 21:40 |
| * devananda kicked the gate | 21:40 | |
| devananda | BadCub_Away: I believe that's the last one for https://blueprints.launchpad.net/ironic/+spec/local-boot-support-with-partition-images | 21:40 |
| BadCub_Away | devananda: yep! I am just waiting to see 164386 merge before I close the BP | 21:41 |
| NobodyCam | dies Depends on tag require the dependent patch to full merge before starting ? | 21:41 |
| devananda | ooooh | 21:41 |
| NobodyCam | does* not dies | 21:41 |
| devananda | that might be a bug in the Depends-on ? | 21:41 |
| NobodyCam | :-p | 21:41 |
| NobodyCam | ahh | 21:41 |
| NobodyCam | I'll keep an eye out for that | 21:41 |
| jroll | it does require the dependent to merge, and it's worked for me in the past | 21:41 |
| devananda | NobodyCam: so it looks like when you +A'd it, jenkins did not start the merge (you can see the lack of comment) | 21:42 |
| devananda | NobodyCam: and it looks like when jenkins finished merging the dependent patch, it did not come back and start merging the former | 21:42 |
| NobodyCam | yea, must just not like me :( | 21:42 |
| devananda | *shrug* it's going now ... | 21:42 |
| NobodyCam | sweet :) | 21:42 |
| NobodyCam | brb | 21:43 |
| * devananda afks a bit now that meetings are winding down | 21:44 | |
| *** ChuckC has quit IRC | 21:57 | |
| TheJulia | JayF: So I got in, toggled debug on and just tell the database that it needs to re-deploy. Looks like the partition table veruses the kernel are just out of sync | 22:03 |
| JayF | jroll: ^ sound familiar | 22:03 |
| JayF | :-( | 22:03 |
| *** ijw has quit IRC | 22:03 | |
| JayF | TheJulia: let me suggest a patch to revert, 1s | 22:04 |
| jroll | JayF: oh god | 22:04 |
| JayF | TheJulia: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=877f66826cd1b50163c67e73c8ebb4590c0f7ec8 Can you try building an agent with this patch reverted? | 22:04 |
| JayF | TheJulia: and see if it fixes your issue? | 22:04 |
| *** ijw has joined #openstack-ironic | 22:05 | |
| JayF | jroll: if reverting that fixes Julia's problem, I suggest we do /sbin/partprobe $DEVICE || true | 22:05 |
| JayF | which is not perfect, but better than something explicitly not working | 22:06 |
| jroll | yeah, do both? | 22:06 |
| jroll | oh | 22:06 |
| *** ijw has quit IRC | 22:06 | |
| *** ijw has joined #openstack-ironic | 22:07 | |
| *** harlowja_ has quit IRC | 22:09 | |
| *** harlowja has joined #openstack-ironic | 22:11 | |
| *** Nisha has quit IRC | 22:12 | |
| mrda | devananda, JoshNang: Just FYI, I've spoken to people about those nova reviews (164313 and 161474), and they're not going to land in K. It's just too late. These changes are considered new features, and as such, the code reviews needed to be up earlier. Only bug fixes are being accepted now, because tomorrow is Nova's deep freeze deadline. | 22:15 |
| mrda | Sorry to be the bearer of bad news... | 22:16 |
| devananda | mrda: thanks. that's what I had expected, honestly | 22:16 |
| NobodyCam | :( | 22:16 |
| mrda | I tried | 22:16 |
| devananda | so we need to decide now what that means for cleaning | 22:16 |
| JoshNang | same unfortunately | 22:16 |
| *** BadCub_Away is now known as BadCub | 22:16 | |
| BadCub | ack | 22:16 |
| mrda | Does this mean we bump those two bp's? | 22:17 |
| jroll | two? | 22:17 |
| TheJulia | JayF: Didn't directly try the revert, but manually tried running partprobe and came to realize the configdrive had been mounted by coreos. I think the issue is that if the config drive already existed when coreos boots up, it mounts the drive, and locks the device <-> partition table data as a result. When it comes time to write out the config drive, it sees the pre-existing device and writes it out. | 22:17 |
| jroll | hahahaha | 22:17 |
| JoshNang | i've got a patch ready to disable cleaning by default | 22:17 |
| JayF | TheJulia: I thought we had something to prevent that? | 22:17 |
| jroll | JayF: it was the other other thing | 22:17 |
| *** Marga_ has quit IRC | 22:17 | |
| JayF | TheJulia: let me look, if that's not upstream then that's 100% my fault | 22:17 |
| jroll | lulz | 22:17 |
| devananda | AIUI, this means a node that enters CLEANING state and stays there for a while (because you know, it's doing something) is going to appear to have failed from Nova's POV | 22:17 |
| jroll | sorry TheJulia but that bug has also been hilarious to me | 22:18 |
| *** Marga_ has joined #openstack-ironic | 22:18 | |
| *** Marga_ has quit IRC | 22:18 | |
| TheJulia | jroll: no worries :) | 22:18 |
| *** hyakuhei has quit IRC | 22:18 | |
| JayF | I know this is the wrong attitude to have, but I want nova to just be broken | 22:18 |
| JayF | the development process is, why shouldn't the software match? | 22:18 |
| devananda | JayF: there are many areas where it's broken today | 22:18 |
| JayF | TheJulia: https://github.com/openstack/ironic-python-agent/blob/master/imagebuild/coreos/oem/cloud-config.yml#L5 should be preventing that | 22:18 |
| JayF | TheJulia: I thought I had that upstreamed, heh | 22:19 |
| mrda | jroll: doesn't this affect "Implement Cleaning Operations for iLO drivers" and "Implement Cleaning States"? | 22:19 |
| devananda | JayF: does that mean we should ship a broken product? | 22:19 |
| *** Marga_ has joined #openstack-ironic | 22:19 | |
| devananda | mrda: afaict, yes. this affects both of those | 22:19 |
| JayF | It means that we have a dependency that's not holding up their end of the bargain | 22:19 |
| devananda | JayF: to be specific, nova never agreed to it | 22:19 |
| JayF | We shouldn't have to involve all of openstack on a feature that touches nothing but Ironic + Ironic's nova driver | 22:20 |
| BadCub | what are the impacts if we ship and break Nova? Is this something that we "Ironic" can consider a tolerate candidate? | 22:20 |
| JayF | I don't actually think we should ship a broken thing | 22:20 |
| JayF | but I do think this is absolutely absurd | 22:20 |
| jroll | mrda: oh, right, I always forget that's two different blueprints | 22:20 |
| mrda | JayF: https://wiki.openstack.org/wiki/Kilo_Release_Schedule has been published for some time. Jan 22 was the published date for code reviews needing to be up. We missed that be 6 weeks. | 22:20 |
| mrda | s/be/by/ | 22:20 |
| devananda | BadCub: the impact is that someone who installs the kilo release of openstack and uses nova + ironic will see all their deletes fail | 22:20 |
| * mrda not arguing whether the timeframe is sane, just that Nova has a very fixed published deadline | 22:21 | |
| JayF | mrda: I think that deadline is absolutely absurd, to be clear | 22:21 |
| JayF | and the lack of flexibility only amplifies the absurdity | 22:21 |
| mrda | JayF: not going to argue that | 22:21 |
| jroll | devananda: didn't we already decide bump cleaning to false. maybe make a note in the help string that you need patches in nova to make it work. | 22:21 |
| JayF | I have to produce code and make a production environment work all the time | 22:21 |
| jroll | (or docs) | 22:21 |
| *** jgrimm is now known as zz_jgrimm | 22:21 | |
| JoshNang | fwiw, that spec merged jan 16 | 22:21 |
| JayF | not all the time minus 2 months out of every 6 | 22:21 |
| mrda | On the flipside, we should be able to get this to land early in "L" | 22:21 |
| jroll | great only months away | 22:21 |
| JayF | mrda: for a feature we've had downstreamed since I | 22:22 |
| BadCub | *puts on his CRB hat* devananda if that is the case, is there a documentation work-around, or a push to Nova to fix as a bug right after release? | 22:22 |
| mrda | JayF: remember I'm the messenger here, I'm not Nova :) | 22:22 |
| jroll | s/downstreamed/in production/ | 22:22 |
| JayF | mrda: I'm afraid to actually rant at Nova, then they might never merge anything again | 22:22 |
| mrda | lol | 22:22 |
| JayF | I'm not even kidding | 22:22 |
| JayF | it takes 10x as much effort to get a patch 10% of the impact merged into Nova | 22:22 |
| JayF | vs Ironic | 22:23 |
| devananda | JayF: i rant at them ALL THE TIME | 22:23 |
| devananda | right now I'm actually being quite calm | 22:23 |
| JayF | Maybe that's why they won't merge our stuff /s | 22:23 |
| devananda | which should scare all of you | 22:23 |
| jroll | if you're following the rules, this patch not merging is totally reasonable | 22:23 |
| mrda | and they have a lot more code, lots more legacy, and more users to worry about. That's why I like Ironic :) | 22:23 |
| jroll | the rules on the other hand | 22:23 |
| JayF | I'm just beyond pissed off that we're trying to solve, literally, the oldest Ironic bug, and it's not getting merged because some damn wiki page says not to | 22:23 |
| *** Mr_T has joined #openstack-ironic | 22:23 | |
| jroll | mrda: it's completely localized | 22:23 |
| mrda | I get that | 22:24 |
| jroll | JayF: it's a nova-baremetal bug originally :P :P :P | 22:24 |
| devananda | i will either be ranting by the summit, or continuing my plotting to get more projects *decoupled* from each other and releasing as-needed, rather than every 6mo | 22:24 |
| JayF | mrda: yes, it's local to our driver, if it wasn't I would be not/less upset | 22:24 |
| mrda | But they're under a crunch this week, just like us | 22:24 |
| jroll | mrda: it literally canoot break their users, only our users. just sayin. | 22:24 |
| JayF | devananda: is it too late for me to change my summit talk from "operators should participate" to "Nova is hostile to contributors" | 22:24 |
| *** harlowja has quit IRC | 22:24 | |
| *** harlowja_ has joined #openstack-ironic | 22:24 | |
| mrda | JayF: DO IT! | 22:24 |
| mrda | lol | 22:24 |
| devananda | JayF: you can say what ever you want when you get on the stage :) | 22:24 |
| NobodyCam | devananda: https://review.openstack.org/#/c/164369 looks good! nice patch Thank you:) | 22:25 |
| mrda | I'm sorry guys, I tried, it's just too late | 22:25 |
| devananda | mrda: no worries. thanks for trying | 22:25 |
| jroll | mrda: know that this isn't directed at you at all :) | 22:25 |
| JayF | I'm 100% serious. Our code is merged. I wanna file a critical bug against nova showing deletes are broken in Ironic | 22:25 |
| * devananda tries one thing... | 22:25 | |
| JayF | and make them take the patch | 22:26 |
| JayF | or leave it broken as *their* choice | 22:26 |
| devananda | JayF: well, our code is still pending JoshNang's patches | 22:26 |
| jroll | the patch to enable it is merged, but that doesn't break things yet | 22:26 |
| JayF | You mean we weren't merging Ironic support until Nova support went in? | 22:26 |
| devananda | JayF: so if someone looks at the git history 9and they will) they'll see we landed the feature at the last minute, well over a month after nova's feature freeze | 22:26 |
| devananda | JayF: no | 22:26 |
| mrda | JayF: Report the bug, and say that it is solved by these two patches (+ ironic code that we're ready to land) | 22:26 |
| JoshNang | mrda: yeah, thanks for trying :) | 22:27 |
| devananda | JayF: i mean someone on the nova team looking at the commit history of the bug you're going to raise is going to point out that it didn't exist until now | 22:27 |
| jroll | I mean, I don't think going the critical bug angle will actually work | 22:27 |
| JayF | I don't think it will actually work either | 22:27 |
| devananda | JayF: so as much as I want them to take the changes to our driver, they're going to find (valid) reasons not to (like following their team's policy) | 22:27 |
| JayF | but I want to have someone actually stand up and tell us that they're crapping on months of work b/c they don't want <100 lines of change in the *Ironic driver* | 22:27 |
| devananda | JayF: yup. | 22:27 |
| devananda | that's valid | 22:27 |
| mrda | Thay are taking important bug fixes (for some value of important) | 22:28 |
| JayF | I think the oldest Ironic/Nova-BM bug should count as important enough | 22:28 |
| JayF | lol | 22:28 |
| NobodyCam | could this not be a customer driver billing issue? | 22:28 |
| devananda | huh. the changes aren't targeted to that bug? | 22:28 |
| JayF | I'm going to go do real work instead of ranting on IRC, this is absurd though and fear of shit like this happening is *exactly* why we didn't integrate with Openstack/Ironic when starting OnMetal originally. | 22:28 |
| NobodyCam | ie I don't want to pay for hours of cleaning after I delete a instance | 22:28 |
| devananda | JoshNang: ? | 22:28 |
| JayF | JoshNang: ^ are all your cleaning patches for nova targeted at the nova-bm bug? | 22:29 |
| JoshNang | devananda: yeah, i had forgotten that was a real bug in launchpad and added that it was part of oone of our specs | 22:29 |
| *** romcheg has quit IRC | 22:29 | |
| JoshNang | no, the first bug is one that was introduced with more states and really has little to do with cleaning | 22:30 |
| *** romcheg has joined #openstack-ironic | 22:30 | |
| devananda | JoshNang: so seriously that needs to target that bug | 22:30 |
| * JoshNang does | 22:30 | |
| devananda | https://bugs.launchpad.net/ironic/+bug/1174153 | 22:30 |
| openstack | Launchpad bug 1174153 in Ironic "data from previous tenants accessible with nova baremetal" [High,Triaged] | 22:30 |
| *** romcheg has quit IRC | 22:30 | |
| openstackgerrit | Merged openstack/ironic: Add uefi support for agent iscsi deploy https://review.openstack.org/164386 | 22:31 |
| JoshNang | added | 22:32 |
| devananda | BadCub: ^ merged :) | 22:32 |
| BadCub | already changed BP LOL | 22:32 |
| *** ijw has quit IRC | 22:32 | |
| devananda | JoshNang: there are two patches to nova, right? | 22:35 |
| JoshNang | devananda: correct, https://review.openstack.org/#/c/164313/ doesn't really affect cleaning though | 22:35 |
| JoshNang | it was suggested the cleaning patch should be based on it though | 22:35 |
| JoshNang | and it is kinda a big bug | 22:36 |
| *** sambetts has quit IRC | 22:36 | |
| devananda | see discussion in -nova | 22:36 |
| *** sambetts has joined #openstack-ironic | 22:38 | |
| *** andreykurilin_ has quit IRC | 22:38 | |
| *** ijw has joined #openstack-ironic | 22:39 | |
| *** ijw has quit IRC | 22:40 | |
| *** ijw has joined #openstack-ironic | 22:42 | |
| devananda | JoshNang: so we should close https://bugs.launchpad.net/ironic/+bug/1174153 in ironic as soon as the agent cleaning support passes tests and merges | 22:43 |
| openstack | Launchpad bug 1174153 in OpenStack Compute (nova) "data from previous tenants accessible with nova baremetal" [High,In progress] - Assigned to Josh Gachnang (joshnang) | 22:43 |
| devananda | JoshNang: so you should also tag this bug on that patch | 22:44 |
| JoshNang | devananda: nice work :) | 22:44 |
| devananda | JoshNang: thanks ;) | 22:44 |
| JoshNang | alright. i'm waiting on the gate right now | 22:44 |
| jroll | JoshNang: did you figure out the devstack thing? | 22:44 |
| JoshNang | jroll: yeah, i was adding the config option after ironic had started. moved it back, should work | 22:45 |
| jroll | nice | 22:45 |
| JayF | JoshNang: Have you done any thinking at all about what docs need to be written for cleaning? Maybe we can chat a little bit when you get a chance to scope out the work? | 22:45 |
| devananda | also, if you have a patch ready to disable cleaning by default, please post it | 22:45 |
| devananda | i'll -2 ... but I'd like to have the trigger ready if this turns into a gate blocker during RC window | 22:46 |
| devananda | (if you dont have that patch ready, please post it anyway) | 22:46 |
| JoshNang | kk | 22:46 |
| devananda | JayF: omgdocsyesplease | 22:46 |
| JayF | JoshNang: are any agent cleaning steps enabled by default today? | 22:47 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Disable cleaning by default https://review.openstack.org/165241 | 22:47 |
| JoshNang | JayF: oh yes, i've been thinking about docs a bunch | 22:47 |
| JayF | devananda: I'm your friendly, local docs writer for purposes of cleaning | 22:47 |
| JayF | devananda: I traded that work to JoshNang so he'd be able to work on migrating off our old downstream patch | 22:47 |
| JoshNang | JayF: erase disks is by default (or how would we close the bug!) | 22:47 |
| * JayF won, I think | 22:47 | |
| JayF | JoshNang: then that will likely fail in the gate ... unless VM disks are secure erasable | 22:47 |
| * JoshNang grumble grumble | 22:47 | |
| JoshNang | likely not? | 22:48 |
| JayF | has anyone checked to see if ATA security erase is supported in our VMs in the gate? | 22:48 |
| BadCub | does https://review.openstack.org/#/c/165241/ need to be associated with the Cleaning BP? | 22:48 |
| JayF | if not, we probably need to whip up a hardware manager that detects it's running in a VM and noops the erase_devices() step (and maybe any/all cleaning steps?) | 22:48 |
| mrda | Jay "The Cleaner" Faulkner | 22:48 |
| jroll | JoshNang: JayF: well... the ironic patch doesn't have the "add erase disks to agent steps" patch yet | 22:49 |
| jroll | so just the agent patch will fail | 22:49 |
| JayF | mrda: when you spew as much crap as I do, you get good at cleaning it up from time to time ;) | 22:49 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Disable cleaning by default https://review.openstack.org/165241 | 22:49 |
| mrda | lol | 22:49 |
| JoshNang | BadCub: added | 22:49 |
| BadCub | JoshNang: Awesomeness, TY :-) | 22:49 |
| devananda | JayF: adam_g might know off hand | 22:50 |
| JayF | JoshNang: do you have a devstack stack'd right now? | 22:50 |
| BadCub | added it to the eterhpad as well | 22:50 |
| mrda | devananda: good job in -nova btw | 22:50 |
| devananda | mrda: ty | 22:50 |
| JoshNang | JayF: i do | 22:50 |
| JayF | JoshNang: if so you can go into one of those VM instances and get the feature lines from the disk | 22:50 |
| JoshNang | JayF: i've been fighting to get the agent patch with cleaning steps to actually build and be used for deploys in devstack | 22:50 |
| JayF | JoshNang: if ata secure erase isn't supported, I can try to whip up something ... a DevstackHardwareManager | 22:50 |
| JayF | which noops the steps that don't make sense in a VM (like, you know, erasing disks) | 22:51 |
| JoshNang | heh | 22:51 |
| JayF | or we can add a shred / dd-zeroes fallback | 22:51 |
| JoshNang | alrighty | 22:51 |
| JayF | but that will make the gate atake a /long freaking time/ | 22:51 |
| JoshNang | yeah, let's not | 22:51 |
| devananda | oh hey, i dont feel so bad about our progress towards k3 after looking at nova's page | 22:52 |
| devananda | (they have 10 open BP still) | 22:52 |
| NobodyCam | nice :) | 22:53 |
| devananda | and by that i actually mean i felt good and now feel even better | 22:53 |
| devananda | JayF: so actually erasing disks in the VM does make sense inasmuchas ironic won't delete the disk between provisionings | 22:54 |
| devananda | JayF: but i totally agree that in the gate it should be no-op'd EXCEPT forwhen we want to actually test THAT feature | 22:54 |
| JayF | We cannot test that feature in a VM. | 22:54 |
| JayF | (If that VM doesn't support ATA Security Erase) | 22:55 |
| devananda | eh? | 22:55 |
| devananda | oh - that | 22:55 |
| devananda | right | 22:55 |
| JayF | we don't support *any* disks upstream that don't support ATA Security Erase today | 22:55 |
| JayF | we don't even fallback to writing zeros in that case, because we don't want it to be easy for someone to kill their disk unsuspecting | 22:55 |
| jroll | I mean, we could write a shred thing to test it, like you say | 22:55 |
| JayF | (kill their disk with write cycles) | 22:55 |
| devananda | jroll: ++ | 22:55 |
| JayF | jroll: what are we testing at that point though? Something that would only, generally run in the gate | 22:55 |
| JayF | IMO that would not make an effective test | 22:56 |
| jroll | oh, true | 22:56 |
| jroll | yeah, no-op'ing it would be equally effective | 22:56 |
| jroll | although eventually someone is going to want a "write zeroes" step | 22:56 |
| jroll | whether that's in IPA proper or not | 22:56 |
| JayF | If we want to add an overall fallback to using shred, that could make sense and to me is more of a "business" decision (I guess those are project decisions in OpenStack? heh) | 22:56 |
| JayF | jroll: prolientutils implements secure erase as /only/ shred for 3 passes | 22:57 |
| jroll | I know :( | 22:57 |
| JayF | it's pretty awful, actaully. RIP those disks in proliant servers everywhere | 22:57 |
| devananda | fallback ++ | 22:57 |
| jroll | ikr | 22:57 |
| jroll | well | 22:57 |
| jroll | someone should improve that | 22:57 |
| devananda | what's the alternative - skip it and operators think cleaning was a success? | 22:58 |
| jroll | but I assume HP is primarily making this for business use | 22:58 |
| jroll | which is likely "install openstack' | 22:58 |
| JayF | devananda: right now, we CLEANFAIL if we can't do it | 22:58 |
| jroll | not much disk churn | 22:58 |
| devananda | JayF: ugh | 22:58 |
| JayF | The alternative being: | 22:58 |
| jroll | back up | 22:58 |
| devananda | JayF: so the default is, fo rhardware without ATA secure erase, you can't delete an instance?!?! | 22:58 |
| JayF | 1) Cleaning takes a linearly longer time based on disk size if we fallback to shred/write zeroes | 22:58 |
| devananda | JayF: that is not an acceptable upstream default | 22:58 |
| JayF | 2) An Operator thinks a device is clean and it's not | 22:58 |
| jroll | you can delete an instance, but the ironic operator doesn't get that node back ;) | 22:59 |
| jroll | no, I agree this is bad | 22:59 |
| devananda | IMO delete taking a long time is fine, when the operator has chosen to enable that clean step | 22:59 |
| devananda | and doesn't have hardware that optimizes it | 22:59 |
| jroll | and operators can choose to disable this step afaik? | 22:59 |
| JayF | If the consensus is to write a fallback, I can have that patch up before I leave. | 22:59 |
| devananda | JoshNang: looking at 161453 I do *not* see an option to disable cleaning for the agent | 23:02 |
| jroll | devananda: worst case we don't land the patch to the agent that enables this step | 23:03 |
| jroll | everything is going to be ok | 23:03 |
| NobodyCam | i was just looking at that. its also failing check-tempest-dsvm-ironic-agent_ssh | 23:03 |
| devananda | yah | 23:03 |
| jroll | we can fix this one way or the other | 23:03 |
| JoshNang | devananda: so, i had been basing all of that off of using hardware managers to determine steps | 23:03 |
| jroll | NobodyCam: that's being worked on | 23:03 |
| NobodyCam | :) | 23:03 |
| JoshNang | adding a config option to disable agent steps is probably a good idea | 23:03 |
| jroll | to disabled built-in agent steps? | 23:04 |
| jroll | or all? | 23:04 |
| devananda | i just have to say, this whole feature feels really really rushed at this point :( | 23:04 |
| JoshNang | i was going to go with all | 23:04 |
| jroll | devananda: wdyt about landing it without any default steps? we can iterate on the agent from there. | 23:05 |
| JayF | Everything feels rushed given we dedicated the first half of the release cycle to changing the state machine | 23:05 |
| JayF | heh | 23:05 |
| devananda | it's important enough that I think we need to go forward with it | 23:05 |
| devananda | JayF: right | 23:05 |
| devananda | JoshNang: 157715 is more like what I am expecting for all drivers | 23:08 |
| devananda | where there is a list of different clean steps that the driver performs, and I can choose in the config what to enable | 23:09 |
| JayF | Hmm. That's not really possible with the agent steps being determined remotely by which agent is booted, is it? | 23:09 |
| JoshNang | right, that's why in band has been a bit different | 23:09 |
| devananda | JayF: perhaps there are categories of steps the agent can perform? | 23:09 |
| devananda | like "erase the disks" "reset bios settings" ... | 23:09 |
| JayF | Hmm. I could get along with that. | 23:09 |
| JayF | Block device erasing , firmware/bios modification , verification | 23:10 |
| JayF | are like three basic categories almost all steps could fall into | 23:10 |
| jroll | and where do you see those being configured? | 23:10 |
| JayF | in Ironic. | 23:10 |
| devananda | side bar -- we're going to start hitting deployments that are heterogeneous enough that such things will need to be determied per-node, not per-conductor, eventually | 23:10 |
| jroll | ok | 23:10 |
| JayF | You'd have to change the IPA interface to pass a category with the steps when fetching steps | 23:10 |
| JoshNang | that's not too hard | 23:11 |
| devananda | side bar pt 2 -- but i think we can address that in a few cycles, and certainly not today | 23:11 |
| JoshNang | i already had to do some filtering to accomdate the raid interface | 23:11 |
| JoshNang | so, categories. i think that's doable and probably a good way to go | 23:13 |
| JoshNang | making it more uniform and less likely any user needs to build a ramdisk is good in my eyes | 23:13 |
| devananda | ++ | 23:14 |
| devananda | i would be delighted if the majority of smaller users can just download the IPA build artifact and use it | 23:14 |
| JoshNang | +100 | 23:15 |
| JoshNang | so if that's the direction we want to go, i don't think the agent bits will make it for K | 23:16 |
| jroll | agent can release any time | 23:17 |
| jroll | like the client | 23:17 |
| JoshNang | *agent driver | 23:17 |
| jroll | I'm not sure if we need to address that this cycle | 23:17 |
| jroll | but we *should* address the no-secure-ata-erase-breaks-all-the-things case | 23:17 |
| JoshNang | i think the categories bit is a good idea | 23:17 |
| JoshNang | that too | 23:17 |
| jroll | since "erase devices" is the only thing IPA does upstream right now, categories might not make much sense | 23:18 |
| devananda | jroll: so the fix for no-secure-erase-breaks-the-world should be entirely in IPA, right? | 23:19 |
| jroll | devananda: indeed, fall back to writing zeroes and/or have some flag/easy way to disable it | 23:19 |
| *** Marga_ has quit IRC | 23:20 | |
| devananda | JoshNang: would it make sense / be feasible for the agent driver to have a conf option to signal the agent to skip the disk erase step, even if its there? | 23:20 |
| JoshNang | devananda: certainly | 23:20 |
| devananda | between the extremes of "fall back to writing zeroes" and "disable all cleaning globally for all drivers" | 23:20 |
| devananda | i think we need something .... | 23:20 |
| JoshNang | heh yesh | 23:20 |
| JayF | I'm literally like 60% of the way through the fallback patch | 23:20 |
| JoshNang | yes even | 23:20 |
| devananda | JayF: awesome | 23:20 |
| JayF | and I'm usually the one panicing over stuff while other people write the patch | 23:20 |
| devananda | :) | 23:21 |
| JayF | devananda: thanks for apache licensing the proliant hw manager | 23:21 |
| * JayF stealing greedily | 23:21 | |
| * devananda shuts up and lets people write code | 23:21 | |
| devananda | JayF: LOL | 23:21 |
| *** Mr_T has left #openstack-ironic | 23:21 | |
| *** yuanying has joined #openstack-ironic | 23:21 | |
| jroll | lol | 23:22 |
| *** Marga_ has joined #openstack-ironic | 23:23 | |
| JayF | oh I'm an idiot | 23:25 |
| JayF | git commit --amend for the first commit #ftl | 23:25 |
| *** ChuckC has joined #openstack-ironic | 23:26 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Add fallback secure erase using shred https://review.openstack.org/165247 | 23:26 |
| *** Marga_ has quit IRC | 23:26 | |
| JayF | ^ gotta write/fix test cases, but that's the actual fix | 23:27 |
| *** Marga_ has joined #openstack-ironic | 23:27 | |
| jroll | JayF: left a thing | 23:30 |
| jroll | also NEEDS TESTS | 23:30 |
| jroll | :P | 23:30 |
| JayF | hah | 23:31 |
| *** Marga_ has quit IRC | 23:31 | |
| JayF | I renamed that function like four times | 23:31 |
| *** Marga_ has joined #openstack-ironic | 23:31 | |
| jroll | :P | 23:31 |
| *** Marga_ has quit IRC | 23:32 | |
| *** Marga_ has joined #openstack-ironic | 23:32 | |
| NobodyCam | JayF: call it FWaN == Function Without a Name | 23:32 |
| jroll | more like function with four names | 23:33 |
| NobodyCam | :-p | 23:33 |
| *** Marga_ has quit IRC | 23:45 | |
| NobodyCam | who having green beer tonight? | 23:45 |
| NobodyCam | s/who/who's/ | 23:46 |
| jroll | not me, have to drive later :( | 23:47 |
| NobodyCam | :( | 23:47 |
| jroll | also I prefer irish carbombs to green beer :) | 23:47 |
| NobodyCam | oh that would mess me up | 23:47 |
| jroll | heh | 23:48 |
| jroll | JoshNang: don't tell me you're so upset about the nova situation that you're spamming the openstack channels :/ | 23:48 |
| JoshNang | jroll: heh | 23:48 |
| NobodyCam | i'd end up leaving my fone at some off the wall food estlisment | 23:48 |
| NobodyCam | lol | 23:48 |
| JoshNang | i'd pick something more creative than 'Cheeseburgah' as my nick | 23:48 |
| JayF | now I have that SNL skit stuck in my head | 23:49 |
| JoshNang | jroll: plus those bugs are now targeted at k-3. there is no need to be upset | 23:49 |
| jroll | :P | 23:49 |
| NobodyCam | lol | 23:49 |
| *** david-lyle is now known as david-lyle_afk | 23:50 | |
| NobodyCam | not coke pepsi | 23:50 |
| NobodyCam | oh its no coke | 23:50 |
| NobodyCam | :-p | 23:50 |
| *** oomichi has joined #openstack-ironic | 23:51 | |
| * jroll suddenly confused | 23:52 | |
| JayF | jroll: https://screen.yahoo.com/olympia-restaurant-000000640.html | 23:53 |
| jroll | thanks | 23:53 |
| jroll | heh | 23:54 |
| *** Marga_ has joined #openstack-ironic | 23:56 | |
| devananda | jroll: btw, unit tests added to https://review.openstack.org/#/c/164369/ -- in case you feel like another review | 23:57 |
| * jroll looks | 23:58 | |
| jroll | I've been slacking on reviews today :/ | 23:58 |
| jroll | devananda: don't see the tests... | 23:59 |
| NobodyCam | are you following the etherpad? | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
