| *** achanda has quit IRC | 00:00 | |
| *** Haomeng has quit IRC | 00:00 | |
| *** penick has joined #openstack-ironic | 00:04 | |
| *** achanda has joined #openstack-ironic | 00:06 | |
| *** absubram has quit IRC | 00:09 | |
| *** mtanino has quit IRC | 00:12 | |
| jroll | does pbr depend on requirements.txt using pypi things? can it use git+https? | 00:12 |
|---|---|---|
| jroll | lifeless: ^ | 00:13 |
| lifeless | jroll: the contents of requirements.txt are just fed into setuptools | 00:13 |
| lifeless | that said, for stuff in openstack we reaaaaaly don't want references to VCS's in requirements. | 00:14 |
| jroll | blah | 00:14 |
| jroll | yeah, this isn't in openstack | 00:14 |
| jroll | and I'm just getting ahead of the last ironicclient release | 00:14 |
| lifeless | pip pulls the requirements back out from setuptools metadata | 00:14 |
| jroll | don't want it in there for long | 00:14 |
| *** hj-hp has quit IRC | 00:14 | |
| jroll | should be ok without it for now, thanks :) | 00:14 |
| lifeless | jroll: you could build a beta release and put it in your devpi or whatever | 00:15 |
| lifeless | jroll: or use the vcs ref, as long as its not upstream :) | 00:15 |
| jroll | lifeless: like I said, this is a non-openstack project :) | 00:15 |
| lifeless | yeah | 00:15 |
| lifeless | so yes, it should work for you | 00:15 |
| jroll | it's not working with git+https://github.com/openstack/python-ironicclient@somesha | 00:16 |
| jroll | but tis ok, I'll figure it out later. thanks :) | 00:16 |
| lifeless | jroll: do you get an error ? | 00:18 |
| jroll | lifeless: yes, "error in setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers" | 00:18 |
| lifeless | don't forget the #egg=python-ironicclient | 00:18 |
| jroll | mmmm | 00:18 |
| * jroll tries | 00:18 | |
| lifeless | oh | 00:18 |
| lifeless | I'd hope that wouldn't break, but sigh, we can't have nice things | 00:19 |
| lifeless | setuptools really has no business validating that stuff | 00:19 |
| jroll | right | 00:19 |
| jroll | might have been the egg thing | 00:19 |
| * jroll waits for tox | 00:19 | |
| lifeless | but then setuptools has no business installing stuff :) | 00:19 |
| jroll | meh, same deal | 00:19 |
| jroll | using this, to be clear: git+https://github.com/openstack/python-ironicclient@master#egg=python-ironicclient | 00:20 |
| lifeless | ok so | 00:20 |
| lifeless | in your actual app you're deploying | 00:20 |
| lifeless | have a requirements.txt with that in it | 00:20 |
| *** hj-hp has joined #openstack-ironic | 00:20 | |
| jroll | right, it's in requirements.txt, using the usual openstack-y setup.py | 00:20 |
| *** ijw has quit IRC | 00:21 | |
| jroll | attempting to use tox for testing and such | 00:21 |
| lifeless | oh | 00:21 |
| jroll | deployment shouldn't be a problem | 00:21 |
| lifeless | I meant not in the pacakge thing | 00:21 |
| lifeless | requirements.txt are meant for deployments. We misuse them. | 00:21 |
| *** ijw has joined #openstack-ironic | 00:21 | |
| lifeless | long standing confusion issue thingy, will get to at some point | 00:21 |
| jroll | mhmm. | 00:21 |
| lifeless | for now though, make a new file, call it whatever the hell you want | 00:21 |
| lifeless | add that git line to it | 00:22 |
| lifeless | and do pip install -r thatfilename | 00:22 |
| lifeless | in your tox.ini | 00:22 |
| lifeless | before the tests run | 00:22 |
| jroll | yeah, I'm doing that via deps = -r{toxinidir}/requirements.txt | 00:23 |
| lifeless | you need this in a file that pbr won't suck up | 00:23 |
| jroll | it fails when it does the python setup.py whatever | 00:23 |
| lifeless | to avoid the setuptools injection error | 00:23 |
| jroll | aha, I see | 00:23 |
| * jroll runs | 00:24 | |
| *** takadayuiko has quit IRC | 00:24 | |
| jroll | lifeless: that indeed works, thanks for the insight | 00:25 |
| lifeless | yw | 00:25 |
| lifeless | your app requirements file should list just python-ironicclient | 00:25 |
| jroll | right | 00:26 |
| *** igordcard_ has quit IRC | 00:32 | |
| *** hj-hp has quit IRC | 00:33 | |
| *** kkoski has joined #openstack-ironic | 00:34 | |
| *** penick has quit IRC | 00:41 | |
| *** hj-hp has joined #openstack-ironic | 00:45 | |
| *** hj-hp has quit IRC | 00:47 | |
| *** penick has joined #openstack-ironic | 00:47 | |
| *** igordcard has joined #openstack-ironic | 00:52 | |
| *** penick has quit IRC | 00:52 | |
| *** naohirot has joined #openstack-ironic | 00:53 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: pxe deploy fails for whole disk images in UEFI https://review.openstack.org/167882 | 01:04 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: pxe deploy fails for whole disk images in UEFI https://review.openstack.org/167882 | 01:11 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: boot_mode is overwritten in node properties https://review.openstack.org/167952 | 01:13 |
| *** harlowja is now known as harlowja_away | 01:14 | |
| openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Use my_ip as default URl instead of localhost https://review.openstack.org/169965 | 01:15 |
| openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Use my_ip as default URL instead of localhost https://review.openstack.org/169965 | 01:16 |
| *** logan2 has quit IRC | 01:19 | |
| *** logan2 has joined #openstack-ironic | 01:21 | |
| *** saripurigopi has joined #openstack-ironic | 01:23 | |
| *** jmanko has joined #openstack-ironic | 01:28 | |
| *** alexpilotti has quit IRC | 01:29 | |
| *** jmank has quit IRC | 01:31 | |
| *** ijw has quit IRC | 01:34 | |
| *** ijw has joined #openstack-ironic | 01:35 | |
| *** Haomeng|2 has quit IRC | 01:37 | |
| *** chenglch has joined #openstack-ironic | 01:42 | |
| *** saripurigopi has quit IRC | 01:47 | |
| *** penick has joined #openstack-ironic | 01:47 | |
| openstackgerrit | Haomeng,Wang proposed openstack/ironic: Fix UnicodeEncodeError issue when the language is not en_US https://review.openstack.org/168268 | 01:51 |
| *** saripurigopi has joined #openstack-ironic | 01:53 | |
| *** Marga_ has quit IRC | 01:55 | |
| *** penick has quit IRC | 01:57 | |
| *** Haomeng has joined #openstack-ironic | 01:57 | |
| *** kkoski has quit IRC | 01:59 | |
| *** kkoski has joined #openstack-ironic | 02:02 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: pxe deploy fails for whole disk images in UEFI https://review.openstack.org/167882 | 02:09 |
| *** kkoski has quit IRC | 02:14 | |
| *** rloo has quit IRC | 02:21 | |
| *** ijw has quit IRC | 02:21 | |
| *** ramineni has joined #openstack-ironic | 02:35 | |
| *** ijw has joined #openstack-ironic | 02:36 | |
| *** yuanying has quit IRC | 02:44 | |
| *** saripurigopi has quit IRC | 02:44 | |
| mrda | Haomeng: pep8 failure on review 168268 | 02:46 |
| mrda | Just FYI :) | 02:46 |
| Haomeng | mrda: yes, will fix in next patch, thank you:) | 02:47 |
| Haomeng | mrda: thanks:) | 02:47 |
| Haomeng | mrda: :) | 02:47 |
| Haomeng | mrda: but srange for such "./ironic/common/exception.py:92:2: H402 one line docstring needs punctuation." issue, I can not find it by local 'flake8', any comments/? | 02:47 |
| Haomeng | mrda: so I run flake8 in my local dev env, and can not see such h402 issue | 02:48 |
| * mrda looks | 02:48 | |
| Haomeng | mrda: will commit new patch to add "." as the punctuation, hope this works | 02:49 |
| openstackgerrit | Haomeng,Wang proposed openstack/ironic: Fix UnicodeEncodeError issue when the language is not en_US https://review.openstack.org/168268 | 02:49 |
| mrda | The "." is what you need on the docstring | 02:49 |
| * mrda has seen this today too | 02:50 | |
| *** yuanying has joined #openstack-ironic | 02:50 | |
| Haomeng | mrda: ok | 02:50 |
| Haomeng | mrda: done | 02:50 |
| mrda | I'll wait for pep8 to complete :) | 02:51 |
| Haomeng | mrda: ok, sure:) | 02:55 |
| *** spandhe has quit IRC | 03:12 | |
| *** spandhe has joined #openstack-ironic | 03:12 | |
| *** spandhe has quit IRC | 03:13 | |
| openstackgerrit | Michael Davies proposed openstack/ironic: Refactor test code to reduce duplication https://review.openstack.org/169981 | 03:31 |
| *** achanda has quit IRC | 03:38 | |
| Haomeng | mrda: one question, do you know how this doc is generated - http://docs.openstack.org/developer/python-ironicclient/api/ironicclient.v1.node.html | 03:39 |
| openstackgerrit | Merged openstack/ironic: pxe deploy fails for whole disk images in UEFI https://review.openstack.org/167882 | 03:39 |
| Haomeng | mrda: I looked into our client code, no such option "detail ¨C Optional, boolean whether to return detailed information about nodes." defined | 03:39 |
| mrda | Haomeng: I would have thought this was just the gendocs job | 03:41 |
| Haomeng | mrda: ok | 03:41 |
| mrda | But I am not sure, as I haven't deliberately generated any of those docs | 03:42 |
| Haomeng | mrda: ok, never mind, thanks:) | 03:44 |
| Haomeng | mrda: :) | 03:44 |
| *** ijw has quit IRC | 03:45 | |
| *** Nisha has joined #openstack-ironic | 03:47 | |
| *** rameshg87 has joined #openstack-ironic | 03:50 | |
| rameshg87 | good morning ironic | 03:50 |
| *** jamielennox is now known as jamielennox|away | 03:51 | |
| mrda | hi rameshg87 | 03:51 |
| rameshg87 | hello mrda | 03:52 |
| *** jcoufal has joined #openstack-ironic | 03:57 | |
| *** saripurigopi has joined #openstack-ironic | 04:01 | |
| *** spandhe has joined #openstack-ironic | 04:03 | |
| *** rameshg87 has left #openstack-ironic | 04:17 | |
| *** rameshg87 has joined #openstack-ironic | 04:24 | |
| *** Marga_ has joined #openstack-ironic | 04:25 | |
| *** Marga_ has quit IRC | 04:25 | |
| *** Marga_ has joined #openstack-ironic | 04:26 | |
| *** achanda has joined #openstack-ironic | 04:32 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Check status of bootloader installation for DIB ramdisk https://review.openstack.org/169419 | 04:56 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: boot_mode is overwritten in node properties https://review.openstack.org/167952 | 04:58 |
| openstackgerrit | IWAMOTO Toshihiro proposed openstack/ironic: Regenerate states diagram after addition of CLEANING. https://review.openstack.org/169997 | 05:12 |
| *** Marga_ has quit IRC | 05:25 | |
| *** jcoufal has quit IRC | 05:39 | |
| *** rameshg87 has left #openstack-ironic | 05:54 | |
| openstackgerrit | IWAMOTO Toshihiro proposed openstack/ironic: Regenerate states diagram after addition of CLEANING https://review.openstack.org/169997 | 05:58 |
| *** achanda has quit IRC | 05:58 | |
| *** achanda has joined #openstack-ironic | 06:06 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Imported Translations from Transifex https://review.openstack.org/169184 | 06:13 |
| *** jcoufal has joined #openstack-ironic | 06:20 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: localboot deploy fails for iscsi_ilo driver https://review.openstack.org/168666 | 06:29 |
| *** Haomeng is now known as Haomeng|2 | 06:34 | |
| *** Haomeng|2 is now known as Haomeng | 06:34 | |
| *** achanda has quit IRC | 06:43 | |
| *** achanda has joined #openstack-ironic | 06:46 | |
| *** pas-ha has joined #openstack-ironic | 06:55 | |
| *** chlong has quit IRC | 06:55 | |
| *** rameshg87 has joined #openstack-ironic | 06:57 | |
| *** mrda is now known as mrda-away | 06:57 | |
| *** dlpartain has joined #openstack-ironic | 06:57 | |
| mrda-away | Have a lovely Easter everyone - see you on Tuesday | 06:58 |
| *** achanda has quit IRC | 07:07 | |
| *** dtantsur|afk is now known as dtantsur | 07:09 | |
| dtantsur | Morning Ironic! | 07:09 |
| *** jistr has joined #openstack-ironic | 07:13 | |
| *** saripurigopi has quit IRC | 07:17 | |
| *** achanda has joined #openstack-ironic | 07:29 | |
| *** pradipta has joined #openstack-ironic | 07:30 | |
| *** yog__ has joined #openstack-ironic | 07:50 | |
| *** Nisha has quit IRC | 07:51 | |
| *** romcheg has joined #openstack-ironic | 07:54 | |
| yuriyz | morning Ironic Dtantsur | 07:55 |
| dtantsur | morning, yuanying | 07:55 |
| dtantsur | ooops | 07:55 |
| dtantsur | yuriyz :) | 07:55 |
| * dtantsur wants smarter autocomplete >_< | 07:55 | |
| *** dlpartain has left #openstack-ironic | 08:02 | |
| *** mgoddard has joined #openstack-ironic | 08:03 | |
| *** mgoddard has quit IRC | 08:07 | |
| *** achanda has quit IRC | 08:14 | |
| *** athomas has joined #openstack-ironic | 08:18 | |
| *** andreykurilin_ has joined #openstack-ironic | 08:21 | |
| rameshg87 | dtantsur: yuriyz: o/ | 08:23 |
| * rameshg87 starts to shamelessly request review | 08:23 | |
| rameshg87 | dtantsur: yuriyz: review please https://review.openstack.org/#/c/169419/ when you get some time | 08:23 |
| rameshg87 | dtantsur: yuriyz: it's one of critical bug for rc1 | 08:24 |
| yuriyz | rameshg87 just doing now | 08:24 |
| rameshg87 | yuriyz: thanks : | 08:25 |
| *** lucasagomes has joined #openstack-ironic | 08:26 | |
| *** andreykurilin_ has quit IRC | 08:27 | |
| *** andreykurilin_ has joined #openstack-ironic | 08:27 | |
| *** achanda has joined #openstack-ironic | 08:28 | |
| *** ndipanov has joined #openstack-ironic | 08:34 | |
| *** tiagogomes_ has joined #openstack-ironic | 08:36 | |
| *** achanda has quit IRC | 08:40 | |
| *** achanda has joined #openstack-ironic | 08:41 | |
| *** pelix has joined #openstack-ironic | 08:43 | |
| *** MattMan has joined #openstack-ironic | 08:47 | |
| *** andreykurilin_ has quit IRC | 08:52 | |
| *** andreykurilin_ has joined #openstack-ironic | 08:53 | |
| *** andreykurilin_ has quit IRC | 08:58 | |
| *** dtantsur is now known as dtantsur|brb | 08:58 | |
| *** andreykurilin_ has joined #openstack-ironic | 08:59 | |
| openstackgerrit | IWAMOTO Toshihiro proposed openstack/ironic-specs: Collect IPA logs https://review.openstack.org/168799 | 09:00 |
| *** andreykurilin_ has quit IRC | 09:04 | |
| *** edcragg has joined #openstack-ironic | 09:04 | |
| *** derekh has joined #openstack-ironic | 09:05 | |
| rameshg87 | lucasagomes: hi | 09:06 |
| lucasagomes | rameshg87, hello | 09:06 |
| rameshg87 | lucasagomes: this is waiting for your vote: https://review.openstack.org/#/c/169354/ | 09:06 |
| rameshg87 | 2 x +2s | 09:06 |
| lucasagomes | rameshg87, oh I will take a look | 09:08 |
| lucasagomes | you got the change in Ironic too? | 09:09 |
| rameshg87 | lucasagomes: yeah | 09:09 |
| rameshg87 | https://review.openstack.org/#/c/169419/ | 09:09 |
| *** saripurigopi has joined #openstack-ironic | 09:10 | |
| lucasagomes | rameshg87, awesome, the power control after installing the bootloader is done by Ironic? | 09:10 |
| lucasagomes | or it still the ramdisk that reboot the node? | 09:10 |
| * lucasagomes will read the code | 09:10 | |
| *** achanda has quit IRC | 09:12 | |
| lucasagomes | rameshg87, seems finish_deploy() is not controlling the power status :/ | 09:13 |
| lucasagomes | rameshg87, I'm asking because this is a really annoying problem we have to test with the VMs | 09:14 |
| lucasagomes | when we deploy with local boot, we change the boot device to DISK, but virsh doesn't apply the change until the machine is powered off and on again | 09:14 |
| lucasagomes | so when the DIB ramdisk just goes and reboot, the machine get stuck in a loop trying to boot from network | 09:15 |
| lucasagomes | and doesn't fall back to the disk or anything :/ | 09:15 |
| rameshg87 | lucasagomes: okay, so what exactly is expected ? | 09:15 |
| rameshg87 | lucasagomes: we should power off the node before doing set_boot_device() ? | 09:15 |
| lucasagomes | rameshg87, hmm I would say that after at the end of finish_deploy(), Ironic should reboot the node | 09:16 |
| lucasagomes | not the ramdisk | 09:16 |
| lucasagomes | something like IPA does | 09:16 |
| lucasagomes | we just need to make sure, that after installing the bootloader in the ramdisk etc | 09:16 |
| lucasagomes | things are sync'd, the data is flushed to the disk | 09:16 |
| rameshg87 | lucasagomes: that is sure when we umount it no ? | 09:17 |
| lucasagomes | perhaps calling "sync" there would do the job | 09:17 |
| lucasagomes | rameshg87, oh yeah | 09:17 |
| lucasagomes | that's true | 09:17 |
| lucasagomes | once you umount it sync it | 09:17 |
| rameshg87 | lucasagomes: but i still didn't get the virsh thing | 09:17 |
| lucasagomes | AFAICT | 09:17 |
| rameshg87 | lucasagomes: so the problem is virsh doesn't allow to change the boot device to disk when vm is powered on, right ? | 09:17 |
| lucasagomes | rameshg87, yeah that's it | 09:17 |
| lucasagomes | rameshg87, cause the VM is powered on, and we change the XML definition | 09:18 |
| lucasagomes | but the changes doesn't get applied until the VM is powered off | 09:18 |
| lucasagomes | rameshg87, it just affects VMs, but it's really annoying for tests | 09:18 |
| rameshg87 | lucasagomes: so if the vm reboots by itself, it doesn't get applied ? | 09:18 |
| rameshg87 | lucasagomes: i mean by running a reboot command ? | 09:18 |
| lucasagomes | rameshg87, yeah it doesn't | 09:19 |
| lucasagomes | because reboot doesn't power it on | 09:19 |
| lucasagomes | off* | 09:19 |
| * rameshg87 also faces same issue with vbox, but just lives with it :) | 09:19 | |
| lucasagomes | it just reboots | 09:19 |
| lucasagomes | rameshg87, yeah it's fine, but if we want to say test local boot in gate | 09:19 |
| lucasagomes | then things gets really complicated | 09:19 |
| rameshg87 | lucasagomes: but we can make the pxe driver change it no, may be in another commit ? | 09:19 |
| lucasagomes | rameshg87, yeah the PXE driver should be the one controlling the power IMO | 09:20 |
| lucasagomes | rameshg87, yeah can be another review | 09:20 |
| lucasagomes | I can put one up following that other patch of urs | 09:20 |
| lucasagomes | I will give it a go and I will let u know if that works | 09:20 |
| lucasagomes | rameshg87, anyway, thanks much for this change | 09:20 |
| lucasagomes | I +1'd the DIB patch | 09:20 |
| rameshg87 | :) | 09:20 |
| rameshg87 | lucasagomes: have a look at yuriyz comment on https://review.openstack.org/#/c/169419/5/ironic/drivers/modules/pxe.py 527 | 09:21 |
| rameshg87 | yuriyz: i think mixin won't work now because of continue_deploy method | 09:21 |
| rameshg87 | yuriyz: because mixin vendor interface wouldn't have heartbeat methods | 09:22 |
| rameshg87 | yuriyz: and so pxe_ssh + agent ramdisk won't work if we move it to a mixin | 09:22 |
| rameshg87 | lucasagomes: am i correct ? | 09:22 |
| lucasagomes | rameshg87, you can add heartbeat to the mixin too, but I don't I think I'm fine with that code | 09:25 |
| lucasagomes | the big part is already separated in a different module (iscsi_deploy) | 09:25 |
| lucasagomes | so, I'm ok with it | 09:25 |
| lucasagomes | it just making the calls | 09:25 |
| rameshg87 | lucasagomes: not only heartbeat methods, but all methods in agentbasevendor has to be added i guess | 09:26 |
| *** jistr has quit IRC | 09:26 | |
| rameshg87 | lucasagomes: like we do self.configure_local_boot() | 09:26 |
| rameshg87 | lucasagomes: now the self is mixin class and that needs to have configure_local_boot too | 09:27 |
| lucasagomes | rameshg87, right, yeah sounds like a PITA to have it | 09:27 |
| rameshg87 | lucasagomes: but we lost the ability to mixin i guess, we might need to restore it back | 09:28 |
| rameshg87 | lucasagomes: like seamicro still uses mixin | 09:28 |
| rameshg87 | lucasagomes: https://github.com/openstack/ironic/blob/master/ironic/drivers/pxe.py#L131-L136 | 09:28 |
| rameshg87 | lucasagomes: oh may be we don't need mixins at all :) | 09:29 |
| openstackgerrit | Nisha Agarwal proposed stackforge/proliantutils: Adding functionality required by ilo-inspection https://review.openstack.org/164142 | 09:30 |
| lucasagomes | rameshg87, yeah we can investigate it | 09:31 |
| * lucasagomes goes test the patch | 09:31 | |
| rameshg87 | yeah | 09:31 |
| *** achanda has joined #openstack-ironic | 09:32 | |
| rameshg87 | yuriyz: thanks for https://review.openstack.org/#/c/169354/2/elements/deploy-ironic/init.d/80-deploy-ironic | 09:40 |
| rameshg87 | yuriyz: i think we should add a check there | 09:40 |
| rameshg87 | yuriyz: do you see any other option other than again passing is_whole_disk_image as a kernel parameter ? | 09:40 |
| *** achanda has quit IRC | 09:41 | |
| *** jistr has joined #openstack-ironic | 09:44 | |
| *** athomas has quit IRC | 09:47 | |
| yuriyz | rameshg87 yes we can just pass 'iwdi' but I'm not sure that it is only one right way | 09:49 |
| rameshg87 | yuriyz: yeah that's the only way i think we can infer that in dib ramdisk | 09:50 |
| yuriyz | rameshg87 we can pass info for ramdisk here for example https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L399 | 09:53 |
| lucasagomes | rameshg87, yuriyz he whole disk and localboot | 09:54 |
| lucasagomes | rameshg87, isn't it somehting that Ironic should validate? | 09:54 |
| lucasagomes | if both are set, we should not even start the deployment | 09:54 |
| rameshg87 | lucasagomes: ironic cannot control code execution in dib | 09:54 |
| rameshg87 | lucasagomes: just like we do for ipa ramdisk | 09:55 |
| lucasagomes | rameshg87, yeah but if is_whole_disk_image == True and boot_option=local | 09:55 |
| lucasagomes | we should fail before | 09:55 |
| rameshg87 | lucasagomes: code execution will go down to boot_option == "local" for both while disk images and partition images | 09:55 |
| rameshg87 | lucasagomes: this is dib ramdisk, right ? | 09:55 |
| lucasagomes | rameshg87, yes, but can we verify it in Ironic | 09:55 |
| lucasagomes | ? | 09:56 |
| lucasagomes | before even booting the ramdisk? | 09:56 |
| yuriyz | now bot options together is supported for agent ramdisk AFAIK | 09:56 |
| rameshg87 | lucasagomes: is_whole_disk_image == true and boot_option == 'local' is a valid thing, right ? | 09:56 |
| yuriyz | s/bot/both | 09:56 |
| *** slagle has quit IRC | 09:56 | |
| *** athomas has joined #openstack-ironic | 09:56 | |
| lucasagomes | rameshg87, hmm so that we don't create the PXE config files? | 09:56 |
| rameshg87 | lucasagomes: ah no .. | 09:57 |
| rameshg87 | it's to prevent we installing the bootloader for whole disk image | 09:57 |
| *** slagle has joined #openstack-ironic | 09:57 | |
| rameshg87 | lucasagomes: if someone passed in a whole disk image and said boot_option == "local" | 09:57 |
| rameshg87 | lucasagomes: we should dd the image and set the node to boot from disk | 09:57 |
| lucasagomes | rameshg87, right, I'm trying to think that the combination of both options are correct | 09:57 |
| openstackgerrit | Nisha Agarwal proposed stackforge/proliantutils: Adding functionality required by ilo-inspection https://review.openstack.org/164142 | 09:58 |
| rameshg87 | lucasagomes: but with currently proposed code, ironic we will dd the image and set the node to boot from disk | 09:58 |
| *** naohirot has quit IRC | 09:58 | |
| rameshg87 | lucasagomes: and signal dib ramdisk to proceed | 09:58 |
| rameshg87 | lucasagomes: but dib ramdisk seeing boot_option == 'local', will try to install boot loader again | 09:58 |
| rameshg87 | because dib ramdisk doesn't know it is a whole disk image | 09:58 |
| rameshg87 | lucasagomes: so i think we have to pass this down to dib ramdisk | 09:59 |
| lucasagomes | rameshg87, right, I have to look at the whole disk image code | 10:00 |
| lucasagomes | but, when is_whole_disk_image is set | 10:00 |
| lucasagomes | does we assume the image has a bootloader already installed? and set the boot device to boot from DISK? | 10:00 |
| rameshg87 | lucasagomes: yeah if whole disk image and boot_option == "local", we assume that | 10:01 |
| lucasagomes | rameshg87, ah gotcha, so you still need the boot_option == local | 10:01 |
| rameshg87 | lucasagomes: yeah | 10:01 |
| lucasagomes | otherwise it will pxe boot and just chainload it to the local boot loader | 10:01 |
| lucasagomes | rameshg87, ok | 10:01 |
| lucasagomes | rameshg87, yeah so we need to check | 10:01 |
| lucasagomes | I was confused because I thought that is_whole_disk_image already asumed local boot | 10:01 |
| rameshg87 | yuriyz: another option is we can change the boot_option that is sent to ramdisk if it is whole disk image and boot_option="local" | 10:02 |
| rameshg87 | lucasagomes: yeah | 10:02 |
| lucasagomes | rameshg87, sorry for the confusion, yeah sounds good to actually pass that option to the ramdisk and check it | 10:02 |
| rameshg87 | lucasagomes: whole disk image by default pxe boots | 10:02 |
| lucasagomes | rameshg87, gotcha | 10:02 |
| rameshg87 | okay | 10:02 |
| openstackgerrit | Merged openstack/ironic: Top level unit tests: Use autospec=True for mocks https://review.openstack.org/169109 | 10:02 |
| rameshg87 | lucasagomes: i was just checking if we can do something else without passing that | 10:02 |
| rameshg87 | lucasagomes: we could tweak value of boot_option sent to ramdisk to something else if boot_option == "local" and it's whole disk image | 10:03 |
| rameshg87 | lucasagomes: so that the block doesn't execute | 10:03 |
| rameshg87 | another option yuriyz pointed out : https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L399 | 10:04 |
| rameshg87 | yuriyz: i hope you meant to send something other than 'done', right ? | 10:04 |
| rameshg87 | and then send | 10:04 |
| lucasagomes | rameshg87, hmm right, sounds a bit obscure to change that done | 10:04 |
| yuriyz | yes | 10:04 |
| rameshg87 | i like yuriyz approach | 10:04 |
| rameshg87 | lucasagomes: wdyt ? ^^^ | 10:04 |
| lucasagomes | hmm I have to get my read around it | 10:05 |
| lucasagomes | too much info, I don't have an strong opnion | 10:05 |
| * lucasagomes is still testing the current code | 10:06 | |
| *** marios has quit IRC | 10:06 | |
| lucasagomes | I will brb | 10:06 |
| *** chenglch has quit IRC | 10:07 | |
| *** marios has joined #openstack-ironic | 10:07 | |
| openstackgerrit | Merged openstack/ironic: Add config drive documentation https://review.openstack.org/166201 | 10:10 |
| rameshg87 | okay | 10:10 |
| openstackgerrit | Anusha Ramineni proposed openstack/ironic: iLO driver documentation for node cleaning https://review.openstack.org/169162 | 10:14 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Update ilo drivers documentation for inspection https://review.openstack.org/170065 | 10:19 |
| openstackgerrit | Anusha Ramineni proposed openstack/ironic: iLO driver documentation for node cleaning https://review.openstack.org/169162 | 10:21 |
| *** dtantsur|brb is now known as dtantsur | 10:22 | |
| *** Marga_ has joined #openstack-ironic | 10:23 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Update ilo drivers documentation for inspection https://review.openstack.org/170065 | 10:36 |
| *** saripurigopi has quit IRC | 10:37 | |
| *** yuanying has quit IRC | 10:42 | |
| *** mgoddard has joined #openstack-ironic | 10:43 | |
| rameshg87 | yuriyz: i am just thinking if i will file another bug and then work on it for is_whole_disk_image thing | 10:45 |
| rameshg87 | yuriyz: because that problem is already there in ironic today and is different from the current bug | 10:45 |
| rameshg87 | does that seem fine to you ? | 10:46 |
| *** mgoddard has quit IRC | 10:47 | |
| * rameshg87 goes home | 10:58 | |
| *** rameshg87 has quit IRC | 10:58 | |
| *** ramineni has quit IRC | 11:13 | |
| openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Use my_ip as default URL instead of localhost https://review.openstack.org/169965 | 11:27 |
| *** links has joined #openstack-ironic | 11:36 | |
| *** alexpilotti has joined #openstack-ironic | 11:43 | |
| *** romcheg has quit IRC | 11:48 | |
| *** MattMan has quit IRC | 11:54 | |
| *** pradipta has quit IRC | 11:56 | |
| *** subscope has quit IRC | 11:59 | |
| *** dprince has joined #openstack-ironic | 12:02 | |
| yuriyz | dtantsur bug 1422723 is only for DIB ramdisk, so no agent changes needed | 12:06 |
| openstack | bug 1422723 in Ironic "Ironic sets instance as active even if bootloader installation fails when boot_option is 'local'" [Critical,In progress] https://launchpad.net/bugs/1422723 - Assigned to Ramakrishnan G (rameshg87) | 12:06 |
| dtantsur | yuriyz, so will agent ramdisk call this passthru? | 12:08 |
| yuriyz | no agent calls another method: continue_deploy() | 12:08 |
| dtantsur | yuriyz, not sure I understand you. agent used with pxe_ drivers should be calling the same methods, no? | 12:09 |
| yuriyz | dtantsur AFAIK no https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L612 | 12:11 |
| dtantsur | I see, good | 12:11 |
| *** pradipta has joined #openstack-ironic | 12:12 | |
| *** subscope has joined #openstack-ironic | 12:15 | |
| *** rameshg87 has joined #openstack-ironic | 12:18 | |
| rameshg87 | yuriyz: lucasagomes: hi | 12:18 |
| lucasagomes | rameshg87, hi there | 12:18 |
| lucasagomes | rameshg87, I tested the patch and it works :) | 12:18 |
| yuriyz | hi rameshg87 | 12:18 |
| *** dprince has quit IRC | 12:19 | |
| lucasagomes | I will put another patch-set doing the reboot thing to solve the virsh problem | 12:19 |
| rameshg87 | :) | 12:19 |
| rameshg87 | yuriyz: lucasagomes: let me know what you think about addressing this as a separate bug - https://review.openstack.org/#/c/169419/ ? | 12:19 |
| *** dprince has joined #openstack-ironic | 12:19 | |
| rameshg87 | i mean localboot + whole disk image, i think is better if it's a separate bug | 12:19 |
| rameshg87 | wdyt ? | 12:19 |
| lucasagomes | right | 12:19 |
| lucasagomes | the problem exist with the current code right? | 12:20 |
| rameshg87 | yes | 12:20 |
| lucasagomes | ok, yeah it makes sense | 12:20 |
| yuriyz | rameshg87 agree it is another problem | 12:20 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add retry logic to _exec_ipmitool https://review.openstack.org/168120 | 12:21 |
| rameshg87 | lucasagomes: yuriyz: okay, let me know if you see any other issue in dib patch, otherwise we can get that in :) | 12:21 |
| rameshg87 | yuriyz: i will address comments on ironic patch in a short while (after going home) :) | 12:22 |
| lucasagomes | ack | 12:22 |
| yuriyz | rameshg87 there is also comment about pass_bootloader_install_info step for DIB | 12:23 |
| * rameshg87 checks | 12:24 | |
| rameshg87 | yuriyz: i didn't get that comment | 12:24 |
| rameshg87 | yuriyz: https://review.openstack.org/#/c/169354/2/elements/deploy-ironic/init.d/80-deploy-ironic L171 | 12:25 |
| rameshg87 | yuriyz: it's already within if [ "$IRONIC_BOOT_OPTION" = "local" ], no ? | 12:25 |
| yuriyz | rameshg87 oh sorry this is true | 12:26 |
| rameshg87 | yuriyz: okay | 12:27 |
| rameshg87 | yuriyz: please leave a comment on dib patch if there is anything else that needs immediate addressal, otherwise i will ping tripleo folks to get this merged | 12:27 |
| rameshg87 | see you folks | 12:28 |
| * rameshg87 goes home now | 12:28 | |
| *** rameshg87 has quit IRC | 12:28 | |
| *** spandhe has quit IRC | 12:31 | |
| *** jjohnson2 has joined #openstack-ironic | 12:34 | |
| *** pradipta has quit IRC | 12:38 | |
| *** trown|outttypeww is now known as trown | 12:39 | |
| *** rloo has joined #openstack-ironic | 12:41 | |
| TheJulia | /wi/win 5 | 12:43 |
| *** mjturek1 has joined #openstack-ironic | 12:46 | |
| openstackgerrit | Merged stackforge/proliantutils: Adding functionality required by ilo-inspection https://review.openstack.org/164142 | 12:54 |
| *** jerryz has joined #openstack-ironic | 13:00 | |
| *** chlong has joined #openstack-ironic | 13:01 | |
| *** romcheg has joined #openstack-ironic | 13:03 | |
| *** kkoski has joined #openstack-ironic | 13:04 | |
| *** subscope has quit IRC | 13:16 | |
| *** subscope has joined #openstack-ironic | 13:16 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: FIX Vm stuck when deploying with pxe_ssh + local boot https://review.openstack.org/170117 | 13:19 |
| *** rameshg87 has joined #openstack-ironic | 13:33 | |
| rameshg87 | hello folks | 13:33 |
| rameshg87 | can someone please have a look at https://review.openstack.org/#/c/165847/ | 13:33 |
| rameshg87 | a small fix, it has been lying around for 15 days :( | 13:33 |
| rloo | rameshg87: you should get the bug associated with that, targetted to rc1 | 13:36 |
| rloo | hello everyone :-) | 13:37 |
| rameshg87 | rloo: hello | 13:37 |
| rameshg87 | rloo: oh i thought it already was, may be i should talk to BadCub | 13:37 |
| rameshg87 | i will do that .. | 13:37 |
| rameshg87 | BadCub: can you please set the milestone for rc1 | 13:38 |
| *** zigo has quit IRC | 13:38 | |
| *** ChuckC has quit IRC | 13:38 | |
| rameshg87 | BadCub: https://launchpad.net/bugs/1434452 | 13:39 |
| openstack | Launchpad bug 1434452 in Ironic "iscsi_ilo driver doesn't support whole disk image deployment using agent ramdisk" [Medium,In progress] - Assigned to Ramakrishnan G (rameshg87) | 13:39 |
| *** zigo_ is now known as zigo | 13:41 | |
| lucasagomes | rameshg87, oh i just tagged it to RC1 | 13:43 |
| lucasagomes | and +2'd the review | 13:43 |
| lucasagomes | rloo, TheJulia morning | 13:44 |
| rloo | hi lucasagomes and TheJulia | 13:44 |
| rameshg87 | lucasagomes: great, thanks :) | 13:45 |
| *** chlong has quit IRC | 13:47 | |
| NobodyCam | good morning Ironic :) | 13:52 |
| openstackgerrit | Merged openstack/ironic: Regenerate states diagram after addition of CLEANING https://review.openstack.org/169997 | 13:56 |
| *** subscope has quit IRC | 13:57 | |
| *** absubram has joined #openstack-ironic | 13:58 | |
| rameshg87 | NobodyCam: morning | 13:58 |
| NobodyCam | morning rameshg87 :) | 13:58 |
| lucasagomes | NobodyCam, morning | 14:08 |
| jroll | good morning lucasagomes NobodyCam rameshg87 rloo TheJulia yuriyz and anyone else that happens to be reading :) | 14:08 |
| lucasagomes | jroll, yo morning | 14:09 |
| rloo | mornin' jroll :) | 14:09 |
| lucasagomes | jroll, since you have looked at wsme, mind taking a look at https://review.openstack.org/#/c/169692/ ? | 14:09 |
| rameshg87 | morning jroll | 14:09 |
| jroll | lucasagomes: sure | 14:09 |
| lucasagomes | I need that so I can serve static file from the ironic api (for the ipxe work) | 14:09 |
| * lucasagomes thinks we should rename wsme to wsmh (web services made hard) | 14:10 | |
| NobodyCam | mornign lucasagomes, jroll | 14:11 |
| jroll | lucasagomes: why do those need to be static, why not make an endpoint that renders them? | 14:11 |
| NobodyCam | lucasagomes: lol | 14:11 |
| lucasagomes | jroll, cause ipxe will download the file to boot it? | 14:12 |
| lucasagomes | also without that we can't return raw content with wsme | 14:12 |
| lucasagomes | it will be serialized, so it will always return a string and ipxe won't boot from a string | 14:12 |
| jroll | lucasagomes: I guess I don't get it, an http response is always a string no? | 14:13 |
| *** ChuckC has joined #openstack-ironic | 14:13 | |
| lucasagomes | jroll, yeah kinda... but wsme will serialize it and add " " around it | 14:13 |
| lucasagomes | like if you return the raw content of the file | 14:14 |
| jroll | ......... | 14:14 |
| lucasagomes | it will become a string like "#!ipxe\n boot" | 14:14 |
| lucasagomes | jroll, yeah I know... | 14:14 |
| jroll | oh so you want to return a file object? | 14:14 |
| lucasagomes | jroll, yup, I got something working locally ere | 14:14 |
| lucasagomes | here* | 14:14 |
| jroll | with open('ipxe.txt') as f: return f | 14:15 |
| lucasagomes | I will attach a file in the response object as http://pecan.readthedocs.org/en/latest/routing.html?highlight=static%20files#static-file-serving | 14:15 |
| jroll | OH | 14:15 |
| *** subscope has joined #openstack-ironic | 14:15 | |
| lucasagomes | jroll, kinda, I will use the reponse object from pecan do do that | 14:15 |
| *** mgoddard has joined #openstack-ironic | 14:15 | |
| lucasagomes | and wsme return type will just be set to None | 14:15 |
| jroll | yeah I see | 14:16 |
| jroll | so it's just wsme+pecan that is weird with this | 14:16 |
| lucasagomes | so that ipxe when is booting it will download the file I just generated and boot from there | 14:16 |
| lucasagomes | so I don't need to have any files in the filesystem | 14:16 |
| jroll | yep | 14:16 |
| lucasagomes | it will be complete dynamic, I will generate the ipxe config files on the fly | 14:16 |
| lucasagomes | depending on the node state | 14:16 |
| lucasagomes | it's pretty neat :) | 14:16 |
| lucasagomes | the driver will be stateless | 14:16 |
| jroll | yeah, if you would have said attachment this would have made sense before :) | 14:17 |
| lucasagomes | if used with swift to boot the images from HTTP too, yeah 100% stateless | 14:17 |
| NobodyCam | ahh no core reviews on 168175 :( | 14:17 |
| jroll | so on this patch the commit message seems weird, but the code seems ok. I have limited knowledge of wsme though, don't feel comfortable with a +1 unless I dig into it more | 14:17 |
| lucasagomes | jroll, heh ok, I will use attachment :) | 14:17 |
| jroll | NobodyCam: you can fix that! | 14:17 |
| NobodyCam | no I can't | 14:18 |
| NobodyCam | its a devstack patch | 14:18 |
| lucasagomes | jroll, yeah that patch is fixing a more generic problem with wsme | 14:18 |
| lucasagomes | but that's required for the ipxe work | 14:18 |
| jroll | lucasagomes: right | 14:18 |
| jroll | NobodyCam: oh :/ | 14:18 |
| lucasagomes | jroll, the thing is, if you return None, that gets serialized into "null" and the content lenght will be 6 | 14:19 |
| lucasagomes | which sucks | 14:19 |
| lucasagomes | and tools will ignore the attached file and download the response body | 14:19 |
| NobodyCam | ahh clippy is gone mock.shocked_look=True gosh and I was just startting to like him/her/it != | 14:20 |
| jroll | lucasagomes: yeah | 14:21 |
| lucasagomes | jroll, but yeah anyway, that's why I want some eyes on that patch. cause I'm not super familiar with wsme codebase either | 14:22 |
| lucasagomes | I'm using it locally, works fine | 14:22 |
| lucasagomes | afaict! | 14:23 |
| jroll | lucasagomes: I haven't looked at wsme code in like a year :P | 14:23 |
| rameshg87 | TheJulia: hi | 14:23 |
| jroll | so my review isn't worth much | 14:23 |
| lucasagomes | jroll, heh believe it didn't change much | 14:23 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Check status of bootloader installation for DIB ramdisk https://review.openstack.org/169419 | 14:23 |
| rameshg87 | lucasagomes: ^^ | 14:23 |
| rameshg87 | :) | 14:23 |
| lucasagomes | rameshg87, thanks | 14:24 |
| TheJulia | rameshg87: good morning | 14:25 |
| rameshg87 | TheJulia: morning | 14:25 |
| NobodyCam | mornign TheJulia | 14:25 |
| rameshg87 | TheJulia: had some questions on https://review.openstack.org/#/c/168120/3/ironic/drivers/modules/ipmitool.py | 14:25 |
| TheJulia | sure | 14:25 |
| rameshg87 | TheJulia: 1) regarding "with excutils.save_and_reraise_exception" | 14:26 |
| *** links has quit IRC | 14:26 | |
| rameshg87 | TheJulia: is it really required ? | 14:26 |
| rameshg87 | i thought it was required for protecting the exception handling code blocks which themselves can raise exceptions | 14:26 |
| rameshg87 | in your case you just have log statements inside | 14:27 |
| rameshg87 | so, is it really required ? | 14:27 |
| rameshg87 | if you wanted to reraise the same exception, you can just do "raise" | 14:27 |
| TheJulia | I can change it, but I think thats what I had initially and someone else recommended that I use that for re-rasing the exception | 14:28 |
| lucasagomes | jroll, anyway, thanks for looking at the patch :) | 14:29 |
| lucasagomes | hope to get some wsme core to look into it see and check if it's fine | 14:29 |
| rameshg87 | TheJulia: http://paste.openstack.org/show/197928/ | 14:30 |
| TheJulia | rameshg87: seems silly to have it there, and the current if statement lends it's self nicely to looping as opposed to what I ad before | 14:30 |
| TheJulia | yeah | 14:31 |
| rameshg87 | TheJulia: i meant something like above ^^^ | 14:31 |
| TheJulia | I was already thinking what you put in the paste | 14:31 |
| rameshg87 | okay, if we don't have a reason for using excutils.save_and_reraise_exception i recommend the above one ^^ | 14:32 |
| rameshg87 | much simpler, less line of code :) | 14:32 |
| jroll | lucasagomes: yeah, no problem, ping ryan p for real eyes :P | 14:32 |
| TheJulia | rameshg87: agreed | 14:32 |
| jroll | er, he might be pecan | 14:32 |
| rameshg87 | okay | 14:33 |
| NobodyCam | brb | 14:33 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add retry logic to _exec_ipmitool https://review.openstack.org/168120 | 14:36 |
| TheJulia | rameshg87: ^^ | 14:36 |
| *** hj-hp has joined #openstack-ironic | 14:37 | |
| rameshg87 | TheJulia: i was just preparing a paste for my another comment | 14:37 |
| rameshg87 | please hold on :) | 14:37 |
| rameshg87 | TheJulia: http://paste.openstack.org/show/197929/ | 14:38 |
| rameshg87 | TheJulia: comment on https://review.openstack.org/#/c/168120/2..3/ironic/drivers/modules/ipmitool.py L362 left side | 14:38 |
| rameshg87 | TheJulia: we can move the exception block in no ? | 14:39 |
| rameshg87 | TheJulia: or am i missing something ? | 14:39 |
| rameshg87 | TheJulia: because in both the current proposed code and the one which i proposed (paste) creates a new password file for each retry | 14:39 |
| rameshg87 | TheJulia: i mean logic is same, just a matter of protecting only relevant lines of code which can raise | 14:40 |
| * rameshg87 learned this from rloo :) | 14:41 | |
| TheJulia | rameshg87: so the question becomes do we want to leave the password on disk when we retry or do we want to hope that with: try/except works as intended | 14:41 |
| rloo | rameshg87: you did? I did? I hope I taught you well, whatever it was :D | 14:41 |
| rameshg87 | rloo: :) | 14:41 |
| NobodyCam | morning rloo :) | 14:41 |
| TheJulia | Well, hmm | 14:42 |
| * TheJulia looks and digests | 14:42 | |
| dtantsur | morning rloo, TheJulia, jroll, NobodyCam, and everyone I missed while running around the office with my visa papers | 14:42 |
| jroll | morning dtantsur :) | 14:42 |
| rloo | morning NobodyCam, hi dtantsur | 14:42 |
| rameshg87 | TheJulia: in both the cases we create password file only once per retry, right ? | 14:42 |
| rloo | dtantsur: why the visa papers? for the summit? | 14:42 |
| rameshg87 | so i assume there is no difference | 14:42 |
| NobodyCam | morning dtantsur :) | 14:43 |
| TheJulia | rameshg87: no, with password file will create it only once | 14:43 |
| dtantsur | rloo, yep. I need visa everywhere :( Canada is not the easiest one btw | 14:43 |
| * rameshg87 thinks over again | 14:43 | |
| rameshg87 | TheJulia: may be i am still not getting it | 14:43 |
| rameshg87 | TheJulia: the iteration is from L352 - L403, right ? | 14:44 |
| rloo | dtantsur: awesome that you'll be at the summit. didn't realize that it wasn't easy to get a visa though :-( | 14:44 |
| rameshg87 | TheJulia: we create password file once in each iteration, right ? | 14:44 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add maintenance check before call do_node_deploy https://review.openstack.org/170149 | 14:44 |
| dtantsur | rloo, if I'm granted a visa - yes. Looking forward to seeing all you :) | 14:45 |
| TheJulia | rameshg87: once per iterration, the with _make_password_file removes it as soon as it catches any exception | 14:45 |
| dtantsur | rloo, (though I'm NOT looking forward to 17 hours of travel :D ) | 14:45 |
| rameshg87 | TheJulia: yes, that would happen here too - http://paste.openstack.org/show/197929/ | 14:45 |
| rloo | dtantsur: 17 hours? ouch. | 14:46 |
| rameshg87 | TheJulia: as soon as exception is raised, we decide to error out or retry - in both cases, the password file is removed | 14:46 |
| rameshg87 | because we go out of the if block | 14:46 |
| dtantsur | rloo, yeah, 9:35 to Toronto, later to Vancouver. I have to avoid London as intermediate point, as I need a transit visa there... | 14:47 |
| TheJulia | Yeah, giving it a try, although I had tried almost the same thing very early on and ran into what I can only describe as weird issues | 14:47 |
| dtantsur | on a bright side, only 15 hrs on the road back \o/ | 14:47 |
| rameshg87 | TheJulia: okay, may be give it a try | 14:47 |
| rameshg87 | TheJulia: i think the code is same as yours, and should pass the tests as it is doing now | 14:47 |
| rloo | dtantsur: glad there's a bright side. | 14:47 |
| TheJulia | rameshg87: seemed to have worked with the tests I wrote, although I'll WIP it until I have a chance to test it in the environment where I can easilly reproduce it | 14:51 |
| rameshg87 | TheJulia: okay | 14:51 |
| TheJulia | rameshg87: anything else? | 14:51 |
| rameshg87 | TheJulia: https://review.openstack.org/#/c/168120/2..3/ironic/tests/drivers/test_ipmitool.py L844 (left side) | 14:51 |
| rameshg87 | TheJulia: can't we write a new test case for which we mock time.time() ? | 14:52 |
| TheJulia | nope | 14:52 |
| TheJulia | it has to be done at the class level if we want to muck with time | 14:52 |
| TheJulia | hence why time.sleep is at class level | 14:52 |
| rameshg87 | TheJulia: it can be mocked above as a decorator just above your new unittest method, no ? | 14:53 |
| TheJulia | This is actually why I ended up moving the num_tries around | 14:53 |
| rameshg87 | TheJulia: why that doesn't work ? | 14:53 |
| TheJulia | rameshg87: from what I read, that only works if it is written in python and the decorator can apply it with to soley the method. time is written in c and is core to python | 14:54 |
| TheJulia | so it can't be mucked without having some level of isolation, it can from there be done on the class level safely from what I read, but that has reprercussions across all of the tests | 14:54 |
| rameshg87 | hmm yeah, at the class level it will have | 14:55 |
| jroll | rameshg87: we solved this in ipa with def _time(): return time.time(), and use _time() from methods that need it, and mock _time() as necessary | 14:56 |
| rameshg87 | jroll: oh okay | 14:56 |
| dtantsur | ehhr? I'm pretty sure you can mock time.time | 14:56 |
| rameshg87 | TheJulia: ^^ | 14:56 |
| * dtantsur is likely to be out of context | 14:56 | |
| rameshg87 | dtantsur: even i am wondering we can mock it | 14:57 |
| jroll | dtantsur: dunno, I had trouble with it at the time :) | 14:57 |
| dtantsur | I did it a couple of times for discoverd for sure | 14:57 |
| jroll | dtantsur: I seem to remember it was confusing testr or something thuogh | 14:57 |
| rameshg87 | jroll: dtantsur: TheJulia: http://paste.openstack.org/show/197936/ | 14:57 |
| * dtantsur blames testr | 14:57 | |
| rameshg87 | it works ... | 14:57 |
| rameshg87 | now if something else prevents it, idk | 14:58 |
| TheJulia | basically the mock collides with the other running tests as jroll found | 14:58 |
| jroll | rameshg87: right, though maybe it breaks when tests are in parallel | 14:58 |
| rameshg87 | oh | 14:58 |
| rameshg87 | so how does it work if we do it at class level ? | 14:58 |
| dtantsur | the same way, I guess | 14:58 |
| jroll | I'm not sure what that means | 14:58 |
| rameshg87 | even then when tests run parallel, it should break, right ? | 14:58 |
| * dtantsur blames desire to run tests in parallel in one process | 14:59 | |
| jroll | maybe mock.patch.object(drivers.modules.agent, 'time') | 14:59 |
| TheJulia | What I read was that if you mock at the class level, like sleep is done presently, it gets isolated to just that suite of tests | 14:59 |
| rameshg87 | TheJulia: did you try it at class level ? | 14:59 |
| jroll | oh, the test class level | 14:59 |
| rameshg87 | yeah, i meant test class level :) | 14:59 |
| TheJulia | rameshg87: at class level requires changing all of the tests in the class, so at this point, I have not | 14:59 |
| rameshg87 | in any case, we can take jrolls solution | 14:59 |
| rameshg87 | :) | 14:59 |
| rameshg87 | _time() | 14:59 |
| dtantsur | how can it solve multithread problem? | 15:00 |
| dtantsur | you will still have threads accessing _time() | 15:00 |
| dtantsur | concurrently | 15:00 |
| dtantsur | what am I missing? | 15:00 |
| jroll | dtantsur: because C modules are weird | 15:00 |
| jroll | if it's pure python it's isolated AIUI | 15:01 |
| rameshg87 | dtantsur: it seems mocking time.time() is going to cause issues | 15:01 |
| jroll | 14:54:00 TheJulia | rameshg87: from what I read, that only works if it is written in python and the decorator can apply it with to soley the method. time is written in c and is core to python | 15:01 |
| dtantsur | it's not isolated, it might seem to due to GIL | 15:01 |
| openstackgerrit | Merged openstack/ironic: Add whole disk image support for iscsi_ilo using agent ramdisk https://review.openstack.org/165847 | 15:01 |
| rameshg87 | dtantsur: so using a def _time(): time.time() will prevent it | 15:01 |
| jroll | dtantsur: I find it funny that you think I know how computers work :) | 15:02 |
| dtantsur | due to GIL you're likely not to encounter conflicts... that does not means it's impossible, no? | 15:02 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: FIX Vm stuck when deploying with pxe_ssh + local boot https://review.openstack.org/170117 | 15:02 |
| jroll | I don't know, I'd have to dig in much further into mock to say for sure | 15:03 |
| * rameshg87 is confused | 15:03 | |
| rameshg87 | i hope dtantsur is saying we can mock time.time() safely | 15:03 |
| rameshg87 | and TheJulia and jroll are saying time.time() can't be mocked safely | 15:03 |
| dtantsur | no, I'm not | 15:03 |
| rameshg87 | right ? | 15:03 |
| rameshg87 | oh | 15:03 |
| * rameshg87 is surely confused | 15:04 | |
| dtantsur | lemme be honest: in multithreaded environment nothing can be mocked safely | 15:04 |
| dtantsur | unless 'mock' is doing something dirty with local thread storage | 15:04 |
| dtantsur | which I'm not sure | 15:04 |
| rameshg87 | i assume it's definitely doing | 15:05 |
| rameshg87 | we mock even builtins without any issues | 15:05 |
| rameshg87 | running mock tests parallely without issues day-in and day-out | 15:05 |
| *** hj-hp has quit IRC | 15:06 | |
| * lucasagomes wants to participate in the conversation but the backlog is just huge | 15:07 | |
| lucasagomes | anyway mocking a stdlib is not always a good idea, that's why having a guardian function such as _time() and mock that instead is encouraged | 15:08 |
| * rameshg87 wonders why everyone became silent | 15:08 | |
| NobodyCam | so as I've already started on Bug #1282836, I'm going to continue on it | 15:08 |
| openstack | bug 1282836 in Ironic "PXE driver does not check if tftpd is running" [Low,Confirmed] https://launchpad.net/bugs/1282836 | 15:08 |
| dtantsur | lucasagomes, I don't agree TBH | 15:08 |
| lucasagomes | dtantsur, other modules might be using that stdlib, mocking it can make those to misbehave | 15:09 |
| dtantsur | mocking stdlib is a _feature_ of python | 15:09 |
| rameshg87 | +1 with dtantsur | 15:09 |
| dtantsur | lucasagomes, that's price to pay. otherwise you have to write wrappers for nearly everything | 15:09 |
| *** pradipta has joined #openstack-ironic | 15:09 | |
| dtantsur | folks, reading testr docs I starting to suspect they're running in separate processes, not threads | 15:10 |
| lucasagomes | fair enough, I can see it being useful to mock stdlib but requires extra attention | 15:10 |
| lucasagomes | anyway I will read the backlog :) | 15:10 |
| dtantsur | which sounds much saner , and should not affect mocking stdlib | 15:11 |
| *** rsalevsky has left #openstack-ironic | 15:11 | |
| dtantsur | or am I wrong? | 15:11 |
| * lucasagomes no idea | 15:11 | |
| * dtantsur does not use test for discoverd | 15:11 | |
| dtantsur | * testr | 15:11 |
| rloo | NobodyCam: wrt bug #1282836 --- do you want me to assign it to you? | 15:12 |
| openstack | bug 1282836 in Ironic "PXE driver does not check if tftpd is running" [Low,Confirmed] https://launchpad.net/bugs/1282836 | 15:12 |
| NobodyCam | rloo: sure!!! | 15:12 |
| rameshg87 | TheJulia: sorry for discussion to different place | 15:13 |
| NobodyCam | I think BadCub running a little late this morning.. :) | 15:13 |
| rloo | NobodyCam: done | 15:13 |
| NobodyCam | nice | 15:13 |
| NobodyCam | TY | 15:13 |
| TheJulia | rameshg87: Nothing to be sorry about :) it happens | 15:13 |
| rloo | NobodyCam: we'll TY when you've fixed it ;) | 15:13 |
| rameshg87 | TheJulia: but i would like if we tested the part mocking time.time() somehow because it's part of control logic in that loop | 15:13 |
| rameshg87 | *somehow* :) | 15:13 |
| NobodyCam | rloo: hehehehe :) | 15:14 |
| jroll | dtantsur: basically, what I know is, I was having a hell of a time mocking time.time() once. so I made a wrapper and it just worked. | 15:14 |
| jroll | dtantsur: someone explained it to me but I've forgotten by now, this was over a year ago | 15:14 |
| rameshg87 | TheJulia: that was all from me .. | 15:14 |
| * rameshg87 will be back after dinner | 15:14 | |
| TheJulia | rameshg87: I tried on the method level and the test blew out in a really weird way, I suspect class level will work moer as expected | 15:14 |
| TheJulia | s/moer/more/ | 15:14 |
| rameshg87 | TheJulia: may be jrolls suggestion ? | 15:14 |
| TheJulia | rameshg87: that is kind of what I'm thinking | 15:15 |
| rameshg87 | TheJulia: okay | 15:15 |
| TheJulia | Anyway, I need to go get something for lunch | 15:15 |
| rameshg87 | me too going | 15:15 |
| *** rameshg87 is now known as rameshg87-dinner | 15:15 | |
| *** rsalevsky has joined #openstack-ironic | 15:15 | |
| *** rsalevsky has quit IRC | 15:15 | |
| *** alexpilotti_ has joined #openstack-ironic | 15:21 | |
| *** alexpilotti has quit IRC | 15:22 | |
| *** alexpilotti_ is now known as alexpilotti | 15:22 | |
| JoshNang | TheJulia: (when you get back) are you setting deploy_kernel and deploy_ramdisk on nodes you deploy with bifrost? i'm trying to deploy master with dhcp_provier=none and getting errors in validate() with the agent driver | 15:23 |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Enable ramdisk_error plugin by default https://review.openstack.org/170168 | 15:25 |
| TheJulia | JoshNang: (haven't actually left yet), we are setting both | 15:29 |
| JoshNang | TheJulia: ahh ok | 15:31 |
| *** hj-hp has joined #openstack-ironic | 15:35 | |
| BadCub | mornin folks. | 15:47 |
| NobodyCam | morning BadCub :) | 15:48 |
| *** kbyrne has quit IRC | 15:48 | |
| lucasagomes | BadCub, g'morning | 15:48 |
| BadCub | mornin NobodyCam lucasagomes | 15:49 |
| BadCub | Sorry I am in a bit late. The pillows were holding me hostage | 15:50 |
| NobodyCam | :) | 15:50 |
| rloo | morning BadCub. Did the dogs rescue you? ;) | 15:52 |
| BadCub | mornin rloo LOL, nope! They helped the pillows!!!! | 15:52 |
| rloo | BadCub: :D | 15:52 |
| BadCub | I think they were feeling guilty for keeping me up most of the prior two nights. | 15:54 |
| * BadCub finishes quickly updating pad on status of existing patches | 15:55 | |
| TheJulia | BadCub: But was it the pillows or the dogs that plotted it to begin with? | 15:57 |
| BadCub | mornin TheJulia Well, the dogs are always plotting, so I suspect they are the masterminds | 15:58 |
| *** enikanorov__ has joined #openstack-ironic | 15:58 | |
| *** rameshg87-dinner is now known as rameshg87 | 15:59 | |
| *** kozhukalov has joined #openstack-ironic | 15:59 | |
| BadCub | rloo: thank you for all the +2s on stuff. :-) | 16:01 |
| lucasagomes | folks I will call it a day | 16:01 |
| rloo | BadCub: yw. But I know, you want +As :) | 16:01 |
| *** enikanorov has quit IRC | 16:01 | |
| lucasagomes | still have to catch the train back home | 16:01 |
| rloo | bye lucasagomes | 16:01 |
| *** ndipanov has quit IRC | 16:01 | |
| lucasagomes | have a good night everyone! | 16:01 |
| BadCub | anyhone free to take a look at review for XML disabling is here: https://review.openstack.org/169643 - NEEDS +2/+A | 16:01 |
| NobodyCam | have a good night lucasagomes | 16:01 |
| BadCub | anyone even lol | 16:02 |
| BadCub | g'night lucasagomes | 16:02 |
| *** derekh has quit IRC | 16:02 | |
| *** trown is now known as trown|lunch | 16:03 | |
| BadCub | rloo: +2 are always good. But those -1s are good food for thought too! :-) | 16:04 |
| * rameshg87 is too sleepy to do anything | 16:04 | |
| rameshg87 | good night folks .. | 16:04 |
| rloo | night rameshg87 | 16:04 |
| BadCub | gnitght rameshg87 | 16:04 |
| *** rameshg87 has quit IRC | 16:04 | |
| BadCub | g'night even | 16:04 |
| *** lucasagomes has quit IRC | 16:07 | |
| *** igordcard_ has joined #openstack-ironic | 16:08 | |
| BadCub | Anyone have any "friends" in devstack? | 16:08 |
| *** dprince has quit IRC | 16:09 | |
| BadCub | Doesn;t seem we got any play on our ask for reviews yesterday :( | 16:09 |
| BadCub | brb need more coffee | 16:11 |
| NobodyCam | brb | 16:11 |
| openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Add ability to save logs received from the ramdisk https://review.openstack.org/170195 | 16:15 |
| *** kbyrne has joined #openstack-ironic | 16:15 | |
| dtantsur | going now, g'night | 16:18 |
| *** dtantsur is now known as dtantsur|afk | 16:18 | |
| *** jcoufal has quit IRC | 16:19 | |
| NobodyCam | night dtantsur|afk | 16:21 |
| *** jistr has quit IRC | 16:23 | |
| *** mgoddard has quit IRC | 16:25 | |
| *** spandhe has joined #openstack-ironic | 16:32 | |
| NobodyCam | brb | 16:42 |
| *** yog__ has quit IRC | 16:42 | |
| *** harlowja_away is now known as harlowja | 16:42 | |
| TheJulia | w/in 5 | 16:47 |
| *** athomas has quit IRC | 16:56 | |
| NobodyCam | off the wall question can MIT licensed be converted to arache 2 license? | 16:57 |
| jroll | NobodyCam: it depends, changing license is complicated afaik | 16:58 |
| jroll | I think all previous contributors need to agree to it | 16:58 |
| jroll | mordred seems to know things about licensing | 16:58 |
| NobodyCam | oh mordred knows! | 16:59 |
| mordred | NobodyCam: it can't be converted | 17:01 |
| *** EmilienM is now known as EmilienM|afk | 17:01 | |
| mordred | NobodyCam: but, you can incorporate MIT licensed code into an apache2 licensed thing | 17:01 |
| mordred | and you can distribute that work under the apache license | 17:01 |
| NobodyCam | oh.. ok as I read MIT is seems to just say include this header and have fun | 17:02 |
| mordred | NobodyCam: which is to say, you can slap an apache license header on it in addition to the MIT license header that is already there - since there is nothing in the MIT license that prevents you from doing so | 17:02 |
| mordred | yup | 17:02 |
| TheJulia | back to the time.time() bit. I went ahead and got it to "work" as-is, although its definitly racey, I put an assert on the number times it was called and some runs its 5, some it is 40+ | 17:02 |
| NobodyCam | w00t!!! | 17:02 |
| NobodyCam | TY mordred | 17:02 |
| BadCub | brb | 17:03 |
| *** ijw has joined #openstack-ironic | 17:04 | |
| *** penick has joined #openstack-ironic | 17:10 | |
| *** pradipta has quit IRC | 17:13 | |
| *** pelix has quit IRC | 17:16 | |
| TheJulia | and even wrapped in another method, it still ends up patching up the everything in the same class by using it with just one method, so I get counts for the other tests as well. | 17:18 |
| * NobodyCam is back | 17:20 | |
| TheJulia | welcome back | 17:21 |
| NobodyCam | :) | 17:21 |
| *** trown|lunch is now known as trown | 17:21 | |
| TheJulia | So maybe it's own testing class? | 17:22 |
| TheJulia | ^ jroll dtantsur|afk | 17:23 |
| jroll | no idea, could be | 17:24 |
| jroll | so um | 17:30 |
| jroll | https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L185 | 17:30 |
| *** spandhe has quit IRC | 17:30 | |
| jroll | that's in stdlib logging module, but not oslo_log.log | 17:31 |
| jroll | https://github.com/openstack/oslo.log/blob/master/oslo_log/log.py | 17:31 |
| jroll | somehow it's working in tests but not in my environment :| | 17:31 |
| *** alexpilotti_ has joined #openstack-ironic | 17:32 | |
| *** spandhe has joined #openstack-ironic | 17:32 | |
| BadCub | anyone free to review https://review.openstack.org/#/c/169419/ - NEEDS +2/+A ? | 17:32 |
| *** alexpilotti has quit IRC | 17:32 | |
| jroll | oh, tests must not set the level | 17:32 |
| jroll | lmao, that's completely broken. nice. | 17:33 |
| *** alexpilotti_ is now known as alexpilotti | 17:33 | |
| * jroll wonders how it worked for us before | 17:33 | |
| *** penick has quit IRC | 17:33 | |
| *** Marga_ has quit IRC | 17:34 | |
| TheJulia | heh, no dice on a separate class :( | 17:34 |
| *** andreykurilin_ has joined #openstack-ironic | 17:35 | |
| *** alexpilotti has quit IRC | 17:42 | |
| *** edcragg has quit IRC | 17:43 | |
| *** alexpilotti has joined #openstack-ironic | 17:44 | |
| *** andreykurilin_ has quit IRC | 17:49 | |
| *** andreykurilin_ has joined #openstack-ironic | 17:49 | |
| jroll | just fixed that nova bug: https://review.openstack.org/170221 | 17:50 |
| jroll | pretty bad one | 17:50 |
| *** achanda has joined #openstack-ironic | 17:53 | |
| *** tiagogomes_ has quit IRC | 17:56 | |
| JayF | I'm shilling for our devstack patch that's required to enable cleaning; so far no core reviews whatsoever on it though :( | 17:57 |
| BadCub | JayF: I am working on it :( | 17:58 |
| JayF | If there's some magic lever for getting reviews other than begging shamelessly in IRC, I'd love to know where/what it is | 17:58 |
| BadCub | talking with folks in -qa now. That is where the devstack folks hang out | 17:58 |
| JayF | BadCub: I'm there too :) | 17:58 |
| BadCub | got our +A on it | 17:59 |
| JayF | \o/ | 17:59 |
| JoshNang | woo! | 17:59 |
| JayF | https://review.openstack.org/#/c/165496/ needs some love on our end now | 17:59 |
| JayF | since we got all the deps merged | 18:00 |
| JayF | enable all the cleaning? | 18:00 |
| BadCub | yep | 18:01 |
| *** penick has joined #openstack-ironic | 18:04 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: WIP: Add a check to pxe driver for TFTP service https://review.openstack.org/169918 | 18:06 |
| JoshNang | JayF: i'm somewhat hesitant to enable by default, since i'm still trying to get it set up in our preprod and finding minor bugs | 18:07 |
| JayF | mordred: lifeless: Your suggestion of [pbr]\nwarnerrors = True in my config file doesn't appear to be working... see https://gist.github.com/jayofdoom/e852b5215f583301da52 (I suspect I might be doing something wrong?) | 18:08 |
| jlvillal | JayF: I've heard one tactic for getting reviews is go review other patches and try to find valid bugs and -1 them. | 18:08 |
| JayF | jlvillal: people like to feed that line to folks, but that's more or less unture | 18:09 |
| JayF | *untrue | 18:09 |
| JayF | It's just a way shill to get more people reviewing | 18:09 |
| jroll | what kind of tactic is that? | 18:09 |
| jlvillal | JayF: Okay. I was repeating what a core in another project told me | 18:09 |
| jroll | the general advice of "review other code" is to try to help take load off of reviews | 18:09 |
| JayF | Yeah, they're trying to get you to review things (you should) | 18:09 |
| jroll | whether that's a +1 or -1 | 18:09 |
| JayF | but it will have no direct impact on the specific patch you care about getting reviewed | 18:10 |
| JayF | just overall raise velocity making it more likely your patch gets reviewed | 18:10 |
| jlvillal | jroll: I think finding valid -1s is probably a touch more valuable then +1s though. If you are pointing out valid issues on why it should be -1. | 18:10 |
| jlvillal | jroll: It makes it easy for a core developer to see it and agree and move on quickly to the next patch. | 18:11 |
| jroll | jlvillal: I think both are valuable, though +1s have a higher false positive rate as some people will just +1 all of their co-worker's patches for instance | 18:12 |
| *** greghaynes has joined #openstack-ironic | 18:12 | |
| jlvillal | jroll: True. Hopefully that doesn't happen too often. | 18:12 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: WIP: Add a check to pxe driver for TFTP service https://review.openstack.org/169918 | 18:13 |
| jroll | it does, but you can generally tell | 18:13 |
| jroll | and I don't mean to say it's a blind +1 | 18:13 |
| jroll | but they won't pick at issues that reviewers that contribute often will | 18:13 |
| JayF | I think sometimes we (j*) are guilty of -1 in person, +1 in public | 18:13 |
| JayF | which maybe makes our stats lean more towards appearing that way, too | 18:13 |
| *** davideag_ has joined #openstack-ironic | 18:15 | |
| jroll | I'm not sure about that | 18:15 |
| *** davideagnello has quit IRC | 18:18 | |
| *** Marga_ has joined #openstack-ironic | 18:20 | |
| jlvillal | So I was working on a patch for: https://bugs.launchpad.net/bugs/1439498 | 18:22 |
| openstack | Launchpad bug 1439498 in Ironic "AgentClient throws incomprehensible error message when agent hits internal server error" [Undecided,New] | 18:22 |
| NobodyCam | morning jlvillal | 18:22 |
| jlvillal | Any suggestions on a good exception to use for failure to decode json? | 18:22 |
| jlvillal | NobodyCam: Good morning :) | 18:22 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Consistent and more valid strings for Booleans https://review.openstack.org/170230 | 18:26 |
| BadCub | brb | 18:28 |
| JayF | "AgentClient receieved invalid JSON response from agent" | 18:28 |
| JayF | or something like that? | 18:28 |
| *** EmilienM|afk is now known as EmilienM | 18:30 | |
| jroll | I'd almost rather fix the agent not to do that | 18:32 |
| jlvillal | JayF: Thanks. I was going to use IronicException with a message like that | 18:32 |
| jroll | but probably best to guard against the possiblity | 18:32 |
| jroll | you can always make a new exception :) | 18:32 |
| jlvillal | jroll: I wasn't sure what to call it? I kind of think IronicException with a message should be okay. Unless people disagree | 18:33 |
| jroll | depends what you're gonna do with it, I don't care much either way :) | 18:33 |
| JayF | jroll: we have to handle the case jlvillal is talking about anyway | 18:34 |
| JayF | although a fix in the agent to always respond with json would be good too | 18:34 |
| JayF | but we don't know what's between our http client and the agent (server) | 18:34 |
| jroll | yeah | 18:34 |
| jroll | touche | 18:34 |
| jlvillal | JayF: jroll: Do you think I should print out the request and the response? not sure if there could be secret values in the request. | 18:34 |
| jroll | there shouldn't be secrets in either | 18:35 |
| jroll | afaik | 18:35 |
| jlvillal | JayF: jroll: To help with debugging the issue. Give that detail | 18:35 |
| JayF | agent is never trusted with secrets in our current implementation | 18:35 |
| jlvillal | JayF, jroll: thanks | 18:35 |
| jroll | jlvillal: +1 | 18:35 |
| JayF | excepting if it gets driver_info which might have passwords/usernames in it depending how new of ironic you use | 18:35 |
| jroll | JayF: I believe those are stripped but not entirely sure | 18:35 |
| jroll | and since this is an ironic patch, "how new of ironic" is a moot point :) | 18:36 |
| *** Marga_ has quit IRC | 18:37 | |
| *** Marga_ has joined #openstack-ironic | 18:37 | |
| NobodyCam | brb | 18:38 |
| *** achanda has quit IRC | 18:50 | |
| *** pas-ha has quit IRC | 18:55 | |
| jroll | do we expect deploys through nova to be broken when the capabilities key does not exist? | 19:00 |
| NobodyCam | i thought that was an optional param? | 19:01 |
| jroll | yeah | 19:03 |
| jroll | still diggin | 19:03 |
| jroll | might be on my end | 19:03 |
| jroll | no, it should work, wth | 19:03 |
| *** rfchapman has quit IRC | 19:05 | |
| *** rfchapman has joined #openstack-ironic | 19:07 | |
| *** andreykurilin_ has quit IRC | 19:07 | |
| *** achanda has joined #openstack-ironic | 19:08 | |
| *** ijw has quit IRC | 19:09 | |
| *** ijw has joined #openstack-ironic | 19:10 | |
| rloo | how goes bug squash day? | 19:10 |
| NobodyCam | not our best one. my bug is taking longer then I expected | 19:11 |
| rloo | NobodyCam: bash harder! | 19:12 |
| BadCub | lol | 19:12 |
| NobodyCam | :-p | 19:13 |
| BadCub | so many bugs | 19:13 |
| BadCub | our crits and highs are in good shape though. | 19:13 |
| *** Marga_ has quit IRC | 19:17 | |
| *** Marga_ has joined #openstack-ironic | 19:18 | |
| *** rfchapman has quit IRC | 19:20 | |
| *** kozhukalov has quit IRC | 19:20 | |
| BadCub | brb | 19:22 |
| *** rfchapman has joined #openstack-ironic | 19:27 | |
| *** enikanorov__ has quit IRC | 19:27 | |
| jroll | NobodyCam: so basically -- if a flavor has extra_specs and there's no capabilities on the node, ComputeCapabilitiesFilter would fail | 19:28 |
| jroll | but extra_specs seems to be used for more than capabilities | 19:28 |
| jroll | and also this worked in the past, but not now, and I don't see much difference :/ | 19:28 |
| NobodyCam | jroll: :( humm | 19:30 |
| lifeless | JayF: re the docs thing - dunno, I've nto fiddled with the sphinx internals. pdb time? | 19:34 |
| JayF | lifeless: You say that with the confidence of a person who has ever run pdb before ever ;) | 19:35 |
| lifeless | :) | 19:36 |
| JayF | lifeless: but I did do it right? tox.ini is the right place for the setting | 19:36 |
| lifeless | oh | 19:37 |
| lifeless | no | 19:37 |
| lifeless | setup.cfg | 19:37 |
| JayF | aha | 19:37 |
| JayF | oh wonderful, that worked. Thanks | 19:37 |
| *** jerryz has quit IRC | 19:44 | |
| *** Marga_ has quit IRC | 19:46 | |
| *** Marga_ has joined #openstack-ironic | 19:47 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Error doc builds on WARN or ERROR https://review.openstack.org/170259 | 19:47 |
| JayF | lifeless: ^ thanks a bunch! | 19:47 |
| *** achanda has quit IRC | 19:56 | |
| alexpilotti | devananda: hello | 20:04 |
| NobodyCam | alexpilotti: devananda is traveling today, I don't expect him to log on today | 20:05 |
| JayF | https://review.openstack.org/#/c/169765/1 this is dirt simple, already has 2x+2, and just needs to be landed: | 20:05 |
| alexpilotti | NobodyCam: ok tx np! | 20:05 |
| jroll | JayF: done | 20:06 |
| JayF | https://review.openstack.org/#/c/168268 another simple one, but it only has 1x+2 | 20:06 |
| jroll | do we have a bug for the thing where ironic starts up too slowly? | 20:06 |
| jroll | and/or elastic recheck | 20:06 |
| jroll | I just hit it on a nova change | 20:07 |
| JayF | No, but it's documented in the whiteboard | 20:07 |
| alexpilotti | NobodyCam: we’re gonna write an OpenCompute chassis power driver for Ironic | 20:07 |
| JayF | alexpilotti: Which platform? | 20:07 |
| BadCub | There are a few things on the pad that need one more +2/+A on them | 20:07 |
| alexpilotti | NobodyCam: to show at the summit | 20:07 |
| jroll | sigh | 20:07 |
| jroll | alexpilotti: by "OpenCompute chassis", do you mean the driver talks to a chassis containing multiple boards? | 20:08 |
| NobodyCam | alexpilotti: oh cool | 20:08 |
| alexpilotti | JayF: http://www.opencompute.org/wiki/Server/SpecsAndDesigns | 20:08 |
| JayF | alexpilotti: I'm aware, I run OCP in production :) | 20:09 |
| alexpilotti | jroll: yes, basically there’s a chassis board with a REST server | 20:09 |
| JayF | alexpilotti: I'm asking which OCP platform you're talking about | 20:09 |
| JayF | Cloud Server? Open Rack? | 20:09 |
| alexpilotti | JayF: cool! It’s a MSFT Open CloudServer V2 | 20:09 |
| JayF | alexpilotti: aha, awesome. | 20:09 |
| jroll | alexpilotti: neat | 20:09 |
| JayF | alexpilotti: We run open rack ocp on quanta gear for rackspace.com/onmetal -- which uses Ironic | 20:10 |
| JayF | alexpilotti: that's exciting though -- but does CloudServer platform not support IPMI / IPMI bridging? | 20:10 |
| alexpilotti | JayF: cool, quanta is also producing those OCP servers | 20:10 |
| alexpilotti | JayF: nope | 20:10 |
| JayF | alexpilotti: cool, if you point the stuff at me I'll help review. Also if you're at ocp summit next year we should say hello | 20:11 |
| alexpilotti | JayF: they have a dedicated board for BCM (power on / off and serial output basically), which talks IPMI over serial port w the blades | 20:11 |
| JayF | alexpilotti: there's another Ironic user/contributor who's running OCP OpenRack as well | 20:11 |
| alexpilotti | JayF: come to our boot! (Cloudbase) | 20:11 |
| JayF | alexpilotti: You've met me then, for sure | 20:11 |
| alexpilotti | :-) | 20:12 |
| JayF | alexpilotti: I saw you all got cloud-init into gerrit | 20:12 |
| jroll | oh, cloudbase! | 20:12 |
| alexpilotti | We also still have to contribute the Lego reBot driver, BTW :-) | 20:12 |
| JayF | alexpilotti: if you helped make that happen, I owe you a ^5 in vancouver | 20:12 |
| alexpilotti | JayF: yep, it was a looong work: one of the conditions for merging cloud-init with cloudbase-init was to use gerrit! | 20:13 |
| JayF | alexpilotti: yeah, I was in some of that convo near your booth in Paris. Honestly part of why I personally haven't contributed more to cloud-init upstream is I spend more time onboarding to bzr than I do to the code | 20:13 |
| JayF | alexpilotti: I'd suspect as soon as the cloud-init v2 in gerrit is usable, I'll get the network json support in there and we'll work rapidly to migrate to it | 20:14 |
| alexpilotti | JayF: heh :-) | 20:14 |
| alexpilotti | nice! | 20:14 |
| alexpilotti | getting back to the power driver, we’ll send a patch ASAP as soon as it’s ready, hopefully already in the next couple of weeks! | 20:16 |
| JayF | Cool, just pop up a spec for it, there are a few good examples from last cycle. I don't think specs for L are technically open yet, but I'm eager to see it, and like I said, lmk and I'll review it | 20:17 |
| BadCub | anyone have a few to gander at https://review.openstack.org/#/c/165666/ Has one +2 on it already | 20:20 |
| rloo | jroll: we (the royal we) should probably do an elastic recheck thingy for ironic starting up slowly. | 20:22 |
| lifeless | JayF: yw | 20:22 |
| jroll | rloo: yeah, I'm going to try | 20:23 |
| rloo | thx jroll | 20:23 |
| rloo | BadCub: https://review.openstack.org/#/c/163730/ is at the bottom of IronicReviewDay | 20:28 |
| *** penick has quit IRC | 20:28 | |
| rloo | BadCub: it has two +2, but Deva had bumped it to Liberty. I think it is OK to +A but... | 20:29 |
| *** igordcard_ has quit IRC | 20:29 | |
| BadCub | rloo: looking now | 20:29 |
| BadCub | rloo: I think we might want to hold this one. devananda indicated there is a significant problem after testing it | 20:31 |
| rloo | BadCub: that problem was fixed | 20:32 |
| BadCub | hmmm | 20:32 |
| rloo | BadCub: fixed in the patch | 20:32 |
| BadCub | okay | 20:32 |
| rloo | BadCub: so I can +A? | 20:33 |
| BadCub | I think we should be good to land it if we are sure the prob is fixed :-) | 20:33 |
| *** penick has joined #openstack-ironic | 20:34 | |
| BadCub | unless there are any objections from anyone else | 20:34 |
| rloo | BadCub: I'm pretty sure it is fixed, although i checked awhile ago. but i think mrda put in a unit test for it too. | 20:34 |
| BadCub | rloo: looks to me like it was fixed as well | 20:36 |
| *** Marga_ has quit IRC | 20:36 | |
| rloo | BadCub: can you +A? | 20:36 |
| BadCub | Nope. I have no core powers :-) | 20:36 |
| *** Marga_ has joined #openstack-ironic | 20:36 | |
| * devananda waves from jetlaglandia | 20:37 | |
| NobodyCam | hey ya devananda :) | 20:37 |
| NobodyCam | how is jetlaglandia :-p | 20:37 |
| NobodyCam | I hear their interwebs aer laggie | 20:38 |
| BadCub | rloo: I put a +1 on it with a note | 20:39 |
| BadCub | devananda: should you not be in sleeplandia? | 20:39 |
| rloo | BadCub: thx. I'm just reviewing the code (yet again) to confirm. | 20:39 |
| BadCub | rloo: awesomeness | 20:39 |
| devananda | I haven't re-tested that in a bit, but yea, looks fine to me | 20:42 |
| BadCub | devananda: awesome :-) | 20:42 |
| * devananda pushes the button | 20:43 | |
| * BadCub applauds | 20:44 | |
| JayF | General update on IPA docs fun: https://review.openstack.org/#/c/170259/ this will make IPA docs builds fail if WARN or ERROR occurs generating them. This ensures no docstring errors can be introduced in new code (and I already fixed the existing ones). https://review.openstack.org/#/c/170273/ is a project-config change to add the docs jobs to IPA | 20:44 |
| devananda | JayF: good stuff | 20:44 |
| rloo | devananda beat me to the +A :) | 20:45 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Better handle when JSON is not returned by agent https://review.openstack.org/170275 | 20:45 |
| jlvillal | jroll, JayF: ^^^^ what we were talking about earlier | 20:45 |
| JayF | reviewing right meow | 20:45 |
| jlvillal | Unsure if I should have done a logError though. | 20:45 |
| jlvillal | logException? | 20:46 |
| JayF | Oh, you aren't logging that? There should def. be a log there | 20:46 |
| JayF | Or will it log on its own for an uncaught exception? | 20:47 |
| jlvillal | JayF: I'm not sure. | 20:47 |
| JoshNang | ehh, i would log there. it's a client lib, it shouldn't rely on the caller to log exceptions | 20:47 |
| jroll | jlvillal: you could run it and find out :) | 20:47 |
| jlvillal | Okay, I'll add logging | 20:48 |
| JayF | jlvillal: wait 1s | 20:48 |
| JayF | jlvillal: just posted my review, I found one other thing | 20:48 |
| jlvillal | Also deleting the TODO line | 20:49 |
| JayF | I wouldn't | 20:49 |
| JayF | still lots TODO there | 20:49 |
| JayF | w/r/t error handling | 20:49 |
| JayF | and besides, if you delete it I can no longer rib russell_h about it everytime I see it | 20:49 |
| *** achanda has joined #openstack-ironic | 20:49 | |
| russell_h | wouldn't want that | 20:50 |
| *** penick has quit IRC | 20:50 | |
| jlvillal | JayF: Okay, I will leave the TODO in | 20:50 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Check temp dir is usable for ipmitool driver https://review.openstack.org/160383 | 20:51 |
| rloo | JayF: wrt https://review.openstack.org/#/c/169162/, are you against the term 'tear down'? | 20:51 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Add check for usable tftp directory to PXE driver https://review.openstack.org/167451 | 20:51 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add retry logic to _exec_ipmitool https://review.openstack.org/168120 | 20:52 |
| *** penick has joined #openstack-ironic | 20:54 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: WIP: Add a check to pxe driver for TFTP service https://review.openstack.org/169918 | 20:54 |
| BadCub | brb | 20:55 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Better handle when JSON is not returned by agent https://review.openstack.org/170275 | 20:57 |
| jlvillal | JayF, JoshNang: I left the simplejson in this latest patch. But I can remove it if desired. I did explain my reasoning in the patch review comments. | 20:57 |
| JoshNang | jlvillal: ah i was responding over there | 20:58 |
| JoshNang | but simplejson was included in the stdlib as json as of py26 | 20:59 |
| jlvillal | JoshNang: Okay. Sounds like a good reason to just use 'import json' then | 20:59 |
| jlvillal | JoshNang: Thanks | 20:59 |
| JoshNang | jlvillal: np! requests supports wayyy more python versions than we do | 21:00 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Better handle when JSON is not returned by agent https://review.openstack.org/170275 | 21:02 |
| *** trown is now known as trown|outttypeww | 21:03 | |
| jlvillal | Did the "Toggle CI" button disappear for anyone else? | 21:04 |
| jroll | I hear that happens if you adblocked clippy | 21:04 |
| *** anish has joined #openstack-ironic | 21:04 | |
| jlvillal | jroll: :D Over on infra they say they have to 'tickle a file' to fix it | 21:05 |
| jroll | huh | 21:05 |
| jroll | ok | 21:06 |
| NobodyCam | jroll: i'm liking that new zuul page you found yesterday | 21:06 |
| jroll | NobodyCam: ikr | 21:06 |
| NobodyCam | :) | 21:06 |
| *** davideag_ has quit IRC | 21:08 | |
| *** ijw_ has joined #openstack-ironic | 21:08 | |
| JayF | rloo: tear_down is an implementation detail of ironic. We only use that term because we know the method is called tear_down | 21:08 |
| rloo | JayF: what's the correct (better) terminology. Also, cleaning happens before the node is first made available. | 21:09 |
| JayF | rloo: I've been referring to it as "cleaning" and linking that term back to the cleaning docs | 21:09 |
| JayF | rloo: I don't know why it has to be any more involved than that | 21:09 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: Add a check to pxe driver for TFTP service https://review.openstack.org/169918 | 21:09 |
| rloo | JayF: ok, I saw that comment. Just that they have 'Node Cleaning support during tear_down' section, which I'm sure you won't like. | 21:10 |
| JayF | rloo: like ilo.rst:103, where I suggested saying "* Support for out of band cleaning operations" ... that could also be written "* Adds support for out of band clean steps using iLO" or any other way | 21:10 |
| JayF | rloo: aha, yeah, if there's one I missed please tag it | 21:10 |
| rloo | JayF: will do. | 21:10 |
| JayF | rloo: I just got done writing the cleaning docs so just trying to make these have a similar use of the terms and such | 21:11 |
| * BadCub cleans up and reorganizes pad | 21:11 | |
| rloo | JayF: ++. I started looking at your cleaning doc; have some suggestions/thoughts. One day will let you know ;) | 21:11 |
| JayF | rloo: it landed, so feel free just to push a patch making it nicer or poke me about what changes need to be made and I might do it :P | 21:12 |
| JayF | although right now all my docs engines are pointed at IPA | 21:12 |
| *** jjohnson2 has quit IRC | 21:12 | |
| *** ijw has quit IRC | 21:12 | |
| *** ijw_ is now known as ijw | 21:12 | |
| *** davideagnello has joined #openstack-ironic | 21:18 | |
| NobodyCam | BadCub: 165666 +a'd | 21:18 |
| BadCub | NobodyCam: Awesome! TY :-) | 21:19 |
| BadCub | jroll: you were having a concern about landing the "enabling cleaning" patch? | 21:20 |
| JayF | BadCub: I think it was JoshNang | 21:20 |
| jroll | yeah I have no issues | 21:20 |
| JoshNang | BadCub: yeah the more i work with it, the more i'm fine enabling it | 21:20 |
| BadCub | ahh, I knew it was a "J" lol | 21:20 |
| JoshNang | one of j* :P | 21:21 |
| jroll | JoshNang: tl;dr ironic ain't broke, onmetal is? :) | 21:21 |
| * NobodyCam believes he also shares JoshNang's consern | 21:21 | |
| JoshNang | i was hitting bugs, but they're more bugs with the none dhcp driver than anything | 21:21 |
| BadCub | JoshNang: cool. I was gonna note it so folks did't push it through | 21:21 |
| JayF | I think JoshNang is just a little scared of his code running by default in so many clouds ;) | 21:21 |
| JayF | I know that feel, my friend :P | 21:21 |
| JoshNang | heh | 21:22 |
| jroll | JayF: all one of them? | 21:22 |
| BadCub | can I get a consensus on this one (165496)... Should we possibly "hold it back"? | 21:23 |
| *** Marga_ has quit IRC | 21:23 | |
| JayF | BadCub: I suggest patience in this case, unless there's a looming deadline I'm unaware of | 21:23 |
| NobodyCam | JayF: I tend to agree I really would like to see several secuessful runs before landing the enabling patch | 21:25 |
| BadCub | I know devananda wanted to land cleaning in K.... But if there are concerns about this one from the group. I think caution/patience is always a good thing myself. | 21:25 |
| jroll | I mean | 21:25 |
| NobodyCam | we have until the 9th | 21:25 |
| BadCub | we landed pretty much everything else associated | 21:25 |
| jroll | there's a config option to disable/enable it | 21:25 |
| jroll | if we don't think the code works, we shouldn't allow people to use it | 21:25 |
| JayF | If we had to vote today; I'd say land it | 21:25 |
| jroll | if we do think it works, we should flip it on | 21:25 |
| jroll | and people can decide to disable it themselves | 21:25 |
| JayF | if we don't think it works, we shouldn't have landed it in the first place | 21:26 |
| JayF | I like the way you think jroll | 21:26 |
| BadCub | good points | 21:26 |
| jroll | it's silly to have code in tree and be like "oh it probably doesn't work, you shouldn't use it" | 21:26 |
| BadCub | I just kinda wanted to have a quickie discussion cuz I noted the earlier mention :-) | 21:28 |
| *** davideagnello has quit IRC | 21:28 | |
| devananda | wait, what's wrong with cleaning? | 21:29 |
| devananda | i thought the nova patches to make nova not break when we turn cleaning on already landed | 21:29 |
| devananda | and there was devstack support going in last week ... | 21:29 |
| BadCub | devananda: nothing. jsut double checking an earlier mention of something | 21:29 |
| JoshNang | it should be good to land :) | 21:29 |
| JayF | devananda: Just I think paranoia from some downstream problems integrating upstream cleaning | 21:30 |
| JoshNang | i was having issues earlier deploying it to our preprod | 21:30 |
| JoshNang | but yeah ^ | 21:30 |
| BadCub | devananda: all dependents have merged now. We just have 165496 to land :-) | 21:30 |
| *** Marga_ has joined #openstack-ironic | 21:31 | |
| *** penick has quit IRC | 21:32 | |
| *** davideagnello has joined #openstack-ironic | 21:32 | |
| devananda | JoshNang: what's the status of the devstack stuff? | 21:32 |
| JoshNang | devananda: it merged/is merging. enabling cleaning adds on ~3 mins to tearing down the node | 21:33 |
| *** mgagne has quit IRC | 21:33 | |
| JoshNang | it is merged: https://review.openstack.org/#/c/168175/ | 21:34 |
| devananda | 3min per delete, or to the whole job? | 21:34 |
| *** jlvillal has quit IRC | 21:34 | |
| *** Ng has quit IRC | 21:34 | |
| *** adam_g has quit IRC | 21:34 | |
| devananda | neat. /me rechecks https://review.openstack.org/#/c/165496/6 | 21:34 |
| *** firl_ has joined #openstack-ironic | 21:35 | |
| *** rloo_ has joined #openstack-ironic | 21:35 | |
| *** wendar has quit IRC | 21:35 | |
| JoshNang | i think the only job impacted right now is agent_ssh | 21:35 |
| *** wendar has joined #openstack-ironic | 21:35 | |
| *** Marga_ has quit IRC | 21:36 | |
| *** morganfainberg has quit IRC | 21:37 | |
| *** morganfainberg has joined #openstack-ironic | 21:37 | |
| *** persia_ has joined #openstack-ironic | 21:37 | |
| *** persia_ has quit IRC | 21:37 | |
| *** persia_ has joined #openstack-ironic | 21:37 | |
| NobodyCam | brb | 21:38 |
| *** Ng has joined #openstack-ironic | 21:38 | |
| *** rainya has quit IRC | 21:38 | |
| *** Shalmazar has joined #openstack-ironic | 21:38 | |
| *** rloo has quit IRC | 21:38 | |
| *** krtaylor has quit IRC | 21:38 | |
| *** persia has quit IRC | 21:38 | |
| *** comstud has quit IRC | 21:38 | |
| *** Madasi has quit IRC | 21:38 | |
| *** jrist has quit IRC | 21:38 | |
| *** firl has quit IRC | 21:38 | |
| *** keekz has quit IRC | 21:38 | |
| *** firl_ is now known as firl | 21:38 | |
| *** Shalmazar is now known as Madasi | 21:39 | |
| *** keekz_ has joined #openstack-ironic | 21:39 | |
| *** comstud has joined #openstack-ironic | 21:39 | |
| *** jlvillal has joined #openstack-ironic | 21:39 | |
| *** rainya has joined #openstack-ironic | 21:39 | |
| *** adam_g has joined #openstack-ironic | 21:40 | |
| *** adam_g has joined #openstack-ironic | 21:40 | |
| *** mgagne has joined #openstack-ironic | 21:40 | |
| *** jrist has joined #openstack-ironic | 21:41 | |
| *** krtaylor has joined #openstack-ironic | 21:41 | |
| NobodyCam | TheJulia: you wipped 168120 again? | 21:44 |
| *** keekz_ is now known as keekz | 21:45 | |
| jroll | more fun nova bugs, so exciting | 21:49 |
| jroll | devananda: you'll like these | 21:49 |
| *** romcheg has quit IRC | 21:49 | |
| *** spandhe has quit IRC | 21:51 | |
| BadCub | brb | 21:52 |
| *** spandhe has joined #openstack-ironic | 21:54 | |
| openstackgerrit | Merged openstack/ironic: Add display-name option to example apache2 configuration https://review.openstack.org/169765 | 21:58 |
| openstackgerrit | Merged openstack/ironic: Fix UnicodeEncodeError issue when the language is not en_US https://review.openstack.org/168268 | 21:58 |
| *** alexpilotti has quit IRC | 21:59 | |
| jroll | devananda: check out: https://review.openstack.org/170221 and https://review.openstack.org/170299 | 21:59 |
| *** kkoski has quit IRC | 22:00 | |
| openstackgerrit | Merged openstack/ironic: New field 'name' not supported in port REST API https://review.openstack.org/163730 | 22:00 |
| *** Haomeng|2 has joined #openstack-ironic | 22:00 | |
| *** Haomeng has quit IRC | 22:03 | |
| openstackgerrit | Merged openstack/ironic: Fix is_hostname_safe for RFC compliance https://review.openstack.org/165666 | 22:13 |
| NobodyCam | nice ! | 22:14 |
| *** penick has joined #openstack-ironic | 22:15 | |
| *** oomichi_ has joined #openstack-ironic | 22:16 | |
| *** andreykurilin_ has joined #openstack-ironic | 22:18 | |
| *** Marga_ has joined #openstack-ironic | 22:21 | |
| *** penick has quit IRC | 22:27 | |
| *** hj-hp has quit IRC | 22:38 | |
| *** hj-hp has joined #openstack-ironic | 22:41 | |
| *** kkoski has joined #openstack-ironic | 22:42 | |
| BadCub | all o fhte approved list has merged :-) | 22:49 |
| *** kkoski has quit IRC | 22:49 | |
| *** romcheg has joined #openstack-ironic | 22:56 | |
| *** hj-hp has quit IRC | 22:56 | |
| *** ijw_ has joined #openstack-ironic | 23:00 | |
| *** romcheg has quit IRC | 23:01 | |
| *** ijw has quit IRC | 23:04 | |
| *** andreykurilin_ has quit IRC | 23:05 | |
| *** achanda has quit IRC | 23:08 | |
| *** yuanying has joined #openstack-ironic | 23:23 | |
| *** hj-hp has joined #openstack-ironic | 23:26 | |
| *** absubram has quit IRC | 23:27 | |
| *** hj-hp has quit IRC | 23:39 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!