BadCub | and on that delicious note.... I think I am gonna head off to dinner :) | 00:00 |
---|---|---|
aweeks | jroll: to be clear, in your comment on the rescue spec, you're suggesting that we allow people to include it in other drivers (by setting self.rescue=agent.AgentRescue())? | 00:01 |
*** BadCub is now known as BadCub_Hiding | 00:01 | |
aweeks | if so, that's already supported | 00:01 |
pshige | if you like Japanese food, the autumn summit is a good chance for you. | 00:04 |
pshige | BadCub | 00:04 |
jroll | aweeks: yeah, I realize it's supported, just to point it out | 00:09 |
aweeks | jroll: cool, will mention that | 00:09 |
*** igordcard_ has quit IRC | 00:15 | |
openstackgerrit | Alex Weeks proposed openstack/ironic-specs: Add implement-rescue-mode spec https://review.openstack.org/171878 | 00:17 |
*** mtanino has quit IRC | 00:22 | |
*** kkoski has joined #openstack-ironic | 00:22 | |
*** jmank has quit IRC | 00:22 | |
*** Sukhdev has quit IRC | 00:23 | |
*** kkoski has quit IRC | 00:23 | |
*** chlong has joined #openstack-ironic | 00:25 | |
*** kkoski has joined #openstack-ironic | 00:25 | |
*** kkoski has quit IRC | 00:25 | |
*** naohirot has joined #openstack-ironic | 00:31 | |
pshige | morning naorhirot | 00:41 |
*** saripurigopi has joined #openstack-ironic | 00:47 | |
naohirot | good morning pshige :) | 00:55 |
pshige | Hodogaya! | 01:05 |
*** jxiaobin has quit IRC | 01:12 | |
*** lazy_prince has quit IRC | 01:13 | |
*** killer_prince has joined #openstack-ironic | 01:14 | |
*** killer_prince is now known as lazy_prince | 01:14 | |
*** Marga_ has quit IRC | 01:19 | |
*** Marga_ has joined #openstack-ironic | 01:20 | |
*** mtanino has joined #openstack-ironic | 01:21 | |
*** stendulker has joined #openstack-ironic | 01:23 | |
SpamapS | jroll: FYI, now we're getting this as a fail instead: http://logs.openstack.org/37/137737/6/check-tripleo/check-tripleo-ironic-overcloud-precise-ha/68fa430/logs/seed_logs/nova-compute.txt.gz#_Apr__9_00_39_29 | 01:25 |
SpamapS | jroll: perhaps it's actually this: http://logs.openstack.org/37/137737/6/check-tripleo/check-tripleo-ironic-overcloud-precise-ha/68fa430/logs/seed_logs/ironic-api.txt.gz#_Apr__9_00_01_27 | 01:26 |
*** Haomeng|2 has joined #openstack-ironic | 01:32 | |
*** Haomeng has quit IRC | 01:34 | |
mrda | BadCub: Just FYI (after reading scrollback), if you have stuff that you'd like worked on while you North Americans sleep, and it's a Monday->Thursday yourtime, feel free to ping me in channel with review numbers etc. and I'll pick up when I check in if at all possible (especially during release periods) | 01:39 |
*** chenglch has joined #openstack-ironic | 01:44 | |
jroll | SpamapS: that seems odd | 01:45 |
jroll | that request didn't even make it to the api | 01:45 |
jroll | where is the failure in the ir-api log from? what made that request? | 01:46 |
*** stendulker has quit IRC | 01:46 | |
jroll | timestamps don't match at all with n-cpu | 01:46 |
greghaynes | we dont ntp in tripleo-ci IIRC | 01:52 |
jroll | mmm. | 01:56 |
jroll | you should do that :P | 01:56 |
greghaynes | I doubt anyone will disagree with that statement | 01:56 |
*** harlowja is now known as harlowja_away | 02:03 | |
*** davideagnello has quit IRC | 02:04 | |
*** lazy_prince has quit IRC | 02:06 | |
*** saripurigopi has quit IRC | 02:14 | |
*** meghal has quit IRC | 02:17 | |
*** Marga_ has quit IRC | 02:26 | |
*** Marga_ has joined #openstack-ironic | 02:26 | |
*** Marga_ has quit IRC | 02:31 | |
*** ramineni has joined #openstack-ironic | 02:41 | |
openstackgerrit | Tan Lin proposed openstack/ironic: Improve AMT driver doc https://review.openstack.org/169606 | 02:47 |
openstackgerrit | Yuiko Takada proposed stackforge/ironic-discoverd: Add unit tests for main.py https://review.openstack.org/171454 | 02:48 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Nit fixes for boot_mode being overwritten https://review.openstack.org/171722 | 02:56 |
openstackgerrit | Zhai, Edwin proposed openstack/ironic: Take place of metrics with meters in option https://review.openstack.org/171915 | 02:58 |
*** alex_xu has quit IRC | 03:08 | |
BadCub_Hiding | mrda: You rock! Thank you :) I usually keep everything organized on an etherpad. Right now all the goodies we have going are on: https://etherpad.openstack.org/p/IronicReviewDay | 03:19 |
BadCub_Hiding | yeah pshige ? | 03:19 |
*** rloo has quit IRC | 03:20 | |
*** Haomeng has joined #openstack-ironic | 03:22 | |
pshige | BadCub: yes | 03:23 |
*** Haomeng|2 has quit IRC | 03:25 | |
*** chenglch|2 has joined #openstack-ironic | 03:33 | |
*** chenglch has quit IRC | 03:35 | |
*** naohirot has quit IRC | 03:35 | |
*** achanda has quit IRC | 03:38 | |
*** achanda has joined #openstack-ironic | 03:43 | |
*** achanda has quit IRC | 03:45 | |
*** davideagnello has joined #openstack-ironic | 03:53 | |
*** foexle_ has joined #openstack-ironic | 03:55 | |
*** davideagnello has quit IRC | 03:57 | |
*** foexle has quit IRC | 03:58 | |
*** coolsvap|afk is now known as coolsvap | 04:00 | |
*** achanda has joined #openstack-ironic | 04:01 | |
*** saripurigopi has joined #openstack-ironic | 04:01 | |
*** naohirot has joined #openstack-ironic | 04:01 | |
*** achanda has quit IRC | 04:03 | |
*** spandhe has quit IRC | 04:11 | |
*** saripurigopi has quit IRC | 04:21 | |
*** achanda has joined #openstack-ironic | 04:23 | |
*** Haomeng|2 has joined #openstack-ironic | 04:28 | |
*** Haomeng has quit IRC | 04:31 | |
*** raginbajin has quit IRC | 04:32 | |
*** raginbajin has joined #openstack-ironic | 04:35 | |
*** achanda has quit IRC | 04:36 | |
*** achanda has joined #openstack-ironic | 04:48 | |
*** spandhe has joined #openstack-ironic | 04:54 | |
*** spandhe_ has joined #openstack-ironic | 04:57 | |
*** spandhe has quit IRC | 04:59 | |
*** spandhe_ is now known as spandhe | 04:59 | |
*** spandhe has quit IRC | 05:09 | |
*** chlong has quit IRC | 05:09 | |
*** saripurigopi has joined #openstack-ironic | 05:12 | |
*** spandhe has joined #openstack-ironic | 05:37 | |
*** jcoufal has joined #openstack-ironic | 05:59 | |
*** mtanino has quit IRC | 06:07 | |
*** alex_xu has joined #openstack-ironic | 06:40 | |
*** ramineni1 has joined #openstack-ironic | 06:42 | |
*** yog__ has joined #openstack-ironic | 06:43 | |
*** ramineni has quit IRC | 06:44 | |
*** ramineni1 has quit IRC | 06:46 | |
*** ramineni has joined #openstack-ironic | 06:46 | |
*** alex_xu has quit IRC | 06:47 | |
*** alex_xu has joined #openstack-ironic | 06:51 | |
*** pas-ha has joined #openstack-ironic | 06:59 | |
*** ukalifon1 has joined #openstack-ironic | 07:04 | |
*** jistr has joined #openstack-ironic | 07:15 | |
*** dtantsur|afk is now known as dtantsur | 07:17 | |
dtantsur | Morning Ironic! | 07:17 |
devananda | g'morning! | 07:18 |
devananda | dtantsur: https://review.openstack.org/#/c/171334/8 could use your eyes (and +2/+A) | 07:18 |
devananda | I can tag the client release once this lands | 07:18 |
devananda | which should unbreak everyone | 07:18 |
dtantsur | sure thing, morning devananda :) | 07:19 |
dtantsur | are you in Europe or just staying late? | 07:19 |
devananda | just up late | 07:19 |
devananda | couldn't sleep .... so ... | 07:19 |
*** pas-ha has quit IRC | 07:23 | |
*** pas-ha has joined #openstack-ironic | 07:25 | |
openstackgerrit | Michael Davies proposed openstack/python-ironicclient: Cache negotiated api microversion for this server https://review.openstack.org/171946 | 07:27 |
devananda | mrda: ohhai, you're awake still too :) | 07:28 |
mrda | hey devananda | 07:29 |
mrda | it's only 5pm here | 07:30 |
mrda | If you want to give me quick feedback on that review, I'd appreciate it. Just want to know if this is the kind of approach you envisaged for version caching | 07:30 |
mrda | devananda: ^^^ | 07:30 |
* devananda is already reading | 07:31 | |
*** achanda has quit IRC | 07:31 | |
dtantsur | devananda, I still get "Not Accepted". looks like you have to fix SessionClient which is actually used | 07:32 |
devananda | dtantsur: in what situation do you get that? | 07:34 |
dtantsur | devananda, running the client :) `env/bin/ironic --ironic-api-version 1.7 node-list` | 07:35 |
devananda | we dont have a 1.7 versoin ... | 07:35 |
dtantsur | I remember folks patching both places when api versions were introduced | 07:35 |
devananda | so that error is correct | 07:35 |
devananda | try 1.6 :) | 07:36 |
dtantsur | devananda, 1.6 is supported on the server | 07:36 |
mrda | ;) | 07:36 |
devananda | dtantsur: right. so you should get an error if you explicitly request a version that isn't supported | 07:36 |
dtantsur | devananda, I mean, then just abandon your patch, error is correct ;) | 07:36 |
*** rameshg87 has joined #openstack-ironic | 07:36 | |
rameshg87 | hello ironic | 07:36 |
dtantsur | devananda, yeah, but your patch is supposed to provide a meaningful error? anyway, my client does not touch code path you introduce | 07:36 |
*** rameshg87 is now known as rameshg87-away | 07:36 | |
dtantsur | rameshg87-away, o/ | 07:37 |
devananda | dtantsur: I think you're missing the point of the patch. right now, the client does not work if you point it at stable/juno, or at any version of the server *before* 1.6 | 07:37 |
devananda | literally all of our stable/juno test runs have failed because of this since monday morning | 07:37 |
*** achanda has joined #openstack-ironic | 07:37 | |
dtantsur | devananda, yes, and it won't work, because your code path is not touched (at least in my env) | 07:38 |
devananda | and tripleo-ci is (was?) broken because they're using an ironic-api service from somewhere mid cycle, which supports up to 1.4 | 07:38 |
devananda | dtantsur: that's quite odd. it works fine in my env. so how is your env resulting i na different code path? | 07:38 |
dtantsur | devananda, let's ask differently: why do we have both HttpClient and SessionClient doing the same thing differently? | 07:39 |
devananda | dtantsur: I have no idea. can we delete one of them? | 07:39 |
dtantsur | I suppose so. because right now I found out that for whatever reason SessionClient is used for me | 07:39 |
devananda | ah, I see | 07:42 |
devananda | ironicclient/v1/client.py: self.http_client = http._construct_http_client(*args, **kwargs) | 07:43 |
* mrda wanders off for dinner | 07:44 | |
dtantsur | devananda, yep and https://github.com/openstack/python-ironicclient/blob/master/ironicclient/common/http.py#L372-L392 | 07:44 |
devananda | I love that it's calling a private method in another module -- I think we should spend a bunch of time in Liberty cleaning up the client ... | 07:44 |
devananda | yea. so if there's a keystone session supplied, it will use the SessionClient | 07:44 |
dtantsur | so our client has a code path for SessionClient, I suggest you update it too | 07:44 |
devananda | whereas i'm testing without that. good catch | 07:44 |
*** achanda has quit IRC | 07:48 | |
*** oomichi has joined #openstack-ironic | 07:50 | |
openstackgerrit | Merged stackforge/ironic-discoverd: Add unit tests for main.py https://review.openstack.org/171454 | 07:57 |
*** jamielennox is now known as jamielennox|away | 08:01 | |
*** oomichi has quit IRC | 08:06 | |
*** spandhe has quit IRC | 08:06 | |
*** derekh has joined #openstack-ironic | 08:13 | |
mrda | . | 08:13 |
* mrda agrees that the client needs work | 08:13 | |
devananda | dtantsur: dont suppose you want to take a stab at the SessionClient class? | 08:20 |
dtantsur | devananda, depends on whether you want to :) | 08:22 |
devananda | I just tried refactoring the _negotiate_supported_version method to be reusable, and then realized HTTPClient and SessionClient have completely different response and connection objects | 08:22 |
devananda | so i'm scrapping that work :-/ | 08:22 |
devananda | for now i think we just need to duplicate the function in both classes | 08:22 |
devananda | eg, in HTTPClient, we have: resp.getheader('Headername'), and in SessionClient, we have: resp.headers.get('headername') | 08:23 |
devananda | it's called "resp" in both places, but it's actually a different class ... | 08:23 |
*** lucasagomes has joined #openstack-ironic | 08:24 | |
devananda | dtantsur: it's 1:30am now, think i'm going to sleep, so feel free to give this a go :) | 08:25 |
dtantsur | devananda, ah ok, I will try to finish it by your wake up :) | 08:25 |
dtantsur | g'night | 08:25 |
devananda | g'night! | 08:25 |
*** rameshg87-away is now known as rameshg87 | 08:26 | |
rameshg87 | lucasagomes: hello | 08:27 |
*** andreykurilin_ has joined #openstack-ironic | 08:27 | |
lucasagomes | rameshg87, hi there | 08:27 |
rameshg87 | lucasagomes: i was just reading through eavesdrop y'day | 08:27 |
lucasagomes | devananda, g'night | 08:27 |
rameshg87 | lucasagomes: has someone started looking at the backward-compat thing fix for localboot status change ? | 08:27 |
lucasagomes | rameshg87, I think greghaynes from tripleo have did part of it | 08:28 |
*** pradipta has joined #openstack-ironic | 08:28 | |
rameshg87 | lucasagomes: i read something like it should "hey i am new ramdisk, so i will work in the newer way of wait" | 08:28 |
rameshg87 | lucasagomes: i can pick up something if something is left | 08:28 |
lucasagomes | rameshg87, right, yeah that was one idea I've idk if the best | 08:28 |
lucasagomes | but a new ramdisk could pass some info to the pass_deploy_info to indicate that it's a new ramdisk | 08:28 |
rameshg87 | lucasagomes: yeah, just read that part .. | 08:29 |
lucasagomes | so that it doesn't try to wait for the callback if that signal is not apssed | 08:29 |
lucasagomes | but idk anyone working on that | 08:29 |
rameshg87 | lucasagomes: but one question | 08:29 |
rameshg87 | lucasagomes: localboot was introduced in kilo, right ? | 08:29 |
* lucasagomes still have to catch up with what happen after I went to sleep | 08:29 | |
lucasagomes | rameshg87, yes | 08:29 |
rameshg87 | lucasagomes: and we haven't released yet | 08:29 |
lucasagomes | rameshg87, right, yeah | 08:29 |
rameshg87 | lucasagomes: so does backward-compat really come into picture ? | 08:29 |
rameshg87 | lucasagomes: i mean are we trying to give backward compatibility for some unreleased code ? | 08:30 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Nit fixes for boot_mode being overwritten https://review.openstack.org/171722 | 08:30 |
rameshg87 | lucasagomes: sure that it went in in k3 | 08:30 |
lucasagomes | rameshg87, well when possible I would say yes, not everyone cares about the release | 08:30 |
lucasagomes | I mean rax for example uses master Ironic | 08:30 |
rameshg87 | lucasagomes: hmm..yeah..i guessed | 08:30 |
lucasagomes | if we can back backward compatibility on every merge instead of release I think it's good | 08:30 |
lucasagomes | we certainly should try to do the best thing | 08:31 |
rameshg87 | lucasagomes: okay, so backward-compat on every merge is important, is it ? | 08:31 |
lucasagomes | IMO yes | 08:31 |
rameshg87 | lucasagomes: okay..that would be the most ideal for everyone | 08:31 |
mrda | oh wow, it's possible for me to overlap with lucasagomes now that the TZ has shifted due to DST :) | 08:31 |
lucasagomes | mrda, hey buddy! | 08:31 |
*** athomas has joined #openstack-ironic | 08:31 | |
rameshg87 | mrda: dst is applicable for you ? | 08:32 |
lucasagomes | mrda, how r u? | 08:32 |
* rameshg87 checks | 08:32 | |
* lucasagomes is now UTC +1 | 08:32 | |
* rameshg87 is always UTC + 5.30 :) | 08:32 | |
lucasagomes | :-) | 08:33 |
mrda | Hmmm, I think I've at +9.5 now | 08:34 |
mrda | I'm | 08:34 |
* mrda has just finished summer, and is heading for winter and long nights | 08:36 | |
*** rpodolyaka1 has quit IRC | 08:41 | |
*** rwsu has quit IRC | 08:41 | |
tiagogomes_ | does anyone knows if Ironic needs parted with device-mapper support? | 08:42 |
*** stendulker has joined #openstack-ironic | 08:42 | |
* mrda wanders off for good now, kids time | 08:44 | |
lucasagomes | tiagogomes_, I don't think we need device-mapper support | 08:45 |
lucasagomes | we are doing basic partition using MBR | 08:45 |
tiagogomes_ | lucasagomes ok, ta | 08:45 |
*** saripurigopi has quit IRC | 08:45 | |
lucasagomes | not using lvm or any base block logical devices | 08:45 |
lucasagomes | np | 08:45 |
*** ndipanov has joined #openstack-ironic | 08:46 | |
*** edcragg has joined #openstack-ironic | 08:53 | |
*** dtantsur is now known as dtantsur|brb | 08:58 | |
lucasagomes | was the RC1 cut yesterday? | 09:09 |
*** pcaruana has joined #openstack-ironic | 09:17 | |
*** coolsvap is now known as coolsvap|afk | 09:18 | |
*** richard_maw has quit IRC | 09:22 | |
*** coolsvap|afk is now known as coolsvap | 09:24 | |
*** richard_maw has joined #openstack-ironic | 09:28 | |
*** lynxman has quit IRC | 09:43 | |
*** lynxman has joined #openstack-ironic | 09:44 | |
*** rbogorodskiy has quit IRC | 09:44 | |
*** dtantsur|brb is now known as dtantsur | 09:52 | |
dtantsur | no idea :) | 09:53 |
*** pelix has joined #openstack-ironic | 09:55 | |
*** naohirot has quit IRC | 09:55 | |
lucasagomes | https://review.openstack.org/#/c/171759/ is now open for reviews | 09:56 |
*** saripurigopi has joined #openstack-ironic | 09:57 | |
*** kalpase has joined #openstack-ironic | 10:00 | |
*** jcoufal has quit IRC | 10:04 | |
*** saripurigopi has quit IRC | 10:05 | |
*** coolsvap is now known as coolsvap|afk | 10:06 | |
*** saripurigopi has joined #openstack-ironic | 10:10 | |
*** jcoufal has joined #openstack-ironic | 10:29 | |
*** jcoufal has quit IRC | 10:36 | |
*** jamielennox|away is now known as jamielennox | 10:42 | |
*** kalpase has quit IRC | 10:52 | |
*** kalpase has joined #openstack-ironic | 10:53 | |
tiagogomes_ | hey, I got the following error "Error: The location 10241 is outside of the device /dev/sdc.\n'" after Ironic mounted the disk using iSCSI. Any ideas? | 10:57 |
dtantsur | tiagogomes_, IIRC there was a problem with partitioner; tl;dr is that you should request root_gb a bit less than your actual hard drive | 10:58 |
openstackgerrit | Dmitry Tantsur proposed openstack/python-ironicclient: Client should fall back to the lower versions if necessary https://review.openstack.org/171334 | 10:59 |
tiagogomes_ | dtantsur, will try, ta | 11:00 |
*** ramineni has quit IRC | 11:05 | |
tiagogomes_ | dtantsur, it continued to fail. My actual drive is 8GB, my root_gb is 7GB | 11:05 |
* rameshg87 goes home | 11:16 | |
*** rameshg87 has quit IRC | 11:16 | |
*** subscope has quit IRC | 11:17 | |
openstackgerrit | Dmitry Tantsur proposed openstack/python-ironicclient: Client should fall back to the lower versions if necessary https://review.openstack.org/171334 | 11:19 |
*** subscope has joined #openstack-ironic | 11:20 | |
*** andreykurilin_ has quit IRC | 11:20 | |
*** chenglch has joined #openstack-ironic | 11:21 | |
*** chenglch|2 has quit IRC | 11:24 | |
*** chenglch has quit IRC | 11:25 | |
*** lucasagomes is now known as lucas-hungry | 11:27 | |
*** kbs has quit IRC | 11:33 | |
*** stendulker has quit IRC | 11:44 | |
*** lucas-hungry is now known as lucasagomes | 11:48 | |
lucasagomes | tiagogomes_, I think that's the GiB vs GB thing | 11:49 |
lucasagomes | 8 GB == 7.45058 GiB | 11:49 |
lucasagomes | 7 GiB == 7.51619 GB | 11:50 |
lucasagomes | Ironic uses GiB as the unit size | 11:50 |
*** Haomeng has joined #openstack-ironic | 11:51 | |
* lucasagomes checks | 11:51 | |
tiagogomes_ | lucasagomes, I already sorted out, after all my hard drive was less than 8BG | 11:52 |
tiagogomes_ | Gb | 11:53 |
*** Haomeng|2 has quit IRC | 11:53 | |
*** jamielennox is now known as jamielennox|away | 11:53 | |
lucasagomes | tiagogomes_, yeah | 11:53 |
lucasagomes | ok | 11:53 |
lucasagomes | someone have seem lintan around? | 11:54 |
*** pradipta has quit IRC | 11:57 | |
tiagogomes_ | mm, I used disk image for creating a ubuntu image to deploy with ironic. Anyone knows the login credentials? | 12:05 |
*** dprince has joined #openstack-ironic | 12:07 | |
dtantsur | tiagogomes_, no idea. I suppose you should have used keypair instead | 12:08 |
dtantsur | tiagogomes_, see middle part of http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack for details | 12:09 |
dtantsur | lucasagomes, hey, could you review https://review.openstack.org/#/c/171211/ ? Imre is still out and I'd like to start pointing people at the "Troubleshooting" section | 12:10 |
TheJulia | tiagogomes_: I think you have to use a dib element like stackuser or provide it a configdrive | 12:11 |
tiagogomes_ | mm, I am not using nova | 12:11 |
dtantsur | then ++ for stackuser, I guess... | 12:11 |
lucasagomes | dtantsur, oh I will check it out, sorry i siad i would do it yesterday but I got busy into something | 12:11 |
lucasagomes | 1 sec will check it | 12:11 |
TheJulia | tiagogomes_: or... create your own dib element to burn in whatever you want :) | 12:11 |
dtantsur | lucasagomes, np, take your time :) | 12:11 |
dtantsur | TheJulia, ... because bash scripting is the best of fun! | 12:12 |
dtantsur | :D | 12:12 |
lucasagomes | tiagogomes_, no idea if it does create any user, I think there's a "stack" element that creates a stack user in the image | 12:12 |
dtantsur | TheJulia, morning also :) | 12:12 |
* lucasagomes vaguely remembers that, not sure if it does exist anymore | 12:12 | |
dtantsur | tiagogomes_, lucasagomes, https://github.com/openstack/tripleo-image-elements/tree/master/elements/stackuser | 12:13 |
dtantsur | note that it's in tripleo-image-elements, not DIB itself | 12:13 |
*** ukalifon1 has quit IRC | 12:14 | |
*** mtanino has joined #openstack-ironic | 12:18 | |
*** kbs has joined #openstack-ironic | 12:19 | |
tiagogomes_ | so I need to rebuild the image | 12:23 |
lucasagomes | tiagogomes_, yeah, well what you can do is mount the image in a loop device | 12:23 |
lucasagomes | chroot in it and create the user | 12:23 |
lucasagomes | or inject a key etc | 12:24 |
tiagogomes_ | ok | 12:24 |
tiagogomes_ | I used the ssh_pxe driver, but the boot order is still pxe first | 12:25 |
tiagogomes_ | shouldn't be local disk first? | 12:25 |
*** Haomeng|2 has joined #openstack-ironic | 12:27 | |
*** Haomeng has quit IRC | 12:30 | |
*** ramineni has joined #openstack-ironic | 12:37 | |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add support for 'baremetal show' command https://review.openstack.org/171739 | 12:38 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Introduce openstackclient plugin https://review.openstack.org/171672 | 12:38 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implement the rest of the args for baremetal list https://review.openstack.org/171699 | 12:38 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implement baremetal delete command https://review.openstack.org/171751 | 12:38 |
openstackgerrit | Julia Kreger proposed openstack/ironic: Follow-up to "Add retry logic to _exec_ipmitool" https://review.openstack.org/171771 | 12:56 |
openstackgerrit | Victor Sergeyev proposed openstack/ironic: Cleanup DHCPFactory._dhcp_provider after tests https://review.openstack.org/172036 | 12:56 |
*** athomas has quit IRC | 12:57 | |
*** mtanino has quit IRC | 13:01 | |
*** rameshg87 has joined #openstack-ironic | 13:02 | |
*** athomas has joined #openstack-ironic | 13:04 | |
*** romcheg has joined #openstack-ironic | 13:06 | |
*** lifeless has quit IRC | 13:07 | |
*** trown|outttypeww is now known as trown | 13:07 | |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add support for 'baremetal show' command https://review.openstack.org/171739 | 13:09 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Introduce openstackclient plugin https://review.openstack.org/171672 | 13:09 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implement the rest of the args for baremetal list https://review.openstack.org/171699 | 13:09 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implement baremetal delete command https://review.openstack.org/171751 | 13:09 |
* lucasagomes submits his first patch to neutron https://review.openstack.org/172040 | 13:12 | |
pshige | Lucasagomes: cool ! | 13:15 |
lucasagomes | 3 LOC :-) | 13:15 |
*** romcheg has quit IRC | 13:16 | |
*** rloo has joined #openstack-ironic | 13:16 | |
*** romcheg has joined #openstack-ironic | 13:19 | |
openstackgerrit | Victor Sergeyev proposed openstack/ironic: Stop eventlet.greenthread.sleep mock patch https://review.openstack.org/172047 | 13:21 |
pshige | 1 LOC is enough to get power! :-) | 13:22 |
openstackgerrit | Victor Sergeyev proposed openstack/ironic: Cleanup DHCPFactory._dhcp_provider after tests https://review.openstack.org/172036 | 13:25 |
tiagogomes_ | I am seeing Calling http://192.168.199.12/latest/meta-data/instance-id failed: bad status code | 13:30 |
tiagogomes_ | what does this means? | 13:30 |
openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Delay failure from pre-processing hooks https://review.openstack.org/172051 | 13:32 |
tiagogomes_ | this is when the deployed image boots (I think) | 13:32 |
dtantsur | I believe it's os-cloud-config trying to reach out to the metadata server (which you might or might not have), but I'm not aware of the details | 13:39 |
jroll | morning everyone :) | 13:39 |
jroll | rameshg87: lucasagomes dtantsur this is the localboot / whole disk image fix: https://review.openstack.org/#/c/171767/ | 13:40 |
jroll | s/fix/hack/ | 13:40 |
dtantsur | jroll, morning | 13:40 |
dtantsur | oh I like the s/fix/hack/ part :D | 13:40 |
jroll | it is a hack :) | 13:42 |
rameshg87 | jroll: hey morning | 13:42 |
tiagogomes_ | I already asked this but the provision_state of the node which I deployed is 'on'. But the VM (I am using pxe_ssh driver) is still configure to boot from PXE | 13:42 |
dtantsur | oh yeah, it looks like a hack... I suppose it should work though :) | 13:42 |
rameshg87 | morning everyone :) | 13:42 |
tiagogomes_ | Is this normal or something failed? Does the deployed image always needs a PXE server? | 13:43 |
rameshg87 | lucasagomes: did shoot this down first ? lucasagomes https://review.openstack.org/#/c/171767/3/ironic/drivers/modules/iscsi_deploy.py ?? :) | 13:43 |
dtantsur | rameshg87, morning. it's funny that I say good morning to you both in my morning and in my evening :D | 13:43 |
tiagogomes_ | sorry, provision_state is 'active' | 13:43 |
rameshg87 | dtantsur: yeah it is :) good evening btw | 13:43 |
dtantsur | good afternoon rather... you don't sleep a lot, do you? :) | 13:44 |
*** saripurigopi has quit IRC | 13:44 | |
jroll | dtantsur: I tested it in devstack so it should work amirite | 13:44 |
tiagogomes_ | If I set it to boot from the hard disk, it doesn't boot :( | 13:44 |
jroll | tiagogomes_: yes, the pxe driver boots the instance from pxe | 13:45 |
tiagogomes_ | jroll even after the deployment been made? | 13:45 |
jroll | yes | 13:45 |
jroll | tiagogomes_: there's a way to set the node up to boot from disk, I forget offhand what it is | 13:45 |
jroll | lucasagomes: ^ ?' | 13:45 |
tiagogomes_ | so it retrieves the kernel and initramfs using tftp, but uses the local disk as rootfs? | 13:46 |
NobodyCam | good morning Ironic | 13:46 |
dtantsur | NobodyCam, morning | 13:46 |
NobodyCam | morning dtantsur :) | 13:46 |
jroll | tiagogomes_: correct | 13:46 |
jroll | tiagogomes_: there's a localboot option that can be set, but it must be set before deploy | 13:46 |
NobodyCam | morning jroll and tiagogomes_ | 13:46 |
jroll | heya NobodyCam :) | 13:47 |
NobodyCam | :) | 13:47 |
tiagogomes_ | morning NobodyCam | 13:47 |
NobodyCam | :) | 13:48 |
openstackgerrit | Victor Sergeyev proposed openstack/ironic: Use mock patch decorator for eventlet.greenthread.sleep https://review.openstack.org/172047 | 13:48 |
*** jcoufal has joined #openstack-ironic | 13:48 | |
rameshg87 | jroll: +2 with me :) | 13:49 |
tiagogomes_ | jroll ok, ta | 13:49 |
jroll | woot | 13:49 |
rameshg87 | dtantsur: it's like 7pm here | 13:49 |
jroll | np tiagogomes_ :) | 13:49 |
rameshg87 | dtantsur: what's your timezone ? | 13:49 |
dtantsur | rameshg87, UTC+2 (with DST) | 13:49 |
dtantsur | usually UTC+1 | 13:49 |
rameshg87 | okay | 13:50 |
rameshg87 | dtantsur: so our timezones are actually more closer | 13:50 |
NobodyCam | morning rameshg87 :) | 13:50 |
rameshg87 | we don't have dst and i am always utc + 5.30 :) | 13:50 |
rameshg87 | morning NobodyCam | 13:50 |
dtantsur | rameshg87, oh not having DST is awesome! | 13:50 |
rameshg87 | yeah more closer to the equator :) | 13:52 |
*** kkoski has joined #openstack-ironic | 13:52 | |
*** openstackgerrit has quit IRC | 13:53 | |
*** openstackgerrit has joined #openstack-ironic | 13:53 | |
rameshg87 | jroll: i saw on irc yesterday | 13:53 |
rameshg87 | jroll: that we were discussing about the backward-compat thing on the localboot status report thing | 13:54 |
TheJulia | quick question if anyone knows without me having to dig into the api code, when in maintenance mode, is an api client prohibited from making changes to endpoints? | 13:54 |
rameshg87 | jroll: we wanted ramdisk to say to ironic that "i am a newer ramdisk and hence treat me like a newer ramdisk" kind of fix | 13:55 |
rameshg87 | jroll: are we planning to do that ? | 13:55 |
jroll | TheJulia: do you mean making changes to the node? node-update etc should work, state transitions probably not | 13:55 |
rameshg87 | jroll: or rather are you planning ? :) | 13:55 |
jroll | rameshg87: yes... /me finds patch | 13:55 |
*** rameshg87 is now known as rameshg87-brb | 13:56 | |
jroll | rameshg87-brb: https://review.openstack.org/#/c/171743/ | 13:57 |
* lucasagomes reads | 13:57 | |
* lucasagomes was afk | 13:57 | |
*** ramineni has quit IRC | 13:57 | |
TheJulia | jroll: okay, that is what I was thinking, thanks! | 13:57 |
TheJulia | thinking/hoping | 13:57 |
jroll | TheJulia: np :) | 13:58 |
lucasagomes | rameshg87-brb, you mean to give that a shoot? | 13:58 |
lucasagomes | tiagogomes_, http://docs.openstack.org/developer/ironic/deploy/install-guide.html#local-boot-with-partition-images | 14:00 |
lucasagomes | there's an explanation about how to do with and without nova there | 14:01 |
lucasagomes | I think ur using it without nova right? | 14:01 |
tiagogomes_ | lucasagomes, yes, without nova, but with Ironic stable/juno | 14:04 |
lucasagomes | tiagogomes_, oh... local boot was introduced in K | 14:04 |
*** jerryz has joined #openstack-ironic | 14:04 | |
NobodyCam | mornign lucasagomes and TheJulia | 14:04 |
lucasagomes | I think in Juno, if u want to have local boot you may need to use the agent driver | 14:04 |
lucasagomes | jroll, ^ | 14:04 |
tiagogomes_ | lucasagomes no worries, I just wanted to be sure that the deployment succeed :) | 14:05 |
lucasagomes | tiagogomes_, with the agent driver you can deploy a full disk image which contains a bootloader | 14:05 |
*** BadCub_Hiding is now known as BadCub | 14:06 | |
TheJulia | NobodyCam: good morning | 14:06 |
*** rameshg87-brb is now known as rameshg87 | 14:06 | |
BadCub | Morning Folks | 14:06 |
NobodyCam | morning BadCub :) | 14:06 |
NobodyCam | TheJulia: :) | 14:06 |
rameshg87 | lucasagomes: initially you were against it no ? but may be we can fix it later, what do you think about that ? | 14:06 |
rameshg87 | jroll: actually i was assuming backward-compat was broken other way round also | 14:08 |
rameshg87 | jroll: if someone was using older dib and newer ironic | 14:08 |
rameshg87 | jroll: right now https://review.openstack.org/#/c/171743/2 solves issue with newer ramdisk and older ironic | 14:09 |
*** mtanino has joined #openstack-ironic | 14:09 | |
rameshg87 | jroll: but what if they had older ramdisk and newer ironic ? the problem there is ironic will goto wait-call-back expecting ramdisk will post back, but it will never do. do we want to fix that ? | 14:10 |
*** romcheg has left #openstack-ironic | 14:11 | |
BadCub | jroll: looks like we are almost approved on ^ Just needs a +A :p | 14:11 |
*** romcheg has joined #openstack-ironic | 14:11 | |
*** rameshg871 has joined #openstack-ironic | 14:11 | |
lucasagomes | rameshg87, right. We could solve it 2 ways... or pass both boot_option and is_whole_disk_image info via kernel cmdline | 14:14 |
*** rameshg87 has quit IRC | 14:14 | |
lucasagomes | to the ramdisk | 14:14 |
lucasagomes | or fool it saying it's netboot so it doesn't try to install the bootloader | 14:14 |
jroll | lucasagomes: you are correct | 14:14 |
openstackgerrit | Steve Martinelli proposed openstack/python-ironicclient: Upgrade hacking to latest release https://review.openstack.org/172072 | 14:15 |
lucasagomes | problem with the former is that it will depend on some change in DIB | 14:15 |
lucasagomes | and the second doesn't | 14:15 |
jroll | (with the juno thing) | 14:15 |
lucasagomes | jroll, cool thanks | 14:15 |
jroll | rameshg871: lucasagomes, right my patch does the latter | 14:15 |
*** ramineni has joined #openstack-ironic | 14:15 | |
rameshg871 | jroll: okay | 14:16 |
*** saripurigopi has joined #openstack-ironic | 14:16 | |
*** pcaruana has quit IRC | 14:17 | |
*** lifeless has joined #openstack-ironic | 14:18 | |
*** rameshg871 is now known as rameshg87 | 14:20 | |
lucasagomes | rameshg87, have you tested jroll's patch? | 14:21 |
openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: README: Troubleshooting: mention DHCP logs and tcpdump https://review.openstack.org/172077 | 14:21 |
jroll | I ran it in devstack, if that helps | 14:22 |
jroll | but not entirely sure I did it right | 14:22 |
jroll | I managed to boot a whole disk image with pxe_ssh driver | 14:22 |
jroll | ¯\_(ツ)_/¯ | 14:22 |
rameshg87 | lucasagomes: no i didn't. i can try it once if you are not planning ... | 14:23 |
dtantsur | folks, review and testing is highly requested for https://review.openstack.org/#/c/171334/ that will allow us to stop breaking people once released :) | 14:24 |
lucasagomes | rameshg87, if u can that will help, my env is a bit messed :-( | 14:24 |
* lucasagomes was dealing with some neutron ipxe problems | 14:25 | |
* lucasagomes will rebuild it | 14:25 | |
jroll | can we kill DIB support yet | 14:25 |
*** jcoufal has quit IRC | 14:26 | |
rameshg87 | lucasagomes: yeah i will | 14:26 |
lucasagomes | jroll, heh that's the plan :-) | 14:27 |
lucasagomes | I mean not DIB | 14:27 |
lucasagomes | but the bash ramdisk | 14:27 |
rameshg87 | lucasagomes: will update in half an hour | 14:27 |
lucasagomes | thanks rameshg87 | 14:27 |
NobodyCam | anyone seen this error before? http://logs.openstack.org/34/171334/10/check/gate-tempest-dsvm-neutron-src-python-ironicclient/be18c2e/console.html#_2015-04-09_13_15_17_713 | 14:27 |
*** jcoufal has joined #openstack-ironic | 14:27 | |
jroll | lucasagomes: well yeah, bash ramdisk | 14:27 |
jroll | NobodyCam: looks like the job timed out | 14:28 |
lucasagomes | NobodyCam, nop :/ | 14:28 |
NobodyCam | that the slow node thing? | 14:28 |
*** jcoufal has quit IRC | 14:29 | |
lucasagomes | I think the slow thing is https://review.openstack.org/#/c/171313/ | 14:29 |
lucasagomes | jroll, NobodyCam rameshg87 when you guys have a time mind taking a look at https://review.openstack.org/#/c/171759/ | 14:30 |
jroll | NobodyCam: no, the slowness thing times out during devstack setup thing... it isn't about slow gate nodes, it's about slow devstack | 14:30 |
rameshg87 | lucasagomes: ack.. | 14:30 |
jroll | lucasagomes: why do we need backwards compat? | 14:31 |
BadCub | we have 3 +2s on https://review.openstack.org/#/c/171767/ someone want to slap a +A on it? | 14:31 |
lucasagomes | jroll, cause iPXE landed in juno | 14:31 |
lucasagomes | jroll, and the boot.ipxe is static, so if they have it working with their juno version | 14:31 |
lucasagomes | looking at hexraw, we should not break it | 14:31 |
jroll | oh I see | 14:31 |
NobodyCam | oh wait this isn't even ironic nova appears to be using nova.virt.libvirt.driver | 14:31 |
lucasagomes | new nodes should still be able to be managed by the old boot.ipxe script | 14:32 |
rameshg87 | BadCub: jroll: do you folks want to wait for half an hour for https://review.openstack.org/#/c/171767/ ? | 14:32 |
jroll | lucasagomes: right, didn't realize boot.ipxe wouldn't get laid down again | 14:32 |
rameshg87 | BadCub: jroll: i am just trying it out | 14:32 |
*** achanda has joined #openstack-ironic | 14:32 | |
jroll | rameshg87: I don't care as long as it makes rc1 | 14:32 |
BadCub | jroll: ++ on ^ | 14:33 |
BadCub | we gots a nice little list of stuff we need to get landed for rc1 now. :-) Good thing is nothing left on the to-do list | 14:34 |
lucasagomes | BadCub, :-) good morning | 14:34 |
BadCub | lucasagomes: morning bud :-) | 14:35 |
BadCub | rameshg87: yeah, I am good with waiting a few :-) | 14:37 |
*** achanda has quit IRC | 14:41 | |
* BadCub needs more coffee | 14:41 | |
*** ramineni1 has joined #openstack-ironic | 14:43 | |
jroll | lucasagomes: I'm still not sure I get this hexraw compat thing, does this patch change what is sent to neutron? | 14:43 |
openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Doublecheck node provision state on receiving data from ramdisk https://review.openstack.org/172094 | 14:43 |
lucasagomes | jroll, no | 14:44 |
lucasagomes | jroll, so for neutron we give a URL pointing to the boot.ipxe script | 14:44 |
lucasagomes | in the ipxe script we expand some variables like ${mac} for the macaddress | 14:44 |
*** ramineni has quit IRC | 14:44 | |
lucasagomes | in order to avoid having a file names with ':' we were using ${mac:hexraw} so it would format the mac to remove the delimiters | 14:45 |
lucasagomes | like 112233445566 | 14:45 |
lucasagomes | but hexraw is not a supported type on older versions of ipxe | 14:45 |
lucasagomes | where hexhyp is, which format the mac to have a '-' delimiter | 14:45 |
lucasagomes | 11-22-33-44-55 | 14:45 |
jroll | sure | 14:45 |
jroll | but doesn't boot.ipxe get generated for every deploy? | 14:45 |
lucasagomes | so I just changed the type, and I create the PXE config file with a '-' now | 14:46 |
* lucasagomes checks, I thought we copied it only once (in case it was not in the http root dir already) | 14:46 | |
jroll | lucasagomes: it's per-node, though | 14:47 |
jroll | right? | 14:47 |
lucasagomes | yes | 14:47 |
lucasagomes | it's per node | 14:47 |
jroll | so any old nodes, the file will be left alone | 14:47 |
*** ramineni has joined #openstack-ironic | 14:47 | |
jroll | any new ones it will be hexhyp style | 14:47 |
rameshg87 | shall we +A https://review.openstack.org/#/c/171767/ ? | 14:47 |
jroll | rameshg87: does it work? :) | 14:47 |
lucasagomes | jroll, oh :-( apparently we copy it everytime prepare() is called | 14:47 |
*** jerryz has quit IRC | 14:48 | |
lucasagomes | https://github.com/openstack/ironic/blob/a45d4797d2246e31c482f3e1713c883d86807f02/ironic/drivers/modules/pxe.py#L443-L445 | 14:48 |
jroll | lucasagomes: right, because it's per node | 14:48 |
lucasagomes | hmmmmm | 14:48 |
lucasagomes | yeah | 14:48 |
lucasagomes | wonders if we need some other way to do it | 14:48 |
jroll | so I don't think we need the backwards compat | 14:48 |
rameshg87 | jroll: yeah works for me :) | 14:48 |
lucasagomes | perhaps should we just go and change the type | 14:48 |
lucasagomes | yea | 14:48 |
jroll | it's straightforward to test if it works, though it isn't clear to me what action would break it | 14:48 |
lucasagomes | jroll, I will put a new patch-set up | 14:48 |
lucasagomes | yeah it seems correct | 14:49 |
jroll | awesome | 14:49 |
* jroll leaves a review so he remembers to come back | 14:49 | |
lucasagomes | jroll, I was wondering like. A node has X nodes deployed and an old boot.ipxe | 14:49 |
lucasagomes | jroll, oh sorry | 14:49 |
lucasagomes | it's not per node | 14:49 |
lucasagomes | it's one per conductor | 14:49 |
lucasagomes | jroll, we use the same script for all nodes | 14:49 |
*** ramineni1 has quit IRC | 14:49 | |
jroll | oh? | 14:50 |
lucasagomes | 1 per conductor | 14:50 |
jroll | wait when does the mac get in there then? | 14:50 |
lucasagomes | jroll, the mac is a link to the specific configuration of that node | 14:50 |
lucasagomes | and the boot.ipxe uses the mac address to chainload from boot.ipxe to the specific configuration | 14:51 |
jroll | OH | 14:51 |
jroll | wait... when does the mac get there though? | 14:51 |
jroll | if it's one per conductor | 14:51 |
jroll | when is it expanded? | 14:51 |
lucasagomes | so the request comes from boot.ipxe, the mac get expanded and it chainloads into the specific mac configuration | 14:51 |
BadCub | brb | 14:51 |
lucasagomes | iPXE expand the ${mac} var | 14:51 |
jroll | aha | 14:51 |
lucasagomes | the mac get's there when the node is deployed | 14:52 |
jroll | +A then | 14:52 |
lucasagomes | https://github.com/openstack/ironic/blob/a45d4797d2246e31c482f3e1713c883d86807f02/ironic/drivers/modules/pxe.py#L172 | 14:52 |
lucasagomes | jroll, I want to change it all making it dynamic | 14:52 |
lucasagomes | but only in L :/ | 14:52 |
jroll | yeah | 14:53 |
lucasagomes | so instead of passing the boot.ipxe script, ipxe do a GET on a endpoint in the ironic api passing the mac | 14:53 |
lucasagomes | and we just returns whatever the node has to boot | 14:53 |
*** jcoufal has joined #openstack-ironic | 14:54 | |
jroll | right | 14:54 |
jroll | lucasagomes: I've also thought about making agent config dynamic that way | 14:55 |
jroll | cloud-config can come from a URL | 14:55 |
lucasagomes | that would be awesome | 14:55 |
lucasagomes | there's some problem with wsme right now doing that | 14:55 |
lucasagomes | I have a patch up but few reviews :-( (no cores) | 14:55 |
jroll | so you don't have to rebuild the container to re-configure it | 14:55 |
jroll | yeah | 14:55 |
jroll | though I don't know if this needs to be an attachment | 14:55 |
lucasagomes | but u need a raw answer no? | 14:55 |
lucasagomes | like not serialized | 14:56 |
jroll | oh, right | 14:56 |
lucasagomes | if you want to return type text with wsme | 14:56 |
jroll | idk, maybe it can handle json? | 14:56 |
lucasagomes | it will do like "string" | 14:56 |
jroll | yeah, I remember your patch | 14:56 |
lucasagomes | right, idk about cloud-config | 14:56 |
lucasagomes | ipxe can't | 14:56 |
lucasagomes | AFAIK | 14:56 |
jroll | doesn't look like it | 14:57 |
lucasagomes | yeah it expects a ipxe script to be server, like a static file | 14:57 |
lucasagomes | served* | 14:57 |
lucasagomes | anyway I will investigate more in L | 14:57 |
jroll | yeah, cloud-config expects yaml, so I think we'll need the raw response thing | 14:58 |
lucasagomes | jroll, well you can create a yaml custom type for wsme I suspect | 14:58 |
lucasagomes | and return that | 14:58 |
lucasagomes | tho it's a bit odd from our api pov | 14:58 |
lucasagomes | it's a json api | 14:58 |
jroll | meh, it needs "#cloud-config" in the header etc | 14:59 |
jroll | not worth it | 14:59 |
lucasagomes | oh | 14:59 |
lucasagomes | yeah :/ | 14:59 |
lucasagomes | jroll, if that makes u happy I found a way to do it without that patch | 14:59 |
lucasagomes | but it's a bit hacky | 14:59 |
jroll | lucasagomes: I don't have time to work on it any time soon :) | 14:59 |
lucasagomes | we have to edit the func._wsme_definition object | 14:59 |
lucasagomes | func._wsme_definition.return_type = None for e.g | 15:00 |
lucasagomes | yeah | 15:00 |
jroll | yeah | 15:00 |
*** romcheg has quit IRC | 15:01 | |
JayF | dtantsur: put a comment on the open specs for liberty -1 | 15:02 |
*** achanda has joined #openstack-ironic | 15:02 | |
JayF | dtantsur: ^ if you'll look at it and respond that'd be awesome; I'm out today but will check back if there's a change needed there | 15:03 |
dtantsur | JayF, IIRC putting specs to backlog is what we planned back then when we introduced specs. | 15:03 |
JayF | dtantsur: a backlog spec is a specific thing that doesn't include implementation details | 15:04 |
JayF | and those likely can change across releases anyway | 15:04 |
dtantsur | not necessary IMO | 15:04 |
jroll | I mean, if we approved them, they are clearly something we want to do | 15:04 |
jroll | whether it has implementation details or not | 15:04 |
JayF | I mean, I think it waters down the idea of the backlog | 15:04 |
JayF | if it also becomes the spec graveyard | 15:04 |
dtantsur | in some sense it already is | 15:05 |
jroll | "shit we want to do but don't have time" | 15:05 |
dtantsur | if people just put it there and forget about them | 15:05 |
JayF | imo putting them in a separate place makes sense, and I'd hope that dir dies from attrition | 15:05 |
JayF | because everyone pulls their k spec out and ports it to l | 15:05 |
JayF | so we can do it for l | 15:05 |
jroll | I think that applies to both the "true" backlog and unimplemented approved specs | 15:05 |
jroll | sure | 15:05 |
jroll | people can pull them out of the backlog | 15:05 |
dtantsur | that's the same as for backlog: we hope that they will be implemented | 15:05 |
JayF | jroll: except we actually unit test and validate fields and such on the backlog | 15:05 |
JayF | jroll: and that doesn't include anythign but the first two basic headlines | 15:06 |
*** jcoufal has quit IRC | 15:06 | |
jroll | I guess I don't have a strong opinion either way; I tend to agree with dtantsur | 15:06 |
jroll | JayF: we fail tests for extra headers in the backlog? | 15:06 |
dtantsur | I'd also wait for devananda to weigh in | 15:06 |
JayF | dtantsur: backlog is "this is a good idea that we haven't fully hashed out yet". kilo-archive is "We wanted to do this but didn't succeed for $reasons" | 15:06 |
jroll | JayF: you made that distinction in this patch | 15:07 |
jroll | I disagree with that distinction. | 15:07 |
* rameshg87 calls it a day | 15:07 | |
JayF | dtantsur: I'll clearly go along with whatever devananda thinks, but I don't think kilo specs should be lumped in | 15:07 |
rameshg87 | good night folks | 15:07 |
dtantsur | for me difference is vague actually. things in backlog are "We wanted to do this but didn't propose it fully for $reasons" | 15:07 |
rameshg87 | see you tomorrow | 15:07 |
BadCub | g'night rameshg87 | 15:07 |
dtantsur | rameshg87, cu | 15:07 |
jroll | night rameshg87 :) | 15:07 |
NobodyCam | night rameshg87 | 15:07 |
*** rameshg87 has quit IRC | 15:07 | |
JayF | jroll: to clarify; devananda made the distinction in IRC and I reflected it at his request in the doc :) | 15:07 |
jroll | -.- | 15:07 |
JayF | jroll: I had all kilo specs together before he asked me to put them somewhere else | 15:07 |
JayF | *shrug* | 15:08 |
jroll | devananda should put those things on reviews so other people know what happened | 15:08 |
dtantsur | ++ | 15:08 |
JayF | I don't think this is something we'll hash out by talking though. If some executive decision is made on IRC; please put it in the review and I'll keep an eye out | 15:08 |
jroll | JayF: to be clear, did he make the backlog/kilo-archive distinction, or the implemented/not-implemented distinction | 15:08 |
JayF | jroll: ^ drop me a text if that patch ends up needing a change before it can land | 15:08 |
jroll | JayF: or I can just fix it :) | 15:08 |
jroll | go play | 15:09 |
JayF | jroll: or do that; but I'm willing to as well. I opened the pandora's box :P | 15:09 |
* JayF & | 15:09 | |
*** achanda has quit IRC | 15:11 | |
*** jistr is now known as jistr|mtg | 15:15 | |
* BadCub reads scroll back | 15:15 | |
BadCub | what is it everyone wants to see on ^^? | 15:19 |
*** kozhukalov has joined #openstack-ironic | 15:20 | |
NobodyCam | anyone encountered this iscsi error before... I haven't seem it but wanted to see if others have: http://paste.openstack.org/show/ae4lRKaJWtLVhO5CQaI3/ | 15:23 |
*** romcheg has joined #openstack-ironic | 15:25 | |
BadCub | dtantsur: jroll in regard to the archive. From what I interpret, the desire is to consolidate "backlog" and "kilo-archive" into a single unit? | 15:26 |
dtantsur | yep | 15:27 |
jroll | BadCub: yes | 15:27 |
*** jistr|mtg is now known as jistr | 15:27 | |
BadCub | reading through I see the logic there. I am good with that process myself as well. | 15:27 |
jroll | BadCub: yeah, I'd like devananda to weigh in, I'm happy to update it if need be (jay is OOO today) | 15:28 |
* jroll bbiaf | 15:28 | |
BadCub | devananda: is on vacation, so I doubt he is going to be around | 15:28 |
NobodyCam | jroll: LOL JayF's doing tripleo things today | 15:29 |
* NobodyCam *ducks* | 15:29 | |
NobodyCam | hummm. my on;y concern would be that spec in backlog may not have gone thru a complete review process | 15:32 |
NobodyCam | while archived specs have actually landed in kilo | 15:32 |
BadCub | NobodyCam: good point | 15:32 |
jroll | NobodyCam: lol | 15:34 |
NobodyCam | :-p | 15:35 |
jroll | NobodyCam: they need re-review anyway, at least to be moved to L | 15:35 |
BadCub | So we only have 2 specs in backlog. One of them is already approved and one is drafting | 15:35 |
BadCub | https://blueprints.launchpad.net/ironic/+spec/exposing-hardware-capabilities is already listed on the pad for the Spec Cores and will most likely be in L. So that leaves one | 15:36 |
BadCub | So my question here is two part: With the amount of specs in said folder, why would it be confusing or detrimental to to keep the two-folder distinction at this time, and if there is a true benefit to consolidating the folders why not just do it? We are not talking about a huge amount of specs here. | 15:40 |
*** jistr has quit IRC | 15:40 | |
NobodyCam | reding the Driver Capabilities spec it makes sense to me.. but I don't yet have my spec reviewer hat on. | 15:40 |
jroll | BadCub: I care this much |__| | 15:41 |
*** kalpase has left #openstack-ironic | 15:41 | |
NobodyCam | I'd be ok with merging them toghether | 15:41 |
NobodyCam | lol | 15:41 |
jroll | have bikeshed; will paint | 15:41 |
BadCub | NobodyCam: I have a section on the pad for unapproved specs. I will add ^ to that list. | 15:41 |
NobodyCam | lol | 15:41 |
BadCub | It really does not seem to be a big deal in either case, and it would make kittens sad if we help off opening specs for L until next week over this | 15:43 |
dtantsur | I don't care much as well, so I can revert my vote if people think so :) | 15:45 |
jroll | dtantsur: do you feel strongly about this? | 15:45 |
BadCub | s/help/held | 15:45 |
dtantsur | jroll, not really | 15:45 |
dtantsur | I can live with it ;) | 15:45 |
jroll | I'm inclined to just merge it then | 15:45 |
BadCub | jroll: I agree | 15:46 |
NobodyCam | ++ | 15:46 |
*** ramineni has quit IRC | 15:46 | |
BadCub | dtantsur: I agree with your points on ^ less confusing is a major ++ | 15:47 |
dtantsur | +2. let's approve it and then think whether to move stuff to backlog | 15:47 |
NobodyCam | brb | 15:47 |
jlvillal | dtantsur: Question on: https://review.openstack.org/#/c/171334/10/ironicclient/common/http.py | 15:48 |
jroll | wait, ramesh took off without test results for https://review.openstack.org/#/c/171767/ :( | 15:48 |
jroll | lucasagomes: dtantsur ^ | 15:48 |
lucasagomes | jroll, oh, he said he tested and works | 15:48 |
lucasagomes | perhaps we should +a that then | 15:48 |
dtantsur | jroll, he left a comment | 15:48 |
jlvillal | dtantsur: Is there a reason _parse_version_headers is not in VersionNegotiationMixin? Seems like the same two functions are duplicated. | 15:48 |
NobodyCam | morning jlvillal | 15:49 |
dtantsur | jlvillal, they're a bit different, have a closer look | 15:49 |
jlvillal | dtantsur: But maybe the request method is different and thus need two ways | 15:49 |
dtantsur | and g'morning | 15:49 |
BadCub | So I was thinking of pulling the 'available" Spec Cores together next Wednesday to meet, go over some process things to make life easier and start eyeing specs. I think this is a good time to discuss this as well for future cycles | 15:49 |
lucasagomes | dtantsur, I will go there and approve jroll's patch ack? | 15:49 |
BadCub | if Wednesday is good for everyone | 15:49 |
jlvillal | NobodyCam: Morning | 15:49 |
dtantsur | lucasagomes, ++ | 15:49 |
NobodyCam | works for /me | 15:49 |
*** ramineni has joined #openstack-ironic | 15:49 | |
dtantsur | BadCub, should be ok | 15:49 |
jroll | dtantsur: lucasagomes: oh, why wouldn't he approve :/ | 15:49 |
dtantsur | no idea | 15:49 |
lucasagomes | jroll, hmmmmm | 15:50 |
NobodyCam | brb | 15:50 |
lucasagomes | no idea, better wait? | 15:50 |
jroll | BadCub: I also +2'd the "open L" thing, and I'm free wednesday afaik | 15:50 |
BadCub | awesome | 15:50 |
jroll | lucasagomes: idk, he's +2 on it | 15:50 |
lucasagomes | jroll, hmm, idk... ok let's wait then | 15:50 |
NobodyCam | lucasagomes: what patch? | 15:51 |
jlvillal | dtantsur: Would it be horrific to have a common function which gets passed the accessor function? | 15:51 |
jlvillal | :) | 15:51 |
lucasagomes | NobodyCam, https://review.openstack.org/#/c/171767/ | 15:51 |
BadCub | jroll: ty :) | 15:51 |
dtantsur | jlvillal, well, not very different as to me. you can go ahead and change it, if you feel like, I was kind of fixing the patch for devananda :) | 15:51 |
jlvillal | dtantsur: Okay, let me look | 15:52 |
BadCub | Thank you NobodyCam for +2 on https://review.openstack.org/#/c/171334/ | 15:52 |
dtantsur | lucasagomes, lemme annoy you once more with https://review.openstack.org/#/c/171211/ (and https://review.openstack.org/#/c/172077/ too) if you don't mind :) | 15:53 |
lucasagomes | I'm on the docs one :-) it's big | 15:53 |
*** Marga_ has joined #openstack-ironic | 15:53 | |
*** Marga_ has quit IRC | 15:53 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Address comments on I5cc41932acd75cf5e9e5b626285331f97126932e https://review.openstack.org/172130 | 15:54 |
*** Marga_ has joined #openstack-ironic | 15:54 | |
jroll | lucasagomes: ok, if you say so. follow-up patch here ^ | 15:54 |
jroll | idk why 3 +2's and "tested, wfm" would wait | 15:54 |
BadCub | jroll: yeah, I was kinda curious there too | 15:55 |
jroll | it's whatever | 15:55 |
lucasagomes | I'm ok approving it | 15:55 |
NobodyCam | lucasagomes: would https://review.openstack.org/#/c/171743/ affect https://review.openstack.org/#/c/171767 | 15:55 |
lucasagomes | NobodyCam, not really | 15:55 |
lucasagomes | wait thinks ... | 15:55 |
lucasagomes | hmmmmmm | 15:56 |
NobodyCam | i think it might | 15:56 |
* BadCub needs a smoke | 15:56 | |
jroll | NobodyCam: 171767 just makes whole disk images not enter that block that 171743 touches | 15:56 |
jroll | I don't see why it would affect it | 15:56 |
dtantsur | going now, see you tomorrow | 15:57 |
*** dtantsur is now known as dtantsur|afk | 15:57 | |
jroll | g'night | 15:57 |
BadCub | g'night dtantsur|afk | 15:57 |
NobodyCam | night dtantsur|afk | 15:57 |
NobodyCam | humm | 15:57 |
* NobodyCam need more coffee | 15:57 | |
NobodyCam | brb | 15:57 |
lucasagomes | jroll, https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L612-L626 | 15:59 |
lucasagomes | I wonder if ur patch should also ignore that if is_whole_disk_image | 15:59 |
* lucasagomes is confused, I really need time to test such changes | 15:59 | |
jroll | lucasagomes: no, we don't want whole disk images to install the bootloader | 15:59 |
jroll | thus they shouldn't wait for the bootloader to be installed | 16:00 |
lucasagomes | ohhh I see the is_whole_disk_image conditional now there | 16:00 |
lucasagomes | yeah | 16:00 |
lucasagomes | makes sense | 16:00 |
lucasagomes | ok /me approves | 16:00 |
jroll | yeah, I went to fix it there as well and it was already there :D | 16:00 |
lucasagomes | NobodyCam, u want to test it first? | 16:01 |
* lucasagomes feels uncomfortable | 16:01 | |
jroll | only two people have tested it | 16:01 |
jroll | :/ | 16:01 |
jroll | man, we should spend the entire liberty cycle writing tests for everything | 16:02 |
jroll | almost nothing is tested these days | 16:02 |
*** rwsu has joined #openstack-ironic | 16:02 | |
lucasagomes | yeah | 16:03 |
lucasagomes | we def need some gate tests for local boot/whole disk image | 16:03 |
lucasagomes | ipxe | 16:03 |
lucasagomes | and so on | 16:03 |
jroll | yep | 16:03 |
NobodyCam | +++++ | 16:04 |
NobodyCam | lucasagomes: my OoO env is currently not working... I broke it somehow | 16:05 |
lucasagomes | if we ditch the bash ramdisk, we at least won't need to test same stuff for both ramdisks | 16:05 |
lucasagomes | we get rid of all the bash ramdisks tests, and just IPA as the official and tested ramdisk | 16:05 |
lucasagomes | right now the matrix will be too big with both ramdisks being official | 16:06 |
lucasagomes | NobodyCam, oh, no idea | 16:06 |
lucasagomes | NobodyCam, what's up? | 16:06 |
*** dttocs has joined #openstack-ironic | 16:06 | |
NobodyCam | lucasagomes: oh that was a reply to your "you wanta test it question" | 16:06 |
* BadCub thinks NobodyCam 's "Taco Dev machine" is giving up on life completely | 16:07 | |
NobodyCam | and I love to drop the bash ramdisc in L | 16:07 |
lucasagomes | NobodyCam, oh I see | 16:07 |
lucasagomes | NobodyCam, it's ok if I go ahead and approve it? | 16:08 |
NobodyCam | I think so. | 16:08 |
lucasagomes | x.x | 16:08 |
lucasagomes | hah | 16:08 |
openstackgerrit | Merged openstack/ironic: Use hexhyp instead of hexraw iPXE type https://review.openstack.org/171759 | 16:11 |
*** derekh has quit IRC | 16:12 | |
* BadCub runs out to hunt breakfast items | 16:13 | |
* lucasagomes approved jrolls patch | 16:15 | |
lucasagomes | folks I have to call it a day | 16:15 |
lucasagomes | gotta catch the train back still | 16:15 |
lucasagomes | have a great night everyone | 16:15 |
NobodyCam | night lucasagomes | 16:16 |
*** lucasagomes has quit IRC | 16:16 | |
NobodyCam | jlvillal: you working on a new rev of 171334? | 16:17 |
NobodyCam | also doc patch with several +1's and a +2 https://review.openstack.org/#/c/169162 | 16:20 |
*** ndipanov has quit IRC | 16:20 | |
jlvillal | NobodyCam: I was working on trying to refactor a little bit to reduce duplication | 16:25 |
NobodyCam | jlvillal: +++ | 16:25 |
*** ramineni1 has joined #openstack-ironic | 16:27 | |
NobodyCam | adam_g: mind if I make a minor edit to 171827? | 16:28 |
*** ramineni has quit IRC | 16:29 | |
openstackgerrit | Chris Krelle proposed openstack/ironic: Add notes about upgrading juno->kilo to docs https://review.openstack.org/171827 | 16:31 |
adam_g | NobodyCam, ya, sure thanks | 16:33 |
NobodyCam | I voted +2 on ^^^^ my patch only removed one word | 16:33 |
NobodyCam | adam_g: :) | 16:33 |
NobodyCam | thank oyu | 16:33 |
adam_g | :P | 16:33 |
NobodyCam | you even | 16:33 |
*** athomas has quit IRC | 16:33 | |
NobodyCam | brb | 16:33 |
*** foexle_ has quit IRC | 16:34 | |
*** harlowja_away is now known as harlowja | 16:35 | |
*** ijw has joined #openstack-ironic | 16:41 | |
*** yog__ has quit IRC | 16:49 | |
*** davideagnello has joined #openstack-ironic | 16:53 | |
* NobodyCam is back | 16:58 | |
* BadCub is also back | 16:58 | |
*** viktors is now known as viktors|afk | 17:02 | |
adam_g | nice http://lists.openstack.org/pipermail/openstack-dev/2015-February/056515.html | 17:04 |
NobodyCam | :) | 17:06 |
BadCub | sweet ^ | 17:13 |
*** saripurigopi has quit IRC | 17:13 | |
openstackgerrit | Merged openstack/ironic: Don't pass boot_option: local for whole disk images https://review.openstack.org/171767 | 17:13 |
*** openstack has quit IRC | 17:13 | |
*** openstack has joined #openstack-ironic | 17:14 | |
*** achanda has joined #openstack-ironic | 17:17 | |
NobodyCam | lol ... got luv dtantsur|afk refferences to "ancient ramdisks" | 17:18 |
*** pelix has quit IRC | 17:18 | |
jroll | easy review: https://review.openstack.org/#/c/172130/ | 17:20 |
*** Marga_ has quit IRC | 17:21 | |
BadCub | added ^ to pad | 17:22 |
*** ramineni1 has quit IRC | 17:22 | |
BadCub | We gots a bunch of things that need +2/+A on em, mostly docs :p | 17:23 |
*** Marga_ has joined #openstack-ironic | 17:24 | |
NobodyCam | jroll: BadCub 172130 ... Bam! | 17:25 |
BadCub | coolness | 17:25 |
NobodyCam | brb | 17:27 |
*** meghal has joined #openstack-ironic | 17:29 | |
*** Marga_ has quit IRC | 17:29 | |
*** meghal has quit IRC | 17:30 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Update session headers during initialization of AgentClient https://review.openstack.org/172154 | 17:31 |
openstackgerrit | Josh Gachnang proposed openstack/ironic: Agent driver fails without Ironic-managed TFTP https://review.openstack.org/170984 | 17:51 |
*** Sukhdev has joined #openstack-ironic | 17:52 | |
*** victorfeitosa has joined #openstack-ironic | 17:54 | |
jroll | BadCub: ^ is this one on the rc1 list? | 17:54 |
* BadCub looks | 17:54 | |
BadCub | Nope | 17:54 |
BadCub | it looks like it should be though | 17:54 |
BadCub | jroll: targets the bug for ^ to rc1 and added to pad | 17:55 |
*** Marga_ has joined #openstack-ironic | 17:56 | |
jroll | thanks | 17:56 |
BadCub | yw :) | 17:57 |
*** meghal has joined #openstack-ironic | 18:00 | |
*** meghal has quit IRC | 18:05 | |
*** edcragg has quit IRC | 18:06 | |
*** Marga_ has quit IRC | 18:07 | |
*** Marga_ has joined #openstack-ironic | 18:18 | |
*** Marga_ has quit IRC | 18:20 | |
*** Marga_ has joined #openstack-ironic | 18:20 | |
NobodyCam | jroll: would you happen to have some time to take a look at the pending doc patches? | 18:27 |
jroll | NobodyCam: this afternoon I could | 18:27 |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: WIP: Unit tests for micro-versions. Feedback wanted! https://review.openstack.org/172168 | 18:28 |
NobodyCam | :) thats only 33 minutes away :-p | 18:28 |
jroll | heh | 18:28 |
jlvillal | jroll, BadCub: ^^^^ Before I go off on a wild tangent, I thought I would get some initial feedback on the patch idea | 18:28 |
BadCub | I need to go away for a while. NobodyCam can you take a look at ^ | 18:29 |
jlvillal | BadCub: NobodyCam: Thanks | 18:30 |
greghaynes | jroll: you had success with https://review.openstack.org/#/c/171743/ ? | 18:30 |
jroll | greghaynes: I didn't test it, no | 18:31 |
greghaynes | ah | 18:31 |
jroll | jlvillal: why would refactoring be a bad idea? | 18:32 |
jlvillal | jroll: It was more on the unittests I was looking for feedback. On the refactoring my only concern is it might be confusing to people passing a function around. | 18:33 |
*** ijw has quit IRC | 18:33 | |
jlvillal | jroll: I like the refactoring of the parse_versions. Less sure on the http request function. | 18:33 |
jroll | jlvillal: idk, seems sane. the accessor_func thing is a bit odd but whatever | 18:34 |
jlvillal | jroll: That was my concern if it would confuse people or not. So wasn't sure to refactor like that or leave it as is. | 18:34 |
jroll | jlvillal: meh, it may take a sec but everyone should be able to figure that out | 18:35 |
openstackgerrit | Merged openstack/ironic: Follow-up to "Add retry logic to _exec_ipmitool" https://review.openstack.org/171771 | 18:37 |
openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Consistent and more valid strings for Booleans https://review.openstack.org/170230 | 18:38 |
BadCub | jlvillal: this is the follow-up to https://review.openstack.org/#/c/171334/ ? | 18:39 |
jlvillal | BadCub: yes, I didn't want to touch the patch in progress. | 18:40 |
BadCub | cool | 18:40 |
jlvillal | BadCub: I figured I would to a follow-on patch | 18:40 |
jlvillal | s/to/do/ | 18:40 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add support for 'baremetal show' command https://review.openstack.org/171739 | 18:40 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Introduce openstackclient plugin https://review.openstack.org/171672 | 18:40 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implement the rest of the args for baremetal list https://review.openstack.org/171699 | 18:40 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implement baremetal delete command https://review.openstack.org/171751 | 18:40 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add support for microversion https://review.openstack.org/172170 | 18:40 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal create https://review.openstack.org/172171 | 18:40 |
openstackgerrit | Merged openstack/ironic: Address comments on I5cc41932acd75cf5e9e5b626285331f97126932e https://review.openstack.org/172130 | 18:41 |
jlvillal | Go Brad! :) | 18:41 |
* BadCub blinks | 18:41 | |
* jlvillal wonders who is Brad P. Crochet? | 18:41 | |
BadCub | All of those were added to the L pad yesterday as "Things of Interest" | 18:42 |
NobodyCam | jlvillal: with that follow up patch could the -1 be removed from devananda's orginal patch? | 18:47 |
BadCub | jlvillal: I added https://review.openstack.org/#/c/172168/1 to the pad :) | 18:48 |
jlvillal | NobodyCam: Will do! | 18:53 |
jlvillal | NobodyCam: Done | 18:53 |
NobodyCam | :) | 18:54 |
*** meghal has joined #openstack-ironic | 18:55 | |
BadCub | can we get another +2/+A on https://review.openstack.org/#/c/171334/ :) | 18:55 |
NobodyCam | rloo: are around? | 18:55 |
rloo | hi NobodyCam | 18:55 |
NobodyCam | hi rloo ... morning (afternoon) | 18:56 |
NobodyCam | rloo: would you happen to have a free minute to look at ^^^^ | 18:56 |
rloo | almost-afternoon-to-you NobodyCam ;) | 18:56 |
rloo | NobodyCam: am in a meeting that should end soon (hopefully in the next 10 min). will look then. | 18:57 |
NobodyCam | awesome TY rloo :) | 18:57 |
NobodyCam | oh on another NOTE: I believe HP will again print up our team shirts | 18:57 |
NobodyCam | working with them now!!! | 18:57 |
rloo | NobodyCam: sweet. I'm guessing this is with bear metal? :) | 18:58 |
NobodyCam | show we'll need a count of the sizes we'll need | 18:58 |
rloo | NobodyCam: guess you'll have to look into the 'import' issue again. | 18:58 |
NobodyCam | rloo: something very close ti: http://www.customink.com/lab?cid=45931546-15537897&pc=SDFU-40124&cm_mmc=sdfu-_-Winter2014-_-Day84-_-button | 18:58 |
BadCub | NobodyCam: I have a sign-up sheet for t-shirts ready on a pad | 18:58 |
NobodyCam | woo hoo BadCub :) | 18:59 |
*** meghal has quit IRC | 18:59 | |
BadCub | I was just waiting to put it out until we got the "black" concept worked out | 18:59 |
rloo | NobodyCam, BadCub: oh, black. even badder ;) | 18:59 |
NobodyCam | yes looks like black shirts with white text / graphics | 18:59 |
BadCub | rloo: yeah, the black prototype looked best, at least to me it did. But considering 99.8% of my entire wardrobe is black, I may be biased | 19:00 |
rloo | BadCub: how boring. How about a RED one for you? | 19:01 |
NobodyCam | lol | 19:01 |
BadCub | rloo: red clashes with my tattoos LOL | 19:01 |
rloo | BadCub: didn't realize people color-coordinated with their tatoos. Guess that makes sense :D | 19:02 |
*** kkoski has quit IRC | 19:02 | |
BadCub | rloo: it's all about complimenting one's art :D | 19:02 |
rloo | NobodyCam: long-sleeve RED shirt for BadCub! | 19:02 |
NobodyCam | hehehe | 19:03 |
* BadCub cringes at idea of long-sleeve and hides in corner | 19:03 | |
*** meghal has joined #openstack-ironic | 19:03 | |
*** Marga_ has quit IRC | 19:03 | |
jroll | I'll only take a long sleeve if it's a hoody | 19:03 |
NobodyCam | jroll: ++ but not a hoody this time just a tee shirt | 19:04 |
NobodyCam | :-p | 19:04 |
BadCub | I have no hoodies :( | 19:04 |
TheJulia | if we're talking about red shirts, LIGHT RED may be an option... | 19:04 |
jroll | NobodyCam: yeah, just hate long sleeve t-shirts :) | 19:05 |
* BadCub links light red to pink and runs away to another oom | 19:05 | |
jroll | TheJulia: so uh, pink? | 19:05 |
BadCub | room even | 19:05 |
*** Marga_ has joined #openstack-ironic | 19:05 | |
NobodyCam | lol | 19:05 |
jroll | I can get behind a pink shirt | 19:05 |
TheJulia | I'm sure we could get JayF doing a sound clip about how LIGHT RED is not pink | 19:05 |
*** kkoski has joined #openstack-ironic | 19:06 | |
jroll | LOL | 19:06 |
jroll | TheJulia: have you met jay in person? | 19:06 |
*** Marga_ has quit IRC | 19:06 | |
NobodyCam | or a new hbo show "pink is the new black" | 19:06 |
*** Marga_ has joined #openstack-ironic | 19:06 | |
BadCub | I just can't......do pink........ | 19:07 |
TheJulia | jroll: JayF and I met years ago in the Raleigh, NC area through mutual friends. When we recognized each other in Paris, he kind did like a tackle hug kind of thing | 19:07 |
jroll | TheJulia: lol, awesome :D | 19:08 |
NobodyCam | lol about about broke my finger | 19:08 |
* rloo doesn't care for pink either. But a strong red, now, that's a different colour :) | 19:08 | |
lifeless | very risky colour | 19:08 |
lifeless | got to watch out for aliens, explosions, poison, warp coil leaks... | 19:09 |
TheJulia | and never beam down to the planet first. | 19:09 |
BadCub | lol | 19:10 |
BadCub | brb | 19:10 |
*** victorfeitosa has quit IRC | 19:15 | |
*** dttocs has quit IRC | 19:15 | |
NobodyCam | lol | 19:17 |
*** dprince has quit IRC | 19:20 | |
*** meghal has quit IRC | 19:20 | |
NobodyCam | bbaib | 19:21 |
*** ijw has joined #openstack-ironic | 19:23 | |
*** Marga_ has quit IRC | 19:39 | |
*** Marga_ has joined #openstack-ironic | 19:40 | |
*** Marga_ has quit IRC | 19:40 | |
*** Marga_ has joined #openstack-ironic | 19:40 | |
*** ijw has quit IRC | 19:43 | |
*** meghal has joined #openstack-ironic | 19:45 | |
*** Marga_ has quit IRC | 19:45 | |
*** kozhukalov has quit IRC | 19:50 | |
*** Sukhdev has quit IRC | 19:52 | |
pshige | morning Ironic | 19:54 |
BadCub | heya pshige :) | 19:55 |
pshige | BadCub: hi | 19:55 |
pshige | 0455 JST in Japan :) | 19:55 |
NobodyCam | morning pshige | 19:55 |
NobodyCam | wow | 19:55 |
BadCub | that's early! | 19:56 |
pshige | NobodyCam: morning | 19:56 |
NobodyCam | :) | 19:56 |
*** meghal1 has joined #openstack-ironic | 20:02 | |
*** meghal has quit IRC | 20:02 | |
*** meghal1 has quit IRC | 20:03 | |
*** meghal has joined #openstack-ironic | 20:03 | |
*** meghal has quit IRC | 20:03 | |
*** meghal has joined #openstack-ironic | 20:04 | |
*** davideagnello has quit IRC | 20:06 | |
*** davideagnello has joined #openstack-ironic | 20:07 | |
*** dttocs has joined #openstack-ironic | 20:07 | |
NobodyCam | I'm going to land https://review.openstack.org/#/c/171831 ? any objections to opening the L specs up? | 20:11 |
BadCub | NobodyCam: ++ | 20:12 |
*** bradjones has quit IRC | 20:13 | |
pshige | no objection | 20:14 |
*** ijw has joined #openstack-ironic | 20:14 | |
*** bradjones has joined #openstack-ironic | 20:17 | |
NobodyCam | BadCub: https://review.openstack.org/#/c/170984 +2'd | 20:18 |
BadCub | NobodyCam: ty :) | 20:19 |
*** ijw has quit IRC | 20:21 | |
NobodyCam | https://review.openstack.org/#/c/171831 +a'd | 20:23 |
BadCub | ty :) | 20:23 |
*** achanda has quit IRC | 20:24 | |
openstackgerrit | Merged openstack/ironic-specs: Open specs for Liberty https://review.openstack.org/171831 | 20:27 |
pshige | cool ! | 20:30 |
BadCub | Now to get our rc1 list cleaned off and we are good_to_go :) | 20:31 |
jlvillal | jroll: Question on: https://review.openstack.org/#/c/171334/10/ironicclient/common/http.py L71 Can that return no version information in the header? | 20:31 |
jlvillal | BadCub: ^^ Maybe you know? | 20:31 |
* BadCub looks | 20:31 | |
jroll | jlvillal: no idea, without digging through the code | 20:32 |
jlvillal | jroll: Thanks | 20:32 |
jlvillal | BadCub: I updated that with my question/comment | 20:33 |
rloo | jlvillal: I was wondering about that but I think it will return the version header, because I think that we only started returning 406 *after* we added the version stuff. | 20:33 |
rloo | jlvillal: but I've been too lazy to look at the log to verify the order in which we added the code | 20:34 |
jlvillal | rloo: Ah, makes sense. | 20:34 |
rloo | jlvillal: are you looking at that patch now? | 20:34 |
rloo | jlvillal: cuz something doesn't make sense to me. | 20:34 |
jlvillal | rloo: I just posted comment with question on patch. So yes | 20:34 |
rloo | do you understand the use of the implicit_api_version? | 20:34 |
jlvillal | rloo: What's that? | 20:34 |
jlvillal | rloo: I wonder if that really means explicit? Let me look again. | 20:35 |
jlvillal | rloo: never mind last comment | 20:35 |
rloo | jlvillal: so line 81 of that http file: https://review.openstack.org/#/c/171334/10/ironicclient/common/http.py | 20:35 |
*** Marga_ has joined #openstack-ironic | 20:36 | |
rloo | it seems to me that if the user explicitly specified the version and the client got a 406, we don't want to change the version/do anaother request | 20:36 |
rloo | and i'm guessing that we have this code here so that we can spit out a msg to the user as to the valid min/max | 20:36 |
jlvillal | rloo: Correct that is the goal from what I understand | 20:36 |
jlvillal | rloo: If they ask for version 1.99 then fail. | 20:37 |
rloo | but i may be tired, cuz if the user specifies a version say 1.5 and they get 406, then negotiate_version wil be called. what if negotiated_ver == 1.5. | 20:37 |
*** Marga_ has quit IRC | 20:38 | |
*** igordcard_ has joined #openstack-ironic | 20:38 | |
rloo | won't it return 1.5 instead of raising an exception? | 20:38 |
jlvillal | rloo: Yes I would think it would return 1.5 but I think that would be correct. If the server supports 1.5 and the user asks for 1.5. | 20:39 |
NobodyCam | rloo: if user requests a version and it fails it should try and negotiate a different version... at leat that is my understanding | 20:39 |
rloo | jlvillal: but the user originally asked for 1.5 and it failed. are we going to do another request for 1.5 again? | 20:39 |
NobodyCam | it should *NOT* try ... | 20:39 |
jlvillal | rloo: I would assume it will try again and should fail again. | 20:39 |
rloo | jlvillal: when will it stop? | 20:40 |
rloo | jlvillal: like, why try again? nothing will have changed. | 20:40 |
jlvillal | rloo: Wouldn't the raised exception stop it? | 20:40 |
rloo | jlvillal: that's my question. i don't see that an exception will be raised. | 20:40 |
NobodyCam | rloo: lines 10 and 11 of the commit message | 20:41 |
rloo | jlvillal: I don't think that if at line 80 will be triggered | 20:41 |
jlvillal | rloo: But wouldn't that be a bug in the server? | 20:41 |
rloo | NobodyCam: 'if the user did not request a specific version'... | 20:42 |
jlvillal | rloo: The server is saying it supports 1.5 but then when the client requests 1.5 it returns 406. Or am I missing something? | 20:42 |
rloo | NobodyCam: but in the http.py file https://review.openstack.org/#/c/171334/10/ironicclient/common/http.py | 20:42 |
rloo | NobodyCam: line 81 -- what is that testing for? | 20:42 |
jlvillal | rloo: I think it is testing for user requests 1.8 but server only supports 1.6. So fail. | 20:43 |
rloo | jlvillal, NobodyCam: maybe I'm missing something. I'll have to test it out. Something doesn't make sense to me. | 20:44 |
jlvillal | rloo: okay | 20:44 |
*** ijw has joined #openstack-ironic | 20:44 | |
NobodyCam | humm | 20:45 |
NobodyCam | oh looks like like 217 should also be checking self.os_ironic_api_version | 20:46 |
*** andreykurilin_ has joined #openstack-ironic | 20:46 | |
NobodyCam | if resp = 406 and self.os_ironic_api_version not none | 20:47 |
NobodyCam | then ... negotiate version | 20:47 |
NobodyCam | if resp = 406 and self.os_ironic_api_version IS none | 20:48 |
NobodyCam | then ... negotiate version | 20:48 |
NobodyCam | :-p | 20:48 |
rloo | NobodyCam: I *think* os_ironic_api_version will actually be specified there. | 20:48 |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: WIP: Unit tests for micro-versions. Feedback wanted! https://review.openstack.org/172168 | 20:49 |
*** pcrews has quit IRC | 20:49 | |
jlvillal | rloo: https://review.openstack.org/#/c/172168/2/ironicclient/tests/unit/test_http.py L123 I added a test case for how I think it should work | 20:49 |
rloo | jlvillal: it's just a ploy on your part to get me to look at your patch ;) | 20:50 |
jlvillal | rloo: :D | 20:50 |
*** ijw has quit IRC | 20:51 | |
rloo | jlvillal: do you have a case where you test that the user-specified version is supported by the server, but that the actual request isn't? | 20:51 |
*** Marga_ has joined #openstack-ironic | 20:51 | |
jlvillal | rloo: I do not. I'm just starting on these unit tests. | 20:51 |
rloo | jlvillal: I mean eg, using a node name if the version is < 1.5 or whatever, or doing an inspect if < 1.6. I think that's where I'm confused as to how this patch is handling or not handling. | 20:52 |
jlvillal | rloo: Ah, that makes sense. | 20:52 |
jlvillal | rloo: User requests a version that the server supports but then asks for a specific call which is not supported by that version. | 20:52 |
*** achanda has joined #openstack-ironic | 20:53 | |
rloo | oh s*. i had to kill my client. i was right. the code isn't correct. | 20:53 |
*** pcrews has joined #openstack-ironic | 20:53 | |
NobodyCam | :( | 20:53 |
NobodyCam | rloo: so for my understanding:you requested a supported version but asked for something that was not supported in that version | 20:54 |
rloo | NobodyCam: yup. | 20:59 |
rloo | NobodyCam: I added a comment or several comments. | 20:59 |
rloo | jlvillal: maybe we should add your tests to that patch too. | 20:59 |
jlvillal | rloo: Works for me. I was trying not to delay the patch. | 21:00 |
rloo | jlvillal: I know, and I normally would agree but there seem to be subtleties/cases here that I'm not sure I can remember to manually think of/test for. | 21:01 |
rloo | we aren't cutting rc1 until Monday, right? | 21:02 |
*** thrash is now known as thrash|g0ne | 21:03 | |
BadCub | rloo: correct | 21:05 |
NobodyCam | jlvillal: would you be able to address these comments? | 21:05 |
NobodyCam | and maybe merge your tests patch in | 21:06 |
rloo | NobodyCam, jlvillal: It works if we remove the check of negotiated != os...version | 21:08 |
NobodyCam | rloo: :) | 21:09 |
jlvillal | rloo: Do you want to propose that change? | 21:10 |
jlvillal | rloo: Does it impact the case of I request version 1.99? | 21:11 |
*** jcoufal has joined #openstack-ironic | 21:12 | |
rloo | jlvillal: I don't know if it impacts that case or not, it shouldn't. ie, if the user specified a version and they get 406, we should just raise an exception. not make another request. | 21:12 |
rloo | jlvillal: i can propose the change if you want. but i'd like to keep my +2 powers for this in case it is needed on Monday. | 21:13 |
jlvillal | rloo: Okay :) | 21:13 |
rloo | jlvillal: esp if you're going to add your tests :-) | 21:13 |
jlvillal | Maybe I just do the small change you suggest. | 21:13 |
NobodyCam | rloo: ++ that is why I asked too | 21:13 |
jlvillal | Okay I will add the tests without the refactoring I think | 21:14 |
rloo | jlvillal, NobodyCam: I'm off in a few minutes. might be back later tonight, or not. but then not back til Monday. | 21:14 |
jlvillal | rloo: Okay | 21:15 |
rloo | jlvillal, NobodyCam: hopefully it'll be merged before then ;) | 21:15 |
jlvillal | rloo: Do you think L384 should be changed? | 21:15 |
BadCub | have a good weekend rloo !! :-) | 21:15 |
jlvillal | rloo: Around there? | 21:15 |
rloo | jlvillal: what do you mean? what change are you thinking of? | 21:16 |
jlvillal | For my case of version 1.99? | 21:16 |
jlvillal | rloo: I need to read the code more... | 21:16 |
NobodyCam | jlvillal: are you going to remove the check rloo pointed out | 21:16 |
NobodyCam | rloo: havea great weekend | 21:16 |
rloo | jlvillal: so user asks for 1.99, server doesn't support it, user should get an exception. right? | 21:16 |
jlvillal | rloo: If we get 406 and the user specified the version should we just fail then. | 21:16 |
rloo | jlvillal: yes, we should just fail. cuz the user explicitly specified the version. | 21:17 |
jlvillal | NobodyCam: I will do that. | 21:17 |
jlvillal | rloo: That is what I was thinking in the L384 region. | 21:17 |
rloo | jlvillal: the 'failing' is being done in that negotiate method though | 21:17 |
jlvillal | rloo: Okay, let me look more closely. And work on an update | 21:18 |
NobodyCam | awesome thank you jlvillal :) | 21:18 |
rloo | jlvillal: if your tests are complete, we should see where the failings are | 21:18 |
jlvillal | rloo: Big if ;) | 21:19 |
rloo | jlvillal: oh, hmm. if there are tests that test the scenarios we are interested in, we will see where/if there are failings :-) | 21:20 |
jlvillal | rloo: Yes | 21:20 |
jlvillal | NobodyCam: Hopefully I can have a patch uploaded before the end of the work day. | 21:20 |
NobodyCam | :) that would be supper awesome :) | 21:22 |
jlvillal | NobodyCam: and dinner great ;) | 21:22 |
NobodyCam | but there is always tomorrow | 21:22 |
jlvillal | NobodyCam: Thanks | 21:23 |
NobodyCam | :) | 21:23 |
*** meghal has quit IRC | 21:23 | |
*** meghal has joined #openstack-ironic | 21:24 | |
*** meghal has quit IRC | 21:24 | |
*** meghal has joined #openstack-ironic | 21:25 | |
openstackgerrit | Clif Houck proposed openstack/ironic: Add support for image caching for the agent driver https://review.openstack.org/161832 | 21:25 |
*** korekhov has joined #openstack-ironic | 21:26 | |
*** r-daneel has joined #openstack-ironic | 21:31 | |
*** rloo is now known as rloo_afk | 21:37 | |
*** Sukhdev has joined #openstack-ironic | 21:45 | |
mrda | Morning Ironic | 21:45 |
TheJulia | Good evening :) | 21:46 |
*** kkoski has quit IRC | 21:46 | |
mrda | TheJulia :) | 21:47 |
*** ijw has joined #openstack-ironic | 21:47 | |
*** trown is now known as trown|outttypeww | 21:50 | |
*** andreykurilin_ has quit IRC | 21:51 | |
*** ijw has quit IRC | 21:52 | |
NobodyCam | mornign mrda | 21:54 |
mrda | hi NobodyCam | 21:54 |
BadCub | heya mrda | 21:54 |
mrda | ...and BadCub | 21:54 |
NobodyCam | :) | 21:54 |
openstackgerrit | Michael Davies proposed openstack/python-ironicclient: Client should fall back to the lower versions if necessary https://review.openstack.org/171334 | 21:55 |
openstackgerrit | Michael Davies proposed openstack/python-ironicclient: Cache negotiated api microversion for this server https://review.openstack.org/171946 | 21:55 |
mrda | ahh, bother. Stupid rebase | 21:56 |
NobodyCam | did you see rloo_afk comments on that one | 21:56 |
NobodyCam | :-p | 21:56 |
mrda | Sorry, I need to put that back how it was - that rebase somehow screwed up :( | 21:57 |
* NobodyCam offers mrda coffee :) | 21:58 | |
mrda | I should have done that first before starting work :-S | 21:58 |
NobodyCam | :p | 21:58 |
openstackgerrit | Clif Houck proposed openstack/ironic: Add support for image caching for the agent driver https://review.openstack.org/161832 | 22:03 |
* NobodyCam steps afk for few | 22:05 | |
openstackgerrit | Michael Davies proposed openstack/python-ironicclient: Client should fall back to the lower versions if necessary https://review.openstack.org/171334 | 22:10 |
* mrda steps away to make coffee | 22:11 | |
*** jcoufal has quit IRC | 22:14 | |
*** kkoski has joined #openstack-ironic | 22:23 | |
*** kkoski has quit IRC | 22:26 | |
jlvillal | mrda: ping | 22:27 |
mrda | hey jlvillal | 22:27 |
jlvillal | mrda: Hey I am working on a patch for 171334 | 22:28 |
jlvillal | I was about to push it | 22:28 |
mrda | great! | 22:28 |
jlvillal | mrda: So I won't trample on you? | 22:28 |
mrda | Sorry, I was rebasing a depends on change, and accidentilly changed 171334 | 22:28 |
mrda | So I just reverted | 22:28 |
jlvillal | mrda: Okay :) Thanks! | 22:28 |
mrda | Sorry for the noise | 22:28 |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Client should fall back to the lower versions if necessary https://review.openstack.org/171334 | 22:29 |
jlvillal | mrda: Feel free to review ^^^ :) | 22:29 |
jlvillal | NobodyCam: ^^^^^ | 22:29 |
NobodyCam | oh... TY jlvillal | 22:29 |
NobodyCam | I'm reading over the rescue mode spec | 22:30 |
NobodyCam | hehehehe | 22:30 |
NobodyCam | which if run on a not borked node could break it.. | 22:30 |
mrda | jlvillal: shall do | 22:30 |
jlvillal | mrda: Thanks | 22:30 |
NobodyCam | would be nice to have soft power off support | 22:31 |
NobodyCam | JoshNang: around? | 22:35 |
JoshNang | NobodyCam: o/ | 22:36 |
NobodyCam | howdy | 22:36 |
NobodyCam | :-p | 22:36 |
JoshNang | how's it going? | 22:36 |
NobodyCam | going good :) | 22:36 |
NobodyCam | just a question | 22:36 |
JoshNang | ok, shoot | 22:37 |
NobodyCam | to much of a miss use of driver_internal_info to store the salted hashed password there vs instance_info | 22:37 |
JoshNang | we went with instance info because it was related to an instance on the machine, and not the node itself | 22:40 |
NobodyCam | :) maakes me want a instance_intenal_info field | 22:40 |
NobodyCam | lol | 22:40 |
JoshNang | also, can you update driver_internal_info via the api? | 22:40 |
NobodyCam | but I understand | 22:40 |
JoshNang | i'd definitely want guards on that so it doesn't show up in api requests, like we do with ipmi passwords | 22:41 |
NobodyCam | :) | 22:42 |
*** Marga_ has quit IRC | 22:43 | |
*** ijw has joined #openstack-ironic | 22:48 | |
*** ijw has quit IRC | 22:52 | |
*** r-daneel has quit IRC | 23:13 | |
*** Marga_ has joined #openstack-ironic | 23:14 | |
*** yuanying has joined #openstack-ironic | 23:23 | |
*** davideagnello has quit IRC | 23:29 | |
*** jcoufal has joined #openstack-ironic | 23:34 | |
*** Marga_ has quit IRC | 23:35 | |
*** Marga_ has joined #openstack-ironic | 23:36 | |
*** davideagnello has joined #openstack-ironic | 23:37 | |
*** Marga_ has quit IRC | 23:38 | |
*** Sukhdev has quit IRC | 23:45 | |
*** Marga_ has joined #openstack-ironic | 23:47 | |
*** Marga_ has quit IRC | 23:48 | |
*** Marga_ has joined #openstack-ironic | 23:48 | |
*** ijw has joined #openstack-ironic | 23:49 | |
*** ijw has quit IRC | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!