*** edcragg has quit IRC | 00:12 | |
*** yuanying has quit IRC | 00:25 | |
*** yuanying has joined #openstack-ironic | 00:30 | |
*** yuanying has quit IRC | 00:38 | |
*** yuanying has joined #openstack-ironic | 00:38 | |
*** BLZbubba has quit IRC | 00:44 | |
*** heyongli has joined #openstack-ironic | 01:28 | |
openstackgerrit | IWAMOTO Toshihiro proposed openstack/ironic-specs: Collect IPA logs https://review.openstack.org/168799 | 01:43 |
---|---|---|
*** naohirot has quit IRC | 01:50 | |
*** chenglch has joined #openstack-ironic | 01:54 | |
*** lintan_ has quit IRC | 02:11 | |
*** lintan has joined #openstack-ironic | 02:17 | |
openstackgerrit | Tan Lin proposed openstack/ironic-specs: Bare Metal Trust Using Intel TXT https://review.openstack.org/133902 | 02:26 |
*** kan_ has joined #openstack-ironic | 02:36 | |
*** yuanying has quit IRC | 03:22 | |
*** yuanying has joined #openstack-ironic | 03:25 | |
*** yuanying has quit IRC | 03:42 | |
*** yuanying has joined #openstack-ironic | 03:50 | |
*** yuanying has quit IRC | 03:56 | |
*** rameshg87 has joined #openstack-ironic | 04:01 | |
rameshg87 | good morning ironic | 04:01 |
*** yuanying has joined #openstack-ironic | 04:02 | |
*** yuanying_ has joined #openstack-ironic | 04:04 | |
*** eghobo has joined #openstack-ironic | 04:06 | |
*** yuanying has quit IRC | 04:06 | |
*** eghobo_ has joined #openstack-ironic | 04:12 | |
*** eghobo has quit IRC | 04:16 | |
*** eghobo has joined #openstack-ironic | 04:22 | |
*** eghobo_ has quit IRC | 04:22 | |
*** Nisha has joined #openstack-ironic | 04:35 | |
*** chenglch has quit IRC | 04:59 | |
*** ijw has joined #openstack-ironic | 05:09 | |
*** lazy_prince has joined #openstack-ironic | 05:11 | |
*** jrist has quit IRC | 05:12 | |
*** Nisha_away has joined #openstack-ironic | 05:15 | |
*** gridinv_ has quit IRC | 05:24 | |
*** Nisha_away has quit IRC | 05:30 | |
*** achanda has joined #openstack-ironic | 05:39 | |
*** zhenguo has joined #openstack-ironic | 05:39 | |
*** ijw has quit IRC | 05:56 | |
*** ijw has joined #openstack-ironic | 06:04 | |
*** yuanying_ has quit IRC | 06:09 | |
*** yuanying has joined #openstack-ironic | 06:09 | |
*** ijw has quit IRC | 06:11 | |
*** pradipta has joined #openstack-ironic | 06:18 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic-python-agent: Make sure sysrq functions are enabled in reboot.sh https://review.openstack.org/187111 | 06:22 |
*** ijw has joined #openstack-ironic | 06:23 | |
*** ukalifon1 has joined #openstack-ironic | 06:25 | |
*** achanda has quit IRC | 06:28 | |
*** ijw has quit IRC | 06:38 | |
*** saripurigopi has joined #openstack-ironic | 06:38 | |
*** ijw has joined #openstack-ironic | 06:38 | |
*** achanda has joined #openstack-ironic | 06:47 | |
*** takadayuiko has joined #openstack-ironic | 06:47 | |
*** yuanying_ has joined #openstack-ironic | 06:55 | |
*** yuanying has quit IRC | 06:57 | |
*** ifarkas has joined #openstack-ironic | 06:59 | |
*** radek_ has joined #openstack-ironic | 07:11 | |
*** ijw_ has joined #openstack-ironic | 07:23 | |
*** ijw has quit IRC | 07:24 | |
*** dguerri`away is now known as dguerri | 07:30 | |
*** leopoldj has joined #openstack-ironic | 07:32 | |
*** achanda has quit IRC | 07:33 | |
*** kevinbenton has quit IRC | 07:34 | |
*** kevinbenton has joined #openstack-ironic | 07:36 | |
*** jistr has joined #openstack-ironic | 07:39 | |
*** saripurigopi has quit IRC | 07:40 | |
*** chenglch has joined #openstack-ironic | 07:41 | |
*** saripurigopi has joined #openstack-ironic | 07:41 | |
openstackgerrit | Zhai, Edwin proposed openstack/ironic-specs: New meter for Node Manager https://review.openstack.org/176109 | 07:43 |
*** saripurigopi1 has joined #openstack-ironic | 07:44 | |
*** chlong has quit IRC | 07:45 | |
*** saripurigopi has quit IRC | 07:46 | |
*** romainh has joined #openstack-ironic | 07:47 | |
*** achanda has joined #openstack-ironic | 07:49 | |
*** dlpartain has joined #openstack-ironic | 07:59 | |
*** dlpartain has left #openstack-ironic | 08:02 | |
*** yuanying_ has quit IRC | 08:06 | |
*** yuanying has joined #openstack-ironic | 08:09 | |
*** ijw_ has quit IRC | 08:09 | |
*** eghobo has quit IRC | 08:10 | |
*** marzif_ has joined #openstack-ironic | 08:21 | |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add disk layout check on re-provisioning https://review.openstack.org/180014 | 08:21 |
*** achanda has quit IRC | 08:24 | |
*** achanda has joined #openstack-ironic | 08:30 | |
*** saripurigopi has joined #openstack-ironic | 08:31 | |
*** saripurigopi1 has quit IRC | 08:32 | |
*** athomas has joined #openstack-ironic | 08:35 | |
*** saripurigopi1 has joined #openstack-ironic | 08:35 | |
*** saripurigopi has quit IRC | 08:35 | |
*** yuanying has quit IRC | 08:39 | |
*** e0ne has joined #openstack-ironic | 09:02 | |
*** dtantsur|afk is now known as dtantsur | 09:02 | |
dtantsur | Morning folks! | 09:02 |
takadayuiko | dtantsur: morning! | 09:03 |
dtantsur | o/ | 09:04 |
*** sandhya has joined #openstack-ironic | 09:10 | |
sambetts | Morning dtantsur, takadayuiko o/ | 09:13 |
dtantsur | sambetts, o/ | 09:13 |
takadayuiko | sambetts: Morning :D | 09:13 |
*** achanda has quit IRC | 09:14 | |
openstackgerrit | Dmitry Tantsur proposed stackforge/ironic-discoverd: Repair devstack plugin after rename https://review.openstack.org/186718 | 09:16 |
dtantsur | takadayuiko, while Ironic inspection functionality in ^^^ depends on Ironic patch, we can still merge it, if it at least fixes standalone usage (via `openstack baremetal introspection start`). wdyt? | 09:16 |
*** sandhya has quit IRC | 09:18 | |
takadayuiko | dtantsur: so that, you mean... 1) merge 186718(devstack plugin) -> 2) merge 186772(ironic) ? | 09:21 |
dtantsur | takadayuiko, right (because Ironic patch can take longer to merge, and we're in a state of broken devstack plugin right now) | 09:22 |
openstackgerrit | chenglch proposed openstack/ironic-specs: Add console log support https://review.openstack.org/164586 | 09:22 |
takadayuiko | dtantsur: that's right, if we do it, we can also make the impact minimum :) I agree. | 09:23 |
dtantsur | takadayuiko, good. so let's check it once more and merge, if it works :) | 09:23 |
takadayuiko | dtantsur: Well, I will test the latest one soon, so could you please wait a minute? | 09:24 |
dtantsur | sure, I'm testing it as well | 09:24 |
*** mdbooth has quit IRC | 09:25 | |
openstackgerrit | Merged openstack/ironic-specs: Add new boot interface in Ironic https://review.openstack.org/168698 | 09:27 |
openstackgerrit | baiyuan proposed openstack/ironic: Add documentation for getting a node's console https://review.openstack.org/176642 | 09:32 |
*** edcragg has joined #openstack-ironic | 09:36 | |
*** achanda has joined #openstack-ironic | 09:38 | |
*** achanda_ has joined #openstack-ironic | 09:40 | |
*** achanda has quit IRC | 09:43 | |
dtantsur | damn, my devstack fails due to unrelated problem... | 09:44 |
takadayuiko | dtantsur: it happens often :( Rely on me! | 09:46 |
dtantsur | :) | 09:46 |
takadayuiko | dtantsur: at least, ./functest/devstack-test.sh succeed. Now I'm checking ironic node-set-provision-state inspect just in case. | 09:47 |
dtantsur | cool | 09:48 |
*** e0ne is now known as e0ne_ | 09:48 | |
*** e0ne_ is now known as e0ne | 09:50 | |
*** achanda has joined #openstack-ironic | 09:53 | |
takadayuiko | dtantsur: Done! Go ahead! | 09:53 |
dtantsur | \o/ | 09:54 |
*** achanda_ has quit IRC | 09:55 | |
*** dlpartain has joined #openstack-ironic | 09:56 | |
*** dlpartain has left #openstack-ironic | 09:56 | |
openstackgerrit | Sam Betts proposed stackforge/ironic-discoverd: Add SSL/TLS Support https://review.openstack.org/186843 | 09:56 |
sambetts | dtantsur: ^^^ I hope, I'm going about this the right way | 09:57 |
dtantsur | I'll have a look soon :) | 09:57 |
sambetts | :D | 09:59 |
*** mdbooth has joined #openstack-ironic | 10:02 | |
*** achanda has quit IRC | 10:04 | |
dtantsur | sambetts, left some comments | 10:05 |
dtantsur | thanks for working on it! | 10:05 |
rameshg87 | dtantsur: hi | 10:09 |
dtantsur | rameshg87, o/ | 10:09 |
rameshg87 | dtantsur: regarding the http return code for the API in https://review.openstack.org/#/c/173214/9/specs/liberty/ironic-generic-raid-interface.rst | 10:10 |
dtantsur | yep | 10:10 |
rameshg87 | dtantsur: 409 seems like it conflicts with the current state which might give impression that it might work some other time | 10:10 |
rameshg87 | dtantsur: doesn't it ? | 10:10 |
dtantsur | rameshg87, I was intending to write 405 | 10:10 |
dtantsur | sorry | 10:10 |
rameshg87 | dtantsur: oh okay | 10:11 |
dtantsur | 404 might work as well | 10:11 |
dtantsur | but "forbidden" is misleading | 10:11 |
rameshg87 | dtantsur: but your concern with 403 seems documented | 10:11 |
rameshg87 | dtantsur: 403 will make a user think that he/she lacks access rights, which is not true. | 10:11 |
rameshg87 | but in documentation | 10:11 |
rameshg87 | The server understood the request, but is refusing to fulfill it. Authorization will not help and the request SHOULD NOT be repeated. | 10:11 |
rameshg87 | yeah but "refusing" seems a bit bad :( | 10:12 |
dtantsur | yep | 10:12 |
dtantsur | imagine user calling our CLI and getting "403 Forbidden" | 10:13 |
openstackgerrit | Merged stackforge/ironic-discoverd: Repair devstack plugin after rename https://review.openstack.org/186718 | 10:13 |
rameshg87 | yeah i agree | 10:13 |
rameshg87 | 404 seems better | 10:15 |
rameshg87 | since we are not passing any method in 405, that might be misleading too. | 10:15 |
*** zz_naotok has quit IRC | 10:15 | |
rameshg87 | dtantsur: 404 my suggestion, wdyt ? | 10:16 |
dtantsur | lgtm | 10:16 |
* rameshg87 changes right away | 10:16 | |
*** openstackstatus has quit IRC | 10:20 | |
*** openstack has quit IRC | 10:20 | |
*** openstack has joined #openstack-ironic | 10:27 | |
*** foexle has joined #openstack-ironic | 10:30 | |
*** Nisha has quit IRC | 10:36 | |
openstackgerrit | Pratyusha proposed stackforge/proliantutils: Add iSCSI boot support in RIS https://review.openstack.org/187162 | 10:38 |
*** saripurigopi has joined #openstack-ironic | 10:41 | |
*** romainh1 has joined #openstack-ironic | 10:41 | |
*** caiobo_ has joined #openstack-ironic | 10:42 | |
*** saripurigopi1 has quit IRC | 10:43 | |
*** romainh has quit IRC | 10:43 | |
*** caiobo has quit IRC | 10:43 | |
*** mitz has quit IRC | 10:43 | |
*** mordred has quit IRC | 10:43 | |
*** mitz has joined #openstack-ironic | 10:43 | |
*** mordred has joined #openstack-ironic | 10:44 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: ironic-discoverd is being renamed to ironic-inspector https://review.openstack.org/186772 | 10:52 |
TheJulia | good morning everyone! | 10:54 |
takadayuiko | TheJulia: Morning :) | 10:54 |
dtantsur | TheJulia, morning | 10:56 |
* rameshg87 goes home | 10:59 | |
*** rameshg87 has quit IRC | 10:59 | |
dtantsur | am I the only one for whom etherpad.o.o does not save anything? | 10:59 |
*** saripurigopi1 has joined #openstack-ironic | 11:03 | |
*** saripurigopi has quit IRC | 11:03 | |
sambetts | dtantsur: Thanks for the comments :) | 11:10 |
dtantsur | yvw | 11:10 |
*** saripurigopi1 has quit IRC | 11:14 | |
*** saripurigopi has joined #openstack-ironic | 11:16 | |
*** e0ne has quit IRC | 11:21 | |
*** chenglch has quit IRC | 11:21 | |
*** e0ne has joined #openstack-ironic | 11:30 | |
*** takadayuiko has quit IRC | 11:42 | |
*** albertoffb has joined #openstack-ironic | 11:45 | |
*** dprince has joined #openstack-ironic | 11:58 | |
*** edcragg_ has joined #openstack-ironic | 12:01 | |
*** edcragg has quit IRC | 12:02 | |
*** dlpartain has joined #openstack-ironic | 12:06 | |
*** dlpartain has quit IRC | 12:06 | |
*** dlpartain has joined #openstack-ironic | 12:10 | |
*** dlpartain has left #openstack-ironic | 12:11 | |
openstackgerrit | Feng Xi Yan proposed openstack/ironic: Add documentation for getting a node's console https://review.openstack.org/176642 | 12:13 |
*** trown|outttypeww is now known as trown | 12:15 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Use Cirros for CI testing https://review.openstack.org/187067 | 12:46 |
*** saripurigopi has quit IRC | 12:47 | |
*** saripurigopi has joined #openstack-ironic | 12:48 | |
*** chlong has joined #openstack-ironic | 12:49 | |
radek_ | Morning All!!! | 12:55 |
radek_ | I have a quick question, just trying to setup by dev Ironic | 12:55 |
radek_ | and want to use sqlite for now, but when I run ironic-dbsync, I got this exception: NotImplementedError: No support for ALTER of constraints in SQLite dialect | 12:55 |
radek_ | I am wondering is sqlite is supported at all ? | 12:56 |
dtantsur | radek_, hi there, it is with one issue: | 12:57 |
dtantsur | radek_, migration really is not supported, use $ ironic-dbsync --config-file ... create_schema | 12:57 |
dtantsur | if you need to update schema, you'll have to drop sqlite file and run it again | 12:57 |
dtantsur | hope that helps | 12:58 |
radek_ | hmmm I don't have an existing sqlite file yet | 12:58 |
radek_ | ok let me try . . . . | 12:58 |
*** [1]cdearborn has joined #openstack-ironic | 12:58 | |
*** ukalifon1 has quit IRC | 12:58 | |
radek_ | dtantsur_, I removed my old sqlite file and run the command you recommended but this time I end up with: DbMigrationError: DB schema is already under version control. Use upgrade() instead | 13:00 |
dtantsur | radek_, after you ran dbsync for the first time, you do have an existing file. it should be deleted before create_schema | 13:00 |
dtantsur | (in your case seems like you've removed the wrong file) | 13:01 |
radek_ | hmmm this may be an issue here :) | 13:01 |
radek_ | I will double check this | 13:02 |
radek_ | indeed that was the problem, thanks a million! | 13:03 |
dtantsur | you're welcome | 13:03 |
*** ukalifon1 has joined #openstack-ironic | 13:05 | |
sambetts | dtantsur: Are you using the DocImpact flag for inspector commit messages? | 13:10 |
*** rloo has joined #openstack-ironic | 13:11 | |
dtantsur | sambetts, inspector is not covered by the doc team, so no | 13:11 |
*** thiagop has joined #openstack-ironic | 13:11 | |
sambetts | dtantsur: cool :) | 13:12 |
*** ukalifon1 has quit IRC | 13:12 | |
dtantsur | sambetts, the only documentation for inspector now is its README :) | 13:12 |
radek_ | dtantsur_, "ironic-dbsync --debug . . . . ." wouldn't it be nice to print the connection string or where we create the database file if this is sqlite? | 13:20 |
openstackgerrit | Sam Betts proposed stackforge/ironic-discoverd: Add SSL/TLS Support https://review.openstack.org/186843 | 13:24 |
*** achanda has joined #openstack-ironic | 13:29 | |
*** achanda has quit IRC | 13:30 | |
*** achanda has joined #openstack-ironic | 13:31 | |
*** saripurigopi has quit IRC | 13:34 | |
*** e0ne has quit IRC | 13:35 | |
*** achanda has quit IRC | 13:35 | |
*** dlpartain has joined #openstack-ironic | 13:43 | |
*** dlpartain has left #openstack-ironic | 13:43 | |
*** dhellmann has left #openstack-ironic | 13:44 | |
dtantsur | radek_, well, it would :) please file a bug | 13:52 |
*** ukalifon1 has joined #openstack-ironic | 13:53 | |
*** jrist has joined #openstack-ironic | 13:54 | |
*** jrist has quit IRC | 13:54 | |
*** jrist has joined #openstack-ironic | 13:54 | |
jroll | morning all :) | 13:56 |
jroll | "tl;dr: To simplify release management, especially for projects releasing more than one time per cycle, we would like projects currently using date-based versioning to move to semver." | 13:56 |
jroll | woot | 13:56 |
dtantsur | \o/ | 13:58 |
dtantsur | also wsme released | 13:58 |
dtantsur | \o/ | 13:58 |
dtantsur | and g'morning, jroll :) | 13:58 |
jroll | \o/ morning! | 13:59 |
openstackgerrit | Radoslaw Smigielski proposed openstack/ironic: ironic-dbsync to log connection string when run in debug https://review.openstack.org/187203 | 14:05 |
radek_ | dtantsur_, how about this https://review.openstack.org/#/c/187203/ ? | 14:06 |
dtantsur | looking now | 14:06 |
dtantsur | radek_, left one comment | 14:07 |
*** romcheg has joined #openstack-ironic | 14:13 | |
radek_ | dtantsur_, I thought about the same, it's only with debug enabled but to be on safe site I will rework it to remove this | 14:15 |
*** achanda has joined #openstack-ironic | 14:18 | |
*** achanda has quit IRC | 14:18 | |
*** achanda has joined #openstack-ironic | 14:18 | |
NobodyCam | good morning Ironicers | 14:18 |
sambetts | o/ NobodyCam | 14:19 |
NobodyCam | mornign sambetts :) | 14:19 |
BadCub | mornin folks | 14:20 |
rloo | morning and hello NobodyCam, sambetts, dtantsur, jroll, radek_ | 14:20 |
NobodyCam | morning rloo :) | 14:21 |
jroll | morning rloo, BadCub, NobodyCam, sambetts, radek_ :) | 14:21 |
NobodyCam | morning jroll | 14:21 |
dtantsur | morning NobodyCam, BadCub, rloo | 14:21 |
* jroll passes out coffee | 14:21 | |
NobodyCam | morning dtantsur | 14:21 |
NobodyCam | oh coffee | 14:21 |
BadCub | mornin rloo dtantsur jroll NobodyCam | 14:21 |
NobodyCam | thnak you thank you | 14:22 |
NobodyCam | morning BadCub | 14:22 |
BadCub | mmmm coffee | 14:22 |
rloo | hey, lucas doesn't seem to be around. From the summit, we discussed 'moving' vendor passthru's heartbeat/pass_deploy_info into a method in DeployInterface. I figured that meant changing the API endpoint for it too? Or do people think we'd still do /v1/nodes/../vendor_passthru/<method> ? | 14:23 |
*** achanda_ has joined #openstack-ironic | 14:28 | |
*** krtaylor has quit IRC | 14:30 | |
*** achanda has quit IRC | 14:30 | |
*** mtanino has joined #openstack-ironic | 14:31 | |
thiagop | morning | 14:32 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: Add "enroll" state to the state machine https://review.openstack.org/179151 | 14:32 |
dtantsur | rloo, I hope I fixed ^^^ | 14:32 |
dtantsur | thiagop, morning | 14:32 |
thiagop | jroll: I understand that you're "in charge" of implementing the blueprint on boot interface. Is that any work already to take a look (if not, would you like some help with that)? | 14:33 |
rloo | dtantsur: will look soon (well, sometime today anyway, still going through my emails etc) | 14:33 |
dtantsur | yeah, np | 14:33 |
jroll | thiagop: nooooo, I am not in charge of that at all, that I know of | 14:33 |
jroll | thiagop: you want rameshg87 (not here right now) | 14:34 |
thiagop | aw, ok. Maybe we should update that blueprint then. :) | 14:34 |
*** Nick_A has left #openstack-ironic | 14:35 | |
jroll | thiagop: heh, indeed, got a link? | 14:35 |
jroll | there is https://review.openstack.org/#/c/166512/ | 14:35 |
jroll | but idk about a spec | 14:35 |
thiagop | https://blueprints.launchpad.net/ironic/+spec/new-boot-interface | 14:35 |
jroll | thanks | 14:36 |
jroll | thiagop: spec is here btw https://review.openstack.org/#/c/168698/ | 14:36 |
jroll | fixed the bp | 14:37 |
*** kan_ has quit IRC | 14:37 | |
thiagop | I think an update to this patch commit message is better (reference the BP). I can help with that... | 14:37 |
openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: Add boot interface in Ironic https://review.openstack.org/166512 | 14:39 |
*** dguerri is now known as dguerri`away | 14:40 | |
*** dguerri`away is now known as dguerri | 14:40 | |
*** zz_jgrimm is now known as jgrimm | 14:40 | |
thiagop | done | 14:41 |
thiagop | thanks jroll | 14:41 |
*** krtaylor has joined #openstack-ironic | 14:42 | |
jroll | np | 14:42 |
*** achanda has joined #openstack-ironic | 14:44 | |
*** achanda__ has joined #openstack-ironic | 14:45 | |
*** achanda has quit IRC | 14:48 | |
*** achanda_ has quit IRC | 14:49 | |
*** absubram has quit IRC | 14:50 | |
NobodyCam | oh brb.... | 14:50 |
*** achanda__ has quit IRC | 14:50 | |
*** e0ne has joined #openstack-ironic | 14:52 | |
*** e0ne is now known as e0ne_ | 14:52 | |
*** achanda has joined #openstack-ironic | 14:54 | |
*** e0ne_ is now known as e0ne | 14:56 | |
*** achanda_ has joined #openstack-ironic | 14:59 | |
*** achanda has quit IRC | 15:01 | |
krotscheck | Argh. I am stuck between rock and hard place. | 15:04 |
krotscheck | There's a non-trivial faction inside openstack that believe all parts of openstack should be dependent on keystone. | 15:04 |
openstackgerrit | baiyuan proposed openstack/ironic: fix node-get-console returns url always start with http https://review.openstack.org/185523 | 15:05 |
openstackgerrit | baiyuan proposed openstack/ironic: fix node-get-console returns url always start with http https://review.openstack.org/185523 | 15:09 |
rloo | anyone know when this week's ironic meeting is? I'm thinking today 1700 UTC? | 15:09 |
*** penick has joined #openstack-ironic | 15:11 | |
*** hemnabeer is now known as hemna | 15:11 | |
NobodyCam | ya I believe that is correct | 15:11 |
rloo | thx NobodyCam | 15:12 |
*** dprince has quit IRC | 15:13 | |
*** penick has quit IRC | 15:13 | |
*** rameshg87 has joined #openstack-ironic | 15:14 | |
*** david-ly_ is now known as david-lyle | 15:21 | |
*** ChuckC_ has quit IRC | 15:21 | |
*** ChuckC_ has joined #openstack-ironic | 15:22 | |
*** achanda has joined #openstack-ironic | 15:24 | |
rloo | hi dtantsur, wrt Inspector https://review.openstack.org/#/c/186772/ | 15:26 |
rloo | dtantsur: not sure what/if backwards compatibility is needed | 15:26 |
dtantsur | rloo, I expect this patch to be backward compatible. do you think something is wrong with it? | 15:27 |
rloo | dtantsur: eg discoverd + ironic-k, discoverd+ironic-l, inspector+ironic-k, inspector+ironic-l? | 15:27 |
*** achanda_ has quit IRC | 15:27 | |
rloo | dtantsur: dunno if anything wrong yet; need to know what it should support first :-) | 15:27 |
dtantsur | I expect all of these to work | 15:28 |
*** leopoldj has quit IRC | 15:30 | |
rloo | dtantsur: ok, will check :-) | 15:30 |
dtantsur | thnx :) | 15:30 |
*** romcheg has quit IRC | 15:31 | |
rloo | dtantsur: shouldn't it be s/inspector/inspectR/ ? | 15:32 |
rloo | dtantsur: (just kidding) | 15:32 |
dtantsur | lol | 15:32 |
*** foexle has quit IRC | 15:36 | |
*** subscope has joined #openstack-ironic | 15:37 | |
cinerama | greetings programs | 15:40 |
NobodyCam | morning cinerama | 15:40 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Update iLO documentation for UEFI secure boot https://review.openstack.org/178582 | 15:43 |
rloo | dtantsur: ironic-inspector package doesn't exist yet, right? | 15:43 |
dtantsur | rloo, python package is in ironic-discoverd repo for now | 15:44 |
rloo | dtantsur: ok | 15:44 |
dtantsur | I hope to get TC approval for renaming (and creating ironic_inspector_client which we'll actually use) tomorrow | 15:45 |
rloo | dtantsur: cool | 15:47 |
jroll | reminder: this meeting happens in like 10 minutes for those interested https://wiki.openstack.org/wiki/Meetings/Ironic-neutron | 15:49 |
jroll | ironic/neutron integration stuff | 15:49 |
jroll | #openstack-meeting-4 | 15:49 |
*** Sukhdev has joined #openstack-ironic | 15:49 | |
lazy_prince | jroll: will be there for the meeting.. :) | 15:49 |
*** e0ne is now known as e0ne_ | 15:50 | |
*** dlpartain has joined #openstack-ironic | 15:50 | |
jroll | :) | 15:50 |
*** e0ne_ is now known as e0ne | 15:51 | |
*** eghobo has joined #openstack-ironic | 15:53 | |
*** absubram has joined #openstack-ironic | 15:54 | |
* BadCub heads off to morning meeting[s] | 15:55 | |
jlvillal | Good morning Ironic | 15:55 |
jroll | mornin' jlvillal | 15:55 |
*** ifarkas has quit IRC | 15:55 | |
*** zz_natorious is now known as natorious | 15:56 | |
jlvillal | jroll: I'll (virtually) see you in the Neutron meeting. I'm supposed to attend to possibly tell Nova people interesting things. | 15:56 |
*** stendulker has joined #openstack-ironic | 15:56 | |
*** eghobo_ has joined #openstack-ironic | 15:56 | |
NobodyCam | mornign jlvillal | 15:57 |
jroll | jlvillal: huh, ok, my plan was to just make a thing to point them at "what we need to do" and some patches | 15:57 |
jlvillal | jroll: I like your plan. I just saw last week devananda on #openstack-nova that I should attend. | 15:59 |
jlvillal | jroll: I think you will know much better than me on what should be done. | 15:59 |
*** natorious is now known as zz_natorious | 15:59 | |
jroll | jlvillal: sure, you totally should :) just letting you know what my plan is | 15:59 |
*** eghobo has quit IRC | 16:00 | |
openstackgerrit | baiyuan proposed openstack/ironic: Add documentation for getting a node's console https://review.openstack.org/176642 | 16:00 |
NobodyCam | dtantsur: looking to land discover -> inspector name change asap, or wanting to give others time to also review | 16:05 |
dtantsur | NobodyCam, I don't think it's too interesting for a lot of people :) but as you wish, I'm not in hurry with this one | 16:07 |
NobodyCam | :) | 16:07 |
*** subscope has quit IRC | 16:07 | |
rloo | now he tells me he isn't in a hurry ... :) | 16:07 |
*** Nisha has joined #openstack-ironic | 16:08 | |
NobodyCam | lol | 16:08 |
dtantsur | rloo, we were in a big hurry, but we figured out how to unbreak our devstack plugin without this patch :) | 16:09 |
dtantsur | so thank you for timely review | 16:09 |
*** ukalifon1 has quit IRC | 16:09 | |
rloo | dtantsur: just for that, I should make you update the commit msg :-) | 16:09 |
dtantsur | oh | 16:10 |
*** jistr has quit IRC | 16:11 | |
*** eghobo_ has quit IRC | 16:14 | |
*** bethelwell has joined #openstack-ironic | 16:15 | |
*** eghobo has joined #openstack-ironic | 16:22 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic: Revert "Add simplegeneric to py34 requirements" https://review.openstack.org/186208 | 16:23 |
dtantsur | jlvillal, make sure new version of wsme is in global-req before we do ^^^ | 16:24 |
jlvillal | dtantsur: Do you want to specify >=0.7? | 16:25 |
dtantsur | jlvillal, we have to, otherwise it still may fail for people | 16:25 |
jlvillal | dtantsur: Okay. I can do that. Thanks | 16:25 |
jlvillal | dtantsur: https://review.openstack.org/187248 | 16:27 |
* jlvillal goes to make that a dependency for his other patch | 16:28 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic: Revert "Add simplegeneric to py34 requirements" https://review.openstack.org/186208 | 16:29 |
*** pradipta has joined #openstack-ironic | 16:31 | |
*** alexpilotti has joined #openstack-ironic | 16:35 | |
* NobodyCam somkes before meeting | 16:36 | |
*** dprince has joined #openstack-ironic | 16:38 | |
* TheJulia noms lunch | 16:38 | |
*** rameshg87 has quit IRC | 16:39 | |
*** romainh1 has left #openstack-ironic | 16:40 | |
*** dkehn__ is now known as dkehn | 16:42 | |
*** trown is now known as trown|lunch | 16:44 | |
sambetts | dtantsur: trying to work out what the best way to test for the python version is in the SSL patch, I've currently got two ways which should work, either directly quering sys for the version info, or doing getattr on ssl to make sure the right function exists, both of which I can't decide what a nice way to UT is | 16:45 |
dtantsur | sambetts, I would go for sys.version approach (mostly random decision though) | 16:46 |
sambetts | dtantsur: Still not sure how to UT it :/ and unless I modify all the UTs I've written it means it assumes the UTs are run on a version equal to or higher than 2.7.9 | 16:48 |
sambetts | python 2.6 support was deprecated in Juno wasn't it, so do we need the check? | 16:49 |
* dtantsur finally guessed what UT means (spoiler: not Unreal Tournament) | 16:49 | |
dtantsur | python 2.7.8 also won't work | 16:49 |
NobodyCam | dtantsur: lol | 16:49 |
dtantsur | so, now to testing: I think you can mock.patch sys module as well | 16:50 |
sambetts | dtantsur: that assumes knowledge of how the function works though | 16:51 |
dtantsur | which function you mean? | 16:51 |
dtantsur | for sys.version_info approach you only mock sys.version_info | 16:51 |
sambetts | dtantsur: that assumes the code is using sys.version_info to do the check | 16:51 |
dtantsur | sambetts, right, you probably know what your code is doing :) I'm probably missing something in your question, as it does not look a problem to me | 16:52 |
*** ijw has joined #openstack-ironic | 16:53 | |
*** davideagnello has joined #openstack-ironic | 16:53 | |
sambetts | dtantsur: in my mind unit tests shouldn't assume the code does something one way, it should be a test of if the out come is the expected one, given a certain input, so how the code checks for the version shouldn't matter, whether is via version_info or getattr or platform.version as long as the out come is what was expected it should pass | 16:54 |
*** e0ne has quit IRC | 16:55 | |
dtantsur | sambetts, "unit tests shouldn't assume the code does something one way", actually they should - unit tests are white box tests | 16:55 |
dtantsur | now I see the confusion | 16:55 |
*** davideagnello has quit IRC | 16:55 | |
dtantsur | unit testing always assumes full knowledge of internals, otherwise mocking does not make much sense - as you correctly spotted | 16:56 |
jlvillal | dtantsur: +1 | 16:56 |
devananda | gah. vegas. this place smells like stale cigarretes | 16:56 |
dtantsur | lol | 16:56 |
dtantsur | morning devananda | 16:57 |
devananda | g'morning | 16:57 |
jlvillal | I think unit tests are 'white box' tests. At least how we have done them in Ironic. We know for sure the internal workings of the function we are testing. | 16:57 |
jlvillal | It doesn't mean we shouldn't also have some 'black box' testing. Which I think is a goal of the functional testing. | 16:57 |
* jlvillal will hopefully meet with adam_g to discuss the functional testing tomorrow :) | 16:58 | |
* NobodyCam heads over to meeting room | 16:59 | |
* jroll throws a pack of cigarettes at devananda, when in rome | 16:59 | |
NobodyCam | so many meetings | 16:59 |
NobodyCam | morning devananda | 16:59 |
*** zz_natorious is now known as natorious | 17:00 | |
*** spandhe has joined #openstack-ironic | 17:00 | |
sambetts | dtantsur: today I learned XD that makes more sense | 17:01 |
dtantsur | :) | 17:01 |
*** natorious is now known as zz_natorious | 17:01 | |
*** BertieFulton has joined #openstack-ironic | 17:01 | |
Sukhdev | lazy_prince: lets discuss the switch id information here | 17:01 |
*** caiobo_ has quit IRC | 17:01 | |
jroll | lazy_prince: so, I think the creds discussion is an important one - can we leave that up to the mech driver or so we want to standardize it or? | 17:02 |
*** bethelwell has quit IRC | 17:02 | |
morgabra | Sukhdev: lazy_prince: I'm inclined to suggest leaving it up to the implementing driver | 17:02 |
morgabra | jroll beat me | 17:02 |
jroll | guidelines would be cool to have | 17:02 |
*** zz_natorious is now known as natorious | 17:02 | |
jroll | like "these should be stored encrypted" | 17:02 |
morgabra | however, there is lots of value in formalizing something like that... | 17:03 |
morgabra | as it stands right now, it's pretty much impossible to do any kind of validation about the physical connectivity information you are passing in | 17:03 |
Sukhdev | As an FYI - we implement switch creeds out of neutron for Arista drivers | 17:03 |
morgabra | like, what happens if you pass in the same port twice? | 17:03 |
jroll | Sukhdev: file on disk or? | 17:04 |
Sukhdev | and most of the vendors do it this way - this is left to the vendors | 17:04 |
Sukhdev | jroll:neither - | 17:04 |
jroll | so how does it work? | 17:04 |
Sukhdev | we have a config option, which goes into the switch - the networking groups are paranoid about this information going into the hands of server groups:-) | 17:05 |
jroll | in the bare metal case, the mech driver needs to log in to switches or hit the switch api | 17:05 |
jroll | which means you need creds | 17:05 |
lazy_prince | i am interested and listening.. | 17:05 |
Sukhdev | hence, the creeds are only available to networking folks - and, they have a config command to specify it | 17:05 |
jroll | so how does neutron authenticate to the switch? | 17:05 |
morgabra | jroll: you can add arbitrary config options for mech drivers | 17:06 |
morgabra | so it's probably just a static config thing | 17:06 |
Sukhdev | jroll: we use two step process - | 17:06 |
lazy_prince | that would mean mech drivers per switch.. i could be worng too.. | 17:06 |
*** achanda has quit IRC | 17:07 | |
Sukhdev | there is one entry point for which the creeds are specified in the .ini file- this is how neutron (drivers know where the information is) | 17:07 |
*** spandhe_ has joined #openstack-ironic | 17:07 | |
Sukhdev | drivers then use this entry point to get in then the switch creeds are hidden under that entry point | 17:08 |
jroll | so they run code to get the credentials? | 17:08 |
*** achanda has joined #openstack-ironic | 17:08 | |
Sukhdev | so, the server group can not see them and can not fiddle with the switches | 17:08 |
*** spandhe has quit IRC | 17:08 | |
*** spandhe_ is now known as spandhe | 17:08 | |
lazy_prince | that is okay when there is one mech driver per switch.. but here we may have different switches for different nodes being managed by same compute..... | 17:08 |
*** abrito has joined #openstack-ironic | 17:09 | |
Sukhdev | kinda - when switches are configured to participate in OpenStack management, there is configuration which is used to register these switches with the entry point - | 17:09 |
openstackgerrit | Merged openstack/ironic: Update doc "install from packages" section to include Red Hat https://review.openstack.org/186714 | 17:09 |
Sukhdev | lazy_prince: no, multiple switches can be managed by one driver - | 17:09 |
jroll | ok, so | 17:10 |
jroll | we need to allow non-standard things | 17:10 |
jroll | so "leave it up to the mech driver" | 17:10 |
openstackgerrit | Merged openstack/ironic: Remove deprecated pxe_deploy_{kernel, ramdisk} https://review.openstack.org/185937 | 17:10 |
Sukhdev | regardless, I think the creds is a vendor specific issue, and we should leave it for them to deal with | 17:10 |
jroll | yeah, I can deal with that | 17:11 |
lazy_prince | agreed.. | 17:11 |
Sukhdev | cool, so we are in sync on this issue then | 17:11 |
lazy_prince | for now.. yes.. :) | 17:12 |
jroll | heh | 17:12 |
Sukhdev | lazy_prince: we use very elaborate scheme to deal with this - take a look at our ML2 driver - | 17:13 |
*** davideagnello has joined #openstack-ironic | 17:14 | |
Sukhdev | lazy_prince: I have seen other vendors who use very simple scheme | 17:14 |
*** achanda has quit IRC | 17:14 | |
Sukhdev | lazy_prince: depending upon the customers (and deployment scenarios) many customers are very paranoid about creeds going into wrong hands - hence, we do not put them in any file | 17:15 |
lazy_prince | Sukhdev: I will.. for now, it is time for me to hit the road... will check and get back to you in case of doubts/questions.. | 17:16 |
lazy_prince | Good night all... | 17:16 |
Sukhdev | lazy_prince: GN | 17:17 |
jroll | see ya lazy_prince :) | 17:17 |
*** BertieFulton has left #openstack-ironic | 17:19 | |
dtantsur | jlvillal, as you work on https://wiki.openstack.org/wiki/Nova-Ironic-Bugs: can we work together to add some nova-ironic bugs stats/listings to http://ironic-bugs.divius.net/ ? | 17:21 |
jlvillal | dtantsur: Sure. I would need to learn how to do that. | 17:21 |
dtantsur | jlvillal, source is at https://github.com/divius/ironic-bug-dashboard hosted on my web site (will probably move it to openshift in the future) | 17:22 |
jlvillal | dtantsur: I will look at it today. Or tomorrow, a lot of meetings today :( | 17:23 |
dtantsur | yeah, sure | 17:24 |
dtantsur | ping me if you need help or pr merged | 17:24 |
*** lazy_prince has quit IRC | 17:25 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Use Cirros for CI testing https://review.openstack.org/187067 | 17:27 |
*** stendulker has quit IRC | 17:39 | |
openstackgerrit | Sam Betts proposed stackforge/ironic-discoverd: Add SSL/TLS Support https://review.openstack.org/186843 | 17:44 |
*** trown|lunch is now known as trown | 17:49 | |
*** Sukhdev has quit IRC | 17:49 | |
* dtantsur made lp:~ironic-bugs bug maintainers for ironic-inspector, hope nobody objects | 17:51 | |
jroll | I object to any objections! | 17:51 |
*** achanda has joined #openstack-ironic | 17:54 | |
*** achanda_ has joined #openstack-ironic | 17:55 | |
*** zhenguo has quit IRC | 17:57 | |
*** achanda_ has quit IRC | 17:57 | |
*** Sukhdev has joined #openstack-ironic | 17:57 | |
*** achanda has quit IRC | 17:58 | |
*** achanda has joined #openstack-ironic | 17:59 | |
NobodyCam | great meeting all ... THnak you | 18:01 |
* NobodyCam pops out for smoke | 18:01 | |
Nisha | can we continue on capabilities here... | 18:01 |
NobodyCam | yes | 18:01 |
*** wanyen has joined #openstack-ironic | 18:02 | |
thiagop | +1 | 18:02 |
devananda | in -nova, pls | 18:02 |
devananda | as this hinges on Nova's approval / view of the world | 18:02 |
Nisha | devananda, i proposed 4 specs for capabilities , 2 in Nova and 2 in ironic... | 18:02 |
Nisha | but devananda it requires our vote on the approach too | 18:03 |
*** edcragg_ has quit IRC | 18:03 | |
devananda | Nisha: can you summarize the two different approaches and their benefits / drawbacks? | 18:03 |
*** pradipta has quit IRC | 18:03 | |
Nisha | nova changes is dependent on ironic and vice versa | 18:03 |
*** diegolp has joined #openstack-ironic | 18:03 | |
*** JayF has left #openstack-ironic | 18:03 | |
*** eghobo_ has joined #openstack-ironic | 18:03 | |
*** JayF has joined #openstack-ironic | 18:03 | |
thiagop | Nisha: It appears that people are going to continue the discussion in -nova | 18:03 |
*** alexpilotti has quit IRC | 18:03 | |
*** sinval has joined #openstack-ironic | 18:03 | |
Nisha | thiagop, agreed but similar changes might be required in ironic too | 18:04 |
Nisha | for example when we say nova will call ironic API , we need to know what will the ironic API do | 18:05 |
jroll | well | 18:05 |
jroll | nova seems opposed to this | 18:05 |
jroll | if nova won't let it happen, it doesn't matter what we decide for iroinc | 18:05 |
jroll | so let's focus on nova first | 18:05 |
Nisha | devananda, the approach i proposed was : 1. convert the capabilities to dictionary. This requires changes in ironic, ironic-client and nova-ironic virt driver | 18:06 |
*** eghobo has quit IRC | 18:06 | |
Nisha | This should be able to handle multiple values for a capability key | 18:06 |
Nisha | the second problem is with the operators | 18:08 |
wanyen | are we supposed to join nova irc to discuss capabilities now? | 18:08 |
Nisha | nova just picks up the node based on operators | 18:08 |
Nisha | these operators actually may not mean nothing for ironic for the act-upon capabilities | 18:09 |
Nisha | i just proposed one new filter in nova which will filter out the node if it is act-upon capabilities with only few applicable operators | 18:10 |
devananda | nova objects to having non-structured "pass through to the driver" interface | 18:10 |
Nisha | for this filter to work we require changes in ironic as the filter will need to call the ironic API to get list of act-upon capabilities | 18:10 |
*** achanda_ has joined #openstack-ironic | 18:10 | |
Nisha | devananda, sorry but i dont understand the statement | 18:11 |
Nisha | the current scheduling ComputeCapability filter will still be called | 18:11 |
Nisha | with the approach given above | 18:12 |
Nisha | the new filter is called upon after the ComputeCapability filter | 18:12 |
Nisha | devananda, i thought it would be clean approach... | 18:13 |
*** achanda has quit IRC | 18:13 | |
dtantsur | pretty late, going now, g'night | 18:15 |
*** dtantsur is now known as dtantsur|afk | 18:15 | |
*** achanda_ has quit IRC | 18:16 | |
wanyen | Nisha, based on my understanding of your spec, ComputeCapabilitiesFilter will call IronicFilter after it selects a node matching all the falvors. The Ironic Filter will then call Ironic API to get a list of node capabilitites supported by the bare-metal node and then only passes the node capabilitites flavors that needs to be act upon. Right? | 18:17 |
sambetts | Night all | 18:19 |
devananda | gotta relocate, bbiah | 18:23 |
*** athomas_ has quit IRC | 18:26 | |
*** dlpartain has quit IRC | 18:26 | |
Nisha | wanyen, yes | 18:28 |
*** krtaylor has quit IRC | 18:37 | |
*** ijw has quit IRC | 18:41 | |
*** penick has joined #openstack-ironic | 18:41 | |
*** Sukhdev has quit IRC | 18:45 | |
*** natorious is now known as zz_natorious | 18:46 | |
*** bethelwell has joined #openstack-ironic | 18:53 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Validate capability in properties and instance_info https://review.openstack.org/174785 | 19:02 |
*** romainh has joined #openstack-ironic | 19:05 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Update iLO documentation for UEFI secure boot https://review.openstack.org/178582 | 19:05 |
*** penick has quit IRC | 19:08 | |
*** tab__ has joined #openstack-ironic | 19:10 | |
*** e0ne has joined #openstack-ironic | 19:10 | |
*** achanda has joined #openstack-ironic | 19:12 | |
*** penick has joined #openstack-ironic | 19:12 | |
*** achanda_ has joined #openstack-ironic | 19:14 | |
*** achanda has quit IRC | 19:16 | |
*** romcheg has joined #openstack-ironic | 19:17 | |
*** ChuckC_ has quit IRC | 19:19 | |
*** achanda has joined #openstack-ironic | 19:20 | |
*** achanda_ has quit IRC | 19:22 | |
*** romainh has left #openstack-ironic | 19:23 | |
*** e0ne has quit IRC | 19:24 | |
*** achanda has quit IRC | 19:24 | |
*** eghobo_ has quit IRC | 19:26 | |
*** wanyen has quit IRC | 19:27 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Use Cirros for CI testing https://review.openstack.org/187067 | 19:28 |
TheJulia | ^^^ For those interested in bifrost, that should cut our CI job time down quite a bit. | 19:29 |
*** Sukhdev has joined #openstack-ironic | 19:34 | |
*** achanda has joined #openstack-ironic | 19:34 | |
Shrews | TheJulia: ooh, nice. does that change the memory requirements for the vm at all? | 19:35 |
TheJulia | not really. :( I think we could knock the footprint down 500MB, but IPA still needs a good chunk of ram to fire up and run | 19:38 |
*** achanda_ has joined #openstack-ironic | 19:38 | |
*** ubuntu_ has joined #openstack-ironic | 19:40 | |
*** achanda has quit IRC | 19:41 | |
openstackgerrit | Sam Betts proposed stackforge/ironic-discoverd: Add SSL/TLS Support https://review.openstack.org/186843 | 19:50 |
*** achanda_ has quit IRC | 19:58 | |
*** penick has quit IRC | 20:02 | |
*** jgrimm is now known as zz_jgrimm | 20:03 | |
openstackgerrit | Alex Weeks proposed openstack/ironic-specs: Add pluggable metrics backend for Ironic and IPA https://review.openstack.org/137171 | 20:04 |
JayF | TheJulia: what were we using for a guest? | 20:05 |
JayF | OH; bifrost | 20:05 |
JayF | gotcha | 20:05 |
TheJulia | Bifrost just uses the coreos image that comes out of the IPA test job | 20:05 |
*** eghobo has joined #openstack-ironic | 20:07 | |
JayF | for an OS image to deploy? | 20:07 |
*** martini has joined #openstack-ironic | 20:10 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic: Revert "Add simplegeneric to py34 requirements" https://review.openstack.org/186208 | 20:10 |
TheJulia | JayF: to deploy an OS image, in the near future cirros since its fast and lightweight :) | 20:13 |
*** ubuntu_ has quit IRC | 20:15 | |
*** tab__ has quit IRC | 20:16 | |
jlvillal | Anyone interested in taking a look at: https://review.openstack.org/#/c/181985/ Refactor resource_fields.py | 20:16 |
*** krtaylor has joined #openstack-ironic | 20:22 | |
*** radek_ has quit IRC | 20:23 | |
*** zz_natorious is now known as natorious | 20:42 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/186931 | 20:45 |
*** Nisha has quit IRC | 20:47 | |
*** penick has joined #openstack-ironic | 20:55 | |
*** albertoffb has quit IRC | 21:04 | |
*** romcheg1 has joined #openstack-ironic | 21:10 | |
*** romcheg has quit IRC | 21:11 | |
*** bethelwell has quit IRC | 21:17 | |
*** lekha has quit IRC | 21:18 | |
*** lekha has joined #openstack-ironic | 21:19 | |
mrda | Morning Ironic | 21:26 |
jlvillal | mrda: Good morning | 21:26 |
* jlvillal goes off to the post office... | 21:27 | |
NobodyCam | morning mrda | 21:27 |
mrda | o/ | 21:27 |
NobodyCam | jroll: I just addded a second +2 to https://review.openstack.org/#/c/168799 .. ipa logging spec. JayF had a +2 a couple revs back. but you had a -1 for sending logs on every heartbeat. would you happen to have any time to take another look? | 21:29 |
jroll | NobodyCam: lemme see... | 21:31 |
jroll | ok, so still sending on heartbeats | 21:31 |
jroll | that seems like a *huge* payload | 21:31 |
jroll | I'd love to see perf impact of that | 21:31 |
*** trown is now known as trown|outttypeww | 21:31 | |
NobodyCam | the logs will be sent incrementally | 21:32 |
*** penick has quit IRC | 21:32 | |
jroll | yeah, still | 21:32 |
jroll | dmesg over 60 seconds can be large :P | 21:32 |
NobodyCam | but the first hartbeat could be largeish | 21:32 |
NobodyCam | ya | 21:32 |
jroll | yeah | 21:33 |
jroll | I'm having trouble thinking of better ways, though, idk | 21:33 |
JayF | how about an explicit API call from the conductor | 21:33 |
JayF | synchronous | 21:33 |
NobodyCam | maybe we should get some performance impact data | 21:33 |
JayF | that just gives all the logs | 21:33 |
devananda | one thing I thnk we're going to need this cycle | 21:34 |
devananda | is some db refactoring | 21:34 |
*** Sukhdev has quit IRC | 21:34 | |
devananda | eg, to handle receiving a stream of logs | 21:34 |
jroll | devananda: these aren't stored in the db | 21:34 |
devananda | ditto for the consolelogs that have been proposed -- it'd be the same table structure, but a different table | 21:34 |
devananda | jroll: they should be. no? | 21:34 |
jroll | devananda: idk. dumping to ironic logs seems fine to me | 21:34 |
devananda | erm | 21:35 |
devananda | how is that feasible? | 21:35 |
jroll | I don't want every agent's dmesg in my db | 21:35 |
JayF | Why would it be OK to store thousands of nodes' worth of IPA logs into a DB? | 21:35 |
devananda | imagine I'm doing 100 deploys from 1 conductor. I really don't want all of those agent's logs in my conductor log file | 21:35 |
jroll | well | 21:35 |
jroll | https://review.openstack.org/#/c/168799/10/specs/liberty/deploy-agent-logging.rst | 21:35 |
JayF | I certainly don't want them in my DB if it's too much info for a logfile | 21:35 |
jroll | comment away! | 21:35 |
JayF | lol | 21:35 |
jroll | I don't understand why you wouldn't want those in conductor logs | 21:35 |
devananda | because in the DB, I can shove those into sphinx and elasticsearch them | 21:35 |
jroll | separate file, maybe | 21:36 |
jroll | you can do that with conductor logs too | 21:36 |
jroll | ship to logstash | 21:36 |
devananda | jroll: separate file ++ | 21:36 |
jroll | boom, done | 21:36 |
devananda | because filtering | 21:36 |
devananda | hmm | 21:36 |
jroll | grep -v agent-$something conductor.log | 21:36 |
devananda | they're not INFO logs, and they're not DEBUG logs | 21:36 |
jroll | :) | 21:36 |
devananda | what LOG LEVEL would ou use? | 21:36 |
jroll | you should read the spec | 21:36 |
jroll | it's there | 21:36 |
devananda | nope. never gonna read a spec :) | 21:37 |
devananda | (i'm kidding) | 21:37 |
jroll | heh | 21:37 |
jroll | tl;dr agent logs are INFO, dmesg is DEBUG | 21:37 |
devananda | also, let's move vendor_passthru/lookup into deploy | 21:37 |
devananda | we all agreed on that at summit - anyone proposed a spec yet? | 21:38 |
jroll | wait, we have to do work? | 21:38 |
jroll | I thought we just go to summits and pontificate | 21:38 |
devananda | exactly | 21:38 |
devananda | wait, are you saying pontification ISN"T work? | 21:39 |
NobodyCam | ok gota run out... bbiafh | 21:39 |
jroll | heh | 21:39 |
devananda | jroll: so in the REST API Impact section, yo mean the POST will be /v1/driver/agent/vendor_passthru/lookup?logging_enabled=true | 21:41 |
devananda | and that signals to the driver to look for logs: {...} in the body | 21:42 |
jroll | devananda: I have no clue, not my spec | 21:42 |
jroll | devananda: what I would assume is | 21:42 |
jroll | 1) configure agent_logs_enabled in ironic.conf | 21:42 |
jroll | 2) return logging_enabled: true to the agent | 21:42 |
devananda | right, ok | 21:43 |
devananda | so that makes sense, but this sentence confused me: | 21:43 |
devananda | The Ironic API's drivers' vendor_passthru/lookup will have a new | 21:43 |
devananda | logging_enabled attribute. | 21:43 |
jroll | yeah | 21:43 |
jroll | agree | 21:43 |
devananda | so as much as I want to +A this, the wording is poor | 21:44 |
devananda | the idea is fine | 21:44 |
jroll | I really don't love full dmesg in a POST body, personally | 21:44 |
devananda | POST can handle megabytes, if your webserver is configured appropriately | 21:45 |
devananda | I dont love putting these in the log file | 21:45 |
devananda | because single threaded | 21:45 |
jroll | devananda: I understand that but 1) logging will slow down, like you say, and 2) json parsing can be slow in python | 21:47 |
devananda | yes | 21:47 |
*** cdearborn has joined #openstack-ironic | 21:47 | |
jroll | yeah, so I'm wary | 21:47 |
jroll | idk, posted comments, didn't -1 though | 21:48 |
jroll | maybe I will | 21:48 |
jroll | I want to see perf impact section | 21:48 |
jroll | and clarity around the lookup call | 21:48 |
devananda | jroll: random: does IPA support HTTPS? | 21:49 |
devananda | I would assume so, but havne't tried it myself | 21:49 |
jroll | NobodyCam: ^ I -1'd it | 21:49 |
jroll | devananda: no, not today :( | 21:49 |
jroll | well, as a server, no | 21:49 |
devananda | jroll: blarg | 21:49 |
devananda | o | 21:49 |
devananda | oh. should be both directions | 21:49 |
jroll | right | 21:49 |
devananda | does it support it as a client at leaset? | 21:49 |
jroll | "just put apache in front" doesn't work with something like IPA :) | 21:49 |
jroll | ofc | 21:49 |
jroll | it's requests | 21:49 |
devananda | right. but cert validation? | 21:50 |
jroll | I'd like to put https://github.com/openstack/oslo-incubator/blob/master/openstack/common/sslutils.py#L69 in front | 21:50 |
jroll | yep | 21:50 |
devananda | cool | 21:50 |
devananda | also cool | 21:50 |
*** marzif_ has quit IRC | 21:50 | |
jroll | we had an interesting failure case once around unsynced ntp and a cert that was newly issued :P | 21:51 |
*** absubram has quit IRC | 21:51 | |
devananda | heh | 21:51 |
*** e0ne has joined #openstack-ironic | 21:51 | |
JayF | 'interesting' | 21:51 |
JayF | -.- | 21:51 |
jroll | hey, it was interesting | 21:51 |
jroll | you must admit | 21:51 |
JayF | I mean, I never find incidents interesting. Only horribly. | 21:52 |
JayF | *horrible | 21:52 |
jroll | I never said the incident was interesting, only the failure case :P | 21:52 |
*** dprince has quit IRC | 21:53 | |
devananda | jroll: oh. the other concern I have is log file parsing | 21:53 |
openstackgerrit | Merged openstack/bifrost: Use Cirros for CI testing https://review.openstack.org/187067 | 21:54 |
jroll | what about it. greppability? parsability? | 21:54 |
devananda | dropping unformatted dmesg output in there is going to screw up any regex filtering we have today based on log line formatting, wont it? | 21:54 |
jroll | I mean, it will still be formatted the same way | 21:54 |
devananda | eg, each log line has a header and ends with newline | 21:54 |
devananda | unless we're escaping newlines in the dmesg output ... | 21:54 |
devananda | it's going to be awkward | 21:54 |
JayF | oh that's a good point, actually | 21:54 |
jroll | I like to think we would split dmesg on new lines and do one dmesg line per log line | 21:54 |
jroll | but maybe not | 21:54 |
JayF | because thinks like kernel oopses and panics aren't going to look "right" in the logs | 21:54 |
devananda | jroll: oh god that would be even worse | 21:55 |
devananda | jroll: because now I might have two different servers' dmsg getting interleaved | 21:55 |
jroll | heh | 21:55 |
devananda | \o/ | 21:55 |
jroll | grep agent-$node_id | 21:55 |
jroll | but yeah | 21:55 |
devananda | I actually read my log files sometimes | 21:55 |
jroll | your masochism is leaking :) | 21:56 |
devananda | hehe | 21:56 |
devananda | gotta step away and go register for this silly thing | 21:57 |
*** MattMan has joined #openstack-ironic | 22:02 | |
*** [1]cdearborn has quit IRC | 22:02 | |
*** cdearborn has quit IRC | 22:04 | |
*** pcrews has quit IRC | 22:05 | |
*** openstackgerrit has quit IRC | 22:07 | |
*** openstackgerrit has joined #openstack-ironic | 22:08 | |
*** krtaylor has quit IRC | 22:14 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost: WIP: Support for disabling DHCP server configuration https://review.openstack.org/187362 | 22:15 |
*** ijw has joined #openstack-ironic | 22:17 | |
*** chlong has quit IRC | 22:18 | |
*** alexpilotti has joined #openstack-ironic | 22:21 | |
*** e0ne has quit IRC | 22:22 | |
*** trown has joined #openstack-ironic | 22:23 | |
*** natorious is now known as zz_natorious | 22:23 | |
*** trown|outttypeww has quit IRC | 22:23 | |
*** davideagnello has quit IRC | 22:29 | |
*** davideagnello has joined #openstack-ironic | 22:31 | |
*** exciter0 has joined #openstack-ironic | 22:40 | |
*** exciter0 has left #openstack-ironic | 22:43 | |
*** romcheg1 has quit IRC | 22:47 | |
*** openstackgerrit has quit IRC | 22:51 | |
*** openstackgerrit has joined #openstack-ironic | 22:51 | |
*** pcrews has joined #openstack-ironic | 22:52 | |
*** Haomeng has joined #openstack-ironic | 22:56 | |
openstackgerrit | Merged openstack/ironic-specs: Update Ironic spec URL refs to specs.openstack.org https://review.openstack.org/177632 | 23:04 |
*** ijw has quit IRC | 23:05 | |
*** dguerri is now known as dguerri`away | 23:09 | |
martini | I don't really know how the specs work, so pardon me if this is a silly question - are there specs for bifrost? Would that just fall under ironic specs, or am I way out in left field? | 23:10 |
*** krtaylor has joined #openstack-ironic | 23:12 | |
*** Sukhdev has joined #openstack-ironic | 23:24 | |
*** yuanying has joined #openstack-ironic | 23:31 | |
*** pcrews has quit IRC | 23:36 | |
*** chlong has joined #openstack-ironic | 23:41 | |
cinerama | martini: oh hi! so i don't think we have specs or blueprints at present, but TheJulia will know for sure | 23:46 |
*** hemna is now known as hemnafk | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!