*** alexpilotti has quit IRC | 00:03 | |
NobodyCam | lol converting """ doc strings to # comments is kinda cheatting ... but I like it | 00:06 |
---|---|---|
jroll | heh | 00:08 |
jroll | it's a test | 00:08 |
jroll | if people think those are useful docs, well... | 00:08 |
JoshNang | fwiw we've started doing that in some ironic tests | 00:08 |
*** hemna is now known as hemnafkj | 00:09 | |
jlvillal | jroll, Thanks | 00:09 |
jroll | np | 00:09 |
JoshNang | +A! | 00:11 |
jroll | JoshNang: YOU'RE STILL HERE | 00:11 |
jroll | https://gist.github.com/jimrollenhagen/2223dd45689c0b747982 | 00:11 |
jroll | bam | 00:11 |
jroll | review pls | 00:11 |
jroll | muahahahaha | 00:11 |
jroll | JayF: ^ and anyone else wlecome to review | 00:11 |
JoshNang | that's pretty silly it openstack bot doesn't update test-requirements | 00:11 |
JoshNang | dammit! | 00:11 |
jroll | context is sending this to compute@ after deploy | 00:12 |
jroll | oh wow | 00:12 |
JoshNang | lol | 00:12 |
jroll | wrooong channel. | 00:12 |
JoshNang | yuuup | 00:12 |
jlvillal | BadCub, FYI: The poll is spelled 'porposed' instead of 'proposed'. | 00:13 |
jroll | thanks for +a though JoshNang :P | 00:13 |
JoshNang | :D | 00:13 |
*** saripurigopi has joined #openstack-ironic | 00:16 | |
openstackgerrit | Haomeng,Wang proposed openstack/bifrost: supports redhat yum installation https://review.openstack.org/185294 | 00:23 |
openstackgerrit | Haomeng,Wang proposed openstack/bifrost: supports redhat yum installation https://review.openstack.org/185294 | 00:24 |
*** naohirot has joined #openstack-ironic | 00:31 | |
openstackgerrit | Michael Davies proposed openstack/python-ironicclient: Cache negotiated api microversion for server https://review.openstack.org/173674 | 00:54 |
*** Sukhdev has quit IRC | 00:59 | |
*** ukalifon1 has joined #openstack-ironic | 01:09 | |
*** openstack has joined #openstack-ironic | 01:23 | |
-cameron.freenode.net- [freenode-info] channel trolls and no channel staff around to help? please check with freenode support: http://freenode.net/faq.shtml#gettinghelp | 01:23 | |
*** ukalifon1 has joined #openstack-ironic | 01:23 | |
*** openstack has joined #openstack-ironic | 01:38 | |
*** ukalifon1 has quit IRC | 01:40 | |
*** kan_ has joined #openstack-ironic | 01:43 | |
TheJulia | jhova: sorry, dinner and stuff as well. Something just seems afoot, what is the git hash for the version your running? | 01:50 |
*** openstack has quit IRC | 01:52 | |
*** openstack has joined #openstack-ironic | 01:54 | |
TheJulia | ok, im out getting dinner at the moment and am planning on crashing when I get home. I'll investigate a little more tomorrow morning and see if anuthing stands out to me | 01:54 |
*** spandhe has quit IRC | 01:54 | |
jhova | TheJulia: sure thing | 01:55 |
jhova | thanks | 01:55 |
TheJulia | jhova: No problem, I'm just glad people are using biftost. :) | 01:55 |
*** eghobo_ has quit IRC | 02:04 | |
*** yuanying has joined #openstack-ironic | 02:05 | |
*** yuanying has quit IRC | 02:10 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Add 'pbr' to the requirements https://review.openstack.org/188204 | 02:12 |
*** yuanying has joined #openstack-ironic | 02:17 | |
*** yuanying has quit IRC | 02:20 | |
*** yuanying has joined #openstack-ironic | 02:28 | |
*** yuikotakada has joined #openstack-ironic | 02:32 | |
*** kan_ has quit IRC | 02:32 | |
*** saripurigopi has quit IRC | 02:33 | |
*** kan_ has joined #openstack-ironic | 02:34 | |
*** yuanying has quit IRC | 02:41 | |
openstackgerrit | Zhenguo Niu proposed openstack/bifrost: Fix typos https://review.openstack.org/188241 | 02:45 |
*** bradbeam has joined #openstack-ironic | 02:46 | |
openstackgerrit | Zhenguo Niu proposed openstack/bifrost: Add .gitignore file https://review.openstack.org/188242 | 02:50 |
*** spandhe has joined #openstack-ironic | 03:04 | |
*** spandhe has quit IRC | 03:07 | |
*** spandhe has joined #openstack-ironic | 03:25 | |
*** yuikotakada has quit IRC | 03:26 | |
openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/188093 | 03:32 |
openstackgerrit | chenglch proposed openstack/ironic-specs: Add petitboot iscsi deploy driver support https://review.openstack.org/177641 | 03:32 |
*** coolsvap|afk is now known as coolsvap | 03:39 | |
*** hemna has joined #openstack-ironic | 03:40 | |
*** saripurigopi has joined #openstack-ironic | 03:47 | |
*** EmilienM|off has quit IRC | 03:55 | |
*** EmilienM has joined #openstack-ironic | 04:00 | |
*** hemna has quit IRC | 04:02 | |
*** pradipta has joined #openstack-ironic | 04:04 | |
*** Nisha has joined #openstack-ironic | 04:10 | |
*** eghobo has joined #openstack-ironic | 04:11 | |
*** jhova has quit IRC | 04:16 | |
*** krotscheck has quit IRC | 04:19 | |
*** mordred has quit IRC | 04:21 | |
*** mordred has joined #openstack-ironic | 04:25 | |
*** krotscheck has joined #openstack-ironic | 04:25 | |
*** kan__ has joined #openstack-ironic | 04:25 | |
*** kan_ has quit IRC | 04:29 | |
*** yuikotakada has joined #openstack-ironic | 04:56 | |
openstackgerrit | Michael Davies proposed openstack/python-ironicclient: Cache negotiated api microversion for server https://review.openstack.org/173674 | 05:00 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Validate capability in properties and instance_info https://review.openstack.org/174785 | 05:09 |
*** yuikotakada has quit IRC | 05:34 | |
*** yuanying has joined #openstack-ironic | 05:47 | |
*** yuanying_ has joined #openstack-ironic | 05:48 | |
*** chenglch has joined #openstack-ironic | 05:51 | |
*** yuanying has quit IRC | 05:51 | |
*** spandhe_ has joined #openstack-ironic | 05:52 | |
*** spandhe has quit IRC | 05:52 | |
*** spandhe_ is now known as spandhe | 05:52 | |
*** yuanying_ has quit IRC | 05:53 | |
*** chenglch has quit IRC | 05:54 | |
*** chenglch has joined #openstack-ironic | 05:55 | |
*** yuanying has joined #openstack-ironic | 06:01 | |
*** ukalifon has joined #openstack-ironic | 06:01 | |
*** pradipta has quit IRC | 06:04 | |
*** dlpartain has joined #openstack-ironic | 06:07 | |
*** dlpartain has left #openstack-ironic | 06:09 | |
*** yuikotakada has joined #openstack-ironic | 06:17 | |
*** eghobo has quit IRC | 06:22 | |
*** radek_ has joined #openstack-ironic | 06:23 | |
*** yuanying has quit IRC | 06:32 | |
*** rameshg87 has joined #openstack-ironic | 06:32 | |
rameshg87 | good morning ironic | 06:32 |
*** yuanying has joined #openstack-ironic | 06:33 | |
*** yuanying has quit IRC | 06:33 | |
*** spandhe has quit IRC | 06:35 | |
*** yuanying has joined #openstack-ironic | 06:39 | |
zhenguo | rameshg87: morning :) | 06:40 |
*** dtantsur|afk is now known as dtantsur | 06:42 | |
dtantsur | morning everyone! | 06:43 |
rameshg87 | zhenguo: dtantsur: o/ | 06:43 |
dtantsur | o/ | 06:44 |
*** yuanying has quit IRC | 06:44 | |
zhenguo | dtantsur: morning | 06:44 |
dtantsur | yuikotakada, morning! re https://review.openstack.org/188030 | 06:46 |
dtantsur | may I enable translation-jobs in a separate patch? this one is big enough already... | 06:47 |
dtantsur | not sure if we'll need some kind of i18n team ack before landing something like that | 06:47 |
openstackgerrit | chenglch proposed openstack/ironic-specs: Add console log support https://review.openstack.org/164586 | 06:48 |
yuikotakada | dtantsur: o/ | 06:48 |
yuikotakada | dtantsur: No problem with separated patch :) | 06:49 |
yuikotakada | dtantsur: Then, could you please write about it (so that, just "may I enable translation-jobs in a separate patch?") into the patch? then, I will +1 | 06:51 |
dtantsur | ok | 06:53 |
*** yuikotak_ has joined #openstack-ironic | 06:53 | |
*** yuikotakada has quit IRC | 06:53 | |
*** ndipanov has quit IRC | 06:53 | |
*** yuikotak_ has left #openstack-ironic | 06:53 | |
*** yuikotak_ has joined #openstack-ironic | 06:53 | |
naohirot | rameshg87: good afternoon | 06:55 |
rameshg87 | naohirot: o/ | 06:56 |
naohirot | dtantsur: good morning | 06:56 |
dtantsur | naohirot, o/ | 06:56 |
naohirot | rameshg87: do you have some time now? | 06:56 |
rameshg87 | naohirot: sure | 06:56 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: Add "enroll" state to the state machine https://review.openstack.org/179151 | 06:56 |
naohirot | rameshg87: I'd like to ask if you are going to remove floppy auth code form ilo deploy? | 06:57 |
naohirot | rameshg87: s/form/from/ | 06:57 |
rameshg87 | naohirot: I think we might. I need to check with others in the team about this as well. | 06:58 |
rameshg87 | naohirot: right now it doesn't make sense to pass the token simply because the endpoint anyway is unauthenticated | 06:58 |
rameshg87 | naohirot: I need to check if anyone feels there is any value in keeping that endpoint protected | 06:58 |
naohirot | rameshg87: I'm asking this question regarding https://review.openstack.org/#/c/151958/20/ironic/drivers/modules/irmc/deploy.py | 06:59 |
*** pradipta has joined #openstack-ironic | 06:59 | |
yuikotak_ | rameshg87, naohirot: Good afternoon :) | 06:59 |
rameshg87 | yuikotak_: o/ | 06:59 |
naohirot | rameshg87: line 353 | 06:59 |
naohirot | yuikotak_: good afternoon | 06:59 |
rameshg87 | naohirot: yeah I got it .. may be I will get back to you in 1 or 2 days | 07:00 |
naohirot | rameshg87: Okay | 07:00 |
rameshg87 | naohirot: if someone comes up with some value in still keeping the endpoint protected for ilo drivers, we can think of making it configurable or come with a new protected endpoint (but that might break backward compatibility). I still have to think | 07:00 |
rameshg87 | naohirot: at least for now, as yuriyz said, it doesn't make sense to pass the token because the pass_deploy_info endpoint anyway doesn't require authentication | 07:01 |
naohirot | rameshg87: So what is the current master status? Is only no auth endpoint opened? | 07:03 |
naohirot | rameshg87: My concern is compatibility | 07:04 |
rameshg87 | naohirot: yes, in master the pass_deploy_info endpoint is unprotected | 07:04 |
naohirot | rameshg87: I see. | 07:04 |
rameshg87 | naohirot: it will still work if you don't pass the token to the older ramdisk | 07:05 |
rameshg87 | naohirot: see this block of code in dib: naohirot: it's okay if you pass the token (i.e | 07:05 |
rameshg87 | https://github.com/openstack/diskimage-builder/blob/master/elements/deploy-ironic/init.d/80-deploy-ironic#L136-L141 | 07:05 |
rameshg87 | naohirot: if we don't find token file, we don't pass X-Auth-Token | 07:06 |
rameshg87 | naohirot: similarly for pxe drivers, it doesn't pass X-Auth-Token if it fails to retrieve token from tftp server | 07:06 |
*** yuikotak_ has quit IRC | 07:08 | |
naohirot | rameshg87: What I'd like to know is ilo case which would have some impact for current customer. What cases are they? | 07:08 |
rameshg87 | naohirot: there is no impact as such now | 07:08 |
openstackgerrit | Tan Lin proposed openstack/ironic: Change driver_info to driver_internal_info in conductor https://review.openstack.org/188281 | 07:08 |
rameshg87 | naohirot: and there will be no impact if we stop passing token through the virtual media floppy | 07:08 |
naohirot | rameshg87: does that mean that ilo floppy auth code can be removed too? | 07:09 |
*** yuikotakada has joined #openstack-ironic | 07:09 | |
naohirot | rameshg87: I thought you have some concern because you need to check your co-workder, right? | 07:10 |
rameshg87 | naohirot: yes, it can be removed | 07:11 |
rameshg87 | naohirot: but I wanted to check if others want to leave the ilo driver endpoint unprotected (that means just stop passing token) OR make ilo driver endpoint protected somehow (idk how yet). | 07:12 |
rameshg87 | naohirot: but it can be removed, there is no impact | 07:12 |
naohirot | rameshg87: I understood. | 07:12 |
naohirot | rameshg87: If there is no compatibility, I'll remove it. | 07:13 |
naohirot | rameshg87: s/compatibility/compatibility issue/ | 07:14 |
openstackgerrit | Merged stackforge/ironic-discoverd: Make the number of green threads configurable https://review.openstack.org/187723 | 07:15 |
*** natorious is now known as zz_natorious | 07:15 | |
rameshg87 | naohirot: yeah | 07:15 |
rameshg87 | naohirot: but you can confirm once :) | 07:15 |
naohirot | rameshg87: you mean doing actual test in lab? | 07:16 |
rameshg87 | yeah :) | 07:16 |
rameshg87 | sometimes code can be crazier than what we think :) | 07:16 |
*** pas-ha has joined #openstack-ironic | 07:17 | |
naohirot | rameshg87: sometimes it happens :) | 07:17 |
*** ifarkas has joined #openstack-ironic | 07:29 | |
rameshg87 | dtantsur: hi | 07:33 |
dtantsur | rameshg87, o/ | 07:34 |
rameshg87 | dtantsur: in enroll state spec: https://review.openstack.org/#/c/179151/5/specs/liberty/enroll-node-state.rst | 07:34 |
rameshg87 | dtantsur: on failure it just returns back to state enroll ? | 07:35 |
dtantsur | yes, I think it will simplify life a bit | 07:35 |
rameshg87 | dtantsur: and all user/3rd party apps can check is last_error ? | 07:35 |
dtantsur | right | 07:35 |
rameshg87 | okay, that seems a bit different from all other things that have a *FAIL | 07:37 |
rameshg87 | but anyway I can't think of any impact because of this | 07:37 |
rameshg87 | only thing might be the power_state_sync | 07:37 |
rameshg87 | which might try to pickup nodes that failed enroll | 07:37 |
dtantsur | rameshg87, oh, good catch, we should forbid power_state_sync in ENROLL and VERIFYING! wdyt? | 07:38 |
* dtantsur brb | 07:39 | |
rameshg87 | dtantsur: yeah, I think we should | 07:41 |
rameshg87 | dtantsur: VERIFYING should be okay because power state sync doesn't take anything that is reserved | 07:41 |
rameshg87 | dtantsur: only thing is enroll, it should be disabled in power state sync | 07:41 |
dtantsur | rameshg87, please leave a comment on the spec, I'll add it | 07:43 |
rameshg87 | sure | 07:43 |
*** chlong has quit IRC | 07:44 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add iRMC Virtual Media Deploy module for iRMC Driver https://review.openstack.org/151958 | 07:45 |
*** dguerri`away is now known as dguerri | 07:49 | |
*** yuanying has joined #openstack-ironic | 07:49 | |
*** jistr has joined #openstack-ironic | 07:50 | |
*** jistr is now known as jistr|mt | 07:54 | |
*** jistr|mt is now known as jistr|mtg | 07:54 | |
*** romainh has joined #openstack-ironic | 07:57 | |
*** Nisha has quit IRC | 07:59 | |
*** yuikotakada has quit IRC | 08:01 | |
*** Nisha has joined #openstack-ironic | 08:02 | |
*** ndipanov has joined #openstack-ironic | 08:07 | |
*** yuikotakada has joined #openstack-ironic | 08:08 | |
*** lucasagomes has joined #openstack-ironic | 08:09 | |
openstackgerrit | Tan Lin proposed openstack/ironic-specs: Bare Metal Trust Using Intel TXT https://review.openstack.org/133902 | 08:12 |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add localboot support for iscsi_irmc driver https://review.openstack.org/163738 | 08:13 |
*** MattMan has quit IRC | 08:13 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add whole disk image support for iscsi_irmc driver https://review.openstack.org/181771 | 08:21 |
openstackgerrit | Tan Lin proposed openstack/ironic: Change driver_info to driver_internal_info in conductor https://review.openstack.org/188281 | 08:26 |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add IPA support for iscsi_irmc driver https://review.openstack.org/181807 | 08:29 |
*** erelwell has joined #openstack-ironic | 08:35 | |
*** athomas has joined #openstack-ironic | 08:35 | |
sambetts | Good UGT Morning Ironic o/ | 08:50 |
*** MattMan has joined #openstack-ironic | 08:53 | |
dtantsur | sambetts, morning (ugt) | 08:58 |
lucasagomes | sambetts, dtantsur good (ugt) morning | 08:58 |
yuikotakada | sambetts: mornin (UGT) | 08:59 |
lucasagomes | dtantsur btw, re flake8 patches from sambetts.... that will require some special review I think | 08:59 |
lucasagomes | I think we should merge it at once, so we enforce the rules | 08:59 |
lucasagomes | otherwise it will get really messy if we start merging particular patches (because other patches merged in between might introduce new errors) | 09:00 |
lucasagomes | yuikotakada, good (ugt) morning :-) | 09:00 |
Nisha | dtantsur | 09:00 |
Nisha | hi | 09:00 |
yuikotakada | lucasagomes: good (UGT) morning. I like this new greeting :) | 09:01 |
lucasagomes | sambetts, you think that, after reviewing the whole series, it would make sense to squash it into 1 patch and just merge it ? | 09:01 |
lucasagomes | yuikotakada, hah yeah, makes it easier for us on diff TZs | 09:01 |
Nisha | dtantsur, i was creating ramdisk for ironic-inspector | 09:02 |
Nisha | only ubuntu and ironic-discoverd-ramdisk elements are required to create ramdisk using ironic-inspector | 09:04 |
Nisha | am i correct? | 09:04 |
sambetts | lucasagomes: might be worth doing, either that or ensure that +2s are given in reverse order, so that the one at the bottom of the tree gets the +A last then they'll all gate at the same time | 09:05 |
sambetts | by the bottom I mean the one that they're all based off | 09:05 |
sambetts | which I guess is actually the top of a CompSci tree | 09:06 |
lucasagomes | yeah gotcha... I will see if I can review then all today, if another core agrees to do it too we can try to get it merged soon | 09:08 |
lucasagomes | cause it's going to conflict with many other patches so it's better doing it soon | 09:08 |
dtantsur | Nisha, yeah, should be fine (never tested it on ubuntu though) | 09:08 |
sambetts | lucasagomes: yeah, it already needs a rebase again, after I did it yesterday | 09:08 |
lucasagomes | sambetts, :-( | 09:08 |
dtantsur | lucasagomes, I think the last patch can just fix the remaining things | 09:08 |
lucasagomes | will try to coordinate with someone to do it | 09:09 |
Nisha | How do u create the ramdisk, means which elements you use for creating ramdisk for ironic-inspector | 09:09 |
lucasagomes | dtantsur, ok lemme review them and sambetts maybe can go rebase and squash the patches | 09:09 |
dtantsur | it's too hard to land them at once :( | 09:09 |
Nisha | using DIB | 09:09 |
lucasagomes | so we get it merged ? | 09:09 |
lucasagomes | dtantsur, yeah thta's why I think it's good to squash it into 1 patch | 09:09 |
lucasagomes | and merge it | 09:09 |
dtantsur | hmm maybe | 09:09 |
lucasagomes | instead of merging 8+ patches in order | 09:09 |
lucasagomes | we can review it as a series | 09:09 |
lucasagomes | but before merging, we squash and approve | 09:10 |
dtantsur | Nisha, I base it on Fedora usually, maybe yuikotakada uses Ubuntu? | 09:10 |
lucasagomes | dtantsur, makes sense? | 09:10 |
Nisha | k | 09:10 |
dtantsur | lucasagomes, oh lgtm | 09:10 |
openstackgerrit | Pratyusha proposed stackforge/proliantutils: Add iSCSI boot support in RIS https://review.openstack.org/187162 | 09:10 |
lucasagomes | dtantsur, ack | 09:10 |
*** yuikotakada has quit IRC | 09:10 | |
sambetts | lucasagomes, dtantsur: ack | 09:11 |
* rameshg87 understood what ugt means now | 09:13 | |
*** edcragg has joined #openstack-ironic | 09:17 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add vendor-passthru to attach and boot an ISO https://review.openstack.org/188317 | 09:17 |
sambetts | rameshg87: Universal Greeting Time http://www.total-knowledge.com/~ilya/mips/ugt.html | 09:19 |
*** jistr|mtg is now known as jistr | 09:19 | |
*** dtantsur is now known as dtantsur|lunch | 09:19 | |
rameshg87 | sambetts: yeah, just got to know :) | 09:20 |
sambetts | :) | 09:20 |
*** pas-ha has left #openstack-ironic | 09:26 | |
lucasagomes | hole cow man, the flake8 patches never ends haha | 09:29 |
sambetts | lucasagomes: shall I wait until I squash to rebase those patches? haha yes they are huge | 09:29 |
lucasagomes | sambetts, yeah I would like to have 2 cores at least reviewing then | 09:29 |
lucasagomes | 1 more, I'm already doing it | 09:29 |
lucasagomes | rameshg87, dtantsur|lunch ^ are you guys up to it? | 09:29 |
* rameshg87 reads backwards | 09:30 | |
lucasagomes | the ones I reviewed looks pretty straight forward, it's mostly space being added or removed | 09:30 |
rameshg87 | oh the E12x patches ? | 09:30 |
lucasagomes | rameshg87, yes | 09:30 |
rameshg87 | okay, I am in .. :) | 09:30 |
lucasagomes | like we have to merge it soonish because otherwise it will be impossible to keep rebasing it | 09:30 |
lucasagomes | rameshg87, we agreed to review them in a serie. Like 2 cores looking into it | 09:31 |
lucasagomes | rameshg87, once we think it's good, sambetts can go, rebase it and squash them into 1 patch | 09:31 |
lucasagomes | and we merge it at once so that we enforce the rules and we don't have any other patch in between being merged and introducing new errors | 09:31 |
lucasagomes | rameshg87, sounds good? | 09:31 |
rameshg87 | yeah, I agree | 09:31 |
lucasagomes | ack | 09:31 |
lucasagomes | ok | 09:31 |
rameshg87 | are we doing it right away ? | 09:31 |
lucasagomes | rameshg87, yeah I started already | 09:32 |
rameshg87 | some people were against enabling E129 sometime back ? | 09:32 |
rameshg87 | do all people agree to enabling the rules here ? | 09:32 |
lucasagomes | I tihnk E129 is not included right? | 09:32 |
lucasagomes | it's 3,4,5,6,7,8 | 09:32 |
rameshg87 | I think sambetts patch covers on E128 | 09:32 |
rameshg87 | *only till 128 | 09:32 |
lucasagomes | yeah it does | 09:32 |
lucasagomes | I mean it does not include 129 | 09:32 |
rameshg87 | yeah I meant the same :) | 09:33 |
sambetts | rameshg87: theses patches cover E123/6/7/8 and it was voted in mondays meeting to go with it | 09:33 |
rameshg87 | sambetts: okay | 09:33 |
rameshg87 | https://review.openstack.org/#/q/owner:%22Sam+Betts%22+status:open+project:+openstack/ironic,n,z | 09:33 |
rameshg87 | all of them right ? | 09:33 |
rameshg87 | anything missing from above ? ^^^ | 09:34 |
sambetts | rameshg87: yeah, rloo asked me to split them for easier reviewin | 09:34 |
sambetts | rameshg87: yup there are 10 of them so thats link covered them all | 09:34 |
rameshg87 | sambetts: okay | 09:34 |
rameshg87 | lucasagomes: sambetts: I am starting with them right away | 09:35 |
lucasagomes | rameshg87, ack, yeah me too | 09:35 |
lucasagomes | I'm +2'ing the ones I reviewed | 09:35 |
rameshg87 | sure .. | 09:35 |
lucasagomes | rameshg87, the first one is -2'd just to avoid people merging it separately, but it looks good | 09:36 |
rameshg87 | okay | 09:37 |
sambetts | thanks lucasagomes, rameshg87 :D | 09:37 |
lucasagomes | np, otherwise it sounds like masochism to keep rebasing this patches forever | 09:38 |
lucasagomes | and it was agreeded in the meeting to have them in, so we gotta do it | 09:38 |
lucasagomes | better to do it soon | 09:38 |
sambetts | :D | 09:39 |
*** e0ne has joined #openstack-ironic | 09:44 | |
*** vdrok has quit IRC | 09:50 | |
*** romainh has quit IRC | 09:51 | |
*** vdrok has joined #openstack-ironic | 09:51 | |
*** Nisha has quit IRC | 09:57 | |
*** chenglch has quit IRC | 09:57 | |
lucasagomes | rameshg87, sambetts reviewed... it looks good to me, some oddities here and there when closing the parenthesis but it's fine. Overall I think it's better/good | 09:58 |
rameshg87 | lucasagomes: I am in 3rd or 4th I guess. | 10:01 |
lucasagomes | rameshg87, no rush | 10:01 |
sambetts | thanks lucasagomes :D | 10:08 |
*** notq has quit IRC | 10:10 | |
rameshg87 | sambetts: thanks a lot for these changes, some are pretty big patches :) | 10:11 |
* rameshg87 in 5th one now | 10:11 | |
*** saripurigopi has quit IRC | 10:14 | |
*** yuanying has quit IRC | 10:15 | |
sambetts | :) | 10:18 |
*** thrash|g0ne is now known as thrash | 10:19 | |
*** saripurigopi has joined #openstack-ironic | 10:21 | |
openstackgerrit | Sam Betts proposed stackforge/ironic-discoverd: Add node UUID to response from /v1/continue https://review.openstack.org/187575 | 10:21 |
*** notq has joined #openstack-ironic | 10:24 | |
*** coolsvap is now known as coolsvap|afk | 10:30 | |
rameshg87 | sambetts: lucasagomes: I am done too. | 10:43 |
lucasagomes | rameshg87, ack, you good with the patch series? | 10:43 |
rameshg87 | yeah | 10:43 |
sambetts | awesome :D I'm just address the few comments you left :) | 10:43 |
rameshg87 | some 3 or 4 comments overall in all 8 patches | 10:43 |
lucasagomes | sambetts, mind rebasing & squashing it? | 10:43 |
lucasagomes | yeah same | 10:43 |
lucasagomes | rameshg87, thanks a lot for it | 10:43 |
rameshg87 | all thanks should goto sambetts I guess :) | 10:44 |
lucasagomes | yeah sambetts thanks much! | 10:44 |
*** marzif_ has joined #openstack-ironic | 10:47 | |
*** marzif_ has quit IRC | 10:50 | |
*** pradipta has quit IRC | 10:50 | |
*** marzif_ has joined #openstack-ironic | 10:50 | |
*** coolsvap|afk is now known as coolsvap | 10:54 | |
*** romainh has joined #openstack-ironic | 10:57 | |
rameshg87 | lucasagomes: are you planning to work on https://review.openstack.org/#/c/185667/ ? | 11:08 |
* lucasagomes looks | 11:09 | |
rameshg87 | lucasagomes: if you don't have anything WIP, I can try to put those changes into that patch | 11:09 |
lucasagomes | rameshg87, I was, tho I got dragged into something | 11:09 |
lucasagomes | rameshg87, sure if you want feel free to | 11:09 |
rameshg87 | lucasagomes: okay, will try to put a patch today | 11:09 |
lucasagomes | thanks | 11:09 |
rameshg87 | lucasagomes: easier for me because I can test if new patch fixes the uefi localboot issue | 11:09 |
lucasagomes | yeah that helps indeed | 11:09 |
lucasagomes | I just test the wol bits, but even then I'm in the office today | 11:10 |
lucasagomes | and my machines at home so... Can't test anything today | 11:10 |
rameshg87 | oh okay :) | 11:10 |
*** yuikotakada has joined #openstack-ironic | 11:12 | |
saripurigopi | I'm running py34 tests for pxe_ucs driver, and test_power.test_validate_fail testcase is failing with TypeError: 'InvalidParameterValue' object is not iterable. I've tried to run the same tests on existing drivers also, ilo,amt, I see the same error. am I missing something | 11:13 |
*** dtantsur|lunch is now known as dtantsur | 11:13 | |
lucasagomes | saripurigopi, I've seem some people talking about it in the channel, it seems to be a problem with the mock library | 11:14 |
dtantsur | ++ it's about mock | 11:14 |
lucasagomes | jlvillal probably knows it better | 11:14 |
saripurigopi | lucasagomes: okay. is there a fix or workaround present? | 11:15 |
lucasagomes | saripurigopi, not that I know really | 11:15 |
* lucasagomes needs to update his OS, I'm on f20 heh no py3.4 | 11:15 | |
saripurigopi | lucasagomes: okay | 11:15 |
*** coolsvap is now known as coolsvap|afk | 11:16 | |
saripurigopi | :-) | 11:16 |
lucasagomes | saripurigopi, in the code yes, I think you can use an mock.side_effect = iter(<list>) | 11:16 |
lucasagomes | but outside changing the code I'm not aware of any workarounds | 11:16 |
lucasagomes | sometimes it makes me wonder whether we should do ^ in the code so it will workaround the bug for all versions of mock | 11:16 |
lucasagomes | but I don't know much about the problem itself to have a good opnion on it | 11:17 |
lucasagomes | (doesn't hurt proposing such change tho) | 11:17 |
saripurigopi | lucasagomes: okay | 11:17 |
alex_xu | hi, guys, I'm submit microversion guideline to api-wg, and there is different propose from nova side. I send this out in ML http://lists.openstack.org/pipermail/openstack-dev/2015-June/065793.html Hope ironic team can join the discussion and review the guideline, thanks! | 11:18 |
openstackgerrit | Michael Davies proposed openstack/python-ironicclient: Cache negotiated api microversion for server https://review.openstack.org/173674 | 11:20 |
*** athomas_ has joined #openstack-ironic | 11:21 | |
openstackgerrit | Merged stackforge/ironic-discoverd: Add node UUID to response from /v1/continue https://review.openstack.org/187575 | 11:24 |
*** athomas has quit IRC | 11:25 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: API: Get a subset of fields from Ports and Chassis https://review.openstack.org/183549 | 11:25 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: API: Get a subset of fields from Nodes https://review.openstack.org/183491 | 11:25 |
saripurigopi | are py34 tests mandatory for all the patches? | 11:25 |
*** athomas_ has quit IRC | 11:26 | |
*** lucasagomes is now known as lucas-hungry | 11:27 | |
dtantsur | saripurigopi, yes | 11:28 |
saripurigopi | dtantsur: okay | 11:29 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: Add "enroll" state to the state machine https://review.openstack.org/179151 | 11:35 |
dtantsur | lucas-hungry, rameshg87, please have a look ^^ | 11:35 |
sambetts | dtantsur: would the mock work around that you showed be yesterday work for saripurigopi? | 11:37 |
dtantsur | don't know | 11:38 |
dtantsur | it's a different issue | 11:38 |
rameshg87 | dtantsur: ack | 11:38 |
*** e0ne is now known as e0ne_ | 11:39 | |
sambetts | dtantsur: all issues with the external mock lib in py34 though, IMO shouldn't we be using the sys lib version in py34 anyway? | 11:39 |
*** athomas_ has joined #openstack-ironic | 11:39 | |
dtantsur | sambetts, it's worth trying | 11:40 |
sambetts | saripurigopi: https://review.openstack.org/#/c/187723/3/ironic_inspector/test/test_utils.py try replacing your mock import like this file does | 11:41 |
saripurigopi | sambetts: (y) | 11:42 |
*** yuikotakada has quit IRC | 11:44 | |
saripurigopi | sambetts: still see the same error. | 11:45 |
*** kan__ has quit IRC | 11:45 | |
sambetts | saripurigopi, dtantsur: :( | 11:45 |
* rameshg87 goes home | 11:47 | |
*** rameshg87 has quit IRC | 11:47 | |
*** e0ne_ has quit IRC | 11:49 | |
sambetts | lucas-hungry, dtantsur: when I squash my commits which change ID should I use, or should I generate a new one?? | 11:51 |
*** saripurigopi has quit IRC | 11:52 | |
dtantsur | sambetts, of the first (parent) patch | 11:54 |
sambetts | dtantsur: OK cool :D | 11:54 |
*** dprince has joined #openstack-ironic | 12:04 | |
openstackgerrit | Sam Betts proposed openstack/ironic: Enforce flake8 E123/6/7/8 in ironic https://review.openstack.org/186450 | 12:06 |
lucas-hungry | dtantsur, will do | 12:07 |
*** lucas-hungry is now known as lucasagomes | 12:07 | |
TheJulia | good morning | 12:08 |
lucasagomes | sambetts, thanks, I will remove the -2... can you also abandon the rest of the patches in the series? | 12:09 |
sambetts | lucasagomes: will do :) | 12:09 |
dtantsur | morning, TheJulia | 12:09 |
*** e0ne has joined #openstack-ironic | 12:13 | |
lucasagomes | TheJulia, good ugt morning | 12:16 |
*** mtanino has joined #openstack-ironic | 12:16 | |
*** chlong has joined #openstack-ironic | 12:20 | |
lucasagomes | dtantsur, are you reviewing 186450? | 12:22 |
dtantsur | lucasagomes, not yet. should I? :) | 12:22 |
lucasagomes | I did my final skimming seems good, me and ramesh reviewed the whole patch series | 12:22 |
lucasagomes | so I'm thinking about going ahead and approving it | 12:22 |
dtantsur | +1 please do | 12:23 |
lucasagomes | dtantsur, if you feel like doing it before I push the button | 12:23 |
lucasagomes | ack | 12:23 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: Driver Composition Reform https://review.openstack.org/188370 | 12:23 |
dtantsur | here the flame starts ^^^! | 12:23 |
openstackgerrit | Merged openstack/ironic: Use oslo config import methods for Keystone options https://review.openstack.org/187944 | 12:24 |
openstackgerrit | Merged openstack/ironic: Change driver_info to driver_internal_info in conductor https://review.openstack.org/188281 | 12:24 |
lucasagomes | ok +a | 12:25 |
dtantsur | folks, do we have an etherpad/whatever to track liberty priorities like we did in K? | 12:27 |
*** trown|outttypeww is now known as trown | 12:27 | |
lucasagomes | dtantsur, hmm not that I remember https://etherpad.openstack.org/p/liberty-ironic-cycle-goals | 12:32 |
lucasagomes | but I don't think it's fully up-to-date | 12:32 |
dtantsur | yeah.. I'd like us to see how well on track we're with every important thing | 12:33 |
dtantsur | because in K we could to better tbh | 12:33 |
lucasagomes | yeah | 12:33 |
*** rwsu has joined #openstack-ironic | 12:36 | |
dtantsur | while working on the driver composition spec, I got one more idea: | 12:39 |
dtantsur | should we allow changing node driver only in ENROLL state? | 12:40 |
dtantsur | lucasagomes, ^^^ | 12:40 |
lucasagomes | hmm | 12:40 |
lucasagomes | never thought about it | 12:40 |
lucasagomes | if we have checks on the driver for going from ENROLL to MANAGEABLE | 12:41 |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add iRMC vendor passthru for soft reboot and NMI https://review.openstack.org/187082 | 12:41 |
lucasagomes | I think it makes some sense | 12:41 |
lucasagomes | we def should brainstorm it | 12:41 |
dtantsur | lucasagomes, do we allow changing driver at all? | 12:41 |
lucasagomes | yes | 12:41 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: Driver Composition Reform https://review.openstack.org/188370 | 12:41 |
lucasagomes | I don't think you have any explicity rules preventing it at the moment | 12:42 |
dtantsur | lucasagomes, hmm, but if we do it, we'll never change it again, as we have no way of going back to enroll... | 12:42 |
dtantsur | probably ML thread will work? | 12:42 |
lucasagomes | dtantsur, hmm yeah | 12:43 |
lucasagomes | probably we should allow it in MANAGEABLE | 12:43 |
lucasagomes | or make a path from MANGEABLE back to ENROLL | 12:43 |
*** marzif_ has quit IRC | 12:44 | |
*** [1]cdearborn has joined #openstack-ironic | 12:45 | |
* dtantsur sent a email | 12:47 | |
dtantsur | also folks, in case you didn't notice: I invite you to start a good flamewar on the driver composition spec https://review.openstack.org/#/c/188370 :) it's roughly based on what we discuss on the summit | 12:49 |
dtantsur | (only for backlog for now, as I'm not sure how people will react) | 12:50 |
*** smoriya has quit IRC | 12:56 | |
sambetts | dtantsur: speaking of specs, is this https://review.openstack.org/#/c/134303 being reworked/resummited for L? | 12:58 |
*** zhenguo has quit IRC | 12:58 | |
dtantsur | sambetts, yes and no. meaning that we'll probably land the code in the futurist library instead | 12:58 |
*** e0ne is now known as e0ne_ | 13:01 | |
sambetts | dtantsur: ah, ok is it worth leaving a comment on the bug or patch to that effect? | 13:02 |
dtantsur | I think there's such a comment somewhere deep in that patch | 13:02 |
dtantsur | lucasagomes, tbh https://review.openstack.org/#/c/184714/ does not look right to me. IMO we should be fixing Oslo, not applying workarounds to every project... | 13:04 |
*** e0ne_ is now known as e0ne | 13:04 | |
*** rloo has joined #openstack-ironic | 13:05 | |
*** mtanino has quit IRC | 13:05 | |
[1]cdearborn | morning ironic! | 13:10 |
lucasagomes | dtantsur, right... I think we can check on oslo | 13:11 |
openstackgerrit | Merged openstack/ironic: Use svg as it looks better/scales better than png https://review.openstack.org/188211 | 13:11 |
lucasagomes | probably dhellmann might have some more info on it. If you have some time can you please look at dtantsur comments on https://review.openstack.org/#/c/184714/ ? Thanks | 13:11 |
lucasagomes | [1]cdearborn, good ugt morning | 13:11 |
dtantsur | [1]cdearborn, morning, cool nick :) | 13:12 |
trown | good ugt morning [1]cdearborn | 13:14 |
[1]cdearborn | qq - the wiki says the weekly meeting alternates between 1700 Mon, and 0500 Tues on alternate weeks, but the google cal shows the meeting every Mon, while next meeting is listed as Tues 6/9 @ 0500 | 13:14 |
dtantsur | trown, morning (ugt obviously) | 13:14 |
dtantsur | [1]cdearborn, google cal must be wrong | 13:14 |
trown | good morning dtantsur | 13:15 |
dtantsur | also, lucasagomes, rloo, and others: I remember we had a preliminary agreement on creating some repo like ironic-contrib-tools to carry things like chassis discovery, right? | 13:15 |
dtantsur | instead I'm seeing people suggesting adding a driver for chassis, which I more-or-less hate | 13:16 |
[1]cdearborn | k - so the next meeting is 6/9 @ 0500, then the one after that will be 6/15 @ 1700, and continue alternating after that? | 13:17 |
rloo | dtantsur: yes, there was discussion at the summit. Did anyone put down notes. There was this back/forth about separate or one repo per vendor, and who would maintain if one repo for all... | 13:17 |
rloo | hi ironic'ers | 13:17 |
dtantsur | oh and g'morning rloo :) | 13:17 |
trown | dtantsur: I had a question regarding the inspector functest: | 13:17 |
trown | I have been trying to write a test to expose that bug, but if I patch the functest "ramdisk" to return a huge list for the data key, I fail on jq being able to handle that before I fail in the way of the bug | 13:17 |
trown | dtantsur: does the functest use a "real" db, or just writes to a file? | 13:18 |
openstackgerrit | Merged openstack/bifrost: Fix typos https://review.openstack.org/188241 | 13:18 |
trown | dtantsur: for Ironic that is | 13:18 |
dtantsur | trown, unfortunately, functest now is very unreliable, better don't use it :( | 13:18 |
rloo | [1]cdearborn: wrt meetings, didn't know we had a google calendar. | 13:18 |
dtantsur | trown, is mock Ironic with static data | 13:18 |
dtantsur | * it mocks | 13:18 |
trown | ah ok, that makes sense then | 13:19 |
* dtantsur is writing one more email, now on vendor repo | 13:19 | |
rloo | [1]cdearborn: I have been trying to keep the 'Next Meeting' section relevant. Will try to find out about the google calendar (not sure I want to maintain that) | 13:19 |
lucasagomes | dtantsur, yeah rings me a bell | 13:19 |
rloo | NobodyCam: ^^ any idea about the google calendar at https://wiki.openstack.org/wiki/Meetings/Ironic | 13:19 |
lucasagomes | not sure what was the final agreement on that tho | 13:19 |
[1]cdearborn | rloo: see: https://wiki.openstack.org/wiki/Meetings/Ironic | 13:20 |
trown | dtantsur: interestingly, I found that jq provides an upper bound to how many facts we can return if they are all on that one key, seems to fail on the order of 900 facts :) | 13:20 |
dtantsur | lol 900 facts | 13:20 |
dtantsur | we're insane :D | 13:20 |
rloo | [1]cdearborn: yeah, I looked at the wiki. I think we should delete the google calendar but need to check | 13:21 |
lucasagomes | trown, wow | 13:21 |
openstackgerrit | Merged openstack/bifrost: Add .gitignore file https://review.openstack.org/188242 | 13:22 |
lucasagomes | trown, we might be really missusing Ironic for that, perhaps we should have a way to upload these facts somewhere else (like swift) and just linking it in Ironic? | 13:22 |
lucasagomes | it sounds more sane | 13:22 |
lucasagomes | services consuming it could then take the object id that is in the node, fetch from swift and consume it | 13:23 |
trown | lucasagomes: https://bugs.launchpad.net/bugs/1461252 | 13:24 |
openstack | Launchpad bug 1461252 in ironic-inspector "edeploy plugin puts too much data in Ironic extra column" [Critical,Triaged] | 13:24 |
trown | lucasagomes: definitely :) | 13:24 |
lucasagomes | trown, awesome! yeah | 13:24 |
trown | lucasagomes: we are not returning 900 facts btw, I just was trying to write a test to expose that bug, and found that we actually have a jq limit in the ramdisk at around 900 facts | 13:25 |
lucasagomes | gotcha | 13:25 |
* dtantsur wrote one more email \o/ | 13:31 | |
dtantsur | trown, I guess the most sane solution is to figure out why the hell we need so many facts... | 13:31 |
dtantsur | but yeah, storing them in swift sounds sane anyway :) | 13:31 |
TheJulia | what if one does not have swift? | 13:34 |
trown | TheJulia: then you would not be able to use that plugin I think | 13:34 |
dtantsur | TheJulia, that's one specific use case of inspector, I think people who need it, might install swift | 13:34 |
dtantsur | it's not required to use inspector as backend for Ironic inspection | 13:34 |
trown | ya, it is a totally optional plugin | 13:35 |
*** jhova has joined #openstack-ironic | 13:38 | |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic-specs: Add new deploy driver for diskless nodes https://review.openstack.org/181074 | 13:41 |
TheJulia | ok | 13:41 |
*** stendulker has joined #openstack-ironic | 13:42 | |
NobodyCam | good morning Ironic | 13:44 |
trown | good ugt morning NobodyCam | 13:44 |
*** thiagop has joined #openstack-ironic | 13:45 | |
NobodyCam | good (UGT) morning trown | 13:45 |
sambetts | UGT Morning NobodyCam, rloo trown | 13:45 |
NobodyCam | and sambetts | 13:45 |
dtantsur | NobodyCam, morning | 13:45 |
NobodyCam | morning dtantsur | 13:45 |
trown | morning sambetts | 13:45 |
NobodyCam | :) | 13:45 |
trown | and rloo | 13:45 |
NobodyCam | morning rloo.. | 13:46 |
rloo | morning trown, sambetts, NobodyCam | 13:46 |
rloo | NobodyCam: after you've had your coffee, someone asked about the google calendar in our meetings wiki. Do you know who maintains it? I'd like to delete it. | 13:47 |
NobodyCam | morning rloo | 13:47 |
thiagop | morning people | 13:49 |
NobodyCam | I think jlvillal added it.. but not 100% sure there... I can check on that... is it wrong? | 13:49 |
NobodyCam | morning thiagop | 13:49 |
openstackgerrit | Merged openstack/ironic: Enforce flake8 E123/6/7/8 in ironic https://review.openstack.org/186450 | 13:49 |
dtantsur | ^^^ \o/ | 13:49 |
sambetts | \o/ !! | 13:50 |
thiagop | dtantsur lucasagomes I hope I had answered your questions on the OneView spec | 13:50 |
dtantsur | will have a look asap | 13:50 |
rloo | NobodyCam: the google calendar is out of sync | 13:50 |
rloo | NobodyCam: I'll touch base with jlvillal then. | 13:51 |
thiagop | pshige: you too ^ | 13:53 |
NobodyCam | rloo: ya: https://wiki.openstack.org/w/index.php?title=Meetings/Ironic&diff=prev&oldid=76244 | 13:53 |
rloo | NobodyCam: thx. | 13:54 |
NobodyCam | :) | 13:55 |
lucasagomes | thiagop, sure thanks, I will re-review it as soon as possible | 13:55 |
lucasagomes | NobodyCam, rloo good ugt morning | 13:56 |
NobodyCam | good )UGT) morning lucasagomes :) | 13:56 |
rloo | hi lucasagomes! | 13:56 |
thiagop | I couldn't find ramesh on the channel these days. Our team is interested in helping him on the BootInterface stuff | 13:56 |
thiagop | do you know how can I reach him/her? | 13:57 |
dtantsur | thiagop, it's "he" and he's in India | 13:57 |
dtantsur | so he usually disappears before you appear | 13:57 |
thiagop | huahuahua | 13:57 |
*** athomas_ has quit IRC | 13:58 | |
thiagop | perhaps I could reach him by e-mail then... | 13:58 |
dtantsur | thiagop, I guess sending him a mail is a good start | 13:58 |
*** naohirot has quit IRC | 13:58 | |
*** stendulker_ has joined #openstack-ironic | 13:59 | |
*** e0ne is now known as e0ne_ | 13:59 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/187680 | 13:59 |
*** stendulker has quit IRC | 14:01 | |
stendulker_ | NobodyCam, lucasgomes, JoshNag: Can you please have a look at this UEFI secure boot spec for pxe driver when you get time. https://review.openstack.org/#/c/174295 | 14:02 |
stendulker_ | thiagop: ramesh is busy with some personal stuff for few days. He should be back by Monday. | 14:03 |
dtantsur | so folks, you may call me insane (I often am), but I've written blueprint https://blueprints.launchpad.net/ironic-inspector/+spec/node-not-found-hook that allows to write plugins (only plugins, not in-tree implementation) enabling discovery (in a sense of discovery) of new nodes using inspector. Wdyt? | 14:03 |
dtantsur | sambetts, you may be interested ^^^ | 14:03 |
* sambetts looks | 14:03 | |
*** e0ne_ has quit IRC | 14:04 | |
rloo | dtantsur: you're insane :-) | 14:04 |
dtantsur | rloo, thanks! :) | 14:04 |
thiagop | stendulker_: Ok. I'll send him an e-mail nonetheless to see if he'd like some help | 14:04 |
NobodyCam | stendulker_: I'll put it on the list for today :) Thank you for the poke :) | 14:05 |
stendulker_ | NobodyCam: Thank you :) | 14:05 |
trown | dtantsur: I like it, but you are also insane :), mostly since we are trying to clear up the discovery terminology only to add in actual discovery ;p | 14:05 |
*** e0ne has joined #openstack-ironic | 14:06 | |
dtantsur | trown, I'm not adding it, and I don't even talk much about it. but that becomes possible. again: no in-tree implementation for now, only hook point | 14:07 |
*** Nisha has joined #openstack-ironic | 14:07 | |
trown | dtantsur: ya, I think the limited scope makes sense | 14:08 |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Cache Keystone client instance https://review.openstack.org/186685 | 14:09 |
sambetts | dtantsur: would a user have to still pass a UUID into the introspect API endpoint so that it would trigger the NotFound? | 14:10 |
sambetts | i mean the UUID could be like "fake" or something | 14:11 |
sambetts | but still has to pass it right? | 14:11 |
BadCub | morning folks | 14:11 |
sambetts | good ugt morning BadCub | 14:12 |
trown | morning BadCub | 14:12 |
NobodyCam | morning BadCub | 14:12 |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Remove auth token saving from iLO driver https://review.openstack.org/187924 | 14:13 |
BadCub | mornign sambetts trown NobodyCam | 14:13 |
dtantsur | sambetts, no, no "introspect" call at all in this case. just node appearing out of nowhere (that's what discovery means) | 14:15 |
dtantsur | BadCub, morning | 14:15 |
*** saripurigopi has joined #openstack-ironic | 14:16 | |
*** mtanino has joined #openstack-ironic | 14:16 | |
BadCub | morning dtantsur :) | 14:17 |
*** mtanino_ has joined #openstack-ironic | 14:21 | |
sambetts | dtantsur: So it would hook off the NotFound exception thrown in process.py not the one in introspect.py ? | 14:21 |
dtantsur | sambetts, yep (probably I should be more clean about it) | 14:21 |
*** mtanino has quit IRC | 14:23 | |
lucasagomes | now all my patches needs rebase heh | 14:24 |
sambetts | lucasagomes: sorry :P | 14:24 |
thiagop | HAHA! | 14:24 |
lucasagomes | sambetts, hah no bothers man | 14:25 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: API: Get a subset of fields from Ports and Chassis https://review.openstack.org/183549 | 14:26 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: API: Get a subset of fields from Nodes https://review.openstack.org/183491 | 14:26 |
sambetts | dtantsur: so that would allow for nodes and they're info to be added into ironic, but it doesn't cover how they get the inspection image booted on them | 14:27 |
sambetts | s/they're/their | 14:27 |
dtantsur | sambetts, it can't cover - it can only use Ironic, and Ironic is not aware of nodes | 14:27 |
dtantsur | with discovery it's always like that | 14:27 |
sambetts | dtantsur: yeah thats fine that a really cool idea | 14:27 |
sambetts | dtantsur: it means that as long as you can get the inspector ramdisk on the machine somehow then inspection will work | 14:28 |
dtantsur | I believe so | 14:28 |
sambetts | dtantsur: does the ironic inspectors dhcp server allow for blanket pxe? | 14:32 |
sambetts | dtantsur: or do you limit it by MAC or somethig? | 14:32 |
dtantsur | sambetts, it's exactly what it is for :) inspector does not know MAC in advance | 14:32 |
sambetts | dtantsur: oooooooo | 14:33 |
sambetts | dtantsur: getting excited ... | 14:33 |
dtantsur | :) | 14:34 |
sambetts | dtantsur: so all we need to be able to do is somehow power the machines on if they can pxe, or in the case of a CMDB you don't even need to boot the machine you could just create some scripty thing to pull the info out of the CMDB and pipe it into the process function | 14:35 |
dtantsur | sambetts, yeah, In case of CMDB knowing everything, you probably don't even need the inspector :) | 14:36 |
*** jeh has joined #openstack-ironic | 14:37 | |
sambetts | not the pxe side of it, but it would probably be easier from a scripting perspective to just pull a blob from the CMDB and let the inspector's process function hooks take it apart and understand what it needs to add to ironic | 14:38 |
sambetts | the script could just mimic what the ramdisk would do | 14:39 |
*** mtanino_ has quit IRC | 14:39 | |
dtantsur | well, maybe | 14:41 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Override PXE kernel cmdline via Glance property https://review.openstack.org/178229 | 14:42 |
jlvillal | rloo, You mentioned the Google calendar? I did add that for the Ironic weekly meeting. | 14:42 |
rloo | jlvillal: were you intending on keeping it up to date? | 14:43 |
jlvillal | rloo, I am. | 14:43 |
*** mtanino has joined #openstack-ironic | 14:43 | |
rloo | jlvillal: i had added a 'next meeting' section in that wiki, so i'd be able to find/update that info quickly. | 14:43 |
jlvillal | rloo, I just checked it and I thought it was accurate??? | 14:43 |
jlvillal | https://www.google.com/calendar/embed?showPrint=0&showCalendars=0&mode=WEEK&height=600&wkst=1&bgcolor=%23FFFFFF&src=sodarock.com_fepuqkqe2333htb41n2n9qmue8%40group.calendar.google.com&color=%235229A3&ctz=America%2FLos_Angeles | 14:44 |
rloo | jlvillal: dunno I don't look at the calendar. someone on irc mentioned that it wasn't in sync with the 'next meeting' info. | 14:44 |
*** Nisha has quit IRC | 14:44 | |
NobodyCam | mornign jlvillal | 14:44 |
jlvillal | NobodyCam, Morning | 14:44 |
rloo | jlvillal: is that google calendar specific to your time zone? | 14:45 |
dtantsur | I hope Ironic won't use https://review.openstack.org/#/c/187896/ ? Otherwise I should go -1 it | 14:45 |
jlvillal | rloo, No. I put all times in using UTC. It should work for all time zones. | 14:45 |
jlvillal | rloo, I admit I can only see it in my time zone, so it would be nice if others can look at it. | 14:46 |
jlvillal | rloo, I just looked and in my view it shows the next meeting at the correct time. | 14:46 |
rloo | [1]cdearborn: wrt the google calendar, ^^ jlvillal sez it is up to date. what was out of sync, do you recall? | 14:46 |
*** chlong has quit IRC | 14:47 | |
[1]cdearborn | shows all meetings on Monday, no tuesday meetings | 14:47 |
BadCub | [1]cdearborn: Ironic doesn't have Tuesday meetings to my knowledge | 14:48 |
rloo | dtantsur: wrt that guideline, yeah, if we don't agree, we should voice our opinion. that's why i just sent out email. i didn't actually look at the guideline though, wanted to know what people thought. | 14:48 |
jlvillal | [1]cdearborn, What time zone are you in? | 14:48 |
BadCub | although the late-night MOnday meeting can overflow into Tusday for some | 14:48 |
rloo | [1]cdearborn, jlvillal: ah, I see the confusion. it is the timezone issue. | 14:48 |
jlvillal | [1]cdearborn, Are any meetings correct? | 14:48 |
[1]cdearborn | EDT - "The Meeting time alternates between 1700 UTC on Monday and 0500 UTC on Tuesday, to accommodate contributors from around the world." | 14:48 |
[1]cdearborn | from https://wiki.openstack.org/wiki/Meetings/Ironic | 14:48 |
rloo | [1]cdearborn: when you look at the google calendar, what timezone is it showing you? | 14:49 |
[1]cdearborn | Pacific | 14:49 |
jlvillal | [1]cdearborn, For us in PDT it is Monday at 10AM and Monday at 10PM | 14:49 |
NobodyCam | jlvillal: ++ | 14:50 |
jlvillal | [1]cdearborn, So it doesn't detect your time zone :( | 14:50 |
rloo | jlvillal: not good :-( | 14:50 |
[1]cdearborn | cdearbor: LOL! oh man - sorry! didn't notice the am/pm switch | 14:50 |
rloo | jlvillal: i mean, the google calendar. | 14:50 |
* [1]cdearborn cdearborn smacks forehead | 14:50 | |
NobodyCam | I think its working | 14:50 |
NobodyCam | :) | 14:50 |
sambetts | :) | 14:50 |
jlvillal | [1]cdearborn, So it doesn't update the time zone for you? To show your time zone? | 14:50 |
[1]cdearborn | yep - it's working - need more coffee! | 14:50 |
* jlvillal was hoping Google calendar would show user's correct time zone. | 14:51 | |
jlvillal | sambetts, Does the calendar update for your time zone? | 14:51 |
jlvillal | https://www.google.com/calendar/embed?showPrint=0&showCalendars=0&mode=WEEK&height=600&wkst=1&bgcolor=%23FFFFFF&src=sodarock.com_fepuqkqe2333htb41n2n9qmue8%40group.calendar.google.com&color=%235229A3&ctz=America%2FLos_Angeles | 14:51 |
[1]cdearborn | jlvillal, right, showing in Pacific | 14:51 |
jlvillal | [1]cdearborn, And you are in Eastern? | 14:51 |
[1]cdearborn | y - EDT | 14:51 |
jlvillal | :( | 14:51 |
rloo | jlvillal: I just checked. I'm in EST, and it shows me pacific. | 14:52 |
sambetts | its not updating for me and I'm in the uK | 14:52 |
NobodyCam | jlvillal: I'll bet it the " &ctz=America%2FLos_Angeles " bit on the end of the link | 14:52 |
dtantsur | rloo, replied to email, and commented on the guideline | 14:52 |
jlvillal | NobodyCam, Duh! :) | 14:52 |
sambetts | NobodyCam: I tried removing that it didn't help :-P | 14:53 |
jlvillal | sambetts, So it also shows Pacific for you. | 14:53 |
jlvillal | :( | 14:53 |
jlvillal | I'll investigate, but I might give up on it. | 14:53 |
sambetts | If you look at the bottom of the page it actually says "Events shown in time zone: Pacific Time" | 14:53 |
NobodyCam | jlvillal: have you looked over : https://support.google.com/calendar/answer/179200?hl=en | 14:53 |
jlvillal | NobodyCam, I'll check | 14:54 |
rloo | dtantsur: thx. I like that description 'if a sane user will be broken by that change' :-) | 14:55 |
[1]cdearborn | yeah - i was expecting a Tues meeting to show up, and only Mon meetings were showing, and coincidently, the times were all @ 10 - just didn't notice the am/pm switch | 14:55 |
* jlvillal has to go attend an 8am meeting... | 14:56 | |
[1]cdearborn | sorry guys - didn't mean to cause a rathole, but thx | 14:57 |
dtantsur | rloo, :) | 14:57 |
NobodyCam | [1]cdearborn: NP.. its good to test the tools we used to make sure they work as expected | 14:57 |
* [1]cdearborn starts guzzling coffee... | 14:59 | |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Do not preserve partitions after ephemeral https://review.openstack.org/182688 | 14:59 |
sambetts | rloo, dtantsur: sounds like something from a legal document :-P | 14:59 |
rloo | sambetts: can't be if you can understand it! | 15:00 |
sambetts | rloo: haha v.true | 15:00 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Allow referring to Glance images by name https://review.openstack.org/188429 | 15:00 |
*** eghobo has joined #openstack-ironic | 15:03 | |
*** hemnafkj is now known as hemna | 15:06 | |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add disk layout check on re-provisioning https://review.openstack.org/180014 | 15:07 |
*** romainh has left #openstack-ironic | 15:10 | |
*** alexpilotti has joined #openstack-ironic | 15:11 | |
jlvillal | saripurigopi, You have an issue with object not iterable for Mock tests in Python 3.4. I think sambetts ran into this issue. Might be a bug in Python 3.4 | 15:12 |
jlvillal | [1]cdearborn, ^^^^ Did you see this also? | 15:12 |
jlvillal | saripurigopi, Does the error occur in Jenkins? Or only locally? | 15:14 |
sambetts | jlvillal: that bug is interesting, I don't see it in python 3.4.0 but I do see it in python 3.4.2 | 15:14 |
saripurigopi | jlvillal: only locally | 15:15 |
jlvillal | saripurigopi, What is your Python 3.4 version? | 15:15 |
jlvillal | saripurigopi, And OS version? | 15:15 |
saripurigopi | jlvillal: Python 3.4.3, OSX 10.10 | 15:16 |
jlvillal | saripurigopi, sambetts I wonder if we will have to update our tests to make it compatible with the new Python 3.4 release? | 15:17 |
rloo | jlvillal: I noticed you added a 'Cross Projects Liaisons' table in the Ironic wiki. What do you think about replacing that with a link to https://wiki.openstack.org/wiki/CrossProjectLiaisons? Otherwise things could get out of sync | 15:18 |
saripurigopi | jlvillal: I think so | 15:22 |
jlvillal | rloo, Works for me. I saw the Nova project had a Cross Project Liaison section. So I copied that idea. | 15:23 |
rloo | jlvillal: what, for once, we have a better idea than nova? :) | 15:27 |
jlvillal | :) | 15:27 |
*** stendulker_ has quit IRC | 15:28 | |
lucasagomes | rloo, intresting discussion on when to bump the api version | 15:28 |
lucasagomes | rloo, I like sean's point | 15:29 |
rloo | lucasagomes: :) | 15:29 |
lucasagomes | it avoids the subjectivity bits | 15:29 |
*** zz_natorious is now known as natorious | 15:29 | |
rloo | lucasagomes: my first thought is that sean's point should be mentioned in the guideline. although maybe it is cuz i haven't read it yet | 15:30 |
rloo | lucasagomes: my second thought is that i should read it all thoroughly but i don't want to | 15:30 |
lucasagomes | lol | 15:30 |
rloo | lucasagomes: my third thought -- aren't you our liaison for the api stuff :) | 15:30 |
lucasagomes | I am yeah | 15:31 |
lucasagomes | not sure if I'm doing a great work to get my head around the micro versioning stuff | 15:31 |
rloo | lucasagomes: so sean's point i think goes back to the description used i nnova's microversions. bump it if non-backwards and/or a change in the API | 15:31 |
dtantsur | oh, we've found whom to blame :D | 15:31 |
lucasagomes | seems now people are starting to agree with something | 15:31 |
rloo | lucasagomes: push for http headers :) | 15:32 |
lucasagomes | rloo, yeah, I've suggested something in that thread | 15:32 |
lucasagomes | rloo, "Whenever a change is made to the API which is | 15:32 |
lucasagomes | visible to the client the micro version should be incremented" | 15:32 |
dtantsur | lucasagomes, "gives the clients a fine grained way to detect what are the API features available." oh no, it clearly does not... | 15:32 |
*** natorious is now known as zz_natorious | 15:33 | |
lucasagomes | dtantsur, says in the nova driver I want to fetch only part of the resources in the node | 15:33 |
lucasagomes | how I know if that's supported? | 15:33 |
lucasagomes | if we don't bump it | 15:33 |
lucasagomes | (that's not a non-backward compat change) | 15:33 |
dtantsur | by using special API for requesting capabilities | 15:33 |
dtantsur | using API version for that is no better than using software version | 15:34 |
dtantsur | i.e. parsing rpm -q openstack-nova | 15:34 |
dtantsur | for me API versioning is meant for not breaking people, not for (imperfect) feature discovery | 15:35 |
lucasagomes | right, yeah so there are many *ways* of doing it | 15:36 |
lucasagomes | whether using the header or a new endpoint | 15:36 |
*** eghobo has quit IRC | 15:37 | |
dtantsur | I think a good way is to ask for it, aka explicit better than implicit | 15:37 |
dtantsur | lucasagomes, ok, imagine us (red hat) backporting a feature (we do it a lot). how do we deal with it, when using microversions? | 15:38 |
dtantsur | (ok, not a lot, but we still do it) | 15:38 |
lucasagomes | well ideally we should NOT backport api changes | 15:38 |
lucasagomes | for stable branches that's a rule | 15:38 |
dtantsur | I'm talking about downstream | 15:38 |
dtantsur | it does happen, e.g. we backported Imre's RAID passthrough | 15:39 |
lucasagomes | right, for backports numberic versioning is not ideal at all... perhaps it should be a tag or something | 15:39 |
lucasagomes | but that's vendor | 15:39 |
lucasagomes | not core api | 15:39 |
dtantsur | it's a change visible to client | 15:39 |
lucasagomes | or vendor endpoints I don't think we make any compabilitiy guarantees | 15:40 |
lucasagomes | for* | 15:40 |
dtantsur | more rare example is that features can be disabled via configuration or by downstream patch | 15:40 |
* lucasagomes finds it hard to argue about downstreaming stuff | 15:41 | |
lucasagomes | cause that's mad | 15:41 |
rloo | hey NobodyCam, wrt Ironic wiki page, the sub-bullets are driving me crazy (1.1.1 Ironic 1.1.1.1 Api and conductor etc) | 15:41 |
dtantsur | lucasagomes, and finally, I just prefer explicit approach. people don't like guessing which features they have - and they introduce new way of _guessing_ | 15:42 |
rloo | NobodyCam: what were you trying to convey? Did you want it too look like '1.1.1 Ironic (Api and conductor)' | 15:42 |
rloo | NobodyCam: or did you want 'Api and conductor' to show up above the table? | 15:42 |
lucasagomes | dtantsur, sure yeah I can see it working... but if we bump the version on every visible change for the core api, we could have the client to ask as well "hey ironic what's ur min and max version" | 15:42 |
*** viktors is now known as viktors|afk | 15:43 | |
lucasagomes | and client will know what is avaible,... tho I agree with you that with backports | 15:43 |
lucasagomes | it sucks | 15:43 |
* lucasagomes flips the table | 15:43 | |
dtantsur | lucasagomes, that's good, but that's again attempt to guess :) instead of providing a way of explicitly tell | 15:43 |
NobodyCam | rloo: my intent was not to add sub bullets.. just to add a info like line to the wiki ... that all came from suggestions at the "new to ironic" table at the summit | 15:44 |
lucasagomes | dtantsur, yeah, it sounds a lot like the LBYL vs EAFP discussion | 15:44 |
lucasagomes | one could try to do something if there's an error the server will return min and max | 15:45 |
lucasagomes | so client can handle from there | 15:45 |
rloo | NobodyCam: did you want to add that info so it showed up in the Contents? https://wiki.openstack.org/wiki/Ironic | 15:45 |
lucasagomes | instead of asking what is supported and then doing the request | 15:45 |
rloo | NobodyCam: or only if you eg clicked on 'Ironic' and saw the table? | 15:45 |
lucasagomes | but anyway... yeah I'm happy people are having such discussion | 15:45 |
dtantsur | lucasagomes, I'm not sure the problem is not artificial at all. I've never heard rackspace folks, for example, complaining about API feature discovery missing in Ironic | 15:45 |
lucasagomes | cause I'm confused about it all | 15:45 |
NobodyCam | rloo: I was thinking just info text under each of the projects. | 15:47 |
rloo | NobodyCam: ok, I can make that change. thx. | 15:47 |
NobodyCam | comments I got at the summit were folks unclear as to what each one of the project was for | 15:48 |
NobodyCam | rloo: awesome and THank you | 15:48 |
dtantsur | ok, I think I've stated my point here, and now can go home :) | 15:48 |
dtantsur | see you! | 15:48 |
*** dtantsur is now known as dtantsur|afk | 15:48 | |
NobodyCam | night dtantsur|afk | 15:48 |
rloo | night dtantsur|afk and thanks! :) | 15:48 |
sambetts | night dtantsur|afk | 15:51 |
lucasagomes | rloo, +1 for click in Ironic and see the table | 15:52 |
rloo | lucasagomes: :) | 15:52 |
lucasagomes | rloo, if all 1.X.Y will have only 1 submenu it makes sense to not have a submenu at all | 15:52 |
rloo | lucasagomes: yeah, and that wasn't the intent at all. editing now... | 15:53 |
lucasagomes | cooleo | 15:53 |
lucasagomes | rloo, btw the "1 OpenStack Bare Metal Provisioning Program" seems bollocks too | 15:54 |
lucasagomes | it's a bullet list with only 1 bullet | 15:54 |
lucasagomes | we can get rid of that too (if you don't mind :-) ) | 15:54 |
rloo | lucasagomes: ah, yes, you're right. will do. | 15:54 |
*** Nisha has joined #openstack-ironic | 15:58 | |
jlvillal | NobodyCam, I added a Future Meetings section to https://wiki.openstack.org/wiki/Meetings/Ironic#Future_Meetings | 15:59 |
jlvillal | NobodyCam, I was hoping it will make it easier for you to cut and paste as each week goes by. | 16:00 |
*** jistr has quit IRC | 16:01 | |
openstackgerrit | Matt Keenan proposed openstack/ironic: get_supported_boot_devices() returns static device list https://review.openstack.org/188466 | 16:05 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/188475 | 16:18 |
rloo | ok, who touched the ironic wiki page while i was editing it? ... | 16:20 |
* lucasagomes didn't | 16:21 | |
lucasagomes | rloo, you probably can see the history of changes | 16:22 |
rloo | lucasagomes: yeah i can see the changes. but i made a lot of changes and i need to remake them or something. thinking... | 16:22 |
lucasagomes | rloo, :-( | 16:23 |
rloo | lucasagomes: no worries. nothing like copy/paste. it showed me my changes so copied them over the 'to-be-changed' text. hope it works... | 16:24 |
* BadCub is not guilty of touching the WIKI lol | 16:24 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/188495 | 16:24 |
lucasagomes | BadCub, +1 yeah nobody should | 16:24 |
BadCub | lucasagomes: indeed | 16:25 |
*** gridinv_ has joined #openstack-ironic | 16:26 | |
BadCub | my brain is now numb from lengthy, boring conference call | 16:26 |
rloo | ok, wiki has been updated. I added a new 'people' section but no, your names aren't in highlights there :) | 16:27 |
lucasagomes | devananda, rloo re bump microversioning... So, it seems there are an agreement about bumping it for every change that the client sees | 16:27 |
lucasagomes | which I think is sane (after reading that email thread) | 16:28 |
rloo | lucasagomes: so new API/endpoint too? | 16:28 |
lucasagomes | yes | 16:28 |
rloo | lucasagomes: so much more work. argh. i didn't follow the discussion you had with dmitry. do we need to give him some beers next time we see him, to make him feel better? | 16:29 |
lucasagomes | hah | 16:29 |
lucasagomes | the discussion is really a brainstorm | 16:29 |
lucasagomes | I mean, I never had a strong opnion on microversioning but I'm glad that email thread is doing it | 16:29 |
rloo | lucasagomes: ok, would be nice to make everyone happy but ... | 16:30 |
lucasagomes | I mean I'm forming one opnion on it | 16:30 |
lucasagomes | in any case, I've -2 my patch about fetch subresources until we have something defined on it | 16:30 |
lucasagomes | fetch subset* | 16:31 |
lucasagomes | damn my english is going down, I'm tired... should go home soon | 16:31 |
rloo | lucasagomes: i don't want the microversion stuff to hold up any specs. | 16:31 |
lucasagomes | rloo, oh no... it's great | 16:31 |
lucasagomes | I just want to have something defined and clear | 16:31 |
rloo | lucasagomes: go home :D | 16:31 |
*** gridinv_ has quit IRC | 16:32 | |
rloo | lucasagomes: i didn't read your spec but if i understand what it is, i woudl have thought (before today's email) or hoped that it wouldn't need a version bump | 16:32 |
NobodyCam | TheJulia: have you seen : http://logs.openstack.org/62/187362/5/check/gate-bifrost/76502da/console.html#_2015-06-04_16_01_08_635 | 16:32 |
lucasagomes | rloo, yeah, it's not a spec tho... it's just the patch | 16:33 |
lucasagomes | rloo, yeah based on the last discussion we had with devananda I would say it wouldn't need one bump either | 16:33 |
rloo | lucasagomes: oh. a patch. yeah, guess it makes sense to defer/wait. (or bump the microversion). | 16:33 |
lucasagomes | but the email thread seems to be proving the opossite, which is good... I think we are coming to a conclusion on that | 16:33 |
*** marzif_ has joined #openstack-ironic | 16:37 | |
*** eghobo has joined #openstack-ironic | 16:37 | |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add disk layout check on re-provisioning https://review.openstack.org/180014 | 16:41 |
*** erelwell is now known as bethelwell | 16:46 | |
NobodyCam | rloo: thank you wiki looks MUCH better :) | 16:54 |
*** trown is now known as trown|lunch | 16:56 | |
*** marzif_ has quit IRC | 17:00 | |
*** ukalifon has quit IRC | 17:02 | |
sambetts | right, I'm calling it a day here, cya tomorrow :) | 17:03 |
sambetts | o/ | 17:03 |
lucasagomes | yeah same here, I will gotta grab the train back home (came to the office today) | 17:03 |
lucasagomes | sambetts, night | 17:04 |
lucasagomes | good night everyone! | 17:04 |
sambetts | night lucasagomes | 17:04 |
*** bethelwell has quit IRC | 17:04 | |
rloo | NobodyCam: :) | 17:08 |
rloo | night lucasagomes | 17:09 |
rloo | night sambetts | 17:09 |
NobodyCam | night lucasagomes | 17:09 |
NobodyCam | night sambetts | 17:09 |
lucasagomes | see y'all later! | 17:10 |
lucasagomes | going | 17:10 |
*** lucasagomes has quit IRC | 17:10 | |
*** saripurigopi has quit IRC | 17:11 | |
*** marzif_ has joined #openstack-ironic | 17:11 | |
*** pradipta has joined #openstack-ironic | 17:17 | |
*** bradjones is now known as bradjones_away | 17:19 | |
*** Nisha has quit IRC | 17:20 | |
dhellmann | devananda, NobodyCam: before we release a new oslo.messaging with my cleaned up fix for the option registration thing that bit you earlier this week, I'd like to test it. Do you have a writeup on how to run the tests? | 17:22 |
*** e0ne has quit IRC | 17:22 | |
*** dan| is now known as dan | 17:23 | |
*** Nisha has joined #openstack-ironic | 17:23 | |
*** dguerri is now known as dguerri`away | 17:24 | |
*** dguerri`away is now known as dguerri | 17:24 | |
*** dguerri is now known as dguerri`away | 17:24 | |
dhellmann | lintan: maybe as our liaison, you can help with ^^ ? | 17:25 |
*** Viswanath has joined #openstack-ironic | 17:25 | |
NobodyCam | dhellmann: humm I think the only stuff we have written on running test is on : http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html about mid wya thru the first section. | 17:29 |
*** Viswanath has quit IRC | 17:30 | |
*** ndipanov has quit IRC | 17:30 | |
*** spandhe has joined #openstack-ironic | 17:31 | |
*** edcragg has quit IRC | 17:32 | |
rloo | dhellmann: I believe lintan is in Asia so he may not be online now. | 17:38 |
TheJulia | NobodyCam: saw that, just haven't sat down to look at it yet | 17:43 |
*** pelix has quit IRC | 17:45 | |
*** dontalton has joined #openstack-ironic | 17:47 | |
*** jjohnson2 has joined #openstack-ironic | 17:51 | |
jlvillal | dhellmann: adam_g might be a good resource | 17:51 |
TheJulia | NobodyCam: I think it is just the fact that it needed to be rebased... tested locally just fine after rebasing. Just shipped up the updated ref to gerrit | 17:52 |
*** Nisha has quit IRC | 17:53 | |
adam_g | a simple test would be to deploy ironic (with devstack or in a venv pointed at real messaging server) /w the oslo change and do an 'ironic driver-list' | 17:53 |
*** Nisha has joined #openstack-ironic | 17:54 | |
*** ukalifon has joined #openstack-ironic | 17:54 | |
NobodyCam | brb | 17:54 |
jlvillal | dhellmann: ^^^^^ | 17:55 |
*** igordcard_ has joined #openstack-ironic | 17:55 | |
*** marzif_ has quit IRC | 17:55 | |
*** igordcard_ has quit IRC | 17:56 | |
*** marzif_ has joined #openstack-ironic | 17:56 | |
*** igordcard_ has joined #openstack-ironic | 17:56 | |
*** Nisha has quit IRC | 17:57 | |
*** trown|lunch is now known as trown | 17:57 | |
*** Nisha has joined #openstack-ironic | 17:58 | |
*** ijw has joined #openstack-ironic | 18:00 | |
*** Viswanath has joined #openstack-ironic | 18:01 | |
*** barra204 has joined #openstack-ironic | 18:01 | |
*** Viswanath has quit IRC | 18:04 | |
*** barra204 has quit IRC | 18:07 | |
dhellmann | rloo: thanks | 18:10 |
dhellmann | jlvillal, adam_g : thanks, that may be enough to get me going | 18:10 |
adam_g | maybe someone has a dev env up now they can just pull your oslo.messaging patch into and test? | 18:11 |
dhellmann | NobodyCam: I was hoping for the integration tests, or whatever was failing before | 18:11 |
dhellmann | adam_g: that would be cool, too, I just didn't want to impose. https://review.openstack.org/#/c/188163/ | 18:12 |
adam_g | dhellmann, the failure before wasnt the test itself but ironic being non-functioning. a driver-list or some other commands will do a basic exercise of the messaging layer | 18:12 |
adam_g | jlvillal, did you manage to get setup with devstack since tuesday? | 18:13 |
dhellmann | adam_g: ok, I guess I'm just looking for the simplest possible way to verify that, and it sounds like running a couple of commands like you suggest would do that | 18:13 |
dhellmann | I thought maybe if I could "tox -e functional" or something I wouldn't have to actually install everything :-) | 18:13 |
adam_g | yup | 18:13 |
jlvillal | adam_g: in progress. I have been working on getting the Ubuntu cloud image to work with virt-install. | 18:13 |
*** dprince has quit IRC | 18:13 | |
jlvillal | adam_g: And then getting side-lined with meetings and other stuff :( | 18:13 |
adam_g | is the gate still blocked? | 18:15 |
dhellmann | adam_g: no, this is a "nicer" version of the fix, and I want to make sure I don't re-break you guys | 18:15 |
adam_g | dhellmann, ah cool. ill see if i can bring up an env from this laggy cafe wifi to do a quick sniff | 18:16 |
dhellmann | adam_g: sweet, I owe you one | 18:16 |
*** dguerri`away is now known as dguerri | 18:17 | |
*** pradipta has quit IRC | 18:17 | |
*** bethelwell has joined #openstack-ironic | 18:19 | |
*** Sukhdev has joined #openstack-ironic | 18:22 | |
Sukhdev | jroll, devananda: Ping | 18:23 |
jroll | heya Sukhdev | 18:23 |
*** ukalifon has quit IRC | 18:24 | |
Sukhdev | jroll: Bertie, pushed this https://review.openstack.org/#/c/188528 - please have a look | 18:24 |
jroll | wonderful, thanks | 18:24 |
jroll | Sukhdev: also https://review.openstack.org/#/c/187829/ | 18:25 |
Sukhdev | jroll: cool - thanks - will review it | 18:25 |
jroll | awesome | 18:25 |
*** eghobo_ has joined #openstack-ironic | 18:25 | |
*** eghobo has quit IRC | 18:27 | |
*** [1]cdearborn has quit IRC | 18:29 | |
*** bradjones_away is now known as bradjones | 18:29 | |
adam_g | dhellmann, which oslo.messaging release was broken? | 18:32 |
*** edcragg has joined #openstack-ironic | 18:39 | |
*** openstackstatus has joined #openstack-ironic | 18:39 | |
*** ChanServ sets mode: +v openstackstatus | 18:39 | |
*** bradjones is now known as bradjones_away | 18:40 | |
-openstackstatus- NOTICE: Gerrit has been restarted to clear an issue with its event stream. Any change events between 17:25 and 18:38 UTC should be rechecked or have their approvals reapplied to initiate testing. | 18:42 | |
dhellmann | adam_g: 1.12.0 | 18:45 |
dhellmann | adam_g: 1.13.0 had the hacky fix | 18:46 |
*** marzif_ has quit IRC | 18:47 | |
*** dprince has joined #openstack-ironic | 18:49 | |
*** dguerri is now known as dguerri`away | 18:51 | |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Install the ironicclient into the 'venv' virtualenv https://review.openstack.org/188550 | 18:58 |
*** krtaylor has quit IRC | 18:59 | |
*** vishwana_ has joined #openstack-ironic | 19:04 | |
*** marzif_ has joined #openstack-ironic | 19:04 | |
*** vishwanathj has quit IRC | 19:06 | |
*** [1]cdearborn has joined #openstack-ironic | 19:09 | |
*** Nisha has quit IRC | 19:12 | |
*** Viswanath has joined #openstack-ironic | 19:18 | |
*** ifarkas has quit IRC | 19:19 | |
*** Viswanath has quit IRC | 19:21 | |
*** krtaylor has joined #openstack-ironic | 19:23 | |
*** spandhe has quit IRC | 19:38 | |
*** afaranha has left #openstack-ironic | 19:45 | |
*** afaranha has joined #openstack-ironic | 19:45 | |
*** ijw_ has joined #openstack-ironic | 19:50 | |
*** ijw has quit IRC | 19:52 | |
*** e0ne has joined #openstack-ironic | 19:55 | |
*** Viswanath has joined #openstack-ironic | 19:55 | |
*** dprince has quit IRC | 19:56 | |
NobodyCam | brb | 19:59 |
*** Viswanath has quit IRC | 20:00 | |
*** marzif_ has quit IRC | 20:00 | |
*** edcragg has quit IRC | 20:06 | |
*** Viswanath has joined #openstack-ironic | 20:07 | |
*** [1]cdearborn has quit IRC | 20:07 | |
*** ijw_ has quit IRC | 20:08 | |
*** ijw has joined #openstack-ironic | 20:09 | |
*** Viswanath has quit IRC | 20:10 | |
*** cdearborn has joined #openstack-ironic | 20:13 | |
*** Viswanath has joined #openstack-ironic | 20:16 | |
TheJulia | It has been really quiet in here today | 20:19 |
*** sinval has quit IRC | 20:19 | |
*** Viswanath has quit IRC | 20:20 | |
NobodyCam | :) | 20:22 |
NobodyCam | that means its all working | 20:22 |
*** Sukhdev has quit IRC | 20:22 | |
trown | TheJulia: are you going to the OpenStack 5th birthday in RDU? I think I met you there last year | 20:22 |
trown | very briefly, if so | 20:23 |
*** stendulker has joined #openstack-ironic | 20:25 | |
*** dguerri`away is now known as dguerri | 20:26 | |
*** bradjones_away has quit IRC | 20:26 | |
TheJulia | trown: Possibly, I was there, but it seemed like an awkward bunch. Although, I will now drink english ales :) | 20:26 |
TheJulia | trown: was not planning on attending | 20:26 |
trown | TheJulia: I think I am in the "awkward bunch" category :) | 20:28 |
NobodyCam | TheJulia: I really what to make the nginx port configurable in bifrost .. 8080 keeps bumping heads with swift proxy | 20:28 |
*** Haomeng|2 has joined #openstack-ironic | 20:28 | |
TheJulia | Looks like it is at fortnight brewing again | 20:28 |
trown | TheJulia: indeed | 20:28 |
TheJulia | NobodyCam: I look forward to the patch :) | 20:28 |
NobodyCam | lol | 20:28 |
*** dguerri is now known as dguerri` | 20:29 | |
*** ijw_ has joined #openstack-ironic | 20:29 | |
*** Haomeng has quit IRC | 20:30 | |
TheJulia | trown: RSVP'ed | 20:31 |
trown | TheJulia: cool, you will be the first Ironic person I have met in person | 20:31 |
*** bradjones has joined #openstack-ironic | 20:32 | |
trown | even though I work with lucasagomes dtantsur and ifarkas | 20:32 |
*** ijw has quit IRC | 20:32 | |
*** stendulker has quit IRC | 20:32 | |
*** romcheg has joined #openstack-ironic | 20:39 | |
NobodyCam | brb stepping afk to eat pizza | 20:43 |
*** spandhe has joined #openstack-ironic | 20:44 | |
*** Viswanath has joined #openstack-ironic | 20:44 | |
*** igordcard_ has quit IRC | 20:45 | |
*** Viswanath has quit IRC | 20:47 | |
openstackgerrit | Jarrod Johnson proposed stackforge/pyghmi: Support systems with IPv6 disabled https://review.openstack.org/188590 | 20:48 |
TheJulia | trown: cool! | 20:55 |
*** ijw_ has quit IRC | 21:00 | |
*** ijw has joined #openstack-ironic | 21:00 | |
*** e0ne has quit IRC | 21:05 | |
*** trown is now known as trown|outttypeww | 21:08 | |
*** ijw has quit IRC | 21:10 | |
*** ijw has joined #openstack-ironic | 21:10 | |
*** ijw_ has joined #openstack-ironic | 21:20 | |
*** ijw has quit IRC | 21:23 | |
*** zer0c00l has quit IRC | 21:26 | |
*** zer0c00l has joined #openstack-ironic | 21:26 | |
*** jjohnson2 has quit IRC | 21:27 | |
openstackgerrit | Michael Davies proposed openstack/python-ironicclient: Cache negotiated api microversion for server https://review.openstack.org/173674 | 21:40 |
mrda | hi rloo | 21:46 |
rloo | hi mrda | 21:46 |
mrda | still online? | 21:46 |
mrda | Good evening! | 21:46 |
mrda | So on the spec - I've just replied to your comment | 21:46 |
rloo | mrda: yeah, for another 15 min or so :-) ok, will look. | 21:47 |
mrda | thanks | 21:47 |
rloo | mrda: so it seems like the caching is a new feature. Yes? | 21:48 |
NobodyCam | good morning mrda | 21:48 |
mrda | Well, it was called out in the api microversion spec | 21:50 |
mrda | which was informational | 21:50 |
mrda | and it was left as a TODO in the code, by deva, whwn he did the client microversion stuff | 21:50 |
rloo | mrda: right, informational. and even though called out, it was something like 'we should have a cache'. | 21:50 |
rloo | mrda: those discussions/questions/decisions that came about due to your patch are basically what ought to be put in a spec. | 21:51 |
mrda | And in the review Monty and Deva, in review commenrts, decided that dogpile.cache should be used | 21:51 |
mrda | right | 21:51 |
rloo | mrda: which is why i think it is a small spec, even though i don't know what a small spec is. | 21:51 |
mrda | Sure rloo - I'll go write a spec then | 21:51 |
mrda | thanks for your review | 21:52 |
rloo | mrda: So spec -- add caching. Use dogpile.cache cuz some other crossproject something in openstack is using it. | 21:52 |
rloo | mrda: thx. and just because devananda and monty said something, doesn't mean others will agree, so this is their change to provide input. | 21:52 |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Initial inventory module https://review.openstack.org/184084 | 21:53 |
rloo | mrda: although I believe monty and devananda were right in this situation :-) | 21:53 |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Initial dynamic enrollment role https://review.openstack.org/188176 | 21:53 |
rloo | mrda: s/change/chance/. Anyway, it'll be documented. | 21:53 |
mrda | rloo: tbh, I'm not seeing the value. But I can see to get this (small) patch landed there's no way around it. So I'll wriet the spec. | 21:55 |
rloo | mrda: no value cuz you know how you've implemented it? | 21:55 |
rloo | mrda: or no value cuz who cares about specs? | 21:55 |
mrda | well, the discussion happened in the patch - in this instance. And it's not a contentious issue. | 21:56 |
*** krtaylor has quit IRC | 21:56 | |
*** romcheg has quit IRC | 21:56 | |
rloo | mrda: there could be a way around it wrt getting your patch to land. I have no idea what/if other cores agree with needing a spec. | 21:56 |
mrda | I think specs are worth it - if it indeed gets discussion going and gathers team consensus | 21:56 |
mrda | rloo: It's no big deal. I'll write the spec. | 21:57 |
rloo | mrda: but that's the point. there shouldn't have needed to be a discussion in the patch -- it should have been discussed/decided (ie in a spec) | 21:57 |
mrda | So I would have written a spec if I thought one was needed initially. I thought the combination of the api microversion spec and deva's TODOs in the code were sufficient. | 21:58 |
mrda | But it's ok that we have a different opinion - and I'm happy to follow direction | 21:58 |
rloo | mrda: but the spec isn't meant for you to know what/how to code. it is meant for communicating with anyone that is interested. | 21:58 |
rloo | mrda: if you hadn't written that code, and someone said to you that they wanted to have caching for something. Would you think a spec would be useful or would you be ok if they submitted a patch? | 21:59 |
mrda | See logical-name spec. Spec is approved. Code is approved. But now it's like "WTF?!? why are there restrictions on what a name can be?". Specs don't always fulfill their purpose (i.e. not always considered carefully) | 22:00 |
rloo | mrda? huh. a spec doesn't mean something is written in stone and cannot change. | 22:00 |
mrda | rloo: agreed | 22:01 |
mrda | I agree rloo, my piont is that specs don't always fulfill the purpose of gaining project consensus like they should | 22:03 |
* mrda wanders off to write a spec | 22:04 | |
*** cdearborn has quit IRC | 22:05 | |
rloo | mrda: agreed, but hopefully better than w/o specs... | 22:06 |
*** ijw_ has quit IRC | 22:09 | |
openstackgerrit | Mario Villaplana proposed openstack/ironic-specs: Adds spec for creating a key manager with Barbican to Ironic https://review.openstack.org/188609 | 22:10 |
*** ijw has joined #openstack-ironic | 22:12 | |
openstackgerrit | Mario Villaplana proposed openstack/ironic-specs: Adds spec for creating a key manager with Barbican to Ironic https://review.openstack.org/188609 | 22:14 |
*** spandhe has quit IRC | 22:16 | |
mariojv | hi all - if anyone looks at the above spec, they might find https://review.openstack.org/#/c/171918/ interesting too | 22:16 |
mariojv | would eventually like to use that instead if adopted by the rest of openstack, but it looks like it isn't really usable quite yet | 22:17 |
openstackgerrit | Summer Barringer proposed openstack/bifrost: Add DHCP documentation https://review.openstack.org/187415 | 22:18 |
*** bradbeam has quit IRC | 22:18 | |
*** eghobo_ has quit IRC | 22:22 | |
*** spandhe has joined #openstack-ironic | 22:25 | |
*** jrist has quit IRC | 22:26 | |
*** krtaylor has joined #openstack-ironic | 22:26 | |
*** bradbeam has joined #openstack-ironic | 22:27 | |
*** Sukhdev has joined #openstack-ironic | 22:29 | |
*** bradbeam_ has joined #openstack-ironic | 22:30 | |
*** rwsu has quit IRC | 22:30 | |
*** ijw has quit IRC | 22:32 | |
*** ijw has joined #openstack-ironic | 22:32 | |
*** jrist has joined #openstack-ironic | 22:34 | |
*** bradbeam has quit IRC | 22:34 | |
*** dontalton has quit IRC | 22:35 | |
*** bradbeam has joined #openstack-ironic | 22:37 | |
*** bradbeam_ has quit IRC | 22:40 | |
*** ijw has quit IRC | 22:42 | |
*** ijw has joined #openstack-ironic | 22:43 | |
*** bethelwell has quit IRC | 22:44 | |
*** ijw_ has joined #openstack-ironic | 22:53 | |
*** ijw has quit IRC | 22:56 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Enable agent_ipmitool driver when testing https://review.openstack.org/188623 | 23:08 |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Addition of dynamic configuration drives https://review.openstack.org/188624 | 23:08 |
*** radek_ has quit IRC | 23:09 | |
*** bradbeam has quit IRC | 23:20 | |
*** chlong has joined #openstack-ironic | 23:27 | |
*** enikanorov_ has quit IRC | 23:29 | |
*** enikanorov__ has joined #openstack-ironic | 23:29 | |
*** zhenguo has joined #openstack-ironic | 23:30 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Support for disabling DHCP server configuration https://review.openstack.org/187362 | 23:30 |
*** bradjones has quit IRC | 23:36 | |
*** cdearborn has joined #openstack-ironic | 23:37 | |
*** bradjones has joined #openstack-ironic | 23:39 | |
*** eghobo has joined #openstack-ironic | 23:41 | |
*** eghobo_ has joined #openstack-ironic | 23:43 | |
*** hemna is now known as hemnafk | 23:43 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Add DHCP documentation https://review.openstack.org/187415 | 23:44 |
*** eghobo has quit IRC | 23:46 | |
*** rloo has quit IRC | 23:47 | |
*** jhova has quit IRC | 23:48 | |
openstackgerrit | Chris Krelle proposed openstack/bifrost: WIP: make nginx port configurable https://review.openstack.org/188631 | 23:50 |
NobodyCam | TheJulia: ^^^^^ | 23:51 |
* TheJulia looks | 23:52 | |
TheJulia | looks good so far | 23:55 |
TheJulia | I realized I'll need some way to define multiple ironic API urls since my current test env is ipmi and ssh on the same run | 23:56 |
TheJulia | muahahahaha | 23:56 |
NobodyCam | :) | 23:57 |
TheJulia | which means... virbr0 and eth0 and I think adding a route on my router is lame | 23:58 |
NobodyCam | but it is once again that magic time when rum just appers in the dite coke I've been drinking all day... :) | 23:58 |
NobodyCam | so I will say G'Night | 23:58 |
NobodyCam | and see ya in morning (ugt, ofc) | 23:58 |
TheJulia | awww | 23:58 |
TheJulia | goodnight NobodyCam | 23:59 |
NobodyCam | :) | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!