*** naohirot has joined #openstack-ironic | 00:01 | |
naohirot | good morning ironic | 00:02 |
---|---|---|
naohirot | devananda: jroll: I just looked at the IRC meeting summary, you are going to vacation. | 00:03 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] remove tests that fail with latest o.vo https://review.openstack.org/216470 | 00:03 |
naohirot | devananda: jroll: I'd like to get your feed back about the soft reboot and inject nmi spec and poc. | 00:04 |
naohirot | devananda: jroll: spec is https://review.openstack.org/#/c/186700/ | 00:04 |
jlvillal | naohirot: jroll is on vacation this week. As an FYI | 00:04 |
naohirot | devananda: jroll: poc is https://review.openstack.org/#/c/207897/ | 00:05 |
naohirot | jlvillal: Yeah, I know. but it's kind of surprise because I switched the vendor implementaiton t | 00:06 |
*** lucas-dinner has quit IRC | 00:06 | |
naohirot | jlvillal: because I switched vendor implementation to generic implementation based on the core's decision, mainly jim. | 00:07 |
jlvillal | naohirot: Okay | 00:08 |
*** smoriya has joined #openstack-ironic | 00:11 | |
jlvillal | rloo: mrda: I think we might be in trouble with this oslo.versionedobjects release. | 00:13 |
jlvillal | dansmith says it will be a lot of work for us to fix it properly in Ironic :( | 00:13 |
jlvillal | And cinder and nova have been waiting for the release for their Liberty work. | 00:13 |
mrda | Yeah sounds like it | 00:15 |
mrda | We might have to revert oslo.versionedobjects for a while | 00:15 |
jlvillal | mrda: I think they may push back on that. Not sure how that works. | 00:18 |
jlvillal | mrda: They are pushing back on reverting release. | 00:22 |
* jlvillal wishes devananda was around | 00:22 | |
*** shadower has quit IRC | 00:23 | |
*** shadower has joined #openstack-ironic | 00:23 | |
openstackgerrit | Dan Smith proposed openstack/ironic: Revert "Migrate ObjectListBase to subclass from the Oslo one" https://review.openstack.org/216472 | 00:26 |
*** mtanino has quit IRC | 00:30 | |
jlvillal | rloo: devananda: ^^^^^ Please look at that patch. It is needed to unblock the gate. | 00:31 |
jlvillal | mrda: Maybe you can ping some of the cores when they come online. If rloo and devananda are not available to look at it. | 00:32 |
*** baoli has joined #openstack-ironic | 00:38 | |
*** shoutm_ has joined #openstack-ironic | 00:43 | |
*** zhenguo has joined #openstack-ironic | 00:43 | |
mrda | thanks jlvillal | 00:45 |
*** shoutm has quit IRC | 00:45 | |
jlvillal | mrda: Thanks to dansmith! | 00:46 |
mrda | yup | 00:46 |
jlvillal | mrda: Maybe you can get him an Ironic shirt. And if you have more, maybe I could get one ;) | 00:46 |
*** BadCub has quit IRC | 00:46 | |
*** Ng has quit IRC | 00:47 | |
mrda | jlvillal: I don't know of such things, except the ones I've made myself via cafepress :) | 00:47 |
*** zsmithnyc has quit IRC | 00:47 | |
mrda | (with the exception of pixie boots) | 00:47 |
*** Ng has joined #openstack-ironic | 00:47 | |
jlvillal | darn! | 00:47 |
*** zsmithnyc has joined #openstack-ironic | 00:48 | |
*** BadCub has joined #openstack-ironic | 00:48 | |
*** praneshp has quit IRC | 00:48 | |
*** shoutm_ has quit IRC | 01:03 | |
*** shoutm has joined #openstack-ironic | 01:08 | |
*** lintan__ has joined #openstack-ironic | 01:12 | |
*** lazy_prince has joined #openstack-ironic | 01:17 | |
openstackgerrit | Tan Lin proposed openstack/ironic: Add a new field ListOfObjectField https://review.openstack.org/213601 | 01:18 |
*** dprince has quit IRC | 01:21 | |
openstackgerrit | Yuiko Takada proposed openstack/ironic: Fix ascii codec error https://review.openstack.org/216478 | 01:31 |
*** asd112z has joined #openstack-ironic | 01:35 | |
*** tsekiyam_ has joined #openstack-ironic | 01:47 | |
*** tsekiyama has quit IRC | 01:50 | |
*** tsekiyam_ has quit IRC | 01:51 | |
*** Haomeng has joined #openstack-ironic | 01:56 | |
*** Haomeng|2 has quit IRC | 01:58 | |
openstackgerrit | Merged openstack/python-ironic-inspector-client: Fix error message for unsupported API version https://review.openstack.org/212003 | 01:58 |
*** shoutm_ has joined #openstack-ironic | 02:01 | |
*** rameshg87 has joined #openstack-ironic | 02:01 | |
*** shoutm has quit IRC | 02:03 | |
jlvillal | Haomeng, rameshg87: The gate is broken | 02:08 |
jlvillal | Haomeng, rameshg87: Believe this can fix things for now: https://review.openstack.org/216472 | 02:08 |
* rameshg87 checks | 02:08 | |
jlvillal | rameshg87, Thank you | 02:08 |
rloo | jlvillal, mrda: so we need to revert? | 02:08 |
jlvillal | rloo, https://review.openstack.org/216472 is a proposed fix from dansmith | 02:09 |
jlvillal | rloo, Strong pushback on reverting the oslo.versionedobjects release. | 02:09 |
rameshg87 | jlvillal: I had seen somewhere we requested to remove that class itself | 02:09 |
lintan__ | what about remove ObjectListBase | 02:09 |
rloo | jlvillal: did you see lintan__'s suggestion? | 02:09 |
jlvillal | lintan__, If you can make a patch that fixes it, that would be great. | 02:09 |
rameshg87 | https://review.openstack.org/#/c/213601/ | 02:10 |
jlvillal | rameshg87, It fails unit tests | 02:10 |
rameshg87 | lintan__: ^^ this one, right ? | 02:10 |
rloo | jlvillal: there is a chicken/egg problem though. devananda asked that we didn't approve anything. | 02:10 |
rameshg87 | jlvillal: that patch doesn't implement the removal yet | 02:10 |
jlvillal | rameshg87, Yeah. | 02:10 |
rameshg87 | jlvillal: only comments were added to remove it | 02:10 |
lintan__ | yes, I will remove the objectlist if all agree on that | 02:11 |
jlvillal | At the moment we have one patch that fixes the gate. If another patch can be done that fixes it better that sounds good too. Depends how long want to wait. | 02:11 |
jlvillal | rloo, Yes, devananda's patch can't get merged until gate is fixed. | 02:11 |
*** achanda has joined #openstack-ironic | 02:11 | |
jlvillal | rloo, So yes chicken and egg. Catch-22, etc... ;) | 02:11 |
rameshg87 | I am +1 on removing it as it's not used. | 02:12 |
rloo | lintan__: are you OK if we revert, then you do whatever changes later? | 02:12 |
lintan__ | what about this, let's remove the test of objectlist which block the gate, then remove the code | 02:12 |
jlvillal | lintan__, No | 02:12 |
jlvillal | dansmith said that there are real issues. | 02:13 |
lintan__ | I am fine with this , rloo | 02:13 |
jlvillal | That removing the test is wrong. | 02:13 |
jlvillal | We had IRC conversation on #openstack-nova earlier. Read today's log | 02:13 |
rloo | lintan__: i don't actually know what the issue is. so if you're fine with reverting (and if we revert, our stuff still works?), then that is probably easiest/safest to do. | 02:13 |
rloo | lintan__: could you please put your +1 (if it looks ok to you) on https://review.openstack.org/#/c/216472/ | 02:14 |
lintan__ | rloo, that's because versionedobject increase to 0.8 and change some behaviors, which break Ironic's versionedobject | 02:15 |
lintan__ | OK | 02:15 |
rloo | lintan__: right, and it sounds like nova etc need 0.8, so we can't pin it to an older version | 02:15 |
rloo | lintan__: the NERVE of them. but what can we do... | 02:15 |
jlvillal | rloo, dims did apologize for not testing on Ironic. Well that his test didn't work correctly and didn't actually pull in the new versionedobjects | 02:16 |
rloo | everyone, note that the only reason (well, only urgent reason i can think of) to get gate working sooner rather than later, is for devananda to be able to get the ironic release done. | 02:17 |
jlvillal | +1, if a better fix can be done. That works for me. | 02:17 |
lintan__ | +1 for me | 02:17 |
*** Marga_ has joined #openstack-ironic | 02:17 | |
rloo | jlvillal: well, these things happen. reminds me as to why i don't like to jump on the bandwagon to use something that is newish. | 02:17 |
jlvillal | lintan__, You are the Ironic expert on versionedobjects. So if you can give us guidance that would be great. | 02:18 |
rloo | except that lintan__ may not know what 0.8 changes. | 02:18 |
* jlvillal knows almost nothing.... | 02:18 | |
*** baoli has quit IRC | 02:18 | |
jlvillal | lintan__, Link to bug: https://bugs.launchpad.net/ironic/+bug/1488270 | 02:19 |
openstack | Launchpad bug 1488270 in Ironic "oslo.versionedobjects 0.8.0 release causing py27/py34 unittests to fail in ironic" [Critical,In progress] - Assigned to Dan Smith (danms) | 02:19 |
rloo | anyway. i'm around off/on for another 40 min or so before i shut down, if you need +2. although ramesh and Haomeng seem to be around and devananda should be back... | 02:19 |
*** jcoufal has quit IRC | 02:20 | |
*** baoli has joined #openstack-ironic | 02:21 | |
*** zz_natorious is now known as natorious | 02:23 | |
*** lintan__ has quit IRC | 02:28 | |
*** lintan__ has joined #openstack-ironic | 02:35 | |
mrda | rloo, jlvillal, lintan__ I think the longer term point is for us to complete the migration to oslo.versionedobjects i.e. update how we use this library, using dims and dansmith as subject matter experts | 02:37 |
jlvillal | mrda, +1. I think lintan has been working on that. | 02:38 |
mrda | jlvillal: yeah, and I appreciate his work! | 02:38 |
jlvillal | But now I think we have more urgency | 02:38 |
mrda | I think this bump in version will just hasten the need for that migration to complete | 02:38 |
mrda | jlvillal: snap, yeah | 02:38 |
jlvillal | mrda, Have a good day. I'm going to try to stop watching IRC :) | 02:39 |
rameshg87 | jlvillal: mrda: I still wonder why we are not removing it off. what if I (or someone else) throw a patch to fix that removes it | 02:39 |
mrda | jlvillal: probably a good idea, have a nice night | 02:39 |
rameshg87 | jlvillal: mrda: would you guys prefer it over the revert patch ? | 02:39 |
mrda | rameshg87: what do you mean by "removing it off"? | 02:40 |
jlvillal | rameshg87, If it works, then it sounds like it might be a good idea. | 02:40 |
*** lazy_prince has quit IRC | 02:40 | |
jlvillal | mrda, I think it is the ListObject class. | 02:40 |
rameshg87 | jlvillal: mrda: removing ObjectListBase in ironic/objects/base.py | 02:40 |
jlvillal | We may not be using it. | 02:40 |
mrda | oh | 02:40 |
rameshg87 | mrda: the funny news is we have never used it in ironic | 02:40 |
mrda | Should we be using it though? | 02:40 |
rameshg87 | at least we don't use it now | 02:41 |
jlvillal | rameshg87, I don't know enough to vote either way. Today was the first time I have looked at the code. | 02:41 |
mrda | Is it "oslo.versionedobjects best practice"? | 02:41 |
rameshg87 | mrda: I don't know the use case, but afaik most of the code in oslo was taken from nova when ironic was created | 02:41 |
jlvillal | lintan, probably knows. I thought he was going to look into a patch to remove it. | 02:41 |
lintan | yes, I am working on that | 02:42 |
rameshg87 | mrda: may be it was ObjectListBase which was in it, was never used in ironic | 02:42 |
jlvillal | lintan, Great. rameshg87 ^^^ | 02:42 |
rameshg87 | lintan: great .. | 02:42 |
mrda | cool | 02:42 |
jlvillal | rameshg87, lintan mrda I will leave it in your capable hands :) | 02:42 |
rameshg87 | so what about the revert patch https://review.openstack.org/#/c/216472/1 ? | 02:43 |
jlvillal | rameshg87, Figure out which is the best way to proceed. I will leave that up to you. | 02:43 |
jlvillal | I really don't know what way is best. | 02:43 |
jlvillal | rameshg87, Hopefully devananda jumps on at some point. Since he didn't want any code merged until his patch merged. But now his patch is blocked by this issue... | 02:44 |
rameshg87 | jlvillal: okay :) | 02:44 |
rameshg87 | heh irony :) | 02:44 |
jlvillal | hehe | 02:44 |
mrda | irony in the ironic project, who would have thought? :) | 02:45 |
jlvillal | Good night all | 02:45 |
mrda | night jlvillal | 02:45 |
rameshg87 | good night jlvillal | 02:45 |
mrda | rameshg87: I'm thinking that 216472 should probably be taken | 02:46 |
mrda | rameshg87: I'm just reviewing it more thoroughly - I'm assuming Dan brought that code in from somewhere... | 02:47 |
rameshg87 | mrda: but that's just a revert of https://review.openstack.org/#/q/3b08da311447289d60fb900dc69dff0fd004ca17,n,z, right ? | 02:47 |
rloo | night jlvillal | 02:48 |
mrda | rameshg87: yes | 02:48 |
rameshg87 | rloo: I will catch up with you tomorrow on https://review.openstack.org/#/c/196006/ since it's already late for you | 02:48 |
mrda | ...which looks very much like base.py in oslo.versionedobjects at some revision | 02:49 |
rloo | rameshg87: yes, tomorrow | 02:49 |
rloo | for now, I think we should revert. | 02:49 |
mrda | rloo: cool | 02:49 |
mrda | rloo: thanks for staying up | 02:49 |
rloo | mrda. I +2'd it. Either rameshg87 can +2/approve, and/or you can wait to see when/what devananda thinks. | 02:50 |
*** achanda has quit IRC | 02:50 | |
rameshg87 | rloo: I am still terribly confused. | 02:51 |
mrda | rloo: thanks for that. | 02:51 |
rloo | rameshg87: with oslo.versionedojects 0.8, our unit test fails, which means our gate is broken. | 02:51 |
rameshg87 | rloo: yeah I understand the problem | 02:52 |
rloo | rameshg87: the fix for now is to revert our change that uses something from oslo.versionedobjects | 02:52 |
rameshg87 | rloo: but, we are spending so much on something that's not even used in ironic, than just removing it off. | 02:52 |
mrda | ...because we're half-way through upgrading to using oslo.versionedobjects how they're meant to be used | 02:52 |
rameshg87 | anyways not much point talking after this patch is ready to be merged | 02:52 |
rloo | rameshg87: so i don't know the details of the problem, and i don't know if the failure is *only* due to that class that we aren't using, or whether there is something else going on. | 02:52 |
*** hakimo_ has joined #openstack-ironic | 02:52 | |
mrda | ...and oslo released the new version without testing it against ironic (but they tried, the test failed for them) | 02:53 |
rloo | rameshg87: so it seems safest right now, just to revert. cuz we know that it works/worked w/o that change. | 02:53 |
rameshg87 | okay, let's do it then .. | 02:53 |
openstackgerrit | Tan Lin proposed openstack/ironic: Remove ObjectListBase https://review.openstack.org/213601 | 02:53 |
rloo | rameshg87: but again, can wait for devananda to make the call. assuming he returns but he said he would so i suspect he will. | 02:53 |
rameshg87 | lintan has a follow up patch anyway to remove it off - we can see if it still continues to work | 02:53 |
rameshg87 | lintan right on time ^^^ :) | 02:54 |
mrda | :) | 02:54 |
rloo | rameshg87: so devananda wants to do a release of ironic, so the less we change the better. | 02:54 |
rloo | rameshg87: devananda told us not to approve any changes until (i don't have the link handy) merges, but I think it can't merge due to the gate being broken. | 02:55 |
rameshg87 | rloo: anyways I will leave it to him to +2 and +A the patch | 02:55 |
*** hakimo has quit IRC | 02:55 | |
rloo | rameshg87: ok, that's fine. in the meantime, you and other cores know not to approve anything in ironic tree, right? | 02:56 |
rameshg87 | yeah I hear that now | 02:56 |
rameshg87 | ack | 02:56 |
rloo | ciao everyone | 02:57 |
mrda | thanks rloo | 02:57 |
*** rloo has quit IRC | 02:57 | |
*** rameshg87 is now known as rameshg87-away | 02:58 | |
*** achanda has joined #openstack-ironic | 03:01 | |
zhenguo | rameshg87, Haomeng: as we discussed yesterday about configuring the consumed memory size by agent, any suggestion on the default size? | 03:05 |
Haomeng | zhenguo: I think defautl 1G should be ok, and we can have the configuration option for user to change if it is not enough | 03:05 |
zhenguo | Haomeng: ok, got it. thanks | 03:06 |
Haomeng | zhenguo: the 1G input that is from our devstack script, it will create 1G ram vm as vm to provision os via ironic | 03:07 |
Haomeng | zhenguo: that is ipa driver | 03:07 |
Haomeng | zhenguo: but this is vm total ram size | 03:07 |
devananda | back | 03:08 |
Haomeng | zhenguo: the option we have is to reserve the ram for ipa os only, not including the image which download to ram disk | 03:08 |
zhenguo | Haomeng: yes, so 1G will not be ok for devsctack env? | 03:08 |
* devananda reads scrollback | 03:08 | |
devananda | mrda: lots of scrollback for me to read ... can you tldr? | 03:09 |
Haomeng | zhenguo: I mean 1G is our devstack default configuration for ipa vm | 03:09 |
Haomeng | zhenguo: and dont worry about the default configuration, 512M should be fine for ipa os I think | 03:10 |
*** rameshg87 has joined #openstack-ironic | 03:10 | |
Haomeng | zhenguo: so devstack 1G = 512M ram used by ipa os, and rest of them will be consumed by ram disk | 03:10 |
devananda | jlvillal, NobodyCam, rameshg87-away - anyone around to summarize current status? or shall we wait until the morning? | 03:11 |
zhenguo | Haomeng: ok, will update, | 03:11 |
Haomeng | zhenguo: ok, thanks | 03:11 |
*** rameshg87-away has quit IRC | 03:11 | |
lintan | hi devanada, as versionedobject library increase to 0.8, which break Ironic's versionedobject. So the solution is to using our own objectlist class like https://review.openstack.org/#/c/216472/ | 03:16 |
devananda | i found the whiteboard and the revert path | 03:16 |
devananda | patch | 03:16 |
devananda | dhellmann: ping -- gate is stuck and, well, we can't land the tag now | 03:17 |
lintan | devanada, but because Ironic didn't use objectlist at all, we can remove it in a follow patch | 03:17 |
devananda | lintan: the problem is - we've already tagged the release to the current HEAD | 03:18 |
devananda | so landing something else now and THEN the release ... i do not know what that will do | 03:18 |
lintan | it's tough.... | 03:18 |
devananda | lifeless: around? any ideas? | 03:20 |
devananda | I'm goiung to hold of funtil tomorrow, when I an get assistane from dhellmann or lifeless | 03:20 |
devananda | as I don't want to make their lives harder | 03:20 |
devananda | Haomeng, rameshg87 - please continue reviewing and +2'ing, but do not +A tonight | 03:21 |
devananda | thanks | 03:21 |
rameshg87 | devananda: sure. | 03:21 |
Haomeng | devananda: ok:) | 03:21 |
mrda | hey devananda, you're up to speed now? | 03:23 |
*** links has joined #openstack-ironic | 03:24 | |
*** asd112z has quit IRC | 03:31 | |
*** davideagnello has quit IRC | 03:33 | |
rameshg87 | Haomeng: mrda: lintan: have you guys ever tested a take over of a bare metal by another conductor ? | 03:45 |
*** shoutm_ has quit IRC | 03:48 | |
rameshg87 | Haomeng: mrda: lintan: any idea why it isn't supported for nodes at 'wait call-back' ? | 03:52 |
mrda | ooh, ok | 03:54 |
mrda | I haven't tested it, but that is totally something I *need* to test :) | 03:55 |
mrda | and if a node is at wait-callback, it would be wonderful if another conductor could take it over, but my guess is that it doesn't work | 03:55 |
rameshg87 | mrda: yeah take over in that sense is just caching the deploy kernel/ramdisk and creating the pxe config | 03:56 |
jlvillal | rameshg87, Have you tried 'git grep'? | 03:56 |
rameshg87 | mrda: I don't see a reason why it isn't possible | 03:56 |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Check image size before provisioning for agent driver https://review.openstack.org/215254 | 03:56 |
rameshg87 | jlvillal: for what ? | 03:56 |
mrda | jlvillal: you need to stop working now :) | 03:57 |
jlvillal | Instead of 'grep -R blah ironic/*' :) | 03:57 |
jlvillal | rameshg87, ^^ I was looking at your comment: https://review.openstack.org/#/c/213601/3/ironic/objects/fields.py | 03:57 |
mrda | jlvillal: I use 'ack-grep'. It's grep on steriods and *so* much better | 03:57 |
jlvillal | mrda, I will. I was just checking in and seeing what was going on. | 03:58 |
mrda | rameshg87: I'm not sure at a code level why it's not possible | 03:58 |
jlvillal | mrda, I have never heard of 'ack-grep' | 03:58 |
mrda | jlvillal: http://beyondgrep.com/ | 03:58 |
jlvillal | mrda, Thanks | 03:58 |
rameshg87 | jlvillal: what difference does it make | 03:59 |
rameshg87 | ? | 03:59 |
rameshg87 | even git grep returns me nothing actually | 03:59 |
mrda | rameshg87: If it doesn't work for you, can I suggest raising a bug? I think as a project we want this to work... | 03:59 |
jlvillal | rameshg87, I like it because it won't try to search .git/ directories. It is pretty fast too. | 03:59 |
*** shoutm has joined #openstack-ironic | 03:59 | |
rameshg87 | mrda: yeah, I was plannign to raise a bug, but thought of first checking with a few folks who know any reason why today it isn't | 04:00 |
mrda | jlvillal: ack-grep doesn't search git dirs, temp files, binary files etc It's awesome! You should totally try it! | 04:00 |
rameshg87 | jlvillal: oh okay | 04:00 |
jlvillal | mrda, I might :) 'git grep' has been working well for me. But ack-grep does sound like it would be useful in non-git tree situations for me. | 04:01 |
rameshg87 | jlvillal: honestly I didn't know anything could beat gnu grep :) | 04:01 |
mrda | rameshg87: Thanks rameshg87, I'm not promising to solve it, but I'm happy to try and confirm it with a little (NUC-based) test network here at home. I think it's something my overlords would want to work. | 04:01 |
rameshg87 | mrda: sure. will file a bug then. | 04:02 |
jlvillal | rameshg87, Maybe give it a try some time :) | 04:02 |
rameshg87 | mrda: the only issue that I see is | 04:02 |
rameshg87 | mrda: take_over takes a little time to detect unless we shut it down in a gentle way | 04:02 |
rameshg87 | mrda: by that time the bare metal could have attempted to boot from pxe and would have failed | 04:03 |
rameshg87 | mrda: today the heart beat timeout is 60 seconds | 04:03 |
rameshg87 | mrda: so any bare metal taking less than 60 seconds to complete POST might not benefit | 04:03 |
mrda | right | 04:04 |
mrda | I didn't say it's necessarily easy, but it's an edge case that would be nice to have covered properly | 04:04 |
rameshg87 | mrda: yeah would be nice to have anyway | 04:04 |
rameshg87 | mrda: is it a feature or bug ? :) | 04:05 |
mrda | rameshg87: I'd say bug :) | 04:09 |
*** ramineni has joined #openstack-ironic | 04:12 | |
*** VikasC has joined #openstack-ironic | 04:14 | |
*** ramineni1 has joined #openstack-ironic | 04:16 | |
*** ramineni2 has joined #openstack-ironic | 04:17 | |
*** puranamr has joined #openstack-ironic | 04:17 | |
*** ramineni has quit IRC | 04:17 | |
*** VikasC has quit IRC | 04:18 | |
*** ramineni1 has quit IRC | 04:20 | |
*** ramineni2 has quit IRC | 04:22 | |
*** ramineni has joined #openstack-ironic | 04:25 | |
*** saripurigopi has joined #openstack-ironic | 04:27 | |
*** puranamr has quit IRC | 04:29 | |
*** ramineni has quit IRC | 04:29 | |
*** baoli has quit IRC | 04:35 | |
*** bnemec has quit IRC | 04:42 | |
*** Sukhdev has joined #openstack-ironic | 04:42 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor agent driver with pxe boot interface https://review.openstack.org/166521 | 04:46 |
*** natorious is now known as zz_natorious | 04:47 | |
*** rameshg871 has joined #openstack-ironic | 04:50 | |
*** rameshg87 has quit IRC | 04:52 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: iLO driver documentation for UEFI secure boot https://review.openstack.org/216528 | 05:10 |
*** VikasC has joined #openstack-ironic | 05:15 | |
*** lintan__ has quit IRC | 05:17 | |
*** VikasC has quit IRC | 05:20 | |
*** yog_ has joined #openstack-ironic | 05:20 | |
saripurigopi | Morning Ironic | 05:23 |
*** yog_ has quit IRC | 05:31 | |
*** asd112z has joined #openstack-ironic | 05:32 | |
openstackgerrit | Tan Lin proposed openstack/ironic: Remove ObjectListBase https://review.openstack.org/213601 | 05:33 |
*** praneshp has joined #openstack-ironic | 05:34 | |
*** davideagnello has joined #openstack-ironic | 05:36 | |
*** praneshp_ has joined #openstack-ironic | 05:41 | |
*** balajin_ has quit IRC | 05:41 | |
Haomeng | saripurigopi: morning:) | 05:43 |
*** praneshp has quit IRC | 05:43 | |
*** praneshp_ is now known as praneshp | 05:43 | |
saripurigopi | Haomeng: o/ | 05:43 |
*** balajin has joined #openstack-ironic | 05:45 | |
*** asd112z has quit IRC | 05:51 | |
*** yog_ has joined #openstack-ironic | 05:52 | |
*** zhenguo has quit IRC | 05:53 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Refactor iscsi_ilo driver to use new boot interface https://review.openstack.org/216538 | 05:56 |
*** links has quit IRC | 05:57 | |
*** links has joined #openstack-ironic | 06:00 | |
*** baoli has joined #openstack-ironic | 06:05 | |
*** zhenguo has joined #openstack-ironic | 06:09 | |
*** irenab has quit IRC | 06:11 | |
*** BadCub has quit IRC | 06:12 | |
*** boris-42 has quit IRC | 06:12 | |
*** lekha has quit IRC | 06:13 | |
*** BadCub has joined #openstack-ironic | 06:14 | |
lifeless | devananda: hi, sup ? | 06:14 |
lifeless | devananda: oh - land the fix | 06:15 |
*** lekha has joined #openstack-ironic | 06:16 | |
*** boris-42 has joined #openstack-ironic | 06:17 | |
*** baoli has quit IRC | 06:20 | |
*** ukalifon1 has joined #openstack-ironic | 06:20 | |
*** yuanying has quit IRC | 06:25 | |
*** yog_ has quit IRC | 06:31 | |
*** Sukhdev has quit IRC | 06:34 | |
*** irenab has joined #openstack-ironic | 06:38 | |
*** lintan has quit IRC | 06:39 | |
*** yuanying has joined #openstack-ironic | 06:44 | |
*** rameshg871 has quit IRC | 06:45 | |
*** shoutm has quit IRC | 06:49 | |
*** lintan has joined #openstack-ironic | 06:49 | |
*** yuikotakada has joined #openstack-ironic | 06:49 | |
*** Nisha has joined #openstack-ironic | 06:51 | |
*** shoutm has joined #openstack-ironic | 06:51 | |
*** dtantsur|afk is now known as dtantsur | 06:54 | |
dtantsur | Morning Ironic | 06:54 |
*** davideagnello has quit IRC | 06:57 | |
*** PradeepV has joined #openstack-ironic | 07:00 | |
PradeepV | Hi Ironic | 07:02 |
saripurigopi | dtantsur: o/ | 07:03 |
Haomeng | PradeepV: hi, sorry for late response, I am in away status for my night time:) | 07:03 |
Haomeng | dtantsur: o/ | 07:03 |
yuikotakada | Hi, Ironic :) | 07:03 |
Haomeng | PradeepV: so what is your last question, can you repeat | 07:03 |
dtantsur | yuikotakada, o/ | 07:04 |
dtantsur | Haomeng, saripurigopi o/ | 07:04 |
Haomeng | yuikotakada: o/ | 07:04 |
Haomeng | dtantsur: :) | 07:04 |
yuikotakada | dtantsur, Haomeng, o/ | 07:04 |
*** ifarkas has joined #openstack-ironic | 07:05 | |
PradeepV | Thank you Haomeng, at last i was able to bring up the flat network setup for deploying the ironic using agent driver, can we use the same whole disk image for agent driver also? | 07:07 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/216562 | 07:07 |
Haomeng | PradeepV: yes, sure | 07:07 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements https://review.openstack.org/213048 | 07:07 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/216563 | 07:07 |
Haomeng | PradeepV: cool | 07:07 |
PradeepV | ok Haomeng,is there any configuration changes for deploying the agent driver or is it similar to pxe driver? | 07:08 |
Haomeng | PradeepV: almostly same operations, and you can check the guide out to see the differences | 07:09 |
Haomeng | PradeepV: http://docs.openstack.org/developer/ironic/deploy/install-guide.html | 07:09 |
*** achanda has quit IRC | 07:10 | |
Haomeng | PradeepV: there are some special for agent drivers, such as MD5 checksum of instance image is required | 07:11 |
PradeepV | can you send me the link for the guide | 07:12 |
*** achanda has joined #openstack-ironic | 07:14 | |
*** praneshp has quit IRC | 07:20 | |
*** achanda has quit IRC | 07:30 | |
*** yog_ has joined #openstack-ironic | 07:30 | |
openstackgerrit | Merged openstack/ironic-lib: Updated from global requirements https://review.openstack.org/213048 | 07:31 |
*** ndipanov has quit IRC | 07:38 | |
*** lazy_prince has joined #openstack-ironic | 07:39 | |
Haomeng | PradeepV: this one - http://docs.openstack.org/developer/ironic/deploy/install-guide.html | 07:48 |
*** baoli has joined #openstack-ironic | 07:58 | |
*** ionutbalutoiu has joined #openstack-ironic | 08:00 | |
*** yuikotakada has quit IRC | 08:02 | |
*** baoli has quit IRC | 08:02 | |
*** shoutm has quit IRC | 08:03 | |
*** asd112z has joined #openstack-ironic | 08:03 | |
*** Nisha_away has joined #openstack-ironic | 08:04 | |
*** Nisha has quit IRC | 08:05 | |
*** shoutm has joined #openstack-ironic | 08:05 | |
*** asd112z has quit IRC | 08:08 | |
*** ionutbalutoiu has quit IRC | 08:08 | |
betherly | morning all :) | 08:11 |
*** jistr has joined #openstack-ironic | 08:12 | |
*** rameshg87 has joined #openstack-ironic | 08:15 | |
*** e0ne has joined #openstack-ironic | 08:17 | |
*** derekh has joined #openstack-ironic | 08:24 | |
*** romainh has joined #openstack-ironic | 08:24 | |
*** karimb has joined #openstack-ironic | 08:25 | |
Haomeng | betherly: morning:) | 08:26 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: [WIP] Add introspection rules support https://review.openstack.org/208375 | 08:26 |
dtantsur | betherly, morning | 08:26 |
*** lucasagomes has joined #openstack-ironic | 08:31 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add deprecation warning to periodic tasks with parallel=False https://review.openstack.org/216604 | 08:31 |
betherly | :) | 08:32 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add deprecation warning to periodic tasks with parallel=False https://review.openstack.org/216604 | 08:34 |
dtantsur | devananda, hi, I see you don't sleep :) Is it possible we get ^^ in Liberty? | 08:34 |
*** Nisha_away has quit IRC | 08:34 | |
devananda | hi! | 08:34 |
devananda | maybe? | 08:34 |
dtantsur | hmm, I should have updated docs as well in this patch.. | 08:35 |
devananda | i'm trying to get 4.0.0 out now(), but I hope this is not the final cut for liberty. we have several things in flight right now, half done, which we should all finish soon | 08:35 |
devananda | and then roll into liberty, regardless of whether that is 4.1 or 5.0 or what ever | 08:35 |
lifeless | devananda: I replied btw - I think you should just land the unbreak patch | 08:37 |
devananda | lifeless: ack. I have pushed that button now | 08:37 |
dtantsur | cool | 08:37 |
devananda | lifeless: how does that work for the release mechanisms? | 08:38 |
devananda | do we go update openstack/releases with the new SHA ? | 08:38 |
lifeless | devananda: I wouldn't both | 08:38 |
*** Nisha_away has joined #openstack-ironic | 08:38 | |
lifeless | devananda: the only reason your tree state matters at all is landing the patch to remove version= | 08:38 |
*** pelix has joined #openstack-ironic | 08:39 | |
devananda | lifeless: IIUC, someone installing a package of the SHA listed in openstack/releases, and pulling down 0.8.0 of oslo versioned objects, is going to find that it doesn't work | 08:39 |
lifeless | yes, but if your release had happened, they'd still find that | 08:40 |
devananda | sure | 08:40 |
devananda | and we'd do a 4.0.1 right away | 08:40 |
lifeless | devananda: so, since its not planned to be your final release | 08:40 |
lifeless | I wouldn't sweat it | 08:40 |
*** romcheg has joined #openstack-ironic | 08:41 | |
lifeless | devananda: also the fix is AIUI test only, so most users wouldn't notice | 08:41 |
lifeless | devananda: how many people run your tests from releases? | 08:41 |
devananda | fair point | 08:41 |
*** pelix has quit IRC | 08:43 | |
devananda | ok - I'm going to go back to sleep now, and check on the gate again when I wake up :) | 08:43 |
rameshg87 | devananda: I can watch and give some rechecks if required. gn ;-) | 08:45 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add deprecation warning to periodic tasks with parallel=False https://review.openstack.org/216604 | 08:46 |
*** dtantsur is now known as dtantsur|brb | 08:47 | |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add vendor interface to ipminative driver https://review.openstack.org/215185 | 08:55 |
openstackgerrit | Dingyx proposed openstack/ironic-specs: lenovo driver proposal https://review.openstack.org/208319 | 08:56 |
*** max_lobur has joined #openstack-ironic | 09:00 | |
*** max_lobur has quit IRC | 09:00 | |
*** romcheg has quit IRC | 09:01 | |
*** max_lobur has joined #openstack-ironic | 09:02 | |
lucasagomes | alright so our gate is broken :-( ? | 09:06 |
lucasagomes | damn oslo objects | 09:06 |
rameshg87 | lucasagomes: it will be fixed soon, the fixing patch is already in merge queue | 09:14 |
lucasagomes | rameshg87, thanks, yeah it's in gate | 09:14 |
lucasagomes | tho gate's a bit slow | 09:14 |
*** romcheg has joined #openstack-ironic | 09:14 | |
lucasagomes | rameshg87, btw re elilo UEFI | 09:14 |
rameshg87 | yes | 09:15 |
lucasagomes | rameshg87, the guy built the deploy ramdisk w/o dracut and it booted | 09:15 |
lucasagomes | but it fails when talking to Ironic | 09:15 |
lucasagomes | when building the json | 09:15 |
lucasagomes | <myllynen> Requesting Ironic API to deploy image | 09:15 |
lucasagomes | <myllynen> Requesting Ironic API to comlete the deploy | 09:15 |
lucasagomes | <myllynen> 500 Internal Server Error | 09:15 |
lucasagomes | <myllynen> sigh | 09:15 |
lucasagomes | <myllynen> error_message ... Invalid control character '\\\\\n' at line 1 column 163 (char 162) | 09:15 |
rameshg87 | eh, that's strange | 09:16 |
lucasagomes | seems to be something around https://github.com/openstack/diskimage-builder/blob/master/elements/deploy-ironic/init.d/80-deploy-ironic#L154-L155 | 09:16 |
lucasagomes | rameshg87, yeah | 09:16 |
lucasagomes | was wondering if the elilo will replace that "ip=" kernel cmd line template we have https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/elilo_efi_pxe_config.template#L6 | 09:17 |
lucasagomes | ip=%I:{{pxe_options.tftp_server}}:%G:%M:%H::on" | 09:17 |
lucasagomes | anyway... rameshg87 you haven't seem that right? | 09:17 |
rameshg87 | lucasagomes: no | 09:18 |
lucasagomes | it's cool, I will help him to debug it | 09:18 |
rameshg87 | lucasagomes: we run internal jenkins nightly for pxe_ilo which uses elilo, so it's not broken | 09:18 |
lucasagomes | rameshg87, right | 09:18 |
lucasagomes | yeah it's odd | 09:18 |
*** MattMan has joined #openstack-ironic | 09:19 | |
rameshg87 | lucasagomes: let me check if I can machine console of pxe_ilo uefi job | 09:19 |
lucasagomes | rameshg87, ack thanks | 09:19 |
*** marzif has joined #openstack-ironic | 09:21 | |
*** marzif has quit IRC | 09:31 | |
*** marzif has joined #openstack-ironic | 09:31 | |
*** ramineni has joined #openstack-ironic | 09:38 | |
rameshg87 | lucasagomes: https://drive.google.com/file/d/0B5a_VAhX3Hz5RTM3LVp4WGo0NXM/view | 09:40 |
rameshg87 | lucasagomes: not sure if it will help, but you can refer those portions of elilo boot to compare and see if you see something strange | 09:41 |
lucasagomes | rameshg87, ah thanks much! | 09:41 |
*** shoutm has quit IRC | 09:41 | |
lucasagomes | rameshg87, this is PXE booting ? Or virtual media? | 09:41 |
rameshg87 | lucasagomes: pxe booting with elilo | 09:41 |
lucasagomes | oh I see the PXE part | 09:41 |
lucasagomes | thanks | 09:41 |
rameshg87 | lucasagomes: elilo version also mattered | 09:42 |
rameshg87 | lucasagomes: faizan who worked on this had faced issues with versions < 3.16 iirc | 09:42 |
lucasagomes | rameshg87, anything > 3.16 should do it? | 09:43 |
rameshg87 | yes | 09:43 |
lucasagomes | gotcha rameshg87 thanks very much! | 09:43 |
*** max_lobur has quit IRC | 09:49 | |
*** ndipanov has joined #openstack-ironic | 09:51 | |
*** naohirot has quit IRC | 09:55 | |
*** romainh has quit IRC | 10:00 | |
Nisha_away | lucasagomes, rameshg87 please review https://review.openstack.org/198656 https://review.openstack.org/201904 | 10:01 |
*** yog_ has quit IRC | 10:06 | |
*** romcheg has quit IRC | 10:06 | |
*** irenab has quit IRC | 10:18 | |
*** pelix has joined #openstack-ironic | 10:28 | |
*** romcheg has joined #openstack-ironic | 10:32 | |
rameshg87 | lucasagomes: hi | 10:39 |
rameshg87 | lucasagomes: any thoughts on this bug that I had raised today morning ? - https://bugs.launchpad.net/ironic/+bug/1488314 | 10:39 |
openstack | Launchpad bug 1488314 in Ironic "ironic doesn't support take_over for nodes in wait-call-back" [Undecided,New] | 10:39 |
lucasagomes | rameshg87, hi there! Lemme check | 10:41 |
*** Nisha_away has quit IRC | 10:43 | |
*** dtantsur|brb is now known as dtantsur | 10:43 | |
lucasagomes | rameshg87, yeah it seems right, if the node gets remapped in the ring and a new conductor gets the request to continue deploy | 10:44 |
lucasagomes | it should have things cached from prepare() | 10:44 |
openstackgerrit | Satoru Moriya proposed openstack/ironic-specs: Volume connection information for Ironic nodes https://review.openstack.org/200496 | 10:44 |
rameshg87 | lucasagomes: yeah, I don't see a reason why it isn't possible | 10:44 |
lucasagomes | rameshg87, perhaps it's something that continue_deploy should do? In case the images, pxe config etc is not present it should call prepare() for that node? | 10:45 |
lucasagomes | rameshg87, yeah, seems totally possible | 10:45 |
rameshg87 | may be if time for bare metal POST < the heart beat timeout | 10:45 |
rameshg87 | the bare metal might attempt booting and fail | 10:45 |
rameshg87 | but we can always give a chance | 10:45 |
lucasagomes | yeah | 10:45 |
rameshg87 | lucasagomes: yeah, okay | 10:45 |
rameshg87 | lucasagomes: another one | 10:46 |
rameshg87 | there is a window of gap between when the node gets remapped to different conductor (due to heartbeat timeout) and the periodic task sync local state is run | 10:46 |
rameshg87 | lucasagomes: any operation triggered within this timeframe (like reboot of instance) might fail because pxe configs are not generated | 10:47 |
rameshg87 | lucasagomes: is there anything I am missing ? I haven't tried out this scenario, but it seems possible it can happen. | 10:48 |
lucasagomes | rameshg87, yeah no I think it can totally happen indeed | 10:48 |
lucasagomes | I think few people see it because they usually use local boot | 10:48 |
lucasagomes | or full disk image | 10:48 |
rameshg87 | lucasagomes: okay | 10:48 |
rameshg87 | lucasagomes: okay, will test and see if I can reproduce that issue locally | 10:49 |
lucasagomes | they only way to fix that I would say is somehow have all the conductors which has that driver enbaled to be to control all the nodes deployed with that driver | 10:49 |
rameshg87 | lucasagomes: but even then the neutron dhcp parameters would still point to the dead conductor | 10:50 |
rameshg87 | lucasagomes: and tftp fetch of kernel will fail unless take_over is completed | 10:50 |
rameshg87 | if it's a netboot though | 10:50 |
lucasagomes | oh true | 10:51 |
rameshg87 | lucasagomes: another way is we can have someway to indicate that take_over hasn't happened and can trigger a take_over first when power on or reboot is triggered | 10:52 |
lucasagomes | rameshg87, yeah, the problem is that we calculate the hash when the request comes | 10:52 |
rameshg87 | lucasagomes: yes | 10:52 |
lucasagomes | or in that periodic task | 10:52 |
lucasagomes | we could try to trigger something when we detect that a conductor is dead | 10:53 |
rameshg87 | yeah may be | 10:53 |
rameshg87 | lucasagomes: anyways looks like an interesting thing to solve | 10:53 |
rameshg87 | :) | 10:53 |
lucasagomes | ++ | 10:53 |
* rameshg87 begins setting up another conductor | 10:54 | |
*** yog_ has joined #openstack-ironic | 10:54 | |
*** romcheg has quit IRC | 10:57 | |
*** smoriya has quit IRC | 11:00 | |
openstackgerrit | Merged openstack/ironic: Remove ObjectListBase https://review.openstack.org/213601 | 11:02 |
*** asd112z has joined #openstack-ironic | 11:03 | |
*** asd112z has quit IRC | 11:08 | |
*** Marga_ has quit IRC | 11:10 | |
*** adam_g has quit IRC | 11:12 | |
*** dprince has joined #openstack-ironic | 11:19 | |
rameshg87 | devananda: ^^^^ it's merged | 11:20 |
*** lucasagomes has quit IRC | 11:21 | |
*** lucasagomes has joined #openstack-ironic | 11:22 | |
*** romcheg has joined #openstack-ironic | 11:24 | |
sambetts | UGT Morning everyone o/ | 11:25 |
lucasagomes | sambetts, morning | 11:28 |
dtantsur | sambetts, morning again :) | 11:29 |
sambetts | :D | 11:29 |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor agent driver with pxe boot interface https://review.openstack.org/166521 | 11:30 |
* rameshg87 leaves for the day | 11:31 | |
*** rameshg87 has quit IRC | 11:31 | |
TheJulia | good morning everyone | 11:33 |
*** saripurigopi has quit IRC | 11:34 | |
dtantsur | TheJulia, morning | 11:34 |
sambetts | dtantsur: https://review.openstack.org/#/c/216670/ | 11:35 |
dtantsur | sambetts, cool! do you have a link generated for it? | 11:35 |
sambetts | dtantsur: I've not created a short url for it yet, I'm about to do it | 11:36 |
sambetts | dtantsur: whats the best services for that do you think? | 11:36 |
dtantsur | sambetts, no idea, I used perm.ly ones | 11:37 |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add vendor interface to ipminative driver https://review.openstack.org/215185 | 11:37 |
sambetts | dtantsur: cool, I'll look into it, and post it on the whiteboard once its done | 11:37 |
dtantsur | thanks! | 11:38 |
*** ramineni has quit IRC | 11:38 | |
*** Haomeng|2 has joined #openstack-ironic | 11:39 | |
*** irenab has joined #openstack-ironic | 11:40 | |
*** Marga_ has joined #openstack-ironic | 11:40 | |
*** Haomeng has quit IRC | 11:42 | |
*** lucasagomes is now known as lucas-hungry | 11:45 | |
lucas-hungry | TheJulia, morning | 11:45 |
*** zhenguo has quit IRC | 11:55 | |
openstackgerrit | Lucio Seki proposed stackforge/pyghmi: Add RAID drive and controller to ThinkServer inventory https://review.openstack.org/216398 | 11:57 |
*** shoutm has joined #openstack-ironic | 12:02 | |
*** trown|outttypeww is now known as trown | 12:03 | |
trown | good morning Ironic, and congrats Sam | 12:04 |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Resync with openstack/requirements https://review.openstack.org/216681 | 12:14 |
openstackgerrit | Lucio Seki proposed stackforge/pyghmi: Add RAID drive and controller to ThinkServer inventory https://review.openstack.org/216398 | 12:15 |
*** romcheg has quit IRC | 12:20 | |
*** romainh has joined #openstack-ironic | 12:20 | |
*** dlpartain has joined #openstack-ironic | 12:21 | |
*** dlpartain has left #openstack-ironic | 12:21 | |
*** romcheg has joined #openstack-ironic | 12:24 | |
sambetts | trown: Thanks :) | 12:40 |
*** baoli has joined #openstack-ironic | 12:44 | |
*** [1]cdearborn has joined #openstack-ironic | 12:44 | |
openstackgerrit | Lucio Seki proposed stackforge/pyghmi: Add RAID drive and controller to ThinkServer inventory https://review.openstack.org/216398 | 12:44 |
*** lucas-hungry is now known as lucasagomes | 12:46 | |
*** sinval has quit IRC | 12:47 | |
*** nicodemos has joined #openstack-ironic | 12:48 | |
*** baoli has quit IRC | 12:48 | |
*** jjohnson2 has joined #openstack-ironic | 12:50 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/216562 | 12:51 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: [WIP] Add introspection rules support https://review.openstack.org/208375 | 12:58 |
*** nicodemos has quit IRC | 13:00 | |
openstackgerrit | Merged stackforge/pyghmi: Add RAID drive and controller to ThinkServer inventory https://review.openstack.org/216398 | 13:01 |
*** nicodemos has joined #openstack-ironic | 13:03 | |
*** baoli has joined #openstack-ironic | 13:07 | |
*** rloo has joined #openstack-ironic | 13:08 | |
openstackgerrit | Merged openstack/ironic: Switch to post-versioning https://review.openstack.org/216388 | 13:09 |
rloo | hi everyone. and yay, ^^, does this mean we can approve? | 13:11 |
dtantsur | rloo, I hope so.. and g'morning :) | 13:11 |
rloo | dtantsur: you go first :D | 13:12 |
*** baoli_ has joined #openstack-ironic | 13:14 | |
*** zhenguo has joined #openstack-ironic | 13:16 | |
*** baoli has quit IRC | 13:17 | |
openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Introduce tempest-lib to functional tests https://review.openstack.org/216701 | 13:18 |
*** davidlenwell has quit IRC | 13:19 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/216562 | 13:20 |
*** davidlenwell has joined #openstack-ironic | 13:20 | |
*** links has quit IRC | 13:23 | |
*** mtanino has joined #openstack-ironic | 13:23 | |
*** davideagnello has joined #openstack-ironic | 13:28 | |
*** davideagnello has quit IRC | 13:28 | |
*** thiagop has joined #openstack-ironic | 13:29 | |
thiagop | good morning Ironicers | 13:29 |
*** absubram has joined #openstack-ironic | 13:32 | |
*** absubram has quit IRC | 13:35 | |
BadCub | morning Ironic | 13:36 |
thiagop | morning BadCub | 13:39 |
*** sinval has joined #openstack-ironic | 13:40 | |
*** bapalm has quit IRC | 13:44 | |
*** karimb has quit IRC | 13:46 | |
dtantsur | BadCub, thiagop, morning | 13:46 |
BadCub | morning thiagop and dtantsur | 13:47 |
*** bapalm_ is now known as bapalm | 13:51 | |
rloo | Anyone know if ramesh is around? I don't see him. | 13:52 |
*** karimb has joined #openstack-ironic | 13:52 | |
rloo | morning BadCub, thiagop. | 13:52 |
thiagop | rloo: o/ | 13:53 |
thiagop | dtantsur BadCub o/ | 13:53 |
dtantsur | rloo, I think he's sleeping :) | 13:54 |
BadCub | morning rloo | 13:54 |
rloo | dtantsur: already? :D. Guess I missed him again. Oh well. | 13:54 |
openstackgerrit | John Trowbridge proposed openstack/ironic-inspector: Store and expose introspection data https://review.openstack.org/213159 | 13:54 |
dtantsur | rloo, I think they have around 8-9pm now | 13:54 |
rloo | dtantsur: I should have 'talked' to him last night but i was tired then. We'll connect at some point... | 13:55 |
thiagop | jlvillal: Hiya | 13:55 |
thiagop | jlvillal: are you there? | 13:55 |
rloo | dtantsur: it is actually regarding the RAID patch https://review.openstack.org/#/c/196006/20 | 13:56 |
rloo | dtantsur: where he calls raid.validate() to check if the submitted config is OK | 13:57 |
rloo | dtantsur: don't know if you have any opinion on that. I disagree with calling .validate() cuz it could be doing more than checking the config. | 13:57 |
dtantsur | rloo, what else do you think validate() could be doing? | 13:58 |
rloo | dtantsur: dunno. but it is driver specific. what if there was something in driver_info that it wanted? | 13:58 |
NobodyCam | good morning ironicers :) | 13:58 |
rloo | dtantsur: if validate ONLY validated the config, i'd be fine with it, but it isn't documented as saying that it only does that. | 13:59 |
trown | o/ NobodyCam | 13:59 |
thiagop | good morning NobodyCam | 14:00 |
trown | dtantsur: for the devstack/excercise.sh do you think it is even worth using those env variables, or should I just hardcode the URI in the CURL function? | 14:00 |
rloo | morning NobodyCam | 14:00 |
NobodyCam | good morning trown thiagop rloo lucasagomes dtantsur sambetts jlvillal TheJulia jroll | 14:00 |
dtantsur | trown, I would starting with just hardcoding it, until we get inspector registered in keystone (which is a nice TODO btw) | 14:00 |
dtantsur | NobodyCam, morning! | 14:01 |
lucasagomes | NobodyCam, thiagop BadCub rloo trown good ugt morning | 14:01 |
NobodyCam | :) | 14:01 |
thiagop | hiya lucasagomes | 14:01 |
trown | o/ lucasagomes | 14:02 |
BadCub | morning lucasagomes | 14:03 |
*** ukalifon1 has quit IRC | 14:03 | |
*** endorphin has joined #openstack-ironic | 14:07 | |
rloo | hi lucasagomes | 14:08 |
NobodyCam | :) | 14:08 |
jlvillal | thiagop, Hello. I hope the review was okay :) | 14:10 |
jlvillal | Good morning thiagop BadCub rloo dtantsur trown lucasagomes and everyone else I may have missed :) | 14:11 |
dtantsur | jlvillal, morning! | 14:11 |
* jlvillal only reads the backlog so far... | 14:11 | |
BadCub | Morning jlvillal | 14:11 |
rloo | morning jlvillal | 14:11 |
jlvillal | I'm glad to see the gate is unbroken. Thanks for fixing it! | 14:11 |
thiagop | jlvillal: much very ok! thank you very much. We're studying the possibility to remove that exception class to python-oneviewclient, but I was wondering about the messages anyway | 14:11 |
thiagop | jlvillal: do you think "Server Hardware went to Error State when trying to change power state" fits better on OneViewErrorStateSettingPowerState? | 14:13 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Pass -w flag to iptables to make it wait for xtables lock https://review.openstack.org/216726 | 14:13 |
jlvillal | thiagop, Just let me know if you have questions. And remember my review can be wrong too! :) | 14:13 |
jlvillal | thiagop, looking... | 14:13 |
*** mtanino has quit IRC | 14:14 | |
jlvillal | thiagop, Yes, that makes much more sense to me than what is currently at https://review.openstack.org/#/c/191822/18/ironic/drivers/modules/oneview/exceptions.py | 14:15 |
thiagop | jlvillal: ty ;) | 14:16 |
*** dlpartain has joined #openstack-ironic | 14:20 | |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal power state commands https://review.openstack.org/172517 | 14:20 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Introduce openstackclient plugin https://review.openstack.org/171672 | 14:20 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal port create https://review.openstack.org/172461 | 14:20 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add provision state command https://review.openstack.org/206119 | 14:20 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add maintenance mode command https://review.openstack.org/216727 | 14:20 |
thrash | dtantsur: fixed a coupld of typos, and broke out provision state and maintenance mode to their own commands | 14:21 |
dtantsur | cool! | 14:21 |
thrash | lol... type in the sentence 'fixed a couple of typos' | 14:21 |
thrash | and ANOTHER typo | 14:22 |
thrash | recursive typos! | 14:22 |
trown | intypoception | 14:22 |
dtantsur | I can't write typo correctly 4 times of 5 | 14:24 |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Generic power I/F for soft power off and cancel task https://review.openstack.org/216730 | 14:25 |
*** dlpartain has left #openstack-ironic | 14:28 | |
*** tsekiyama has joined #openstack-ironic | 14:32 | |
*** asd112z has joined #openstack-ironic | 14:32 | |
*** asd112z has quit IRC | 14:33 | |
*** asd112z has joined #openstack-ironic | 14:33 | |
*** asd112z has quit IRC | 14:34 | |
*** asd112z has joined #openstack-ironic | 14:34 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Enhance ipmitool driver for soft power off and cancel task https://review.openstack.org/216738 | 14:34 |
*** PradeepV has quit IRC | 14:38 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add credentials migration script https://review.openstack.org/193218 | 14:38 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add pluggable credentials storage https://review.openstack.org/185074 | 14:38 |
*** mgoddard has quit IRC | 14:40 | |
*** afaranha has joined #openstack-ironic | 14:41 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Enhance iRMC driver for soft power off and cancel task https://review.openstack.org/216743 | 14:41 |
*** links has joined #openstack-ironic | 14:43 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic-specs: Add Zapping support to iLO drivers https://review.openstack.org/145404 | 14:46 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Add cleanup in console utils tests https://review.openstack.org/216745 | 14:49 |
*** shoutm has quit IRC | 14:52 | |
*** zz_natorious is now known as natorious | 14:53 | |
*** amotoki has joined #openstack-ironic | 14:54 | |
*** achanda has joined #openstack-ironic | 14:54 | |
*** natorious is now known as zz_natorious | 14:54 | |
*** zz_natorious is now known as natorious | 14:56 | |
*** mtanino has joined #openstack-ironic | 15:02 | |
*** nicodemos has quit IRC | 15:03 | |
*** mgoddard has joined #openstack-ironic | 15:03 | |
*** achanda has quit IRC | 15:04 | |
*** ionutbalutoiu has joined #openstack-ironic | 15:07 | |
devananda | morning, all | 15:11 |
NobodyCam | good morning devananda :) | 15:11 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Fix ensures pass_deploy_info() always calls boot.prepare_instance() https://review.openstack.org/216756 | 15:12 |
*** [1]cdearborn has quit IRC | 15:12 | |
*** linggao has joined #openstack-ironic | 15:13 | |
zhenguo | devananda: morning | 15:14 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Add cleanup in console utils tests https://review.openstack.org/216745 | 15:16 |
openstackgerrit | Doug Hellmann proposed openstack/ironic: format links in the readme to work with the release notes tools https://review.openstack.org/216758 | 15:17 |
rloo | morning devananda. I hope we're OK to approve patches now | 15:25 |
devananda | gmorning, rloo. there are a few things I am trying to clean up so we can do a 4.0.1 right away, after that, yes | 15:26 |
rloo | devananda: ok. (/me hopes I didn't approve anything in ironic already.) | 15:27 |
zhenguo | devananda: can you have a look at the updated nodes-tagging spec https://review.openstack.org/#/c/192935/ please after you finish the release work, it's stuck for a long time so I take it over and update. | 15:28 |
*** davideagnello has joined #openstack-ironic | 15:29 | |
devananda | zhenguo: thanks! however, I probably won't have time -- there's a lot to do before I leave for vacation in 2 days, and it's very unlikely we'll get around to that work in Liberty | 15:29 |
krotscheck | Can whoever sees rameshg next ask him to respond to my comment on https://review.openstack.org/#/c/199769/ please? | 15:30 |
dtantsur | devananda, morning | 15:31 |
zhenguo | devananda: ok, maybe we should move it to next. | 15:31 |
*** davideagnello has quit IRC | 15:34 | |
* devananda recreates his venv | 15:34 | |
*** zhenguo has quit IRC | 15:36 | |
*** Marga_ has quit IRC | 15:42 | |
*** jjohnson2 has quit IRC | 15:42 | |
*** Marga_ has joined #openstack-ironic | 15:43 | |
*** mgoddard has quit IRC | 15:43 | |
*** meghal has joined #openstack-ironic | 15:44 | |
*** lsmola has quit IRC | 15:44 | |
*** links has quit IRC | 15:44 | |
thiagop | morning devananda | 15:44 |
*** puranamr has joined #openstack-ironic | 15:45 | |
*** puranamr has quit IRC | 15:46 | |
*** puranamr has joined #openstack-ironic | 15:46 | |
* devananda is having E_TOO_LITTLE_COFFEE issues | 15:47 | |
*** puranamr has quit IRC | 15:47 | |
*** puranamr has joined #openstack-ironic | 15:48 | |
*** meghal has left #openstack-ironic | 15:48 | |
*** meghal has joined #openstack-ironic | 15:48 | |
rloo | jlvillal: wrt https://wiki.openstack.org/wiki/Nova-Ironic-Bugs, what is 'Fix proposed' vs eg 'Owned by Ironic team'? | 15:50 |
*** mgoddard has joined #openstack-ironic | 15:59 | |
*** davideagnello has joined #openstack-ironic | 16:00 | |
*** ifarkas has quit IRC | 16:02 | |
thiagop | jlvillal: in some of the exceptions, we intend to overwrite the message. Do you think we should remove the default message of them? | 16:03 |
*** mgoddard1 has joined #openstack-ironic | 16:04 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Fail introspection early if no lookup attributes can be detected https://review.openstack.org/216777 | 16:06 |
devananda | ** NOTICE ** everyone can resume normal reviewing / landing patches. We have switched to "post versioning" now on the server, much like the client used to be (and still is). <<< rloo NobodyCam dtantsur lucasagomes Haomeng|2 yuriyz ramesh^^^ jroll | 16:06 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic-specs: Add pluggable credentials storage https://review.openstack.org/186056 | 16:07 |
*** mgoddard has quit IRC | 16:07 | |
dtantsur | devananda, \o/ | 16:07 |
rloo | devananda: yay! | 16:07 |
NobodyCam | ty devananda :) | 16:07 |
dtantsur | (inspector has been on postversioning since 2.0.0) | 16:07 |
devananda | I'll be sending release notes for 4.0.0 after I get some food | 16:07 |
trown | woot | 16:08 |
devananda | dtantsur: you are aware of the new (in liberty) release process and that it is in effect for inspector as well, I presume? | 16:08 |
devananda | ie, post a CR to openstack/releases | 16:08 |
dtantsur | devananda, I'm aware only about the former, and the latter requires actions for me, IIRC | 16:08 |
dtantsur | * from | 16:08 |
dtantsur | it's not automatic, someone needs to fix ACL's, maybe launchpad | 16:09 |
devananda | cool. I believe dhellmann does that. it's updated in the governance repo, so I suspect he's done it automatically, but good to check with him | 16:09 |
dtantsur | devananda, so I'm not sure it's in effect for inspector *now*, but I'll be definitely switching to it ASAP | 16:09 |
dtantsur | devananda, we've chatted on the ML. governance repo is a bit messy wrt inspector: python-ironic-inspector-client got release:managed without me knowing, inspector itself is still officially independent | 16:11 |
dtantsur | I assume the easiest thing now is to sort it out after we release Liberty... | 16:11 |
*** marzif has quit IRC | 16:12 | |
lucasagomes | \o/ | 16:13 |
*** endorphin has quit IRC | 16:14 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic-specs: Add pluggable credentials storage https://review.openstack.org/186056 | 16:15 |
dtantsur | JoshNang, around? it's re https://review.openstack.org/#/c/215061/ | 16:16 |
devananda | dtantsur: I would think it's better to sort that out before liberty | 16:16 |
devananda | so that we can release inspector and ironic in as consistent a way as possible | 16:16 |
dtantsur | devananda, me too, if I had, say 36 hours in a day, or better a couple of clones :) | 16:16 |
JoshNang | dtantsur: o/ | 16:16 |
devananda | LOL. yea, well, if you figure that out, let me know. I need some too :) | 16:17 |
*** jistr has quit IRC | 16:17 | |
devananda | this copy of me, however, needs breakfast ... bbiab | 16:17 |
dtantsur | devananda, so I'll put it on my todo list, and will *try* hard to sort it before liberty, ok? enjoy breakfast :) | 16:17 |
JoshNang | dtantsur: ah yeah, that's reasonable. | 16:17 |
JoshNang | (just saw your comment) | 16:17 |
dtantsur | JoshNang, I think we should make lookup-less life possible, but it's a bit harder than just dropping it | 16:18 |
*** davideagnello has quit IRC | 16:18 | |
dtantsur | IIRC there's a (pretty contradictive) spec on it even | 16:18 |
*** jlk has left #openstack-ironic | 16:18 | |
JoshNang | heh yeah i talked about that spec a bunch at the midcycle | 16:18 |
*** puranamr has quit IRC | 16:19 | |
openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: OneView Driver for Ironic https://review.openstack.org/191822 | 16:19 |
JoshNang | but yeah, we should be able to pass those configs in via the kernel commandline, but for now, yeah this makes sense | 16:19 |
*** e0ne has quit IRC | 16:20 | |
JoshNang | dtantsur: +2 | 16:23 |
dtantsur | sorry, my router decided that happily blinking is much funnier than giving me internets... | 16:24 |
dtantsur | JoshNang, thanks! | 16:24 |
JoshNang | heh no worries | 16:24 |
*** bnemec has joined #openstack-ironic | 16:25 | |
*** marzif has joined #openstack-ironic | 16:28 | |
openstackgerrit | John Trowbridge proposed openstack/ironic-inspector: Store and expose introspection data https://review.openstack.org/213159 | 16:33 |
trown | dtantsur: whoops I did not see you did recheck | 16:34 |
dtantsur | no problem :) | 16:35 |
trown | dtantsur: I changed to hardcoded inspector url | 16:35 |
trown | I think it failed building the ramdisk though | 16:36 |
dtantsur | yeah | 16:38 |
*** romcheg has quit IRC | 16:44 | |
jlvillal | rloo: "Fix proposed' our bugs that show a patch has been submitted (mrda) | 16:44 |
*** romcheg has joined #openstack-ironic | 16:45 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Clean up README https://review.openstack.org/216797 | 16:45 |
*** romcheg has quit IRC | 16:45 | |
jlvillal | rloo: 'Owned by Ironic team' our bugs that don't have a patch submitted (mrda) | 16:45 |
jlvillal | In theory... | 16:45 |
rloo | jlvillal: what is not owned by ironic team? | 16:45 |
rloo | jlvillal: I mean. Does the ironic team own all nova/ironic bugs? | 16:46 |
*** amotoki has quit IRC | 16:46 | |
jlvillal | rloo: No, we shouldn't own all of them. Some bugs are owned by people who don't contribute much to Ironic. They should go into that category. | 16:47 |
rloo | jlvillal: I don't understand the different subcategories. if they are meant to be mutually exclusive or just different ways of displaying the same info or ... | 16:47 |
rloo | jlvillal: so there could be 'Fix proposed' patches that are related to bugs owned by ironic team or not owned by ironic team? | 16:47 |
jlvillal | rloo: We were trying to categorize things and hopefully stuff only went into one category. | 16:47 |
jlvillal | That was the initial plan. | 16:48 |
rloo | jlvillal: so which bugs are not owned by ironic team? (And how do you decide if they are owned... 'who don't contribute much'. hmm. | 16:48 |
*** mgoddard1 has quit IRC | 16:48 | |
jlvillal | Happy to take ideas on improvements. | 16:48 |
rloo | jlvillal: really, i just want to know which are high priorities for us to look at :) | 16:48 |
openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: Make our README friendly to OpenStack release-tools https://review.openstack.org/216799 | 16:49 |
rloo | jlvillal: well, I'm just giving you feedback that I don't understand the subsections. | 16:49 |
*** adam_g has joined #openstack-ironic | 16:49 | |
jlvillal | rloo: Ah. mrda and I were planning on a more thorough scrub this afternoon. Go revisit bugs and see if things are changed. Some weeks we only look for new bugs. | 16:49 |
*** adam_g has quit IRC | 16:49 | |
*** adam_g has joined #openstack-ironic | 16:49 | |
rloo | jlvillal: 'Fix committed'. does that mean a patch was merged but the bug is still open/not fixed? | 16:50 |
jlvillal | rloo: it means the fix was committed. The bug could still be open or closed. We were trying to keep track of the things we have monitored. | 16:50 |
jlvillal | Instead of just deleting it from the page when it was merged. | 16:50 |
jlvillal | I will discuss with mrda today if we can figure out a better way to indicate high priority bugs. | 16:51 |
*** romainh has left #openstack-ironic | 16:51 | |
rloo | jlvillal: 'the fix' == ? that the bug was fixed, or a patch with some fix was committed but it may eg be a partial fix? | 16:51 |
jlvillal | rloo: Though we do put bugs that are ready for review into the Nova etherpad. | 16:51 |
jlvillal | rloo: I think we were only doing bugs that had a 'closes-bug' comment. I think. | 16:52 |
jlvillal | Hopefully partials didn't get into that list. | 16:52 |
rloo | jlvillal: so maybe i should just look at the nova etherpad? does this mean that if someone submits a patch for one of the bugs, they should let you/mrda know so you can update that etherpad? | 16:52 |
rloo | jlvillal: is the agreement between nova/ironic, that they will only look at the etherpad for patches? | 16:53 |
jlvillal | rloo: That would be helpful for us. Which makes me think we should add that to the wiki page. | 16:53 |
jlvillal | Nova wants us (mrda and me) to review patches and put them on the Etherpad. | 16:53 |
*** mgoddard has joined #openstack-ironic | 16:53 | |
*** jjohnson2 has joined #openstack-ironic | 16:54 | |
jlvillal | rloo: FYI: https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 16:54 |
jlvillal | There is a section for Ironic patches. | 16:54 |
rloo | jlvillal: perhaps an email to the community would help then, wrt the process. if nova folks will only look at the patches on that etherpad, it is in the interest of the patch submitters to have their patches listed there. | 16:54 |
jlvillal | rloo: I think Nova will make an effort to look at the ones in the Etherpad. But I don't think they will only look at those ones. | 16:55 |
lucasagomes | devananda, rloo dtantsur NobodyCam wsme 0.8.0 was released and will break Ironic | 16:56 |
rloo | jlvillal: ok, but given that there is the etherpad and that some patches get listed there, it'd be good to know which ones/how/etc. | 16:56 |
jlvillal | rloo: Okay. Thanks for the input. I will discuss it with mrda today and we can work on an email to send out. | 16:56 |
lucasagomes | devananda, rloo dtantsur NobodyCam I will put a fix right on before the mirror cache it | 16:56 |
*** romcheg has joined #openstack-ironic | 16:56 | |
rloo | lucasagomes: ugh. you sure it will break? | 16:56 |
jlvillal | rloo: Hopefully we can make things more obvious. | 16:56 |
lucasagomes | rloo, yup just tested it locally | 16:56 |
jlvillal | I think we need to describe our categories better. | 16:56 |
rloo | jlvillal: thx! (sorry, guess i should have looked at that wiki months ago.) | 16:57 |
rloo | lucasagomes: ok, let us know what to do :) | 16:57 |
rloo | lucasagomes: and thx for the heads up. | 16:58 |
lucasagomes | cool np | 16:58 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Update tests to reflect WSME 0.8 fixes https://review.openstack.org/216802 | 16:59 |
lucasagomes | devananda, rloo dtantsur ^^^ | 16:59 |
lucasagomes | NobodyCam, ^ | 16:59 |
*** meghal has quit IRC | 16:59 | |
*** derekh has quit IRC | 16:59 | |
*** meghal has joined #openstack-ironic | 17:00 | |
dtantsur | lucasagomes, isn't it an API breaking change? | 17:00 |
jlvillal | rloo: Thanks for the feedback. Much appreciated! | 17:01 |
*** meghal has quit IRC | 17:01 | |
*** lazy_prince has quit IRC | 17:01 | |
*** meghal has joined #openstack-ironic | 17:01 | |
*** rameshg87 has joined #openstack-ironic | 17:02 | |
lucasagomes | dtantsur, well it was a bug in WSME | 17:03 |
lucasagomes | dtantsur, it should not ignore fields that doesn't exist and says it created the object correctly | 17:03 |
dtantsur | lucasagomes, still, following our definition of versioning we need to cover it by API version :) | 17:03 |
rameshg87 | rloo: hi | 17:03 |
lucasagomes | now it does the right thing | 17:03 |
lucasagomes | dtantsur, that's an independent library... idk how we are capturing thta with API version | 17:04 |
rloo | hi rameshg87 | 17:04 |
rloo | rameshg87: you have a bit of time to discuss the raid stuff? | 17:04 |
dtantsur | lucasagomes, it's not that I insist (and it's not that it's possible), obviously, but it might break people for real | 17:04 |
rloo | lucasagomes: where did those node.raid fields come from? | 17:04 |
rameshg87 | rloo: yeah, I came in for that | 17:04 |
*** karimb has quit IRC | 17:04 | |
lucasagomes | dtantsur, potentially yes | 17:04 |
rloo | rameshg87: oh, sorry you had to come in for that :-( | 17:04 |
lucasagomes | rloo, some patch added it | 17:04 |
rameshg87 | rloo: oh no problem .. | 17:04 |
rameshg87 | was there something related to my patch going on already ? | 17:05 |
* rameshg87 reads back log | 17:05 | |
lucasagomes | rloo, https://review.openstack.org/#/c/155230/ | 17:05 |
rloo | rameshg87: it is something else | 17:05 |
rameshg87 | okay | 17:06 |
rloo | lucasagomes: oh yeah. forgot that it got merged. sorry. | 17:06 |
dtantsur | lucasagomes, so, to sum up my concern: previously people could provide unused fields, and everything seemed to work fine. It will break now. | 17:06 |
rloo | lucasagomes: but yeah, i was wondering if it will break our users (like dtantsur sez) | 17:06 |
lucasagomes | dtantsur, nonexistent | 17:06 |
rloo | ok rameshg87, about the validation of the target raid config. | 17:06 |
rameshg87 | rloo: so my concern was we cannot call common.raid.validate_configuration() directly because drivers can define new schemas | 17:07 |
lucasagomes | dtantsur, rloo we will need to pin the WSME version then... but it's a legitimate bug in wsme that got fixed | 17:07 |
rameshg87 | rloo: so it would be odd if we raise some errors while accepting target_raid_config | 17:07 |
lucasagomes | before it was error because if you do a POST {'driver': 'fake', 'foo': 'bar'} it would return 201 (Created) | 17:07 |
lucasagomes | which is wrong because the field "foo" does not exist | 17:07 |
rameshg87 | rloo: and some other when we call the actual task.driver.raid.validate() - the actual driver's method which validates their custom raid schema | 17:08 |
rloo | rameshg87: what's the use of having common.raid.validate_configuration() if drivers can define new schemas? | 17:08 |
rameshg87 | rloo: it's a base implementation which we have accepted to be a norm | 17:08 |
*** e0ne has joined #openstack-ironic | 17:08 | |
rameshg87 | rloo: in the spec we have iterated most of the people's points and captured as the default ironic would wish for | 17:08 |
dtantsur | devananda, I know you like talking about API compatibility :-P so we have some good discussion here ^^ | 17:09 |
rameshg87 | rloo: but still open to accepting newer properties from drivers if they wish to add new | 17:09 |
dtantsur | devananda, tl;dr new wsme release starts to give an error on unexpected API fields | 17:09 |
rloo | rameshg87: in your opinion, is the raid.validate() meant to only validate the actual config? | 17:09 |
rameshg87 | rloo: may not be. if someone does raid configuration out of band, they might validate if they have the credentials of the bmc which does raid configuration. right ? | 17:10 |
rloo | rameshg87: right, that's what i was wondering. | 17:10 |
rloo | rameshg87: so maybe we need another method in the raid interface to only verify the config? | 17:10 |
rloo | rameshg87: IF we want to do any verification when the user submits the target raid config. | 17:11 |
rameshg87 | rloo: that's one option. validate() of the driver could call that method to do the verification of the config | 17:11 |
rameshg87 | rloo: another alternative is by type of exception. | 17:12 |
rameshg87 | rloo: how about if we define an exception class InvalidRaidConfig(InvalidParameterValue) | 17:12 |
rloo | rameshg87: you mean, call validate() and based on the exception returned? | 17:12 |
rloo | rameshg87: I don't like that. it is sort of a side effect of calling validate. | 17:12 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Update tests to reflect WSME 0.8 fixes https://review.openstack.org/216802 | 17:12 |
devananda | dtantsur: reading scrollback .... | 17:13 |
rloo | rameshg87: if we think the drivers should all explicitly validate the config, we should have a method for that. | 17:13 |
rameshg87 | rloo: hmm..yeah then probably we will need to have a method defined in the RAIDInterface | 17:13 |
rameshg87 | rloo: and the base implementation of validate() should just call validate_raid_config() | 17:14 |
*** mestery has quit IRC | 17:14 | |
rloo | rameshg87: yes, i think that is cleaner, more explicit. | 17:14 |
rameshg87 | rloo: and drivers are free to override and implement both validate() and validate_raid_config() | 17:14 |
rloo | rameshg87: yup. | 17:14 |
devananda | oh, awesome | 17:15 |
*** achanda has joined #openstack-ironic | 17:15 | |
rameshg87 | rloo: okay, makes sense | 17:15 |
rameshg87 | rloo: let me propose an update to the spec | 17:15 |
rloo | rameshg87: thx. I am fine if you remove the validate part from that patch, and we approve it so you aren't blocked. (as long as others are fine too.) | 17:16 |
rameshg87 | rloo: and add the call to validate_interfaces part later on | 17:17 |
rameshg87 | rloo: but I don't want the API patch to be merged anyway, otherwise we might have different behaviours. | 17:17 |
rloo | rameshg87: oh, good point. | 17:17 |
rameshg87 | jroll: mind +2ing the patch now - https://review.openstack.org/#/c/215431/ :) | 17:18 |
lucasagomes | devananda, the fix for WSME 0.8 is this one https://review.openstack.org/216802 | 17:18 |
rameshg87 | jroll: because I have another update to that spec coming up shortly :) | 17:18 |
lucasagomes | devananda, IMHO it's a legitimate bug in WSME that has been fixed | 17:19 |
rameshg87 | oh jroll is on vacation | 17:19 |
lucasagomes | but yeah, as dtantsur pointed out it may break users which are creating resources with nonexistent fields | 17:19 |
rameshg87 | devananda or lucasagomes, can someone please have a look at a spec update https://review.openstack.org/#/c/215431/ | 17:19 |
lucasagomes | rameshg87, :-( can I take a look at it tomorrow? | 17:19 |
openstackgerrit | Devananda van der Veen proposed openstack/ironic: add links for UEFI secure boot support to iLO driver documentation https://review.openstack.org/216528 | 17:19 |
rameshg87 | lucasagomes: sure no problem | 17:20 |
*** Nisha_away has joined #openstack-ironic | 17:20 | |
rloo | rameshg87: or just modify that spec update to include the new method | 17:20 |
lucasagomes | rameshg87, thank | 17:20 |
lucasagomes | thanks | 17:20 |
*** r3mu5 has joined #openstack-ironic | 17:21 | |
rameshg87 | rloo: eh, anyway 2 different things - hard to explain and hard to get for others | 17:21 |
rameshg87 | rloo: I would rather opt for a separate patch | 17:21 |
rloo | rameshg87: true. also hard to get people to review :) | 17:21 |
devananda | lucasagomes: confirmed - your fix fixes the issues I was seeing this morning | 17:22 |
lucasagomes | devananda, cool, yeah I think it would be better to merge it before we actually get the gate broken | 17:22 |
*** absubram has joined #openstack-ironic | 17:22 | |
lucasagomes | it's not yet because the mirror wasn't updated | 17:22 |
devananda | yep | 17:22 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: [WIP] Add introspection rules support https://review.openstack.org/208375 | 17:23 |
*** mestery has joined #openstack-ironic | 17:23 | |
devananda | any other cores want to review lucas' patch real quick? | 17:24 |
NobodyCam | I can look but do not have env to test atm.... | 17:24 |
NobodyCam | devananda: ahh I see you comment :) | 17:24 |
rloo | devananda: done | 17:24 |
* lucasagomes is trying to give a heads up to others projects using wsme | 17:25 | |
*** davideagnello has joined #openstack-ironic | 17:25 | |
NobodyCam | rloo: lol your quick :) hehehe | 17:25 |
rloo | NobodyCam: I had already looked at it! | 17:26 |
rloo | NobodyCam: I meant to say, yeah, I'm super quick ;) | 17:26 |
*** trown is now known as trown|lunch | 17:27 | |
*** thiagop has left #openstack-ironic | 17:27 | |
*** thiagop has joined #openstack-ironic | 17:27 | |
lucasagomes | thanks folks | 17:28 |
lucasagomes | cdent will put an email to the ML alerting other projects about WSME 0.8 | 17:28 |
*** Nisha_away has quit IRC | 17:28 | |
*** Nisha_away has joined #openstack-ironic | 17:28 | |
dtantsur | see you all tomorrow | 17:29 |
*** dtantsur is now known as dtantsur|afk | 17:29 | |
lucasagomes | dtantsur, g'night | 17:29 |
*** meghal has quit IRC | 17:30 | |
*** meghal has joined #openstack-ironic | 17:30 | |
openstackgerrit | SHIGEMATSU Mitsuhiro proposed openstack/bifrost: Generate network_info json using a module https://review.openstack.org/216372 | 17:30 |
thiagop | good night dtantsur|afk | 17:30 |
jlvillal | dtantsur|afk: Ciao | 17:30 |
*** Nisha_away is now known as Nisha_ | 17:34 | |
NobodyCam | night dtantsur|afk | 17:34 |
*** meghal has quit IRC | 17:35 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: Add a new method validate_raid_config to RAIDInterface https://review.openstack.org/216809 | 17:35 |
rameshg87 | rloo: ^^^ when you got some time | 17:35 |
*** meghal has joined #openstack-ironic | 17:35 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor agent driver with pxe boot interface https://review.openstack.org/166521 | 17:41 |
rloo | rameshg87: will look in a few minutes. thx! | 17:46 |
rameshg87 | rloo: thanks | 17:46 |
*** romcheg has quit IRC | 17:46 | |
* rameshg87 leaves for the day | 17:46 | |
*** rameshg87 has quit IRC | 17:46 | |
lucasagomes | I will call it a day too | 17:47 |
lucasagomes | folks have a great night! | 17:47 |
*** lucasagomes is now known as lucas-dinner | 17:47 | |
thiagop | good night lucas-dinner | 17:47 |
NobodyCam | have a good nught lucas-dinner | 17:47 |
NobodyCam | night even :-p | 17:47 |
thiagop | and ramesh too (though he's out before I can wish it) | 17:48 |
openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Add some comparison operators to Serializable class https://review.openstack.org/215854 | 18:01 |
*** marzif has quit IRC | 18:11 | |
sambetts | Also calling it a night o/ see you all tomorrow | 18:12 |
thiagop | night sambetts | 18:12 |
*** rloo_ has joined #openstack-ironic | 18:15 | |
NobodyCam | night sambetts | 18:16 |
*** rloo has quit IRC | 18:17 | |
*** meghal has quit IRC | 18:17 | |
*** tab has joined #openstack-ironic | 18:20 | |
*** tab is now known as Guest55946 | 18:20 | |
*** Guest55946 has quit IRC | 18:20 | |
*** jlk has joined #openstack-ironic | 18:21 | |
*** tab___ has joined #openstack-ironic | 18:21 | |
*** cdearborn has joined #openstack-ironic | 18:23 | |
*** trown|lunch is now known as trown | 18:26 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic: Remove the ironic.config.sample file https://review.openstack.org/216829 | 18:27 |
rloo_ | jlvillal: wrt the .sample. seems like it comes up again and again. i like having it and we decided awhile ago to keep it. | 18:29 |
jlvillal | rloo_: Oh, I didn't know that. I noticed that sometimes it gets updated and sometimes it doesn't | 18:30 |
jlvillal | rloo_: So I liked what Nova did :) | 18:30 |
*** puranamr has joined #openstack-ironic | 18:30 | |
rloo_ | jlvillal: it used to be gated and would get out of sync if some other package was updated. nova got frustrated and got rid of it. but we decided to not gate on it but still have it. | 18:30 |
rloo_ | jlvillal: i don't like what nova did, cuz now, if i want to generate nova's .sample, it takes time to do. | 18:31 |
rloo_ | jlvillal: you can't generate it w/o a dev environment. i don't think. i'm not sure, but i think some operators weren't happy about that. | 18:31 |
jlvillal | rloo_: Okay. Thanks for the info. I had mentioned this idea on IRC a week or so ago. But nothing but crickets ;) | 18:32 |
*** mtanino_ has joined #openstack-ironic | 18:32 | |
jlvillal | So I went for it! | 18:32 |
*** meghal has joined #openstack-ironic | 18:32 | |
rloo_ | jlvillal: now i'm wondering how to document this for folks to know. since that .sample is generated i don't see how we can add a comment there. | 18:32 |
jlvillal | rloo_: Maybe update the 'genconfig' job to add something at the top of the file after it is generated? | 18:33 |
thiagop | there isn't a command on tox to generate the nova.conf.sample? | 18:33 |
thiagop | "tox -e genconfig" | 18:34 |
rloo_ | would it be enough to add a comment in the tox.ini file? | 18:34 |
*** mtanino has quit IRC | 18:34 | |
jlvillal | thiagop: There is a command. You just said it :) | 18:35 |
thiagop | just nuts-checking myself | 18:35 |
jlvillal | rloo_: I can see people never looking at tox.ini | 18:35 |
jlvillal | If they are looking at the config file | 18:36 |
rloo_ | jlvillal: how do folks know that the config is out of date then? I mean, why did you think of getting rid of it? | 18:37 |
*** rloo_ is now known as rloo | 18:38 | |
jlvillal | rloo: Well I knew because I did a 'tox -e genconfig' and then there was a diff | 18:38 |
rloo | jlvillal: the problem with adding a comment to the top of the .sample is that folks may not even read that. | 18:38 |
*** romcheg has joined #openstack-ironic | 18:38 | |
jlvillal | And if some oslo package makes changes, it can make the config out of date. | 18:39 |
rloo | jlvillal: how did you know to do a tox -e genconfig? you didn't look in tox.ini? | 18:39 |
rloo | jlvillal: do we have doc somewhere for generating the config? | 18:39 |
jlvillal | rloo: I did yes. But I'm saying someone who is looking at the config file as an example will have no idea. | 18:39 |
rloo | jlvillal: no idea that it might be out of sync? | 18:39 |
jlvillal | rloo: Yes | 18:39 |
rloo | jlvillal: I'm only concerned with folks who want to delete the .sample. | 18:39 |
jlvillal | rloo: And also, no idea on how to regenerate it. | 18:40 |
rloo | jlvillal: I mean, I don't want others to submit a patch to delete the .sample. | 18:40 |
jlvillal | rloo: You lost me there. Folks like me who proposed a patch to delete .sample? | 18:40 |
jlvillal | Ah :) | 18:40 |
rloo | jlvillal: if someone notices the .sample is out of sync, they can ask and hopefully someone on irc or mailing list can answer. | 18:40 |
rloo | jlvillal: yeah, cuz you said you didn't know that we wanted to keep it. | 18:41 |
jlvillal | rloo: Maybe add a README file? Like my patch does. | 18:41 |
jlvillal | But don't delete the sample | 18:41 |
jlvillal | I could change my patch to do that. | 18:41 |
rloo | jlvillal: i don't want another README file. | 18:41 |
rloo | jlvillal: forget all that ^^. I'm going to move on to something else. | 18:42 |
jlvillal | rloo: Works for me. Thanks. I'll just abandon my patch. | 18:43 |
*** Sukhdev has joined #openstack-ironic | 18:43 | |
thiagop | ¯\_(ツ)_/¯ | 18:44 |
* jlvillal now knows that means shrug :) | 18:45 | |
devananda | oh hey, http://docs.openstack.org/developer/ironic/deploy/install-guide.html?highlight=enroll#enrollment does not mention the new default ENROLL state :( | 18:46 |
devananda | dtantsur|afk: ^ | 18:46 |
thiagop | devananda: I think there is a patch from NobodyCam to update that | 18:47 |
devananda | also, there's no good writeup of the new workflow for me to link to in the release notes. | 18:47 |
devananda | oh? | 18:47 |
*** puranamr has quit IRC | 18:47 | |
thiagop | devananda: #link https://review.openstack.org/#/c/209251/ | 18:48 |
rloo | devananda: ask and you shall receive... | 18:48 |
jlvillal | Is our gate broken again? | 18:49 |
jlvillal | :( | 18:49 |
rloo | jlvillal: ? | 18:49 |
jlvillal | I just noticed a lot of jobs failed the check... | 18:49 |
rloo | jlvillal: unless the wsme got in before lucas' patch | 18:49 |
rloo | jlvillal: example? | 18:49 |
jlvillal | rloo: https://review.openstack.org/#/c/216758/ | 18:50 |
jlvillal | rloo: I think it could be wsme | 18:50 |
thiagop | I got some of that on my local tox too | 18:50 |
devananda | urhhh | 18:51 |
devananda | yea, oslo rleease | 18:51 |
rloo | jlvillal: it is the wsme thing | 18:51 |
devananda | nope | 18:51 |
devananda | now it's oslo.config and oslo.i18n | 18:51 |
thiagop | Unknown attributes for argument node: chassis_id, target_raid_config, raid_config | 18:51 |
rloo | thiagop: that's the wsme thing | 18:51 |
devananda | oh never mind. I'm in the wrong venv | 18:51 |
rloo | this is when we wish there was a a VIP queue for patches. | 18:52 |
jlvillal | rloo: Okay. lucas-dinner patch is in the check queue and is queued not running yet. So we got some time before the gate will get fixed .... | 18:52 |
jlvillal | rloo: +1 | 18:52 |
*** marzif has joined #openstack-ironic | 18:52 | |
* thiagop grabs coffee to wait | 18:53 | |
jlvillal | rloo: And current gate queue is at 5+ hours... | 18:53 |
openstackgerrit | Lilia Sampaio proposed openstack/ironic: OneView Driver for Ironic https://review.openstack.org/191822 | 18:53 |
rloo | jlvillal: can we just kill a bunch of patches cuz we know they will fail? | 18:53 |
rloo | jlvillal: i mean, take them out of the gate queue | 18:54 |
jlvillal | rloo: I have no idea how to do that :( And for sure I don't have the power. | 18:55 |
openstackgerrit | Merged openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/216563 | 18:55 |
rloo | jlvillal: ha ha. | 18:55 |
* jlvillal thinks now is a good time for lunch... | 18:55 | |
*** mtanino has joined #openstack-ironic | 18:58 | |
thiagop | jlvillal rloo you should be able to remove your own patches when you see a gate failing.. | 18:59 |
thiagop | that would be useful... | 18:59 |
devananda | rloo: upload a new revision to gerrit | 19:00 |
devananda | rloo: even just a whitespace edit in the commit message should do it | 19:00 |
rloo | devananda: won't that just cause the cycle to start over again? | 19:00 |
*** mtanino_ has quit IRC | 19:01 | |
devananda | no - it'll require another +A | 19:01 |
devananda | so it will go into the check queue, but not the gate queue | 19:01 |
thiagop | also, WIP shouldn't run tests | 19:01 |
thiagop | or run in low priority at least | 19:01 |
devananda | thiagop: anything you post to gerrit will always run tests | 19:01 |
rloo | devananda: oh yeah. and have everyone kill me cuz they lost their +A. | 19:01 |
devananda | rloo: :) | 19:01 |
*** Nisha_ has quit IRC | 19:01 | |
rloo | i dare you to do it devananda ;) | 19:02 |
*** Nisha has joined #openstack-ironic | 19:02 | |
* rloo isn't in a hurry | 19:02 | |
*** jlk has left #openstack-ironic | 19:07 | |
openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add release notes for 4.0.0 https://review.openstack.org/216843 | 19:09 |
JayF | So 4.0.0 is released? | 19:09 |
JayF | if so I'll let jroll know, he'll be excited - vacation or not | 19:09 |
NobodyCam | morning JayF :) | 19:10 |
devananda | technically the bits are already cut, but there are things being ironied out | 19:10 |
jlvillal | rloo: devananda: lucas-dinner: NobodyCam: Updated the whiteboard about the gate being broken. | 19:10 |
devananda | like the fact the release didn' thave any release notes | 19:10 |
devananda | jlvillal: ty | 19:10 |
*** yog_ has quit IRC | 19:11 | |
devananda | JayF, rloo, NobodyCam, others ... do not land that release notes patch yet. dhellmann is working on some tooling to do it "right" (I dont know details yet) so he will be taking over that patch and/or working with ya'll to update it soon | 19:11 |
* JayF can't land it anyway :) | 19:11 | |
devananda | er, I meant jroll ^ :L( | 19:11 |
rloo | devananda: you want us to review but not land, or not review too? | 19:11 |
devananda | :) | 19:11 |
devananda | rloo: feel free to review - your eye to detail may spot things I didn't include | 19:12 |
devananda | also this shouldn't include everyu little detail -- just the big things | 19:12 |
devananda | which i htink i got :) | 19:12 |
*** thiagop has left #openstack-ironic | 19:14 | |
*** thiagop has joined #openstack-ironic | 19:14 | |
rloo | devananda: our previous release notes had 'known issues' and 'upgrade notes'. this one just has the key features. is that ok? | 19:14 |
devananda | rloo: we should probably do some of that too | 19:14 |
devananda | however | 19:14 |
devananda | this isn't the liberty final release | 19:15 |
devananda | the biggest thing is: hey look, semver versioning! | 19:15 |
devananda | but then there are also all the other htings we did. and some that we haphazardly landed half-done so far | 19:15 |
devananda | which we should finish up before Liberty, and then drop, say, 4.1.0 | 19:15 |
devananda | assuming no more incompatible changes (cause omg please no) | 19:15 |
rloo | devananda: life would be so boring w/o incompatible changes | 19:16 |
rloo | devananda: don't worry, we'll wait til you're back from vacation to mention the rest ;) | 19:17 |
devananda | I've added a section to the whiteboard with a few links and notes. I'm also super late for doing things I need to do before vacation now ... so I gotta run ... | 19:18 |
NobodyCam | enjoy the running devananda :) | 19:18 |
devananda | lol | 19:18 |
NobodyCam | :) | 19:18 |
*** achanda has quit IRC | 19:28 | |
*** pelix has quit IRC | 19:32 | |
*** davideagnello has quit IRC | 19:36 | |
*** davideagnello has joined #openstack-ironic | 19:36 | |
*** jjohnson2 has quit IRC | 19:37 | |
*** davideagnello has quit IRC | 19:37 | |
*** mgoddard has quit IRC | 19:37 | |
*** pelix has joined #openstack-ironic | 19:39 | |
*** dims has joined #openstack-ironic | 19:43 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: Remove the hard dependency of swift from ilo drivers https://review.openstack.org/198656 | 19:44 |
*** marzif_ has joined #openstack-ironic | 19:44 | |
*** pelix has quit IRC | 19:46 | |
*** marzif has quit IRC | 19:46 | |
*** ionutbalutoiu has quit IRC | 19:51 | |
*** ionutbalutoiu has joined #openstack-ironic | 19:52 | |
*** ionutbalutoiu has quit IRC | 20:01 | |
*** achanda has joined #openstack-ironic | 20:11 | |
*** puranamr has joined #openstack-ironic | 20:22 | |
*** jjohnson2 has joined #openstack-ironic | 20:30 | |
*** e0ne has quit IRC | 20:35 | |
*** Nisha has quit IRC | 20:39 | |
*** Sukhdev has quit IRC | 20:43 | |
openstackgerrit | John Trowbridge proposed openstack/ironic-inspector: Store and expose introspection data https://review.openstack.org/213159 | 20:46 |
thiagop | folks, I'm calling it a day | 20:58 |
thiagop | see you tomorrow | 20:59 |
*** thiagop has quit IRC | 20:59 | |
*** bnemec has quit IRC | 21:05 | |
*** bnemec has joined #openstack-ironic | 21:06 | |
*** meghal has quit IRC | 21:07 | |
*** meghal has joined #openstack-ironic | 21:07 | |
*** tab___ has quit IRC | 21:08 | |
*** jjohnson2 has quit IRC | 21:11 | |
*** achanda has quit IRC | 21:15 | |
*** trown is now known as trown|outttypeww | 21:15 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic: Stop providing 'message' property in IronicException https://review.openstack.org/215362 | 21:16 |
*** meghal has quit IRC | 21:16 | |
*** achanda has joined #openstack-ironic | 21:17 | |
*** dprince has quit IRC | 21:19 | |
*** meghal has joined #openstack-ironic | 21:31 | |
*** linggao has quit IRC | 21:34 | |
*** davideagnello has joined #openstack-ironic | 21:37 | |
*** davideagnello has quit IRC | 21:43 | |
*** davideagnello has joined #openstack-ironic | 21:44 | |
mrda | Morning Ironic | 21:45 |
NobodyCam | good morning mrda | 21:45 |
mrda | hey NobodyCam | 21:45 |
NobodyCam | :) | 21:45 |
*** e0ne has joined #openstack-ironic | 21:48 | |
*** meghal has quit IRC | 21:49 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost: WIP: Ansible 2.0 compatibility **DO NOT MERGE** https://review.openstack.org/196832 | 21:51 |
*** natorious is now known as zz_natorious | 21:52 | |
TheJulia | Yeah, ansible 2.0 is not my friend | 21:53 |
*** meghal has joined #openstack-ironic | 21:54 | |
*** meghal has quit IRC | 21:58 | |
*** meghal has joined #openstack-ironic | 21:58 | |
rloo | hey, morning mrda. | 22:01 |
mrda | hey rloo | 22:01 |
rloo | mrda, i was looking over some of the nova-ironic bugs. Wondering what the status was for https://bugs.launchpad.net/nova/+bug/1459874 | 22:01 |
openstack | Launchpad bug 1459874 in OpenStack Compute (nova) "Ironic driver needs microversion support" [Low,In progress] - Assigned to Michael Davies (mrda) | 22:01 |
rloo | mrda: would be nice to get it into liberty. i dunno, we don't seem to have needed it but it worries me not to have it there, just in case. | 22:03 |
mrda | rloo: I haven't done much on this yet (since thinking about it and raising it) | 22:03 |
mrda | rloo: I agree. But given feature freeze, I don't think it'll make it. I think a better bet is easy Muppet | 22:03 |
mrda | s/easy/early/ | 22:04 |
rloo | mrda: guess they might consider it a feature. and it is low priority. oh well. | 22:04 |
JayF | I just tossed a second +2 on this, anyone wanna take a look before I land it? https://review.openstack.org/#/c/215061 (IPA) | 22:04 |
mrda | rloo: I'll push up something soon | 22:05 |
rloo | mrda: no worries. if we don't think it'll get into liberty, we can wait til M. | 22:06 |
rloo | mrda: I want to make sure that anything we really want in liberty/nova, we do/review soon. | 22:06 |
*** bnemec has quit IRC | 22:07 | |
mrda | rloo: thanks, I agree | 22:07 |
*** bnemec has joined #openstack-ironic | 22:09 | |
rloo | JayF: I looked. Left the +A honor for you :) | 22:09 |
JayF | heh, you can feel free to +A | 22:09 |
JayF | I don't get as much time to review nowadays so feels strange to approve things | 22:09 |
JayF | although trying to get back into a cadence of doing some reviews, even if I don't have a bulk of time | 22:09 |
rloo | welcome back JayF ;) Anyway, that's why I left the honour for you, since you so rarely do it! | 22:10 |
JayF | hah | 22:10 |
JayF | well I was gone for 6 weeks, and I got manager'd back in May | 22:10 |
*** zz_natorious is now known as natorious | 22:10 | |
JayF | now that I know somewhat what I'm doing hopefully I can stop being missing entirely from upstream :) | 22:10 |
NobodyCam | JayF: it is nice to have you back in channel again though :) | 22:11 |
rloo | JayF: there are a lot of specs that want your eyeballs... | 22:11 |
JayF | I'm starting out with IPA stuff and working my way up :) | 22:11 |
JayF | don't wanna get too deep into any specs until I'm certain I can see them to the end | 22:11 |
jlvillal | JayF: JoshNang mariojv : Any objections to making the IPA python34 tests voting? gate-ironic-python-agent-python34 | 22:14 |
JoshNang | jlvillal: has it been stable? | 22:15 |
mariojv | jlvillal: i've never actually been able to run those locally | 22:15 |
JayF | I don't have enough recent context to object :) | 22:15 |
jlvillal | Looking at some patches, it seems like it is passing. It did catch an error on my patch :) | 22:15 |
*** absubram has quit IRC | 22:15 | |
mariojv | jlvillal: if it's stable when running at the gate, i'd vote yes. i think the errors i was seeing are just a problem with my local environment | 22:16 |
JoshNang | yeah, same, i've had some bug locally where it "can't determine db type" and quits | 22:16 |
*** e0ne has quit IRC | 22:16 | |
JoshNang | but ++ gate seems to be fine | 22:16 |
jlvillal | JoshNang: I do rm .testrepository and then it works. | 22:17 |
jlvillal | For a while... | 22:17 |
JoshNang | i've done that and got one run out of it.. | 22:17 |
mariojv | JoshNang: that's the same error i see | 22:17 |
jlvillal | JoshNang: mariojv JayF: I'll see if I can do a patch to move it to voting. Unless someone else wants to do it :) | 22:17 |
jlvillal | mariojv: Do rm -rf .testrepository/ | 22:18 |
mariojv | jlvillal: that doesn't seem to help | 22:18 |
jlvillal | mariojv: and it should work. | 22:18 |
jlvillal | Really? | 22:18 |
mariojv | yeah, i just tried it | 22:18 |
jlvillal | In the top directory | 22:18 |
mrda | +1 rm the testr stuff and start over and the db error disappears | 22:18 |
* jlvillal goes to find his old patches related to gate voting | 22:19 | |
*** achanda has quit IRC | 22:19 | |
SpamapS | TheJulia: interesting thing I just ran into w/ Bifrost | 22:20 |
*** r3mu5 has left #openstack-ironic | 22:20 | |
SpamapS | TheJulia: my deploy network is 10.10.16.128/26 | 22:20 |
NobodyCam | oh do we hardcode a /24? | 22:20 |
NobodyCam | heya SpamapS | 22:21 |
*** achanda has joined #openstack-ironic | 22:21 | |
mariojv | yeah, tried switching over to a regular master branch and rm'ing .testrepository, rm'ing .tox, 3.4 tests still fail with the db error | 22:23 |
jlvillal | mariojv: :( | 22:24 |
JayF | I'm going to try it | 22:24 |
jlvillal | JoshNang: Does IPA have any releases? stable? kilo? etc... ? | 22:24 |
JayF | jlvillal: we have never cut a release, and we've never made an incompatible change | 22:24 |
jlvillal | JayF: Wonderful :) | 22:25 |
JayF | jlvillal: whether or not that's the "right thing" has been an issue of some debate, but nobody has cared enough to do the legwork or push hard for it | 22:25 |
JoshNang | jlvillal: there's a patch somewhere to tag releases | 22:25 |
jlvillal | JayF: JoshNang: Just wondering if I needed to exclude the check from old releases. Sounds like the answer is no. | 22:25 |
*** cdearborn has quit IRC | 22:26 | |
TheJulia | SpamapS: I thought I made that configurable... but sounds like an issue :( | 22:26 |
SpamapS | TheJulia: it is configurable | 22:27 |
SpamapS | TheJulia: However, the code assumes deploying ipv4_subnet_mask == end network subnet mask. | 22:27 |
SpamapS | TheJulia: my end network is a /24 | 22:27 |
jlvillal | JoshNang: JayF mariojv: https://review.openstack.org/#/c/216886/ | 22:28 |
SpamapS | TheJulia: also my gateway is different. | 22:28 |
SpamapS | TheJulia: so we need a deploy_ipv4_* and an active_ipv4_* | 22:29 |
SpamapS | NobodyCam: howdy | 22:29 |
TheJulia | SpamapS: That kind of makes sense | 22:31 |
SpamapS | TheJulia: it's all caused by this weird vlan stuff | 22:32 |
SpamapS | been fighting this network for 2 and a half years. | 22:32 |
SpamapS | So wish we could just have transit and a router and they'd let us do whatever we want. | 22:32 |
TheJulia | yah | 22:33 |
TheJulia | So what do you need from me in the short term to be successful? | 22:33 |
SpamapS | TheJulia: oh, I think just reviews | 22:33 |
SpamapS | TheJulia: working on patches already. :) | 22:33 |
TheJulia | awesome! | 22:33 |
SpamapS | will just split the current unqualified ipv4_* into two | 22:33 |
TheJulia | 10-4 | 22:34 |
SpamapS | I COULD also just bring things up on 10.10.16.128/26 .. and layer the vlan25 stuff on later | 22:34 |
*** lucas-dinner has quit IRC | 22:34 | |
SpamapS | That may actually be the shorter path | 22:35 |
SpamapS | but I'll try and get my patches done anyway | 22:36 |
NobodyCam | SpamapS: TY :) | 22:36 |
jlvillal | mariojv: As a note, I do not need to remove .testrepository after each run. I did it once. I may have done it more than once. But not each run. | 22:38 |
mariojv | oh, ok | 22:38 |
jlvillal | mariojv: I'm using Fedora 22 | 22:39 |
jlvillal | mariojv: Testing on my Ubuntu 14.04 system now...... | 22:39 |
mariojv | jlvillal: i'm on ubuntu 14.04 | 22:40 |
*** puranamr has quit IRC | 22:41 | |
*** puranamr has joined #openstack-ironic | 22:41 | |
jlvillal | mariojv: Works for me on Ubuntu 14.04 also. | 22:41 |
mariojv | weird | 22:41 |
jlvillal | mariojv: :( | 22:42 |
mariojv | jlvillal: i'll try it out on a fresh vm, fresh clone later and see what happens | 22:44 |
jlvillal | mariojv: Good luck | 22:44 |
mariojv | it may well be something strange happening on my local setup | 22:44 |
mariojv | jlvillal: do you know why removing .testrepository fixes the issue? | 22:45 |
*** Sukhdev has joined #openstack-ironic | 22:45 | |
jlvillal | mariojv: I'm guessing that is a database inside that directory. | 22:45 |
jlvillal | mariojv: $ ls ~/openstack/ironic-python-agent/.testrepository/ | 22:46 |
jlvillal | 0 1 2 failing format next-stream times.dbm | 22:46 |
jlvillal | Probably 'times.dbm' | 22:46 |
mariojv | jlvillal: i think you're right | 22:48 |
mariojv | jlvillal: https://ask.openstack.org/en/question/5310/db-type-could-not-be-determined/ | 22:48 |
mariojv | i was able to remove that file, then just run 3.4 tests, then run 2.7 tests, in that order | 22:48 |
jlvillal | mariojv: Thanks for the link :) | 22:49 |
JayF | py34 tests won't pass locally for me, even though they will run | 22:49 |
JayF | hah | 22:49 |
jlvillal | mariojv: Great, you got it to work. I was doing 'tox -v -v -epy34' | 22:49 |
jlvillal | So not doing py27 | 22:49 |
jlvillal | Maybe lifeless will fix the issue soon :) | 22:50 |
lifeless | hmm ? | 22:50 |
lifeless | whats up ? | 22:50 |
mariojv | lifeless: talking about bug https://bugs.launchpad.net/testrepository/+bug/1229445, we just ran into it | 22:51 |
openstack | Launchpad bug 1212909 in Testrepository "duplicate for #1229445 times.dbm incompatible based on Python version it was created with" [Critical,Triaged] | 22:51 |
lifeless | oh - the testr thing. so I don't think the bug will get fixed directly | 22:51 |
lifeless | instead I'm pushing ahead on making it possible to put testr outside of tox | 22:51 |
lifeless | rather than inside | 22:51 |
mrda | lifeless: do you know why it gets occasionally tickled? | 22:51 |
lifeless | I have a prototype working now that tests testr itself in 9 different python versions | 22:51 |
lifeless | mrda: tox | 22:51 |
lifeless | mrda: I dove down into it in the thread about this on the list a while back | 22:52 |
mrda | so it's a refresh of tox that causes this issue? | 22:52 |
mrda | ok | 22:52 |
lifeless | mrda: if a brief google doesn't find that for you, let me know | 22:52 |
lifeless | mrda: different python versions have different db formats they support | 22:52 |
mrda | I'm assuming it's related to a library refresh or something that makes it suddenly appear | 22:52 |
mrda | thanks | 22:52 |
lifeless | times.dbm is shared across different python versions because the 'testr' that is being run is being installed inside the virtualenv | 22:52 |
mrda | :) | 22:53 |
lifeless | the solution is to a) install testr globally and b) don't install it inside the venv | 22:53 |
mrda | right | 22:53 |
*** asd112z has quit IRC | 22:59 | |
*** shoutm has joined #openstack-ironic | 23:01 | |
openstackgerrit | Merged openstack/ironic-python-agent: Allow passing node UUID to lookup https://review.openstack.org/215061 | 23:02 |
*** davideagnello has quit IRC | 23:24 | |
*** bitblt has joined #openstack-ironic | 23:28 | |
*** bitblt has quit IRC | 23:28 | |
*** marzif_ has quit IRC | 23:29 | |
*** davideagnello has joined #openstack-ironic | 23:31 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost: Cleanup role meta definitions https://review.openstack.org/216905 | 23:42 |
openstackgerrit | Julia Kreger proposed openstack/bifrost: WIP: Ansible 2.0 compatibility **DO NOT MERGE** https://review.openstack.org/196832 | 23:46 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!