rloo | jroll: :D | 00:00 |
---|---|---|
*** romcheg1 has joined #openstack-ironic | 00:01 | |
*** romcheg has quit IRC | 00:01 | |
jroll | oh this is good | 00:02 |
jroll | You are not allowed to post to this mailing list, and your message has | 00:02 |
jroll | been automatically rejected. If you think that your messages are | 00:02 |
jroll | being rejected in error, contact the mailing list owner at | 00:02 |
jroll | openstack-announce-owner@lists.openstack.org. | 00:02 |
jroll | devananda: ^ | 00:02 |
jroll | sorry for spam | 00:02 |
*** naohirot has joined #openstack-ironic | 00:03 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/221929 | 00:04 |
*** romcheg1 has quit IRC | 00:06 | |
*** Sukhdev has quit IRC | 00:07 | |
*** Sukhdev has joined #openstack-ironic | 00:07 | |
*** shoutm has quit IRC | 00:17 | |
*** alexpilo_ has joined #openstack-ironic | 00:19 | |
*** alexpilotti has quit IRC | 00:19 | |
*** shoutm has joined #openstack-ironic | 00:20 | |
*** shadower has quit IRC | 00:23 | |
*** shadower has joined #openstack-ironic | 00:23 | |
*** garthb has quit IRC | 00:25 | |
*** ijw__ has joined #openstack-ironic | 00:32 | |
*** ijw_ has quit IRC | 00:33 | |
*** puranamr has joined #openstack-ironic | 00:39 | |
*** tsekiyam_ has joined #openstack-ironic | 00:40 | |
*** tsekiyam_ has quit IRC | 00:44 | |
*** tsekiyama has quit IRC | 00:44 | |
*** alexpilotti has joined #openstack-ironic | 00:46 | |
*** alexpilo_ has quit IRC | 00:46 | |
jroll | BadCub: great linkedin picture | 00:48 |
*** chenke_ has quit IRC | 01:01 | |
openstackgerrit | Wang Wei proposed openstack/ironic: Fix mistakes in comments https://review.openstack.org/222005 | 01:02 |
openstackgerrit | Wang Wei proposed openstack/ironic: Fix mistakes in comments https://review.openstack.org/222005 | 01:10 |
*** dims_ has joined #openstack-ironic | 01:16 | |
*** dims has quit IRC | 01:19 | |
*** rloo has quit IRC | 01:20 | |
*** puranamr has quit IRC | 01:22 | |
*** puranamr has joined #openstack-ironic | 01:23 | |
jroll | devananda and friends https://etherpad.openstack.org/p/mitaka-ironic-design-summit-ideas | 01:25 |
* jroll sends email | 01:25 | |
*** achanda has quit IRC | 01:26 | |
* jroll also resends 4.1.0 announcement as he failed the first time | 01:27 | |
*** achanda has joined #openstack-ironic | 01:29 | |
*** harshs has quit IRC | 01:42 | |
*** baoli has joined #openstack-ironic | 01:43 | |
*** Sukhdev has quit IRC | 01:43 | |
*** Marga_ has quit IRC | 01:45 | |
*** ijw__ has quit IRC | 01:47 | |
*** vishwanathj has quit IRC | 01:50 | |
*** Haomeng|2 has joined #openstack-ironic | 01:51 | |
*** Haomeng has quit IRC | 01:55 | |
*** baoli has quit IRC | 01:56 | |
*** r-daneel has quit IRC | 01:57 | |
*** baoli has joined #openstack-ironic | 02:04 | |
*** praneshp has quit IRC | 02:15 | |
*** chenglch has joined #openstack-ironic | 02:15 | |
*** thrash is now known as thrash|g0ne | 02:16 | |
*** blakec has quit IRC | 02:33 | |
*** penick has quit IRC | 02:36 | |
*** puranamr has quit IRC | 02:45 | |
*** puranamr has joined #openstack-ironic | 02:52 | |
*** sdake has quit IRC | 02:58 | |
*** puranamr has quit IRC | 03:03 | |
*** puranamr has joined #openstack-ironic | 03:03 | |
openstackgerrit | Merged openstack/bifrost: Follow up to Ifdccb32035fa91fe8d8200c3090973c34d453801 https://review.openstack.org/221819 | 03:08 |
*** harshs has joined #openstack-ironic | 03:12 | |
openstackgerrit | Merged openstack/bifrost: Remove explicit ELEMENTS_PATH definition https://review.openstack.org/221436 | 03:13 |
*** sonuk has quit IRC | 03:16 | |
*** sonuk has joined #openstack-ironic | 03:17 | |
*** dims_ has quit IRC | 03:23 | |
openstackgerrit | Merged openstack/ironic: Fix mistakes in comments https://review.openstack.org/222005 | 03:24 |
*** natorious has quit IRC | 03:26 | |
*** eglute has quit IRC | 03:27 | |
*** natorious has joined #openstack-ironic | 03:27 | |
*** eglute has joined #openstack-ironic | 03:28 | |
*** ijw_ has joined #openstack-ironic | 03:29 | |
*** links has joined #openstack-ironic | 03:30 | |
*** vvb has joined #openstack-ironic | 03:30 | |
*** vvb has quit IRC | 03:35 | |
*** achanda has quit IRC | 03:38 | |
*** achanda has joined #openstack-ironic | 03:38 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: Remove the hard dependency of swift from ilo drivers https://review.openstack.org/198656 | 03:41 |
*** saripurigopi has joined #openstack-ironic | 03:43 | |
saripurigopi | Morning Ironic | 03:43 |
*** vvb has joined #openstack-ironic | 03:46 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: Remove the hard dependency of swift from ilo drivers https://review.openstack.org/198656 | 03:47 |
*** puranamr has quit IRC | 03:48 | |
*** praneshp has joined #openstack-ironic | 03:49 | |
*** praneshp_ has joined #openstack-ironic | 03:51 | |
*** alexpilotti has quit IRC | 03:52 | |
*** alexpilotti has joined #openstack-ironic | 03:53 | |
*** praneshp has quit IRC | 03:53 | |
*** praneshp_ is now known as praneshp | 03:53 | |
*** vvb has left #openstack-ironic | 04:01 | |
*** ijw_ has quit IRC | 04:05 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add support for inband raid configuration agent ramdisk https://review.openstack.org/198238 | 04:05 |
*** morgan has quit IRC | 04:06 | |
*** morganfainberg has joined #openstack-ironic | 04:07 | |
*** morganfainberg is now known as morgan | 04:09 | |
*** baoli has quit IRC | 04:10 | |
*** VikasC has joined #openstack-ironic | 04:10 | |
*** marzif has joined #openstack-ironic | 04:10 | |
*** dims has joined #openstack-ironic | 04:23 | |
*** lazy_prince has joined #openstack-ironic | 04:27 | |
*** dims has quit IRC | 04:30 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Cache the description of RAID properties https://review.openstack.org/221939 | 04:36 |
Haomeng|2 | saripurigopi: morning:) | 04:58 |
Haomeng|2 | saripurigopi: I am back from vacations:) | 04:58 |
*** Haomeng|2 is now known as Haomeng | 04:58 | |
saripurigopi | Hello Haomeng|2 | 04:58 |
Haomeng | saripurigopi: :) | 04:58 |
*** Marga_ has joined #openstack-ironic | 05:01 | |
*** stendulker has joined #openstack-ironic | 05:01 | |
zhenguo | Haomeng: welcome back :) | 05:05 |
*** Marga_ has quit IRC | 05:09 | |
*** Nisha has joined #openstack-ironic | 05:10 | |
*** praneshp has quit IRC | 05:15 | |
*** ijw_ has joined #openstack-ironic | 05:16 | |
*** praneshp has joined #openstack-ironic | 05:17 | |
*** sdake_ has joined #openstack-ironic | 05:18 | |
*** Sukhdev has joined #openstack-ironic | 05:19 | |
*** sdake_ is now known as sdake | 05:21 | |
*** ramineni_ has joined #openstack-ironic | 05:25 | |
*** sonuk has quit IRC | 05:27 | |
*** sonuk has joined #openstack-ironic | 05:27 | |
*** vishwanathj has joined #openstack-ironic | 05:27 | |
*** vishwanathj has quit IRC | 05:28 | |
*** saripurigopi has quit IRC | 05:29 | |
*** sdake_ has joined #openstack-ironic | 05:29 | |
*** sdake has quit IRC | 05:30 | |
*** alexpilotti has quit IRC | 05:40 | |
*** alexpilo_ has joined #openstack-ironic | 05:40 | |
Haomeng | zhenguo: :) | 05:42 |
Haomeng | zhenguo: thanks:) | 05:42 |
*** saripurigopi has joined #openstack-ironic | 05:46 | |
*** jerrygb has joined #openstack-ironic | 05:53 | |
*** harshs has quit IRC | 05:55 | |
*** sonuk has quit IRC | 05:56 | |
*** sonuk has joined #openstack-ironic | 05:56 | |
*** sdake has joined #openstack-ironic | 06:08 | |
*** sdake_ has quit IRC | 06:11 | |
*** jerrygb has quit IRC | 06:19 | |
*** ukalifon has joined #openstack-ironic | 06:20 | |
*** praneshp has quit IRC | 06:27 | |
*** sdake has quit IRC | 06:28 | |
*** sdake has joined #openstack-ironic | 06:29 | |
*** rameshg87 has joined #openstack-ironic | 06:29 | |
*** Haomeng|2 has joined #openstack-ironic | 06:36 | |
*** alexpilo_ has quit IRC | 06:36 | |
*** alexpilotti has joined #openstack-ironic | 06:36 | |
*** Haomeng has quit IRC | 06:39 | |
*** achanda has quit IRC | 06:39 | |
*** achanda has joined #openstack-ironic | 06:39 | |
*** penick has joined #openstack-ironic | 06:43 | |
zhenguo | Haomeng|2: hi | 06:45 |
*** achanda has quit IRC | 06:48 | |
Haomeng|2 | zhenguo: pong | 06:49 |
zhenguo | Haomeng|2: can you please help to get this https://review.openstack.org/#/c/177642/ in? already have 2 +2s now | 06:50 |
Haomeng|2 | zhenguo: sure | 06:51 |
zhenguo | Haomeng|2: thanks :) | 06:51 |
*** achanda has joined #openstack-ironic | 06:53 | |
*** achanda has quit IRC | 06:54 | |
*** penick has quit IRC | 06:56 | |
*** achanda has joined #openstack-ironic | 07:00 | |
*** lsmola has joined #openstack-ironic | 07:02 | |
*** romainh has joined #openstack-ironic | 07:03 | |
*** yuikotakada has joined #openstack-ironic | 07:03 | |
yuikotakada | hi, ironic :) | 07:04 |
*** achanda has quit IRC | 07:06 | |
*** achanda has joined #openstack-ironic | 07:06 | |
*** jcoufal has joined #openstack-ironic | 07:07 | |
*** smoriya has joined #openstack-ironic | 07:07 | |
*** achanda has quit IRC | 07:12 | |
*** ijw_ has quit IRC | 07:17 | |
*** Sukhdev has quit IRC | 07:19 | |
*** yog_ has joined #openstack-ironic | 07:23 | |
Haomeng|2 | zhenguo: approved, and thanks for your big efforts to fix this bug. | 07:30 |
Haomeng|2 | yuikotakada: morning:) | 07:30 |
yuikotakada | Haomeng|2: morning :) | 07:30 |
Haomeng|2 | yuikotakada: :) | 07:30 |
zhenguo | Haomeng|2: thanks a lot :) | 07:31 |
Haomeng|2 | zhenguo: thanks for your patches:) | 07:32 |
Haomeng|2 | zhenguo: : | 07:32 |
Haomeng|2 | zhenguo: :) | 07:32 |
zhenguo | Haomeng|2 :) | 07:32 |
*** bigjools has quit IRC | 07:43 | |
openstackgerrit | Debayan Ray proposed stackforge/proliantutils: common, ris, ribcl changes to support firmware update https://review.openstack.org/203543 | 07:44 |
*** bigjools has joined #openstack-ironic | 07:46 | |
*** bigjools has quit IRC | 07:46 | |
*** bigjools has joined #openstack-ironic | 07:46 | |
dtantsur | Morning Ironic | 07:47 |
*** dlpartain has joined #openstack-ironic | 07:48 | |
*** yuikotakada has quit IRC | 07:51 | |
*** Haomeng has joined #openstack-ironic | 07:51 | |
*** yuikotakada has joined #openstack-ironic | 07:54 | |
*** amotoki has joined #openstack-ironic | 07:55 | |
*** Haomeng|2 has quit IRC | 07:55 | |
*** bapalm has quit IRC | 07:58 | |
Nisha | dtantsur, o/ | 07:59 |
dtantsur | o/ | 07:59 |
*** mbound has joined #openstack-ironic | 07:59 | |
*** mikal has quit IRC | 07:59 | |
*** shoutm_ has joined #openstack-ironic | 08:00 | |
Nisha | dtantsur, https://review.openstack.org/#/c/198656/23 | 08:00 |
Nisha | plz | 08:00 |
*** bapalm has joined #openstack-ironic | 08:00 | |
dtantsur | Nisha, ok, will try to fit it in my schedule | 08:01 |
*** jistr has joined #openstack-ironic | 08:01 | |
Nisha | dtantsur, thanks | 08:01 |
*** mikal has joined #openstack-ironic | 08:01 | |
*** shoutm has quit IRC | 08:01 | |
*** dlpartain has left #openstack-ironic | 08:02 | |
*** marzif has quit IRC | 08:13 | |
*** lucasagomes has joined #openstack-ironic | 08:15 | |
*** sdake has quit IRC | 08:17 | |
*** MattMan has joined #openstack-ironic | 08:18 | |
*** jerrygb has joined #openstack-ironic | 08:19 | |
*** jerrygb has quit IRC | 08:24 | |
*** jcoufal has quit IRC | 08:25 | |
*** ifarkas has joined #openstack-ironic | 08:25 | |
*** athomas has joined #openstack-ironic | 08:25 | |
*** karimb has joined #openstack-ironic | 08:30 | |
*** mbound has quit IRC | 08:35 | |
*** pelix has joined #openstack-ironic | 08:36 | |
*** bigjools has quit IRC | 08:38 | |
*** bigjools has joined #openstack-ironic | 08:40 | |
*** bigjools has joined #openstack-ironic | 08:40 | |
openstackgerrit | Merged openstack/ironic: When boot option is not persisted, set boot on next power on https://review.openstack.org/177642 | 08:41 |
*** romcheg has joined #openstack-ironic | 08:45 | |
*** ijw_ has joined #openstack-ironic | 08:48 | |
betherly | Morning ironic! | 08:51 |
*** derekh has joined #openstack-ironic | 08:51 | |
dtantsur | betherly, morning | 08:51 |
betherly | hey :) | 08:52 |
betherly | so i have a quick question that im pretty sure i need to ask michael but #timezones #paternity | 08:52 |
betherly | anyone know why /www has been git ignored? | 08:52 |
*** ijw_ has quit IRC | 08:53 | |
dtantsur | I'm not sure I even get the question :) | 08:56 |
*** e0ne has joined #openstack-ironic | 08:57 | |
betherly | ah ok :) no worries | 08:58 |
*** Nisha has quit IRC | 09:04 | |
*** shoutm has joined #openstack-ironic | 09:05 | |
openstackgerrit | Tan Lin proposed openstack/ironic: Base IronicObject on VersionedObject https://review.openstack.org/213602 | 09:06 |
openstackgerrit | Tan Lin proposed openstack/ironic: Use oslo.versionedobjects remotable decorators https://review.openstack.org/217000 | 09:06 |
openstackgerrit | Tan Lin proposed openstack/ironic: Replace metaclass registry with explicit opt-in registry from oslo https://review.openstack.org/217584 | 09:06 |
openstackgerrit | Tan Lin proposed openstack/ironic: Remove unused object function https://review.openstack.org/222082 | 09:06 |
*** mbound has joined #openstack-ironic | 09:07 | |
*** shoutm_ has quit IRC | 09:07 | |
*** e0ne has quit IRC | 09:07 | |
sambetts | betherly: I don't see /www in the ironic .gitignore file | 09:11 |
*** e0ne has joined #openstack-ironic | 09:12 | |
dtantsur | morning sambetts | 09:12 |
betherly | sorry sambetts not being clear! talking the ironic webclient. my bad. | 09:13 |
*** bnemec has quit IRC | 09:13 | |
*** bnemec has joined #openstack-ironic | 09:14 | |
vdrok | morning ironic | 09:15 |
betherly | i think though its because a different folder is being used but in which case im a little confused why changes to /www have an affect on /app at all and further to that if /app is being used why /www exists | 09:15 |
betherly | morning vdrok | 09:15 |
vdrok | betherly, morning | 09:15 |
sambetts | Morning everyone o/ | 09:15 |
betherly | hi sambetts | 09:15 |
vdrok | sambetts, morning | 09:17 |
*** jcoufal has joined #openstack-ironic | 09:18 | |
*** jerrygb has joined #openstack-ironic | 09:20 | |
*** Nisha has joined #openstack-ironic | 09:23 | |
*** penick has joined #openstack-ironic | 09:24 | |
*** jerrygb has quit IRC | 09:26 | |
lucasagomes | betherly, dtantsur sambetts vdrok good morning (-: | 09:27 |
betherly | morning lucasagomes | 09:27 |
vdrok | morning lucasagomes, dtantsur | 09:27 |
dtantsur | o/ | 09:31 |
*** dims has joined #openstack-ironic | 09:31 | |
openstackgerrit | Tan Lin proposed openstack/ironic-specs: Add support to boot Windows PreInstallation Environment(WinPE) https://review.openstack.org/220889 | 09:32 |
*** dtantsur is now known as dtantsur|brb | 09:32 | |
rameshg87 | dtantsur: just a quick question - https://review.openstack.org/#/c/198238/23/ironic/drivers/modules/agent.py L491 | 09:33 |
dtantsur|brb | sure | 09:33 |
rameshg87 | dtantsur|brb: oh still here | 09:33 |
dtantsur|brb | you caught me the last second :) | 09:33 |
rameshg87 | dtantsur|brb: might take some time if you want to go and come back | 09:33 |
*** dtantsur|brb is now known as dtantsur | 09:33 | |
rameshg87 | dtantsur: okay | 09:33 |
dtantsur | no problem | 09:33 |
rameshg87 | dtantsur: why do you prefer @clean_step decorator more than current implementation | 09:33 |
dtantsur | rameshg87, because that's how we do it according to clean/zapping spec? | 09:34 |
rameshg87 | dtantsur: if we use @clean_step_decorator, we need to handle the error of our own in create_configuration | 09:34 |
dtantsur | I mean, why reinvent the same thing? What if we add more arguments to clean_step (Lucas is doing it)? | 09:34 |
dtantsur | rameshg87, which error? | 09:34 |
rameshg87 | dtantsur: if agent doesn't support raid configuration, deploy_utils.agent_execute_clean_step(task, step) will fail | 09:35 |
rameshg87 | dtantsur: with agent saying I can't find any hardware manager support it | 09:35 |
*** e0ne has quit IRC | 09:35 | |
dtantsur | so? | 09:35 |
rameshg87 | dtantsur: hmm we might just need to throw the error back upwards | 09:35 |
rameshg87 | hmm yeah, in that case we might not need | 09:36 |
* rameshg87 checks | 09:36 | |
dtantsur | yeah, please check | 09:36 |
rameshg87 | https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/clean.py#L69-L75 | 09:36 |
dtantsur | I'll be around for 5-10 mins more | 09:36 |
rameshg87 | dtantsur: okay, I will check | 09:36 |
rameshg87 | thanks a lot | 09:36 |
*** alexpilotti_ has joined #openstack-ironic | 09:37 | |
*** dims has quit IRC | 09:38 | |
*** mbound has quit IRC | 09:38 | |
openstackgerrit | Merged openstack/ironic: Remove the hard dependency of swift from ilo drivers https://review.openstack.org/198656 | 09:38 |
openstackgerrit | Merged openstack/ironic: Fix object field type calling conventions https://review.openstack.org/221894 | 09:38 |
*** mbound has joined #openstack-ironic | 09:39 | |
dtantsur | rameshg87, lucasagomes, hmm it looks like agent drivers to not use @clean_step decorator, which somewhat bothers me | 09:39 |
lucasagomes | dtantsur, right, yeah the IPA ramdisk has the clean operations for it | 09:40 |
dtantsur | oh well... | 09:40 |
lucasagomes | once it boots it tells the Ironic conductor what are the clean operations | 09:40 |
lucasagomes | cause those are in-band | 09:41 |
lucasagomes | (sure it will only boot if the "clean_nodes" config option is set to True) | 09:41 |
openstackgerrit | Merged openstack/ironic-python-agent: Tuples returned by clean steps cause API error https://review.openstack.org/221498 | 09:41 |
*** e0ne has joined #openstack-ironic | 09:41 | |
dtantsur | rameshg87, so then maybe this code is more-or-less fine. so maybe create a mix-in class to keep this agent-cleaning related code? | 09:42 |
rameshg87 | dtantsur: yeah, the ipa ramdisk does that | 09:43 |
dtantsur | lucasagomes, could you have a look at https://review.openstack.org/#/c/198238/ then? You seem to understand cleaning much better than me :) | 09:43 |
rameshg87 | dtantsur: I mean it doesn't use @clean_step decorator because they don't have a corresponding method on ironic which can trigger something for them | 09:43 |
dtantsur | rameshg87, I've dropped my -1, need to dig into how cleaning works at all for us | 09:43 |
*** dtantsur is now known as dtantsur|brb | 09:44 | |
* dtantsur|brb really brb | 09:44 | |
rameshg87 | dtantsur|brb: agreed, please brb | 09:44 |
rameshg87 | :) | 09:44 |
* lucasagomes looks | 09:44 | |
lucasagomes | give me some minutes, finishing some thoughts on the abort review before. Otherwise I will confuse the topics by reviewing two patches at the same time | 09:45 |
openstackgerrit | Sam Betts proposed openstack/ironic-inspector: Add API Discovery to Ironic Inspector https://review.openstack.org/215067 | 09:46 |
rameshg87 | lucasagomes: sure. thanks. | 09:47 |
*** dims has joined #openstack-ironic | 09:49 | |
*** ijw_ has joined #openstack-ironic | 09:50 | |
*** ijw_ has quit IRC | 09:54 | |
*** yuikotakada has quit IRC | 09:58 | |
*** naohirot has quit IRC | 09:59 | |
*** ramineni_ has quit IRC | 09:59 | |
*** romcheg has quit IRC | 10:07 | |
*** penick has quit IRC | 10:07 | |
*** romcheg has joined #openstack-ironic | 10:13 | |
*** saripurigopi has quit IRC | 10:17 | |
lucasagomes | rameshg87, there's a lot going on in that patch no? especifically about the post hooks | 10:18 |
rameshg87 | lucasagomes: yes, | 10:18 |
lucasagomes | was that agreed somewhere? I don't see it in the spec | 10:18 |
rameshg87 | lucasagomes: we didn't have a provision to do something after a clean step | 10:19 |
rameshg87 | *inband clean step | 10:19 |
*** lintan_ has joined #openstack-ironic | 10:19 | |
rameshg87 | lucasagomes: eh no. should I just go back and update the spec ? | 10:19 |
lucasagomes | right, yeah. I understand the case | 10:19 |
*** saripurigopi has joined #openstack-ironic | 10:19 | |
rameshg87 | lucasagomes: I thought that was an implementation thing. but I can go back and update the spec if required. | 10:20 |
lucasagomes | but I also think that this creates an interface between ramdisk & ironic conductor that haven't been disucssed anywhere | 10:20 |
*** PradeepV has joined #openstack-ironic | 10:20 | |
rameshg87 | lucasagomes: hmm yeah | 10:20 |
rameshg87 | lucasagomes: better to update the spec ? | 10:21 |
lucasagomes | rameshg87, right, yeah. We can ask for opnions for other reviewers. But seems something that should be part of the spec yes | 10:21 |
lucasagomes | rameshg87, +1 from me | 10:21 |
*** lintan has quit IRC | 10:21 | |
rameshg87 | lucasagomes: will do, let me do it right away | 10:21 |
lucasagomes | rameshg87, but I wouldn't hesitate on ask other people what they think. Or just discuss it in that patch | 10:21 |
lucasagomes | rameshg87, thanks | 10:21 |
rameshg87 | lucasagomes: yeah will update spec anyway irrespective of current one gets accepted or not | 10:21 |
rameshg87 | good to update the spec in any case | 10:21 |
lucasagomes | rameshg87, +1 thanks for it (and for the patience) | 10:24 |
rameshg87 | lucasagomes: :) | 10:24 |
*** lazy_prince has quit IRC | 10:29 | |
*** zhenguo has quit IRC | 10:33 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic-python-agent: Fixes config drive creation failure in UEFI boot mode https://review.openstack.org/215097 | 10:33 |
*** vgridnev has joined #openstack-ironic | 10:33 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: Implement take_over for iscsi_ilo driver https://review.openstack.org/217068 | 10:39 |
*** chenglch has quit IRC | 10:39 | |
PradeepV | HI Ironic, I am trying to bring up a baremetal instance through agent driver, the deployment of the images are going on fine in baremetal but the nova state of the instance is only in spawning state and getting timedout | 10:39 |
PradeepV | has any one observerd the same isue | 10:39 |
sambetts | PradeepV: whats the state of the deployment in Ironic? | 10:40 |
*** mbound has quit IRC | 10:40 | |
PradeepV | sambetts: , on observing the logs the provisioning state of is in "wait-call-back" and moving to deploy failed | 10:41 |
sambetts | PradeepV: then something is going wrong with your deploy, if you do ironic node-show <node-uuid>, whats in the last-error field? | 10:42 |
PradeepV | sambetts: Failed to prepare node 12785e1e-d17b-4234-a6ac-258a996cf5ea for cleaning:Network 9432481f-1acc-479b-bd5a-ac01b0082674 could not be found | 10:43 |
*** blinky_ghost has joined #openstack-ironic | 10:43 | |
*** alexpilotti_ has quit IRC | 10:43 | |
*** blinky_ghost has left #openstack-ironic | 10:43 | |
*** Nisha has quit IRC | 10:43 | |
sambetts | PradeepV: Have you updated your ironic.conf with the network from neutron that your using to boot the nodes? | 10:45 |
lucasagomes | PradeepV, that error seems to happen after the deployment failed right? Cause the node is going to cleaning | 10:46 |
lucasagomes | PradeepV, maybe up in the logs you can see the reason why the deployment itself failed? | 10:47 |
lucasagomes | or even if it's timeout waiting for the ramdisk to talk back to Ironic | 10:47 |
lucasagomes | worth checking the node's console as well to see what's going on, if the ramdisk booted or what | 10:47 |
openstackgerrit | Tan Lin proposed openstack/ironic: Validate the input of properties https://review.openstack.org/215505 | 10:48 |
PradeepV | yes sambetts, i have updated the neutron, ok lucasagomes i will check the logs | 10:48 |
sambetts | lucasagomes, PradeepV: Yeah I think one error is obsuring the other | 10:48 |
sambetts | although you should be able to see in the conductor logs what happened as lucasagomes says | 10:49 |
*** dtantsur|brb is now known as dtantsur | 10:51 | |
*** ijw_ has joined #openstack-ironic | 10:51 | |
*** ijw_ has quit IRC | 10:56 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: Update in-band agent raid spec https://review.openstack.org/222133 | 11:02 |
openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add support for inband raid configuration agent ramdisk https://review.openstack.org/198238 | 11:05 |
*** Haomeng|2 has joined #openstack-ironic | 11:07 | |
*** achanda has joined #openstack-ironic | 11:08 | |
*** alexpilotti has quit IRC | 11:08 | |
openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: Update in-band agent raid spec https://review.openstack.org/222133 | 11:09 |
*** alexpilotti has joined #openstack-ironic | 11:09 | |
*** Haomeng has quit IRC | 11:10 | |
rameshg87 | lucasagomes: ^^^ I have proposed update to the spec, let me know how it looks like when you get some time | 11:10 |
lucasagomes | rameshg87, thanks! Will do | 11:10 |
rameshg87 | will be back on Monday and will continue with the work | 11:10 |
rameshg87 | thanks a lot for reviews | 11:10 |
* rameshg87 leaves for home and then for a vacation \o/ | 11:11 | |
*** rameshg87 has quit IRC | 11:11 | |
*** achanda has quit IRC | 11:12 | |
*** vgridnev has quit IRC | 11:12 | |
dtantsur | lucasagomes, I guess we can try to continue without ramesh until Monday | 11:12 |
dtantsur | otherwise not so much time to land everything... | 11:13 |
*** vgridnev has joined #openstack-ironic | 11:14 | |
*** ijw_ has joined #openstack-ironic | 11:18 | |
*** jerrygb has joined #openstack-ironic | 11:21 | |
*** ijw_ has quit IRC | 11:23 | |
*** shoutm has quit IRC | 11:24 | |
*** jerrygb has quit IRC | 11:26 | |
*** shoutm has joined #openstack-ironic | 11:26 | |
lucasagomes | dtantsur, ++ | 11:29 |
*** trown|outttypeww is now known as trown | 11:31 | |
*** sambetts has quit IRC | 11:35 | |
*** dlpartain has joined #openstack-ironic | 11:35 | |
*** dlpartain has left #openstack-ironic | 11:35 | |
*** sambetts has joined #openstack-ironic | 11:35 | |
*** saripurigopi has quit IRC | 11:40 | |
*** VikasC has quit IRC | 11:46 | |
openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/221929 | 11:48 |
*** jamielennox is now known as jamielennox|away | 11:49 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Refactor iscsi_ilo driver to use new boot interface https://review.openstack.org/216538 | 11:52 |
openstackgerrit | Juliana Motira proposed stackforge/pyghmi: Add custom OEM domain name command for Lenovo ThinkServers https://review.openstack.org/221911 | 12:00 |
*** jistr is now known as jistr|mtg | 12:03 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Refactor agent_ilo driver to use new boot interface https://review.openstack.org/217102 | 12:04 |
*** thrash|g0ne is now known as thrash | 12:11 | |
*** stendulker has quit IRC | 12:13 | |
openstackgerrit | Merged openstack/ironic-inspector: Enable colorized logging in devstack plugin https://review.openstack.org/221298 | 12:14 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Move update functions to NodeInfo object https://review.openstack.org/220939 | 12:15 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Split standard plugin tests from other processing tests https://review.openstack.org/221845 | 12:15 |
openstackgerrit | Juliana Motira proposed stackforge/pyghmi: Add custom OEM domain name command for Lenovo ThinkServers https://review.openstack.org/221911 | 12:17 |
*** dims has quit IRC | 12:22 | |
*** dims has joined #openstack-ironic | 12:23 | |
*** Marga_ has joined #openstack-ironic | 12:31 | |
*** Marga_ has quit IRC | 12:31 | |
*** Marga_ has joined #openstack-ironic | 12:32 | |
*** linkmark has joined #openstack-ironic | 12:36 | |
*** e0ne has quit IRC | 12:37 | |
*** nicodemos has joined #openstack-ironic | 12:39 | |
*** jerrygb has joined #openstack-ironic | 12:40 | |
*** jerrygb has quit IRC | 12:45 | |
*** PradeepV has quit IRC | 12:52 | |
*** jistr|mtg is now known as jistr | 12:52 | |
*** rloo has joined #openstack-ironic | 12:57 | |
*** romcheg has quit IRC | 12:57 | |
*** romcheg1 has joined #openstack-ironic | 12:57 | |
*** vgridnev has quit IRC | 12:57 | |
*** puranamr has joined #openstack-ironic | 12:57 | |
*** lazy_prince has joined #openstack-ironic | 13:08 | |
*** baoli has joined #openstack-ironic | 13:10 | |
*** vgridnev has joined #openstack-ironic | 13:10 | |
*** zhenguo has joined #openstack-ironic | 13:11 | |
*** puranamr has quit IRC | 13:15 | |
*** baoli_ has joined #openstack-ironic | 13:16 | |
*** puranamr has joined #openstack-ironic | 13:16 | |
*** baoli has quit IRC | 13:19 | |
*** links has quit IRC | 13:23 | |
*** alexpilotti has quit IRC | 13:23 | |
openstackgerrit | Sam Betts proposed openstack/ironic: Add Cisco IMC PXE Driver https://review.openstack.org/219253 | 13:24 |
*** smoriya has quit IRC | 13:24 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Allow abort for CLEANWAIT states https://review.openstack.org/201552 | 13:24 |
lucasagomes | JayF, ^ take a look when you have some time, this should do what you've asked (/me finishing some tests) | 13:24 |
*** alexpilotti has joined #openstack-ironic | 13:25 | |
dtantsur | jroll or JoshNang, could you review/approve https://review.openstack.org/#/c/205587/ please? got 2x +2 already | 13:25 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Allow abort for CLEANWAIT states https://review.openstack.org/201552 | 13:27 |
dtantsur | fg | 13:28 |
dtantsur | damn | 13:28 |
*** alexpilotti has quit IRC | 13:30 | |
*** e0ne has joined #openstack-ironic | 13:33 | |
NobodyCam | good morning Ironicers :) | 13:33 |
BadCub | jroll: thanks LOL | 13:33 |
dtantsur | NobodyCam, BadCub, morning | 13:33 |
*** yog_ has quit IRC | 13:33 | |
NobodyCam | morning dtantsur :) | 13:34 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Add introspection rules support https://review.openstack.org/208375 | 13:34 |
openstackgerrit | Sam Betts proposed openstack/ironic: Add Cisco IMC PXE Driver https://review.openstack.org/219253 | 13:36 |
BadCub | morning dtantsur | 13:36 |
*** alexpilotti has joined #openstack-ironic | 13:38 | |
vgridnev | Hey folks! I tried the following doc for creating prepared images for ubuntu: http://docs.openstack.org/developer/ironic/deploy/install-guide.html#image-requirements , but it failed with the following bug: https://bugs.launchpad.net/diskimage-builder/+bug/1470400 Is there a chance to fix this issue? | 13:38 |
openstack | Launchpad bug 1470400 in diskimage-builder "element grub2 worked with centos7, but not ubuntu." [Medium,Triaged] | 13:38 |
lucasagomes | vgridnev, hmm, if you're not going to use local boot you won't need the grub2 element | 13:40 |
lucasagomes | or as the bug indicates you can use another base OS until ubuntu gets fixed | 13:41 |
*** jerrygb has joined #openstack-ironic | 13:41 | |
rloo | morning NobodyCam, BadCub. Hi lucasagomes, dtantsur | 13:41 |
lucasagomes | rloo, NobodyCam BadCub good morning! | 13:41 |
BadCub | morning rloo lucasagomes | 13:42 |
dtantsur | morning rloo | 13:42 |
NobodyCam | Good morning rloo lucasagomes jlvillal jroll JoshNang JayF sambetts BadCub and all other not included in this list | 13:42 |
NobodyCam | :) | 13:42 |
lucasagomes | (-: | 13:43 |
dtantsur | we definitely need a morning bot :D | 13:43 |
vgridnev | lucasagomes, ok, but changing OS is not a good fix | 13:43 |
linkmark | hi (: | 13:43 |
BadCub | lol | 13:43 |
lucasagomes | vgridnev, it's not a fix, its a workaround | 13:43 |
lucasagomes | until the grub2 or ubuntu gets fixed | 13:44 |
jroll | dtantsur++ | 13:45 |
jroll | morning everyone :) | 13:45 |
NobodyCam | morning | 13:45 |
*** alexpilotti has quit IRC | 13:45 | |
lucasagomes | jroll, hi there | 13:45 |
*** jerrygb has quit IRC | 13:45 | |
BadCub | morning jroll | 13:46 |
*** puranamr has quit IRC | 13:48 | |
*** Haomeng has joined #openstack-ironic | 13:52 | |
lucasagomes | folks interested in the nova bits, if you have some time please take a look at https://review.openstack.org/#/c/221848/ and https://review.openstack.org/#/c/221057/ (I want feedback about the approach) | 13:52 |
jroll | dtantsur: +A on inspector agent thing with comments | 13:54 |
jroll | lucasagomes: you might be interested in this comment https://review.openstack.org/#/c/205587/18..19/ironic_python_agent/utils.py | 13:54 |
jroll | (my reply, that is) | 13:54 |
*** Haomeng|2 has quit IRC | 13:55 | |
*** alexpilotti has joined #openstack-ironic | 13:55 | |
*** shoutm has quit IRC | 13:55 | |
lucasagomes | jroll, right | 13:55 |
lucasagomes | yeah the sort() there might do it | 13:55 |
dtantsur | jroll, \o/ | 13:56 |
* dtantsur is dancing | 13:56 | |
jroll | hehe | 13:56 |
jroll | lucasagomes: it keeps it consistent, at least, as long as that size is unique | 13:56 |
lucasagomes | yeah I may have missed that bits sorting the list there | 13:56 |
lucasagomes | fair enuff! | 13:57 |
dtantsur | FWIW I'm replicating the same logic in the inspector support for root device hints | 13:57 |
*** alexpilotti has quit IRC | 13:59 | |
*** harshs has joined #openstack-ironic | 14:00 | |
rloo | dtantsur: wrt ramesh's patch 198238, he initially coded it to work with cleaning and zapping, but after discussing with you, he changed to only zapping. | 14:04 |
rloo | dtantsur: do you recall the reason for not allowing it in cleaning? | 14:04 |
rloo | dtantsur: that's the in-band RAID patch | 14:04 |
*** bigjools has quit IRC | 14:05 | |
dtantsur | rloo, yep. 1. it won't work with cleaning, as target config is overriden in the end of cleaning; 2. it's unclear how to handle difference between zap and cleaning (i.e. whether to fail if target config is none) | 14:06 |
dtantsur | rloo, so to simplify things a bit I suggested to add cleaning in a separate patch | 14:06 |
jroll | lucasagomes: nova microversion patch now has a few comments, the other is in merge conflict so I'll just check out the approach | 14:07 |
*** shoutm has joined #openstack-ironic | 14:07 | |
rloo | dtantsur: ok, so all related to the target config. wrt 1. i think we can leave the target config as-is after cleaning. wrt 2. yeah, need to think about it. | 14:07 |
*** bigjools has joined #openstack-ironic | 14:07 | |
*** bigjools has quit IRC | 14:07 | |
*** bigjools has joined #openstack-ironic | 14:07 | |
rloo | dtantsur: am asking cuz it means there are code changes in the patch that don't need to be there any more. hate to ask ramesh to undo them. | 14:07 |
*** alexpilotti has joined #openstack-ironic | 14:08 | |
dtantsur | rloo, btw ramesh is out till Monday, so we might have to update the patch in the meanwhile... is it possible you just drop whatever you don't like? | 14:11 |
rloo | dtantsur: oh, thought he'd be around for a bit today. | 14:11 |
jroll | lucasagomes: actually, left some comments on the second | 14:12 |
dtantsur | rloo, he was :) | 14:12 |
lucasagomes | jroll, cool, will take a look | 14:12 |
lucasagomes | thanks much | 14:12 |
jroll | lucasagomes: and thank you for the code! | 14:12 |
rloo | dtantsur: ha ha. we can also wait til monday, we have til next Fri to get that feature in. | 14:12 |
rloo | dtantsur: but yeah, i can take the bits out if we're sure we don't want it in cleaning steps. | 14:12 |
rloo | dtantsur: my concern is that we/I take it out and someone says wait, it should be in cleaning. | 14:13 |
rloo | dtantsur: i can do those bits in a separate patch though, it is code cleanup. | 14:13 |
*** getvasanth has joined #openstack-ironic | 14:13 | |
getvasanth | sinval: here you go :) http://getvasanth.blogspot.in/2015/09/getting-start-with-ironic.html | 14:14 |
lucasagomes | jroll, yeah, the only reason why I let the default 1 is because that was the default before | 14:14 |
lucasagomes | perhaps we can make it work with both, if it's 1 or None just use the default in the library | 14:14 |
getvasanth | lucasagomes: hi | 14:15 |
jroll | lucasagomes: yeah, I think it's safe to change, None would be backwards compat | 14:15 |
lucasagomes | but I found that to be more confusing than what it is right now | 14:15 |
lucasagomes | getvasanth, hi there | 14:15 |
lucasagomes | jroll, fair enuff | 14:15 |
*** lintan_ has quit IRC | 14:15 | |
rloo | lucasagomes: wrt ramesh's RAID patch 198238, want to be sure -- are you OK with his post-step-hook and just want it documented, or are you against/unsure? I am fine with it and not even sure it needs a spec but since you think it does...? | 14:15 |
*** jerrygb has joined #openstack-ironic | 14:15 | |
*** lintan_ has joined #openstack-ironic | 14:15 | |
jroll | lucasagomes: I think we probably want to set to None, deprecation warning on 1 since it's the old default, and have 1 == default client version | 14:16 |
openstackgerrit | Jarrod Johnson proposed stackforge/pyghmi: Implement NTP support for Lenovo Thinkserver https://review.openstack.org/221448 | 14:16 |
getvasanth | lucasagomes: my ironic setup doc http://getvasanth.blogspot.in/2015/09/getting-start-with-ironic.html :) | 14:16 |
lucasagomes | rloo, I'm fine with it. But we should have it documented somewhere | 14:16 |
lucasagomes | rloo, I mean I think the spec would be good because it's actually introducing a new interface (and a new feature) to clean steps that hasn't been documented/discussed anywhere | 14:16 |
rloo | lucasagomes: documented for developers right? although it is specific to the agent. | 14:16 |
lucasagomes | rloo, right, but people may have some opnion about the approach as well | 14:17 |
rloo | lucasagomes: but it isn't a global feature. it is only specific to the agent. | 14:17 |
dtantsur | rloo, I think we'll want it in cleaning eventually, but it's not that high a priority as getting raid during zapping IMO | 14:17 |
lucasagomes | so I don't think putting on a spec is actually bad | 14:17 |
lucasagomes | rloo, it's for IPA right? cleaning in general | 14:17 |
rloo | lucasagomes: only if you assume that cleaning is only for IPA | 14:17 |
lucasagomes | there's another spec to introduce cleaning for iscsi methodology | 14:17 |
lucasagomes | so it will be global | 14:17 |
dtantsur | iscsi is also IPA :) | 14:17 |
lucasagomes | yup | 14:18 |
lucasagomes | so basically it's a feature that will affect all drivers | 14:18 |
rloo | lucasagomes: it could be global, but not the way it is implemented right now. (the hook stuff has to be changed to be more general) | 14:18 |
* jroll eagerly awaits a CleanInterface :/ | 14:18 | |
lucasagomes | rloo, yeah, that's why it perhaps makes sense to be discussed before | 14:18 |
lucasagomes | that's not part of the spec proposed | 14:18 |
rloo | lucasagomes: let me ask you this. if he didn't implement it with that decorator, but hard-coded something in the agent, would you have asked him to generalize/add the hook/decorator? | 14:19 |
lucasagomes | in the agent clean step? Within the ramdisk? | 14:19 |
lucasagomes | that's out of Ironic I wouldn't actually see it | 14:20 |
rloo | lucasagomes: no, the hook is in the conductor code. | 14:20 |
rloo | lucasagomes: https://review.openstack.org/#/c/198238/24/ironic/drivers/modules/agent_base_vendor.py | 14:20 |
rloo | lucasagomes: line 271 | 14:21 |
lucasagomes | rloo, yeah i probably would ask to clarify it them | 14:21 |
lucasagomes | then* | 14:21 |
lucasagomes | rloo, I talked to ramesh on IRC btw before commenting on the patch | 14:21 |
rloo | lucasagomes: a non-general way would be if step was create_config, do post-create_config, if step was delete_config, do post-delete-config | 14:21 |
rloo | lucasagomes: I just don't think that decorator is ready to be used/generalized | 14:22 |
lucasagomes | rloo, we are adding something to the base interface that is specific for a given driver | 14:22 |
*** marzif has joined #openstack-ironic | 14:23 | |
lucasagomes | it's not right | 14:23 |
*** vishwanathj has joined #openstack-ironic | 14:23 | |
lucasagomes | the base interface is shared across other drivers as well, it has to be generic | 14:23 |
rloo | lucasagomes: it is being added to agent_base_vendor. | 14:23 |
rloo | lucasagomes: you are calling that the base interface? | 14:23 |
openstackgerrit | Jarrod Johnson proposed stackforge/pyghmi: Implement NTP support for Lenovo Thinkserver https://review.openstack.org/221448 | 14:23 |
lucasagomes | rloo, that's interface is used for all drivers, including pxe_ | 14:23 |
rloo | lucasagomes: i'm inclined then to not have the hook/decorator stuff yet. | 14:24 |
*** vishwanathj has quit IRC | 14:24 | |
lucasagomes | rloo, https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L746 | 14:24 |
lucasagomes | rloo, right, yeah we can not have it | 14:25 |
*** degorenko has quit IRC | 14:26 | |
lucasagomes | tho I don't think the idea is bad, having pos/pre hook scripts is fine | 14:26 |
rloo | lucasagomes: i like the idea of the hook/decorator. i just don't think we're ready to know how it might be used globally | 14:27 |
rloo | lucasagomes: and i'd rather not have it for these two cases and add it later with more knowledge, than have it and maybe have to deprecate it for something else later. | 14:27 |
lucasagomes | rloo, yeah that makes sense | 14:28 |
lucasagomes | because if we merge it people may start using those decorators | 14:28 |
*** alexpilotti has quit IRC | 14:28 | |
rloo | lucasagomes: exactly. unless we make it internal to that file/class I guess. | 14:28 |
*** harshs_ has joined #openstack-ironic | 14:28 | |
lucasagomes | right | 14:28 |
*** harshs has quit IRC | 14:28 | |
*** harshs_ is now known as harshs | 14:28 | |
*** alexpilotti has joined #openstack-ironic | 14:30 | |
lucasagomes | rloo, mind commenting on the patch about it? | 14:30 |
*** mgoddard1 has joined #openstack-ironic | 14:30 | |
*** marzif has quit IRC | 14:30 | |
rloo | lucasagomes: @##$, agent is the one that has the RAID interface; agent_base_vendor needs a way to know if there is any post-step-method to call | 14:31 |
rloo | lucasagomes: so yeah, you're right, the decorator/etc needs to be described. | 14:31 |
*** marzif has joined #openstack-ironic | 14:31 | |
*** vgridnev has quit IRC | 14:31 | |
*** mgoddard has quit IRC | 14:32 | |
lucasagomes | rloo, right, yeah. And in fairness, I don't think the decorator is controversial | 14:32 |
lucasagomes | but we also can't sneak in something like that as part of that patch | 14:32 |
lucasagomes | it seems like a feature own it's own | 14:32 |
dtantsur | let's split the patch then.. | 14:33 |
rloo | lucasagomes: it isn't that the decorator is controversial but that in the future we might move it to base instead of in agent_base_vendor, if we want to generalize it so it isn't IPA specific | 14:34 |
lucasagomes | right | 14:34 |
lucasagomes | yeah I think I commented about having it in the base.py | 14:34 |
lucasagomes | where the @clean_step one is | 14:34 |
lucasagomes | dtantsur, yeah that works too | 14:34 |
rloo | lucasagomes, dtantsur: i think we need to split the patch into three: 1. cleanup code wrt deploy_utils.change_clean_step_priority; 2. hook decorator; 3. agent.RAID | 14:35 |
dtantsur | lgtm | 14:35 |
rloo | lucasagomes: but we can't move it to base because right now, only the agent_base_vendor can deal with those hooks and it passes the command-status to the hook method. which isn't general. | 14:36 |
*** lazy_prince has quit IRC | 14:36 | |
rloo | lucasagomes: but we can deal with deprecating/whatever that later if we need to. | 14:36 |
*** lazy_prince has joined #openstack-ironic | 14:36 | |
lucasagomes | right | 14:37 |
*** alexpilotti has quit IRC | 14:37 | |
lucasagomes | yeah it's odd, I can see this being generic if implemented as part of the _do_next_clean_step() in manager.py | 14:38 |
lucasagomes | maybe... I have to think more about it | 14:38 |
dtantsur | ifarkas, could you review https://review.openstack.org/#/c/220939/ ? a lot of patches start to depend on it.. | 14:38 |
ifarkas | dtantsur, will do | 14:39 |
*** alexpilotti has joined #openstack-ironic | 14:41 | |
*** romcheg1 has quit IRC | 14:42 | |
*** shoutm has quit IRC | 14:42 | |
rloo | lucasagomes: to some extent, a post-clean-step method could be implemented/hack'd as a clean-step that follows the previous clean step. | 14:45 |
*** alexpilotti has quit IRC | 14:45 | |
*** mgoddard1 has quit IRC | 14:46 | |
*** Marga_ has quit IRC | 14:47 | |
*** mgoddard has joined #openstack-ironic | 14:47 | |
openstackgerrit | Merged openstack/ironic-python-agent: Add support for inspection using ironic-inspector https://review.openstack.org/205587 | 14:47 |
trown | woot | 14:48 |
*** saripurigopi has joined #openstack-ironic | 14:49 | |
trown | nice one dtantsur ^ | 14:49 |
dtantsur | yeah, that's awesome | 14:49 |
*** degorenko has joined #openstack-ironic | 14:53 | |
*** alexpilotti has joined #openstack-ironic | 14:53 | |
*** vgridnev has joined #openstack-ironic | 14:53 | |
*** alexpilotti has quit IRC | 14:54 | |
*** e0ne has quit IRC | 14:55 | |
*** getvasanth has quit IRC | 14:57 | |
*** marzif has quit IRC | 14:59 | |
*** Nisha has joined #openstack-ironic | 14:59 | |
lucasagomes | jroll, https://review.openstack.org/#/c/221057 lemme know if my answers makes sense | 15:00 |
lucasagomes | rloo, true (sorry missed this ping previously) | 15:01 |
*** Nisha has quit IRC | 15:01 | |
*** Nisha has joined #openstack-ironic | 15:01 | |
rloo | lucasagomes: no worries. I think with all the other stuff on our plate, we should just leave ramesh's hook stuff as-is until we have more data/info on how it might be used outside of agent. | 15:02 |
lucasagomes | right yeah we are short on time indeed :-( | 15:02 |
lucasagomes | rloo, this *has* to merge on the next release? | 15:02 |
*** vishwanathj has joined #openstack-ironic | 15:03 | |
*** e0ne has joined #openstack-ironic | 15:03 | |
jroll | lucasagomes: cool, thanks :) replied again | 15:03 |
rloo | lucasagomes: well, we'd like this feature in for L* | 15:03 |
lucasagomes | cause we are now flexible about release dates, if not in the next, we can tag another release right after this gets merged own it's own time | 15:03 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Import option before using it https://review.openstack.org/222233 | 15:03 |
dtantsur | sambetts, ifarkas, may I also ask you to fast-track this one-liner ^^ | 15:03 |
rloo | lucasagomes: i know we have this new release thingy, but honestly, i'm not convinced about it and i think it is important to get some features in for our release that corresponds to Liberty | 15:04 |
*** vgridnev has quit IRC | 15:04 | |
*** Marga_ has joined #openstack-ironic | 15:04 | |
lucasagomes | rloo, yeah | 15:04 |
jroll | regardless of how we release, some deployers will only ever use the integrated release | 15:04 |
rloo | lucasagomes: of course, we still need to get zapping in for raid to work | 15:04 |
ifarkas | dtantsur, sure | 15:05 |
lucasagomes | rloo, true | 15:05 |
rloo | lucasagomes: i think it is do-able to get the hi priority features in for Liberty, esp since we've deferred the neutron stuff to M | 15:05 |
dtantsur | yeah, I would not say if completely avoided pre-release rush :( | 15:05 |
dtantsur | s/if/we/ | 15:05 |
jroll | :| | 15:07 |
jroll | though, I think it's us rushing these things | 15:07 |
jroll | rather than a bunch of people trying to slam stuff in | 15:07 |
jroll | these are all things we want to ship | 15:07 |
lucasagomes | jroll, re-replied re latest | 15:07 |
ifarkas | dtantsur, re: 222233, why do you need to use import_opt? isn't it available on CONF without it? | 15:08 |
jroll | and honestly, zapping/raid/networking sat for half of the cycle while we went back and forth on the spec, and I think that's a large part of the rush :( | 15:08 |
sambetts | dtantsur, ifarkas: I was just writing the same thing, I don't get it | 15:08 |
rloo | jroll: I suspect there are/would be a bunch of people trying to slam stuff in if they could | 15:08 |
jroll | rloo: not sure what you mean by "if they could" | 15:08 |
jroll | but I think I maybe agree? :) | 15:08 |
rloo | jroll: heh. i mean, if they felt like they could slam stuff in, they would. but some of us are blocking them. | 15:09 |
jroll | yeah, maybe | 15:09 |
rloo | jroll: and yeah, the delay in specs is a problem. | 15:09 |
jroll | I don't feel like I've seen as much of it this cycle | 15:09 |
lucasagomes | yeah, it's odd right now because for Ironic project we don't have specific dates to release (so no rush) but for OpenStack it does | 15:10 |
rloo | jroll: i think/hope it is because they know from previous cycles, how our priorities work. | 15:10 |
jroll | so, I started the summit brainstorming etherpad, the only session I put on it so far is a retro on this cycle | 15:10 |
lucasagomes | it's like having to deal with both worlds | 15:10 |
*** alexpilotti has joined #openstack-ironic | 15:10 | |
jroll | I think a retro is something we should do every cycle | 15:10 |
jroll | https://etherpad.openstack.org/p/mitaka-ironic-design-summit-ideas btw | 15:10 |
rloo | jroll: ++ for retro/lesson learned/how we can do better/etc | 15:10 |
lucasagomes | IMHO what I thought re integrated released was that we would pick the last release of Ironic and say that's the integrated release | 15:10 |
lucasagomes | but we wouldn't rush stuff to get in the integrated release, cause it's not important to the project itself | 15:11 |
* lucasagomes may be wrong | 15:11 | |
rloo | dtantsur, lucasagomes: I guess I volunteer to split up ramesh's RAID patch 198238 | 15:11 |
lucasagomes | rloo, ++ (-: | 15:12 |
jroll | lucasagomes: yeah, in general that's my goal... however knowing that some people will only ever run the stable branch | 15:12 |
jroll | I still want to ship some major features with it | 15:12 |
lucasagomes | sure, I get that | 15:12 |
jroll | zapping/raid/networking are kind of our top asks for a while now | 15:12 |
rloo | lucasagomes: and it still means we have to get stuff we want into other (non-ironic) projects for Liberty. | 15:13 |
*** garthb has joined #openstack-ironic | 15:13 | |
lucasagomes | true | 15:13 |
jroll | I'm fine if none of them make it this cycle, it just bums me out a bit | 15:13 |
rloo | jroll: we should get zapping in. i'll be annoyed if we don't. | 15:13 |
jroll | rloo: indeed | 15:13 |
rloo | jroll: and i think RAID is almost there | 15:14 |
jroll | I agree | 15:14 |
jroll | I wonder if there's a way to test that in the gate, hm | 15:14 |
*** jistr is now known as jistr|mtg | 15:14 | |
*** ifarkas is now known as ifarkas|afk | 15:14 | |
lucasagomes | raid? | 15:15 |
lucasagomes | 3rd part CIs only for now :-( cause we currently do not test even IPMI | 15:15 |
jroll | yeah, raid | 15:16 |
*** alexpilotti has quit IRC | 15:17 | |
dtantsur | ifarkas|afk, sambetts, well, no, if 'conf' module does not get imported earlier | 15:18 |
dtantsur | that's the problem when tests are run in a random order | 15:19 |
lucasagomes | dtantsur, https://bugs.launchpad.net/ironic/+bug/1494367 | 15:21 |
openstack | Launchpad bug 1494367 in Ironic "IPA: missing dmidecode binary" [Medium,New] - Assigned to Lucas Alvares Gomes (lucasagomes) | 15:21 |
lucasagomes | dtantsur, we should isntall dmidecode by default right? | 15:21 |
dtantsur | lucasagomes, oh yeah, I totally forgot about coreos builder >_< yeah, just add it and ipmitool to the docker file | 15:22 |
lucasagomes | (-: no bothers... adding it | 15:22 |
jroll | I thought dmidecode was already there :/ | 15:23 |
jroll | good catch though | 15:23 |
lucasagomes | jroll, yeah, perhaps not installed by default on debian | 15:23 |
jroll | true | 15:23 |
*** vgridnev has joined #openstack-ironic | 15:24 | |
*** alexpilotti has joined #openstack-ironic | 15:25 | |
*** jistr|mtg is now known as jistr | 15:26 | |
*** ukalifon has quit IRC | 15:27 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Install "dmidecode" by default https://review.openstack.org/222247 | 15:28 |
lucasagomes | boom | 15:28 |
openstackgerrit | Zhenguo Niu proposed openstack/python-ironicclient: Remove unneeded param['detail'] setting https://review.openstack.org/222249 | 15:29 |
jlvillal | NobodyCam, Just curious, have you or anyone else investigated Trello (https://trello.com/)? I was thinking maybe it could help organize what we are working on and what should be reviewed. | 15:30 |
jlvillal | NobodyCam, I'm in a conference call where some Swift people are using it for their work. It sounded interesting, but I don't know a lot about it. | 15:30 |
NobodyCam | jlvillal: lol.. yes.. I just got a email this mornign that I was removed from the tripleo trillo board | 15:32 |
NobodyCam | its okay | 15:32 |
jlvillal | NobodyCam, Ah cool. You have used it before. So nothing amazing then, I take it. Thanks :) | 15:32 |
NobodyCam | yep just a basic task board | 15:33 |
*** alexpilotti has quit IRC | 15:35 | |
*** alexpilotti has joined #openstack-ironic | 15:35 | |
*** saripurigopi has quit IRC | 15:35 | |
*** alexpilotti has quit IRC | 15:36 | |
*** lazy_prince has quit IRC | 15:37 | |
*** Nisha_away has joined #openstack-ironic | 15:38 | |
*** Nisha has quit IRC | 15:38 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Install "dmidecode" and "ipmitool" by default https://review.openstack.org/222247 | 15:38 |
jroll | jlvillal: I've thought about the same, basically ditching our google doc in favor of trello | 15:38 |
lucasagomes | dtantsur, ^ updated | 15:38 |
* lucasagomes updates the bug as well | 15:38 | |
jroll | trello does need folks to stay on top of keeping it up to date though | 15:38 |
jroll | thanks lucasagomes | 15:39 |
lucasagomes | jlvillal, jroll as a datapoint at the very beggining of Ironic we used trello | 15:39 |
lucasagomes | jroll, jlvillal https://trello.com/b/piX6M1KA/ironic | 15:40 |
lucasagomes | heh | 15:40 |
jroll | :P | 15:40 |
* lucasagomes nova driver was being coded at the time | 15:40 | |
lucasagomes | and we had no python client | 15:40 |
lucasagomes | good times | 15:40 |
jroll | some of those still aren't done :( | 15:40 |
jroll | a LOT of those still aren't done | 15:40 |
*** saripurigopi has joined #openstack-ironic | 15:40 | |
lucasagomes | yeah | 15:40 |
jroll | some day we'll move super fast | 15:41 |
jroll | (mostly kidding, we're doing pretty well) | 15:41 |
lucasagomes | well up to the next cycle all we aimed mostly was to be feature compatible with nova baremetal | 15:41 |
lucasagomes | so it's expected that we didn't complete the extra stuff | 15:41 |
lucasagomes | that wasn't the focus at all at the time | 15:41 |
lucasagomes | well Ironic didn't work at that time as well | 15:41 |
*** vgridnev has quit IRC | 15:41 | |
jroll | yeah, totally | 15:42 |
*** harshs has quit IRC | 15:43 | |
lucasagomes | up the the previous cycle* | 15:43 |
*** trown is now known as trown|lunch | 15:44 | |
*** ijw_ has joined #openstack-ironic | 15:46 | |
*** degorenko has quit IRC | 15:46 | |
*** Nisha_away has quit IRC | 15:53 | |
*** e0ne has quit IRC | 15:56 | |
*** alexpilotti has joined #openstack-ironic | 15:57 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Add instructions how to try IPA as a ramdisk https://review.openstack.org/222260 | 15:58 |
*** mgoddard has quit IRC | 15:59 | |
dtantsur | trown|lunch, ^^ | 15:59 |
*** mgoddard has joined #openstack-ironic | 16:00 | |
*** alexpilotti has quit IRC | 16:01 | |
*** e0ne has joined #openstack-ironic | 16:02 | |
*** getvasanth has joined #openstack-ironic | 16:02 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Import option before using it https://review.openstack.org/222233 | 16:02 |
*** smoriya has joined #openstack-ironic | 16:03 | |
dtantsur | see you tomorrow | 16:04 |
*** dtantsur is now known as dtantsur|afk | 16:04 | |
openstackgerrit | Merged openstack/ironic-inspector: Move update functions to NodeInfo object https://review.openstack.org/220939 | 16:04 |
*** alexpilotti has joined #openstack-ironic | 16:07 | |
*** degorenko has joined #openstack-ironic | 16:09 | |
jlvillal | jroll, lucasagomes Thanks for the trello info. | 16:10 |
lucasagomes | dtantsur|afk, see ya, g'night | 16:10 |
openstackgerrit | Ruby Loo proposed openstack/ironic: Refactor deploy_utils methods https://review.openstack.org/222264 | 16:10 |
lucasagomes | jroll, I'm a bit divided on that None as default for the api_version. Isn't it more confusing to see "if set to None or 1 the default version from the ironic library will be used" ? | 16:11 |
lucasagomes | cause we need to keep that 1 for backward compat | 16:11 |
lucasagomes | or not? hmmmmm | 16:11 |
* lucasagomes end of the day, can't think straight | 16:12 | |
jroll | lucasagomes: meh, I'm hoping we can deprecate '1' | 16:18 |
jroll | some people might have the default (1) in their config file | 16:19 |
jroll | so if we say 1.0 is invalid it'll break them | 16:19 |
lucasagomes | yeah, we should support both at the beginning | 16:20 |
openstackgerrit | Zhenguo Niu proposed openstack/python-ironicclient: Add more filters for chassis node-list https://review.openstack.org/222280 | 16:20 |
*** Nisha has joined #openstack-ironic | 16:20 | |
lucasagomes | jroll, to add something in the thinking here, even the python-ironicclient uses 1 as the "default" | 16:20 |
jroll | lucasagomes: might be worth asking the nova folks as well, they may have done something like this | 16:20 |
lucasagomes | for --ironic-api-version | 16:21 |
lucasagomes | :-/ | 16:21 |
jroll | orly | 16:21 |
jroll | :| | 16:21 |
lucasagomes | https://github.com/openstack/python-ironicclient/blob/3f4671a0b7eb5c300291c2e92082d16b96e6316c/ironicclient/shell.py#L202 | 16:21 |
*** tsekiyama has joined #openstack-ironic | 16:25 | |
lucasagomes | jroll, yeah ++ to ask them | 16:25 |
zhenguo | lucasagomes: can you please give some suggestions here https://review.openstack.org/#/c/215254/ when you have time? | 16:28 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Refactor iscsi_ilo driver to use new boot interface https://review.openstack.org/216538 | 16:29 |
*** praneshp has joined #openstack-ironic | 16:30 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Refactor agent_ilo driver to use new boot interface https://review.openstack.org/217102 | 16:31 |
lucasagomes | zhenguo, hi yeah | 16:31 |
* lucasagomes added to his todo | 16:31 | |
zhenguo | lucasagomes: thanks :) | 16:32 |
*** ijw_ has quit IRC | 16:33 | |
*** baoli_ has quit IRC | 16:33 | |
*** alexpilotti has quit IRC | 16:35 | |
*** alexpilotti has joined #openstack-ironic | 16:35 | |
*** romainh has left #openstack-ironic | 16:37 | |
*** jistr has quit IRC | 16:40 | |
*** bradjones|away is now known as bradjones | 16:42 | |
*** achanda has joined #openstack-ironic | 16:42 | |
openstackgerrit | Ruby Loo proposed openstack/ironic: Agent supports post-clean-step operations https://review.openstack.org/222287 | 16:42 |
lucasagomes | zhenguo, wow that's a though one | 16:43 |
lucasagomes | zhenguo, even for the CoreOS image that we provide of IPA it needs at least 1G of ram | 16:45 |
lucasagomes | J's correct me if I'm wrong here ^ | 16:45 |
lucasagomes | zhenguo, the DIB one needs a bit more 1.5 G the last time I checked | 16:45 |
zhenguo | lucasagomes: yeah, I'm not sure which default value should be here | 16:45 |
lucasagomes | perhaps setting it to 1G since the CoreOS are the images that we distribute seems more realistic | 16:46 |
lucasagomes | zhenguo, yeah me neither | 16:46 |
* lucasagomes thinking | 16:46 | |
zhenguo | lucasagomes: but I think Yuriy's point is right, we just wan't to check too big image | 16:46 |
zhenguo | lucasgomes: can't guarantee the depoy not fail | 16:47 |
*** dims_ has joined #openstack-ironic | 16:48 | |
lucasagomes | yeah | 16:48 |
lucasagomes | we can't | 16:48 |
zhenguo | and this check in valudate method, so we cant get real memory use from agent | 16:49 |
zhenguo | s/valudate/validate | 16:49 |
*** dims has quit IRC | 16:51 | |
*** lsmola has quit IRC | 16:53 | |
lucasagomes | zhenguo, yeah, I commented there | 16:53 |
openstackgerrit | Ruby Loo proposed openstack/ironic: Add support for inband raid configuration agent ramdisk https://review.openstack.org/198238 | 16:53 |
lucasagomes | zhenguo, fyi the VMs in gate has 1G of ram to test IPA | 16:53 |
lucasagomes | https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/devstack-gate.yaml#L719-L720 | 16:53 |
*** e0ne has quit IRC | 16:54 | |
*** ifarkas|afk has quit IRC | 16:54 | |
*** saripurigopi has quit IRC | 16:55 | |
lucasagomes | zhenguo, or even, maybe we should have a way to disable that check (and that's the default) | 16:55 |
lucasagomes | like by default it's set to -1 which means that the check won't be performed. We can document how operators can enable that check if they wish to do so | 16:56 |
*** jcoufal has quit IRC | 16:56 | |
* lucasagomes can't think straight,it's late | 16:57 | |
*** praneshp_ has joined #openstack-ironic | 16:57 | |
zhenguo | lucasagomes: IMO, instead of disable the check, user can set the value to 0, | 16:58 |
*** puranamr has joined #openstack-ironic | 16:59 | |
lucasagomes | right, yeah. perhaps that should be the default ? | 16:59 |
*** praneshp has quit IRC | 16:59 | |
*** praneshp_ is now known as praneshp | 16:59 | |
*** ijw_ has joined #openstack-ironic | 16:59 | |
zhenguo | lucasagomes: yeah, the value should be minimal | 17:00 |
lucasagomes | right, and we can add in the documentation how one can work with that configuration option to have a pre-check before the deployment about memory constraints | 17:01 |
rloo | Poopoo12. | 17:01 |
rloo | whoops | 17:02 |
rloo | :D | 17:02 |
lucasagomes | lol | 17:02 |
zhenguo | lucasagomes: yeah, agree. | 17:02 |
lucasagomes | zhenguo, cool | 17:02 |
*** Marga_ has quit IRC | 17:03 | |
rloo | lucasagomes: i'll take a look at the nova bits in a bit; going to grab some food now. | 17:03 |
lucasagomes | you can ask more people about it as well, it's hard to set default values for stuff | 17:03 |
lucasagomes | rloo, thanks | 17:03 |
lucasagomes | and I will call it a day here | 17:03 |
*** Marga_ has joined #openstack-ironic | 17:03 | |
lucasagomes | I'm in the office, I have to grab the train back home still | 17:03 |
*** baoli has joined #openstack-ironic | 17:04 | |
*** blakec has joined #openstack-ironic | 17:04 | |
zhenguo | lucasagomes: yeah, maybe rloo can give some suggestions https://review.openstack.org/#/c/215254/ | 17:04 |
lucasagomes | ok | 17:05 |
lucasagomes | see y'all! Have a great evening | 17:05 |
*** derekh has quit IRC | 17:06 | |
NobodyCam | have a good night lucasagomes :) | 17:06 |
lucasagomes | you too bye bye | 17:07 |
*** lucasagomes has quit IRC | 17:07 | |
*** baoli_ has joined #openstack-ironic | 17:07 | |
*** zhenguo has quit IRC | 17:07 | |
*** baoli has quit IRC | 17:08 | |
*** trown|lunch is now known as trown | 17:15 | |
*** athomas has quit IRC | 17:25 | |
sambetts | Night all o/ | 17:25 |
*** alexpilotti has quit IRC | 17:27 | |
*** puranamr has quit IRC | 17:28 | |
*** alexpilotti has joined #openstack-ironic | 17:28 | |
*** achanda has quit IRC | 17:31 | |
*** achanda has joined #openstack-ironic | 17:32 | |
NobodyCam | night sambetts | 17:43 |
*** smoriya has quit IRC | 17:47 | |
*** alexpilotti has quit IRC | 17:51 | |
*** Marga_ has quit IRC | 17:54 | |
*** Marga_ has joined #openstack-ironic | 17:54 | |
*** getvasanth has quit IRC | 17:55 | |
jlvillal | JoshNang: I just noticed your comment last night on the Serializable patch I did. | 17:58 |
jlvillal | :( | 17:58 |
devananda | <cough> <sneeze> g'morning, ya'll | 17:59 |
NobodyCam | good morning devananda | 18:00 |
*** karimb has quit IRC | 18:00 | |
*** pelix has quit IRC | 18:01 | |
*** penick has joined #openstack-ironic | 18:03 | |
jlvillal | Get better devananda | 18:03 |
devananda | moving really slow today so this cold doesn't get worse | 18:03 |
NobodyCam | uggh | 18:04 |
NobodyCam | :( | 18:04 |
* NobodyCam hopes devananda feels better | 18:04 | |
JoshNang | jlvillal: :( but i do think it's important. if two objects serialize to the same output, they should be considered equal there | 18:06 |
JoshNang | otherwise things like {'a':'b'} == OrderedDict(a='b') would be false | 18:06 |
jlvillal | JoshNang: Okay. I will disagree and commit. If they are different classes I think they should be different. | 18:07 |
jlvillal | JoshNang: I will respin. | 18:07 |
*** puranamr has joined #openstack-ironic | 18:08 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Add some comparison operators to Serializable class https://review.openstack.org/215854 | 18:11 |
jlvillal | JoshNang: ^^^ :) | 18:12 |
JoshNang | thanks :) | 18:12 |
jlvillal | JoshNang: Thanks for the review! | 18:12 |
JoshNang | \\ | 18:13 |
*** e0ne has joined #openstack-ironic | 18:13 | |
JoshNang | whoops, puppy attacked the keyboard | 18:14 |
* jlvillal does not understand that emoticon... | 18:14 | |
JoshNang | :P | 18:14 |
*** Marga_ has quit IRC | 18:14 | |
*** Marga_ has joined #openstack-ironic | 18:14 | |
jlvillal | Would it be a correct assumption that the ironic-conductor must have read/write access to the tftp_root directory? Assuming that PXE is being used. | 18:15 |
* jlvillal contemplates updating docs a little bit. | 18:15 | |
jroll | jlvillal: yes, it would | 18:16 |
jroll | ironic puts things there | 18:16 |
jlvillal | jroll: I thought so. Thanks. | 18:16 |
*** blakec has quit IRC | 18:17 | |
*** e0ne has quit IRC | 18:17 | |
*** garthb has quit IRC | 18:21 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic: Update help string on tftp_root option https://review.openstack.org/222313 | 18:23 |
*** Nisha has quit IRC | 18:23 | |
*** Nisha has joined #openstack-ironic | 18:24 | |
*** garthb has joined #openstack-ironic | 18:25 | |
*** Nisha_away has joined #openstack-ironic | 18:30 | |
*** Nisha has quit IRC | 18:30 | |
*** Nisha_away has quit IRC | 18:36 | |
*** Nisha has joined #openstack-ironic | 18:36 | |
*** saripurigopi has joined #openstack-ironic | 18:38 | |
*** harshs has joined #openstack-ironic | 18:45 | |
*** Nisha has quit IRC | 18:47 | |
*** puranamr has quit IRC | 18:51 | |
*** saripurigopi has quit IRC | 18:52 | |
*** nicodemos has quit IRC | 19:00 | |
*** penick_ has joined #openstack-ironic | 19:00 | |
*** derekh has joined #openstack-ironic | 19:00 | |
*** penick has quit IRC | 19:01 | |
*** penick_ is now known as penick | 19:01 | |
*** dims_ has quit IRC | 19:11 | |
*** dims has joined #openstack-ironic | 19:11 | |
*** achanda has quit IRC | 19:18 | |
openstackgerrit | Merged stackforge/pyghmi: Implement NTP support for Lenovo Thinkserver https://review.openstack.org/221448 | 19:18 |
sinval | getvasanth: Thank you very much o/ | 19:19 |
*** puranamr has joined #openstack-ironic | 19:19 | |
*** achanda has joined #openstack-ironic | 19:20 | |
*** Nisha has joined #openstack-ironic | 19:21 | |
*** achanda has quit IRC | 19:22 | |
*** achanda_ has joined #openstack-ironic | 19:22 | |
*** puranamr has quit IRC | 19:23 | |
*** Sukhdev has joined #openstack-ironic | 19:23 | |
*** penick has quit IRC | 19:29 | |
*** derekh has quit IRC | 19:29 | |
*** puranamr has joined #openstack-ironic | 19:31 | |
*** ijw_ has quit IRC | 19:49 | |
openstackgerrit | Merged openstack/ironic-python-agent: Install "dmidecode" and "ipmitool" by default https://review.openstack.org/222247 | 19:55 |
*** sdake has joined #openstack-ironic | 19:55 | |
*** achanda_ has quit IRC | 19:56 | |
*** jerrygb has quit IRC | 19:58 | |
*** sdake_ has joined #openstack-ironic | 20:02 | |
*** amotoki has quit IRC | 20:03 | |
*** sdake has quit IRC | 20:05 | |
*** Nisha_away has joined #openstack-ironic | 20:07 | |
*** Nisha has quit IRC | 20:07 | |
*** Nisha_brb has joined #openstack-ironic | 20:11 | |
*** Nisha_away has quit IRC | 20:11 | |
*** ijw_ has joined #openstack-ironic | 20:16 | |
*** Nisha_brb has quit IRC | 20:16 | |
*** Nisha has joined #openstack-ironic | 20:17 | |
*** Nisha_away has joined #openstack-ironic | 20:18 | |
*** Nisha has quit IRC | 20:18 | |
*** Nisha_brb has joined #openstack-ironic | 20:23 | |
*** Nisha_away has quit IRC | 20:23 | |
*** jerrygb has joined #openstack-ironic | 20:30 | |
*** Nisha_away has joined #openstack-ironic | 20:32 | |
*** Nisha_brb has quit IRC | 20:32 | |
*** Nisha_brb has joined #openstack-ironic | 20:33 | |
*** Nisha_away has quit IRC | 20:33 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: Implement take_over for iscsi_ilo driver https://review.openstack.org/217068 | 20:34 |
*** karimb has joined #openstack-ironic | 20:34 | |
*** puranamr has quit IRC | 20:36 | |
rloo | JoshNang: let me know if you have any questions about my comments in your zap patches, so I am not holding you up. | 20:37 |
*** puranamr has joined #openstack-ironic | 20:43 | |
JoshNang | rloo: will do! got pulled into downstream things. the comments all seemed fine after a quick look | 20:47 |
rloo | JoshNang: good. | 20:47 |
*** achanda has joined #openstack-ironic | 20:48 | |
JoshNang | as far as zap_step vs clean_step, i checked the spec and it doesn't say either way :/ | 20:49 |
rloo | JoshNang: remind me. zap_step is the current zap step being performed? | 20:50 |
JoshNang | correct | 20:50 |
rloo | JoshNang: where do we store the list of zap steps that the user wants? | 20:50 |
JoshNang | driver_internal_info | 20:50 |
rloo | JoshNang: this might be the first time that we aren't saving the user's information in some non-internal field. | 20:51 |
rloo | JoshNang: not sure that is a good idea. | 20:51 |
rloo | JoshNang: I'd rather have zap_steps for the user-specified stuff :) | 20:52 |
rloo | JoshNang: on the other hand, if I don't say anything, we can go with what you are coding and modify or not later. | 20:52 |
JoshNang | hmmmm | 20:52 |
JoshNang | what about driver_info for it? | 20:54 |
*** achanda has quit IRC | 20:54 | |
rloo | JoshNang: let me think about it. | 20:54 |
rloo | JoshNang: I need to review the zap spec blah blah. | 20:55 |
*** Marga_ has quit IRC | 20:58 | |
*** Marga_ has joined #openstack-ironic | 20:58 | |
*** achanda has joined #openstack-ironic | 21:02 | |
rloo | JoshNang: what do you think of having node.zap_steps. It would include the info the user specified, and an additional 'status' in each step, indicating 'processing/current?', 'completed', 'not started'. Or something like that? | 21:05 |
rloo | JoshNang: or is that too much information to spit out? Seems like that is more useful than just the current zap step. | 21:06 |
rloo | JoshNang: how does the heartbeating/waiting work. Will we need some new config to indicate when to abort/stop waiting for zapping to be done? | 21:07 |
JoshNang | rloo: i'm fine with that. it's slightly inconsistent with cleaning, but i'm ok with it | 21:07 |
JoshNang | i still need to track current zap_step somewhere, preferably node.zap_step, or the code is going to get very ugly very quickly | 21:08 |
JoshNang | the goal is to share as much code between zapping and cleaning as possible, which is why i opted for node.zap_step and internal info for zap_steps | 21:08 |
rloo | JoshNang: well, i say use 'clean_step' then for that. | 21:09 |
JoshNang | hearting/waiting should work just like it does for cleaning right now | 21:09 |
JoshNang | isn't that more confusing to the user? it's already very confusing to have cleaning/zapping | 21:09 |
rloo | JoshNang: I think there is/will be some config to timeout a cleaning step or something. let me see. | 21:09 |
JoshNang | ah yeah, it should work just the same for zapping then | 21:09 |
JoshNang | same with abortable | 21:10 |
rloo | JoshNang: the user can look at zap_steps. | 21:10 |
rloo | JoshNang: it is documented that zap steps are a superset of clean steps, so it is already confusing. or not. | 21:10 |
rloo | JoshNang: seems like clean_step is really convenient for you/the developer? | 21:11 |
JoshNang | it certainly is | 21:11 |
rloo | JoshNang: would have liked it to be in driver_internal_info then. | 21:12 |
JoshNang | i mean, i use it as an operator all the time | 21:12 |
*** sdake_ has quit IRC | 21:13 | |
rloo | JoshNang: oh. so clean_step is more useful that having eg 'clean_steps' that shows all the steps and indicates which one is current? | 21:13 |
JoshNang | yeah, i don't want to scan 10+ steps in a json blob to see what's running | 21:13 |
JoshNang | though, i look at it through our dash 99% of the time anyway, so it's kinda moot. | 21:14 |
JoshNang | but if i was doing an ironic node list, or a db query, having it not in internal info would be preferable | 21:14 |
rloo | JoshNang: ha ha. I was wondering if something like 'status' might be more useful, to have information about the current operation (in any provisioning state/transition). But that is another conversation I think. | 21:15 |
*** achanda has quit IRC | 21:15 | |
*** achanda has joined #openstack-ironic | 21:15 | |
JoshNang | :D that definitely would be more useful and is one of the big reasons i use our dash over ironic node-list | 21:17 |
*** Marga_ has quit IRC | 21:17 | |
*** Marga_ has joined #openstack-ironic | 21:17 | |
jroll | rloo: JoshNang driver_internal_info is exposed in the API, it just isn't editable, so I don't see a problem with having zap steps there | 21:22 |
* jroll late to the party | 21:22 | |
rloo | jroll: I think this is the first time the user has specified something that isn't saved in the node in a non-internal field. that's all. | 21:23 |
jroll | rloo: raid does the same thing if I'm not mistaken? | 21:23 |
*** Sukhdev has quit IRC | 21:23 | |
jroll | they can't edit node.raid_config | 21:23 |
rloo | jroll: you're mistaken. and maybe that's my fault. we have node.target_raid_config. | 21:23 |
rloo | jroll: and node.raid_config | 21:23 |
jroll | right... | 21:23 |
*** Nisha_brb has quit IRC | 21:23 | |
jroll | target_raid_config is what the user edits | 21:24 |
jroll | raid_config is what is actually validated and going to happen | 21:24 |
jroll | right? | 21:24 |
rloo | jroll: 10 points. | 21:24 |
rloo | jroll: no. 8 points. | 21:24 |
rloo | jroll: raid_config is what is actually configured | 21:24 |
jroll | I like internal_info to keep it consistent with cleaning, I think. but idk. I want to rewrite our entire API | 21:24 |
jroll | oh | 21:24 |
JoshNang | with zapping, i have the zap steps being passed in with the provision_state api, like we do with configdrive | 21:24 |
JoshNang | instead of post to field, then update provision state | 21:25 |
*** mbound has joined #openstack-ironic | 21:25 | |
jroll | yeah | 21:25 |
rloo | JoshNang: where do we save configdrive? | 21:25 |
mrda | Morning ironic | 21:25 |
tonyb | is devananda around ATM or vactioning? | 21:25 |
JoshNang | mmm good question, lemme check | 21:25 |
jroll | tonyb: he's kind of around, moving apartments, can I help? | 21:26 |
tonyb | jroll: Sadly only devananda has the magic +2 I need :) | 21:26 |
tonyb | jroll: Thanks for the offer. | 21:27 |
JoshNang | rloo: swift or instance info | 21:27 |
jroll | tonyb: boo, which kind is it? I may be able to reach him | 21:27 |
*** sdake has joined #openstack-ironic | 21:27 | |
rloo | JoshNang: just leave the zap steps in internal info for now then. :) | 21:27 |
tonyb | jroll: It's not that urgent. If he's doing IRL stuff then leave him to it | 21:27 |
jroll | mmmkay | 21:27 |
tonyb | jroll: I was really just trying to work out if he's busy or hates me | 21:28 |
rloo | JoshNang: we can deal with it when someone complains. | 21:28 |
jroll | lol | 21:28 |
tonyb | jroll: of course it could be both ;P | 21:28 |
jroll | tonyb: he *just* got back from vacation, too, so | 21:28 |
jroll | get in the queue, pls | 21:28 |
JoshNang | rloo: heh ok :) i do agree with jroll though, reviewing the whole of the api would be a good idea | 21:28 |
jroll | I was at least half joking | 21:28 |
rloo | JoshNang: yeah, if/when we review, that info might end up somewhere else, so seems safer to put in internal for now. | 21:29 |
JoshNang | jroll: i assume we'll want a v2 api someday | 21:29 |
jroll | noooo | 21:29 |
JoshNang | or not, maybe we just put up with the little things | 21:30 |
jroll | (maybe) | 21:30 |
tonyb | jroll: Thanks, and I'll just take a number ;P | 21:31 |
*** blakec has joined #openstack-ironic | 21:31 | |
jroll | :) | 21:32 |
*** achanda has quit IRC | 21:33 | |
*** achanda has joined #openstack-ironic | 21:34 | |
*** puranamr has quit IRC | 21:34 | |
*** puranamr has joined #openstack-ironic | 21:35 | |
*** blakec1 has joined #openstack-ironic | 21:35 | |
*** blakec has quit IRC | 21:38 | |
*** thrash is now known as thrash|g0ne | 21:42 | |
NobodyCam | anyone happen to have a working nova env and have the time to paste a nova hypervisor-list ???? | 21:50 |
NobodyCam | nova with ironic driver | 21:50 |
openstackgerrit | Stephanie Miller proposed openstack/bifrost: README cleanups https://review.openstack.org/222380 | 21:50 |
jroll | NobodyCam: I would if hypervisor-list worked with cells :P | 21:51 |
*** derekh has joined #openstack-ironic | 21:51 | |
NobodyCam | :) | 21:51 |
NobodyCam | doh | 21:51 |
jroll | it would also be wayyyy too long :P | 21:52 |
devananda | tonyb: pong - what's up? | 21:57 |
tonyb | devananda: You're the only ironic person that can +2 https://review.openstack.org/#/c/173121/ (g-r sync in juno) I was hoping you could take a look at it | 21:59 |
jroll | devananda: we should make that more HA | 22:00 |
tonyb | devananda: no rush but it'd reduce my juno dashboard by one item. | 22:00 |
jroll | devananda: that also reminds me, can you add me to ironic-drivers in launchpad? | 22:00 |
openstackgerrit | Stephanie Miller proposed openstack/bifrost: README cleanups https://review.openstack.org/222380 | 22:01 |
*** mbound has quit IRC | 22:02 | |
mrda | Just wondering how hard to would be to get the agent driver going with AMT... | 22:06 |
jroll | no harder than !agent driver with AMT | 22:06 |
jroll | there's the swift thing, though | 22:06 |
* mrda hasn't used the agent against real hardware yet | 22:07 | |
mrda | jroll: but that's not dependent on anything h/w related, just need swift tmpurl configured, right? | 22:08 |
jroll | mrda: correct | 22:08 |
jroll | mrda: it also totally works if you just give it an http url to an image | 22:08 |
mrda | right | 22:08 |
*** marzif has joined #openstack-ironic | 22:10 | |
mrda | this might end up being a Friday lunchtime random hack idea | 22:10 |
*** ijw_ has quit IRC | 22:11 | |
jroll | +1 | 22:13 |
*** marzif_ has joined #openstack-ironic | 22:18 | |
*** marzif has quit IRC | 22:18 | |
openstackgerrit | Stephanie Miller proposed openstack/bifrost: Clean up troubleshooting.rst markup https://review.openstack.org/222384 | 22:20 |
*** dims_ has joined #openstack-ironic | 22:20 | |
*** davideag_ has joined #openstack-ironic | 22:21 | |
devananda | tonyb: done | 22:21 |
devananda | jroll: you're already a member -- https://launchpad.net/~ironic-drivers | 22:22 |
*** davideagnello has quit IRC | 22:23 | |
jroll | orly | 22:23 |
tonyb | devananda: Thanks! | 22:23 |
jroll | devananda: I wonder if I had doug do that, oops | 22:23 |
*** dims has quit IRC | 22:23 | |
devananda | mrda: I already got agent working with amt -- https://github.com/devananda/ironic/blob/new-amt-driver/ironic/drivers/agent.py#L135 | 22:24 |
mrda | devananda: oh, cool! | 22:24 |
tonyb | devananda: There will be a few more coming as juno is kinda fubar right now. | 22:24 |
devananda | mrda: just not the in-tree amt driver, because that one doesn't work for my NUC | 22:24 |
mrda | devananda: thanks for that | 22:24 |
devananda | and the hack I did for demo purposes is, well, a hack :) | 22:24 |
devananda | tonyb: ugh -- ok, thanks for the heads up. I'll try to keep an eye on them, but pinging me is good | 22:25 |
jroll | devananda: so, sdague says he has a fix for that if he finds time to contribute it | 22:25 |
mrda | devananda: it's strange, I've been using in tree successfully, and we've got the same NUC | 22:25 |
tonyb | devananda: Thanks. | 22:25 |
devananda | mrda: strange indeed | 22:26 |
mrda | devananda: (well, almost successfully, the latest rebuild I did is failing on iscsiadm dd, but I assumed that was a problem with the deploy disk I wrote) | 22:26 |
jroll | devananda: tl;dr just make it python a la https://github.com/sdague/amt/blob/master/amt/wsman.py | 22:26 |
devananda | mrda: by 'doesnt work' i mean it locks up the conductor process | 22:26 |
devananda | jroll: LOL | 22:27 |
jroll | devananda: it isn't much code, I fully support this | 22:27 |
mrda | devananda: I don't get that, I get a hung boot during deploy. Biut I assume it was me fat fingering... | 22:27 |
devananda | https://github.com/sdague/amt/blob/master/amt/hostdb.py | 22:27 |
jroll | ya | 22:28 |
devananda | ahh i see | 22:29 |
devananda | so, this comment is exactly what i've been running into | 22:29 |
devananda | Retry http requests when they fail. AMT processors randomly drop | 22:29 |
devananda | some connections, built in limited retry should be done. | 22:29 |
devananda | and why the current in-tree driver fails. a single dropped response and the conductor process hangs in EPOLLWAIT indefinitely | 22:30 |
jroll | right | 22:32 |
jroll | so sean said he wanted to pull that in when he finds time (read: after L3) | 22:32 |
*** Marga_ has quit IRC | 22:32 | |
*** ijw_ has joined #openstack-ironic | 22:33 | |
jlvillal | mrda: On the AMT stuff. I was thinking about hacking it to attempt to do a socket attempt to the port before handing it off to wsman. Any thoughts? | 22:34 |
*** Marga_ has joined #openstack-ironic | 22:35 | |
mrda | It could be done by shell out with a netcat or something | 22:35 |
mrda | if that | 22:35 |
mrda | 's easier jlvillal | 22:35 |
jroll | why not just do what sdague did | 22:36 |
jlvillal | mrda: I guess it annoys me to go out to the shell... | 22:36 |
jroll | or sit back and wait for him to do it | 22:36 |
*** Marga_ has quit IRC | 22:36 | |
jroll | also, it apparently drops connections, so making sure it can connect first probably won't help | 22:36 |
jlvillal | jroll: I will take a look at his stuff. Just trying to figure out why I my AMT is always timing out with Ironic. Using web interface I can control it. | 22:37 |
*** achanda has quit IRC | 22:37 | |
*** Marga_ has joined #openstack-ironic | 22:37 | |
mrda | jroll: it's quite determiniistic - often the first connection to the AMT port fails, but the 2nd succeeds | 22:37 |
jroll | jlvillal: because AMT apparently randomly drops connections | 22:37 |
jroll | hah | 22:37 |
jroll | maybe not so randomly then | 22:37 |
mrda | so by making the connection first i.e. "telnet ip-addr 16992" I don't see this wsman lockup | 22:38 |
mrda | but this is annecdotal, I only have one NUC so I'm hardly an expert | 22:38 |
*** linkmark has quit IRC | 22:38 | |
jroll | I have zero, so :) | 22:39 |
jlvillal | mrda: I see similar. First telnet doesn't connect, if I haven't connected for awhile. | 22:39 |
mrda | right, stupid idea having the control and data plane on a single NIC | 22:39 |
mrda | and have two things listening on the same mac address | 22:40 |
*** Marga_ has quit IRC | 22:43 | |
*** Marga_ has joined #openstack-ironic | 22:43 | |
jlvillal | mrda: Well I think for desktop you have to make compromises. Hard to convince people to run two networks out to each desktop system. | 22:51 |
mrda | sure, but it has to work too :) | 22:52 |
*** marzif_ has quit IRC | 22:52 | |
*** davideagnello has joined #openstack-ironic | 22:55 | |
*** davideag_ has quit IRC | 22:58 | |
devananda | mrda: also when the NUC reboots, it appears to powers off the NIC, so what ever device is connected on the other end of that cable sees a disconnect/reconnect | 22:59 |
devananda | which triggers some fun things in network stacks | 22:59 |
* devananda has spent a fair bit of time wiresharking his NUC .... | 23:00 | |
devananda | also my sample size is 1, so this could be a peculiarity of my NUC :) | 23:00 |
mrda | devananda: oh yes, I see this too. | 23:00 |
*** baoli_ has quit IRC | 23:01 | |
mrda | So I'm connecting the NUC's nic to another computer, and not via a swicth, so I see the network disconnects in syslog on the other computer. It's pretty average. | 23:02 |
*** baoli has joined #openstack-ironic | 23:02 | |
mrda | devananda: did you need to do anything else other than mixin the agent and amt together? Were there any changes needed (ignoring your attempts to fix the dropped packets problem) | 23:03 |
devananda | i think that's it | 23:07 |
devananda | you can see the commit history, it's shallow and pretty clean | 23:07 |
*** baoli has quit IRC | 23:07 | |
*** baoli has joined #openstack-ironic | 23:08 | |
openstackgerrit | Stephanie Miller proposed openstack/bifrost: Cleanups for README.vagrant https://review.openstack.org/222395 | 23:09 |
jlvillal | mrda: How did you comment out the periodic task logging in conductor? Is that a config file setting? | 23:11 |
mrda | commented out the loggin only | 23:14 |
mrda | and manually | 23:14 |
mrda | and manually | 23:14 |
*** achanda has joined #openstack-ironic | 23:17 | |
jlvillal | mrda: Ah, thanks. | 23:19 |
openstackgerrit | Joshua Harlow proposed openstack/ironic-python-agent: Cleanup tempdir if '_get_partition' dies https://review.openstack.org/219915 | 23:20 |
openstackgerrit | Joshua Harlow proposed openstack/ironic-python-agent: Cleanup tempdir if '_get_partition' dies https://review.openstack.org/219915 | 23:22 |
*** trown is now known as trown|outttypeww | 23:25 | |
*** karimb has quit IRC | 23:28 | |
mrda | jlvillal: How about something like: while true; do nc -zv 10.0.0.251 16992; if [ "$?" == "0" ]; then break; fi; done | 23:32 |
jlvillal | mrda: Could do, though I still dislike calling external processes when could do it inside Python. | 23:32 |
mrda | jlvillal: sure, but this is working for me in a script right now, just fyi | 23:33 |
jlvillal | mrda: Though I do notice that greenlet is running, so I'm not sure if things like socket.create_connection() get changed. | 23:33 |
jlvillal | mrda: Also have to make sure that 'nc' is installed on the system. | 23:33 |
mrda | yes | 23:33 |
jlvillal | If it it was a permanent solution | 23:33 |
jroll | IMO this is a terrible permanent solution | 23:34 |
jroll | especially when code has been written already to do it better | 23:34 |
mrda | jroll: just testing to see if the problem can be solved this way. Not suggesting this as a permanent solution | 23:35 |
mrda | i.e. ensuring the connection open before starting provisioning | 23:35 |
jroll | yeah, just pointing it out | 23:35 |
mrda | jroll: appreciate that. I wouldn't propose a hacky permanent solution | 23:35 |
jroll | no, none of us would ever do that | 23:36 |
jroll | ;) | 23:36 |
* mrda is sometimes too much a purist for some | 23:36 | |
jlvillal | Uh, yeah me too. I would never do that. pinky swear | 23:36 |
mrda | I'd also note that my nc example can fail up to 10 times before it succeeds | 23:36 |
mrda | in the limited testing I've done this morning | 23:37 |
jlvillal | jroll: mrda: I like the idea of the amt library. Especially if don't have to use pywsman. At the moment pywsman is a black box that my request goes into to die (aka timeout and return None) | 23:37 |
jlvillal | mrda: I keep timing out on the call to: client.wsman_get() | 23:38 |
mrda | huh | 23:39 |
jroll | jlvillal: yep, +1 | 23:39 |
jlvillal | mrda: it is in the function: wsman_get() | 23:40 |
mrda | good work jlvillal | 23:41 |
jlvillal | mrda: Uh, so far I am having no joy. Ugh. | 23:41 |
jlvillal | mrda: But getting to learn the AMT code much better :) | 23:41 |
mrda | all worthwhile :) | 23:42 |
*** baoli has quit IRC | 23:47 | |
*** shoutm has joined #openstack-ironic | 23:51 | |
*** Sukhdev has joined #openstack-ironic | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!