| *** achanda has quit IRC | 00:01 | |
| NobodyCam | morning mrda | 00:01 |
|---|---|---|
| *** Sukhdev has quit IRC | 00:02 | |
| mrda | hey NobodyCam | 00:02 |
| *** lucas-dinner has quit IRC | 00:03 | |
| *** lucasagomes_ has quit IRC | 00:04 | |
| *** naohirot has joined #openstack-ironic | 00:04 | |
| openstackgerrit | Joshua Harlow proposed openstack/ironic-python-agent: Use system random where applicable https://review.openstack.org/223266 | 00:05 |
| NobodyCam | :) | 00:11 |
| *** Marga_ has quit IRC | 00:17 | |
| *** penick has quit IRC | 00:20 | |
| *** Marga_ has joined #openstack-ironic | 00:25 | |
| *** liliars has quit IRC | 00:29 | |
| *** liliars has joined #openstack-ironic | 00:32 | |
| *** MattMan has left #openstack-ironic | 00:40 | |
| *** baoli has joined #openstack-ironic | 00:40 | |
| *** baoli has quit IRC | 00:43 | |
| *** garthb has quit IRC | 00:45 | |
| *** baoli has joined #openstack-ironic | 00:46 | |
| *** slagle has joined #openstack-ironic | 00:47 | |
| *** dims_ has joined #openstack-ironic | 00:48 | |
| openstackgerrit | William Stevenson proposed openstack/ironic: Add network provider interface and implementations https://review.openstack.org/139687 | 00:49 |
| openstackgerrit | William Stevenson proposed openstack/ironic: Update the deploy drivers with network flipping logic https://review.openstack.org/213262 | 00:51 |
| *** arahal_ has joined #openstack-ironic | 01:02 | |
| openstackgerrit | Merged openstack/bifrost: Fix HACKING.rst and canary test for merges https://review.openstack.org/220113 | 01:04 |
| *** r-daneel has quit IRC | 01:06 | |
| *** arahal_ has quit IRC | 01:06 | |
| *** zhenguo has joined #openstack-ironic | 01:09 | |
| *** puranamr has joined #openstack-ironic | 01:22 | |
| *** Marga_ has quit IRC | 01:22 | |
| *** stendulker has joined #openstack-ironic | 01:26 | |
| *** smoriya has joined #openstack-ironic | 01:39 | |
| *** Marga_ has joined #openstack-ironic | 01:49 | |
| *** puranamr has quit IRC | 01:53 | |
| *** rloo has quit IRC | 02:02 | |
| *** baoli has quit IRC | 02:02 | |
| *** baoli has joined #openstack-ironic | 02:03 | |
| jlvillal | mrda, This patch might be interesting to you, or maybe not :) https://review.openstack.org/#/c/222827/ | 02:06 |
| jlvillal | mrda, I ran into the issue when I was using '--secure' with tftpd | 02:06 |
| * jlvillal goes back to watching NFL football... | 02:07 | |
| *** stendulker has quit IRC | 02:10 | |
| *** dims_ has quit IRC | 02:11 | |
| *** harshs has quit IRC | 02:13 | |
| *** harshs has joined #openstack-ironic | 02:13 | |
| *** harshs has quit IRC | 02:17 | |
| mrda | thanks jlvillal | 02:19 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/223380 | 02:23 |
| *** achanda has joined #openstack-ironic | 02:27 | |
| *** praneshp has quit IRC | 03:05 | |
| *** dims_ has joined #openstack-ironic | 03:12 | |
| *** dims_ has quit IRC | 03:19 | |
| openstackgerrit | Merged openstack/ironic: Update 'Installation Guide' for RHEL7/CentOS7/Fedora https://review.openstack.org/222920 | 03:20 |
| *** baoli has quit IRC | 03:22 | |
| *** Nisha has joined #openstack-ironic | 03:24 | |
| *** natorious has quit IRC | 03:26 | |
| *** eglute has quit IRC | 03:27 | |
| *** mgagne has quit IRC | 03:28 | |
| *** saripurigopi has joined #openstack-ironic | 03:28 | |
| *** jroll has quit IRC | 03:28 | |
| *** comstud has quit IRC | 03:28 | |
| *** persia has quit IRC | 03:29 | |
| *** persia has joined #openstack-ironic | 03:30 | |
| *** persia has quit IRC | 03:30 | |
| *** persia has joined #openstack-ironic | 03:30 | |
| *** harshs has joined #openstack-ironic | 03:30 | |
| *** eglute has joined #openstack-ironic | 03:30 | |
| *** comstud has joined #openstack-ironic | 03:30 | |
| *** natorious has joined #openstack-ironic | 03:30 | |
| *** mgagne has joined #openstack-ironic | 03:31 | |
| *** jroll has joined #openstack-ironic | 03:31 | |
| *** natorious has quit IRC | 03:39 | |
| *** eglute has quit IRC | 03:39 | |
| *** jroll has quit IRC | 03:41 | |
| *** mgagne has quit IRC | 03:41 | |
| *** comstud has quit IRC | 03:41 | |
| *** persia has quit IRC | 03:41 | |
| *** persia has joined #openstack-ironic | 03:42 | |
| saripurigopi | Morning Ironic | 03:45 |
| *** adam_g has quit IRC | 03:45 | |
| *** david-lyle has joined #openstack-ironic | 03:50 | |
| *** adam_g has joined #openstack-ironic | 03:51 | |
| *** adam_g has quit IRC | 03:51 | |
| *** adam_g has joined #openstack-ironic | 03:51 | |
| *** achanda has quit IRC | 03:52 | |
| *** harshs has quit IRC | 03:53 | |
| *** shuquan has joined #openstack-ironic | 03:58 | |
| *** rameshg87 has joined #openstack-ironic | 04:00 | |
| *** comstud has joined #openstack-ironic | 04:03 | |
| *** eglute has joined #openstack-ironic | 04:03 | |
| *** mgagne has joined #openstack-ironic | 04:03 | |
| *** natorious has joined #openstack-ironic | 04:04 | |
| *** jroll has joined #openstack-ironic | 04:04 | |
| *** achanda has joined #openstack-ironic | 04:05 | |
| *** achanda has quit IRC | 04:11 | |
| *** harshs has joined #openstack-ironic | 04:13 | |
| *** dims_ has joined #openstack-ironic | 04:16 | |
| *** achanda has joined #openstack-ironic | 04:21 | |
| *** dims_ has quit IRC | 04:22 | |
| *** achanda has quit IRC | 04:27 | |
| *** shoutm has quit IRC | 04:45 | |
| *** rcarrillocruz has left #openstack-ironic | 04:46 | |
| *** amotoki has joined #openstack-ironic | 04:47 | |
| *** shoutm has joined #openstack-ironic | 04:55 | |
| *** yog_ has joined #openstack-ironic | 04:57 | |
| *** garthb has joined #openstack-ironic | 05:06 | |
| *** praneshp has joined #openstack-ironic | 05:11 | |
| *** lazy_prince has joined #openstack-ironic | 05:11 | |
| *** harshs has quit IRC | 05:11 | |
| *** amotoki has quit IRC | 05:14 | |
| *** coolsvap has joined #openstack-ironic | 05:15 | |
| *** praneshp_ has joined #openstack-ironic | 05:16 | |
| *** praneshp has quit IRC | 05:18 | |
| *** praneshp_ is now known as praneshp | 05:18 | |
| *** amotoki has joined #openstack-ironic | 05:21 | |
| *** Marga_ has quit IRC | 05:24 | |
| *** praneshp has quit IRC | 05:35 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor agent {prepare,tear_down}_cleaning into deploy_utils https://review.openstack.org/220895 | 05:40 |
| *** shoutm has quit IRC | 05:45 | |
| *** shoutm has joined #openstack-ironic | 05:48 | |
| *** marios has joined #openstack-ironic | 05:49 | |
| *** Marga_ has joined #openstack-ironic | 05:52 | |
| *** Marga_ has quit IRC | 05:52 | |
| *** Marga_ has joined #openstack-ironic | 05:53 | |
| *** garthb has quit IRC | 05:58 | |
| *** dlpartain has joined #openstack-ironic | 05:59 | |
| *** dlpartain has quit IRC | 06:01 | |
| *** ishant has joined #openstack-ironic | 06:01 | |
| *** dlpartain has joined #openstack-ironic | 06:01 | |
| *** yog_ has quit IRC | 06:02 | |
| *** yuikotakada has joined #openstack-ironic | 06:03 | |
| jlvillal | mrda, Can you look at the Nova patch: https://review.openstack.org/#/c/221848/ | 06:05 |
| jlvillal | mrda, Please see if my concern is valid or not. Maybe I'm wrong | 06:06 |
| * jlvillal goes to sleep | 06:06 | |
| *** dlpartain has left #openstack-ironic | 06:07 | |
| *** enikanorov_ has quit IRC | 06:09 | |
| mrda | thanks jlvillal | 06:11 |
| mrda | I think that's a pretty good concern. | 06:16 |
| *** chenke has quit IRC | 06:17 | |
| mrda | Just need to look at teh configuration system, to see what it does | 06:17 |
| *** yog_ has joined #openstack-ironic | 06:19 | |
| * mrda writes a couple of tests | 06:21 | |
| *** shuquan has quit IRC | 06:23 | |
| *** coolsvap_ has joined #openstack-ironic | 06:24 | |
| *** shuquan has joined #openstack-ironic | 06:26 | |
| yuikotakada | good morning, Ironic | 06:27 |
| mrda | hi yuikotakada | 06:29 |
| yuikotakada | mrda, hi :) | 06:29 |
| *** e0ne has joined #openstack-ironic | 06:40 | |
| *** wshao has joined #openstack-ironic | 06:42 | |
| *** e0ne has quit IRC | 06:44 | |
| *** mordred has quit IRC | 06:46 | |
| *** shadower has joined #openstack-ironic | 06:46 | |
| *** e0ne has joined #openstack-ironic | 06:48 | |
| *** coolsvap_ has quit IRC | 06:49 | |
| *** mordred has joined #openstack-ironic | 06:49 | |
| *** adam_g has quit IRC | 06:55 | |
| *** achanda has joined #openstack-ironic | 07:06 | |
| *** wshao has quit IRC | 07:10 | |
| *** boris-42 has quit IRC | 07:10 | |
| *** e0ne has quit IRC | 07:10 | |
| *** yog_ has quit IRC | 07:13 | |
| *** shuquan has quit IRC | 07:15 | |
| *** ukalifon has joined #openstack-ironic | 07:15 | |
| zigo | I've finished packaging ironic-inspector, however, there's things I don't understand. | 07:18 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor agent {prepare,tear_down}_cleaning into deploy_utils https://review.openstack.org/220895 | 07:18 |
| zigo | What is the point of having it connect to a DB ? | 07:18 |
| zigo | Should it be a central db? | 07:18 |
| zigo | Does SQLite works? | 07:18 |
| zigo | What else should be configured by default, and what would be the typical deployment workflow? | 07:19 |
| *** ukalifon has quit IRC | 07:20 | |
| zigo | All this is mostly for my own knowledge, I'm not sure I need to know for doing the packaging (though it'd be nice if I could test it enough...). | 07:21 |
| *** achanda has quit IRC | 07:22 | |
| zigo | And also, does it needs to run as root? It seems to work as ironic-inspector:ironic-inspector... | 07:22 |
| zigo | I'd prefer to let it run as non-root if it's not mandatory for it to be root. | 07:22 |
| * zigo just uploaded ironic-inspector 2.1.0-1 to Debian Experimental. It will go through the FTP masters NEW queue because of the rename. | 07:23 | |
| *** achanda has joined #openstack-ironic | 07:25 | |
| *** ifarkas has joined #openstack-ironic | 07:26 | |
| mrda | zigo: dtantsur should be online soon, he will be able to answer your questions | 07:29 |
| zigo | Cheers. | 07:29 |
| mrda | jlvillal: Look what I hit just now: [23547:/build/buildd/openwsman-2.4.3/src/lib/wsman-client-transport.c:91:wsman_send_request] Couldn't send request to client: Failure when receiving data from the peer Are you seeing that too? | 07:30 |
| *** e0ne has joined #openstack-ironic | 07:31 | |
| mrda | jlvillal: so I was able to do the ramdisk deploy method quite ok. Now trying agent_amt (existing in-tree amt driver + agent) fails all the time. | 07:32 |
| *** itsuugo has joined #openstack-ironic | 07:32 | |
| *** itsuugo has quit IRC | 07:33 | |
| *** itsuugo has joined #openstack-ironic | 07:34 | |
| *** shoutm_ has joined #openstack-ironic | 07:35 | |
| *** shoutm has quit IRC | 07:35 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add support for in-band cleaning in ISCSIDeploy https://review.openstack.org/220898 | 07:38 |
| *** yog_ has joined #openstack-ironic | 07:38 | |
| *** achanda has quit IRC | 07:41 | |
| *** e0ne has quit IRC | 07:42 | |
| *** dlpartain has joined #openstack-ironic | 07:43 | |
| *** dlpartain has left #openstack-ironic | 07:43 | |
| *** e0ne has joined #openstack-ironic | 07:46 | |
| *** stendulker has joined #openstack-ironic | 07:47 | |
| *** e0ne has quit IRC | 07:51 | |
| *** Haomeng has joined #openstack-ironic | 07:53 | |
| *** Haomeng|2 has quit IRC | 07:56 | |
| *** dtantsur|afk is now known as dtantsur | 07:57 | |
| dtantsur | Morning Ironic | 07:57 |
| dtantsur | hi zigo, how can I help? | 07:57 |
| zigo | dtantsur: Morning! o/ | 07:57 |
| zigo | dtantsur: What is the point of having it connect to a DB in ironic-inspector? What else should be configured by default, and what would be the typical deployment workflow? | 07:58 |
| dtantsur | zigo, inspector caches some information in database, it's perfectly fine to have sqlite there (that's what we use in gate) | 07:58 |
| zigo | Ah... | 07:58 |
| dtantsur | zigo, as to root: it makes calls to iptables, hence root | 07:58 |
| zigo | Oh ok. | 07:58 |
| zigo | I'll fix this soonish then. | 07:58 |
| zigo | dtantsur: Can't it use sudo & rootwrap then? | 07:58 |
| zigo | It'd be nice if it did. | 07:58 |
| dtantsur | zigo, nice catch, just didn't have time for it. mind reporting a bug? | 07:59 |
| zigo | dtantsur: For supporting rootwrap? | 07:59 |
| dtantsur | yep | 07:59 |
| dtantsur | zigo, as to configuration, https://github.com/openstack/ironic-inspector#configuration mentions what is required | 08:00 |
| dtantsur | g'afternoon yuikotakada! do you think you could have some time to add support for rootwrap in inspector? ^^ | 08:00 |
| * mrda knew dtantsur would have all the answers | 08:00 | |
| dtantsur | :) | 08:01 |
| zigo | Ok, thanks a lot. | 08:01 |
| yuikotakada | dtantsur, o/ | 08:01 |
| yuikotakada | dtantsur, yeah, I will. maybe within 3 hours | 08:03 |
| zigo | https://bugs.launchpad.net/ironic-inspector/+bug/1495844 | 08:04 |
| openstack | Launchpad bug 1495844 in Ironic Inspector "ironic-inspector doesn't use rootwrap" [Undecided,New] | 08:04 |
| dtantsur | yuikotakada, awesome, thanks! | 08:04 |
| dtantsur | zigo, thanks | 08:04 |
| *** shuquan has joined #openstack-ironic | 08:06 | |
| *** sdake has quit IRC | 08:07 | |
| betherly | Morning all | 08:07 |
| dtantsur | betherly, morning | 08:07 |
| yuikotakada | betherly, morning :) | 08:08 |
| *** mgoddard has joined #openstack-ironic | 08:08 | |
| *** itsuugo has quit IRC | 08:11 | |
| *** derekh has joined #openstack-ironic | 08:13 | |
| *** ndipanov has joined #openstack-ironic | 08:13 | |
| *** VikasC has joined #openstack-ironic | 08:16 | |
| *** lucas-dinner has joined #openstack-ironic | 08:16 | |
| *** lucasagomes has joined #openstack-ironic | 08:16 | |
| *** shuquan has quit IRC | 08:16 | |
| *** lucasagomes_ has joined #openstack-ironic | 08:16 | |
| *** jistr has joined #openstack-ironic | 08:18 | |
| *** itsuugo has joined #openstack-ironic | 08:19 | |
| *** romainh has joined #openstack-ironic | 08:19 | |
| *** dims_ has joined #openstack-ironic | 08:20 | |
| betherly | hi dtantsur , yuikotakada :) | 08:20 |
| *** shuquan has joined #openstack-ironic | 08:27 | |
| *** Nisha has quit IRC | 08:27 | |
| *** pelix has joined #openstack-ironic | 08:31 | |
| *** athomas has joined #openstack-ironic | 08:32 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: [WIP] Support for introspection rules https://review.openstack.org/223096 | 08:38 |
| openstackgerrit | Merged openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/223380 | 08:47 |
| *** e0ne has joined #openstack-ironic | 08:48 | |
| *** dims_ has quit IRC | 08:53 | |
| *** romcheg has joined #openstack-ironic | 08:55 | |
| *** mgoddard1 has joined #openstack-ironic | 08:56 | |
| *** Nisha has joined #openstack-ironic | 08:57 | |
| *** mgoddard has quit IRC | 08:57 | |
| sambetts | Morning ironic o/ | 08:59 |
| *** mgoddard1 has quit IRC | 09:08 | |
| openstackgerrit | Ramakrishnan G proposed stackforge/proliantutils: Add logging for _rest_op method in RIS https://review.openstack.org/219636 | 09:09 |
| *** itsuugo has quit IRC | 09:09 | |
| *** mgoddard has joined #openstack-ironic | 09:09 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: [WIP] Add a proper client object https://review.openstack.org/223490 | 09:10 |
| dtantsur | morning sambetts! | 09:11 |
| *** romcheg has quit IRC | 09:14 | |
| *** dtantsur is now known as dtantsur|brb | 09:17 | |
| openstackgerrit | Merged openstack/ironic-inspector: Add instructions how to try IPA as a ramdisk https://review.openstack.org/222260 | 09:18 |
| openstackgerrit | Ramakrishnan G proposed stackforge/proliantutils: Add logging for _rest_op method in RIS https://review.openstack.org/219636 | 09:19 |
| *** itsuugo has joined #openstack-ironic | 09:23 | |
| *** romcheg has joined #openstack-ironic | 09:26 | |
| lucasagomes | rameshg87, around, re https://bugs.launchpad.net/ironic/+bug/1433812 | 09:29 |
| openstack | Launchpad bug 1433812 in Ironic "ironic-python-agent silently fails to write a configdrive if a previous drive is found" [High,Fix released] - Assigned to Ramakrishnan G (rameshg87) (rameshg87) | 09:29 |
| lucasagomes | rameshg87, what else is needed there? Seems all patches have been merged but none were closing the bug (just partial-bug tags) | 09:30 |
| rameshg87 | lucasagomes: hi | 09:30 |
| * rameshg87 can find three lucas in the root | 09:30 | |
| rameshg87 | lucasagomes: let me check | 09:30 |
| *** lucas-dinner has quit IRC | 09:30 | |
| *** lucasagomes_ has quit IRC | 09:30 | |
| lucasagomes | rameshg87, yeah was having some connection problems, closed the others | 09:31 |
| rameshg87 | lucasagomes: nothing else I guess. | 09:31 |
| rameshg87 | lucasagomes: we can close the bug | 09:31 |
| lucasagomes | rameshg87, ack! Thanks | 09:31 |
| sambetts | Morning dtantsur|brb, I'm getting a weird error running the inspector-tests locally, FileNotFoundError: [Errno 2] No such file or directory: 'iptables' I think we might be missing another mock somewhere | 09:33 |
| *** mgoddard1 has joined #openstack-ironic | 09:34 | |
| *** mgoddard has quit IRC | 09:35 | |
| sambetts | dtantsur|brb: I'll put up a patch for it | 09:40 |
| *** bradjones|away has quit IRC | 09:47 | |
| *** bradjones has joined #openstack-ironic | 09:49 | |
| *** bradjones has quit IRC | 09:49 | |
| *** bradjones has joined #openstack-ironic | 09:49 | |
| *** alexpilotti has joined #openstack-ironic | 09:50 | |
| *** dims_ has joined #openstack-ironic | 09:52 | |
| openstackgerrit | Merged stackforge/proliantutils: Make proliantutils return 1 size less than actual disk size https://review.openstack.org/221686 | 09:52 |
| *** Nisha_away has joined #openstack-ironic | 09:55 | |
| *** Nisha has quit IRC | 09:55 | |
| *** dims_ has quit IRC | 09:57 | |
| *** naohirot has quit IRC | 09:57 | |
| openstackgerrit | Sam Betts proposed openstack/ironic-inspector: Add API Discovery to Ironic Inspector https://review.openstack.org/215067 | 09:58 |
| TheJulia | Good morning | 09:59 |
| *** chlong has quit IRC | 10:09 | |
| *** shuquan has quit IRC | 10:09 | |
| *** chlong has joined #openstack-ironic | 10:11 | |
| sambetts | Morning TheJulia | 10:14 |
| lucasagomes | TheJulia, sambetts morning | 10:15 |
| *** romainh has quit IRC | 10:17 | |
| openstackgerrit | Sam Betts proposed openstack/ironic-inspector: Add mock for check_call to all firewall tests https://review.openstack.org/223503 | 10:18 |
| *** dtantsur|brb is now known as dtantsur | 10:21 | |
| dtantsur | sambetts, oh, good catch | 10:22 |
| dtantsur | TheJulia, morning | 10:22 |
| sambetts | dtantsur: My system seems to catch all the weird edge cases :-P | 10:22 |
| dtantsur | hehe | 10:23 |
| *** mgoddard1 has quit IRC | 10:27 | |
| *** mgoddard has joined #openstack-ironic | 10:28 | |
| *** wendar has quit IRC | 10:31 | |
| openstackgerrit | Nisha Agarwal proposed stackforge/proliantutils: Fix ribcl to return correct number of processors https://review.openstack.org/221678 | 10:31 |
| *** wendar has joined #openstack-ironic | 10:31 | |
| *** Nisha_away has quit IRC | 10:37 | |
| *** shoutm_ has quit IRC | 10:40 | |
| *** shoutm has joined #openstack-ironic | 10:41 | |
| *** dims_ has joined #openstack-ironic | 10:44 | |
| *** romcheg has quit IRC | 10:51 | |
| *** romcheg has joined #openstack-ironic | 10:52 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: [WIP] Add a proper client object https://review.openstack.org/223490 | 10:55 |
| *** itsuugo has quit IRC | 10:56 | |
| *** itsuugo has joined #openstack-ironic | 11:02 | |
| TheJulia | lucasagomes: so that bug you closed out about an hour ago, regarding config drives, I just reproduced. :( | 11:04 |
| lucasagomes | TheJulia, oh so it's not fixed? | 11:04 |
| lucasagomes | rameshg87, ^ | 11:05 |
| TheJulia | lucasagomes: digging through the patches first, I may have sqashed the fix in something I did | 11:05 |
| rameshg87 | TheJulia: on which driver is it ? | 11:05 |
| *** shoutm has quit IRC | 11:05 | |
| TheJulia | Yeah, I reproduced it because of my pxe template | 11:06 |
| TheJulia | I thought it had been somewhat fixed elsewhere, looks like it was only ever put in the template :( and coreos still has the base bug | 11:07 |
| rameshg87 | TheJulia: so do you use a custom template for pxe driver without coreos.configdrive kernel option ? | 11:08 |
| TheJulia | yup, for some reason I thought it was fixed so I took it out of my template | 11:08 |
| TheJulia | Oh well | 11:08 |
| * TheJulia fixes | 11:08 | |
| *** ishant has quit IRC | 11:08 | |
| rameshg87 | TheJulia: okay | 11:08 |
| rameshg87 | lucasagomes: ^^ | 11:09 |
| lucasagomes | right | 11:09 |
| * lucasagomes brb lunch | 11:11 | |
| *** shoutm has joined #openstack-ironic | 11:14 | |
| *** [1]cdearborn has joined #openstack-ironic | 11:15 | |
| *** e0ne has quit IRC | 11:22 | |
| *** sdake has joined #openstack-ironic | 11:25 | |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Correct pxe template for CoreOS config drive https://review.openstack.org/223534 | 11:26 |
| *** itsuugo has quit IRC | 11:27 | |
| *** sdake_ has joined #openstack-ironic | 11:31 | |
| *** sdake has quit IRC | 11:31 | |
| *** MattMan has joined #openstack-ironic | 11:32 | |
| *** itsuugo has joined #openstack-ironic | 11:36 | |
| *** athomas_ has joined #openstack-ironic | 11:39 | |
| *** lazy_prince has quit IRC | 11:40 | |
| *** amotoki has quit IRC | 11:42 | |
| *** athomas has quit IRC | 11:42 | |
| *** stendulker has quit IRC | 11:47 | |
| *** lucasagomes is now known as lucas-hungry | 11:47 | |
| *** itsuugo has quit IRC | 11:48 | |
| *** trown|outttypeww is now known as trown | 11:49 | |
| *** coolsvap_ has joined #openstack-ironic | 11:56 | |
| *** nicodemos has joined #openstack-ironic | 12:07 | |
| *** Haomeng|2 has joined #openstack-ironic | 12:07 | |
| *** Haomeng has quit IRC | 12:10 | |
| *** romainh has joined #openstack-ironic | 12:12 | |
| *** athomas_ has quit IRC | 12:13 | |
| *** baoli has joined #openstack-ironic | 12:13 | |
| *** itsuugo has joined #openstack-ironic | 12:22 | |
| *** athomas has joined #openstack-ironic | 12:24 | |
| *** nicodemos has quit IRC | 12:24 | |
| *** shoutm has quit IRC | 12:24 | |
| *** athomas has quit IRC | 12:25 | |
| *** sdake_ has quit IRC | 12:30 | |
| *** saripurigopi has quit IRC | 12:34 | |
| openstackgerrit | Yuiko Takada proposed openstack/ironic-inspector: [WIP]Support IPA for devstack-plugin https://review.openstack.org/223563 | 12:35 |
| *** VikasC has quit IRC | 12:36 | |
| *** lucas-hungry is now known as lucasagomes | 12:37 | |
| *** karimb has joined #openstack-ironic | 12:38 | |
| *** karimb has quit IRC | 12:39 | |
| *** karimb has joined #openstack-ironic | 12:39 | |
| *** itsuugo has quit IRC | 12:42 | |
| *** itsuugo has joined #openstack-ironic | 12:43 | |
| *** karimb has quit IRC | 12:46 | |
| *** thiagop has quit IRC | 12:47 | |
| *** dlpartain has joined #openstack-ironic | 12:49 | |
| *** puranamr has joined #openstack-ironic | 12:49 | |
| *** rloo has joined #openstack-ironic | 12:53 | |
| *** puranamr has quit IRC | 12:55 | |
| *** rameshg87 has quit IRC | 12:58 | |
| *** smoriya has quit IRC | 13:01 | |
| *** cdearborn has joined #openstack-ironic | 13:11 | |
| *** thiagop has joined #openstack-ironic | 13:12 | |
| thiagop | good morning Ironicers | 13:13 |
| *** itsuugo has quit IRC | 13:13 | |
| thiagop | is the gate broken again? | 13:14 |
| *** coolsvap_ has quit IRC | 13:19 | |
| dtantsur | thiagop, morning, not sure | 13:19 |
| jroll | it was yesterday | 13:20 |
| *** dlpartain has left #openstack-ironic | 13:20 | |
| jroll | thiagop: which patch are you looking at? | 13:20 |
| jroll | and, good morning everyone | 13:20 |
| trown | good morning jroll dtantsur thiagop | 13:20 |
| dtantsur | morning trown, jroll | 13:21 |
| *** dims_ has quit IRC | 13:21 | |
| *** dims_ has joined #openstack-ironic | 13:22 | |
| *** itsuugo has joined #openstack-ironic | 13:23 | |
| *** yog_ has quit IRC | 13:24 | |
| *** yog_ has joined #openstack-ironic | 13:24 | |
| *** [1]cdearborn has quit IRC | 13:25 | |
| thiagop | morning jroll dtantsur trown | 13:25 |
| *** ukalifon has joined #openstack-ironic | 13:26 | |
| thiagop | I'm in fact wondering if I should recheck the oneview patch, but the whiteboard says the gate is broken with a different problem than yesterday | 13:26 |
| thiagop | (postgres) | 13:26 |
| rloo | thiagop: my understanding is that the neutron fix, fixed the gate yesterday. i'm going to update the etherpad. Do you see a different issue? | 13:32 |
| thiagop | the whiteboard says something about pxe_ssh rloo. I didn't checked that though | 13:33 |
| thiagop | rloo: morning, btw | 13:33 |
| thiagop | :) | 13:33 |
| rloo | thiagop: i know, that's what i meant. am going to update the etherpad. | 13:33 |
| rloo | thiagop: if you believe what the etherpad says, look again! | 13:33 |
| thiagop | rloo: lol | 13:34 |
| rloo | yes, hi thiagop and everyone else :) | 13:34 |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: CORS configuration support https://review.openstack.org/223589 | 13:37 |
| NobodyCam | good morning Ironicers | 13:42 |
| thiagop | morning NobodyCam | 13:42 |
| *** BobBall has joined #openstack-ironic | 13:42 | |
| NobodyCam | mornign thiagop | 13:42 |
| NobodyCam | morning thiagop jroll lucasagomes dtantsur sambetts jlvillal rloo | 13:43 |
| dtantsur | morning NobodyCam | 13:43 |
| rloo | morning NobodyCam | 13:44 |
| NobodyCam | morning :) | 13:44 |
| *** shuquan has joined #openstack-ironic | 13:45 | |
| openstackgerrit | Juliana Motira proposed stackforge/pyghmi: Add custom OEM domain name command for Lenovo ThinkServers https://review.openstack.org/221911 | 13:45 |
| *** itsuugo has quit IRC | 13:47 | |
| *** ukalifon has quit IRC | 13:47 | |
| BobBall | How do I add a node using pxe_ssh? I've set ssh_address etc, but the node gets set in maintenance mode because 'Node <ssh_addr> could not be found'. Does the hypervisor need to be added as a node and if so, what driver etc? | 13:47 |
| lucasagomes | NobodyCam, thiagop jroll rloo morning | 13:48 |
| thiagop | morning lucasagomes | 13:48 |
| NobodyCam | :) | 13:48 |
| *** itsuugo has joined #openstack-ironic | 13:49 | |
| thiagop | BobBall: did you check if the node can ping the conductor? | 13:49 |
| lucasagomes | BobBall, hi there, to register a node you need to enable pxe_ssh in the ironic.conf and then register a node with "ironic node-create -d pxe_ssh ..." | 13:49 |
| lucasagomes | BobBall, you seem to have done it already | 13:49 |
| *** nicodemos has joined #openstack-ironic | 13:49 | |
| *** shuquan has quit IRC | 13:49 | |
| lucasagomes | BobBall, now for the ssh_addr thing, you seem to missing the credentials? You also need to tell the server the ssh_username and ssh_password? | 13:50 |
| jroll | thiagop: it was postgres that was broken yesterday | 13:50 |
| lucasagomes | and ssh_virt_type | 13:50 |
| *** shuquan has joined #openstack-ironic | 13:50 | |
| BobBall | Hang on - the node needs access to the conductor?? I assumed (and still hope) that just the ironic server needed to access the ssh_address? | 13:50 |
| BobBall | lucasagomes: All set, yes - I just didn't paste the credentials in here :) | 13:50 |
| BobBall | Ah - they are *'ed out | 13:51 |
| BobBall | | driver_info | {u'ssh_username': u'root', u'ssh_virt_type': u'xenserver', | | 13:51 |
| BobBall | | | u'ssh_address': u'10.219.10.32', u'ssh_password': u'******'} | | 13:51 |
| BobBall | (yes, yes, I know that 'xenserver' is new *cough*) | 13:51 |
| lucasagomes | heh yeah I would say that :-P | 13:51 |
| BobBall | I'm hacking it up currently just to see what we can get working - in advance of submitting a spec etc ;) | 13:52 |
| lucasagomes | BobBall, yeah AFAICT only the conductor need access to the ssh address so it can log into it | 13:52 |
| lucasagomes | and issue the hypervisor commands | 13:52 |
| BobBall | The conductor can ssh to the ssh address just fine, yes | 13:52 |
| lucasagomes | and the hypervisor commands are working properly? Can you start/stop a vm there? | 13:52 |
| lucasagomes | note that IIRC, the code uses the port MAC address to find the right VM to start and stop | 13:53 |
| trown | dtantsur: the [discover]/database option moved to [database]/connection but it no longer takes a path to a sqlite file...is the intention to use the same SQL database as Ironic now? | 13:53 |
| lucasagomes | so make sure you also have a port registered within ur node | 13:53 |
| *** Haomeng has joined #openstack-ironic | 13:54 | |
| BobBall | Well that's what I'm trying to hack up. So I wanted things like "set-node-powerstate <node> off" to work, but this is still calling the node the "ssh_address" which is confusing me royally | 13:54 |
| dtantsur | trown, it uses a bit weird syntax: https://github.com/openstack/ironic-inspector/blob/master/devstack/plugin.sh#L138 | 13:54 |
| dtantsur | trown, but we should probably switch to mysql/whatever is default | 13:55 |
| trown | dtantsur: ah, perfect, thanks | 13:55 |
| lucasagomes | BobBall, but that's correct right? I mean the ironic-conductor will ssh into <ssh_address> | 13:55 |
| BobBall | Hmmmz... Hang on a mo... Just spotted something in the logs. Let me dig a bit then I'll come back with more q's | 13:55 |
| lucasagomes | BobBall, what's confusing about it? | 13:55 |
| lucasagomes | ok | 13:55 |
| BobBall | Yes, it is doing that | 13:55 |
| jroll | I'm thinking it's the word 'node' that's confusing | 13:55 |
| jroll | because the hypervisor host isn't an ironic node | 13:55 |
| lucasagomes | yeah it can be any node | 13:56 |
| BobBall | OK; I think I may have spotted something... Could it be that the interpretation of what a 'MAC' is seems inconsistent between the SSH drivers (i.e. upper vs lower case, with or without ':'s) | 13:57 |
| *** Haomeng|2 has quit IRC | 13:57 | |
| jroll | BobBall: yeah, depends what the xen command returns I guess | 13:58 |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: Add a proper client object https://review.openstack.org/223490 | 13:58 |
| jroll | e.g. look at the sed in the parallels get_node_macs command, heh | 13:58 |
| jroll | that does sound like it could be the issue, though | 13:59 |
| *** mgoddard has quit IRC | 14:00 | |
| *** mgoddard has joined #openstack-ironic | 14:00 | |
| BobBall | Yup - but different ssh drivers have different mac formats: parallels is clearly lower case (with : separators?) and vbox is upper case with no : separators :) | 14:01 |
| * BobBall assumed we had to conform to a particular format | 14:02 | |
| jroll | BobBall: right, see also _normalize_mac | 14:02 |
| BobBall | Ah - so the node I register needs a lower case MAC with no :'s? | 14:02 |
| jroll | so don't worry about upper/lower case, and it looks like it needs to have no separator, or : or - | 14:03 |
| BobBall | no, it'll normalize both ways... drat | 14:03 |
| jlvillal | NobodyCam, Good morning | 14:03 |
| jroll | _normalize_mac will handle upper/lower, deadbeef, de:ad:be:ef, and de-ad-be-ef | 14:03 |
| lucasagomes | it should yes | 14:03 |
| jlvillal | Good morning lucasagomes jroll trown dtantsur rloo BobBall and everyone else | 14:04 |
| lucasagomes | (if not that's another bug) | 14:04 |
| jroll | ohai jlvillal | 14:04 |
| lucasagomes | jlvillal, hi there morning | 14:04 |
| BobBall | morning :) | 14:04 |
| * BobBall will dig into why it can't find the MAC | 14:04 | |
| lucasagomes | :-) | 14:04 |
| jroll | BobBall: just to be sure, you have a port for the node, right? | 14:04 |
| rloo | morning jlvillal, lucasagomes and anyone else I missed | 14:04 |
| BobBall | Yes | 14:05 |
| jroll | if you want to paste DEBUG logs I can try to see if I see something | 14:05 |
| jroll | cool | 14:05 |
| lucasagomes | rloo, btw re abort... take a look at the answers see if it makes sense | 14:05 |
| lucasagomes | (when you have some time) | 14:06 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Fix string formatting issues https://review.openstack.org/222862 | 14:06 |
| rloo | lucasagomes: oh yeah. i started to think about it and got distracted. give me a few minutes to think about it a bit more. | 14:06 |
| lucasagomes | rloo, no rush | 14:06 |
| *** lsmola has quit IRC | 14:06 | |
| trown | o/ jlvillal | 14:06 |
| thiagop | morning jlvillal | 14:08 |
| *** itsuugo has quit IRC | 14:09 | |
| BobBall | Thanks guys; I had a very stupid error in my mac-list command - was using the NAME in the wrong place. It's working nicely now. | 14:10 |
| jroll | hah | 14:10 |
| jroll | awesome :) | 14:11 |
| *** gabriel-bezerra has quit IRC | 14:11 | |
| *** gabriel-bezerra has joined #openstack-ironic | 14:11 | |
| *** shuquan has quit IRC | 14:15 | |
| *** mtanino has joined #openstack-ironic | 14:15 | |
| *** david-lyle has quit IRC | 14:20 | |
| *** krtaylor has quit IRC | 14:21 | |
| rloo | lucasagomes: you have a few minutes to discuss? | 14:21 |
| *** itsuugo has joined #openstack-ironic | 14:21 | |
| rloo | lucasagomes: to some extent, the abort has a similar issue as with your proposed delete (or whatever it was) | 14:21 |
| rloo | lucasagomes: we want to defer doing something until later. ie, queue something up. | 14:22 |
| rloo | lucasagomes: I think if we can abort 'now', then the code is fine. the issue is with aborting 'after'. | 14:22 |
| rloo | lucasagomes: i think it is very confusing to see in the state machine diagram, that one can 'abort' when a node is in CLEANING, and the API sort of allows you to do that but will always return an error. | 14:23 |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: Add a proper client object https://review.openstack.org/223490 | 14:23 |
| trown | dtantsur: in the devstack plugin we configure both [ironic] and [keystone_authtoken] with credentials...is that required? | 14:23 |
| rloo | lucasagomes: at the very least, the API should return InvalidStateRequested. except that it is 'allowed' if you look at the state machine. | 14:24 |
| dtantsur | trown, yep. ironic is for accessing ironic, keystone_authtoken is for authenticating clients, swift for accesing swift. all is required. | 14:24 |
| dtantsur | in theory, all these could (and maybe should) be different | 14:24 |
| trown | dtantsur: ok, makes sense... I think I was getting confused by the deprecated message, but I see that is for the old discoverd options | 14:25 |
| dtantsur | trown, yeah, previously it was a mess | 14:25 |
| *** harshs has joined #openstack-ironic | 14:27 | |
| lucasagomes | rloo, API will answer NodeLocked right? | 14:27 |
| rloo | lucasagomes: yeah. Doesn't seem like a good user experience. | 14:27 |
| lucasagomes | rloo, the same if you try to do a delete in the node which is DEPLOYING | 14:27 |
| lucasagomes | rloo, right, but consistent with the rest | 14:27 |
| lucasagomes | this is not something that is part of the scope of that patch IMHO | 14:28 |
| lucasagomes | the NodeLocked is a problem apart (if you count with the retry, even more) | 14:28 |
| rloo | lucasagomes: http://docs.openstack.org/developer/ironic/_images/states.svg | 14:28 |
| rloo | lucasagomes: you cannot delete when deploying | 14:29 |
| rloo | lucasagomes: if you look at the state machine diagram | 14:29 |
| rloo | lucasagomes: with your change, the diagram will show that you can abort from cleaning | 14:29 |
| rloo | lucasagomes: besides confusing me, i suspect it will confuse others. | 14:29 |
| *** achanda has joined #openstack-ironic | 14:30 | |
| rloo | lucasagomes: and i suspect it is wrong. i think we're trying to hack something here. like the 'queuing of events'. | 14:30 |
| *** Nisha has joined #openstack-ironic | 14:30 | |
| jroll | if aborting from CLEANING will never work, why add it to the state machine? | 14:30 |
| rloo | jroll: cuz of the way it is coded. | 14:31 |
| lucasagomes | jroll, cause it was requested to if the clean step is not abortable | 14:31 |
| lucasagomes | we should wait it finish and then abort cleaing | 14:31 |
| lucasagomes | cleaning* | 14:31 |
| jroll | but if the API will return 409 | 14:31 |
| *** achanda has quit IRC | 14:31 | |
| jroll | we don't ever get to that part | 14:31 |
| rloo | jroll: a user can make the rquest to abort from CLEANWAIT, but if the cleanstep isn't abortable, a flag is added to abort after the step is finished | 14:31 |
| lucasagomes | and that happens when the node is in CLEANING state (_do_next_clean_step()) | 14:31 |
| *** kbyrne has quit IRC | 14:31 | |
| jroll | mmm. | 14:31 |
| rloo | lucasagomes: so i was going to propose that if the user indicates an abort, we should always abort, regardless of whetther it is the last/final step in a clean operation. | 14:32 |
| jroll | in that case, you could move it back to CLEANWAIT and then abort it? | 14:32 |
| *** rameshg87 has joined #openstack-ironic | 14:32 | |
| rloo | lucasagomes: and i think if we do that, we can do the abort when in cleanwait, before the 'resume' is done. | 14:32 |
| rameshg87 | rloo: hi | 14:32 |
| rloo | lucasagomes: ha ha, or do as jroll suggests; i hadn't thought of that. | 14:32 |
| rloo | rameshg87: hi, didn't know you were around. | 14:33 |
| rameshg87 | rloo: were you looking for me ? ;-) | 14:33 |
| lucasagomes | rloo, jroll move to CLEANWAIT and abort it? | 14:33 |
| rameshg87 | rloo: just a quick one on https://review.openstack.org/#/c/220895/4/ironic/drivers/modules/deploy_utils.py L88 | 14:33 |
| jroll | rloo: yeah, or do it before it goes to CLEANING like you say | 14:33 |
| lucasagomes | well yeah, I mean that works | 14:33 |
| rloo | rameshg87: i was wondering what the status was with the inband raid stuff. are you waiting for reviewers, or are we waiting on you. hadn't had a chance to look today. | 14:34 |
| lucasagomes | jroll, rloo ok I will investigate that | 14:34 |
| lucasagomes | rloo, that works for you? | 14:34 |
| jroll | lucasagomes: just an idea :) | 14:34 |
| rameshg87 | rloo: waiting for reviewers to review | 14:34 |
| rameshg87 | rloo: first waiting for spec to merge | 14:34 |
| rloo | lucasagomes: yeah. | 14:34 |
| rloo | rameshg87: ok. | 14:34 |
| lucasagomes | jroll, right yeah it's good. I mean I don't mind wether it's on CLEANING or CLEANWAIT, apart from the diagram there | 14:34 |
| lucasagomes | that will show something different | 14:34 |
| lucasagomes | but still... state machine is internal... not all that it does needs to also be able to do in the API | 14:35 |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: Add a proper client object https://review.openstack.org/223490 | 14:35 |
| rloo | lucasagomes: the state machine is what we're showing 'the world' wrt what happens to a node. | 14:36 |
| rloo | lucasagomes: and the 'verbs' that can be used to change the node's provision state. | 14:36 |
| rloo | lucasagomes: which is why i think we need to update it to show the new 'abort' verb | 14:36 |
| *** harshs has quit IRC | 14:36 | |
| lucasagomes | rloo, I'm fine with that | 14:36 |
| lucasagomes | rloo, just saying that I don't think that the CLEANING->CLEANFAIL with abort being part of the state machine is incorrect | 14:37 |
| lucasagomes | even if it's not exposed in the API | 14:37 |
| rloo | lucasagomes: sorry, do you have time to re-review rameshg87's raid spec update: https://review.openstack.org/#/c/222133/ | 14:37 |
| *** kbyrne has joined #openstack-ironic | 14:37 | |
| lucasagomes | rloo, yup, will do | 14:37 |
| rloo | lucasagomes: but i think it is incorrect, because it would make it look like a user could issue an 'abort' in CLEANING, but they can't. | 14:37 |
| lucasagomes | jroll, rloo btw, I saw this bug https://bugs.launchpad.net/ironic/+bug/1384379 was in the list of prioritize but nobody was working on it so I'm fixing | 14:38 |
| openstack | Launchpad bug 1384379 in Trove "versions resource uses host_url which may be incorrect" [Medium,In progress] - Assigned to Nikhil Manchanda (slicknik) | 14:38 |
| *** kbyrne has quit IRC | 14:38 | |
| lucasagomes | but there's different ways to fix it (see the other projects patches). I'm doing something similar to the glance/cinder fix (already merged) | 14:38 |
| jroll | lucasagomes: cool, thank you | 14:38 |
| rloo | lucasagomes: thx. maybe add to the etherpad then. | 14:39 |
| lucasagomes | writing the tests will push it soon | 14:40 |
| *** gabriel-bezerra has quit IRC | 14:40 | |
| *** kbyrne has joined #openstack-ironic | 14:40 | |
| rloo | lucasagomes: i could be wrong wrt the state machine diagram. we have other verbs/transitions that the user cannot initiate i think. (guess that's a separate issue). | 14:40 |
| jroll | I'm going to go through the stuff on the etherpad today and mark it liberty-rc-potential or something | 14:40 |
| jroll | jfyi | 14:41 |
| lucasagomes | rloo, yeah, it's fine I'm ok moving it to CLEANWAIT (or doing it before it resume) | 14:41 |
| rloo | jroll: i thought all the stuff on the etherpad was liberty-rc-potential? | 14:41 |
| jroll | rloo: I haven't marked it in launchpad or anything | 14:41 |
| rloo | jroll: oh, or do you mean mark that on the bug etc. | 14:41 |
| rloo | jroll: got it! | 14:41 |
| jroll | yeah | 14:41 |
| jroll | :) | 14:41 |
| *** itsuugo has quit IRC | 14:41 | |
| jroll | launchpad is kind of a mess right now; moreso in blueprints than bugs | 14:42 |
| lucasagomes | rloo, so the only thing changed on that spec is the work on the IPA side? | 14:42 |
| rloo | lucasagomes: yeah. (from the previous revision) | 14:43 |
| lucasagomes | yup, ok yeah I was ok with the state on the previous patch | 14:43 |
| lucasagomes | anyone wants to take a quick look on https://review.openstack.org/#/c/222133/ before I push the final button? | 14:43 |
| rloo | lucasagomes: and he fixed the typo you pointed out :) | 14:43 |
| lucasagomes | rloo, heh yeah | 14:43 |
| lucasagomes | that's fine | 14:44 |
| lucasagomes | +a | 14:44 |
| *** [1]cdearborn has joined #openstack-ironic | 14:44 | |
| jroll | lucasagomes: heh, you beat me to it | 14:44 |
| lucasagomes | :-) | 14:45 |
| jroll | pushing a quick followup | 14:45 |
| *** harshs has joined #openstack-ironic | 14:45 | |
| lucasagomes | jroll, I can remove the +a | 14:45 |
| jroll | nah it's cool | 14:45 |
| jroll | just a nit | 14:45 |
| lucasagomes | ok... (/me adds the +a again) | 14:46 |
| dtantsur | trown, if you plan to make a client patch, please base it on https://review.openstack.org/#/c/223490/ so that we don't have terrible merge conflicts | 14:46 |
| jroll | meh, git-review is being weird :( | 14:47 |
| *** Nisha has quit IRC | 14:47 | |
| jroll | I'll wait til it merges | 14:47 |
| jroll | bbiaf | 14:47 |
| trown | dtantsur: yep, will do | 14:48 |
| *** Nisha has joined #openstack-ironic | 14:48 | |
| openstackgerrit | Merged openstack/ironic-specs: Update in-band agent raid spec https://review.openstack.org/222133 | 14:48 |
| jroll | oh there it goes | 14:48 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic-specs: s/agent_ipminative/agent_pyghmi/ in inband RAID spec https://review.openstack.org/223628 | 14:49 |
| rloo | jroll: specs merge too fast. we have to add more tests! :) | 14:49 |
| jroll | there, super easy review | 14:49 |
| jroll | hahaha | 14:49 |
| dtantsur | rloo, something on devstack | 14:49 |
| *** amotoki has joined #openstack-ironic | 14:50 | |
| BobBall | OK; so now I've got a networking issue that the nodes don't get a DHCP address (while trying to do openstack baremetal introspection bulk start). Should these be served by discoverd? The conf file has the right interface, and this interface is (according to tcpdump) receiving DHCP requests but no response is sent. | 14:51 |
| lucasagomes | wow I didn't know it was agent_pyghmi! | 14:51 |
| lucasagomes | BobBall, yes, ironic-discoverd (now called ironic-inspector) has it's own dhcp server | 14:52 |
| lucasagomes | dtantsur, ^ | 14:52 |
| BobBall | And it seems that ironic-discoverd doesn't have any log files? :) | 14:52 |
| trown | BobBall: look at the journal | 14:53 |
| dtantsur | BobBall, depending on your system, journalctl -u openstack-ironic-discoverd -u openstack-ironic-discoverd-dnsmasq | 14:53 |
| dtantsur | that's for RH-based systems | 14:53 |
| BobBall | Ah - ok, thanks. | 14:53 |
| BobBall | Great - yes, logs be there! | 14:53 |
| dtantsur | BobBall, logs from openstack-ironic-discoverd-dnsmasq are particularly interesting for your case | 14:54 |
| *** shoutm has joined #openstack-ironic | 14:54 | |
| *** achanda has joined #openstack-ironic | 14:58 | |
| *** cdearborn has quit IRC | 14:59 | |
| *** itsuugo has joined #openstack-ironic | 14:59 | |
| *** thrash has quit IRC | 15:01 | |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Check image size before provisioning for agent driver https://review.openstack.org/215254 | 15:01 |
| *** mgoddard has quit IRC | 15:02 | |
| rameshg87 | rloo: just a quick question, do we ever need to remove off the deprecated names of conf options ? | 15:02 |
| rloo | rameshg87: well, we never need to delete anything that is deprecated. do we? but I think we like to. | 15:03 |
| jroll | can someone approve https://review.openstack.org/#/c/223628/ just to get it off my list? :P | 15:03 |
| rameshg87 | rloo: what's the general policy ? because oslo_config doesn't let us know if people are using the deprecated name or the current name | 15:03 |
| *** Nisha has quit IRC | 15:03 | |
| rloo | jroll: that's a hard one. not sure i want to approve it. | 15:03 |
| *** mgoddard has joined #openstack-ironic | 15:03 | |
| jroll | and yes, we should remove deprecated names at some point - per the new guidelines it's one cycle and at least 3 months between deprecating and removing | 15:04 |
| *** thrash has joined #openstack-ironic | 15:04 | |
| *** thrash has quit IRC | 15:04 | |
| *** thrash has joined #openstack-ironic | 15:04 | |
| rloo | rameshg87: i think our general policy is one release. other things we deprecated during liberty, are slated for deletion in Mitaka. | 15:04 |
| jroll | rloo: thanks ;) | 15:04 |
| rameshg87 | jroll: so how do we tell the operators ? | 15:04 |
| rameshg87 | jroll: rloo: only by documentation ? | 15:04 |
| rloo | jroll: oh, did they decide? | 15:04 |
| jroll | rameshg87: deprecated_name logs a deprecation warning afaik | 15:04 |
| jroll | rloo: http://lists.openstack.org/pipermail/openstack-dev/2015-September/074484.html | 15:05 |
| * rameshg87 checks | 15:05 | |
| rloo | jroll: how do you find those links so quickly? | 15:05 |
| jroll | rloo: go to http://lists.openstack.org/pipermail/openstack-dev/2015-$MONTH | 15:05 |
| jroll | and ctrl-f | 15:05 |
| jroll | also, I just read that email this morning so it's fresh in my mind, I knew thierry sent it and 'deprecat' was in the title :) | 15:06 |
| rameshg87 | :) | 15:06 |
| *** achanda has quit IRC | 15:06 | |
| rloo | jroll: ah, ok. seems like google should be crawling all this stuff but i haven't actually looked. i don't like having to go to the month etc. | 15:06 |
| *** zhenguo has quit IRC | 15:06 | |
| jroll | rameshg87: https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1526 | 15:07 |
| rameshg87 | jroll: yeah it does | 15:07 |
| rameshg87 | thanks | 15:07 |
| jroll | np | 15:07 |
| *** gabriel-bezerra has joined #openstack-ironic | 15:07 | |
| *** blakec has joined #openstack-ironic | 15:08 | |
| rloo | jroll, rameshg87: the problem is that it logs that it is deprecated, but doesn't mention when it will be deleted. | 15:08 |
| rloo | jroll, rameshg87: but I guess that is good enough for now. | 15:08 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add config option to override url for links https://review.openstack.org/223640 | 15:08 |
| rloo | rameshg87: maybe put in the commit msg, that it is deprecated/will be deleted in Mitaka. | 15:09 |
| openstackgerrit | Merged openstack/ironic-specs: s/agent_ipminative/agent_pyghmi/ in inband RAID spec https://review.openstack.org/223628 | 15:09 |
| rameshg87 | rloo: sure | 15:09 |
| jroll | rloo: yeah, though generally if folks see a deprecation warning they should fix it asap... which is why the new guideline exists, gives both continuous deployers and stable deployers ample time to fix their config | 15:09 |
| rloo | jroll: and for other projects too, like us, to update our code. now we only have 3 months :) | 15:10 |
| jroll | heh | 15:11 |
| dtantsur | jroll, when you have a second of time, could you please review one more agent patch? https://review.openstack.org/#/c/223054 it's pretty important for the inspector release | 15:11 |
| jroll | dtantsur: sure thing | 15:11 |
| * dtantsur hopes it's the last agent patch for inspector this cycle... | 15:11 | |
| *** david-lyle has joined #openstack-ironic | 15:13 | |
| rloo | rameshg87: in case you miss it, i added comments to https://review.openstack.org/#/c/220895/ | 15:15 |
| rameshg87 | rloo: thanks | 15:16 |
| jroll | dtantsur: just one question inline, but +2 | 15:16 |
| *** shoutm has quit IRC | 15:17 | |
| dtantsur | jroll, answered. guess_root_disk modifies its argument | 15:18 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Refactor agent {prepare,tear_down}_cleaning into deploy_utils https://review.openstack.org/220895 | 15:18 |
| jroll | oh, so it's a copy | 15:18 |
| jroll | got it | 15:18 |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: [WIP] Support for introspection rules https://review.openstack.org/223096 | 15:18 |
| dtantsur | jroll, well, yeah :) it's a full slice of a list | 15:19 |
| jroll | right | 15:20 |
| jroll | it's still early here :) | 15:20 |
| *** harshs has quit IRC | 15:20 | |
| *** e0ne has joined #openstack-ironic | 15:20 | |
| dtantsur | :) | 15:21 |
| dtantsur | have to go earlier today, see you tomorrow | 15:21 |
| *** dtantsur is now known as dtantsur|afk | 15:21 | |
| thiagop | night dtantsur|afk | 15:22 |
| *** itsuugo has quit IRC | 15:24 | |
| jroll | later dtantsur|afk | 15:24 |
| *** pradipta has joined #openstack-ironic | 15:25 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add support for in-band cleaning in ISCSIDeploy https://review.openstack.org/220898 | 15:25 |
| * rameshg87 is done for the day | 15:25 | |
| rameshg87 | good night folks | 15:25 |
| *** rameshg87 has quit IRC | 15:25 | |
| *** Nisha has joined #openstack-ironic | 15:29 | |
| *** shadower has quit IRC | 15:30 | |
| *** slagle has quit IRC | 15:30 | |
| *** marios has quit IRC | 15:31 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Fix iBoot test__switch_retries test to not waste time sleeping https://review.openstack.org/223649 | 15:31 |
| *** coolsvap has quit IRC | 15:31 | |
| NobodyCam | night dtantsur|afk | 15:33 |
| *** garthb has joined #openstack-ironic | 15:33 | |
| NobodyCam | night rameshg87 | 15:33 |
| thiagop | night rameshg87 | 15:34 |
| BobBall | Curious... So is ironic-discoverd compiled somewhere? Adding the boot order control to ssh.py and removing *.pyc *.pyo from site-packages/ironic and restarting ironic-discoverd ends up with a stack trace that is clearly based on old source code (i.e. the lines do not match up and it still reports an exception that it shouldn't be reporting). Any thoughts? | 15:34 |
| *** boris-42 has joined #openstack-ironic | 15:35 | |
| trown | BobBall: it looks like you are actually editing ironic code | 15:36 |
| sambetts | BobBall: ironic discoverd (inspector now) is its own python package, so removing pyc from /ironic won't help | 15:36 |
| trown | BobBall: so you would need to restart ironic-conductor | 15:37 |
| *** itsuugo has joined #openstack-ironic | 15:38 | |
| BobBall | Ah, sorry, I should have thought of that. I'm going to just restart all ironic servers whenever I make a change. Clearly I don't understand the interactions between them. | 15:38 |
| trown | BobBall: no worries, its is complicated :) | 15:38 |
| lucasagomes | :-) | 15:40 |
| *** romcheg has quit IRC | 15:40 | |
| jroll | hm, is command['command_result']['clean_result'] from the agent a thing? | 15:41 |
| jroll | :/ | 15:41 |
| jroll | I don't remember ever seeing that | 15:41 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic-python-agent: Fixes incorrect description URL https://review.openstack.org/223657 | 15:41 |
| jroll | apparently it is, TIL | 15:41 |
| JoshNang | yeah, it returns that and the hardware manager versions in command result, iirc | 15:42 |
| JoshNang | oh nvm, that's get clean steps. execute returns result and what step was just executed | 15:42 |
| jroll | yeah, found it | 15:44 |
| *** puranamr has joined #openstack-ironic | 15:45 | |
| *** mgoddard1 has joined #openstack-ironic | 15:50 | |
| *** Nisha has quit IRC | 15:51 | |
| *** mgoddard has quit IRC | 15:51 | |
| BobBall | OK - So I'm still struggling here... journalctl is not showing any failures, it whitelists the MAC for eth1 on the firewall, but that's the only output it gives me (I turned on debugging too): Any other thoughts for where I can look for why discoverd isn't assigning a DHCP address? I've checked that we get the requests on the eth1 (http://paste.openstack.org/show/463164/) so I'm still thinking it's something wrong with my ironic setu | 15:53 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add config option to override url for links https://review.openstack.org/223640 | 15:54 |
| jroll | 2x+2 on https://review.openstack.org/#/c/198238/ if anyone else wants to take a look and approve it | 15:54 |
| lucasagomes | jroll, looking | 15:55 |
| *** marios has joined #openstack-ironic | 15:56 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add config option to override url for links https://review.openstack.org/223640 | 15:57 |
| jroll | ^ also fixed a quick nit and +2 | 15:58 |
| *** ifarkas has quit IRC | 15:58 | |
| *** mgoddard1 has quit IRC | 15:58 | |
| trown | BobBall: and your dnsmasq.conf also has eth1? I have only ever used a bridge for the dnsmasq, but I am not sure if that would be an issue | 15:59 |
| rloo | lucasagomes: wrt https://review.openstack.org/#/c/223640/, did you see the comment in the nova patch: https://review.openstack.org/#/c/160266/ | 15:59 |
| devananda | g'morning, all | 15:59 |
| rloo | morning devananda | 16:00 |
| jroll | ohai devananda | 16:00 |
| openstackgerrit | Sam Betts proposed openstack/ironic-inspector: Add alembic migrations for the inspector database https://review.openstack.org/223665 | 16:00 |
| thiagop | morning devananda | 16:00 |
| lucasagomes | jroll, cool, need to update the config tho | 16:00 |
| lucasagomes | sample | 16:00 |
| BobBall | yup trown | 16:00 |
| * lucasagomes fix | 16:00 | |
| BobBall | Well I can switch to a bridge... Let me test that | 16:00 |
| jroll | lucasagomes: damnit, lol | 16:00 |
| jroll | thanks | 16:00 |
| lucasagomes | jroll, heh I'm on it | 16:00 |
| trown | sambetts: do we really need migrations for a cache database? It is empty most of the time | 16:01 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add config option to override url for links https://review.openstack.org/223640 | 16:01 |
| lucasagomes | rloo, looking | 16:01 |
| *** mgoddard has joined #openstack-ironic | 16:01 | |
| lucasagomes | rloo, yeah, I based my fix on the glance and cinder fix | 16:01 |
| jroll | rloo: ehhh, that is a good idea, though x-forwarded-for isn't 100% reliable | 16:01 |
| jroll | so I'm conflicted | 16:01 |
| lucasagomes | rloo, ceilomter is proposing a different way | 16:01 |
| lucasagomes | different than nova and cinder/glance | 16:01 |
| BobBall | Damn trown - that was exactly the problem... Many thanks! Switching to the bridge I already had rather than the eth directly fixed it for me | 16:02 |
| lucasagomes | that's why I pointed you guys to take a look at the other proposed fixes | 16:02 |
| trown | BobBall: awesome | 16:02 |
| lucasagomes | FYI glance and cinder is already merged, so I considered that too | 16:02 |
| *** yog_ has quit IRC | 16:02 | |
| lucasagomes | devananda, morning | 16:02 |
| rloo | lucasagomes: oh, i was too lazy to look at all the options. Wanted to check that you saw the alternatives and picked the best one. | 16:03 |
| jroll | apparently the animals are hungry, bbiab | 16:03 |
| sambetts | trown: It was a wishlist we had in launchpad, so I started sketching a patch out, I need to dicuss it with dtantsur|afk and yuikotakada | 16:03 |
| lucasagomes | rloo, yeah, I think there's no best one. But the glance and cinder looked straight forward and they have been accepted already | 16:03 |
| lucasagomes | they use the same config option as the one we proposed for ironic | 16:04 |
| lucasagomes | so it's more consistent | 16:04 |
| trown | sambetts: cool, maybe there will be more stuff for that db eventually | 16:04 |
| *** slagle has joined #openstack-ironic | 16:04 | |
| trown | having migrations for the node cache seems silly to me | 16:04 |
| rloo | lucasagomes: well, it'll be consistent for 3 projects then. | 16:04 |
| sambetts | trown: we've got a little bit more than just a cache already because dtantsur|afk added inspector rules, so more advanced stuff, just is 3 more tables | 16:04 |
| trown | ah, right... | 16:05 |
| lucasagomes | rloo, yeah that was my thought but idk we can discuss better | 16:05 |
| *** blakec has quit IRC | 16:05 | |
| trown | sambetts: awesome then, thanks for working on that then | 16:05 |
| lucasagomes | rloo, the ceilometer one https://review.openstack.org/#/c/180929/ | 16:05 |
| trown | sambetts: that totally makes sense to have migrations for the rules | 16:05 |
| lucasagomes | rloo, but you can see in the comments cdent pointing the author to the glance fix too | 16:05 |
| sambetts | trown: Yeah :) | 16:06 |
| *** Marga_ has quit IRC | 16:10 | |
| lucasagomes | rloo, jroll another way to do it, we probably can merge both approches | 16:11 |
| lucasagomes | rloo, jroll check for the config option, if None, check for the header, if not set assume host_url | 16:11 |
| jroll | yeah, that might be the best route | 16:12 |
| rloo | lucasagomes: i think i looked at too many patches for that. looks like oslo.middleware has some support. | 16:12 |
| rloo | lucasagomes: and yeah, i was thinking it wouldn't hurt to have this option anyway. | 16:12 |
| *** itsuugo has quit IRC | 16:12 | |
| rloo | lucasagomes: i have a few nits i think for your patch. let me find/go back to it... | 16:12 |
| lucasagomes | rloo, ack, lemme look at oslo.middleware | 16:13 |
| rloo | lucasagomes: i saw it via the heat patch. but that would be a separate patch for us if we decided to do that. | 16:13 |
| lucasagomes | rloo, right, to complement the one I proposed? | 16:14 |
| rloo | lucasagomes: right. | 16:14 |
| lucasagomes | ok | 16:14 |
| *** romcheg has joined #openstack-ironic | 16:14 | |
| *** pradipta has quit IRC | 16:15 | |
| *** puranamr has quit IRC | 16:16 | |
| *** Marga_ has joined #openstack-ironic | 16:17 | |
| *** puranamr has joined #openstack-ironic | 16:17 | |
| rloo | lucasagomes: oh boy, i'm reviewing revision 1 and you're at revision 4 already! | 16:17 |
| lucasagomes | rloo, heh just nits | 16:18 |
| lucasagomes | rloo, sample config, and s/i.e/e.g | 16:18 |
| lucasagomes | in the config option string | 16:18 |
| lucasagomes | rest is same | 16:18 |
| rloo | lucasagomes: i had some nits/comments, so let me know what you think. | 16:18 |
| lucasagomes | cool thanks | 16:18 |
| *** vinbs has joined #openstack-ironic | 16:23 | |
| *** jistr has quit IRC | 16:24 | |
| *** itsuugo has joined #openstack-ironic | 16:25 | |
| *** romainh has left #openstack-ironic | 16:25 | |
| *** vinbs has quit IRC | 16:29 | |
| *** sdake has joined #openstack-ironic | 16:29 | |
| *** sdake_ has joined #openstack-ironic | 16:31 | |
| lucasagomes | rloo, Public URL to use when building the links to the API resources (e.g. \"https://ironic.rocks:6384\"). If None the links will be built using the request's host URL. If the API is operating behind a proxy, you will want to change this to represent the proxy's URL. Defaults to None | 16:32 |
| lucasagomes | ? | 16:32 |
| rloo | lucasagomes: thx, that's much better! | 16:33 |
| lucasagomes | rloo, ack thanks | 16:33 |
| rloo | lucasagomes: i need to check though, not sure we should be using e.g. vs for example. | 16:33 |
| lucasagomes | rloo, ok s/e.g/for example there | 16:34 |
| rloo | lucasagomes: ok thx. it's in the wiki guidelines for documenting but it always takes me awhile to find it. we use 'for example' in other places so I suspect we should do that. | 16:35 |
| *** sdake has quit IRC | 16:35 | |
| lucasagomes | ack | 16:35 |
| lucasagomes | for example is it | 16:35 |
| jroll | where's the "enable cleaning" flag for the agent driver, I can't find it :( | 16:36 |
| jroll | JoshNang: ^ you know offhand? | 16:37 |
| JoshNang | it's in the conductor, no driver specific one | 16:37 |
| jroll | aha | 16:37 |
| jroll | thanks | 16:37 |
| JoshNang | np | 16:37 |
| lucasagomes | jroll, clean_nodes = False | 16:38 |
| lucasagomes | IIRC | 16:38 |
| jroll | yep, found it | 16:38 |
| jroll | I was grepping 'enable' and 'cleaning' in the conf hah | 16:38 |
| lucasagomes | heh yeah, naming stuff is hard | 16:40 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add config option to override url for links https://review.openstack.org/223640 | 16:41 |
| *** marios has quit IRC | 16:45 | |
| *** harshs has joined #openstack-ironic | 16:49 | |
| *** puranamr has quit IRC | 16:49 | |
| *** lazy_prince has joined #openstack-ironic | 16:51 | |
| *** puranamr has joined #openstack-ironic | 16:51 | |
| *** itsuugo has quit IRC | 16:51 | |
| *** puranamr has quit IRC | 16:52 | |
| *** puranamr has joined #openstack-ironic | 16:52 | |
| *** blakec has joined #openstack-ironic | 16:55 | |
| jroll | jlvillal: mrda just to be sure you see it, time to line up nova bugs we want in liberty: http://lists.openstack.org/pipermail/openstack-dev/2015-September/074560.html | 16:55 |
| jlvillal | jroll, Thanks for the heads up | 16:56 |
| jroll | np | 16:56 |
| jlvillal | jroll, lucasagomes ^^^ Anything you see as critical to get into Nova for Ironic? I know lucasagomes you are working on the microversions. | 16:58 |
| jroll | idk, I'd have to look at the list | 16:58 |
| lucasagomes | jlvillal, same, there's a list somewhere? | 16:59 |
| lucasagomes | jlvillal, and thanks for the review on the microversions, that's a awesome catch! | 16:59 |
| jlvillal | jroll, lucasagomes , Okay. Just wanted to see if there was something that popped into your head. | 16:59 |
| jroll | yeah, nothing in mind at the moment | 16:59 |
| jroll | I can try to look at the list later | 16:59 |
| *** blakec has quit IRC | 17:00 | |
| *** trown is now known as trown|lunch | 17:00 | |
| jlvillal | lucasagomes, jroll: FYI this: https://bugs.launchpad.net/nova/+bugs?field.tag=ironic and also this: https://wiki.openstack.org/wiki/Nova-Ironic-Bugs (mrda) | 17:00 |
| jroll | yep | 17:01 |
| jroll | just need the time to look : | 17:01 |
| jroll | :P | 17:01 |
| lucasagomes | nice one | 17:02 |
| * lucasagomes looks | 17:02 | |
| * jlvillal finishes conference call and heads into work... | 17:02 | |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Correct pxe template for CoreOS config drive https://review.openstack.org/223534 | 17:03 |
| jroll | lucasagomes: sent a mail about the DIB patch for deprecating bash ramdisk | 17:05 |
| jroll | I'm going to be really frustrated if that doesn't land | 17:05 |
| lucasagomes | jroll, :-( | 17:05 |
| lucasagomes | yeah it's taking ages | 17:05 |
| lucasagomes | jroll, I will try to ping james to take a look at it as well | 17:06 |
| jroll | lucasagomes: yeah, I asked in channel but didn't get a response | 17:06 |
| *** itsuugo has joined #openstack-ironic | 17:06 | |
| lucasagomes | jroll, will try | 17:07 |
| *** amotoki has quit IRC | 17:08 | |
| lucasagomes | jroll, 4+2 ! | 17:08 |
| lucasagomes | hah | 17:08 |
| jroll | ikr | 17:08 |
| *** derekh has quit IRC | 17:11 | |
| jroll | jlvillal: nothing stands out to me as a nova bug we really need fixed | 17:13 |
| *** lazy_prince has quit IRC | 17:16 | |
| jlvillal | jroll: That was my gut feeling. But glad somewhat else thinks so :) | 17:19 |
| *** adam_g has joined #openstack-ironic | 17:20 | |
| *** adam_g has quit IRC | 17:20 | |
| *** adam_g has joined #openstack-ironic | 17:20 | |
| *** puranamr_ has joined #openstack-ironic | 17:24 | |
| lucasagomes | folks I'm going to call it a day | 17:25 |
| lucasagomes | have a great night everyone! | 17:25 |
| lucasagomes | jroll, re deprecation of DIB element, talked to james on #tripleo, removed the depends-on of the patch and rebased | 17:25 |
| *** baoli has quit IRC | 17:25 | |
| lucasagomes | jroll, will work on the tripleo-ci using IPA in parallel | 17:25 |
| jroll | lucasagomes: cool thanks | 17:26 |
| jroll | have a good night :) | 17:26 |
| lucasagomes | (the tripleo ci seems to have changed a lot since and is not using the scripts form tripleo-incubator to generate the images) | 17:26 |
| *** penick has joined #openstack-ironic | 17:26 | |
| lucasagomes | you too | 17:26 |
| lucasagomes | see y'all | 17:26 |
| *** puranamr has quit IRC | 17:26 | |
| thiagop | nigth lucasagomes | 17:27 |
| lucasagomes | see ya | 17:27 |
| *** lucasagomes is now known as lucas-dinner | 17:27 | |
| *** baoli has joined #openstack-ironic | 17:27 | |
| *** achanda has joined #openstack-ironic | 17:28 | |
| *** baoli has quit IRC | 17:28 | |
| *** puranamr has joined #openstack-ironic | 17:29 | |
| *** puranamr_ has quit IRC | 17:31 | |
| penick | mariojv: hey, could I get you to take a look at this, and see if it still sounds sane to you? https://review.openstack.org/#/c/212206/ | 17:32 |
| mariojv | penick: sure | 17:32 |
| penick | The no IPA to conductor communication spec | 17:32 |
| penick | thanks! | 17:32 |
| *** sdake_ is now known as sdake | 17:33 | |
| jlvillal | lucas-dinner: Ciao | 17:34 |
| mariojv | penick: LGTM. not sure if i should +1 since i'm listed as a co author even though all we did was chat a bit at the summit. :) | 17:35 |
| rloo | mariojv: co-authors can still +1. | 17:36 |
| jroll | it's fine | 17:36 |
| mariojv | done | 17:36 |
| rloo | mariojv: it is a good indication that the coauthors agree :) | 17:36 |
| *** degorenko has quit IRC | 17:37 | |
| penick | thanks :) | 17:37 |
| jroll | TheJulia: you confirmed https://bugs.launchpad.net/ironic/+bug/1433812 isn't still a bug in ironic, right? was a bifrost problem? | 17:39 |
| openstack | Launchpad bug 1433812 in Ironic "ironic-python-agent silently fails to write a configdrive if a previous drive is found" [High,Fix released] - Assigned to Ramakrishnan G (rameshg87) (rameshg87) | 17:39 |
| *** sdake_ has joined #openstack-ironic | 17:41 | |
| *** puranamr has quit IRC | 17:42 | |
| TheJulia | jroll: yeah, my reproduction of it was just because of a differing template file | 17:44 |
| jroll | TheJulia: cool, thanks | 17:44 |
| *** sdake has quit IRC | 17:44 | |
| TheJulia | jroll: so ignore me, i pushed up a fix for bifrost's template file | 17:44 |
| jroll | \o/ | 17:44 |
| *** puranamr has joined #openstack-ironic | 17:46 | |
| *** itsuugo has quit IRC | 17:47 | |
| *** kbyrne has quit IRC | 17:49 | |
| *** praneshp has joined #openstack-ironic | 17:51 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add config option to override url for links https://review.openstack.org/223640 | 17:53 |
| lucas-dinner | fix py3 :-( | 17:53 |
| * lucas-dinner goes away | 17:53 | |
| *** e0ne has quit IRC | 17:54 | |
| jroll | devananda: rloo: etc: I've updated launchpad to match the whiteboard: https://launchpad.net/ironic/+milestone/4.2.0 | 17:55 |
| rloo | thx jroll | 17:56 |
| jroll | feel free to add stuff to that (or poke me) if you find things you want there | 17:56 |
| devananda | nice, thx! | 17:56 |
| rloo | jroll: what's with the 'undefined' priority for deprecate bash ramdisk? | 17:56 |
| jroll | rloo: I missed it, that's what :) | 17:56 |
| *** blakec has joined #openstack-ironic | 17:56 | |
| jroll | need to update status too | 17:56 |
| rloo | jroll: lol | 17:56 |
| praneshp | jroll: rloo are there any examples of filtering on a JsonEncodedDict field by treating it as a string? I have something like “query = query.filter(field.like('temp’))”, but I get TypeError: JSONEncodedDict supposes to store dict objects, but str given. Is there a function that can cast the dict field to a str first? | 17:58 |
| jroll | praneshp: like I said before, that isn't something we should be doing, because it's slow etc | 17:58 |
| praneshp | jroll: correct, but this is on an internal change I’m working on, and I don’t mind the slowness. I went through https://review.openstack.org/#/c/204641/4/specs/liberty/node-reservations.rst too | 18:00 |
| praneshp | Its still better than getting the nodes to the client side and parsing in python, no? | 18:00 |
| jroll | praneshp: I'm happy to help with upstream changes, but not so much downstream changes | 18:00 |
| *** blakec has quit IRC | 18:01 | |
| praneshp | jroll: I do have a spec here https://review.openstack.org/#/c/221173/1, but I agree that filtering on the properties field is probably not the best | 18:01 |
| praneshp | thanks! | 18:01 |
| *** puranamr_ has joined #openstack-ironic | 18:04 | |
| *** sinval has joined #openstack-ironic | 18:04 | |
| *** puranamr has quit IRC | 18:06 | |
| *** puranamr has joined #openstack-ironic | 18:08 | |
| devananda | in the fullness of time I'd like to refactor those JSON fields into an indexable key:value structure OR support storing them in a full-text search engine so we can do things like that | 18:08 |
| devananda | but for now, yea, searching in the TEXT field inside the DB is badslow | 18:08 |
| *** puranamr_ has quit IRC | 18:09 | |
| jroll | yeah, my plan is to make a table for those | 18:09 |
| rloo | jroll or other cores, this should be a not-so-hard review (for RAID): https://review.openstack.org/#/c/222287 | 18:10 |
| *** trown|lunch is now known as trown | 18:11 | |
| *** tsekiyama has joined #openstack-ironic | 18:15 | |
| rloo | jroll: sorry, I thought we wanted this spec/BP done too (actual use of RAID): https://blueprints.launchpad.net/ironic/+spec/inband-raid-configuration | 18:15 |
| jroll | rloo: you might be right, thanks :) | 18:16 |
| rloo | jroll: yeah, just checked the etherpad, it is listed there | 18:17 |
| *** e0ne has joined #openstack-ironic | 18:29 | |
| jlvillal | rloo: regarding: https://review.openstack.org/#/c/222287/ I did -1 because I don't see any use of the decorator and not sure that it actually works. | 18:34 |
| * jlvillal admits that it probably does work... | 18:35 | |
| jroll | jlvillal: do you want me to remove my +A? | 18:35 |
| rloo | jroll: doesn't the unit tests show that? you need to look at the patch that depends on it | 18:35 |
| jroll | the unit tests satisfy me, and they're used in the follow up patch | 18:35 |
| jlvillal | jroll: rloo: Okay. In that patch, I just didn't see any use of the decorator. Not sure if that should stop it from being merged. | 18:36 |
| *** puranamr has quit IRC | 18:36 | |
| jlvillal | The actual decorator function was never called in the patch. | 18:36 |
| rloo | jlvillal: the original patch was split up cuz someone said that this is a new 'api' thingy and should be in its own patch. | 18:36 |
| jlvillal | rloo: Okay. I will go look at the other patch. Thanks :) | 18:36 |
| rloo | jlvillal: guess it is sort of like a new Interface that isn't used yet. | 18:37 |
| rloo | jlvillal: maybe we need a test with the decorator. Hard for me to see it with fresh eyes cuz i split it up from the original. | 18:37 |
| rloo | jlvillal: let us know what you think! | 18:37 |
| jlvillal | rloo: Right. I was just hoping for a unit test with the decorator. Because I went off on the tangent of wondering if needed to use @six.wraps() | 18:38 |
| jlvillal | Let me bring in the 2nd patch and look. | 18:38 |
| *** e0ne has quit IRC | 18:38 | |
| rloo | jlvillal: if we have units tests for other decorators, seems like a fair question to ask about this one. | 18:39 |
| jroll | jlvillal: line 904 https://review.openstack.org/#/c/222287/2/ironic/tests/drivers/test_agent_base_vendor.py | 18:39 |
| jroll | uses the decorator | 18:39 |
| rloo | oh, didn't notice that jroll approved it. we can add a followup patch if we need to, jlvillal. | 18:40 |
| jlvillal | jroll: Sweet. Thanks. I did the wrong search before :( | 18:40 |
| jlvillal | And didn't see it. | 18:40 |
| jroll | heh, no worries | 18:41 |
| *** sdake_ is now known as sdake | 18:45 | |
| *** puranamr has joined #openstack-ironic | 18:46 | |
| *** puranamr has quit IRC | 18:46 | |
| *** alexpilotti has quit IRC | 18:50 | |
| *** wshao has joined #openstack-ironic | 18:50 | |
| *** pelix has quit IRC | 18:51 | |
| *** e0ne has joined #openstack-ironic | 18:53 | |
| *** nicodemos has quit IRC | 18:53 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Implement take_over for iscsi_ilo driver https://review.openstack.org/217068 | 18:53 |
| *** alexpilotti has joined #openstack-ironic | 18:54 | |
| *** romcheg has quit IRC | 18:55 | |
| devananda | gotta take my car in for 15k service // clean out all the playa from the engine! | 19:01 |
| devananda | back in an hour or two | 19:01 |
| *** romcheg has joined #openstack-ironic | 19:04 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Implement take_over for iscsi_ilo driver https://review.openstack.org/217068 | 19:06 |
| rloo | JoshNang: wrt https://review.openstack.org/#/c/221989/, I commented on some of your comments. | 19:07 |
| *** krtaylor has joined #openstack-ironic | 19:08 | |
| JoshNang | rloo: yeah i think those are all valid. i meant to push the code before i left last night but missed the "are you sure you want to submit multiple commits" prompt.. | 19:09 |
| JoshNang | fixing tests right now. | 19:09 |
| rloo | JoshNang: ha ha. I'll look at it after you've fixed the tests and pushed a new version up :) | 19:10 |
| JoshNang | awesome, thanks! | 19:10 |
| *** nicodemos has joined #openstack-ironic | 19:10 | |
| rloo | jroll: do you think this is medium priority? otherwise, I'd wonder why this takes precedence over all the other specs/BPs that are medium priority: https://blueprints.launchpad.net/ironic/+spec/inband-raid-configuration | 19:11 |
| jroll | rloo: I think it's probably medium; I didn't really look at priorities when I set the milestone on those | 19:12 |
| jroll | I still want to go through the 100+ blueprints we have untargeted / unprioritized and clean them up | 19:12 |
| rloo | jroll: whoa. there are 100+ bps?!! | 19:12 |
| jroll | rloo: wait, it's set to low, I assume you mean why everything else takes precedence over it? | 19:13 |
| jroll | 124, to be exact https://blueprints.launchpad.net/ironic | 19:13 |
| rloo | jroll: I mean, that BP is set to low yet targeted for liberty. but there are other BPs that have been approved with medium priority and they aren't targetted for liberty. | 19:14 |
| *** krtaylor has quit IRC | 19:14 | |
| jroll | rloo: oh. idk. | 19:14 |
| rloo | jroll: so it seems like if we want it for liberty, it should be medium? | 19:15 |
| jroll | yeah, I'll upgrade it | 19:15 |
| rloo | thx jroll | 19:15 |
| jroll | np, thanks for pointing it out :) | 19:16 |
| openstackgerrit | venkatamahesh proposed openstack/ironic-python-agent: Added home-page value in setup.cfg file https://review.openstack.org/223769 | 19:18 |
| mariojv | jroll: with 223657 (fix description link in IPA), would you prefer it to point to the IPA wiki page or http://docs.openstack.org/developer/ironic-python-agent/ ? we don't have api-specific docs yet | 19:18 |
| jroll | lucas-dinner: feel free to just answer tomorrow, but curious if you're still trying to get this in liberty https://review.openstack.org/#/c/178229/ | 19:19 |
| jroll | mariojv: docs, for sure | 19:19 |
| jroll | mrda: this is done yah? https://blueprints.launchpad.net/ironic/+spec/version-caching | 19:26 |
| *** baoli has joined #openstack-ironic | 19:35 | |
| *** baoli_ has joined #openstack-ironic | 19:37 | |
| *** baoli has quit IRC | 19:40 | |
| jroll | going to grab lunch and such, bbl | 19:43 |
| *** devlaps has joined #openstack-ironic | 19:51 | |
| *** baoli_ has quit IRC | 19:55 | |
| *** achanda has quit IRC | 20:01 | |
| *** praneshp has quit IRC | 20:01 | |
| *** blakec has joined #openstack-ironic | 20:01 | |
| *** praneshp has joined #openstack-ironic | 20:02 | |
| *** nicodemos has quit IRC | 20:03 | |
| *** wshao has quit IRC | 20:08 | |
| *** mtanino has quit IRC | 20:11 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: OneView Driver for Ironic https://review.openstack.org/191822 | 20:16 |
| *** romcheg has quit IRC | 20:27 | |
| *** romcheg has joined #openstack-ironic | 20:27 | |
| *** shadower has joined #openstack-ironic | 20:29 | |
| *** baoli has joined #openstack-ironic | 20:34 | |
| *** achanda has joined #openstack-ironic | 20:35 | |
| *** achanda has quit IRC | 20:35 | |
| *** achanda has joined #openstack-ironic | 20:35 | |
| *** mgoddard has quit IRC | 20:41 | |
| *** mgoddard has joined #openstack-ironic | 20:43 | |
| *** baoli has quit IRC | 20:43 | |
| *** baoli has joined #openstack-ironic | 20:44 | |
| openstackgerrit | Mario Villaplana proposed openstack/ironic-python-agent: Fixes incorrect description URL https://review.openstack.org/223657 | 20:46 |
| *** baoli has quit IRC | 20:47 | |
| *** baoli has joined #openstack-ironic | 20:48 | |
| *** liliars has quit IRC | 20:52 | |
| rloo | hmm, 'The following LIBS_FROM_GIT were not installed correct: python-ironicclient'. test failing for https://review.openstack.org/#/c/222249/ | 20:54 |
| *** baoli has quit IRC | 20:57 | |
| *** wshao has joined #openstack-ironic | 20:57 | |
| *** baoli has joined #openstack-ironic | 20:57 | |
| *** baoli_ has joined #openstack-ironic | 20:59 | |
| *** baoli has quit IRC | 20:59 | |
| *** baoli has joined #openstack-ironic | 21:00 | |
| *** garthb has quit IRC | 21:03 | |
| thiagop | folks, I'm calling it a day | 21:03 |
| thiagop | see you tomorrow | 21:03 |
| *** thiagop has quit IRC | 21:03 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Fixes incorrect description URL https://review.openstack.org/223657 | 21:05 |
| *** lucas-dinner has quit IRC | 21:06 | |
| *** baoli has quit IRC | 21:12 | |
| jroll | rloo: ruh roh | 21:14 |
| jlvillal | rloo: jroll: Is that an #openstack-infra question? | 21:14 |
| jroll | lifeless: any clues on http://logs.openstack.org/49/222249/1/check/gate-tempest-dsvm-neutron-src-python-ironicclient/cf7081b/logs/devstacklog.txt.gz#_2015-09-15_17_53_39_835 ? | 21:14 |
| jroll | jlvillal: possiblemente | 21:14 |
| jlvillal | Or a lifeless question :) | 21:14 |
| jroll | lifeless: corresponding change is https://review.openstack.org/#/c/222249/ | 21:14 |
| rloo | jlvillal, jroll: i have no idea. haven't yet had a chance to dig into it. | 21:14 |
| *** baoli has joined #openstack-ironic | 21:15 | |
| jroll | after cross-project meeting is fine too :) | 21:15 |
| rloo | jlvillal, jroll: but now that you're both on the case, I'm going to not look into it. (whew) | 21:15 |
| jlvillal | rloo: I don't see how the patch could cause the problem. | 21:15 |
| openstackgerrit | Colleen Murphy proposed openstack/bifrost: Move dnsmasq to the end of the Debian package list https://review.openstack.org/223813 | 21:15 |
| * jlvillal wonders how he and jroll just got finagled?? ;) | 21:15 | |
| jroll | well, the error isn't terribly verbose, I'll dig more | 21:15 |
| jroll | interesting thing is the other -src job should install it the same way | 21:16 |
| jroll | so maybe a dependency conflict or something | 21:16 |
| jroll | in cross project meeting at the moment but will try to look more during | 21:16 |
| rloo | jroll, jlvillal: yeah, sorry, just because you responded doesn't mean I should pass the hot potato to you. that's bad and I don't like it when others do that. So one of you should offer :) | 21:16 |
| jlvillal | rloo: I'm joking. The ;) was supposed to signify that :) | 21:17 |
| jroll | heh | 21:17 |
| jlvillal | rloo: I'm happy to look at it | 21:17 |
| rloo | thx jlvillal! | 21:17 |
| jlvillal | jroll: That test passed on the 10th. | 21:18 |
| jroll | I don't see it even trying to install ironicclient :/ | 21:19 |
| rloo | jroll: yeah, that's as far as I got. | 21:19 |
| jlvillal | rloo: jroll I am pinging on infra. | 21:20 |
| jroll | mmmkay | 21:20 |
| jroll | thanks | 21:20 |
| lifeless | jroll: could be the constraints file wasn't edited for some reason ? | 21:20 |
| lifeless | jroll: can you reproduce locally? | 21:20 |
| *** baoli has quit IRC | 21:21 | |
| jroll | lifeless: this is a dsvm job on a client change, no requirements changes or whatever, the other dsvm job that installes ironicclient from source seems to pass | 21:21 |
| *** baoli_ has joined #openstack-ironic | 21:22 | |
| * jlvillal does not know how to run the tempest jobs locally... :( | 21:22 | |
| lifeless | jlvillal: this hasn't reached tempest, its still in devstack | 21:22 |
| jlvillal | lifeless: Ah | 21:22 |
| lifeless | http://logs.openstack.org/49/222249/1/check/gate-tempest-dsvm-neutron-src-python-ironicclient/cf7081b/logs/devstacklog.txt.gz#_2015-09-15_17_52_34_218 | 21:24 |
| lifeless | ^ thats what 'install a thing from git' looks like in the log | 21:25 |
| jroll | lifeless: I can try to reproduce locally after this meeting, just mostly curious if you could spot something quickly | 21:25 |
| lifeless | we edit the constraints to say 'this is from git, not from the name' | 21:25 |
| jroll | right, so it doesn't appear to even be attempting that, which is odd | 21:25 |
| *** baoli_ has quit IRC | 21:25 | |
| lifeless | jroll: so I don't see any python-ironicclient install at all | 21:26 |
| lifeless | jroll: e.g. its a devstack bug ? | 21:26 |
| jroll | yep, agree | 21:26 |
| jroll | yeah maybe | 21:26 |
| jroll | I'll poke around shortly | 21:26 |
| jlvillal | As a note we haven't had any other patches to python-ironicclient recently. | 21:26 |
| rloo | how does devstack know to install python-ironicclient? | 21:27 |
| jroll | rloo: LIBS_FROM_GIT or whatever | 21:27 |
| rloo | the other tempest job passes, gate-tempest-dsvm-python-ironicclient-src, so there is something that isn't being configured. i think. | 21:27 |
| jroll | heh | 21:28 |
| *** puranamr has joined #openstack-ironic | 21:28 | |
| jroll | c71973eb04d05c2497eb930c4e1b59dcaf983085 in devstack | 21:28 |
| jroll | this was possibly just always broken | 21:28 |
| *** baoli has joined #openstack-ironic | 21:28 | |
| *** baoli has quit IRC | 21:29 | |
| jlvillal | jroll: I think your found it (lifeless) | 21:29 |
| jlvillal | s/your/you/ | 21:29 |
| jroll | https://github.com/openstack-dev/devstack/commit/c71973eb04d05c2497eb930c4e1b59dcaf983085 | 21:29 |
| jroll | gdi | 21:29 |
| *** mtanino has joined #openstack-ironic | 21:29 | |
| jlvillal | jroll: Another thing to add to our collection of gate breakages... | 21:30 |
| jroll | well, this just tells me it was always broken | 21:30 |
| jlvillal | jroll: As in it never tested the patches? | 21:30 |
| jroll | maybe! :) | 21:31 |
| *** baoli has joined #openstack-ironic | 21:31 | |
| jlvillal | Heh | 21:31 |
| jroll | probably not though, because gate-tempest-dsvm-python-ironicclient-src passes | 21:31 |
| jroll | assuming that does what I think it does | 21:31 |
| jroll | yeah, http://logs.openstack.org/49/222249/1/gate/gate-tempest-dsvm-python-ironicclient-src/21fc524/logs/devstacklog.txt.gz#_2015-09-15_02_41_42_216 | 21:31 |
| jroll | so it's just that one job | 21:31 |
| jroll | that's silly | 21:32 |
| lifeless | so, your issue is- I think - that your other job wasn't installing python-ironiclient before this test runs | 21:33 |
| *** garthb has joined #openstack-ironic | 21:33 | |
| lifeless | which does seem like your job isn't doing much | 21:33 |
| *** puranamr has quit IRC | 21:33 | |
| *** baoli has quit IRC | 21:33 | |
| jroll | lifeless: yeah, I agrewe | 21:34 |
| *** baoli has joined #openstack-ironic | 21:34 | |
| jroll | the other weird thing, is I don't think that -neutron- job is useful | 21:34 |
| *** baoli has quit IRC | 21:34 | |
| jroll | it runs full tempest with neutron... without the ironic driver. | 21:34 |
| jroll | so I don't believe ironicclient is even exercised | 21:34 |
| *** baoli has joined #openstack-ironic | 21:35 | |
| jroll | whereas the passing job uses the ironic driver in nova | 21:35 |
| *** krtaylor has joined #openstack-ironic | 21:35 | |
| *** puranamr has joined #openstack-ironic | 21:36 | |
| *** baoli has quit IRC | 21:40 | |
| *** baoli has joined #openstack-ironic | 21:41 | |
| *** baoli_ has joined #openstack-ironic | 21:54 | |
| *** baoli_ has quit IRC | 21:54 | |
| *** baoli has quit IRC | 21:56 | |
| *** baoli has joined #openstack-ironic | 21:57 | |
| *** baoli has quit IRC | 21:57 | |
| *** baoli has joined #openstack-ironic | 21:58 | |
| lifeless | jroll: so tl;dr - I think you should remove that job, since it seems legitimately useless | 21:59 |
| jroll | lifeless: yeah, that's what I'm thinking | 22:00 |
| *** baoli has quit IRC | 22:00 | |
| *** baoli has joined #openstack-ironic | 22:01 | |
| *** krtaylor has quit IRC | 22:02 | |
| *** baoli has quit IRC | 22:02 | |
| *** baoli has joined #openstack-ironic | 22:03 | |
| *** puranamr has quit IRC | 22:04 | |
| *** baoli has quit IRC | 22:05 | |
| mrda | jroll: yes, version caching is done | 22:05 |
| mrda | oh, and Good morning Ironic :) | 22:06 |
| jroll | mrda: g'morning, thanks! | 22:06 |
| NobodyCam | morning mrda :) | 22:06 |
| mrda | o/ | 22:06 |
| jroll | mrda: I'm not going to pin it to an ironic milestone, because that seems weird to have in release notes :) | 22:06 |
| mrda | So jroll, just on the openwsman lockups... | 22:07 |
| mrda | you suggest the miestong for the fix is 4.2.0 | 22:07 |
| mrda | milestone | 22:07 |
| jroll | mrda: I'm hoping it is, if we miss it that's cool | 22:07 |
| *** baoli has joined #openstack-ironic | 22:07 | |
| mrda | So what is the solution? Fix openwsman (and hence keep the current drivers for amt/drac as is)? | 22:07 |
| jroll | IMO do it in python | 22:08 |
| *** penick has quit IRC | 22:08 | |
| mrda | ok, so Sean's solution... whcih is a replacement for openwsman? | 22:08 |
| jroll | yeah | 22:08 |
| mrda | ok, thanks. | 22:08 |
| jroll | though if we use that as a library, it's going to have to wait for M | 22:08 |
| jroll | because requirements freeze | 22:08 |
| mrda | I created an agenrt_amt yesterday and it locks up every time :) | 22:09 |
| *** harshs has quit IRC | 22:09 | |
| *** baoli has quit IRC | 22:09 | |
| jroll | nice. | 22:09 |
| jroll | :( | 22:09 |
| mrda | Yeah, so I'd like to get that working, even if that means I just do something locally and copy a python-only-wsman library into my tree | 22:10 |
| jroll | nod | 22:11 |
| jroll | I mean, we should update that patch that imports sean's amt thing | 22:11 |
| jroll | and you could test with that | 22:11 |
| jroll | and when M opens we can land it | 22:11 |
| mrda | sounds good to me | 22:11 |
| * mrda goes looking for said patch | 22:12 | |
| jroll | https://review.openstack.org/#/c/222682/ is the patch | 22:12 |
| jroll | mrda: ^ | 22:12 |
| mrda | thanks jroll! | 22:12 |
| jroll | no problem! | 22:12 |
| *** mgoddard has quit IRC | 22:13 | |
| *** baoli has joined #openstack-ironic | 22:13 | |
| *** baoli has quit IRC | 22:14 | |
| *** baoli has joined #openstack-ironic | 22:14 | |
| *** mgoddard has joined #openstack-ironic | 22:16 | |
| *** harshs has joined #openstack-ironic | 22:17 | |
| *** harshs has quit IRC | 22:17 | |
| *** harshs has joined #openstack-ironic | 22:17 | |
| *** baoli has quit IRC | 22:19 | |
| jroll | jlvillal: rloo https://review.openstack.org/#/c/223856/ | 22:19 |
| jroll | removes that test because useless | 22:19 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: Implement take_over for iscsi_ilo driver https://review.openstack.org/217068 | 22:20 |
| *** baoli has joined #openstack-ironic | 22:22 | |
| *** baoli has quit IRC | 22:23 | |
| *** baoli has joined #openstack-ironic | 22:23 | |
| *** baoli has quit IRC | 22:24 | |
| *** baoli has joined #openstack-ironic | 22:24 | |
| *** baoli has quit IRC | 22:25 | |
| *** baoli has joined #openstack-ironic | 22:27 | |
| *** baoli has quit IRC | 22:27 | |
| *** baoli has joined #openstack-ironic | 22:29 | |
| *** baoli_ has joined #openstack-ironic | 22:31 | |
| *** baoli has quit IRC | 22:31 | |
| *** harshs has joined #openstack-ironic | 22:32 | |
| *** baoli has joined #openstack-ironic | 22:35 | |
| *** alexpilotti has quit IRC | 22:35 | |
| *** baoli_ has quit IRC | 22:36 | |
| *** baoli has quit IRC | 22:38 | |
| *** baoli has joined #openstack-ironic | 22:38 | |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Support Zapping in the conductor https://review.openstack.org/221989 | 22:42 |
| jroll | yessss | 22:42 |
| JoshNang | so. many. tests. | 22:44 |
| JoshNang | and i'm pretty sure there's still more to change. | 22:44 |
| * JoshNang walks through and makes sure all the changes i said 'done' for are actually done. | 22:46 | |
| *** Sukhdev has joined #openstack-ironic | 22:47 | |
| *** Sukhdev_ has joined #openstack-ironic | 22:48 | |
| jroll | JoshNang: probably want to rebase that patch on the api changes? | 22:48 |
| *** krtaylor has joined #openstack-ironic | 22:49 | |
| JoshNang | jroll: ah dang. meant to do that when i pushed | 22:49 |
| *** [1]cdearborn has quit IRC | 22:50 | |
| jroll | heh | 22:51 |
| *** baoli has quit IRC | 22:52 | |
| *** baoli has joined #openstack-ironic | 22:53 | |
| *** sdake has quit IRC | 22:56 | |
| *** r-daneel has joined #openstack-ironic | 22:57 | |
| *** Sukhdev has quit IRC | 22:57 | |
| *** Sukhdev_ is now known as Sukhdev | 22:57 | |
| *** wshao has quit IRC | 23:01 | |
| *** baoli has quit IRC | 23:09 | |
| *** e0ne has quit IRC | 23:09 | |
| *** e0ne has joined #openstack-ironic | 23:13 | |
| *** openstackgerrit has quit IRC | 23:16 | |
| *** david-lyle has quit IRC | 23:17 | |
| *** openstackgerrit has joined #openstack-ironic | 23:17 | |
| jlvillal | jroll: Thanks for the patch to fix the gate issue. | 23:17 |
| jroll | np | 23:18 |
| jroll | whether people think it's good is another question | 23:18 |
| jroll | JoshNang: so are you rebasing that or should I just review as is? | 23:19 |
| JoshNang | jroll: mmm i'll push up the rebase quick. i updating more tests, but i'll do that after | 23:19 |
| jroll | oh either way | 23:19 |
| jroll | I can find something else to do, I'm sure | 23:20 |
| JoshNang | nah it's all good. i noticed a couple comments i didn't actually fix too :P | 23:20 |
| jroll | heh | 23:20 |
| jroll | cool thanks | 23:20 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Add Zapping states to node and API https://review.openstack.org/221949 | 23:21 |
| openstackgerrit | Josh Gachnang proposed openstack/ironic: Support Zapping in the conductor https://review.openstack.org/221989 | 23:21 |
| JoshNang | oh :/ that's not what i meant to do | 23:21 |
| jroll | :| | 23:21 |
| jroll | oh well | 23:21 |
| JoshNang | git review -F. boo | 23:21 |
| *** harshs has quit IRC | 23:21 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add Zapping states to node and API https://review.openstack.org/221949 | 23:22 |
| *** harshs has joined #openstack-ironic | 23:22 | |
| jroll | just updated commit message there | 23:22 |
| JoshNang | thanks | 23:22 |
| jroll | partial-implements isn't a thing, in case you care | 23:23 |
| jroll | oh dang, now it's outdated again, lol | 23:23 |
| JoshNang | oh lame | 23:24 |
| jroll | I got it | 23:24 |
| JoshNang | double lame | 23:24 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Support Zapping in the conductor https://review.openstack.org/221989 | 23:24 |
| *** e0ne has quit IRC | 23:26 | |
| openstackgerrit | Merged openstack/ironic: Fix iBoot test__switch_retries test to not waste time sleeping https://review.openstack.org/223649 | 23:28 |
| *** romcheg has quit IRC | 23:32 | |
| jroll | JoshNang: a few more comments there, I assume I caught some of the same ones you said you missed | 23:43 |
| JoshNang | jroll: thanks, i'll update now | 23:43 |
| jroll | cools | 23:43 |
| rloo | thx for the patch jroll; i updated the etherpad with red for the client. | 23:53 |
| jroll | thanks! | 23:54 |
| *** achanda_ has joined #openstack-ironic | 23:55 | |
| JoshNang | anyone else ever get test timeous like this? https://gist.github.com/pcsforeducation/ab8a25338e97041054c8 | 23:57 |
| *** achanda_ has quit IRC | 23:57 | |
| JoshNang | i think it has something to do with this, but no idea what: https://github.com/openstack/ironic/blob/master/ironic/tests/drivers/test_deploy_utils.py#L1523. happens every time on my ubuntu 14.04 box, but obviously isn't happening in the gate. even tried a fresh clone of ironic | 23:58 |
| JoshNang | heh this: https://github.com/openstack/ironic/blob/master/ironic/tests/drivers/test_deploy_utils.py#L1523 | 23:58 |
| jroll | hrm, weird | 23:58 |
| *** achanda has quit IRC | 23:58 | |
| *** wshao has joined #openstack-ironic | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
