Thursday, 2015-09-17

*** praneshp has quit IRC00:00
*** praneshp has joined #openstack-ironic00:01
*** naohirot has joined #openstack-ironic00:02
*** shoutm has joined #openstack-ironic00:02
*** Sukhdev has quit IRC00:04
*** MattMan has left #openstack-ironic00:04
openstackgerritRuby Loo proposed openstack/ironic: Document GET ...raid/logical_disk_properties  https://review.openstack.org/22435600:06
*** Sukhdev has joined #openstack-ironic00:10
*** praneshp has quit IRC00:10
*** mdbooth has quit IRC00:10
openstackgerritRuby Loo proposed openstack/ironic-specs: Update RAID spec based on what was coded  https://review.openstack.org/22435800:11
openstackgerritRuby Loo proposed openstack/ironic: Update descriptions in RAID config schema  https://review.openstack.org/22429900:13
*** devlaps has quit IRC00:15
*** harshs has joined #openstack-ironic00:16
*** mdbooth has joined #openstack-ironic00:16
*** smoriya has joined #openstack-ironic00:17
*** tsekiyama has quit IRC00:20
*** mtanino has quit IRC00:20
*** shadower has quit IRC00:23
*** Sukhdev has quit IRC00:23
*** shadower has joined #openstack-ironic00:23
*** achanda_ has quit IRC00:31
openstackgerritJosh Gachnang proposed openstack/ironic-python-agent: Add more info to checksum exception  https://review.openstack.org/21736900:31
openstackgerritJosh Gachnang proposed openstack/ironic-python-agent: Add more info to checksum exception  https://review.openstack.org/21736900:31
*** thrash is now known as thrash|g0ne00:31
*** achanda has joined #openstack-ironic00:33
*** achanda has quit IRC00:38
*** garthb has quit IRC00:45
*** Haomeng|2 has joined #openstack-ironic00:46
*** Haomeng has quit IRC00:49
*** ijw_ has quit IRC00:54
*** dims_ has quit IRC01:01
*** achanda has joined #openstack-ironic01:22
*** dims_ has joined #openstack-ironic01:26
*** zhenguo has joined #openstack-ironic01:31
openstackgerritTan Lin proposed openstack/ironic: Base IronicObject on VersionedObject  https://review.openstack.org/21360201:37
openstackgerritTan Lin proposed openstack/ironic: Remove unused object function  https://review.openstack.org/22208201:37
openstackgerritTan Lin proposed openstack/ironic: Use oslo.versionedobjects remotable decorators  https://review.openstack.org/21700001:37
*** achanda has quit IRC01:41
*** chlong has joined #openstack-ironic01:47
*** bizarrochristy has joined #openstack-ironic01:51
*** chlong_ has joined #openstack-ironic01:53
*** yog_ has joined #openstack-ironic01:53
*** shoutm has quit IRC01:55
*** Haomeng has joined #openstack-ironic01:57
*** Haomeng|2 has quit IRC02:00
*** r-daneel has quit IRC02:02
*** bizarrochristy has quit IRC02:02
*** bizarrochristy has joined #openstack-ironic02:03
openstackgerritRuby Loo proposed openstack/ironic-specs: Update RAID spec based on what was coded  https://review.openstack.org/22435802:05
*** yog_ has quit IRC02:09
*** shoutm has joined #openstack-ironic02:19
*** rloo has quit IRC02:31
*** david-lyle has joined #openstack-ironic02:34
*** yog_ has joined #openstack-ironic02:38
*** achanda has joined #openstack-ironic02:41
*** harshs_ has joined #openstack-ironic02:44
*** achanda has quit IRC02:45
*** harshs has quit IRC02:46
*** harshs_ is now known as harshs02:46
*** chlong_ has quit IRC02:50
*** VikasC has joined #openstack-ironic02:59
*** achanda has joined #openstack-ironic03:03
*** yog_ has quit IRC03:08
*** yog_ has joined #openstack-ironic03:09
*** coolsvap is now known as coolsvap|holiday03:17
*** bizarrochristy has quit IRC03:18
*** purp has quit IRC03:22
*** purp has joined #openstack-ironic03:22
*** praneshp has joined #openstack-ironic03:22
*** achanda has quit IRC03:35
*** achanda has joined #openstack-ironic03:35
*** penick has joined #openstack-ironic03:40
*** olaph has quit IRC03:41
*** praneshp_ has joined #openstack-ironic03:43
*** praneshp has quit IRC03:43
*** praneshp_ is now known as praneshp03:43
*** boris-42 has quit IRC03:50
*** yog_ has quit IRC03:50
*** boris-42 has joined #openstack-ironic03:51
*** sdake_ has joined #openstack-ironic03:52
*** yog_ has joined #openstack-ironic03:52
*** sdake has quit IRC03:54
*** ijw_ has joined #openstack-ironic04:11
*** harshs has quit IRC04:12
*** ijw_ has quit IRC04:15
*** chlong has quit IRC04:16
*** shoutm_ has joined #openstack-ironic04:17
*** shoutm has quit IRC04:19
*** olaph has joined #openstack-ironic04:21
openstackgerritYuiko Takada proposed openstack/ironic-inspector: [WIP]Support rootwrap  https://review.openstack.org/22393004:24
openstackgerritYuiko Takada proposed openstack/ironic-inspector: Support rootwrap  https://review.openstack.org/22393004:24
*** amotoki has joined #openstack-ironic04:25
*** chlong has joined #openstack-ironic04:33
openstackgerritYuiko Takada proposed openstack/ironic-specs: Get executable events API  https://review.openstack.org/22402204:37
*** dims_ has quit IRC04:38
*** achanda has quit IRC04:39
*** dims_ has joined #openstack-ironic04:43
*** dims_ has quit IRC04:44
*** sdake has joined #openstack-ironic04:46
*** chlong has quit IRC04:48
*** sdake_ has quit IRC04:49
*** shoutm_ has quit IRC04:50
*** shoutm has joined #openstack-ironic04:52
*** shoutm has quit IRC05:06
*** shoutm has joined #openstack-ironic05:10
*** penick has quit IRC05:10
*** achanda has joined #openstack-ironic05:20
*** shoutm has quit IRC05:41
*** shoutm has joined #openstack-ironic05:43
*** dims_ has joined #openstack-ironic05:45
*** dims_ has quit IRC05:53
*** Sukhdev has joined #openstack-ironic05:54
*** ukalifon has joined #openstack-ironic06:00
*** lsmola has joined #openstack-ironic06:01
*** chenglch has joined #openstack-ironic06:11
*** chenke has joined #openstack-ironic06:17
chenkeHaomeng:how are u?06:17
*** chlong has joined #openstack-ironic06:18
Haomengchenke: fine, and you?06:23
chenkeHaomeng: find too. seems we can enable swap while "nova boot" a barematal node, do you know what config should be changed for that?06:25
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Imported Translations from Zanata  https://review.openstack.org/22424006:25
*** balajin has quit IRC06:28
*** praneshp has quit IRC06:29
*** zer0c00l has quit IRC06:29
*** harlowja has quit IRC06:29
*** zhenguo has quit IRC06:30
*** zhenguo has joined #openstack-ironic06:32
*** zer0c00l has joined #openstack-ironic06:33
*** balajin has joined #openstack-ironic06:36
*** e0ne has joined #openstack-ironic06:56
Haomengchenke: should be swap_mb parameters to control the size06:57
Haomengchenke: you want to disable/enable swap paration?06:57
chenkeHaomeng: i want to enable it06:58
Haomengchenke: yes, set swap_mb properties value can enable06:58
Haomengchenke: node's properties06:58
chenkeHaomeng: now the issue is: the partition is right, but it doesn't mount as swap06:58
chenkeHaomeng: you mean set ironic node property to add swap06:59
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: Remove DictMatches custom matcher from unit tests  https://review.openstack.org/22428706:59
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: Fix string formatting issues  https://review.openstack.org/22286206:59
Haomengchenke: did you set it already?06:59
Haomengchenke: I understand your swap paration is created but it is not enabled in os, right?07:00
chenkeHaomeng: no, i am not.07:00
chenkeHaomeng:yes.07:00
Haomengchenke: "now the issue is: the partition is right, but it doesn't mount as swap"07:00
Haomengdid you check /etc/fstab07:01
chenkeHaomeng: yes. there is no swap configration in /etc/fstab. when i set it, the swap is ok.07:02
chenkeHaomeng: but i understand it should be set by ironic while deploy. right?07:02
Haomengchenke: I can confirm the swap paration is created, but not sure if it is enabled during os starting07:03
*** e0ne has quit IRC07:03
chenkechenke: yes. it should be like what i said. because i verify it just 1 month ago. now my openstack env was deploy again, but it failed set swap.07:05
chenkeHaomeng: yes. it should be like what i said. because i verify it just 1 month ago. now my openstack env was deploy again, but it failed set swap.07:05
Haomengchenke: what driver you are using, agent or ipmitool?07:06
Haomengchenke: pxe_impitool07:06
chenkeHaomeng: yes. pxe07:06
Haomengchenke: https://github.com/openstack/ironic/blob/68ec9be6a0abe4946edf55fa8337e2c9854bc397/ironic/drivers/modules/deploy_utils.py#L28407:06
chenkeHaomeng: can you confirm that the swap should be set in the node or flavor?07:08
Haomengchenke: should be node properties I think07:08
*** Sukhdev has quit IRC07:11
Haomengchenke: let me confirm07:16
chenkeHaomeng:tku. i also turn to verify it in my env.07:17
Haomengchenke: should be in flavors, sorry for confusing07:18
Haomengchenke: it will be set into instance_info07:18
Haomengchenke: after nova booting07:18
chenkeHaomeng: tku. so i need to check why no config in /etc/fstab.07:20
Haomengchenke: yes, not sure if it is depending on image07:23
Haomengchenke: if it can auto-mount07:23
Haomengchenke: ironic just help to create the swap paration07:23
*** dtantsur|afk is now known as dtantsur07:27
dtantsurMorning Ironic07:27
openstackgerritMerged openstack/python-ironic-inspector-client: Fix func test job broken by Inspector func tests changes  https://review.openstack.org/22426807:32
*** alex_xu_ is now known as alex_xu07:32
openstackgerritMerged openstack/python-ironic-inspector-client: Support for introspection rules  https://review.openstack.org/22309607:32
openstackgerritDmitry Tantsur proposed openstack/python-ironic-inspector-client: Support for getting introspection data  https://review.openstack.org/22407507:36
*** achanda has quit IRC07:38
*** yuikotakada has joined #openstack-ironic07:39
yuikotakadamorning Ironic07:39
*** achanda has joined #openstack-ironic07:47
openstackgerritDmitry Tantsur proposed openstack/python-ironic-inspector-client: Add a simple 'introspection rule show' command  https://review.openstack.org/22447107:50
*** achanda has quit IRC07:50
*** dims_ has joined #openstack-ironic07:51
*** Marga_ has quit IRC07:53
*** shuquan has joined #openstack-ironic07:55
*** dims_ has quit IRC07:57
*** ifarkas has joined #openstack-ironic07:59
dtantsuryuikotakada, o/07:59
yuikotakadadtantsur, o/08:00
*** dlpartain has joined #openstack-ironic08:01
*** dlpartain has left #openstack-ironic08:01
-openstackstatus- NOTICE: Gate is currently stuck, failing grenade upgrade tests due the release of oslo.utils 1.4.1 for Juno.08:01
dtantsuroh damn ^^08:03
dtantsurbut it does not affect inspector. I guess08:03
*** shoutm_ has joined #openstack-ironic08:06
*** shoutm has quit IRC08:08
*** romainh has joined #openstack-ironic08:12
*** jistr has joined #openstack-ironic08:20
dtantsuryuikotakada, could you please review https://review.openstack.org/#/c/224075/ and https://review.openstack.org/#/c/224471/ ? We need a client release today08:20
openstackgerritGrzegorz Grasza (xek) proposed openstack/ironic: Fix upgrades by implementing indirection_api  https://review.openstack.org/22407908:21
openstackgerritYuiko Takada proposed openstack/ironic-inspector: Support rootwrap  https://review.openstack.org/22393008:26
*** ndipanov has joined #openstack-ironic08:27
*** lucasagomes has joined #openstack-ironic08:29
*** derekh has joined #openstack-ironic08:33
*** mgoddard has joined #openstack-ironic08:37
*** Marga_ has joined #openstack-ironic08:39
*** romcheg has joined #openstack-ironic08:44
*** Marga_ has quit IRC08:47
yuikotakadadtantsur, output of "glance image-list" seems has been changed, do you know?08:51
dtantsuryuikotakada, sorry? that is possible, but is it important for us?08:52
yuikotakadadtantsur, https://github.com/openstack/ironic-inspector/blob/master/devstack/exercise.sh#L191 fails08:53
dtantsuryuikotakada, weird we don't catch it in gate... what's in image-list now? we should raise it to glance folks, if it's really a breaking change08:54
yuikotakadadtantsur, just ID and Name. does it cause only in my env...? I will investigate08:55
*** alexpilotti has joined #openstack-ironic08:55
dtantsuryuikotakada, in my env as well...08:56
lucasagomesglance broke other stuff as well08:59
yuikotakadadtantsur, lucasagomes, that's too bad08:59
lucasagomesthey now point to the v2 API by default in their client08:59
dtantsurlucasagomes, damn. that's not very nice thing to do just before the release08:59
lucasagomesdtantsur, yeah I put a doc up these days to fix the image-create command that has changed :-/09:01
lucasagomesyuikotakada, dtantsur btw https://review.openstack.org/#/c/219802/09:01
dtantsuryuikotakada, I'll put up a patch09:03
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Allow abort for CLEANWAIT states  https://review.openstack.org/20155209:06
yuikotakadadtantsur, thank you :)09:08
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: Replace glance and keystone commands with OSC equivalents  https://review.openstack.org/22450109:08
dtantsuryuikotakada, ^^09:08
dtantsurlucasagomes, ^^^09:09
lucasagomesdtantsur, cool, there are others to be replaced there as well09:12
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Allow abort for CLEANWAIT states  https://review.openstack.org/20155209:13
dtantsurlucasagomes, yep, I'll replace them soonish. but these are particularly bad, as keystone utility is deprecated, and glance is going to break us09:14
lucasagomesdtantsur, yeah the keystone there is exactly the same command you just replaced09:14
dtantsurah, you meant more keystone things, I just read the comment :)09:14
lucasagomesdtantsur, yup09:14
lucasagomesthere are two more09:14
sambettsAh the pythonclients breaking everything again I see :-P09:15
dtantsurlucasagomes, openstack endpoint list is empty :( I remember there was some v2 vs v3 thingy...09:15
lucasagomesdtantsur, oh :-/09:17
yuikotakadasambetts, o/09:17
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: Replace glance and keystone commands with OSC equivalents  https://review.openstack.org/22450109:17
*** athomas has joined #openstack-ironic09:17
dtantsurmorning sambetts! yeah, usual fun... and these people are talking about inspector-client feature freeze :D09:17
dtantsursambetts, I've prepared a 'rule show' command for your reviewing pleasure: https://review.openstack.org/#/c/224471/09:18
dtantsur:)09:18
dtantsuralso, lets land the last 2 patches, and release the damned client finally :)09:18
yuikotakadadtantsur, lucasagomes so that all we can do is Dmitry's patch as is :)09:19
dtantsuryeah... yuikotakada could you please check that it actually fixes things for you?09:20
dtantsuroh, you already did, right/09:20
lucasagomesI just +a that... are you still testing it?09:20
lucasagomesdtantsur, ^ ?09:20
dtantsurlucasagomes, I've tested only the commands. And if our gate passes, I think we're fine09:21
lucasagomesyeah fair enuff, won't merge if it fails09:21
yuikotakadadtantsur ^^09:21
sambettsdtantsur: Aweseome09:22
* sambetts looks :) 09:22
*** pelix has joined #openstack-ironic09:27
sambettsdtantsur: Oh wow thats confusing!! The Cliff docs refer to rows as columns! http://docs.openstack.org/developer/cliff/demoapp.html#show-py09:31
lucasagomessambetts, lol!09:34
* lucasagomes remembers the javascript api for media09:34
lucasagomessambetts, http://www.w3schools.com/jsref/met_video_canplaytype.asp09:35
lucasagomescheck the return values09:35
*** shuquan has quit IRC09:35
sambettslucasagomes: haha09:35
dtantsursambetts, yeah :) and I wonder why couldn't they just accept a dict09:40
sambettsdtantsur: No idea, its a bit odd :-p09:41
dtantsurOSC is relatively young, a lot of things to improve09:42
dtantsuranyway, it's MUCH better than writing a client from scratch09:42
*** shuquan has joined #openstack-ironic09:42
sambettsdtantsur: waay better :-p, btw I think looking at this I've just noticed something about the rules API, the GET /v1/rules/<uuid> returns { uuid: balh, desc: blash } instead of { rule: { uuid: blah, desc: blah } } which is the way the other APIs do it http://developer.openstack.org/api-ref-networking-v2.html#showNetwork09:46
dtantsursambetts, well, nesting a dict is probably a matter of taste... we didn't do it with introspection status either. anyway, it's a bit too late to change :)09:47
sambettsdtantsur: Yeah, I just didn't know if it was an OpenStack standard or not, looking at the other APIs, neutron, cinder and nova for their GETs nest, but glance and celiometer don't, so I guess its not a problem09:50
*** e0ne has joined #openstack-ironic09:51
sambettsdtantsur: I've always found the nesting odd anyway09:53
dtantsuryeah09:55
*** chenglch has quit IRC09:55
lucasagomesdtantsur, not that young actually, it's been around since 201209:56
lucasagomes(or 2013... not sure)09:56
*** naohirot has quit IRC09:58
dtantsursambetts, ifarkas, WDYT about yuikotakada's suggestion on https://review.openstack.org/#/c/224075/ ? I'm a bit undecided on this matter...09:59
dtantsurjust like with rules, the table representation will look ugly09:59
*** shuquan has quit IRC09:59
dtantsurbut we can always use '-f json' to get just JSON09:59
*** dims_ has joined #openstack-ironic09:59
dtantsurhere's how it looks for me: http://paste.openstack.org/show/466058/10:00
dtantsur(actually it will be heavily wrapped)10:00
*** e0ne has quit IRC10:00
*** shuquan has joined #openstack-ironic10:01
openstackgerritVladyslav Drok proposed openstack/ironic: Add IPMINative vendor methods to *IPMINative drivers  https://review.openstack.org/22409910:01
*** shuquan has quit IRC10:02
dtantsuryuikotakada, hmm, I took one more look, seems like '-f json' does not give us an equivalent JSON. maybe split into "data" and "raw data" commands?10:02
ifarkasdtantsur, I vote for landing the patch as it is but I am not opposed having a table view10:02
sambettsdtantsur: I think it would likely be worth making it a ShowOne like the rule one, it can't hurt to enable the flexablity in the command10:02
dtantsursambetts, that we'll need the 2nd command to output a raw JSON...10:03
yuikotakadadtantsur, wait.. the output you pasted is different from mine...10:03
dtantsuryuikotakada, it depends on how you implement it :)10:03
dtantsursambetts, '-f json' does not give the original JSON back, it's more like [{"Field": "..", "value": "..."}]10:04
dtantsurhere's how it looks with '-f json': http://paste.openstack.org/show/466060/10:05
sambettsdtantsur: I guess thats because you have to transpose it out of the dict before you return it :(10:06
dtantsursambetts, I'm using dict2columns, so it should be fine10:07
dtantsursambetts, here's what I'm testing: http://paste.openstack.org/show/466062/10:07
yuikotakadadtantsur, http://paste.openstack.org/show/466058/ looks fine enough. mine is not easy to read. http://paste.openstack.org/show/466061/10:08
sambettsdtantsur: thats not how the docs say it should output10:09
sambettshttp://docs.openstack.org/developer/cliff/show_commands.html#json10:09
dtantsurweird...10:09
*** e0ne has joined #openstack-ironic10:11
*** ndipanov has quit IRC10:11
dtantsursambetts, tested 'image show', it also outputs with "Field" and "Value"10:11
sambettsdtantsur: How odd! I wonder if they changed something in their code! Thats really annoying10:12
dtantsuryep10:13
dtantsursambetts, yuikotakada, so I'd like us to have something returning data in machine readable format. I'm ok with leaving it as it is, or with splitting into 2 commands: human readable and machine readable10:14
-openstackstatus- NOTICE: Gate back to normal, thanks to the backlisting of the problematic version10:15
sambettsdtantsur: if you do -f shell does it output it properly?10:15
dtantsursambetts, yep10:17
sambettsdtantsur: Arg! So annoying... Maybe in the future we'll have to create our own formatter as it describes at the bottom of that cliff doc, so we could deal with the wrapping10:17
dtantsurso, I'll change this command to "raw data", and we'll revisit it later. WDYT?10:18
sambettsdtantsur: Ok, we can deprecated it later if we managed to make a successful combined command10:19
dtantsuryeah10:19
*** ndipanov has joined #openstack-ironic10:20
*** romainh has quit IRC10:21
openstackgerritDmitry Tantsur proposed openstack/python-ironic-inspector-client: Support for getting introspection data  https://review.openstack.org/22407510:22
dtantsursambetts, yuikotakada ^^10:22
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: Do not use matchers for trivial assertions  https://review.openstack.org/22456010:25
lucasagomesvdrok, racing comments hehe10:36
lucasagomesvdrok, I just added a suggestion the commit message on the patch-set #1, but ps #2 is grand as well10:36
lucasagomes+2'd10:36
vdroklucasagomes, :) thanks10:36
vdrokalso morning everyone10:37
openstackgerritMerged openstack/ironic: Base IronicObject on VersionedObject  https://review.openstack.org/21360210:38
openstackgerritJuliana Motira proposed stackforge/pyghmi: Add custom OEM domain name command for Lenovo ThinkServers  https://review.openstack.org/22191110:38
*** chenke has quit IRC10:39
*** zhenguo has quit IRC10:40
openstackgerritGrzegorz Grasza (xek) proposed openstack/ironic: Fix upgrades by implementing indirection_api  https://review.openstack.org/22407910:42
openstackgerritJuliana Motira proposed stackforge/pyghmi: Add custom OEM domain name command for Lenovo ThinkServers  https://review.openstack.org/22191110:44
openstackgerritMerged openstack/ironic-inspector: Replace glance and keystone commands with OSC equivalents  https://review.openstack.org/22450110:44
*** yuikotakada has quit IRC10:50
openstackgerritMerged openstack/python-ironic-inspector-client: Add a simple 'introspection rule show' command  https://review.openstack.org/22447110:54
dtantsuronly one patch left before the client release \o/10:55
*** dtantsur is now known as dtantsur|lunch10:55
sambetts\o/10:57
*** lsmola has quit IRC11:01
*** timbyr_ has joined #openstack-ironic11:02
*** lsmola has joined #openstack-ironic11:02
*** timbyr_ has quit IRC11:03
*** romcheg has quit IRC11:07
*** MattMan has joined #openstack-ironic11:11
*** romainh has joined #openstack-ironic11:16
*** e0ne has quit IRC11:23
*** sdake_ has joined #openstack-ironic11:43
*** sdake has quit IRC11:47
*** romcheg has joined #openstack-ironic11:53
*** trown|outttypeww is now known as trown11:55
*** thrash|g0ne is now known as thrash12:01
openstackgerritMerged openstack/ironic: Use oslo.versionedobjects remotable decorators  https://review.openstack.org/21700012:04
*** baoli has joined #openstack-ironic12:04
*** e0ne has joined #openstack-ironic12:04
*** amotoki has quit IRC12:12
*** sdake_ is now known as sdake12:13
*** romcheg has quit IRC12:23
sambettsIs someone around that can explain some ipmitool bridging stuff?12:29
TheJuliasambetts: I have a basic understanding of it12:30
TheJuliaAlso, good morning12:30
*** romcheg has joined #openstack-ironic12:31
*** achanda has joined #openstack-ironic12:35
sambettsMorning TheJulia, so I'm looking at the ironic ipmitool bridge spec, and I'm interested to know what format the target address is/local addresses are, from the blueprint they don't look like IPs12:36
TheJuliasambetts: so there is the target address of the node, which conceptually you could think about it as a single chassis controller for a number of blades, from there multiple nodes may have the same address, but they would have different bridge addresses12:39
TheJuliaExample being, On a moonshot, to manage the nodes, it is the same IP, but I have to use dual bridging, and define node specific parameters for each node's specific control.12:40
TheJuliadoes that make sense/answer your question?12:40
sambettsTheJulia, so if you were to run "ipmitool lan print" on one of those nodes does it actually return anything? I'm working on adding bridging support to inspector, and thats the command inspector uses to pull the ipmi address from the node, so I'm trying to work out what it would return12:43
*** shoutm_ has quit IRC12:46
TheJuliasambetts: I don't think anything gets printed.  I think nodes are slightly unaware.  I think we ended up scanning to figure out each cartrige's bridging info12:47
*** cdearborn has joined #openstack-ironic12:48
*** mdbooth has quit IRC12:48
*** dtantsur|lunch is now known as dtantsur12:48
BobBallWhat should be updating a node's power state?  Is there a period task somewhere which will query the power state and update the appropriate nodes?  Adding a new SSH PM driver and the command I run manually gives the correct list of running VMs, but ironic's view of the nodes is not updated12:49
*** mdbooth has joined #openstack-ironic12:50
*** amotoki has joined #openstack-ironic12:50
sambettsTheJulia: Ah ok, back the white board I go :-P12:50
*** rloo has joined #openstack-ironic12:53
dtantsurTheJulia, morning12:56
lucasagomesBobBall, yes there's a periodic task that sync the power states12:56
TheJuliagood morning dtantsur lucasagomes12:56
BobBalllucasagomes: Run by which process?  Trying to track it down so I can debug why the power states aren't being synced12:57
lucasagomesBobBall, and there's another configuration to make the power state to be forced upon the nodes (vm's in ur case) or just passive. For e.g in active move if the DB says the node is "on" but it's actually "off" it will power on the node. Passive mode it will just update the db saying the node is "off"12:57
lucasagomesBobBall, ironic-conductor12:57
lucasagomesBobBall, https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L222912:58
rloohi dtantsur, lucasagomes, BobBall, TheJulia12:58
dtantsurrloo, o/12:58
lucasagomesBobBall, actually here's the periodic task https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L110312:58
lucasagomesTheJulia, rloo good morning!12:58
BobBallHowdy13:00
BobBallThanks lucasagomes - I'll chuck some debugging in there.13:00
lucasagomesBobBall, cool13:01
lucasagomesBobBall, you can see there that some states the nodes are not sync'd (deploywait, cleanwait, enroll)13:02
lucasagomesand if it's in maintenance it doesn't sync either13:02
openstackgerritNaohiro Tamura proposed openstack/ironic: Refactor IRMCVirtualMediaIscsiDeploy by applying new BootInterface  https://review.openstack.org/22137113:02
lucasagomess/and/or13:02
BobBallthey are all available / not in maintenance13:02
lucasagomescool yeah should be sync'ing then13:02
* lucasagomes suspect it may be something with the get_power_state() which is returning only one value (not failing)13:03
BobBallMy checks show it returning multiple values from the plain SSH command (separated by newline) ... but investigating :)13:08
zigoI'm getting my jenkins build process to die, when it builds ironicclient.13:11
zigoHow can I investigate the issue?13:11
*** jefabo has joined #openstack-ironic13:11
zigoIt does when doing the CommonParamsForListTest series of test.13:12
rloozigo: do you have anything more specific? does it dump out where it died?13:16
zigorloo: That's the issue: it does nothing that gives me a clue.13:17
rloozigo: :-(13:17
zigorloo: https://liberty-jessie.pkgs.mirantis.com/job/python-ironicclient/4/console13:17
rloozigo: does the 'wait: No child processes...' mean that one of the unit tests failed? or is that more of a problem with the build machine13:20
*** zhenguo has joined #openstack-ironic13:20
zigorloo: I think it's just jenkins saying it's child process died.13:21
zigoFYI, building in plain sid, not using Jenkins, works.13:21
zigoAlso, I have the same issue with Nova.13:21
zigoI increased RAM from 4 to 6 GB, and it didn't help13:21
rloozigo: oh. then I blame it on Nova :-)13:21
*** romcheg has quit IRC13:22
rloozigo: I don't know much about jenkins and it doesn't look like the problem is due to the unit tests themselves. Else I would think it would have outputted the unit test it was working on when it barfed.13:23
rloozigo: and everything else in the openstack world works fine except nova and this client?13:24
*** romcheg has joined #openstack-ironic13:24
zigorloo: Correct.13:24
rloozigo: hmm, not always good to be special...13:24
zigorloo: Another thing is that when it is in this state, Python 3.4 takes some CPU.13:25
zigoBut I have no clue what this process is doing ...13:25
*** romcheg has quit IRC13:26
rloozigo: I'm not a py 3.4 person.13:26
rloozigo: does 'py3versions: no X-Python3-Version in control file, using supported versions' mean anything?13:26
zigorloo: This is only a warning and it can be ignored.13:27
lucasagomeszigo, "Build killed with signal TERM after 150 minutes of inactivity" is that time configurable?13:27
zigoBasically, it's saying: oh, you haven't declard anything in your package, so I'll just take whatever Python version is supported in this Debian system.13:28
*** romcheg has joined #openstack-ironic13:28
zigolucasagomes: Probably. That's just a Jenkins timeout, IMO.13:28
rloozigo: and do you know that the python version is "good"?13:28
lucasagomeszigo, perhaps incress it a bit see how far it gets. Then investigate why it's saying it's inactive13:28
zigorloo: 2.7 and 3.4 are fine.13:28
zigolucasagomes: 150 minutes is *A LOT* of time.13:28
lucasagomesindeed13:29
zigoA way more than it takes to build ironicclient.13:29
rloolucasagomes: I know we test with py3.4, but do we say to the world that ironic/openstack works with py3.4?13:29
lucasagomeszigo, it would be good to have some timestamps for the commands there13:29
rloolucasagomes: I don't think it should take more than 150 minutes!13:29
lucasagomesto see where it's hangin13:29
rloozigo: if it is out of child processes, is there a way to increase that? or find out how many child processes it is using?13:29
lucasagomesrloo, it totally shouldn't, but for debug purprose see what happens if u set the time a bit longer, if it stops at the same place or not13:30
BobBallARGHHH!!!!!! https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ssh.py#L371 Why on earth does sshy.py assume the nodename is __always__ quoted?  For XenServer it isn't :)13:30
* BobBall bangs his head on the padded walls13:30
*** openstackgerrit has quit IRC13:31
rloozigo: is it easy to change jenkins so it runs py3.4 first, before py2.7?13:31
zigorloo: Yes, I just change something in my debian/rules13:31
zigo(for this package)13:32
*** openstackgerrit has joined #openstack-ironic13:32
lucasagomeszigo, build 5 has a diff error https://liberty-jessie.pkgs.mirantis.com/job/python-ironicclient/5/console13:32
*** shoutm has joined #openstack-ironic13:32
lucasagomesironicclient.tests.unit.test_utils.CommonParamsForListTest.test_sort_dir_invalid ... FAIL13:33
lucasagomesfor py3.413:33
zigoThat's because I killed it.13:33
zigolucasagomes: Not relevant IMO.13:33
rloolucasagomes, zigo: that's basically around where the first jenkins died13:33
lucasagomesoh right ok if you killed yah13:33
zigoTrying to build 3.4 tests first, see how it goes.13:34
zigoIf it fails there, then I'll just skip running 3.4 tests.13:34
rloozigo: is it possible it is creating child processes for all those unit tests, but not freeing them?13:34
zigoOk, it is stuck at the same place, still.13:36
zigorloo: What do you mean "not freeing them"?13:36
rloozigo: am wondering if it is spawning processes/threads for the unit tests, but holding on to those threads even after the test is done.13:37
rloozigo: if you do some sort of 'ps' command while it is waiting, you should be able to see how many processes are being used. i think.13:38
zigoWell, it's just standard "testr run" stuff...13:38
BobBalllucasagomes: Confirmed - the bug was that ironic requires for running-vms to give a list of quoted node names instead of just the node names...  Seems that vmware/virsh adds the quotes in the ssh commands but vbox quotes by default13:38
zigoI only see the discover one.13:38
zigoNot even the testr run.13:38
zigoSo my guess is that it really dies.13:38
dtantsurtrown, sambetts, ifarkas, WDYT about releasing the client without introspection data change? it fails in zuul for the 2nd time for mirror reasons...13:39
lucasagomesBobBall, I see13:39
rloozigo: hmm. that's about as much as i know. wonder if the infra folks have more experience with jenkins/testr/blah blah.13:39
lucasagomesBobBall, yeah the ssh driver can be pretty dodge13:39
zigoMaybe.13:39
rloozigo: unless it has to do with that series of tests. i guess you could delete that test file and see what happens.13:39
zigorloo: Thanks, I'll try to ask.13:39
trowndtantsur: fine by me... we can get that same thing with swiftclient... so not really a huge deal13:39
* BobBall thinks some comments explaining the required output from each command would be __very__ helpful.13:39
ifarkasdtantsur, you don't want to wait until tomorrow?13:39
BobBallWhen we add XS support we'll add the comments too.  Just to save the next poor unfortunate soul13:40
dtantsurifarkas, we're past all possible deadlines already tbh...13:40
*** achanda has quit IRC13:40
ifarkasdtantsur, ok then13:40
zigoI can confirm that if not running 3.4 tests, and it finishes building ...13:40
lucasagomesBobBall, hah thanks yes that helps13:40
trownit is also a really small patch for backport later13:40
rlooBobBall: that's a good idea wrt comments. Do you have time to submit a patch for that?13:41
lucasagomesBobBall, are you planning to submit the xenserver virt type support for ssh upstream?13:41
zigoOh, btw, I forgot to tell a good news: ironic-inspector has been FTP master approved, and it will reach your closest Debian mirror soon (FYI: upload was done in Debian Experimental, and will stay there until the final release of Liberty).13:41
trownzigo: nice one13:41
dtantsurzigo, \o/13:41
BobBallYes rloo.  And eventually, yes lucasagomes.  It makes a lot of sense to me to add that support - but I guess there may be additional requirements (e.g. CI?) that might delay adding it...13:41
*** VikasC has quit IRC13:41
sambettsifarkas, dtantsur: I think we can do it, without the table view its only a shortcut to the curl anyways :-P13:41
dtantsurhehe, right13:42
lucasagomesBobBall, not really, cause we don't have CI for anything else than virsh right now13:42
lucasagomesso it's def not a requirement13:42
BobBallAh - well, in that case it might just need a lot more testing + validating before I'm happy with it ;)13:42
lucasagomesBobBall, ++, thanks! Yeah looking fwd to it13:42
BobBallNeed a spec for XS support in ssh driver, or wishlist bug?  Different projects 'n' all...13:43
lucasagomesBobBall, IMHO, a bug is good enough. This is just yet another hypervisor support for the ssh driver13:44
* lucasagomes think parallels only had a bug as well13:44
* lucasagomes checks13:44
rlooBobBall: just looking at that code in ssh.py; we/you could change it so that it looks for non-quoted names too.13:44
lucasagomesBobBall, yeah https://bugs.launchpad.net/ironic/+bug/135840113:45
openstackLaunchpad bug 1358401 in Ironic "Add Parallels virtualisation to ssh driver" [Wishlist,Fix released] - Assigned to Davide Guerri (davide-guerri)13:45
lucasagomesit's cool to have a wishlist bug only13:45
* lucasagomes tho it's an old bug, but hey, it's grand!13:45
BobBallrloo: TBH that was my fix as well (node_name == node) or (quote_node_name in node)13:49
openstackgerritSam Betts proposed openstack/ironic-inspector: Ignore IPMI Address for IPMI Bridged nodes  https://review.openstack.org/22412713:49
rlooBobBall: thx. it is OK to just submit that fix w/o your hypervisor support, since that is a bug. If you want.13:50
rlooBobBall: or you can do it all in one shot or whatever works for you.13:50
BobBallActually - will do that + comments now.13:50
sambettsdtantsur: I've reworked that one ^, unfortunatly until the migrations one goes in and we can update the DB then we can't store multiple bmc_addresses with the same value13:51
BobBallrloo / lucasagomes: BTW... is the vmware ssh driver out of date?  I'm not sure it can work because it does not have get/set boot device?13:53
sambettsdtantsur: I had a solution based on my original one, with the multiple return detection, which would have working, until I realised we couldn't even store it in the DB without changing something13:53
dtantsursambetts, well, IPMI address is useless there anyway13:53
sambettsdtantsur: Yup13:53
rlooBobBall: I don't know but that is possible. Sorry, head down reviewing code now.13:53
*** shoutm has quit IRC13:54
openstackgerritSam Betts proposed openstack/ironic-inspector: Ignore IPMI Address for IPMI Bridged nodes  https://review.openstack.org/22412713:54
BobBallnp!13:54
lucasagomesBobBall, no idea!13:55
dtantsurawesome, now python-ironic-inspector-client release just doesn't work >_<13:55
* dtantsur has a "lucky" day as usual13:56
trownlucky week13:56
dtantsurok, it's queued now. complaining always works :)13:57
*** romainh has quit IRC13:57
sambettsdtantsur: haha13:57
*** absubram has joined #openstack-ironic13:57
*** romainh has joined #openstack-ironic13:58
*** mtanino has joined #openstack-ironic13:58
lucasagomesdtantsur, :-(13:59
*** MattMan has left #openstack-ironic14:01
*** e0ne has quit IRC14:01
*** e0ne has joined #openstack-ironic14:06
*** shoutm has joined #openstack-ironic14:08
*** mjturek1 has joined #openstack-ironic14:09
dtantsurok, we released python-ironic-inspector-client 1.2.0 :) lets move on, ironic-inspector-2.2.0 is ~ in a week :)14:12
rloodtantsur is a stern task master :D14:13
trowndtantsur: aye aye captain14:14
trownnice one on the client release14:14
dtantsur:)14:14
openstackgerritDmitry Tantsur proposed openstack/python-ironic-inspector-client: Support for getting introspection data  https://review.openstack.org/22407514:20
jrollmorning everyone14:20
jrolldtantsur: \o/14:21
openstackgerritNaohiro Tamura proposed openstack/ironic: Refactor IRMCVirtualMediaAgentDeploy by applying new BootInterface  https://review.openstack.org/22157714:21
dtantsurjroll, morning!14:21
lucasagomesjroll, yo14:21
*** achanda has joined #openstack-ironic14:22
jrollrandom informal poll: what do people think about spec-less blueprints for small features (like bob's xenserver support)14:23
dtantsurjroll, I'm all for fall back approach: if patch is deemed to complex we ask a person to write a spec14:23
*** amotoki has quit IRC14:23
jrollI should give context, I guess14:24
jrollI like having BPs for tracking features in releases, just to differentiate features from bugs14:24
jrollthe BP can just be a title and quick blurb like a bug would be, no need to design the feature there14:24
openstackgerritZhenguo Niu proposed openstack/ironic: Check image size before provisioning for agent driver  https://review.openstack.org/21525414:24
jrollbut being able to tag features to a release as a feature rather than a bug seems useful14:25
jlvillalSounds reasonable to me, from a gut feeling, I haven't thought about it a lot, standpoint :)14:25
*** achanda has quit IRC14:25
jrollI'd much rather use another system to track it but hey14:25
dtantsurjroll, yeah, looks good at first glance14:25
jroll\o/14:27
jrollI'd love to get launchpad cleaned up real soon, definitely before the summit14:27
sambettsthat sounds pretty good to me, I've written specs when I end up putting the word None in more places than actually explanation14:28
dtantsuroh yeah, that happens14:29
dtantsurjroll, could you have one more look at https://review.openstack.org/#/c/223054 if you have a minute?14:30
jrollyep14:30
*** mtanino has quit IRC14:31
jrolldtantsur: +A14:31
dtantsurthanks!14:32
jrollnp14:32
* jroll wonders how zapping is doing14:32
jrolllucasagomes: are you planning to deal with the tripleo CI stuff?14:37
lucasagomesjroll, hi there, yes I will14:37
jrollawesome, thanks14:37
lucasagomesjroll, I got a bit confused because it's passing to a lot of changes right now14:37
lucasagomesit was using devtest before now it uses instack14:37
jrollhm14:38
lucasagomesso the patches I put up before doesn't work anymore14:38
jrollweird that your patch could even possibly make it fail14:38
lucasagomesbecause it just doesn't use those scripts to generate images14:38
jrolloh14:38
lucasagomesyeah14:38
lucasagomesheh14:38
jrollthat's fun14:38
lucasagomesjroll, the tripleo-ci was basically replaced14:38
dtantsurjroll, we're upstreaming a HUGE bunch of tripleo downstream stuff14:39
dtantsurit will be much saner once we finish14:39
lucasagomesfrom devtest (and tripleo-incubator etc...) to instack-undercloud and python-tripleoclient14:39
dtantsurbut now it's a temporary mess :)14:39
lucasagomesjroll, yeah that's a good thing actually14:39
lucasagomesjroll, but yeah I will fix it up for IPA14:39
lucasagomeswaiting for it to calm down a little14:39
lucasagomesjroll, anyway, the patch deprecating the deploy-ironic element is now +a14:39
rloojroll: am fine with BP/spec-less, but I think we need to (try to) make it clear what is a BP-spec, BP+spec, bug.14:40
rloojroll: and bug-less :)14:40
lucasagomesjroll, hmm... you mean bps for small features that doesn't need a spec?14:41
rloolucasagomes: I think jroll is saying a feature needs a BP14:41
rloolucasagomes: whether the BP needs a spec, depends on the feature.14:42
lucasagomesrloo, right, but what's the diff of a feature that needs a bp and the one that needs a bp and spec?14:42
rloolucasagomes: that's what i mentioned; we need to try to clarify that or we'll have this question again and again14:42
lucasagomesrloo, ++14:42
lucasagomesjroll, rloo but wouldn't a wishlist bug be better for that?14:42
rloolucasagomes: I suspect a BP without spec is one that doesn't require any architect/thinking about how it fits in.14:42
jrolllucasagomes: well, for release tracking... we list blueprints as features and bugs as bugs14:43
lucasagomesrloo, yeah, perhaps something like "if the feature does impact in multiple areas of the project (api, database model, rpc, etc...) it needs a spec"14:43
jrolland yes, I also want to document this14:44
rloolucasagomes: right. so i think (most) cores might know; if i have to ask questions about how someone is going to implement a feature, it needs a spec.14:44
lucasagomesjroll, fair enuff14:44
rloolucasagomes: and we all know, i ask a lot of questions :D14:44
jrollso here's what I want to do, whether I'm PTL or deva is PTL:14:44
jroll- clean up launchpad, start actually tracking things well there14:44
lucasagomesrloo, lol yeah, it's good tho14:44
rloojroll: there's still time for someone else to run for ptl? :)14:44
lucasagomesrloo, no it's closed14:45
jroll- for a BP to be approved, we decide if it needs a spec or not14:45
rloolucasagomes: oh? good, now the fun starts!14:45
jroll- we also document why we would or would not want a spec14:45
rloojroll: maybe we can discuss this after we freeze liberty.14:45
jrollyeah14:45
jrolljust wanted to start the conversation14:46
rloojroll: cuz i really want to focus on zapping and am still trying to review.14:46
jrolland hear folks' thoughts14:46
jrollyep14:46
openstackgerritBob Ball proposed openstack/ironic: Make requirements for ssh power manager clear  https://review.openstack.org/22477014:46
jrollhence "informal poll"14:46
lucasagomesrloo, ++14:46
rloojroll: yeah, good conversation, i want to participate but... also. maybe start it on mail list?14:46
lucasagomesjroll, yeah those ideas are fine, I think that's why blueprints exists in launchpad14:46
jrollrloo: let me rephrase, I wanted to hear what dmitry, ruby, and lucas had to say about this14:46
lucasagomesit just that launchpad seems a bit eww to track things14:46
jrollrloo: and take it from there14:46
rloojroll: my concern is to avoid too many steps for someone trying to get a feature in. if i have to submit BP, then wait for it to be approved, then submit spec, then wait for it to be approved...14:47
jrolllucasagomes: sure, but a text file or google doc is just as eww :) I for one welcome our phabricator overlords14:47
lucasagomesjroll, yeah ML and if needed we take it to the summit14:47
lucasagomesjroll, fair enuff14:47
lucasagomesI'm ok with processes, as long as we have a well defined flow14:48
lucasagomesthat is straight fwd14:48
jrollyep14:48
rloojroll: I *think* we had the idea of short specs for that purpose; to get a quick 'does it need more info or not'. and I don't think anyone has gone that route.14:48
jrollI don't see it as different than "file a wishlist bug", it's still a quick form on launchpad14:48
rloolucasagomes: the process could be well-defined, but if takes weeks to get a bp approved and weeks to get a spec approved, there is something wrong.14:48
lucasagomesrloo, the short spec was more in the fields of ideas. Sometihng controversial that may not be aligned with the project's scope14:48
lucasagomesrloo, and the idea was to either say: "yeah go ahead and finish up the spec" or "no we don't think the idea is aligned within the project scope"14:49
*** penick has joined #openstack-ironic14:49
lucasagomesrloo, ++14:49
jrollrloo: my goal would be days or less to get feedback on the blueprint :)14:49
rloojroll: the wishlist bug, unless we triage and kick it out, means that the person can start coding. and/or we ask person to submit spec for the wishlist bug.14:49
rloojroll obviously has his release hat on. which is good I guess :)14:50
jrollhehe14:50
lucasagomes:D14:51
*** achanda has joined #openstack-ironic14:52
lucasagomesas a side, one thing that I usually do when writing a spec is to code in parallel, like POC. Because sometimes I just don't know how to solve something unless I'm trying it out14:53
*** dims_ has quit IRC14:53
jrolllucasagomes: +1, I'm the same way14:54
jlvillaldtantsur, After reading up on decorators and looking at Ironic code yesterday, I learned something. You must know a lot about decorators :)14:54
dtantsurhehe14:55
dtantsurjlvillal, morning :)14:55
jrollsomething something mad scientist14:55
jlvillaldtantsur, In particular decorators with arguments and needing two layers of closure in the decorator :)14:55
* jlvillal learned that yesterday.14:55
*** dims_ has joined #openstack-ironic14:55
jlvillaldtantsur, Good morning14:55
dtantsurjlvillal, I think that's just a problem in design. @decorator should be equivalent to @decorator(). but it's not.14:56
jlvillalYep.14:56
dtantsurthough it would be a bit less flexible, I have to admit14:56
jlvillalAnd then there is decorators implemented using a class vs the typical function implementation.14:57
dtantsurwell, class with __call__ is callable :)14:57
dtantsurI know even worse topic for understanding: metaclasses14:58
jlvillalBut if use a decorator implemented using a class on a class function it makes it even weirder. With __get__ being called. My brain started hurting at a certain point :)14:58
*** penick has quit IRC14:58
dtantsur:)14:58
* jroll sees metaclasses and runs away14:58
jlvillaldtantsur, I will weight for a day when I feel like I deserve punishment to learn about metaclasses ;)14:59
jlvillals/weight/wait/14:59
*** Marga_ has joined #openstack-ironic14:59
* jlvillal goes prepares to go to work...14:59
dtantsurI was hacking on SQLAlchemy some years ago. A lot of fun :)14:59
dtantsurmetaclasses, decorators, descriptors, everything mixed15:00
*** Marga_ has quit IRC15:00
*** Marga_ has joined #openstack-ironic15:01
*** jefabo has quit IRC15:04
*** zhenguo has quit IRC15:06
lucasagomesdtantsur, heh metaclasses are really black magic15:08
rlooomg, pep8 failure, No matching distribution found for hacking<0.11,>=0.10.015:08
rloohttp://logs.openstack.org/99/224299/2/check/gate-ironic-pep8/92a5fda/console.html15:08
* rloo so sad15:08
lucasagomes:-(15:09
jroll:|15:09
jrolloh wait, I think I may have heard about pypi mirror issues15:09
*** achanda has quit IRC15:09
jrollyeah, that's what it looks like15:09
lucasagomeswe are hitting record number of gate breakage the last 2 weeks (non was our fault tho)15:10
dtantsurone of our patches didn't get in the release because of gate...15:10
*** ukalifon has quit IRC15:10
dtantsuryeah, the same error15:10
sambettsdtantsur: :(15:11
jrollyeah, verifying with infra but I saw some things in scrollback there15:11
*** mgoddard has quit IRC15:12
*** mgoddard has joined #openstack-ironic15:12
*** alexpilotti has quit IRC15:19
openstackgerritMerged openstack/ironic-python-agent: inspection: prepare for future deprecations  https://review.openstack.org/22305415:22
*** alexpilotti has joined #openstack-ironic15:24
*** puranamr has joined #openstack-ironic15:25
*** krtaylor has quit IRC15:29
*** devlaps has joined #openstack-ironic15:40
jrollJoshNang: getting close15:50
*** puranamr has quit IRC15:51
*** vishwanathj has joined #openstack-ironic15:51
JoshNang\o/15:56
* JoshNang goes to fix15:56
*** krtaylor has joined #openstack-ironic15:57
jrollJoshNang: I'm testing in devstack now btw15:59
*** e0ne has quit IRC15:59
jrollif you want to wait a few, I may end up with more comments15:59
*** e0ne has joined #openstack-ironic16:00
JoshNangwfm. i've gotta rebuild my devstack box today16:00
*** purp has quit IRC16:02
*** ijw has joined #openstack-ironic16:05
*** uggla_ has joined #openstack-ironic16:05
jrollJoshNang: if something gets stuck in zapping due to code bug, that can't be aborted right?16:05
*** shoutm has quit IRC16:05
dtantsursee you tomorrow16:06
*** dtantsur is now known as dtantsur|afk16:06
JoshNangjroll: not yet16:07
jrollk16:07
JoshNangfound a code bug?16:07
*** mgoddard has quit IRC16:09
jrollJoshNang: yeah16:10
jrollhere, I'll add the comments16:10
jrollconductor line 87516:10
jrollalso...16:11
jrollI submitted '{"target": "zap", "zap_steps": [{"interface": "deploy", "step": "hi"}]}'16:11
jrollit booted the agent and whatnot16:11
jrolland did the step, in theory16:11
jrolldon't see any indication that it didn't happen16:11
jroll(because obviously invalid step)16:11
JoshNangweird, wtf16:12
jrolllemme play with it16:13
jrollI wonder if it just skipped the first step altogether16:13
*** mgoddard has joined #openstack-ironic16:13
jrolloff by one errors ftw16:13
*** purp has joined #openstack-ironic16:13
*** e0ne has quit IRC16:15
*** romcheg has quit IRC16:16
* lucasagomes updated the microversion support patch for the ironic driver in nova, for those interested: https://review.openstack.org/#/c/221848/ 16:18
JayFthanks lucas16:18
JayFjroll: I talked to clif_h yesterday; I think he's interested in picking up improving the agent client as an upstream project16:19
JayFjroll: very exciting \o/16:19
clif_hI will corroborate JayF's story16:19
*** sdake_ has joined #openstack-ironic16:19
JayFWe have to let the entire onmetal team +1 the change that removes the comment from Russell with the #todo(russell) actually error check16:20
JayFor somehting like that16:20
JayFheh16:20
*** karimb has joined #openstack-ironic16:20
*** ifarkas has quit IRC16:20
*** sdake has quit IRC16:23
devanandajroll: if you want to manage LP -- I'd say "go for it" except I think it's such a bad tool for collaborative design that it would hamper the whole team and I'd rather we just not use it.16:23
jrolldevananda: I mean, we need something, I'd also rather not use launchpad but it's already integrated with all the release management stuff16:24
jrolldevananda: so I'd prefer to take that pain now and move to phabricator ASAP when that's a thing16:24
jrollI definitely don't think we should do design there, if that's actually what you meant16:25
*** penick has joined #openstack-ironic16:25
jrolldesign can stay to specs, just LP for tracking things16:25
devanandajroll: tracking acceptance status of BP's?16:26
devanandajroll: I thought that was done through the specs process now16:26
jrolldevananda: tracking all the steps, and also features that don't need a spec16:27
jrolllike "added minor feature X" shouldn't be in the list of bugfixes for a release, but it is now because we use wishlist bugs for that16:28
*** romcheg has joined #openstack-ironic16:28
lucasagomesdevananda, morning16:29
*** romainh has left #openstack-ironic16:31
devanandajroll: I agree that using LP to generate release notes is helpful16:31
devanandajroll: so if ttracking minor features with a short BP is helpful, even though it breaks the process of needing a spec for every BP .... maybe?16:32
BobBallHey all... One more question (I hope just one).  Trying to boot a node I get an error in the console of the node saying that it was unable to locate the target IQN.  We don't understand this one - and actually are getting confused about where the server is vs the client?16:32
devanandajroll: anyhow, probably a better topic for tokyo16:32
lucasagomesthere's no way to filter the wishlist bugs severity and mark it as a feature? (Maybe I got used to the same stuff on bugzilla, but there s/whishlist/enhancement)16:33
jrolldevananda: I mean, it can just be a title and a link to a spec, E_DO_NOT_CARE16:33
devanandalucasagomes: LP doesn't differentiate between importance and severity16:33
devanandait's one of the major issues I take with its design16:33
lucasagomesBobBall, you're using pxe_ssh and not agent_ssh right?16:33
*** garthb has joined #openstack-ironic16:33
BobBallRight16:34
lucasagomesBobBall, cause with pxe_ssh, the way the image gets written to the node's disk is: The deploy ramdisk boots up -> expose the local disk as an iscsi target and send it to the Ironic conductor via the API -> ironic conductor writes the image onto the disk over the network16:34
BobBallJust had to double check though! :D16:34
lucasagomesso see if the network stuff is configured properly16:34
BobBallYes, that's what we thought - which is why we're confused that the node is saying that it can't find the initiator16:35
*** jistr has quit IRC16:35
*** sdake has joined #openstack-ironic16:35
lucasagomesdevananda, :-( that's sad16:35
BobBallIt connects to the host, but the error is iscsi Login negotiation failed; are there access credentials somewhere?16:35
*** david-lyle has quit IRC16:36
lucasagomesBobBall, hmm there's none. But you may have problems with the time (session expiring)16:36
lucasagomesa ntp server is usually useful for it16:36
BobBallAh - ok.  I don't have an NTP server setup.  Good call.16:36
* BobBall will investigate16:36
*** ifarkas has joined #openstack-ironic16:37
lucasagomesBobBall, cool16:37
*** sdake_ has quit IRC16:38
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/22461716:39
jrollJoshNang: conductor continue_node_clean always sends clean_steps, left a comment16:40
*** Nisha has joined #openstack-ironic16:41
jrollstepping away for a few then some meetings, will continue testing this as time allows16:41
lucasagomesjroll, JoshNang btw I have a patch touching those parts (the abort one)16:41
JoshNangjroll: ah, good catch16:41
JoshNanglucasagomes: yeah :( but also ++ for abort.16:42
lucasagomesJoshNang, ++ yeah we can add it to zapping too16:42
JoshNang++ should be an easy follow up16:42
lucasagomesindeed!16:43
*** penick has quit IRC16:43
Nishalucasagomes, jroll JoshNang please could you have look at https://review.openstack.org/21706816:46
lucasagomesNisha, will do /me adds to his todo16:46
lucasagomesI'm going home now (thursday's office day)16:47
lucasagomeshave a great night everyone!16:47
NishaThanks lucasagomes16:47
*** lekha||away is now known as lekha16:47
*** david-lyle has joined #openstack-ironic16:47
*** mtanino has joined #openstack-ironic16:48
lucasagomessee y'all16:48
*** derekh has quit IRC16:50
*** ndipanov has quit IRC16:50
sambettsCya lucasagomes16:51
*** lucasagomes has quit IRC16:53
*** Nisha_away has joined #openstack-ironic16:57
*** Nisha has quit IRC16:57
openstackgerritVladyslav Drok proposed openstack/ironic: Add retries to ssh._get_hosts_name_for_node  https://review.openstack.org/22482817:02
*** david-lyle has quit IRC17:03
*** Nisha_away has quit IRC17:04
*** harlowja has joined #openstack-ironic17:04
*** Nisha has joined #openstack-ironic17:04
*** trown is now known as trown|lunch17:10
*** ijw has quit IRC17:10
*** romcheg has quit IRC17:10
jrollJoshNang: something up with the heartbeat thing, I'm not sure what the intended code is17:10
JoshNangoh?17:11
jrollbut it looks like we only resume if not clean_step and not zap_step?17:11
jrollI don't see where it's like "oh hey, step is complete"17:11
jrolloh, wait, the else hmm17:12
jrollthe log message there is throwing me off17:13
JoshNangright17:13
jrollline 40217:13
JoshNangyeah, that gets me pretty often17:13
JoshNangs/msg/exc_msg/ or something17:13
jrollOH17:14
jrollheh17:14
*** romcheg has joined #openstack-ironic17:14
*** uggla_ has quit IRC17:14
*** Marga_ has quit IRC17:15
*** Marga_ has joined #openstack-ironic17:16
*** lsmola has quit IRC17:17
*** karimb has quit IRC17:17
jrollMUAHAHA17:17
*** ijw has joined #openstack-ironic17:19
jrollJoshNang: left a comment, but _get_completed_cleaning_command needs more zap17:20
JoshNangahh gdi17:20
JoshNangin retrospect, we should have just allowed you to pass in a list of steps to cleaning and avoided zapping completely17:22
jrollmhmmm17:23
jrollit's not too late to do that :)17:23
JoshNangit honestly might be easier, but would mean changing the state machine17:23
JoshNangwell. maybe.17:24
jrollI'm not sure17:24
* jroll thinks about it17:24
rlooI was thinking about that. Getting rid of 'zap' altogether and just use 'clean'. there are a few things in our state machine that don't like 'clean' states going to different target states.17:24
jrollI do like the idea of keeping the code/api nicer17:25
jroll(but is automated clean + manual clean going to be confusing to users? not sure)17:25
rlooor is zap (manual) and clean (automated) more confusing?17:25
JoshNangright, the biggest problem i see is manageable->clean/zap->manageable17:26
rlooI think it is less confusing to have automated/manual clean.17:26
JoshNang++ personally17:26
*** Nisha has quit IRC17:26
*** Nisha has joined #openstack-ironic17:26
jrollJoshNang: rloo: I hate to ask this question... maybe (though sad) it would be better to bump this to M and rework it?17:27
jrollrather than dealing with a less-optimal API for years?17:27
JoshNangjroll: i think that's best for the long term success of the project17:27
rlooyeah. it means no RAID though. unless we fix that to work with auto clean.17:28
JoshNangthough i'll be sad to not get to finish it. (i'm leaving RS in a week)17:28
rlooJoshNang: WHAT?17:28
jrollrloo: no inband RAID, or none at all?17:28
rloojroll: no inband RAID.17:28
JoshNangi though raid works with clean right now?17:28
jrollrloo: ok. hm.17:28
JoshNanghrm maybe17:28
JoshNangrloo: yeah :( i'm leaving RS for a healthcare startup next thurs :( :( :(17:29
rlooIt had something to do with not knowing how to handle verifying the raid config or something. i've already forgotten but I left a note in the review. let me find it.17:29
rlooJoshNang: Yay and Boo! That is awesome for you.17:29
JoshNangrloo: yeah :) it's an inspiring mission so :) :) :) there, but i'm gonna miss this community17:30
rlooJoshNang: the healthcare startup wants to use OpenStack, right? ;)17:30
JoshNangheh maybe!17:30
*** Nisha_away has joined #openstack-ironic17:31
*** Nisha has quit IRC17:31
rloowrt RAID & cleaning: https://review.openstack.org/#/c/198238/17:31
*** ifarkas has quit IRC17:31
rlooI was trying to recall the reasoning for not allowing RAID in cleaning. Dmitry said it was: 1. it won't work with cleaning, as target config is overriden in the end of cleaning; 2. it's unclear how to handle difference between zap and cleaning (i.e. whether to fail if target config is none)17:32
jrollJoshNang: one more thing... this isn't popping the step off the list17:32
* jroll shredding a VM forever17:32
rloojroll, JoshNang: #1 is not a concern any more. the code was changed so that target confis isn't overridden17:32
*** jefabo has joined #openstack-ironic17:32
rloojroll, JoshNang: so #2 is what we didn't know so we punted on it.17:32
jrollgot it17:33
JoshNangmakes sense17:33
*** penick has joined #openstack-ironic17:34
JoshNangso if we kill zapping, make it fail if target config is none?17:34
rlooJoshNang: assuming we add in the configs to set the create/deleteRAID step priority and it is non-zero.17:35
rlooJoshNang: no target config; 1. fail all cleaning or 2. 'skip' the create RAID step17:36
*** Nisha_away has quit IRC17:37
*** Nisha_brb has joined #openstack-ironic17:37
*** achanda has joined #openstack-ironic17:39
JoshNangrloo: hrm i'm gonna have to review this harder17:39
rlooJoshNang: I think it should fail cleaning. BUT maybe for almost all your nodes, you want RAID stuff done, but you have a few special cases. We only have one global config to do raid or not, so you want to use the 'no target config' to indicate whether or not to do it for that particular node.17:41
rlooJoshNang: on the other hand, all the other clean steps (so far) are ON or NOT, depending on the agent/hw manager on the node, right?17:41
*** jefabo has quit IRC17:41
*** Nisha_brb has quit IRC17:42
*** Nisha_brb has joined #openstack-ironic17:43
JoshNangrloo: so hrm. does setting the raid expose any scheduling hints?17:44
JoshNangand yeah, the steps in a hwm are much more dynamic, can be based on what hardware is actually present, etc. so it's less global17:46
openstackgerritSam Betts proposed openstack/ironic-inspector: Add alembic migrations for the inspector database  https://review.openstack.org/22366517:48
jlvillalJoshNang: WTF!?!?!17:48
jlvillalYou are leaving :(17:48
jlvillalSo sad...17:48
jlvillalFor us.17:48
JoshNangjlvillal: yeah :( but y'all get another week of me! :D17:49
jlvillalI hope you have great fun though!17:49
JoshNangi will...it's a small team...lots of room to make a big impact on our patients' lives17:49
jlvillalJoshNang: Sounds like a great opportunity :)17:49
rlooJoshNang: you ask too much! There isn't any explicit correlation between setting RAID and scheduling hints. Not that I know of anyway.17:49
JoshNangrloo: ahh! dang. if there was, skip would be much more palatable...you'd get no hosts found errors instead of provisioning to a box you thought had raid but doesn't17:50
rlooJoshNang: but presumably, depending on the raid-config per node, that node can be set up appropriately to have its properties/capabilities match a flavor.17:50
jlvillalPersonally I find 'zap' vs 'cleaning' confusing. As someone who hasn't read that much about it. 'automated cleaning' vs 'manual cleaning' would be easier to read and more likely to be understood immediately.17:51
jlvillalIMHO17:51
JoshNangjlvillal: ++17:51
* rloo so said that we're all voicing this now instead of 6+ months ago.17:51
jlvillalTrue :(17:52
rloobut better late than never17:52
jrollwell, I think we've learned a lot since then17:52
rlooso 'zap' isn't a normal term used by operators?17:52
JoshNangLOL17:52
jrollheh17:52
jrollI still don't know where that came from :)17:53
* jlvillal doesn't know as he needs operator training. Which comes in November.17:53
JoshNangi think most operators prefer "pew pew"17:53
*** harshs has joined #openstack-ironic17:53
* jroll wonders what operator training is17:53
* jlvillal thinks it is what RackSpace will teach him in November. He hopes it is :)17:53
JoshNangjroll: i think that's where they throw you at hardware and say "make a cloud!"17:53
jroll"here, stare at these logs and see if you find anything interesting"17:53
rloojroll: i think it means they're going to send jlvillal to RS17:53
JoshNang:D17:53
jroll"here, I'm going to break your network, try to keep things up"17:53
jlvillalrloo: ding ding ding!17:53
rloooh, so I was right! ha ha.17:54
rloojlvillal: can you request to be where jroll and JayF are? :)17:54
jlvillalrloo: Yeah, Rackspace and Intel have a joint agreement. So I will go learn from them in San Antonio.17:54
jrollrloo: I'm not letting him in my house... at least not for work :D17:54
jlvillalrloo: I did request San Francisco and my boss said no.17:54
jrollhe can come over for beers, though17:54
JoshNangheh17:54
jrolllol17:54
rlooJoshNang: you sure you want to leave. Look at all the fun you'll be missing...17:55
jrolljlvillal: SF office isn't very openstack-y anyway :P17:55
jlvillalSomething about me needing to learn how to ride escalators and go down slides.17:55
JoshNangrloo: ;)17:55
jrollslides \o/17:55
rlooso to go back to zap vs clean. Are we good with 'clean'? (as the verb/descripto/blah blah)17:56
jrollI tend to prefer 'clean' for both, even if it wipes out days worth of work from josh17:56
JoshNangi think it's good. i'd also prefer not to break the api by changing it17:57
*** ijw has quit IRC17:57
jrollbut it's hard to say it could land this cycle :(17:57
rloojroll, JoshNang: I'm not convinced it wipes out a lot of work of Josh's. We still need that code refactored.17:57
JoshNangjroll: meh. better than a crappy api17:57
rlooit is really the strings etc that were/are annoying, right?17:57
jrollrloo: a lot of that work is s/clean/clean_or_zap/17:57
jrollyeah, it's just gruntwork17:57
jrollbut still work17:58
JoshNangyeah. also a lot of parallel state checks like if zapwait: etc17:58
rloojroll: that's minor as long as architecturally etc it is good17:58
jrollright17:58
jrollstill conflicted on landing it17:58
rloojroll: oh, i don't think we should land it as is.17:58
jrollrloo: I mean "during this cycle"17:58
rloojroll: just need to think of what we'd like, and what/if those are minor changes to the existing patch.17:58
rloojroll: oh, well, if not during this cycle, should be soon after, if we can agree on something.17:59
jroll+217:59
rloolike, i think we might agree that the verb should be 'clean', not 'zap'?17:59
jroll*I* agree17:59
jrollidk abuot anyone else :)17:59
JoshNangso we'd need the handling for the optional steps args in the provision state. and we'd need to store those provided steps on the node, then some handling around set_node_clean_steps to prefer the provided steps...and that should be it18:00
rlooI *think* the issue for me is the state machine, and ZAP* states vs CLEAN* states.18:00
rlooJoshNang: that'd be node.clean_steps I think. or node.target_clean_steps? hmm, don't like the target.18:01
jrollyeah... state machine will need to allow manageable -> verb[clean] -> manageable, which doesn't seem that painful18:01
rlooJoshNang: your code already handles the optional step args in the provision state for 'zap', right?18:02
rloojroll: well, it isn't painful except that we added 'target-state' or something like that to our state machine.18:02
*** trown|lunch is now known as trown18:03
jrollrloo: right, I think that helps if nothing else18:03
rloojroll: I actually looked at it briefly yesterday or the day before. Guess I should have mentioned it then. I had decided it might not be worth delving into the state machine code to see about how to deal with that target state.18:03
rloojroll: let me think/look into it. Need a couple hours maybe.18:04
jrollrloo: yeah, I guess I need to read code18:04
JoshNangjroll: oh. manageable -> verb[clean] -> manageable is pretty perfect.18:04
jrollrloo: JoshNang so at some point today we need to make the decision whether to sneak this into 4.2 (liberty) or punt on it until Mitaka opens18:05
JoshNangrloo: yeah, actually that's fine18:05
*** jamielennox is now known as jamielennox|away18:05
jrollI'm leaning toward the latter18:05
JoshNangeither wfm. i can start coding it18:05
rloojroll: https://github.com/openstack/ironic/blob/master/ironic/common/states.py#L23018:05
rloojroll: that's what I mean. target=AVAILABLE.18:06
jrollrloo: oh :(18:06
JoshNangah dang18:06
rloojroll: in meeting now; let me think about it a bit. if I can figure out something that is simple, I think we can get it in. Otherwise, we punt on it.18:06
jrollrloo: ditto, sounds good. thank you!18:06
JoshNangwfm...i should probably head in to the office anyway :P18:07
JoshNangrloo: jroll thanks for the help here!18:07
jrollnp18:07
*** e0ne has joined #openstack-ironic18:07
rlooJoshNang: thank YOU for working on zapping :)18:07
devanandajroll: product WG wants to know our roadmap. forwarding you the email. I'm happy to respond or to etherpad up a response with you, if you'd like18:07
jrolldevananda: will read in a moment here18:08
JoshNang:)18:08
*** pelix has quit IRC18:11
jrolldevananda: either way works for me18:11
devanandak, i'll fire off a quick reply18:13
*** e0ne has quit IRC18:17
jrollthanks18:18
*** sdake has quit IRC18:19
*** athomas has quit IRC18:20
*** e0ne has joined #openstack-ironic18:21
*** sdake has joined #openstack-ironic18:23
sambettsNight all o/18:25
TheJuliagoodnight18:26
*** yog_ has quit IRC18:27
jlvillalsambetts: Good night!18:28
*** sdake has quit IRC18:31
*** sdake has joined #openstack-ironic18:34
*** [1]cdearborn has joined #openstack-ironic18:40
openstackgerritJohn L. Villalovos proposed openstack/ironic: Add constraint target to tox.ini  https://review.openstack.org/22062718:40
*** penick has quit IRC18:41
openstackgerritJohn L. Villalovos proposed openstack/ironic: Add constraint target to tox.ini  https://review.openstack.org/22062718:43
*** greghaynes has quit IRC18:49
*** penick has joined #openstack-ironic18:51
*** penick has quit IRC18:51
*** cdearborn has quit IRC18:51
openstackgerritGrzegorz Grasza (xek) proposed openstack/ironic: Fix upgrades by implementing indirection_api  https://review.openstack.org/22407919:04
openstackgerritMario Villaplana proposed openstack/ironic-python-agent: Adds more functional tests for commands  https://review.openstack.org/22424719:08
*** devlaps has quit IRC19:08
*** yog_ has joined #openstack-ironic19:10
*** david-lyle has joined #openstack-ironic19:11
jlvillalDoes anyone else have opinions on imports inside classes inside functions?  Should imports be done at the top of the file?19:12
* jlvillal thinks the answer is yes they should be at the top of the file and not inside a class function.19:13
*** olaph has quit IRC19:18
jrolljlvillal: agree, though one might put them in a function to avoid circular imports19:21
jlvillaljroll: Thanks. I don't think it is the case for the patch I was reviewing. I left comment and see if they have strong reasoning for it being there. If so, I think a comment would be good.19:21
jroll+119:22
* jlvillal likes comments when things deviate from the expected :)19:22
*** david-lyle has quit IRC19:25
*** Marga_ has quit IRC19:26
*** alexpilotti has quit IRC19:35
*** sinval has quit IRC19:37
*** sinval has joined #openstack-ironic19:37
*** Sukhdev has joined #openstack-ironic19:39
*** sinval has quit IRC19:42
*** sinval has joined #openstack-ironic19:43
*** sdake has quit IRC19:46
*** yog_ has quit IRC19:46
*** yog_ has joined #openstack-ironic19:47
*** sdake has joined #openstack-ironic19:49
*** derekh has joined #openstack-ironic19:51
*** Sukhdev has quit IRC19:51
rloojroll, JoshNang: here's what I'm thinking/proposing wrt zap -> clean.19:52
JoshNangrloo: thinking more about raid...you have to opt in to raid by changing the priority or hardware manager in the agent. if we have a raid config that is basically "don't raid", then we can fail cleaning if no config is provided19:52
rlooI don't think it is feasible to use the existing CLEAN* states for both manual & automated cleaning, cuz of the target-state stuff19:53
JoshNangwhere do we use that?19:53
*** Sukhdev_ has joined #openstack-ironic19:53
rlooJoshNang: the node has a target_provision_state19:53
JoshNangsure, but is that actually used?19:54
rlooJoshNang: and that node.target_provision_state is set via the fsm's target_state19:54
jrollrloo: about to jump in a meeting for an hour, sorry :(19:54
JoshNangsame :/19:54
rlooJoshNang: in the short term, I don't want to touch target_provision_state19:54
rloojroll, JoshNang:ok19:54
rloojroll, JoshNang: I'll add this in comments to the patch.19:55
rloojroll, JoshNang: and you can decide what to do based on that :)19:55
JoshNangalrighty. i have most of the patch (minus needing some updated tests) to fix what's commented so far. i'll push it up either way19:55
rlooJoshNang: thx!19:55
jrollrloo: alright, ty19:56
*** Nisha_brb has quit IRC19:57
*** Nisha_brb has joined #openstack-ironic19:57
*** sdake has quit IRC19:57
*** sdake has joined #openstack-ironic20:00
*** Nisha_away has joined #openstack-ironic20:04
*** Nisha_brb has quit IRC20:04
*** Sukhdev_ has quit IRC20:06
*** ijw has joined #openstack-ironic20:08
*** Nisha_away has quit IRC20:10
*** Nisha has joined #openstack-ironic20:10
*** Nisha_away has joined #openstack-ironic20:16
*** Nisha_away has quit IRC20:17
*** Nisha has quit IRC20:17
*** lucasagomes has joined #openstack-ironic20:17
*** Nisha has joined #openstack-ironic20:18
*** Nisha_away has joined #openstack-ironic20:19
*** Nisha has quit IRC20:19
*** Nisha_brb has joined #openstack-ironic20:21
*** Nisha_away has quit IRC20:21
*** Nisha_brb has quit IRC20:21
*** penick has joined #openstack-ironic20:21
*** derekh has quit IRC20:21
*** Nisha_brb has joined #openstack-ironic20:21
*** Nisha_away has joined #openstack-ironic20:25
*** Nisha_brb has quit IRC20:25
*** Marga_ has joined #openstack-ironic20:26
*** Nisha_away has quit IRC20:26
*** Nisha_away has joined #openstack-ironic20:26
*** lucasagomes has quit IRC20:29
*** karimb has joined #openstack-ironic20:29
*** penick has quit IRC20:31
openstackgerritMerged stackforge/pyghmi: Add custom OEM domain name command for Lenovo ThinkServers  https://review.openstack.org/22191120:40
*** Nisha_away has quit IRC20:40
*** Nisha_away has joined #openstack-ironic20:41
*** Sukhdev has joined #openstack-ironic20:42
*** lucasagomes has joined #openstack-ironic20:44
*** krtaylor has quit IRC20:45
*** baoli has quit IRC20:46
*** baoli has joined #openstack-ironic20:46
*** Nisha_away has quit IRC20:47
*** e0ne has quit IRC20:50
*** Nisha has joined #openstack-ironic20:56
*** penick has joined #openstack-ironic20:57
*** penick has quit IRC20:59
*** Nisha has quit IRC21:03
*** blakec has joined #openstack-ironic21:04
*** david-lyle has joined #openstack-ironic21:06
JoshNangrloo: it seems like 2 is the exact same patch, minus zap_step and slightly different api code. still ugly, still full of conditionals. i'd rather kill target state and have it implicty in the state machine.21:06
*** ijw has quit IRC21:06
rlooJoshNang: Not as many conditionals as before (I mean, the logs/output dont' have to say 'manual clean' vs 'clean' I don't think?)21:07
rlooJoshNang: I didn't see any obvious/quick way to clean up/fix the target state stuff.21:07
JoshNangsure, i don't think there's any quick fix here21:08
rlooJoshNang: w/o hacking something and I don't want to take the chance of breaking our state machine stuff.21:08
*** david-lyle has quit IRC21:09
rlooJoshNang: my 2 was the least risk/good to go into Liberty.21:09
*** baoli has quit IRC21:09
rlooJoshNang: but will let you or jroll make the call. we can just punt it to M*21:09
*** baoli has joined #openstack-ironic21:09
JayFrloo: JoshNang: jroll: Should we put in a PR to revert/change zapping spec if it's getting pushed + perhaps substantially changing?21:10
JoshNangheh fwiw, there's still the followup to the zapping spec pending21:10
JoshNanghttps://review.openstack.org/#/c/209207/21:10
rlooJayF: I must be tired. what is a PR?21:10
JayFrloo: github terminology. "Pull Request"21:11
JayFrloo: I should've said gerrit patchset or something more openstacky21:11
rlooJayF: oh. gotcha. i hate pull requests.21:11
*** trown is now known as trown|outttypeww21:11
rlooJayF: yeah, we'd need to change the spec.21:11
*** Sukhdev has quit IRC21:12
JoshNangwith that, i'd say this is definitely a punt-to-M21:14
*** baoli has quit IRC21:14
*** absubram has quit IRC21:16
*** olaph has joined #openstack-ironic21:16
jrollJayF: no, we should just ignore it and pretend it didn't happen21:18
jroll;)21:18
jrollJoshNang: rloo: I take it this means bumping in-band raid as well eh21:20
rloojroll: not necessarily. just need to get it to work with cleaning.21:21
jrollok.21:21
rloojroll: the code is in21:21
jrollrloo: oh, so just some tweaks then?21:21
rloojroll: I mean, the code for that is merged, to be used with zapping21:21
rloojroll: yeah. I think. two configs, and whatever I mentioned earlier.21:21
jrollrloo: perfect21:22
*** ijw has joined #openstack-ironic21:22
rloojroll: what to do if the target config wasn't specified, but create-raid-config is a clean step.21:22
jrollyep21:22
rloojroll: i don't even have my head wrapped around what clean steps i'd want and what i'd like to see happen if one of them fails, let alone know what to do in the raid situation. if i had to choose, if they configure create-raid as a clean step, they should specify target-config, and if they don't, clean bombs. but that's just me :)21:23
*** dims_ has quit IRC21:23
*** jamielennox|away is now known as jamielennox21:24
jrollrloo: yeah, I need to think about it... I tend to think you're right. if part of the fleet shouldn't get RAID, they could get a different ramdisk without that clean step or something21:24
rloojroll: I think it is all or nothing. per driver.21:25
jrollrloo: hm, I would think for inband that clean step would come from the agent?21:25
jrollI should like, read this code21:25
rloojroll: yeah, from the agent.21:26
rloojroll: and yeah, you should read the code :)21:26
rloojroll: cuz really, I'm not 'up' on the agent.21:26
jrollrloo: right, so they could build a second agent without that clean step for those nodes21:26
jrollwhich is a pain but hey21:26
rloojroll: ok. presumably, that's how you'd/the agent stuff/ would deal with any clean step21:27
JoshNangor have the hardware manager conditionally expose that step (nodes with this raid card have a raid step, nodes without a raid card don't have the step)21:27
jrollyah21:27
rlooso the feature freeze whatever is today. fixing the raid to work with clean can be done next week i think? or did you want it in this week?21:28
jrollI'm okay with whenever for that, I think21:28
jrollI guess I'd have to see the code21:29
rloojroll: oh, you mean someone needs to write it?21:29
jrollrloo: I assume so :P21:29
rlooi wonder if ramesh is around.21:29
jrollI agree21:29
JoshNanghe's in india, right? if so, it's 3am :P21:31
JoshNang(or about that timezone, iirc)21:31
jrollyeah, india21:32
openstackgerritJohn L. Villalovos proposed openstack/ironic: Help patch authors to remember to update version docs  https://review.openstack.org/22490821:32
rlooJoshNang: yeah. Just that I didn't see anything from him last night/earlier today. but he just came back from some time off so I think he's around.21:33
JoshNangah gotcha21:33
jlvillalJoshNang: On your zapping initial patch. I'm fine if doc change was a follow up, but I am not the decider :)21:33
JoshNangjlvillal: ++21:34
rlooJoshNang, jroll: I can probably push up a preliminary patch for it if we want something this week. I'm here for another few hours, then gone til Mon.21:34
jlvillalJoshNang: It did motivate me to do the patchset I just uploaded.21:34
JoshNangrloo: sure, i'd be more than happy to review.21:34
rlooJoshNang, jroll: should we mark the zap patches as work in progress or something?21:35
jrolljlvillal: a doc update like this one? https://review.openstack.org/#/c/223295/21:35
jrollrloo: you already have a -2 on the first one :)21:35
rloojroll: yeah, but jlvillal just reviewed it.21:35
jrolltrue21:35
rloojroll: no sense folks reviewing if we're going to change it.21:35
openstackgerritMerged openstack/ironic-specs: Extend the state machine spec to cover DEPLOYWAIT and abort  https://review.openstack.org/22400821:35
jlvillaljroll: Ah! Cool. I will get rid of my -1. Thanks.21:35
JoshNangyeah i'll wip em all21:36
jrollJoshNang: let us do it in case you disappear :P21:36
JoshNangheh k :D21:36
jrollrloo: I've WIPd them21:36
rloojroll: good thinking. although I think wips are easy to get rid of; just do another revision. it's those killer -2s that are more of a problem!21:36
rloothx jroll21:36
jrollnp, ty for suggestion21:37
jrollrloo: it's also now gone from https://launchpad.net/ironic/+milestone/4.2.021:37
* jroll updates the other BPs there21:37
rloojroll: thx21:37
jrollrloo: probably safe to call this done? https://blueprints.launchpad.net/ironic/+spec/ironic-generic-raid-interface21:42
rloojroll: yesish.21:43
jrollrloo: after your patches?21:43
rloojroll: i have an update to that spec -- i was reviewing it yesterday and there were a few inconsistencies wrt coding, so figured that'd be the best way to document/check with ramesh.21:43
rloojroll: after patches. + client + any documentation.21:43
jrollrloo: ok, I'll leave it for now21:43
*** jst_ has joined #openstack-ironic21:44
jrollholy cow, boot interface still has large patches out :(21:45
jrollso much for finishing any features :(21:46
*** jaypipes has quit IRC21:47
rloojroll: oh yeah. the actual driver changes. i never got around to reviewing those. wanted zapping/raid more.21:47
jrollyep, same21:47
jrollit's just ilo and irmc21:48
jroll"just"21:48
*** jst_ has quit IRC21:48
*** dims_ has joined #openstack-ironic21:49
*** karimb has quit IRC21:53
*** thrash is now known as thrash|g0ne21:55
*** Sukhdev has joined #openstack-ironic21:57
*** vishwanathj has quit IRC22:04
*** Sukhdev has quit IRC22:05
*** vishwanathj has joined #openstack-ironic22:05
*** vishwana_ has joined #openstack-ironic22:07
*** vishwanathj has quit IRC22:10
*** achanda has quit IRC22:11
openstackgerritMerged openstack/ironic: Imported Translations from Zanata  https://review.openstack.org/22424022:13
jlvillalSo how do I hurry things out of the 'wait' state?  I know I should already know this :(22:14
jlvillal$ ironic node-set-provision-state nuc1 manage22:14
jlvillalThe requested action "manage" can not be performed on node "cf15449c-7d09-4b6c-b2db-7e07795ebc98" while it is in state "wait call-back". (HTTP 400)22:14
mrdaironic node-set-maintenance-state nuc1 on; ironic node-delete nuc1 <-- Is that what you want jlvillal ?22:15
mrdaoh, and good morning :)22:15
jlvillalmrda: Thanks! :)  Good morning.22:15
jlvillalmrda: Trying to debug my failing ramdisk issue. Got some USB to serial adapters :)22:16
jlvillalmrda: Uh, will that delete my node?  I don't want to delete it. Just move it back to manage or something.22:16
jlvillalbasically hurry up what would happen after the time-out occurs22:17
*** dims_ has quit IRC22:17
*** sinval has quit IRC22:19
jlvillalmrda: Hmm. Didn't seem to work, though I was too scared to do the 'node-delete'22:19
*** sinval has joined #openstack-ironic22:19
openstackgerritMerged openstack/ironic: Remove DictMatches custom matcher from unit tests  https://review.openstack.org/22428722:20
*** dims_ has joined #openstack-ironic22:20
*** ijw has quit IRC22:25
*** [1]cdearborn has quit IRC22:26
*** achanda has joined #openstack-ironic22:26
jlvillalmrda: I think my hanging issue was related to console=ttyS0,....   I removed that and the kernel no longer hangs.22:30
jlvillalmrda: Now I see an error about -c not a valid option to tftp22:31
jlvillalAnd that I don't have a web server on port 8022:31
mrdahmmm22:31
jlvillalAs there is a curl command trying to run22:31
jlvillalmrda: Is there a way to turn on more verbose output of what the DIB image is doing?22:32
jlvillalOr better question, do you know a way to turn on more verbose output.22:32
* jlvillal wanders off to tripleo-image-elements web page...22:33
mrdajlvillal: I don't know of any22:44
jlvillalmrda: Thanks22:44
mrdajlvillal: ...because where we it store that? Unless you could configure a syslog as part of the deploy image22:46
mrdaand send it off over the network22:46
jlvillalmrda: Okay, I'm just hoping to make it print out the commands it is running on the console22:47
jlvillalstill playing around with it22:47
mrdaso you could mount the deploy image locally, independent of the actual deploy, and step through what it's doing...22:48
jlvillalmrda: Oh, I didn't think about that. Thanks.22:52
jlvillalmrda: I would suggest on  your blog to not have the console=ttyS0 lines22:52
jlvillalMaybe others might have hanging systems too.22:52
mrdata22:53
openstackgerritSinval Vieira Mendes Neto proposed openstack/python-oneviewclient: Sending OneView Client implementation  https://review.openstack.org/21279622:54
*** dims_ has quit IRC22:59
*** david-lyle has joined #openstack-ironic22:59
*** krtaylor has joined #openstack-ironic23:03
*** harshs has quit IRC23:03
*** lucasagomes has quit IRC23:16
*** trown|outttypeww is now known as trown23:25
*** baoli has joined #openstack-ironic23:25
openstackgerritRuby Loo proposed openstack/ironic: Refactor deploy_utils methods  https://review.openstack.org/22226423:34
*** penick has joined #openstack-ironic23:38
openstackgerritRuby Loo proposed openstack/ironic: Refactor deploy_utils methods  https://review.openstack.org/22226423:39
*** romcheg has quit IRC23:44
*** alexpilotti has joined #openstack-ironic23:49
openstackgerritSinval Vieira Mendes Neto proposed openstack/ironic: OneView Driver for Ironic  https://review.openstack.org/19182223:50
sinvalhey guys o/23:51
sinvalwhen you have time, please take a look at:https://review.openstack.org/19182223:51
sinvalthank you very much23:52
sinvalhttps://review.openstack.org/19182223:52
*** shoutm has joined #openstack-ironic23:56
*** baoli has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!