| JayF | I know, but part of that trust is knowing more eyes is better :P | 00:00 |
|---|---|---|
| * JayF lands it | 00:00 | |
| *** sdake has joined #openstack-ironic | 00:00 | |
| *** harshs has quit IRC | 00:01 | |
| *** naohirot has joined #openstack-ironic | 00:01 | |
| openstackgerrit | Merged openstack/ironic-specs: Ceph Object Gateway Temp URL support for Ironic https://review.openstack.org/228829 | 00:06 |
| *** garthb has quit IRC | 00:09 | |
| *** dims_ has quit IRC | 00:13 | |
| *** dims_ has joined #openstack-ironic | 00:14 | |
| *** tsekiyam_ has joined #openstack-ironic | 00:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements https://review.openstack.org/231229 | 00:17 |
| *** tsekiyama has quit IRC | 00:18 | |
| *** dims_ has quit IRC | 00:19 | |
| *** tsekiyam_ has quit IRC | 00:19 | |
| *** mtanino has quit IRC | 00:19 | |
| *** JoshNang has joined #openstack-ironic | 00:21 | |
| *** shadower has quit IRC | 00:23 | |
| *** shadower has joined #openstack-ironic | 00:23 | |
| *** dims_ has joined #openstack-ironic | 00:25 | |
| *** dims_ has quit IRC | 00:26 | |
| *** dims_ has joined #openstack-ironic | 00:26 | |
| *** smoriya has joined #openstack-ironic | 00:26 | |
| mrda | Just following up on https://review.openstack.org/#/c/213264/ - does anyone know if a Nova spec is being worked on for this? I can't see anything up | 00:29 |
| mrda | (ie. this is for Nova does not support baremetal vnic) | 00:29 |
| jroll | mrda: I'm meant to write a spec for that stuff, someone else working on networks things may do it if I don't get to it | 00:30 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic-python-agent: Update the launchpad link for IPA https://review.openstack.org/231637 | 00:31 |
| openstackgerrit | Merged openstack/ironic: Fix log formatting issue in agent base https://review.openstack.org/231140 | 00:32 |
| mrda | thanks jroll - just hate to see this languish in Nova M because we haven't followed what has been asked of us | 00:34 |
| jroll | mrda: tell me about it | 00:34 |
| mrda | i.e. this change needs a spec according to Nova, so if we don't get the spec written and approved in time, the code won't get reviewed and merged. And then we get Sad Panda :( | 00:35 |
| * jlvillal is getting tired at tracing through the logging code.... | 00:35 | |
| jroll | mrda: yep, I'm familiar with the process | 00:35 |
| jroll | mrda: though, not a spec, a blueprint | 00:35 |
| jroll | :) | 00:36 |
| mrda | jroll: But please don't see what I said as me saying "Work Harder". I'd do it if I knew anything about networks, and I had some time, I'd do it myself. | 00:36 |
| jroll | mrda: I'm totally reading it as that and super mad at you now | 00:36 |
| *** alexpilotti has joined #openstack-ironic | 00:36 | |
| mrda | jroll: lol | 00:36 |
| * jroll totally kidding if that isn't clear | 00:36 | |
| jroll | heh | 00:36 |
| mrda | jroll: WORK HARDER! | 00:37 |
| mrda | NO SLEEP FOR YOU, JROLL :) | 00:37 |
| jroll | mrda: I don't respond well to yelling. I'm going to walk away and find a beer now | 00:37 |
| jroll | :) | 00:37 |
| mrda | Good job. Have one for me too. | 00:37 |
| * jlvillal thinks jroll works pretty hard already... | 00:37 | |
| jroll | can do | 00:37 |
| jroll | have a good night | 00:37 |
| jlvillal | jroll: Ciao | 00:37 |
| mrda | Have a good one jroll, thanks for your help today | 00:38 |
| openstackgerrit | Merged openstack/ironic-python-agent: Fix log formatting error in iscsi.py https://review.openstack.org/231634 | 00:40 |
| *** alexpilotti has quit IRC | 00:40 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/231230 | 00:47 |
| openstackgerrit | Merged openstack/ironic-lib: Replace .iteritems() with .items() https://review.openstack.org/230597 | 00:48 |
| *** baoli has joined #openstack-ironic | 01:05 | |
| openstackgerrit | Merged openstack/ironic: Rename 'message' attribute to '_msg_fmt' in IronicException https://review.openstack.org/215362 | 01:08 |
| openstackgerrit | Merged openstack/ironic: Add .eggs to gitignore https://review.openstack.org/231414 | 01:08 |
| openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/231228 | 01:08 |
| *** praneshp has quit IRC | 01:14 | |
| *** harshs has joined #openstack-ironic | 01:17 | |
| *** alexpilotti has joined #openstack-ironic | 01:18 | |
| *** alexpilotti has quit IRC | 01:23 | |
| *** thrash is now known as thrash|g0ne | 01:36 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements https://review.openstack.org/231229 | 01:42 |
| *** achanda has joined #openstack-ironic | 01:52 | |
| *** sdake has quit IRC | 01:53 | |
| *** puranamr has joined #openstack-ironic | 01:53 | |
| *** sdake has joined #openstack-ironic | 01:56 | |
| rloo | jlvillal: that's a good question. I don't think using pdb with tox fits in quick start, but I'm not sure where else to put it. | 01:59 |
| *** alexpilotti has joined #openstack-ironic | 01:59 | |
| rloo | jlvillal: seems like we need another developer section that isn't 'quick start'. "Debugging"? | 02:01 |
| *** alexpilotti has quit IRC | 02:04 | |
| *** VikasC has quit IRC | 02:16 | |
| *** baoli has quit IRC | 02:18 | |
| *** sdake has quit IRC | 02:19 | |
| *** penick has quit IRC | 02:22 | |
| *** sdake_ has joined #openstack-ironic | 02:22 | |
| *** alexpilotti has joined #openstack-ironic | 02:41 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Refactor list_all_block_devices & add block_type param https://review.openstack.org/218404 | 02:42 |
| openstackgerrit | Merged openstack/ironic-python-agent: Update the launchpad link for IPA https://review.openstack.org/231637 | 02:42 |
| *** puranamr has quit IRC | 02:44 | |
| *** baoli has joined #openstack-ironic | 02:45 | |
| *** alexpilotti has quit IRC | 02:45 | |
| *** sdake_ is now known as sdake | 02:54 | |
| *** rloo has quit IRC | 02:54 | |
| *** baoli has quit IRC | 02:59 | |
| *** alexpilotti has joined #openstack-ironic | 03:00 | |
| *** baoli has joined #openstack-ironic | 03:01 | |
| *** alexpilotti has quit IRC | 03:04 | |
| *** amotoki has joined #openstack-ironic | 03:08 | |
| *** achanda has quit IRC | 03:09 | |
| *** garthb has joined #openstack-ironic | 03:10 | |
| *** garthb has quit IRC | 03:12 | |
| *** garthb_ has joined #openstack-ironic | 03:12 | |
| *** Marga_ has quit IRC | 03:18 | |
| *** Marga_ has joined #openstack-ironic | 03:19 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic-specs: Organize Liberty specs into implemented versions https://review.openstack.org/231695 | 03:20 |
| *** links has joined #openstack-ironic | 03:21 | |
| *** Marga_ has quit IRC | 03:23 | |
| *** saripurigopi has joined #openstack-ironic | 03:24 | |
| *** puranamr has joined #openstack-ironic | 03:26 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Use mount -t sysfs to avoid host /sys dependencies https://review.openstack.org/231658 | 03:29 |
| *** puranamr has quit IRC | 03:31 | |
| *** garthb_ has quit IRC | 03:32 | |
| *** garthb has joined #openstack-ironic | 03:32 | |
| *** saripurigopi has quit IRC | 03:33 | |
| *** baoli has quit IRC | 03:34 | |
| *** sdake has quit IRC | 03:37 | |
| *** saripurigopi has joined #openstack-ironic | 03:37 | |
| *** sdake has joined #openstack-ironic | 03:37 | |
| *** alexpilotti has joined #openstack-ironic | 03:41 | |
| *** rameshg87 has joined #openstack-ironic | 03:42 | |
| *** alexpilotti has quit IRC | 03:45 | |
| *** Sukhdev has joined #openstack-ironic | 03:56 | |
| *** Marga_ has joined #openstack-ironic | 03:58 | |
| *** Marga_ has quit IRC | 03:59 | |
| *** alexpilotti has joined #openstack-ironic | 03:59 | |
| *** Marga_ has joined #openstack-ironic | 03:59 | |
| *** Sukhdev has quit IRC | 04:00 | |
| *** Sukhdev has joined #openstack-ironic | 04:00 | |
| *** Marga_ has quit IRC | 04:01 | |
| *** Marga_ has joined #openstack-ironic | 04:02 | |
| *** VikasC has joined #openstack-ironic | 04:03 | |
| *** saripurigopi has quit IRC | 04:05 | |
| *** Marga_ has quit IRC | 04:06 | |
| *** Marga_ has joined #openstack-ironic | 04:06 | |
| *** saripurigopi has joined #openstack-ironic | 04:06 | |
| *** alexpilotti has quit IRC | 04:07 | |
| *** Nisha has joined #openstack-ironic | 04:09 | |
| *** saripurigopi has quit IRC | 04:12 | |
| *** hemna has joined #openstack-ironic | 04:12 | |
| *** ramineni has joined #openstack-ironic | 04:19 | |
| *** achanda has joined #openstack-ironic | 04:20 | |
| *** achanda has quit IRC | 04:20 | |
| *** alexpilotti has joined #openstack-ironic | 04:24 | |
| *** alexpilotti has quit IRC | 04:28 | |
| *** garthb has quit IRC | 04:29 | |
| *** Sukhdev has quit IRC | 04:40 | |
| *** praneshp has joined #openstack-ironic | 04:49 | |
| *** dims_ has quit IRC | 04:52 | |
| *** alexpilotti has joined #openstack-ironic | 05:05 | |
| *** praneshp_ has joined #openstack-ironic | 05:08 | |
| *** praneshp has quit IRC | 05:09 | |
| *** praneshp_ is now known as praneshp | 05:09 | |
| *** alexpilotti has quit IRC | 05:10 | |
| *** hemna has quit IRC | 05:18 | |
| *** achanda has joined #openstack-ironic | 05:19 | |
| *** hemna has joined #openstack-ironic | 05:24 | |
| *** e0ne has joined #openstack-ironic | 05:28 | |
| *** e0ne has quit IRC | 05:30 | |
| *** jamielennox is now known as jamielennox|away | 05:30 | |
| *** e0ne has joined #openstack-ironic | 05:34 | |
| *** e0ne has quit IRC | 05:37 | |
| *** e0ne has joined #openstack-ironic | 05:42 | |
| *** alexpilotti has joined #openstack-ironic | 05:47 | |
| *** e0ne has quit IRC | 05:49 | |
| *** alexpilotti has quit IRC | 05:51 | |
| *** e0ne has joined #openstack-ironic | 05:53 | |
| *** e0ne has quit IRC | 05:54 | |
| *** praneshp has quit IRC | 05:57 | |
| *** e0ne has joined #openstack-ironic | 05:58 | |
| *** praneshp has joined #openstack-ironic | 05:59 | |
| *** e0ne has quit IRC | 06:02 | |
| *** hemna has quit IRC | 06:06 | |
| *** achanda has quit IRC | 06:13 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic-lib: Config drive support for whole disk images for iscsi based deploy https://review.openstack.org/230924 | 06:16 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic: Add support for in-band cleaning in ISCSIDeploy https://review.openstack.org/220898 | 06:17 |
| *** achanda has joined #openstack-ironic | 06:19 | |
| *** ramineni has left #openstack-ironic | 06:19 | |
| *** e0ne has joined #openstack-ironic | 06:21 | |
| *** jamielennox|away is now known as jamielennox | 06:21 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: Add support for UEFI iSCSI boot https://review.openstack.org/207337 | 06:22 |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: Add support for UEFI iSCSI boot https://review.openstack.org/207337 | 06:25 |
| *** pas-ha has joined #openstack-ironic | 06:25 | |
| *** mtreinish has quit IRC | 06:26 | |
| openstackgerrit | Ramakrishnan G proposed openstack/ironic-specs: Add support for UEFI iSCSI boot https://review.openstack.org/207337 | 06:26 |
| *** e0ne has quit IRC | 06:26 | |
| *** vdrok_ has joined #openstack-ironic | 06:26 | |
| *** vdrok_ has joined #openstack-ironic | 06:27 | |
| *** alexpilotti has joined #openstack-ironic | 06:28 | |
| *** vdrok_ has quit IRC | 06:30 | |
| *** vdrok_ has joined #openstack-ironic | 06:30 | |
| *** vdrok_ has left #openstack-ironic | 06:30 | |
| *** mtreinish has joined #openstack-ironic | 06:31 | |
| *** e0ne has joined #openstack-ironic | 06:31 | |
| *** alexpilotti has quit IRC | 06:33 | |
| *** e0ne has quit IRC | 06:35 | |
| *** ukalifon has joined #openstack-ironic | 06:37 | |
| *** achanda has quit IRC | 06:39 | |
| *** e0ne has joined #openstack-ironic | 06:39 | |
| *** vdrok has joined #openstack-ironic | 06:41 | |
| *** achanda has joined #openstack-ironic | 06:42 | |
| *** jcoufal has joined #openstack-ironic | 06:43 | |
| *** vdrok has left #openstack-ironic | 06:44 | |
| *** vdrok has joined #openstack-ironic | 06:45 | |
| *** praneshp has quit IRC | 06:46 | |
| *** alexpilotti has joined #openstack-ironic | 06:47 | |
| *** jcoufal has quit IRC | 06:49 | |
| *** jcoufal has joined #openstack-ironic | 06:52 | |
| *** alexpilotti has quit IRC | 06:53 | |
| *** e0ne has quit IRC | 06:55 | |
| *** amotoki has quit IRC | 06:58 | |
| *** puranamr has joined #openstack-ironic | 06:58 | |
| *** romainh has joined #openstack-ironic | 07:01 | |
| *** romainh has left #openstack-ironic | 07:03 | |
| *** puranamr has quit IRC | 07:03 | |
| *** alexpilotti has joined #openstack-ironic | 07:08 | |
| *** alexpilotti has quit IRC | 07:12 | |
| *** vdrok has left #openstack-ironic | 07:13 | |
| *** harshs has quit IRC | 07:15 | |
| *** mkovacik has joined #openstack-ironic | 07:26 | |
| *** marzif has joined #openstack-ironic | 07:34 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add hardware inspection module for iRMC driver https://review.openstack.org/196480 | 07:34 |
| *** achanda has quit IRC | 07:39 | |
| *** ifarkas has joined #openstack-ironic | 07:39 | |
| *** dtantsur|afk is now known as dtantsur | 07:40 | |
| dtantsur | Morning Ironic | 07:42 |
| *** alexpilotti has joined #openstack-ironic | 07:45 | |
| *** tteggel has quit IRC | 07:48 | |
| openstackgerrit | afazekas proposed openstack/ironic-python-agent: Move oslotest to test-requirements https://review.openstack.org/231880 | 07:48 |
| *** alexpilotti has quit IRC | 07:50 | |
| *** tteggel has joined #openstack-ironic | 07:51 | |
| *** tteggel has left #openstack-ironic | 07:54 | |
| *** MattMan has quit IRC | 07:57 | |
| *** MattMan has joined #openstack-ironic | 07:57 | |
| mrda | hi dtantsur | 07:57 |
| dtantsur | o/ | 07:57 |
| *** marzif has quit IRC | 08:02 | |
| *** yog_ has joined #openstack-ironic | 08:03 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Refactor IRMCVirtualMediaIscsiDeploy by applying new BootInterface https://review.openstack.org/221371 | 08:07 |
| openstackgerrit | Matt Keenan proposed openstack/ironic-specs: Add Solaris IPMItool driver https://review.openstack.org/231536 | 08:09 |
| *** e0ne has joined #openstack-ironic | 08:10 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Refactor IRMCVirtualMediaAgentDeploy by applying new BootInterface https://review.openstack.org/221577 | 08:18 |
| *** mbound has joined #openstack-ironic | 08:18 | |
| *** romcheg has joined #openstack-ironic | 08:23 | |
| *** sdake has quit IRC | 08:23 | |
| *** sdake has joined #openstack-ironic | 08:26 | |
| *** lucas-dinner has joined #openstack-ironic | 08:27 | |
| *** alexpilotti has joined #openstack-ironic | 08:27 | |
| *** lucasagomes has joined #openstack-ironic | 08:27 | |
| *** e0ne has quit IRC | 08:30 | |
| *** pelix has joined #openstack-ironic | 08:31 | |
| *** alexpilotti has quit IRC | 08:31 | |
| openstackgerrit | Merged openstack/ironic-inspector: Add coverage target to tox.ini https://review.openstack.org/231495 | 08:31 |
| *** e0ne has joined #openstack-ironic | 08:32 | |
| *** itamarl has joined #openstack-ironic | 08:32 | |
| *** jistr has joined #openstack-ironic | 08:36 | |
| *** links has quit IRC | 08:38 | |
| *** achanda has joined #openstack-ironic | 08:39 | |
| *** mrmoje has joined #openstack-ironic | 08:42 | |
| *** degorenko_away is now known as degorenko | 08:43 | |
| *** athomas has joined #openstack-ironic | 08:44 | |
| *** vdrok has joined #openstack-ironic | 08:45 | |
| *** vdrok has quit IRC | 08:45 | |
| *** vdrok has joined #openstack-ironic | 08:46 | |
| *** achanda has quit IRC | 08:46 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: PXE: Support Extra DHCP Options for IPv6 https://review.openstack.org/231573 | 08:48 |
| *** vdrok has quit IRC | 08:48 | |
| *** fandi has quit IRC | 08:49 | |
| openstackgerrit | afazekas proposed openstack/ironic-python-agent: Babel is not a direct dependency https://review.openstack.org/231894 | 08:51 |
| Nisha | lucas-dinner, please relook at https://review.openstack.org/228020. I had addressed your comments last week | 08:51 |
| *** romcheg has quit IRC | 08:53 | |
| *** romcheg has joined #openstack-ironic | 08:56 | |
| *** alexpilotti has joined #openstack-ironic | 08:57 | |
| *** vdrok has joined #openstack-ironic | 08:58 | |
| *** itamarl has quit IRC | 09:00 | |
| *** alexpilotti has quit IRC | 09:01 | |
| *** romcheg has quit IRC | 09:01 | |
| *** itamarl has joined #openstack-ironic | 09:02 | |
| *** fandi has joined #openstack-ironic | 09:05 | |
| *** itamarl_ has joined #openstack-ironic | 09:06 | |
| *** itamarl has quit IRC | 09:07 | |
| *** itamarl_ is now known as itamarl | 09:07 | |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Fix irmc driver unit test https://review.openstack.org/231900 | 09:14 |
| *** subscope has joined #openstack-ironic | 09:15 | |
| *** yuikotakada has joined #openstack-ironic | 09:16 | |
| rameshg87 | lucasagomes: lucas-dinner: hello | 09:17 |
| yuikotakada | good morning, ironic :) | 09:17 |
| rameshg87 | which one are you ? :) | 09:17 |
| rameshg87 | yuikotakada: dtantsur: o/ | 09:18 |
| yuikotakada | rameshg87, dtantsur, lucasagomes, o/ | 09:18 |
| dtantsur | afternoon, rameshg87, yuikotakada :) | 09:18 |
| yuriyz | morning Ironic and all | 09:19 |
| dtantsur | morning yuriyz | 09:19 |
| vdrok | morning rameshg87 yuikotakada dtantsur yuriyz lucasagomes | 09:19 |
| rameshg87 | vdrok: o/ | 09:20 |
| dtantsur | vdrok, morning | 09:20 |
| yuikotakada | yuriyz, vdrok, morning :) | 09:20 |
| openstackgerrit | Merged openstack/ironic-python-agent: Adds more functional tests for commands https://review.openstack.org/224247 | 09:23 |
| *** lucas-dinner has quit IRC | 09:23 | |
| lucasagomes | rameshg87, hello! | 09:23 |
| lucasagomes | yuikotakada, vdrok dtantsur morning | 09:23 |
| rameshg87 | lucasagomes: hi | 09:24 |
| rameshg87 | lucasagomes: regarding https://review.openstack.org/#/c/191822/37/ironic/drivers/utils.py | 09:24 |
| lucasagomes | rameshg87, yeah | 09:25 |
| rameshg87 | lucasagomes: I thought ValueError made more sense because the input to that method is wrong | 09:25 |
| *** links has joined #openstack-ironic | 09:25 | |
| lucasagomes | rameshg87, it's fine, but usually they are adding a try..catch around that function and reraising it as IronicException | 09:25 |
| lucasagomes | that's why I suggested to just raise the invalidparametervalue | 09:25 |
| rameshg87 | lucasagomes: yeah, that's true because most often it came from node capabilties | 09:26 |
| lucasagomes | so we don't have to keep converting it | 09:26 |
| rameshg87 | lucasagomes: okay, but logicaly ValuerError made more sense. but anyway I buy your argument too :) | 09:26 |
| lucasagomes | rameshg87, right, yeah I'm fine with both. Just wanted to keep it simpler | 09:27 |
| rameshg87 | agreed :) | 09:28 |
| *** fandi has quit IRC | 09:29 | |
| *** fandi has joined #openstack-ironic | 09:31 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed openstack/ironic: Refactor disk partitioner code from ironic and use ironic-lib. https://review.openstack.org/184443 | 09:34 |
| *** alexpilotti has joined #openstack-ironic | 09:38 | |
| *** romcheg has joined #openstack-ironic | 09:38 | |
| *** romainh has joined #openstack-ironic | 09:40 | |
| sambetts | Morning all o/ | 09:41 |
| *** VikasC has quit IRC | 09:42 | |
| *** alexpilotti has quit IRC | 09:43 | |
| *** achanda has joined #openstack-ironic | 09:43 | |
| yuikotakada | sambetts, o/ | 09:43 |
| sambetts | How you doing yuikotakada? You flown home now or still in europe? | 09:44 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Config drive support for whole disk images for iscsi based deploy https://review.openstack.org/225115 | 09:44 |
| yuikotakada | sambetts, now in Dublin still :) feel very sorry for not working for community recentry :( | 09:45 |
| *** achanda has quit IRC | 09:46 | |
| *** achanda has joined #openstack-ironic | 09:47 | |
| *** VikasC has joined #openstack-ironic | 09:47 | |
| *** subscope has quit IRC | 09:49 | |
| sambetts | yuikotakada: Sorry its not as warm on this side of the planet, are you enjoying it though? Thats ok things aren't as hectic right now anyway | 09:50 |
| *** achanda has quit IRC | 09:52 | |
| yuikotakada | sambetts, hehe, I knew it, it's colder than I expected, but no problem at all, I'm enjoying very well! I will be able to back to the community in the next week | 09:53 |
| sambetts | :D | 09:53 |
| dtantsur | morning sambetts | 09:53 |
| sambetts | Hey dtantsur, Thanks for fixing that func test issue, sorry I had to run yesterday | 09:54 |
| dtantsur | heh, no problem | 09:54 |
| dtantsur | I still wonder why it got broken, but what we ended up with is definitely saner | 09:54 |
| *** naohirot has quit IRC | 09:57 | |
| *** e0ne has quit IRC | 10:06 | |
| *** romainh has left #openstack-ironic | 10:06 | |
| sambetts | dtantsur: Yeah, not sure :/ | 10:06 |
| *** e0ne has joined #openstack-ironic | 10:09 | |
| *** alexpilotti has joined #openstack-ironic | 10:16 | |
| *** alexpilotti has quit IRC | 10:21 | |
| openstackgerrit | Syed Ismail Faizan Barmawer proposed openstack/ironic: Refactor disk partitioner code from ironic and use ironic-lib. https://review.openstack.org/184443 | 10:24 |
| *** subscope has joined #openstack-ironic | 10:26 | |
| lucasagomes | sambetts, morning! | 10:33 |
| sambetts | o/ lucasagomes | 10:34 |
| *** Nisha has quit IRC | 10:36 | |
| openstackgerrit | Bob Ball proposed openstack/ironic: XenAPI: Add support for XenServer VMs https://review.openstack.org/231381 | 10:39 |
| rameshg87 | lucasagomes: are you planning to raise a patch to remove the dib ramdisk stuffs (pass_deploy_info,...) from ironic soon ? | 10:43 |
| lucasagomes | rameshg87, yes, but I think we need to keep it for this cycle | 10:43 |
| lucasagomes | cause the tripleo-ci wasn't updated in time for liberty to actually use IPA | 10:43 |
| lucasagomes | dprince is working on it right now | 10:44 |
| lucasagomes | rameshg87, or I would remove it later on the cycle at least, I think now it's too early :-( | 10:44 |
| rameshg87 | lucasagomes: do you mean keep that code in ironic for Mitaka as well ? | 10:44 |
| lucasagomes | rameshg87, I think we should, or remove it at the end of the cycle | 10:44 |
| lucasagomes | since the patches in triple-o took ages to get merged | 10:45 |
| lucasagomes | and the work to use IPA in the ci is not done yet | 10:45 |
| lucasagomes | rameshg87, wdyt? | 10:46 |
| *** fandi has quit IRC | 10:49 | |
| *** romainh has joined #openstack-ironic | 10:51 | |
| *** alexpilotti has joined #openstack-ironic | 10:53 | |
| *** alexpilotti has quit IRC | 10:57 | |
| rameshg87 | lucasagomes: sorry, I went away from my desk | 11:09 |
| rameshg87 | lucasagomes: but the code is out in liberty saying bash ramdisk is deprecated | 11:10 |
| rameshg87 | lucasagomes: I don't know we might have 2-3 releases between liberty and mitaka ? | 11:10 |
| rameshg87 | lucasagomes: but until then enabling cleaning in iscsi drivers has to be delayed - https://review.openstack.org/#/c/220898/ | 11:11 |
| rameshg87 | lucasagomes: I removed the CONF option to enable/disable cleaning for iscsi drivers (which was frowned saying we don't need CONF option if we chose to do it later) | 11:12 |
| rameshg87 | lucasagomes: but the *ssh drivers using dib ramdisk still won't go through unless they switch to ipa ramdisk | 11:12 |
| openstackgerrit | Bob Ball proposed openstack/ironic: XenAPI: Add support for XenServer VMs https://review.openstack.org/231381 | 11:13 |
| rameshg87 | lucasagomes: will catch up with you later on, need to go home now | 11:13 |
| * rameshg87 goes home | 11:13 | |
| *** rameshg87 has quit IRC | 11:13 | |
| *** alexpilotti has joined #openstack-ironic | 11:14 | |
| *** alexpilotti has quit IRC | 11:19 | |
| *** jamielennox is now known as jamielennox|away | 11:19 | |
| *** thrash|g0ne is now known as thrash | 11:23 | |
| *** alexpilotti has joined #openstack-ironic | 11:24 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Baremetal provisioning in UEFI secure boot mode for iLO drivers https://review.openstack.org/231927 | 11:27 |
| lucasagomes | right... yeah ok we need to sync that then | 11:27 |
| *** alexpilotti has quit IRC | 11:28 | |
| *** dtantsur is now known as dtantsur|brb | 11:30 | |
| *** ndipanov has joined #openstack-ironic | 11:31 | |
| *** lucasagomes is now known as lucas-hungry | 11:36 | |
| *** subscope has quit IRC | 11:37 | |
| *** baoli has joined #openstack-ironic | 11:38 | |
| *** romainh has left #openstack-ironic | 11:39 | |
| *** baoli_ has joined #openstack-ironic | 11:39 | |
| *** baoli has quit IRC | 11:43 | |
| openstackgerrit | Merged openstack/ironic: Allow empty password for ipmitool console https://review.openstack.org/229904 | 11:44 |
| *** jcoufal has quit IRC | 11:45 | |
| openstackgerrit | Merged openstack/ironic: Use standard locale when executing 'parted' command https://review.openstack.org/231367 | 11:45 |
| openstackgerrit | Merged openstack/ironic: To run a specific unit test with ostestr use -r https://review.openstack.org/231156 | 11:46 |
| *** sambetts has quit IRC | 11:52 | |
| *** sambetts has joined #openstack-ironic | 11:53 | |
| *** jcoufal has joined #openstack-ironic | 11:57 | |
| *** subscope has joined #openstack-ironic | 12:05 | |
| *** Marga_ has quit IRC | 12:05 | |
| *** alexpilotti has joined #openstack-ironic | 12:05 | |
| *** Marga_ has joined #openstack-ironic | 12:05 | |
| *** david-ly_ has joined #openstack-ironic | 12:07 | |
| *** david-lyle has quit IRC | 12:09 | |
| *** david-ly_ is now known as david-lyle | 12:09 | |
| *** alexpilotti has quit IRC | 12:09 | |
| openstackgerrit | Yuiko Takada proposed openstack/ironic-inspector: Support IPA for devstack-plugin https://review.openstack.org/223563 | 12:14 |
| thiagop | Good morning Ironicers | 12:19 |
| *** alexpilotti has joined #openstack-ironic | 12:24 | |
| sambetts | morning thiagop | 12:26 |
| *** alexpilotti has quit IRC | 12:28 | |
| *** puranamr has joined #openstack-ironic | 12:30 | |
| *** yuikotakada has quit IRC | 12:31 | |
| *** liliars has joined #openstack-ironic | 12:33 | |
| vdrok | morning sambetts thiagop | 12:33 |
| *** puranamr has quit IRC | 12:35 | |
| *** kozhukalov_ has quit IRC | 12:36 | |
| *** lucas-hungry is now known as lucasagomes | 12:40 | |
| *** aswadr has joined #openstack-ironic | 12:41 | |
| *** smoriya has quit IRC | 12:41 | |
| *** dims_ has joined #openstack-ironic | 12:44 | |
| *** Marga_ has quit IRC | 12:46 | |
| *** Marga_ has joined #openstack-ironic | 12:47 | |
| *** VikasC has quit IRC | 12:50 | |
| thiagop | sambetts vdrok o/ | 12:51 |
| *** rloo has joined #openstack-ironic | 12:53 | |
| jroll | morning everyone :) | 13:00 |
| thiagop | morning jroll | 13:01 |
| jroll | ohai thiagop \o | 13:01 |
| *** yuikotakada has joined #openstack-ironic | 13:02 | |
| *** links has quit IRC | 13:02 | |
| *** alexpilotti has joined #openstack-ironic | 13:03 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Refactor deploy_utils methods https://review.openstack.org/222264 | 13:04 |
| vdrok | morning jroll | 13:05 |
| *** alexpilotti has quit IRC | 13:05 | |
| jroll | heya vdrok \o | 13:05 |
| *** alexpilotti has joined #openstack-ironic | 13:05 | |
| *** yuikotakada has quit IRC | 13:07 | |
| lucasagomes | jroll, thiagop morning! | 13:08 |
| *** alexpilotti has quit IRC | 13:10 | |
| thiagop | lucasagomes: o/ | 13:11 |
| *** david-lyle has quit IRC | 13:16 | |
| TheJulia | /win 4 | 13:23 |
| TheJulia | doh | 13:23 |
| *** lazy_prince has joined #openstack-ironic | 13:24 | |
| lazy_prince | umm.. does fake_agent driver use pxe boot..? | 13:27 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal power state commands https://review.openstack.org/172517 | 13:27 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add maintenance mode command https://review.openstack.org/216727 | 13:27 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal port create https://review.openstack.org/172461 | 13:27 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add provision state command https://review.openstack.org/206119 | 13:27 |
| jroll | lazy_prince: I would assume so? | 13:29 |
| lazy_prince | Well.. looks like i did a nova boot and the tftp details are not getting attached to the port created in neutron.. so just checking.. | 13:30 |
| lazy_prince | However, I if i use pxe_ipmitool, it is getting done.. | 13:31 |
| lazy_prince | Sorry, if my was question was not clear.. | 13:32 |
| rloo | morning lazy_prince, jroll, TheJulia, TheJulia, vdrok, lucasagomes and the other wonderful ironicers | 13:32 |
| lucasagomes | rloo, morning! | 13:32 |
| *** david-lyle has joined #openstack-ironic | 13:32 | |
| jroll | lazy_prince: I mean, I could be wrong :) | 13:32 |
| vdrok | morning rloo :) | 13:32 |
| mkovacik | hello guys, does anyone use virtual box machine as an ironic node? I have issues setting this up :-/ | 13:32 |
| thiagop | morning rloo | 13:32 |
| lucasagomes | lazy_prince, in the ports objects for that node, check the extra field see if there's any VIF there | 13:33 |
| lucasagomes | mkovacik, ramesh87 does (tho he's not online right now :-( ) | 13:33 |
| mkovacik | lucasagomes, thanks, will try to reach out | 13:34 |
| *** Nisha has joined #openstack-ironic | 13:34 | |
| lucasagomes | mkovacik, seems we have http://docs.openstack.org/developer/ironic/drivers/vbox.html and also pxe_ssh drivers that supports vbox | 13:34 |
| lucasagomes | may worth trying both | 13:35 |
| mkovacik | lucasagomes, precisely what I'm following | 13:35 |
| lazy_prince | okay.. so I get the problem now... Thanks lucasagomes | 13:35 |
| *** trown|outttypeww is now known as trown | 13:35 | |
| lucasagomes | cool np! | 13:36 |
| thiagop | Guys, I need an opinion regarding docstrings for exceptions | 13:36 |
| thiagop | should we put :raises: for an exception that is not being thrown by the method itself? | 13:36 |
| mkovacik | lucasagomes, the thing is, when I do reboot/power on through ironic, I can see the virtual box machine booting (bios, no drive yet) but I can't make nova instantiate cirros on it :-/ | 13:36 |
| jroll | FYI all, gate might get flaky today | 13:37 |
| jroll | 13:27:34 sdague | 2015-10-07 11:27:08.533 | Get:36 http://us.archive.ubuntu.com trusty/multiverse amd64 Packages [169 kB] | 13:37 |
| jroll | 13:27:34 sdague | 2015-10-07 11:27:08.630 | Fetched 17.4 MB in 17min 32s (16.5 kB/s) | 13:37 |
| jroll | thiagop: personally I'd catch everything and re-raise as some subclass of IronicException | 13:37 |
| lucasagomes | mkovacik, hmm but did you deploy the cirros image through nova using the Ironic driver right? | 13:38 |
| lucasagomes | is the instance marked as ACTIVE in nova? | 13:38 |
| lucasagomes | jroll, :-( | 13:38 |
| lucasagomes | thiagop, if one of the methods that function invokes can raise that exception and it's not handled by the method you're currently working | 13:38 |
| lucasagomes | it would be good to indicate that the method can raise that exception as well | 13:39 |
| thiagop | lucasagomes: as ":raises:" or literally inside the docstring as yuriyz asked? | 13:39 |
| lucasagomes | jroll, we don't have any cache for those images in the gate? | 13:39 |
| mkovacik | lucasagomes, yeah, it is active (as far as I can tell, noob here) http://www.fpaste.org/275880/14442251/ (there are 2 ironic KVMs and one virtual box machine in the list) | 13:39 |
| lucasagomes | thiagop, I would say as :raises: | 13:40 |
| jroll | lucasagomes: it's slow mirrors, so any package devstack installs | 13:40 |
| * lucasagomes tho I didn't see yuriyz comment | 13:40 | |
| yuriyz | thiagop +1 for lucasagomes | 13:40 |
| *** Marga_ has quit IRC | 13:41 | |
| lucasagomes | mkovacik, right, what "nova list" shows? | 13:41 |
| mkovacik | lucasagomes, I think there might be some --flavor switch I should use while doing nova boot as bare metal doesn't seem to work :-/ | 13:41 |
| thiagop | lucasagomes yuriyz jroll so, as :raises: then. Agreed? | 13:41 |
| mkovacik | lucasagomes, atm nothing as I've killed the instance, the error was: no hosts | 13:42 |
| * mkovacik boots again | 13:42 | |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal power state commands https://review.openstack.org/172517 | 13:42 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add maintenance mode command https://review.openstack.org/216727 | 13:42 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal port create https://review.openstack.org/172461 | 13:42 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add provision state command https://review.openstack.org/206119 | 13:42 |
| lucasagomes | mkovacik, right, yeah... worth looking at n-sched to see what's the error why "no host found" was raised | 13:42 |
| jroll | thiagop: yeah, that's fine, I still think I would catch and re-raise as "OneViewException" or something | 13:43 |
| lucasagomes | but that can be a could of thing, look at the nodes/properties for cpus, memory_mb, local_gb and arch | 13:43 |
| lucasagomes | and compare it with the flavor see if it all match | 13:43 |
| mkovacik | lucasagomes, mind pointing me to the log file? (I'm running devstack) | 13:43 |
| jroll | thiagop: that way the docstring will always be accurate at least :) | 13:43 |
| rloo | thiagop: what I was told: 1. drivers need to handle and only let ironic exceptions be raised | 13:43 |
| lucasagomes | mkovacik, right, do a ./rejoin_stack.sh | 13:44 |
| *** kkoski has joined #openstack-ironic | 13:44 | |
| lucasagomes | check the "n-sch" tab | 13:44 |
| jroll | rloo++ | 13:44 |
| lucasagomes | rloo, ++ correct | 13:44 |
| rloo | thiagop: no need to add docstrings for internal (ie _*) methods. Otherwise docstrings should have :raises: for all exceptions that might come from that (or any called methods) | 13:44 |
| mkovacik | lucasagomes, thanks, will look into that | 13:44 |
| lucasagomes | a exception that inherits from IronicException | 13:44 |
| rloo | thiagop: guess it would be worth documenting somewhere | 13:44 |
| lucasagomes | mkovacik, cool! | 13:45 |
| mkovacik | lucasagomes, btw here's the error nova show gives as the instance state: http://www.fpaste.org/275883/42255001/ | 13:45 |
| *** links has joined #openstack-ironic | 13:46 | |
| lucasagomes | mkovacik, right so seems n-cpu raised some exception | 13:47 |
| lucasagomes | yeah you will have to check the nova services and see what's going on | 13:47 |
| *** alexpilotti has joined #openstack-ironic | 13:47 | |
| lucasagomes | c-cond, n-cpu and n-sch | 13:47 |
| lucasagomes | "code": 500, it's an internal error | 13:47 |
| *** Marga_ has joined #openstack-ironic | 13:48 | |
| mkovacik | lucasagomes, alright, me will checks | 13:48 |
| lucasagomes | cool | 13:49 |
| lucasagomes | rloo, ++ it may worth checking pep8, pep257 (and maybe hacking in openstack ? ) for guidelines | 13:50 |
| lucasagomes | hacking == the project | 13:50 |
| lucasagomes | http://docs.openstack.org/developer/hacking/#docstrings | 13:50 |
| rloo | lucasagomes: that's too much work. | 13:50 |
| rloo | lucasagomes: i just looked at that link, it doesn't go into detail about exceptions | 13:51 |
| *** alexpilotti has quit IRC | 13:51 | |
| lucasagomes | right, yeah, it's odd we don't have a code convention guildeline actually | 13:52 |
| rloo | lucasagomes: when I started on ironic i thought i would try to document things as I found out, but I forgot about doing that. | 13:52 |
| lucasagomes | I think we may just follow sphinx | 13:52 |
| lucasagomes | rloo, ++ yeah that would be good | 13:53 |
| rloo | thiagop, jroll, lucasagomes and anyone else, i added the exceptions stuff to https://wiki.openstack.org/wiki/Ironic/Developer_guidelines#Exceptions | 13:53 |
| lucasagomes | o/ | 13:53 |
| lucasagomes | "although rloo does like them" lol | 13:54 |
| thiagop | rloo: thanks! | 13:54 |
| lucasagomes | so personal | 13:54 |
| thiagop | That's good stuff actually, never saw that page | 13:54 |
| rloo | lucasagomes: I do but I was told that it wasn't necessary so I can't impose that :) | 13:54 |
| lucasagomes | heh fair enuff | 13:54 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Begin adding dev docs for writing methods https://review.openstack.org/232011 | 13:54 |
| jroll | rloo: heh, I just did the same, kind of ^ | 13:55 |
| rloo | lucasagomes: so many times i look at code that i hadn't looked at for awhile and it takes me some time to figure out what the parameters are etc. | 13:55 |
| jroll | I'd like to try to put docs like this in the tree going forward | 13:55 |
| rloo | jroll: that's great. we can delete from the wiki then. | 13:55 |
| thiagop | rloo: that docs could link to this too: http://docs.openstack.org/developer/oslo.i18n/guidelines.html | 13:55 |
| rloo | jroll: the reason i don't like intree is cuz on the wiki, i got it done w/o any approval in minutes. | 13:55 |
| lucasagomes | hmmm | 13:56 |
| rloo | jroll: in tree... seems like too much of an obstacle. but I am fine if we go that way. I was just being lazy. | 13:56 |
| jroll | rloo: yeah, I agree, but I think in-tree dev docs are going to be better quality, and we can make them more discoverable | 13:56 |
| jroll | rloo: I eventually want to have a page on docs.o.o that is "here is everything you need to know to contribute to ironic" | 13:56 |
| rloo | jroll: i would disagree about the 'quality' part but intree means it is vetted and will stay put easier :) | 13:57 |
| jroll | rloo: for example, I don't remember ever seeing this wiki page :) | 13:57 |
| lucasagomes | right, that's a hard path tho... there's plenty of code style guidelines around there | 13:57 |
| lucasagomes | I think we are better off just adopting one ? | 13:57 |
| lucasagomes | instead of writing our own | 13:57 |
| jroll | I mean, we should link to those with wild abandon | 13:58 |
| jroll | I don't want to document pep8 here | 13:58 |
| jroll | but things like "only raise IronicExceptions" or "to land a feature you need a blueprint" etc | 13:58 |
| lucasagomes | right | 13:58 |
| rloo | jroll: so basically, we should take everything (or most of it) from https://wiki.openstack.org/wiki/Ironic/Developer_guidelines and put intree. | 14:00 |
| jroll | rloo: yeah, plus probably more | 14:00 |
| rloo | jroll: yeah, definitely more. | 14:00 |
| jroll | this is the "devref" I keep talking about | 14:00 |
| rloo | jroll: oh. got it. we should just copy nova's structure if it makes sense. | 14:01 |
| jroll | rloo: yeah, something like that | 14:01 |
| rloo | jroll: 'structure' -> headings so we know what issues to document :) | 14:01 |
| lazy_prince | lucasagomes: jroll: I am assuming that ironic virt driver adds the vif to the ironic port.. | 14:01 |
| lazy_prince | is that right assumption..? | 14:01 |
| lucasagomes | lazy_prince, nova does | 14:01 |
| jroll | rloo: yeah, fair enough | 14:02 |
| jroll | lazy_prince: yeah, plug_vifs | 14:02 |
| lazy_prince | okay.. so I was trying to use the neutron as dhcp provider and network provider.. with the patches listed on the etherpad https://etherpad.openstack.org/p/ironic-neutron-mid-cycle | 14:03 |
| *** Nisha has quit IRC | 14:03 | |
| lazy_prince | And I was using fake agent driver... | 14:03 |
| *** Nisha has joined #openstack-ironic | 14:03 | |
| lazy_prince | so there are four patches listed on the etherpad... | 14:03 |
| *** alexpilotti has joined #openstack-ironic | 14:04 | |
| lazy_prince | under nova.. which ones of them are needed and which ones are not.. | 14:04 |
| * lucasagomes is not sure... | 14:04 | |
| lazy_prince | My understanding is that nova should not add the vif to the ironic port | 14:05 |
| * lazy_prince could be wrong | 14:05 | |
| lazy_prince | or it should be there and ironic should move it to provisioning port that it creates... | 14:07 |
| jroll | lazy_prince: ohhhhh. that should be fun. hm. | 14:07 |
| jroll | I never thought about pxe booting picking up vif ids from there :/ | 14:07 |
| *** alexpilotti has quit IRC | 14:08 | |
| lazy_prince | I mean Ironic should update the port with vif port uuid of provisioning network | 14:08 |
| lazy_prince | I mean update_dhcp_opts in ironic/dhcp/neutron.py | 14:09 |
| jroll | right, yeah | 14:10 |
| NobodyCam | good morning Ironicers | 14:10 |
| jlvillal | Good morning Ironic :) | 14:11 |
| TheJulia | good morning | 14:11 |
| thiagop | Good morning NobodyCam jlvillal TheJulia | 14:11 |
| * jlvillal is still trying to wake up... | 14:11 | |
| lazy_prince | well.. looks like time for another patch.. | 14:11 |
| * thiagop wonders if home office is really good | 14:12 | |
| NobodyCam | good mornign jroll lucasagomes dtantsur|brb rloo lazy_prince jlvillal sambetts thiagop TheJulia and anyone not listed here :) | 14:12 |
| * jroll thinks about lazy_prince's problem some more | 14:12 | |
| jroll | hi NobodyCam :) | 14:12 |
| lucasagomes | lazy_prince, yeah, I think the things in that etherpad is an on-going work... not sure how complete it is | 14:12 |
| lucasagomes | problbably it's missing some pieces of the puzzle | 14:12 |
| lucasagomes | NobodyCam, jlvillal TheJulia morning | 14:13 |
| jroll | lucasagomes: lazy_prince is doing most of the work on that pad :P | 14:13 |
| lucasagomes | a-ha... ok that makes sense them :-) | 14:13 |
| NobodyCam | :) | 14:13 |
| lucasagomes | ok if I can just opinate a little on that, I would love we to not use "extra" as a field for things like VIF | 14:13 |
| jlvillal | thiagop, I still have to go to work :) | 14:13 |
| lucasagomes | then* | 14:14 |
| *** Marga_ has quit IRC | 14:16 | |
| *** Marga_ has joined #openstack-ironic | 14:16 | |
| NobodyCam | :) | 14:17 |
| *** harshs has joined #openstack-ironic | 14:18 | |
| rloo | morning NobodyCam, jlvillal | 14:19 |
| krtaylor | Good morning UGT everyone | 14:19 |
| jlvillal | :) | 14:19 |
| trown | dtantsur|brb: sambetts, any ideas how we would hit this trace? http://logs.openstack.org/90/223690/28/check/gate-puppet-ironic-puppet-beaker-rspec-upgrade-dsvm-centos7/6ee5847/console.html#_2015-10-06_13_36_09_727 | 14:20 |
| thiagop | morning kragniz | 14:21 |
| thiagop | morning too you too krtaylor | 14:22 |
| NobodyCam | morning | 14:22 |
| *** tsekiyama has joined #openstack-ironic | 14:25 | |
| openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Use requests lib in HTTPClient https://review.openstack.org/229286 | 14:29 |
| openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Use requests lib in HTTPClient https://review.openstack.org/229286 | 14:31 |
| *** Nisha has quit IRC | 14:33 | |
| *** Nisha has joined #openstack-ironic | 14:33 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add retries to ssh._get_hosts_name_for_node https://review.openstack.org/224828 | 14:36 |
| openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Use requests lib in HTTPClient https://review.openstack.org/229286 | 14:42 |
| *** amotoki has joined #openstack-ironic | 14:42 | |
| *** mtanino has joined #openstack-ironic | 14:43 | |
| * sambetts looks for trown | 14:44 | |
| *** alexpilotti has joined #openstack-ironic | 14:45 | |
| jlvillal | sambetts, I saw him over there ->>>> | 14:46 |
| jlvillal | :P | 14:46 |
| sambetts | :-P | 14:46 |
| *** lintan_ has joined #openstack-ironic | 14:48 | |
| *** alexpilotti has quit IRC | 14:49 | |
| *** lintan__ has quit IRC | 14:49 | |
| *** HenryG has quit IRC | 14:49 | |
| *** shadower has quit IRC | 14:49 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Add retries to ssh._get_hosts_name_for_node https://review.openstack.org/224828 | 14:50 |
| sambetts | trown: Do you know what version of alembic is installed on that machine? | 14:50 |
| *** dansmith has quit IRC | 14:50 | |
| *** dansmith has joined #openstack-ironic | 14:51 | |
| *** harshs has quit IRC | 14:51 | |
| trown | sambetts: looks like python-alembic-0.7.4-2.el7.noarch | 14:51 |
| rloo | vdrok: I didn't want to make (annoy) you do another revision of 224828 so I updated the commit myself. hope you don't mind. | 14:52 |
| trown | sambetts: this is coming from here btw: https://review.openstack.org/#/c/223690/ | 14:52 |
| *** HenryG has joined #openstack-ironic | 14:52 | |
| sambetts | trown: According to our reqs file we require alembic >=0.8.0 | 14:53 |
| trown | sambetts: the odd thing is, the '...dsvm-centos7' test passes, it is only the '...upgrade-dsvm-centos7' which has that issue, which makes no sense to me | 14:53 |
| *** BobBall has joined #openstack-ironic | 14:54 | |
| *** itamarl has quit IRC | 14:54 | |
| trown | since the "upgrade" test installs master of the module and runs the test, then installs the change and runs the test again, but there was not inspector support previously, so they should really be the same test | 14:54 |
| trown | sambetts: you rock! | 14:55 |
| sambetts | trown: that trace comes from the fact alembic is out of date, the edit command was only added in 0.8 :) | 14:55 |
| vdrok | rloo, of course, thanks :) | 14:55 |
| trown | it is the alembic version...somehow that upgrade test has a lower version | 14:55 |
| trown | stupid puppet | 14:56 |
| *** marios has quit IRC | 14:56 | |
| sambetts | trown: yeah, I would expected it to be inline with global reqs | 14:57 |
| *** marios has joined #openstack-ironic | 14:57 | |
| trown | sambetts: ya, those two tests are supposed to use the same repos, but something is wonky, that gives me something to pester puppet folks about | 14:58 |
| trown | thanks a ton | 14:58 |
| sambetts | :D | 14:58 |
| *** alexpilotti has joined #openstack-ironic | 15:01 | |
| rloo | vdrok: yw :) | 15:04 |
| *** pas-ha has quit IRC | 15:06 | |
| *** Nisha has quit IRC | 15:08 | |
| jlvillal | lucasagomes, I started work on choices for IntOpt https://review.openstack.org/219047 | 15:09 |
| *** alexpilotti has quit IRC | 15:09 | |
| * jlvillal has another patch he has to get back to working on.... | 15:10 | |
| *** dtantsur|brb is now known as dtantsur | 15:10 | |
| lucasagomes | jlvillal, ++ w00t | 15:10 |
| * jlvillal wonders if 8 patches in his queue is too many.... | 15:10 | |
| lucasagomes | jlvillal, btw if you have some time https://review.openstack.org/#/c/231399/ | 15:10 |
| * dtantsur is back, hello everyone | 15:10 | |
| jlvillal | lucasagomes, Cool :) | 15:10 |
| lucasagomes | didn't get any review yet, I wonder if that's something people care | 15:10 |
| lucasagomes | that actually facilitate the transition from stropt without choices to stropt with choices | 15:11 |
| lucasagomes | dtantsur, wb | 15:11 |
| *** sdake has quit IRC | 15:11 | |
| dtantsur | folks, ironic-lib version bump does not pass the gate, and I have no idea why: https://review.openstack.org/#/c/231368/ | 15:11 |
| jlvillal | lucasagomes, Actually I think ignore_case could be used with regex. re.I ??? | 15:12 |
| jlvillal | Might be useful | 15:12 |
| lucasagomes | right, yeah I left it mutally exclusive cause idk how confusing that would be tho | 15:12 |
| *** mrmoje has quit IRC | 15:13 | |
| *** sdake has joined #openstack-ironic | 15:14 | |
| *** jistr is now known as jistr|mtg | 15:14 | |
| lucasagomes | dtantsur, the failure seems unrelated to the patch... other jobs are also failing with the same error | 15:15 |
| lucasagomes | https://review.openstack.org/#/c/231118/ | 15:15 |
| lucasagomes | other patches* | 15:15 |
| dtantsur | oh, I see | 15:15 |
| *** tsekiyama has quit IRC | 15:16 | |
| *** jistr|mtg is now known as jistr | 15:17 | |
| jlvillal | lucasagomes, dhellmann is a good person to beg for reviews on your ignore_case patch :) https://review.openstack.org/#/c/231399/ | 15:18 |
| *** subscope has quit IRC | 15:18 | |
| lucasagomes | ++ | 15:18 |
| lucasagomes | yeah I just put it there to see ideas, no rush on that | 15:18 |
| jlvillal | lucasagomes, I did review with my suggestion. | 15:18 |
| lucasagomes | jlvillal, thanks | 15:19 |
| lucasagomes | jlvillal, yeah that seems fair enough, I just need to add a flag to that compile() | 15:20 |
| lucasagomes | I will do that | 15:20 |
| NobodyCam | wb dtantsur | 15:21 |
| dtantsur | mkovacik, I've created a bug to add "no valid host found" problem to the ironic docs (aka move from tripleo ones): https://bugs.launchpad.net/ironic/+bug/1503735 | 15:25 |
| openstack | Launchpad bug 1503735 in Ironic "Write troubleshooting docs for "no valid host found" nova error when used with ironic" [Low,Triaged] | 15:25 |
| dhellmann | jlvillal, lucasagomes : reviewed ;-) | 15:26 |
| dtantsur | mkovacik, might be a good chance to get started with the project | 15:26 |
| lucasagomes | thanks much! | 15:26 |
| * lucasagomes updates the patch | 15:26 | |
| mkovacik | dtantsur, right --- I shall :) | 15:27 |
| *** subscope has joined #openstack-ironic | 15:28 | |
| *** alexpilotti has joined #openstack-ironic | 15:29 | |
| *** alexpilotti has quit IRC | 15:30 | |
| *** alexpilotti has joined #openstack-ironic | 15:30 | |
| *** rameshg87 has joined #openstack-ironic | 15:33 | |
| *** dims_ has quit IRC | 15:34 | |
| thiagop | rameshg87: Thanks for the reviews | 15:38 |
| thiagop | rameshg87: I'm answering it now | 15:38 |
| rameshg87 | thiagop: welcome | 15:38 |
| *** harshs has joined #openstack-ironic | 15:38 | |
| rameshg87 | thiagop: one question in your vendor.py I had, please let me know if there's something to discuss | 15:39 |
| rameshg87 | thiagop: I feel we can move what you want to the parent class so that you dont' need to reimplement the method reboot_to_instance() | 15:39 |
| rameshg87 | *if my assumptions are correct | 15:39 |
| rameshg87 | jroll: lucasagomes: continuing discussion on review and irc, so both of you feel we should wait for enabling cleaning for iscsi drivers ? - https://review.openstack.org/#/c/220898/ | 15:41 |
| *** david-lyle has quit IRC | 15:41 | |
| thiagop | rameshg87: me and jroll discussed that earlier. Once that is done, we shall remove that interface from the driver. But I couldn't yet check if the code you pointed out resolves our problem | 15:41 |
| openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Use requests lib in HTTPClient https://review.openstack.org/229286 | 15:42 |
| thiagop | rameshg87: that's my next step once resolving the "easy stuff" | 15:42 |
| *** david-lyle has joined #openstack-ironic | 15:42 | |
| *** links has quit IRC | 15:42 | |
| rameshg87 | thiagop: it doesn't resolve that problem | 15:42 |
| lucasagomes | rameshg87, the bash ramdisk is preventing it from landing? | 15:43 |
| lucasagomes | cause bash doesn't support cleaning and we have no way to differentiate it ? | 15:43 |
| rameshg87 | thiagop: I just thought we can move the set boot device call between power off and power on in the pointed out code if it solves your problem | 15:43 |
| rameshg87 | lucasagomes: yeah | 15:43 |
| rameshg87 | lucasagomes: or I will have to check if there is some other way | 15:43 |
| lucasagomes | hmmm | 15:44 |
| rameshg87 | lucasagomes: as you said, find out whether agent ramdisk is used | 15:44 |
| * lucasagomes thinks | 15:44 | |
| thiagop | rameshg87: sure. What I don't know is if in that specific point of the code solves for me (maybe ignorance). Need to test... | 15:44 |
| *** dims_ has joined #openstack-ironic | 15:44 | |
| thiagop | rameshg87: I would need to send it in another patch since it extends beyond the scope of the driver, right? | 15:45 |
| *** praneshp has joined #openstack-ironic | 15:45 | |
| rameshg87 | thiagop: yeah another patch and then this patch (I know this will get delayed if that happens and please don't kill me :)) | 15:45 |
| rameshg87 | thiagop: but maintaining an extended method that does almost does same thing is hard to maintain | 15:46 |
| rameshg87 | thiagop: I myself have that experience in the past 1 year extending so many methods for ilo driver :) | 15:46 |
| thiagop | rameshg87: but I think the need to do this was pointed out more than once | 15:46 |
| rameshg87 | thiagop: okay | 15:46 |
| thiagop | rameshg87: by more than one driver | 15:46 |
| *** harshs has quit IRC | 15:48 | |
| *** Marga_ has quit IRC | 15:48 | |
| lucasagomes | rameshg87, yeah it's hard... thinking here, cause if we remove that methods right now we will break others (tripleo) | 15:48 |
| *** nicodemos has joined #openstack-ironic | 15:54 | |
| *** david-ly_ has joined #openstack-ironic | 15:55 | |
| *** david-lyle has quit IRC | 15:55 | |
| rameshg87 | lucasagomes: yeah, bash ramdisk doesn't even POST an error message back on error | 15:56 |
| *** david-ly_ has quit IRC | 15:56 | |
| rameshg87 | lucasagomes: instead we could have hacked something on it if bash ramdisk was invoked on cleaning | 15:56 |
| *** david-lyle has joined #openstack-ironic | 15:56 | |
| *** ionutbalutoiu has joined #openstack-ironic | 15:58 | |
| *** dims__ has joined #openstack-ironic | 15:59 | |
| *** subscope has quit IRC | 15:59 | |
| rloo | jroll: btw, wrt specs. if i recall, when approved, we used to put them in <cycle>/, and if they weren't implemented, we'd move them out of <cycle>/ and they'd go in <cycle+1>. So those placeholders for kilo & juno reflect implemented specs, but liberty includes implemented & not-implemented specs. | 16:00 |
| rloo | jroll: I think we should just hide the placeholder stuff. as long as the old links work, i don't think we need to actually show those links. | 16:00 |
| *** lazy_prince has quit IRC | 16:00 | |
| rloo | jroll: I'm referring to http://specs.openstack.org/openstack/ironic-specs/#placeholders :) | 16:01 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add documentation for Ceph Object Gateway support https://review.openstack.org/232068 | 16:01 |
| *** mrmoje has joined #openstack-ironic | 16:02 | |
| *** dims_ has quit IRC | 16:03 | |
| lucasagomes | rameshg87, I think it does post an error message for deploy and bootloader installation | 16:04 |
| rameshg87 | lucasagomes: yeah, it doesn't | 16:04 |
| rameshg87 | lucasagomes: just drops down to a shell | 16:04 |
| *** tsekiyama has joined #openstack-ironic | 16:04 | |
| lucasagomes | rameshg87, but anyway... hmmm, what happen if we try to call clean using a bash ramdisk? | 16:05 |
| rameshg87 | lucasagomes: clean timeout | 16:05 |
| lucasagomes | maybe we can identify it by the heartbeat? Cause bash won't call it | 16:05 |
| rameshg87 | lucasagomes: yeah, but we can by heartbeat | 16:05 |
| *** jistr has quit IRC | 16:05 | |
| jroll | rloo: +1 for removing placeholders. I think it's only there because docs generation blows up if a file isn't in a toctree | 16:05 |
| rameshg87 | lucasagomes: but how about first time cleaning when manage->available | 16:05 |
| rameshg87 | heartbeat won't be there then | 16:06 |
| rloo | jroll: I figured out how to hide the docs but to get sphinx to generate them. | 16:06 |
| jroll | rloo: \o/ | 16:06 |
| lucasagomes | rameshg87, right... in any case. Let's assume the bash ramdisk is gone and we add cleaning for iscsi | 16:06 |
| rloo | jroll: i'll push up a patch for that later today i think. | 16:06 |
| lucasagomes | is it enabled by default or not? | 16:06 |
| jroll | rameshg87: I'd love to talk about this but I'm in a meeting right now and this takes more brain that I can generate :( | 16:06 |
| lucasagomes | if it's not enabled by default, I think we are grand | 16:06 |
| lucasagomes | cause that will keep the old behavior and we can add an alert in the documentation, BASH RAMDISK IS DEPRECATED AND DOESNT SUPPORT CLEANING | 16:07 |
| lucasagomes | or something like that | 16:07 |
| *** yog_ has quit IRC | 16:07 | |
| jroll | lucasagomes: that's the issue, cleaning is on by default, and we shouldn't have a separate config for that driver just to make it off by default | 16:09 |
| *** ifarkas has quit IRC | 16:09 | |
| lucasagomes | jroll, right, but if enable it by default we are changing people's workflow right? | 16:09 |
| jlvillal | lucasagomes, I think almost there on ignore_case patch. Looking really good. Thanks for it. | 16:10 |
| lucasagomes | "before I moved from manageable to available very quick, now it can take ours" | 16:10 |
| lucasagomes | jlvillal, cheers! | 16:10 |
| jroll | lucasagomes: I guess, but we did that before because we think it's important and the sane default for production | 16:10 |
| lucasagomes | jroll, indeed | 16:11 |
| lucasagomes | the main problem is time here, cause this change is blocking the cleaning for iscsi | 16:12 |
| rameshg87 | right. | 16:12 |
| lucasagomes | perhaps we need just to talk to the TripleO folks about our plans to remove it this cycle | 16:12 |
| rameshg87 | it's trivial enough to enable it and attain parity between drivers, but we aren't able to | 16:12 |
| lucasagomes | see if when would be a good time, M1, M2, ... and do it there | 16:12 |
| rameshg87 | and I guess since we aren't able to find a good way to detect if it's a bash ramdisk or agent ramdisk, we are in some need to introduce another CONF for a very short span of time | 16:13 |
| jroll | lucasagomes: right, that's the hard part. the initial proposal was introducing a config that was immediately deprecated which seems... bad | 16:13 |
| *** Marga_ has joined #openstack-ironic | 16:14 | |
| rameshg87 | lucasagomes: jroll: other solution I can think of is to give bash ramdisk enough to heartbeat | 16:16 |
| lucasagomes | jroll, yeah that's bad indeed | 16:16 |
| rameshg87 | lucasagomes: jroll: enough dummy values for it to heartbeat back and if it's in CLEANWAT | 16:16 |
| rameshg87 | bash ramdisk doesn't heartbeat. sorry. enough to do a POST. | 16:17 |
| lucasagomes | rameshg87, hmm I don't get it? | 16:17 |
| lucasagomes | maybe we should just wait for the TripleO-CI | 16:18 |
| rameshg87 | lucasagomes: if we fill in dummy values for iscsi_target_iqn, deployment_id, deployment_key, etc while starting a node for cleaning | 16:18 |
| rameshg87 | lucasagomes: if it was bash ramdisk, it would do a POST on pass_deploy_info by which we would be able to see if it's a bash ramdisk or not | 16:18 |
| rameshg87 | lucasagomes: if it was agent ramdisk, it just wouldn't care and would work normally | 16:19 |
| *** dims__ is now known as dims | 16:19 | |
| rameshg87 | I think that should work | 16:19 |
| rameshg87 | but some workaround .. | 16:19 |
| *** amotoki has quit IRC | 16:20 | |
| rameshg87 | lucasagomes: jroll: I would like to pursue something if we plan not to do in Mitaka, because enabling cleaning for iscsi* drivers in N seems too long to me :( | 16:21 |
| lucasagomes | rameshg87, it may, but urgh... we would need to change pass_dpeloy_info to ignore it cause it's not a deploy | 16:21 |
| jroll | rameshg87: I agree, I just can't talk about this right at the moment | 16:22 |
| jroll | this sounds like a mailing list thread | 16:22 |
| rameshg87 | jroll: sure, may be some other time. no problem. | 16:22 |
| lucasagomes | yeah a ML thread seems good | 16:22 |
| jroll | especially because multiple projects, multiple time zones | 16:22 |
| lucasagomes | for Ironic and TripleO | 16:22 |
| jroll | yep +1 | 16:22 |
| * lucasagomes wonder if we can add some glance metadata for the deploy kernel | 16:23 | |
| lucasagomes | so we can say "hey it's the bash thing!" | 16:23 |
| rameshg87 | lucasagomes: shall I or do you want to shoot ? | 16:23 |
| rameshg87 | lucasagomes: it's too late, we are asking people to stop using bash ramdisk :) | 16:23 |
| jroll | lucasagomes: we probably shouldn't rely on that for existing deployments, but maybe "if this metadata is here, it's an agent" would work | 16:23 |
| lucasagomes | rameshg87, if you can send it, I will reply | 16:23 |
| rameshg87 | lucasagomes: sure, will do. | 16:23 |
| lucasagomes | jroll, yeah something like that | 16:24 |
| jroll | lucasagomes: and remove that when we remove the bash thing. or something. | 16:24 |
| lucasagomes | it's hard... cause when I was porting the pxe_ drivers to use ipa I wanted it to be a drop-in replacement | 16:24 |
| lucasagomes | but yeah, that's the bad part of it | 16:24 |
| jroll | yeah, we need something to say "I'm okay with the iscsi driver trusting the clean_nodes config" | 16:25 |
| lucasagomes | jroll, I also wonder if that would be enough to use say in the ML or/and release notes | 16:25 |
| lucasagomes | if you are using the bash ramdisk, please set "clean_nodes" to False in the configuration file before updating | 16:26 |
| lucasagomes | to just say* | 16:26 |
| *** mbound has quit IRC | 16:26 | |
| lucasagomes | like a big ass WARNING message there | 16:26 |
| *** romcheg has quit IRC | 16:32 | |
| openstackgerrit | Merged openstack/bifrost: Correct typo in install role README https://review.openstack.org/230742 | 16:38 |
| openstackgerrit | Merged openstack/bifrost: Use parameterized include for repeated git tasks https://review.openstack.org/230598 | 16:39 |
| openstackgerrit | Merged openstack/bifrost: Fix fail if network_interface contains '-' https://review.openstack.org/230779 | 16:39 |
| *** Nisha has joined #openstack-ironic | 16:40 | |
| *** trown is now known as trown|lunch | 16:40 | |
| *** alexpilotti has quit IRC | 16:43 | |
| *** harshs has joined #openstack-ironic | 16:43 | |
| *** alexpilotti has joined #openstack-ironic | 16:43 | |
| jlvillal | lucasagomes, Gave +1, but had an idea for additional test case if you feel motivated :) | 16:47 |
| lucasagomes | jlvillal, will take a look! Thanks | 16:48 |
| *** alexpilotti has quit IRC | 16:49 | |
| *** alexpilotti has joined #openstack-ironic | 16:50 | |
| * rameshg87 is done for the day | 16:50 | |
| rameshg87 | lucasagomes: tomorrow first thing will shoot the mail | 16:51 |
| rameshg87 | see you all folks tomorrow | 16:51 |
| lucasagomes | rameshg87, cool, thanks you! | 16:51 |
| lucasagomes | have a great night | 16:51 |
| thiagop | good night rameshg87 | 16:51 |
| *** rameshg87 has quit IRC | 16:51 | |
| lucasagomes | jlvillal, yeah I will add the test for it, it should preserve all flags | 16:51 |
| *** achanda has joined #openstack-ironic | 16:51 | |
| jlvillal | lucasagomes, Thank you | 16:53 |
| *** yuikotakada has joined #openstack-ironic | 16:54 | |
| *** Marga_ has quit IRC | 16:55 | |
| *** dprince has joined #openstack-ironic | 16:56 | |
| *** alexpilotti has quit IRC | 16:56 | |
| *** ukalifon has quit IRC | 16:58 | |
| *** mkovacik has quit IRC | 16:58 | |
| *** Sukhdev has joined #openstack-ironic | 16:58 | |
| *** penick has joined #openstack-ironic | 17:02 | |
| *** lazy_prince has joined #openstack-ironic | 17:05 | |
| *** krtaylor has quit IRC | 17:09 | |
| *** praneshp has quit IRC | 17:09 | |
| lucasagomes | jlvillal, np! Thank YOU for reviewing it | 17:11 |
| *** achanda has quit IRC | 17:11 | |
| *** tsekiyama has quit IRC | 17:13 | |
| *** achanda has joined #openstack-ironic | 17:13 | |
| jlvillal | lucasagomes: :) | 17:16 |
| *** dtantsur is now known as dtantsur|afk | 17:17 | |
| devananda | morning, all | 17:21 |
| lucasagomes | devananda, morning | 17:22 |
| lucasagomes | I'm calling a day already :-( | 17:22 |
| lucasagomes | have a great night everyone, see y'all | 17:23 |
| jlvillal | lucasagomes: Good night | 17:23 |
| thiagop | morning devananda, night lucasagomes | 17:23 |
| jlvillal | devananda: Good morning | 17:23 |
| *** gabriel is now known as gabriel-bezerra | 17:23 | |
| lucasagomes | see ya | 17:23 |
| *** krtaylor has joined #openstack-ironic | 17:23 | |
| *** lucasagomes is now known as lucas-dinner | 17:23 | |
| *** ijw has joined #openstack-ironic | 17:24 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic-specs: Manual cleaning https://review.openstack.org/231288 | 17:25 |
| *** Nisha has quit IRC | 17:26 | |
| *** Nisha has joined #openstack-ironic | 17:26 | |
| *** achanda has quit IRC | 17:28 | |
| *** harshs has quit IRC | 17:28 | |
| *** jcoufal has quit IRC | 17:28 | |
| *** romcheg has joined #openstack-ironic | 17:29 | |
| *** jcoufal has joined #openstack-ironic | 17:29 | |
| *** x3k has joined #openstack-ironic | 17:30 | |
| *** trown|lunch is now known as trown | 17:30 | |
| *** e0ne has quit IRC | 17:30 | |
| *** Marga_ has joined #openstack-ironic | 17:33 | |
| *** harshs has joined #openstack-ironic | 17:33 | |
| *** x3k has quit IRC | 17:35 | |
| *** mrmoje has quit IRC | 17:35 | |
| *** pelix has quit IRC | 17:38 | |
| *** vishwanathj has joined #openstack-ironic | 17:43 | |
| *** thrash is now known as thrash|biab | 17:47 | |
| *** sdake has quit IRC | 17:51 | |
| *** dims has quit IRC | 17:52 | |
| *** dims has joined #openstack-ironic | 17:53 | |
| *** sdake has joined #openstack-ironic | 17:57 | |
| *** achanda has joined #openstack-ironic | 18:00 | |
| *** dims_ has joined #openstack-ironic | 18:00 | |
| *** e0ne has joined #openstack-ironic | 18:03 | |
| *** lazy_prince has quit IRC | 18:03 | |
| * NobodyCam has to run to the dentist ... bbiab | 18:03 | |
| *** dims has quit IRC | 18:04 | |
| *** gmmaha has quit IRC | 18:06 | |
| *** gmmaha has joined #openstack-ironic | 18:06 | |
| *** xek has quit IRC | 18:07 | |
| openstackgerrit | Merged openstack/bifrost: Remove outdated bifrost-setup-nodes role https://review.openstack.org/231130 | 18:08 |
| *** xek has joined #openstack-ironic | 18:08 | |
| *** dims_ has quit IRC | 18:08 | |
| *** dprince has quit IRC | 18:08 | |
| *** tsekiyama has joined #openstack-ironic | 18:11 | |
| *** e0ne has quit IRC | 18:12 | |
| *** thrash|biab is now known as thrash | 18:13 | |
| thiagop | jroll: | 18:16 |
| thiagop | jroll: ping | 18:16 |
| *** e0ne has joined #openstack-ironic | 18:18 | |
| jroll | hi thiagop | 18:18 |
| openstackgerrit | Ruby Loo proposed openstack/ironic-specs: Remove placeholders from being displayed https://review.openstack.org/232136 | 18:18 |
| thiagop | jroll: do you remember a few weeks ago when we discussed about moving the set boot device somewhere between power on/off in the vendor interface for agent? | 18:19 |
| thiagop | jroll: (today it is done while the server is yet on) | 18:19 |
| *** jcoufal has quit IRC | 18:20 | |
| *** gabriel-bezerra is now known as gabriel | 18:21 | |
| jroll | thiagop: vaguely remember, yes | 18:21 |
| thiagop | jroll: I'll send a patch to do that. Do you think it should be filed as a bug or requires a whole spec? | 18:21 |
| jroll | thiagop: I don't remember why we need to do this, so I'm not sure | 18:22 |
| jroll | thiagop: it almost certainly doesn't require a spec, but if we consider it a feature a blueprint would be good for tracking | 18:23 |
| thiagop | jroll: in the OneView driver, we need to power the server off to change the boot priority. You said that some other drivers behaves the same way. | 18:23 |
| rloo | jroll, thiagop: I think that's a bug, not a feature. (2 cents worth) | 18:24 |
| jroll | thiagop: sorry, I'm terribly distracted with other things right now. do what you think is best and reviewers can decide if they agree | 18:24 |
| jroll | rloo: yeah, I tend to think so too | 18:24 |
| thiagop | jroll: Today we re-implement the reboot_to_instance method to do that, but Ramesh said that could be interesting changing it for every agent driver and maintain it as a common code | 18:24 |
| jroll | yeah just file a bug for now | 18:25 |
| thiagop | jroll np. Will file a bug. thks. | 18:25 |
| thiagop | rloo: agreed ;) | 18:25 |
| *** alexpilotti has joined #openstack-ironic | 18:28 | |
| *** harshs has quit IRC | 18:30 | |
| *** achanda has quit IRC | 18:30 | |
| *** alexpilotti has quit IRC | 18:32 | |
| *** dprince has joined #openstack-ironic | 18:34 | |
| *** dims has joined #openstack-ironic | 18:40 | |
| *** tsekiyam_ has joined #openstack-ironic | 18:43 | |
| *** tsekiyam_ has quit IRC | 18:43 | |
| *** tsekiyama has quit IRC | 18:46 | |
| *** mtanino has quit IRC | 18:46 | |
| *** tsekiyama has joined #openstack-ironic | 18:48 | |
| *** achanda has joined #openstack-ironic | 18:51 | |
| *** Sukhdev has quit IRC | 18:52 | |
| *** Sukhdev has joined #openstack-ironic | 18:52 | |
| *** Marga_ has quit IRC | 18:54 | |
| *** Marga_ has joined #openstack-ironic | 18:57 | |
| *** Sukhdev has quit IRC | 18:57 | |
| devananda | jroll: there did not seem to be a resolution to the "is breaking my atmtool driver a bug or am I abusing the API" discussion | 19:01 |
| *** Marga_ has quit IRC | 19:02 | |
| *** achanda has quit IRC | 19:02 | |
| jroll | devananda: I have a reply in mind but have been pulled in a million directions this morning | 19:03 |
| devananda | jroll: *nod* only pinging about it cause you were holding up the release for it, IIRC | 19:03 |
| jroll | tl;dr do we think the fix could break out of tree drivers? if so, which do we think will break more drivers | 19:03 |
| jroll | if we think it could, not fixing may be better because the downstream fix is super easy | 19:04 |
| *** puranamr has joined #openstack-ironic | 19:04 | |
| devananda | yea. I don't know because I haven't seen any out of tree drivers that do the other thing, so IDK all the ways they might be affected | 19:05 |
| devananda | it looks like ramesh has a solution that might work for both? he commented on the review. tldr; change the in-tree drivers that expect driver.boot to be a no-op so they actually define it as such | 19:07 |
| devananda | and then use the code I proposed so that, if a driver doesn't define driver.boot, it's assumed to behave like it did in kilo | 19:07 |
| devananda | ie, PXEBoot | 19:07 |
| jroll | ah, so e.g. add a FakeBoot driver to ilo? | 19:08 |
| devananda | yup | 19:08 |
| jroll | I think I like that, with a whole 15 seconds of thought :) | 19:08 |
| devananda | hehe | 19:08 |
| *** puranamr has quit IRC | 19:09 | |
| jroll | devananda: actually, that doesn't fix the case where there's an out-of-tree driver like ilo | 19:09 |
| jroll | but that should be rare/zero if they're depending on kilo behavior | 19:09 |
| *** dims has quit IRC | 19:10 | |
| devananda | if an out of tree power+mgmt driver is depending on kilo's AgentDeploy, it's going to need something to handle boot now -- that's my driver's case | 19:10 |
| jroll | right | 19:11 |
| devananda | oh, sorry. you mean an out of tree Deploy driver | 19:11 |
| devananda | ? | 19:11 |
| jroll | I'm saying for example, if this ilo driver was out of tree, it would break | 19:11 |
| *** dims has joined #openstack-ironic | 19:13 | |
| * devananda checks out stable/kilo and reads hte code | 19:13 | |
| devananda | jroll: yah. drivers/modules/ilo/deploy.py: IloPXEDeploy would totally break -- it inherits from a PXEDeploy class that *no longer exists* | 19:14 |
| jroll | lol | 19:14 |
| jroll | so there's another break :P | 19:15 |
| devananda | well | 19:15 |
| jroll | but that isn't really an interface | 19:15 |
| devananda | i'm beginning to think ramesh's point about these classes not being part of the API is 1) correct 2) something we may want to think more about | 19:15 |
| jroll | orright | 19:15 |
| jroll | right* | 19:15 |
| *** tsekiyama has quit IRC | 19:17 | |
| *** tsekiyama has joined #openstack-ironic | 19:17 | |
| *** Nisha has quit IRC | 19:19 | |
| JayF | rloo: re: manual cleaning, I was thinking if we're adding manual cleaning to "manage" verb to go from MANAGABLE -> CLEAN (manual) -> MANAGEABLE, why wouldn't you just add new options to provide to go MANAGABLE->CLEAN(manual)->AVAILABLE | 19:19 |
| *** Nisha has joined #openstack-ironic | 19:19 | |
| JayF | rloo: I am OK with the argument that if automatic cleaning is enabled, it's mandatory to go through it to get to available (I've made that argument) but just trying to clarify what I was thinking of | 19:19 |
| rloo | JayF: did I make a mistake? the verb for manual cleaning is 'clean'. | 19:19 |
| openstackgerrit | Dan Prince proposed openstack/ironic: Use power manager to reboot in agent deployments https://review.openstack.org/232157 | 19:19 |
| rloo | JayF: but yeah, CLEANING -> MANAGEABLE is via 'clean' | 19:20 |
| JayF | rloo: oh nope, you're right | 19:20 |
| JayF | rloo: I misread it and munged those two lines | 19:20 |
| rloo | JayF: did you want to do manual clean instead of auto clean? | 19:20 |
| JayF | I mean, I'm just thinking of options is all | 19:21 |
| JayF | I know zapping was originally scratching the itch of those who had "oneoff" needs | 19:21 |
| rloo | JayF: well, good to think. cuz i think that existing automated clean isn't that flexible. | 19:21 |
| JayF | and if manual cleaning has to happen THEN automated cleaning | 19:21 |
| JayF | you reduce the utility of manual cleaning significantly | 19:21 |
| rloo | JayF: 1. can't skip it, it is all the time, or never; 2. can't have any nodes opt out | 19:21 |
| JayF | rloo: if that's the opinion we want Ironic to have (I'm OK with it) then I'm OK with the way it's written and not allowing to target AVAILABLE | 19:22 |
| rloo | JayF: i also never understood why you'd want to do manual clean followed by autoclean. and if you did, then why wouldn't manual clean steps be separate from auto clean steps unless you wanted to run the same step twice in a row. | 19:22 |
| JayF | rloo: I just am curious if one of the original people who promoted zapping would be happy with that | 19:22 |
| rloo | JayF: I based it on Josh's zap. I have no idea where he got his ideas from. I was thinking it was from you/RS | 19:23 |
| JayF | TBH, I don't anticipate us using manual cleaning at all | 19:23 |
| rloo | JayF: I have no idea who promoted zapping. I don't even know who came up with 'zap'. | 19:23 |
| JayF | we're in the cookie cutter business | 19:23 |
| *** nicodemos has quit IRC | 19:24 | |
| *** Marga_ has joined #openstack-ironic | 19:25 | |
| *** vishwana_ has joined #openstack-ironic | 19:25 | |
| *** ijw_ has joined #openstack-ironic | 19:25 | |
| *** e0ne has quit IRC | 19:25 | |
| rloo | JayF: so I think that manual cleaning has to be able to end up at manageable because ops may want to do something else before it is avail and you don't want avail then back to manageable cuz once it is avail there is the possibility of nova scheduling it. | 19:27 |
| JayF | yeah, I'm OK with that | 19:27 |
| rloo | JayF: whether or not to allow manual clean -> avail (instead of manageable) is another question | 19:27 |
| *** vishwanathj has quit IRC | 19:27 | |
| *** ijw has quit IRC | 19:27 | |
| rloo | JayF: but we need to know what it means: i would think it would mean auto cleaning is skipped. | 19:27 |
| *** Nisha has quit IRC | 19:28 | |
| JayF | rloo: yeah, that's generally what I was proposing | 19:28 |
| *** dims has quit IRC | 19:28 | |
| JayF | rloo: and not "proposing" so much as saying "we should at least talk about this" | 19:28 |
| rloo | JayF: but I also think that might be a separate spec/feature. I don't think what the manual clean spec proposes, precludes adding that additional functionality later. | 19:28 |
| JayF | rloo: I would not personally use that functionality. | 19:28 |
| JayF | ++ I think that's the best solution | 19:28 |
| *** dims has joined #openstack-ironic | 19:28 | |
| rloo | JayF: my thinking is that the whole cleaning stuff will evolve as we have more folks using it/giving feedback. | 19:29 |
| JayF | rloo: ++ | 19:29 |
| JayF | rloo: in that case; I'd just add somethign in the spec about how clean_nodes= behaves | 19:29 |
| *** Marga_ has quit IRC | 19:29 | |
| JayF | rloo: then you have my +2 | 19:29 |
| rloo | JayF: i already added something about changing clean_nodes config. | 19:30 |
| JayF | oh, perfect, I'll go check it again then | 19:30 |
| JayF | I was thrilled to see how nice that spec was | 19:30 |
| rloo | JayF: although I didn't use your suggestion. i think i used automated_clean_enable or something like that. | 19:30 |
| rloo | JayF: do you prefer 'automated clean' or 'automatic clean'? | 19:30 |
| JayF | yeah my suggestion was crappy | 19:30 |
| JayF | I don't have a preference | 19:30 |
| rloo | JayF: glad I was able to 'thrill' you :D | 19:30 |
| *** ionutbalutoiu has quit IRC | 19:30 | |
| dprince | JayF: hi, any other thoughts on the sysfs patch https://review.openstack.org/#/c/231658/ | 19:30 |
| JayF | dprince: hey, I was going to chat w/you about that, although today is not an awesome day to do so | 19:31 |
| rloo | JayF: oh, I don't think your suggestion was crappy! | 19:31 |
| JayF | dprince: basically I'm curious if the DIB element should setup all the mounts and such rather than IPA doing it | 19:31 |
| JayF | dprince: because IPA *can't* do it in the default CoreOS image, because it's containerized | 19:31 |
| JayF | dprince: and that's a bucketload of "if" statements :/ | 19:32 |
| dprince | JayF: I don't think I'm changing any behaviour regarding CoreOS | 19:32 |
| rloo | JayF: in case you miss it, i made one other change. One API to get the clean steps (for auto or manual), instead of two separate ones. | 19:32 |
| dprince | JayF: but FWIW I think this breaks all Centos ramdisks deployments that do local boot config, not just ones using serial consoles | 19:32 |
| dprince | JayF: so this is a show stopper for me, we can't proceed w/ IPA in TripleO until this is sorted I think | 19:32 |
| *** sdake has quit IRC | 19:33 | |
| JayF | dprince: yea, I did bump it last night so tempest would run | 19:34 |
| dprince | JayF: if those bind mounts work in coreos, then I'd expect this to as well... unless I'm misunderstanding something | 19:34 |
| JayF | dprince: TBH when I looked at this code, I suspected it might not work | 19:34 |
| JayF | dprince: and the tempest job tests a whole disk not a partial disk image | 19:34 |
| dprince | JayF: yeah, well CI seems happy | 19:34 |
| JayF | dprince: because CI doesn't test this code at all | 19:34 |
| jroll | yes it does | 19:35 |
| *** sdake has joined #openstack-ironic | 19:35 | |
| jroll | JayF: pxe-ipa job tests this | 19:35 |
| JayF | oooooh | 19:35 |
| jroll | partition image + iscsi stuff | 19:35 |
| JayF | well if CI passes then I'll +2 it, because it'll mean definitively that I'm wrong | 19:35 |
| jroll | and even with coreos ramdisk | 19:35 |
| JayF | jroll: but not local partition images | 19:35 |
| JayF | jroll: which is what this code interacts with | 19:35 |
| JayF | jroll: unless the iscsi deploy driver does the grub install locally via the agent | 19:36 |
| jroll | what does 'local' mean here | 19:36 |
| jroll | yeah | 19:36 |
| dprince | JayF: also, per my last comment this makes IPA behave more like the traditional deployement ramdisk in DIB (when I looked it up it also used sysfs) | 19:36 |
| jroll | I believe so | 19:36 |
| jroll | I'm not 100% sure though | 19:36 |
| dprince | jroll: local means it installs a grub boot loader for "local" booting | 19:36 |
| jroll | ahhh. | 19:36 |
| jroll | yeah I think JayF is right than. | 19:36 |
| jroll | then. | 19:36 |
| dprince | jroll: we call that local boot | 19:36 |
| *** gmmaha has quit IRC | 19:37 | |
| jroll | right | 19:37 |
| jroll | I think this is a sign for me to walk away for a while :) | 19:37 |
| dprince | anyways, I would like to use IPA but it has a couple issues for us | 19:38 |
| *** sdake_ has joined #openstack-ironic | 19:38 | |
| jroll | yes, I would like that too, and fully support fixing these things | 19:38 |
| jroll | we need moar CI :( | 19:39 |
| *** sdake has quit IRC | 19:39 | |
| dprince | JayF: so you are concerned this breaks a coreos deployment ramdisk? | 19:40 |
| *** ionutbalutoiu has joined #openstack-ironic | 19:40 | |
| JayF | dprince: yes, although tbh, I'm concerned it's already broken b/c of the bind mounts | 19:40 |
| *** tsekiyama has quit IRC | 19:40 | |
| dprince | JayF: You've got to create things for the chroot somehow right? | 19:41 |
| dprince | JayF: doing that in IPA seems fine to me (it is what the traditional deployment ramdisk did too) | 19:42 |
| dprince | JayF: the gist of this patch is creating <chroot>/sys w/ mount -t sysfs is cleaner than bind mounting sys on the host. | 19:43 |
| dprince | FWIW we could do something simlar with /dev (mknod) but that isn't causing issues, and is probalby overkill | 19:43 |
| *** e0ne has joined #openstack-ironic | 19:43 | |
| JayF | dprince: for IPA, we inject all the mounts via the ramdisk | 19:44 |
| *** yuikotakada has quit IRC | 19:44 | |
| JayF | s/IPA/CoreOS/ | 19:44 |
| JayF | https://github.com/openstack/ironic-python-agent/blob/master/imagebuild/coreos/oem/cloud-config.yml#L59 | 19:44 |
| JayF | that's why I'm wondering how in the hell that would work from within the container | 19:44 |
| JayF | wait | 19:44 |
| JayF | it's bind mounting in /sys from the container into "new" /sys on the newly minted fs | 19:45 |
| JayF | that makes me think if mount -t sysfs works from inside systemd-nspawn, your patch should be good | 19:45 |
| *** sambetts has quit IRC | 19:45 | |
| dprince | JayF: I agree | 19:46 |
| *** ionutbalutoiu has quit IRC | 19:46 | |
| JayF | dprince: I don't have 5m to spare, but I'll spare it anyway and see if I can get you a quick answer | 19:46 |
| *** purp has quit IRC | 19:47 | |
| *** dhellmann has quit IRC | 19:47 | |
| *** dhellmann has joined #openstack-ironic | 19:47 | |
| dprince | JayF: it can wait till tomorrow FWIW, no rush other than I'm anxious to use IPA :) | 19:47 |
| *** purp_too has joined #openstack-ironic | 19:47 | |
| dprince | JayF: but thanks for your time/review | 19:47 |
| *** ionutbalutoiu has joined #openstack-ironic | 19:48 | |
| JayF | dprince: https://gist.github.com/jayofdoom/98cbe8c658b28e974c03 | 19:48 |
| *** sambetts has joined #openstack-ironic | 19:48 | |
| JayF | dprince: does that look like a valid test to you? | 19:48 |
| dprince | JayF: I think so. I see a /sys | 19:50 |
| JayF | dprince: hooray for science \o/ | 19:50 |
| *** Sukhdev has joined #openstack-ironic | 19:51 | |
| JayF | dprince: +3'd | 19:51 |
| dprince | JayF: \o/ | 19:52 |
| *** gmmaha has joined #openstack-ironic | 19:53 | |
| *** tsekiyama has joined #openstack-ironic | 19:54 | |
| *** penick has quit IRC | 19:59 | |
| *** penick has joined #openstack-ironic | 19:59 | |
| *** penick has quit IRC | 19:59 | |
| *** Sukhdev_ has joined #openstack-ironic | 20:01 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: Power off the machine before set_boot_device https://review.openstack.org/232186 | 20:04 |
| *** e0ne has quit IRC | 20:05 | |
| *** trown is now known as trown|outttypeww | 20:08 | |
| *** tsekiyama has quit IRC | 20:09 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: OneView Driver for Ironic https://review.openstack.org/191822 | 20:10 |
| *** tsekiyama has joined #openstack-ironic | 20:12 | |
| *** BobBall has quit IRC | 20:20 | |
| *** BobBall has joined #openstack-ironic | 20:22 | |
| *** BobBall is now known as Guest4559 | 20:22 | |
| *** Marga_ has joined #openstack-ironic | 20:26 | |
| mrda | Morning Ironic | 20:29 |
| thiagop | morning mrda | 20:31 |
| *** Marga_ has quit IRC | 20:31 | |
| mrda | o/ | 20:31 |
| *** achanda has joined #openstack-ironic | 20:34 | |
| *** achanda has quit IRC | 20:34 | |
| *** dprince has quit IRC | 20:36 | |
| *** achanda has joined #openstack-ironic | 20:41 | |
| *** tsekiyama has quit IRC | 20:43 | |
| *** sdake_ has quit IRC | 20:43 | |
| *** tsekiyama has joined #openstack-ironic | 20:45 | |
| *** harshs has joined #openstack-ironic | 20:46 | |
| *** kkoski has quit IRC | 20:48 | |
| *** Marga_ has joined #openstack-ironic | 20:49 | |
| *** sdake has joined #openstack-ironic | 20:51 | |
| *** tsekiyama has quit IRC | 20:55 | |
| thiagop | I'm calling it a day | 20:57 |
| thiagop | see you tomorrow | 20:57 |
| *** thiagop has quit IRC | 20:57 | |
| openstackgerrit | Sinval Vieira Mendes Neto proposed openstack/python-oneviewclient: Refactoring python-oneviewclient to use domain models of OneView as objects https://review.openstack.org/230988 | 20:57 |
| *** thrash is now known as thrash|g0ne | 20:59 | |
| *** tsekiyama has joined #openstack-ironic | 20:59 | |
| *** harshs has quit IRC | 21:01 | |
| *** puranamr has joined #openstack-ironic | 21:05 | |
| *** achanda has quit IRC | 21:07 | |
| *** penick has joined #openstack-ironic | 21:07 | |
| *** mtanino has joined #openstack-ironic | 21:07 | |
| *** harlowja has quit IRC | 21:08 | |
| *** tsekiyama has quit IRC | 21:09 | |
| *** puranamr has quit IRC | 21:10 | |
| *** tsekiyama has joined #openstack-ironic | 21:11 | |
| *** achanda has joined #openstack-ironic | 21:15 | |
| * NobodyCam is back | 21:17 | |
| *** willsama has joined #openstack-ironic | 21:27 | |
| *** harshs has joined #openstack-ironic | 21:27 | |
| *** jamielennox|away is now known as jamielennox | 21:32 | |
| *** sdake_ has joined #openstack-ironic | 21:40 | |
| *** sdake has quit IRC | 21:41 | |
| *** tsekiyama has quit IRC | 21:43 | |
| *** tsekiyama has joined #openstack-ironic | 21:47 | |
| *** harlowja has joined #openstack-ironic | 21:53 | |
| * jlvillal thinks OMFG | 21:54 | |
| NobodyCam | ??? | 21:54 |
| jlvillal | NobodyCam: I finally figured it out :) | 21:55 |
| NobodyCam | w00t | 21:55 |
| jlvillal | NobodyCam: This line: https://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/alembic/env.py#L33 | 21:56 |
| jlvillal | I couldn't understand why I couldn't make mal-formed log messages fail. | 21:56 |
| jlvillal | Finally figured out that this line, disables the loggers. | 21:56 |
| NobodyCam | jlvillal: because its configured that way the conf file? | 21:57 |
| jlvillal | NobodyCam: I'm not exactly sure. That calls into the logging module and sets logger.disabled = True | 21:58 |
| jlvillal | One thing, we shouldn't be calling the standard logging module. We should be using oslo_log | 21:58 |
| NobodyCam | oh | 21:59 |
| NobodyCam | (facepalm) | 21:59 |
| NobodyCam | gotcha | 21:59 |
| NobodyCam | good catch | 21:59 |
| jlvillal | NobodyCam: Took me 2 days :( | 22:00 |
| NobodyCam | :) but you got it ;) | 22:00 |
| jlvillal | NobodyCam: But I'm hoping to be able to enable it so we can detect log messages that are not formatted correctly. | 22:00 |
| jlvillal | And yes :) | 22:00 |
| NobodyCam | jlvillal: switching that to oslo_logging? | 22:01 |
| jlvillal | NobodyCam: More than that. Going to steal from Nova who have already done it. | 22:01 |
| NobodyCam | hehehehe, | 22:01 |
| NobodyCam | :) | 22:01 |
| *** penick has quit IRC | 22:03 | |
| *** tsekiyama has quit IRC | 22:04 | |
| *** sambetts has quit IRC | 22:05 | |
| *** sambetts has joined #openstack-ironic | 22:07 | |
| *** tsekiyama has joined #openstack-ironic | 22:07 | |
| *** penick has joined #openstack-ironic | 22:09 | |
| *** sdake_ has quit IRC | 22:10 | |
| *** sdake has joined #openstack-ironic | 22:14 | |
| *** zer0c00l has quit IRC | 22:19 | |
| *** Sukhdev has quit IRC | 22:19 | |
| *** dims has quit IRC | 22:29 | |
| *** romcheg has quit IRC | 22:32 | |
| *** harshs has quit IRC | 22:36 | |
| devananda | jroll: found some issues in your agent_amt patch - going to toss up a fix | 22:37 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP for finding bad messages https://review.openstack.org/232257 | 22:38 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add agent_amt driver https://review.openstack.org/231665 | 22:40 |
| devananda | with that ^ change, it at least loads and tries to deploy, but then fails on the iscsi connection -- http://paste.openstack.org/show/475667/ | 22:41 |
| devananda | also, jroll, I would expect agent_amt not to use iscsi, but apparently it is | 22:42 |
| jlvillal | devananda: That might be a sudoers issue. Though why it calls iscsiadm I'm not sure. | 22:48 |
| devananda | it's calling iscsiadm to do the iscsi deploy method | 22:48 |
| devananda | and yea, i'm trying to see if it's a sudoers // rootwrap issue, or something else right now | 22:48 |
| *** david-lyle has quit IRC | 22:54 | |
| jlvillal | devananda: On my system I had to setup NOPASSWD for my sudoer entry | 22:54 |
| jlvillal | devananda: Also, you may not want "Defaults requiretty" | 22:55 |
| *** david-lyle has joined #openstack-ironic | 22:55 | |
| jlvillal | From reading that pastebin message | 22:55 |
| jlvillal | NobodyCam: Any idea what problems this could cause? https://review.openstack.org/#/c/232257/1/ironic/db/sqlalchemy/alembic/env.py | 22:57 |
| jlvillal | I'm not sure if we need that or not. | 22:57 |
| *** davidlenwell has quit IRC | 23:01 | |
| *** davidlenwell has joined #openstack-ironic | 23:02 | |
| NobodyCam | jlvillal: I'd have to test that | 23:04 |
| jlvillal | NobodyCam: Okay. I'm not quite sure what that code does. I didn't see anything like it in Nova. It came from: https://review.openstack.org/#/c/67415/ | 23:08 |
| jlvillal | The patch author seems to no longer work on OpenStack. | 23:09 |
| * jlvillal will wait and see what the tempest tests say... | 23:09 | |
| *** harlowja has quit IRC | 23:10 | |
| *** david-lyle has quit IRC | 23:10 | |
| jlvillal | Good morning mrda | 23:10 |
| mrda | hi jlvillal | 23:10 |
| *** harlowja has joined #openstack-ironic | 23:10 | |
| *** willsama has quit IRC | 23:10 | |
| *** david-lyle has joined #openstack-ironic | 23:10 | |
| NobodyCam | morning mrda | 23:11 |
| NobodyCam | jlvillal: ack :) | 23:11 |
| mrda | hey NobodyCam | 23:12 |
| NobodyCam | :) | 23:13 |
| *** david-lyle has quit IRC | 23:14 | |
| devananda | jlvillal: tried changing to NOPASSWD, still not working right. but also, i'd rather this use agent deply than iscsi anyway | 23:15 |
| jlvillal | +1 | 23:15 |
| mrda | +1 | 23:15 |
| jlvillal | devananda: Any difference in the error message? | 23:16 |
| *** david-lyle has joined #openstack-ironic | 23:17 | |
| devananda | nope | 23:17 |
| devananda | probably another issue with sudo in my vagrant vm | 23:17 |
| devananda | not really interested in debugging it further | 23:17 |
| jlvillal | Don't blame you. Only so many hours in the day.... | 23:17 |
| *** david-ly_ has joined #openstack-ironic | 23:19 | |
| *** yuanying has joined #openstack-ironic | 23:19 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Detect when log messages are mis-formatted https://review.openstack.org/232257 | 23:20 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add agent_amt driver https://review.openstack.org/231665 | 23:20 |
| devananda | that fixes it ^ | 23:20 |
| devananda | and it works on my NUC \o/ | 23:20 |
| *** david-lyle has quit IRC | 23:21 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Detect when log messages are mis-formatted https://review.openstack.org/232257 | 23:21 |
| jlvillal | woo hoo :) | 23:21 |
| *** dims has joined #openstack-ironic | 23:22 | |
| NobodyCam | nice | 23:23 |
| *** zer0c00l has joined #openstack-ironic | 23:31 | |
| *** david-ly_ is now known as david-lyle | 23:31 | |
| *** tsekiyama has quit IRC | 23:33 | |
| *** penick has quit IRC | 23:34 | |
| *** lucas-dinner has quit IRC | 23:35 | |
| *** penick has joined #openstack-ironic | 23:37 | |
| *** dims has quit IRC | 23:40 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Remove unused import of oslo_log https://review.openstack.org/232275 | 23:40 |
| *** ionutbalutoiu has quit IRC | 23:43 | |
| *** Nisha has joined #openstack-ironic | 23:44 | |
| lifeless | jlvillal: how did you go with that logging thing? | 23:46 |
| jlvillal | lifeless: https://review.openstack.org/232257 | 23:46 |
| *** achanda has quit IRC | 23:47 | |
| jlvillal | lifeless: There was a call in one module to logging.config.FileConfig() that was disabling the logger. Took me a very long time to figure that out. | 23:47 |
| jlvillal | env.py | 23:47 |
| lifeless | jlvillal: cool | 23:48 |
| jlvillal | lifeless: So I am detecting the errors without modifying fixtures as oslo_log has a fixture to raise logs on formatting errors | 23:48 |
| lifeless | jlvillal: we should put nullhandler in fixtures too | 23:48 |
| *** smoriya has joined #openstack-ironic | 23:48 | |
| jlvillal | lifeless: Might not be a bad idea. I got that code from Nova. sdague wrote it | 23:49 |
| *** penick has quit IRC | 23:49 | |
| *** achanda has joined #openstack-ironic | 23:49 | |
| *** tsekiyama has joined #openstack-ironic | 23:50 | |
| *** Marga_ has quit IRC | 23:50 | |
| *** aswadr has quit IRC | 23:52 | |
| *** achanda has quit IRC | 23:53 | |
| *** dims has joined #openstack-ironic | 23:54 | |
| *** achanda has joined #openstack-ironic | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!