Wednesday, 2015-11-18

JayFimpossible to debug just looking through the lens of the gate00:00
jrollyeah00:00
jroller00:00
jrollwhat I meant was, without running locally00:00
Haomengzer0c00l: yes00:00
zer0c00lJayF: I run devstack on a RHEL7 box00:01
zer0c00lI was able to get the systemd-nspawn working00:01
zer0c00lfine00:01
*** sacharya_ has quit IRC00:01
zer0c00lit did the installation00:01
JayFzer0c00l: we've def seen issues downstream, when implementing some hardwaremanagers00:01
zer0c00lIf you look at the ironic-bm-logs, all i see is tftp loading the deploy kernel00:01
JayFzer0c00l: that nspawn has some security pieces that are nearly-impossible to disable to implement some cleaning bits00:02
JayFzer0c00l: may be unrelated to the pain you're seeing though :/00:02
zer0c00lyeah00:02
zer0c00lAgain, the setup just works fine with the changes to cloud-config.yml. With kernel 4.1.x they introduced a new cgroups fs00:03
zer0c00lso all i needed to do was just mount /sys/fs/cgroup into /opt/ironic_python_agent/sys00:03
zer0c00lAll is left to do is00:04
zer0c00lrunning the gate locally00:04
zer0c00lis it possible?00:04
zer0c00lAny pointers?00:04
jrollzer0c00l: keep in mind whenever the "baremetal" node in the gate reboots, it truncates the console log :(00:05
jrollzer0c00l: otherwise, yes it's possible. I'd recommend just running tempest locally though I forget the specific incantation00:06
zer0c00li see00:07
zer0c00lSo is there a way to look at the logs while the gate is running00:07
zer0c00lI mean the "baremetal" logs00:07
jrollnot that I know of00:08
jrollso when you run it locally, a full provision works?00:08
Haomengzer0c00l: I think you run on RHEL, right, it works00:09
zer0c00lHaomeng:  Yeah, i run it on RHEL00:09
zer0c00ljroll: yes00:09
zer0c00lit works00:09
zer0c00lI have a devstack setup00:09
jrollwtf00:10
zer0c00li can post the logs if you want ;)00:10
jrollheh00:10
Haomengzer0c00l: but our gate does not run on rhel I think00:10
jrollI mean, the gate runs on ubuntu00:10
zer0c00lyes it runs on ubuntu00:10
jrollwhich shouldn't matter at all, because this is running in a vm00:10
Haomengyes, so there are some differents00:10
zer0c00ljroll: Yes it could be a hypervisor thing?00:11
jrollzer0c00l: that would be very odd, but it could be I guess00:11
JayFI mean, honestly, more often our gate fails bceause it's a slow-thing00:11
JayFmoreso than a hypervisor specific thing00:11
zer0c00li see00:11
JayFbut we've def had failures specific to running teh gate in VMs00:11
jrollnot repeatedly like this though00:11
JayFthat's why after writing an image we run both partprobe and partx00:11
JayFjroll: ^ see that bug00:11
jrollthis definitely smells like a real break00:11
Haomengzer0c00l: looks like the systemd-nspawn not working as well00:11
Haomengand the issue is docker related I think00:12
jrolldocker only does the build, not the running of the container00:12
jrollzer0c00l: I'll run this on ubuntu and see what I can do00:12
Haomengjroll: ok00:13
*** naohirot has joined #openstack-ironic00:13
*** derekh has joined #openstack-ironic00:13
Haomengis this /opt/ironic-python-agent/sys/fs/cgroup/blkio folder created by systemd-nspawn?00:13
jrollI think so?00:14
zer0c00lHaomeng:  that has been fixed by editing the cloud-config.yml00:15
Haomengzer0c00l: should related with /sys/fs/cgroup which we changed in this patch00:15
zer0c00lyes00:15
zer0c00lhere is a successful boot with the latest installer build00:15
zer0c00lhttps://paste.fedoraproject.org/291642/14478056/00:15
Haomengzer0c00l: yes, maybe this patch is just working on rhel and not working on ubuntu00:16
Haomengzer0c00l: we dont think other ipa gate failed, it should not be common issue I think00:16
jrollzer0c00l: hm, that has [  549.917839] systemd-nspawn[821]: Failed to mount to /opt/ironic-python-agent/sys/fs/cgroup/blkio: No such file or directory00:16
jrollbut it eventually succeeds?00:16
zer0c00loh sorry,00:17
zer0c00lit was one of test runs00:17
jrollah ok00:17
*** harshs has quit IRC00:17
zer0c00li ssh'd into the running VM00:17
zer0c00land edited the systemd unit file00:17
Haomengzer0c00l: dont worry00:17
zer0c00ladded /sys/fs/cgroup00:17
zer0c00lthen it worked00:17
zer0c00llol00:17
Haomengzer0c00l: so we have workaround?00:17
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/24609000:18
zer0c00lHaomeng:  Yes, It has been already in-corporated in the code00:18
zer0c00lIn linux kernel 4.1.7 (which is the latest coreos stable) they added cgroups fs00:19
zer0c00lsystemd-nspawn requires it to be mounted in order for it work00:19
Haomengzer0c00l: https://review.openstack.org/#/c/191505/9/imagebuild/coreos/oem/cloud-config.yml ?00:19
zer0c00lYes that is the work around00:19
*** penick has quit IRC00:20
*** derekh has quit IRC00:20
Haomengzer0c00l: you mean we have to ssh'd to vm and add "00:22
zer0c00lHaomeng:  When created the core OS ramdisk with my authorized_keys, I was noticing the logs and systemd-nspawn failed00:23
zer0c00lSo i sshed' into the VM as core@ user00:23
Haomengzer0c00l: ok,got00:24
zer0c00lThen edited the systemd unit file in /etc/systemd/system/ironic-python-agent.service00:24
zer0c00lUpdated the systemd-nspawn command in there to bind mount /sys/fs/cgroups00:24
zer0c00lThen i did a systemctl daemon-reload to reload the unit files00:24
*** Pavo has quit IRC00:24
zer0c00lIPA started working now00:24
zer0c00lokay!00:25
JayFAwesome :)00:25
JayFI built a lot of that coreos builder stuff initially and have been one of the sole maintainers00:25
JayFwarms my heart to see other people troubleshooting and knowing how it all ticks00:25
zer0c00l:)00:25
JayFyou just have to accept the love of systemd into your heart00:25
zer0c00lhahaha00:26
HaomengJayF: :)00:26
* jroll foresees JayF handing out pamphlets door to door soon00:26
JayFno just black boxes00:26
Haomeng:)00:26
JayFyou just have to trust the pamplets are inside, and communicating truth00:26
jrolllolol00:26
openstackgerritSinval Vieira Mendes Neto proposed openstack/python-ironicclient: Refactoring and removing duplicate code of "base.Manager" heirs  https://review.openstack.org/24669200:27
*** penick has joined #openstack-ironic00:27
Haomengzer0c00l: so can we do some code change to modify ironic-python-agent.service defination, it is our ipa service defination, not sure, ingored me if does make sense:)00:30
JayFHaomeng: he did that change; all those units for systemd are created in the cloud-config.yml file00:30
JayFjust waiting to see if tempest passes before tossing on my +200:30
HaomengJayF: yes, got:)00:31
JayFjroll: re: the coreos stable patch -- we're OK knowing CoreOS can break the gate at any point?00:31
*** harshs has joined #openstack-ironic00:31
HaomengJayF: this one - https://review.openstack.org/#/c/191505/9/imagebuild/coreos/oem/cloud-config.yml ?00:31
JayFyes00:31
HaomengJayF: ok,got,thk:)00:31
JayFheh, I haven't looked at the upstream version of that file in a long time :)00:32
JayFmuch more clean than the one in my downstream ramdisk :)00:32
*** harshs_ has joined #openstack-ironic00:34
*** alexpilotti has joined #openstack-ironic00:35
*** harshs has quit IRC00:36
*** harshs_ is now known as harshs00:36
*** harshs has quit IRC00:37
*** sinval has joined #openstack-ironic00:37
*** alexpilotti has quit IRC00:39
jrollJayF: right, that's a good question, probably not (I previously thought maybe)00:39
JayFit would only break -src00:40
JayFb/c we couldn't get a "clean build" uplaoded if that gate was broken00:40
JayFbreaking IPA gate seems less bad, but I'm on the fence00:40
jrollright00:40
*** Sukhdev has quit IRC00:41
*** Sukhdev has joined #openstack-ironic00:43
*** harshs has joined #openstack-ironic00:44
*** Sukhdev has quit IRC00:44
*** harshs has quit IRC00:44
zer0c00lI don't have ubuntu with me, we are kind of a redhat shop , let me know how it goes jroll00:46
JayFzer0c00l: ^ we're talking about that change a little up there too00:46
JayFtl;dr: linking to a coreos channel means they can do a deploy that breaks our IPA gate00:47
JayFwhich is a bad thing, but the alternatives are bad too, so meh00:47
jrollzer0c00l: yeah, i'm trying to test00:48
jrollzer0c00l: dang, totally works for me too00:54
* jroll sighs00:55
*** jerrygb has quit IRC00:55
zer0c00l:)00:55
zer0c00lSo something's up with the gate?00:55
jrollJayF: also random data point, this took 3 minutes to get from power on to agent heartbeating :/00:55
jrollzer0c00l: I have no clue. in general the gate is working afaik00:56
zer0c00ljroll:  3 min is too slow?00:57
zer0c00lwhat is the normal time is like?00:57
zer0c00lAlso is the timeout less than 3 mins?00:57
jrollI don't think it's too slow, but not sure00:57
jrolljust a random data point :)00:57
jrollzer0c00l: default deploy timeout is 1800 seconds, so I don't think that's the problem here00:58
jroll:)00:58
harlowjazer0c00l u need to make that script that uses kexec to switch out vms into ubuntu :-P00:59
harlowjaget er done, lol00:59
harlowja*switch our vms00:59
*** hemna is now known as hemnafk01:04
*** jamielennox is now known as jamielennox|away01:10
zer0c00ljroll:  If you look at the conductor log it looks like it is provisioning it fine01:10
zer0c00lhttp://logs.openstack.org/05/191505/9/check/gate-tempest-dsvm-ironic-pxe_ipa-src/2bc210a/logs/screen-ir-cond.txt.gz01:10
zer0c00l2015-11-17 20:15:18.507 12254 INFO ironic.drivers.modules.agent_base_vendor [-] Deployment to node 91247dfc-5ace-47a0-9a06-835d33e11b6d done01:11
zer0c00lIt looks like things get stuck on clean wait?01:13
jrollodd01:16
jrollso maybe the job timed out?01:16
*** penick has quit IRC01:19
zer0c00lThe timeout is 300s?01:20
zer0c00lhttps://github.com/openstack/tempest/blob/88d0e77b25dfc79becf50116fd72dec8750a1d05/tempest/config.py#L122501:20
jrolloh wow01:23
jrollthat's good to know :)01:23
*** Pavo has joined #openstack-ironic01:23
jrollI had no clue that was there01:23
lintan_morning Ironic01:23
jrollsuch enlightenment01:23
lintan_morning jroll, Haomeng,JayF zer0c00l01:24
jrollzer0c00l: we also have a seemingly random bug where the node seems to fail to pxe01:24
jrollwhich I thuoght was slowness, but couldn't find a small timeout like this01:24
jrolllintan_: hey, good morning01:24
zer0c00llintan_:  Morning01:25
zer0c00lFrom the conductor it seems the node starts booting at 20:1601:26
zer0c00lFinishes to deploying at 20:2101:26
zer0c00lor almost 20:21:5801:26
zer0c00l~6 mins01:26
zer0c00lThe timeout is 300 secs01:27
openstackgerritSinval Vieira Mendes Neto proposed openstack/python-ironicclient: Refactoring and removing duplicate code of "base.Manager" heirs  https://review.openstack.org/24669201:27
zer0c00l360 secs to deploy01:27
zer0c00lThis could be a problem to01:27
jrollzer0c00l: yep, I think you nailed it01:27
zer0c00ljroll:  So we should increase the timeout?01:28
zer0c00lin tempest01:28
jrollzer0c00l: I'm thinking so, yes01:29
jrollzer0c00l: maybe add a related-bug for bug 139309901:30
openstackbug 1393099 in OpenStack-Gate "test_baremetal_server_ops fails with timeout waiting for provision_state to change" [Undecided,Confirmed] https://launchpad.net/bugs/139309901:30
jrollsince it might fix that as well01:30
zer0c00lLooks like that has something to do with tftp timeout01:32
zer0c00lIn our case there is no tftp timeout01:32
openstackgerritSinval Vieira Mendes Neto proposed openstack/python-ironicclient: Refactoring and removing duplicate code of "base.Manager" heirs  https://review.openstack.org/24669201:32
jrollzer0c00l: that's the guess, but hard to tell01:32
zer0c00lLooks like our case the host boots.. We see and actually does the provisioning according to the conductor01:33
jrollzer0c00l: so I think what's happening in that bug is that the deploy times out during the boot, and it looks like a tftp failure01:33
zer0c00lyes01:34
zer0c00lIt wipes out the console log as well01:34
zer0c00lThats why we half-baked logs in baremetal_0_console.log01:34
jrollright, so I think that timeout is what is causing the bug I linked01:34
jrollbecause someitmes we get slow gate hosts01:35
zer0c00lokay01:35
zer0c00ljroll:  There are some timeouts here https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/ironic.yaml01:40
zer0c00lWhere should we change this?01:40
jrollzer0c00l: those timeouts are in minutes, those should be fine01:40
jrollI think just need to change the tempest one01:41
*** zhenguo has joined #openstack-ironic01:42
Haomenglintan_: morning:)01:49
*** boris-42 has joined #openstack-ironic01:50
*** harshs has joined #openstack-ironic01:52
lintan_hey Haomeng :)01:52
openstackgerritHaomeng,Wang proposed openstack/python-ironicclient: support multi-nodes input for node-set-boot-device  https://review.openstack.org/24620701:58
*** penick has joined #openstack-ironic01:58
Haomenglintan_: :)01:58
*** cemason has joined #openstack-ironic01:59
*** harshs has quit IRC02:02
*** baoli has joined #openstack-ironic02:03
*** Haomeng has quit IRC02:04
*** sacharya has joined #openstack-ironic02:05
openstackgerritJim Rollenhagen proposed openstack/python-ironicclient: Drop explicit Python 2.6 support  https://review.openstack.org/24651202:06
jroll^ easy one02:06
*** thrash is now known as thrash|g0ne02:06
zer0c00ljroll: https://review.openstack.org/#/c/246718/02:07
jrollzer0c00l: mind if I update the commit message?02:07
*** lazy_prince has joined #openstack-ironic02:10
*** Marga_ has quit IRC02:11
*** Haomeng has joined #openstack-ironic02:12
zer0c00ljroll:  I don't. please go ahead02:12
*** praneshp has quit IRC02:13
jrollzer0c00l: done, thanks02:14
*** MattMan has quit IRC02:18
*** MattMan has joined #openstack-ironic02:18
zer0c00ljroll:  There is a spell error there s/enuogh/enough ?02:21
jrollzer0c00l: ha, thanks02:21
jrollI'll leave it for now02:22
openstackgerritJim Rollenhagen proposed openstack/ironic-python-agent: Use latest CoreOS stable when building  https://review.openstack.org/19150502:22
jrollzer0c00l: ^ added a depends-on there, that will tell us if this works as we expect02:22
jroll]/b 7102:22
jrolloops02:22
zer0c00ljroll:  Cool! Thanks.02:23
jrollno problem, thanks for working on this :D02:23
zer0c00l:)02:23
zer0c00ljroll:  Do you know the current status of hardware raid in IPA?02:24
zer0c00lI remeber there was a spec to enable hw raid02:25
Haomengjroll: good night:)02:25
*** baoli_ has joined #openstack-ironic02:25
jrollhiya Haomeng :)02:25
jrollzer0c00l: all the pieces are there for RAID, we just need to finish the "manual cleaning" work so ops can trigger it. that should be done this cycle02:26
Haomengjroll: :)02:26
*** penick has quit IRC02:27
zer0c00ljroll: oh i see, what type of raid controllers are supported now?02:27
zer0c00lHP? DELL?02:27
*** baoli has quit IRC02:28
jrollzer0c00l: good question, I believe those all live out of tree as agent hardware managers. I know HP has support, not sure who else off the top of my head02:28
Haomengjroll: last question, if you have time please help to check with lucas and dmitry for this bp patch - https://review.openstack.org/#/c/228301/ ,thank you:)02:28
*** davideagnello has quit IRC02:28
jrollHaomeng: oh my, I'm sorry I forgot about that bp02:29
*** davideagnello has joined #openstack-ironic02:29
*** jerrygb has joined #openstack-ironic02:29
jrollHaomeng: approved the bp and removed -202:29
jrollthanks for reminder02:30
*** dims_ has quit IRC02:30
zer0c00ljroll: Looks like they want us to set it locally https://review.openstack.org/#/c/246718/02:31
Haomengjroll: np, it just a client minor patch:) thank you very much:)02:31
openstackgerritTan Lin proposed openstack/python-ironicclient: Add '--node' to port-list  https://review.openstack.org/24621602:31
Haomengjroll: and I am still working on backup bp spec proposal02:31
*** meghal has joined #openstack-ironic02:33
jrollHaomeng: cool, thanks02:33
Haomengjroll: but the 'backup' function is more complex bp, will take care and commit the bp spec:)02:34
Haomengjroll: :)02:34
jrollHaomeng: indeed :)02:34
Haomengjroll: it is late for youon local time I think02:34
jrollHaomeng: a bit late, I'll be leaving soon :)02:35
Haomengjroll: ok, good night, and nice dream:)02:35
jrollHaomeng: have a good day02:35
Haomengjroll: :)02:35
jrollzer0c00l: let's revisit tomorrow?02:35
zer0c00ljroll: I agree!02:36
zer0c00lGood night!02:36
*** yonglihe has quit IRC02:42
sinvalI'm leaving folks, see you later o/02:44
openstackgerritMerged openstack/python-ironicclient: Use keystoneclient.exception directly  https://review.openstack.org/24449102:45
*** sinval has left #openstack-ironic02:48
*** deray has joined #openstack-ironic02:55
openstackgerritTan Lin proposed openstack/python-ironicclient: Correct node-port-list help info  https://review.openstack.org/24672902:58
*** meghal has quit IRC02:58
*** NobodyCam has quit IRC02:59
*** NobodyCam has joined #openstack-ironic03:00
*** liliars has quit IRC03:01
*** meghal has joined #openstack-ironic03:03
*** liliars has joined #openstack-ironic03:05
*** ijw has quit IRC03:10
*** meghal has quit IRC03:11
*** yuanying_ has joined #openstack-ironic03:17
*** cemason has quit IRC03:19
*** yuanying has quit IRC03:19
*** yuanying_ has quit IRC03:21
*** achanda has joined #openstack-ironic03:24
openstackgerritTan Lin proposed openstack/python-ironicclient: Add more unit tests for clituils  https://review.openstack.org/24673203:25
*** cemason has joined #openstack-ironic03:30
*** cdearborn has quit IRC03:35
*** sacharya has quit IRC03:46
*** achanda has quit IRC03:48
*** cemason has quit IRC03:55
*** lazy_prince has quit IRC03:55
*** achanda has joined #openstack-ironic03:55
*** cemason has joined #openstack-ironic03:56
*** cemason has quit IRC03:57
*** meghal has joined #openstack-ironic04:04
*** lazy_prince has joined #openstack-ironic04:05
*** meghal1 has joined #openstack-ironic04:05
*** meghal has quit IRC04:08
*** yuanying has joined #openstack-ironic04:10
jrollzer0c00l: progress! http://logs.openstack.org/05/191505/10/check/gate-tempest-dsvm-ironic-pxe_ipa-src/bfee19e/logs/ironic-bm-logs/baremetalbrbm_0_console.txt.gz04:10
jrollodd progress, but it's progress04:11
* jroll actually goes away now04:11
*** rloo has quit IRC04:17
*** lazy_prince has quit IRC04:30
*** amotoki has joined #openstack-ironic04:34
*** deray has quit IRC04:46
*** amotoki has quit IRC04:49
*** kalpase has joined #openstack-ironic04:50
*** harshs has joined #openstack-ironic04:52
*** harshs_ has joined #openstack-ironic04:53
*** deray has joined #openstack-ironic04:53
*** jamielennox|away is now known as jamielennox04:54
*** harshs has quit IRC04:56
*** harshs_ is now known as harshs04:56
*** amotoki has joined #openstack-ironic05:01
*** HimanshuGarg has quit IRC05:01
*** yuikotakada has joined #openstack-ironic05:07
*** mtanino has quit IRC05:09
*** amotoki has quit IRC05:10
*** achanda has quit IRC05:12
*** amotoki has joined #openstack-ironic05:14
*** Sukhdev has joined #openstack-ironic05:17
*** Marga_ has joined #openstack-ironic05:20
*** Marga_ has quit IRC05:20
*** Marga_ has joined #openstack-ironic05:21
*** praneshp has joined #openstack-ironic05:23
*** jerrygb has quit IRC05:25
*** achanda has joined #openstack-ironic05:25
*** krtaylor has quit IRC05:29
*** achanda has quit IRC05:29
*** achanda has joined #openstack-ironic05:35
Sukhdevlazy_prince: Ping05:36
*** amotoki has quit IRC05:40
*** harshs_ has joined #openstack-ironic05:44
*** harshs has quit IRC05:44
*** harshs_ is now known as harshs05:44
*** praneshp_ has joined #openstack-ironic05:50
*** Sukhdev has quit IRC05:50
openstackgerritDebayan Ray proposed openstack/ironic-specs: Add Manual cleaning support to iLO drivers  https://review.openstack.org/14540405:51
*** amotoki has joined #openstack-ironic05:51
*** achanda has quit IRC05:53
*** praneshp has quit IRC05:53
*** praneshp_ is now known as praneshp05:53
*** achanda has joined #openstack-ironic05:58
openstackgerritDebayan Ray proposed openstack/ironic-specs: Add Manual cleaning support to iLO drivers  https://review.openstack.org/14540406:01
*** yuikotakada has quit IRC06:15
*** xiexs has joined #openstack-ironic06:15
openstackgerritTan Lin proposed openstack/python-ironicclient: Add a new cmd method node-get-vendor-passthru-methods  https://review.openstack.org/23744406:32
openstackgerritTan Lin proposed openstack/python-ironicclient: Add driver-get-vendor-passthru-methods cmd  https://review.openstack.org/24676506:32
openstackgerritHaomeng,Wang proposed openstack/python-ironicclient: support multi-nodes operation for set_power_state command  https://review.openstack.org/22830106:34
*** rcernin has joined #openstack-ironic06:37
*** Marga_ has quit IRC07:03
*** Marga_ has joined #openstack-ironic07:05
*** alexpilotti has joined #openstack-ironic07:10
openstackgerritHaomeng,Wang proposed openstack/python-ironicclient: support multi-nodes operation for node-set-power-state command  https://review.openstack.org/22830107:12
*** alexpilotti has quit IRC07:15
openstackgerritHaomeng,Wang proposed openstack/python-ironicclient: support multi-nodes operation for node-set-power-state command  https://review.openstack.org/22830107:17
*** ionutbalutoiu has joined #openstack-ironic07:18
openstackgerritHaomeng,Wang proposed openstack/python-ironicclient: support multi-nodes input for node-set-boot-device  https://review.openstack.org/24620707:19
openstackgerritHaomeng,Wang proposed openstack/python-ironicclient: support multi-nodes input for node-set-maintenance  https://review.openstack.org/24229907:22
*** subscope has joined #openstack-ironic07:24
*** jerrygb has joined #openstack-ironic07:25
openstackgerritHaomeng,Wang proposed openstack/python-ironicclient: support multi-nodes input for node-set-provision-state  https://review.openstack.org/24230107:26
*** jerrygb has quit IRC07:30
*** alexpilotti has joined #openstack-ironic07:31
*** achanda has quit IRC07:32
*** alexpilotti has quit IRC07:35
*** harshs has quit IRC07:36
*** ukalifon1 has joined #openstack-ironic07:38
*** ionutbalutoiu has quit IRC07:40
openstackgerritTan Lin proposed openstack/python-ironicclient: A minor change for driver_shell test  https://review.openstack.org/24678407:42
openstackgerritHaomeng,Wang proposed openstack/python-ironicclient: support multi-nodes operation for node-set-power-state command  https://review.openstack.org/22830108:02
*** ifarkas has joined #openstack-ironic08:08
*** pas-ha has quit IRC08:10
*** GheRivero has left #openstack-ironic08:15
*** deray has quit IRC08:21
*** deray has joined #openstack-ironic08:21
*** pas-ha has joined #openstack-ironic08:22
*** ionutbalutoiu has joined #openstack-ironic08:24
*** ziggypup has joined #openstack-ironic08:24
*** ziggypup has left #openstack-ironic08:24
*** kozhukalov_ has joined #openstack-ironic08:26
openstackgerritDebayan Ray proposed openstack/ironic: Firmware update as part of iLO manual cleaning process  https://review.openstack.org/21101908:26
*** alexpilotti has joined #openstack-ironic08:30
*** yog_ has joined #openstack-ironic08:34
*** jcoufal has joined #openstack-ironic08:35
*** deray has quit IRC08:35
*** dtantsur|afk is now known as dtantsur08:36
dtantsurMorning Ironic08:37
ionutbalutoiuMorning dtantsur08:38
*** sacharya has joined #openstack-ironic08:49
*** kozhukalov_ has quit IRC08:51
Haomengmorning dtantsur, ionutbalutoiu :)08:52
*** sacharya has quit IRC08:53
openstackgerritZhenguo Niu proposed openstack/ironic: Validate all tcp/udp port numbers  https://review.openstack.org/24471309:00
aarefievmorning folks09:04
*** achanda has joined #openstack-ironic09:05
aarefievdtantsur: hi, have a min?09:07
aarefievIs it possible nodes auto discovery?09:07
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Add documentation on how to run tests  https://review.openstack.org/24086609:07
dtantsuraarefiev, hi! not right now, see ML for discussion. we may end up with it available this cycle, but it's pretty controversial09:08
aarefievdtantsur: ahh I see, I've found Lucas demo and wondering how it works09:09
aarefievhttps://www.youtube.com/watch?v=gZGYeo7sJhQ09:09
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Add documentation on how to run tests  https://review.openstack.org/24086609:10
dtantsuraarefiev, it used to be an early prototype of ironic-inspector. we didn't implement it that way for various reasons, not we're discussing this feature again09:11
*** romainh has joined #openstack-ironic09:11
*** lucas-afk is now known as lucasagomes09:12
aarefievdtantsur: thanks for clarification, looking forward to see this feature, I suggest you are working on this09:14
*** _degorenko is now known as degorenko09:14
dtantsuraarefiev, sambetts plans on doing it, as soon as we polish the design details09:14
openstackgerritTan Lin proposed openstack/python-ironicclient: A minor change for driver_shell test  https://review.openstack.org/24678409:16
aarefievdtantsur: ok thanks, hope I can help with this feature, I'm interesting in09:18
*** ionutbalutoiu has quit IRC09:19
betherlyMorning all!09:19
*** ionutbalutoiu has joined #openstack-ironic09:20
dtantsurmorning betherly09:21
*** Piet has quit IRC09:21
dtantsuraarefiev, cool! please start with a ML discussion, it started a couple of weeks ago, but stalled. I also need to get back to it.09:21
*** achanda has quit IRC09:22
aarefievdtantsur: sure09:22
*** ziggypup has joined #openstack-ironic09:24
*** ziggypup has left #openstack-ironic09:24
*** athomas has joined #openstack-ironic09:29
*** naohirot has quit IRC09:30
*** e0ne has joined #openstack-ironic09:32
*** xek has joined #openstack-ironic09:37
*** mkovacik has joined #openstack-ironic09:41
*** jistr has joined #openstack-ironic09:42
openstackgerrityolanda.robla proposed openstack/ironic-python-agent: Create partition at max msdos limit for disks > 2TB  https://review.openstack.org/24625309:48
openstackgerritLucas Alvares Gomes proposed openstack/ironic-python-agent: Follow up patch for da9c3b0adc67efa916fc534d975823c0a45948a1  https://review.openstack.org/24682709:56
*** ionutbalutoiu has quit IRC09:56
lucasagomesmorning all :-)09:56
dtantsurmorning lucasagomes!09:58
openstackgerritMerged openstack/ironic: Use wsgi from oslo.service for Ironic API  https://review.openstack.org/21929810:00
openstackgerritMerged openstack/ironic: Sort root device hints when parsing  https://review.openstack.org/24642210:02
openstackgerritMerged openstack/ironic: Document 'erase_devices_iterations' config option  https://review.openstack.org/24013710:02
*** mgould has joined #openstack-ironic10:07
mgouldmorning Ironicers!10:07
*** ionutbalutoiu has joined #openstack-ironic10:08
dtantsurmorning mgould10:11
openstackgerritMerged openstack/ironic: Add and document two new root device hints: wwn_{with, vendor}_extension  https://review.openstack.org/24587010:15
*** kozhukalov_ has joined #openstack-ironic10:24
*** jerrygb has joined #openstack-ironic10:26
*** deray has joined #openstack-ironic10:26
*** daemontool has joined #openstack-ironic10:28
*** daemontool has quit IRC10:30
*** daemontool has joined #openstack-ironic10:30
*** jerrygb has quit IRC10:31
*** daemontool has quit IRC10:31
*** thrash|g0ne has quit IRC10:34
yolandahi, newbie question... i'm trying to generate a custom image with bifrost, to add an extra element. I add the element on /etc/bifrost/bifrost_global_vars. The element is just a custom ironic-agent one, that cherry-picks a fix : https://review.openstack.org/24625310:36
yolandait doesn't seem to be applied, am i missing some logic?10:36
yolandawhat i do is to add the element on /etc/bifrost/bifrost_global_vars, and regenerate the image10:37
*** dtantsur is now known as dtantsur|brb10:37
yolandalucasagomes, i amended the change following your comments, thanks for the review10:41
*** e0ne has quit IRC10:43
*** mgould has quit IRC10:44
*** amotoki has quit IRC10:47
*** sacharya has joined #openstack-ironic10:54
*** mgould has joined #openstack-ironic10:57
*** sacharya has quit IRC10:58
*** meghal1 has quit IRC11:02
lucasagomesyolanda, thanks I will look in a min11:04
*** HimanshuGarg has joined #openstack-ironic11:04
*** e0ne has joined #openstack-ironic11:04
*** meghal has joined #openstack-ironic11:05
*** dims has joined #openstack-ironic11:07
*** deray has quit IRC11:09
*** dims has quit IRC11:12
*** daemontool has joined #openstack-ironic11:17
*** dims has joined #openstack-ironic11:18
*** daemontool has quit IRC11:18
*** daemontool has joined #openstack-ironic11:19
*** romainh has quit IRC11:19
openstackgerritLucas Alvares Gomes proposed openstack/ironic-python-agent: Refactor the image download and checksum computation bits  https://review.openstack.org/23433811:19
openstackgerritLucas Alvares Gomes proposed openstack/ironic-python-agent: Add support for streaming raw images directly onto the disk  https://review.openstack.org/23433911:19
*** meghal has quit IRC11:20
*** daemontool has quit IRC11:21
*** daemontool has joined #openstack-ironic11:24
yolandalucasagomes, thanks11:25
yolandai tested the change manually, running the script on a machine with 5tb disk, and worked. I am trying to bring a custom element to my bifrost setup, to test it, but no luck11:26
openstackgerritAnton Arefiev proposed openstack/python-ironicclient: Add missing translation markers  https://review.openstack.org/24687511:26
openstackgerritTan Lin proposed openstack/ironic: Wake up AMT interface before send request  https://review.openstack.org/23419011:27
*** zhenguo has quit IRC11:27
openstackgerritAnton Arefiev proposed openstack/python-ironicclient: Add missing translation markers  https://review.openstack.org/24687511:28
*** sinval has joined #openstack-ironic11:30
sinvalgood morning folks11:30
openstackgerritAnton Arefiev proposed openstack/ironic: Add SSL support to the Ironic API  https://review.openstack.org/24049211:32
openstackgerritSinval Vieira Mendes Neto proposed openstack/python-ironicclient: Refactoring and removing duplicate code of "base.Manager" heirs  https://review.openstack.org/24669211:37
*** subscope has quit IRC11:41
sambettsMorning all o/11:41
sambettsHow was your holiday dtantsur11:41
sinvalhey sambetts11:41
sambettso/ sinval11:42
*** subscope has joined #openstack-ironic11:42
*** dtantsur|brb is now known as dtantsur11:43
dtantsurmorning sambetts! nothing special, mostly cleaning at home :D still I feel relieved, not sure why :)11:43
lucasagomesyolanda, right, yeah I don't know much about ansible playbooks :-(11:43
lucasagomessinval, morning11:43
sambettsdtantsur: :D its always good to get that stuff out of the way11:43
lucasagomessambetts, morning too :-)11:43
sambettso/ lucasagomes11:44
sinvalhey lucasagomes o/11:44
sinvaljlvillal, hey I updated https://review.openstack.org/24669211:46
sinvaljlvillal, take a look when you have time11:46
*** daemontool has quit IRC11:47
*** daemontool has joined #openstack-ironic11:47
*** amotoki has joined #openstack-ironic11:48
*** amotoki has quit IRC11:49
* mgould could also use another look at https://review.openstack.org/#/c/240202/, which now addresses dtantsur's comments11:50
*** mgould is now known as mgould|afk11:53
*** romainh has joined #openstack-ironic11:57
openstackgerritYuiko Takada proposed openstack/ironic-specs: Add allowed transitions to API  https://review.openstack.org/22402211:57
openstackgerritAnton Arefiev proposed openstack/ironic: Add SSL support to the Ironic API  https://review.openstack.org/24049212:04
*** smoriya_ has quit IRC12:20
*** subscope has quit IRC12:20
*** subscope has joined #openstack-ironic12:21
*** subscope has quit IRC12:21
openstackgerritHaozhi Cui proposed openstack/python-ironicclient: fix a typo in node_shell.py  https://review.openstack.org/24689912:24
*** aarefiev has quit IRC12:25
*** aarefiev has joined #openstack-ironic12:27
sinvalvdrok, are you there?12:28
vdroksinval, morning, yes ^)12:28
sinvalvdrok, morning12:28
sinvalhey, I have some questions about your last comment on https://review.openstack.org/#/c/246692/4/ironicclient/common/base.py12:28
sinvalyou suggested a common function _vendor_passthru for driver and node, to avoid the problem of relying update, delete and get functions defined only on the heirs12:29
openstackgerritIonut-Madalin Balutoiu proposed openstack/ironic: Add clean up method for the DHCP factory  https://review.openstack.org/24591112:29
vdroksinval, yep, not sure if it is the nest solution, but at least it will not be in the base class :)12:30
sinvalvdrok, what do you think about the same idea of _create and _get methods, that would be nice to pass the specific function as a parameter12:31
vdrok*best12:31
jlvillalGood morning Ironic12:31
vdroksinval, why do you need a function? It seems that just path to resource would be enough?12:32
vdrokmorning jlvillal12:32
sinvalmorning jlvillal12:32
jlvillal:)12:33
sinvalvdrok, could you be clearer about the path to resource approach? I'm missing something about this...12:33
vdroksinval, on L 48 in base.py for example add path argument and do self.api.json_request to this path. and e.g. in chassis.py L172 pass self._path() as an argument12:35
vdrokdef _create(self, creation_attributes, path, **kwargs):12:36
*** lucasagomes is now known as lucas-hungry12:37
sinvalvdrok, I see, for def _create I agree with this12:38
*** kalpase has left #openstack-ironic12:38
*** mbound has joined #openstack-ironic12:39
sinvalvdrok, but for _vendor_passthru, the problem was the self.update, self.get and self.delete calls, so to me, passing those functions as parameters, just like you're saying about _create would be good enough12:40
*** mbound has quit IRC12:41
vdroksinval, yes, it is an option, my suggestion was to add some util function that will get node or driver object as an argument and call methods on it12:44
vdroksinval, it's up to you to decide :)12:45
sinvalvdrok, ok, I'll maintain the _vendor_passthru on base.Manager, make more sense once we are already using inheritance to deal with this, just a nit...12:45
sinvalvdrok, thnaks for your help o/12:46
vdroknp12:46
*** romainh has quit IRC12:47
*** mbound has joined #openstack-ironic12:50
aarefievjlvillal: hi, could you take a look one more time, please: https://review.openstack.org/#/c/229286/12:54
*** electrofelix has joined #openstack-ironic12:57
*** e0ne has quit IRC12:57
*** jerrygb has joined #openstack-ironic13:06
openstackgerritSyed Ismail Faizan Barmawer proposed openstack/ironic-lib: Replace rootwrap_config and rootwrap_helper_cmd with root_helper  https://review.openstack.org/24574113:07
TheJuliagood morning13:10
*** jerrygb has quit IRC13:10
sambettso/ TheJulia13:10
*** e0ne has joined #openstack-ironic13:10
*** mgould|afk is now known as mgould13:14
*** dprince has joined #openstack-ironic13:19
*** sacharya has joined #openstack-ironic13:19
jrollmorning all :)13:20
dtantsurmorning TheJulia, jroll13:21
*** praneshp has quit IRC13:21
jroll\o13:21
sinvalmorning TheJulia, dtantsur, jroll13:22
liliarsmorning TheJulia sambetts jroll dtantsur and everyone else I don't see :))13:23
sinvalhey liliars o/13:23
openstackgerritAnton Arefiev proposed openstack/python-ironicclient: Add missing translation markers  https://review.openstack.org/24687513:23
dtantsursinval, o/13:23
jrollhiya liliars, sinval :)13:23
dtantsurmorning liliars as well :) do you still plan to update that IPA documentation patch?13:23
*** sacharya has quit IRC13:24
liliarsdtantsur: hey! was just about to talk to you. sorry I didn't have the time to go over and update that IPA patch. I left some comments though. actually I was thinking a follow up patch, at least for the swift part, is a better idea. especially to ease the review process as folks seem to have mixed opinions about this storage backend thing. so we can move the discussion to a new patch, wdyt?13:28
liliarsdtantsur: but I can update the patch as well with the other comments :)13:28
liliarsthe existing patch*13:29
liliarsdtantsur: don't know if you had the time to see the reviews yet but there is some discussion going on over there13:29
liliarshey sinval :)13:30
dtantsurliliars, I'm a bit busy right now, so I didn't have a chance to look at comments yet13:31
liliarsdtantsur, yeah you were also on a holiday yesterday so I kinda figured. when you have some time take a look and let me know. but I'm still up for it :) was just trying to figure a better way to do it considering the new reviews13:34
dtantsurliliars, if you feel like updating - just go ahead :) I definitely won't have time for it today and unlikely tomorrows13:34
*** kbyrne has quit IRC13:36
liliarsdtantsur: ok then, I'll update the swift unrelated things and afterwards we can move the discussion regarding this to a new patch, I think it's the best way. thanks!13:36
dtantsurthank you!13:36
*** afaranha has joined #openstack-ironic13:37
*** ndipanov has quit IRC13:38
*** ndipanov has joined #openstack-ironic13:39
*** kbyrne has joined #openstack-ironic13:43
*** achanda has joined #openstack-ironic13:44
*** krtaylor has joined #openstack-ironic13:46
*** achanda has quit IRC13:46
ifarkasdtantsur, hi, could you please review https://review.openstack.org/#/c/235350/ ?13:47
dtantsurifarkas, on my list, will try to find some time :)13:47
ifarkasdtantsur, thanks!13:47
*** lucas-hungry is now known as lucasagomes13:48
*** thrash has joined #openstack-ironic13:48
*** thrash has quit IRC13:48
*** thrash has joined #openstack-ironic13:48
jlvillalaarefiev, I will try to look at it today. I am in training this week. Which is good for me, but bad for my reviewing...13:48
*** achanda has joined #openstack-ironic13:49
*** ionutbalutoiu has quit IRC13:50
aarefievjlvillal: cool, have fun:); don't worry so..13:50
*** thiagop has joined #openstack-ironic13:52
*** absubram has joined #openstack-ironic13:52
*** achanda has quit IRC13:53
thiagopGood morning Ironic13:57
sambettso/ ifarkas, liliars, thiagop13:57
ifarkaso/14:00
*** alexpilotti has quit IRC14:03
*** alexpilotti has joined #openstack-ironic14:03
jrollhey cores, got a couple client patches that need landing pls14:05
jrollhttps://review.openstack.org/#/c/246512/14:05
jrollhttps://review.openstack.org/#/c/237444/14:05
*** kozhukalov_ has quit IRC14:07
*** bapalm has joined #openstack-ironic14:08
*** boris-42 has quit IRC14:08
jrollfor context I'd like to release a client after those land14:09
jrollto drop py2614:09
liliarsdtantsur: np :)14:10
openstackgerritZhenguo Niu proposed openstack/ironic: Check shellinabox started successfully or not  https://review.openstack.org/24628314:10
*** achanda has joined #openstack-ironic14:12
*** mgoddard__ has joined #openstack-ironic14:18
*** kozhukalov_ has joined #openstack-ironic14:19
openstackgerritAnton Arefiev proposed openstack/python-ironicclient: Add missing translation markers  https://review.openstack.org/24687514:19
*** romainh has joined #openstack-ironic14:20
*** mgoddard_ has quit IRC14:20
*** cdearborn has joined #openstack-ironic14:24
*** daemontool_ has joined #openstack-ironic14:25
*** daemontool_ has quit IRC14:26
*** lsmola has quit IRC14:26
*** daemontool_ has joined #openstack-ironic14:27
*** absubram has quit IRC14:27
*** daemontool has quit IRC14:27
*** mgould has quit IRC14:27
*** daemontool_ has quit IRC14:28
*** mgoddard__ has quit IRC14:28
*** rloo has joined #openstack-ironic14:29
*** mgoddard has joined #openstack-ironic14:29
*** daemontool_ has joined #openstack-ironic14:29
*** lsmola has joined #openstack-ironic14:29
*** lsmola has quit IRC14:31
*** openstackgerrit has quit IRC14:31
*** openstackgerrit has joined #openstack-ironic14:32
jrolllucasagomes: when you have a sec https://review.openstack.org/#/c/246512/14:33
lucasagomesjroll, will do, I'm in a call at the moment14:33
jrollcool, thanks14:33
*** mgould has joined #openstack-ironic14:40
*** bapalm has quit IRC14:43
openstackgerritAnton Arefiev proposed openstack/python-ironicclient: Add missing translation markers  https://review.openstack.org/24687514:43
*** bapalm has joined #openstack-ironic14:43
openstackgerritAnton Arefiev proposed openstack/python-ironicclient: Add missing translation markers  https://review.openstack.org/24687514:47
*** kozhukalov_ has quit IRC14:51
*** daemontool_ has quit IRC14:51
openstackgerritYuriy Zveryanskyy proposed openstack/ironic-specs: Add System Event Log support to management interface  https://review.openstack.org/24696514:52
aarefievrloo: hi, have a min to talk about  https://review.openstack.org/#/c/226201/ ?14:57
rlooaarefiev: sure14:57
aarefievrloo: not sure I understand your opinion about exception changed, how it can break something14:58
*** harshs has joined #openstack-ironic14:58
rlooaarefiev: if an exception is raised -- that usually means some code won't be run.14:58
rlooaarefiev: there are i think cases where if you had not made those changes, the code would still 'work'.14:58
*** mbound has quit IRC14:58
*** jasonamyers has joined #openstack-ironic14:59
rlooaarefiev: so i think i am fine with making the changes but i am not fine with not documenting the effect of those changes to the users.14:59
rlooaarefiev: ie, there may be cases where a 'not-correct' value still worked before, and now when someone upgrades, it will break for them.14:59
rlooaarefiev: and i don't have time to go through all the configs that you modified, to see which ones will break and which won't.15:00
rlooaarefiev: do you know what i mean?15:00
aarefievrloo: hmm, hot it works with  'not-correct' value ?15:01
aarefievs/hot/how15:01
rlooaarefiev: did you test/run any of this, or did you just make code changes?15:01
*** daemontool has joined #openstack-ironic15:01
aarefievrloo: tested not all, but there are checks for them already in code15:03
*** kozhukalov_ has joined #openstack-ironic15:03
rlooaarefiev: for example, https://review.openstack.org/#/c/226201/6/ironic/api/app.py15:03
rlooaarefiev: line 9815:04
rlooaarefiev: that line only checks if the value is 'keystone'.15:04
rlooaarefiev: so if it had been 'foo' before, it would have been fine.15:04
rlooaarefiev: but it cannot be 'foo' with your change.15:04
rlooaarefiev: and i think with your change, an exception will be raised at line 98, right?15:04
aarefievrloo: sure, but it value = 'foo', it's wrong behavior15:06
aarefievshould it be error?15:06
rlooaarefiev: i am not disagreeing with your code change. i am saying that we need to document the effect this change will have on users.15:06
aarefievrloo: ahh ok, I see , where do you suggest to document it?15:07
rlooaarefiev: in the commit. that seems easiest.15:07
jrollreno!15:07
rlooaarefiev: sorry, i was afraid jroll would be listening to this... in reno.15:08
jrolllol15:08
*** subscope has joined #openstack-ironic15:08
rlooaarefiev: (I was hoping to make more work for jroll so he'd extract stuff from commits and put them in reno.)15:08
* jroll cries15:08
jrollrloo: there's enough of that to do already :/15:09
rlooaarefiev, jroll: anyway, in addition to reno, i think it makes sense to put it in the commit itself.15:09
jrollyeah, agree15:09
aarefievrloo: :) ok I get it, thanks for clarification15:09
rloojroll: yeah, i know. just that we're starting with reno and don't quite have whatever process in place for that, do we?15:09
jrollrloo: the process is "add a release note with reno", not sure what you're asking for15:10
rlooaarefiev: sorry if my comment in that review wasn't clear. (hard to know when to blab on, or keep it short.)15:10
jrollhttp://docs.openstack.org/developer/reno/usage.html15:10
*** harshs has quit IRC15:10
*** kromanenko has joined #openstack-ironic15:11
aarefievrloo: np, thank you for help15:11
rloojroll: well, do we need to worry about formatting or anything? or i guess we can just get info in there and it can be cleaned up later.15:11
jrollrloo: meh, the most important thing is the info15:12
rloojroll: i haven't had a chance to read about reno etc. so if i haven't, just didn't think i should be asking others to do it yet.15:13
jrollrloo: well, the longer we wait to enforce it, the more work we have to do to go back and pick things up15:14
jrollso please do read about it, it's important15:14
rloojroll: agree. on my list...15:14
*** ukalifon1 has quit IRC15:16
*** jcoufal has quit IRC15:17
*** Nakato has quit IRC15:17
*** ndipanov has quit IRC15:18
*** Nakato has joined #openstack-ironic15:18
*** ndipanov has joined #openstack-ironic15:19
*** ukalifon has joined #openstack-ironic15:19
jrollstepping away for a while15:20
dhellmannjroll, rloo : reno notes are expected to be restructuredtext. The test jobs should fail if the output can't be parsed.15:23
*** sacharya has joined #openstack-ironic15:23
*** jcoufal has joined #openstack-ironic15:23
rloodhellmann: good to know. I'm sure it'll all be easy as pie once we start using it :)15:23
dhellmannrloo : there's no time like the present ;-)15:24
rloodhellmann: i was just wondering about the 'overhead' for people to land a bug/feature. Anyway...15:24
openstackgerritThiago Paiva Brito proposed openstack/ironic: Use server_profile_template_uri at scheduling  https://review.openstack.org/23712215:25
dhellmannrloo : overhead?15:25
rloodhellmann: well, they maybe have to have a spec or open  a bug, do the code changes. know how to submit patches, write proper commit messages, and now add something to reno.15:26
rloodhellmann: oh, and update documentation. and maybe i'm missing some other stuff :)15:27
dhellmannrloo : someone else was doing all of this work before. Distributing the load will, eventually, make the release process smoother and ensure we don't miss things by waiting until the end of the release to write about them.15:27
dhellmannrloo : yep, building complicated things well takes effort15:27
rloodhellmann: oh, i don't disagree with it. just wondering how/if we can make it easier for submitters.15:27
openstackgerritAnton Arefiev proposed openstack/ironic: Use oslo_config choices support  https://review.openstack.org/22620115:28
rloodhellmann: not that i am spending many seconds wondering about it.15:28
*** sacharya has quit IRC15:28
openstackgerritSerge Kovaleff proposed openstack/ironic-inspector: Generate Sphinx docs  https://review.openstack.org/24698515:28
dhellmannrloo : yeah, we'll find a balance as we go15:28
*** yonglihe has joined #openstack-ironic15:29
*** mbound has joined #openstack-ironic15:29
openstackgerritYuriy Zveryanskyy proposed openstack/ironic-specs: Add limits support to management interface  https://review.openstack.org/20961215:29
openstackgerritYuriy Zveryanskyy proposed openstack/ironic-specs: Intel Node Manager policies support  https://review.openstack.org/21465715:30
*** ifarkas has quit IRC15:30
*** ifarkas has joined #openstack-ironic15:30
*** ifarkas has quit IRC15:30
*** ifarkas has joined #openstack-ironic15:31
rlooaarefiev: hey, quick question for you or devananda. This bug can be closed now, right? https://bugs.launchpad.net/ironic/+bug/129683315:31
openstackLaunchpad bug 1296833 in Ironic "client disconnect should not log stack trace in API" [Low,Opinion]15:31
aarefievrloo: sure, we don't use wsgiref anymore15:32
*** lazy_prince has joined #openstack-ironic15:32
aarefievrloo: I've updated commit msg, now trying to figure out how reno works :)15:35
rlooaarefiev: let me know when you find out! (or I'll just look at your patch)15:35
*** pas-ha has quit IRC15:38
*** kozhukalov_ has quit IRC15:40
*** deray has joined #openstack-ironic15:47
*** deray_ has joined #openstack-ironic15:47
*** Sukhdev has joined #openstack-ironic15:48
*** gabriel-bezerra is now known as gabriel15:49
*** mgould has quit IRC15:54
*** kozhukalov_ has joined #openstack-ironic15:56
*** jerrygb has joined #openstack-ironic15:57
*** daemontool has quit IRC15:58
*** daemontool has joined #openstack-ironic15:59
vdrokrloo, morning, are you currently working on manual cleaning? I'd like to understand cleaning stuff better, so maybe I can help with it?15:59
*** mgoddard has quit IRC15:59
rloovdrok: yes, i'm working on it. the code is done, i "just" have to write more unit tests and break it up into several patches...15:59
*** dtantsur is now known as dtantsur|brb16:00
rloovdrok: am hoping to do that stuff later today. will see how it goes.16:00
sambettsjroll, krtaylor: QA Meeting on today at 17:00?16:00
vdrokrloo, great :)16:00
lucasagomesjroll, patch is already merged, I'm late :-) thanks rloo16:01
lucasagomess/merged/approved16:01
rloolucasagomes: :D16:02
openstackgerritMerged openstack/python-ironicclient: Drop explicit Python 2.6 support  https://review.openstack.org/24651216:06
*** hemnafk is now known as hemna16:06
*** mgould has joined #openstack-ironic16:07
derayhello ironic folks ..16:07
mgouldhi deray16:07
deraymgould: hi ..16:08
*** rcernin has quit IRC16:09
derayI am currently working on a topic related to manual cleaning .. https://review.openstack.org/#/c/145404/16:09
deray"Add Manual cleaning support to iLO drivers"16:09
deraywould like you to have a look at the spec, to validate my understanding about manual cleaning16:11
*** wuhg has quit IRC16:11
openstackgerritMerged openstack/ironic: Remove duplicated unit tests in test_manager  https://review.openstack.org/24644216:13
krtaylorsambetts, yes, I'm planning on it  :)16:18
sambettskrtaylor: :) cool16:18
krtaylorI'm hopeful that jlvillal will be there, else I'll run it again16:18
*** yog_ has quit IRC16:19
derayvdrok: can you have a cursory glance at  https://review.openstack.org/#/c/145404/, when you are a little free?16:20
jlvillalkrtaylor, If you can run it again that would be most helpful. I am in class all day long today.16:22
*** dims_ has joined #openstack-ironic16:22
krtaylorjlvillal, no worries, I'll take care of it16:23
jrollderay: I think you will like my review :)16:23
*** dims has quit IRC16:24
jrollkrtaylor: so I went hunting for the list of driver contacts, it isn't as complete as I remember: https://wiki.openstack.org/wiki/Ironic/Drivers16:25
derayjroll: lol, no no please spare me, i am just a new kid on the block :) .. just kidding, please do.16:25
jrollderay: haha, I tried to make your life easy :)16:25
derayjroll: appreciate ;)16:26
krtaylorjroll, ouch, well that makes direct contact harder, but not impossible, we can call front desks if necessary like thingee said  :)16:26
derayjroll: please have a look .. my first contribution to Ironic :)16:27
jrollkrtaylor: yeah, we'll do the best we can. should be able to dig in git history a bit for email addresses too :)16:27
deray"goign to be" of course16:27
sambettskrtaylor, jroll some people have started putting their IRC handles next to their drivers on the etherpad too :)16:27
jrollderay: I mean I left a review already, please look at it :)16:27
JayFderay: jroll gave you a get-out-of-spec-free comment on that spec, pretty much the best -1 ever16:28
sambettskrtaylor, jroll: Hopefully we can build up a comprehensive list on there16:28
krtaylorsambetts, agreed, that should be the place to "work" on it16:28
derayoh .. brb16:28
jlvillalkrtaylor, Thanks!16:28
JayFjroll: re: the 3rd party CI spec, if the 3rd party drivers are going 100% outside of the ironic umbrella, I think that should be explicit16:29
sambettsjroll, can you have a look on that IronicQA pad and see if there are any drivers you think we've missed in our list16:29
krtaylorsambetts, we will eventually need the CI systems to use the infra wiki page for listing their contact info also16:29
JayFjroll: My assumption reading through it would be we might end up with openstack/ironic-CrappyHardware2000-driver repos :)16:29
sambettskrtaylor: Agreed, maybe something we need to put into the spec?16:30
krtaylorJayF, thanks for bringing that up, I don't have an answer16:30
krtaylorJayF, we discussed it briefly, and the summary was that they just stop being there an not be moved anywhere16:30
jrollsambetts: link please :)16:30
sambettsJayF: I've already got a cisco-ironic-contrib repo for my out-of-tree one, maybe we need to define a convention in the spec16:30
*** alexpilotti has quit IRC16:30
sambettsjroll: https://etherpad.openstack.org/p/IronicCI16:31
krtaylorJayF, I had proposed an attic approach to be a bit nicer16:31
JayFI don't care about if there's a convention; just if the 3rd party drivers aren't even allowed under the "big umbrella" of openstack bare metal we should say so.16:31
jrollJayF: openstack/ironic-CrappyHardware2000-driver is totally fine. big tent. it just won't be under the baremetal program (aka ironic umbrella)16:31
JayFjroll: aha, okay16:31
JayFjroll: not 100% sure how those lines are drawn now, part of why I was asking16:31
*** mgoddard has joined #openstack-ironic16:31
jrollJayF: and we should document that. but I don't care if it's in the spec or not16:31
jrollah16:31
jrolllemme link16:31
krtaylorbut, we don't want to create that repo for them, right?16:32
sambettsJayF: its a document stored by infra, http://git.openstack.org/cgit/openstack/governance/tree/reference/projects.yaml16:32
jrollJayF: ironic umbrella: https://github.com/openstack/governance/blob/master/reference/projects.yaml#L1459-L154516:32
JayFwell I knew that piece16:32
JayFI didn't know there were allowed to be projects sorta just hanging out16:32
JayFnot under any umbrella16:33
jrollJayF: and project existence https://github.com/openstack-infra/project-config/blob/master/gerrit/projects.yaml#L230716:33
jrollyep16:33
jrollkrtaylor: correct16:33
JayFgot it16:33
krtaylorif a driver team cares enough to continue with a driver that has been removed from tree, shouldn't they create a out-of-tree repo for it>16:33
krtaylorok, I can update the spec with this info, I think that is a valid approach16:33
sambettskrtaylor: Something that happened with the neutron decomposion was that people wanted to keep their git history when they decomposed, are we going to support that?16:35
rloojroll: there is some other web page that has ironic drivers listed (besides https://wiki.openstack.org/wiki/Ironic/Drivers). let me see if i can find it16:35
*** dprince has quit IRC16:35
jrollrloo: yeah, I couldn't find it :/16:35
krtaylorsambetts, I don't believe it is possible across namespaces/projects, hm...16:36
*** Nisha has joined #openstack-ironic16:36
jrollsambetts: they can do that on their own, since we aren't moving the thing16:36
krtaylorrloo, you may be thinking of the etherpad?16:36
rloojroll: found it. http://stackalytics.com/report/driverlog?project_id=openstack%2Fironic16:36
jrollsambetts: btw, I added msftocs and seamicro drivers to the pad16:36
krtaylorah, yes, that too :)16:36
sambettsjroll: :D awesome thanks16:36
rloojroll: (linked from our main ironic page. we did something right!)16:36
jrollrloo: aha, thanks! krtaylor check that link out16:36
jrollheh16:37
*** alexpilotti has joined #openstack-ironic16:37
krtaylorjroll, at some point, we need to say the spec is good enough  :) else we will keep refining it instead of JFDI16:38
*** Piet has joined #openstack-ironic16:38
jrollkrtaylor: that's what my +2 was meant to say :)16:40
*** Marga_ has quit IRC16:40
*** Marga_ has joined #openstack-ironic16:42
*** mkovacik has quit IRC16:42
openstackgerritJarrod Johnson proposed openstack/pyghmi: Add TLS support and TSM remote video (WIP)  https://review.openstack.org/24659616:43
openstackgerritMerged openstack/ironic-lib: Updated from global requirements  https://review.openstack.org/24609116:44
*** mgoddard_ has joined #openstack-ironic16:45
*** sacharya has joined #openstack-ironic16:45
*** mkovacik has joined #openstack-ironic16:46
*** lazy_prince has quit IRC16:47
*** lazy_prince has joined #openstack-ironic16:47
*** mgoddard has quit IRC16:48
*** mgould has quit IRC16:51
rloojroll: what/are there guidelines wrt what we can log in debug? we shouldn't do passwords, but what about eg swift temp url. is it a security risk? : https://review.openstack.org/#/c/243141/16:52
jrollrloo: great question16:53
jrollso, the security risk there is that someone with that url can fetch a private image until the url expires16:53
*** rpioso has joined #openstack-ironic16:53
jrollI think I would prefer to not do that, but I'm not sure16:54
jrollbasically the risk profile is someone with logs access that does not have ir-api/ir-db/glance admin access16:54
rloojroll: someone that has access to the logs and wants to do that. i feel like we should err on the side of caution but i dunno too.16:54
jrollrloo: I feel like that too16:55
rloojroll: i'm passing the hot potato to you :)16:55
jrollnooooo16:55
lucasagomeslol, I'm actually OK with that16:57
jrolllucasagomes: okay with that risk profile, you mean?16:58
lucasagomesyeah16:58
rloojroll, lucasagomes: i was thinking. what about yet another config to show sensitive info in debug.16:58
*** dtantsur|brb is now known as dtantsur16:59
lucasagomescause he can only get that image, he can't modify or do anything right?16:59
jrolllucasagomes: sure, but that image may have private data16:59
openstackgerritDebayan Ray proposed openstack/ironic: Firmware update as part of iLO manual cleaning process  https://review.openstack.org/21101916:59
lucasagomesjroll, say configdrive, when we log the string for it16:59
lucasagomessomeone can also unzip it and have the config drive right? Can it have sensitive information?16:59
lucasagomesbut that said, I kinda like rloo opnion on that17:00
lucasagomesrloo, maybe not even a config option but a policy thing?17:00
lucasagomesthat we can enable/disable debug logs for sensitive information17:00
* lucasagomes jumps on another call (I will keep an eye in the channel)17:00
rloolucasagomes: policy is based on user/tenant?17:00
jrollpolicy is for api17:00
lucasagomesoh true, it's only for api17:01
* lucasagomes facepalm17:01
*** e0ne has quit IRC17:01
jrollmaybe it's fine to log, idk, I lean toward not logging it17:01
jrollwe should probably not log configdrive either >.>17:01
lucasagomesyeah17:01
rlooi also think not logging. is this something we can ask the security group?17:01
*** penick has joined #openstack-ironic17:02
jrollwe can ask them anything :)17:02
openstackgerritMerged openstack/ironic-python-agent: Follow up patch for da9c3b0adc67efa916fc534d975823c0a45948a1  https://review.openstack.org/24682717:02
rloojroll: I mean, is this a 'reasonable question' to ask the security group? :D17:02
jrollsure!17:02
lucasagomesthis also raises the question whether debug is the right log level for production17:02
jrollrloo: or even mailing list, I'm sure some folks would dogpile on it17:02
* lucasagomes knows jroll runs it in debug17:02
jrollit is because openstack is impossible to debug without it17:03
lucasagomesyeah17:03
jrollas long as nothing breaks, info is fine17:03
jrollbut17:03
jrollya know.17:03
lucasagomesheh17:03
rloolucasagomes: we cannot prevent what values folks use in production.17:03
rloolucasagomes: but we can describe what info is shown, and let them decide17:03
lucasagomesrloo, right17:04
rloounfortunately we need to debug cuz it doesn't work perfectly :-(17:05
lucasagomesyeah, it's another problem that triggers this17:05
*** mgould has joined #openstack-ironic17:05
lucasagomescause ideally, debug could have sensitive info17:05
*** HimanshuGarg has quit IRC17:06
dtantsursensitive info can be useful for debugging too17:06
jrolllucasagomes: I'm just going to land this if you're okay with that https://review.openstack.org/#/c/237444/17:06
dtantsurso I'd say people running in debug should secure their logs (actually I think everyone should)17:06
jrolldtantsur: sure, it's just yet another attack vector17:06
lucasagomesjroll, ++ I'm totally godo with it, I've tested locally17:06
lucasagomesworks fine17:06
jrollcool17:06
*** kozhukalov_ has quit IRC17:07
dtantsurjroll, I just tend to consider logs as sensitive no matter what... we never know what information can be deduced from them17:07
jrolldtantsur: agree, that doesn't mean we should intentionally put credentials etc there17:08
dtantsurdefinitely... is this conversation about swift tempurls?17:08
lucasagomesdtantsur, yeah17:09
dtantsurI see. I can't make up my mind about this issue, but I do agree that logging them could be handy... could be a configuration option?17:10
dtantsurin some cases (e.g. tripleo) logging these should be totally fine17:10
jrollright17:10
jrollit's fine for rackspace too, as we don't support custom images17:10
jrolljust trying to think of the general case17:11
*** jistr has quit IRC17:11
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Node  https://review.openstack.org/23950617:12
dtantsurjroll, option defaulting to false would make at least some people happy. dunno..17:13
derayjroll: sorry to break into.. registered 2 new blueprints (bp/ilo-firmware-update-in-manual-cleaning and bp/ilo-license-activate-in-manual-cleaning) .. thanks17:14
jrolldtantsur: yeah, I guess that's fine, I just don't like options :P17:14
jrollderay: perfect, thanks!17:14
* dtantsur creates options for everything usually :D17:14
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Node  https://review.openstack.org/23950617:15
*** romainh has quit IRC17:15
openstackgerritAnton Arefiev proposed openstack/ironic: Use oslo_config choices support  https://review.openstack.org/22620117:16
jrollderay: could you add some words to those about how it works, maybe just "add a clean step with this function signature"?17:18
derayjroll: will definitely do ..17:18
*** meghal has joined #openstack-ironic17:19
*** mbound has quit IRC17:19
*** kozhukalov_ has joined #openstack-ironic17:19
*** HimanshuGarg has joined #openstack-ironic17:19
jrollderay: thanks, I can approve them when that's done17:19
*** daemontool has quit IRC17:20
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Node  https://review.openstack.org/23950617:20
jrollaarefiev: your release note on 226201 lgtm, but I think the category should be 'upgrade', not 'other'17:21
aarefievjroll: I thought about upgrade at first time too, but now not sure, actually we don't need to upgrade anything17:22
aarefievfrom doc For example, if a database schema alteration is needed.17:23
jrollaarefiev: but it could become a problem at upgrade time, that is for notes about things operators need to check when they upgrade17:23
jrollso config changes should always have an upgrade: section17:23
aarefievjroll: ok17:24
*** kromanenko has quit IRC17:24
*** lazy_prince has quit IRC17:25
openstackgerritAnton Arefiev proposed openstack/ironic: Use oslo_config choices support  https://review.openstack.org/22620117:25
*** Sukhdev has quit IRC17:31
derayjroll: have just hastily updated it. let me know wyt.17:33
derayfolks, going to log off now, good day ahead17:34
jrollthanks deray :)17:34
*** Sukhdev has joined #openstack-ironic17:36
derayjroll: thank you! have a good day!17:37
jrollyou too!17:38
*** deray_ has quit IRC17:38
*** deray has quit IRC17:38
*** mgoddard has joined #openstack-ironic17:38
*** mgoddard_ has quit IRC17:38
jrollTIL this is a thing http://grafana.openstack.org/dashboard/db/zuul-status17:39
*** ionutbalutoiu has joined #openstack-ironic17:44
*** ukalifon has quit IRC17:49
*** jerrygb_ has joined #openstack-ironic17:54
*** jerrygb_ has quit IRC17:54
*** rloo has quit IRC17:54
*** verdurin has quit IRC17:55
*** jerrygb_ has joined #openstack-ironic17:55
*** mkovacik has quit IRC17:55
*** jerrygb has quit IRC17:57
sambettswell thats pretty!17:57
*** jerrygb_ has quit IRC17:59
*** achanda has quit IRC18:00
liliarswoo nice one! *looking forward*18:00
*** jerrygb_ has joined #openstack-ironic18:01
*** jerrygb_ has quit IRC18:01
*** jerrygb_ has joined #openstack-ironic18:01
*** degorenko is now known as _degorenko18:02
*** achanda has joined #openstack-ironic18:02
*** dprince has joined #openstack-ironic18:03
*** achanda has quit IRC18:03
*** meghal has quit IRC18:04
*** meghal has joined #openstack-ironic18:04
*** meghal has quit IRC18:04
openstackgerritMerged openstack/ironic: Updated from global requirements  https://review.openstack.org/24609018:04
*** meghal has joined #openstack-ironic18:04
openstackgerritMerged openstack/python-ironicclient: Add a new cmd method node-get-vendor-passthru-methods  https://review.openstack.org/23744418:04
openstackgerritMerged openstack/python-ironicclient: Add driver-get-vendor-passthru-methods cmd  https://review.openstack.org/24676518:04
*** daemontool has joined #openstack-ironic18:05
JayFlucasagomes: thanks for fixing my bug in the past (get_os_install_device used to return None in some edge cases, just looked at the upstream agent, and you fixed it when you factored out guess_root_disk)18:08
*** mgould has quit IRC18:10
openstackgerritJarrod Johnson proposed openstack/pyghmi: Add TLS support and TSM remote video (WIP)  https://review.openstack.org/24659618:11
*** HimanshuGarg has quit IRC18:11
*** Marga_ has quit IRC18:13
lucasagomesJayF, hi there, morning! No problem. I'm sure you added some FIXME/TODO in the code so thank you for that :-)18:14
JayFlucasagomes: nope, I literally just ran over the bug, b/c we had something in a downstream hardware manager using get_os_install_device and it bugged out when None was returned instead of a string containing the block device :)18:14
JayFlucasagomes: we have pretty significant downstream hardware managers in the agent as I'm sure you can imagine :)18:14
*** e0ne has joined #openstack-ironic18:15
lucasagomesJayF, heh yeah I've looked at some of it actually to see the clean tasks you guys have18:15
lucasagomesonmetal_ironic_hardware_manager or something like that18:16
JayFYeah, we actually have a more up to date version downstream18:16
JayFhad to start using some vendor tools only given to us under NDA, so we had to close up our newer version o fit18:16
*** daemontool has quit IRC18:16
JayFwe've refactored it since then to map to the new api -- one hardware manager per piece of hardware + one generic hardware manager to run things not-hardware-specific18:16
* JayF is implementing something in the non-hw-specific hw manager now to validate no hardware is missing from any machine before OnMetal provisions it18:17
*** meghal has quit IRC18:17
*** jerrygb_ has quit IRC18:17
JayFI honestly would like to talk publically more about the coolness of the hardware manager stuff we have downstream. Good stuff from JoshNang and natorious in there that not many upstream folks get to see18:17
dtantsurwonderful evening news: coreos IPA image goes to dracut emergency shell for me... I didn't think it even uses dracut, but ok..18:18
*** Sukhdev has quit IRC18:19
JayFCoreOS uses dracut when booting18:19
JayFThat's a really strange problem though18:19
JayFI don't think I've *ever* seen CoreOS pxe fail to boot18:19
dtantsurI see... so it fails with something like "systemd not found" or similar... will investigate on18:19
JayFI've seen IPA fail to load and other failure cases, but never it fail to run dracut18:19
dtantsureverything is possible in ironic-inspector gates :D18:19
JayFhah18:19
sambettshaha18:19
JayFIf you get stuck, feel free to toss some gists my way and I'll see if I can help18:20
lucasagomesJayF, oh that's interesting... cause I most tools for firmware management is going to be non-foss18:20
JayFI know a few things about how all that stuff works18:20
*** dprince has quit IRC18:20
lucasagomesso having an abstraction to isolate those is very useful18:20
dtantsuryeah, I'll torture myself for tomorrow as well, then will cry for help :) thanks!18:20
*** dprince has joined #openstack-ironic18:20
JayFlucasagomes: it's almost like when I wrote the hardware manager interface to allow arbitrary things to be done I knew we'd have this problem ;)18:20
lucasagomesdtantsur, systemd not gound!?18:21
lucasagomesfound*18:21
jrolllucasagomes: it isn't super interesting, it's like a clean step to run a thing provided by the vendor18:21
lucasagomeslol18:21
jrollnot much we can abstract :P18:21
dtantsurlucasagomes, yeah... systemd complaining that systemd is not found, or something of the same level of insanity... I'll figure out tomorrows, maybe18:21
JayFlucasagomes: part of why I've always insisted on the agent being able to to drive what gets run18:21
dtantsurg'night everyone18:21
JayFdtantsur: that honestly just sounds like a bad build18:21
jrollnight dtantsur18:21
*** meghal has joined #openstack-ironic18:22
lucasagomesjroll, yes, but that's good because if you can abstract that say in another file... you can opensource all the rest of the hardware manager except those bits18:22
dtantsurJayF, yeah, but I only download it, no build is supposed to happen. maybe I did something wrong, not sure..18:22
dtantsurwill see18:22
sambettsnight dtantsur18:22
*** dtantsur is now known as dtantsur|afk18:22
*** verdurin has joined #openstack-ironic18:22
jrolllucasagomes: sure, there just isn't much left when we remove the vendor stuff, that isn't in our v1 manager18:22
lucasagomesoh ok, yeah that's sad heh18:23
jrolllucasagomes: we did build it in multiple classes so it's easy to open up some of those if needed18:23
lucasagomesbtw JayF, if you have some time your input would be good here https://review.openstack.org/#/c/246253/18:24
JayFlucasagomes: I do anticipate a time coming when we'll be able to talk more about some of the stuff in the manager. It's just a complete non-starter today18:25
lucasagomesand I feel like we want to translate that script to python, it keep growing18:25
sambettsjroll: has anyone else ever seen a devstack ironic install fail to download the required image from glance and just hang at deploying??18:25
lucasagomesjroll, yeah that's perfect18:25
*** HimanshuGarg has joined #openstack-ironic18:26
lucasagomessambetts, seems like a bug... you can see the failure in the logs but the state wans't moved to deploy fail?18:26
sambettsthere isn't a failure in the logs, I see Master cache miss for image d9e4ee2a-138e-4fbf-bda0-76101b26cd82, starting download and then its just sat and not completed the download18:26
JayFlucasagomes: I really hate that code getting more complex w/o being refactored into python18:26
jrollsambetts: idk18:26
lucasagomesJayF, ++18:26
JayFlucasagomes: but then you get into the loop of waiting for ironiclib, and it just gets more sticky from there18:27
JayFsambetts: there's little/no error checking in the agent client code18:27
JayFsambetts: If the agent failed in the middle of downloading the image, I wouldn't expect anything to fail it short of a timeout18:27
sambettsJayF: this is the conductor downloading the image for the cache18:27
JayFhah okay18:27
* JayF goes back into his agent hole18:28
lucasagomesproblem being I don't think we have timeout for nodes in "deploying"... do we?18:28
* lucasagomes checks18:28
JayFlucasagomes: yep.18:28
JayFlucasagomes: that would be a correct statement18:28
JayFlucasagomes: and we may or may not monitor downstream for various "stuck" states that come from the lack of error handling in the agent18:28
*** dprince has quit IRC18:29
*** dprince has joined #openstack-ironic18:29
lucasagomesright yeah things to improve18:30
*** HimanshuGarg has quit IRC18:30
*** ifarkas has quit IRC18:30
*** trown is now known as trown|lunch18:31
sambettslucasagomes: I can't abort a node in deploying either can I?18:31
lucasagomessambetts, nop18:31
sambetts:'(18:31
* lucasagomes gotta get back to the spec to be able to abort stuff while *ing18:32
lucasagomessambetts, but it worth some investigation if you can... it feels like glance should error out eventually?18:33
lucasagomesor maybe it did and ironic somehow did bubble that exception up to the manager.py18:33
sambettslucasagomes: Yeah, I need to check all the logs18:33
lucasagomesdidn't *18:33
lucasagomessambetts, it also may be some lock in the filesystem?18:34
lucasagomessome leftover somewhere, cause I think we use some fs locks to help synchronize stuff18:35
lucasagomesmaybe the code is just there waiting for it18:35
*** meghal has quit IRC18:35
* lucasagomes is guessing now18:35
*** athomas has quit IRC18:36
*** alexpilotti has quit IRC18:36
lucasagomessambetts, https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/lockutils.py#L188-L19018:37
*** alexpilotti has joined #openstack-ironic18:40
lucasagomesI will call it a day, have a good night everyone!18:41
*** lucasagomes is now known as lucas-dinner18:41
thiagopbye lucas-dinner, see you tomorrow18:41
lucas-dinnersee ya :-)18:41
*** harshs has joined #openstack-ironic18:43
*** HimanshuGarg has joined #openstack-ironic18:44
*** jerrygb has joined #openstack-ironic18:44
thiagopvdrok: Hey! Did you see my comments on that OneView patch?18:45
*** dprince has quit IRC18:49
JoshNangJayF: yeah the multiple hardware manager stuff worked out really well. i'm sad i didn't get to give my talk about that (and other stuff) at tokyo18:53
*** rloo has joined #openstack-ironic18:54
sambettscya lucas-dinner18:56
*** mbound has joined #openstack-ironic18:56
*** harlowja has quit IRC19:05
*** harlowja has joined #openstack-ironic19:08
*** dprince has joined #openstack-ironic19:09
*** mbound has quit IRC19:10
*** mbound has joined #openstack-ironic19:12
*** dprince has quit IRC19:14
*** dprince has joined #openstack-ironic19:15
*** absubram has joined #openstack-ironic19:18
*** Marga_ has joined #openstack-ironic19:19
*** dprince has quit IRC19:19
*** ndipanov has quit IRC19:20
*** penick has quit IRC19:20
*** penick has joined #openstack-ironic19:20
*** meghal has joined #openstack-ironic19:23
*** bapalm has quit IRC19:23
*** bapalm has joined #openstack-ironic19:26
*** dprince has joined #openstack-ironic19:27
*** [1]rpioso has joined #openstack-ironic19:27
*** rpioso has quit IRC19:28
*** trown|lunch is now known as trown19:28
*** vishwanathj has quit IRC19:29
*** alexpilotti has quit IRC19:36
*** Sukhdev has joined #openstack-ironic19:38
*** alexpilotti has joined #openstack-ironic19:42
sambettsnight all19:43
*** Marga_ has quit IRC19:47
*** Sukhdev has quit IRC19:49
*** Sukhdev has joined #openstack-ironic20:05
*** subscope has quit IRC20:06
*** subscope has joined #openstack-ironic20:06
*** subscope has quit IRC20:09
*** subscope has joined #openstack-ironic20:10
*** e0ne has quit IRC20:13
*** Marga_ has joined #openstack-ironic20:14
*** subscope has quit IRC20:17
sinvalnight sambetts20:18
thiagopnight sambetts20:18
*** kozhukalov_ has quit IRC20:27
zer0c00lMorning folks20:27
*** dprince has quit IRC20:32
thiagopmorning zer0c00l20:33
*** penick has quit IRC20:34
zer0c00l:)20:35
*** harlowja has quit IRC20:36
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/24711120:39
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements  https://review.openstack.org/24711220:39
*** harlowja has joined #openstack-ironic20:41
openstackgerritMerged openstack/ironic-python-agent: Create partition at max msdos limit for disks > 2TB  https://review.openstack.org/24625320:42
*** Marga_ has quit IRC20:45
*** Nisha has quit IRC20:45
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: $$configuration mock  https://review.openstack.org/24712620:45
openstackgerritRuby Loo proposed openstack/ironic: Specifying target provision states in fsm  https://review.openstack.org/24712820:46
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/24711120:47
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements  https://review.openstack.org/24711220:47
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements  https://review.openstack.org/24713020:47
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/24713120:47
*** verdurin has quit IRC20:49
*** ionutbalutoiu has quit IRC20:50
openstackgerritOpenStack Proposal Bot proposed openstack/python-ironic-inspector-client: Updated from global requirements  https://review.openstack.org/24715220:51
openstackgerritOpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements  https://review.openstack.org/24715320:51
*** rebase has joined #openstack-ironic20:53
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added Ironic API result transformation.  https://review.openstack.org/24179920:54
*** Sukhdev has quit IRC20:55
*** sinvalv has joined #openstack-ironic20:56
*** Walts has joined #openstack-ironic20:56
WaltsHi everyone, I have been running a POC of ironic for work, and have been deploying bare metal nodes from from a network with dhcp enabled. this is all fine but is there anyway I can statically assign IP addresses bare metal nodes21:00
*** openstack has joined #openstack-ironic21:05
*** meghal has quit IRC21:05
*** meghal has joined #openstack-ironic21:05
*** meghal has quit IRC21:05
*** meghal has joined #openstack-ironic21:06
*** mbound has joined #openstack-ironic21:06
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added IronicDriverProperties resource  https://review.openstack.org/24717121:06
*** e0ne has joined #openstack-ironic21:09
*** dprince has joined #openstack-ironic21:09
sinvalvWalts: Hi, well, I'm not sure if you can provide static IP for your bare metal nodes, but I do know that during the deployment you'll need the DHCP anyway, he is the guy that send the nodes to the TFTP server (which contains the image to be deployed to your node)21:09
jrollWalts: use dhcp_provider=none and manage_tftp=False, and set up your own dhcp/tftp thing.21:09
*** thiagop has left #openstack-ironic21:10
*** meghal has quit IRC21:10
jrollWalts: that's for deployment anyway, there's ways for the tenant network as well (configdrive + cloud-init or similar)21:10
*** thiagop has joined #openstack-ironic21:10
*** penick has joined #openstack-ironic21:10
*** meghal has joined #openstack-ironic21:10
*** jistr has joined #openstack-ironic21:10
*** mbound has quit IRC21:11
*** jerrygb_ has joined #openstack-ironic21:12
devanandasambetts: for maintenance mode, wdyt of "ignore / include" ?21:12
Waltssinvalv, jroll: thanks I will look into those options, I was curious as to the extra specs that can be passed to the ironic port create command I wondered if an IP address could be passed in that way e.g. ronic  port-create -a $MAC_ADDRESS -n $NODE_UUID -e vif_port_ID=$PORT_ID21:13
devanandaWalts: you can pass in static IP through the config drive. I don't have a link handy for documentation on how to do it, but there is a runbook in bifrost that, I believe, does just that21:14
devanandaWalts: no - Ironic can't set the IP itself21:14
*** meghal has quit IRC21:15
Waltsdevananda: thanks I will try to find it, sounds like config drive is a good bet for this21:15
devanandaWalts: if you're using Neutron to manage the bare metal node's network, then it can set the IP21:15
Waltsyes using neutron21:15
*** penick has quit IRC21:15
*** jerrygb has quit IRC21:15
devanandaah. then don't look into configdrive -- you should use neutron to manage the dhcp21:15
Waltsdevananda: sorry if this is a silly question but wont neutron still be handing out dynamic ips, it is doing this currently?21:17
* krotscheck has somehow managed to create a circular set of dependencies in gerrit.21:17
devanandakrotscheck: well done21:17
krotschecks/dependencies/patches/21:17
krotscheckI have no idea how21:17
*** verdurin has joined #openstack-ironic21:17
devanandaWalts: sorry, maybe I misunderstood. What are you using neutron for?21:18
*** penick has joined #openstack-ironic21:19
*** jerrygb_ has quit IRC21:22
*** ijw has joined #openstack-ironic21:22
*** ijw has quit IRC21:22
Waltsdevananda: my bad I'm new to this and not explaining myself well. With neutron I have a flat dhcp network mapped to a physical network,  I am provisioning a bare metal node through nova which of course uses ironic, the node builds but has a dynamicly assigned IP I was just wondering if it is possible to set this statically. I if I made the network none dhcp then i would loose the ability to net boot21:22
*** ijw has joined #openstack-ironic21:23
*** jerrygb_ has joined #openstack-ironic21:23
*** alexpilotti has quit IRC21:23
Waltsthis may be an issue with my lack of understanding of the other openstack components not just ironic21:24
devanandaWalts: gotcha. If you want statically assigned IPs, you would need neutron to _not_ assign dynamic IPs or manage DHCP for those nodes21:25
*** ionutbalutoiu has joined #openstack-ironic21:26
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: $$configuration mock  https://review.openstack.org/24712621:26
*** jerrygb__ has joined #openstack-ironic21:26
devanandaWalts: in that scenario, you could do what jroll suggested earlier -- in ironic, set dhcp_provider=none and manage_tftp=False, run your own dhcp service that is statically configured to respond to bootp requests with the ironic-python-agent ramdisk, and inform ironic that you'd like all nodes to boot from local disk after deployment21:27
*** ukalifon1 has joined #openstack-ironic21:27
Waltsdevananda: understood, thanks for you help21:27
*** jerrygb__ has quit IRC21:27
*** jerrygb has joined #openstack-ironic21:28
*** jerrygb_ has quit IRC21:28
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added Ironic API result transformation.  https://review.openstack.org/24179921:30
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added IronicDriverProperties resource  https://review.openstack.org/24717121:30
*** verdurin has quit IRC21:31
*** e0ne has quit IRC21:31
*** Marga_ has joined #openstack-ironic21:34
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Removed ports  https://review.openstack.org/24657821:37
*** alexpilotti has joined #openstack-ironic21:38
*** Marga_ has quit IRC21:39
*** Marga_ has joined #openstack-ironic21:40
*** jistr has quit IRC21:41
*** Pavo has quit IRC21:41
*** Pavo has joined #openstack-ironic21:44
*** e0ne has joined #openstack-ironic21:47
*** kozhukalov_ has joined #openstack-ironic21:47
*** HimanshuGarg has quit IRC21:49
*** e0ne has quit IRC21:50
*** Walts has quit IRC21:53
*** verdurin has joined #openstack-ironic21:59
*** jerrygb has quit IRC22:00
*** penick has quit IRC22:01
*** HimanshuGarg has joined #openstack-ironic22:01
*** verdurin has quit IRC22:03
openstackgerritRuby Loo proposed openstack/ironic: Support arguments to clean step methods  https://review.openstack.org/24720122:06
*** penick has joined #openstack-ironic22:24
*** harshs has quit IRC22:26
*** Sukhdev has joined #openstack-ironic22:26
openstackgerritRuby Loo proposed openstack/ironic: Add manual cleaning to state machine  https://review.openstack.org/24721322:30
*** verdurin has joined #openstack-ironic22:31
*** cdearborn has quit IRC22:31
*** hemna has quit IRC22:35
*** penick has quit IRC22:36
*** sacharya has quit IRC22:38
openstackgerritSinval Vieira Mendes Neto proposed openstack/python-ironicclient: Refactoring and removing duplicate code of "base.Manager" heirs  https://review.openstack.org/24669222:39
*** ukalifon1 has quit IRC22:40
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added IronicDriverProperties resource  https://review.openstack.org/24717122:54
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Upgraded eslint  https://review.openstack.org/24722322:54
*** dprince has quit IRC23:00
*** ijw has quit IRC23:03
*** Sukhdev has quit IRC23:04
*** jerrygb has joined #openstack-ironic23:05
*** Piet has quit IRC23:05
*** penick has joined #openstack-ironic23:06
*** ijw has joined #openstack-ironic23:07
*** jerrygb has quit IRC23:09
*** jerrygb has joined #openstack-ironic23:14
*** Sukhdev has joined #openstack-ironic23:15
openstackgerritSinval Vieira Mendes Neto proposed openstack/python-ironicclient: Refactoring and removing duplicate code of "base.Manager" heirs  https://review.openstack.org/24669223:15
openstackgerritHaozhi Cui proposed openstack/python-ironicclient: update node shell help info  https://review.openstack.org/24689923:19
*** ionutbalutoiu has quit IRC23:20
*** kozhukalov_ has quit IRC23:22
*** harshs has joined #openstack-ironic23:23
*** penick has quit IRC23:35
*** alexpilotti has quit IRC23:45
*** naohirot has joined #openstack-ironic23:51
*** smoriya_ has joined #openstack-ironic23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!