| *** Sukhdev has quit IRC | 00:06 | |
| *** jjohnson2 has quit IRC | 00:09 | |
| *** suro-patz has quit IRC | 00:10 | |
| *** garthb has quit IRC | 00:11 | |
| *** davideag_ has quit IRC | 00:23 | |
| *** mtanino has quit IRC | 00:29 | |
| *** Sukhdev has joined #openstack-ironic | 00:33 | |
| *** Sukhdev has quit IRC | 00:33 | |
| *** achanda has quit IRC | 00:41 | |
| *** Marga_ has quit IRC | 00:48 | |
| *** Goneri has quit IRC | 01:12 | |
| *** vishwanathj has joined #openstack-ironic | 01:30 | |
| *** thrash is now known as thrash|g0ne | 01:36 | |
| *** baoli has joined #openstack-ironic | 01:37 | |
| *** baoli_ has joined #openstack-ironic | 01:39 | |
| *** achanda has joined #openstack-ironic | 01:41 | |
| *** baoli_ has quit IRC | 01:42 | |
| *** baoli has quit IRC | 01:42 | |
| *** achanda has quit IRC | 01:46 | |
| *** Marga_ has joined #openstack-ironic | 01:49 | |
| *** Marga_ has quit IRC | 01:54 | |
| *** Haomeng has joined #openstack-ironic | 01:56 | |
| *** achanda has joined #openstack-ironic | 01:56 | |
| *** mtanino has joined #openstack-ironic | 02:00 | |
| *** harshs has quit IRC | 02:02 | |
| *** spandhe has quit IRC | 02:03 | |
| *** Marga_ has joined #openstack-ironic | 02:10 | |
| *** Goneri has joined #openstack-ironic | 02:14 | |
| *** Marga_ has quit IRC | 02:14 | |
| *** yolanda has quit IRC | 02:18 | |
| *** Goneri has quit IRC | 02:23 | |
| openstackgerrit | Tan Lin proposed openstack/ironic: Make use of oslo-config-generator https://review.openstack.org/247331 | 02:27 |
|---|---|---|
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Normalize MAC OctetString to fix InvalidMAC exception https://review.openstack.org/299721 | 02:27 |
| openstackgerrit | Tan Lin proposed openstack/ironic: Make use of oslo-config-generator https://review.openstack.org/247331 | 02:28 |
| openstackgerrit | Tan Lin proposed openstack/ironic-lib: Explore config options to oslo-config-generator https://review.openstack.org/297549 | 02:29 |
| *** hoangcx has joined #openstack-ironic | 02:31 | |
| *** Marga_ has joined #openstack-ironic | 02:48 | |
| *** suro-patz has joined #openstack-ironic | 02:53 | |
| *** Marga_ has quit IRC | 02:53 | |
| *** hoangcx has quit IRC | 03:02 | |
| *** achanda has quit IRC | 03:03 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Force iRMC vmedia boot from remotely connected CD/DVD https://review.openstack.org/297541 | 03:05 |
| *** Marga_ has joined #openstack-ironic | 03:07 | |
| *** Marga_ has quit IRC | 03:07 | |
| *** Marga_ has joined #openstack-ironic | 03:08 | |
| *** Marga_ has quit IRC | 03:08 | |
| *** hoangcx has joined #openstack-ironic | 03:08 | |
| *** Marga_ has joined #openstack-ironic | 03:09 | |
| *** Haomeng has quit IRC | 03:18 | |
| *** spandhe has joined #openstack-ironic | 03:19 | |
| *** yuanying has quit IRC | 03:21 | |
| *** marlinc_ has joined #openstack-ironic | 03:29 | |
| *** keekz_ has joined #openstack-ironic | 03:30 | |
| *** krotscheck has joined #openstack-ironic | 03:30 | |
| *** BadCub_ has joined #openstack-ironic | 03:31 | |
| *** keekz has quit IRC | 03:32 | |
| *** marlinc has quit IRC | 03:32 | |
| *** JoshNang has quit IRC | 03:32 | |
| *** marlinc_ is now known as marlinc | 03:32 | |
| *** krotscheck_dcm has quit IRC | 03:32 | |
| *** serverascode has quit IRC | 03:33 | |
| *** BadCub has quit IRC | 03:33 | |
| *** sergek has quit IRC | 03:33 | |
| *** adreznec has quit IRC | 03:33 | |
| *** BadCub_ is now known as BadCub | 03:33 | |
| *** adreznec has joined #openstack-ironic | 03:34 | |
| *** JoshNang has joined #openstack-ironic | 03:38 | |
| *** sergek has joined #openstack-ironic | 03:38 | |
| *** serverascode has joined #openstack-ironic | 03:38 | |
| *** links has joined #openstack-ironic | 03:44 | |
| openstackgerrit | Sivaramakrishna Garimella proposed openstack/ironic: WIP: add network drivers https://review.openstack.org/285852 | 03:47 |
| *** yarkot_ has joined #openstack-ironic | 03:51 | |
| *** yarkot_ has quit IRC | 03:53 | |
| *** mkovacik_ has joined #openstack-ironic | 03:57 | |
| *** mkovacik has quit IRC | 03:59 | |
| *** suro-patz has quit IRC | 04:03 | |
| *** achanda has joined #openstack-ironic | 04:04 | |
| *** yuanying has joined #openstack-ironic | 04:07 | |
| *** achanda has quit IRC | 04:09 | |
| *** achanda has joined #openstack-ironic | 04:09 | |
| *** baoli has joined #openstack-ironic | 04:10 | |
| *** baoli has quit IRC | 04:14 | |
| *** harlowja_at_home has joined #openstack-ironic | 04:23 | |
| *** baoli has joined #openstack-ironic | 04:31 | |
| *** vmud213 has joined #openstack-ironic | 04:35 | |
| *** baoli has quit IRC | 04:36 | |
| *** moshele has joined #openstack-ironic | 04:45 | |
| *** vishwanathj has quit IRC | 04:53 | |
| *** rcernin has joined #openstack-ironic | 04:59 | |
| *** harlowja_at_home has quit IRC | 05:05 | |
| *** zer0c00l has quit IRC | 05:10 | |
| *** zer0c00l has joined #openstack-ironic | 05:11 | |
| *** spandhe has quit IRC | 05:12 | |
| mrda | Just wondering, has anyone here used Ironic to control an HP DL380 Gen3 server? (aka iLO 1.96) Can these beasts be tamed with IPMI/PXE and the agent_ipmi driver? | 05:17 |
| * mrda might add a few of these to his home lab if the collective wisdom suggests they'll work | 05:18 | |
| *** Sukhdev has joined #openstack-ironic | 05:26 | |
| *** mtanino has quit IRC | 05:31 | |
| *** baoli has joined #openstack-ironic | 05:32 | |
| *** baoli has quit IRC | 05:37 | |
| *** lazy_prince has quit IRC | 05:44 | |
| *** Guest33334 has quit IRC | 05:46 | |
| *** pcaruana has quit IRC | 05:49 | |
| *** mtanino has joined #openstack-ironic | 05:50 | |
| openstackgerrit | Tan Lin proposed openstack/ironic-specs: Support online upgrades https://review.openstack.org/299245 | 05:53 |
| *** lazy_prince has joined #openstack-ironic | 05:53 | |
| *** sivaramakrishna has joined #openstack-ironic | 05:54 | |
| *** sivaramakrishna is now known as Guest95270 | 05:54 | |
| openstackgerrit | Tan Lin proposed openstack/ironic: Make use of oslo-config-generator https://review.openstack.org/247331 | 05:55 |
| openstackgerrit | Debayan Ray proposed openstack/ironic: Note on ilo firmware update swift url scheme https://review.openstack.org/299756 | 05:56 |
| *** e0ne has joined #openstack-ironic | 05:56 | |
| *** Sukhdev has quit IRC | 05:57 | |
| *** spandhe has joined #openstack-ironic | 05:58 | |
| *** mtanino has quit IRC | 06:03 | |
| *** jaybeale has joined #openstack-ironic | 06:07 | |
| *** jaybeale has quit IRC | 06:10 | |
| *** suro-patz has joined #openstack-ironic | 06:12 | |
| *** lazy_prince has quit IRC | 06:15 | |
| *** Guest95270 has quit IRC | 06:16 | |
| *** daemontool has joined #openstack-ironic | 06:22 | |
| *** e0ne has quit IRC | 06:24 | |
| *** lazy_prince has joined #openstack-ironic | 06:24 | |
| *** sivarama- has joined #openstack-ironic | 06:24 | |
| *** spandhe has quit IRC | 06:25 | |
| *** stevebaker has joined #openstack-ironic | 06:34 | |
| *** deray has joined #openstack-ironic | 06:37 | |
| *** Haomeng has joined #openstack-ironic | 06:37 | |
| *** deray has quit IRC | 06:40 | |
| *** JieLi has joined #openstack-ironic | 06:41 | |
| *** deray has joined #openstack-ironic | 06:44 | |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add test to verify ironic multitenancy https://review.openstack.org/269157 | 06:44 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Allow to build user image with DIB https://review.openstack.org/256363 | 06:44 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add Link-Local-Connection info to ironic port https://review.openstack.org/256365 | 06:45 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Added operator documentation for ironic portgroups https://review.openstack.org/228496 | 06:45 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: refactor ironic enroll-node code https://review.openstack.org/256364 | 06:45 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add configure_provision_network function https://review.openstack.org/256367 | 06:45 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Update Ironic VM network connection https://review.openstack.org/256366 | 06:45 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: DO NOT REVIEW https://review.openstack.org/296432 | 06:45 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Update the deploy drivers with network flipping logic https://review.openstack.org/213262 | 06:45 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: WIP: add network drivers https://review.openstack.org/285852 | 06:45 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add Ironic/Neutron integration documentation https://review.openstack.org/258596 | 06:45 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Allow to use NETWORK_DRIVERS in devstack https://review.openstack.org/293520 | 06:45 |
| *** deray has quit IRC | 06:47 | |
| *** hoangcx has quit IRC | 06:47 | |
| *** hoangcx has joined #openstack-ironic | 06:48 | |
| *** deray has joined #openstack-ironic | 06:48 | |
| *** deray has quit IRC | 06:49 | |
| *** tesseract has joined #openstack-ironic | 06:49 | |
| *** tesseract is now known as Guest11037 | 06:49 | |
| *** baoli has joined #openstack-ironic | 06:50 | |
| *** deray has joined #openstack-ironic | 06:51 | |
| deray | Hello and g'morning Ironicers! | 06:54 |
| Haomeng | deray: morning:) | 06:54 |
| *** baoli has quit IRC | 06:55 | |
| deray | Haomeng, o/ | 06:55 |
| Haomeng | :) | 06:55 |
| *** moshele has quit IRC | 07:00 | |
| *** moshele has joined #openstack-ironic | 07:02 | |
| *** daemontool has quit IRC | 07:04 | |
| openstackgerrit | Haomeng,Wang proposed openstack/ironic: make sure conf is loaded first than "@periodics.periodic()" https://review.openstack.org/299781 | 07:08 |
| openstackgerrit | Haomeng,Wang proposed openstack/ironic: WIP:make sure conf is loaded first than "@periodics.periodic()" https://review.openstack.org/299781 | 07:08 |
| *** zer0c00l has quit IRC | 07:08 | |
| *** suro-patz has quit IRC | 07:11 | |
| *** Nisha has joined #openstack-ironic | 07:15 | |
| *** e0ne has joined #openstack-ironic | 07:15 | |
| *** e0ne has quit IRC | 07:18 | |
| openstackgerrit | Haomeng,Wang proposed openstack/ironic: WIP:make sure conf is loaded first than "@periodics.periodic()" https://review.openstack.org/299781 | 07:21 |
| openstackgerrit | Haomeng,Wang proposed openstack/ironic: WIP:make sure conf is loaded first than "@periodics.periodic()" https://review.openstack.org/299781 | 07:29 |
| *** lintan_ has quit IRC | 07:31 | |
| openstackgerrit | Haomeng,Wang proposed openstack/ironic: WIP:make sure conf is loaded first than "@periodics.periodic()" https://review.openstack.org/299781 | 07:32 |
| *** wuhg has joined #openstack-ironic | 07:38 | |
| *** jtomasek has joined #openstack-ironic | 07:40 | |
| *** pcaruana has joined #openstack-ironic | 07:41 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DO NOT REVIEW https://review.openstack.org/296432 | 07:46 |
| *** moshele has quit IRC | 07:48 | |
| *** moshele has joined #openstack-ironic | 07:49 | |
| *** ohamada has joined #openstack-ironic | 07:49 | |
| *** mgoddard has joined #openstack-ironic | 07:50 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP Tune interval for node provision state check https://review.openstack.org/299795 | 07:53 |
| *** jistr has joined #openstack-ironic | 07:53 | |
| *** lintan has joined #openstack-ironic | 07:53 | |
| *** mbound has joined #openstack-ironic | 07:59 | |
| *** jcoufal has joined #openstack-ironic | 08:15 | |
| *** ifarkas has joined #openstack-ironic | 08:17 | |
| *** ndipanov has joined #openstack-ironic | 08:20 | |
| *** kromanenko has joined #openstack-ironic | 08:25 | |
| openstackgerrit | Merged openstack/ironic-inspector: Use keystoneauth for Ironic and Swift clients https://review.openstack.org/286510 | 08:25 |
| *** e0ne has joined #openstack-ironic | 08:28 | |
| *** e0ne has quit IRC | 08:29 | |
| *** ndipanov has quit IRC | 08:30 | |
| *** achanda has quit IRC | 08:30 | |
| *** achanda has joined #openstack-ironic | 08:34 | |
| alineb | morning all! | 08:34 |
| *** e0ne has joined #openstack-ironic | 08:34 | |
| *** e0ne has quit IRC | 08:35 | |
| *** deray has quit IRC | 08:38 | |
| *** mbound has quit IRC | 08:38 | |
| *** daemontool has joined #openstack-ironic | 08:41 | |
| *** hoangcx has quit IRC | 08:47 | |
| *** daemontool has quit IRC | 08:48 | |
| *** achanda has quit IRC | 08:48 | |
| *** achanda has joined #openstack-ironic | 08:49 | |
| *** ChubYann has quit IRC | 08:50 | |
| *** baoli has joined #openstack-ironic | 08:51 | |
| *** achanda has quit IRC | 08:52 | |
| *** baoli has quit IRC | 08:55 | |
| *** hoangcx has joined #openstack-ironic | 08:56 | |
| *** pece has joined #openstack-ironic | 08:56 | |
| *** daemontool has joined #openstack-ironic | 08:58 | |
| *** achanda has joined #openstack-ironic | 08:59 | |
| *** mgould has joined #openstack-ironic | 09:05 | |
| openstackgerrit | Hieu LE proposed openstack/ironic: Fix typo in devstack script https://review.openstack.org/299812 | 09:05 |
| *** deray has joined #openstack-ironic | 09:08 | |
| *** dtantsur|afk is now known as dtantsur | 09:09 | |
| dtantsur | Morning Ironic | 09:09 |
| deray | g'morning dtantsur :) | 09:11 |
| *** derekh has joined #openstack-ironic | 09:19 | |
| mgould | morning Ironic | 09:21 |
| aarefiev | morning all! | 09:22 |
| mgould | morning aarefiev dtantsur deray | 09:23 |
| dtantsur | sambetts|afk, when you're no longer afk, could you please take a look at https://review.openstack.org/267637 | 09:23 |
| dtantsur | hey alineb, mgould, aarefiev, deray :) | 09:24 |
| aarefiev | dtantsur: morning, https://review.openstack.org/#/c/299821/ not sure it will work, I'm trying to use devstack-virtual-ironic builder | 09:24 |
| aarefiev | mgould: morning | 09:24 |
| deray | mgould, aarefiev o/ | 09:24 |
| aarefiev | deray o/ | 09:25 |
| *** electrofelix has joined #openstack-ironic | 09:26 | |
| *** achanda has quit IRC | 09:26 | |
| dtantsur | aarefiev, me neither, maybe it's worth pinging jroll for review | 09:29 |
| *** mkovacik_ has quit IRC | 09:29 | |
| *** sambetts|afk is now known as sambetts | 09:29 | |
| sambetts | dtantsur: sure :) | 09:29 |
| aarefiev | dtantsur: ok, thanks | 09:30 |
| aarefiev | sambetts: morning | 09:30 |
| sambetts | o/ aarefiev | 09:30 |
| *** e0ne has joined #openstack-ironic | 09:30 | |
| vdrok | morning ironic, deray, Haomeng, dtantsur, mgould, aarefiev and sambetts | 09:31 |
| aarefiev | vdrok: morning | 09:31 |
| dtantsur | o/ | 09:32 |
| mgould | morning sambetts vdrok | 09:33 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add test to verify ironic multitenancy https://review.openstack.org/269157 | 09:33 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DO NOT REVIEW https://review.openstack.org/296432 | 09:33 |
| deray | vdrok, o/ :) | 09:34 |
| sambetts | aarefiev: I don't think that job you've added will work because the devstack-virtual-ironic builder is setup to run all the ironic tempest tests, what we may need to do is make the DEVSTACK_GATE_TEMPEST_REGEX overideable in the builder, so that the devstack-virtual-ironic builder can be used for both inspector and ironic | 09:35 |
| *** e0ne has quit IRC | 09:37 | |
| aarefiev | sambetts: why export DEVSTACK_GATE_TEMPEST_REGEX doesn't override ? | 09:38 |
| *** mgould has quit IRC | 09:40 | |
| *** e0ne has joined #openstack-ironic | 09:42 | |
| sambetts | aarefiev: I don;t think thats how the job builders work, if you look at the devstack-virtual-ironic builder, its just a wrapper around a shell script that the values passed into it override, so defining your own shell builder it will first run the whole devstack-virtual-ironic script then run your shell script resulting in a devstack being setup and all the ironic tempest tests running then your | 09:43 |
| sambetts | script will try to setup antoher devstack enironoment with inspector to run the inspector tempest tests | 09:43 |
| *** daemontool has quit IRC | 09:43 | |
| *** daemontool has joined #openstack-ironic | 09:44 | |
| *** mgould has joined #openstack-ironic | 09:45 | |
| *** ndipanov has joined #openstack-ironic | 09:45 | |
| *** _degorenko|afk is now known as degorenko | 09:47 | |
| aarefiev | sambetts: heh, I hoped it just runs builders, so we need separate builder I guess | 09:49 |
| aarefiev | sambetts: thanks for help | 09:50 |
| sambetts | aarefiev: See my comments for an idea of how to make sure we don't end up duplicating code | 09:52 |
| aarefiev | sambetts: ok, thanks | 09:54 |
| *** electrofelix has quit IRC | 10:08 | |
| *** electrofelix has joined #openstack-ironic | 10:09 | |
| *** electrofelix has quit IRC | 10:13 | |
| *** electrofelix has joined #openstack-ironic | 10:13 | |
| *** mkovacik_ has joined #openstack-ironic | 10:15 | |
| *** e0ne has quit IRC | 10:15 | |
| *** JieLi has quit IRC | 10:15 | |
| *** e0ne has joined #openstack-ironic | 10:17 | |
| *** hoangcx has quit IRC | 10:18 | |
| *** e0ne has quit IRC | 10:20 | |
| *** e0ne has joined #openstack-ironic | 10:21 | |
| *** e0ne has quit IRC | 10:22 | |
| *** e0ne has joined #openstack-ironic | 10:23 | |
| *** e0ne has quit IRC | 10:24 | |
| sambetts | dtantsur: I've left some comments on that reapply patch, WDYT? | 10:24 |
| *** Nisha has quit IRC | 10:25 | |
| dtantsur | sambetts, as to "why post", maybe we should use PUT dunno.. | 10:25 |
| sambetts | dtantsur: well it expecting an empty body so why not GET? | 10:26 |
| dtantsur | sambetts, oh god no | 10:26 |
| dtantsur | 1. GET does not modify anything, 2. GET does not return 202 | 10:26 |
| dtantsur | I'm not sure what is wrong about using POST with an empty body tbh | 10:27 |
| dtantsur | finally, one day we may actually provide new data via API | 10:27 |
| dtantsur | this may end up as a result of discussion with fuel folks, cause they run their kind of "inspection" periodically | 10:28 |
| dtantsur | sambetts, mkovacik_ ^^ | 10:28 |
| sambetts | but I would expect that to happen on PUT to /data | 10:28 |
| dtantsur | PUT to /data may be confusing, as we'll not only save new data, we'll actually process it | 10:28 |
| sambetts | but to reapply wouldn't make sense because its new data | 10:29 |
| *** electrofelix has quit IRC | 10:31 | |
| *** electrofelix has joined #openstack-ironic | 10:31 | |
| mkovacik_ | sambetts, dtantsur I think the issue is more complex: we have the continue end point we re posting to, that's not very restful in first place; instead we should have an endpoint /<uuid>/data that posting/putting to would cause applying/reapplying introspection | 10:32 |
| mkovacik_ | not sure how to address this now | 10:33 |
| * mkovacik_ 's 2C | 10:33 | |
| dtantsur | the /v1/continue endpoint is special cause it does not require authentication | 10:34 |
| aarefiev | imo PUT is idempotent, and reapplying could change properties, so post would be better | 10:34 |
| dtantsur | that's why we can't mix it with the endpoints we introduce now | 10:35 |
| dtantsur | aarefiev++ | 10:35 |
| sambetts | I like the idea of only having the /data endpoint and making it so POSTing a body to it replaces the data and reapplies, and POSTing an empty body would reapply the existing data? Unless I'm missing something ? | 10:37 |
| mkovacik_ | dtantsur, /continue can have auth provided the same way we push the callback url to the ramdisk, so that shouldn't be an issue | 10:38 |
| mkovacik_ | sambetts, yeah, that was my idea, post + data -> apply, put -> reapply | 10:38 |
| dtantsur | mkovacik_, except for "oh god now" issue #2 | 10:38 |
| dtantsur | * no | 10:38 |
| sambetts | sending auth data over the wire is not a good plan :-P | 10:39 |
| dtantsur | this | 10:39 |
| dtantsur | I don't care much if we end with or without /apply postfix tbh | 10:40 |
| *** caiobo has quit IRC | 10:40 | |
| dtantsur | also, lunch time, brbr | 10:40 |
| dtantsur | brb | 10:40 |
| dtantsur | damn English, w u so hard? | 10:41 |
| sambetts | :-P | 10:41 |
| sambetts | What about if it was designed like this: POST + data to /data is unauthed and acts just like /continue does now, because thats the only actual creation action, PUT + data = replace existing data and reapply, PUT + empty body = reapply existing data ?? | 10:42 |
| mkovacik_ | dtantsur, there's the option of baking-in the certs in the ramdisk but something tells me that'd be a "oh god no" #3 ;) | 10:43 |
| sambetts | mkovacik_: we've discussed that alot in Ironic in regards to IPA to Ironic authentication but it tends to lead down a rabbit hole | 10:44 |
| mkovacik_ | sambetts,+1 on the endpoint | 10:44 |
| mkovacik_ | sambetts, and what's the preferred way in ironic? | 10:44 |
| mkovacik_ | w/r the auth | 10:45 |
| sambetts | mkovacik_: there isn't, IPA is unauthed still AFAIK | 10:45 |
| mkovacik_ | sambetts, dtantsur, OK, then how about POST /uuid/data no auth; one shot only; all other return 409 | 10:48 |
| mkovacik_ | PUT /uuid/data -> reapply? | 10:48 |
| sambetts | mkovacik_: thats what I'm suggesting | 10:49 |
| mkovacik_ | PUT /uuid/data requiring auth? | 10:49 |
| mkovacik_ | sambetts, ah, OK | 10:49 |
| mkovacik_ | sambetts, then +1 :D | 10:49 |
| sambetts | :) | 10:49 |
| mkovacik_ | sambetts, shouldn't that come as a separate pull request? | 10:50 |
| *** mbound has joined #openstack-ironic | 10:50 | |
| sambetts | my concern is that all this affects the API, and the reapply patch would need rebasing on top of it so it would delay that patch if we decided to go that route | 10:51 |
| *** baoli has joined #openstack-ironic | 10:52 | |
| mkovacik_ | sambetts, we could do it other way, merge this version of reapply then have a RESTfulness induced refactoring patch? | 10:53 |
| mkovacik_ | that would deprecate /continue | 10:53 |
| sambetts | mkovacik_: so change this patch to implement reapply as PUT to /data ? | 10:54 |
| mkovacik_ | sambetts, yeah, makes sense, was that what you've been suggesting already? ;) | 10:55 |
| sambetts | we could do it if we change it like that, but if we merge it as it is now we'll have to have a deprecation for the /reapply endpoint too | 10:55 |
| mkovacik_ | sambetts, valid point | 10:56 |
| mkovacik_ | let's make it PUT@/uuid/data | 10:56 |
| mkovacik_ | dtantsur, wdyt ^ | 10:56 |
| *** baoli has quit IRC | 10:57 | |
| sambetts | I think we should wait for dtantsur to get back, before we make any final decisions IRT the API, another problem I've just realised with the moving /continue to POST/uuid/data is that the ramdisk doesn't have the UUID at the time it sends the data so we couldn't do it anyway | 10:57 |
| openstackgerrit | Sam Betts proposed openstack/ironic-python-agent: Enable branch tagging during tinyipa build https://review.openstack.org/299529 | 10:59 |
| mkovacik_ | sambetts, ouch, you're right, sounds like /continue provides two things actually: registry and introspection data processing | 10:59 |
| mkovacik_ | sambetts, maybe that could be split somehow | 10:59 |
| sambetts | mkovacik_: yeah, I hope to bring up at the summit to split those up | 10:59 |
| aarefiev | sambetts, mkovacik_: what does the actual problem you are trying to solve? | 11:00 |
| mkovacik_ | aarefiev, RESTfulness of the endpoint POST@/uuid/data/apply | 11:00 |
| mkovacik_ | aarefiev, it got us to discuss the RESTfulness of the /continue endpoint | 11:01 |
| mkovacik_ | and back to | 11:01 |
| mkovacik_ | let's make it PUT@/uuid/data to reapply | 11:01 |
| mkovacik_ | and possibly refactor POST@/continue | 11:02 |
| mkovacik_ | to | 11:02 |
| aarefiev | mkovacik_: ok, whats wrong with current approach? | 11:02 |
| * sambetts isn't a fan of introducing a new /reapply API entry point | 11:02 | |
| aarefiev | why | 11:03 |
| mkovacik_ | POST@/register -> uuid + POST{data}@/uuid/data to process | 11:03 |
| *** moshele has quit IRC | 11:03 | |
| *** moshele has joined #openstack-ironic | 11:03 | |
| sambetts | aarefiev: because right now is a POST entry point, thats only ever expecting an empty body and that seems wrong to me | 11:03 |
| mkovacik_ | aarefiev, sambetts it's wrong even conceptually | 11:04 |
| mkovacik_ | should be verb + data/ | 11:04 |
| mkovacik_ | aarefiev, I agree with sambetts to make it PUT@/uuid/data | 11:04 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add user and project domains to ironic context https://review.openstack.org/295371 | 11:05 |
| sambetts | where providing a body == reapply with new data from body, and an empty body == reapply with existing data | 11:06 |
| aarefiev | dunno, put looks wrong here | 11:06 |
| mkovacik_ | PUT is conceptually update | 11:07 |
| mkovacik_ | that's what've doing with the data | 11:07 |
| mkovacik_ | *what we're doing | 11:07 |
| aarefiev | yeah, but it's possible that there will be diff result, it's wrong for put | 11:08 |
| mkovacik_ | aarefiev, hence the split of /continue to post@/registry -> uuid and post@/uuid/data | 11:08 |
| mkovacik_ | aarefiev, if you update input what's wrong on having different output? | 11:09 |
| mkovacik_ | PUT with empty body and PUT with different data that is | 11:09 |
| *** deray has quit IRC | 11:11 | |
| *** mbound has quit IRC | 11:13 | |
| *** mbound has joined #openstack-ironic | 11:13 | |
| *** mbound has quit IRC | 11:15 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add user and project domains to ironic context https://review.openstack.org/295371 | 11:16 |
| *** e0ne has joined #openstack-ironic | 11:17 | |
| *** e0ne has quit IRC | 11:18 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add test to verify ironic multitenancy https://review.openstack.org/269157 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Allow to build user image with DIB https://review.openstack.org/256363 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Link-Local-Connection info to ironic port https://review.openstack.org/256365 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Added operator documentation for ironic portgroups https://review.openstack.org/228496 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: refactor ironic enroll-node code https://review.openstack.org/256364 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add configure_provision_network function https://review.openstack.org/256367 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update Ironic VM network connection https://review.openstack.org/256366 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DO NOT REVIEW https://review.openstack.org/296432 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update the deploy drivers with network flipping logic https://review.openstack.org/213262 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add network drivers https://review.openstack.org/285852 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Ironic/Neutron integration documentation https://review.openstack.org/258596 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Allow to use NETWORK_DRIVERS in devstack https://review.openstack.org/293520 | 11:19 |
| dtantsur | mkovacik_, sambetts, what if we issue 2 PUT requests in a row? will it work? | 11:22 |
| dtantsur | if answer is not, we should use POST | 11:22 |
| *** jlvillal_ has joined #openstack-ironic | 11:22 | |
| *** adreznec has quit IRC | 11:22 | |
| *** jlvillal has quit IRC | 11:22 | |
| *** bigjools has quit IRC | 11:22 | |
| *** dhellmann has quit IRC | 11:22 | |
| sambetts | dtantsur: not sure what you mean | 11:22 |
| *** dhellmann_ has joined #openstack-ironic | 11:22 | |
| dtantsur | I issue double PUT request to /uuid/data | 11:23 |
| dtantsur | will it work the same as issuing only one request? | 11:23 |
| * dtantsur is not sure without looking at the patch | 11:23 | |
| *** adreznec has joined #openstack-ironic | 11:23 | |
| *** e0ne has joined #openstack-ironic | 11:23 | |
| sambetts | I don't think 2 PUTs would be any different to issing 2 POSTs | 11:23 |
| *** jlvillal_ is now known as jlvillal | 11:23 | |
| dtantsur | PUT is idempotent, POST is not | 11:23 |
| *** bigjools has joined #openstack-ironic | 11:24 | |
| *** bigjools has quit IRC | 11:24 | |
| *** bigjools has joined #openstack-ironic | 11:24 | |
| dtantsur | so if we don't maintain idempotency, we should use POST | 11:24 |
| *** jlvillal is now known as Guest87578 | 11:24 | |
| dtantsur | that's the most essential difference between these 2 | 11:24 |
| dtantsur | having or not having a body is not related to the choice at all | 11:24 |
| mkovacik_ | dtantsur, that should work, the (_)reapply functions are already idempotent | 11:25 |
| dtantsur | ok, that I'm fine with PUT to /introspection/<UUID>/data | 11:25 |
| sambetts | if you don't change the rules inbetween the 2 PUT requests then they should result in the same result | 11:25 |
| *** e0ne has quit IRC | 11:26 | |
| *** dhellmann_ is now known as dhellmann | 11:26 | |
| sambetts | but if you actively change the rules then you expect the result to be different right | 11:26 |
| dtantsur | fair | 11:26 |
| mkovacik_ | sambetts, dtantsur, should we add the put{body}@/uuid/data processing in this patch? | 11:28 |
| dtantsur | sambetts, mkovacik_, wait, reapply fails when it can't acquire a lock | 11:28 |
| dtantsur | so 2 PUT's in a row won't work, 2nd will fail with HTTP 409 | 11:29 |
| mkovacik_ | dtantsur, 2 parallel puts, one fails | 11:29 |
| dtantsur | mkovacik_, then it should be POST | 11:29 |
| mkovacik_ | 2 consecutive puts all succeed | 11:29 |
| mkovacik_ | no? | 11:29 |
| dtantsur | no, if the 1st PUT still holds the lock | 11:31 |
| dtantsur | the thing about idempotency is that idempotent requests can be retried. this one is dangerous to retry | 11:32 |
| dtantsur | oh well, and nobody guarantees that processing hooks won't have side effect that will change the results | 11:33 |
| dtantsur | actually we have at least one processing hook with such side effects: raid_device (or how is it?) | 11:33 |
| dtantsur | its execution changes based on whether it's executed for the 1st or the 2nd time | 11:33 |
| dtantsur | mkovacik_, sambetts, for this reasons ^^^ O | 11:34 |
| dtantsur | ...I'd prefer POST | 11:34 |
| aarefiev | dtantsur : ++, there are a lot of ifs here for use simple PUT | 11:35 |
| *** e0ne has joined #openstack-ironic | 11:35 | |
| mkovacik_ | dtantsur, fair about side effects of plugins but lock acquiring per se shouldn't prevent PUT usage | 11:35 |
| dtantsur | well, right. if we wait for a lock - it shouldn't. however, we fail right away | 11:36 |
| dtantsur | ...if another lock is acquired | 11:36 |
| mkovacik_ | dtantsur, you're still saying that lock (acquire) usage (failure) should prevent using PUT | 11:38 |
| dtantsur | well, yes | 11:38 |
| dtantsur | cause it's not idempotent (at least how I understand it) | 11:38 |
| * dtantsur finds it funny to argue over IRC with a guy who is 2 meters away :D | 11:38 | |
| mkovacik_ | but idempotence isn't the same as mutual exclusivity, or I'm missing something? | 11:39 |
| jroll | ohai | 11:39 |
| mkovacik_ | yeah :D | 11:39 |
| dtantsur | hey jroll | 11:39 |
| sambetts | o/ jroll | 11:39 |
| jroll | dtantsur: just means you can also throw things :) | 11:39 |
| jroll | aarefiev: I reviewed your inspector tempest job thing | 11:39 |
| dtantsur | jroll++ | 11:39 |
| dtantsur | lol, this made mkovacik_ run away, so now I've won \o/ | 11:40 |
| aarefiev | jroll: thanks, sambetts helps me | 11:40 |
| sambetts | POST @ uuid/data would still be better than a new entry point imo | 11:40 |
| dtantsur | I'm fine with POST @ uuid/data | 11:41 |
| jroll | lol | 11:41 |
| *** e0ne has quit IRC | 11:41 | |
| * dtantsur suddenly realizes that the summit is less than in a month, and he definitely needs to start preparing his talk | 11:42 | |
| aarefiev | dtantsur, jroll: what about usual nv job? | 11:42 |
| jroll | aarefiev: well, experimental would be better to not waste gate resources until the patch lands | 11:43 |
| jroll | unless you wait to land this after the tests merge | 11:44 |
| jroll | dtantsur: if you start before your flight you're doing it wrong ;) | 11:44 |
| aarefiev | jroll: ahh ok, no I would prefer landed job first | 11:44 |
| dtantsur | lol | 11:44 |
| dtantsur | well, actually it's a nice idea to spend time on a flight | 11:44 |
| dtantsur | aarefiev, btw, was the discovery talk accepted? | 11:45 |
| aarefiev | dtantsur: no ( , but I'll be attending summit | 11:46 |
| TheJulia | good morning everyone | 11:47 |
| dtantsur | that's sad, then I'll cover it briefly in my talk | 11:47 |
| aarefiev | morning TheJulia | 11:47 |
| dtantsur | anyway will be great to see you | 11:47 |
| dtantsur | TheJulia, morning | 11:47 |
| aarefiev | dtantsur: cool, me too | 11:47 |
| *** thrash|g0ne is now known as thrash | 11:48 | |
| mgould | morning TheJulia | 11:51 |
| sambetts | aarefiev: I understand your response to my comment on the job patch | 11:52 |
| sambetts | I don't understand* | 11:52 |
| aarefiev | sambetts: maybe I don't understand your question:) | 11:53 |
| aarefiev | why do we need to change regex there? | 11:53 |
| sambetts | aarefiev: because if the branch thats running is mitaka onwards then DEVSTACK_GATE_TEMPEST_ALL_PLUGINS = 1 | 11:54 |
| aarefiev | sambetts: but AFAIU DEVSTACK_GATE_TEMPEST_ALL_PLUGINS=1 is used for stable branches, no? | 11:56 |
| sambetts | aarefiev: the opposite, the if statement is $ZUUL_BRANCH != "stable/kilo and $ZUUL_BRANCH != "stable/liberty" | 11:57 |
| aarefiev | sambetts: yeah, checked, looks like I'm wrong | 11:57 |
| aarefiev | sambetts: thanks | 11:57 |
| sambetts | :) | 11:57 |
| *** e0ne has joined #openstack-ironic | 11:59 | |
| *** e0ne has quit IRC | 12:00 | |
| jroll | aarefiev: oh yeah, don't forget to exclude this test in stable branches (for now, anyway) | 12:00 |
| dtantsur | yeah. we'll probably backport tempest plugin if we find it working, but for now it should be disabled | 12:00 |
| aarefiev | jroll: ok, and how to do that :) | 12:01 |
| *** moshele has quit IRC | 12:01 | |
| dtantsur | aarefiev, e.g. https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L2523-L2524 | 12:01 |
| jroll | ^ what he said | 12:02 |
| aarefiev | jroll, dtantsur: thanks | 12:02 |
| jroll | dtantsur: what we actually need to do is have the plugin from master installed in the venv, when running against stable branches | 12:02 |
| jroll | though, need to think about how that affects new tests I guess | 12:03 |
| * jroll something something microversions >.> | 12:03 | |
| dtantsur | microversion anything \o/ | 12:04 |
| dtantsur | well, I don't see anything wrong in backporting tests, if they don't require code changes, so dunno | 12:05 |
| *** trown|outtypewww is now known as trown | 12:05 | |
| jroll | well, this lets us get rid of the regex hacks in project-config, and drop ironic config/tests from tempest now | 12:07 |
| openstackgerrit | Julia Kreger proposed openstack/python-ironicclient: Client addition for Active Node Creation verb adopt https://review.openstack.org/275767 | 12:08 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Active Node Creation via adopt state https://review.openstack.org/275766 | 12:10 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent: Fix incorrect formatting in the iSCSI extension https://review.openstack.org/299887 | 12:11 |
| *** e0ne has joined #openstack-ironic | 12:11 | |
| *** jjohnson2 has joined #openstack-ironic | 12:11 | |
| *** dprince has joined #openstack-ironic | 12:12 | |
| mkovacik_ | dtantsur, sambetts, aarefiev if we use post@/uuid/data we'll be deprecating it later when refactoring post@/continue into post@/registry->uuid, post@/uuid/data but otherwise OK | 12:12 |
| *** e0ne has quit IRC | 12:13 | |
| dtantsur | I'm not sure I'm buying in this refactoring, so lets not think about it right now | 12:13 |
| sambetts | refactoring continue needs a lot more disucssion, so I think we're ok with that right now | 12:14 |
| sambetts | ultimatly the nicest solution would be that IPA could authenticate itself, and hit the same POST uuid/data endpoint that we would | 12:15 |
| sambetts | but ramdisk authentication is a whole other topic | 12:16 |
| dtantsur | oh yeah | 12:16 |
| dtantsur | interesting, long and complex topic | 12:16 |
| *** degorenko has left #openstack-ironic | 12:17 | |
| *** moshele has joined #openstack-ironic | 12:19 | |
| vmud213 | morning ironicers | 12:20 |
| vmud213 | jroll: regarding the patch https://review.openstack.org/#/c/299450 | 12:21 |
| vmud213 | i am just trying to understand what would be the best option in this case. | 12:22 |
| jroll | vmud213: looking | 12:22 |
| vmud213 | thanks | 12:23 |
| jroll | vmud213: so, again, you're right, but semantically I still think this should be a 404 | 12:25 |
| jroll | I agree the exception logging is annoying, but I'd rather our api be right | 12:25 |
| vmud213 | IMO, the change introduced will only log a message whereas in the previous case it logs and raises exception | 12:26 |
| vmud213 | as far as the functionality is concerned, it is intact.. | 12:26 |
| *** baoli has joined #openstack-ironic | 12:27 | |
| vmud213 | in either way(with or without code change) IPA retries for the lookup | 12:27 |
| *** baoli has quit IRC | 12:27 | |
| jroll | functionality is changing, you're now returning a 200 (success) instead of 404 (the node was not found) | 12:27 |
| *** baoli has joined #openstack-ironic | 12:27 | |
| jroll | (and really, maybe an empty set of interfaces should be a 400, hrm | 12:28 |
| jroll | ) | 12:28 |
| vmud213 | ok.. | 12:28 |
| jroll | maybe other reviewers think I'm wrong, though, I am not the only one with opinions here :) | 12:29 |
| *** afaranha has joined #openstack-ironic | 12:30 | |
| vmud213 | i agree...May be it makes sense to add a case in IPA to handle new status code? Your opinion ^^^ | 12:31 |
| vmud213 | and may be sending that status from conductor when the interfaces are null | 12:32 |
| vmud213 | ok..404:not found makes sense to me.. | 12:33 |
| *** baoli_ has joined #openstack-ironic | 12:34 | |
| *** raildo-afk is now known as raildo | 12:36 | |
| *** baoli has quit IRC | 12:37 | |
| *** daemontool_ has joined #openstack-ironic | 12:39 | |
| mkovacik_ | sambetts, dtantsur aarefiev I'm just about to rewrite the endpoint code to POST@/uuid/data to reapply the introspection, any last comments before I do? | 12:39 |
| * mkovacik_ would like to avoid rewriting it later ;) | 12:39 | |
| dtantsur | nothing from me in addition to what's on the spec | 12:39 |
| *** rbudden has joined #openstack-ironic | 12:40 | |
| sambetts | only the other comments I left in regards to the stored data and reruns of it leading to different results etc | 12:42 |
| *** daemontool has quit IRC | 12:42 | |
| mkovacik_ | sambetts, OK, I'll address that in gerrit | 12:48 |
| *** mbound has joined #openstack-ironic | 12:48 | |
| sambetts | :) | 12:48 |
| *** mbound has quit IRC | 12:49 | |
| *** daemontool__ has joined #openstack-ironic | 12:49 | |
| *** mbound has joined #openstack-ironic | 12:49 | |
| *** e0ne has joined #openstack-ironic | 12:50 | |
| openstackgerrit | Moshe Levi proposed openstack/ironic: Adding InfiniBand Support https://review.openstack.org/264263 | 12:51 |
| openstackgerrit | Merged openstack/ironic: Note on ilo firmware update swift url scheme https://review.openstack.org/299756 | 12:51 |
| *** e0ne has quit IRC | 12:51 | |
| *** mbound has quit IRC | 12:51 | |
| *** daemontool_ has quit IRC | 12:52 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Tune interval for node provision state check https://review.openstack.org/299795 | 12:54 |
| *** daemontool__ has quit IRC | 12:55 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: [PROOF OF CONCEPT] Ansible deploy driver https://review.openstack.org/238183 | 12:56 |
| *** penick has quit IRC | 12:57 | |
| *** thiagop has joined #openstack-ironic | 12:58 | |
| thiagop | Good morning, Ironic | 12:58 |
| sambetts | morning thiagop | 12:58 |
| *** links has quit IRC | 12:58 | |
| thiagop | sambetts: o/ | 12:59 |
| *** daemontool__ has joined #openstack-ironic | 13:00 | |
| *** daemontool__ is now known as daemontool | 13:00 | |
| *** achanda has joined #openstack-ironic | 13:00 | |
| *** Goneri has joined #openstack-ironic | 13:01 | |
| *** yolanda has joined #openstack-ironic | 13:05 | |
| *** achanda has quit IRC | 13:06 | |
| mkovacik_ | sambetts, dtantsur I'm still fighting about the difference between post(body)@/uuid/data to update the ramdisk input to reapply introspection; post == data update is my issue here; you cool with that? | 13:07 |
| openstackgerrit | Merged openstack/ironic: Clean up test node post data https://review.openstack.org/297248 | 13:08 |
| openstackgerrit | Julia Kreger proposed openstack/ironic-specs: Boot from Volume - Reference Drivers https://review.openstack.org/294995 | 13:08 |
| sambetts | mkovacik_: yeah thats ok :) | 13:08 |
| sambetts | dtantsur: agree? ^ | 13:09 |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add tests for testing node-delete command https://review.openstack.org/251458 | 13:10 |
| mkovacik_ | you know cause if we had <uuid>/input <uuid>/result might make more sense ;) | 13:11 |
| mkovacik_ | dtantsur, sambetts ^ | 13:11 |
| dtantsur | I didn't get the question :) | 13:11 |
| mkovacik_ | cause the GET@/uuid/data currently gives you something else than the POST is going to store | 13:12 |
| dtantsur | well... yes. that | 13:12 |
| dtantsur | damn enter... | 13:12 |
| dtantsur | that's what caused us to introduce /apply, I guess | 13:12 |
| mkovacik_ | dtantsur, correct | 13:12 |
| *** penick has joined #openstack-ironic | 13:13 | |
| dtantsur | anyway, I don't want us to spend the whole cycle arguing about it | 13:13 |
| sambetts | :-P | 13:13 |
| dtantsur | I'm fine with whatever you guys propose | 13:13 |
| sambetts | this is the confusion I faced when I was reading through the commit message earlier, because we now store 2 types of data, raw and post processed, and the commit message kept saying Stored Data, and I was like :/ | 13:14 |
| dtantsur | I need some tea to make up my mind, brb :) | 13:14 |
| dtantsur | (ditto for mkovacik_ as he's my tea provider ^_^) | 13:15 |
| * sambetts thinks mkovacik_ and dtantsur are more british than he is | 13:15 | |
| dtantsur | lol | 13:15 |
| dtantsur | we drink green tea made by cold infusion | 13:15 |
| dtantsur | not so british, isn't it? | 13:15 |
| sambetts | oooo fancy :-P | 13:15 |
| sambetts | no, not so british | 13:15 |
| dtantsur | all thanks to mkovacik_, I'd be too lazy to bother | 13:15 |
| * dtantsur is really brb now | 13:15 | |
| *** baoli_ has quit IRC | 13:16 | |
| *** [1]cdearborn has joined #openstack-ironic | 13:19 | |
| *** mtanino has joined #openstack-ironic | 13:20 | |
| *** electrofelix has quit IRC | 13:21 | |
| *** electrofelix has joined #openstack-ironic | 13:21 | |
| *** electrofelix has quit IRC | 13:21 | |
| *** Goneri has quit IRC | 13:22 | |
| *** smoriya_ has quit IRC | 13:24 | |
| *** dprince has quit IRC | 13:28 | |
| sambetts | dtantsur: Congrats man I just saw your linkin update! | 13:29 |
| *** dprince has joined #openstack-ironic | 13:29 | |
| jroll | oh nice \o/ | 13:29 |
| *** e0ne has joined #openstack-ironic | 13:32 | |
| *** Goneri has joined #openstack-ironic | 13:37 | |
| NobodyCam | good morning Ironicers :) | 13:39 |
| *** ametts has joined #openstack-ironic | 13:39 | |
| sambetts | o/ NobodyCam | 13:39 |
| NobodyCam | :) | 13:40 |
| vdrok | morning jroll thiagop and NobodyCam :) | 13:40 |
| TheJulia | good morning | 13:40 |
| vdrok | and morning TheJulia | 13:40 |
| jroll | morning vdrok, NobodyCam, TheJulia :) | 13:41 |
| NobodyCam | morning dtantsur sambetts vdrok JayF TheJulia lucasagomes mgould devananda :) | 13:41 |
| NobodyCam | and ofc jroll :) | 13:41 |
| * NobodyCam needs coffee | 13:42 | |
| *** Nisha has joined #openstack-ironic | 13:42 | |
| Nisha | o/ | 13:47 |
| *** vmud213 has quit IRC | 13:47 | |
| *** ametts has quit IRC | 13:50 | |
| *** baoli has joined #openstack-ironic | 13:50 | |
| *** e0ne has quit IRC | 13:52 | |
| *** mtanino has quit IRC | 13:52 | |
| *** e0ne has joined #openstack-ironic | 13:54 | |
| *** ametts has joined #openstack-ironic | 13:54 | |
| *** ibravo has joined #openstack-ironic | 13:56 | |
| *** e0ne has quit IRC | 13:56 | |
| *** mgoddard_ has joined #openstack-ironic | 14:00 | |
| *** achanda has joined #openstack-ironic | 14:02 | |
| *** electrofelix has joined #openstack-ironic | 14:03 | |
| *** electrofelix has quit IRC | 14:03 | |
| *** mgoddard has quit IRC | 14:03 | |
| dtantsur | sambetts, thanks :) | 14:05 |
| dtantsur | morning NobodyCam | 14:05 |
| *** dprince has quit IRC | 14:06 | |
| *** dprince has joined #openstack-ironic | 14:07 | |
| *** keekz_ is now known as keekz | 14:07 | |
| *** penick has quit IRC | 14:07 | |
| *** achanda has quit IRC | 14:08 | |
| dtantsur | sambetts, mkovacik_, so, what are we agreed on re this API? I'm fine with anything that moves us forward | 14:11 |
| thiagop | morning vdrok TheJulia | 14:13 |
| thiagop | and NobodyCam | 14:14 |
| mkovacik_ | sambetts, dtantsur, i'm biased towards somehow distinguishing between incoming (ramdisk) data endpoint and processed data endpoint (just GET atm) | 14:15 |
| sambetts | perhaps a new API endpoint e.g. uuid/ramdisk_data that GETs the raw data, and POST either updates the data or reruns the existing data | 14:16 |
| dtantsur | I'm +1 on having an endpoint for getting the ramdisk data, but that's a separate RFE | 14:17 |
| dtantsur | would be good to make it clear that the POST API does not ONLY updates the data, but also runs all the processing | 14:17 |
| sambetts | dtantsur: I'm thinking this could add the POST part of that work and then a separate commit could add the GET part | 14:17 |
| dtantsur | jroll, do you think we can approve https://bugs.launchpad.net/ironic/+bug/1564195 ? we discussed it several times iirc | 14:17 |
| openstack | Launchpad bug 1564195 in Ironic "[RFE]Adopt oslo-config-generator" [Wishlist,In progress] - Assigned to Tan Lin (tan-lin-good) | 14:18 |
| jroll | dtantsur: yes please | 14:18 |
| dtantsur | sambetts, this is fine with me. maybe uuid/data/raw or uuid/data/unprocessed? | 14:18 |
| dtantsur | oh, rfe-approved is not an official tag, lemme fix | 14:18 |
| jroll | dtantsur: I asked for a separate rfe for that because it was lumped in with config centralization and didn't want to wait for the cross-project spec for this | 14:19 |
| jroll | it is O_o | 14:19 |
| jroll | I added that last week | 14:19 |
| dtantsur | well, I added it again right now :) | 14:19 |
| jroll | huh. | 14:19 |
| sambetts | dtantsur: moving the current /data API to /data/unprocessed would require deprecation right? | 14:19 |
| sambetts | I mean /data/processed | 14:20 |
| sambetts | or would we leave /data as it is ? | 14:20 |
| dtantsur | sambetts, the current /data is processed, I'd leave it where it was | 14:20 |
| dtantsur | cause that's the data most people should be interested in (at least that's my assumption) | 14:20 |
| mag009_ | morning all | 14:20 |
| dtantsur | morning mag009_ | 14:20 |
| sambetts | I wouldn't mind /data/raw | 14:21 |
| mag009_ | I've managed to get it working with ipxe | 14:21 |
| sambetts | and POSTing to /data/raw runs the processing and will update what you get from /data | 14:21 |
| mag009_ | but I have a problem with ipxe how do you get the enroll image deployed with ipxe ? | 14:21 |
| thiagop | morning mag009_ | 14:22 |
| mag009_ | the boot.ipxe is looking for the mac address if none is found then nothing else is booting my dhcp point to that ipxe is there something i'm missing | 14:24 |
| mkovacik_ | sambetts, dtantsur aarefiev I'm for separate ramdisk data, too; should it be uuid/data/raw or uuid/raw/data ? | 14:25 |
| NobodyCam | Nisha: have a minute to take a look at https://review.openstack.org/#/c/299573 | 14:26 |
| dtantsur | mkovacik_, uuid/data is our existing prefix, so uuid/data/raw IMO | 14:26 |
| sambetts | mkovacik_: data/raw, because its a type of dat | 14:27 |
| aarefiev | ++, /v1/introspection/<uuid>/data/raw | 14:27 |
| dtantsur | jroll, a philosophical question: what to do with bugs like https://bugs.launchpad.net/ironic/+bug/1563694 ? we've changed the behavior of old API versions, not we probably need to change it back | 14:27 |
| openstack | Launchpad bug 1563694 in Ironic "Can create/update node with name "" in any api version" [High,In progress] - Assigned to Zhenguo Niu (niu-zglinux) | 14:28 |
| dtantsur | both options are quite bad | 14:28 |
| Nisha | NobodyCam, ack | 14:28 |
| jroll | dtantsur: :/ | 14:28 |
| dtantsur | (well, I understand that impact is minimum, but still) | 14:28 |
| *** links has joined #openstack-ironic | 14:28 | |
| *** e0ne has joined #openstack-ironic | 14:29 | |
| *** e0ne has quit IRC | 14:29 | |
| mkovacik_ | sambetts, dtantsur, aarefiev cool, so just the minor naming thing: raw? ramdisk? incoming? recently I've found myself renaming "incoming" to "ramdisk" in the code because of a review | 14:30 |
| jroll | dtantsur: I'm not sure right now, and need to pay attention to a meeting, might be worth bugging people like sdague or api wg, to see what they think | 14:30 |
| dtantsur | well... I like raw or unprocessed. both versions of data come from ramdisk | 14:30 |
| openstackgerrit | Merged openstack/ironic: Fix typo in devstack script https://review.openstack.org/299812 | 14:31 |
| sambetts | unprocessed would probably be the best because we use the term raw to many other things | 14:31 |
| dtantsur | yeah, and it may give a clue that something "unprocessed" should be "processed" :) | 14:31 |
| aarefiev | :) | 14:31 |
| sambetts | ++ | 14:32 |
| mkovacik_ | true :) | 14:34 |
| * mkovacik_ hacks | 14:34 | |
| *** rbudden has quit IRC | 14:37 | |
| clif_h | how many +2s/reviews does a patch need to merge? | 14:41 |
| sambetts | clif_h: 2 +2s and a +W | 14:42 |
| clif_h | doesn't this have that: https://review.openstack.org/#/c/288632/ | 14:42 |
| sambetts | it needs a +W from someone | 14:43 |
| TheJulia | I know a few people prefer to wait 24 hours | 14:45 |
| *** e0ne has joined #openstack-ironic | 14:45 | |
| TheJulia | give other people a chance to take a look if its not critical | 14:45 |
| clif_h | is the +W new? | 14:46 |
| TheJulia | +W is just setting the workflow to approved | 14:47 |
| TheJulia | which then allows the patch to go through the gate and hopefully merge | 14:47 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: [WIP] Store ramdisk logs on preprocessing failures as well https://review.openstack.org/300011 | 14:48 |
| *** links has quit IRC | 14:48 | |
| dtantsur | sambetts, just noticed when debugging a validation failure ^^^ | 14:49 |
| *** wuhg has quit IRC | 14:49 | |
| *** Nisha_away has joined #openstack-ironic | 14:49 | |
| *** links has joined #openstack-ironic | 14:49 | |
| *** Nisha has quit IRC | 14:50 | |
| sambetts | dtantsur: makes sense, I could have used that a few times recently | 14:53 |
| dtantsur | ok. the unit tests will fail right now on this patchset, just wanted to have a quick sanity-check | 14:53 |
| jroll | clif_h: the other reason someone might not +W (or what I call +A) is to allow people that had a -1 to come back and make sure their concerns are addressed | 14:54 |
| *** rbudden has joined #openstack-ironic | 14:57 | |
| *** mgoddard_ has quit IRC | 14:57 | |
| *** mgoddard has joined #openstack-ironic | 14:58 | |
| *** mtanino has joined #openstack-ironic | 15:00 | |
| *** pece has quit IRC | 15:01 | |
| *** e0ne has quit IRC | 15:01 | |
| *** ametts has quit IRC | 15:02 | |
| *** mkovacik_ has quit IRC | 15:03 | |
| *** rbudden has quit IRC | 15:06 | |
| jroll | clif_h: I think I may have just killed your dreams, sorry :( | 15:07 |
| jroll | should all be quick fixes though | 15:07 |
| *** jistr has quit IRC | 15:07 | |
| *** ametts has joined #openstack-ironic | 15:07 | |
| clif_h | even doc changes are hard to get in :P | 15:07 |
| TheJulia | clif_h: I think doc changes are sometimes... the hardest. :) | 15:08 |
| jroll | you just should learn not to show docs patches to myself or rloo :) | 15:08 |
| TheJulia | lol | 15:08 |
| jroll | argh devstack y u hate me so | 15:08 |
| *** mtanino has quit IRC | 15:09 | |
| *** jistr has joined #openstack-ironic | 15:09 | |
| TheJulia | jroll: did you give it coffee yet? | 15:09 |
| jroll | yes, three days worth :/ | 15:10 |
| *** mtanino has joined #openstack-ironic | 15:11 | |
| TheJulia | :( | 15:11 |
| jroll | trying to find the base branch under test in our plugin, going nowhere | 15:14 |
| * jroll takes a break | 15:14 | |
| *** piet has joined #openstack-ironic | 15:14 | |
| * NobodyCam makes waffles | 15:16 | |
| sambetts | :O waffles! | 15:17 |
| NobodyCam | :) | 15:18 |
| jroll | and sean just gave me the most obvious solution | 15:19 |
| * jroll feels dumb now | 15:19 | |
| *** links has quit IRC | 15:19 | |
| jroll | stepping away for a few and then I'll be pushing all of this code | 15:19 |
| *** rbudden has joined #openstack-ironic | 15:21 | |
| JayF | clif_h: jroll hit the nail on the head. I was the 2nd +2 but others who had -1'd it before hadn't re-reviewed, so I wasn't going to land it until this morning | 15:24 |
| mag009_ | is it possible that you guys don't support ironic-inspector on ipxe ? | 15:27 |
| dtantsur | mag009_, we definitely support iPXE. we have a gate covering iPXE and the whole TripleO defaults to it. | 15:28 |
| *** jistr has quit IRC | 15:28 | |
| mag009_ | ok well I'm missing something | 15:28 |
| mag009_ | here's my problem | 15:28 |
| *** jistr has joined #openstack-ironic | 15:28 | |
| dtantsur | mag009_, he's how we configure it in devstack: https://github.com/openstack/ironic-inspector/commit/be14aae263a8b6bb46796f10bb9461d20629a667 | 15:29 |
| dtantsur | or take a look at puppet-ironic - it's more production-ready | 15:29 |
| thiagop | uhmmm, waffles... | 15:29 |
| mag009_ | ok I think what I'm missing is the tags | 15:30 |
| mag009_ | thx | 15:30 |
| dtantsur | you're welcome | 15:30 |
| mag009_ | I have another question do you know why the ironic agent is not updating ironic with the serial of the server | 15:31 |
| mag009_ | I only get basic info ram , disk and cpu | 15:31 |
| *** jcoufal_ has joined #openstack-ironic | 15:33 | |
| *** jcoufal has quit IRC | 15:35 | |
| *** jaybeale has joined #openstack-ironic | 15:37 | |
| *** e0ne has joined #openstack-ironic | 15:37 | |
| dtantsur | mag009_, well, serial is not required for ironic | 15:38 |
| dtantsur | we only apply required properties by default | 15:38 |
| mag009_ | how do I force it ? | 15:39 |
| dtantsur | mag009_, you can probably use introspection rules http://docs.openstack.org/developer/ironic-inspector/http-api.html#introspection-rules for that | 15:40 |
| *** e0ne has quit IRC | 15:40 | |
| dtantsur | mag009_, it's not entirely straightforward. if you have problems figuring out, please drop me a email on dtantsur@redhat.com | 15:40 |
| dtantsur | I have to run right now | 15:40 |
| *** trown is now known as trown|lunch | 15:41 | |
| dtantsur | essentially you have to create an action like {"op": "set-attribute", "path": "/properties/serial", "value": "{node[inventory][system_vendor][serial]}"} or something like that | 15:41 |
| dtantsur | aarefiev, you might remember ^^^ it was you who wrote this feature ;) | 15:42 |
| *** mkovacik has joined #openstack-ironic | 15:42 | |
| mag009_ | thanks I'll figured out ;) | 15:42 |
| mag009_ | I thought it was simpler by adding a hook in the .conf file | 15:43 |
| mag009_ | but it confirm what I thought everything extra is done through the rules.. | 15:43 |
| *** e0ne has joined #openstack-ironic | 15:44 | |
| dtantsur | yep | 15:45 |
| dtantsur | ok, see you tomorrow :) | 15:45 |
| aarefiev | here | 15:45 |
| *** rbudden has quit IRC | 15:45 | |
| aarefiev | I'd say "value": "{data[inventory][system_vendor][serial]}"} | 15:45 |
| aarefiev | s/node/data | 15:46 |
| dtantsur | right | 15:46 |
| *** dtantsur is now known as dtantsur|afk | 15:46 | |
| aarefiev | see you | 15:46 |
| *** thiagop is now known as thiagop-afk | 15:46 | |
| *** e0ne has quit IRC | 15:46 | |
| *** e0ne has joined #openstack-ironic | 15:47 | |
| devananda | mornin, all | 15:48 |
| sambetts | Morning devananda | 15:49 |
| NobodyCam | goood morning devananda :) | 15:49 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Allow fetching IPA ramdisk with branch name https://review.openstack.org/297479 | 15:51 |
| *** harshs has joined #openstack-ironic | 15:53 | |
| *** harshs has quit IRC | 15:53 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Allow fetching IPA ramdisk with branch name https://review.openstack.org/297479 | 15:54 |
| jroll | hiya devananda | 15:54 |
| *** Guest87578 is now known as jlvillal | 15:55 | |
| * jlvillal prefers being jlvillal and not Guest87578 | 15:55 | |
| jlvillal | Good morning all :) | 15:56 |
| NobodyCam | morning jlvillal :) | 15:56 |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add tests for testing node-delete command https://review.openstack.org/251458 | 15:56 |
| *** baoli_ has joined #openstack-ironic | 15:56 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Allow fetching IPA ramdisk with branch name https://review.openstack.org/297479 | 15:56 |
| jroll | boom, that should be it for master | 15:56 |
| jlvillal | jroll: In my testing this seems correct thing to do: https://review.openstack.org/#/c/298967/ for Grenade stuff. | 15:57 |
| jlvillal | Not saying Grenade is working, but for running Grenade as plugin, will need that. | 15:57 |
| *** baoli has quit IRC | 15:57 | |
| jlvillal | Also have a patch to openstack/project-config: https://review.openstack.org/299011 | 15:57 |
| *** e0ne has quit IRC | 15:58 | |
| jroll | jlvillal: nice | 15:58 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Tune interval for node provision state check https://review.openstack.org/299795 | 15:59 |
| *** mgoddard_ has joined #openstack-ironic | 15:59 | |
| *** mgoddard has quit IRC | 16:02 | |
| *** achanda has joined #openstack-ironic | 16:05 | |
| *** pcaruana has quit IRC | 16:08 | |
| *** garthb has joined #openstack-ironic | 16:10 | |
| *** e0ne has joined #openstack-ironic | 16:11 | |
| *** achanda has quit IRC | 16:11 | |
| * mgould -> home. Goodnight, everyone! | 16:13 | |
| *** mgould has quit IRC | 16:13 | |
| openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Add test for 'node-list field' command Closes-Bug: #1564490 https://review.openstack.org/300064 | 16:13 |
| openstack | bug 1564490 in python-ironicclient "Add test for 'node-list field' command" [Undecided,New] https://launchpad.net/bugs/1564490 - Assigned to Sofiia Andriichenko (sandriichenko) | 16:13 |
| jlvillal | jroll: On: branch: ^(?!stable/(kilo|liberty|mitaka)).*$ | 16:14 |
| jlvillal | Is 'mitaka' supposed to be in that regex? | 16:14 |
| jroll | depends | 16:14 |
| jroll | afaik, this job upgrades from (previous branch) to (branch under test) | 16:14 |
| jroll | right? | 16:14 |
| jlvillal | I believe so. | 16:14 |
| jlvillal | For master it uses stable/mitaka now. | 16:14 |
| jroll | right, so it upgrades from stable/mitaka to master for master changes | 16:15 |
| jlvillal | Ah, so that regex will make it not try to check for a patch against stable/mitaka... | 16:15 |
| jroll | for mitaka changes, it would upgrade from stable/liberty to stable/mitaka | 16:15 |
| jroll | right | 16:15 |
| jlvillal | Makes sense, thanks :) | 16:15 |
| jroll | yeah np | 16:15 |
| *** jtomasek has quit IRC | 16:16 | |
| jlvillal | I will propose that. | 16:16 |
| jroll | cool, that's in zuul/layout btw | 16:16 |
| NobodyCam | night mgould | 16:17 |
| jlvillal | jroll: Thanks. I had just found it after wandering around :) | 16:18 |
| jroll | heh, cool | 16:18 |
| jroll | jlvillal: probably ditto for partial | 16:19 |
| jlvillal | ok | 16:21 |
| *** jayc_ has joined #openstack-ironic | 16:22 | |
| *** Haomeng has quit IRC | 16:24 | |
| *** Haomeng has joined #openstack-ironic | 16:25 | |
| openstackgerrit | Clif Houck proposed openstack/ironic-python-agent: Add docstrings to all functions in Agent standby extension https://review.openstack.org/288632 | 16:26 |
| jlvillal | jroll: Quick sanity check? http://paste.openstack.org/show/492620/ | 16:28 |
| jroll | clif_h: so close, one thing | 16:28 |
| clif_h | :D | 16:28 |
| *** afaranha has quit IRC | 16:28 | |
| jroll | jlvillal: looks fine, I was thinking of two separate stanzas, as those will become working at different times | 16:30 |
| jroll | we also need to define what "partial" means for us, I believe it's currently defined as upgrade nova but don't upgrade ironic or something | 16:30 |
| jlvillal | jroll: Okay. I was worried they would review and say why don't you put those together ;) | 16:30 |
| jlvillal | I'll split them up | 16:30 |
| *** davideagnello has joined #openstack-ironic | 16:30 | |
| jroll | jlvillal: yeah, it will probably happen. cool thanks | 16:30 |
| *** mbound has joined #openstack-ironic | 16:31 | |
| *** e0ne has quit IRC | 16:32 | |
| *** mbound has quit IRC | 16:33 | |
| *** penick has joined #openstack-ironic | 16:34 | |
| jlvillal | jroll: https://review.openstack.org/#/c/300082/ | 16:34 |
| jroll | thanks | 16:35 |
| jroll | +1'd | 16:35 |
| *** trown|lunch is now known as trown | 16:39 | |
| clif_h | jroll: are you sure about the partition thing? | 16:41 |
| clif_h | it calls https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/shell/copy_configdrive_to_disk.sh right? | 16:41 |
| jroll | clif_h: the method is called write configdrive to partition | 16:41 |
| clif_h | to_disk | 16:41 |
| jroll | I could be wrong | 16:41 |
| jroll | lemme see | 16:41 |
| jroll | clif_h: +2 then | 16:42 |
| jroll | that's silly | 16:42 |
| *** jayc_ has quit IRC | 16:42 | |
| clif_h | ascii shrug | 16:42 |
| jroll | clif_h: I wouldn't mind that docstring starting with "... to a partition on given device" | 16:43 |
| jroll | but meh | 16:43 |
| *** kromanenko_ has joined #openstack-ironic | 16:43 | |
| clif_h | which docstring? | 16:43 |
| clif_h | line 186? | 16:43 |
| jroll | the one I commented on in this patchset | 16:43 |
| jroll | yeah 186 | 16:43 |
| clif_h | ok one sec | 16:44 |
| *** afaranha has joined #openstack-ironic | 16:44 | |
| openstackgerrit | Clif Houck proposed openstack/ironic-python-agent: Add docstrings to all functions in Agent standby extension https://review.openstack.org/288632 | 16:45 |
| jroll | +2 again | 16:45 |
| jroll | ty for that | 16:45 |
| *** e0ne has joined #openstack-ironic | 16:47 | |
| *** piet has quit IRC | 16:48 | |
| clif_h | np | 16:48 |
| JayF | I can just land that now if there are no objections? | 16:48 |
| jroll | I think so yeah | 16:48 |
| jroll | TheJulia had a +2 on the update before that one | 16:48 |
| JayF | +2W | 16:48 |
| *** e0ne has quit IRC | 16:50 | |
| jroll | devananda: dtantsur|afk: can we please land these to get the ball rolling? https://review.openstack.org/#/q/status:open+project:openstack/ironic-python-agent+topic:bug/1561756 | 16:51 |
| jroll | and whoever cores, CI is coming in green on https://review.openstack.org/#/c/297479/6 | 16:51 |
| jroll | hasn't reported yet but zuul looks happy | 16:51 |
| *** kromanenko_ has quit IRC | 16:53 | |
| *** moshele has quit IRC | 16:53 | |
| *** kromanenko has quit IRC | 16:53 | |
| *** jayc_ has joined #openstack-ironic | 16:55 | |
| *** piet has joined #openstack-ironic | 16:55 | |
| *** ohamada has quit IRC | 17:00 | |
| *** jistr has quit IRC | 17:00 | |
| *** mgoddard has joined #openstack-ironic | 17:01 | |
| sambetts | jroll, JayF: I've uploaded a new version of https://review.openstack.org/#/c/299529/ with the style changes | 17:01 |
| *** mgoddard_ has quit IRC | 17:02 | |
| JayF | restored my +2, ty | 17:02 |
| jroll | also +2, will let someone else +A | 17:04 |
| *** Guest11037 has quit IRC | 17:05 | |
| *** MattMan has quit IRC | 17:05 | |
| *** MattMan has joined #openstack-ironic | 17:05 | |
| *** suro-patz has joined #openstack-ironic | 17:05 | |
| *** rcernin has quit IRC | 17:06 | |
| mag009_ | ipxe without neutron isn't working guys | 17:06 |
| *** derekh has quit IRC | 17:06 | |
| *** jayc_ is now known as jayc | 17:06 | |
| sambetts | jroll, JayF: thanks :D now we just need to get some attention on the project config patch | 17:08 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Allow fetching IPA ramdisk with branch name https://review.openstack.org/297479 | 17:09 |
| jroll | yep | 17:10 |
| jroll | stepping away for a while | 17:10 |
| *** achanda has joined #openstack-ironic | 17:15 | |
| *** rajinir has quit IRC | 17:15 | |
| *** mbound has joined #openstack-ironic | 17:19 | |
| *** ChrisAusten has joined #openstack-ironic | 17:20 | |
| *** penick has quit IRC | 17:21 | |
| *** daemontool has quit IRC | 17:25 | |
| * sambetts is heading off for the evening | 17:26 | |
| *** sambetts is now known as sambetts|afk | 17:26 | |
| thiagop-afk | good evening sambetts|afk | 17:26 |
| *** spandhe has joined #openstack-ironic | 17:27 | |
| *** penick has joined #openstack-ironic | 17:27 | |
| NobodyCam | night sambetts|afk | 17:28 |
| *** yonglihe has quit IRC | 17:32 | |
| vdrok | if someone has a bit of time please review this one too - https://review.openstack.org/292552 | 17:37 |
| vdrok | have a good night! | 17:37 |
| thiagop-afk | night vdrok | 17:38 |
| *** dims_ has quit IRC | 17:39 | |
| *** dims has joined #openstack-ironic | 17:40 | |
| *** rbudden has joined #openstack-ironic | 17:41 | |
| openstackgerrit | Merged openstack/python-ironicclient: Code style fix according to flake8 https://review.openstack.org/296552 | 17:47 |
| -openstackstatus- NOTICE: Job failures for missing traceroute packages are in the process of being fixed now, ETA 30 minutes to effectiveness for new jobs | 17:48 | |
| *** suro-patz has quit IRC | 17:51 | |
| clif_h | something wrong with ipa gate? | 18:03 |
| jroll | 17:48:24 -- | Notice(openstackstatus): NOTICE: Job failures for missing traceroute packages are in the process of being fixed now, ETA 30 minutes to effectiveness for new jobs | 18:04 |
| *** suro-patz has joined #openstack-ironic | 18:04 | |
| jroll | all the things are hosed | 18:04 |
| mag009_ | I don't know how you guys get it working the ipxe with inspector but in your dhcp you need to boot the boot.ipxe but if you do so the one shipped with ironic is wrong... | 18:07 |
| mag009_ | it only check if there's a mac file | 18:07 |
| mag009_ | then it failed | 18:07 |
| mag009_ | so what I did is if there's no mac boot the default image (enroll image) | 18:07 |
| *** jaybeale has quit IRC | 18:11 | |
| *** Sukhdev has joined #openstack-ironic | 18:12 | |
| mag009_ | it does the trick... | 18:13 |
| *** devananda has quit IRC | 18:14 | |
| *** ibravo has quit IRC | 18:14 | |
| *** ibravo has joined #openstack-ironic | 18:14 | |
| *** Sukhdev has quit IRC | 18:15 | |
| *** harshs has joined #openstack-ironic | 18:16 | |
| *** baoli_ has quit IRC | 18:17 | |
| *** jcoufal_ has quit IRC | 18:19 | |
| jroll | mag009_: interesting, mind filing bugs for this stuff? | 18:19 |
| mag009_ | Yes, I will I'm not sure if it's a (bug) maybe it work with Neutron | 18:20 |
| *** ChubYann has joined #openstack-ironic | 18:21 | |
| mag009_ | but anyhow as standalone I couldn't get it working other then changing the boot.ipxe | 18:22 |
| *** dims_ has joined #openstack-ironic | 18:24 | |
| *** yolanda has quit IRC | 18:24 | |
| *** dims has quit IRC | 18:24 | |
| jroll | mag009_: we want to support standalone deployments, so I'd say it's a bug :) | 18:26 |
| NobodyCam | jroll: +a on 299529 with busted gate I don't think it go thru but ... | 18:26 |
| NobodyCam | :p | 18:27 |
| *** devananda has joined #openstack-ironic | 18:27 | |
| jroll | NobodyCam: heh, cool. thanks :) | 18:27 |
| *** penick has quit IRC | 18:27 | |
| *** yolanda has joined #openstack-ironic | 18:27 | |
| *** Marga_ has quit IRC | 18:32 | |
| *** jayc has quit IRC | 18:34 | |
| TheJulia | mag009_: sounds a bit like a doc issue for standalone use case. I sem to remember I had to do some investigation when I did it in bifrost, so bug would be awesome :) | 18:34 |
| TheJulia | a report that is | 18:35 |
| * TheJulia should like... eat food | 18:35 | |
| *** piet has quit IRC | 18:39 | |
| *** piet has joined #openstack-ironic | 18:39 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Make tox respect upper-constraints.txt https://review.openstack.org/300146 | 18:44 |
| JayF | jroll: ^ -1 w/comments | 18:47 |
| *** zer0c00l has joined #openstack-ironic | 18:47 | |
| jroll | thanks | 18:48 |
| *** jayc has joined #openstack-ironic | 18:48 | |
| jroll | jlvillal: mind testing this change behind your proxy? https://review.openstack.org/#/c/300146/1 | 18:50 |
| jroll | jlvillal: probably just tox -r -epep8 should do it | 18:50 |
| jroll | (at your leisure | 18:50 |
| jroll | ) | 18:50 |
| *** Nisha_brb has joined #openstack-ironic | 18:57 | |
| *** zer0c00l has quit IRC | 18:57 | |
| *** zer0c00l has joined #openstack-ironic | 18:58 | |
| *** Nisha_away has quit IRC | 18:59 | |
| *** openstackgerrit has quit IRC | 19:03 | |
| *** openstackgerrit has joined #openstack-ironic | 19:04 | |
| *** penick has joined #openstack-ironic | 19:06 | |
| *** suro-patz has quit IRC | 19:07 | |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Node list permits individual and group selection. https://review.openstack.org/300161 | 19:07 |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Removed setPowerState https://review.openstack.org/300162 | 19:07 |
| *** penick has quit IRC | 19:07 | |
| *** Marga_ has joined #openstack-ironic | 19:09 | |
| *** Sukhdev has joined #openstack-ironic | 19:10 | |
| openstackgerrit | Clint 'SpamapS' Byrum proposed openstack/bifrost: Add playbook to transfer nodes to another Ironic https://review.openstack.org/299660 | 19:11 |
| *** penick has joined #openstack-ironic | 19:14 | |
| *** penick has quit IRC | 19:16 | |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Table header checkbox disappears when no nodes available. https://review.openstack.org/300166 | 19:16 |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Enabled Refresh button https://review.openstack.org/300167 | 19:16 |
| *** Nisha_brb has quit IRC | 19:28 | |
| *** piet has quit IRC | 19:32 | |
| *** piet has joined #openstack-ironic | 19:33 | |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Table header checkbox disappears when no nodes available. https://review.openstack.org/300166 | 19:33 |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Enabled Refresh button https://review.openstack.org/300167 | 19:33 |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Removed setPowerState https://review.openstack.org/300162 | 19:33 |
| jlvillal | jroll: Sure I can test that. I just got back from lunch. | 19:37 |
| jroll | jlvillal: cool, no rush. thanks! :) | 19:37 |
| jlvillal | jroll: Why I think checking log messages in unit tests are a good idea :) https://bugs.launchpad.net/ironic/+bug/1564531 | 19:37 |
| openstack | Launchpad bug 1564531 in Ironic "Unit test: ironic.tests.unit.conductor.test_manager.DoNodeCleanTestCase.test__do_next_clean_step_manual_fail_in_tear_down_cleaning incorrect" [Undecided,New] - Assigned to Anup (anup-d-navare) | 19:37 |
| * NobodyCam steps afk for a few | 19:37 | |
| * jlvillal continues to tilt at windmills | 19:37 | |
| *** jayc has quit IRC | 19:38 | |
| jroll | jlvillal: idgi, why doesn't that fail in the gate | 19:38 |
| *** krtaylor has quit IRC | 19:40 | |
| jlvillal | jroll: I just think the test isn't testing what it thought it was testing | 19:40 |
| *** rbudden has quit IRC | 19:40 | |
| jlvillal | jroll: On a different note: http://paste.openstack.org/show/492658/ | 19:40 |
| *** mgoddard has quit IRC | 19:41 | |
| jroll | jlvillal: oh, not a bug, just a weird name? | 19:41 |
| jlvillal | jroll: And that could be an issue with my devpi server??? | 19:41 |
| jroll | jlvillal: hrm, something is wrong, however it did pull down the constraints file fine (assuming git.o.o goes through your proxy) so I think that shows the patch is okay | 19:42 |
| jlvillal | jroll: Maybe that restructed-text isn't yet on the PyPi mirror I'm using? | 19:43 |
| jlvillal | But yes I think your patch is working. | 19:44 |
| jroll | jlvillal: yeah, sounds like it | 19:44 |
| jlvillal | jroll: On your comment: oh, not a bug, just a weird name? | 19:45 |
| jlvillal | Was that about the bug I posted or the pep8 stuff? | 19:45 |
| jroll | jlvillal: the bug you posted | 19:45 |
| jroll | I'm also in mtgs right now so maybe missed something | 19:46 |
| jlvillal | I do think the bug I posted is a bug. Missing one mock. | 19:46 |
| jroll | I guess we could say it's a bug in the test too | 19:46 |
| jroll | cool | 19:46 |
| * jlvillal will probably steal the bug from his co-worker | 19:46 | |
| jroll | nah, leave it for a newbie :) | 19:46 |
| *** rbudden has joined #openstack-ironic | 19:50 | |
| *** jayc has joined #openstack-ironic | 19:51 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Allow rerunning introspection on stored data https://review.openstack.org/267637 | 19:52 |
| -openstackstatus- NOTICE: Any jobs which erroneously failed on missing traceroute packages should be safe to recheck now | 19:54 | |
| jroll | NobodyCam: ^ fyi | 19:55 |
| jroll | (the recheck thing) | 19:55 |
| jroll | oh jlvillal, could you post your results on that patch? https://review.openstack.org/#/c/300146/ | 19:55 |
| mrda | Morning Ironic | 19:55 |
| JayF | I mean I saw IRC, I can change my vote | 19:57 |
| jroll | heh, that works too | 19:58 |
| jlvillal | jroll: Done | 20:00 |
| jroll | ty | 20:01 |
| *** ibravo has quit IRC | 20:04 | |
| NobodyCam | morning mrda | 20:08 |
| NobodyCam | jroll: issued reverify on 299529 | 20:09 |
| jroll | ty | 20:09 |
| jroll | figured you might have other things to recheck too :P | 20:09 |
| *** Sukhdev has quit IRC | 20:09 | |
| mrda | hey NobodyCam | 20:10 |
| jroll | morning mrda \o | 20:11 |
| jlvillal | Hi mrda | 20:12 |
| mrda | hey jroll and jlvillal! | 20:13 |
| * jroll -> lunch and stuff | 20:14 | |
| *** baoli has joined #openstack-ironic | 20:15 | |
| *** baoli_ has joined #openstack-ironic | 20:15 | |
| *** dprince has quit IRC | 20:16 | |
| *** spandhe has quit IRC | 20:17 | |
| *** baoli has quit IRC | 20:19 | |
| *** piet has quit IRC | 20:23 | |
| *** piet has joined #openstack-ironic | 20:23 | |
| *** penick has joined #openstack-ironic | 20:25 | |
| *** krtaylor has joined #openstack-ironic | 20:28 | |
| *** piet has quit IRC | 20:31 | |
| *** suro-patz has joined #openstack-ironic | 20:32 | |
| * jlvillal notices it is World Backup Day and thinks we should create World Bare Metal Provisioning Day | 20:33 | |
| jlvillal | mrda: Can you attend the Nova meeting today? I have a conflict :( | 20:34 |
| mrda | So do I unfortunately jlvillal. I have 2 clashes today :-/ | 20:36 |
| jlvillal | mrda: :( | 20:36 |
| mrda | Sorry | 20:36 |
| JayF | When is the nova meeting? | 20:37 |
| jlvillal | JayF: 23 minutes | 20:37 |
| JayF | If one of you wants to bring me up to speed on what's needed there, I'm more than willing to rep Ironic in the meeting | 20:38 |
| jlvillal | JayF: Usually we just watch and see if they say 'ironic' | 20:38 |
| jlvillal | JayF: And usually they don't | 20:38 |
| jlvillal | Just trying to be there if they have any questions. | 20:38 |
| jlvillal | JayF: http://eavesdrop.openstack.org/#Nova_Team_Meeting | 20:39 |
| jlvillal | s/we just watch/I just watch/ | 20:39 |
| JayF | I can handle that then, you both go have a good other-meeting or whatever it is :P | 20:40 |
| jlvillal | JayF: Thanks! You rock :) | 20:40 |
| jlvillal | mrda: ^^^ | 20:40 |
| mrda | Thanks JayF, that's a big help for today | 20:41 |
| JayF | no problem, glad to be able to help | 20:41 |
| JayF | although I'll probably end up proxying most questions | 20:41 |
| * devananda is lurking too | 20:41 | |
| * mrda wonders if he has someone else who can attend another of his clashes in this timeslot :-) | 20:41 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Fix _do_next_clean_step_fail_in_tear_down_cleaning() https://review.openstack.org/300204 | 20:42 |
| *** stevemar_ has joined #openstack-ironic | 20:56 | |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Added capitalize filter https://review.openstack.org/300212 | 20:59 |
| openstackgerrit | Jarrod Johnson proposed openstack/pyghmi: Remove a cyclical reference in Lenovo OEM https://review.openstack.org/300213 | 20:59 |
| *** suro-patz has quit IRC | 21:02 | |
| *** suro-patz has joined #openstack-ironic | 21:02 | |
| *** suro-patz has quit IRC | 21:02 | |
| *** suro-patz has joined #openstack-ironic | 21:03 | |
| *** Goneri has quit IRC | 21:04 | |
| openstackgerrit | Merged openstack/pyghmi: Remove a cyclical reference in Lenovo OEM https://review.openstack.org/300213 | 21:06 |
| *** trown is now known as trown|outtypewww | 21:07 | |
| *** jjohnson2 has quit IRC | 21:10 | |
| *** spandhe has joined #openstack-ironic | 21:10 | |
| *** harshs has quit IRC | 21:11 | |
| JayF | that nova meeting was crazy short | 21:14 |
| *** piet has joined #openstack-ironic | 21:15 | |
| *** chihhsin has quit IRC | 21:15 | |
| *** wuhg has joined #openstack-ironic | 21:16 | |
| *** baoli_ has quit IRC | 21:17 | |
| *** Sukhdev has joined #openstack-ironic | 21:18 | |
| *** thiagop-afk has quit IRC | 21:18 | |
| *** piet has quit IRC | 21:18 | |
| *** achanda has quit IRC | 21:22 | |
| *** baoli has joined #openstack-ironic | 21:24 | |
| krotscheck | I have a few questions regarding power state. | 21:28 |
| krotscheck | To reboot a box, I do a PUT /v1/nodes/(node_ident)/states/power | 21:29 |
| krotscheck | With the body {node_ident: '', target: 'rebooting'}, correct? | 21:30 |
| krotscheck | Or is it just {target: 'rebooting'}? | 21:30 |
| devananda | krotscheck: I think it the latter, but s/rebooting/reboot/ | 21:32 |
| JayF | Honestly, when I need to know exactly what api calls like that look like, I tend to just run them through ironicclient with debug | 21:32 |
| krotscheck | devananda: Thanks. That's difficult to glean from http://docs.openstack.org/developer/ironic/_modules/ironic/common/states.html | 21:32 |
| devananda | krotscheck: this is a little better, I hope: http://docs.openstack.org/developer/ironic/webapi/v1.html#put--v1-nodes-%28node_ident%29-states-power | 21:34 |
| krotscheck | devananda Urm, yeah, not so much? The desired power state is 'rebooting'. The action is 'reboot'. No? | 21:35 |
| devananda | hmm. jroll, speaking of docs, we need to be here: http://developer.openstack.org/api-ref.html | 21:35 |
| JayF | devananda: that doesn't specify the potential targets | 21:35 |
| JayF | devananda: i.e. reboot vs rebooting, which I think is what krotscheck was pointing out originally | 21:36 |
| devananda | JayF: no. and it totally should. | 21:36 |
| JayF | devananda: btw; https://review.openstack.org/#/c/263842/ is that patch we talked about (that originally was changing API contract), it's up and passing tests if you get a chance to have a look | 21:36 |
| JayF | but I'm pretty sure I'll have to refactor it a little more to make sure it only impacts ramdisk booting | 21:36 |
| devananda | JayF: neat! um. you know, busy, but i'll look | 21:36 |
| JayF | I know :) I just value reviews from you, especially on stuff like this. | 21:37 |
| *** suro-patz has quit IRC | 21:41 | |
| devananda | JayF: what about vmedia boots? | 21:43 |
| JayF | vmedia boots don't use pxe driver. | 21:43 |
| JayF | That's why making it a pxe driver option instead of an agent driver option makes it somewhat simpler. | 21:43 |
| devananda | oh | 21:43 |
| devananda | oh! | 21:44 |
| *** harshs has joined #openstack-ironic | 21:44 | |
| *** suro-patz has joined #openstack-ironic | 21:44 | |
| JayF | I still think there's a bug somewhere around the prep that prepare_ramdisk() does being reused by the pxe-boot-an-instance code | 21:45 |
| JayF | like I might have to check and do some of that prep in prepare_instance (I think that's thee method name?) if manage_ramdisk_boot is false | 21:46 |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Added capitalize filter https://review.openstack.org/300212 | 21:49 |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Renamed IronicNodeTransition to IronicNodeProvisionTransition https://review.openstack.org/300225 | 21:49 |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Added IronicNodePowerTransition resource https://review.openstack.org/300226 | 21:49 |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Available node transitions now available in node_list https://review.openstack.org/300227 | 21:49 |
| NobodyCam | SpamapS: rechecking 299660 looks like to hit the traceroute thing. | 21:49 |
| *** krtaylor has quit IRC | 21:57 | |
| JayF | devananda: tyvm for taking that time. Just didn't wanna waste my time fixing up smaller nits if the direction was going to be nix'd later :) | 21:58 |
| *** yolanda has quit IRC | 21:59 | |
| *** amotoki has joined #openstack-ironic | 22:01 | |
| *** yolanda has joined #openstack-ironic | 22:07 | |
| *** rbudden has quit IRC | 22:08 | |
| jlvillal | devananda: jroll: API doc site appears to come from here: https://github.com/openstack/api-site | 22:08 |
| *** ametts has quit IRC | 22:09 | |
| *** Goneri has joined #openstack-ironic | 22:10 | |
| *** [1]cdearborn has quit IRC | 22:13 | |
| openstackgerrit | Clint 'SpamapS' Byrum proposed openstack/bifrost: Add playbook to transfer nodes to another Ironic https://review.openstack.org/299660 | 22:24 |
| openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Basic node action hooks. https://review.openstack.org/281900 | 22:24 |
| krotscheck | Ok, I think that's it for me today. Have fun reviewing javascript, everyone :D | 22:25 |
| *** baoli has quit IRC | 22:38 | |
| *** jjohnson2 has joined #openstack-ironic | 22:45 | |
| NobodyCam | your just evil krotscheck | 22:45 |
| *** penick has quit IRC | 22:58 | |
| *** garthb_ has joined #openstack-ironic | 22:58 | |
| *** garthb has quit IRC | 22:59 | |
| *** jjohnson2 has quit IRC | 23:04 | |
| *** jaybeale has joined #openstack-ironic | 23:06 | |
| JayF | Someone around who knows a thing about the network patchset list? I have a question about some of the code I'm reviewing | 23:06 |
| JayF | think it could be a bug, but I think the bug might be in my understanding and not the code | 23:06 |
| devananda | I might? | 23:06 |
| JayF | looking at https://review.openstack.org/#/c/213262/96/ironic/drivers/modules/iscsi_deploy.py, line 583 | 23:07 |
| JayF | are we guaranteed that prepare() is called exactly once? | 23:07 |
| JayF | because there's no protection there for if a node in DEPLOYING hits that twice, it just loses it's power and potentially network, and redoes a lot of stuff | 23:08 |
| devananda | oh | 23:10 |
| devananda | we certainly are not | 23:10 |
| devananda | prepare can expclitly be called >1 | 23:10 |
| devananda | ironic/drivers/base.py: If implemented, this method must be idempotent. | 23:11 |
| JayF | perfect | 23:11 |
| JayF | How I knew that without knowing that idk, but it just ... looked dangerous | 23:11 |
| *** amotoki has quit IRC | 23:13 | |
| JayF | commented that on the patch | 23:14 |
| *** ChrisAusten has quit IRC | 23:16 | |
| *** harshs has quit IRC | 23:20 | |
| jroll | devananda: jlvillal: there's currently work being done on in-tree api docs, kinda waiting on that because there's no way I'm writing wadl | 23:23 |
| jroll | devananda: also, could you please review these stable branch things, kinda blocked on those: https://review.openstack.org/#/q/status:open+project:openstack/ironic-python-agent++topic:bug/1561756 | 23:25 |
| jroll | they're short, promise | 23:25 |
| *** early has quit IRC | 23:30 | |
| *** early has joined #openstack-ironic | 23:33 | |
| * devananda looks | 23:35 | |
| devananda | oh, right | 23:36 |
| devananda | jroll: done. thx for the reminder | 23:38 |
| jroll | nice thanks \o/ | 23:38 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!