| *** smoriya has joined #openstack-ironic | 00:04 | |
| *** rama_y has quit IRC | 00:05 | |
| *** rbudden has quit IRC | 00:09 | |
| openstackgerrit | Merged openstack/ironic: Add some docs/comments to devstack/plugin.sh https://review.openstack.org/315740 | 00:10 |
|---|---|---|
| *** sdake has quit IRC | 00:21 | |
| *** sdake has joined #openstack-ironic | 00:21 | |
| *** sdake has quit IRC | 00:21 | |
| *** Sukhdev has joined #openstack-ironic | 00:25 | |
| *** mbound has joined #openstack-ironic | 00:30 | |
| *** mbound has quit IRC | 00:35 | |
| *** piet has quit IRC | 00:36 | |
| *** baoli has joined #openstack-ironic | 00:43 | |
| *** amotoki has joined #openstack-ironic | 00:46 | |
| *** amotoki has quit IRC | 00:50 | |
| *** ChrisAusten has quit IRC | 00:50 | |
| *** hoangcx has joined #openstack-ironic | 00:52 | |
| *** rloo has joined #openstack-ironic | 00:53 | |
| *** YiboCai has joined #openstack-ironic | 00:53 | |
| *** baoli has quit IRC | 01:02 | |
| *** amotoki has joined #openstack-ironic | 01:07 | |
| *** lintan has joined #openstack-ironic | 01:08 | |
| *** amotoki_ has joined #openstack-ironic | 01:10 | |
| *** amotoki has quit IRC | 01:11 | |
| *** moshele has joined #openstack-ironic | 01:15 | |
| *** baoli has joined #openstack-ironic | 01:17 | |
| *** baoli has quit IRC | 01:23 | |
| *** penick has quit IRC | 01:24 | |
| *** baoli has joined #openstack-ironic | 01:28 | |
| *** sabeen has quit IRC | 01:32 | |
| *** sabeen has joined #openstack-ironic | 01:33 | |
| *** baoli has quit IRC | 01:46 | |
| *** baoli has joined #openstack-ironic | 01:53 | |
| *** piet has joined #openstack-ironic | 01:57 | |
| *** baoli has quit IRC | 01:58 | |
| *** gcb has quit IRC | 02:00 | |
| *** ijw has quit IRC | 02:09 | |
| *** ijw has joined #openstack-ironic | 02:10 | |
| *** ijw has quit IRC | 02:10 | |
| *** gcb has joined #openstack-ironic | 02:15 | |
| *** Sukhdev has quit IRC | 02:16 | |
| *** piet has quit IRC | 02:21 | |
| *** Haomeng has joined #openstack-ironic | 02:22 | |
| *** amotoki_ has quit IRC | 02:27 | |
| *** rama_y has joined #openstack-ironic | 02:30 | |
| *** yonglihe has joined #openstack-ironic | 02:30 | |
| *** amotoki has joined #openstack-ironic | 02:30 | |
| *** rloo has quit IRC | 02:43 | |
| *** thrash is now known as thrash|g0ne | 02:44 | |
| *** joprovost has quit IRC | 02:45 | |
| *** ChrisAusten has joined #openstack-ironic | 02:46 | |
| *** moshele has quit IRC | 02:50 | |
| *** yuanying has quit IRC | 02:51 | |
| *** piet_ has joined #openstack-ironic | 02:53 | |
| *** dims_ has quit IRC | 02:55 | |
| *** dims has joined #openstack-ironic | 03:00 | |
| *** yuanying has joined #openstack-ironic | 03:01 | |
| *** gcb has quit IRC | 03:04 | |
| openstackgerrit | Tan Lin proposed openstack/ironic: Make use of oslo-config-generator https://review.openstack.org/247331 | 03:08 |
| *** piet_ has quit IRC | 03:11 | |
| *** piet_ has joined #openstack-ironic | 03:11 | |
| *** gcb has joined #openstack-ironic | 03:17 | |
| *** haomeng_ has joined #openstack-ironic | 03:26 | |
| *** greghaynes has quit IRC | 03:31 | |
| *** joprovost has joined #openstack-ironic | 03:34 | |
| *** amotoki_ has joined #openstack-ironic | 03:39 | |
| *** amotoki has quit IRC | 03:41 | |
| *** yuanying has quit IRC | 03:45 | |
| *** yuanying has joined #openstack-ironic | 03:45 | |
| *** yuanying has quit IRC | 03:47 | |
| *** yuanying has joined #openstack-ironic | 03:48 | |
| *** harlowja_at_home has joined #openstack-ironic | 03:49 | |
| *** piet_ has quit IRC | 03:53 | |
| *** amotoki_ has quit IRC | 03:53 | |
| *** Sukhdev has joined #openstack-ironic | 03:54 | |
| *** amotoki has joined #openstack-ironic | 03:58 | |
| *** joprovost has quit IRC | 04:01 | |
| *** piet_ has joined #openstack-ironic | 04:06 | |
| *** sabeen has quit IRC | 04:07 | |
| *** harlowja_at_home has quit IRC | 04:07 | |
| *** links has joined #openstack-ironic | 04:13 | |
| *** amotoki has quit IRC | 04:17 | |
| *** piet_ has quit IRC | 04:23 | |
| *** piet has joined #openstack-ironic | 04:23 | |
| *** Sukhdev has quit IRC | 04:25 | |
| *** Sukhdev has joined #openstack-ironic | 04:26 | |
| *** sdake_ has joined #openstack-ironic | 04:30 | |
| *** amotoki has joined #openstack-ironic | 04:34 | |
| *** jcoufal has joined #openstack-ironic | 04:39 | |
| *** klindgren has quit IRC | 04:44 | |
| *** rama_y has quit IRC | 04:44 | |
| *** hoangcx has quit IRC | 04:45 | |
| *** piet has quit IRC | 05:01 | |
| *** sabeen has joined #openstack-ironic | 05:07 | |
| *** Nakato has quit IRC | 05:07 | |
| *** Sukhdev has quit IRC | 05:33 | |
| *** ChubYann has quit IRC | 05:45 | |
| *** rcernin has joined #openstack-ironic | 05:48 | |
| *** hoangcx has joined #openstack-ironic | 05:51 | |
| *** sabeen has quit IRC | 05:53 | |
| *** sachary__ has quit IRC | 05:53 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/318851 | 05:59 |
| *** greghaynes has joined #openstack-ironic | 06:02 | |
| *** _vsaienko has joined #openstack-ironic | 06:13 | |
| *** amotoki has quit IRC | 06:13 | |
| *** _vs has joined #openstack-ironic | 06:13 | |
| *** mjura has joined #openstack-ironic | 06:14 | |
| *** kromanenko__ has joined #openstack-ironic | 06:16 | |
| *** kromanenko_ has joined #openstack-ironic | 06:16 | |
| *** Romanenko_K has joined #openstack-ironic | 06:16 | |
| *** mjura has quit IRC | 06:19 | |
| *** mjura has joined #openstack-ironic | 06:19 | |
| *** ChrisAusten has quit IRC | 06:21 | |
| *** milan has joined #openstack-ironic | 06:22 | |
| *** _milan_ has quit IRC | 06:22 | |
| *** david-lyle_ has joined #openstack-ironic | 06:26 | |
| *** swatson_ has joined #openstack-ironic | 06:26 | |
| *** swatson has quit IRC | 06:27 | |
| *** jrist has quit IRC | 06:27 | |
| *** david-lyle has quit IRC | 06:28 | |
| *** boris-42 has quit IRC | 06:28 | |
| *** jrist has joined #openstack-ironic | 06:29 | |
| *** boris-42 has joined #openstack-ironic | 06:29 | |
| *** Nakato has joined #openstack-ironic | 06:31 | |
| *** _vsaienko has quit IRC | 06:35 | |
| *** _vs has quit IRC | 06:35 | |
| *** vishwanathj has quit IRC | 06:52 | |
| *** sacharya has joined #openstack-ironic | 06:54 | |
| *** sacharya has quit IRC | 06:59 | |
| *** jtomasek has quit IRC | 07:01 | |
| *** parlos has joined #openstack-ironic | 07:03 | |
| milan | morning Ironic! | 07:06 |
| milan | #pixiesay yawn, Friday -m flexing | 07:06 |
| PixieBoots | ᕙʕ⇀ᴥ⇀ʔᕗ: yawn, Friday | 07:06 |
| parlos | good morning | 07:07 |
| milan | morning parlos | 07:17 |
| *** haomeng_ has quit IRC | 07:23 | |
| parlos | Good morning milan, | 07:29 |
| *** ohamada has joined #openstack-ironic | 07:42 | |
| *** dtantsur|afk is now known as dtantsur | 07:47 | |
| dtantsur | Morning Ironic | 07:47 |
| dtantsur | happy Friday! | 07:47 |
| *** mbound has joined #openstack-ironic | 07:48 | |
| *** electrofelix has joined #openstack-ironic | 07:49 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: grenade checking https://review.openstack.org/311109 | 07:50 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Make sure create_ovs_taps createse uniq taps https://review.openstack.org/319101 | 07:50 |
| *** electrofelix has quit IRC | 07:50 | |
| milan | #pixiesay good Friday morning dtantsur! -m happy | 07:57 |
| PixieBoots | ʕ^ᴥ^ʔ: good Friday morning dtantsur! | 07:58 |
| aarefiev | morning all! | 07:58 |
| aarefiev | milan: thanks for update | 07:58 |
| milan | dtantsur, good news everyone: the inspector tempest basic test no longer WIP ;) | 07:58 |
| milan | aarefiev, morning :) | 07:58 |
| milan | aarefiev, np, should be ready for reviews (experimental check passed) | 07:59 |
| aarefiev | yeah, it's cool | 07:59 |
| milan | aarefiev, I suppose next is discovery test case | 07:59 |
| *** zzzeek has quit IRC | 08:00 | |
| milan | separate pull request, right? | 08:00 |
| aarefiev | milan: yeah, I'll push wip version today or monday | 08:00 |
| dtantsur | milan, no, next is moving it from experimental | 08:00 |
| dtantsur | then we can iterator more | 08:00 |
| *** zzzeek has joined #openstack-ironic | 08:00 | |
| dtantsur | it = the job ofc | 08:00 |
| milan | dtantsur, right | 08:01 |
| aarefiev | dtantsur: I have patch for this | 08:01 |
| dtantsur | awesome, so lets merge the basic test patch, and proceed with it | 08:01 |
| * dtantsur reviews | 08:01 | |
| milan | so, dtantsur, +2 this one and we can move on ;) | 08:01 |
| *** daemontool has joined #openstack-ironic | 08:03 | |
| *** ifarkas has joined #openstack-ironic | 08:07 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 08:10 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 08:10 |
| dtantsur | milan, sorry for spoiling fun, but I have some issues there.. | 08:12 |
| *** amotoki has joined #openstack-ironic | 08:15 | |
| *** jistr has joined #openstack-ironic | 08:15 | |
| milan | dtantsur, me looks | 08:20 |
| *** alex_xu has joined #openstack-ironic | 08:21 | |
| *** lucas-afk is now known as lucasagomes | 08:32 | |
| lucasagomes | morning all | 08:32 |
| lucasagomes | #pixiesay -m flexing | 08:32 |
| PixieBoots | ᕙʕ⇀ᴥ⇀ʔᕗ | 08:32 |
| dtantsur | morning lucasagomes | 08:34 |
| vdrok | morning ironic, lucasagomes dtantsur milan and PixieBoots ! | 08:34 |
| dtantsur | hey vdrok | 08:35 |
| dtantsur | oh lucasagomes, I have a great feature request! | 08:35 |
| dtantsur | we need a command like #pixiemorning that will say good morning to everyone who was active for say 6 hours :D | 08:35 |
| milan | morning vdrok lucasagomes ! | 08:36 |
| *** Haomeng has quit IRC | 08:36 | |
| milan | dtantsur, could be implemented as anyone who has used pixiesay recently ;) | 08:37 |
| vsaienko | morning Ironic'ers | 08:37 |
| milan | morning vsaienko | 08:37 |
| openstackgerrit | Merged openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/318852 | 08:37 |
| dtantsur | milan, maybe? | 08:37 |
| milan | dtantsur, w/r the test | 08:38 |
| milan | dtantsur, I feel the introspection call and settling down should be part of setup | 08:38 |
| milan | because: | 08:38 |
| milan | a) we're messing with the state and registering cleanUp | 08:39 |
| milan | b) we need the nodes to settle down before we can perform assertions | 08:39 |
| dtantsur | sorry, I'll interrupt you, but the thing we test must be in test. we're testing introspection, not nova boot | 08:39 |
| milan | dtantsur, IMHO the test isn't the call to rest api it's rather asserting the results of that call | 08:40 |
| dtantsur | even more, there might be tests starting differently later on. or tests doing 2 introspection, but no nova boot | 08:40 |
| dtantsur | milan, no, test is everything. think of it: setUp should consist of things that don't fail | 08:41 |
| *** mgould|afk is now known as mgould | 08:41 | |
| milan | yes, but all of those would call introspect and settle or? | 08:41 |
| mgould | morning everyone! | 08:41 |
| milan | morning mgould ! | 08:41 |
| dtantsur | milan, not necessary? or they would call something else before. e.g. set up different rules. | 08:41 |
| milan | dtantsur, but should we then bump the loading of the introspection rule too? | 08:41 |
| dtantsur | milan, I'd say so, yes. | 08:41 |
| dtantsur | purging all rules can stay in setUp | 08:42 |
| dtantsur | s/can/should/ I guess | 08:42 |
| milan | dtantsur, hmmmm | 08:42 |
| mgould | milan, dtantsur: is there a review I can look at? having trouble following this discussion | 08:42 |
| dtantsur | mgould, https://review.openstack.org/293926 | 08:43 |
| milan | mgould, yeah, we're trying to figure out what to keep in setup and what to bump to the test case | 08:44 |
| *** derekh has joined #openstack-ironic | 08:44 | |
| mgould | thanks! | 08:45 |
| * mgould sees the length of the thread and remembers why he didn't review this patch before... | 08:45 | |
| milan | mgould, I prefer the test setUp to be the part where the steps necessary for the assertions happen, dtantsur says setUp better contains just the steps that shouldn't fail (selecting node_ids and purging rules here) the rest should go to test itself | 08:47 |
| * mgould nods | 08:48 | |
| mgould | you know about GIVEN/WHEN/THEN test structure? | 08:48 |
| mgould | [one step back: I don't have firm opinions, but I'm about to describe how I think about this] | 08:49 |
| milan | mgould, I don't | 08:49 |
| milan | yes please, describe | 08:49 |
| mgould | some test frameworks force you to write GIVEN [that my system is in a certain state] WHEN [I do a thing] THEN [certain things happen] | 08:49 |
| mgould | in xUnit-style testing, I try to put GIVEN steps in setUp, and WHEN and THEN in the test method | 08:50 |
| mgould | ie assertions plus the actual action under test | 08:50 |
| mgould | OTOH, setUp is shared among the whole class, so it usually ends up as "common GIVEN steps go in setUp, test-specific GIVEN steps go in that test's method, refactor to move GIVEN steps into setUp where possible" | 08:51 |
| * mgould may need more coffee | 08:52 | |
| mgould | does that make any sense? | 08:52 |
| mgould | anyway, I think "might this fail?" is the wrong question | 08:52 |
| mgould | everything might fail | 08:53 |
| mgould | the question is "is this tested somewhere else?" | 08:53 |
| mgould | if so, it can go in setUp | 08:53 |
| mgould | if not, then we are writing the test for it right now and it should go in the test method | 08:54 |
| milan | mgould, it does, my point was: GIVEN the nodes have been introspected and their state is in sync with ironic and inspector WHEN asserting the introspection result passes and nova is able to boot an instance THEN Inspector is sane | 08:55 |
| milan | but | 08:55 |
| milan | on the second thought this is a scenario not a unit test | 08:55 |
| mgould | yeah, sounds like you need to test several things about Inspector's state there | 08:56 |
| lucasagomes | dtantsur, hahaha man that's a good thing yes! | 08:57 |
| lucasagomes | automatic morning :-) | 08:57 |
| * lucasagomes adds to a todo list | 08:57 | |
| mgould | lucasagomes: GitHub Issues, then anyone can do it | 08:58 |
| * mgould didn't realise that lucasagomes had drawn PixieBoots - nice work! | 08:59 | |
| mgould | milan: so the problem is that the "nova boot" step is flaky? | 09:00 |
| milan | so maybe GIVEN no introspection rules and a set of OK nodes WHEN step 1 and step 2 and .. and step n) are asserted OK THEN Inspector is sane | 09:00 |
| milan | mgould, dtantsur says we're not testing nova boot and the test now looks like that | 09:01 |
| mgould | so what's the actual action we're testing? Is it the ironic/ironic-inspector sync? | 09:01 |
| milan | dtantsur, ^ correct me if I'm wrong | 09:01 |
| mgould | you mean that nova boot isn't tested *anywhere*? | 09:01 |
| * mgould hopes the nova people are testing it... | 09:02 | |
| mgould | the WHEN step should be an action | 09:02 |
| mgould | https://en.wikipedia.org/wiki/Given-When-Then | 09:02 |
| dtantsur | milan, mgould, we don't test nova boot as it is, we test that we didn't break it by our firewall rules | 09:02 |
| milan | mgould, rather the point of the test case shouldn't be nova boot only | 09:02 |
| dtantsur | milan, so what we test is: 1. successful introspection, 2. nova boot can still work | 09:03 |
| dtantsur | actually we could (and probably should) move introspection rules to the 2nd test: 1. create rules, 2. introspection works and runs rules | 09:03 |
| mgould | OK | 09:03 |
| dtantsur | there are not strictly related | 09:04 |
| dtantsur | * these | 09:04 |
| vdrok | morning mgould | 09:04 |
| mgould | and the setup needed to test those is "we have some nodes and no introspection rules"? | 09:04 |
| mgould | morning vdrok | 09:04 |
| lucasagomes | mgould, :-) | 09:05 |
| mgould | yeah, "nova boot still works" and "introspection runs" sound like separate tests | 09:05 |
| *** daemontool has quit IRC | 09:05 | |
| mgould | though I guess they share heavy setup | 09:05 |
| milan | mgould, I thought the same | 09:05 |
| *** daemontool has joined #openstack-ironic | 09:05 | |
| milan | so there should be test_Introspection | 09:06 |
| milan | rather TestIntrospectionClass | 09:06 |
| milan | TestNovaBootAfterIntrospectionClasss | 09:06 |
| milan | TestDiscoveryClass | 09:06 |
| mgould | if you've got two independent tests that share preconditions, setting up those preconditions is *exactly what setUp is for* | 09:06 |
| *** e0ne has joined #openstack-ironic | 09:06 | |
| milan | TestNovaBootAfterDiscoveryClass? | 09:06 |
| mgould | both inheriting from TestAfterDiscoveryClass, maybe | 09:07 |
| dtantsur | TestIntrospection, TestDiscovery :) lets not overcomplicate it | 09:07 |
| dtantsur | as test case can have more than 1 tests, y'know :) | 09:08 |
| mgould | yep :-) | 09:08 |
| dtantsur | in TestIntrospection we test various aspects of the introspection process: that it works, that it does not break nova, that it runs rules, .. (maybe more) | 09:08 |
| dtantsur | in TestDiscovery we at least test discovery, but maybe we can have more tests there too | 09:09 |
| dtantsur | we probably can't have too many tests per gate run, cause $timeouts, but 2-3 is still fine | 09:09 |
| milan | dtantsur, so TestIntrospection.test_introspection and TestIntrospection.test_nova_boot_after_introspection? | 09:10 |
| mgould | is "after introspection" what we care about, or "after creation of firewall rules"? | 09:10 |
| dtantsur | mgould, after introspection, I'd say | 09:10 |
| mgould | OK | 09:11 |
| milan | dtantsur, mgould then it ought to go separate class not to have interdependent test cases | 09:11 |
| milan | or? | 09:11 |
| dtantsur | so in test_introspection we test the process itself and rules? and in test_nova_boot we only test introspection + nova boot, right? | 09:11 |
| dtantsur | milan, they're not interdependent | 09:11 |
| mgould | less independent than I'd thought, then | 09:11 |
| milan | well, they are as test nova boot _after_ introspection implies dependency to me | 09:12 |
| milan | could be TestNovaBoot.after_introspection TestNovaBoot.after_discovery? | 09:12 |
| dtantsur | #pixiesay I don't get it --mood meh | 09:12 |
| PixieBoots | ¯\_(ツ)_/¯: I don't get it | 09:12 |
| milan | dtantsur, i.e. test_introspection is a precondition of working test_nova_boot_after_introspection from my pow | 09:13 |
| * mgould would just put the whole sequence in one test, in that case | 09:13 | |
| dtantsur | mgould, milan, https://etherpad.openstack.org/p/ironic-inspector-tempest | 09:13 |
| dtantsur | hope this is clear now :) | 09:15 |
| dtantsur | aarefiev, ^^^ | 09:15 |
| milan | dtantsur, missed test introspection without rules | 09:16 |
| dtantsur | milan, not sure it's valuable | 09:16 |
| aarefiev | why do you need separate test for all this cases? | 09:16 |
| milan | dtantsur, also doesn't test_introspection_with_rules failing imply test_with_nova failing? | 09:17 |
| dtantsur | milan, not necessary. imagine we broken the rule engine somehow | 09:17 |
| dtantsur | milan, also the nova one will not have explicit checks on e.g. properties content. only check that nova does boot with whatever we provided | 09:17 |
| aarefiev | I mean test_introspection_with_rules and test_introspection_with_nova_boot | 09:18 |
| mgould | I think the value of "test introspection without rules" would be that it would help us narrow down the causes of failures | 09:18 |
| mgould | with rules fails, without doesn't => bug in rule engine | 09:18 |
| dtantsur | mgould, this is covered by the nova test | 09:18 |
| mgould | etc | 09:18 |
| dtantsur | aarefiev, better failure separation? maybe we don't need it, dunno | 09:18 |
| dtantsur | my only point today is that stuff that we test should not go to setUp :) | 09:19 |
| milan | mgould, dtantsur, I'd say then for those 2 test cases Introspection is a setUp phase they share, right? | 09:19 |
| mgould | milan: no, because with-rules sets up rules first | 09:19 |
| dtantsur | setUp is not about sharing code | 09:19 |
| dtantsur | srsly | 09:19 |
| dtantsur | if you want to share some code, create a method | 09:19 |
| aarefiev | dtantsur: I'm agree with this, I had comment about this | 09:19 |
| openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/318851 | 09:19 |
| milan | dtantsur, setup is about precondition | 09:19 |
| *** dmk0202 has joined #openstack-ironic | 09:19 | |
| milan | they share the same precondition my point is | 09:19 |
| dtantsur | milan, setup is about setting about a test, yes, preconditions which is independent of the test subject | 09:19 |
| dtantsur | introspection IS a test subject | 09:20 |
| aarefiev | + 1000 | 09:20 |
| dtantsur | we test introspection: from its start to its end, and then its results. this should go to a test | 09:20 |
| dtantsur | we don't test nova boot as it is, we only test that it can work after introspection | 09:21 |
| dtantsur | (which we might easily break if we break our firewall logic) | 09:21 |
| milan | aarefiev, dtantsur so you say you'd put the steps in an order were it a single test case, then they're interdependent with given order all of them sharing the introspection pass as a precondition | 09:21 |
| milan | but OK :) | 09:21 |
| dtantsur | no interdependent tests please :) just see the etherpad, it has the whole flow | 09:22 |
| aarefiev | we can put all in one test for now, I don't see how it helps to separate test | 09:22 |
| aarefiev | also I would say introspection is not precondition, it's part of test scenario | 09:23 |
| milan | OK cool I was referring to lines #7 and #11 here being preconditions | 09:23 |
| dtantsur | I don't insist on separating, just thinking it would be cleaner | 09:23 |
| dtantsur | milan, no, it is what we test. precondition is e.g. having nodes enrolled or not having any stale introspection rules | 09:23 |
| mgould | yeah, AFAICT "run introspection" is the action under test, and "nova boot" is a very slow assertion | 09:23 |
| dtantsur | mgould++ well put | 09:24 |
| aarefiev | I'm not insist, doesn't matter | 09:24 |
| *** sambetts|afk is now known as sambetts | 09:24 | |
| sambetts | man there a ton of scroll back to read this morning ... | 09:25 |
| * mgould also thinks separating the two tests is cleaner, but squashing it into one test wouldn't be a disaster | 09:25 | |
| aarefiev | morning sambetts | 09:25 |
| mgould | sambetts: tl;dr bikeshedding over test structure | 09:25 |
| milan | morning sambetts | 09:25 |
| mgould | also morning sambetts | 09:25 |
| dtantsur | sambetts, good morning, happy Friday and enjoy the scrollback :D | 09:25 |
| sambetts | Happy Friday :D | 09:25 |
| mgould | sambetts: https://review.openstack.org/#/c/293926/14/ironic_inspector/test/inspector_tempest_plugin/tests/test_basic.py@65 is the test-case under discussion | 09:26 |
| vsaienko | dtanstur, jroll I have a question | 09:26 |
| milan | dtantsur, aarefiev, mgould OK, let's make it a single test case bumping the steps in a single scenario | 09:26 |
| vsaienko | After upgrade ramdisk from Mitaka should work on Newton or not? | 09:26 |
| milan | mgould, dtantsur aarefiev let's remove line #10? | 09:27 |
| dtantsur | vsaienko, should, yes | 09:27 |
| vsaienko | at the moment it doen't work http://logs.openstack.org/09/311109/36/experimental/gate-grenade-dsvm-partial-ironic/076b225/logs/new/screen-ir-cond.txt.gz#_2016-05-20_08_55_01_087 | 09:27 |
| milan | (and #11) | 09:27 |
| mgould | milan: cool, works for me | 09:27 |
| dtantsur | milan, 10 and 11 then, yes. I'm fine with that too | 09:27 |
| milan | OK | 09:27 |
| milan | ok, cool | 09:27 |
| * milan hacks | 09:27 | |
| sambetts | dtantsur, vsaienko: and this is why we need upgrade testing | 09:27 |
| dtantsur | vsaienko, oh hmm... lets wait for jroll then | 09:28 |
| dtantsur | sambetts, +1000 | 09:28 |
| vsaienko | might backport wipe_disk_metadata to Mitaka? | 09:28 |
| aarefiev | milan: line 10? | 09:28 |
| vsaienko | sambetts definitely :). It is a little bit complicated to make it working at this stage :-D | 09:29 |
| dtantsur | vsaienko, feature backport is a no-go. we can recommend updating the ramdisk first. but for the future we need to think more when we introduce something like that | 09:29 |
| milan | aarefiev, ack | 09:29 |
| dtantsur | vsaienko, maybe we should always update IPA first | 09:29 |
| milan | aarefiev, 10&11 | 09:29 |
| dtantsur | aarefiev, this is about the etherpad, not the source file | 09:29 |
| mgould | aarefiev: line 10 of https://etherpad.openstack.org/p/ironic-inspector-tempest used to start another test method | 09:29 |
| vsaienko | dtanstur upgrading ramdisk during upgrade require to update all nodes info, if we are ok with this we can do it | 09:29 |
| sambetts | dtantsur, vsaienko: newton IPA should work with mitaka ironic yes? We've not removed anything | 09:29 |
| aarefiev | ahh, so make test w/o nova boot | 09:30 |
| aarefiev | ? | 09:30 |
| dtantsur | sambetts, yeah, but mitaka IPA does not seem to work with newton ironic. maybe it's fine. | 09:30 |
| dtantsur | aarefiev, the opposite. have only one test with everything (like we have now) | 09:30 |
| lucasagomes | dtantsur, oh really ? :-/ | 09:30 |
| dtantsur | we can split it later if we want | 09:30 |
| lucasagomes | you know what is broken there? | 09:30 |
| * lucasagomes adds to his todo to test it | 09:31 | |
| dtantsur | lucasagomes, yep. ironic used a new argument. actually we could be more careful with that | 09:31 |
| dtantsur | wipe_disk_metadata it is | 09:31 |
| sambetts | dtantsur: I think that makes sense, because there are new things in newton that aren't in mitaka IPA | 09:31 |
| lucasagomes | dtantsur, oh right I kinda remember that, there was bugzilla about it right? | 09:31 |
| lucasagomes | or someone internally was testing it I believe | 09:31 |
| aarefiev | dtantsur: https://etherpad.openstack.org/p/ironic-inspector-tempest looks good | 09:31 |
| lucasagomes | that sucks | 09:31 |
| sambetts | or do we support +1 -1 on IPA too, if thats the case we need IPA API versioning | 09:31 |
| sambetts | :'( | 09:32 |
| lucasagomes | sambetts, yeah, I'm afraid so | 09:32 |
| * dtantsur runs away | 09:32 | |
| * sambetts hides | 09:32 | |
| lucasagomes | heh | 09:32 |
| * mgould wonders how we can get the other four permutations of {I,P,A} in there too... | 09:32 | |
| sambetts | I wish we could un-lockstep IPA and make it always backward compatible (which it is now basicly) | 09:33 |
| sambetts | its obviously just not forward compatible | 09:34 |
| *** jtomasek_ has joined #openstack-ironic | 09:34 | |
| sambetts | which is fine, but I think we might have to add code into Ironic to turn off features if your using an older IPA | 09:35 |
| mgould | does IPA currently identify how old it is in any way? | 09:35 |
| dtantsur | mgould, I don't think so | 09:39 |
| sambetts | :/ I guess we could do it just by detecting the http error responses | 09:42 |
| dtantsur | FYI: disabling cleaning in inspector jobs, should make us a bit faster https://review.openstack.org/#/c/319165/ | 09:47 |
| dtantsur | actually with switch to tinyipa it's already pretty fast, yay! | 09:49 |
| dtantsur | (and with removing the DIB job ofc) | 09:49 |
| * mgould votes that the next time we create an API, we version it *just in case* | 09:50 | |
| dtantsur | versioning has it's own problems | 09:51 |
| *** devananda has quit IRC | 09:52 | |
| dtantsur | e.g. with Ironic version schema we would have exactly the same breakage | 09:52 |
| dtantsur | because every time we use a new feature, we have to bump the version we demand | 09:52 |
| dtantsur | mgould, ^^^ | 09:52 |
| openstackgerrit | Merged openstack/ironic: Replace project clients calls with openstack client https://review.openstack.org/318567 | 09:53 |
| jroll | dtantsur: lucasagomes: vsaienko: sigh, I would prefer not needing to upgrade IPA at the same time as ironic | 10:02 |
| jroll | :( | 10:02 |
| dtantsur | yeah... | 10:02 |
| jroll | I guess we need to decide upgrade order, too | 10:02 |
| dtantsur | but then we need to somehow do version negotiation (yay!) | 10:03 |
| mgould | dtantsur: I thought the problem with Ironic API versions was that there were pre-versioned clients out there to which we can never say "go away, you're too old" | 10:03 |
| jroll | but we could say IPA always goes first, or ironic always goes first | 10:03 |
| mgould | because they wouldn't understand it | 10:03 |
| jroll | instead of version negotiation | 10:03 |
| *** devananda has joined #openstack-ironic | 10:03 | |
| mgould | jroll: sounds sensible | 10:03 |
| vdrok | morning jroll, maybe we should add something like https://github.com/openstack/ironic-python-agent/blob/16265a6c8bcbd5fb21be82197d77d85739577fc2/ironic_python_agent/extensions/clean.py#L49 to iscsi extension | 10:03 |
| * jroll oh noez ipa upgrade testing D: | 10:04 | |
| jroll | vdrok: that's an idea too | 10:04 |
| *** amotoki has quit IRC | 10:05 | |
| *** milan has quit IRC | 10:06 | |
| jroll | so for the short term, we can say for newton we screwed up and you must upgrade IPA first, and we can express that in the release notes and grenade's from-mitaka | 10:06 |
| jroll | s/newton/newton and 6.0.0/ | 10:06 |
| *** mbound has quit IRC | 10:06 | |
| jroll | which means we should probably release IPA before 6.x | 10:06 |
| * jroll assumes new IPA works with mitaka ironic | 10:07 | |
| jroll | that's the other way we could do grenade right now, always use latest IPA | 10:07 |
| dtantsur | jroll, ideally we should do both... | 10:08 |
| vdrok | jroll: the fastest way I think is to do kwargs instead of argument in that function | 10:08 |
| jroll | dtantsur: yeah | 10:08 |
| dtantsur | vdrok, it's not really good to ignore arguments, unless we always guarantee that they're not important | 10:09 |
| jroll | vdrok: well... not sure that's backportable | 10:09 |
| jroll | it would need to happen on mitaka | 10:09 |
| dtantsur | it could be backportable, but I'd say it's dangerous | 10:09 |
| vdrok | it's just that using old ramdisk with new ironic makes more sense that using new ramdisk with old ironic :) | 10:09 |
| *** stendulker has joined #openstack-ironic | 10:10 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 10:10 |
| vsaienko | jroll so for now we going to upgrade IPA with Ironic, and in Ocata we will guarantee Newton IPA works with Ocata Ironic? | 10:10 |
| vsaienko | vdrok we will not use new ramdisk with old ironic | 10:10 |
| jroll | vsaienko: I'm thinking so, dtantsur ^^ | 10:11 |
| jroll | keep in mind I'm still on coffee #1 | 10:11 |
| vdrok | lucasagomes: wdyt on ^ | 10:13 |
| *** amotoki has joined #openstack-ironic | 10:13 | |
| sambetts | o/ jroll | 10:14 |
| vdrok | morning sambetts | 10:15 |
| sambetts | hey vdrok | 10:15 |
| jroll | morning sambetts | 10:15 |
| jroll | the other option here is revert the offending feature and figure out how to make it not blow up on older ramdisk | 10:15 |
| *** fragatina has quit IRC | 10:20 | |
| *** fragatina has joined #openstack-ironic | 10:20 | |
| sambetts | couldn't we just add code into newton that detects if the requested operation fails and detect that its a unsupported feature at that point and gracefully degrade? | 10:22 |
| jroll | sambetts has clearly had more coffee than I | 10:23 |
| *** fragatin_ has joined #openstack-ironic | 10:24 | |
| *** fragatina has quit IRC | 10:24 | |
| sambetts | heh | 10:25 |
| * sambetts also on his first surprisingly | 10:25 | |
| jroll | do log.debug need _() ? | 10:25 |
| * jroll writing a patch | 10:25 | |
| sambetts | No | 10:26 |
| dtantsur | jroll, no, no i18n for debug | 10:26 |
| * lucasagomes reads | 10:27 | |
| jroll | thanks | 10:27 |
| lucasagomes | jroll, yeah same about upgrading IPA, it should be compatible :-/ | 10:27 |
| *** fragatin_ has quit IRC | 10:28 | |
| lucasagomes | vdrok, kwargs does guarantee that it won't break, but I'm afraid that ignoring something important may not be the perfect solution. Say we pass something like disk_label gpt but got ignored by IPA, now deployment finishes sucessfully but it's different than what I requested | 10:30 |
| lucasagomes | or things like that | 10:30 |
| vsaienko | jroll, I'm going to revert https://github.com/openstack/ironic/commit/1a4bf23ce5773726fc776369b483254d13d54f2b place it in the chain and launch tests. Who knows what surprises waits us in future. In meantime lets find a good fix for this. | 10:31 |
| lucasagomes | vdrok, ansible driver o/ | 10:31 |
| jroll | vsaienko: one sec, I have a patch coming | 10:31 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Gracefully degrade wipe_disk_metadata for Mitaka ramdisk https://review.openstack.org/319183 | 10:32 |
| jroll | vsaienko: ^ give that a try | 10:32 |
| openstackgerrit | Yibo Cai proposed openstack/ironic: devstack: Configure console device name https://review.openstack.org/319184 | 10:32 |
| *** YiboCai has quit IRC | 10:33 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: grenade checking https://review.openstack.org/311109 | 10:34 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Gracefully degrade wipe_disk_metadata for Mitaka ramdisk https://review.openstack.org/319183 | 10:34 |
| vdrok | lucasagomes: yep :) | 10:34 |
| *** amotoki has quit IRC | 10:35 | |
| *** thrash|g0ne is now known as thrash | 10:35 | |
| *** fragatina has joined #openstack-ironic | 10:36 | |
| vsaienko | jroll, launched tests | 10:36 |
| vsaienko | jroll, could you please review https://review.openstack.org/#/c/318521/. There is no need to launch tempest tests from devstack-gate, since we running smoke tests after upgrade. | 10:37 |
| *** fragatina has quit IRC | 10:40 | |
| jroll | vsaienko: done, thanks | 10:40 |
| vsaienko | jroll, thanks | 10:41 |
| *** alaski is now known as lascii | 10:43 | |
| *** milan has joined #openstack-ironic | 10:51 | |
| *** sacharya has joined #openstack-ironic | 10:56 | |
| mgould | vsaienko: are we now running upgrade tests in gate? | 11:00 |
| *** sacharya has quit IRC | 11:01 | |
| jroll | mgould: no, they're still experimental | 11:06 |
| jroll | but we're running them in upstream CI if that's your question | 11:06 |
| mgould | OK, thanks | 11:07 |
| mgould | I didn't think we were running them yet, so I was confused at a patch which seems to assume we are | 11:07 |
| jroll | ah | 11:09 |
| jroll | yeah, 'check experimental' runs them | 11:09 |
| mgould | cool, thanks | 11:09 |
| *** zzzeek has quit IRC | 11:12 | |
| openstackgerrit | Tan Lin proposed openstack/ironic-specs: Support rolling upgrades https://review.openstack.org/299245 | 11:15 |
| milan | dtantsur, how do I overwrite the version here: https://review.openstack.org/#/c/293926/14/ironic_inspector/test/inspector_tempest_plugin/tests/manager.py,unified line #36 cls.baremetal_client.api_version = 1.8? | 11:15 |
| dtantsur | milan, just create a new client instance, I guess. I don't think ironicclient officially supports overriding the version | 11:16 |
| aarefiev | dtantsur: tempest doesn't use projects clients | 11:17 |
| aarefiev | it uses own clients | 11:18 |
| milan | aarefiev, dtantsur so how to deal with the version? | 11:18 |
| dtantsur | oh damn... | 11:18 |
| aarefiev | looks like ironic doesn't support version yet | 11:18 |
| dtantsur | maybe we need a wrapper than to always prepend the version header? | 11:18 |
| dtantsur | we can't test inspection with the default 1.1 :) | 11:19 |
| aarefiev | yeah, pass in header manually | 11:19 |
| dtantsur | my point was: if we do that (and we have to), we need to do it in every request to Ironic | 11:19 |
| dtantsur | that's how versioning is expected to be used at least :) | 11:20 |
| milan | dtantsur, aarefiev how about fixing that in a pull request for the baremetal_client | 11:20 |
| milan | ? | 11:20 |
| aarefiev | and it should be done in ironic someвфн :) | 11:21 |
| aarefiev | someday | 11:21 |
| sambetts | вфн well those are some fun characters XD | 11:21 |
| dtantsur | milan, +1. I know Yuiko was working on it some time ago, but I don't know the status | 11:21 |
| mgould | sambetts: Cyrillic for "vfn" | 11:21 |
| aarefiev | slow layout switching :) | 11:21 |
| dtantsur | hehe | 11:21 |
| sambetts | hehe | 11:21 |
| dtantsur | aarefiev, I have layout switching on caps lock, so I do hit it sometimes | 11:22 |
| jroll | dtantsur: https://review.openstack.org/#/c/260358/ | 11:22 |
| aarefiev | :) | 11:22 |
| * mgould has Win+Space, which is pretty hard to hit accidentally | 11:22 | |
| milan | aarefiev, dtantsur so keep the workaround then? | 11:22 |
| milan | for the moment? | 11:22 |
| * jroll consider just merging that | 11:23 | |
| dtantsur | oh | 11:23 |
| dtantsur | milan, looks like we merge https://review.openstack.org/#/c/260358/ and then use ironic_tempest_plugin instead | 11:23 |
| jroll | then we just need the tempest.conf changes somehow | 11:23 |
| jroll | (and more tests) | 11:23 |
| milan | dtantsur, Updated 3 months ago | 11:24 |
| milan | sounds scary | 11:24 |
| milan | #pixiesay milan hesitates what to do now -m confused | 11:27 |
| PixieBoots | ʕ๏ᴥ๏ʔ: milan hesitates what to do now | 11:27 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add support API microversions for Tempest tests https://review.openstack.org/260358 | 11:27 |
| jroll | rebased that to make sure it still works | 11:27 |
| jroll | it's only so old because we've been bad reviewers :) | 11:27 |
| aarefiev | also we need to switch on ironic plugin client | 11:28 |
| milan | jroll, so to overwrite that version in one's manager he'd just super(MyManager, cls).setup_clients(); cls.baremetal_client.set_api_microversion('1.8') correct? | 11:30 |
| dtantsur | jroll, it needs reworking, tempest has changed since then... | 11:31 |
| jroll | milan: I'm not sure | 11:31 |
| jroll | dtantsur: of course :/ | 11:31 |
| milan | jroll, ok cool, I'm trying to figure out how to use it to solve the version requirement we have in inspector test | 11:33 |
| *** daemontool has quit IRC | 11:34 | |
| xavierr | #pixiesay good morning Ironic | 11:35 |
| PixieBoots | ʕ•͡ᴥ•ʔ: good morning Ironic | 11:35 |
| dtantsur | milan, we can start with something simple, if possible.. | 11:35 |
| milan | dtantsur, +1 | 11:36 |
| milan | dtantsur, what do you suggest? | 11:36 |
| dtantsur | milan, dunno. maybe a subclass of BaremetalClient redefining get/set/put/post to append a fixed version? | 11:36 |
| dtantsur | whatever we can quickly hack to not get blocked right away | 11:36 |
| dtantsur | woohoo, ironic projects got stable:follows-policy tags! | 11:37 |
| sambetts | \o/ | 11:37 |
| mgould | \o/ | 11:38 |
| milan | dtantsur, OK, I'll do that inspiration | 11:41 |
| milan | to be taken from the micro version patch correct? | 11:41 |
| *** hoangcx has quit IRC | 11:41 | |
| *** daemontool has joined #openstack-ironic | 11:41 | |
| dtantsur | right | 11:42 |
| *** athomas has joined #openstack-ironic | 11:42 | |
| *** baoli has joined #openstack-ironic | 11:43 | |
| *** baoli_ has joined #openstack-ironic | 11:44 | |
| *** baoli has quit IRC | 11:47 | |
| *** nico-afk is now known as nicodemos | 11:48 | |
| nicodemos | morning xavierr and ironic | 11:49 |
| *** mbound has joined #openstack-ironic | 11:51 | |
| mat128 | o/ nicodemos | 11:52 |
| xavierr | morning nicodemos mat128 aarefiev dtantsur jroll | 11:52 |
| mat128 | good morning everyone | 11:53 |
| mat128 | incl xavierr :D | 11:53 |
| nicodemos | mat128 \o | 11:53 |
| mgould | morning xavierr mat128 | 11:54 |
| xavierr | morning mgould \o\ | 11:55 |
| *** nicodemos has quit IRC | 12:02 | |
| *** lucasagomes is now known as lucas-hungry | 12:02 | |
| *** jtomasek_ has quit IRC | 12:05 | |
| *** jtomasek_ has joined #openstack-ironic | 12:05 | |
| dtantsur | as we're working on upgrades, I'm creating an official "upgrade" bug tag, wdyt? | 12:08 |
| mgould | dtantsur: +1 | 12:08 |
| mat128 | dtantsur: good idea | 12:08 |
| openstackgerrit | Sam Betts proposed openstack/ironic: [DO NOT MERGE] Testing Cisco CI https://review.openstack.org/289312 | 12:08 |
| * sambetts 's CI made had a hissyfit again because my test team rebooted jenkins | 12:10 | |
| *** rbudden has joined #openstack-ironic | 12:13 | |
| dtantsur | #pixiesay -m meh | 12:13 |
| PixieBoots | ¯\_(ツ)_/¯ | 12:13 |
| *** daemontool_ has joined #openstack-ironic | 12:14 | |
| mat128 | #pixiesay you should never reboot Jenkins :D | 12:14 |
| PixieBoots | ʕ•͡ᴥ•ʔ: you should never reboot Jenkins :D | 12:14 |
| *** dprince has joined #openstack-ironic | 12:14 | |
| sambetts | hehe | 12:15 |
| *** jtomasek_ has quit IRC | 12:16 | |
| *** ayoung has quit IRC | 12:16 | |
| *** jtomasek has joined #openstack-ironic | 12:16 | |
| * dtantsur has to rebuild his devstack vm, because he dared rebooting it and upgrading the host machine. Not the vm panics on start up >_< | 12:17 | |
| *** daemontool has quit IRC | 12:17 | |
| sambetts | :( | 12:17 |
| *** piet has joined #openstack-ironic | 12:18 | |
| mat128 | dtantsur: panics! | 12:19 |
| mat128 | weird | 12:19 |
| * mat128 uses a cloud instance for devstack 8) | 12:20 | |
| dtantsur | I have a pretty powerful Dell Tower machine which is always on and I use it as a virt host (+ IRC bouncer) | 12:22 |
| * parlos tries to get devstack+ironic working using http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack as reference. | 12:22 | |
| *** amotoki has joined #openstack-ironic | 12:22 | |
| dtantsur | I used to have a separate bare metal server for devstack, but they took it away :) | 12:24 |
| * parlos started with a Windows VirtBox VM; failed. Then Linux BM; but conflicts with gitlab.. Now third try (a charm?) with BM linux (but with xen configured). | 12:25 | |
| *** trown|outtypewww is now known as trown | 12:25 | |
| *** afaranha has quit IRC | 12:25 | |
| *** amotoki has quit IRC | 12:32 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: [WIP] Remove support for the old bash ramdisk https://review.openstack.org/319227 | 12:35 |
| dtantsur | here is starts \o/ | 12:38 |
| sambetts | \o/ | 12:38 |
| dtantsur | the patch is not quite ready, just checking if I'm removing too much | 12:38 |
| *** fellypefca has joined #openstack-ironic | 12:39 | |
| *** piet has quit IRC | 12:40 | |
| *** piet has joined #openstack-ironic | 12:43 | |
| parlos | Have a nice weekend, bye bye | 12:43 |
| sambetts | cya parlos | 12:44 |
| *** parlos has quit IRC | 12:48 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: grenade checking https://review.openstack.org/311109 | 12:54 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Gracefully degrade wipe_disk_metadata for Mitaka ramdisk https://review.openstack.org/319183 | 12:54 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Move all cleanups to cleanup_ironic https://review.openstack.org/318660 | 12:54 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Restart n-cpu after Ironic install https://review.openstack.org/318479 | 12:54 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Make sure create_ovs_taps createse uniq taps https://review.openstack.org/319101 | 12:54 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Keep backward compatibility for openstack port crate https://review.openstack.org/319232 | 12:54 |
| *** piet has quit IRC | 12:55 | |
| *** sacharya has joined #openstack-ironic | 12:57 | |
| dtantsur | jroll, did we ever discuss an ironicclient command to import 1 or more nodes from a JSON? | 12:59 |
| jroll | dtantsur: we did, at some point, but never did it | 13:00 |
| *** lucas-hungry is now known as lucasagomes | 13:00 | |
| jroll | dtantsur: I think the conclusion was "this is what for loops are for" | 13:00 |
| dtantsur | jroll, I'm trying to reduce the amount of things that tripleo reinvents, and this is one of them. | 13:00 |
| dtantsur | jroll, not sure I get it, what do you mean? | 13:01 |
| jroll | dtantsur: I think this isn't out of the question for people to handle on their own | 13:01 |
| jroll | everyone's enrollment process is a bit different | 13:01 |
| jroll | for example, ours involves touching our CMDB | 13:01 |
| lucasagomes | dtantsur, jroll I once proposed having something in yaml, that looks like: http://paste.openstack.org/show/497895/ | 13:02 |
| jroll | so I'm not sure how useful it is, other than moving code from tripleo to ironicclient | 13:02 |
| dtantsur | jroll, well, tripleo already has this command, so I wonder if more people could benefit | 13:02 |
| *** sacharya has quit IRC | 13:02 | |
| lucasagomes | I still have some code for it, it checks against a schema and things like that | 13:02 |
| dtantsur | lucasagomes, yeah, that's what I was thinking about (modulo also supporting JSON) | 13:02 |
| * lucasagomes I don't think I've put a patch for it up tho, but I do have a PoC | 13:03 | |
| *** cdearborn has joined #openstack-ironic | 13:03 | |
| lucasagomes | dtantsur, jroll I think bifrost has something similar too | 13:03 |
| jroll | yeah, I'm not strongly opinionated, I just feel like it's a distraction and more code to carry | 13:04 |
| lucasagomes | to import nodes from json or yaml (not sure which) | 13:04 |
| cinerama | oh yeah we can import stuff from json, csv etc | 13:04 |
| lucasagomes | jroll, right, yeah it worth checking if there are multiple implementations say tripleo, bifrost, <something else> | 13:04 |
| lucasagomes | I believe it's good to have a de-facto one in our client | 13:04 |
| lucasagomes | since the client is suppose to facilitate usage | 13:05 |
| lucasagomes | (so it won't be in the API like a PUT, only in the client) | 13:05 |
| mat128 | lucasagomes: cat + xargs ftw :) | 13:05 |
| jroll | lucasagomes: yeah, I'm just imagining the feature explosion, e.g. validating every possible driver_info field etc | 13:06 |
| lucasagomes | jroll, oh no, that's way out | 13:06 |
| jroll | lucasagomes: someone will add it, guarantee | 13:06 |
| dtantsur | jroll, no logic there, just take JSON, create a node, update fields that are not part of node-create API | 13:06 |
| lucasagomes | like the schema was checking for things like uuid syntax, mac address syntax | 13:06 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic-python-agent: TEST COMMIT https://review.openstack.org/305473 | 13:06 |
| jroll | what fields are not part of our node-create api O_o | 13:06 |
| lucasagomes | jroll, heh yeah if that happens we have to block it | 13:06 |
| mat128 | lucasagomes: we have to version this schema then? | 13:06 |
| dtantsur | jroll, we did this mistake in tripleo, it's horrible, I'll -2 every attempt to do client-side validation | 13:06 |
| lucasagomes | mat128, good question, it's possible | 13:07 |
| lucasagomes | mat128, at the time I don't think we had microversions in place | 13:07 |
| jroll | dtantsur: but we don't do server side validation of driver_info etc fields | 13:07 |
| dtantsur | jroll, well, this is to be fixed on server side then. client side is only JSON -> API | 13:07 |
| mat128 | lucasagomes: if we were to offer an --import-from-file option in our client, the schema for that file must be consistent across releases | 13:07 |
| dtantsur | mat128, the schema for this file would be: whatever /v1/node/detail returns | 13:08 |
| dtantsur | i.e. what we show, the same we accept | 13:08 |
| jroll | dtantsur: going back, what fields are not part of our node-create api? | 13:08 |
| lucasagomes | jroll, target_ | 13:08 |
| dtantsur | jroll, I'm not sure, maybe none.. I got this assumption somehow, but now I can't remember | 13:08 |
| lucasagomes | there a couple | 13:08 |
| jroll | lucasagomes: target_? | 13:09 |
| lucasagomes | target_provision_state | 13:09 |
| lucasagomes | and power | 13:09 |
| dtantsur | well, we're not supposed to allow setting read only fields | 13:09 |
| jroll | sure, that isn't part of node-update api | 13:09 |
| jroll | either* | 13:09 |
| *** daemontool_ has quit IRC | 13:09 | |
| jroll | dtantsur said "take JSON, create a node, update fields that are not part of node-create API", that's what I'm asking about | 13:09 |
| lucasagomes | jroll, yeah it's not | 13:09 |
| dtantsur | jroll, ignore that. I was under assumption that we only accept a few fields for POST. Friday... | 13:10 |
| jroll | :) | 13:10 |
| lucasagomes | jroll, oh right, I believe we can create a node with everything we need (for the writable fields ofc) in oneinput | 13:10 |
| jroll | at any rate, I honestly don't find this super important | 13:11 |
| jroll | not necessarily opposed | 13:11 |
| dtantsur | jroll, so yeah, it could be: for node in json: for port in node['ports']: create_port(port) create_node(node) | 13:11 |
| dtantsur | another interesting feature people request is to be able to *update* a node from such file. or ever *create-or-update* which is MUCH funnier | 13:12 |
| lucasagomes | dtantsur, yeah, that would require the file to actually have the id's | 13:12 |
| jroll | right, you see how far this rabbit hole goes :) | 13:12 |
| dtantsur | lucasagomes, it's worse, but lets put it aside :) | 13:13 |
| dtantsur | jroll, well, we have a -2 button to prevent it from going too far, right? ;) | 13:13 |
| lucasagomes | TheJulia, ^ I think bifrost does have it, no? | 13:13 |
| jroll | dtantsur: sure, after we spend hours discussing if it's too far :) | 13:14 |
| *** parlos has joined #openstack-ironic | 13:14 | |
| dtantsur | neither the first time, nor the last :) | 13:14 |
| mat128 | don't forget provision_state | 13:14 |
| mat128 | cant set that | 13:14 |
| mat128 | in case you want to do /v1/node/detail | ironic --load-from-json | 13:15 |
| jroll | dtantsur: we're used to it so let's keep wasting time on it? | 13:15 |
| jroll | what I'm trying to say is, if it's just a simple for loop | 13:15 |
| jroll | that's easy enough for folks to do on their own | 13:15 |
| dtantsur | jroll, could you please type this for loop if it's so simple? noting that our CLI does not accept JSON right now | 13:16 |
| jroll | dtantsur: use the python sdk... | 13:16 |
| dtantsur | jroll, we're talking about CLI now.. do you want people to continue developing "additions" for our CLI? | 13:16 |
| jroll | dtantsur: I don't think our cli needs to do everything | 13:16 |
| dtantsur | jroll, I'm trying to fight this right now: https://github.com/openstack/python-tripleoclient/blob/master/setup.cfg#L58-L64 | 13:17 |
| dtantsur | jroll, well, our API does allow creating a node from JSON. our CLI does not. | 13:17 |
| mat128 | dtantsur: for node in json.loads(json_data): ironic.node.create(**node) | 13:17 |
| dtantsur | mat128, bash: syntax error near unexpected token `(' | 13:17 |
| mat128 | was python | 13:18 |
| mat128 | gimme a sec :) | 13:18 |
| dtantsur | right :) and I'm talking about CLI | 13:18 |
| dtantsur | if you give me a python example, don't forget the whole authentication btw | 13:18 |
| mat128 | well, same applies to having a working ironic CLI | 13:18 |
| mat128 | ironic node-list | 13:18 |
| mat128 | or whatev | 13:18 |
| dtantsur | anyway, we're talking about CLI and mere users, not programmers | 13:19 |
| lucasagomes | jroll, JayF off-topic the current discussion. I was reviewing the rolling upgrade spec and there's a couple of meantions to re-loading the config via SIGHUP, which is tricky and unsupported in Ironic AFAICT | 13:19 |
| cinerama | here's our relevant science re json: http://git.openstack.org/cgit/openstack/bifrost/tree/bifrost/inventory.py | 13:19 |
| lucasagomes | jroll, JayF since you guys have been managing and upgrading ironic for some time, do you have some of it downstream? | 13:19 |
| lucasagomes | even tho I don't think you guys do rolling upgrade, right? | 13:19 |
| jroll | lucasagomes: we don't have that downstream, no | 13:20 |
| lucasagomes | right, ok I will take a look at it see if there's a nice way of doing it | 13:20 |
| jroll | lucasagomes: yeah, I'd comment on the spec and ask for it to be added as a work item or removed | 13:21 |
| jroll | lucasagomes: fwiw, nova has this | 13:21 |
| lucasagomes | my concern is more about periodic tasks, since the decorators gets a directly value for spacing (spacing=<value>) | 13:21 |
| jroll | maybe oslo.service does? | 13:21 |
| lucasagomes | jroll, I did | 13:21 |
| lucasagomes | jroll, it does handle the signal yes, but still we need to reload | 13:21 |
| mat128 | dtantsur: I agree with you, it's not trivial and the proof is https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v1/baremetal.py#L147 | 13:22 |
| jroll | lucasagomes: yeah | 13:22 |
| mat128 | it's a class on it's own | 13:22 |
| lucasagomes | like the periodic task there, the problem is, the value is in the decorator so won't be reloaded | 13:22 |
| dtantsur | mat128, this thing does way too much stuff tbh | 13:22 |
| lucasagomes | a possible solution was to have spacing to receive a reference to a function, that returns the value | 13:22 |
| lucasagomes | so it can be update on-the-fly | 13:22 |
| mat128 | dtantsur: it probably started as a csv -> ironic node-create | 13:22 |
| mat128 | or json | 13:22 |
| mat128 | dtantsur: and then, feature creep | 13:22 |
| * lucasagomes looks at nova | 13:22 | |
| jroll | lucasagomes: yeah, so we could say certain configs don't reload with SIGHUP | 13:23 |
| lucasagomes | jroll, right, which is a bit strange... I mean, how to identify those? | 13:23 |
| dtantsur | mat128, yeah. that inevitably will happen with a 3rd party enrolling implementation. people will start to make it too specific. that's why I'd love us to have a simple common basis | 13:23 |
| lucasagomes | jroll, it really should be able to update it all, if done right | 13:23 |
| jroll | lucasagomes: sure | 13:23 |
| lucasagomes | dtantsur, mat128 fwiw https://github.com/openstack/bifrost/blob/fa5f65adeff340f8415be46754cb327a3912852d/bifrost/inventory.py | 13:24 |
| jroll | dtantsur: so like I said, I'm not strictly opposed, I just think we'll feature creep on it for something that isn't incredibly useful | 13:24 |
| jroll | I struggle to find a person that can build a json file in the prescribed schema, that also wouldn't be able to program for the ironic sdk | 13:25 |
| jroll | (without writing that json by hand, which is just as annoying as doing node-create commands one by one) | 13:25 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: WIP: grenade checking https://review.openstack.org/311109 | 13:25 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Keep backward compatibility for openstack port crate https://review.openstack.org/319232 | 13:25 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Gracefully degrade start_iscsi_target for Mitaka ramdisk https://review.openstack.org/319183 | 13:25 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Move all cleanups to cleanup_ironic https://review.openstack.org/318660 | 13:26 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Restart n-cpu after Ironic install https://review.openstack.org/318479 | 13:26 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Make sure create_ovs_taps createse uniq taps https://review.openstack.org/319101 | 13:26 |
| dtantsur | jroll, believe me or not, folks deploying tripleo in fields write it by hand.. | 13:26 |
| dtantsur | jroll, and they're not programmers | 13:26 |
| jroll | dtantsur: they write the json by hand? | 13:26 |
| dtantsur | jroll, yep (I'm not saying it's great fwiw) | 13:26 |
| jroll | dtantsur: why is that easier than writing all the node-create commands by hand? | 13:26 |
| *** mjura has quit IRC | 13:27 | |
| dtantsur | jroll, the only reason I can think of is repeatability | 13:27 |
| mat128 | jroll dtantsur could as well maintain a shell script with ironic node-create || ironic node-update ;) | 13:27 |
| dtantsur | I don't disagree with that :) | 13:27 |
| *** nicodemos has joined #openstack-ironic | 13:27 | |
| jroll | there's repeatability in the node-create too... | 13:27 |
| *** parlos has quit IRC | 13:27 | |
| jroll | anyway, my view doesn't change here | 13:28 |
| jroll | but I'm not a dictator | 13:28 |
| jroll | unfortunately I can't tell people what to work on either | 13:28 |
| jroll | so, do what you will | 13:28 |
| jroll | but I think it's a poor use of our time | 13:28 |
| dtantsur | got it, thanks | 13:28 |
| *** dansmith is now known as superdan | 13:31 | |
| dtantsur | jroll, on an unrelated topic: could you please take a look at https://review.openstack.org/317969 ? this is hardware_initialize with the sleep bit stripped away to another patch | 13:31 |
| *** ayoung has joined #openstack-ironic | 13:33 | |
| *** sabeen has joined #openstack-ironic | 13:34 | |
| openstackgerrit | Vincent S. Cojot proposed openstack/ironic: Makes the vbox driver work on headless VirtualBox machines https://review.openstack.org/311278 | 13:37 |
| jroll | dtantsur: just one thing | 13:37 |
| dtantsur | ouch, good catch | 13:37 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-lib: Clarify which projects are meant to use the ironic-lib https://review.openstack.org/319251 | 13:38 |
| lucasagomes | jroll, devananda rloo^ | 13:39 |
| lucasagomes | since we reached a decision in the ML about it | 13:39 |
| * lucasagomes think so at least | 13:39 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent: Add hardware manager interface for hardware initialization https://review.openstack.org/317969 | 13:40 |
| dtantsur | jroll, ^^^ | 13:40 |
| jroll | lucasagomes: ++ | 13:40 |
| jroll | dtantsur: +2 | 13:41 |
| dtantsur | thnx | 13:41 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent: Add a configurable sleep before IPA starts working https://review.openstack.org/318745 | 13:42 |
| dtantsur | and this is what we all hate :( | 13:42 |
| sambetts | Yup :( | 13:43 |
| * sambetts wishes we lived in a more event driven world | 13:43 | |
| ElCoyote_ | dtantsur: Good morning.. :) | 13:43 |
| ElCoyote_ | and good morning everyone else also.. :) :) :) | 13:44 |
| *** daemontool has joined #openstack-ironic | 13:44 | |
| mgould | morning ElCoyote_ | 13:44 |
| sambetts | Hi ElCoyote_ ! | 13:44 |
| *** joprovost has joined #openstack-ironic | 13:45 | |
| dtantsur | ElCoyote_, morning | 13:45 |
| *** links has quit IRC | 13:46 | |
| *** smoriya has quit IRC | 13:46 | |
| lucasagomes | ElCoyote_, morning | 13:47 |
| ElCoyote_ | That's my first commit in Openstack land.. it started a few weeks ago with just a few changed lines and have evolved into something more fully implemented.. I've also learned a great deal along that road.. Thanks to all the reviewers. (And I wish I wouldn't have given you all that trouble! :) ) | 13:47 |
| sambetts | \o/ congrats ElCoyote_ | 13:49 |
| ElCoyote_ | sambetts: Don't! It's not accepted yet.. :) and I'm only at the 12th revision.. :) | 13:50 |
| lucasagomes | ElCoyote_, good, thanks for contributing :-) | 13:51 |
| *** joprovost has quit IRC | 13:52 | |
| *** ametts has joined #openstack-ironic | 13:53 | |
| *** linuxaddicts has quit IRC | 13:53 | |
| ElCoyote_ | if I wanted a backport of my patch into liberty.. I assume it must first be accepted on master but how I do go about providing a patch to liberty afterwards or helping with it? | 13:53 |
| jroll | morning ElCoyote_ :) | 13:54 |
| sambetts | ElCoyote_: I assume you'd need to backport it into mitaka first | 13:54 |
| *** joprovost has joined #openstack-ironic | 13:54 | |
| jroll | ElCoyote_: liberty is for security and critical bug fixes only, I don't think this will make it there | 13:54 |
| ElCoyote_ | jroll: too bad then .. | 13:54 |
| jroll | it's probably fine for mitaka | 13:55 |
| lucasagomes | ElCoyote_, as jroll said, there's also some guidelines you can check about stable branches | 13:56 |
| ElCoyote_ | jroll: I use liberty in my lab (OSP8) so I'm patching ssh.py manually there.. was wondering if I had a change to see that small patch nbackported (since the functionnality is there) | 13:56 |
| lucasagomes | ElCoyote_, http://docs.openstack.org/project-team-guide/stable-branches.html#appropriate-fixes | 13:56 |
| jroll | ElCoyote_: yeah, see the link, them's the rules :/ | 13:56 |
| ElCoyote_ | Oh.. I hadn't seen that .. Many thanks for thsat | 13:59 |
| *** mgoddard__ has joined #openstack-ironic | 14:02 | |
| *** joprovost1 has joined #openstack-ironic | 14:03 | |
| *** milan has quit IRC | 14:03 | |
| *** mgoddard_ has quit IRC | 14:03 | |
| *** joprovost has quit IRC | 14:04 | |
| *** joprovost1 is now known as joprovost | 14:04 | |
| *** daemontool has quit IRC | 14:06 | |
| *** lintan has quit IRC | 14:09 | |
| *** linuxaddicts has joined #openstack-ironic | 14:09 | |
| vdrok | has anyone seen this - http://logs.openstack.org/79/310179/4/gate/gate-tempest-dsvm-python-ironicclient-src/1c21ca5/console.html ? | 14:09 |
| vdrok | seems that instance just does not get associated with a node? | 14:09 |
| vdrok | (unrelated to grenade:)) | 14:10 |
| sambetts | vdrok: you've hit my race condition bug | 14:10 |
| vdrok | sambetts: oh, could you give a link? | 14:10 |
| *** lintan has joined #openstack-ironic | 14:10 | |
| sambetts | vdrok: Here is the patch to fix it, it linked to the bug, https://review.openstack.org/#/c/308348/, it can be identified by looking at the n-sch log you can see it freaks up | 14:11 |
| sambetts | freaks out | 14:11 |
| *** stendulker has quit IRC | 14:12 | |
| vdrok | yep, I remember you saying about that thing with int and none, thanks! | 14:12 |
| * jroll bbiab | 14:14 | |
| vdrok | :( reverify does not add a job directly to gate check anymore | 14:15 |
| *** linuxaddicts has quit IRC | 14:19 | |
| *** joprovost1 has joined #openstack-ironic | 14:22 | |
| *** wajdi has joined #openstack-ironic | 14:22 | |
| *** joprovost has quit IRC | 14:23 | |
| *** joprovost1 is now known as joprovost | 14:23 | |
| *** parlos has joined #openstack-ironic | 14:25 | |
| *** wajdi_ has joined #openstack-ironic | 14:27 | |
| *** wajdi_ has quit IRC | 14:28 | |
| *** wajdi_ has joined #openstack-ironic | 14:28 | |
| *** wajdi_ has quit IRC | 14:28 | |
| *** ChrisAusten has joined #openstack-ironic | 14:29 | |
| *** wajdi_ has joined #openstack-ironic | 14:29 | |
| sambetts | orly? | 14:29 |
| sambetts | even if it passed check already?? | 14:29 |
| sambetts | it makes it go through both queues again? | 14:29 |
| *** hemna_ has joined #openstack-ironic | 14:30 | |
| *** wajdi_ has quit IRC | 14:30 | |
| *** wajdi has quit IRC | 14:30 | |
| *** wajdi has joined #openstack-ironic | 14:31 | |
| wajdi | good morning | 14:31 |
| vdrok | sambetts: yep | 14:32 |
| vdrok | morning wajdi | 14:32 |
| wajdi | 0/ | 14:32 |
| sambetts | vdrok: ah man thats annoyinh | 14:33 |
| openstackgerrit | Debayan Ray proposed openstack/proliantutils: Add supported boot modes to server capabilities https://review.openstack.org/275053 | 14:35 |
| *** wajdi_ has joined #openstack-ironic | 14:36 | |
| *** wajdi_ has quit IRC | 14:36 | |
| *** wajdi_ has joined #openstack-ironic | 14:37 | |
| devananda | mornin, all | 14:37 |
| *** sacharya has joined #openstack-ironic | 14:37 | |
| sambetts | morning devananda | 14:38 |
| vdrok | good morning devananda | 14:38 |
| *** wajdi_ has quit IRC | 14:39 | |
| *** wajdi_ has joined #openstack-ironic | 14:39 | |
| *** wajdi has quit IRC | 14:40 | |
| *** trown is now known as trown|afk | 14:42 | |
| *** wajdi_ is now known as wajdi | 14:43 | |
| * wajdi really needs to get around to setting up a bnc | 14:43 | |
| devananda | dtantsur: could you clarify your comments on https://review.openstack.org/318829 ? | 14:44 |
| *** daemontool has joined #openstack-ironic | 14:44 | |
| *** mtanino has joined #openstack-ironic | 14:48 | |
| dtantsur | devananda, try str(b"hello") in Python. this will give you something like repr(b"hello"), not converted bytes into str (at least as far as I understood) | 14:48 |
| dtantsur | also morning devananda | 14:49 |
| devananda | g'morning :) | 14:49 |
| dtantsur | also Popen is a bit redundant, you could use check_output, but that's a nit | 14:50 |
| devananda | hmm | 14:51 |
| *** milan has joined #openstack-ironic | 14:52 | |
| *** ohamada has quit IRC | 14:52 | |
| devananda | oh, i see | 14:52 |
| devananda | dtantsur: yea, this is the wrong output ... | 14:53 |
| devananda | © Copyright OpenStack Foundation. Last updated on b"'Thu May 19 10:52:23 2016, commit f749c77'". Created using Sphinx 1.2.3. | 14:53 |
| devananda | good catch :) | 14:53 |
| dtantsur | :) | 14:53 |
| sambetts | bytes and strings between py2 and py3 is the most annoying of the differences | 14:54 |
| dtantsur | .. and the most important :) | 14:54 |
| sambetts | yeah XD | 14:54 |
| *** mgkwill has joined #openstack-ironic | 14:57 | |
| lucasagomes | jroll, replied to the add a warning request in https://review.openstack.org/#/c/319251/ | 14:59 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Read the Sphinx html_last_updated_fmt option correctly in py3 https://review.openstack.org/318829 | 15:00 |
| *** jjohnson2 has joined #openstack-ironic | 15:00 | |
| jroll | lucasagomes: well, I want some indication that we're free to break projects not in ironic governance that are using this | 15:00 |
| jroll | lucasagomes: or more strongly worded to say projects outside of our governance shouldn't use it | 15:00 |
| devananda | dtantsur: ^ | 15:00 |
| jroll | I don't think what you have now is enough to keep people away | 15:00 |
| *** rama_y has joined #openstack-ironic | 15:01 | |
| lucasagomes | jroll, ack, lemme try to reword that, perhaps saying "used exclusively by projects under..." | 15:01 |
| jroll | lucasagomes: cool, thanks | 15:01 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-lib: Clarify which projects are meant to use the ironic-lib https://review.openstack.org/319251 | 15:03 |
| *** kromanenko_ has quit IRC | 15:03 | |
| *** Romanenko_K has quit IRC | 15:03 | |
| *** kromanenko__ has quit IRC | 15:04 | |
| *** _vsaienko has joined #openstack-ironic | 15:04 | |
| *** _vs has joined #openstack-ironic | 15:04 | |
| wajdi | @devananda I don't have the full context of what type of outputs will be stored in "html_last_updated_fmt". But are there any risks of single quotes being inside the string? | 15:05 |
| *** hemna_ has quit IRC | 15:05 | |
| devananda | wajdi: the output is the result of running that git log command | 15:08 |
| devananda | eg, Thu May 19 10:52:23 2016, commit f749c77 | 15:08 |
| devananda | there should not be any quotation marks in either the date string or the commit sha | 15:08 |
| wajdi | Thanks for the clarification. | 15:09 |
| dtantsur | devananda, just omit quotes after format: | 15:10 |
| dtantsur | it's not needed, subprocess will figure out spaces in the argument | 15:10 |
| * dtantsur just tested | 15:10 | |
| dtantsur | >>> git_cmd = ["git", "log", "--pretty=format:%ad, commit %h", "--date=local", "-n1"] | 15:11 |
| dtantsur | >>> check_output(git_cmd).decode('utf-8') | 15:11 |
| dtantsur | 'Thu May 19 17:21:28 2016, commit 8e0fe82' | 15:11 |
| dtantsur | then you won't need the replace bit | 15:11 |
| dtantsur | devananda, ^^^ | 15:11 |
| devananda | oh, cool | 15:12 |
| *** jjohnson2 has quit IRC | 15:13 | |
| devananda | dtantsur: re: documentation on maintenance mode - I don't think the API docs are the place to put that, but I completely agree that we need more docs on that | 15:14 |
| dtantsur | maybe. I just see a lot of users confused by this field, hence my request | 15:15 |
| dtantsur | maybe the user guide, not the API ref | 15:15 |
| devananda | exactly | 15:15 |
| devananda | the api ref should link to that, IMO | 15:15 |
| devananda | but right now, the only docs on maintenance that we have are in the #troubleshooting section | 15:16 |
| *** vishwanathj has joined #openstack-ironic | 15:16 | |
| openstackgerrit | Vincent S. Cojot proposed openstack/ironic: Makes the vbox driver work on headless VirtualBox machines https://review.openstack.org/311278 | 15:16 |
| wajdi | doh....silly me...for some odd reason I thought that git log would have contained a commit message as well (hence my concern for random punctuation)....fwiw I can also confirm testing on my end that the replace is not needed. | 15:19 |
| *** _vs has quit IRC | 15:20 | |
| *** _vsaienko has quit IRC | 15:20 | |
| *** rbudden has quit IRC | 15:23 | |
| *** mbound has quit IRC | 15:26 | |
| *** Sukhdev has joined #openstack-ironic | 15:28 | |
| *** Sukhdev has quit IRC | 15:29 | |
| *** Sukhdev has joined #openstack-ironic | 15:30 | |
| *** daemontool_ has joined #openstack-ironic | 15:31 | |
| *** daemontool has quit IRC | 15:33 | |
| *** sacharya_ has joined #openstack-ironic | 15:34 | |
| *** wajdi has quit IRC | 15:37 | |
| *** sacharya has quit IRC | 15:37 | |
| *** wajdi has joined #openstack-ironic | 15:37 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Update the api-ref documentation for Drivers https://review.openstack.org/313708 | 15:41 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Update the api-ref documentation for Ports https://review.openstack.org/313187 | 15:41 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Update the api-ref documentation for Root and Nodes https://review.openstack.org/312795 | 15:41 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Read the Sphinx html_last_updated_fmt option correctly in py3 https://review.openstack.org/318829 | 15:41 |
| sambetts | dtantsur: I wonder if we should handle the sleep inside the long initalize? | 15:43 |
| devananda | so, folks, I'd really like to suggest that we land these | 15:43 |
| devananda | even if they're not perfect | 15:43 |
| devananda | because other folks are already proposing conflicting (duplicative) updates | 15:44 |
| devananda | because our docs are terrible right now | 15:44 |
| devananda | eg, https://review.openstack.org/316651 | 15:44 |
| *** _vsaienko has joined #openstack-ironic | 15:44 | |
| JayF | I'll review 'em right now | 15:44 |
| *** _vs has joined #openstack-ironic | 15:44 | |
| * dtantsur reviews | 15:44 | |
| devananda | thanks | 15:44 |
| devananda | IMO, it's a disservice to users when we nitpick doc reviews like this | 15:45 |
| devananda | and makes more work for developers, too | 15:45 |
| sambetts | devananda: have you seen https://review.openstack.org/#/c/314514/? Something I've been working on and sort of relevant to the fact we're now documenting our API properly | 15:45 |
| devananda | sambetts: no, I had not. thanks ... | 15:46 |
| *** penick has joined #openstack-ironic | 15:46 | |
| devananda | sambetts: haha. yea, we have several "reserved names" right now :( | 15:47 |
| devananda | at first glance, that's a good fix | 15:47 |
| dtantsur | devananda, first two LGTM, sorry for holding the node's one for so long | 15:47 |
| *** _vsaienko has quit IRC | 15:47 | |
| *** _vs has quit IRC | 15:47 | |
| devananda | dtantsur: all your feedback has been great, and very much appreciated | 15:47 |
| sambetts | devananda: its interesting the more I dug into it the more URLs I found that routed into places we didn't expect or want | 15:48 |
| devananda | sambetts: heh :( | 15:48 |
| *** Nakato has quit IRC | 15:49 | |
| sambetts | documenting our API makes it better thought because then invalid URLs can be treated as bugs, because we've had a few discussions on here about if that change/the ones that follow it are technically removing working URLS from our API, I personally think they are bugs | 15:50 |
| sambetts | and I think thats the conclusion we came to in here the other day | 15:50 |
| vsaienko | dtantsur: do we have a bug to track grenade work? | 15:51 |
| vsaienko | morning devananda | 15:51 |
| *** rcernin has quit IRC | 15:51 | |
| devananda | sambetts: bugs, IMO | 15:51 |
| sambetts | cool :) | 15:52 |
| *** jjohnson2 has joined #openstack-ironic | 15:55 | |
| *** MattMan has quit IRC | 15:56 | |
| *** MattMan has joined #openstack-ironic | 15:56 | |
| wajdi | devananda: With respect to entries in the docs like "Normal response code". If there are multiple codes supported, would you prefer pluralizing "code"? (asking before I comment unnecessarily) | 15:56 |
| wajdi | and I guess the same applies for cases where "codes" is used and only a single response code is specified | 15:57 |
| *** _vsaienko has joined #openstack-ironic | 15:58 | |
| *** _vs has joined #openstack-ironic | 15:58 | |
| *** sdake_ has quit IRC | 15:59 | |
| sambetts | devananda: something that I realised going through the controllers, is that right now GET/DELETE/PUT v1/chassis/<chassis id>/nodes/<node id> all return 403 Operation not permitted, I was wondering what your thoughts were on enabling them, because if done right they shouldn't be a duplicate of v1/nodes/<node id> because it should validate that the node your operating on is a member of that | 16:00 |
| openstackgerrit | Yosef Hoffman proposed openstack/ironic-inspector: Update API Docs from UUID to Node ID https://review.openstack.org/319330 | 16:00 |
| sambetts | chassis | 16:00 |
| *** sdake has joined #openstack-ironic | 16:01 | |
| *** athomas has quit IRC | 16:02 | |
| dtantsur | vsaienko, not that I'm aware of | 16:03 |
| *** jjohnson2 has quit IRC | 16:04 | |
| openstackgerrit | Merged openstack/python-ironicclient: Replace deprecated tempest-lib with tempest https://review.openstack.org/310179 | 16:05 |
| *** e0ne has quit IRC | 16:06 | |
| lucasagomes | devananda, agreed on the docs thing... +a 312795 | 16:06 |
| *** daemontool has joined #openstack-ironic | 16:07 | |
| devananda | wajdi: the response code(s) data needs to be cleaned up a bit more | 16:08 |
| lucasagomes | jroll, devananda https://review.openstack.org/#/c/319251/ since we agreed on it in te ML (if you have time) | 16:08 |
| devananda | I haven't audited all the possible success/failure codes from each method | 16:08 |
| *** daemontool_ has quit IRC | 16:09 | |
| devananda | sambetts: oh, interesting | 16:09 |
| wajdi | devananda: ok. I'm just trying to gauge what should be -1 worthy since this is all documentation. If I find any typo's or inconsistent casings, should I categorize those as nits? | 16:09 |
| *** Sukhdev has quit IRC | 16:09 | |
| devananda | wajdi: or toss up a fix-it patch on top ;) | 16:10 |
| wajdi | Good point! :) | 16:10 |
| devananda | wajdi: for a docs patch, yea, typos should be fixed. (if it were inline comments, I'm more relaxed about those) | 16:11 |
| *** Sukhdev has joined #openstack-ironic | 16:11 | |
| *** _vsaienko has quit IRC | 16:11 | |
| *** _vs has quit IRC | 16:11 | |
| * parlos feeling happy that I managed to setup the devstack+ironic environment, now I have a playground for the weekend :) | 16:12 | |
| *** Sukhdev_ has joined #openstack-ironic | 16:12 | |
| *** sdake has quit IRC | 16:12 | |
| devananda | oh, right. I can't build docs on my laptop right now :( | 16:13 |
| devananda | yay py3 .... | 16:13 |
| devananda | File "/opt/source/openstack/ironic/.tox/venv/lib/python3.5/site-packages/wsmeext/sphinxext.py", line 364, in format_name | 16:13 |
| devananda | return '/' + '/'.join(path) | 16:13 |
| devananda | TypeError: can only join an iterable | 16:13 |
| sambetts | nice :( | 16:13 |
| wajdi | oh my... | 16:14 |
| *** Sukhdev has quit IRC | 16:15 | |
| mgoddard__ | hey Ironic, is the linux bridge neutron mechansim driver supported for use with ironic, or is OVS required? | 16:16 |
| wajdi | parlos: did you follow the documentation when setting up your devstack/ironic environment? I've been reviewing the tutorial documentation and I ran in to some issues by just following the docs. Trying to determine if it is just me or others have experienced similar issues. | 16:16 |
| *** Sukhdev_ has quit IRC | 16:16 | |
| parlos | wajdi: afaik I followed this http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack. | 16:16 |
| sambetts | mgoddard__: devstack or real hardware deployment? | 16:17 |
| *** dmk0202 has quit IRC | 16:17 | |
| sambetts | mgoddard__: our devstack plugin directly hooks in OVS for certain things, so in that case you really need to use it | 16:17 |
| wajdi | parlos: Great. And that documentation was clear enough to get through without issues? | 16:17 |
| parlos | But it took a while as I started with a box that was 'operational', i.e. mysql etc was already there.. | 16:17 |
| wajdi | ok | 16:17 |
| sambetts | mgoddard__: but in a real world deployment, your controller node should be able to run either | 16:17 |
| JayF | wajdi: I use that doc all the time, it works great | 16:17 |
| parlos | So, in stead of fixing the merge, I just moved to the next box. | 16:18 |
| mgoddard__ | sambetts, thanks. this is a real world question | 16:18 |
| parlos | which was 'cleaner' it just had xen installed. | 16:19 |
| wajdi | JayF: Following this documentation: http://docs.openstack.org/developer/devstack/ gave me issues until I decided to look at the more ironic specific one and it worked great. | 16:19 |
| JayF | wajdi: yeah, gotta use the ironic one ot have ironic work | 16:19 |
| parlos | Should it not be possible to start with one devstack and then add ironic support? | 16:19 |
| devananda | mgoddard__: OVS/OVN is required for real-world use, afaik | 16:20 |
| wajdi | parlos: so yeah...that is actually what I was trying to do. I wanted to use the stand-alone devstack doc and see what i had to do from themre | 16:20 |
| devananda | mgoddard__: there are a few other mech drivers floating around the community, but I do not believe they are based on linuxbridge | 16:20 |
| mgoddard__ | devananda: any idea why? | 16:20 |
| wajdi | turns out it was much easier and less of a headache to just do the ironic devstack doc | 16:20 |
| devananda | mgoddard__: well, because you need TOR control | 16:20 |
| sambetts | devananda, mgoddard__: linux bridge can do flat network, I don't think multitenent was mentioned anywhere | 16:21 |
| *** jjohnson2 has joined #openstack-ironic | 16:21 | |
| devananda | oh, good point | 16:21 |
| mgoddard__ | sambetts: correct, this is flat | 16:21 |
| parlos | wajdi thats my experience too. Ok have a nice day | 16:21 |
| devananda | mgoddard__: do you need neutron to do anything other than DHCP? | 16:21 |
| parlos | bye | 16:21 |
| wajdi | bye | 16:21 |
| *** parlos has quit IRC | 16:21 | |
| mgoddard__ | devananda: nope | 16:22 |
| mgoddard__ | we may need to support multiple flat networks | 16:22 |
| devananda | what does that mean? | 16:22 |
| mgoddard__ | multiple physical networks | 16:22 |
| devananda | mgoddard__: different deployments of Ironic, then? if the machines are on physically separate (flat) networks, how can they talk to each other? | 16:23 |
| sambetts | that should be fine with linux bridge, as long as those networks can route back to the control plane and talk to the API | 16:23 |
| jroll | vsaienko: for grenade, https://bugs.launchpad.net/ironic/+bug/1561773 | 16:23 |
| openstack | Launchpad bug 1561773 in Ironic "[RFE] Run grenade tests against Ironic in CI" [Wishlist,Confirmed] - Assigned to John L. Villalovos (happycamp) | 16:23 |
| mgoddard__ | devnanda, 1 node, two networks | 16:24 |
| *** fellypefca has quit IRC | 16:24 | |
| mgoddard__ | one deployment of ironic | 16:24 |
| *** hemna_ has joined #openstack-ironic | 16:25 | |
| devananda | mgoddard__: sambetts is correct re: flatnetwork and linuxbridge for a single network | 16:25 |
| sambetts | you may have to disable cleaning for that setup | 16:25 |
| devananda | sambetts: should be able to do cleaning - just on the same PXE network as everything else, no? | 16:26 |
| sambetts | not if multiple flat networks | 16:26 |
| mgoddard__ | why would cleaning fail? | 16:26 |
| sambetts | works for provisioning because the network is set through nova for that, but because we only store 1 network id in the ironic config for cleaning network it would work for one of the networks but not the other | 16:27 |
| *** daemontool has quit IRC | 16:27 | |
| *** daemontool_ has joined #openstack-ironic | 16:27 | |
| mgoddard__ | I see. we're not using cleaning, so not a problem | 16:29 |
| mgoddard__ | thanks for the help | 16:29 |
| *** swatson_ is now known as swatson | 16:33 | |
| jlvillal | vsaienko: vdrok: Good evening. Just curious about current status of Grenade stuff? | 16:40 |
| vdrok | morning jlvillal | 16:41 |
| vdrok | 311109 currently running in zuul | 16:41 |
| vdrok | partial grenade results are promising :) | 16:41 |
| *** rajinir has quit IRC | 16:42 | |
| vdrok | it failed, but it's run with concurrency 2, and the issue seems to be an ordinary timeout not related to upgrade process | 16:42 |
| jlvillal | vdrok: Great :) | 16:42 |
| jlvillal | I'm building my VM right now to do a test run. | 16:43 |
| *** trown|afk is now known as trown | 16:43 | |
| lucasagomes | jlvillal, morning | 16:45 |
| jlvillal | Good morning lucasagomes. I hope you are ready for a nice weekend :) | 16:45 |
| *** sacharya has joined #openstack-ironic | 16:47 | |
| lucasagomes | JayF, if you have time, https://review.openstack.org/#/c/318538/ (that's the node object thing) | 16:47 |
| lucasagomes | jlvillal, yup! Calling it a day very soon | 16:48 |
| lucasagomes | JayF, and btw, thanks a lot for the stickers! | 16:48 |
| JayF | lucasagomes: always have time to review things, but it's -1 and V-1 right now | 16:48 |
| openstackgerrit | Merged openstack/ironic: Read the Sphinx html_last_updated_fmt option correctly in py3 https://review.openstack.org/318829 | 16:48 |
| lucasagomes | JayF, yes, it's just to know if people are OK with the idea | 16:48 |
| JayF | yeah okay cool I'll have a look | 16:48 |
| JayF | it's open | 16:48 |
| vdrok | jlvillal: jroll true grenade pass! http://logs.openstack.org/09/311109/39/experimental/gate-grenade-dsvm-ironic/b14cce8/logs/grenade.sh.txt.gz | 16:48 |
| *** sacharya_ has quit IRC | 16:48 | |
| jlvillal | vdrok: Woo hoo! | 16:48 |
| vdrok | it still runs tempest all for some reason afterwards, seems like some project config issue | 16:49 |
| vdrok | but the grenade itself is ok | 16:49 |
| jlvillal | vdrok: In my local setup it runs tempest-smoke afterwards | 16:50 |
| vsaienko | jlvillal, jroll, vrok http://logs.openstack.org/09/311109/39/experimental/gate-grenade-dsvm-ironic/b14cce8/logs/grenade.sh.txt.gz#_2016-05-20_15_40_47_732 | 16:50 |
| vsaienko | smoke tests succeeded after upgrade | 16:50 |
| jlvillal | vdrok: Maybe we can ask mtreinish about if we need to have tempest run at the very end. | 16:50 |
| *** lazy_prince has quit IRC | 16:50 | |
| *** Guest89093 has quit IRC | 16:50 | |
| vsaienko | job failed by timeout | 16:50 |
| vdrok | jlvillal: I think we don't | 16:50 |
| openstackgerrit | Yosef Hoffman proposed openstack/ironic-inspector: Update Introspection API Docs from UUID to Node ID https://review.openstack.org/319330 | 16:50 |
| vsaienko | jroll, jlvillal we need this merged https://review.openstack.org/#/c/318521/ | 16:51 |
| jlvillal | vdrok: Have you looked at a Nova run to see if their job does? | 16:51 |
| jlvillal | vsaienko: I can harrass^H^H^H^H^H^H^H ask people to look at it. | 16:51 |
| vdrok | jlvillal: I don't see nova grenade running tests afterwards | 16:54 |
| lucasagomes | ok folks, calling it a day | 16:54 |
| lucasagomes | have a great evening all, enjoy the weekend! | 16:54 |
| sambetts | o/ lucasagomes | 16:55 |
| *** lucasagomes is now known as lucas-afk | 16:55 | |
| vdrok | jlvillal: oh, actually they have DEVSTACK_GATE_TEMPEST=1, without any additional parameters, so they run smoke in the end | 16:56 |
| jlvillal | vsaienko, vdrok: I have a bad feeling: https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate-wrap.sh#L236 | 16:56 |
| vdrok | yep :( | 16:56 |
| jlvillal | In regards to: https://review.openstack.org/#/c/318521/ | 16:56 |
| vdrok | jlvillal: well, we still don't have to set it manually :) | 16:56 |
| jlvillal | vdrok: For sure drop the ALL one | 16:56 |
| vdrok | but idk | 16:57 |
| *** jjohnson2 has quit IRC | 16:58 | |
| jlvillal | vdrok: vsaienko https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate.sh#L760 | 16:59 |
| jlvillal | So good to get rid of the DEVSTACK_GATE_TEMPEST_ALL_PLUGINS=1 | 16:59 |
| *** mbound has joined #openstack-ironic | 17:01 | |
| vdrok | jlvillal: we need to remove this one too then - https://github.com/openstack/ironic/blob/master/devstack/upgrade/settings#L19 | 17:02 |
| *** derekh has quit IRC | 17:03 | |
| jlvillal | vdrok: I agree. Since we will just be running it twice. | 17:03 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add some docs about firmware security https://review.openstack.org/308978 | 17:03 |
| vdrok | jlvillal: right now we would run smoke twice - during grendade, and then once again by devstack-gate in the very end | 17:03 |
| vdrok | yep | 17:03 |
| vdrok | so | 17:03 |
| JayF | lucas-afk: approach lgtm | 17:03 |
| * devananda has not locally tested ^ | 17:03 | |
| vdrok | jlvillal: I'll update project-config patch to only remove all-plugin and revert the TARGET_RUN_SMOKE patch in ironic | 17:03 |
| JayF | devananda: that's a solid doc on firmware security | 17:04 |
| jlvillal | vdrok: Spasibo | 17:04 |
| vdrok | jlvillal: no problemo :D | 17:04 |
| devananda | heading into the office. I may or may not be back online... | 17:04 |
| devananda | JayF: thanks | 17:04 |
| sambetts | cya devananda | 17:04 |
| * sambetts is heading off for the weekend | 17:04 | |
| * jlvillal is jealous of sambetts living in sunny England | 17:05 | |
| sambetts | o/ cya Monday everyone :D | 17:05 |
| sambetts | jlvillal: ha sunny :-P | 17:05 |
| jlvillal | sambetts: Enjoy your weekend! | 17:05 |
| sambetts | cya jlvillal :D | 17:05 |
| *** sambetts is now known as sambetts|afk | 17:05 | |
| jlvillal | sambetts: I lived three years in Huntingdon | 17:05 |
| jlvillal | sambetts: In between Peterborough and Cambridge | 17:05 |
| sambetts|afk | jlvillal: Oh nice | 17:05 |
| jlvillal | Summer's were nice :) | 17:05 |
| sambetts|afk | :) so you know how tempremental it can be then ;) | 17:06 |
| jlvillal | Yep. And back in the time when the malls were closed on Sundays... | 17:06 |
| jlvillal | It was my introduction to Doner Kebabs :) | 17:06 |
| * jlvillal still likes them... | 17:06 | |
| sambetts|afk | mmmm doner hehe | 17:07 |
| jlvillal | :) | 17:07 |
| * jlvillal remembers paying 1 quid at the time. | 17:08 | |
| * jlvillal is also dating himself... | 17:08 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Revert "Run smoke tests after upgrade" https://review.openstack.org/319372 | 17:09 |
| *** jistr has quit IRC | 17:09 | |
| *** jtomasek has quit IRC | 17:14 | |
| *** sabeen has quit IRC | 17:19 | |
| *** ElCoyote_ has left #openstack-ironic | 17:20 | |
| dtantsur | have a great weekend everyone! | 17:22 |
| *** dtantsur is now known as dtantsur|afk | 17:22 | |
| *** david-lyle_ is now known as david-lyle | 17:22 | |
| *** hemna_ has quit IRC | 17:23 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: WIP: grenade checking https://review.openstack.org/311109 | 17:24 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Revert "Run smoke tests after upgrade" https://review.openstack.org/319372 | 17:24 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Keep backward compatibility for openstack port create https://review.openstack.org/319232 | 17:24 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Gracefully degrade start_iscsi_target for Mitaka ramdisk https://review.openstack.org/319183 | 17:24 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Move all cleanups to cleanup_ironic https://review.openstack.org/318660 | 17:24 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Restart n-cpu after Ironic install https://review.openstack.org/318479 | 17:24 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Make sure create_ovs_taps creates unique taps https://review.openstack.org/319101 | 17:24 |
| *** jralph has joined #openstack-ironic | 17:26 | |
| vdrok | jlvillal: leaving now, could you retrigger check experimental on https://review.openstack.org/311109 after https://review.openstack.org/318521 is merged? | 17:28 |
| jlvillal | vdrok: Sure. Will do. | 17:28 |
| jlvillal | vdrok: Have a great weekend | 17:28 |
| vdrok | thanks, you too! | 17:28 |
| vdrok | good night everyone | 17:28 |
| *** daemontool has joined #openstack-ironic | 17:37 | |
| *** ChrisAusten has quit IRC | 17:38 | |
| *** daemontool_ has quit IRC | 17:39 | |
| *** ChubYann has joined #openstack-ironic | 17:40 | |
| * mgould -> away; have a good weekend, everyone! | 17:41 | |
| *** mgould is now known as mgould|afk | 17:41 | |
| openstackgerrit | Merged openstack/ironic: Update the api-ref documentation for Root and Nodes https://review.openstack.org/312795 | 17:42 |
| *** e0ne has joined #openstack-ironic | 17:46 | |
| openstackgerrit | Vincent S. Cojot proposed openstack/ironic: Make the vbox driver work on headless VirtualBox machines https://review.openstack.org/311278 | 17:56 |
| *** mtanino has quit IRC | 17:57 | |
| *** jcoufal has quit IRC | 18:01 | |
| *** ijw has joined #openstack-ironic | 18:03 | |
| openstackgerrit | Vincent S. Cojot proposed openstack/ironic: Make the vbox driver work on headless VirtualBox machines https://review.openstack.org/311278 | 18:04 |
| openstackgerrit | Yosef Hoffman proposed openstack/ironic-inspector: Update Introspection API Docs from UUID to Node ID https://review.openstack.org/319330 | 18:06 |
| *** fragatina has joined #openstack-ironic | 18:06 | |
| *** jcoufal has joined #openstack-ironic | 18:07 | |
| *** joprovost has quit IRC | 18:08 | |
| *** ijw has quit IRC | 18:10 | |
| *** fragatina has quit IRC | 18:10 | |
| *** ifarkas has quit IRC | 18:11 | |
| *** joprovost has joined #openstack-ironic | 18:11 | |
| *** fragatina has joined #openstack-ironic | 18:13 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add some docs about firmware security https://review.openstack.org/308978 | 18:13 |
| *** mtanino has joined #openstack-ironic | 18:14 | |
| *** joprovost1 has joined #openstack-ironic | 18:14 | |
| *** fragatina has quit IRC | 18:15 | |
| *** fragatina has joined #openstack-ironic | 18:15 | |
| *** joprovost has quit IRC | 18:15 | |
| *** joprovost1 is now known as joprovost | 18:15 | |
| jlvillal | vsaienko: vdrok: https://review.openstack.org/#/c/318567/ now I am seeing an error in Grenade about it not knowing about "openstack port create" | 18:17 |
| jlvillal | 2016-05-20 18:05:37.629 | ++ /opt/stack/new/ironic/devstack/lib/ironic:create_ovs_taps:680 : openstack port create --network 51d7bdc6-2f60-4ba2-b6b4-ec78bdb624dd temp_port -c id -f value | 18:18 |
| jlvillal | 2016-05-20 18:05:38.202 | + /opt/stack/new/ironic/devstack/lib/ironic:create_ovs_taps:680 : port_id='openstack: '\''port'\'' is not an openstack command. See '\''openstack --help'\''. | 18:18 |
| jlvillal | 2016-05-20 18:05:38.202 | Did you mean one of these? | 18:18 |
| jlvillal | 2016-05-20 18:05:38.202 | port delete | 18:18 |
| jlvillal | 2016-05-20 18:05:38.202 | port show | 18:18 |
| *** nicodemos is now known as nico-afk | 18:21 | |
| *** sabeen has joined #openstack-ironic | 18:22 | |
| openstackgerrit | Vincent S. Cojot proposed openstack/ironic: Make the vbox driver work on headless VirtualBox machines https://review.openstack.org/311278 | 18:22 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Revert "Replace project clients calls with openstack client" https://review.openstack.org/319405 | 18:24 |
| *** jcoufal has quit IRC | 18:29 | |
| *** ElCoyote_ has joined #openstack-ironic | 18:29 | |
| *** _vsaienko has joined #openstack-ironic | 18:37 | |
| *** _vs has joined #openstack-ironic | 18:37 | |
| *** _vsaienko has quit IRC | 18:43 | |
| *** _vs has quit IRC | 18:43 | |
| *** sdake has joined #openstack-ironic | 18:46 | |
| *** _vsaienko has joined #openstack-ironic | 18:49 | |
| *** _vs has joined #openstack-ironic | 18:49 | |
| *** dmk0202 has joined #openstack-ironic | 18:50 | |
| *** rajinir has joined #openstack-ironic | 18:51 | |
| *** _vsaienko has quit IRC | 18:53 | |
| *** _vs has quit IRC | 18:53 | |
| *** ChrisAusten has joined #openstack-ironic | 18:56 | |
| *** ijw has joined #openstack-ironic | 18:57 | |
| *** ijw_ has joined #openstack-ironic | 19:01 | |
| *** ijw has quit IRC | 19:02 | |
| rajinir | ktaylor: or anyone: I'm starting to setup the Ironic Thirdparty CI job and before I do I want to get familiar with Ironic Testing and I'm new. Is this a good page to start? | 19:03 |
| rajinir | http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack | 19:03 |
| *** liliars has quit IRC | 19:14 | |
| *** xavierr has quit IRC | 19:16 | |
| *** jjohnson2 has joined #openstack-ironic | 19:16 | |
| *** clenimar has quit IRC | 19:17 | |
| *** hemna_ has joined #openstack-ironic | 19:18 | |
| *** nico-afk has quit IRC | 19:19 | |
| *** jiangfei has quit IRC | 19:23 | |
| *** jiangfei has joined #openstack-ironic | 19:23 | |
| *** jjohnson2 has quit IRC | 19:24 | |
| *** _vsaienko has joined #openstack-ironic | 19:25 | |
| *** _vs has joined #openstack-ironic | 19:25 | |
| *** cdearborn has quit IRC | 19:26 | |
| *** marksei has joined #openstack-ironic | 19:27 | |
| *** ayoung has quit IRC | 19:29 | |
| *** cdearborn has joined #openstack-ironic | 19:35 | |
| *** hemna_ has quit IRC | 19:45 | |
| *** joprovost has quit IRC | 19:47 | |
| *** joprovost has joined #openstack-ironic | 19:48 | |
| *** xavierr has joined #openstack-ironic | 19:49 | |
| *** nico-afk has joined #openstack-ironic | 19:50 | |
| *** clenimar has joined #openstack-ironic | 19:51 | |
| *** _vsaienko has quit IRC | 19:58 | |
| *** _vs has quit IRC | 19:58 | |
| *** _vsaienko has joined #openstack-ironic | 20:01 | |
| *** _vs has joined #openstack-ironic | 20:01 | |
| *** _vsaienko has quit IRC | 20:05 | |
| *** _vs has quit IRC | 20:05 | |
| *** e0ne has quit IRC | 20:08 | |
| *** e0ne has joined #openstack-ironic | 20:12 | |
| openstackgerrit | Vincent S. Cojot proposed openstack/ironic: Make the vbox driver work on headless VirtualBox machines https://review.openstack.org/311278 | 20:14 |
| *** sdake has quit IRC | 20:22 | |
| *** sdake has joined #openstack-ironic | 20:22 | |
| *** marksei has quit IRC | 20:24 | |
| *** _vsaienko has joined #openstack-ironic | 20:25 | |
| *** _vs has joined #openstack-ironic | 20:25 | |
| *** sdake has quit IRC | 20:25 | |
| *** ayoung has joined #openstack-ironic | 20:26 | |
| *** joprovost has quit IRC | 20:30 | |
| *** e0ne has quit IRC | 20:32 | |
| *** _vsaienko has quit IRC | 20:33 | |
| *** _vsaienko has joined #openstack-ironic | 20:35 | |
| *** baoli_ has quit IRC | 20:36 | |
| *** baoli has joined #openstack-ironic | 20:37 | |
| *** baoli has quit IRC | 20:44 | |
| *** sdake has joined #openstack-ironic | 20:45 | |
| *** _vsaienko has quit IRC | 20:53 | |
| *** _vs has quit IRC | 20:54 | |
| *** _vsaienko has joined #openstack-ironic | 20:55 | |
| *** _vs has joined #openstack-ironic | 20:55 | |
| *** dprince has quit IRC | 20:58 | |
| *** _vs has quit IRC | 20:58 | |
| *** _vs has joined #openstack-ironic | 21:00 | |
| *** _vsaienko has quit IRC | 21:02 | |
| *** _vs has quit IRC | 21:02 | |
| *** _vsaienko has joined #openstack-ironic | 21:05 | |
| *** _vs has joined #openstack-ironic | 21:05 | |
| mat128 | Monday is Victoria Day for us canadians, have a good weekend everyone | 21:05 |
| mat128 | http://www.statutoryholidays.com/victoriaday.php | 21:06 |
| *** wajdi_ has joined #openstack-ironic | 21:06 | |
| *** wajdi has quit IRC | 21:09 | |
| *** wajdi__ has joined #openstack-ironic | 21:09 | |
| *** wajdi has joined #openstack-ironic | 21:10 | |
| *** lucas-afk has quit IRC | 21:11 | |
| *** wajdi_ has quit IRC | 21:11 | |
| JayF | devananda: goign to fix the pep8 error in the firmware doc | 21:13 |
| *** trown is now known as trown|outtypewww | 21:13 | |
| devananda | JayF: thanks much | 21:13 |
| devananda | I can't test the doc build locally yet | 21:13 |
| devananda | it bails on py35 | 21:14 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: WIP: grenade checking https://review.openstack.org/311109 | 21:14 |
| devananda | and I haven't rebuild a py27 env | 21:14 |
| *** wajdi__ has quit IRC | 21:14 | |
| JayF | I found most of my environment-building annoyance went away when I started working from home and not having to share my internet :) | 21:15 |
| *** wajdi has quit IRC | 21:15 | |
| *** lucasagomes has joined #openstack-ironic | 21:18 | |
| *** rcernin has joined #openstack-ironic | 21:20 | |
| *** daemontool has quit IRC | 21:22 | |
| *** ametts has quit IRC | 21:31 | |
| *** _vsaienko has quit IRC | 21:37 | |
| *** _vs has quit IRC | 21:37 | |
| *** _vsaienko has joined #openstack-ironic | 21:40 | |
| *** _vs has joined #openstack-ironic | 21:40 | |
| *** cdearborn has quit IRC | 21:46 | |
| *** lascii is now known as alaski | 21:50 | |
| *** dmk0202 has quit IRC | 21:57 | |
| *** lindycoder has joined #openstack-ironic | 21:59 | |
| *** sdake has quit IRC | 21:59 | |
| *** lindycoder has quit IRC | 22:00 | |
| *** _vs has quit IRC | 22:01 | |
| *** _vsaienko has quit IRC | 22:01 | |
| *** sdake has joined #openstack-ironic | 22:09 | |
| *** hemna_ has joined #openstack-ironic | 22:19 | |
| *** stevemar is now known as notstevemar | 22:24 | |
| *** vishwanathj has quit IRC | 22:24 | |
| *** sabeen has quit IRC | 22:35 | |
| *** krotscheck is now known as krotscheck_dcm | 22:57 | |
| JayF | devananda: I will get to that, just got sent down a rabbithole with my dev env being busted | 23:07 |
| jlvillal | JayF: Your environment building sounds the same as mine. I am SSHing into my box at home and doing my grenade stuff there. Too much of a pain inside work... | 23:08 |
| JayF | I mean, I have a nice vagrant setup going | 23:08 |
| JayF | but an upgrade of $something broke it | 23:08 |
| JayF | I'm about 4 changes deep in to the rabbithole now :/ | 23:09 |
| JayF | I think I may have fixed it now, about to find out | 23:09 |
| JayF | I think the core problem was ansible must have gotten upgraded in the fedora repos, breaking my automation | 23:09 |
| jlvillal | jroll: https://review.openstack.org/#/c/311109/ Woo hoo :) Both grenade jobs are green. | 23:09 |
| jlvillal | vsaienko: vdrok ^^^^ | 23:10 |
| jlvillal | JayF: Enjoy your yak-shaving ;) | 23:11 |
| * jlvillal has often gone yak-shaving... | 23:11 | |
| JayF | yeah at this point just trying to get this stuff fixed up so maybe next week I can not be sick most of the week and start getting stuff done again :/ | 23:11 |
| jlvillal | JayF: I'm worried I will be sick next week. My wife was sick and now I feel a slight soreness in my throat... | 23:12 |
| * jlvillal thinks he will work from home the rest of the day. | 23:13 | |
| *** rbudden has joined #openstack-ironic | 23:32 | |
| *** ChrisAusten has quit IRC | 23:37 | |
| *** ppiela has quit IRC | 23:38 | |
| *** ijw_ has quit IRC | 23:45 | |
| JayF | ==> jay_dev: file /usr/share/man/man1/vim.1.gz from install of vim-common-2:7.4.1718-1.fc23.x86_64 conflicts with file from package vim-minimal-2:7.4.827-1.fc23.x86_64 | 23:48 |
| * JayF flips table | 23:48 | |
| *** jaybeale has joined #openstack-ironic | 23:51 | |
| *** ChrisAusten has joined #openstack-ironic | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!