| *** mbound has joined #openstack-ironic | 00:11 | |
| *** rama_y has quit IRC | 00:11 | |
| *** rama_y has joined #openstack-ironic | 00:12 | |
| *** fragatina has joined #openstack-ironic | 00:17 | |
| *** Fdaisuke has joined #openstack-ironic | 00:21 | |
| *** adu has joined #openstack-ironic | 00:27 | |
| *** jjohnson2_ has joined #openstack-ironic | 00:33 | |
| *** jjohnson2 has quit IRC | 00:34 | |
| *** sean-k-mooney_ has left #openstack-ironic | 00:39 | |
| *** krotscheck_dcm is now known as krotscheck | 00:39 | |
| *** hoangcx has joined #openstack-ironic | 00:48 | |
| *** YiboCai has joined #openstack-ironic | 00:55 | |
| *** mbound has quit IRC | 00:58 | |
| *** chlong has joined #openstack-ironic | 01:00 | |
| *** fragatina has quit IRC | 01:19 | |
| *** fragatina has joined #openstack-ironic | 01:45 | |
| *** fragatina has quit IRC | 01:45 | |
| *** fragatina has joined #openstack-ironic | 01:45 | |
| *** JieLi has joined #openstack-ironic | 01:54 | |
| *** baoli has quit IRC | 01:57 | |
| *** notstevemar is now known as stevemar | 01:57 | |
| *** fragatina has quit IRC | 02:02 | |
| *** fragatina has joined #openstack-ironic | 02:02 | |
| *** baoli has joined #openstack-ironic | 02:04 | |
| *** baoli has quit IRC | 02:26 | |
| *** milan has quit IRC | 02:33 | |
| *** milan has joined #openstack-ironic | 02:34 | |
| *** rbudden has quit IRC | 03:15 | |
| *** stendulker has joined #openstack-ironic | 03:16 | |
| *** jcoufal has joined #openstack-ironic | 03:26 | |
| *** amit213 has quit IRC | 03:32 | |
| *** ChrisAusten has quit IRC | 03:43 | |
| *** Egyptian[Home] has quit IRC | 03:58 | |
| *** davidlenwell has quit IRC | 04:04 | |
| *** praneshp has joined #openstack-ironic | 04:10 | |
| *** davidlenwell has joined #openstack-ironic | 04:13 | |
| *** jcoufal has quit IRC | 04:16 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Enhance ilo drivers to do inband inspection https://review.openstack.org/201904 | 04:20 |
|---|---|---|
| openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: [WIP] Test patch for gpu device count https://review.openstack.org/315402 | 04:25 |
| *** guest has joined #openstack-ironic | 04:28 | |
| guest | Hello everyone, | 04:28 |
| guest | I am facing two problems with ironic setup. | 04:29 |
| guest | 1) My provisioning network is private network, i can not access outsite(8.8.8.8) from my baremetal, is it expected behaviour or something is wrong with my setup. | 04:30 |
| guest | 2) Is it possible to attach floating IP and get metadata from the metadata server at the same time? If i attach router(for floating IP) to the network then i can not recevie metadata. If i don't attach gateway then i can not attach floating IPs as well but i am able to get metadata. Is it the problem with my setup or is the expected behaviour? | 04:34 |
| *** sacharya has quit IRC | 04:34 | |
| *** JieLi has quit IRC | 04:37 | |
| *** rama_y has quit IRC | 04:53 | |
| *** jjohnson2_ has quit IRC | 04:55 | |
| *** ChubYann has quit IRC | 05:07 | |
| *** chlong has quit IRC | 05:08 | |
| *** amotoki has joined #openstack-ironic | 05:09 | |
| *** e0ne has joined #openstack-ironic | 05:09 | |
| *** e0ne has quit IRC | 05:18 | |
| *** chlong has joined #openstack-ironic | 05:25 | |
| *** ianw has quit IRC | 05:26 | |
| *** eglute_s has quit IRC | 05:27 | |
| *** cloudnull has quit IRC | 05:27 | |
| *** eglute has joined #openstack-ironic | 05:30 | |
| *** ianw has joined #openstack-ironic | 05:30 | |
| *** vmud213 has joined #openstack-ironic | 05:33 | |
| *** sacharya has joined #openstack-ironic | 05:34 | |
| *** jjohnson2 has joined #openstack-ironic | 05:34 | |
| *** sacharya has quit IRC | 05:39 | |
| *** rcernin has joined #openstack-ironic | 05:45 | |
| *** eglute has quit IRC | 05:51 | |
| *** eglute has joined #openstack-ironic | 05:52 | |
| *** eglute has quit IRC | 05:52 | |
| *** eglute has joined #openstack-ironic | 05:53 | |
| *** yuikotakada has joined #openstack-ironic | 05:55 | |
| *** yuikotakada is now known as yuikotakadamori | 05:55 | |
| *** yuywz has quit IRC | 06:01 | |
| *** mjura has joined #openstack-ironic | 06:13 | |
| openstackgerrit | vinay kumar muddu proposed openstack/ironic-lib: Add support for BIOS local boot for GPT label https://review.openstack.org/311613 | 06:17 |
| *** chlong has quit IRC | 06:25 | |
| *** itamarl has joined #openstack-ironic | 06:41 | |
| *** sivaramakrishna has joined #openstack-ironic | 06:43 | |
| *** sivaramakrishna is now known as Guest67116 | 06:43 | |
| *** lazy_prince has joined #openstack-ironic | 06:44 | |
| *** tesseract has joined #openstack-ironic | 06:47 | |
| *** kromanenko__ has joined #openstack-ironic | 06:54 | |
| *** kromanenko_ has joined #openstack-ironic | 06:54 | |
| *** Romanenko_K has joined #openstack-ironic | 06:54 | |
| *** parlos has joined #openstack-ironic | 06:59 | |
| *** sacharya has joined #openstack-ironic | 07:01 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Tempest: add basic test https://review.openstack.org/293926 | 07:04 |
| *** sacharya has quit IRC | 07:06 | |
| *** athomas has joined #openstack-ironic | 07:18 | |
| vsaienko | Morning Ironic'ers! | 07:19 |
| *** yuikotakadamori has quit IRC | 07:23 | |
| *** praneshp has quit IRC | 07:25 | |
| *** amotoki_ has joined #openstack-ironic | 07:25 | |
| *** amotoki has quit IRC | 07:28 | |
| *** _vs has joined #openstack-ironic | 07:34 | |
| *** _vsaienko has joined #openstack-ironic | 07:34 | |
| openstackgerrit | Merged openstack/bifrost: Use constraints for all the things https://review.openstack.org/318685 | 07:35 |
| *** dtantsur|afk is now known as dtantsur | 07:39 | |
| dtantsur | Morning Ironic | 07:39 |
| *** _vsaienko has quit IRC | 07:40 | |
| *** _vs has quit IRC | 07:40 | |
| *** keekz has quit IRC | 07:42 | |
| *** _vsaienko has joined #openstack-ironic | 07:42 | |
| *** _vs has joined #openstack-ironic | 07:42 | |
| *** _vsaienko has quit IRC | 07:48 | |
| *** _vs has quit IRC | 07:48 | |
| openstackgerrit | Merged openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/317500 | 07:48 |
| parlos | Morning Ironic | 07:50 |
| *** adu has quit IRC | 07:52 | |
| *** ohamada has joined #openstack-ironic | 07:54 | |
| *** mbound has joined #openstack-ironic | 07:58 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-ironic | 08:01 | |
| *** ifarkas has joined #openstack-ironic | 08:01 | |
| *** sacharya has joined #openstack-ironic | 08:02 | |
| *** _vs has joined #openstack-ironic | 08:02 | |
| *** _vsaienko has joined #openstack-ironic | 08:02 | |
| *** _vsaienko has quit IRC | 08:05 | |
| *** _vs has quit IRC | 08:06 | |
| pas-ha | morning dtantsur parlos and others | 08:06 |
| dtantsur | o/ | 08:06 |
| *** sacharya has quit IRC | 08:07 | |
| *** _vsaienko has joined #openstack-ironic | 08:08 | |
| *** _vs has joined #openstack-ironic | 08:08 | |
| *** dtantsur is now known as dtantsur|bbl | 08:10 | |
| *** sdake_ has quit IRC | 08:10 | |
| *** sdake has joined #openstack-ironic | 08:11 | |
| *** _vsaienko has quit IRC | 08:13 | |
| *** _vs has quit IRC | 08:13 | |
| lucasagomes | morning all :-) | 08:14 |
| parlos | Morning lucasgomes | 08:15 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Tempest: add basic test https://review.openstack.org/293926 | 08:16 |
| *** dulek has left #openstack-ironic | 08:17 | |
| milan | morning lucasagomes pas-ha parlos dtantsur|bbl | 08:18 |
| *** dmk0202 has joined #openstack-ironic | 08:19 | |
| *** yuikotakadamori has joined #openstack-ironic | 08:20 | |
| yuikotakadamori | hi, ironic | 08:20 |
| openstackgerrit | vinay kumar muddu proposed openstack/ironic-python-agent: Wait for all interfaces to be up before node lookup https://review.openstack.org/303503 | 08:21 |
| milan | yuikotakadamori, morning :) | 08:28 |
| yuikotakadamori | milan, morning :) | 08:28 |
| vdrok | good morning! | 08:32 |
| yuikotakadamori | vdrok, good morning :) | 08:32 |
| vdrok | morning yuikotakadamori :) | 08:32 |
| milan | morning vdrok! :) | 08:35 |
| *** electrofelix has joined #openstack-ironic | 08:37 | |
| *** jtomasek has joined #openstack-ironic | 08:39 | |
| *** derekh has joined #openstack-ironic | 08:41 | |
| *** moshele has joined #openstack-ironic | 08:44 | |
| *** e0ne has joined #openstack-ironic | 08:45 | |
| *** hparekh_ has joined #openstack-ironic | 08:47 | |
| *** hparekh_ has quit IRC | 08:47 | |
| vdrok | milan: morning :) | 08:47 |
| *** jcoufal has joined #openstack-ironic | 08:50 | |
| *** mgould has joined #openstack-ironic | 08:55 | |
| *** e0ne has quit IRC | 08:56 | |
| *** jistr has joined #openstack-ironic | 08:58 | |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Change HTTP_SERVER's default value to TFTPSERVER_IP https://review.openstack.org/319541 | 09:00 |
| *** jistr has quit IRC | 09:00 | |
| *** jistr has joined #openstack-ironic | 09:01 | |
| *** e0ne has joined #openstack-ironic | 09:02 | |
| *** baoli has joined #openstack-ironic | 09:05 | |
| *** jtomasek_ has joined #openstack-ironic | 09:06 | |
| *** _vs has joined #openstack-ironic | 09:08 | |
| *** _vsaienko has joined #openstack-ironic | 09:08 | |
| *** baoli has quit IRC | 09:09 | |
| sambetts|afk | Morning all | 09:09 |
| *** sambetts|afk is now known as sambetts | 09:09 | |
| yuikotakadamori | sambetts|afk, morning :) | 09:09 |
| sambetts | hey yuikotakadamori! | 09:12 |
| sambetts | Hows it going on that side of the world? | 09:12 |
| lucasagomes | sambetts, yuikotakadamori morning | 09:13 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add some docs about firmware security https://review.openstack.org/308978 | 09:13 |
| yuikotakadamori | sambetts, hi! around myself? I'm busy for downstream work a little, it's not good situation :/ | 09:15 |
| yuikotakadamori | lucasagomes, morning :) | 09:15 |
| *** _vsaienko has quit IRC | 09:18 | |
| *** _vs has quit IRC | 09:18 | |
| *** Nisha has joined #openstack-ironic | 09:22 | |
| *** _vsaienko has joined #openstack-ironic | 09:22 | |
| *** _vs has joined #openstack-ironic | 09:22 | |
| *** jtomasek_ has quit IRC | 09:22 | |
| *** _vsaienko has quit IRC | 09:39 | |
| *** _vs has quit IRC | 09:39 | |
| *** _vsaienko has joined #openstack-ironic | 09:39 | |
| *** _vs has joined #openstack-ironic | 09:39 | |
| *** _vs has quit IRC | 09:40 | |
| dtantsur|bbl | hey yuikotakadamori, milan, lucasagomes, sambetts | 09:40 |
| *** dtantsur|bbl is now known as dtantsur | 09:40 | |
| yuikotakadamori | dtantsur, hey :) | 09:40 |
| *** d0ugal has quit IRC | 09:40 | |
| *** d0ugal has joined #openstack-ironic | 09:41 | |
| dtantsur | oh downstream work | 09:41 |
| * dtantsur has enough as well | 09:41 | |
| *** _vsaienko has quit IRC | 09:41 | |
| yuikotakadamori | hehe | 09:41 |
| dtantsur | yuikotakadamori, if you haven't already, please take a look at https://review.openstack.org/305864 when you have a second | 09:43 |
| *** _vsaienko has joined #openstack-ironic | 09:43 | |
| yuikotakadamori | dtantsur, sure | 09:43 |
| *** _vs has joined #openstack-ironic | 09:44 | |
| *** pece has joined #openstack-ironic | 09:46 | |
| *** athomas has quit IRC | 09:49 | |
| *** _vsaienko has quit IRC | 09:53 | |
| *** _vs has quit IRC | 09:53 | |
| *** hoonetorg has quit IRC | 09:53 | |
| *** 64MAAAGQA has joined #openstack-ironic | 09:54 | |
| *** 7GHAA557Q has joined #openstack-ironic | 09:54 | |
| openstackgerrit | Tan Lin proposed openstack/ironic-specs: Tooling for recovering nodes https://review.openstack.org/319812 | 09:54 |
| *** YiboCai has quit IRC | 09:59 | |
| milan | dtantsur, aarefiev guys, to avoid us waiting for https://review.openstack.org/#/c/260358/7 landing, I've put some monkey patching in place for the Inspector tempest basic test https://review.openstack.org/#/c/293926/17 | 10:02 |
| * milan hopes monkey patching is acceptable to solve that ;) | 10:02 | |
| dtantsur | milan, I'm not against hacking around it to move forward, if it's not too creepy :) lemme see | 10:03 |
| *** sacharya has joined #openstack-ironic | 10:03 | |
| milan | dtantsur, OK | 10:03 |
| milan | :) | 10:03 |
| dtantsur | milan, that's all because tempest used NOSTATE instead of ENROLL, right? | 10:04 |
| milan | dtantsur, yeah, no micro versions and NOSTATE instead of AVAILABLE | 10:04 |
| dtantsur | yuikotakadamori, btw do you plan to update https://review.openstack.org/#/c/260358/ more or less soon? | 10:05 |
| dtantsur | maybe we can help with that? | 10:05 |
| dtantsur | milan, this looks pretty bad tbh :( maybe we can help Yuiko landing the dependency? | 10:05 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: grenade checking https://review.openstack.org/311109 | 10:05 |
| milan | dtantsur, :-/ | 10:05 |
| milan | dtantsur, yeah, we should do that | 10:06 |
| milan | aarefiev, you cool with blocking the test for the patch? | 10:07 |
| *** 64MAAAGQA has quit IRC | 10:07 | |
| *** 7GHAA557Q has quit IRC | 10:07 | |
| *** hoonetorg has joined #openstack-ironic | 10:07 | |
| milan | *with | 10:07 |
| milan | dtantsur, aarefiev I needed to patch 3 classes with 2 attributes and 2 methods for this to work so it's not very nice indeed | 10:08 |
| *** sacharya has quit IRC | 10:08 | |
| dtantsur | milan, on the other side, landing the Ironic part will benefit the whole community A LOT | 10:08 |
| aarefiev | milan: hey, looking ... | 10:09 |
| milan | dtantsur, I agree | 10:09 |
| vsaienko | Morning dtantsur, aarefiev, vdrok, milan, sambetts and all Ironic'ers! | 10:10 |
| dtantsur | hey vsaienko | 10:10 |
| milan | morning vsaienko | 10:10 |
| mgould | morning vsaienko dtantsur aarefiev vdrok milan sambetts and anyone else! | 10:19 |
| dtantsur | hey mgould | 10:19 |
| dtantsur | lucasagomes, when you have a second of time, could you please check the capabilities discovery patch https://review.openstack.org/308292 ? | 10:20 |
| lucasagomes | dtantsur, sure 1 sec | 10:21 |
| vdrok | Morning mgould vsaienko ! | 10:21 |
| dtantsur | lucasagomes, oh, even more importantly: the hardware initialization bit: https://review.openstack.org/#/c/317969/ | 10:21 |
| dtantsur | (capabilities can wait a bit) | 10:21 |
| lucasagomes | ++ will check both | 10:22 |
| lucasagomes | just finishing adding some tests here and will take a look | 10:22 |
| dtantsur | awesome | 10:22 |
| milan | morning mgould! | 10:23 |
| * milan relocates | 10:24 | |
| aarefiev | morning vsaienko, mgould | 10:25 |
| *** milan has quit IRC | 10:25 | |
| *** lintan has quit IRC | 10:26 | |
| aarefiev | milan, dtantsur: yeah, looks terrible, looks like ironic patch update is the best way here | 10:26 |
| *** alex_xu has quit IRC | 10:27 | |
| *** lintan has joined #openstack-ironic | 10:27 | |
| *** alex_xu has joined #openstack-ironic | 10:29 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Enhance ilo drivers to do inband inspection https://review.openstack.org/201904 | 10:29 |
| *** jcoufal has quit IRC | 10:30 | |
| Nisha | Hello Ironic | 10:37 |
| Nisha | I am seeing timeout happening in tempest in iLO driver thirdparty CI | 10:38 |
| Nisha | It is happening since today only | 10:39 |
| *** jcoufal has joined #openstack-ironic | 10:39 | |
| sambetts | when is it timing out? | 10:41 |
| *** yuriyz has joined #openstack-ironic | 10:45 | |
| *** amotoki has joined #openstack-ironic | 11:01 | |
| *** ifarkas has quit IRC | 11:01 | |
| *** amotoki_ has quit IRC | 11:03 | |
| *** sdake has quit IRC | 11:04 | |
| *** smoriya has quit IRC | 11:05 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Always convert the size root device hints to an integer https://review.openstack.org/315140 | 11:05 |
| dtantsur | aarefiev, finally updated ^^^ | 11:05 |
| *** ifarkas has joined #openstack-ironic | 11:06 | |
| *** alex_xu has quit IRC | 11:07 | |
| aarefiev | dtantsur: thanks | 11:09 |
| *** hoonetorg has quit IRC | 11:10 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Get root device hints from the node object https://review.openstack.org/318538 | 11:11 |
| *** amotoki has quit IRC | 11:11 | |
| *** alex_xu has joined #openstack-ironic | 11:11 | |
| *** Romanenko_K has quit IRC | 11:13 | |
| *** stendulker has quit IRC | 11:13 | |
| *** hoonetorg has joined #openstack-ironic | 11:15 | |
| *** Nisha has quit IRC | 11:16 | |
| openstackgerrit | Merged openstack/ironic-inspector: Update Introspection API Docs from UUID to Node ID https://review.openstack.org/319330 | 11:21 |
| jroll | morning y'all | 11:29 |
| mgould | morning jroll | 11:29 |
| sambetts | Morning jroll | 11:30 |
| sambetts | o/ mgould vsaienko | 11:30 |
| vsaienko | morning jroll, mgould, sambetts | 11:30 |
| *** _vsaienko has joined #openstack-ironic | 11:31 | |
| *** _vs has joined #openstack-ironic | 11:32 | |
| *** _vs has quit IRC | 11:34 | |
| *** _vsaienko has quit IRC | 11:35 | |
| lucasagomes | vsaienko, mgould jroll morning | 11:35 |
| vsaienko | o/ lucasagomes | 11:35 |
| *** _vsaienko has joined #openstack-ironic | 11:37 | |
| *** _vs has joined #openstack-ironic | 11:37 | |
| *** jjohnson2 has quit IRC | 11:37 | |
| *** adu has joined #openstack-ironic | 11:38 | |
| *** athomas has joined #openstack-ironic | 11:44 | |
| dtantsur | morning jroll | 11:44 |
| lucasagomes | dtantsur, code-wise the capabilities patch looks good, but I think it should be split in two no? The CPU flags seems unrelated to the capabilities discovery | 11:50 |
| dtantsur | lucasagomes, well, both are part of the capabilities work, just on some step I realized that the flags can be provided in a generic way | 11:51 |
| dtantsur | the first version used the flags to assign capabilities, now I want to do it on inspector side | 11:51 |
| dtantsur | I'm not strongly opposed to splitting them fwiw | 11:51 |
| sambetts | for some reason dtantsur is pink on my IRC client today, normally orange and its throwing me off completely ... | 11:52 |
| dtantsur | LOL | 11:52 |
| dtantsur | I'm yellow for myself :) | 11:52 |
| lucasagomes | dtantsur, if you happen to submit a new patch-set please split, +2 for now | 11:52 |
| dtantsur | got it | 11:52 |
| lucasagomes | you are all blue for me :-) | 11:53 |
| * lucasagomes gets confused when there are too many colors | 11:53 | |
| sambetts | lucasagomes is bold and green, jroll is bold and blue and dtantsur should be orange... no idea why its changed XD | 11:54 |
| lucasagomes | sambetts, cool, my fav color :D | 11:54 |
| sambetts | :D | 11:54 |
| * dtantsur is so unpredictable ^_^ | 11:54 | |
| sambetts | hehe, I can only think that you must have DCed over the weekend or something and my client got confused when you rejoined | 11:55 |
| sambetts | dtantsur: Thats a really odd thing about docstrings ... I didn't expect them to be considered code by the compiler :/ | 11:56 |
| xavierr | good morning Ironic :) | 11:56 |
| *** _vsaienko has quit IRC | 11:56 | |
| sambetts | o/ xavierr | 11:57 |
| *** _vsaienko has joined #openstack-ironic | 11:57 | |
| lucasagomes | sambetts, docstrings are code. They are part of the object instance and all (the special __doc__ attribute) | 11:57 |
| xavierr | \o sambetts | 11:57 |
| lucasagomes | so it counts as instrunctions in the function/method scope | 11:57 |
| *** dprince has joined #openstack-ironic | 11:57 | |
| *** hoangcx has quit IRC | 11:58 | |
| sambetts | yeah :/ seems weird to me personally to have doc stuff as part of the code at all, just one of the querks of python I guess | 11:58 |
| jroll | well, it's so you can do things like help(func) | 11:59 |
| lucasagomes | jroll, exactly! | 11:59 |
| lucasagomes | it's kinda useful, you can do it in the class and check all it's methods etc | 12:00 |
| sambetts | I guess its great for an interactive interpreter, but for actual programs not so sure, /me's main doc experience comes from writing javadoc style block comments | 12:00 |
| dtantsur | yeah, and sphinx uses docstrings for its autodoc feature | 12:00 |
| lucasagomes | #pixiesay lunch time, brb -m flexing | 12:01 |
| PixieBoots | ᕙʕ⇀ᴥ⇀ʔᕗ: lunch time, brb | 12:01 |
| *** lucasagomes is now known as lucas-hungry | 12:01 | |
| *** e0ne has quit IRC | 12:01 | |
| *** baoli has joined #openstack-ironic | 12:02 | |
| xavierr | #pixiesay Lesson learned: docstrings are really really really useful | 12:03 |
| PixieBoots | ʕ•͡ᴥ•ʔ: Lesson learned: docstrings are really really really useful | 12:03 |
| *** sacharya has joined #openstack-ironic | 12:04 | |
| *** trown|outtypewww is now known as trown | 12:04 | |
| *** moshele has quit IRC | 12:06 | |
| *** moshele has joined #openstack-ironic | 12:07 | |
| *** sacharya has quit IRC | 12:08 | |
| *** _vsaienko has quit IRC | 12:13 | |
| *** _vs has quit IRC | 12:13 | |
| *** mtanino has joined #openstack-ironic | 12:14 | |
| *** rbudden has joined #openstack-ironic | 12:15 | |
| *** vmud213 has quit IRC | 12:16 | |
| *** thrash has quit IRC | 12:16 | |
| *** thrash has joined #openstack-ironic | 12:17 | |
| *** thrash has quit IRC | 12:17 | |
| *** thrash has joined #openstack-ironic | 12:17 | |
| *** _vsaienko has joined #openstack-ironic | 12:17 | |
| *** _vs has joined #openstack-ironic | 12:17 | |
| *** mtanino has quit IRC | 12:19 | |
| *** ricardoas has quit IRC | 12:20 | |
| *** e0ne has joined #openstack-ironic | 12:21 | |
| TheJulia | Good morning everyone | 12:22 |
| dtantsur | morning TheJulia, how was your pto? | 12:22 |
| mgould | morning TheJulia | 12:22 |
| TheJulia | dtantsur: painful, I had put off major surgery until may 7th, so I'm back, alive, moving a little slower, might need to nap a little ;) | 12:23 |
| * mgould wishes TheJulia a speedy recovery | 12:24 | |
| dtantsur | ouch :( get better TheJulia! | 12:24 |
| TheJulia | initially my recovery was one of the speediest they had seen... then I flew home and swelled up :( | 12:26 |
| sambetts | :( | 12:26 |
| *** adu has quit IRC | 12:27 | |
| *** _vsaienko has quit IRC | 12:27 | |
| *** _vsaienko has joined #openstack-ironic | 12:27 | |
| TheJulia | I was also under anesthesia far longer than I had ever been before, and 2.5 hours longer than the original estimate... that has a habit of wreaking havoc later on. | 12:27 |
| *** _vs has quit IRC | 12:27 | |
| *** _vs has joined #openstack-ironic | 12:28 | |
| sambetts | wow thats crazy | 12:31 |
| * sambetts feels luckly he's never been under general for that long | 12:32 | |
| vsaienko | Ironic'ers please help to review/merge Ironic grenade related patches https://review.openstack.org/#/q/topic:grenade_01 | 12:33 |
| TheJulia | 7.5 hours.... amazingly enough, no clear horrible side effects besides the standard hair loss | 12:33 |
| mgould | huh, I didn't know that was a side effect | 12:34 |
| dtantsur | oh | 12:36 |
| openstackgerrit | Merged openstack/ironic-inspector: Always convert the size root device hints to an integer https://review.openstack.org/315140 | 12:36 |
| *** ricardoas has joined #openstack-ironic | 12:37 | |
| *** xavierr has quit IRC | 12:37 | |
| TheJulia | Basically they shutdown your body chemically, causes interruption to hair growth and you can loose some hair. I had it happen once before, not a big deal | 12:38 |
| * TheJulia doesn't want to open her email... expects waaaaay too much email | 12:38 | |
| sambetts | emails after PTO == never fun, you end up spending a whole day just deleting stuff | 12:39 |
| jroll | ctrl-a, delete | 12:39 |
| sambetts | heh | 12:39 |
| * jroll raises his coffee to a fast healthy recovery for TheJulia | 12:40 | |
| * mgould advises deleting the "can we use Go in OpenStack" thread unread, nothing good can come of it | 12:40 | |
| dtantsur | mgould++ | 12:40 |
| sambetts | LOLK | 12:40 |
| sambetts | LOL* | 12:40 |
| mgould | tl;dr yes, but people took the opportunity to air hobby-horses | 12:40 |
| mgould | speaking of which, let's rewrite IPA in Go :-) | 12:40 |
| jroll | +2 | 12:40 |
| sambetts | assembly would be smaller and faster though :/ | 12:41 |
| jroll | you can use some of this as inspiration mgould https://github.com/rackerlabs/onmetal-rescue-agent/blob/master/agent.go | 12:41 |
| mgould | jroll: thanks! | 12:41 |
| jroll | :D | 12:41 |
| TheJulia | jroll: Thank you :) | 12:41 |
| *** _milan_ has joined #openstack-ironic | 12:42 | |
| TheJulia | sambetts: across 3 mailboxes, including ansible stuff that ends up in my personal mailbox that is work related...... | 12:42 |
| TheJulia | so it went unread as well :\ | 12:42 |
| jroll | mgould: though, when we named IPA we specifically said "because there may one day be an ironic-go-agent", so... new repo? | 12:42 |
| mgould | ah, good point | 12:42 |
| * dtantsur find Go code pretty ugly | 12:43 | |
| * mgould hasn't written much | 12:43 | |
| * TheJulia doesn't want to have to keep any more feature matrixies in her head..... | 12:43 | |
| mgould | the "generics are evil" thing annoys me | 12:43 |
| jroll | mgould: I'm only being half serious here, mostly because I don't want to have to deprecate another ramdisk thing again :) | 12:43 |
| mgould | heh | 12:43 |
| mgould | yeah, I don't anticipate doing this any time soon | 12:43 |
| TheJulia | oh lovely, people that copied both work and open source email addresses | 12:45 |
| sambetts | \o/ duplicates... | 12:46 |
| *** _vsaienko has quit IRC | 12:47 | |
| *** _vs has quit IRC | 12:47 | |
| TheJulia | hmm... ask for redfish driver in one of my emails that I've not completely groked | 12:48 |
| dtantsur | mgould, "generics are evil" is a show-stopped for me to seriously consider a languages in the 21st century | 12:51 |
| dtantsur | * a language | 12:51 |
| dtantsur | like we didn't have enough fun with C and void* | 12:51 |
| mgould | yep | 12:51 |
| mgould | but hey! You can write a generic version that works with void*, and then template a type-safe wrapper around it! | 12:52 |
| mgould | except, oh wait, no templates | 12:52 |
| dtantsur | :) | 12:52 |
| mgould | but you can do that by hand for every type you care about! | 12:52 |
| dtantsur | \o/ | 12:52 |
| mgould | the Oberon manual literally tells you to do that | 12:53 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic-lib: Include wipefs --force option https://review.openstack.org/319918 | 12:53 |
| mgould | screw you, Niklaus Wirth | 12:53 |
| mgould | making his life as a compiler-writer easy at the expense of usability since Pascal 1.0 | 12:53 |
| *** jjohnson2 has joined #openstack-ironic | 12:54 | |
| *** amotoki has joined #openstack-ironic | 12:56 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Tempest: add basic test https://review.openstack.org/293926 | 12:57 |
| *** parlos has quit IRC | 12:59 | |
| *** _vsaienko has joined #openstack-ironic | 12:59 | |
| *** _vs has joined #openstack-ironic | 13:00 | |
| *** parlos has joined #openstack-ironic | 13:00 | |
| *** nico-afk is now known as nicodemos | 13:06 | |
| nicodemos | Good morning, Ironic | 13:07 |
| sambetts | hi nicodemos | 13:07 |
| *** cdearborn has joined #openstack-ironic | 13:07 | |
| mgould | morning nicodemos | 13:07 |
| vdrok | morning nicodemos | 13:07 |
| vdrok | sambetts: I think it was just copypasted from somewhere, dunno why it is needed there | 13:07 |
| nicodemos | sambetts, mgould, vdrok o/ | 13:07 |
| vdrok | sambetts: we don't check for 'uuid' value anywhere in those 2 tests, and of course functions themselves don't rely on it | 13:09 |
| *** _vs has quit IRC | 13:09 | |
| *** _vsaienko has quit IRC | 13:09 | |
| sambetts | vdrok: yeah, taking a quick look through the code I can't see anything that would rely on it :/ but the other tests above for prepare image also do it and don't seem to be using it :/ | 13:11 |
| vdrok | sambetts: I can add this line back, or fix all of them in the followup, as you wish :) | 13:12 |
| sambetts | vdrok: I think that might be a nicer way to do it, my concern is if that is added for a reason we don | 13:12 |
| sambetts | don | 13:12 |
| sambetts | t | 13:12 |
| *** nicodemos has quit IRC | 13:13 | |
| sambetts | realise and then need to revert it, we don't want to revert your whole fix | 13:13 |
| vdrok | but then, should I add it to the newly added test? | 13:14 |
| vdrok | if there is such reason | 13:14 |
| mgould | sambetts, vdrok: which patch are you talking about? | 13:14 |
| *** nicodemos has joined #openstack-ironic | 13:14 | |
| sambetts | mgould: https://review.openstack.org/#/c/319183/5/ironic/tests/unit/drivers/modules/test_agent_client.py | 13:14 |
| mgould | thanks | 13:14 |
| *** afaranha has joined #openstack-ironic | 13:15 | |
| *** ricardoas_ has joined #openstack-ironic | 13:16 | |
| *** ricardoas_ has quit IRC | 13:17 | |
| *** lucas-hungry is now known as lucasagomes | 13:17 | |
| mgould | sambetts, vdrok: FWIW the mock call was added by lucasagomes along with the original test | 13:19 |
| *** ricardoas has quit IRC | 13:19 | |
| sambetts | lucasagomes: https://review.openstack.org/#/c/319183/5/ironic/tests/unit/drivers/modules/test_agent_client.py Do you know why we need this mock? | 13:19 |
| * lucasagomes reads | 13:20 | |
| vdrok | sambetts: just removed all of them, unittests run OK | 13:21 |
| lucasagomes | sambetts, which mock? The _command one? | 13:22 |
| vdrok | lucasagomes: uuid.uuid4() | 13:22 |
| sambetts | lucasagomes: the one I've commented on, mocking uuid | 13:22 |
| lucasagomes | vdrok, sambetts not sure, I mean the tests are not failing without it so it seems good | 13:23 |
| *** piet has joined #openstack-ironic | 13:23 | |
| lucasagomes | probably was left there for some reason, not sure have to look at the history | 13:23 |
| lucasagomes | vdrok, sambetts ohhhhh wait | 13:23 |
| lucasagomes | vdrok, iscsi_target uses a UUID right? Which is the node uuid (if passed) | 13:24 |
| mgould | lucasagomes: added in commit d87309e6 | 13:24 |
| lucasagomes | otherwise it generates a uuid | 13:24 |
| *** xavierr has joined #openstack-ironic | 13:24 | |
| lucasagomes | I think that was the reason | 13:24 |
| lucasagomes | but it's not being used in the test so can be removed | 13:24 |
| vdrok | lucasagomes: yep | 13:24 |
| vdrok | sambetts: so I'd like to remove all the others in the followup, unless there are more things to fix, so as not to rebase the whole chain | 13:25 |
| sambetts | vdrok: +1 | 13:26 |
| vdrok | thanks :) | 13:26 |
| *** daemontool has joined #openstack-ironic | 13:26 | |
| mgould | istm that mock could make tests pass by accident, by giving different things the same UUID | 13:26 |
| mgould | so yeah, +1 to removing it if not needed, and +1 to doing so in a follow-up patch | 13:27 |
| *** krtaylor has quit IRC | 13:28 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Get root device hints from the node object https://review.openstack.org/318538 | 13:29 |
| *** keekz has joined #openstack-ironic | 13:33 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: The driver composition reform https://review.openstack.org/188370 | 13:37 |
| dtantsur | this is crazy ^^^ :D | 13:37 |
| *** cdearborn has quit IRC | 13:42 | |
| *** cdearborn has joined #openstack-ironic | 13:43 | |
| *** ijw has joined #openstack-ironic | 13:44 | |
| *** ijw has quit IRC | 13:47 | |
| jlvillal | vsaienko, FYI: You kind of stomped on my revision 6 patch of https://review.openstack.org/315268. Was that intentional? | 13:47 |
| *** ijw has joined #openstack-ironic | 13:47 | |
| *** adu has joined #openstack-ironic | 13:50 | |
| vsaienko | jlvillal, I have removed some unnecessary patches from the chain, and added back https://review.openstack.org/#/c/318119/2 since without it tests will not pass | 13:50 |
| jlvillal | vsaienko, Okay. But I had cleaned up https://review.openstack.org/315268 a little bit. | 13:51 |
| jlvillal | vsaienko, Don't we still need https://review.openstack.org/315268 ? Or is it not needed? | 13:51 |
| vsaienko | jlvillal it looks that only commit message was updated | 13:52 |
| vsaienko | https://review.openstack.org/315268 this patch is needed | 13:52 |
| jlvillal | vsaienko, No. I updated the code | 13:53 |
| jlvillal | vsaienko, https://review.openstack.org/#/c/315268/6..8/projects/60_nova/resources.sh | 13:53 |
| *** mbound has quit IRC | 13:53 | |
| vsaienko | jlvillal I don't see any difference between patchset 5 and latests only in commit message | 13:54 |
| jlvillal | Patchset 6. Six | 13:54 |
| vsaienko | jlvillal restored your changes back | 13:55 |
| jlvillal | vsaienko, Thank you :) | 13:56 |
| vsaienko | jlvillal, it looks that I've missed them during rebase | 13:56 |
| *** sdake has joined #openstack-ironic | 13:56 | |
| jlvillal | vsaienko, No worries. | 13:57 |
| *** ametts has joined #openstack-ironic | 13:58 | |
| *** sdake_ has joined #openstack-ironic | 14:00 | |
| *** joprovost has joined #openstack-ironic | 14:00 | |
| *** sdake has quit IRC | 14:02 | |
| *** sacharya has joined #openstack-ironic | 14:04 | |
| *** mgoddard__ has quit IRC | 14:08 | |
| *** sacharya has quit IRC | 14:08 | |
| *** mgoddard__ has joined #openstack-ironic | 14:09 | |
| *** ChrisAusten has joined #openstack-ironic | 14:10 | |
| *** vishwanathj has joined #openstack-ironic | 14:12 | |
| jroll | dtantsur: oh man, I can't wait to review that | 14:16 |
| *** ElCoyote__ has joined #openstack-ironic | 14:16 | |
| *** ElCoyote__ has quit IRC | 14:16 | |
| *** ElCoyote__ has joined #openstack-ironic | 14:17 | |
| dtantsur | jroll, go ahead then ;) | 14:17 |
| * sambetts has added it to his list :D | 14:18 | |
| *** ppiela has joined #openstack-ironic | 14:18 | |
| jroll | dtantsur: oh I will, don't worry :) need to focus on nova things early this week | 14:18 |
| dtantsur | sure-sure | 14:18 |
| sambetts | jroll: | 14:19 |
| sambetts | https://review.openstack.org/#/c/318479 I looking at this patch and it worries me | 14:19 |
| jroll | sambetts: can you elaborate? | 14:20 |
| sambetts | As I understand it that its more or less a bandaid until we can work out the nova side fix, but I was wondering if its possible that any other service might be affected by apache restarting like that, or if its purly that we've got a missing try except in our nova driver | 14:21 |
| sambetts | and its just us at fault | 14:22 |
| dtantsur | I was trying to think of a nova side fix and I remember that it was somehow complicated.. | 14:22 |
| jroll | sambetts: I think it's something like our nova driver can't auth properly and bails out | 14:22 |
| jroll | but I don't remember offhand | 14:23 |
| jroll | fwiw, we already have this hack in devstack, just not grenade's upgrade phase | 14:23 |
| sambetts | jroll: but bails out and crashes the whole of nova compute, insetad of just repeatedly leaving tracebacks in the logs | 14:23 |
| jroll | I think keystone is the only thing running behind apache right now | 14:23 |
| jroll | yeah we should likely fix that :) | 14:23 |
| sambetts | jroll: several of the other services have a flag to make them run under mod wsgi | 14:24 |
| sambetts | including nova :/ | 14:24 |
| dtantsur | jroll, everyone is moving to be behind apache afaik. there is a tripleo patch moving ironic API behind apache (does not work for some reason though) | 14:24 |
| dtantsur | sambetts, including ironic ;) | 14:25 |
| sambetts | dtantsur: as I understand from our devstack plugin we only run mod wsgi if we're doing iPXE | 14:25 |
| jroll | I mean, I don't think it's much of a problem other than our nova driver | 14:25 |
| openstackgerrit | Vincent S. Cojot proposed openstack/ironic: Make the vbox driver work on headless VirtualBox machines https://review.openstack.org/311278 | 14:26 |
| vsaienko | jroll, I just realized that https://review.openstack.org/#/c/315268 is not needed at all | 14:26 |
| sambetts | yeah :/ I think its a bug in our nova code looking at the logs etc just wanted to make sure | 14:26 |
| jroll | vsaienko: perfect, I'll abandon | 14:26 |
| vsaienko | laste successful grenade run doesn't contain patch http://logs.openstack.org/09/311109/43/experimental/gate-grenade-dsvm-ironic/dc0f693/logs/grenade.sh.txt.gz#_2016-05-23_11_16_04_693 | 14:26 |
| jroll | awesome | 14:27 |
| *** superdan is now known as dansmith | 14:32 | |
| *** e0ne has quit IRC | 14:33 | |
| *** sdake_ has quit IRC | 14:38 | |
| *** e0ne has joined #openstack-ironic | 14:38 | |
| openstackgerrit | Merged openstack/ironic: devstack: Configure console device name https://review.openstack.org/319184 | 14:48 |
| *** daemontool has quit IRC | 14:52 | |
| *** sdake has joined #openstack-ironic | 14:59 | |
| *** derekh has quit IRC | 15:05 | |
| *** mtanino has joined #openstack-ironic | 15:05 | |
| *** jaybeale has joined #openstack-ironic | 15:07 | |
| *** _milan_ has quit IRC | 15:10 | |
| *** thiagop has joined #openstack-ironic | 15:11 | |
| thiagop | Good morning Ironic | 15:11 |
| *** rbudden has quit IRC | 15:11 | |
| openstackgerrit | Merged openstack/ironic-lib: Add support for BIOS local boot for GPT label https://review.openstack.org/311613 | 15:13 |
| sambetts | jroll: I think I know where the problem is with that bug, I think there was a missing except in the ironicclient itself that should have been converting that exception into an ironicclient.exc.Unauthorized exception, and then it would have been handled by nova just fine. Although the trace back in that bug is from before we switched to keystoneauth, there literally isn't anywhere in ironiclient | 15:13 |
| sambetts | we raise ironicclient.exc.Unauthorized now, I wonder if thats a problem :/ | 15:13 |
| *** rama_y has joined #openstack-ironic | 15:14 | |
| *** sabeen has joined #openstack-ironic | 15:14 | |
| *** vmud213 has joined #openstack-ironic | 15:17 | |
| *** piet has quit IRC | 15:20 | |
| *** mtanino has quit IRC | 15:22 | |
| *** vmud213 has quit IRC | 15:22 | |
| *** mjura has quit IRC | 15:24 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: Tenant network separation for in-band inspection https://review.openstack.org/320003 | 15:24 |
| *** itamarl has quit IRC | 15:25 | |
| parlos | bye | 15:26 |
| *** parlos has quit IRC | 15:26 | |
| *** vmud213 has joined #openstack-ironic | 15:26 | |
| *** Nisha_away has joined #openstack-ironic | 15:29 | |
| *** daemontool has joined #openstack-ironic | 15:30 | |
| *** vmud213 has quit IRC | 15:31 | |
| *** amotoki has quit IRC | 15:34 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: Boot management for in-band inspection https://review.openstack.org/305864 | 15:36 |
| *** harlowja_at_home has joined #openstack-ironic | 15:37 | |
| *** absubram has joined #openstack-ironic | 15:37 | |
| dtantsur | sambetts, I've split away the specs ^^^ | 15:40 |
| sambetts | dtantsur: Nice, I'll review when I get a moment :D | 15:41 |
| dtantsur | thnx! | 15:41 |
| *** davidlenwell has quit IRC | 15:44 | |
| * dtantsur relocates for the meeting | 15:44 | |
| *** dtantsur is now known as dtantsur|bbl | 15:44 | |
| *** sacharya has joined #openstack-ironic | 15:47 | |
| *** krtaylor has joined #openstack-ironic | 15:47 | |
| *** dmk0202 has quit IRC | 15:47 | |
| jroll | devananda: lucasagomes: https://review.openstack.org/#/c/320016/ | 15:52 |
| jroll | anyone else interested in nova compute things ^ | 15:52 |
| lucasagomes | jroll, thanks! /me will read | 15:53 |
| *** vaishnavi has joined #openstack-ironic | 15:53 | |
| *** davidlenwell has joined #openstack-ironic | 15:53 | |
| thiagop | me | 15:53 |
| *** ipukha has joined #openstack-ironic | 15:54 | |
| *** athomas has quit IRC | 15:54 | |
| *** ipukha has quit IRC | 15:54 | |
| *** ipukha has joined #openstack-ironic | 15:55 | |
| jroll | lucasagomes: I think the way I lay it out here, we no longer need the search/claim apis | 15:55 |
| jroll | (still useful but ya know) | 15:55 |
| lucasagomes | jroll, right, yeah I remember I read a pastebin from jay pipes explaining the resource class thing | 15:56 |
| lucasagomes | I'm now reading the official propose :-) | 15:56 |
| jroll | lucasagomes: yep, I guess I should rebase on top of that | 15:56 |
| *** MattMan has quit IRC | 15:56 | |
| lucasagomes | jroll, yup, in fact that spec should be under Dependencies instead of Referencies in our proposal | 15:56 |
| *** stendulker has joined #openstack-ironic | 15:56 | |
| *** MattMan has joined #openstack-ironic | 15:56 | |
| lucasagomes | (will add comment after reading the full propose) | 15:57 |
| jroll | sure | 15:57 |
| jroll | thanks | 15:57 |
| *** Sukhdev has joined #openstack-ironic | 15:59 | |
| *** rbudden has joined #openstack-ironic | 16:02 | |
| *** vaishnavi has quit IRC | 16:02 | |
| *** penick has joined #openstack-ironic | 16:06 | |
| JayF | https://review.openstack.org/#/c/317969 was merged, is broken, and should be reverted IMO | 16:07 |
| *** e0ne has quit IRC | 16:07 | |
| JayF | jroll: lucasagomes sambetts ^ | 16:07 |
| JayF | You're calling initialize_hardware() only on the most specific manager that has it | 16:07 |
| JayF | instead of on all managers | 16:07 |
| JayF | that means inconsistent/unreliable behavior on agents with >1 hardware manager | 16:07 |
| JayF | I think we should start requiring a spec for changes/additions to hardware managers :/ | 16:08 |
| JayF | I'll put up a patch to potentially fix | 16:08 |
| jroll | JayF: that's a good point, but I think it's safe to just roll forward and fix it? | 16:08 |
| JayF | yeah, I'm going to roll forward and fix it | 16:08 |
| jroll | I can't imagine anyone has a hw mgr with that method already :P | 16:08 |
| JayF | Just a little unnerving that a change to an external interface changed to quickly without a spec or really any disucssion over it | 16:08 |
| jroll | that's fair | 16:09 |
| jroll | there was some back and forth in irc | 16:09 |
| JayF | there's not a lot of back and forth in the review, and some of us were sick last week :P | 16:09 |
| lucasagomes | JayF, :-( , I tend to agree with the spec, cause even for the get_os_install_device() it took me a while to realize the amount of corner cases | 16:09 |
| lucasagomes | iwth other managers inheriting from GenericHardwareManager itself and so on | 16:09 |
| JayF | That's why I actually think we should roll this back | 16:10 |
| JayF | rather than rolling forward with a fix | 16:10 |
| jroll | JayF: well, do you have any other problems with it other than incorrect code? | 16:10 |
| JayF | Yes; I think everything intialize_hardware() does should be done in evaluate_hardware_support() | 16:10 |
| JayF | it already runs at startup | 16:10 |
| JayF | and is designed to be for the hardware manager to detect and enable any hardware it manages | 16:10 |
| jroll | then revert it please | 16:11 |
| JayF | there's absolutely nothing about this design that couldn't have been done in evaluate_hardware_support() | 16:11 |
| jroll | and we can discuss further | 16:11 |
| * lucasagomes looks at evaluate_hardware_support() | 16:11 | |
| jroll | JayF: you might consider adding a topic for the meeting about this, if you want to chat with the team about it | 16:11 |
| lucasagomes | jroll, JayF agreed yeah, sorry I may have been to quick with my +a on that | 16:11 |
| JayF | Do I revert the merge commit by jenkins or the original commit itself? | 16:12 |
| jroll | JayF: the original | 16:12 |
| jroll | JayF: there's even a revert button in gerrit :) | 16:12 |
| lucasagomes | JayF, git revert <git hash> | 16:12 |
| JayF | oh, nice | 16:12 |
| lucasagomes | then submit the revert | 16:12 |
| JayF | TIL about the revert button | 16:12 |
| lucasagomes | or the button heh | 16:12 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Revert "Add hardware manager interface for hardware initialization" https://review.openstack.org/320031 | 16:12 |
| jroll | lucasagomes: the question was which hash, the merge commit or the original :) | 16:12 |
| * JayF used the revert button | 16:13 | |
| JayF | just using git-revert seemend to make git review angry about Change IDs | 16:13 |
| jroll | +2'd, dtantsur|bbl ^^ fyi | 16:13 |
| JayF | lucasagomes: that's going to break tests on your node caching patch. again :( | 16:13 |
| lucasagomes | JayF, yeah I will re-update it | 16:13 |
| JayF | jroll: you think the patch itself should be a meeting topic? or just the idea that maybe IPA HWM interface changes should have a spec or some baking time | 16:14 |
| *** rcernin has quit IRC | 16:14 | |
| jroll | JayF: the latter, if you want to talk about it more | 16:15 |
| JayF | Cool, yeah I think that's a good idea | 16:15 |
| *** rpioso has joined #openstack-ironic | 16:15 | |
| *** kromanenko_ has quit IRC | 16:17 | |
| *** kromanenko__ has quit IRC | 16:17 | |
| devananda | morning, all | 16:19 |
| TheJulia | good morning devananda | 16:19 |
| jroll | heya devananda | 16:19 |
| *** jaoh has joined #openstack-ironic | 16:20 | |
| vdrok | morning TheJulia, devananda | 16:29 |
| *** sivaramakrishna has joined #openstack-ironic | 16:34 | |
| *** hshiina has joined #openstack-ironic | 16:35 | |
| *** harlowja_at_home has quit IRC | 16:38 | |
| *** moshele has quit IRC | 16:44 | |
| sambetts | jroll, dtantsur|bbl: https://review.openstack.org/#/c/320040/ | 16:44 |
| jroll | cool | 16:45 |
| * jlvillal goes to update the whiteboard... | 16:45 | |
| *** rcernin has joined #openstack-ironic | 16:46 | |
| sambetts | jlvillal: you also might be interested in ^ | 16:48 |
| jlvillal | sambetts: looking... | 16:48 |
| sambetts | jlvillal: it relates to https://review.openstack.org/#/c/318479/8 | 16:48 |
| * jlvillal checks to see if ambiguous is spelled correctly... :) | 16:49 | |
| jlvillal | sambetts: That's an ambiguous sound exception to me. What does it mean?? | 16:51 |
| jlvillal | s/sound/sounding/ | 16:51 |
| jlvillal | :) | 16:51 |
| sambetts | jlvillal: hehe, so any Exception we get from keystoneauth in ironicclient gets wrapped in that class :/ | 16:52 |
| sambetts | jlvillal: its litterally that generic | 16:52 |
| jlvillal | mgould: Not sure if you saw. But Grenade had a passing run :) | 16:52 |
| jlvillal | sambetts: heh | 16:53 |
| *** KennethWilke has quit IRC | 16:54 | |
| mgould | jlvillal: woohoo! | 16:54 |
| sambetts | jlvillal: \o/ | 16:54 |
| * mgould has to cry off the meeting this evening, unfortunately | 16:55 | |
| jlvillal | mgould: sambetts: vsaienko and vdrok did some great work on it!!!! | 16:55 |
| * jlvillal thinks they are a dynamic duo | 16:55 | |
| *** jcoufal has quit IRC | 16:55 | |
| jlvillal | "The Dynamic Duo, the partnership between Batman and Robin in the DC Comics" | 16:56 |
| *** trown is now known as trown|lunch | 16:56 | |
| *** chopmann has joined #openstack-ironic | 16:57 | |
| *** dtantsur|bbl is now known as dtantsur | 16:58 | |
| vdrok | heh :) | 16:59 |
| *** ohamada has quit IRC | 16:59 | |
| dtantsur | JayF, the spec is useless if people don't understand the problem. I still don't, for example | 16:59 |
| mgould | vsaienko, vdrok: awesome work, thanks! | 16:59 |
| thiagop | meeting now? | 17:00 |
| dtantsur | JayF, -1 due to that | 17:00 |
| JayF | My problem is that in 2 days time, we changed a public external interface | 17:01 |
| vsaienko | mgould, thanks. We only need to wait when near 12 patches are merged to different projects :) | 17:01 |
| JayF | with the review of only 2 core reviewers plus the one who submitted it | 17:01 |
| dtantsur | morning devananda | 17:01 |
| dtantsur | JayF, well, that's how reviews work here | 17:01 |
| JayF | regardless of the fact there were better technical solutions; I think that's a really, really quick review process for something that should be considered a major change | 17:02 |
| *** KennethWilke has joined #openstack-ironic | 17:02 | |
| * dtantsur feels sorry he tried to provide a more generic solution; should have hacked around | 17:02 | |
| *** piet has joined #openstack-ironic | 17:02 | |
| JayF | I mean, I'm just saying that a change to the HardwareManager | 17:03 |
| JayF | is like chaing a driver interface | 17:03 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Gracefully degrade start_iscsi_target for Mitaka ramdisk https://review.openstack.org/319183 | 17:03 |
| JayF | it shouldn't be done without exceptional review and consideration | 17:03 |
| JayF | but I have it as a topic on the meeting today, so we should probably save it for there | 17:03 |
| *** thiagop has quit IRC | 17:04 | |
| *** thiagop has joined #openstack-ironic | 17:04 | |
| hshiina | sambetts, Sukhdev, thanks, i will read the patches you showed in ironic-neutron meeting. | 17:04 |
| jlvillal | vsaienko: vdrok: Can you update the Grenade whiteboard before you leave today? | 17:07 |
| *** _milan_ has joined #openstack-ironic | 17:07 | |
| *** ChubYann has joined #openstack-ironic | 17:07 | |
| jlvillal | I will work on trying to get patches merged in. | 17:07 |
| *** KennethWilke has quit IRC | 17:07 | |
| dtantsur | JayF, that's not what we're going to discuss; if you miss the spec it will be just as well approved without you knowing | 17:07 |
| vsaienko | jlvillal: I did it this morning, and it looks like it is up to date | 17:07 |
| *** sivaramakrishna has quit IRC | 17:07 | |
| JayF | dtantsur: in this case; I think evaluate_hardware_support is the place to do all the hardware initialization | 17:08 |
| jlvillal | vsaienko: Thanks! | 17:08 |
| JayF | dtantsur: but even beyond that, the code as written is broken with >1 hardware manager | 17:08 |
| *** sivaramakrishna has joined #openstack-ironic | 17:08 | |
| dtantsur | JayF, why? | 17:08 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: WIP: grenade checking https://review.openstack.org/311109 | 17:08 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Revert "Run smoke tests after upgrade" https://review.openstack.org/319372 | 17:08 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Keep backward compatibility for openstack port create https://review.openstack.org/319232 | 17:08 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Move all cleanups to cleanup_ironic https://review.openstack.org/318660 | 17:08 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Restart n-cpu after Ironic install https://review.openstack.org/318479 | 17:08 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Make sure create_ovs_taps creates unique taps https://review.openstack.org/319101 | 17:08 |
| JayF | dtantsur: because using dispatch_to_managers() will only call initialize hardware on the most specific hardware manager that has it | 17:08 |
| dtantsur | JayF, right. what's wrong with that? | 17:09 |
| JayF | where given the docstring of the method, it's one you want run against all supported managers | 17:09 |
| *** hshiina has quit IRC | 17:09 | |
| dtantsur | no, I don't, unless you convince me otherwise | 17:09 |
| JayF | so you're OK with me adding a manager for JaysNIC | 17:09 |
| *** sabeen has quit IRC | 17:09 | |
| JayF | that has an initialize_hardware() loading a module for my nic | 17:09 |
| JayF | and then all your code in generichardwaremanager doesn't run? | 17:09 |
| *** sivaramakrishna has quit IRC | 17:09 | |
| dtantsur | JayF, yes, because get_os_install_device from generic hardware manager also won't run. and list_hardware_info. | 17:10 |
| *** adu has quit IRC | 17:11 | |
| *** jaoh has left #openstack-ironic | 17:11 | |
| *** shamail has joined #openstack-ironic | 17:12 | |
| JayF | that's not true | 17:12 |
| JayF | that's only true *if* my HWM implements those methods | 17:12 |
| *** shamail has quit IRC | 17:15 | |
| *** sdake has quit IRC | 17:15 | |
| *** stendulker_ has joined #openstack-ironic | 17:15 | |
| *** ricardoas has joined #openstack-ironic | 17:16 | |
| *** stendulker has quit IRC | 17:16 | |
| *** sdake has joined #openstack-ironic | 17:17 | |
| openstackgerrit | Merged openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/319881 | 17:18 |
| *** moshele has joined #openstack-ironic | 17:21 | |
| *** sdake has quit IRC | 17:22 | |
| *** harlowja has joined #openstack-ironic | 17:24 | |
| *** electrofelix has quit IRC | 17:26 | |
| dtantsur | JayF, so now I'm fine with reverting this patch and doing everything in evaluate.. (I hope it counts as a bug fix rather than RFE), but please extend the commit message with the reason why we reverted it | 17:27 |
| JayF | dtantsur: +1 thanks. My annoyance was more at being gone for a week and missing something important, so sorry if it bled through or seemed directed at you | 17:28 |
| *** KennethWilke has joined #openstack-ironic | 17:29 | |
| dtantsur | JayF, no worries, I hope I did not seem to aggressive as well :) | 17:29 |
| JayF | heh no, I think it's good to be firm and direct in your beliefs about stuff, especially on IRC | 17:30 |
| *** rbudden_ has joined #openstack-ironic | 17:31 | |
| TheJulia | An occassional emoticon does help though ;) since... we have no body language translation layer for IRC as well :) | 17:31 |
| *** rbudden has quit IRC | 17:34 | |
| *** rbudden_ is now known as rbudden | 17:34 | |
| *** _milan_ has quit IRC | 17:35 | |
| *** davidlenwell has quit IRC | 17:35 | |
| *** _milan_ has joined #openstack-ironic | 17:35 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Revert "Add hardware manager interface for hardware initialization" https://review.openstack.org/320031 | 17:41 |
| JayF | dtantsur: jroll TheJulia ^ updated commit message as requested | 17:41 |
| vdrok | leaving now, good night everyone | 17:42 |
| vdrok | jlvillal: whiteboard seems to be up to date | 17:42 |
| jlvillal | vdrok: Thanks :) | 17:42 |
| jlvillal | vdrok: Good night! | 17:42 |
| *** davidlenwell has joined #openstack-ironic | 17:43 | |
| JayF | dtantsur: ty for using evaluate_hardware_support() for this. I will work on the knowledge sharing stuff for the HWMs. This is literally the exact class of problem we had to fix downstream in our managers several months ago. | 17:44 |
| *** e0ne has joined #openstack-ironic | 17:44 | |
| *** thrash is now known as thrash|biab | 17:47 | |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal power state commands https://review.openstack.org/172517 | 17:47 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add maintenance mode commands https://review.openstack.org/216727 | 17:47 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal port create https://review.openstack.org/172461 | 17:47 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Bring OSC plugin inline with approved spec https://review.openstack.org/284160 | 17:47 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add provision state commands https://review.openstack.org/206119 | 17:47 |
| *** trown|lunch is now known as trown | 17:57 | |
| * jroll slams food into his face | 17:58 | |
| *** stendulker_ has quit IRC | 17:58 | |
| * sambetts -> home | 17:58 | |
| * dtantsur -> afk | 17:59 | |
| sambetts | night all | 17:59 |
| dtantsur | :) see you tomorrow, g'night | 17:59 |
| sambetts | cya dtantsur | 17:59 |
| *** sambetts is now known as sambetts|afk | 17:59 | |
| *** moshele has quit IRC | 17:59 | |
| *** praneshp has joined #openstack-ironic | 18:00 | |
| thiagop | night sambetts|afk dtantsur | 18:00 |
| JayF | nn | 18:00 |
| *** dtantsur is now known as dtantsur|afk | 18:00 | |
| lucasagomes | night sambetts|afk dtantsur|afk | 18:02 |
| * lucasagomes goes as well | 18:02 | |
| lucasagomes | see y'all later! | 18:02 |
| thiagop | night lucasagomes | 18:02 |
| *** Sukhdev has quit IRC | 18:04 | |
| *** lucasagomes is now known as lucas-dinner | 18:04 | |
| *** _vs has joined #openstack-ironic | 18:08 | |
| *** _vsaienko has joined #openstack-ironic | 18:08 | |
| *** jaybeale has quit IRC | 18:10 | |
| *** jaybeale has joined #openstack-ironic | 18:10 | |
| *** mgould is now known as mgould|afk | 18:10 | |
| *** thrash|biab is now known as thrash | 18:12 | |
| *** jaybeale has quit IRC | 18:13 | |
| *** ig0r_ has joined #openstack-ironic | 18:15 | |
| *** moshele has joined #openstack-ironic | 18:21 | |
| *** moshele has quit IRC | 18:26 | |
| *** liliars has joined #openstack-ironic | 18:28 | |
| *** liliars has quit IRC | 18:28 | |
| *** liliars has joined #openstack-ironic | 18:29 | |
| *** liliars has quit IRC | 18:29 | |
| *** adu has joined #openstack-ironic | 18:31 | |
| *** _vs has quit IRC | 18:31 | |
| *** _vsaienko has quit IRC | 18:31 | |
| *** Sukhdev has joined #openstack-ironic | 18:33 | |
| ElCoyote__ | Is Vladyslav Drok around? | 18:35 |
| gabriel-bezerra | vdrok: ^ | 18:38 |
| vdrok | Kinda :) but it's 940 pm here, so I'd prefer to talk tomorrow unless it's something very quick | 18:39 |
| vdrok | ElCoyote__: is it a question related to review? | 18:40 |
| *** _vsaienko has joined #openstack-ironic | 18:43 | |
| *** _vs has joined #openstack-ironic | 18:43 | |
| openstackgerrit | Vincent S. Cojot proposed openstack/ironic: Make the vbox driver work on headless VirtualBox machines https://review.openstack.org/311278 | 18:43 |
| *** pece has quit IRC | 18:48 | |
| ElCoyote__ | vdrok: Yes.. it's a question related to a review | 18:52 |
| vdrok | ElCoyote__: go ahead, what is it? :) | 18:53 |
| ElCoyote__ | vdrok: You said you needed a 'unittest' for one line in the code. In fact, this line is the exact copy of another line which I got from the code. | 18:53 |
| *** chopmann has quit IRC | 18:53 | |
| ElCoyote__ | vdrok: I have no idea how to write a unittest for that. | 18:53 |
| ElCoyote__ | vdrok: Btw, if you need to go, just tell me.. this can wait until next time. | 18:54 |
| vdrok | Hmm, it's not one line iirc, it's a block of code added to set bit device? | 18:54 |
| vdrok | Boot | 18:54 |
| ElCoyote__ | I'm talking about: https://review.openstack.org/#/c/311278/17/ironic/drivers/modules/ssh.py@766 | 18:55 |
| ElCoyote__ | vdrok: Nope. I'm not touching boot devices. | 18:55 |
| *** fragatina has quit IRC | 18:55 | |
| jroll | looks like a block to me, that should certainly be unit tested | 18:56 |
| jroll | look at the current tests for set_boot_device | 18:56 |
| vdrok | Huh? ElCoyote__ , line 765 | 18:56 |
| jroll | make a similar one that sets the right properties for the node | 18:56 |
| vdrok | jroll: ++ | 18:57 |
| jroll | (and make sure it calls power off) | 18:57 |
| ElCoyote__ | jroll: I have no idea what you mean by 'set the right properties for the node'. | 18:57 |
| *** shamail has joined #openstack-ironic | 18:58 | |
| ElCoyote__ | If virt_type is vbox, then the VM must be powered off prior to attempting to set the boot device. | 18:58 |
| jroll | ElCoyote__: so there's this: https://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/test_ssh.py#L763 | 18:58 |
| jroll | you'll want something similar | 18:58 |
| *** shamail has left #openstack-ironic | 18:58 | |
| jroll | except you'll want to set something like self.node.power_state = POWER_ON | 18:58 |
| ElCoyote__ | setting the boot device was the code I found (your code, guys).. but it wasn't working. | 18:58 |
| jroll | and then assert that the power off command is called | 18:58 |
| ElCoyote__ | jroll: Ok, let me take a look. | 18:59 |
| vdrok | ElCoyote__: bug fix has to have a unit test, that fails with old code and passes with new, ensuring that your fix works. | 19:00 |
| ElCoyote__ | jroll: Should I modify an existing unittest or write a new one? It's not a function per se.. | 19:00 |
| *** baoli has quit IRC | 19:01 | |
| vdrok | ElCoyote__: new one please | 19:01 |
| jroll | ElCoyote__: yeah, new one | 19:01 |
| ElCoyote__ | vdrok: I saw the code fail when I tried to use ironic with tripleo to deploy an OSP. All I have is log that show it failed. I don't have any failed unittests | 19:01 |
| *** mbound has joined #openstack-ironic | 19:02 | |
| ElCoyote__ | I fail to understand what it should be testing for.. the whole patch only makes startvm for vbox use '--type headless' if the end user sets a property and also it makes the vbox VM power off if it's on when ironic attempts to set the boot device. | 19:03 |
| jroll | right, so the idea is to add a unit test to prove that this works (and to make sure we don't break it later) | 19:03 |
| vdrok | Yeah, we don't have unit tests for everything, but it would be good to have :) to catch such things without having to launch tripleo. | 19:03 |
| jroll | right, so you want to test those things | 19:03 |
| ElCoyote__ | Do you think that the existing unittest for vbox set_boot_device should fail when the VM is 'on' or should it ask for the VM to be powered off? or should it power off the vm by itself? | 19:05 |
| jroll | the existing seems like it's fine, we should add another that tests what it does if the VM is already on | 19:05 |
| ElCoyote__ | jroll: The existing is fine because your tests only run with a VM that's off.. it's only when tripleo attempts to reboot the node into the 'disk' after booting from 'net' that the current code fails. | 19:07 |
| jroll | ElCoyote__: right, so your patch fixes that... so we need a new unit test to verify the fix doesn't break again | 19:07 |
| ElCoyote__ | so without my patch, the whole OSP/tripleo deployment fails. | 19:07 |
| jroll | "the fix" being "set boot device works while the machine is on" | 19:08 |
| vdrok | ElCoyote__: here is an explanation that might be useful https://wiki.openstack.org/wiki/DevQuickstart | 19:08 |
| ElCoyote__ | jroll: err.. no. to set a boot device in vbox, the VM has to be off. Else 'modifyvm' will fail. | 19:08 |
| jroll | ElCoyote__: let me rephrase, "the fix" being "calling set_boot_device() works while the machine is on" | 19:09 |
| jroll | that is behavior we should have a unit test for | 19:09 |
| jroll | to ensure we don't break it | 19:09 |
| jroll | does that make sense? | 19:10 |
| ElCoyote__ | Ok, I didn't know about OpenStack code standards and unittests before I wanted to contribute that patch back. | 19:11 |
| ElCoyote__ | I need a little help to write a unittest for that. | 19:11 |
| ElCoyote__ | all I wanted was contribute a patch that makes tripleo work when the Hypervisor is set to vbox. | 19:12 |
| ElCoyote__ | now, it's the 19th rev of my original 3-line patch and new changes keep being requested. Some of the comments are useful and pointed me to better code (Thanks for that). | 19:13 |
| ElCoyote__ | but the unittest stuff is like a black hole to me.. so we're probably going to go through several other iterations as I keep poking in the dark. | 19:13 |
| *** ijw has quit IRC | 19:13 | |
| jroll | right, so you'll want to do something like the other unit test for set_boot_device(), but first set self.node.power_state = states.POWER_ON; self.node.save(). then add a similar assert to make sure "power off" was called before set boot device | 19:14 |
| jroll | yeah, I'm sorry it's been so difficult | 19:14 |
| jroll | this is the nature of openstack | 19:14 |
| jroll | the thing is, the community needs to be able to maintain the code as a group | 19:15 |
| jroll | common practices, good code, and unit tests each help us do that | 19:15 |
| ElCoyote__ | jroll: I understand and fully supports the work you do, guys. It's just very difficult for the old C/C++ programmer in me to try to contribute stuff. | 19:16 |
| jroll | yeah, there's a learning curve | 19:17 |
| *** fragatina has joined #openstack-ironic | 19:18 | |
| ElCoyote__ | jroll: If I write a unittest that sets the boot device and sets the power to 'on', that will make 'modifyvm' fail.. so the test will fail. is it the purpose of unittests? | 19:18 |
| jroll | erm, isn't that what your patch fixes? | 19:20 |
| *** tesseract has quit IRC | 19:21 | |
| ElCoyote__ | jroll: what my patch fixes is that it ensures that the VM is off before setting the boot device (because this will fail for vbox if the VM is already on and the boot device will not get set). | 19:22 |
| jroll | ElCoyote__: right | 19:22 |
| jroll | so | 19:22 |
| jroll | let me write up what I think this should look like | 19:22 |
| jroll | that may help | 19:22 |
| ElCoyote__ | So I don't understand why the unittest should test the opposite of the successful condition for set_boot_device | 19:23 |
| *** _vsaienko has quit IRC | 19:23 | |
| *** _vsaienko has joined #openstack-ironic | 19:24 | |
| jroll | right, so what your patch fixes is that calling set_boot_device() is okay when the machine is on | 19:24 |
| jroll | because set_boot_device() powers it off first now | 19:25 |
| ElCoyote__ | jroll: Yes, in a sense, that's true.. | 19:25 |
| ElCoyote__ | I hadn't seen things this way. | 19:25 |
| jroll | so here's the test I wrote, I *think* it will work: https://gist.github.com/jimrollenhagen/6898cc162723f63e51af73084da081d5 | 19:25 |
| *** clenimar has quit IRC | 19:25 | |
| jroll | compare to existing: https://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/test_ssh.py#L760-L774 | 19:25 |
| *** _vsaienko has quit IRC | 19:26 | |
| *** _vs has quit IRC | 19:26 | |
| ElCoyote__ | jroll: Many thanks for that.. don't have you have both VBoxManage cmds reversed? | 19:26 |
| jroll | ElCoyote__: heh, yes, yes I do | 19:27 |
| *** sabeen has joined #openstack-ironic | 19:27 | |
| jroll | was just trying to bang that out quickly to show what I meant | 19:27 |
| ElCoyote__ | jroll: Ok, thanks.. and since this can happen not only with PXE (but also with 'disk | 19:27 |
| ElCoyote__ | ' too.. ) | 19:28 |
| jroll | ElCoyote__: yeah, but that's just a string replacement so I think just testing one is enough :) | 19:28 |
| *** daemontool has quit IRC | 19:29 | |
| ElCoyote__ | ok.. I'm starting to understand. | 19:29 |
| *** lucas-dinner has quit IRC | 19:30 | |
| rama_y | jroll: hello? | 19:33 |
| jroll | rama_y: hello? | 19:34 |
| rama_y | jroll: may I bring up the RFE for centralizing config options? | 19:34 |
| rama_y | I thought of bringing it up in the IRC meeting; but not much time left towards the end of the meeting :-) | 19:34 |
| jroll | rama_y: sure | 19:34 |
| rama_y | RFE: https://bugs.launchpad.net/ironic/+bug/1561100 | 19:34 |
| openstack | Launchpad bug 1561100 in Ironic "[RFE] Centralize config options in Ironic" [Wishlist,In progress] - Assigned to Ramamani Yeleswarapu (ramamani-yeleswarapu) | 19:34 |
| devananda | dtantsur|afk: thanks again for the reviews on the first api-ref patch! FYI, there are two more in that chain (same gerrit topic) | 19:35 |
| rama_y | jroll: I posted patches for centralizing config options: https://review.openstack.org/#/c/295946/ | 19:35 |
| rama_y | jroll: They are dependent on the oslo-config patch: https://review.openstack.org/#/c/247331/ | 19:35 |
| rama_y | jroll: and the cross-project spec: https://review.openstack.org/#/c/295543 | 19:35 |
| ElCoyote__ | jroll: Thanks for your help. So you want me to remove: | 19:35 |
| ElCoyote__ | mock_exc.assert_called_once_with(mock.ANY, expected_cmd) | 19:35 |
| ElCoyote__ | and use this instead? | 19:35 |
| jroll | rama_y: great, what's the question? | 19:35 |
| jroll | ElCoyote__: this should be an additional test, IMO | 19:36 |
| ElCoyote__ | self.assertEqual(expected_cmds, mock_exc.call_args_list | 19:36 |
| rama_y | jroll: The cross-project spec needs reviews. | 19:36 |
| jroll | ElCoyote__: so probably just drop it in | 19:36 |
| ElCoyote__ | jroll: How do I say that this test is related to my patch (through the name of the test) | 19:36 |
| *** lucasagomes has joined #openstack-ironic | 19:36 | |
| rama_y | jroll: there is a -2 on my patches because the RFE is dependent on the cross-project spec. | 19:37 |
| jroll | ElCoyote__: test_management_interface_set_boot_device_vbox_with_power_on maybe? | 19:37 |
| jroll | rama_y: yes, we agreed we're waiting for the cross project spec to be approved | 19:37 |
| rama_y | jroll: yes. | 19:38 |
| ElCoyote__ | jroll: Ok, let's do that and keep the fun coming.. someone will come up to me and say that the other test is un-necessary.. many thanks for your help. I wouldn't have been able to write it (at this time) | 19:39 |
| jroll | ElCoyote__: send them to me :D | 19:39 |
| ElCoyote__ | jroll: I'll have the new patchset ready in a minute.. would you mind taking a look? | 19:41 |
| jroll | ElCoyote__: sure | 19:41 |
| openstackgerrit | Vincent S. Cojot proposed openstack/ironic: Make the vbox driver work on headless VirtualBox machines https://review.openstack.org/311278 | 19:44 |
| jroll | rama_y: so, did you have a question, or just wanted to say the c-p spec needs reviews? | 19:44 |
| rama_y | jroll: thanks. I just wanted to say, the c-p spec needs reviews :-) | 19:45 |
| *** _vsaienko has joined #openstack-ironic | 19:45 | |
| *** _vs has joined #openstack-ironic | 19:45 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Update resources subnet CIDR https://review.openstack.org/317082 | 19:45 |
| jroll | rama_y: okay, cool, I'll bug people :) | 19:45 |
| jroll | thanks | 19:45 |
| rama_y | jroll: thanks! | 19:45 |
| *** piet has quit IRC | 19:46 | |
| ElCoyote__ | jroll: Many thanks for your help. I have bugged you enough for today.. many thanks for that. | 19:48 |
| *** _vsaienko has quit IRC | 19:48 | |
| *** piet has joined #openstack-ironic | 19:48 | |
| jroll | ElCoyote__: not a problem :) | 19:48 |
| *** _vs has quit IRC | 19:48 | |
| *** lucasagomes has quit IRC | 19:50 | |
| rajinir | Can I follow the instructions in http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack to provision baremetal hardware using ipmi driver? | 19:50 |
| *** _vsaienko has joined #openstack-ironic | 19:52 | |
| *** _vs has joined #openstack-ironic | 19:52 | |
| rajinir | Basically I'm trying to provision real hardware, the instructions are faking it using Vms | 19:52 |
| rajinir | Can anyone provide any insights? | 19:53 |
| JayF | rajinir: it's possible in devstack; but you'll need to provide different configurations than that guide tells you | 19:54 |
| JayF | rajinir: IDK how to do it exactly; but in the code there's a few variables around hardware. I'd suggest browsing devstack/lib/ironic in our tree and you might be able to figure it out | 19:55 |
| JayF | when you do; document it so nobody else has to again :) | 19:55 |
| *** lucasagomes has joined #openstack-ironic | 19:55 | |
| rajinir | JayF: Is there a blog or any ref? | 19:55 |
| JayF | That's what I'm saying; there's no documentation for that aside from reading the code | 19:56 |
| *** baoli has joined #openstack-ironic | 19:56 | |
| JayF | unless something exists I'm unaware of | 19:56 |
| rajinir | JayF: understand. But how are hardware drivers testing thier code? | 19:56 |
| TheJulia | rajinir: for greater context, most users change the driver from agent_ssh, supply the apprropriate config information and then go from there | 19:56 |
| *** baoli has quit IRC | 19:57 | |
| *** baoli has joined #openstack-ironic | 19:57 | |
| TheJulia | rajinir: third party CI as a job for emulating IPMI to control a VM as fake baremetal | 19:57 |
| TheJulia | as well as a job | 19:57 |
| rajinir | TheJulia: I'm actually trying to put the thirdparty CI in place for our driver and looking for some instructions | 19:59 |
| TheJulia | Ahhh! | 19:59 |
| TheJulia | rajinir: that gets a little more complex then | 19:59 |
| *** ig0r_ has quit IRC | 19:59 | |
| rajinir | TheJulia: Do you mean, the hardware drivers are relying on VM as fake baremetal? | 19:59 |
| JayF | krtaylor: are you aware of any docs any of our existing 3rd party CI folks have done about setting it up (for rajinir) | 19:59 |
| *** joprovost has quit IRC | 20:00 | |
| TheJulia | rajinir: in the upstream gate, yes | 20:00 |
| TheJulia | rajinir: downstream, real hardware tends to be used | 20:00 |
| rajinir | I guess that is acceptable for upstream gate. I would imagine for hardware driver thirdparty , we have to use real hardware | 20:00 |
| TheJulia | I only say tends because I think one of the CIs does use hardware when there is a simulator of somw sort that could possibly be used | 20:01 |
| TheJulia | rajinir: exactly | 20:01 |
| *** Nisha_away has quit IRC | 20:01 | |
| rajinir | TheJulia: I have the hardware nodes and was just looking for instructions to configure Devstack | 20:01 |
| TheJulia | rajinir: Since everyone's configurations are diferent, the drivers are different in what they need, and your physical environment is different, I think it might be a good start for two things, the first to attend the Ironic QA meeting if your not already attending it. The second is likely talking to Nisha, sambetts, and thiagop since they have all waded through various parts of the 3rd party CI | 20:02 |
| jroll | ElCoyote__: fixed a couple other nitpicks I had on your patch :) | 20:02 |
| TheJulia | puzzle | 20:02 |
| TheJulia | rajinir: lots of environment variables? :) | 20:03 |
| * thiagop reads | 20:03 | |
| rajinir | TheJulia: hmm. Been attending the Ironic QA meetings. Thanks. Being new to ironic , this is a bit challenging without much docs | 20:04 |
| TheJulia | rajinir: there are lots of docs, but the context is absolutely not geared to third party CI operation :( | 20:05 |
| rajinir | TheJulia: True, that's what I'm seeing | 20:05 |
| TheJulia | we would love to see one, even if its bullet points or lessons learned, or anything :) | 20:05 |
| rajinir | TheJulia: if I can get through it, sure | 20:06 |
| TheJulia | rajinir: We are a very friendly community, and I truly wish I could help more. I know enough to be very dangerous with part of that discussion of getting it setup, but getting it running to fit your environment's special needs coupled with your drivers, your best bet is really to talk to those who have done it and try to condense their lessons learned | 20:07 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Patch to test Grenade. https://review.openstack.org/317751 | 20:07 |
| *** Sukhdev has quit IRC | 20:08 | |
| rajinir | TheJulia: Sure, will do. Our hardware should work with pxe_ipmitool as well | 20:08 |
| TheJulia | rajinir: Nisha can be in or out, but her timezone is IST, thiago... I think is GMT-3, sambetts is GMT+1 I believe | 20:08 |
| rajinir | TheJulia: Let me get started with that, and ping if I need some specific help | 20:08 |
| TheJulia | rajinir: that is a good place to start with then, awesome! | 20:08 |
| rajinir | TheJulia: Thanks a bunch | 20:09 |
| TheJulia | rajinir: no problem, and please don't hesitate to ask questions, we might not know the answer, but we're typically more than happy to try and help figure out an issue :) | 20:09 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Revert "Run smoke tests after upgrade" https://review.openstack.org/319372 | 20:09 |
| JayF | rajinir: and seirously, devstack/lib/ironic in the codebase is not an awful read | 20:09 |
| JayF | rajinir: and has all the flags you'll care about in there | 20:10 |
| rajinir | JayF: ok, will check out, thanks | 20:11 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Make sure create_ovs_taps creates unique taps https://review.openstack.org/319101 | 20:15 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Keep backward compatibility for openstack port create https://review.openstack.org/319232 | 20:16 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Move all cleanups to cleanup_ironic https://review.openstack.org/318660 | 20:18 |
| *** baoli_ has joined #openstack-ironic | 20:19 | |
| thiagop | rajinir: Hi! | 20:19 |
| thiagop | TheJulia: GMT-3 indeed | 20:19 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Restart n-cpu after Ironic install https://review.openstack.org/318479 | 20:19 |
| rajinir | thiago:hi | 20:19 |
| *** _vs has quit IRC | 20:19 | |
| *** _vsaienko has quit IRC | 20:19 | |
| *** baoli_ has quit IRC | 20:20 | |
| thiagop | rajinir: In what step are you stuck exactly? Step 0 (don't know exactly what I should be doing) or are you on the middle of something? | 20:20 |
| *** baoli_ has joined #openstack-ironic | 20:20 | |
| TheJulia | thiagop: Well, for all I know, you could still be at REI in Austin ;) | 20:21 |
| rajinir | thiago: Just starting out with this page http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack. Have hardware nodes and want to provision using Devstack, pxe_ipmitool driver | 20:21 |
| krtaylor | JayF, rajinir - reading scrollback | 20:21 |
| thiagop | TheJulia: Ya, I almost hide in a tent down there | 20:21 |
| *** sdake has joined #openstack-ironic | 20:21 | |
| *** baoli has quit IRC | 20:21 | |
| JayF | rajinir: krtaylor is our 3rd party ci coordinator, if any docs exist he'd know where they are | 20:21 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic-specs: Add "Ramdisk impact" section to spec template https://review.openstack.org/320125 | 20:21 |
| rajinir | The article talks about provision Vms(faking hardware), was wondering if the instructions and configurations are same for provisioning real hardware as well | 20:22 |
| thiagop | rajinir: doing it to understand how it works is fine, but for third party I'd take a look on openstack-infra/devstack-gate | 20:22 |
| devananda | JayF: what do you think of the wording there ^ ? | 20:22 |
| JayF | devananda: perhaps something about size? | 20:22 |
| jroll | devananda: lgtm fwiw | 20:23 |
| JayF | devananda: the only thing I see missing is about adding deps, to consider size and availabliity on all ramdisk platforms | 20:23 |
| *** Sukhdev has joined #openstack-ironic | 20:23 | |
| thiagop | rajinir: The 1st version of our CI turned out to be very VERY slow and not very maintenance friendly as we kinda deploy a devstack "by hand" on it | 20:23 |
| devananda | JayF: good point | 20:23 |
| krtaylor | rajinir, from what I can glean from the scroll back, it sounds like you are setting up exactly the same environment my team has been | 20:23 |
| jroll | devananda: JayF: impacting ramdisks, in general | 20:23 |
| thiagop | rajinir: understand by hand as "custom shell scripts" | 20:23 |
| krtaylor | rajinir, we are testing pxe_ipmitool against physical hardware, and the plan is (now that we are reporting) to get docs underway on how to set it up | 20:24 |
| rajinir | krtaylor: I guess so, if I can get that working with the CI, I can switch it to use our pxe_drac driver | 20:25 |
| *** thrash is now known as thrash|g0ne | 20:25 | |
| krtaylor | rajinir, ah, I see, yes that would be a good first step imho | 20:25 |
| rajinir | thiago: We have a thirdpart CI with sandbox implemented for M. Working on adding ironic gate for pxe_drac | 20:25 |
| krtaylor | rajinir, are you having problems with the infra components, or with ironic deployment? | 20:26 |
| rajinir | krtaylor: ironic deployment, no problems yet. Just starting out and reaching out to see if there are docs | 20:26 |
| krtaylor | rajinir, said another way, is this the first time setting up community reporting CI? | 20:27 |
| rajinir | krtaylor: we have cinder thirdparty CI | 20:27 |
| krtaylor | rajinir, ah ok, excellent, that helps | 20:27 |
| rajinir | krtaylor: cinder seems straight forward, ironic is a bit tricky | 20:28 |
| krtaylor | rajinir, so the ironic specifics, we had to create a manager for ironic targets and integrate that into nodepool in order to get things to work well | 20:28 |
| krtaylor | rajinir, if you don't already know about the third party CI meetings, they are also a great source of info | 20:29 |
| jroll | see y'all tomorrow | 20:29 |
| rajinir | krtaylor: already attend them(wednesday | 20:29 |
| thiagop | night jroll | 20:29 |
| rajinir | krtaylor: if there is more info about the ironic specifics and nodepool, it will be useful | 20:30 |
| krtaylor | rajinir, so here is the initial drop of the physical machine pool manager we wrote -> https://review.openstack.org/#/c/304683/ | 20:31 |
| krtaylor | rajinir, there is a readme there that describes how it is used and what it solves | 20:31 |
| rajinir | krtaylor: heard about MoltenIron in this article too. https://developer.ibm.com/opentech/2016/04/20/ironic-continuous-integration-testing-with-hardware-pool-management/ | 20:32 |
| rajinir | krtaylor: Do you recommend that we use it? | 20:32 |
| krtaylor | rajinir, yes, mjturek1 is also around here and he is the main author on my team | 20:32 |
| krtaylor | rajinir, well I'm kinda biased, it was the only way we could get things working | 20:33 |
| krtaylor | rajinir, we contributed it so that it might help others also | 20:33 |
| mjturek1 | rajinir: it can definitely be useful. What driver are you using? | 20:33 |
| mjturek1 | agent_ipmitool? | 20:33 |
| krtaylor | hey mjturek1 - pxe_ipmitool | 20:33 |
| krtaylor | then switch to pxe_drac | 20:34 |
| rajinir | mjturek1: pxe_drac. But for now, we are trying pxe_ipmitool | 20:34 |
| mjturek1 | cool! | 20:34 |
| *** Sukhdev has quit IRC | 20:34 | |
| mjturek1 | so yeah, in it's current state you can use it (we're hoping to expand it for other drivers down the road) | 20:34 |
| TheJulia | I'm basically gone for the day folks, still.... going through... email. If anyone needs something specific from me, please feel free to /msg me | 20:35 |
| *** Sukhdev has joined #openstack-ironic | 20:35 | |
| krtaylor | mjturek1, rajinir is also needing docs :( we need to get busy on that | 20:35 |
| *** ijw has joined #openstack-ironic | 20:35 | |
| *** baoli_ has quit IRC | 20:35 | |
| rajinir | Mjturek1: will look at it. Thanks ;) | 20:35 |
| mjturek1 | krtaylor: definitely :( | 20:35 |
| rajinir | krTaylor: :)) | 20:35 |
| mjturek1 | rajinir: I'd be happy to help you with setting it up and on how to use it. Just ping me! | 20:36 |
| mjturek1 | or krtaylor") | 20:36 |
| mjturek1 | :)* | 20:36 |
| rajinir | mjturek1: awesome thanks | 20:36 |
| mjturek1 | np | 20:36 |
| thiagop | night TheJulia | 20:36 |
| rajinir | krtaylor: thx | 20:36 |
| *** sdake has quit IRC | 20:37 | |
| krtaylor | rajinir, any comments/suggestions for molten iron, feel free to post them to that patch review | 20:37 |
| rajinir | krtaylor:sure | 20:37 |
| krtaylor | rajinir, for now, until we get docs underway, ping me or mjturek1 for problems you have, we have prob seen them too :) | 20:38 |
| rajinir | krtaylor: cool , thx :) | 20:39 |
| *** ijw has quit IRC | 20:40 | |
| devananda | jroll: storing all the specs in approved/ means that adding a section requires changing every approved spec | 20:41 |
| devananda | jroll: we used to store approved specs in folders by release | 20:41 |
| devananda | now, we no longer use different templates for different release cycles ... | 20:42 |
| *** dprince has quit IRC | 20:42 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/319880 | 20:44 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements https://review.openstack.org/316937 | 20:44 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/318853 | 20:44 |
| *** sdake has joined #openstack-ironic | 20:47 | |
| JayF | https://review.openstack.org/#/c/308978/4 is an easy approval if anyone has time (firmware security docs) | 20:48 |
| devananda | done | 20:49 |
| *** lucasagomes has quit IRC | 20:50 | |
| *** sdake_ has joined #openstack-ironic | 20:51 | |
| *** baoli has joined #openstack-ironic | 20:52 | |
| *** sdake has quit IRC | 20:54 | |
| *** ijw has joined #openstack-ironic | 20:56 | |
| *** lucasagomes has joined #openstack-ironic | 20:56 | |
| openstackgerrit | Merged openstack/ironic: Add some docs about firmware security https://review.openstack.org/308978 | 20:57 |
| openstackgerrit | Vincent S. Cojot proposed openstack/ironic: Make the vbox driver work on headless VirtualBox machines https://review.openstack.org/311278 | 20:58 |
| *** trown is now known as trown|outtypewww | 20:59 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/319880 | 21:00 |
| *** jjohnson2 has quit IRC | 21:01 | |
| *** jaybeale has joined #openstack-ironic | 21:03 | |
| devananda | JayF: do you recall what was decided w.r.t. spec process for completed specs? | 21:11 |
| JayF | devananda: unsure what you mean | 21:11 |
| devananda | whether we move completed specs out of the /approved dir, for examle | 21:11 |
| devananda | example | 21:11 |
| JayF | oh, I was managering when all that was decided, and don't remember much of it at all :( | 21:12 |
| * JayF finds himself missing that 6 months of context from time to time | 21:12 | |
| devananda | ok, found it in the README | 21:15 |
| devananda | heh | 21:15 |
| devananda | Starting with the Mitaka development cycle, all approved specifications | 21:15 |
| devananda | (implemented and not-implemented) will reside in the `specs/approved` | 21:15 |
| devananda | directory. | 21:15 |
| devananda | however, as we evolve the spec template, that poses a problem | 21:16 |
| devananda | we currently apply the tests to everyting in /approved -- even if it's implemented | 21:16 |
| JayF | we could make the test aware of if it's symlinked into implemented | 21:16 |
| devananda | yea | 21:16 |
| JayF | and if so skip testing that spec | 21:16 |
| devananda | that's one way | 21:16 |
| JayF | but that's going to be ... unpleasant | 21:16 |
| JayF | because you'll have to determine if it's linked from the destination | 21:16 |
| devananda | however, what about approved-but-not-implemented specs? | 21:16 |
| JayF | I don't think you can do that without searching | 21:16 |
| devananda | well - and there are many destinations | 21:17 |
| devananda | also, we never created the mitaka-implemented dir | 21:17 |
| devananda | just 5.0/ 5.1/ | 21:17 |
| devananda | technically, I think I can do "exclude from tests if find_symlink(filename)" pretty easily | 21:18 |
| devananda | but we'll end up with a strange hodgepodge of files over time, all in one dir, and all adhering to different templates | 21:19 |
| JayF | yeah, but the alternative is to have massive moves and trying delicately to not break links every release | 21:21 |
| JayF | maybe we need a versioned approved directory and a versioned template? | 21:21 |
| JayF | heh | 21:21 |
| *** adu has quit IRC | 21:27 | |
| *** e0ne has quit IRC | 21:28 | |
| openstackgerrit | Merged openstack/ironic: Revert "Run smoke tests after upgrade" https://review.openstack.org/319372 | 21:33 |
| *** nicodemos is now known as nico-afk | 21:33 | |
| *** Egyptian[Home] has joined #openstack-ironic | 21:34 | |
| *** daemontool has joined #openstack-ironic | 21:36 | |
| *** sacharya has quit IRC | 21:44 | |
| openstackgerrit | Merged openstack/ironic: Move all cleanups to cleanup_ironic https://review.openstack.org/318660 | 21:56 |
| openstackgerrit | Merged openstack/ironic: Restart n-cpu after Ironic install https://review.openstack.org/318479 | 21:56 |
| *** e0ne has joined #openstack-ironic | 21:59 | |
| mrda | Morning Ironic | 22:07 |
| *** rpioso has quit IRC | 22:09 | |
| *** piet has quit IRC | 22:11 | |
| xavierr | Good evening mrda :) | 22:17 |
| *** cdearborn has quit IRC | 22:17 | |
| *** daemontool_ has joined #openstack-ironic | 22:21 | |
| *** daemontool has quit IRC | 22:22 | |
| thiagop | morning mrda | 22:23 |
| *** absubram has quit IRC | 22:24 | |
| mrda | o/ | 22:24 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Patch to test Grenade. https://review.openstack.org/317751 | 22:25 |
| *** rbudden has quit IRC | 22:26 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Patch to test Grenade. https://review.openstack.org/317751 | 22:28 |
| *** adu has joined #openstack-ironic | 22:29 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic-specs: Add "Ramdisk impact" section to spec template https://review.openstack.org/320125 | 22:31 |
| devananda | JayF: ^ | 22:31 |
| devananda | now ready for real reviews | 22:31 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Patch to test Grenade. https://review.openstack.org/317751 | 22:33 |
| jlvillal | Only 9 patches left to get merged for Ironic :) | 22:34 |
| jlvillal | https://review.openstack.org/#/c/317751/ | 22:34 |
| *** daemontool_ has quit IRC | 22:34 | |
| jlvillal | Only 9 patches left to get merged for Ironic Grenade to work :) | 22:34 |
| *** e0ne has quit IRC | 22:35 | |
| devananda | jlvillal: nice ! | 22:35 |
| openstackgerrit | Merged openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/318853 | 22:35 |
| devananda | that's half what it was this morning, right? | 22:35 |
| *** adu has quit IRC | 22:35 | |
| jlvillal | I was thinking about 15. But it might have been less. | 22:36 |
| openstackgerrit | Merged openstack/ironic: Keep backward compatibility for openstack port create https://review.openstack.org/319232 | 22:36 |
| jlvillal | We have got at least 2-3 merged since this morning. We had a few patches with +2 and +A | 22:36 |
| jlvillal | But they were in a patch chain. So I rebased them out of the patch chain as they didn't touch the same code and didn't depend on each other. | 22:37 |
| jlvillal | That allowed those patches to get merged today. | 22:37 |
| jlvillal | Woot, another one just got merged :) | 22:37 |
| jlvillal | Down to 8 | 22:37 |
| JayF | I put a +1 on about a half dozen of them, they all look easy enough to get landed | 22:38 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Patch to test Grenade. https://review.openstack.org/317751 | 22:38 |
| jlvillal | JayF: Thanks :) | 22:40 |
| JayF | it's just always funny that it's only like, a dozen lines keeping something like that from working | 22:40 |
| JayF | and the amount of effort expended to find out *which dozen lines* is crazy | 22:40 |
| JayF | nice work :) | 22:41 |
| jlvillal | JayF: Yep! | 22:41 |
| jlvillal | JayF: Do you understand https://review.openstack.org/#/c/317082/ well? | 22:41 |
| jlvillal | I kind of would like more docs/comments as I don't quite understand it. | 22:41 |
| jlvillal | But I'm not that knowledgeable in network stuff. | 22:41 |
| JayF | then review it with that | 22:41 |
| jlvillal | Probably to someone who knows networking well, it is easy peasy | 22:42 |
| jlvillal | Okay | 22:42 |
| JayF | Just because I know it doesn't mean it shouldn't be commented and clear | 22:42 |
| JayF | that's how we get into situations like in the meeting this morning trying to make a jay-gate for some patches | 22:42 |
| JayF | lol | 22:42 |
| JayF | The only thing I hate more than a SPOF in an environment is /being/ a SPOF in an environment | 22:42 |
| *** tonyb_ has joined #openstack-ironic | 22:48 | |
| *** jhesketh_ has joined #openstack-ironic | 22:49 | |
| jlvillal | JayF: :) | 22:50 |
| *** stevebak` has joined #openstack-ironic | 22:51 | |
| *** odyssey4me_ has joined #openstack-ironic | 22:51 | |
| *** dutsmoc has joined #openstack-ironic | 22:51 | |
| *** __maurosr__ has joined #openstack-ironic | 22:51 | |
| *** natorious_ has joined #openstack-ironic | 22:51 | |
| *** lucasagomes_ has joined #openstack-ironic | 22:51 | |
| *** intr1nsic_ has joined #openstack-ironic | 22:52 | |
| *** rm_work| has joined #openstack-ironic | 22:52 | |
| *** zigo_ has joined #openstack-ironic | 22:52 | |
| *** lucasagomes has quit IRC | 22:53 | |
| *** rcernin has quit IRC | 22:53 | |
| *** ppiela has quit IRC | 22:53 | |
| *** d0ugal has quit IRC | 22:53 | |
| *** eglute has quit IRC | 22:53 | |
| *** BadCub has quit IRC | 22:53 | |
| *** devananda has quit IRC | 22:53 | |
| *** vdrok has quit IRC | 22:53 | |
| *** zhenguo_ has quit IRC | 22:53 | |
| *** PixieBoots has quit IRC | 22:53 | |
| *** agordeev has quit IRC | 22:53 | |
| *** ildikov has quit IRC | 22:53 | |
| *** rm_work has quit IRC | 22:53 | |
| *** odyssey4me has quit IRC | 22:53 | |
| *** comstud has quit IRC | 22:53 | |
| *** clif_h has quit IRC | 22:53 | |
| *** tonyb has quit IRC | 22:53 | |
| *** jhesketh has quit IRC | 22:53 | |
| *** intr1nsic has quit IRC | 22:53 | |
| *** mmedvede has quit IRC | 22:53 | |
| *** zigo has quit IRC | 22:53 | |
| *** mrda has quit IRC | 22:53 | |
| *** stevebaker has quit IRC | 22:53 | |
| *** maurosr has quit IRC | 22:53 | |
| *** patrickeast has quit IRC | 22:53 | |
| *** natorious has quit IRC | 22:53 | |
| *** intr1nsic_ is now known as intr1nsic | 22:53 | |
| *** rm_work| is now known as rm_work | 22:53 | |
| *** natorious_ is now known as natorious | 22:53 | |
| *** __maurosr__ is now known as maurosr | 22:53 | |
| *** rm_work has quit IRC | 22:54 | |
| *** rm_work has joined #openstack-ironic | 22:54 | |
| *** eglute has joined #openstack-ironic | 22:55 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: Get root device hints from the node object https://review.openstack.org/318538 | 22:56 |
| JayF | lucasagomes_: ^ rebased your patch for you | 22:58 |
| *** chlong has joined #openstack-ironic | 22:58 | |
| *** mmedvede has joined #openstack-ironic | 23:04 | |
| thiagop | I think I found a big nasty bug on ironicclient | 23:04 |
| openstackgerrit | Thiago Paiva Brito proposed openstack/python-ironicclient: Changing functional tests to run on py34 https://review.openstack.org/320168 | 23:05 |
| *** ametts has quit IRC | 23:10 | |
| *** adu has joined #openstack-ironic | 23:15 | |
| * thiagop -> home | 23:16 | |
| thiagop | good night folks | 23:16 |
| JayF | nn | 23:16 |
| *** thiagop has quit IRC | 23:16 | |
| *** rama_y has quit IRC | 23:17 | |
| JayF | I wonder if he filed that bug :/ | 23:17 |
| *** sabeen has quit IRC | 23:18 | |
| *** ChrisAusten has quit IRC | 23:23 | |
| *** rama_y has joined #openstack-ironic | 23:25 | |
| *** rbudden has joined #openstack-ironic | 23:28 | |
| *** adu has quit IRC | 23:38 | |
| *** sabeen has joined #openstack-ironic | 23:39 | |
| *** zhenguo_ has joined #openstack-ironic | 23:39 | |
| *** tonyb_ is now known as tonyb | 23:43 | |
| *** sabeen1 has joined #openstack-ironic | 23:43 | |
| *** sabeen has quit IRC | 23:45 | |
| *** mbound has quit IRC | 23:54 | |
| *** alexpilotti has joined #openstack-ironic | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!