*** fragatina has quit IRC | 00:01 | |
*** caldw__ has joined #openstack-ironic | 00:01 | |
*** wajdi has quit IRC | 00:01 | |
*** fragatin_ has quit IRC | 00:02 | |
*** rbudden has joined #openstack-ironic | 00:03 | |
*** bsilverman has joined #openstack-ironic | 00:04 | |
*** mbound has quit IRC | 00:04 | |
*** blakec1 has quit IRC | 00:04 | |
*** fragatina has joined #openstack-ironic | 00:05 | |
*** sdake_ has quit IRC | 00:05 | |
*** caldw__ has quit IRC | 00:06 | |
*** fragatina has quit IRC | 00:07 | |
*** fragatin_ has joined #openstack-ironic | 00:07 | |
*** rama_y has quit IRC | 00:08 | |
*** fragatin_ has quit IRC | 00:08 | |
*** garthb has quit IRC | 00:15 | |
*** amotoki has joined #openstack-ironic | 00:18 | |
*** jaybeale has quit IRC | 00:33 | |
*** mtanino has quit IRC | 00:34 | |
openstackgerrit | Devananda van der Veen proposed openstack/ironic: Update the api-ref documentation for Drivers https://review.openstack.org/313708 | 00:34 |
---|---|---|
*** sdake has joined #openstack-ironic | 00:39 | |
*** r-daneel has quit IRC | 00:39 | |
*** Sukhdev has quit IRC | 00:42 | |
*** hoangcx has joined #openstack-ironic | 00:43 | |
*** ChrisAusten has joined #openstack-ironic | 00:52 | |
*** penick has joined #openstack-ironic | 00:58 | |
*** sacharya has joined #openstack-ironic | 00:59 | |
*** Sukhdev has joined #openstack-ironic | 01:03 | |
*** Sukhdev has quit IRC | 01:04 | |
*** sacharya has quit IRC | 01:04 | |
*** harlowja has joined #openstack-ironic | 01:08 | |
*** amotoki has quit IRC | 01:08 | |
*** anteaya has quit IRC | 01:10 | |
*** Goneri has joined #openstack-ironic | 01:14 | |
*** piet has quit IRC | 01:15 | |
*** jasondotstar has quit IRC | 01:18 | |
*** Goneri has quit IRC | 01:20 | |
*** vishwanathj has joined #openstack-ironic | 01:31 | |
*** rloo has quit IRC | 01:35 | |
*** amotoki has joined #openstack-ironic | 01:35 | |
*** sdake has quit IRC | 01:50 | |
*** divya_ has quit IRC | 01:57 | |
*** sacharya has joined #openstack-ironic | 01:59 | |
*** rbudden has quit IRC | 01:59 | |
*** PollyZ has joined #openstack-ironic | 01:59 | |
*** amotoki has quit IRC | 02:00 | |
openstackgerrit | Yibo Cai proposed openstack/ironic: Support multi arch deployment https://review.openstack.org/322632 | 02:10 |
*** penick has quit IRC | 02:10 | |
*** sdake has joined #openstack-ironic | 02:11 | |
*** amotoki has joined #openstack-ironic | 02:12 | |
*** rm_work has quit IRC | 02:16 | |
*** sdake_ has joined #openstack-ironic | 02:18 | |
*** sdake has quit IRC | 02:20 | |
*** PollyZ has quit IRC | 02:20 | |
*** causten_ has joined #openstack-ironic | 02:21 | |
*** ChrisAusten has quit IRC | 02:24 | |
*** rbudden has joined #openstack-ironic | 02:25 | |
*** _vsaienko has joined #openstack-ironic | 02:45 | |
*** vsaienko has joined #openstack-ironic | 02:45 | |
*** mbound has joined #openstack-ironic | 02:47 | |
*** phuongnh has joined #openstack-ironic | 02:49 | |
*** yuanying_ has joined #openstack-ironic | 02:51 | |
*** yuanying has quit IRC | 02:51 | |
*** mbound has quit IRC | 02:51 | |
*** rm_work has joined #openstack-ironic | 02:56 | |
*** rbudden has quit IRC | 03:02 | |
*** rm_work has quit IRC | 03:07 | |
*** fragatina has joined #openstack-ironic | 03:10 | |
*** fragatin_ has joined #openstack-ironic | 03:11 | |
*** rm_work has joined #openstack-ironic | 03:11 | |
*** phuongnh has quit IRC | 03:13 | |
*** rama_y has joined #openstack-ironic | 03:14 | |
*** fragatina has quit IRC | 03:15 | |
*** wajdi_ has quit IRC | 03:19 | |
*** Nisha has joined #openstack-ironic | 03:21 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: Patch to test Grenade. https://review.openstack.org/311109 | 03:21 |
*** kalpase has joined #openstack-ironic | 03:31 | |
*** sdake_ has quit IRC | 03:38 | |
*** links has joined #openstack-ironic | 03:56 | |
*** Nisha_away has joined #openstack-ironic | 04:00 | |
*** Nisha has quit IRC | 04:03 | |
*** ijw has quit IRC | 04:06 | |
*** Nisha_away has quit IRC | 04:06 | |
*** Nisha_brb has joined #openstack-ironic | 04:06 | |
*** pcaruana has joined #openstack-ironic | 04:11 | |
*** yuanying_ has quit IRC | 04:18 | |
*** yuanying has joined #openstack-ironic | 04:21 | |
*** pcaruana has quit IRC | 04:24 | |
* jlvillal is unsure when vsaienko1 sleeps | 04:25 | |
*** rama_y has quit IRC | 04:29 | |
*** rama_y has joined #openstack-ironic | 04:33 | |
*** pcaruana has joined #openstack-ironic | 04:34 | |
*** sacharya has quit IRC | 04:36 | |
*** sacharya has joined #openstack-ironic | 04:37 | |
*** pcaruana has quit IRC | 04:40 | |
*** sacharya has quit IRC | 04:42 | |
*** YiboCai has quit IRC | 04:53 | |
*** rbartal has joined #openstack-ironic | 05:00 | |
*** Nisha_away has joined #openstack-ironic | 05:00 | |
*** Nisha_brb has quit IRC | 05:04 | |
*** moshele has joined #openstack-ironic | 05:07 | |
*** _vs_ has joined #openstack-ironic | 05:10 | |
*** _vsaienko has quit IRC | 05:11 | |
*** vsaienko has quit IRC | 05:11 | |
*** _vs_ has quit IRC | 05:11 | |
*** Nisha_away has quit IRC | 05:21 | |
*** Sukhdev has joined #openstack-ironic | 05:21 | |
*** ChubYann has quit IRC | 05:24 | |
*** rcernin has joined #openstack-ironic | 05:36 | |
*** sacharya has joined #openstack-ironic | 05:38 | |
*** Sukhdev has quit IRC | 05:41 | |
*** Sukhdev has joined #openstack-ironic | 05:41 | |
*** rama_y has quit IRC | 05:42 | |
*** sacharya has quit IRC | 05:43 | |
*** mjura has joined #openstack-ironic | 05:52 | |
*** mjura has quit IRC | 05:59 | |
*** mjura has joined #openstack-ironic | 06:00 | |
openstackgerrit | Merged openstack/proliantutils: Modify minimum disk for RAID 0 in hpssa https://review.openstack.org/311714 | 06:02 |
*** vsaienko1 has left #openstack-ironic | 06:03 | |
*** vsaienko1 has joined #openstack-ironic | 06:03 | |
*** mjura has quit IRC | 06:22 | |
openstackgerrit | Shivanand Tendulker proposed openstack/proliantutils: Add RIS support for power operations https://review.openstack.org/289800 | 06:22 |
*** milan has joined #openstack-ironic | 06:23 | |
*** ijw has joined #openstack-ironic | 06:23 | |
*** vsaienko1 has quit IRC | 06:29 | |
*** vsaienko has joined #openstack-ironic | 06:30 | |
vsaienko | Morning Ironic'ers | 06:30 |
*** moshele has quit IRC | 06:31 | |
*** fragatin_ has quit IRC | 06:34 | |
*** jtomasek has joined #openstack-ironic | 06:48 | |
*** Sukhdev has quit IRC | 07:06 | |
*** mjura_ has joined #openstack-ironic | 07:08 | |
*** mjura has joined #openstack-ironic | 07:08 | |
*** mjura has quit IRC | 07:09 | |
*** vishwanathj has quit IRC | 07:11 | |
*** e0ne has joined #openstack-ironic | 07:24 | |
*** athomas has joined #openstack-ironic | 07:26 | |
vsaienko | project-config gates are broken by dib ;) http://logs.openstack.org/45/315545/6/check/gate-project-config-dib/95b1cbf/console.html#_2016-06-07_07_11_00_417947 | 07:27 |
*** dtantsur|afk is now known as dtantsur | 07:28 | |
dtantsur | Morning Ironic, morning vsaienko | 07:28 |
dtantsur | oh that DIB | 07:28 |
vsaienko | morning dtantsur | 07:28 |
vsaienko | dtantsur what do you think about project-config-dib job for DIB? | 07:29 |
dtantsur | vsaienko, I'm totally fine with it, but I'm not in charge in DIB :) | 07:29 |
dtantsur | you can chat with folks on #tripleo about it | 07:30 |
vsaienko | dtabntsur can you please have look at http://logs.openstack.org/29/299229/14/check/gate-ironic-staging-drivers-dsvm-nv/5647b80/logs/screen-ir-cond.txt.gz#_2016-06-06_12_44_18_141 | 07:31 |
vsaienko | sorry, dtantsur: the error comes from https://review.openstack.org/#/c/299229/ amt driver, it requires pywsman | 07:32 |
dtantsur | vsaienko, correct, I don't see pywsman installing in the devstack log | 07:33 |
vsaienko | dtantsur: yeah, we can't just install pywsman, we need to compile/install openwsman first https://openwsman.github.io/ | 07:34 |
dtantsur | vsaienko, can't you install it from package? | 07:35 |
dtantsur | my F24 has openwsman-python package, for example | 07:35 |
*** ijw has quit IRC | 07:43 | |
vsaienko | dtantsur, it works if install openwsman and python-openwsman packages | 07:44 |
*** ifarkas has joined #openstack-ironic | 07:47 | |
*** ohamada has joined #openstack-ironic | 07:47 | |
vsaienko | dtantsur: I will prepare patchset | 07:48 |
*** e0ne has quit IRC | 07:48 | |
dtantsur | thnx | 07:51 |
dtantsur | vsaienko, see also about s/bash/source/ there | 07:52 |
vsaienko | dtantsur, yeah I just thought about it | 07:56 |
*** SiRiuS has joined #openstack-ironic | 07:57 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-ironic | 08:00 | |
*** e0ne has joined #openstack-ironic | 08:02 | |
*** e0ne has quit IRC | 08:02 | |
lucasagomes | morning all | 08:04 |
*** mjura_ has quit IRC | 08:06 | |
vsaienko | morning lucasabomes | 08:07 |
dtantsur | morning lucasagomes | 08:09 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 08:11 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 08:11 |
*** hoangcx has quit IRC | 08:20 | |
*** bcornec1 has joined #openstack-ironic | 08:20 | |
bcornec1 | Good morning evrybody | 08:20 |
bcornec1 | I'm trying to solve issues with my stadalone Ironic install, and would like some help for that. | 08:21 |
bcornec1 | Thanks to TheJulia, I've been able to have a working Bifrost and using the agent_ilo, beig able to enroll and activate my ProLiant server (380 Gen9 in UEFI mode) | 08:22 |
bcornec1 | Now, I'm facing issues with debugging of the install itself. | 08:22 |
bcornec1 | Besides issues with dib, I'm trying to understand how I can build a correct image to install on my node. Especially when it fails (which is all the time now :-)) I have no way to avoid that the node reboots. It would help if I could keep control of the node (through the Virtual console) and look at logs to understand what isn't working fine. | 08:24 |
bcornec1 | Any idea of what I should do for that ? | 08:24 |
bcornec1 | Also I'd like to understand which formats can be used to deploy the system, and what is the mechanism behind the scene used by IPA to realize that. | 08:26 |
*** rbartal has quit IRC | 08:26 | |
*** mjura has joined #openstack-ironic | 08:28 | |
*** MattMan has quit IRC | 08:37 | |
*** MattMan has joined #openstack-ironic | 08:37 | |
*** derekh has joined #openstack-ironic | 08:46 | |
*** hoangcx has joined #openstack-ironic | 08:46 | |
*** tesseract has joined #openstack-ironic | 08:50 | |
*** moshele has joined #openstack-ironic | 08:51 | |
lucasagomes | bcornec, hi there, what is failing specifically (or that's what you are trying to figure out?) ? | 08:52 |
lucasagomes | the image gets deployed, so the node reboots and it fails to boot the new OS ? | 08:52 |
lucasagomes | bcornec, for the serial, I believe you can use the ipmi console http://docs.openstack.org/developer/ironic/deploy/install-guide.html#configure-node-web-console | 08:53 |
lucasagomes | for the console* | 08:54 |
bcornec1 | Yes, it doesn't seem the install worked as there is nothing on the disk. I guesses it was due to lack of Smart Array support, so I started to add a Raid JSON file, but all that is trial and error from the outside, would be much better to get logs and console shell :-( | 08:54 |
bcornec1 | I don't use IPMI. I'm on the iLO support. Want to have agent_ilo working fine, in UEFI, so I can start hacking the Redfish support from that once it's working. | 08:55 |
bcornec1 | I'll need to change room as I'm with a customer for a PoC, on this !!! Connecting back in 10 minutes or so. | 08:56 |
bcornec1 | The node reboots, then goes to PXE. Using UEFI I can see that the disk has not been prepared. I also guess that the image may not be UEFI compliant, but again no easy way to see it ... | 08:56 |
*** milan has quit IRC | 08:59 | |
*** bcornec1 has quit IRC | 09:01 | |
*** electrofelix has joined #openstack-ironic | 09:03 | |
*** dmk0202 has joined #openstack-ironic | 09:05 | |
*** moshele has quit IRC | 09:06 | |
*** dtantsur is now known as dtantsur|bbl | 09:10 | |
*** vmud213 has joined #openstack-ironic | 09:17 | |
openstackgerrit | Szymon Borkowski proposed openstack/ironic-python-agent: Add PCI devices list into the inventory https://review.openstack.org/326318 | 09:17 |
lucasagomes | bcornec, right, so the ilo console is the same as the ipmi (https://github.com/openstack/ironic/blob/8e81b964a5fc815a7d42be749331571f4bb56be1/ironic/drivers/modules/ilo/console.py#L24) | 09:18 |
lucasagomes | so you can use it | 09:18 |
openstackgerrit | Aparna proposed openstack/proliantutils: Add support to sort values of raid_config for 'share_physical_disks' https://review.openstack.org/326319 | 09:19 |
lucasagomes | bcornec, you will have more logs on the console, but maybe make the environment more constraint for testing first and then gradually add stuff? Like disable UEFI, check if it works | 09:20 |
lucasagomes | to try to isolate where's the problem | 09:20 |
sambetts|afk | Morning all | 09:23 |
*** sambetts|afk is now known as sambetts | 09:23 | |
* sambetts is sad because the neutron fwaas has broken his CI | 09:24 | |
*** mgoddard_ has quit IRC | 09:26 | |
*** e0ne has joined #openstack-ironic | 09:28 | |
*** vdrok has joined #openstack-ironic | 09:28 | |
*** bcornec1 has joined #openstack-ironic | 09:31 | |
sambetts | looks like there is already a fix merging :) | 09:31 |
openstackgerrit | Merged openstack/python-ironicclient: Add sanity tests for testing actions with Port https://review.openstack.org/240944 | 09:31 |
*** moshele has joined #openstack-ironic | 09:38 | |
*** mbound has joined #openstack-ironic | 09:39 | |
*** sacharya has joined #openstack-ironic | 09:40 | |
*** causten_ has quit IRC | 09:43 | |
openstackgerrit | Merged openstack/ironic: Update resources subnet CIDR https://review.openstack.org/317082 | 09:43 |
*** causten_ has joined #openstack-ironic | 09:43 | |
openstackgerrit | Sam Betts proposed openstack/ironic-specs: Add spec for interface attach and detach API https://review.openstack.org/317636 | 09:44 |
*** sacharya has quit IRC | 09:45 | |
lucasagomes | sambetts, morning | 09:46 |
sambetts | o/ lucasagomes | 09:47 |
openstackgerrit | Aparna proposed openstack/proliantutils: Sort values of raid_config for 'share_physical_disks' https://review.openstack.org/326319 | 09:48 |
*** vishwanathj has joined #openstack-ironic | 09:54 | |
openstackgerrit | Bharath kumar proposed openstack/ironic-specs: Correct RAID approved spec JSON https://review.openstack.org/326345 | 09:56 |
vdrok | morning ironic | 09:57 |
*** vishwanathj has quit IRC | 09:57 | |
*** vishwanathj has joined #openstack-ironic | 09:58 | |
lucasagomes | sambetts, quick q: where do I find the packages/applications available for tiny core linux? | 10:03 |
sambetts | lucasagomes: http://distro.ibiblio.org/tinycorelinux/7.x/x86_64/tcz/ | 10:03 |
lucasagomes | sambetts, cheers | 10:03 |
*** vishwanathj has quit IRC | 10:04 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 10:10 |
*** milan has joined #openstack-ironic | 10:16 | |
milan | morning ironic | 10:17 |
sambetts | o/ milan | 10:17 |
milan | sambetts, o/ :) | 10:19 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: Patch to test Grenade. https://review.openstack.org/311109 | 10:21 |
openstackgerrit | Merged openstack/ironic-inspector: Remove deprecated alias "root_device_hint" for "raid_device" hook https://review.openstack.org/325351 | 10:22 |
*** athomas has quit IRC | 10:24 | |
*** hparekh has quit IRC | 10:31 | |
*** dtantsur|bbl is now known as dtantsur | 10:32 | |
dtantsur | Morning sambetts, milan | 10:32 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic-lib: Support configdrive in iscsi deploy for whole disk images https://review.openstack.org/230924 | 10:37 |
*** hoangcx has quit IRC | 10:38 | |
*** rbartal has joined #openstack-ironic | 10:41 | |
sambetts | Hi dtantsur | 10:43 |
vdrok | morning milan sambetts and dtantsur | 10:43 |
sambetts | o/ vdrok | 10:43 |
dtantsur | morning vdrok | 10:44 |
openstackgerrit | Aparna proposed openstack/proliantutils: Passing 'process_input' to the running hpssacli process https://review.openstack.org/325730 | 10:44 |
*** hparekh has joined #openstack-ironic | 10:44 | |
*** itamarl has joined #openstack-ironic | 10:46 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-specs: Collect system logs from IPA upon a deploy failure https://review.openstack.org/323511 | 10:50 |
dtantsur | sambetts, when you have some time take a look at spec https://review.openstack.org/315413 please. looks promising, but I'm afraid I can miss something | 10:55 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic-lib: Support configdrive in iscsi deploy for whole disk images https://review.openstack.org/230924 | 10:55 |
sambetts | dtantsur: sure :) \ | 10:55 |
*** amotoki has quit IRC | 11:00 | |
*** wajdi has joined #openstack-ironic | 11:08 | |
*** wajdi has quit IRC | 11:15 | |
milan | morning vdrok, dtantsur | 11:20 |
*** amotoki has joined #openstack-ironic | 11:20 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add CLI tests to check JSON response body https://review.openstack.org/291239 | 11:25 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add test for 'port-show --field' command https://review.openstack.org/304008 | 11:26 |
*** mgoddard has joined #openstack-ironic | 11:28 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Negative tests for port-related commands https://review.openstack.org/259354 | 11:28 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Tests for testing port-create command https://review.openstack.org/291802 | 11:30 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Tests for testing port-create command https://review.openstack.org/291802 | 11:30 |
openstackgerrit | Bharath kumar proposed openstack/ironic: adding back the inspect_ports as an optional parameter https://review.openstack.org/325230 | 11:31 |
*** joprovost has joined #openstack-ironic | 11:34 | |
*** chihhsin has quit IRC | 11:35 | |
*** lucasagomes is now known as lucas-hungry | 11:40 | |
*** sacharya has joined #openstack-ironic | 11:41 | |
*** joprovost has quit IRC | 11:43 | |
*** sacharya has quit IRC | 11:46 | |
sambetts | dtantsur: just reading through the pci spec, does this spec need reworking to populate this information in the hardware manager/inventory and process it from the inventory on the inspector side? | 11:46 |
dtantsur | sambetts, that's a hard question. I'm afraid that such change would pollute the inventory with not-so-useful for everyone stuff | 11:47 |
dtantsur | also I'd prefer it to be disableable | 11:47 |
dtantsur | jroll, you opinion re ^^^? spec https://review.openstack.org/315413 | 11:48 |
openstackgerrit | Merged openstack/ironic: Keep original error message when cleaning tear down fails https://review.openstack.org/325991 | 11:49 |
sambetts | dtantsur: I thought we were moving away from having inspector specific collectors though right, using the inventory instead? Thats why I implemented the lldp stuff in the generic hardware manager | 11:50 |
openstackgerrit | Aline Bousquet proposed openstack/ironic-lib: Add support for metrics https://review.openstack.org/301526 | 11:51 |
dtantsur | sambetts, I've never heard about moving away from inspector collectors. I rather thought of it as of something as weird it probably should not go to inventory. | 11:52 |
dtantsur | sambetts, e.g. the extra_hardware collector gets back HUGE amount of data and requires plenty of dependencies on the ramdisk | 11:52 |
dtantsur | so I was thinking this PCI case might be the same.. or maybe not | 11:52 |
* dtantsur looks how many PCI devices he has and tries to imagine | 11:53 | |
*** kalpase has left #openstack-ironic | 11:53 | |
dtantsur | so, my dell tower has 77 PCI devices. it will probably increase the inventory substantially | 11:54 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Tests for testing node-create command https://review.openstack.org/262055 | 11:54 |
*** thrash|g0ne is now known as thrash | 11:56 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Update the api-ref documentation for Drivers https://review.openstack.org/313708 | 11:58 |
*** dprince has joined #openstack-ironic | 11:59 | |
*** amotoki has quit IRC | 12:00 | |
*** baoli has joined #openstack-ironic | 12:01 | |
sambetts | dtantsur: hmmm, interesting, I guess I don't know the full extent of the inventory's uses, I guess I have the attitude of if its useful for inspector its probably useful for someone else, but I don't know who that someone else is | 12:01 |
*** baoli_ has joined #openstack-ironic | 12:02 | |
*** baoli has quit IRC | 12:05 | |
*** amotoki has joined #openstack-ironic | 12:09 | |
dtantsur | sambetts, "I don't know the full extent of the inventory's uses" neither do I, that's the problem :) | 12:12 |
sambetts | JayF, maybe you can help enlighten us ^ | 12:13 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Gracefully degrade start_iscsi_target for Mitaka ramdisk https://review.openstack.org/319183 | 12:15 |
*** mgould|afk is now known as mgould | 12:17 | |
sambetts | o/ mgould | 12:17 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: Tenant network separation for in-band inspection https://review.openstack.org/320003 | 12:17 |
dtantsur | hey-hey mgould, back finally? | 12:17 |
mgould | yep | 12:18 |
mgould | system upgrades: just say no | 12:18 |
sambetts | hehe | 12:18 |
dtantsur | lol | 12:19 |
dtantsur | (says man using F24 beta because of hardware upgrade) | 12:19 |
sambetts | dtantsur: did you manage to get most of your issues sorted? | 12:19 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal power state commands https://review.openstack.org/172517 | 12:20 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add maintenance mode commands https://review.openstack.org/216727 | 12:20 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add provision state commands https://review.openstack.org/206119 | 12:20 |
mgould | dtantsur: I considered installing F24, but decided I'd already exceeded my YOLO ration | 12:21 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Fix quotation mark in docstring https://review.openstack.org/326416 | 12:21 |
dtantsur | hehe | 12:21 |
*** trown|outtypewww is now known as trown | 12:22 | |
*** piet has joined #openstack-ironic | 12:22 | |
*** piet has quit IRC | 12:26 | |
*** jjohnson2 has joined #openstack-ironic | 12:29 | |
*** jcoufal has joined #openstack-ironic | 12:30 | |
TheJulia | good morning everyone | 12:33 |
sambetts | Hi TheJulia | 12:33 |
mgould | morning TheJulia | 12:36 |
jroll | dtantsur: my opinion on what, specifically? | 12:36 |
jroll | also how do you have 77 pci devices O_o | 12:37 |
jroll | morning everyone | 12:37 |
* jroll $ lspci | wc -l | 12:38 | |
jroll | 15 | 12:38 |
vdrok | morning TheJulia and jroll | 12:38 |
jroll | sambetts: also, we don't use inspector so I'm not sure if jay can enlighten you :P | 12:39 |
dtantsur | jroll, dunno, I used the same command :) on which hardware do you use it? | 12:40 |
*** lucas-hungry is now known as lucasagomes | 12:40 | |
sambetts | jroll: I'm hoping JayF might have an idea of what the IPA inventory is used for other than inspector | 12:40 |
dtantsur | jroll, opinion on putting heavy stuff to inventory versus creating an inspection collector | 12:40 |
jroll | dtantsur: a tower I built | 12:40 |
vdrok | sambetts, there is a return inside the loop instead of break | 12:41 |
jroll | sambetts: oh, originally we had hoped to store it all in ironic but it never happened because, cmdb | 12:41 |
dtantsur | jroll, "I built" may be the key :) | 12:41 |
jroll | heh, yeah | 12:41 |
jroll | it has a gpu and stuff, dunno | 12:41 |
jroll | dtantsur: anyway, now I see what you mean, that does seem heavy for the inventory posted to ironic | 12:41 |
sambetts | vdrok: oooh yeah sorry, my eyes were playing silly with the indentation, I thought the return was outside the loop | 12:42 |
*** rbudden has joined #openstack-ironic | 12:42 | |
lucasagomes | TheJulia, jroll vdrok morning | 12:42 |
vdrok | sambetts, yep, gerrit is not good at indentation highlight in this case :) | 12:42 |
vdrok | morning lucasagomes | 12:42 |
dtantsur | also g'morning jroll, TheJulia | 12:43 |
jroll | :) | 12:43 |
dtantsur | jroll, could you please evaluate RFE https://bugs.launchpad.net/ironic/+bug/1572529 as soon as you get some coffee? | 12:44 |
openstack | Launchpad bug 1572529 in Ironic "[RFE] DRAC RAID configuration" [Wishlist,In progress] - Assigned to Imre Farkas (ifarkas) | 12:44 |
dtantsur | sambetts, so, are you fine with keeping the PCI listing in a collector? | 12:45 |
jroll | dtantsur: sounds like generic raid but do it through the bmc, seems fine to me | 12:46 |
dtantsur | good. rfe-approved? | 12:46 |
openstackgerrit | Julia Kreger proposed openstack/ironic-specs: Update active node creation spec based on feedback https://review.openstack.org/326066 | 12:47 |
sambetts | dtantsur: not sure, probably initally, I guess the alternative is to extend the hardware manager, and have a kernal parameter to toggle whether to include it in the inventory or not | 12:47 |
dtantsur | sambetts, well, I don't quite like having inventory depend on kernel parameters too much (lldp being an exception). especially if nobody except for inspector is going to benefit from it | 12:48 |
dtantsur | (in this case list of collectors is a kernel parameter you're looking for) | 12:48 |
openstackgerrit | Julia Kreger proposed openstack/ironic-specs: Update active node creation spec based on feedback https://review.openstack.org/326066 | 12:49 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Tests for testing node-create command https://review.openstack.org/262055 | 12:49 |
sambetts | so the thing thats bugging me is that I don't why we bother with the hardware manager inventory if 1 Ironic ignores it, and 2 inspector is going to circumvent it | 12:50 |
*** links has quit IRC | 12:51 | |
*** ccarmack has joined #openstack-ironic | 12:51 | |
*** links has joined #openstack-ironic | 12:52 | |
dtantsur | sambetts, well, not really circumvent, that's not true. we're still extending inventory (just landed CPU flags and boot mode). | 12:52 |
*** thiagop has joined #openstack-ironic | 12:53 | |
dtantsur | sambetts, the problem is that sometimes we need to get A LOT of information. e.g. the extra_hardware collector collects a JSON with hundreds to thousands elements | 12:53 |
dtantsur | we don't want THAT to be posted to ironic :) | 12:53 |
thiagop | Good morning Ironic | 12:53 |
dtantsur | morning thiagop | 12:53 |
jroll | dtantsur: yeah, I'll approve it | 12:53 |
dtantsur | thnx | 12:54 |
jroll | dtantsur: sambetts: I'd love to actually store the hw mgr inventory in ironic one day, I think we could do some interesting things with it | 12:55 |
dtantsur | jroll, we could, yeah. so would you prefer the PCI listing to be there? | 12:55 |
jroll | dtantsur: probably not yet :D | 12:56 |
jroll | dtantsur: if we do it, let's figure out the db structure and such first (well, and if it's useful at all), and then maybe promote some collectors as needed | 12:57 |
dtantsur | makes sense | 12:57 |
*** bcornec1 has quit IRC | 12:57 | |
dtantsur | sambetts, ^^? | 12:57 |
sambetts | dtantsur: right, but we're extending it for ourselves only, ideally I guess we should all be using the hardware managers, and I guess we should have a list of hardware managers to run as a kernal parameter, like we have for collectors now | 12:57 |
jroll | another alternative is to always use the hw mgrs, but be very specific (in code, not config) about what's sent to ironic | 12:58 |
*** rloo has joined #openstack-ironic | 13:00 | |
*** oberezovskyi has quit IRC | 13:01 | |
*** vmud213 has quit IRC | 13:03 | |
sambetts | hmmm, /me suddenly had the thought that we should be not posting any inventory etc at lookup/inspection, and if inspector/ironic wants specific info it should be able to request it via the API :/ | 13:04 |
sambetts | (obviously we'd have to post the mac address/ipmi address because lookup) | 13:05 |
dtantsur | sambetts, I have a patch for not posting it on lookup, but for inspection.. it brings us close to the idea of SSH ramdisk, doesn't it? ;) | 13:05 |
jroll | sambetts: yeah, not a bad idea | 13:06 |
*** Goneri has joined #openstack-ironic | 13:08 | |
dtantsur | yeah, but a bit unrelated to this particular patch :) | 13:08 |
jroll | giving someone else a chance to approve this: https://review.openstack.org/#/c/319183/20 | 13:08 |
dtantsur | s/unrelated/out of scope/ | 13:08 |
jroll | 1/2 of the patches left to get grenade working | 13:08 |
sambetts | dtantsur: a refactor I guess | 13:08 |
dtantsur | sambetts, yeah. I just don't want to block this patch until we make up our mind and do the refactor | 13:09 |
dtantsur | jroll, looking | 13:09 |
jroll | well, hopefully 1/2, it depends on a -2 patch :| | 13:09 |
sambetts | dtantsur: sure, ok, I'll re-read that spec with that in mind :) | 13:10 |
dtantsur | jroll, usually I would -1 it for missing logging | 13:10 |
jroll | dtantsur: oh, good catch,t hanks | 13:10 |
dtantsur | vdrok, could you please follow up with a logging if we approve https://review.openstack.org/#/c/319183/ now? | 13:10 |
jroll | too late, I -1'd | 13:11 |
dtantsur | ok :) | 13:11 |
*** r-daneel has joined #openstack-ironic | 13:11 | |
*** amotoki has quit IRC | 13:13 | |
openstackgerrit | Julia Kreger proposed openstack/ironic: Active Node Creation via adopt state https://review.openstack.org/275766 | 13:13 |
NobodyCam | Good Morning Ironicers, says the person who feels much less like a zombie then yesterday. | 13:14 |
sambetts | Hi NobodyCam | 13:14 |
NobodyCam | hey sambetts :) | 13:14 |
*** nico-afk is now known as nicodemos | 13:15 | |
TheJulia | NobodyCam: Have you seen the movie Maggie? | 13:15 |
*** amotoki has joined #openstack-ironic | 13:15 | |
jroll | morning NobodyCam :) | 13:16 |
NobodyCam | Morning TheJulia jroll | 13:17 |
NobodyCam | :) | 13:17 |
NobodyCam | TheJulia: I don't think I've seen that one yet | 13:18 |
rbartal | lucasagomes, dtantsur, Hi guys, I try to disable the erase_device clean step by setting its priority to 0 (erase_devices_priority=0) and got this error "Failed to tear down from cleaning for node" | 13:21 |
nicodemos | morning ironic! | 13:22 |
NobodyCam | morning nicodemos | 13:22 |
thiagop | morning NobodyCam | 13:22 |
*** chihhsin has joined #openstack-ironic | 13:22 | |
NobodyCam | morning thiagop :) | 13:22 |
dtantsur | morning NobodyCam | 13:22 |
dtantsur | and nicodemos | 13:22 |
NobodyCam | hey hey dtantsur :) | 13:23 |
NobodyCam | good morning :) | 13:23 |
dtantsur | jroll, rbartal sees a strange keystone error (HTTP 404) when tearing down cleaning. have you seen anything like that? | 13:23 |
jroll | dtantsur: nope O_o | 13:23 |
*** r-daneel has quit IRC | 13:24 | |
jroll | dtantsur: at which piece, I'm surprised we talk to keystone on teardown at all, maybe to talk to neutron though? | 13:24 |
dtantsur | jroll, we talk neutronclient, which talks to keystone first | 13:24 |
dtantsur | to authenticate the request | 13:24 |
jroll | dtantsur: rbartal: is it reproducible every time or sporadic? | 13:24 |
jroll | also, master or? | 13:24 |
lucasagomes | yeah, this happens trhough neutronclient when it tries to list the ports | 13:25 |
dtantsur | mitaka. dunno about reproduceability | 13:25 |
NobodyCam | good morning lucasagomes | 13:26 |
jroll | we let neutronclient auth for us, so could be a bug there or just bad config | 13:26 |
jroll | e.g. if conf.neutron.auth_url is wrong | 13:26 |
lucasagomes | NobodyCam, hi there | 13:26 |
dtantsur | well, but deployment seems to work | 13:26 |
NobodyCam | :) | 13:26 |
dtantsur | jroll, I don't think we have conf.neutron.auth_url, it uses keystone_authtoken section (which is wrong, but still) | 13:26 |
jroll | dtantsur: yeah, I'd guess some sort of bug in the client then | 13:26 |
jroll | mitaka certainly has neutron.auth_url | 13:27 |
jroll | I'm staring at it :) | 13:27 |
dtantsur | jroll, link handy? | 13:27 |
jroll | oh no, you're right | 13:27 |
* jroll is dumb | 13:27 | |
jroll | you're sure the 404 is keystone? | 13:27 |
*** sdake has joined #openstack-ironic | 13:28 | |
dtantsur | rbartal, mind pasting the backtrace to a public location? | 13:28 |
rbartal | dtantsur, sure, 1 sec | 13:28 |
*** frontrunner has joined #openstack-ironic | 13:29 | |
*** PollyZ has joined #openstack-ironic | 13:29 | |
*** maurosr has quit IRC | 13:30 | |
rbartal | dtantsur, jroll http://paste.openstack.org/show/508645/ | 13:32 |
*** _milan_ has joined #openstack-ironic | 13:32 | |
* lucasagomes finds it odd that unauthorized returns 404 | 13:32 | |
dtantsur | I think they have a generic exception there | 13:32 |
rbartal | lucasagomes, Bluejeans link please | 13:33 |
*** milan has quit IRC | 13:33 | |
jroll | so, File "/usr/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 335, in retry_request | 13:34 |
jroll | makes me think the token went invalid somewhere here | 13:34 |
jroll | which is why I ask how reproducible this is :) | 13:34 |
*** sdake_ has joined #openstack-ironic | 13:34 | |
openstackgerrit | Merged openstack/ironic-inspector-specs: Generic PCI Resource spec https://review.openstack.org/315413 | 13:34 |
* sambetts thinks I've seen this before | 13:34 | |
*** sdake has quit IRC | 13:36 | |
sambetts | jroll: I think I merged a fix for this which later got reverted | 13:36 |
*** r-daneel has joined #openstack-ironic | 13:36 | |
jroll | sambetts: :| | 13:37 |
*** maurosr has joined #openstack-ironic | 13:40 | |
*** causten_ has quit IRC | 13:42 | |
sambetts | jroll: So my at least part of my change is still there I think, I belive I saw this issue when the token in the task context is reused and passed into neutron client | 13:44 |
*** mgoddard_ has joined #openstack-ironic | 13:45 | |
sambetts | jroll: in my out of tree driver I think I fixed it by just simply not passing a token into neutron _build_client | 13:45 |
sambetts | jroll: but there was a problem were we didn't pass the username and password into neutron client in _build_client, so in retry_request in neutron client it fell over because it couldn't reauthenticate | 13:46 |
sambetts | jroll: and thats what I fixed in Ironic | 13:46 |
jroll | sambetts: oh, interesting | 13:46 |
*** mgoddard has quit IRC | 13:48 | |
*** amotoki has quit IRC | 13:48 | |
sambetts | jroll: https://bugs.launchpad.net/ironic/+bug/1524779 | 13:50 |
openstack | Launchpad bug 1524779 in Ironic "Neutron client will fail to re-authenticate if token expires because no credentials are provided" [Undecided,Fix released] - Assigned to Sam Betts (sambetts) | 13:50 |
jroll | sambetts: so part of that was reverted? why? | 13:51 |
*** ametts has joined #openstack-ironic | 13:53 | |
sambetts | jroll: I'm sure I remember it being reverted, but git blaming it, it seems like some of it is there still, there was some talk that Keystone v3/auth/sessions would fix this I think :/ | 13:53 |
jroll | sambetts: hrm, ok | 13:54 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Tests for testing node-create command https://review.openstack.org/262055 | 13:55 |
sambetts | jroll: looking at the code, I would guess that one of these params['username'] = CONF.keystone_authtoken.admin_user | 13:57 |
sambetts | params['tenant_name'] = CONF.keystone_authtoken.admin_tenant_name | 13:57 |
sambetts | params['password'] = CONF.keystone_authtoken.admin_password | 13:57 |
sambetts | is misconfigured for rbartals error | 13:57 |
jroll | sambetts: well, then it would have a hard time auth'ing incoming requests no? | 13:58 |
jroll | it's also used for the authtoken middleware | 13:58 |
dtantsur | correct | 13:58 |
sambetts | hmmm, good point :/ | 13:58 |
* jroll takes super early lunch, bbl | 13:59 | |
sambetts | o/ | 13:59 |
*** Goneri has quit IRC | 14:01 | |
*** rloo has quit IRC | 14:03 | |
*** rloo has joined #openstack-ironic | 14:03 | |
sambetts | dtantsur, rbartal: Do you know if your running ks v2 or v3 ? | 14:05 |
dtantsur | judging by configuration, v3. not sure what actually. | 14:06 |
*** bcornec1 has joined #openstack-ironic | 14:06 | |
rbartal | dtantsur, How can I check? | 14:08 |
openstackgerrit | Hugo Nicodemos proposed openstack/python-oneviewclient: Adding dynamic allocation operations https://review.openstack.org/258699 | 14:10 |
*** ChrisAusten has joined #openstack-ironic | 14:10 | |
dtantsur | rbartal, `openstack endpoint show identity` shows v2.0 for me on liberty, for example | 14:10 |
dtantsur | though my ironic configuration also used v3. wtf?? | 14:10 |
devananda | morning, all | 14:13 |
sambetts | rbartal: you don't happen to have the keystone logs for the other end of this request do you? Because the 404 error in the ironic logs doesn't give us much insight into which part of the request caused the 404 | 14:14 |
devananda | hmm. not awake yet, but I see ya'll talking about keystone v3 ? | 14:14 |
thiagop | dtantsur: I think both works, but the rc file by default sets 2.0 on liberty | 14:14 |
sambetts | devananda: yeah, rbartal is seeing a weird keystone 404 from neutron client on cleaning, not sure if related to https://bugs.launchpad.net/ironic/+bug/1524779 which I fixed a little while ago | 14:14 |
openstack | Launchpad bug 1524779 in Ironic "Neutron client will fail to re-authenticate if token expires because no credentials are provided" [Undecided,Fix released] - Assigned to Sam Betts (sambetts) | 14:14 |
dtantsur | morning devananda. early for you, isn't it? | 14:15 |
thiagop | dtantsur: that was supposed to change on mitaka, don't know if it landed though | 14:15 |
devananda | dtantsur: a bit, yes | 14:15 |
rbartal | sambetts, I can get the keystone log, just need some time | 14:15 |
devananda | I have been looking at keystone v2/v3 things recently as I've been adding policy support | 14:15 |
*** chlong has quit IRC | 14:16 | |
rbartal | dtantsur, http://paste.openstack.org/show/508667/ | 14:16 |
*** Goneri has joined #openstack-ironic | 14:17 | |
devananda | rbartal: what's the error you're seeing in ironic's logs? | 14:17 |
sambetts | devananda: http://paste.openstack.org/show/508645/ | 14:18 |
sambetts | ironic logs ^ | 14:18 |
thiagop | rbartal: do you see anything on neutron logs? | 14:18 |
lucasagomes | folks, wondering what you guys think about the proposed solution here: https://bugs.launchpad.net/ironic/+bug/1588901 | 14:19 |
openstack | Launchpad bug 1588901 in Ironic "Nodes stuck on power state transitions" [High,Confirmed] - Assigned to Lucas Alvares Gomes (lucasagomes) | 14:19 |
rbartal | thiagop, I'm going to check | 14:20 |
rbartal | dtantsur, sambetts my keystone is v2 | 14:20 |
mgould | morning devananda | 14:21 |
thiagop | lucasagomes: wonder about the workload of a periodic like that, but seem like a good solution | 14:22 |
devananda | lucasagomes: minor edit to your proposal there: | 14:22 |
openstackgerrit | John L. Villalovos proposed openstack/ironic: Update comment from NOTE to TODO https://review.openstack.org/326504 | 14:22 |
lucasagomes | thiagop, devananda thanks, will take a look | 14:22 |
devananda | lucasagomes: http://paste.openstack.org/show/508668/ | 14:23 |
*** rama_y has joined #openstack-ironic | 14:23 | |
*** Goneri has quit IRC | 14:23 | |
thiagop | devananda: question: do we have to know which conductor is handling a node? I never deployed Ironic with multiple conductors... | 14:24 |
lucasagomes | devananda, a-ha ++ yes, we should only look at the conductor that are marked as "offline" inded | 14:24 |
thiagop | how to know* | 14:24 |
devananda | thiagop: yes | 14:24 |
thiagop | very cool | 14:24 |
lucasagomes | thiagop, if you look at the "reservation" field of the node, that's the name of the last conductor that touched that node | 14:25 |
lucasagomes | last/current* | 14:25 |
jlvillal | vsaienko, vdrok mgould: We are getting very close on Grenade :) 2 patches remaining, I think. | 14:26 |
sambetts | \o/ | 14:26 |
dtantsur | \o/ | 14:26 |
jlvillal | :) | 14:26 |
* jlvillal needs to get ready and into the office for an 8am meeting | 14:27 | |
vdrok | morning jlvillal | 14:29 |
vdrok | dtantsur, jroll fixing now | 14:29 |
lucasagomes | jlvillal, w00t | 14:31 |
*** _milan_ has quit IRC | 14:32 | |
*** chlong has joined #openstack-ironic | 14:32 | |
NobodyCam | morning vdrok jlvillal :) | 14:33 |
vdrok | morning NobodyCam | 14:33 |
*** frontrunner has quit IRC | 14:33 | |
thiagop | lucasagomes: I thought that field would be used for something on the claims thing :) | 14:33 |
NobodyCam | :) | 14:33 |
*** mgoddard_ has quit IRC | 14:33 | |
lucasagomes | thiagop, well, basically the claim would reserve the node for a given conductor to be deployed on | 14:34 |
lucasagomes | so yeah, I guess it would be used yes | 14:34 |
lucasagomes | if we have a claims api, last proposed changes on scheduling in nova may not need that | 14:34 |
rbartal | sambetts, dtantsur devananda keystone error: "2016-06-06 17:26:28.883 1531 DEBUG keystone.middleware.auth [req-df8007ad-0837-4ede-b8d3-b68ef5701a22 - - - - -] There is either no auth token in the request or the certificate issuer is not trusted. No auth context will be set. _build_auth_context /usr/lib/python2.7/site-packages/keystone/middleware/auth.py:71 | 14:35 |
rbartal | 2016-06-06 17:26:28.883 1531 INFO keystone.common.wsgi [req-df8007ad-0837-4ede-b8d3-b68ef5701a22 - - - - -] GET http://172.16.1.1:5000/v2.0/ | 14:35 |
thiagop | lucasagomes: I heard of it, I need to keep up on it today | 14:35 |
lucasagomes | thiagop, https://review.openstack.org/#/c/312696/ | 14:35 |
thiagop | lucasagomes: thanks | 14:35 |
*** sdake_ has quit IRC | 14:36 | |
thiagop | rbartal: I would use paste.openstack since logs have a bad reading on irc | 14:36 |
thiagop | :) | 14:37 |
*** Goneri has joined #openstack-ironic | 14:37 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Tests for testing chassis-create command https://review.openstack.org/293634 | 14:37 |
*** blakec has joined #openstack-ironic | 14:38 | |
vdrok | dtantsur, jroll are you good with the following? "The ironic python agent in the ramdisk on node %(node)s failed to start the iSCSI target because it doesn't support wipe_disk_metadata parameter, retrying without passing it. If you need to have node's root disk wiped before exposing it via iSCSI, please update the ramdisk to use version >= 1.3 (Newton, or higher) of ironic python agent." | 14:39 |
vdrok | as a warning | 14:39 |
rbartal | thiagop, right, http://paste.openstack.org/show/508678/ | 14:42 |
jroll | vdrok: sounds fine to me | 14:42 |
sambetts | dtantsur, rbartal, devananda: Looking at the neutronclient code, _authenticate_keystone, which is where the error is occuring from, passes the user id or username and password and tenantName or id to keystone to generate a token | 14:42 |
*** mgoddard has joined #openstack-ironic | 14:43 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Gracefully degrade start_iscsi_target for Mitaka ramdisk https://review.openstack.org/319183 | 14:44 |
sambetts | dtantsur, rbartal: from that keystone log it appears you are running both v2 and v3 APIs for keystone | 14:45 |
* sambetts is listening to the thunderstorm spinning up outside and is wondering if he's suddenly going to go AFK in a minute | 14:46 | |
rbartal | sambetts, dtantsur http://paste.openstack.org/show/508683/ | 14:46 |
* thiagop likes thunderstorms *_* | 14:49 | |
sambetts | thiagop: me too! | 14:49 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Tests for testing chassis-create command https://review.openstack.org/293634 | 14:51 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: WIP: Patch to test Grenade. https://review.openstack.org/311109 | 14:53 |
*** amotoki has joined #openstack-ironic | 14:53 | |
*** frontrunner has joined #openstack-ironic | 14:53 | |
JayF | alineb: https://review.openstack.org/#/c/321153/ got merged so your patch should be unblocked now | 14:54 |
NobodyCam | morning JayF | 14:54 |
sambetts | o/ JayF | 14:54 |
JayF | o/ | 14:54 |
JayF | although brb voting so don't wave too hard yet :) | 14:54 |
dtantsur | morning JayF | 14:54 |
alineb | o/ JayF, I've updated the patch according to the spec changes | 14:56 |
lucasagomes | dtantsur, https://review.openstack.org/#/c/232571/ (capabilities as dict, apparent openstackgerrit is dead) | 14:59 |
jlvillal | Good morning vdrok NobodyCam alineb dtantsur JayF sambetts rbartal jroll thiagop lucasagomes devananda rloo and everyone else :) | 14:59 |
sambetts | Morning jlvillal | 14:59 |
dtantsur | lucasagomes, fantastic! | 14:59 |
dtantsur | morning jlvillal | 14:59 |
dtantsur | lucasagomes, 2 moments though: 1. will Nova understand it? 2. what if we make one more step and move capabilities to their own node attribute? | 15:00 |
thiagop | good morning jlvillal | 15:00 |
lucasagomes | dtantsur, good points. So nova needs to be updated to support it | 15:02 |
*** absubram has quit IRC | 15:02 | |
dtantsur | yeah.. | 15:02 |
lucasagomes | dtantsur, we can move it to another field, biggest problem is the data migration | 15:02 |
rloo | good morning jlvillal, sambetts, dtantsur, alineb, lucasagomes, thiagop, JayF, NobodyCam | 15:03 |
dtantsur | morning rloo | 15:03 |
dtantsur | lucasagomes, it's a problem anyway... | 15:03 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Update the api-ref documentation for Drivers https://review.openstack.org/313708 | 15:03 |
dtantsur | like what do we do about clients which are not updated yet | 15:03 |
alineb | morning jlvillal, rloo | 15:03 |
lucasagomes | dtantsur, yeah, depends how we want to do it, exactly, we probably need to create a proxy from properties/capabilities to the new field | 15:04 |
lucasagomes | it gets complicated | 15:04 |
dtantsur | lucasagomes, it's required even in your patch, but with a separate field it might be easier to mess with API versions | 15:04 |
lucasagomes | dtantsur, if the idea is just make it easy to manipulate I think we should just do as the patch do, and have it as a dict (and string for backward compat) | 15:04 |
dtantsur | lucasagomes, no, it's the same problem: how to make old clients work | 15:04 |
dtantsur | lucasagomes, what I suggest is: if API version < 1.x, read and write properties/capabilities, else read and write node.capabilities | 15:05 |
lucasagomes | dtantsur, interesting, yeah seems a way around that. Would we need to translate node.capabilities to properties/capabilities on older versions? | 15:06 |
*** vishwanathj has joined #openstack-ironic | 15:06 | |
dtantsur | lucasagomes, I'm afraid, yes | 15:06 |
lucasagomes | dtantsur, maybe a spec would be good for it | 15:06 |
lucasagomes | cause there are corner cases | 15:06 |
dtantsur | probably | 15:07 |
*** yuriyz_ has joined #openstack-ironic | 15:08 | |
*** aarefiev_ has joined #openstack-ironic | 15:08 | |
*** blakec has quit IRC | 15:09 | |
*** vdrok_ has joined #openstack-ironic | 15:09 | |
*** e0ne_ has joined #openstack-ironic | 15:09 | |
*** vsaienko1 has joined #openstack-ironic | 15:10 | |
*** aarefiev has quit IRC | 15:12 | |
*** yuriyz has quit IRC | 15:12 | |
*** e0ne has quit IRC | 15:12 | |
*** vsaienko has quit IRC | 15:12 | |
*** Romanenko_K has quit IRC | 15:12 | |
*** vdrok has quit IRC | 15:12 | |
*** kromanenko_ has quit IRC | 15:12 | |
*** kromanenko_ has joined #openstack-ironic | 15:12 | |
*** kromanenko__ has quit IRC | 15:13 | |
*** Romanenko_K has joined #openstack-ironic | 15:13 | |
*** garthb has joined #openstack-ironic | 15:13 | |
*** kromanenko__ has joined #openstack-ironic | 15:13 | |
*** vdrok_ has quit IRC | 15:15 | |
*** vdrok-afk is now known as vdrok | 15:16 | |
*** rcernin has quit IRC | 15:17 | |
*** e0ne_ has quit IRC | 15:18 | |
*** e0ne has joined #openstack-ironic | 15:18 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Functional tests for portgroups in ironicclient https://review.openstack.org/297727 | 15:19 |
*** links has quit IRC | 15:26 | |
*** itamarl has quit IRC | 15:28 | |
openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Add test for chassis-node-list https://review.openstack.org/299482 | 15:28 |
*** sdake has joined #openstack-ironic | 15:28 | |
*** rama_y has quit IRC | 15:31 | |
openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Add test for chassis-node-list https://review.openstack.org/299482 | 15:31 |
jroll | lucasagomes: dtantsur: if we're going to move capabilities around, can we get rid of the json field there anyway? :) | 15:33 |
dtantsur | maybe? :) | 15:34 |
jroll | moving to node.capabilities is 90% of that pain anyway | 15:34 |
lucasagomes | jroll, heh that's the question. We probably need a spec for covering all the cases | 15:34 |
lucasagomes | jroll, but yeah, if we do move let's make it indexable | 15:35 |
*** mjura has quit IRC | 15:35 | |
jlvillal | One delicious comment line change patch up for review :) https://review.openstack.org/#/c/326504/ | 15:37 |
*** lifeless has quit IRC | 15:37 | |
jroll | lucasagomes: ++ | 15:37 |
jlvillal | sambetts: I'm curious about the current state of the Cisco CI. How's it working at the moment? | 15:40 |
lucasagomes | dtantsur, btw, not today but when you get some time I've updated the logs spec with ur suggestions (local storage for standalone and so on) https://review.openstack.org/#/c/323511/ | 15:40 |
dtantsur | cool | 15:40 |
sambetts | jlvillal: it had a sad moment last night, because tempest broke the neutron-fwaas tempest plugin | 15:41 |
sambetts | jlvillal: the fix mergered this morning and its passing tests again now | 15:41 |
jlvillal | sambetts: I just saw a failure on a patch I submitted an hour ago. So curious. | 15:41 |
jlvillal | sambetts: Okay great :) | 15:41 |
sambetts | jlvillal: oh link? | 15:41 |
jlvillal | sambetts: https://review.openstack.org/#/c/326504/ | 15:42 |
jlvillal | sambetts: Okay slightly more than an hour ago. | 15:42 |
*** sacharya has joined #openstack-ironic | 15:42 | |
dtantsur | FYI I'm adding a topic to https://etherpad.openstack.org/p/ironic-newton-midcycle to discuss this situation around building RAID at deploy-time | 15:43 |
jlvillal | JayF: Not sure if you saw my message about adding your name to the list of people working on CI improvements. I think you have been doing work in that area. | 15:43 |
sambetts | dtantsur: awesome :D | 15:43 |
jlvillal | https://etherpad.openstack.org/p/IronicWhiteBoard Line 96 | 15:43 |
JayF | jlvillal: there's a list of people? | 15:44 |
JayF | jlvillal: yeah, I've mainly been plugging all the new bits into project-config | 15:44 |
jlvillal | People to blam^H^H^H^H give credit to. | 15:44 |
*** mtanino has joined #openstack-ironic | 15:44 | |
JayF | jlvillal: did a little bit of science as well but all that ended up with is knowing that ipxe is faster, and we shouldn't change our nic in qemu | 15:44 |
sambetts | jlvillal: somethings gone weird in the devstack run for that test, its failing to configure a neutron router... but I have neutron l3 disabled in local.conf... soooo ... /me digs | 15:44 |
jlvillal | JayF: I added you. If you object, feel free to delete your name :) | 15:45 |
jlvillal | sambetts: Thanks! | 15:45 |
*** rbartal has quit IRC | 15:45 | |
NobodyCam | Morning rloo :-) | 15:45 |
jlvillal | sambetts: There was a patch doing things to the neutron router, that that patch is updating the comment for. | 15:45 |
* jlvillal goes to find link. | 15:45 | |
jlvillal | sambetts: https://review.openstack.org/317082 | 15:46 |
jlvillal | sambetts: Not sure if that would blow your tests up or not. | 15:46 |
JayF | jlvillal: I'm just curious where said list is :) | 15:46 |
sambetts | jlvillal: shouldn't do, as far as I know that shouldn't run in a normal devstack flow :/ | 15:46 |
jlvillal | JayF: https://etherpad.openstack.org/p/IronicWhiteBoard Line 96 | 15:47 |
jlvillal | sambetts: Oh yeah. True. | 15:47 |
jroll | jlvillal: JayF: the subteam list of people is the people noted as contacts in the priorities doc | 15:47 |
jroll | so, I removed JayF again :{P | 15:47 |
jroll | whoa, I grew a mustache | 15:47 |
sambetts | hahaha | 15:47 |
jlvillal | heh | 15:47 |
JayF | yeah please to not put me as a contact | 15:47 |
JayF | lol | 15:47 |
* jlvillal wonders if jroll invented a new emoticon | 15:47 | |
*** sacharya has quit IRC | 15:47 | |
jroll | JayF: I read your mind, don't worry :) | 15:48 |
jlvillal | sambetts: I'm not sure then why the Cisco CI is breaking then :( | 15:49 |
*** lifeless has joined #openstack-ironic | 15:49 | |
sambetts | no, I'm trying to work out if something merged in the last 4 hours that might have broken something, my last passed test was @ 12:16 | 15:50 |
*** harlowja_at_home has joined #openstack-ironic | 15:52 | |
sambetts | jlvillal: I think this might be the cause https://github.com/openstack-dev/devstack/commit/a45b40a630d4615455725bcfd8774c2afb054189 | 15:53 |
jlvillal | sambetts: Those son of a guns! ;) | 15:54 |
sambetts | jlvillal: its the only thing thats merged in the last 4 hours that might have affected it, so now I've got to work out why... | 15:54 |
*** harlowja_at_home has quit IRC | 15:54 | |
sambetts | jlvillal: it seems like they have removed an is_service_enabled q-l3 | 15:55 |
sambetts | jlvillal: which is causing it to go into code that it didn't go before | 15:55 |
*** absubram has joined #openstack-ironic | 15:55 | |
*** sacharya has joined #openstack-ironic | 16:03 | |
*** Jabadia has joined #openstack-ironic | 16:05 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-specs: Collect system logs from IPA upon a deploy failure https://review.openstack.org/323511 | 16:06 |
dtantsur | lucasagomes, oops, also on one of previous revisions I've asked to have an option to *always* store deploy logs, even on success | 16:07 |
dtantsur | could you please add it too? | 16:07 |
lucasagomes | dtantsur, yeah I saw that. I think I've asked to extend it later... lemme think on it a bit more | 16:09 |
*** frontrunner has quit IRC | 16:09 | |
lucasagomes | dtantsur, perhaps the option to enable/disable it should support values like "always", "deploy failure" or something like that? | 16:09 |
dtantsur | I'm not going to block due to that, but based on my inspector experience that's an absolute must | 16:09 |
dtantsur | yeah | 16:09 |
dtantsur | enough times it just does the wrong thing without failing... >_< | 16:09 |
lucasagomes | yeah, it can finish the deployment and the image does boot or things like that | 16:10 |
*** mgoddard has quit IRC | 16:10 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Register all tempest options if not registered https://review.openstack.org/326607 | 16:10 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Register tempest options unconditionally https://review.openstack.org/326608 | 16:10 |
lucasagomes | lemme just see how it would look like to with that feature | 16:10 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Tests for testing node-create command https://review.openstack.org/262055 | 16:12 |
*** frontrunner has joined #openstack-ironic | 16:12 | |
*** Jabadia has quit IRC | 16:13 | |
*** tesseract has quit IRC | 16:13 | |
*** Jabadia has joined #openstack-ironic | 16:13 | |
lucasagomes | JayF, you have any thoughts/objects on ^ ? | 16:14 |
lucasagomes | I think it's useful, but will need to change the spec | 16:14 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Register all tempest options if not registered https://review.openstack.org/326607 | 16:15 |
lucasagomes | dtantsur, maybe I can leave open grounds to it? Make the config option open to accept other values (not only true/false) and do it as a separated work? | 16:15 |
lucasagomes | I'm afraid of making the spec too big | 16:15 |
jroll | oops, messed that one up | 16:15 |
lucasagomes | ppl may want log from cleaning and other tasks, I don't wanna keep putting too much onto that work | 16:15 |
lucasagomes | but I can make it simple to extend | 16:15 |
dtantsur | lucasagomes, this is a tiny change, I'm not sure what's the problem with it | 16:17 |
*** dprince has quit IRC | 16:17 | |
dtantsur | like: if deploy_failed or CONF.agent.store_deploy_logs == 'always' | 16:17 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Register tempest options unconditionally https://review.openstack.org/326608 | 16:17 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Register all tempest options if not registered https://review.openstack.org/326607 | 16:17 |
jroll | there we go | 16:17 |
*** r-daneel has quit IRC | 16:17 | |
lucasagomes | dtantsur, right, yeah, I guess most of the changes are just how we word the spec (even the title is about "deploy failure") | 16:19 |
lucasagomes | same for problem description and so on | 16:19 |
lucasagomes | dtantsur, I will mark as WIP and rewrite the bits tomorrow | 16:19 |
dtantsur | lucasagomes, just a wider definition of "failure", I guess :) | 16:19 |
dtantsur | lucasagomes, well, ok, we can add it as an RFE later | 16:19 |
lucasagomes | dtantsur, it's cool, marking as WIP. Tomorrow I will update it | 16:20 |
jlvillal | rloo: Great catch on https://review.openstack.org/#/c/319183/ :) | 16:20 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Add an option to not fail when root device is not supplied https://review.openstack.org/326620 | 16:21 |
rloo | jlvillal: which one. cuz the one i thought was wrong, was actually right. | 16:21 |
jlvillal | rloo: Though you did do a +1. /me would have thought -1 | 16:21 |
jlvillal | rloo: Ahh. I didn't see your follow-on comment | 16:21 |
*** sabeen has joined #openstack-ironic | 16:21 | |
rloo | jlvillal: oh wait. i think it is wrong. not sure. | 16:22 |
JayF | lucasagomes: no objection here at all. I might would even advocate for our production config to enable it. | 16:22 |
jroll | jlvillal: rloo: it's right | 16:22 |
lucasagomes | JayF, cool, thanks. Marked the spec as WIP and will update it tomorrow | 16:22 |
rloo | jlvillal: depends on whether the return result line is indented under the while, or at the same level of the while. i can't tell by eyeballing. | 16:22 |
vdrok | jlvillal: rloo it won't loop forever | 16:23 |
* jlvillal will look more closely | 16:23 | |
rloo | jroll, vdrok: i think i would have liked a break instead of a continue. but that may just be me, cuz i tripped on the existing code. | 16:24 |
vdrok | see the previous patchset comments | 16:24 |
jroll | the test verifies that it's correct, btw | 16:24 |
*** amotoki has quit IRC | 16:24 | |
jroll | rloo: sure, that's fair, just saying it's right :) | 16:24 |
*** Jabadia has quit IRC | 16:24 | |
rloo | vdrok, jroll: yes, i realize it is right. just wondering whether we can/should redo it so that it is more obvious. | 16:24 |
*** ifarkas has quit IRC | 16:25 | |
rloo | vdrok, jroll: or add more comments. eg, in this case, we don't retry cuz ... | 16:25 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Add an option to not fail when root device is not supplied https://review.openstack.org/326620 | 16:25 |
vdrok | rloo: OK will do, just going to let the grenade run to finish | 16:26 |
*** r-daneel has joined #openstack-ironic | 16:26 | |
rloo | vdrok: just a suggestion :) | 16:26 |
rloo | vdrok: why do we need to make a copy of param? | 16:26 |
*** jabadia has joined #openstack-ironic | 16:27 | |
*** jaybeale has joined #openstack-ironic | 16:27 | |
vdrok | rloo: it's for the unittest unfortunately | 16:29 |
*** Romanenko_K has quit IRC | 16:29 | |
*** jabadia has quit IRC | 16:29 | |
*** kromanenko__ has quit IRC | 16:29 | |
vdrok | if not copy it, mock.call has the reference to a params dictionary | 16:29 |
*** Jabadia has joined #openstack-ironic | 16:29 | |
vdrok | so if we just do the del, it will be the same in both mock calls | 16:29 |
*** kromanenko_ has quit IRC | 16:29 | |
*** dmk0202 has quit IRC | 16:30 | |
rloo | vdrok: should at least put a comment then. although i really don't like it; i'd almost rather we didn't test for that. | 16:30 |
vdrok | and instead of being shown as called with 3 params first time and 2 params second time, it will report that it was called twice with 2 params | 16:30 |
vdrok | rloo: I can try to do it with mock.call_args[0][1] or something like that, but it will be uglier | 16:32 |
dtantsur | see you tomorrow, g'night | 16:32 |
rloo | vdrok: so my preference would be no copy, and put a comment in the actual test. but that is me. i think if you want to do the copy, put a comment in the code. | 16:32 |
rloo | night dtantsur | 16:32 |
vdrok | good night dtantsur | 16:32 |
rloo | vdrok: i think we want to get the code in, so i am fine with a comment. someone could try to improve on it later. | 16:33 |
NobodyCam | night dtantsur | 16:33 |
*** dtantsur is now known as dtantsur|afk | 16:33 | |
*** fragatina has joined #openstack-ironic | 16:34 | |
*** e0ne has quit IRC | 16:35 | |
*** fragatina has quit IRC | 16:35 | |
*** fragatina has joined #openstack-ironic | 16:35 | |
*** e0ne has joined #openstack-ironic | 16:35 | |
*** e0ne has quit IRC | 16:40 | |
*** rama_y has joined #openstack-ironic | 16:40 | |
*** derekh has quit IRC | 16:40 | |
*** e0ne has joined #openstack-ironic | 16:41 | |
jlvillal | The Ironic email thread has been interesting for me to read. FYI, if people haven't seen it: http://lists.openstack.org/pipermail/openstack-dev/2016-June/096715.html | 16:45 |
*** e0ne has quit IRC | 16:49 | |
lucasagomes | calling it a day, have a great evening all | 16:51 |
lucasagomes | talk to you all tomorrow | 16:51 |
*** bharath has joined #openstack-ironic | 16:52 | |
*** lucasagomes is now known as lucas-dinner | 16:52 | |
vdrok | night lucas-dinner | 16:52 |
NobodyCam | night lucas-dinner | 16:52 |
bharath | can someone review https://review.openstack.org/#/c/326345/ ? | 16:53 |
*** dprince has joined #openstack-ironic | 16:53 | |
jlvillal | lucas-dinner: Ciao! | 16:55 |
jroll | bharath: approved | 16:56 |
jroll | thanks for that | 16:56 |
*** ijw has joined #openstack-ironic | 16:59 | |
*** bharath has quit IRC | 16:59 | |
*** vishwanathj has quit IRC | 17:00 | |
*** r-daneel has quit IRC | 17:02 | |
*** trown is now known as trown|lunch | 17:02 | |
*** bcornec1 has quit IRC | 17:05 | |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal power state commands https://review.openstack.org/172517 | 17:06 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add maintenance mode commands https://review.openstack.org/216727 | 17:06 |
openstackgerrit | Brad P. Crochet proposed openstack/python-ironicclient: Add provision state commands https://review.openstack.org/206119 | 17:06 |
vdrok | rloo: so the only way I found to get rid of .copy in the function is to override _mock_call private method of mock.Mock to do the deepcopy of the arguments | 17:09 |
rloo | vdrok: don't do that. I don't think it is worth it. | 17:10 |
vdrok | ++ | 17:10 |
rloo | vdrok: but thx for looking. just add a comment. the comment could also have a TODO(vdrok) get rid of this one day :) | 17:10 |
vdrok | and I think we want to do some unittesting of what was called, so I'll add a comment | 17:11 |
vdrok | yep | 17:11 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Update devstack plugin with new auth options https://review.openstack.org/297312 | 17:11 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Migrate to using keystoneauth Sessions https://review.openstack.org/236982 | 17:11 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Warn on legacy auth options on conductor start https://review.openstack.org/326660 | 17:11 |
*** ohamada has quit IRC | 17:13 | |
*** moshele has quit IRC | 17:14 | |
*** r-daneel has joined #openstack-ironic | 17:15 | |
*** PollyZ has quit IRC | 17:20 | |
*** amotoki has joined #openstack-ironic | 17:24 | |
openstackgerrit | Merged openstack/ironic-specs: Correct RAID approved spec JSON https://review.openstack.org/326345 | 17:28 |
*** amotoki has quit IRC | 17:29 | |
sambetts | jlvillal: my CI got broke because that commit made the neutron tempest code suddenly start caring if I hadn't configured a IPv6 subnet CIDR in my local.conf | 17:31 |
jlvillal | sambetts: Thanks for figuring it out! :) | 17:31 |
sambetts | jlvillal: I've pushed an update to my tests local.conf to force v4 so it should me happy again now I hope | 17:31 |
*** sabeen has quit IRC | 17:37 | |
*** PollyZ has joined #openstack-ironic | 17:37 | |
sambetts | Anyone else seeing the gerrit sign in broken?! | 17:38 |
*** sabeen has joined #openstack-ironic | 17:39 | |
*** keekz_ is now known as nicholas | 17:40 | |
*** nicholas is now known as keekz | 17:40 | |
*** keekz is now known as nicholas | 17:40 | |
*** PollyZ has quit IRC | 17:42 | |
sambetts | its late and I can't sign into gerrit, so /me -> afk | 17:44 |
*** nicholas is now known as keekz | 17:44 | |
*** sambetts is now known as sambetts|afk | 17:44 | |
*** Sukhdev has joined #openstack-ironic | 17:46 | |
sambetts|afk | Night all | 17:46 |
vdrok | night sambetts|afk | 17:48 |
*** Sukhdev has quit IRC | 17:48 | |
*** PollyZ has joined #openstack-ironic | 17:51 | |
*** priteau has joined #openstack-ironic | 17:52 | |
*** garthb_ has joined #openstack-ironic | 17:53 | |
NobodyCam | night sambetts|afk | 17:54 |
*** garthb has quit IRC | 17:55 | |
*** PollyZ has quit IRC | 17:55 | |
*** fragatina has quit IRC | 17:56 | |
*** e0ne has joined #openstack-ironic | 17:59 | |
devananda | JayF: around? | 18:02 |
JayF | aye | 18:02 |
*** electrofelix has quit IRC | 18:02 | |
JayF | Was out sick yesterday but roaring to go today | 18:02 |
*** e0ne has quit IRC | 18:02 | |
devananda | JayF: ugh. well, glad you're feeling better! | 18:03 |
devananda | JayF: I've got the devstack changes up too, now, though I haven't finished the base changes to ironic | 18:03 |
JayF | Yeah; I saw the patchset exists but haven't looked at it in-depth yet | 18:03 |
JayF | just gone done w/morning meetings and email catchup and was going to start into 'real work' :) | 18:04 |
devananda | JayF: even though the service actually works, unit tests are blowing up with 500 errors, which is where I stopped debugging last night | 18:04 |
JayF | 500 errors! That's a lot of errors! :P | 18:05 |
JayF | I can take a look at the tests if that's what you're asking? See what's tossing the 500 error | 18:06 |
devananda | hah | 18:06 |
*** rbudden has quit IRC | 18:06 | |
devananda | JayF: up to you. just sharing where I'm at. when you have spec things for me to review / add to, LMK | 18:07 |
JayF | I'll add you to the review when I get it up | 18:07 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Gracefully degrade start_iscsi_target for Mitaka ramdisk https://review.openstack.org/319183 | 18:07 |
JayF | likely today maybe tomorrow | 18:07 |
devananda | cool | 18:07 |
JayF | honestly depends on if I update rescue spec first or write that one first | 18:07 |
*** mgould is now known as mgould|afk | 18:07 | |
JayF | given the policy spec seems like ... paperwork (the main decisions are obvious/been made) I might do the rescue first | 18:07 |
*** moshele has joined #openstack-ironic | 18:08 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Warn on legacy auth options on conductor start https://review.openstack.org/326660 | 18:08 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Update devstack plugin with new auth options https://review.openstack.org/297312 | 18:08 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Migrate to using keystoneauth Sessions https://review.openstack.org/236982 | 18:08 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Update ironic.conf.sample https://review.openstack.org/326682 | 18:08 |
*** trown|lunch is now known as trown | 18:10 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Gracefully degrade start_iscsi_target for Mitaka ramdisk https://review.openstack.org/319183 | 18:12 |
*** piet_ has joined #openstack-ironic | 18:17 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/python-ironicclient: Move OpsnStack client to test-requirements https://review.openstack.org/297730 | 18:17 |
devananda | jroll, JayF: do we really need a spec for policy? | 18:20 |
JayF | I was just wondering that myself. | 18:20 |
devananda | we *definitely* need docs on it | 18:20 |
JayF | but usually when I think that, it means writing the spec is easy anyway | 18:21 |
jroll | I think I'd like a spec listing the default policy and the endpoints, and maybe a bit about the implementation | 18:21 |
devananda | I'm pretty sure I have implemented it so that there's no immediate effect on upgrade (but I want grenade to convince me of that) | 18:21 |
devananda | but there will need to be operator actions to make the changes go into effect | 18:21 |
jroll | well, the immediate effect will almost certainly depend on the user people are using :) | 18:21 |
jroll | yeah | 18:22 |
JayF | today you have no option but to use an admin user | 18:22 |
JayF | if admin user keeps having full perms, then what's the immediate effect jroll ? | 18:22 |
jroll | JayF: yeah, I guess you're right | 18:23 |
jroll | and there's no change until the new policy.json is dropped in | 18:23 |
JayF | even with the proposed policy.json, there's no change | 18:23 |
devananda | jroll: assume that deployers may have changed policy.json | 18:24 |
devananda | *do we .. | 18:24 |
devananda | (I do) | 18:24 |
JayF | me too | 18:24 |
JayF | it's a config file, not code | 18:24 |
devananda | right | 18:24 |
JayF | which is the whole reason for the policy-in-code thing | 18:24 |
devananda | and this can very definitely be changed today: https://github.com/openstack/ironic/blob/master/etc/ironic/policy.json#L2 | 18:24 |
JayF | and if we do ours using policy-in-code (I hope we do?) even then, the default settings to be implemented would work with an existing, configured user aiui | 18:25 |
jroll | +1, make that assumption | 18:25 |
devananda | inside ironic, we enforce the "admin_api" policy | 18:25 |
devananda | but an operator could change what that means, as far as keystone roles | 18:25 |
*** amotoki has joined #openstack-ironic | 18:26 | |
devananda | this is hte main check: https://github.com/openstack/ironic/blob/master/ironic/api/hooks.py#L121 | 18:26 |
devananda | btw, this one is, as far as I can tell, actually a no-op: https://github.com/openstack/ironic/blob/master/ironic/api/hooks.py#L82 | 18:26 |
*** ametts has quit IRC | 18:27 | |
devananda | my point is, today, an operator actually could change what keystone roles pass our "is_admin" check | 18:27 |
JayF | any way you slice it this should be upgrade-safe | 18:27 |
jroll | right, agree with that | 18:27 |
devananda | such an operator would need to modify the new policy.json to match their existing roles -- and they'd know that | 18:27 |
JayF | 1) if you edited your policy.json, it stays in place and we don't break you | 18:28 |
JayF | 2) If you didn't edit the policy.json, our new policies would mean the user you're using (admin role) would keep working | 18:28 |
devananda | JayF: correct | 18:28 |
JayF | we only have to be backwards compat with configs we shipped | 18:28 |
JayF | not with arbitrary user configs, because they get to keep those | 18:28 |
devananda | I will need to change https://review.openstack.org/#/c/325599/3/etc/ironic/policy.json a bit, actually | 18:29 |
devananda | to retain compat, is_admin shouldn't check is_member | 18:29 |
devananda | well - it will pass devstack | 18:30 |
devananda | because in devstack, the admin user is a member of hte demo project | 18:30 |
*** amotoki has quit IRC | 18:30 | |
devananda | I feel like "but it works in devstack" is never a good explanation for something | 18:30 |
*** e0ne has joined #openstack-ironic | 18:32 | |
*** PollyZ has joined #openstack-ironic | 18:32 | |
JayF | lol, that's a good philosophy | 18:32 |
*** baoli_ has quit IRC | 18:32 | |
*** PollyZ has quit IRC | 18:37 | |
*** rbudden has joined #openstack-ironic | 18:40 | |
*** ametts has joined #openstack-ironic | 18:40 | |
*** Sukhdev has joined #openstack-ironic | 18:47 | |
*** PollyZ has joined #openstack-ironic | 18:47 | |
*** mbound has quit IRC | 18:51 | |
*** fragatina has joined #openstack-ironic | 18:58 | |
*** frontrunner has quit IRC | 18:58 | |
*** ChubYann has joined #openstack-ironic | 19:01 | |
*** piet_ has quit IRC | 19:02 | |
*** moshele has quit IRC | 19:03 | |
*** SiRiuS has quit IRC | 19:09 | |
devananda | jroll, JayF: as we start enforcing policy in a lot more places, wdyt of changes in errors that an unauth'd user will get back? | 19:10 |
devananda | I can try to preserve them, or I can change them | 19:10 |
JayF | that's really interesting | 19:10 |
JayF | because you can't really "hide" some of it behind a microversion | 19:10 |
NobodyCam | morning devananda :) | 19:11 |
JayF | b/c obviously you'd have to 404 any resource they weren't allowed to know if it existed (i.e. if you don't have node list, we have to return 404 for *any* node action, even if node is valid) | 19:11 |
devananda | JayF: right | 19:11 |
JayF | I can't think of any case other than that where we'd have to 404 instead of 403 a resource, so maybe that's just hte most complex edge case | 19:11 |
devananda | NobodyCam: g'morning! | 19:12 |
NobodyCam | :) | 19:12 |
JayF | Is there any case where it makes sense to have a role that wouldn't have node-list? | 19:12 |
devananda | JayF: right now, I've put the policy checks as the very first call in every location | 19:12 |
JayF | If no; then it gets a hell of a lot simpler | 19:12 |
JayF | because we don't have any other types of resources we'd have to fake a 404 for (instead of a 403) | 19:12 |
devananda | so, eg, it's happening before API version checks, API routing checks, validation of state machine, etc | 19:12 |
JayF | and I'm all for changing errors to 403s | 19:12 |
JayF | ooooooh | 19:12 |
JayF | that's gnarly | 19:12 |
devananda | which makes sense to me -- before ironic does any work, make sure the user is ALLOWED to request that work | 19:12 |
JayF | because 403 could also be pushed by something upstream | 19:12 |
JayF | like if I run ironic wsgi in Apache, I upgrade, start getting 403s | 19:13 |
devananda | don't tell them "your request is invalid while node is in state X" if they aren't even authorized to see the list of Nodes | 19:13 |
JayF | my client can't know if it's some stuff setup in apache | 19:13 |
JayF | or if Ironic is rejecting based on permissions | 19:13 |
devananda | right | 19:13 |
devananda | so yea, things get tricky | 19:13 |
JayF | *if* we eliminate the security case (i.e. where you need to 404 a resource to deny info leakage) | 19:14 |
JayF | and we could move the check behind a microversion, I think that's the golden solution | 19:14 |
devananda | uh | 19:14 |
devananda | why would we microversion policy support when our API technocally already supports it? | 19:14 |
devananda | it's just becoming more granular | 19:15 |
JayF | That's valid too. | 19:15 |
JayF | I think you change the errors, and it's fine | 19:15 |
JayF | but I know I'm highly biased toward forward motion over backwards compat | 19:15 |
*** frontrunner has joined #openstack-ironic | 19:15 | |
JayF | I'd be interested to hear what someone with a different use case woul think | 19:15 |
devananda | for instance, if an unauthenticated user requests GET /v1/chassis/CCCC/nodes/NNNN they will currently hit this code | 19:16 |
devananda | if self.from_chassis: | 19:16 |
devananda | raise exception.OperationNotPermitted() | 19:16 |
devananda | erm, edit | 19:16 |
devananda | if an *AUTHENTICATED* user ... | 19:16 |
devananda | an unauth'd user will get rejected by the TrustedCallHook much higher up the stack | 19:16 |
devananda | so to preserve that, I'm pretty sure I need to be checking policy before that if statement | 19:17 |
JayF | authenticated but unauthorized user | 19:17 |
devananda | right | 19:17 |
JayF | that still returns a 403 | 19:18 |
JayF | ooooh | 19:18 |
JayF | but maybe a 404 is the 'better' thing in some cases | 19:18 |
JayF | I think the key question is: Is there anything "secret" about acknowleding a resource exists by returning 403 vs 404 | 19:19 |
JayF | In Ironic, I suspect that answer is no, but I could be wrong | 19:19 |
JayF | I think 404'ing resources you aren't authorized to know exists is a significant enough api change to outweigh the security risk | 19:20 |
devananda | JayF: yes | 19:20 |
JayF | and almost completely undiscoverable by an unsophisticated operator | 19:20 |
devananda | JayF: with my security hat on, I would say we do not disclose whether a thing exists inthe response to a request, if the requestor has no permissions to act upon the thing | 19:21 |
devananda | like a bad login attempt -- you don't disclose the validity of the email address | 19:21 |
JayF | Yeah, but security is always a slider, right? between UX and security? In this case, I think the risk is small and the harm to UX would be significant | 19:22 |
devananda | I think we may be mincing hairs at this point | 19:22 |
JayF | yep | 19:22 |
JayF | I could easily go either way | 19:22 |
devananda | I think I can implement 403 DENIED at a level where it would happen regardless of whether the resource exists ir not | 19:22 |
JayF | that has no downsides then, does it? That sounds like the golden solution | 19:23 |
devananda | let's see if I'm right :) | 19:25 |
rloo | devananda, JayF: what do the other openstack projects do? we should be consistent? | 19:27 |
devananda | rloo: I believe the api-wg is trying to create consistency,but there isn't that today | 19:27 |
*** baoli has joined #openstack-ironic | 19:28 | |
*** MattMan has quit IRC | 19:29 | |
* JayF brb, off to lunch break | 19:30 | |
*** MattMan has joined #openstack-ironic | 19:30 | |
*** e0ne has quit IRC | 19:40 | |
*** SiRiuS__ has joined #openstack-ironic | 19:43 | |
*** morgabra_ is now known as morgabra | 19:52 | |
*** morgabra has joined #openstack-ironic | 19:52 | |
*** mbound has joined #openstack-ironic | 19:52 | |
*** jaybeale has quit IRC | 19:54 | |
*** trown is now known as trown|brb | 19:55 | |
*** Goneri has quit IRC | 19:56 | |
*** mbound has quit IRC | 19:57 | |
* jlvillal wonders if gate is broken or if he is just unlucky. Goes to read the log files | 19:58 | |
* jlvillal is unlucky | 19:58 | |
*** trown|brb is now known as trown | 19:59 | |
*** Sukhdev has quit IRC | 20:02 | |
*** clenimar has joined #openstack-ironic | 20:04 | |
jlvillal | Has anyone else seen gate failures where Apache fails to restart? I've seen two different jobs experience it over two test runs. A job failed in one run and a different job failed in the other run. But both with Apache failing to restart. | 20:06 |
TheJulia | jlvillal: as part of horizon setup? | 20:07 |
jlvillal | TheJulia: Yep | 20:08 |
jlvillal | Sample at very end of: http://logs.openstack.org/04/326504/1/gate/gate-tempest-dsvm-ironic-pxe_ipa/3680916/logs/devstacklog.txt.gz | 20:08 |
TheJulia | jlvillal: I had two jobs that failed yesterday due to that, I noticed it, searched around, saw no known bugs so kind of figured it might have been a transient fluke, and rechecked to see if it appeared in more jobs or if everything cleared up. Truthfully I bet the socket is being held open by the kernel and thus cannot be rebound until it times out | 20:10 |
jlvillal | TheJulia: Thanks. I forget the magic needed to search the failed job messages. | 20:10 |
jlvillal | I know there is some master log stash. And you can search it. I just forget how. Not sure I really have learned how. The UI was a bit confusing the last time I remember using it. | 20:11 |
*** baoli has quit IRC | 20:12 | |
TheJulia | jlvillal: http://logstash.openstack.org/#/dashboard/file/logstash.json | 20:12 |
jroll | ++ | 20:12 |
TheJulia | I've used it once in a blue moon, but yeah, you have to be very careful with what you submit to the ES cluster | 20:12 |
jroll | this is a perfect thing to file a bug for, and add to elastic-recheck | 20:12 |
TheJulia | ++ | 20:12 |
jroll | (and e-r is a good source of example queries) | 20:12 |
*** baoli has joined #openstack-ironic | 20:12 | |
TheJulia | ++ | 20:13 |
jlvillal | TheJulia: That's the UI. Maybe it is better, but last time I failed miserably trying to make it work :) | 20:13 |
jlvillal | jroll: Thanks | 20:13 |
TheJulia | jlvillal: custom queries, just remember to keep a time constraint on the queries, the longer you go out, the more on disk it has to look at, thus gets slower :) | 20:14 |
jlvillal | TheJulia: Noted. Going to clone elastic recheck and file a bug. | 20:14 |
jlvillal | https://bugs.launchpad.net/ironic/+bug/1590139 | 20:17 |
openstack | Launchpad bug 1590139 in Ironic "Gate jobs failing during Horizon setup" [Undecided,New] | 20:17 |
*** jjohnson2 has quit IRC | 20:17 | |
openstackgerrit | Merged openstack/python-oneviewclient: Adding dynamic allocation operations https://review.openstack.org/258699 | 20:17 |
*** jjohnson2 has joined #openstack-ironic | 20:17 | |
jroll | jlvillal: for e-r purposes, I'd re-name the bug to be the actual failure, rather than "this makes our jobs fail" | 20:18 |
jlvillal | jroll: Okay | 20:18 |
openstackgerrit | Andre Aranha proposed openstack/python-oneviewclient: Added functions to translate between uuid and uri https://review.openstack.org/301877 | 20:21 |
jlvillal | #openstack-meeting is now talking about the golang proposal | 20:22 |
* jlvillal grabs his soda and watches... | 20:22 | |
TheJulia | Well, make popcorn too? | 20:28 |
jlvillal | TheJulia: ;) | 20:30 |
*** jaybeale has joined #openstack-ironic | 20:37 | |
*** ayoung has quit IRC | 20:44 | |
jroll | jlvillal: did you get a logstash query going? | 20:47 |
* jroll curious how hard this is hitting | 20:47 | |
jlvillal | jroll: Not yet. Got distracted by golang meeting | 20:47 |
jlvillal | jroll: And I have to go pick my wife up from school | 20:47 |
* jlvillal is already late :( | 20:47 | |
* jlvillal and possibly going to be in trouble... | 20:48 | |
TheJulia | eek | 20:48 |
jroll | oops, gogogo | 20:48 |
TheJulia | ++ | 20:48 |
jlvillal | jroll: Thanks. I will do it when I get back, unless you or someone else does it first. | 20:48 |
jroll | jlvillal: sure, | 20:48 |
jlvillal | jroll: I liked your question about swift leaving. I didn't really see a response though :( | 20:49 |
*** frontrunner has quit IRC | 20:49 | |
jroll | nop | 20:49 |
JayF | Is there at least a bug filed? | 20:49 |
JayF | oh yep above | 20:49 |
*** nicodemos is now known as nico-afk | 20:51 | |
thiagop | jlvillal: or you if you don't survive... | 20:51 |
thiagop | :) | 20:51 |
*** baoli has quit IRC | 20:52 | |
*** baoli has joined #openstack-ironic | 20:52 | |
TheJulia | lucas-dinner: Tomorrow, if you have time, please take a look at https://bugs.launchpad.net/ironic/+bug/1590146 which I've filed. Since you put in the cleaning timeout, I'm curious to know if there was an intent behind the current behavior, and if it is intended or not, before I go trying to submit a fix. :) | 20:53 |
openstack | Launchpad bug 1590146 in Ironic "A timed out manual cleaning cannot be retried successfuly" [Undecided,New] | 20:53 |
*** dprince has quit IRC | 20:55 | |
*** baoli has quit IRC | 20:56 | |
*** baoli has joined #openstack-ironic | 20:56 | |
*** priteau has quit IRC | 20:59 | |
*** baoli has quit IRC | 21:01 | |
*** baoli has joined #openstack-ironic | 21:01 | |
*** clenimar has quit IRC | 21:02 | |
*** ayoung has joined #openstack-ironic | 21:04 | |
*** jjohnson2 has quit IRC | 21:05 | |
*** trown is now known as trown|outtypewww | 21:05 | |
*** Goneri has joined #openstack-ironic | 21:07 | |
*** r-daneel has quit IRC | 21:09 | |
*** spandhe has joined #openstack-ironic | 21:12 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Gracefully degrade start_iscsi_target for Mitaka ramdisk https://review.openstack.org/319183 | 21:12 |
*** SiRiuS__ has quit IRC | 21:19 | |
*** frontrunner has joined #openstack-ironic | 21:19 | |
*** Jabadia has quit IRC | 21:23 | |
*** priteau has joined #openstack-ironic | 21:25 | |
*** amotoki has joined #openstack-ironic | 21:27 | |
*** r-daneel has joined #openstack-ironic | 21:30 | |
*** ijw has quit IRC | 21:32 | |
*** ijw has joined #openstack-ironic | 21:32 | |
*** amotoki has quit IRC | 21:33 | |
*** ijw has quit IRC | 21:33 | |
*** thiagop has quit IRC | 21:33 | |
*** jcoufal has quit IRC | 21:34 | |
*** r-daneel has quit IRC | 21:35 | |
*** priteau has quit IRC | 21:40 | |
*** r-daneel has joined #openstack-ironic | 21:48 | |
JayF | jroll: where do you plug in queries that are candidates for e-r? | 21:49 |
JayF | jroll: I know you said there's an es somewhere, I've not used it | 21:49 |
* JayF thinks he figured it out, but apparently is doing SOMETHING wrong | 21:52 | |
jroll | JayF: logstash.o.o | 21:53 |
JayF | yeah I found it, and figured out a thing or two I was doing wrong | 21:53 |
*** ayoung has quit IRC | 21:54 | |
*** Sukhdev has joined #openstack-ironic | 21:54 | |
jroll | cool | 21:54 |
jroll | thanks for doing that, I realized after TC meeting I should stop working | 21:54 |
JayF | it's either not working or I don't know how to use it | 21:54 |
*** frontrunner has quit IRC | 21:54 | |
JayF | (message:"AH00072: make_sock: could not bind to address [::]:8088" AND message:"The apache2 instance did not start within 20 seconds. Please read the log files to discover problems") | 21:54 |
JayF | specific enough for an e-r you think? | 21:54 |
jroll | probably | 21:55 |
jroll | reviewers can tell you if not, I guess | 21:55 |
mrda | Morning Ironic | 21:55 |
jroll | hey mrda :) | 21:55 |
mrda | o/ | 21:55 |
*** Sukhdev has quit IRC | 21:57 | |
TheJulia | good morning mrda | 21:57 |
jlvillal | JayF: Glad I am not the only one who has been confused by logstash :) | 21:57 |
JayF | honestly I've been poking at it for all of 15 minutes now | 21:58 |
JayF | after I asked jim I looked, the e-r repo has a great readme | 21:58 |
JayF | and I used an existing query as a template | 21:58 |
JayF | about to push up the patchset to e-r now | 21:58 |
jroll | nice | 21:58 |
JayF | https://review.openstack.org/326739 Add e-r query for 1282876 | 21:59 |
*** ccarmack has quit IRC | 21:59 | |
JayF | jlvillal: the trickiest thing about es, is it defaults to a very short timeline, so you have to zoom out to catch most of anything | 22:01 |
devananda | JayF: no, not quite | 22:01 |
devananda | JayF: you need to specify a file name or a "tag" | 22:02 |
JayF | hmm. Do you have an example? | 22:02 |
JayF | http://logs.openstack.org/83/319183/23/check/gate-tempest-dsvm-ironic-pxe_ipa/4e3ae7a/logs/devstacklog.txt.gz#_2016-06-07_19_45_09_714 | 22:02 |
JayF | is an example of what I'm trying to catch | 22:02 |
*** sdake_ has joined #openstack-ironic | 22:03 | |
devananda | JayF: https://github.com/openstack-infra/elastic-recheck/blob/master/queries/1393099.yaml | 22:03 |
jroll | another example: https://github.com/openstack-infra/elastic-recheck/blob/master/queries/1353962.yaml | 22:04 |
jroll | (TIL) | 22:04 |
devananda | JayF: http://docs.openstack.org/infra/elastic-recheck/readme.html#queries | 22:04 |
JayF | devananda: updated, thanks for the tip | 22:04 |
devananda | np | 22:05 |
devananda | heh. in between other meetings and emails, I've made progress on policy | 22:05 |
*** Jabadia has joined #openstack-ironic | 22:05 | |
openstackgerrit | Chris Krelle proposed openstack/ironic-python-agent: Add basic troubleshooting doc https://review.openstack.org/326743 | 22:05 |
*** Sukhdev has joined #openstack-ironic | 22:05 | |
devananda | I'm now getting 283 "403" errors, rather than 500 errors | 22:05 |
*** sdake has quit IRC | 22:06 | |
JayF | that's like, 217 less errors! | 22:06 |
JayF | /s | 22:06 |
JayF | updated again | 22:06 |
JayF | apparently you're supposed to use tag:blah.txt instead of filename:blah.txt so you catch the files in grenade jobs too | 22:06 |
*** sdake has joined #openstack-ironic | 22:06 | |
*** ayoung has joined #openstack-ironic | 22:08 | |
*** sdake_ has quit IRC | 22:10 | |
*** Sukhdev has quit IRC | 22:12 | |
*** Sukhdev has joined #openstack-ironic | 22:12 | |
*** jaybeale_ has joined #openstack-ironic | 22:14 | |
*** jaybeale has quit IRC | 22:14 | |
openstackgerrit | Yosef Hoffman proposed openstack/ironic-python-agent: [WIP] Add configuration options for DISK_WAIT https://review.openstack.org/324909 | 22:15 |
*** Sukhdev has quit IRC | 22:16 | |
*** Sukhdev has joined #openstack-ironic | 22:16 | |
*** r-daneel has quit IRC | 22:17 | |
JayF | both of the api-ref docs items outstanding - https://review.openstack.org/#/c/313187/ and https://review.openstack.org/#/c/313708/ are 1x+2 and has some +1s (from me for sure) | 22:18 |
JayF | would appreciate some core reviews on them, as they are in great shape and way better than what we have now | 22:18 |
*** ijw has joined #openstack-ironic | 22:19 | |
*** PollyZ has quit IRC | 22:20 | |
*** ijw has quit IRC | 22:21 | |
*** ijw_ has joined #openstack-ironic | 22:23 | |
devananda | JayF: thinking out loud here for a minute ... | 22:25 |
devananda | we have two different config flags that pretty much do almost the same thing | 22:25 |
openstackgerrit | Chris Krelle proposed openstack/ironic-python-agent: Add basic troubleshooting doc https://review.openstack.org/326743 | 22:25 |
devananda | CONF.auth_strategy && ironic/api/config.py "enable_acl" | 22:25 |
*** PollyZ has joined #openstack-ironic | 22:26 | |
openstackgerrit | Merged openstack/ironic: Update comment from NOTE to TODO https://review.openstack.org/326504 | 22:26 |
JayF | I didn't know api/config.py was operator editable? | 22:27 |
devananda | it's not -- and yet | 22:27 |
JayF | I always read that code as that being pecan's config file written out in ironic code | 22:27 |
devananda | we have a bunch of code that keys off of whether it is True or False | 22:27 |
devananda | so clearly, someone sometime expected it to be mutable | 22:27 |
*** ijw_ has quit IRC | 22:27 | |
JayF | I don't think it's safe to assume that was explicit, but sure :) | 22:28 |
JayF | I would imagine we should change all those checks to be if CONF.auth_strategy is none (or noauth, or whatever the secret string is), right? | 22:28 |
*** ijw has joined #openstack-ironic | 22:29 | |
devananda | that's my thinking | 22:29 |
devananda | thanks for confirming :) | 22:29 |
*** amotoki has joined #openstack-ironic | 22:30 | |
JayF | and even if someone has jiggled an option in that file | 22:30 |
*** rbudden has quit IRC | 22:30 | |
JayF | IMO we have no responsiblity whatever to support them | 22:30 |
JayF | anymore than we would anyone who patched Ironic code to act differently | 22:30 |
devananda | cool | 22:30 |
*** ametts has quit IRC | 22:30 | |
*** PollyZ has quit IRC | 22:31 | |
devananda | WOOT! down to 5 errors | 22:31 |
*** amotoki has quit IRC | 22:34 | |
*** PollyZ has joined #openstack-ironic | 22:40 | |
*** sabeen has quit IRC | 22:41 | |
*** sdake has quit IRC | 22:43 | |
JayF | Anyone have any experience with fixtures.MonkeyPatch? | 22:45 |
*** PollyZ has quit IRC | 22:45 | |
JayF | I'm well down the rabbithole. e-r gate is broken and I'm trying to fix it | 22:45 |
JayF | and I'm feeling very like http://vignette1.wikia.nocookie.net/someordinarygamers/images/a/ab/I-have-no-idea-what-im-doing-science-dog.jpg | 22:45 |
jlvillal | JayF: Did you get a working logstash query? | 22:46 |
JayF | Yep. | 22:46 |
JayF | and I have it up for review, linked it in here earlier | 22:46 |
JayF | but unit tests for it are failing because e-r is broken | 22:46 |
JayF | given I can't barely get a review from infra because they are busy, I was trying to fix unit tests | 22:46 |
jlvillal | I mean one that I can see on logstash.o.o? | 22:46 |
JayF | and am now stuck, squarely at the bottom of the rabbithole | 22:46 |
JayF | I mean, you can look at my review and input it? | 22:47 |
openstackgerrit | Devananda van der Veen proposed openstack/ironic: [WIP] Add keystone policy support to Ironic https://review.openstack.org/325599 | 22:47 |
jlvillal | Okay. I tried and I got zero results. | 22:47 |
JayF | I didn't make a direct link, not sure you can... well, more accurately, idk how I'd do it | 22:47 |
JayF | haha | 22:47 |
jlvillal | Well I did two of the three | 22:47 |
JayF | you have to zoom out | 22:47 |
JayF | and be very, very patient | 22:47 |
jlvillal | message:"AH00072: make_sock: could not bind to address [::]:8088" AND tag:"devstacklog.txt.gz" | 22:47 |
JayF | and paste the *whole thing in* as one filter | 22:47 |
jlvillal | JayF: Trying: message:"AH00072: make_sock: could not bind to address [::]:8088" AND tag:"devstacklog.txt.gz" AND message:"The apache2 instance did not start within 20 seconds. Please read the log files to discover problems" | 22:48 |
jlvillal | And have it set for 1week, I believe | 22:48 |
jlvillal | And it seemed to stop with zero results. | 22:48 |
jlvillal | So /me is confused | 22:48 |
devananda | JayF: that ^ is passing unit tests locally :-D | 22:49 |
devananda | JayF: so I succeeded in not breaking the error codes for unauth'd users | 22:49 |
JayF | \o/ | 22:49 |
JayF | jlvillal: I can't reproduce it now either | 22:51 |
* JayF flips table | 22:51 | |
jlvillal | whew! | 22:51 |
JayF | screw this bug, I'm going to go do something else | 22:51 |
* jlvillal was feeling like an idiot over here | 22:51 | |
* devananda feels accomplished with the policy work and goes afk for a bit | 22:52 | |
* jlvillal also remembers why he thought the logstash UI sucked before and continues to think it is non-intuitive. Apologies to logstash developers reading this ;) | 22:52 | |
devananda | shameless self promotion for API documentation - https://review.openstack.org/#/c/313187/9 needs another +2 | 22:53 |
*** PollyZ has joined #openstack-ironic | 22:53 | |
devananda | ditto for https://review.openstack.org/#/c/313708/7 | 22:53 |
*** frontrunner has joined #openstack-ironic | 22:55 | |
JayF | I already shilled them too, I +1'd 'em earlier | 22:55 |
jlvillal | devananda: I'm thinking dumb question. But I click the generated docs link. And I see API. And assume I click the only thing which says API, would be the content. But it doesn't appear to be. So now I wonder, where is it buried in the docs? | 22:57 |
* jlvillal feels dumb again... | 22:57 | |
*** PollyZ has quit IRC | 22:58 | |
jlvillal | Looking at: http://docs-draft.openstack.org/87/313187/9/check/gate-ironic-docs/724c5a2//doc/build/html/ | 22:59 |
*** Goneri has quit IRC | 23:02 | |
TheJulia | devananda: they are on my screen :) | 23:02 |
*** absubram has quit IRC | 23:04 | |
*** Sukhdev has quit IRC | 23:05 | |
*** Sukhdev has joined #openstack-ironic | 23:05 | |
*** baoli has quit IRC | 23:07 | |
*** Sukhdev has quit IRC | 23:09 | |
*** sdake has joined #openstack-ironic | 23:12 | |
TheJulia | devananda: is the removal of error response codes intended? | 23:14 |
*** sacharya_ has joined #openstack-ironic | 23:15 | |
*** sacharya has quit IRC | 23:15 | |
*** Sukhdev has joined #openstack-ironic | 23:19 | |
*** PollyZ has joined #openstack-ironic | 23:20 | |
*** ijw has quit IRC | 23:21 | |
devananda | jlvillal: look at the api-ref job output | 23:21 |
devananda | jlvillal: that renders the api-ref pages, which is where these changes end up, as opposed to the docs.os.o/dev/ site | 23:21 |
jlvillal | devananda: Ah, see I knew I was doing something dumb. | 23:22 |
devananda | TheJulia: yea. because they were bogus and I haven't vetted what the real ones are | 23:22 |
TheJulia | 10-4 | 23:22 |
jlvillal | devananda: Thanks! | 23:22 |
devananda | jlvillal: TY! | 23:22 |
*** ijw has joined #openstack-ironic | 23:22 | |
devananda | I've been trying to land these doc updates for a month now :p | 23:22 |
jlvillal | Oh pretty :) | 23:22 |
devananda | jlvillal: isn't it?! | 23:22 |
jlvillal | :) | 23:22 |
TheJulia | very pretty | 23:22 |
*** PollyZ has quit IRC | 23:25 | |
*** sacharya_ has quit IRC | 23:25 | |
*** Sukhdev has quit IRC | 23:30 | |
*** amotoki has joined #openstack-ironic | 23:30 | |
*** Sukhdev has joined #openstack-ironic | 23:32 | |
*** ppiela has joined #openstack-ironic | 23:33 | |
*** PollyZ has joined #openstack-ironic | 23:34 | |
*** amotoki has quit IRC | 23:35 | |
*** Jabadia has quit IRC | 23:35 | |
*** rbrud has joined #openstack-ironic | 23:36 | |
*** PollyZ has quit IRC | 23:38 | |
*** Sukhdev has quit IRC | 23:40 | |
*** Sukhdev has joined #openstack-ironic | 23:40 | |
*** garthb_ has quit IRC | 23:44 | |
*** sdake has quit IRC | 23:46 | |
*** ChrisAusten has quit IRC | 23:46 | |
*** PollyZ has joined #openstack-ironic | 23:48 | |
*** clenimar has joined #openstack-ironic | 23:49 | |
*** PollyZ has quit IRC | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!