*** sdake has joined #openstack-ironic | 00:08 | |
*** thrash is now known as thrash|g0ne | 00:10 | |
*** jaybeale has joined #openstack-ironic | 00:16 | |
*** sabeen has quit IRC | 00:16 | |
*** gfhellma has quit IRC | 00:19 | |
openstackgerrit | Devananda van der Veen proposed openstack/ironic-specs: Add "Ramdisk impact" section to spec template https://review.openstack.org/320125 | 00:28 |
---|---|---|
*** yibo has joined #openstack-ironic | 00:30 | |
*** penick has joined #openstack-ironic | 00:31 | |
*** david-lyle has quit IRC | 00:42 | |
*** hoangcx has joined #openstack-ironic | 00:43 | |
devananda | rloo: vdrok: responded on that patch. | 00:45 |
rloo | thx devananda! or should I thank you *after* I read your response ;) | 00:46 |
devananda | hehe | 00:46 |
devananda | it's short ;) | 00:46 |
rloo | devananda: read it. good with me. the only thing I'm not sure, is that I think it is used for the cleaning port and provisioning port. i was thinking of it as the vif id of whatever was being used by ironic at the moment. but let's see what vdrok says. | 00:48 |
devananda | rloo: ooh. huh. | 00:49 |
*** sdake has quit IRC | 00:49 | |
devananda | well, we need to cache the vif port id that nova created somewhere _else_, which I think is currently extra.vif_port_id | 00:49 |
rloo | devananda: i think the point is we aren't going to cache the vif port id that nova created -- that's the tenant one, right? we leave that in extra.vif_port_id. | 00:50 |
devananda | ironic still needs to cache the vif id from the tenant network | 00:50 |
rloo | devananda: the 'original' patch was caching extra['vif_port_id'] in extra['tenant_vif_port_id']: https://review.openstack.org/#/c/285852/ | 00:51 |
devananda | AIUI, ironic still needs to bind the instance to it later (when provisioning is done) and unbind (before cleaning starts) | 00:51 |
* devananda looks | 00:52 | |
*** Sukhdev has joined #openstack-ironic | 00:53 | |
rloo | devananda: vdrok is going to change 285852, to use this new internal_info thing instead of extra['tenant_vif_port_id'] (by not modifying extra['vif_port_id'] I think. | 00:53 |
rloo | devananda: but we can wait til tomorrow to hear from vdrok. I'm going to call it a day. thx! | 00:54 |
*** rloo has quit IRC | 00:54 | |
devananda | sounds good. I'm not quite following this 285852 patch yet ... | 00:56 |
* devananda calls it a day and goes in search of food | 00:56 | |
*** rook has quit IRC | 01:03 | |
*** rama_y has quit IRC | 01:05 | |
openstackgerrit | Yuiko Takada Mori proposed openstack/ironic: Remove iterated form of side effects https://review.openstack.org/338002 | 01:07 |
*** yibo has quit IRC | 01:15 | |
*** yibo has joined #openstack-ironic | 01:15 | |
*** ChrisAusten has joined #openstack-ironic | 01:27 | |
*** priteau has joined #openstack-ironic | 01:28 | |
*** Sukhdev has quit IRC | 01:30 | |
*** yuikotakadamori has joined #openstack-ironic | 01:31 | |
*** priteau has quit IRC | 01:33 | |
*** mtanino has joined #openstack-ironic | 01:33 | |
*** yuikotakadamori has quit IRC | 01:35 | |
*** yuikotakadamori has joined #openstack-ironic | 01:36 | |
*** rook has joined #openstack-ironic | 01:44 | |
*** sdake has joined #openstack-ironic | 01:50 | |
*** ChrisAusten has quit IRC | 01:55 | |
*** ChrisAusten has joined #openstack-ironic | 01:57 | |
*** joprovost has joined #openstack-ironic | 02:02 | |
*** joprovost1 has joined #openstack-ironic | 02:09 | |
*** joprovost has quit IRC | 02:10 | |
*** joprovost1 is now known as joprovost | 02:10 | |
openstackgerrit | Dao Cong Tien proposed openstack/ironic: Nova-compatible serial console: socat console_utils https://review.openstack.org/328168 | 02:20 |
openstackgerrit | Dao Cong Tien proposed openstack/ironic: Nova-compatible serial console: socat console_utils https://review.openstack.org/328168 | 02:25 |
*** jaybeale has quit IRC | 02:28 | |
*** kun_huang has joined #openstack-ironic | 02:30 | |
*** ChrisAusten has quit IRC | 02:39 | |
*** ChrisAusten has joined #openstack-ironic | 02:40 | |
*** PollyZ has joined #openstack-ironic | 02:43 | |
openstackgerrit | Yuiko Takada Mori proposed openstack/ironic: Follow-up patch of cbe51c6a10d1fa68c7082af67827d8c0d8967fe3 https://review.openstack.org/338658 | 02:49 |
*** baoli has joined #openstack-ironic | 02:54 | |
*** rook has quit IRC | 02:54 | |
*** baoli_ has joined #openstack-ironic | 02:56 | |
openstackgerrit | Yuiko Takada Mori proposed openstack/ironic: Mock global variables https://review.openstack.org/338665 | 02:57 |
*** Nakato has quit IRC | 02:57 | |
*** baoli has quit IRC | 02:59 | |
*** Nakato has joined #openstack-ironic | 03:03 | |
yuikotakadamori | rloo, jroll, could you please review https://review.openstack.org/#/c/328168/ and https://review.openstack.org/#/c/293873/ Nova patch cannot be merged without merging 2 these Ironic patches. | 03:03 |
*** joprovost has quit IRC | 03:11 | |
*** vishwanathj has joined #openstack-ironic | 03:20 | |
*** MattMan has quit IRC | 03:42 | |
*** MattMan has joined #openstack-ironic | 03:42 | |
*** sdake has quit IRC | 03:48 | |
*** PollyZ has quit IRC | 03:52 | |
*** rajinir has quit IRC | 03:54 | |
*** mtanino has quit IRC | 03:57 | |
*** links has joined #openstack-ironic | 04:03 | |
*** yuikotak_ has joined #openstack-ironic | 04:10 | |
*** yuikotakadamori has quit IRC | 04:11 | |
*** harlowja_at_home has joined #openstack-ironic | 04:12 | |
*** Goneri has quit IRC | 04:20 | |
*** Goneri has joined #openstack-ironic | 04:21 | |
*** harlowja_at_home has quit IRC | 04:22 | |
*** skramaja has joined #openstack-ironic | 04:31 | |
*** sdake has joined #openstack-ironic | 04:32 | |
*** baoli_ has quit IRC | 04:40 | |
*** Sukhdev has joined #openstack-ironic | 04:49 | |
openstackgerrit | Yuiko Takada Mori proposed openstack/ironic: Follow-up patch of cbe51c6a10d1fa68c7082af67827d8c0d8967fe3 https://review.openstack.org/338658 | 04:51 |
*** sdake has quit IRC | 04:51 | |
*** yuikotak_ has quit IRC | 04:51 | |
*** sdake has joined #openstack-ironic | 04:55 | |
*** sabeen has joined #openstack-ironic | 04:55 | |
*** jaybeale has joined #openstack-ironic | 04:59 | |
*** bharathk has joined #openstack-ironic | 05:23 | |
*** sdake has quit IRC | 05:26 | |
*** jaybeale has quit IRC | 05:30 | |
*** sabeen has quit IRC | 05:31 | |
*** M00nr41n has joined #openstack-ironic | 05:37 | |
*** ChubYann has quit IRC | 05:37 | |
*** mjura has joined #openstack-ironic | 05:59 | |
*** rbartal has joined #openstack-ironic | 06:00 | |
openstackgerrit | zhufl proposed openstack/ironic: Remove unused LOG https://review.openstack.org/338706 | 06:00 |
*** jaybeale has joined #openstack-ironic | 06:06 | |
*** jaybeale has quit IRC | 06:06 | |
*** mjura has quit IRC | 06:07 | |
*** sdake has joined #openstack-ironic | 06:10 | |
openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Centralize config options - [glance] https://review.openstack.org/304829 | 06:10 |
*** fragatina has quit IRC | 06:10 | |
*** fragatina has joined #openstack-ironic | 06:11 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Add IRONIC_TEST_NETWORK_NAME variable https://review.openstack.org/338116 | 06:11 |
*** Sukhdev has quit IRC | 06:14 | |
openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Centralize config options - [neutron] https://review.openstack.org/304838 | 06:14 |
*** edand has joined #openstack-ironic | 06:16 | |
*** rcernin has joined #openstack-ironic | 06:18 | |
*** sdake has quit IRC | 06:19 | |
*** sdake has joined #openstack-ironic | 06:20 | |
*** mjura has joined #openstack-ironic | 06:20 | |
openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Centralize config options - [DEFAULT] https://review.openstack.org/309070 | 06:24 |
*** sdake has quit IRC | 06:29 | |
*** sdake has joined #openstack-ironic | 06:39 | |
*** dtantsur has joined #openstack-ironic | 06:41 | |
dtantsur | Morning Ironic! My IRC proxy has died over the holidays, so please repeat all pings you could make :) | 06:42 |
openstackgerrit | lokesh s proposed openstack/ironic: Add support for the audit middleware https://review.openstack.org/272658 | 06:55 |
*** sdake has quit IRC | 06:55 | |
openstackgerrit | lokesh s proposed openstack/ironic: Add support for the audit middleware https://review.openstack.org/272658 | 06:57 |
*** tesseract- has joined #openstack-ironic | 07:03 | |
*** priteau has joined #openstack-ironic | 07:12 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Add IRONIC_TEST_NETWORK_NAME variable https://review.openstack.org/338116 | 07:13 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Make Ironic variables visible inside exercise.sh https://review.openstack.org/338727 | 07:13 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Make Ironic variables visible inside exercise.sh https://review.openstack.org/338727 | 07:13 |
*** ChrisAusten has quit IRC | 07:13 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Add IRONIC_TEST_NETWORK_NAME variable https://review.openstack.org/338116 | 07:13 |
pas-ha | morning Ironic | 07:14 |
dtantsur | morning pas-ha, vsaienk0 | 07:15 |
vsaienk0 | morning dtantsur, pas-ha and all Ironic'ers | 07:15 |
*** ifarkas has joined #openstack-ironic | 07:15 | |
openstackgerrit | Tan Lin proposed openstack/ironic: Add a doc about appending kernel parameters to boot instances https://review.openstack.org/320848 | 07:17 |
*** itamarl has joined #openstack-ironic | 07:19 | |
*** makowals has joined #openstack-ironic | 07:22 | |
*** dtantsur is now known as dtantsur|bbl | 07:30 | |
*** priteau has quit IRC | 07:33 | |
*** watanabe_isao has joined #openstack-ironic | 07:36 | |
gbraad | dtantsur|bbl: see you at the OpenStack Day(s) China ;-) | 07:45 |
openstackgerrit | Aparna proposed openstack/ironic: Documentation change for in-band cleaning https://review.openstack.org/338744 | 07:47 |
*** Haomeng|2 has quit IRC | 07:47 | |
*** makowals has quit IRC | 07:55 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-ironic | 08:00 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Introduce IRONIC_TEST_NETWORK_NAME variable https://review.openstack.org/338117 | 08:01 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: DO NOT REVIEW https://review.openstack.org/334420 | 08:01 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Introduce IRONIC_TEST_NETWORK_NAME variable https://review.openstack.org/338117 | 08:04 |
*** jrist has quit IRC | 08:07 | |
*** electrofelix has joined #openstack-ironic | 08:08 | |
*** fragatina has quit IRC | 08:09 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 08:10 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: DO NOT REVIEW https://review.openstack.org/334420 | 08:10 |
*** Romanenko_K has joined #openstack-ironic | 08:11 | |
*** openstackgerrit has quit IRC | 08:18 | |
*** openstackgerrit has joined #openstack-ironic | 08:19 | |
lucasagomes | morning all | 08:19 |
*** derekh has joined #openstack-ironic | 08:19 | |
dtantsur|bbl | gbraad, I can't go actually, sorry :( I'm not sure why they put me there, I have visa problems | 08:23 |
dtantsur|bbl | morning lucasagomes | 08:23 |
lucasagomes | hah openstack day china ? | 08:28 |
lucasagomes | dtantsur|bbl, you should go :-) | 08:28 |
lucasagomes | must be fun | 08:28 |
*** pcaruana has joined #openstack-ironic | 08:30 | |
*** sambetts|afk is now known as sambetts | 08:38 | |
sambetts | Morning all | 08:38 |
*** livelace has joined #openstack-ironic | 08:39 | |
*** athomas has joined #openstack-ironic | 08:40 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Extend root device hints to support "rotational" https://review.openstack.org/338245 | 08:41 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Small refactor root device loop matching logic https://review.openstack.org/338763 | 08:41 |
alineb | morning all | 08:41 |
lucasagomes | dtantsur|bbl, ^ follows ur suggestion, also refactors size which was also outside that main loop | 08:41 |
lucasagomes | alineb, sambetts morning | 08:41 |
sambetts | o/ lucasagomes | 08:42 |
alineb | hey lucasagomes | 08:43 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Small refactor in the root device loop matching logic https://review.openstack.org/338763 | 08:44 |
mgould | morning Ironic! | 08:50 |
mgould | morning dtantsur|bbl lucasagomes sambetts alineb | 08:50 |
mgould | also morning vsaienk0 pas-ha gbraad | 08:51 |
lucasagomes | mgould, hi there | 08:52 |
*** jpich has joined #openstack-ironic | 08:53 | |
alineb | o/ mgould | 08:54 |
openstackgerrit | Imre Farkas proposed openstack/ironic: DRAC RAID configuration https://review.openstack.org/176319 | 08:55 |
ifarkas | morning all | 08:58 |
aarefiev | morning! | 08:58 |
*** rbartal_ has joined #openstack-ironic | 08:59 | |
mgould | hi ifarkas aarefiev | 08:59 |
aarefiev | morning mgould | 08:59 |
*** jrist has joined #openstack-ironic | 09:00 | |
*** jrist has quit IRC | 09:00 | |
*** jrist has joined #openstack-ironic | 09:00 | |
*** rbartal has quit IRC | 09:02 | |
openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: [WIP]Fix unit tests https://review.openstack.org/338777 | 09:06 |
*** ifarkas has quit IRC | 09:13 | |
*** fragatina has joined #openstack-ironic | 09:22 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Support to validate iLO SSL certificate in iLO drivers https://review.openstack.org/338791 | 09:23 |
*** watanabe_isao has quit IRC | 09:29 | |
*** ifarkas has joined #openstack-ironic | 09:31 | |
openstackgerrit | yuyafei proposed openstack/ironic-lib: Correct reraising of exception https://review.openstack.org/338797 | 09:31 |
openstackgerrit | yuyafei proposed openstack/ironic-lib: Correct reraising of exception https://review.openstack.org/338797 | 09:33 |
gbraad | dtantsur|bbl: very unfortunate. anyways, you are always welcome here in China... | 09:34 |
*** ifarkas has quit IRC | 09:41 | |
* mgould once got a Chinese tourist visa, but didn't get to go in the end | 09:46 | |
*** ifarkas has joined #openstack-ironic | 09:46 | |
mgould | I remember the process being quite involved | 09:46 |
mgould | easier than getting a Russian visa, though :-) | 09:46 |
vdrok | good morning ironic! | 09:58 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Extend root device hints to support "rotational" https://review.openstack.org/338245 | 09:59 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Small refactor in the root device loop matching logic https://review.openstack.org/338763 | 09:59 |
openstackgerrit | Aline Bousquet proposed openstack/ironic: Metric chassis, driver, node, and port API calls https://review.openstack.org/301923 | 10:02 |
*** dtantsur|bbl is now known as dtantsur | 10:02 | |
*** appu103_ has joined #openstack-ironic | 10:02 | |
*** appu103_ is now known as aparnav | 10:02 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Add and document the "rotational" root device hint https://review.openstack.org/338264 | 10:02 |
dtantsur | morning mgould, vdrok, aarefiev, ifarkas, alineb | 10:03 |
dtantsur | gbraad, thanks! | 10:03 |
mgould | morning vdrok | 10:03 |
aarefiev | hey dtantsur, how's your weekend? | 10:04 |
vdrok | morning dtantsur mgould lucasagomes ifarkas alineb sambetts and gbraad :) | 10:04 |
lucasagomes | vdrok, hi there | 10:04 |
alineb | o/ dtantsur, vdrok | 10:06 |
dtantsur | aarefiev, pretty good :) I didn't go anywhere, just relaxed at home and finished some errands | 10:06 |
*** daemontool has joined #openstack-ironic | 10:07 | |
*** fragatina has quit IRC | 10:07 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Make Ironic variables visible inside exercise.sh https://review.openstack.org/338727 | 10:08 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Add IRONIC_TEST_NETWORK_NAME variable https://review.openstack.org/338116 | 10:08 |
aarefiev | dtantsur: nice, sometimes rest at home is best rest :) | 10:09 |
dtantsur | very true | 10:09 |
*** hoangcx has quit IRC | 10:09 | |
openstackgerrit | Sam Betts proposed openstack/ironic-specs: Add spec for interface attach and detach API https://review.openstack.org/317636 | 10:13 |
openstackgerrit | Aparna proposed openstack/ironic: Documentation change on RAID https://review.openstack.org/338844 | 10:14 |
*** rbartal_ has quit IRC | 10:16 | |
openstackgerrit | Aparna proposed openstack/ironic: Documentation change on RAID https://review.openstack.org/338844 | 10:22 |
*** fragatina has joined #openstack-ironic | 10:27 | |
*** rbartal_ has joined #openstack-ironic | 10:28 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add internal_info field to ports and portgroups https://review.openstack.org/338417 | 10:30 |
*** marios is now known as marios|brb | 10:37 | |
openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: [WIP]Fix unit tests https://review.openstack.org/338777 | 10:40 |
lucasagomes | dtantsur, https://review.openstack.org/#/c/327891/ seems to make inspector to fall into an emergency shell when booting | 10:43 |
lucasagomes | (according to the gate-ironic-inspector-dsvm-ipa-src-nv job) | 10:43 |
dtantsur | oooops | 10:43 |
dtantsur | what is it doing so wrong, I wonder? | 10:44 |
lucasagomes | I haven't dig into it, wondering if you have any idea | 10:44 |
lucasagomes | don't know, it's not very clear from the console nodes | 10:44 |
*** fragatina has quit IRC | 10:44 | |
lucasagomes | "Specified switch root path /sysroot does not seem to be an OS tree. os-release file is missing." | 10:45 |
* lucasagomes googles | 10:45 | |
*** hoangcx has joined #openstack-ironic | 10:46 | |
yibo | vdrok, would you help review https://review.openstack.org/#/c/322632? thanks. | 10:47 |
*** moshele has joined #openstack-ironic | 10:48 | |
sambetts | lucasagomes: I've seen that issue before with CoreOS and my hardware, the only solution I came up with was creating TinyIPA | 10:52 |
*** athomas has quit IRC | 10:52 | |
dtantsur | yeah, we probably need to switch our gate to tinyipa | 10:53 |
lucasagomes | sambetts, stange, cause the new coreos image seems to be booting fine as part of the Ironic tests | 10:53 |
dtantsur | I suspect we hardcode building the cores ramdisk somewhere in our devstack plugin | 10:53 |
vdrok | yibo: hey, yep, sorry, I forgot to review it last time you asked :( will try to do today | 10:53 |
lucasagomes | something in inspector, I suspect that it's some kernel cmdline | 10:53 |
lucasagomes | config in general | 10:53 |
dtantsur | well, we don't do anything fancy to my best knowledge | 10:53 |
dtantsur | what's the exact failure? | 10:54 |
lucasagomes | yeah, exactly that's why I'm confused | 10:54 |
lucasagomes | dtantsur, http://logs.openstack.org/91/327891/8/check/gate-ironic-inspector-dsvm-ipa-src-nv/ea48918/logs/ironic-bm-logs/node-0_console.txt.gz | 10:54 |
lucasagomes | Specified switch root path /sysroot does not seem to be an OS tree. os-release file is missing. | 10:54 |
sambetts | lucasagomes: not sure :/ I saw it when using the old CoreOS image to provision on certain versions of my hardware, some it worked fine others saw that error | 10:54 |
dtantsur | memory too low? no idea.. | 10:55 |
sambetts | lucasagomes, dtantsur: we did bump the RAM for the Ironic gate | 10:55 |
sambetts | I think we did anyway :/ | 10:56 |
dtantsur | sambetts, maybe nobody did it for inspector? | 10:56 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: [devstack] Do not hardcode coreos ramdisk when building from source https://review.openstack.org/338867 | 10:56 |
dtantsur | sambetts, ^^^ | 10:56 |
sambetts | dtantsur: awesome :D | 10:57 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent: [DO NOT MERGE] Testing inspector gate https://review.openstack.org/338870 | 10:58 |
sambetts | lucasagomes, dtantsur: https://review.openstack.org/#/c/336278/ | 10:58 |
*** athomas has joined #openstack-ironic | 10:58 | |
sambetts | I guess we need to do that ^ for the inspector jobs | 10:58 |
dtantsur | yep | 10:59 |
lucasagomes | yeah seems so | 10:59 |
lucasagomes | looking at the console logs it seems to have less memory in inspector indeed | 10:59 |
lucasagomes | [ 0.000000] Memory: 666372K/1048176K available | 10:59 |
lucasagomes | [ 0.000000] Memory: 924424K/1310320K available | 10:59 |
lucasagomes | first one is inspector | 10:59 |
dtantsur | sambetts, well, actually we just switch to tinyipa by default with my patch above, so it might be not needed | 11:00 |
dtantsur | sambetts, we should probably have a separate coreos job though | 11:01 |
sambetts | dtantsur: yeah we should probably have a job for each ramdisk coreos tinyipa and DIB the same as Ironic does | 11:01 |
*** hkominos has quit IRC | 11:03 | |
*** hkominos has joined #openstack-ironic | 11:03 | |
* mgould thought we'd already switched to tinyipa and *reduced* the RAM requirement - was that for something else? | 11:05 | |
sambetts | mgould: we have for Ironic itself, but the Inspector we don't use the same macro in project-config so we don't pick up those changes automatically | 11:05 |
lucasagomes | mgould, the IPA gate still testing both ramdisks | 11:06 |
lucasagomes | tinyipa and coreos | 11:06 |
dtantsur | not for inspector | 11:07 |
*** marios|brb is now known as marios | 11:09 | |
* mgould nods - thanks! | 11:11 | |
*** m3m0 has quit IRC | 11:15 | |
jroll | morning y'all | 11:16 |
mgould | morning jroll | 11:16 |
sambetts | Morning jroll | 11:16 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add tests for maintenance mode commands https://review.openstack.org/337259 | 11:19 |
mat128 | morning jroll, mgould and sambetts | 11:19 |
mgould | morning mat128 | 11:19 |
*** moshele has quit IRC | 11:20 | |
mat128 | dtantsur and lucasagomes: the bump to 1280M landed yesterday in project-config, but so far the CoreOS image is still on the old version which should pass | 11:20 |
lucasagomes | mat128, right, but that gate is testing building it from source | 11:21 |
lucasagomes | so it will use the new one | 11:21 |
dtantsur | mat128, the bump was not applied to inspector gates | 11:21 |
lucasagomes | and that ^ | 11:21 |
lucasagomes | mat128, and morning :D | 11:21 |
mat128 | yeah based on your comments, i figured :( | 11:21 |
mat128 | morning :) | 11:21 |
lucasagomes | jroll, morning to you too | 11:21 |
sambetts | mat128: its this patch we're seeing the failure in https://review.openstack.org/#/c/327891/ | 11:22 |
sambetts | mat128: we're not broken yet ;) but would be once this merges | 11:22 |
mat128 | ah you guys are investigating failures in proposed changes :) | 11:22 |
mat128 | yes | 11:22 |
mat128 | I was on it yesterday very late but didnt have much time to give it | 11:23 |
mat128 | glad you guys looked at it this morning | 11:23 |
sambetts | :) | 11:23 |
mat128 | didnt know we had 1024M hardcoded twice :( | 11:23 |
mat128 | Won't https://review.openstack.org/#/c/338867/ make it not use CoreOS tho? | 11:23 |
sambetts | mat128: yeah, it'll use which ever is configured as the default, but we've dicussed adding inspector jobs for all the ramdisk types | 11:24 |
mat128 | so commit message is not right in that case | 11:24 |
mat128 | let me find where that second 1024M is | 11:24 |
sambetts | yeah its because we don't use the same macro for the inspector jobs | 11:25 |
*** PollyZ has joined #openstack-ironic | 11:26 | |
*** ayoung has quit IRC | 11:27 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Add IRONIC_TEST_NETWORK_NAME variable https://review.openstack.org/338116 | 11:29 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Use IRONIC_TEST_NETWORK_NAME to boot instance. https://review.openstack.org/338116 | 11:31 |
*** dprince has joined #openstack-ironic | 11:32 | |
mat128 | sambetts, lucasagomes: https://review.openstack.org/#/c/338892/ | 11:33 |
mat128 | for now, doesnt prevent us from running gates with all disk images or refactoring it to use the same macro or something else | 11:33 |
sambetts | yeah, it probably should have an if ramdisk == blah conditional the same as the Ironic macro | 11:34 |
openstackgerrit | Aparna proposed openstack/proliantutils: Modify error message of InvalidInputExecption in hpssa https://review.openstack.org/338894 | 11:34 |
mat128 | sambetts: I wanted the smallest change for this to work | 11:35 |
mat128 | I agree we can (and should) improve this | 11:35 |
sambetts | mat128: yeah, tbh I want to sit down and refactor all the Ironic jobs anyway because every time we need to add a new feature switch we change the macro and then have to update every single job even the ones without that featyre | 11:36 |
sambetts | mat128: I should include the inspecotor ones at the same time | 11:36 |
mat128 | good idea | 11:36 |
mat128 | I always wondered why some of those things defined in the macro aren't in our plugin | 11:36 |
mat128 | like, if we get passed the ramdisk type, we can define the value in ironic | 11:37 |
mat128 | leading to less changes in project-config | 11:37 |
mat128 | sambetts: got a draft of this refactor? | 11:39 |
*** ayoung has joined #openstack-ironic | 11:39 | |
sambetts | mat128: not yet, I hope to get one up before the end of the week though | 11:40 |
*** ifarkas has quit IRC | 11:40 | |
*** dprince has quit IRC | 11:44 | |
PollyZ | I have a question about this bugI have a question about this bug https://bugs.launchpad.net/ironic/+bug/1584718 do we still want to have the parameters default__version and latest__version. Code is here https://github.com/openstack/ironic/blob/master/ironic/api/controllers/base.py | 11:45 |
openstack | Launchpad bug 1584718 in Ironic Inspector "Use the new microversion-parse library to parse the version headers" [Low,Triaged] - Assigned to Polly Zhou (polly-zhou) | 11:45 |
*** dprince has joined #openstack-ironic | 11:45 | |
*** ayoung has quit IRC | 11:48 | |
dtantsur | PollyZ, sorry for not answering your email - just came from PTO | 11:49 |
*** dprince has quit IRC | 11:49 | |
dtantsur | PollyZ, we need to parse the same headers as before, just via the new library. our service_type is "baremetal" | 11:49 |
PollyZ | dtantsur: I am sorry, I didn't know you were on PTO | 11:51 |
dtantsur | no problem :) | 11:51 |
*** bharathk has quit IRC | 11:51 | |
*** dprince has joined #openstack-ironic | 11:52 | |
vdrok | morning jroll and mat128 | 11:53 |
mat128 | o/ vdrok | 11:53 |
mat128 | mgould: added partial-bug to the commit message on https://review.openstack.org/#/c/338892/ | 11:54 |
*** thrash|g0ne is now known as thrash | 11:55 | |
*** ifarkas has joined #openstack-ironic | 11:56 | |
*** yuikotakadamori has joined #openstack-ironic | 11:57 | |
*** rook has joined #openstack-ironic | 11:58 | |
PollyZ | dtantsur: Thx, and there is bug in the ironic-inspector but I couldn't figure it out, could you help me with it | 11:59 |
dtantsur | sure | 12:01 |
*** rbartal_ has quit IRC | 12:01 | |
openstackgerrit | Miles Gould proposed openstack/ironic: Fix two types in ironic.conf.sample https://review.openstack.org/338919 | 12:03 |
PollyZ | if I have multiple lines, where should I paste it | 12:03 |
*** cdearborn has joined #openstack-ironic | 12:05 | |
jroll | PollyZ: gist.github.com or paste.openstack.org are good | 12:06 |
*** maurosr has quit IRC | 12:06 | |
PollyZ | thanks jroll | 12:06 |
* jroll be back in a while, bike ride time | 12:06 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add test for 'baremetal port create' command https://review.openstack.org/332880 | 12:08 |
PollyZ | https://gist.github.com/polly1994/ffcb3a93792e9a212beffa8ae852a615 | 12:08 |
openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Fix unit tests https://review.openstack.org/338777 | 12:08 |
*** ccamacho is now known as ccamacho|lunch | 12:08 | |
*** maurosr has joined #openstack-ironic | 12:09 | |
lucasagomes | mat128, cool, thanks | 12:09 |
dtantsur | PollyZ, I can't help much by looking at the gist alone - I don't know what you've changed to get there. I suggest you propose the patch and we can inspector both the change and the CI failure | 12:09 |
*** trown|outtypewww is now known as trown | 12:09 | |
*** hoangcx has quit IRC | 12:11 | |
*** rbudden has joined #openstack-ironic | 12:12 | |
dtantsur | lucasagomes, http://logs.openstack.org/70/338870/1/check/gate-ironic-inspector-dsvm-ipa-src-nv/c6bbae0/logs/ironic-bm-logs/node-0_console_07-07-2016-11:31:13.txt.gz#_2016-07-07_11_31_10_324 | 12:14 |
dtantsur | not a blocker for anything, but is worth fixing | 12:14 |
*** baoli has joined #openstack-ironic | 12:14 | |
PollyZ | dtantsur: Sure, thx, and for the commit message, I will put partial-bug xxx, right | 12:14 |
lucasagomes | dtantsur, ew, thanks will put a patch up | 12:15 |
lucasagomes | is it tinyipa? | 12:15 |
dtantsur | yep | 12:15 |
*** baoli_ has joined #openstack-ironic | 12:15 | |
lucasagomes | dtantsur, right on, lemme fix it | 12:15 |
dtantsur | sambetts, aarefiev, https://review.openstack.org/#/c/338867/ is ready for review, the dependent gate passed (and showed tinyipa) | 12:16 |
*** joprovost has joined #openstack-ironic | 12:17 | |
*** baoli has quit IRC | 12:19 | |
*** vmud213 has joined #openstack-ironic | 12:22 | |
vmud213 | good morning all | 12:22 |
dtantsur | jroll, morning! please reconsider https://review.openstack.org/#/c/329428/ when you're back | 12:24 |
dtantsur | morning vmud213 | 12:24 |
vmud213 | morning dtantsur | 12:24 |
vmud213 | dtantsur: Really having tough time to build redhat image with DIB, Can you please help... | 12:28 |
dtantsur | sure | 12:29 |
vmud213 | dtantsur: Here is the log that says my node is registered with redhat satellite server http://paste.openstack.org/show/526952/ | 12:30 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Make Ironic variables visible inside exercise.sh https://review.openstack.org/338727 | 12:30 |
vmud213 | dtantsur: But when i run DIB with DIB_LOCAL_IMAGE=<some image.qcow2> it fails saying | 12:30 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-inspector: Use IRONIC_TEST_NETWORK_NAME to boot instance. https://review.openstack.org/338116 | 12:31 |
*** xavierr has quit IRC | 12:33 | |
vmud213 | dtantsur: When building the image it fails as pasted in http://paste.openstack.org/show/526953/ | 12:33 |
vmud213 | dtantsur: any clue? | 12:34 |
dtantsur | hmm, so it does not catch the fact that you use satellite | 12:35 |
mat128 | vmud213: + yum -v -y install os-prober system-logos grub2-tools gettext redhat-lsb-core There are no enabled repos. | 12:35 |
dtantsur | vmud213, have you checked the readme for older "rhel" element: http://docs.openstack.org/developer/diskimage-builder/elements/rhel/README.html | 12:35 |
dtantsur | I think it applies to rhel7 as well | 12:35 |
* vmud213 looking at it now | 12:36 | |
*** zzzeek has quit IRC | 12:37 | |
*** aparnav has quit IRC | 12:38 | |
vmud213 | dtantsur: my case applies to RHN and not RHSM correct? I am not really sure.and also wher do i get these variables that the document asks to set? | 12:39 |
dtantsur | vmud213, hmm, I've just realized I don't understand this bit well enough. Did you try asking on #tripleo? they know more about DIB for sure | 12:40 |
vmud213 | for instance, DIB_RHSM_USER, DIB_SAT_KEY, DIB_SAT_URL etc? | 12:40 |
vmud213 | dtantsur: Sure will ask...Thanks for point out the rhel stuff...I missed it hoping i only need rhel7. | 12:41 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Remove the -x option from ps -ax when collecting logs https://review.openstack.org/338942 | 12:41 |
*** jcoufal has joined #openstack-ironic | 12:43 | |
*** yuikotakadamori has quit IRC | 12:47 | |
*** yuikotakadamori has joined #openstack-ironic | 12:48 | |
lucasagomes | dtantsur, you have the link to the patch changing the job to tinyipa handy there? | 12:52 |
sambetts | lucasagomes: https://review.openstack.org/#/c/338867/ | 12:53 |
*** thiagop has joined #openstack-ironic | 12:53 | |
lucasagomes | sambetts, ta much | 12:53 |
thiagop | Good morning folks | 12:53 |
sambetts | Morning thiagop | 12:53 |
lucasagomes | thiagop, morning | 12:53 |
thiagop | sambetts: hiya! I was meaning to ask you something: what distro do you use to deploy the physical machines on tempest? CirrOS is not working well for me (propably network driver missing...) | 12:54 |
thiagop | morning lucasagomes | 12:54 |
*** joprovost has quit IRC | 12:54 | |
thiagop | probably* | 12:55 |
dtantsur | thiagop, I assume that our CI is using CirrOS for instances | 12:56 |
*** xavierr has joined #openstack-ironic | 12:56 | |
sambetts | thiagop: I built an ubuntu image according to the Ironic install guide using DIB and uploaded it to a server in my test environment, L38 | 12:56 |
sambetts | http://paste.openstack.org/show/521216/ | 12:56 |
*** Goneri has quit IRC | 12:56 | |
thiagop | dtantsur: default is cirros :/ | 12:56 |
sambetts | is how you can inject a custom iamge | 12:56 |
sambetts | CirrOS doesn't work good with real hardware it seems, the drivers aren't there | 12:57 |
dtantsur | ah, I've missed the real hardware bit | 12:57 |
sambetts | yeah | 12:57 |
thiagop | sambetts: yeah. This custom image of ubuntu of yours, is it >1G? | 12:57 |
thiagop | sambetts: (I'm begining to get sick about time) | 12:58 |
thiagop | time of the full test, btw | 12:58 |
sambetts | thiagop: its whatever "disk-image-create ubuntu vm dhcp-all-interfaces -o my-image" spits out | 12:58 |
sambetts | thiagop: what sort of times are you getting? my CI completes a run in 1.5-2hrs right now | 12:59 |
*** PollyZ has quit IRC | 12:59 | |
thiagop | my tempest is running right below 1h | 12:59 |
thiagop | 54min, 56min... | 13:00 |
sambetts | does that include the time to devstack ? | 13:00 |
thiagop | yep | 13:00 |
thiagop | but I'm using nodepool to cache some dependencies | 13:00 |
sambetts | wow thats really fast | 13:00 |
sambetts | thiagop: I also do | 13:01 |
sambetts | thiagop: so that means your actual tempest run is taking about 30 mins because devstack is normally about 20mins | 13:01 |
*** links has quit IRC | 13:02 | |
*** sdake has joined #openstack-ironic | 13:07 | |
*** rloo has joined #openstack-ironic | 13:07 | |
*** hoangcx has joined #openstack-ironic | 13:09 | |
*** yuikotakadamori has quit IRC | 13:11 | |
*** vmud213 has quit IRC | 13:12 | |
openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Fix py35 unit tests https://review.openstack.org/338777 | 13:12 |
*** ccamacho|lunch is now known as ccamacho | 13:12 | |
thiagop | sambetts: The last test I did resulted in 1h7m | 13:14 |
thiagop | sambetts: http://paste.openstack.org/show/526962/ | 13:14 |
*** yuikotakadamori has joined #openstack-ironic | 13:15 | |
thiagop | sambetts: this one failed due to ssh timeout, so it should be faster when things works. :) | 13:15 |
*** M00nr41n has quit IRC | 13:15 | |
openstackgerrit | Merged openstack/ironic-inspector: [devstack] Do not hardcode coreos ramdisk when building from source https://review.openstack.org/338867 | 13:17 |
dtantsur | lucasagomes, ^^^ | 13:18 |
lucasagomes | o/ | 13:18 |
* lucasagomes updates the other patch | 13:18 | |
sambetts | thiagop: interestingly my actual tempest run is faster than yours, 1789 seconds vs 1920 seconds, for some reason devstack seems to be slow | 13:18 |
*** mtanino has joined #openstack-ironic | 13:19 | |
*** fragatina has joined #openstack-ironic | 13:21 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-python-agent: Replace the ps options when collecting logs https://review.openstack.org/338942 | 13:21 |
lucasagomes | dtantsur, ^ let's see | 13:21 |
dtantsur | yep | 13:21 |
*** PollyZ has joined #openstack-ironic | 13:22 | |
*** sdake_ has joined #openstack-ironic | 13:23 | |
*** baoli_ has quit IRC | 13:24 | |
jroll | dtantsur: +1'd | 13:25 |
dtantsur | thnx | 13:25 |
jroll | thiagop: your question from last night, downstream we use images that our images team builds, mostly stock ubuntu with some special rackspace edits for cloud-init and such | 13:26 |
thiagop | jroll: right, tks for the info | 13:26 |
*** sdake has quit IRC | 13:27 | |
*** PollyZ has quit IRC | 13:30 | |
*** PollyZ has joined #openstack-ironic | 13:30 | |
thiagop | General question: is there a channel where the OS foundation people chat? | 13:34 |
mat128 | thiagop: #openstack-foundation has 20 users right now | 13:34 |
thiagop | thanks mat128 | 13:35 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Implement new heartbeat for AgentDeploy https://review.openstack.org/333964 | 13:35 |
*** baoli has joined #openstack-ironic | 13:37 | |
sambetts | vdrok: RE: the test changes in the internal_info patch, I wonder whether we should add a patch that fixes those create calls and also adds some code into create_test_port that prevents dev doing this sort of thing again | 13:42 |
*** mtanino has quit IRC | 13:43 | |
*** baoli has quit IRC | 13:44 | |
*** zzzeek has joined #openstack-ironic | 13:44 | |
vdrok | sambetts: OK will do that, I'm in the middle of rebase :) but as the changes to tests are super easy, I think it does no harm leaving it there | 13:44 |
rloo | sambetts, vdrok: or open a bug and have someone else fix those :) | 13:45 |
rloo | vdrok: I just commented. let me know about the reno. | 13:45 |
vdrok | morning rloo and thiagop | 13:45 |
vdrok | ugh, reno :( | 13:45 |
thiagop | morning vdrok rloo | 13:45 |
rloo | hi vdrok, sambetts, mat128, thiagop, dtantsur, lucasagomes, jroll | 13:46 |
dtantsur | morning rloo | 13:46 |
mat128 | hi rloo | 13:46 |
rloo | vdrok: sorry, but our users out there love them :) | 13:46 |
sambetts | Morning rloo | 13:46 |
lucasagomes | rloo, morning | 13:46 |
thiagop | jroll: btw, I'd like very much to hear (see?!) your thoughts on the leadership training | 13:46 |
vdrok | yeah, so as I will update it anyway, will remove those unittest changes | 13:47 |
lucasagomes | rloo, btw the nova matchers thingy, we still unsure whether the <all-in> op is used to match items from a list or substring? | 13:47 |
lucasagomes | mgould, I think you've asked it around right ^ ? | 13:47 |
mat128 | lucasagomes: I dont think theres a concept of list in flavors | 13:47 |
mat128 | s/flavors/capabilities | 13:47 |
rloo | lucasagomes: i think it was meant to match items from a list. the problem is that the list is specified as a string. | 13:47 |
lucasagomes | rloo, hmm right | 13:48 |
* lucasagomes really just wanted to agree in which operators he should use :-/ | 13:48 | |
*** Goneri has joined #openstack-ironic | 13:48 | |
rloo | lucasagomes: so my thinking is, if the original nova code is 'wrong', the new improved version from josh is similarly 'wrong'. so I am fine with both patches, and if someone fixes it later, then that is fine too. but others may want to fix it first if it is wrong. | 13:49 |
mgould | rloo, lucasagomes: I asked on #openstack-nova but couldn't convince them there was a question to answer | 13:49 |
mgould | I've been meaning to post to the ML but haven't got to it yet | 13:49 |
mgould | will do that this afternoon | 13:49 |
mgould | sorry! | 13:49 |
lucasagomes | rloo, right, and without that fix apparently we won't get it in oslo :-/ | 13:50 |
rloo | lucasagomes, mgould: see changbo's comment. But no mention of who 'we' are, that is going to confirm ... https://review.openstack.org/#/c/308398/ | 13:50 |
lucasagomes | tbh, it seems fine to support both cases, the "in" operator in python does the same thinh | 13:50 |
lucasagomes | sounds like a feature (lol) :D | 13:50 |
mgould | heh | 13:50 |
mgould | I don't think the "fix" will affect the semantics of the operators | 13:51 |
rloo | lucasagomes, mgould: I have to admit, I am sorry that i detected that. | 13:51 |
mgould | it just changes how they're parsed, the code to evaluate each op is unchanged | 13:51 |
lucasagomes | rloo, no problem at all, if there's anyone correct here it's you | 13:51 |
mgould | rloo: I'm glad you noticed it | 13:51 |
rloo | lucasagomes: I don't know about 'correct', but I do ask questions sometimes ;) | 13:51 |
lucasagomes | which is the correct thing to do if you are unsure | 13:52 |
*** joprovost has joined #openstack-ironic | 13:52 | |
mgould | http://jvns.ca/blog/2014/06/13/asking-questions-is-a-superpower/ | 13:52 |
lucasagomes | rloo, I'm just thinking whether I should stick to that nova's operator since nobody likes it or I should just do something different | 13:52 |
rloo | lucasagomes, mgould: yeah, it is a good thing to do, unless it slooooows things doooooown... | 13:52 |
lucasagomes | or even if we should merge it in ironic-lib first and then move to oslo.utils later once that's unstuck | 13:52 |
rloo | lucasagomes: i honestly think that there should be a crossproject spec on operators. | 13:52 |
lucasagomes | rloo, right... it's not simple tho | 13:53 |
rloo | lucasagomes: but that doesn't help us in the short term. | 13:53 |
lucasagomes | ceilometer, nova, ironic (maybe others) have different syntax | 13:53 |
rloo | lucasagomes: so my feeling is to go with nova, since whatever/whenever there is a crossproject spec, it will have to be addressed then. | 13:53 |
mgould | lucasagomes: if you invent your own language, please *start* with a grammar so we don't end up trying to reverse-engineer weird edge-cases later :-) | 13:53 |
lucasagomes | mgould, yeah, that's my last option really but yeah, will keep in mind | 13:54 |
mgould | \o/ | 13:54 |
rloo | lucasagomes, mgould: I definitely do not agree with a new/different op syntax. that would make things even worse. | 13:54 |
lucasagomes | rloo, right, so can we have it in ironic-lib then so I can move fwd with it? | 13:54 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Promote agent vendor passthru to core API https://review.openstack.org/330018 | 13:54 |
rloo | lucasagomes: sigh. let me ask harlowja what he thinks. | 13:54 |
lucasagomes | ack, ty :-) | 13:55 |
dtantsur | jroll, wdyt about vdrok's suggestion about a new job using old API at https://review.openstack.org/#/c/334523/8/ironic_python_agent/ironic_api_client.py ? | 13:55 |
rloo | vdrok: wrt 'temporary_vif_port_id'. If we had separate 'clean_vif_port_id' and 'provision_vif_port_id', would that make things more complicated (wrt coding); or make it easier to understand? | 13:57 |
rloo | vdrok: or is 'vif_port_id_being_used' clearer? | 13:57 |
vdrok | heh, vif_port_id_being_used :) | 13:58 |
vdrok | so it will be just more things listed | 13:58 |
rloo | vdrok: except that it never includes the tenant's, right? | 13:58 |
*** PollyZ has quit IRC | 13:59 | |
vdrok | rloo: correct | 13:59 |
sambetts | rloo, vdrok: it just makes it more complicated in the dhcp providers | 13:59 |
vdrok | it will look like port.internal_info.get('cleaning_vif_port_id') or port.internal_info.get('provisioning_vif_port_id') or port.extra.get('vif_port_id') | 13:59 |
vdrok | or we can pass some parameter like 'cleaning' or 'provisioning to some functions' | 13:59 |
sambetts | ^ I don't mind that | 14:00 |
sambetts | the multi ORs that is | 14:00 |
rloo | sambetts: with the multi ORs, does it make it clearer what is going on? I think so... | 14:00 |
vdrok | also on cleaning up the fields we'll have to clean up them all | 14:00 |
sambetts | rloo: I think it does | 14:00 |
*** baoli has joined #openstack-ironic | 14:01 | |
sambetts | vdrok: but each peice of the code will be responsible for its own varibale | 14:01 |
sambetts | vdrok: which I think will be much nicer | 14:01 |
*** joprovost1 has joined #openstack-ironic | 14:02 | |
vdrok | sambetts: not really, eg what's in code now - this temporary_vif_port_id is added to ironic port in common neutron, not in network provider | 14:02 |
sambetts | vdrok: which I hate | 14:02 |
*** joprovost has quit IRC | 14:02 | |
*** joprovost1 is now known as joprovost | 14:02 | |
sambetts | :-P | 14:02 |
vdrok | and now I moved all the cleanup into the remove_neutron_ports also in common | 14:02 |
vdrok | sambetts: yeah, but we need to know which ones were created and which ones were not | 14:03 |
*** mgould is now known as mgould|meeting | 14:03 | |
vdrok | as it's done in common neutron, addition of this field is there | 14:03 |
sambetts | vdrok: I think that in the neutron network interface connect to provisioning network should be responsible for the variable provis_vif_port_id | 14:04 |
johnthetubaguy | jroll: who is good to ask about vnic_type having to be baremetal when you create a port? https://bugs.launchpad.net/nova/+bug/1599836 | 14:04 |
openstack | Launchpad bug 1599836 in OpenStack Compute (nova) "Booting Ironic instance, neutron port remains in DOWN state" [High,Triaged] - Assigned to John Garbutt (johngarbutt) | 14:04 |
vdrok | sambetts: so that still means additional param to add_ports_to_network and remove_ports_from_network | 14:06 |
sambetts | vdrok: nope, just make add_ports return the IDs it creates | 14:06 |
vdrok | as the common code is shared between lots of places | 14:06 |
sambetts | and make remove ports take in a list of ports or somethign | 14:07 |
vdrok | sambetts: hm, it already does return all the ports it creates | 14:08 |
vdrok | https://review.openstack.org/#/c/285852/62/ironic/common/neutron.py@183 | 14:08 |
sambetts | imo the network interface itself should be responsible for storing the IDs whereever it wants because it may be implementation specific | 14:09 |
vdrok | ah, you mean move the storing to interface | 14:09 |
sambetts | and if its done in the common neutron code that ties that code to the in-tree nettron based network interfaces | 14:09 |
sambetts | vdrok: yes | 14:10 |
vdrok | then there will be duplication in flat and neutron interfaces | 14:10 |
vdrok | but maybe it's ok | 14:10 |
*** baoli has quit IRC | 14:11 | |
*** baoli has joined #openstack-ironic | 14:12 | |
sambetts | only like a few lines in the cleaning_network configuration functions | 14:12 |
vdrok | yup | 14:13 |
openstackgerrit | Yuiko Takada Mori proposed openstack/ironic: Follow-up patch of cbe51c6a10d1fa68c7082af67827d8c0d8967fe3 https://review.openstack.org/338658 | 14:14 |
jroll | johnthetubaguy: probably vsaienk0, sambetts, Sukhdev | 14:18 |
yuikotakadamori | good morning ironic | 14:18 |
*** joprovost1 has joined #openstack-ironic | 14:19 | |
jroll | hi yuikotakadamori :) | 14:19 |
yuikotakadamori | jroll, hi :) | 14:19 |
thiagop | morning yuikotakadamori | 14:19 |
dtantsur | yuikotakadamori, o/ | 14:19 |
yuikotakadamori | thiagop, dtantsur: hi :D | 14:21 |
*** joprovost has quit IRC | 14:21 | |
*** joprovost1 is now known as joprovost | 14:21 | |
sambetts | johnthetubaguy: If I remember correctly reason we need a custom vnic type is because we need to indicate to the drivers underlying neutron that this port is directly connected to a server and isn't a going via another technology whether that be a virtual switch or something like SRIOV | 14:21 |
jroll | thiagop: so, I'm still internalizing much of the training. I hope to write something about it. I can tell you it was a very good experience, I learned quite a bit, their model is surprisingly relevant to openstack. | 14:22 |
sambetts | johnthetubaguy: although I've mostly been developing from the Ironic side, Sukhdev_ probably can giev you a more in-depth explanation on why this was required instead of reusing on the existing vnic types | 14:22 |
jroll | thiagop: openstack as a whole needs to do better at communicating, setting expectations, things like that | 14:23 |
*** xhku has joined #openstack-ironic | 14:23 | |
jroll | johnthetubaguy: sambetts: I think it's about how ML2 drivers can stack, so a single neutron thing might have a cisco TOR ML2 thing, and some virtual ML2 thing, the vnic can signal which ports they should handle or skip | 14:23 |
thiagop | jroll: I feel that too. I sense a lack of convergence in objectives, have a common goal. Ironic is a project that is quite different in this context, but in other projects sometimes I see people working in different things to solve the same issue | 14:24 |
sambetts | jroll, johnthetubaguy: yeah I belive that is right, I just wonder what the difference is between "baremetal" and the "direct" vnic types | 14:25 |
jroll | thiagop: yep, there was a lot of talk about visioning (setting sights on the longer-term future to help make shorter-term decisions) that I'd like to explore in ironic. there was also quite a bit about how they implement change from the bottom up | 14:25 |
jroll | thiagop: which may or may not be helpful in an openstack context, it's weird for leaders in openstack because we have some amount of 'power' but no direct authority over anyone | 14:26 |
sambetts | jroll, johnthetubaguy: Sukhdev_: perhaps you can enlighten us on the differences between baremetal and direct vnic tyoes | 14:26 |
sambetts | types | 14:26 |
jroll | thiagop: one thing people are kickstarting is a working group https://review.openstack.org/#/c/337895/ | 14:27 |
jroll | sambetts: yeah, I've no clue, I don't see sukhdev here though :( | 14:27 |
*** mtanino has joined #openstack-ironic | 14:28 | |
vsaienk0 | morning jroll, lucasagomes, sambetts and all | 14:28 |
*** hoangcx has quit IRC | 14:28 | |
thiagop | jroll: setting vision is a thing that I'm struggling to learn right now. I'm always a bit sceptic about trying to influence people this way at first, but experience revealed that influencing people through vision is a better experience than influencing them by deadlines | 14:28 |
jroll | \o vsaienk0 | 14:28 |
lucasagomes | vsaienk0, morning | 14:29 |
*** penick has quit IRC | 14:29 | |
*** rajinir has joined #openstack-ironic | 14:29 | |
jroll | thiagop: right, so the first bit is to agree on a shared vision | 14:29 |
jroll | thiagop: because then you aren't influencing people with it, you all share it and work together toward it | 14:30 |
*** hoangcx has joined #openstack-ironic | 14:30 | |
thiagop | jroll: yeah, right on the concept that is better to lead over authority that over power (authority has another conotation here) | 14:31 |
*** joprovost1 has joined #openstack-ironic | 14:31 | |
*** joprovost has quit IRC | 14:31 | |
*** joprovost1 is now known as joprovost | 14:31 | |
jroll | thiagop: well, in this context, "authority" means "I can tell you what to do because I'm your boss" and "power" means more of "you see me as a good leader with good ideas, and so you trust that I'm making the right decisions" | 14:33 |
thiagop | jroll: leading on openstack has nothing to do with power, but how people respect you and build/share the vision. It is a very interesting environment to build leadership indeed because it is very diverse (people that know how to lead, people that know how to follow, people that know neither) | 14:33 |
jroll | thiagop: yeah, that matches my definition :) | 14:33 |
thiagop | jroll: my understanding is the inverse: authority you build over respect and power is given (and taken) to(from) you | 14:34 |
thiagop | jroll: did they talk about the four leadership roles? I think it's more a NOLSie thing... | 14:34 |
jroll | thiagop: yeah, definitions are important here | 14:35 |
thiagop | (or maybe they have it with another names) | 14:35 |
lucasagomes | thiagop, jroll kinda sounds like s/power/influence | 14:35 |
jroll | thiagop: I don't believe so, no | 14:35 |
jroll | lucasagomes: yeah, I'm just using the words we were using in the discussion | 14:35 |
lucasagomes | right on | 14:35 |
jroll | so anyway, a big struggle in openstack is when the vision differs between upstream power/influence vs downstream authority, and how individual contributors handle that conflict | 14:36 |
*** joprovost has quit IRC | 14:36 | |
thiagop | yeah, leadership is a thing that is studied by different facets and have many definitions conflicting over the theories lucasagomes. It is important to clarify it when discussing this kind of things | 14:36 |
rloo | jroll: no conflict. 'who pays me' wins :) | 14:36 |
jroll | some go community first, some go company first | 14:36 |
lucasagomes | thiagop, sure | 14:37 |
jroll | and a 'leader' in openstack should be community-first | 14:37 |
thiagop | on NOLS we differ the four leadership roles as [1] Designated leader, [2] Active follower, [3] Peer leader and [4] Self-leader | 14:38 |
*** [1]cdearborn has joined #openstack-ironic | 14:39 | |
thiagop | rloo: 'who pays me wins' the outcome, but not my mind over it | 14:40 |
thiagop | :) | 14:40 |
*** moshele has joined #openstack-ironic | 14:40 | |
rloo | thiagop: I'm realistic. You wouldn't be here if someone wasn't paying you? :) | 14:40 |
*** sabeen has joined #openstack-ironic | 14:40 | |
sambetts | jroll: I think we get some really interesting case studys of community vs company in Ironic with Ironic core dev vs driver dev | 14:41 |
thiagop | rloo: sure not, programming is not a hobby for me. But I'm not considering only the OS environment when I say that. | 14:41 |
thiagop | rloo: And I tend to do a bigger effort when I deeply agree with what people ask me to do | 14:42 |
sambetts | rloo: sure, but I would activly seek out someone to pay me to do this | 14:42 |
sambetts | getting paid to do your hobby is the dream right? | 14:42 |
*** hoangcx has quit IRC | 14:43 | |
*** joprovost has joined #openstack-ironic | 14:43 | |
rloo | thiagop et al: I think this is a great thing to discuss offline, I am not comfortable saying what i really think in public :) | 14:43 |
*** hoangcx has joined #openstack-ironic | 14:43 | |
sambetts | rloo: :) sure | 14:43 |
thiagop | rloo: lol, it happens | 14:45 |
thiagop | maybe we can spend a night over sangrias on Barcelona talking about it :) | 14:45 |
sambetts | :D | 14:45 |
jroll | rloo: one of my favorite parts of the training was getting a bunch of those people together for three days, without a hard agenda, and just being able to talk about things | 14:45 |
jroll | the summit gets weird because everyone is so tired by the time the day is done and we can talk without a topic | 14:46 |
rloo | jroll: ++ I suspected the training would be good for that. | 14:46 |
thiagop | let get to barcelona earlier then :X | 14:46 |
*** itamarl_ has joined #openstack-ironic | 14:47 | |
sambetts | when are people planning on getting to spain? | 14:47 |
lucasagomes | rloo, ++ re not being comfortable | 14:47 |
dtantsur | sambetts, monday-saturday for me | 14:47 |
*** vishwanathj has quit IRC | 14:47 | |
rloo | whoa, people already know when they are going? :) | 14:47 |
jroll | what rloo said :P | 14:48 |
lucasagomes | I do :-) | 14:48 |
*** edand has quit IRC | 14:48 | |
dtantsur | sometimes you have to do it in advance :) | 14:48 |
*** vishwanathj has joined #openstack-ironic | 14:48 | |
*** ayoung has joined #openstack-ironic | 14:48 | |
dtantsur | i.e. tickets vienna-barcelona are running out already | 14:48 |
thiagop | I'll try to get there on saturday | 14:48 |
jroll | I'll be there sunday-saturday for sure, I'd like to spend some extra time as well | 14:48 |
jroll | probably will attend board/tc meeting sunday | 14:48 |
*** moshele has quit IRC | 14:48 | |
*** PollyZ has joined #openstack-ironic | 14:48 | |
sambetts | I'm doing Sunday to Sunday to get an extra day for myself at the end | 14:48 |
lucasagomes | jroll, totally worth it, barcelona is pretty awesome | 14:49 |
thiagop | jroll: I want to visit some places I couldn't in 2014 | 14:49 |
jroll | lucasagomes: yeah, I'm super excited about it | 14:49 |
dtantsur | we're under budget constraints this time :) | 14:49 |
*** itamarl has quit IRC | 14:49 | |
*** itamarl_ is now known as itamarl | 14:49 | |
lucasagomes | just watch ur stuff when in the metro and stuff | 14:49 |
jroll | ofc | 14:49 |
lucasagomes | it has been consider the pickpocket capital of europe for a reason | 14:49 |
jroll | :( | 14:49 |
lucasagomes | jroll, it's all good, I've been there before nothing ever happened | 14:50 |
lucasagomes | but yeah stay alert anyway | 14:50 |
jroll | yeah, I've lived in a couple of the most dangerous cities in the US, I'm not too worried | 14:50 |
*** itamarl has quit IRC | 14:50 | |
jroll | but will watch out, thanks! | 14:50 |
* rloo thinks jroll has height to help his cause | 14:51 | |
thiagop | lol | 14:51 |
jroll | heh | 14:51 |
thiagop | I used one of these money bags all the time to put money (ofc) and my passport. Had no problems in 5 days | 14:51 |
jroll | that just means my pockets are closer to eye level for everyone else :| | 14:51 |
thiagop | and out of the pickpocketing, it's a pretty secure city | 14:51 |
*** ametts has joined #openstack-ironic | 14:51 | |
lucasagomes | thiagop, indeed | 14:52 |
thiagop | I just ate badly out there. They don't eat much carbo (out of bread and croissants) | 14:52 |
lucasagomes | thiagop, well, spaniards will eat bread with anything else | 14:53 |
lucasagomes | so... | 14:53 |
*** hoangcx has quit IRC | 14:54 | |
* sambetts is really looking forward to the food | 14:54 | |
*** cdearborn has quit IRC | 14:54 | |
thiagop | lucasagomes: they use all their rice on the paellas | 14:55 |
* thiagop dislikes seafood | 14:55 | |
* dtantsur adores seafood | 14:56 | |
jroll | nom nom seafood | 14:56 |
sambetts | thiagop: we'll go eat together then :-P | 14:56 |
lucasagomes | heh thiagop the authentic valencia paella is not with seafood, but yeah, in catalonia I'm not sure you will find it easily | 14:57 |
thiagop | lucasagomes: what is it with? | 14:58 |
*** thiagop has left #openstack-ironic | 14:59 | |
*** ifarkas has quit IRC | 14:59 | |
lucasagomes | thiagop, diff types, rabbit, chicken | 14:59 |
*** thiagop has joined #openstack-ironic | 14:59 | |
lucasagomes | the small snails | 14:59 |
thiagop | seems way better :) | 15:00 |
*** bharath has joined #openstack-ironic | 15:02 | |
*** mjura has quit IRC | 15:02 | |
*** priteau has joined #openstack-ironic | 15:09 | |
*** mgould|meeting is now known as mgould | 15:12 | |
*** sdake_ has quit IRC | 15:13 | |
*** sdake has joined #openstack-ironic | 15:14 | |
jlvillal | sambetts, For the food. Prepare to eat dinner after 8:30pm :) | 15:15 |
jlvillal | In Barcelona they have dinner late | 15:15 |
thiagop | sambetts: image ubuntu vm dhcp is ~350M | 15:16 |
thiagop | just as a note | 15:16 |
thiagop | morning mr jlvillal | 15:16 |
sambetts | jlvillal: is the whole summit going to shut down in the middle of the day for a siesta | 15:16 |
jlvillal | Hi thiagop | 15:16 |
jlvillal | sambetts, I wish :) | 15:16 |
thiagop | lol | 15:16 |
harlowja | rloo whats up | 15:17 |
rajinir | thiagop: post-config with ironic.conf isn't working. https://www.irccloud.com/pastebin/dSyZp0Mc/ironic-post-config. Any ideas? | 15:17 |
rloo | hey harlowja. remember the discussion we had wrt nova operators | 15:17 |
thiagop | rajinir: post-extra | 15:18 |
rloo | harlowja: https://review.openstack.org/#/c/308398/ | 15:18 |
thiagop | rajinir: post-config runs before tempest is installed | 15:18 |
harlowja | rloo right | 15:18 |
rloo | harlowja: because I found that 'discrepancy' with <all-in> operator, how do we move forward on it | 15:18 |
rajinir | thiagop: post-extra on TEMPEST_CONFIG? | 15:19 |
rloo | harlowja: lucasagomes wants to use it sooner rather than later. if we don't think it'll get into oslo soon, i think we will end up adding that to our ironic-lib (w/o your fancy change) | 15:19 |
thiagop | rajinir: exactly | 15:19 |
*** joprovost1 has joined #openstack-ironic | 15:19 | |
lucasagomes | harlowja, :-) I kinda want to move fwd with it | 15:20 |
harlowja | lucasagomes jeez, whats the rush, lol | 15:20 |
rloo | harlowja: from my point of view, the nova code might be not quite right. that not-quite-right behaviour remains the same with your updated version. | 15:20 |
*** davidlenwell has quit IRC | 15:20 | |
rloo | harlowja: so i am fine if they both land, and if someone later decides that it was wrong, they can fix it. | 15:20 |
rloo | harlowja: but i am not the keeper of the libraries :) | 15:20 |
harlowja | k | 15:20 |
harlowja | rloo u are just the keeper | 15:21 |
*** joprovost has quit IRC | 15:21 | |
*** joprovost1 is now known as joprovost | 15:21 | |
lucasagomes | harlowja, heh it's because I depend on that to implement a feature (operators for root device hints) | 15:21 |
rajinir | thiagop: will try, is there a specific section name you used? | 15:21 |
harlowja | let me poke gcb and see if he's resolving the -1 he put there | 15:21 |
rloo | harlowja: thx. | 15:21 |
harlowja | but overall keeper rloo i agree | 15:21 |
thiagop | rajinir: baremetal | 15:22 |
harlowja | we can do our best (and i think we did pretty good) | 15:22 |
rajinir | thiagop: Ah. Thanks a bunch will try. | 15:22 |
rloo | harlowja: ++. I think I had comments on your patch but I know you can address those if you want :) | 15:22 |
thiagop | rajinir: http://paste.openstack.org/show/526983/ | 15:22 |
yuikotakadamori | rloo, jroll, could you please review serial console patches https://review.openstack.org/#/c/328168/ and https://review.openstack.org/#/c/293873/ ? Nova patch cannot be merged without merging 2 these Ironic patches. | 15:23 |
thiagop | rajinir: that goes in to my jjb script, btw. But you can infer the result | 15:23 |
jroll | harlowja: lucasagomes: you're welcome to take over that oslo patch btw, if there's things to address | 15:23 |
jroll | yuikotakadamori: I'm happy to do so, but nova patch missed their feature freeze | 15:23 |
rloo | harlowja: I had more tests too, if i can find where I stuck them. Am thinking I should put them in a separate patch after the first patch, and your patch be the last patch. | 15:23 |
rajinir | thiagop: got it. Will give it a try thanks | 15:24 |
yuikotakadamori | jroll, even if ironic patches getting merged now? | 15:24 |
lucasagomes | jroll, thanks... yeah, honestly I would prefer it to be just a c&p from the nova code to start with | 15:24 |
rloo | yuikotakadamori: ++ to what jroll said. | 15:24 |
jroll | lucasagomes: yep | 15:24 |
rloo | yuikotakadamori: yup. did you see dan smith's comment on the nova patch? | 15:24 |
jroll | yuikotakadamori: yes, see dan smith comment https://review.openstack.org/#/c/328157/ | 15:25 |
rloo | yuikotakadamori: also, matt replied on the devlist about it too. | 15:25 |
jroll | yuikotakadamori: I could beg during midcycle if we get ironic stuff done, but I don't think they'll merge it | 15:25 |
harlowja | lucasagomes are u part of brexit? | 15:25 |
lucasagomes | harlowja, nop, I live in the republic which is not part of the UK | 15:25 |
harlowja | kk | 15:25 |
*** watanabe_isao has joined #openstack-ironic | 15:26 | |
rloo | yuikotakadamori: http://lists.openstack.org/pipermail/openstack-dev/2016-July/098899.html | 15:26 |
*** ifarkas has joined #openstack-ironic | 15:26 | |
yuikotakadamori | jroll, rloo, oh...ok, thanks. yes, I saw their comments and email and they seem ironic patches cannot be merged soon, so I thought there is a ray of hope | 15:26 |
lucasagomes | harlowja, but ofc, the decisions there kinda affects things here too (the whole EU/globe to be fair) | 15:26 |
harlowja | ya | 15:27 |
rloo | yuikotakadamori: sorry, I didn't know how their FFE thingy worked. | 15:27 |
rloo | yuikotakadamori: we will try to plan better for future features. | 15:27 |
sambetts | rloo: to be fair this is the first time their freeze has been this early as far as I know | 15:28 |
yuikotakadamori | rloo, me, too because it's first time for me to do FFE request. it's too hard to implement in Nova because FF is so early than ironic >_< | 15:28 |
mgould | harlowja: "what's going to happen to Northern Ireland" is one of the scariest parts of the Brexit fiasco: https://storify.com/shockproofbeats/why-didnt | 15:28 |
harlowja | won't ireland just take it back? | 15:28 |
mgould | the whole peace process assumes both sides of the border are EU members | 15:28 |
harlowja | although idk, northern ireland and ireland have issues i think right | 15:28 |
mgould | harlowja: let me tell you about this little thing called The Troubles... | 15:28 |
mgould | yes, yes they do | 15:28 |
mariojv | good morning ironic | 15:29 |
mgould | morning mariojv | 15:29 |
* jroll finds lunch | 15:29 | |
rloo | sambetts: honestly, i haven't paid attention to how nova's ffe worked in the past (or their dates for that matter). i figured someone would tell me if they needed something done urgently. | 15:29 |
mariojv | does anyone have a way for making an ironic instance not go active in nova until the node actually finishes booting? | 15:29 |
rloo | sambetts: when I asked last week, they said we'd have to ask for a FFE, but I didn't realize that it also meant the ironic code had to have been merged by then. | 15:30 |
*** davidlenwell has joined #openstack-ironic | 15:30 | |
sambetts | rloo: ah, me neither :/ | 15:30 |
TheJulia | rloo: regarding your comment as to what you really think, I'm in the same boat. I temper too much, but that comes from a number of experiences where people have focused entirely on how something was said, and not the actual content or meaning. | 15:30 |
*** joprovost has quit IRC | 15:30 | |
mariojv | if not, i'm thinking that there would be a way to do that. something like generate a one time use token, inject it via a config drive, and have cloud-init make a call at the end of its configuration that says "I have booted" | 15:30 |
yuikotakadamori | rloo, sambetts, exactly! we and Fujitsu guys thought so, too | 15:30 |
mariojv | i'm curious about opinions regarding this | 15:30 |
*** watanabe_isao has quit IRC | 15:30 | |
thiagop | TheJulia: conotation vs. denotation. I listened a leadership podcast about that last week... very interesting to be aware of that. | 15:31 |
harlowja | rloo lucasagomes https://review.openstack.org/#/c/308398/ ok +2(ed) | 15:32 |
rloo | TheJulia: :) I know what you mean, and can remember an example. | 15:32 |
harlowja | gcb is fine with fixing issue later | 15:32 |
yuikotakadamori | jroll, rloo, thanks a lot for having reviewed several times! I hope we can implement nova-compatible serial console feature in Ocata. | 15:32 |
rloo | harlowja: sweet. thx! is gcb going to talk to nova/look into it? | 15:32 |
harlowja | rloo i think he will, i asked him to do a ML post if that will help | 15:32 |
harlowja | let's see if anything actually happens there | 15:32 |
*** joprovost has joined #openstack-ironic | 15:33 | |
harlowja | he might get a better response from nova folks if he does that | 15:33 |
harlowja | (eventually nova response) | 15:33 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Verify JSON response of driver commands https://review.openstack.org/336600 | 15:33 |
sambetts | mariojv: I'm not sure we can denote what is and isn't sucessfully booted, because it depends on the User's image, and also we don't run any software inside the tenant image, that can be affected by the tenant | 15:33 |
thiagop | yuikotakadamori: as jroll said yesterday, much of the times a feature will be completed on Ironic in a cycle and in nova only in the next. So, I'd keep gently keep pushing for reviews :) | 15:33 |
rloo | harlowja: good to know. mgould said he might also post on ML. if two people post, that will even be better :D | 15:33 |
openstackgerrit | Merged openstack/ironic: Remove unused LOG https://review.openstack.org/338706 | 15:34 |
*** dtantsur is now known as dtantsur|bbl | 15:34 | |
lucasagomes | harlowja, woohoo! cheers! | 15:34 |
harlowja | rloo cool more posts the better, ha | 15:34 |
sambetts | mariojv: also when the multitenant networking stuff merges at the point the node powers on for booting the tenant images its already in the tenants network and may not be able to communicate to Ironic | 15:35 |
sambetts | mariojv: there is no equivolent for VMs to guarentee a successful boot, so I'm not sure we need it for baremetal | 15:35 |
openstackgerrit | Merged openstack/ironic: Remove iterated form of side effects https://review.openstack.org/338002 | 15:35 |
yuikotakadamori | thiagop, yeah, that's true :) thanks | 15:37 |
mariojv | sambetts: that's true about it not being able to communicate with ironic | 15:39 |
mariojv | i thought that maybe nova did something with nova-agent to communicate a successful boot | 15:39 |
mariojv | thanks for the input, just a random thought | 15:40 |
sambetts | mariojv: yeah its an interesting problem for both VMs and BMs | 15:41 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Implement new heartbeat for AgentDeploy https://review.openstack.org/333964 | 15:42 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Promote agent vendor passthru to core API https://review.openstack.org/330018 | 15:42 |
*** fragatina has quit IRC | 15:45 | |
*** sdake has quit IRC | 15:48 | |
*** pcaruana has quit IRC | 15:49 | |
*** ChrisAusten has joined #openstack-ironic | 15:50 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Verify JSON response of chassis commands https://review.openstack.org/336596 | 15:51 |
*** sdake has joined #openstack-ironic | 15:51 | |
openstackgerrit | Mario Villaplana proposed openstack/ironic: Document API max_limit configuration option https://review.openstack.org/337885 | 15:53 |
*** derekh has quit IRC | 15:55 | |
NobodyCam | good morning Ironicer's. last few days of vacation for me. | 15:55 |
TheJulia | rloo: the curse is of course, when people focus on part of the content they don't like and not context or delivery | 15:55 |
rloo | TheJulia: it is difficult. We are human, from different cultures, and interpret what we read differently. | 15:56 |
rloo | TheJulia: i think that beer levels the playing field or something ;) | 15:56 |
mgould | morning NobodyCam | 15:58 |
mgould | also, what are you doing here if you're on vacation? Shoo! Go have fun! | 15:58 |
NobodyCam | morning mgould :) | 15:58 |
*** rama_y has joined #openstack-ironic | 15:58 | |
mgould | :-) | 15:59 |
NobodyCam | mgould: just waking up with coffee and IRC | 15:59 |
TheJulia | rloo: Completely agree, on all points :) | 15:59 |
*** livelace has quit IRC | 16:01 | |
lucasagomes | rloo, jroll +2+A'd (nova specs in oslo utils o/) | 16:08 |
lucasagomes | nova matchers* | 16:08 |
lucasagomes | NobodyCam, morning | 16:09 |
*** sdake has quit IRC | 16:09 | |
NobodyCam | morning lucasagomes :) | 16:09 |
jroll | lucasagomes: wow, that was quick | 16:09 |
jroll | lucasagomes: that means I need to revive my change to move nova to it, I guess | 16:10 |
* jroll does that since he has 20 minutes to kill | 16:10 | |
lucasagomes | jroll, yup | 16:10 |
*** rcernin has quit IRC | 16:10 | |
lucasagomes | we probably need a release from oslo.utils and all | 16:10 |
jroll | owait, need a release | 16:10 |
lucasagomes | but yeah | 16:10 |
jroll | sigh | 16:10 |
* jroll marks on todo list | 16:10 | |
*** makowals has joined #openstack-ironic | 16:13 | |
rajinir | What could this error mean on deploy? No VIFs found for node xxx when attempting to update DHCP BOOT options. | 16:17 |
sambetts | rajinir: are you running Ironic in an OpenStack environment | 16:18 |
sambetts | ? | 16:18 |
sambetts | rajinir: and did you deploy your instance via nova? | 16:19 |
openstackgerrit | Yuiko Takada Mori proposed openstack/ironic: Mock global variables https://review.openstack.org/338665 | 16:19 |
rajinir | sambetts: This is coming from our CI with hardware nodes. | 16:19 |
*** yuikotakadamori has quit IRC | 16:19 | |
*** sdake has joined #openstack-ironic | 16:20 | |
rajinir | sambetts: OpenStack environment | 16:20 |
sambetts | mat128: https://review.openstack.org/#/c/339111/ | 16:21 |
rajinir | sambetts: Is it a warning? will 'dhcp_provider=None' fix it? | 16:21 |
*** M00nr41n has joined #openstack-ironic | 16:21 | |
jroll | rajinir: do you have ports created in ironic for each node? | 16:22 |
sambetts | rajinir: if you set dhcp_provider to none Ironic will not configure the required options for booting the deployment ramdisk using PXE | 16:22 |
*** tesseract- has quit IRC | 16:23 | |
rajinir | jroll: I found this error in the conductor logs of the CI run. Shouldn't the ports be created as part of the tempests tests? | 16:23 |
sambetts | rajinir: the ports in Ironic are created as part of the devstack install not the tempest run | 16:24 |
jroll | rajinir: they should be created when you register the nodes | 16:24 |
*** ifarkas has quit IRC | 16:24 | |
jroll | in the devstack run, yeah | 16:24 |
rajinir | sambetts: jroll: devstack install ok. How can I make sure they are created? Will it be in the logs. May be I'm missing some config | 16:25 |
*** sdake has quit IRC | 16:25 | |
mat128 | sambetts: good stuff, reviewing atm | 16:25 |
jroll | rajinir: it should be in devstack logs, yes. I forget how the configuration looks for nodes, though | 16:26 |
rloo | lucasagomes, jroll: depends on what you mean by fast, but yeah, nice that it got in. still need to get harlowja's patch in on top of nova's though, but that should be soon. i hope. right harlowja? https://review.openstack.org/#/c/313699/ | 16:26 |
rajinir | jroll: I have specified the details of the node using the IRONIC_HWINFO file. | 16:26 |
jroll | rajinir: with mac addresses as well? | 16:27 |
jlvillal | lucasagomes, Why do you need an oslo.utils release? | 16:27 |
jlvillal | lucasagomes, 3.15 is proposed to be released as a note | 16:27 |
jroll | jlvillal: https://review.openstack.org/#/c/308403/ | 16:27 |
sambetts | jroll, rajinir: it would have failed an nova boot ... if there weren't any ports in Ironic | 16:27 |
jlvillal | https://review.openstack.org/338358 | 16:27 |
*** sdake has joined #openstack-ironic | 16:28 | |
lucasagomes | jlvillal, to use the operators that just got approved (https://review.openstack.org/#/c/308398/) | 16:28 |
jroll | oslo releases very frequently, I'm not concerned, we'll do it when it happens | 16:28 |
rajinir | jroll: <ipmiaddress> <provisioning_mac_address> <ipmiusername> <password> format | 16:28 |
jlvillal | Okay, thanks | 16:28 |
jroll | rajinir: idk then | 16:28 |
sambetts | jroll, rajinir: I've seen that error when people have triggered Ironic to start an deployment by doing ironic node-set-provision-state active | 16:28 |
rajinir | jroll: ok, is it devlog.log, I'll look for errors | 16:29 |
sambetts | jroll, rajinir: then it doesn't find a vif_port_id on the prot | 16:29 |
sambetts | port* | 16:29 |
jroll | sure | 16:29 |
rajinir | sambetts, jroll,yes, it is where I see the error | 16:29 |
sambetts | rajinir: are you doing ironic node-set-provision-state active to start a deployment? ? | 16:29 |
rajinir | jroll: I mean devstack.log ( devstack install log) | 16:30 |
*** jpich has quit IRC | 16:30 | |
*** mkoderer has quit IRC | 16:30 | |
rajinir | sambetts: yes, its part of the tempest test_baremetal_server_ops | 16:31 |
*** mkoderer has joined #openstack-ironic | 16:31 | |
rajinir | jroll, sambetts: full log https://stash.opencrowbar.org/logs/44/338744/1/silent/dell-drac-hw-tempest-dsvm-ironic-pxe_ipmitool/319b1d8/ | 16:32 |
sambetts | rajinir: our tempest plugin doesn't start a deployment via Ironic, it starts it via a nova boot ... | 16:32 |
jroll | ehhhhh | 16:34 |
jroll | https://github.com/openstack/ironic/blob/master/ironic_tempest_plugin/tests/api/admin/test_nodestates.py#L80 | 16:34 |
jroll | I think upstream that uses the fake driver | 16:35 |
sambetts | yup all the API tests use the fake driver | 16:35 |
sambetts | I think you might have run into the issue that I did when I first started | 16:35 |
sambetts | have you turned tempest concurrecny to 1 | 16:36 |
sambetts | if you don't do that the api tests stand on the basic ops test | 16:36 |
sambetts | rajinir: ^ | 16:36 |
*** makowals has quit IRC | 16:37 | |
sambetts | hmm in that log output it seems like you have | 16:37 |
openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: Add trusted_boot to server capabilities https://review.openstack.org/339119 | 16:38 |
rajinir | sambetts: yes the tempest concurrency is turned on | 16:38 |
rajinir | sambetts: I'm using real hardware, have specified deploywait_timeout to 20 mins. But the test is timing out and "No Vips" is the only error in the conductor log files | 16:40 |
*** Romanenko_K has quit IRC | 16:41 | |
rajinir | sambetts: "No VIFs" sorry | 16:41 |
sambetts | rajinir: that means that nova hasn't plugged the vifs on the Ironic node correctly | 16:42 |
*** dprince has quit IRC | 16:42 | |
openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Centralize config options - [glance] https://review.openstack.org/304829 | 16:42 |
openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Centralize config options - [neutron] https://review.openstack.org/304838 | 16:42 |
mgould | rloo lucasagomes: finally hit "send" on my ML post about spec_matcher, sorry for the delay | 16:44 |
rloo | mgould: no worries. thx for doing it! | 16:44 |
openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Centralize config options - [DEFAULT] https://review.openstack.org/309070 | 16:44 |
rajinir | sambetts: What are VIFs? I'm new to ironic and trying to debug this issue. What does this mean? | 16:44 |
mgould | rajinir: Virtual InterFaces | 16:45 |
mgould | https://en.wikipedia.org/wiki/Virtual_network_interface | 16:45 |
sambetts | rajinir: they are the Neutron ports we use to connect the node into the neutron network | 16:45 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Remove IBootOperationError exception https://review.openstack.org/339127 | 16:45 |
thiagop | rajinir: "Network with name: private not found" | 16:45 |
lucasagomes | mgould, thanks a lot and no worries about it :-) | 16:45 |
*** gfhellma has joined #openstack-ironic | 16:45 | |
*** ifarkas has joined #openstack-ironic | 16:46 | |
thiagop | rajinir: line 4039 in tempest.txt | 16:46 |
thiagop | something is wrong on the network configuration | 16:46 |
mgould | rajinir: like network interface cards, but virtual | 16:46 |
lucasagomes | folks I'm calling it a day | 16:47 |
mgould | lucasagomes: good night! | 16:48 |
lucasagomes | have a great night all, talk to you soon | 16:48 |
TheJulia | goodnight lucasagomes | 16:48 |
*** lucasagomes is now known as lucas|afk | 16:48 | |
thiagop | see ya lucas|afk | 16:48 |
*** ifarkas has quit IRC | 16:49 | |
rajinir | mgould: sambetts: thiagop: I see that message in temptest.txt. May be it is a network. Let me get some ironic folks in my team to look at it | 16:50 |
thiagop | rajinir: public and private networks are created by default in devstack and assumed to be ready to use by tempest. So, if you changed some conf, you may need to review. | 16:51 |
rajinir | thiagop: ok | 16:52 |
rajinir | mgould: sambetts: thiagop: thank you guys. Will get back to you after some internal help | 16:54 |
*** dtantsur|bbl is now known as dtantsur | 16:54 | |
mgould | rajinir: no problem, good luck! | 16:56 |
*** cdearborn has joined #openstack-ironic | 17:01 | |
*** Sukhdev has joined #openstack-ironic | 17:02 | |
*** klindgren__ is now known as klindgren | 17:02 | |
*** trown is now known as trown|lunch | 17:03 | |
*** dprince has joined #openstack-ironic | 17:06 | |
harlowja | rloo correct, i'll address some of your comments in that | 17:10 |
rloo | thx harlowja. | 17:10 |
*** sdake has quit IRC | 17:11 | |
sambetts | jroll, JayF: any input you guys have onto this clean up patch for our job would be useful, https://review.openstack.org/#/c/339111, Ajaeger has also suggested moving all our job-templates into an ironic.yaml file as there are so many now | 17:12 |
*** sabeen has quit IRC | 17:12 | |
jroll | sambetts: thanks. not opposed to ironic.yaml, if we can do the same things there | 17:13 |
sambetts | jroll: awesome :) | 17:14 |
*** baoli has quit IRC | 17:14 | |
*** PollyZ has quit IRC | 17:16 | |
*** [1]cdearborn has quit IRC | 17:16 | |
*** PollyZ has joined #openstack-ironic | 17:18 | |
mat128 | jroll, sambetts: all files are created equal in jjb ;) | 17:19 |
jroll | mat128: heh | 17:19 |
jroll | I was just wondering if like, ironic.yaml had to have the initial script jenkins runs in ironic repo | 17:20 |
mat128 | ah | 17:20 |
jroll | idk if that was quite english :) | 17:20 |
mat128 | you can take any part of any yaml and put it anywhere | 17:20 |
mat128 | i got it | 17:21 |
mat128 | the devstack-gate stuff? | 17:21 |
jroll | yeah | 17:21 |
mat128 | I wonder why we have so much in that template rather than in our devstack plugin | 17:21 |
jroll | so like, jenkins jobs think they're testing a single git repo, usually | 17:21 |
mat128 | yeah | 17:21 |
jroll | yeah you get what I'm saying, cool | 17:21 |
jroll | we should move some of it to devstack plugin | 17:21 |
jroll | where possible | 17:21 |
*** dtantsur is now known as dtantsur|afk | 17:22 | |
dtantsur|afk | before I go: huge +1 to ironic.yaml | 17:23 |
dtantsur|afk | now see you tomorrow :) | 17:23 |
*** PollyZ has quit IRC | 17:24 | |
jroll | later dtantsur|afk :P | 17:24 |
mat128 | all green! https://review.openstack.org/#/c/327891/ | 17:26 |
sambetts | mat128: most of it is in our devstack plugin, most of the conditionals in the macro are just turning differnt parts of the devstack plugin on and off | 17:26 |
mat128 | I was thinking | 17:26 |
mat128 | why not feed everything that the macro took to our plugin | 17:27 |
mat128 | and we put the conditionals on our side? | 17:27 |
mat128 | like that switch case for memory | 17:27 |
mat128 | but I like where your refactor is headed, and the rule is no effective change in a refactor :) | 17:27 |
johnthetubaguy | jroll: sambetts: Sukhdev: given the bug I saw, and the think about vnic_types, I wonder if this is the right thing to do? https://review.openstack.org/#/c/339143 | 17:29 |
sambetts | mat128: we'd still need to feed them into the job-template some how though, which still results in a 20 line list of variables which we don't care about for every job becuase jjb doesn't allow you to just set a default for a variable if its not there | 17:31 |
* mgould -> home; good night everyone! | 17:31 | |
jroll | johnthetubaguy: feels sane | 17:31 |
mat128 | sambetts: yeah, did I say take the old macro? I meant take the new macros and make them conditional-less | 17:31 |
mat128 | I'm still going through your patch | 17:32 |
johnthetubaguy | jroll: cool, that might the be last thing to let us auto create ports for ironic instances (with a bit of luck!) | 17:32 |
thiagop | mgould: night! | 17:32 |
*** mgould is now known as mgould|afk | 17:32 | |
*** sdake has joined #openstack-ironic | 17:32 | |
mgould|afk | thiagop: good night! | 17:32 |
*** PollyZ has joined #openstack-ironic | 17:32 | |
jroll | johnthetubaguy: we're doing that today, though, it's just no neutron ML2 things are expecting baremetal yet afaik | 17:32 |
johnthetubaguy | jroll: ah, gotcha | 17:33 |
jroll | johnthetubaguy: or at least in the gate | 17:33 |
*** sdake_ has joined #openstack-ironic | 17:34 | |
johnthetubaguy | jroll: actually, this should be fine for ports created outside that don't include vnic_type set too, works both ways now | 17:34 |
*** caiobo-afk has quit IRC | 17:34 | |
* johnthetubaguy runs away to band | 17:34 | |
jroll | johnthetubaguy: indeed, cheers | 17:34 |
*** liliars has quit IRC | 17:35 | |
sambetts | mat128: ah yeah that would be cool :D | 17:35 |
*** PollyZ has quit IRC | 17:36 | |
*** sdake has quit IRC | 17:37 | |
*** PollyZ has joined #openstack-ironic | 17:45 | |
*** M00nr41n has quit IRC | 17:47 | |
*** electrofelix has quit IRC | 17:48 | |
*** phuongnh has joined #openstack-ironic | 17:50 | |
*** PollyZ has quit IRC | 17:50 | |
*** daemontool has quit IRC | 17:52 | |
*** catintheroof has joined #openstack-ironic | 17:53 | |
*** M00nr41n has joined #openstack-ironic | 17:54 | |
vdrok | does anyone sees a problem with test_reboot_and_finish_deploy_soft_poweroff_fails test? it takes 30 seconds locally for me | 17:55 |
*** M00nr41n has quit IRC | 17:55 | |
vdrok | nevermind, I guess it's becase of multitenancy | 17:56 |
*** aNupoisc has joined #openstack-ironic | 17:57 | |
*** sdake_ has quit IRC | 17:57 | |
*** igordcard has quit IRC | 17:59 | |
*** PollyZ has joined #openstack-ironic | 17:59 | |
*** igordcard has joined #openstack-ironic | 17:59 | |
*** baoli has joined #openstack-ironic | 18:03 | |
*** PollyZ has quit IRC | 18:03 | |
*** bharath has quit IRC | 18:05 | |
*** yibo has quit IRC | 18:06 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add 'neutron' network interface https://review.openstack.org/317393 | 18:07 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add internal_info field to ports and portgroups https://review.openstack.org/338417 | 18:07 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Expose node's network_interface field in API https://review.openstack.org/317392 | 18:07 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Update the deploy drivers with network flipping logic https://review.openstack.org/213262 | 18:07 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add network interface to base driver class https://review.openstack.org/285852 | 18:07 |
*** yibo has joined #openstack-ironic | 18:07 | |
*** PollyZ has joined #openstack-ironic | 18:09 | |
vdrok | yibo: I'm sorry, I didn't get to your patch today again :( | 18:12 |
* vdrok is leaving for today | 18:12 | |
vdrok | I will be on PTO tomorrow so unless vsaienk0 has some free time, more updates to the networking chain will be on monday | 18:13 |
vdrok | good night everyone! | 18:13 |
thiagop | good night vdrok | 18:14 |
*** aNupoisc has quit IRC | 18:14 | |
*** trown|lunch is now known as trown | 18:16 | |
*** baoli has quit IRC | 18:17 | |
openstackgerrit | Andre Aranha proposed openstack/python-oneviewclient: Extend python-oneviewclient to Network https://review.openstack.org/294559 | 18:17 |
*** sabeen has joined #openstack-ironic | 18:17 | |
*** aNupoisc has joined #openstack-ironic | 18:20 | |
openstackgerrit | Andre Aranha proposed openstack/python-oneviewclient: Extend python-oneviewclient to Network https://review.openstack.org/294559 | 18:28 |
*** rcernin has joined #openstack-ironic | 18:39 | |
*** ChubYann has joined #openstack-ironic | 18:41 | |
*** baoli has joined #openstack-ironic | 18:46 | |
*** wajdi has joined #openstack-ironic | 18:49 | |
*** jaybeale has joined #openstack-ironic | 18:50 | |
*** Sukhdev has quit IRC | 18:50 | |
*** daemontool has joined #openstack-ironic | 18:54 | |
* sambetts -> home | 18:56 | |
*** sambetts is now known as sambetts|afk | 18:57 | |
sambetts|afk | night all | 18:57 |
thiagop | g'night sambetts|afk | 18:57 |
*** gfhellma has quit IRC | 18:59 | |
openstackgerrit | Andre Aranha proposed openstack/python-oneviewclient: Extend python-oneviewclient to Network https://review.openstack.org/294559 | 18:59 |
*** baoli has quit IRC | 19:00 | |
*** makowals has joined #openstack-ironic | 19:00 | |
*** baoli has joined #openstack-ironic | 19:00 | |
openstackgerrit | Andre Aranha proposed openstack/python-oneviewclient: Extend python-oneviewclient to UplinkSet https://review.openstack.org/295981 | 19:07 |
*** athomas has quit IRC | 19:08 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic-python-agent: Fix doc warnings https://review.openstack.org/339197 | 19:19 |
*** vgadiraj has joined #openstack-ironic | 19:19 | |
jroll | cores, fairly easy review there that needs to get in soon before pbr releases and breaks us | 19:20 |
*** [1]cdearborn has joined #openstack-ironic | 19:22 | |
*** ametts has quit IRC | 19:23 | |
*** baoli has quit IRC | 19:28 | |
*** jcoufal has quit IRC | 19:29 | |
rook- | can anyone tell me with disk hints, can i use the name? | 19:30 |
mat128 | jroll: I think we have warnings in the ironic docs too | 19:31 |
rloo | jroll: looking... | 19:31 |
rook- | for the disk hints, can i pass the name? | 19:31 |
rook- | ie root_device='{"name": "/dev/nvme0n1"} | 19:32 |
jroll | mat128: we don't have warnerrors=True though | 19:32 |
mat128 | ah | 19:32 |
mat128 | ok nvm then | 19:32 |
rloo | jroll: for eg "param **kwargs", I thought it was "param \*\*kwargs" | 19:32 |
jroll | rloo: maybe, I took a quick look at ironic and most docstrings have just 'param kwargs' | 19:33 |
rloo | jroll: i saw it somewhere recently. if i remember in the next couple minutes i'll let you know. | 19:33 |
jroll | rloo: well, I think we're both right :) | 19:33 |
rloo | jroll: i mean, i don't know whether it should be ** or not. but if it is ** it has to be escaped. | 19:33 |
*** baoli has joined #openstack-ironic | 19:34 | |
jroll | rloo: right. same here. I just copied what we do in ironic for now. | 19:34 |
rloo | jroll: found it: https://github.com/openstack/ironic-lib/blob/master/ironic_lib/utils.py#L59 | 19:34 |
rloo | jroll: but i have no idea if that is right either :) | 19:35 |
rloo | jroll: we'll go with what you have. | 19:35 |
jroll | rloo: ok :) | 19:35 |
*** cdearborn has quit IRC | 19:36 | |
*** joprovost has quit IRC | 19:37 | |
*** PollyZ_ has joined #openstack-ironic | 19:37 | |
*** gfhellma has joined #openstack-ironic | 19:38 | |
rloo | jroll: is there a way to see from jenkins, whether there are warnings or not? | 19:38 |
jroll | rloo: in the build logs, though after a successful build I've no clue how to find those :) | 19:39 |
jroll | maybe just add console.html to the link it gives you? | 19:39 |
rloo | jroll: yeah, that's what I was thinking. if it is successful you just see the doc. | 19:39 |
jroll | rloo: I'll figure something out | 19:40 |
*** joprovost has joined #openstack-ironic | 19:40 | |
*** PollyZ has quit IRC | 19:40 | |
mat128 | rloo: the link changes for the rendered docs, but you can take the link to another build that isnt docs | 19:42 |
rloo | mat128: can you find the link (if any) that shows the output from building the doc? | 19:43 |
mat128 | yeah i'm trying to find it | 19:43 |
mat128 | but that last change hasnt built yet | 19:43 |
rloo | mat128: or i can try it locally or believe that jroll tried it locally and it worked for him :) | 19:43 |
jroll | the latter is true :P | 19:44 |
mat128 | :) | 19:44 |
mat128 | I have the formula | 19:44 |
mat128 | https://review.openstack.org/#/c/327891/ | 19:44 |
mat128 | (for example) | 19:44 |
mat128 | take the pep8 link | 19:44 |
mat128 | remove everything after check/ | 19:44 |
mat128 | then there's a directory listing for all jobs that run | 19:44 |
mat128 | or you can just replace pep8 by docs in the url | 19:45 |
mat128 | oh nvm, last compnent changes. | 19:45 |
*** PollyZ_ has quit IRC | 19:50 | |
rloo | mat128: have trust in your leader :) | 19:50 |
jroll | that's the worst idea I've heard this week | 19:50 |
mat128 | haha | 19:50 |
*** PollyZ has joined #openstack-ironic | 19:52 | |
openstackgerrit | Mathieu Mitchell proposed openstack/ironic: Document operators troubleshooting steps https://review.openstack.org/336055 | 19:52 |
mat128 | rloo: I'm done converting all non-proprietary troubleshooting steps, the table format just didnt work | 19:53 |
mat128 | esp. within 80 chars | 19:53 |
rloo | mat128: yeah, 80 chars. well, it is nice to have long narrow things... thx for looking into it! | 19:53 |
rloo | mat128: i've got a bunch of stuff to review today. will try to get to it next week. | 19:54 |
mat128 | if we skip the 80 chars check, we can probably make a table that's reasonably easy to edit | 19:54 |
mat128 | rloo: not pushing for review, I'm on PTO for 3 weeks starting monday so take your time :) | 19:54 |
mat128 | this is just docs anyway | 19:54 |
rloo | mat128: oh, lucky you. enjoy! and yeah, i'll take my time then :) | 19:55 |
mat128 | I'd rather push for https://review.openstack.org/#/c/327891/ than anything else | 19:55 |
mat128 | rloo: ty :) | 19:55 |
rloo | mat128: i don't know about that coreos stuff, otherwise i'd review it for you. | 19:55 |
mat128 | don't worry, I'm sure tomorrow dtantsur|afk and sambetts|afk will look at it | 19:56 |
rloo | mat128: probably! :) | 19:57 |
*** vgadiraj has quit IRC | 19:57 | |
*** PollyZ has quit IRC | 20:01 | |
*** baoli has quit IRC | 20:09 | |
*** aNupoisc has quit IRC | 20:14 | |
*** baoli has joined #openstack-ironic | 20:16 | |
*** mat128 is now known as mat128|afk | 20:31 | |
*** dprince has quit IRC | 20:34 | |
*** daemontool has quit IRC | 20:36 | |
*** PollyZ has joined #openstack-ironic | 20:39 | |
*** baoli has quit IRC | 20:41 | |
*** baoli has joined #openstack-ironic | 20:41 | |
*** wajdi_ has joined #openstack-ironic | 20:42 | |
*** wajdi has quit IRC | 20:43 | |
*** wajdi_ has quit IRC | 20:43 | |
*** wajdi has joined #openstack-ironic | 20:43 | |
*** joprovost has quit IRC | 20:45 | |
*** priteau has quit IRC | 20:51 | |
*** aNupoisc has joined #openstack-ironic | 20:53 | |
*** wajdi_ has joined #openstack-ironic | 20:55 | |
*** fragatina has joined #openstack-ironic | 20:56 | |
*** wajdi has quit IRC | 20:59 | |
*** wajdi_ has quit IRC | 21:00 | |
*** sabeen has quit IRC | 21:01 | |
*** sabeen has joined #openstack-ironic | 21:02 | |
*** jaybeale has quit IRC | 21:02 | |
*** Goneri has quit IRC | 21:03 | |
*** trown is now known as trown|outtypewww | 21:04 | |
rloo | mat128|afk, jroll: found it, looks "clean": http://logs.openstack.org/97/339197/1/check/gate-ironic-python-agent-docs/147ba68/console.html | 21:04 |
jroll | \o/ | 21:04 |
rloo | jroll: although this is ugly: http://docs-draft.openstack.org/97/339197/1/check/gate-ironic-python-agent-docs/147ba68//doc/build/html/api/ironic_python_agent.hardware.html | 21:06 |
rloo | jroll: look for get_clean_steps | 21:06 |
jroll | rloo: ouch | 21:07 |
jroll | I did want to check that | 21:07 |
rloo | jroll: i think you might have to indent the '*' and then indent the line following, but i'm not sure. | 21:08 |
jroll | rloo: that's what I'm thinking, trying it out | 21:08 |
*** baoli has quit IRC | 21:09 | |
jroll | that should do it | 21:10 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic-python-agent: Fix doc warnings https://review.openstack.org/339197 | 21:10 |
jroll | good catch rloo | 21:10 |
*** priteau has joined #openstack-ironic | 21:13 | |
*** priteau has quit IRC | 21:13 | |
*** mtanino has quit IRC | 21:14 | |
*** rcernin has quit IRC | 21:17 | |
*** makowals has quit IRC | 21:21 | |
*** PollyZ has quit IRC | 21:28 | |
*** PollyZ has joined #openstack-ironic | 21:31 | |
*** ayoung has quit IRC | 21:34 | |
*** sabeen has quit IRC | 21:36 | |
*** baoli has joined #openstack-ironic | 21:42 | |
*** hparekh has quit IRC | 21:47 | |
*** rbudden has quit IRC | 21:54 | |
*** hparekh has joined #openstack-ironic | 21:59 | |
*** jaybeale has joined #openstack-ironic | 22:01 | |
mrda | Morning ironic | 22:02 |
mariojv | morning mdra | 22:03 |
mariojv | *mrda | 22:03 |
mrda | o/ | 22:04 |
*** sabeen has joined #openstack-ironic | 22:04 | |
thiagop | morning mrda | 22:06 |
* TheJulia needs to close some windows in irc... didn't realize that she had buffered pages :( | 22:09 | |
*** joprovost has joined #openstack-ironic | 22:17 | |
*** hoangcx has joined #openstack-ironic | 22:19 | |
*** sean-k-m1 has joined #openstack-ironic | 22:32 | |
*** sean-k-mooney has quit IRC | 22:34 | |
*** ChrisAusten has quit IRC | 22:36 | |
*** catintheroof has quit IRC | 22:40 | |
*** sabeen has quit IRC | 22:44 | |
*** PollyZ has quit IRC | 22:52 | |
*** PollyZ has joined #openstack-ironic | 23:01 | |
*** garthb has joined #openstack-ironic | 23:05 | |
*** jaybeale has quit IRC | 23:06 | |
*** PollyZ has quit IRC | 23:06 | |
*** amotoki has quit IRC | 23:14 | |
*** [1]cdearborn has quit IRC | 23:21 | |
*** vgadiraj has joined #openstack-ironic | 23:24 | |
*** watanabe_isao has joined #openstack-ironic | 23:35 | |
*** ayoung has joined #openstack-ironic | 23:36 | |
*** fragatina has quit IRC | 23:40 | |
rook- | hey TheJulia around by chance for a disk-hint question? | 23:40 |
*** dtantsur|afk has quit IRC | 23:43 | |
*** gfhellma has quit IRC | 23:49 | |
*** dtantsur has joined #openstack-ironic | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!