| *** hoangcx2 has quit IRC | 00:01 | |
| *** sdake_ has joined #openstack-ironic | 00:06 | |
| *** bvandewa_ has quit IRC | 00:08 | |
| *** bvandewa has joined #openstack-ironic | 00:08 | |
| *** sdake has quit IRC | 00:09 | |
| *** jabroney has quit IRC | 00:09 | |
| *** vishwanathj has joined #openstack-ironic | 00:18 | |
| *** bvandewa has quit IRC | 00:24 | |
| *** bvandewa has joined #openstack-ironic | 00:25 | |
| *** vishwanathj has quit IRC | 00:30 | |
| *** vishwanathj has joined #openstack-ironic | 00:31 | |
| *** chlong has quit IRC | 00:32 | |
| *** hoangcx has joined #openstack-ironic | 00:32 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic-specs: Bare metal node N+1 redundancy https://review.openstack.org/259320 | 00:33 |
|---|---|---|
| *** vishwanathj has quit IRC | 00:36 | |
| *** vishwanathj has joined #openstack-ironic | 00:37 | |
| *** mtanino has quit IRC | 00:37 | |
| *** amotoki has joined #openstack-ironic | 00:39 | |
| *** vishwanathj has quit IRC | 00:40 | |
| *** vishwanathj has joined #openstack-ironic | 00:41 | |
| *** vishwanathj has quit IRC | 00:41 | |
| *** rama_y has quit IRC | 00:44 | |
| *** fumie has joined #openstack-ironic | 00:45 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic-specs: iRMC OOB rescue mode support https://review.openstack.org/250648 | 00:45 |
| *** phuongnh has joined #openstack-ironic | 00:49 | |
| openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/350097 | 00:49 |
| *** ijw has quit IRC | 00:54 | |
| *** zhangjl has joined #openstack-ironic | 00:56 | |
| *** ijw has joined #openstack-ironic | 01:01 | |
| *** moshele has quit IRC | 01:05 | |
| *** ayoung has joined #openstack-ironic | 01:07 | |
| *** Sukhdev has quit IRC | 01:08 | |
| *** syed_ has quit IRC | 01:12 | |
| *** jcoufal has joined #openstack-ironic | 01:13 | |
| *** amotoki has quit IRC | 01:18 | |
| *** wajdi has joined #openstack-ironic | 01:30 | |
| openstackgerrit | Alexander Bashmakov proposed openstack/ironic: Rewrite devstack/tools/ironic/scripts/create-node.sh in Python. https://review.openstack.org/346832 | 01:42 |
| *** wlfightup has joined #openstack-ironic | 01:52 | |
| openstackgerrit | zhangyanxian proposed openstack/ironic: Fix type in cleaning.rst file https://review.openstack.org/351457 | 02:00 |
| *** sdake has joined #openstack-ironic | 02:03 | |
| openstackgerrit | Yuiko Takada Mori proposed openstack/ironic: Add node serial console installation howto https://review.openstack.org/293872 | 02:04 |
| *** sdake_ has quit IRC | 02:04 | |
| openstackgerrit | zhangyanxian proposed openstack/ironic: Fix type in cleaning.rst file https://review.openstack.org/351457 | 02:06 |
| openstackgerrit | zhangyanxian proposed openstack/ironic: Fix typo in Install-guide.rst file https://review.openstack.org/351457 | 02:06 |
| *** fragatina has joined #openstack-ironic | 02:12 | |
| *** amotoki has joined #openstack-ironic | 02:13 | |
| *** sdake_ has joined #openstack-ironic | 02:14 | |
| *** sdake has quit IRC | 02:17 | |
| *** fragatina has quit IRC | 02:27 | |
| *** daemontool_ has quit IRC | 02:31 | |
| *** amotoki has quit IRC | 02:48 | |
| *** yuanying has quit IRC | 02:49 | |
| *** joprovost has quit IRC | 03:03 | |
| *** tiendc has joined #openstack-ironic | 03:12 | |
| *** rama_y has joined #openstack-ironic | 03:13 | |
| *** amotoki has joined #openstack-ironic | 03:15 | |
| *** ayoung is now known as ayoung_ZZZzzz | 03:26 | |
| *** syed_ has joined #openstack-ironic | 03:29 | |
| *** amotoki has quit IRC | 03:31 | |
| *** sdake_ has quit IRC | 03:42 | |
| *** appu103_ has joined #openstack-ironic | 03:47 | |
| *** yuanying has joined #openstack-ironic | 03:48 | |
| *** appu103_ is now known as aparnav | 03:49 | |
| *** chlong has joined #openstack-ironic | 03:49 | |
| *** ijw has quit IRC | 03:54 | |
| openstackgerrit | Debayan Ray proposed openstack/proliantutils: Change log added for 2.1.10 release https://review.openstack.org/351481 | 03:56 |
| *** sdake has joined #openstack-ironic | 03:57 | |
| *** jcoufal has quit IRC | 04:02 | |
| *** sdake has quit IRC | 04:14 | |
| *** jabroney has joined #openstack-ironic | 04:15 | |
| *** amotoki has joined #openstack-ironic | 04:16 | |
| *** sdake has joined #openstack-ironic | 04:24 | |
| jabroney | Can someone help me fill the gap between installing ironic via packstack and using it? I see the ironic api & conductor processes. Do I install ironic-ui manually, and if so, anyone know how to find the horizon venv I need to source? | 04:27 |
| *** fragatina has joined #openstack-ironic | 04:27 | |
| *** fragatina has quit IRC | 04:31 | |
| *** Sukhdev has joined #openstack-ironic | 04:34 | |
| *** rama_y has quit IRC | 04:36 | |
| *** Sukhdev has quit IRC | 04:43 | |
| *** rama_y has joined #openstack-ironic | 04:43 | |
| *** Sukhdev has joined #openstack-ironic | 04:43 | |
| jabroney | I gave up and did a `python setup.py install` from the ironic-ui repo. | 04:44 |
| openstackgerrit | Merged openstack/proliantutils: Change log added for 2.1.10 release https://review.openstack.org/351481 | 04:56 |
| *** tiendc has quit IRC | 05:06 | |
| *** Sukhdev has quit IRC | 05:12 | |
| *** wlfightup has quit IRC | 05:13 | |
| *** rama_y has quit IRC | 05:25 | |
| *** Fdaisuke_ has joined #openstack-ironic | 05:29 | |
| *** Fdaisuke has quit IRC | 05:30 | |
| *** rcernin has joined #openstack-ironic | 05:31 | |
| *** e0ne has joined #openstack-ironic | 05:31 | |
| *** syed_ has quit IRC | 05:32 | |
| *** livelace has joined #openstack-ironic | 05:34 | |
| *** links has joined #openstack-ironic | 05:36 | |
| *** ChubYann has quit IRC | 05:55 | |
| *** ekarlso has quit IRC | 05:58 | |
| openstackgerrit | Naohiro Tamura proposed openstack/python-ironicclient: Add soft reboot/poweroff power states. https://review.openstack.org/247904 | 06:05 |
| *** tiendc has joined #openstack-ironic | 06:06 | |
| *** chlong has quit IRC | 06:08 | |
| *** mjura has joined #openstack-ironic | 06:09 | |
| *** zhangjl1 has joined #openstack-ironic | 06:19 | |
| *** zhangjl has quit IRC | 06:20 | |
| tiendc | Hi Dmitry, I want to ask you a question about Driver composition | 06:21 |
| tiendc | Hi folks, are you plan to complete Driver composition in Newton cycle? | 06:22 |
| *** hshiina has joined #openstack-ironic | 06:22 | |
| *** phuongnh has quit IRC | 06:29 | |
| *** phuongnh has joined #openstack-ironic | 06:30 | |
| *** tiendc has quit IRC | 06:32 | |
| openstackgerrit | Namrata proposed openstack/ironic: Add guru meditation report for ironic https://review.openstack.org/350736 | 06:38 |
| *** chlong has joined #openstack-ironic | 06:40 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update add nova user to baremetal_admin behaviour https://review.openstack.org/351512 | 06:40 |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Verify ironic patch https://review.openstack.org/351513 | 06:42 |
| *** jtomasek has joined #openstack-ironic | 06:44 | |
| *** e0ne has quit IRC | 06:51 | |
| *** chlong has quit IRC | 06:52 | |
| *** tiendc has joined #openstack-ironic | 07:02 | |
| *** phuongnh has quit IRC | 07:05 | |
| *** jabroney has quit IRC | 07:12 | |
| *** vishwanathj has joined #openstack-ironic | 07:15 | |
| *** vishwanathj has quit IRC | 07:15 | |
| vsaienk0 | Morning Ironic'ers dtantsur, jroll, lucasagomes, sambetts! | 07:35 |
| vsaienk0 | please review https://review.openstack.org/#/c/351512/ the patch should unblock ironicclient-functional gate job, the job passed with it https://review.openstack.org/#/c/351513/ | 07:36 |
| *** rbartal has quit IRC | 07:38 | |
| *** jpich has joined #openstack-ironic | 07:39 | |
| *** bvandewa has quit IRC | 07:39 | |
| *** bvandewa has joined #openstack-ironic | 07:46 | |
| *** dtantsur|afk is now known as dtantsur | 07:56 | |
| dtantsur | Morning Ironic | 07:56 |
| *** ohamada has joined #openstack-ironic | 07:58 | |
| dtantsur | tiendc, hi! I'm afraid the driver composition won't be finished in Newton | 07:58 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DO NOT REVIEW https://review.openstack.org/296432 | 07:59 |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-ironic | 08:00 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** openstackgerrit has joined #openstack-ironic | 08:03 | |
| dtantsur | amoralej, hi! do you still plan to work on https://review.openstack.org/339457 ? | 08:07 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 08:10 |
| *** mgoddard has joined #openstack-ironic | 08:12 | |
| dtantsur | vsaienk0, morning, LGTM | 08:13 |
| *** stendulker has joined #openstack-ironic | 08:14 | |
| *** tesseract- has joined #openstack-ironic | 08:16 | |
| *** Goneri has joined #openstack-ironic | 08:16 | |
| tiendc | dtantsur: thanks | 08:18 |
| alineb | morning all | 08:19 |
| *** bvandewa has quit IRC | 08:19 | |
| dtantsur | morning alineb | 08:22 |
| *** Romanenko_K has joined #openstack-ironic | 08:26 | |
| *** lucas|dinner is now known as lucasagomes | 08:28 | |
| *** bvandewa has joined #openstack-ironic | 08:29 | |
| *** hshiina has quit IRC | 08:30 | |
| pas-ha | morning Ironic | 08:32 |
| *** d0ugal has quit IRC | 08:32 | |
| vsaienk0 | Mroning pas-ha, alineb, tiendc | 08:33 |
| *** d0ugal has joined #openstack-ironic | 08:33 | |
| *** d0ugal has quit IRC | 08:33 | |
| *** d0ugal has joined #openstack-ironic | 08:33 | |
| *** d0ugal has quit IRC | 08:33 | |
| *** d0ugal has joined #openstack-ironic | 08:33 | |
| *** bvandewa has quit IRC | 08:33 | |
| tiendc | Morming vsaienk0, pas-ha, alineb | 08:34 |
| *** bvandewa has joined #openstack-ironic | 08:34 | |
| *** Fdaisuke has joined #openstack-ironic | 08:35 | |
| *** Fdaisuke_ has quit IRC | 08:37 | |
| *** sdake has quit IRC | 08:37 | |
| lucasagomes | morning all | 08:39 |
| *** moshele has joined #openstack-ironic | 08:46 | |
| vdrok | good morning ironic, dtantsur vsaienk0 alineb pas-ha and lucasagomes | 08:48 |
| Romanenko_K | hi! | 08:50 |
| *** moshele has quit IRC | 08:53 | |
| *** aarefiev_ has joined #openstack-ironic | 09:11 | |
| *** e0ne has joined #openstack-ironic | 09:14 | |
| *** Goneri has quit IRC | 09:15 | |
| sambetts|afk | Morning all o/ | 09:15 |
| *** sambetts|afk is now known as sambetts | 09:15 | |
| *** Goneri has joined #openstack-ironic | 09:18 | |
| dtantsur | morning pas-ha, lucasagomes, vdrok, Romanenko_K, sambetts | 09:33 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Collect deployment logs from IPA https://review.openstack.org/336102 | 09:34 |
| lucasagomes | hi there | 09:34 |
| *** vmud213 has joined #openstack-ironic | 09:35 | |
| jroll | morning y'all, happy friday | 09:35 |
| sambetts | o/ jroll,lucasagomes,dtantsur TGIF | 09:35 |
| dtantsur | oh yeah, TGIF | 09:35 |
| dtantsur | and morning jroll | 09:35 |
| lucasagomes | o/ yup, TGIF indeed | 09:35 |
| dtantsur | so, let's continue the agent API fun :) | 09:36 |
| jroll | heh | 09:36 |
| *** mgould|afk is now known as mgould | 09:40 | |
| mgould | morning Ironic! | 09:40 |
| mgould | morning lucasagomes sambetts jroll dtantsur Romanenko_K pas-ha alineb tiendc | 09:41 |
| dtantsur | morning mgould | 09:41 |
| lucasagomes | hi there | 09:41 |
| *** amoralej is now known as amoralej|brb | 09:46 | |
| vmud213 | morning lucasagomes, dtantsur, sambetts, jroll, mgould and everyone else | 09:46 |
| vdrok | morning Romanenko_K sambetts jroll mgould and vmud213 ! | 09:46 |
| vmud213 | morning vdrok | 09:47 |
| mgould | morning vmud213 | 09:48 |
| jroll | dtantsur: lucasagomes: vdrok: vsaienk0: sambetts: I'm hoping to release 6.1.0 next week, I'd like to get the agent APIs in there, is there anything else that's close that you all can make it? | 09:51 |
| dtantsur | jroll, metrics, if we have anything to finish | 09:52 |
| jroll | dtantsur: also, sorry for breaking your release note :( | 09:52 |
| dtantsur | jroll, heh, no worries :) | 09:52 |
| jroll | oh, metrics++ | 09:52 |
| dtantsur | jroll, I would actually love notifications too, but i'm not sure how close it is | 09:52 |
| jroll | dtantsur: the code is there, it hasn't had much review love | 09:53 |
| dtantsur | jroll, let's finish the agent API and see if we can push it | 09:53 |
| jroll | https://review.openstack.org/#/q/topic:bug/1526408 | 09:53 |
| jroll | oh, and failing CI :( | 09:53 |
| jroll | needs a rebase | 09:53 |
| dtantsur | yeah, merge conflict | 09:53 |
| dtantsur | I think the folks are updating it pretty often, it just conflicts with everything :) | 09:53 |
| vdrok | base classes for notifications looked good, haven't looked at the second patch yet | 09:53 |
| *** bvandewa has quit IRC | 09:54 | |
| vdrok | nothing more from me :) | 09:54 |
| jroll | dtantsur: yeah, mariojv is pretty good about it | 09:54 |
| jroll | dtantsur: the notifications spec just has power state, yuriy has an rfe for more (the rest?), any problem with approving that? https://bugs.launchpad.net/ironic/+bug/1606520 | 09:55 |
| openstack | Launchpad bug 1606520 in Ironic "[RFE] Add resources CRUD notifications to Ironic" [Undecided,In progress] - Assigned to Yuriy Zveryanskyy (yzveryanskyy) | 09:55 |
| dtantsur | jroll, lemme check | 09:55 |
| jroll | I'm okay with it, I don't think it needs much detail | 09:55 |
| dtantsur | jroll, if we're fine with bikeshedding on the exact format on the patches - I'm all for it | 09:55 |
| jroll | oh wait, there's a spec https://review.openstack.org/#/c/347242/ | 09:56 |
| jroll | I think the original spec has the format | 09:56 |
| * jroll leaves it alone because the spec is open | 09:56 | |
| dtantsur | I would love notifications for provision states.. and I'm not sure if we need a spec for every notification we plan to issue | 09:57 |
| lucasagomes | jroll, the collect logs is pretty close too | 09:58 |
| lucasagomes | I've just updated the release notes according to JayF's comments yesterday | 09:58 |
| jroll | lucasagomes: okay, I'll add it to my list | 09:58 |
| lucasagomes | thanks a lot | 09:58 |
| jroll | dtantsur: this spec covers provision states, maintenance, create/update/delete... I think it's everything :) | 09:58 |
| lucasagomes | and +1 for a release next week | 09:58 |
| lucasagomes | after the policies and all, much needed :D | 09:59 |
| jroll | indeed \o/ | 09:59 |
| jroll | so much good stuff in this one | 09:59 |
| lucasagomes | yeah ! | 09:59 |
| dtantsur | oh true | 10:00 |
| * dtantsur is very sad for the driver composition though | 10:00 | |
| *** jcoufal has joined #openstack-ironic | 10:00 | |
| jroll | dtantsur: we made it through a cycle and still have an architecture, that's an improvement :P | 10:01 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Promote agent vendor passthru to core API https://review.openstack.org/330018 | 10:01 |
| dtantsur | jroll, ^^^ | 10:01 |
| jroll | really though, I know we can get it done in ocata | 10:01 |
| dtantsur | yeah | 10:01 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent: Use new agent API if available https://review.openstack.org/334523 | 10:03 |
| dtantsur | typo fixed ^^^ | 10:03 |
| jroll | woo | 10:03 |
| * dtantsur updates the deprecation patch now | 10:03 | |
| *** amoralej|brb is now known as amoralej | 10:06 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Officially deprecate agent passthru classes and API https://review.openstack.org/336547 | 10:08 |
| *** hoangcx has quit IRC | 10:09 | |
| zhangjl1 | hi all, i found mistakes in ironic installation guide doc, and reported a bug https://bugs.launchpad.net/ironic/+bug/1608916. | 10:10 |
| openstack | Launchpad bug 1608916 in Ironic "Installation Guide doc code is out of date" [Undecided,Incomplete] - Assigned to zhangjialong (zhangjl) | 10:10 |
| jroll | dtantsur: just one little thing | 10:11 |
| dtantsur | jroll, I'm not sure it's worth optimizing for, to be honest | 10:11 |
| zhangjl1 | and the patch is here https://review.openstack.org/#/c/350340/ | 10:11 |
| jroll | dtantsur: worth a unit test, though? | 10:11 |
| dtantsur | also it's not NotFound, it's BadRequest, if we really do it | 10:11 |
| zhangjl1 | pls review it, thanks | 10:12 |
| jroll | dtantsur: ah, even better reason to do it, no? | 10:12 |
| dtantsur | jroll, ack | 10:12 |
| jroll | thanks | 10:12 |
| jroll | I'm +2 with that change | 10:12 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Introducing node introspection state management https://review.openstack.org/348943 | 10:14 |
| milan | morning Ironic! :) | 10:14 |
| milan | morning aarefiev, dtantsur, jroll lucasagomes sambetts vdrok zhangjl1 :) | 10:16 |
| milan | and all | 10:16 |
| milan | ;) | 10:16 |
| jroll | hey milan \o | 10:16 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Deny some driver_info updates when console is on https://review.openstack.org/330003 | 10:16 |
| mgould | morning milan! | 10:16 |
| milan | morning mgould :) | 10:16 |
| zhangjl1 | hey milan | 10:17 |
| milan | o/ :) | 10:17 |
| lucasagomes | hi milan | 10:17 |
| dtantsur | morning milan | 10:17 |
| milan | morning :) | 10:17 |
| * milan about to lift the WIP on ^^^ let the discussions begin ;) | 10:18 | |
| *** tiendc has quit IRC | 10:20 | |
| vdrok | good morning milan :) | 10:20 |
| milan | morning vdrok :) | 10:20 |
| openstackgerrit | Merged openstack/ironic: Update add nova user to baremetal_admin behaviour https://review.openstack.org/351512 | 10:28 |
| *** Goneri has quit IRC | 10:29 | |
| dtantsur | recheck all the things ^^^ | 10:31 |
| *** Goneri has joined #openstack-ironic | 10:31 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Promote agent vendor passthru to core API https://review.openstack.org/330018 | 10:31 |
| dtantsur | jroll, ^^^ | 10:31 |
| jroll | ty | 10:32 |
| *** Fdaisuke has quit IRC | 10:33 | |
| jroll | dtantsur: one thing on the deprecation patch as well | 10:38 |
| openstackgerrit | zhangjl proposed openstack/ironic: Fix the mistakes in Installation Guide doc https://review.openstack.org/350340 | 10:41 |
| *** amotoki has quit IRC | 10:44 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Officially deprecate agent passthru classes and API https://review.openstack.org/336547 | 10:46 |
| dtantsur | jroll, ^^^ | 10:46 |
| jroll | ty | 10:47 |
| jroll | dtantsur: oh, I meant a deprecation warning message | 10:47 |
| dtantsur | jroll, see my comments | 10:48 |
| dtantsur | I'm not sure we want ironic to always show a deprecation message which operators can't act on | 10:48 |
| dtantsur | because we're using the deprecated code outselves | 10:48 |
| dtantsur | * ourselves even | 10:48 |
| jroll | dtantsur: oops | 10:48 |
| jroll | good point, thanks | 10:49 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Use devstack test-config phase https://review.openstack.org/351650 | 10:52 |
| dtantsur | jroll, one +2 on the multi-compute patch, great job :) | 10:55 |
| jroll | dtantsur: indeed, thanks! :) | 10:56 |
| *** jcoufal has quit IRC | 11:01 | |
| *** stendulker has quit IRC | 11:04 | |
| TheJulia | Good morning | 11:08 |
| *** lucasagomes is now known as lucas-hungry | 11:11 | |
| dtantsur | morning TheJulia | 11:13 |
| mgould | morning TheJulia | 11:21 |
| vdrok | morning TheJulia | 11:27 |
| *** moshele has joined #openstack-ironic | 11:29 | |
| moshele | vdrok: cab you review the infiniband patches https://review.openstack.org/#/c/264263/ and https://review.openstack.org/#/c/264257/ | 11:31 |
| vdrok | moshele: I promise to do today :) | 11:36 |
| vdrok | dtantsur: jroll just found out that there actually is a standard deprecation logging - https://github.com/openstack/oslo.log/blob/master/oslo_log/versionutils.py | 11:36 |
| jroll | vdrok: neat! | 11:37 |
| dtantsur | cool | 11:39 |
| dtantsur | not sure if I want to put one more revision to my patches though.. | 11:39 |
| jroll | no, let's just keep it in mind in the future | 11:40 |
| vdrok | yeah, that's just a nice thing to cleanup, we were bikeshedding this stuff in some places | 11:41 |
| *** tangchen_ has quit IRC | 11:42 | |
| *** zhangjl1 has quit IRC | 11:45 | |
| *** vmud213 has quit IRC | 11:46 | |
| *** bfournie has quit IRC | 11:55 | |
| openstackgerrit | Gleb Stepanov proposed openstack/ironic: Check keyword arguments https://review.openstack.org/351677 | 11:56 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Remove oslo-incubator references https://review.openstack.org/351678 | 11:57 |
| jroll | easy cleanup there | 11:57 |
| *** Goneri has quit IRC | 12:03 | |
| *** aparnav has quit IRC | 12:04 | |
| *** amoralej is now known as amoralej|lunch | 12:09 | |
| *** baoli has joined #openstack-ironic | 12:11 | |
| *** alaski is now known as lascii | 12:12 | |
| *** baoli_ has joined #openstack-ironic | 12:12 | |
| *** dprince has joined #openstack-ironic | 12:13 | |
| *** Goneri has joined #openstack-ironic | 12:14 | |
| *** mkoderer_ has joined #openstack-ironic | 12:15 | |
| *** baoli has quit IRC | 12:16 | |
| *** mkoderer has quit IRC | 12:18 | |
| *** MattMan has quit IRC | 12:19 | |
| *** MattMan has joined #openstack-ironic | 12:20 | |
| dtantsur | sambetts, does LLDP collection work with tinyipa? | 12:20 |
| * dtantsur got some hardware and wants to try it | 12:20 | |
| *** lucas-hungry is now known as lucasagomes | 12:24 | |
| *** amotoki has joined #openstack-ironic | 12:25 | |
| sambetts | dtantsur: it should do, there aren't any external dependecies, it just uses python + sockets | 12:25 |
| sambetts | dtantsur: I think my last test used tinyipa | 12:25 |
| dtantsur | hmm, I didn't receive any LLDP data, I wonder what went wrong | 12:27 |
| sambetts | dtantsur: did you enable it in the kernal params? | 12:27 |
| dtantsur | apparently, lemme check if I remembered the param name correctly | 12:27 |
| dtantsur | sambetts, OUCH! http://tarballs.openstack.org/ironic-python-agent/tinyipa/files/ are from 14 July, they might not have the change yet | 12:28 |
| sambetts | dtantsur: if the POST job not working?! | 12:28 |
| sambetts | is* | 12:28 |
| dtantsur | jroll, ^^^ | 12:28 |
| dtantsur | wait, is it June 14 even? | 12:29 |
| *** zhangjl has joined #openstack-ironic | 12:29 | |
| sambetts | oh god has the POST job blown up again | 12:29 |
| jroll | must be friday :/ | 12:29 |
| *** amotoki has quit IRC | 12:29 | |
| dtantsur | I wonder how we can make these post jobs visible | 12:30 |
| jroll | last one is http://logs.openstack.org/27/277d97ba2b27fdd193b8daf91b375241d4f2c385/ | 12:30 |
| jroll | fyi https://pypi.python.org/pypi/git-os-job is super handy | 12:31 |
| jroll | looks like it worked... http://logs.openstack.org/27/277d97ba2b27fdd193b8daf91b375241d4f2c385/post/ironic-python-agent-buildimage-tinyipa/1ce0376/console.html | 12:31 |
| sambetts | dtantsur, jroll: that seems sucessful | 12:31 |
| dtantsur | wut? | 12:31 |
| jroll | weird | 12:32 |
| * jroll pokes infra | 12:32 | |
| sambetts | maybe the upload thing isn't working :/ | 12:32 |
| jroll | coreos is uploading fine | 12:32 |
| sambetts | wut... | 12:32 |
| sambetts | its using the same code ... | 12:33 |
| dtantsur | yeah, I'll try with the coreos image for now | 12:33 |
| * dtantsur is not sure if it supports LLDP though | 12:33 | |
| *** joprovost has joined #openstack-ironic | 12:33 | |
| *** tangchen has quit IRC | 12:33 | |
| dtantsur | jroll, unrelated: do you think we can fit https://review.openstack.org/#/c/336102/ in 6.1 as well? I've been dreaming of it since forever.. | 12:34 |
| *** mjura has quit IRC | 12:34 | |
| sambetts | dtantsur: LLDP code merged Jun 22 | 12:34 |
| dtantsur | yeah, I see | 12:35 |
| jroll | dtantsur: I hope so, lucas asked me to put it on the list | 12:35 |
| dtantsur | cool, I second his request :) | 12:36 |
| jroll | sambetts: http://logs.openstack.org/27/277d97ba2b27fdd193b8daf91b375241d4f2c385/post/ironic-python-agent-buildimage-tinyipa/1ce0376/_zuul_ansible/ansible_log.txt | 12:36 |
| jroll | I need to step away for a bit, but will check back soon | 12:38 |
| *** joprovost has quit IRC | 12:41 | |
| openstackgerrit | Merged openstack/python-ironicclient: Remove discover from test-requirements https://review.openstack.org/345443 | 12:43 |
| dtantsur | w00t, raw LLDP data \o/ (with coreos image) | 12:47 |
| *** amotoki has joined #openstack-ironic | 12:47 | |
| sambetts | \o/ | 12:47 |
| *** Goneri has quit IRC | 12:48 | |
| openstackgerrit | Gleb Stepanov proposed openstack/ironic: Fix typo https://review.openstack.org/351731 | 12:50 |
| mat128 | good (late) morning, Ironicers! | 12:50 |
| mat128 | dtantsur, sambetts: did you guys solve the mystery around TinyIPA not being uploaded to tarballs.o.o? | 12:51 |
| sambetts | just trying to work it out now | 12:51 |
| sambetts | the build goes through fine but the command to upload it to the tarballs site works fine for coreos but freaks out when it gets to tinyipa.. | 12:51 |
| milan | morning mat128 :) | 12:52 |
| *** jcoufal has joined #openstack-ironic | 12:52 | |
| *** amotoki has quit IRC | 12:52 | |
| *** ccamacho is now known as ccamacho|lunch | 12:53 | |
| *** catintheroof has quit IRC | 12:53 | |
| mat128 | sambetts: it seems like UPLOAD_RAW and UPLOAD_TAR are magic directories that get uploaded? | 12:55 |
| dtantsur | sambetts, do you think it make sense to have an inspector plugin converting TLVs to a human-readable form? | 12:55 |
| sambetts | mat128: https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/ironic-python-agent-jobs.yaml#L30 | 12:55 |
| sambetts | mat128: we define them and define how they get uploaded | 12:56 |
| sambetts | dtantsur: for logging? | 12:56 |
| mat128 | sambetts: the publisher (scp) part doesnt seem to happen | 12:56 |
| openstackgerrit | Gleb Stepanov proposed openstack/ironic: Fix typo https://review.openstack.org/351731 | 12:56 |
| sambetts | mat128: it happens in ansible now | 12:56 |
| sambetts | mat128: http://logs.openstack.org/27/277d97ba2b27fdd193b8daf91b375241d4f2c385/post/ironic-python-agent-buildimage-coreos/2c32993/_zuul_ansible/ansible_log.txt | 12:56 |
| sambetts | thats the coreos one ^ | 12:56 |
| sambetts | http://logs.openstack.org/27/277d97ba2b27fdd193b8daf91b375241d4f2c385/post/ironic-python-agent-buildimage-tinyipa/1ce0376/_zuul_ansible/ansible_log.txt | 12:56 |
| sambetts | thats the tinycore one ^ | 12:56 |
| dtantsur | sambetts, dunno, just thinking allow. I know that our downstream collector used to produce human-readable forms, but I'm quite unsure if it's actually useful for further processing | 12:57 |
| mat128 | sambetts: http://logs.openstack.org/27/277d97ba2b27fdd193b8daf91b375241d4f2c385/post/ironic-python-agent-buildimage-tinyipa/1ce0376/_zuul_ansible/ansible_log.txt | 12:57 |
| mat128 | doh | 12:57 |
| sambetts | hehe | 12:57 |
| sambetts | dtantsur: not sure what we'd use it for? | 12:57 |
| dtantsur | mmmmmmm | 12:58 |
| * dtantsur has no idea :) | 12:58 | |
| mat128 | sambetts: I think the include/exclude options arent exactly right | 12:58 |
| mat128 | sambetts: it finds some of our mounted stuff that disappears and crashes | 12:58 |
| sambetts | yeah, it seems to be trying to upload the tinyipafinal dir | 12:58 |
| sambetts | for some reason | 12:58 |
| mat128 | sambetts: or maybe thats in the evaluation phase | 12:58 |
| dtantsur | sambetts, ah, remembered. our folks want to display network configuration in the UI. | 12:58 |
| dtantsur | not sure which form would work better for them though.. | 12:58 |
| sambetts | dtantsur: oh I see, so we'd need to dump it into the Ironic node somewhere then? | 12:59 |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add classes for Portgroups API enablement https://review.openstack.org/347549 | 12:59 |
| dtantsur | sambetts, not necessary, they can take it from stored data | 12:59 |
| * dtantsur looks for a link | 12:59 | |
| sambetts | dtantsur: oh true | 12:59 |
| mat128 | sambetts: I guess one way is ensuring all our umount stuff is done (and completed) before exiting, so rsync doesnt crash on them disappearing | 13:00 |
| dtantsur | sambetts, aha, this seems to be public: https://bugzilla.redhat.com/show_bug.cgi?id=1266597 | 13:00 |
| openstack | bugzilla.redhat.com bug 1266597 in openstack-ironic-discoverd "[RFE] Utility to Extract Network Introspection Data" [Medium,New] - Assigned to rhos-maint | 13:00 |
| sambetts | mat128: it should all be umounted in the finalise part of the build | 13:00 |
| mat128 | sambetts: but it sees /dev/fd/3 disappearing | 13:01 |
| mat128 | sambetts: maybe thats just a warning | 13:01 |
| mat128 | last one looks important tho | 13:01 |
| sambetts | mat128: we don't even mount /dev into the build dir | 13:01 |
| mat128 | sambetts: fd/3 is just a file descriptor | 13:01 |
| mat128 | could be an open file or smt | 13:01 |
| mat128 | sambetts: rsync: opendir \"/home/jenkins/workspace/ironic-python-agent-buildimage-tinyipa/imagebuild/tinyipa/tinyipabuild/root/.cache\" failed: Permission denied | 13:01 |
| sambetts | mat128: it shouldn't even be looking at that directory though | 13:02 |
| mat128 | sambetts: I have already had "directory has vanished" errors in a home rsync / backup job, rsync kept going | 13:02 |
| mat128 | sambetts: but I think it does because of the --include="*/" --exclude="*\" | 13:02 |
| mat128 | even though that gives a net result of 0, rsync tries to evaluate the files (I think) | 13:02 |
| mat128 | I,ll try it real quick | 13:02 |
| *** Goneri has joined #openstack-ironic | 13:03 | |
| sambetts | seems a little backward :/ we add the --include=/UPLOAD_TAR/* for a reason | 13:03 |
| sambetts | oh I see... | 13:04 |
| sambetts | rsync will search inside directorys looking for things that match UPLOAD_TAR... ffs... | 13:05 |
| *** catintheroof has joined #openstack-ironic | 13:05 | |
| sambetts | mat128: perhaps we should make it run make clean before trying the upload | 13:06 |
| mat128 | wouldn't make clean delete our binaries? | 13:06 |
| openstackgerrit | Gleb Stepanov proposed openstack/ironic: Fix typo https://review.openstack.org/351731 | 13:06 |
| sambetts | no if we've already mv'd them to somewhere else | 13:06 |
| mat128 | I guess we can try that | 13:06 |
| sambetts | e.g. UPLOAD and UPLOAD_RAW | 13:06 |
| mat128 | but debugging POST jobs are a shot in the dark | 13:06 |
| mat128 | yeah | 13:06 |
| sambetts | yeah :'( | 13:06 |
| mat128 | what are the permissions on .cache? | 13:07 |
| sambetts | its in /root so I assume probably root read only | 13:07 |
| *** foexle has joined #openstack-ironic | 13:07 | |
| mat128 | ahh | 13:08 |
| mat128 | thats in the chroot | 13:08 |
| sambetts | right | 13:08 |
| sambetts | it shoudln't be reading that dir at all | 13:08 |
| mat128 | same for /dev/fd/3 | 13:08 |
| mat128 | well we can use workarounds, but probably that scp-publisher => rsync command conversion isn't totally right | 13:09 |
| sambetts | yeah it was working until ~Jun 6th, but I don't know what repo contains the logic to generate this stuff | 13:09 |
| mat128 | I think https://github.com/openstack-infra/zuul | 13:11 |
| mat128 | trying to dig up the exact command | 13:11 |
| sambetts | https://github.com/openstack-infra/zuul/blame/176431ec1488fbde93c953972f639b8a31d173c8/zuul/launcher/ansiblelaunchserver.py#L927 | 13:11 |
| sambetts | mat128: ^ | 13:11 |
| *** sdake has joined #openstack-ironic | 13:11 | |
| mat128 | sambetts: the comment explains it | 13:12 |
| sambetts | yup | 13:12 |
| sambetts | the search as deep as possble thing | 13:13 |
| mat128 | "include any directories (so that we continue to search for the thing we want no matter how deep it is" | 13:13 |
| mat128 | yes | 13:13 |
| sambetts | maybe we need to make an upload dir under /tmp, that only has UPLOAD_RAW and UPLOAD_TAR under it | 13:14 |
| *** mkoderer has joined #openstack-ironic | 13:14 | |
| sambetts | then point the scp thing at that that directory so that its completly separated from the BUILD_DIR | 13:14 |
| *** mkoderer_ has quit IRC | 13:17 | |
| *** amoralej|lunch is now known as amoralej | 13:20 | |
| *** mtanino has joined #openstack-ironic | 13:21 | |
| fxpester | guys is there graphic map about openstack bridges + brbm bridge ? | 13:22 |
| fxpester | trying to understand it... | 13:22 |
| sambetts | brbm bridge is something we create in our devstack plugin as a hack to use VMs as simulated baremetal nodes | 13:23 |
| sambetts | mat128: I have no idea what directory they run that rsync command from :/ | 13:25 |
| mat128 | sambetts: the comment suggests it's the workspace root | 13:25 |
| mat128 | sambetts: but I'm not able to verify it | 13:25 |
| TheJulia | fxpester: Have you looked at the `ovs-vsctl show` output and/or the neutron networking diagrams? | 13:26 |
| fxpester | sambetts: brbm is used only to generate mac addreses ? | 13:26 |
| mat128 | sambetts: maybe there's a cwd parameter to the ansible exec command? | 13:26 |
| TheJulia | fxpester: brbm serves as a virtual switch, kind of like a vlan that the VMs can attach to locally for testing | 13:26 |
| mat128 | sambetts: https://github.com/openstack-infra/zuul/blame/176431ec1488fbde93c953972f639b8a31d173c8/zuul/launcher/ansiblelaunchserver.py#L970 | 13:26 |
| fxpester | TheJulia: so Its just plugged to br-ex ? | 13:27 |
| TheJulia | https://git.openstack.org/cgit/openstack/ironic/tree/devstack/tools/ironic/scripts/setup-network.sh | 13:28 |
| fxpester | TheJulia: thx | 13:29 |
| TheJulia | Not even that really see: https://git.openstack.org/cgit/openstack/ironic/tree/devstack/tools/ironic/templates/brbm.xml | 13:29 |
| sambetts | mat128: fuuuuu, I think that means that I can't move things to /tmp and then read the files from there :/ | 13:31 |
| sambetts | because /tmp isn't under the workspace dir | 13:32 |
| sambetts | :/ | 13:32 |
| *** wajdi has quit IRC | 13:32 | |
| openstackgerrit | Merged openstack/bifrost: Fix some spelling mistakes https://review.openstack.org/350981 | 13:32 |
| sambetts | or even if it can read the files from /tmp it'll still derp on reading the chroot dir | 13:32 |
| sambetts | looking for other matching files | 13:33 |
| *** ccamacho|lunch is now known as ccamacho | 13:33 | |
| sambetts | mat128: I think the best bet is to run make clean and get rid of the chroot before rsync tries to read it | 13:33 |
| mat128 | sambetts: Agreed | 13:37 |
| *** mat128 is now known as mat128|away | 13:37 | |
| mat128|away | off to the office | 13:37 |
| mat128|away | ttyl sam | 13:37 |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add portgroups to support LAG interfaces - API https://review.openstack.org/332177 | 13:38 |
| sambetts | cya in a bit mat128|away | 13:38 |
| *** joprovost has joined #openstack-ironic | 13:40 | |
| *** moshele has quit IRC | 13:40 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Collect deployment logs from IPA https://review.openstack.org/336102 | 13:41 |
| *** ametts has joined #openstack-ironic | 13:42 | |
| sambetts | mat128|away: https://review.openstack.org/#/c/351742/ | 13:47 |
| *** krtaylor has quit IRC | 13:48 | |
| lazy_prince | lucasagomes: Regarding "Collect deployment logs from IPA", when they will be pushed into swift, will a link for it be associated to the node.. | 13:50 |
| *** krtaylor has joined #openstack-ironic | 13:50 | |
| lazy_prince | so if the deployment fails and I want to take a look at the logs, how do I access it is what I want to know.. | 13:50 |
| *** M4g1c5t0rM has quit IRC | 13:53 | |
| *** amotoki has joined #openstack-ironic | 13:57 | |
| *** joprovost1 has joined #openstack-ironic | 13:57 | |
| *** joprovost has quit IRC | 13:59 | |
| *** joprovost1 is now known as joprovost | 13:59 | |
| *** catintheroof has quit IRC | 14:00 | |
| *** anush_ has joined #openstack-ironic | 14:00 | |
| *** mgoddard_ has joined #openstack-ironic | 14:01 | |
| lucasagomes | lazy_prince, no because a node could contain many logs (in case of "always" collecting the logs on success and errors) | 14:02 |
| lucasagomes | lazy_prince, so the name in the swift will contain the node uuid | 14:02 |
| lucasagomes | so you can just list and grep by the node uuid | 14:02 |
| *** foexle has quit IRC | 14:03 | |
| *** openstackgerrit has quit IRC | 14:03 | |
| lazy_prince | aha.. and if there are multiple deployment failures for the same node, they will be overwritten.. right.. | 14:03 |
| lucasagomes | lazy_prince, e.g swift list ironic_deploy_logs_container -p 5e9258c4-cfda-40b6-86e2-e192f523d668 | 14:03 |
| lucasagomes | that will list all the logs for the node 5e9258c4-cfda-40b6-86e2-e192f523d668 | 14:03 |
| *** openstackgerrit has joined #openstack-ironic | 14:03 | |
| *** mgoddard has quit IRC | 14:05 | |
| *** e0ne has quit IRC | 14:05 | |
| *** jvgrant_ has joined #openstack-ironic | 14:05 | |
| lazy_prince | another thing is, is there any plan to integrate this with ceph or do we want to have it limited to swift and local..? | 14:05 |
| *** e0ne has joined #openstack-ironic | 14:05 | |
| *** zhangjl has quit IRC | 14:07 | |
| *** catintheroof has joined #openstack-ironic | 14:07 | |
| lucasagomes | lazy_prince, you can use ceph as a storage device for swift right? | 14:08 |
| *** mkoderer has quit IRC | 14:08 | |
| lucasagomes | lazy_prince, I don't have any plans to store it in ceph directly, but if someone is willing to do it that's completely fine | 14:08 |
| lazy_prince | i may have only ceph but no swift.. | 14:08 |
| lucasagomes | local, swift, ... <whatever> | 14:09 |
| jroll | sambetts: wow, nice find | 14:09 |
| *** M4g1c5t0rM has joined #openstack-ironic | 14:09 | |
| lucasagomes | lazy_prince, right yeah, we could totally have that if someone wants to work on it | 14:09 |
| lazy_prince | okay.. I will wait for it to merge first... | 14:11 |
| lazy_prince | :) | 14:11 |
| *** PollyZ has joined #openstack-ironic | 14:11 | |
| lazy_prince | so coming back to multiple deployment failures, are you planning to store only last deployment failure..? | 14:12 |
| lucasagomes | lazy_prince, I was thinking of storing all of it | 14:16 |
| *** mkoderer has joined #openstack-ironic | 14:17 | |
| lucasagomes | if you use swift for example you can configure how many days we should keep that logs | 14:17 |
| lucasagomes | so it shouldn't be a big deal | 14:17 |
| lazy_prince | hmm... so you mean, for a node, if the deployment failed an hour back and a deployment fails now, they will get appended to the same object store..? or overwritten.. | 14:18 |
| lazy_prince | I am sorry.. not well versed with swift.. | 14:19 |
| lucasagomes | lazy_prince, oh no, a new file will be created and stored | 14:19 |
| lucasagomes | all files contains a timestamp of when the logs where generated as well | 14:19 |
| lucasagomes | lazy_prince, no worries, I'm not either | 14:19 |
| lucasagomes | lazy_prince, this may help: http://specs.openstack.org/openstack/ironic-specs/specs/approved/collect-system-logs-from-ipa.html#changes-in-ipa | 14:19 |
| lucasagomes | sorry, I mean: http://specs.openstack.org/openstack/ironic-specs/specs/approved/collect-system-logs-from-ipa.html#proposed-change | 14:20 |
| * lazy_prince checking.. | 14:20 | |
| *** cdearborn has joined #openstack-ironic | 14:21 | |
| sambetts | jroll: https://review.openstack.org/#/c/351742/ | 14:21 |
| *** syed_ has joined #openstack-ironic | 14:21 | |
| sambetts | if you hadn't seen | 14:21 |
| lazy_prince | aha.. so there is a instance_id and timestamp associated to the logs.. now i get it.. | 14:21 |
| jroll | sambetts: I did but forgot to +1 | 14:22 |
| jroll | thanks | 14:22 |
| lucasagomes | lazy_prince, yeah :-) | 14:23 |
| openstackgerrit | Akilan Pughazhendi proposed openstack/ironic: Updated Dev quickstart for viewing doc changes https://review.openstack.org/350705 | 14:24 |
| *** daemontool has joined #openstack-ironic | 14:26 | |
| *** vishwanathj has joined #openstack-ironic | 14:31 | |
| *** michauds has joined #openstack-ironic | 14:31 | |
| jroll | devananda: when you're in, please review dmitry's agent API chain: https://review.openstack.org/#/q/status:open+topic:bug/1570841 | 14:32 |
| jroll | I'm out for the rest of the day, may hit some reviews later | 14:32 |
| jroll | have a good weekend all :) | 14:32 |
| TheJulia | Have a good weekend jroll | 14:33 |
| *** Goneri has quit IRC | 14:36 | |
| *** joprovost has quit IRC | 14:41 | |
| *** e0ne has quit IRC | 14:42 | |
| *** ayoung_ZZZzzz is now known as ayoung | 14:42 | |
| sambetts | o/ jroll | 14:43 |
| lucasagomes | jroll, see ya, have a great weekend | 14:43 |
| *** fragatina has joined #openstack-ironic | 14:46 | |
| *** joprovost has joined #openstack-ironic | 14:47 | |
| *** fragatin_ has joined #openstack-ironic | 14:48 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Introducing node introspection state management https://review.openstack.org/348943 | 14:49 |
| *** mkoderer_ has joined #openstack-ironic | 14:51 | |
| *** fragatina has quit IRC | 14:51 | |
| jlvillal | Good morning all | 14:52 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add openstack baremetal driver commands https://review.openstack.org/350050 | 14:52 |
| jlvillal | vsaienk0: Thanks for the correct fix for the python-ironicclient gate issue :) | 14:52 |
| *** nicodemos has quit IRC | 14:54 | |
| *** mkoderer has quit IRC | 14:54 | |
| *** nicodemos has joined #openstack-ironic | 14:54 | |
| *** clenimar has quit IRC | 14:54 | |
| *** clenimar has joined #openstack-ironic | 14:55 | |
| milan | morning jlvillal :) | 14:56 |
| jlvillal | Morning milan :) | 14:56 |
| *** hoonetorg has quit IRC | 14:57 | |
| dtantsur | morning jlvillal | 14:59 |
| jlvillal | dtantsur: Hello and have a great weekend! If I don't notice you signing off later :) | 15:00 |
| dtantsur | hey, I'm around for some more time, but essentially you're right: I'm in a weekend mode already | 15:01 |
| jlvillal | heh. I want to be, but I just started my work day :) | 15:02 |
| dtantsur | I can imagine :) | 15:02 |
| mgould | morning jlvillal | 15:02 |
| mgould | I can confirm that "bonny" means "beautiful, pretty, handsome" in Scotland, BTW :-) | 15:02 |
| jlvillal | Hey mgould. We were discussing 'bonnie' yesterday. I thought it might be a word used in Scotland. At least more than the US :) | 15:03 |
| jlvillal | heh, I was still typing | 15:03 |
| mgould | not all that widely used these days, I think, but universally understood | 15:03 |
| mgould | https://en.wikipedia.org/wiki/The_Bonnie_Banks_o%27_Loch_Lomond | 15:03 |
| jlvillal | mgould: I had never heard of that before. Thanks. | 15:04 |
| *** d0ugal has quit IRC | 15:05 | |
| milan | dtantsur, I could use a +1 on the state patch, since you're in the weekend mode ;) | 15:05 |
| *** clenimar_ has joined #openstack-ironic | 15:05 | |
| dtantsur | milan, I'd prefer to do +2/-1 (-2?) on Monday :) | 15:05 |
| dtantsur | sorry, have a few more urgent things to review | 15:06 |
| milan | dtantsur, sure, I just couldn't resist ;) | 15:06 |
| vdrok | morning jlvillal ! | 15:06 |
| *** dansmith is now known as superdan | 15:07 | |
| jlvillal | vdrok: :) | 15:08 |
| jlvillal | sambetts: Was there ever a note put in: https://etherpad.openstack.org/p/IronicGateDebugging About the StringField thingy? Did that break the gate? | 15:08 |
| jlvillal | sambetts: If it didn't break the gate, then no need. I wasn't sure if it broke the gate. | 15:09 |
| sambetts | jlvillal: there was a race condition that was hit ever now and then, it didn't break it completely :) | 15:09 |
| * jlvillal likes to use highly technical terms like 'thingy' | 15:09 | |
| *** hoonetorg has joined #openstack-ironic | 15:09 | |
| jlvillal | sambetts: Okay, thanks. If you feel motivated and want to add a note feel free :) | 15:10 |
| *** fragatin_ has quit IRC | 15:10 | |
| *** moshele has joined #openstack-ironic | 15:11 | |
| jlvillal | JayF: They did a better fix than mine for yesterday's issue :) https://review.openstack.org/#/c/351512/ | 15:11 |
| *** wajdi has joined #openstack-ironic | 15:12 | |
| *** rbudden has joined #openstack-ironic | 15:12 | |
| openstackgerrit | Alfredo Moralejo proposed openstack/ironic-inspector: Add callback function to manage missing hooks https://review.openstack.org/339457 | 15:13 |
| *** jistr is now known as jistr|mtg | 15:14 | |
| *** e0ne has joined #openstack-ironic | 15:17 | |
| openstackgerrit | Gleb Stepanov proposed openstack/ironic: Check keyword arguments https://review.openstack.org/351677 | 15:17 |
| *** d0ugal has joined #openstack-ironic | 15:18 | |
| *** e0ne has quit IRC | 15:19 | |
| *** tesseract- has quit IRC | 15:21 | |
| jlvillal | Sweet, one +2 on the Nova multiple compute host patch :) https://review.openstack.org/#/c/348443/ | 15:23 |
| *** foexle has joined #openstack-ironic | 15:23 | |
| * jlvillal remembers people talking about the lack of Nova multiple computer host support for Ironic at his very first mid-cycle | 15:24 | |
| *** rcernin has quit IRC | 15:26 | |
| mariojv | good morning ironic. just saw the conversation from yesterday about notifications | 15:29 |
| openstackgerrit | Moshe Levi proposed openstack/ironic: Adding InfiniBand Support https://review.openstack.org/264263 | 15:29 |
| mariojv | i agree that not every notification needs a spec. i don't think it hurts though | 15:29 |
| mariojv | it does take some time away from actual code reviews for spec reviews though | 15:30 |
| JayF | jlvillal: ooh, nice | 15:30 |
| *** ijw has joined #openstack-ironic | 15:32 | |
| *** links has quit IRC | 15:33 | |
| jlvillal | JayF: I'll believe you think it is nice for both the correct patch and the Nova multi-compute host ;) | 15:34 |
| *** Romanenko_K has quit IRC | 15:35 | |
| *** ijw has quit IRC | 15:36 | |
| openstackgerrit | Gleb Stepanov proposed openstack/ironic: Check keyword arguments https://review.openstack.org/351677 | 15:40 |
| JayF | jlvillal: that was more for the correct patch | 15:40 |
| JayF | jlvillal: I already reviewed the multicompute | 15:40 |
| *** HenryG has quit IRC | 15:43 | |
| *** HenryG has joined #openstack-ironic | 15:43 | |
| sambetts | JayF, jroll, jlvillal: https://review.openstack.org/#/c/351806/ this patch should allow the buildimage jobs to appear on: http://status.openstack.org/openstack-health/#/ so we can track any failures there, and it seems like they provide an API for reading the health information too if we want to build in a notification | 15:44 |
| sambetts | bot | 15:44 |
| JayF | sambetts: is the documentation you're following to write that somewhere? | 15:45 |
| JayF | sambetts: otherwise it's just going ot be a blind +1 more or less | 15:45 |
| *** mgoddard has joined #openstack-ironic | 15:47 | |
| *** mgoddard_ has quit IRC | 15:47 | |
| sambetts | JayF: only docs I had to follow where a patch that infra linked me too that they added for translation jobs https://review.openstack.org/#/c/311459/ | 15:48 |
| *** sdake has quit IRC | 15:56 | |
| *** sdake has joined #openstack-ironic | 15:56 | |
| *** rama_y has joined #openstack-ironic | 16:00 | |
| *** rama_y has quit IRC | 16:01 | |
| jlvillal | sambetts: Where does the $SECONDS value come from? | 16:01 |
| *** PollyZ has quit IRC | 16:04 | |
| *** davideagnello has joined #openstack-ironic | 16:04 | |
| *** pcaruana has quit IRC | 16:05 | |
| openstackgerrit | Gleb Stepanov proposed openstack/ironic: Check keyword arguments https://review.openstack.org/351677 | 16:06 |
| dtantsur | have a nice weekend, see you on Monday | 16:08 |
| *** dtantsur is now known as dtantsur|afk | 16:08 | |
| *** fragatina has joined #openstack-ironic | 16:08 | |
| *** fragatina has quit IRC | 16:09 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Docs: Run py34 tox test before py27 https://review.openstack.org/351826 | 16:11 |
| *** foexle has quit IRC | 16:11 | |
| jlvillal | dtantsur|afk: Ciao! | 16:11 |
| vdrok | night dtantsur|afk ! | 16:11 |
| devananda | morning, all | 16:11 |
| vdrok | and morning devananda :) | 16:11 |
| devananda | g'night & enjoy the weekend, dtantsur|afk ! | 16:11 |
| *** davideagnello has quit IRC | 16:12 | |
| *** PollyZ has joined #openstack-ironic | 16:12 | |
| *** davideagnello has joined #openstack-ironic | 16:13 | |
| *** amoralej is now known as amoralej|off | 16:13 | |
| sambetts | jlvillal: bash magic | 16:14 |
| jlvillal | sambetts: You are late to the party ;) I just replied to the two comments telling me where it came from :D | 16:14 |
| NobodyCam | Good Morning Ironic'ers | 16:15 |
| sambetts | ;) I didn't know about it until I starting looking through the patch I used as an example | 16:15 |
| jlvillal | :) | 16:15 |
| jlvillal | Hi NobodyCam! | 16:15 |
| sambetts | o/ NobodyCam | 16:16 |
| NobodyCam | Morning jlvillal and sambetts :) | 16:16 |
| NobodyCam | and of course TGIF!!!! | 16:16 |
| sambetts | \o/ TGIF | 16:17 |
| NobodyCam | :) | 16:17 |
| NobodyCam | no thiagop this morning ? | 16:18 |
| milan | morning NobodyCam :) TGIF++ :) | 16:18 |
| NobodyCam | oh it a holiday for him | 16:18 |
| NobodyCam | morning milan :) | 16:18 |
| *** jabroney has joined #openstack-ironic | 16:19 | |
| *** PollyZ has quit IRC | 16:19 | |
| lucasagomes | devananda, NobodyCam jlvillal morning :-) | 16:24 |
| lucasagomes | yeah TGIF | 16:24 |
| *** fragatina has joined #openstack-ironic | 16:24 | |
| jlvillal | Hey lucasagomes. | 16:24 |
| jlvillal | lucasagomes: And have a great weekend, whenever you decide to call it a night :) | 16:24 |
| lucasagomes | jlvillal, heh thanks, soon | 16:25 |
| openstackgerrit | Merged openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/348673 | 16:25 |
| milan | Good night Ironic! | 16:26 |
| NobodyCam | morning lucasagomes :) | 16:26 |
| NobodyCam | night milan | 16:27 |
| NobodyCam | have a good weekend | 16:27 |
| openstackgerrit | Gleb Stepanov proposed openstack/ironic: Check keyword arguments https://review.openstack.org/351677 | 16:27 |
| *** baoli_ has quit IRC | 16:27 | |
| *** baoli has joined #openstack-ironic | 16:28 | |
| *** ohamada has quit IRC | 16:30 | |
| jlvillal | milan: Ciao! | 16:31 |
| sambetts | o/ Night all | 16:32 |
| *** sambetts is now known as sambetts|afk | 16:32 | |
| *** baoli has quit IRC | 16:33 | |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Remove -l option for port creation in OSC plugin https://review.openstack.org/351836 | 16:33 |
| vdrok | night milan and sambetts|afk | 16:34 |
| jlvillal | sambetts|afk: ciao | 16:34 |
| lucasagomes | ok folks, calling it a day | 16:36 |
| lucasagomes | sambetts|afk, see ya | 16:36 |
| lucasagomes | have a great weekend | 16:36 |
| *** lucasagomes is now known as lucas|dinner | 16:36 | |
| *** jpich has quit IRC | 16:36 | |
| jlvillal | lucas|dinner: Bye! | 16:38 |
| vdrok | night lucas|dinner , you too! | 16:38 |
| fxpester | guys do you have bootstrap images with ubuntu 14.04 ? I have something strange here... | 16:41 |
| *** cdearborn has quit IRC | 16:43 | |
| *** d0ugal has quit IRC | 16:44 | |
| JayF | devananda: here today? Wanna look at https://review.openstack.org/#/c/330018/34 before I land it? | 16:48 |
| JayF | fxpester: bootstrap images? | 16:49 |
| openstackgerrit | Merged openstack/ironic: Fix tempest realted exceptions during docs build https://review.openstack.org/351239 | 16:51 |
| openstackgerrit | Merged openstack/ironic: Fix typo in Install-guide.rst file https://review.openstack.org/351457 | 16:53 |
| openstackgerrit | Merged openstack/ironic: Replacing generic OneViewError w/ InvalidNodeParameter https://review.openstack.org/351422 | 16:53 |
| *** fragatin_ has joined #openstack-ironic | 16:53 | |
| openstackgerrit | Merged openstack/ironic: Fix typo https://review.openstack.org/351731 | 16:53 |
| *** fragatina has quit IRC | 16:55 | |
| mat128|away | fxpester: for devstack? I normally take a clean ubuntu 14.04 | 16:58 |
| *** mat128|away is now known as mat128 | 16:58 | |
| mat128 | fxpester: the only thing I need to add is trusty-backports | 16:58 |
| *** anush_ has quit IRC | 17:00 | |
| *** d0ugal has joined #openstack-ironic | 17:11 | |
| *** daemontool_ has joined #openstack-ironic | 17:13 | |
| *** daemontool has quit IRC | 17:16 | |
| *** davideagnello has quit IRC | 17:20 | |
| *** electrofelix has quit IRC | 17:21 | |
| *** Sukhdev has joined #openstack-ironic | 17:22 | |
| *** davideagnello has joined #openstack-ironic | 17:27 | |
| NobodyCam | JayF: quick question: would you be okay with landing the one view doc if I fix the whitespace and +2 it? | 17:28 |
| JayF | NobodyCam: I thought we already landed it? | 17:28 |
| JayF | NobodyCam: link? | 17:28 |
| jroll | it got pep8'd | 17:29 |
| jroll | I almost fixed/approved | 17:29 |
| NobodyCam | https://review.openstack.org/#/c/305441 | 17:29 |
| jroll | but then didn't :P | 17:29 |
| JayF | NobodyCam: dooet | 17:29 |
| NobodyCam | I'm happy to fix | 17:29 |
| openstackgerrit | Chris Krelle proposed openstack/ironic: OneView driver docs explaining Dynamic Allocation https://review.openstack.org/305441 | 17:35 |
| JayF | NobodyCam: ^ re-landing | 17:36 |
| NobodyCam | :) | 17:36 |
| *** cdearborn has joined #openstack-ironic | 17:41 | |
| *** e0ne has joined #openstack-ironic | 17:44 | |
| *** cdearborn has quit IRC | 17:46 | |
| *** cdearborn has joined #openstack-ironic | 17:46 | |
| *** baoli has joined #openstack-ironic | 17:50 | |
| *** fragatin_ has quit IRC | 17:52 | |
| *** aarefiev_ has quit IRC | 17:53 | |
| *** fragatina has joined #openstack-ironic | 17:53 | |
| *** bvandewa has joined #openstack-ironic | 18:05 | |
| * mgould -> home; have a good weekend, everyone! | 18:05 | |
| *** mgould is now known as mgould|afk | 18:05 | |
| *** bvandewa has quit IRC | 18:06 | |
| *** michauds has quit IRC | 18:06 | |
| *** e0ne_ has joined #openstack-ironic | 18:07 | |
| *** e0ne has quit IRC | 18:07 | |
| *** ijw has joined #openstack-ironic | 18:13 | |
| NobodyCam | night mgould|afk | 18:17 |
| NobodyCam | have a good weekend | 18:17 |
| openstackgerrit | Moshe Levi proposed openstack/ironic: Adding InfiniBand Support https://review.openstack.org/264263 | 18:20 |
| *** adu has joined #openstack-ironic | 18:21 | |
| *** davideagnello has quit IRC | 18:21 | |
| *** daemontool_ has quit IRC | 18:23 | |
| openstackgerrit | Stephanie Miller proposed openstack/ironic: [WIP] Add storage_interface to base driver class https://review.openstack.org/348006 | 18:25 |
| *** moshele has quit IRC | 18:26 | |
| *** davideagnello has joined #openstack-ironic | 18:30 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add test to ensure policy is always authorized https://review.openstack.org/350177 | 18:36 |
| Sukhdev | jroll : are you around? Have an interesting issue | 18:44 |
| jroll | Sukhdev: not really, but as always, just ask your question. there's other smart people here, too :) | 18:45 |
| *** e0ne_ is now known as e0ne | 18:46 | |
| Sukhdev | jroll : So, I have been testing Ironic patches - all works fine, except when I reboot the controller | 18:46 |
| openstackgerrit | Merged openstack/python-ironicclient: Trivial: Remove useless spaces https://review.openstack.org/349949 | 18:47 |
| Sukhdev | once I reboot the controller and launch instance, IPA is not able to pull the image | 18:47 |
| jroll | Sukhdev: is this with devstack or real stuff? | 18:47 |
| Sukhdev | jroll : see paste with the logs - http://paste.openstack.org/show/550669/ | 18:47 |
| Sukhdev | jroll : all devstack | 18:47 |
| jroll | Sukhdev: I don't trust our devstack stuff to work after reboot, too much ovs insanity | 18:48 |
| Sukhdev | jroll : instance goes through the first boot, pulls the image and reboots, I see it gets correct IP address and then fails to pull the image - as the paste shows | 18:48 |
| *** joprovost has quit IRC | 18:48 | |
| *** PollyZ has joined #openstack-ironic | 18:49 | |
| jroll | Sukhdev: again, probably a bug in our devstack setup, not the actual code | 18:49 |
| jroll | or a bug in our tempurl handling maybe? | 18:49 |
| jroll | idk, doesn't look like a networking problem | 18:49 |
| Sukhdev | jroll : no, it is not networking issue - | 18:50 |
| *** joprovost has joined #openstack-ironic | 18:50 | |
| jroll | Sukhdev: I'm not really here today, feel free to file a bug | 18:50 |
| jroll | unstack.sh and stack.sh should get you moving | 18:50 |
| Sukhdev | jroll : if you point me int he right direction, I would not mind digging - but, am not familiar with this stuff | 18:50 |
| Sukhdev | jroll : right unstack/stack works fine | 18:51 |
| jroll | Sukhdev: so, tl;dr, the swift temp url that we pass to the agent appears to be expired | 18:52 |
| *** livelace has quit IRC | 18:52 | |
| jroll | if I'm doing this right, by 3 hours, but maybe a time zone thing | 18:52 |
| Sukhdev | jroll : yes, the swift authentication (and/or) url issue | 18:53 |
| Sukhdev | jroll : I have see couple of times swift auth issue as well | 18:53 |
| Sukhdev | s/see/seen | 18:53 |
| jroll | yeah, I wouldn't know where to start, sorry | 18:54 |
| *** PollyZ_ has joined #openstack-ironic | 18:54 | |
| Sukhdev | jroll : anybody in ironic land who may be more familiar with this who can help out? | 18:55 |
| jroll | Sukhdev: why don't we wait and see if someone else answers, that's the reason to just ask the question, you never know who might know | 18:56 |
| jroll | at any rate, you should file a bug if this is reproducable | 18:56 |
| *** PollyZ has quit IRC | 18:57 | |
| Sukhdev | jroll : this is very reproducible - in fact, I reproduced few times before reaching to this conclusion - | 18:57 |
| jroll | then file a bug, please | 18:57 |
| openstackgerrit | Merged openstack/python-ironicclient: Remove unused LONG_FIELDS https://review.openstack.org/345635 | 18:57 |
| Sukhdev | jroll : Sure - will file a bug | 18:57 |
| *** catintheroof has quit IRC | 19:00 | |
| *** joprovost has quit IRC | 19:01 | |
| *** joprovost has joined #openstack-ironic | 19:01 | |
| *** baoli has quit IRC | 19:07 | |
| *** joprovost has quit IRC | 19:07 | |
| *** joprovost has joined #openstack-ironic | 19:07 | |
| *** sdake has quit IRC | 19:26 | |
| *** sdake has joined #openstack-ironic | 19:28 | |
| *** e0ne has quit IRC | 19:29 | |
| *** penick has joined #openstack-ironic | 19:32 | |
| *** penick_ has joined #openstack-ironic | 19:33 | |
| *** davideagnello has quit IRC | 19:33 | |
| *** davideagnello has joined #openstack-ironic | 19:34 | |
| *** penick has quit IRC | 19:36 | |
| *** penick_ is now known as penick | 19:36 | |
| *** baoli has joined #openstack-ironic | 19:42 | |
| devananda | jroll: any objection to landing the agent vendor api promotion today? | 19:45 |
| devananda | nvm - i see it's on the must-have list | 19:46 |
| * devananda pushes the button | 19:46 | |
| JayF | \o/ | 19:49 |
| JayF | Anyone wanna review https://review.openstack.org/#/c/336102 (Collect deployment logs from IPA) before I land it? | 19:51 |
| *** lintan has quit IRC | 19:52 | |
| JayF | https://review.openstack.org/#/c/344164/ has had (my) +2 and 3x+1 for over a week, it's a relatively small IPA change and it'd be nice to get it landed. | 19:55 |
| jroll | devananda: don't forget the rest of that series :) https://review.openstack.org/#/q/topic:bug/1570841+status:open | 19:55 |
| JayF | nothing else can land in that | 19:56 |
| jroll | why? | 19:56 |
| JayF | until the first patch lands and we verify in devstack IPA is working with the new api | 19:56 |
| JayF | once that happens, we land the IPA patch, when the IPA patch lands we can land the deprecation | 19:56 |
| jroll | they're chained, so it's all tested like that | 19:57 |
| JayF | oh, hah | 19:57 |
| *** joprovost has quit IRC | 19:57 | |
| JayF | let me go look at some devstack logs | 19:57 |
| JayF | and land a thing in ipa then | 19:57 |
| JayF | \o/ | 19:57 |
| *** clenimar_ has quit IRC | 19:58 | |
| *** lintan has joined #openstack-ironic | 19:58 | |
| *** ChubYann has joined #openstack-ironic | 19:58 | |
| JayF | approved the ipa part of that chain | 19:59 |
| JayF | I'm going to land the deprecation in a little bit unless someone else wants to review it (https://review.openstack.org/#/c/336547) | 20:01 |
| *** joprovost has joined #openstack-ironic | 20:01 | |
| jroll | heh, thanks JayF | 20:01 |
| devananda | JayF: I -1 it | 20:01 |
| devananda | *I just -1'd it | 20:02 |
| JayF | go around! go around! | 20:02 |
| JayF | lol | 20:02 |
| jroll | hrm | 20:02 |
| JayF | jroll: I hrm'd at first too, then I thought about how many loglines that would generate in our environment | 20:03 |
| JayF | jroll: and am glad devananda pointed it out | 20:03 |
| jroll | devananda: the one in __init__ is not actionable by operators using in-tree, though | 20:03 |
| devananda | oh. isn't there a patch to actually STOP using these? | 20:03 |
| jroll | and since we can do agent per-node, I feel like we might need to log once per node | 20:03 |
| devananda | I assume there was but haven't found it yet | 20:03 |
| jroll | yeah, if you upgrade the agent | 20:03 |
| devananda | ah | 20:03 |
| devananda | that's it | 20:04 |
| jroll | but the one in init can't tell which agent is in use | 20:04 |
| *** joprovost1 has joined #openstack-ironic | 20:04 | |
| devananda | so the ones in __init__ need to indicate that the operator should upgrade their agent ramdisk | 20:04 |
| JayF | https://review.openstack.org/#/c/334523/16 which is in the gate (IPA change) | 20:04 |
| devananda | uh... LOL | 20:04 |
| JayF | devananda: but even an operator who had upgraded would see that message | 20:04 |
| JayF | I would suggest a "log it once per node" or something similar | 20:04 |
| jroll | and normally people don't look at agent logs so we can't do it there :/ | 20:04 |
| jroll | JayF: so, just lookup? | 20:04 |
| JayF | but i know how crappy that got in a change I was trying to do it in | 20:05 |
| JayF | jroll: I guess? Even that is going to be spammy but probably is the best real-world balance | 20:05 |
| mat128 | JayF: I remember.. lol | 20:05 |
| jroll | once per agent boot seems like the most reasonable thing | 20:05 |
| *** joprovost has quit IRC | 20:05 | |
| *** joprovost1 is now known as joprovost | 20:05 | |
| jroll | because the agent booting is the trigger to be able to know | 20:05 |
| JayF | Yeah; I think that's the most reasonable solution | 20:08 |
| JayF | devananda: ^ you on board? if so I'll update that patch so we can still land it today | 20:08 |
| *** cdearborn has quit IRC | 20:08 | |
| *** cdearborn has joined #openstack-ironic | 20:08 | |
| devananda | sorry, distracted. back now | 20:10 |
| devananda | I'd like to suggest two alternate approaches | 20:10 |
| devananda | - driver class, in __init__, creates a singleton "used_with_deprecated_api = False", and then logs from heartbeat or lookup only once (if the singleton's value is False) | 20:11 |
| JayF | devananda: but I have 100 nodes with agent A, from newton, and 100 nodes with agent B, from way-back-in-the-day | 20:12 |
| *** adu has quit IRC | 20:12 | |
| devananda | JayF: so you want to know which ones are using old-ramdisk | 20:12 |
| JayF | devananda: since we can set agent per node, it seems as if our deprecation needs to somehow hinge as per-node | 20:12 |
| JayF | devananda: and lookup seems like a reasonable enough proxy for that, imo | 20:12 |
| devananda | option 2) driver class, in __init__, creates a singleton that tracks node id's. when heartbeat or lookup is called via the old interface, it logs it once and flags it in the singleton | 20:13 |
| devananda | that'll log once per node per conductor startup | 20:13 |
| devananda | so you could get duplicate messages per node, if a) conductor restarts, b) ring rebalances | 20:13 |
| jroll | I'm worried someone will think they updated it, but didn't, and won't restart their conductors between N release and O release | 20:14 |
| devananda | but I think that's acceptable | 20:14 |
| devananda | oh - you're concern is that once per node isn't sufficient | 20:14 |
| devananda | and it should be once per-node-per-deploy ? | 20:15 |
| *** bvandewa has joined #openstack-ironic | 20:15 | |
| jroll | s/deploy/boot/ | 20:15 |
| JayF | I still prefer lookup because 1) It's simpler overall and 2) Unless we track also if a node has had the ramdisk values updated, we would have jroll's problem | 20:15 |
| devananda | so once in inspect, once in deploy, once in cleaning. rinse and repeat steps 2 & 3 with every "nova boot" | 20:15 |
| *** lintan has quit IRC | 20:16 | |
| devananda | jroll: IMO that's far too spammy | 20:16 |
| jroll | devananda: I always rather too spammy than not spammy enough | 20:16 |
| JayF | the only option would be to do something like on a nodes' driver_info set deprecation_message_logged=True or similar | 20:17 |
| devananda | JayF: driver_internal_info, but yes | 20:17 |
| JayF | and clear that when you change deploy_kernel/deploy_ramdisk values on the node | 20:17 |
| JayF | but I'd prefer be spammy and leave the logic simpler | 20:17 |
| JayF | especially given this will /only occur/ if an operator updates Ironic to Newton without also updating their agent to newton | 20:18 |
| devananda | JayF: to be clear, IIUC, you're suggesting removing the warnings from __init__ and heartbeat, and just leaving the one in lookup() ? | 20:18 |
| JayF | devananda: yes | 20:18 |
| JayF | devananda: well, in __init__, I really couldn't care that much one way or the other | 20:18 |
| devananda | except that the message in __init__ will get printed even if everything is up to date | 20:19 |
| devananda | so I don't think we should do that | 20:19 |
| JayF | Yeah, that's true | 20:19 |
| jroll | __init__ is useful for out-of-tree drivers mixing in agent vendor, though | 20:19 |
| jroll | which is why it's there | 20:19 |
| JayF | jroll: so maybe make that message more targetted to out of tree drivers | 20:20 |
| JayF | jroll: and say nothing about the ramdisk | 20:20 |
| jroll | sure | 20:20 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/bifrost: Updated from global requirements https://review.openstack.org/350875 | 20:20 |
| jroll | it doesn't say anything about the ramdisk, btw | 20:20 |
| devananda | it's still going to log for in-tree drivers | 20:21 |
| devananda | and there's nothing the operator can do | 20:21 |
| JayF | Is there a way to detect and only print that log for a subclass? | 20:21 |
| JayF | *an out of tree subclass | 20:21 |
| devananda | if self.__class__ isa ... | 20:21 |
| *** lintan has joined #openstack-ironic | 20:21 | |
| devananda | or something like that | 20:21 |
| JayF | I kinda feel a release note and no log there is OK | 20:22 |
| devananda | JayF: ditto | 20:22 |
| *** davideagnello has quit IRC | 20:22 | |
| devananda | but perhaps with stronger words | 20:22 |
| JayF | if you're writing an out of tree driver and not reading release notes | 20:22 |
| JayF | you're kinda asking for it | 20:22 |
| *** baoli has quit IRC | 20:23 | |
| jroll | you could add "if using a third party driver"... | 20:23 |
| jroll | it could be very relevant at the end of this cycle | 20:23 |
| jroll | when we drop drivers without CI | 20:23 |
| devananda | warning: If using a third-party driver and you are reading this message, you need to ... | 20:24 |
| jroll | file a bug with that driver? | 20:24 |
| jroll | good point | 20:24 |
| *** michauds has joined #openstack-ironic | 20:25 | |
| *** lintan has quit IRC | 20:25 | |
| JayF | jroll: so does that mean you're in agreement to keep __init__ mum? | 20:26 |
| *** ametts has quit IRC | 20:26 | |
| jroll | I'm in between | 20:27 |
| JayF | I mean, that's not even a plugin interface, right? | 20:27 |
| JayF | Someone would have to patch a driver in | 20:27 |
| JayF | ignore the pydoc changes, ignore the release note | 20:27 |
| devananda | no - it's a class that can be mixed in to any out of tree driver | 20:27 |
| jroll | e.g. https://github.com/openstack/ironic/blob/master/ironic/drivers/agent.py#L55 | 20:28 |
| devananda | actually | 20:28 |
| devananda | I'd like to posit that the init warnings aren't needed at all | 20:28 |
| jroll | yeah, I'm still 50/50 | 20:29 |
| devananda | because this is an in-tree driver. in Ocata, *WE* will change it | 20:29 |
| jroll | I feel like this needs discussion with dtantsur|afk | 20:29 |
| devananda | if someone out of tree is _using_ it -- that's fine. they'll still get our change when we change it | 20:29 |
| jroll | no they won't, we're just going to drop those passthrus | 20:29 |
| jroll | if they have a custom deploy driver and are also using agent vendor passthru, they will break | 20:29 |
| devananda | that's what I mean | 20:29 |
| jroll | unless they also implement deploy.lookup and deploy.heartbeat | 20:30 |
| devananda | so we make those interfaces mandatory | 20:30 |
| jroll | it'll still break when we do that :) | 20:30 |
| jroll | but at startup, at least | 20:30 |
| *** davideagnello has joined #openstack-ironic | 20:31 | |
| devananda | right | 20:31 |
| jroll | still means broken upgrade without a warning outside of release notes | 20:31 |
| jroll | but maybe it's fine | 20:31 |
| jroll | devananda: either way I'd like dmitry's take on it - can you summarize this discussion in a comment so he can reply at will? | 20:32 |
| devananda | lookup is now implmeented in the API tier - it won't touch the driver | 20:33 |
| devananda | and is not implemented on the base driver classes | 20:33 |
| devananda | only heartbeat is | 20:33 |
| devananda | and that is driver-specific | 20:33 |
| jroll | ah right, just heartbeat | 20:33 |
| devananda | it already logs a warning in the base class if it is called, and not implemented/overridden in the inheriting class | 20:33 |
| jroll | aha, good | 20:35 |
| jroll | ok, I'm fine without it in __init__ but would still like dmitry's +1 | 20:35 |
| devananda | *nod* | 20:35 |
| * devananda writes this up | 20:35 | |
| JayF | I wonder if we should still implement it ourselves, now | 20:36 |
| JayF | and +2 it | 20:36 |
| JayF | and let him land it if no objections | 20:36 |
| * JayF optimizes for maximum landing speed | 20:36 | |
| * jroll finally goes to eat "lunch" and have a weekend | 20:38 | |
| devananda | jroll: enjoy the weekend! | 20:39 |
| JayF | o/ | 20:39 |
| jroll | y'all too | 20:39 |
| *** r-daneel has joined #openstack-ironic | 20:41 | |
| devananda | JayF: comments posted. I need to go eat lunch too. bbiab | 20:44 |
| devananda | JayF: if you'd like to implement the changes we discussed, I'm happy to review post-food | 20:44 |
| JayF | I'll just wait, since jim is gone and didn't +1 the idea; he was pretty adament about dmitry getting input | 20:45 |
| *** [1]cdearborn has joined #openstack-ironic | 21:01 | |
| mat128 | alright, weekend for me | 21:01 |
| mat128 | see you monday everyone | 21:01 |
| *** mat128 is now known as mat128|weekend | 21:01 | |
| JayF | o/ | 21:04 |
| *** sdake has quit IRC | 21:12 | |
| *** dprince has quit IRC | 21:12 | |
| *** michauds has quit IRC | 21:13 | |
| *** cdearborn has quit IRC | 21:17 | |
| *** bvandewa_ has joined #openstack-ironic | 21:22 | |
| *** michauds has joined #openstack-ironic | 21:26 | |
| *** bvandewa has quit IRC | 21:26 | |
| JayF | mariojv: you have a patch up to make agent_last_heartbeat better, right? | 21:34 |
| mariojv | JayF: no, i haven't started on it yet, but there's a bug up | 21:34 |
| JayF | OK; cool | 21:34 |
| JayF | was curious, I'm writing an RFE/spec right now that will probably depend on that work being done | 21:34 |
| mariojv | i think someone said they wanted to work on it 2 or 3 days ago | 21:34 |
| mariojv | vgadiraj maybe? | 21:34 |
| JayF | he's one of the new OSIC folks who've been working with me and Jom | 21:35 |
| JayF | *Jim | 21:35 |
| *** joprovost has quit IRC | 21:35 | |
| JayF | so that would fit | 21:35 |
| mariojv | JayF: here's the bug: https://bugs.launchpad.net/ironic/+bug/1602410 | 21:35 |
| openstack | Launchpad bug 1602410 in Ironic "agent_last_heartbeat type not consistent with other date fields" [Undecided,New] - Assigned to Mario Villaplana (mario-villaplana-j) | 21:35 |
| mariojv | on a slightly unrelated note, there's a doc bug i also filed here https://bugs.launchpad.net/ironic/+bug/1597834 which has a fix with 4 +1s up here: https://review.openstack.org/#/c/337885/ :) | 21:36 |
| openstack | Launchpad bug 1597834 in Ironic "Limit for number of items returned by API from collection resource not well-documented" [Undecided,In progress] - Assigned to Mario Villaplana (mario-villaplana-j) | 21:36 |
| JayF | is that a request for review | 21:36 |
| JayF | lol | 21:36 |
| mariojv | maybe | 21:36 |
| *** bnemec is now known as beekneemech | 21:36 | |
| *** jvgrant_ has quit IRC | 21:37 | |
| JayF | +2 | 21:37 |
| mariojv | \o/ thank you | 21:37 |
| JayF | ^^ That's a super easy review if someone else wants to land it | 21:37 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Simplify code by using mask_dict_password https://review.openstack.org/351932 | 21:38 |
| *** davideagnello has quit IRC | 21:40 | |
| *** wajdi_ has joined #openstack-ironic | 21:46 | |
| *** [1]cdearborn has quit IRC | 21:47 | |
| *** wajdi has quit IRC | 21:49 | |
| *** rbudden has quit IRC | 21:50 | |
| *** wajdi_ has quit IRC | 21:50 | |
| *** davideagnello has joined #openstack-ironic | 21:52 | |
| *** sdake has joined #openstack-ironic | 21:54 | |
| JayF | mariojv: ^^ jlvillal just landed your thing | 21:58 |
| JayF | mariojv: tl;dr ask more n00b :D | 21:58 |
| mariojv | ty jlvillal | 21:58 |
| mariojv | and JayF | 21:58 |
| jlvillal | JayF: ^^ Simple patch there ;) | 21:59 |
| mariojv | some people get bothered by review requests, some don't, so i have always just left patches up there for eons | 21:59 |
| JayF | like here's the general etiqutte imo: | 21:59 |
| JayF | 1) If you have negative feedback, fix it first | 21:59 |
| jlvillal | mariojv: Put me into the camp of mostly liking ping requests. Since I like you :) | 21:59 |
| mariojv | \o/ | 21:59 |
| JayF | 2) Don't just jump into a deep technical conversation in IRC with a 'MERGE THIS KTHX' | 21:59 |
| JayF | 3) Make sure you're reviewing other folks' stuff | 22:00 |
| JayF | 4) Ask for reviews from the channel, not from specific people unless you know they don't mind (I don't mind, apparently jlvillal doesn't either) | 22:00 |
| JayF | (and really, even if you're asking from specific people, do it here and not pm) | 22:00 |
| *** jcoufal_ has joined #openstack-ironic | 22:00 | |
| *** chihhsin has quit IRC | 22:01 | |
| mariojv | sounds like good ettiquette to me | 22:01 |
| mariojv | fwiw, i don't mind review requests either, but i don't have that magic +2 button :) | 22:02 |
| JayF | I sorta started viewing it this way before I was core; a -1 is more useful than a +1 | 22:02 |
| JayF | which sorta drove me to review "harder" things or to be more in depth with my reviews | 22:03 |
| JayF | and that leads to better reviews, etc | 22:03 |
| *** jcoufal has quit IRC | 22:04 | |
| *** bvandewa_ has quit IRC | 22:08 | |
| *** bvandewa has joined #openstack-ironic | 22:11 | |
| *** milan has quit IRC | 22:12 | |
| *** jcoufal_ has quit IRC | 22:15 | |
| *** thrash is now known as thrash|wknd | 22:16 | |
| *** hj-hpe has quit IRC | 22:19 | |
| *** jcoufal has joined #openstack-ironic | 22:20 | |
| jlvillal | JayF: Posted a comment on your RFE. https://bugs.launchpad.net/ironic/+bug/1610457 | 22:22 |
| openstack | Launchpad bug 1610457 in Ironic "[RFE] Long running agent ramdisk support" [Undecided,New] - Assigned to Jay Faulkner (jason-oldos) | 22:22 |
| JayF | jlvillal: I'm like, 1/3 of the way through the spec :P | 22:22 |
| JayF | jlvillal: the hardest problems here are going to be things passed down to the node on deployment, like root_device_hints | 22:22 |
| *** adu has joined #openstack-ironic | 22:30 | |
| *** syed_ has quit IRC | 22:32 | |
| *** PollyZ_ has quit IRC | 22:32 | |
| *** ljjjustin has quit IRC | 22:33 | |
| *** jcoufal has quit IRC | 22:35 | |
| *** wajdi has joined #openstack-ironic | 22:36 | |
| *** ljjjustin has joined #openstack-ironic | 22:37 | |
| *** jcoufal has joined #openstack-ironic | 22:40 | |
| openstackgerrit | Merged openstack/ironic: Remove oslo-incubator references https://review.openstack.org/351678 | 22:40 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-specs: Spec for Long Running Ramdisk Support https://review.openstack.org/351943 | 22:45 |
| JayF | jlvillal: ^ that's the spec if you're interested, would love some early reviews but obviously not a priority | 22:45 |
| jlvillal | JayF: Okay. I'm seeing the gorgeous blue skies outside and I'm thinking about leaving work early :) | 22:47 |
| jlvillal | JayF: Plus the airshow starts in about 2 hours | 22:47 |
| jlvillal | Airport is right next door to work and my home. | 22:47 |
| openstackgerrit | Merged openstack/ironic: Follow up to keystoneauth patch https://review.openstack.org/351076 | 22:47 |
| openstackgerrit | Merged openstack/ironic: OneView driver docs explaining Dynamic Allocation https://review.openstack.org/305441 | 22:48 |
| JayF | jlvillal: in seattle? | 22:49 |
| JayF | jlvillal: right? | 22:49 |
| JayF | jlvillal: I saw it was basically fleet week up that way; air shows are pretty neat | 22:49 |
| jlvillal | JayF: Hillsboro airport here in Oregon. | 22:50 |
| JayF | oh really? Sweet! | 22:50 |
| JayF | I know in Seattle they have an air show | 22:50 |
| JayF | I did get to see the blue angels practice over the bay once, that was sweet | 22:50 |
| jlvillal | JayF: Sometimes they get the Blue Angels or Thunderbirds. | 22:51 |
| JayF | honestly I'm less of a military plane guy, I like the civvy stuff better | 22:51 |
| *** adu has quit IRC | 22:51 | |
| JayF | or the giant cargo military planes | 22:52 |
| jlvillal | JayF: But this year it is the Breitling Jet Team. They are from France and fly jets that were made in Czech Republic. | 22:52 |
| JayF | but those jets are more akin to rockets with wings than planes | 22:52 |
| openstackgerrit | David Lenwell proposed openstack/ironic: Add REST API for volume connector and volume target operation https://review.openstack.org/214586 | 22:52 |
| jlvillal | JayF: Repeated my comment from the RFE bug in the spec :) | 22:52 |
| jlvillal | JayF: Feel free to say, not possible | 22:52 |
| JayF | there's a spec out there | 22:52 |
| JayF | that addresses that separately, I think | 22:52 |
| *** wajdi has quit IRC | 22:53 | |
| JayF | jlvillal: commented back, but there is a spec out there for agent api versioning | 22:56 |
| JayF | jlvillal: I just realized that wasn't the core of what you were asking | 22:57 |
| *** davideagnello has quit IRC | 22:58 | |
| jlvillal | JayF: I think the symbolic link was done incorrectly | 23:00 |
| JayF | I don't think so? | 23:01 |
| jlvillal | JayF: The gate disagrees with you | 23:01 |
| jlvillal | JayF: I left a comment. | 23:01 |
| JayF | oh, bah | 23:01 |
| JayF | I see it | 23:01 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-specs: Spec for Long Running Ramdisk Support https://review.openstack.org/351943 | 23:02 |
| JayF | not that it really matters that it passes tests right now, as i have a few todos in there | 23:02 |
| JayF | just mainly looking for design agreement (and for people to throw tomatoes at me now) before I spend too much time :) | 23:03 |
| jlvillal | JayF: And I didn't quite understand your response. | 23:03 |
| jlvillal | But I'm not going to worry about it now :) | 23:03 |
| JayF | jlvillal: so we set deploy_kernel and deploy_ramdisk as attributes on the node | 23:04 |
| JayF | so aiui you can't update the ramdisk without an update command to the node, right? | 23:04 |
| *** ppiela has quit IRC | 23:04 | |
| * JayF waits for jlvillal to blow his assumption out of the water | 23:04 | |
| *** PollyZ has joined #openstack-ironic | 23:05 | |
| jlvillal | JayF: Okay. Could be. | 23:05 |
| JayF | jlvillal: so I'm saying, if ramdisk_booted; you can't update those attributes on the node | 23:06 |
| JayF | jlvillal: you have to power the node off, update the ramdisks, then tell it to boot a ramdisk | 23:06 |
| *** davideagnello has joined #openstack-ironic | 23:06 | |
| jlvillal | JayF: Okay, will that be a pain for operators? | 23:06 |
| JayF | I mean, if the operator chose to either 1) manually boot a ramdisk or 2) tell ironic to boot by default | 23:07 |
| JayF | I'd have presumed they'd already done the work to automate that out | 23:07 |
| jlvillal | If they decide to have all of these hot spare (or whatever you call them) systems ready to go. | 23:07 |
| JayF | yeah; I think I get how that could be painful | 23:07 |
| jlvillal | I'm going to call it a night. | 23:08 |
| jlvillal | Good night JayF and everyone else :) | 23:08 |
| JayF | o/ | 23:09 |
| JayF | I think I might do the same shortly, come back tomorrow and make sure all the things have landed | 23:09 |
| mariojv | JayF: reviewed your long-running ramdisk spec, thanks for that | 23:13 |
| mariojv | have a great weekend all | 23:14 |
| JayF | o/ | 23:15 |
| *** davideagnello has quit IRC | 23:20 | |
| openstackgerrit | Merged openstack/ironic: Document API max_limit configuration option https://review.openstack.org/337885 | 23:22 |
| *** jcoufal has quit IRC | 23:30 | |
| *** sdake has quit IRC | 23:31 | |
| *** PollyZ has quit IRC | 23:37 | |
| *** jcoufal has joined #openstack-ironic | 23:41 | |
| *** wajdi has joined #openstack-ironic | 23:41 | |
| *** michauds has quit IRC | 23:44 | |
| *** ljjjustin has quit IRC | 23:45 | |
| *** ljjjustin has joined #openstack-ironic | 23:49 | |
| *** wajdi has quit IRC | 23:52 | |
| *** ijw has quit IRC | 23:52 | |
| *** ijw has joined #openstack-ironic | 23:53 | |
| *** lascii is now known as alaski | 23:56 | |
| *** ijw has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!