| *** syed_ has quit IRC | 00:02 | |
| *** snizar_ has quit IRC | 00:03 | |
| *** snizar has quit IRC | 00:03 | |
| *** anush_ has quit IRC | 00:04 | |
| *** snizar has joined #openstack-ironic | 00:10 | |
| *** snizar_ has joined #openstack-ironic | 00:10 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic: Add metrics to administrator guide https://review.openstack.org/356811 | 00:11 |
|---|---|---|
| *** rama_y has quit IRC | 00:13 | |
| *** penick has joined #openstack-ironic | 00:31 | |
| *** sdake has joined #openstack-ironic | 00:35 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Introduce VolumeConnector object https://review.openstack.org/214584 | 00:35 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Introduce new RPCs to support volume connector operation https://review.openstack.org/214585 | 00:36 |
| *** causten has joined #openstack-ironic | 00:36 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add volume_targets table to save target information https://review.openstack.org/285218 | 00:36 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Introduce VolumeTarget object https://review.openstack.org/285219 | 00:37 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Introduce new RPCs to support volume target operations https://review.openstack.org/285220 | 00:38 |
| *** hoangcx has joined #openstack-ironic | 00:58 | |
| *** sdake has quit IRC | 00:59 | |
| *** adu has quit IRC | 01:00 | |
| *** sdake has joined #openstack-ironic | 01:02 | |
| *** snizar has quit IRC | 01:04 | |
| *** snizar_ has quit IRC | 01:04 | |
| *** _vsaienko has quit IRC | 01:09 | |
| *** sdake has quit IRC | 01:11 | |
| *** xuao has joined #openstack-ironic | 01:15 | |
| *** sabeen has quit IRC | 01:17 | |
| *** sabeen has joined #openstack-ironic | 01:21 | |
| *** aNupoisc has quit IRC | 01:22 | |
| jroll | dtantsur|afk: sambetts|afk: this feels relevant to IPA and all the magic we do waiting for networking to come up, in a few different ways. worth a read: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ | 01:24 |
| *** tiendc has joined #openstack-ironic | 01:29 | |
| *** Sukhdev has quit IRC | 01:30 | |
| *** zhangjl has joined #openstack-ironic | 01:39 | |
| *** thrash is now known as thrash|g0ne | 01:40 | |
| *** causten has quit IRC | 01:47 | |
| *** causten has joined #openstack-ironic | 01:50 | |
| *** rloo has quit IRC | 02:29 | |
| *** baoli has joined #openstack-ironic | 02:30 | |
| *** vishwanathj has quit IRC | 02:39 | |
| *** yuanying_ has quit IRC | 02:46 | |
| *** yuanying has joined #openstack-ironic | 02:52 | |
| *** causten has quit IRC | 02:55 | |
| openstackgerrit | Nguyen Hung Phuong proposed openstack/ironic: Clean imports in code https://review.openstack.org/355704 | 03:02 |
| *** rbudden has quit IRC | 03:03 | |
| *** baoli has quit IRC | 03:07 | |
| *** Goneri has quit IRC | 03:10 | |
| *** jhooker has quit IRC | 03:10 | |
| *** jhooker has joined #openstack-ironic | 03:11 | |
| *** yuanying has quit IRC | 03:18 | |
| *** yuanying has joined #openstack-ironic | 03:19 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add 'openstack baremetal node adopt' command https://review.openstack.org/356671 | 03:21 |
| *** Sukhdev has joined #openstack-ironic | 03:28 | |
| *** xuao has quit IRC | 03:29 | |
| *** vikrant has joined #openstack-ironic | 03:32 | |
| *** vikrant has quit IRC | 03:37 | |
| *** phschwartz has joined #openstack-ironic | 03:38 | |
| *** vikrant has joined #openstack-ironic | 03:41 | |
| *** yuanying has quit IRC | 03:42 | |
| *** yuanying has joined #openstack-ironic | 03:42 | |
| *** yuanying has quit IRC | 03:43 | |
| *** links has joined #openstack-ironic | 03:45 | |
| *** tiendc has quit IRC | 03:47 | |
| *** yuanying has joined #openstack-ironic | 03:48 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Adds 'openstack baremetal node console' commands https://review.openstack.org/356759 | 03:51 |
| *** vishwanathj has joined #openstack-ironic | 03:56 | |
| *** vikrant is now known as vikrant|brb | 03:58 | |
| *** hshiina has joined #openstack-ironic | 04:02 | |
| *** tiendc has joined #openstack-ironic | 04:06 | |
| *** vishwanathj has quit IRC | 04:17 | |
| *** vikrant|brb is now known as vikrant| | 04:18 | |
| *** vikrant| is now known as vikrant | 04:18 | |
| *** amotoki has joined #openstack-ironic | 04:33 | |
| *** amotoki has quit IRC | 04:38 | |
| *** vishwanathj has joined #openstack-ironic | 04:38 | |
| *** sabeen has quit IRC | 04:42 | |
| *** Sukhdev has quit IRC | 04:46 | |
| *** amotoki has joined #openstack-ironic | 05:00 | |
| *** fragatina has quit IRC | 05:01 | |
| *** amotoki has quit IRC | 05:05 | |
| *** vishwanathj is now known as vishwanathj_zzz | 05:08 | |
| *** _vsaienko has joined #openstack-ironic | 05:10 | |
| *** _vsaienko has quit IRC | 05:23 | |
| *** tiendc has quit IRC | 05:26 | |
| *** amotoki has joined #openstack-ironic | 05:28 | |
| *** tiendc has joined #openstack-ironic | 05:28 | |
| *** amotoki has quit IRC | 05:32 | |
| *** rajinir has quit IRC | 05:35 | |
| *** _vsaienko has joined #openstack-ironic | 05:44 | |
| *** tiendc has quit IRC | 05:52 | |
| *** tiendc has joined #openstack-ironic | 06:03 | |
| *** _vsaienko has quit IRC | 06:06 | |
| *** rcernin has joined #openstack-ironic | 06:12 | |
| *** amotoki has joined #openstack-ironic | 06:22 | |
| *** amotoki has quit IRC | 06:26 | |
| *** amotoki has joined #openstack-ironic | 06:29 | |
| *** _vsaienko has joined #openstack-ironic | 06:31 | |
| *** _vsaienko has quit IRC | 06:32 | |
| *** zer0c00l_ is now known as zer0c00l | 06:38 | |
| *** Lord_Phoenix has joined #openstack-ironic | 06:41 | |
| openstackgerrit | Markos Chandras proposed openstack/bifrost: Add SUSE support in scripts/env-setup.sh https://review.openstack.org/356964 | 06:45 |
| *** amotoki has quit IRC | 06:51 | |
| *** pcaruana has joined #openstack-ironic | 06:52 | |
| *** hoangcx has quit IRC | 06:53 | |
| *** hoangcx has joined #openstack-ironic | 06:54 | |
| *** amotoki has joined #openstack-ironic | 06:56 | |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with Chassis. https://review.openstack.org/343796 | 06:57 |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with chassis-update https://review.openstack.org/344715 | 06:57 |
| *** amotoki has quit IRC | 07:04 | |
| *** xek__ has quit IRC | 07:08 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DO NOT REVIEW https://review.openstack.org/296432 | 07:09 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Introducing node introspection state management https://review.openstack.org/348943 | 07:13 |
| milan | morning Ironic! :) | 07:13 |
| *** tesseract- has joined #openstack-ironic | 07:17 | |
| *** e0ne has joined #openstack-ironic | 07:18 | |
| *** rbartal has joined #openstack-ironic | 07:24 | |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Tests for testing port-create command https://review.openstack.org/291802 | 07:29 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Bypassing NodeInfo.acquire_lock() to try OOL https://review.openstack.org/356982 | 07:29 |
| milan | aarefiev, morning! I've experimented a bit w/r no-locking in inspector (based on our Tuesday's discussion) and I'd say it's not that crazy ^ please, take a look when you've got some time. I've linked some "screenshots" in the comment. Thx! | 07:35 |
| milan | sambetts|afk, ^^ hi ;) | 07:35 |
| milan | dtantsur|afk, ^^^ morning ;) | 07:35 |
| *** stendulker has joined #openstack-ironic | 07:37 | |
| *** fragatina has joined #openstack-ironic | 07:37 | |
| *** jpich has joined #openstack-ironic | 07:38 | |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Tests for testing node-create command https://review.openstack.org/262055 | 07:40 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: iLO drivers documentation update https://review.openstack.org/356989 | 07:41 |
| *** fragatina has quit IRC | 07:42 | |
| *** ohamada has joined #openstack-ironic | 07:48 | |
| *** hoangcx_ has joined #openstack-ironic | 07:49 | |
| *** hoangcx has quit IRC | 07:50 | |
| openstackgerrit | Yuiko Takada Mori proposed openstack/ironic: Add node serial console documentation https://review.openstack.org/293872 | 07:51 |
| *** amotoki has joined #openstack-ironic | 07:55 | |
| *** amotoki_ has joined #openstack-ironic | 07:57 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** amotoki has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-ironic | 08:01 | |
| * milan relocates | 08:01 | |
| *** milan has quit IRC | 08:01 | |
| *** moshele has joined #openstack-ironic | 08:03 | |
| *** tiendc has quit IRC | 08:07 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 08:10 |
| *** lennyb has quit IRC | 08:13 | |
| moshele | lucasagomes: can you review https://review.openstack.org/#/c/264263/ it has already +2 | 08:19 |
| *** Goneri has joined #openstack-ironic | 08:29 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update configure_tenant_networks https://review.openstack.org/356460 | 08:29 |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with Chassis. https://review.openstack.org/343796 | 08:38 |
| *** athomas has joined #openstack-ironic | 08:41 | |
| *** derekh has joined #openstack-ironic | 08:47 | |
| vdrok | morning ironic! prettu quiet here today :) | 08:54 |
| stendulker | morning vdrok :) | 09:03 |
| vdrok | hey stendulker :) | 09:03 |
| *** e0ne has quit IRC | 09:07 | |
| *** d0ugal has quit IRC | 09:08 | |
| tangchen | milan: Hi Milan, would you please help to review this patch and the related ones ? https://review.openstack.org/#/c/349421/ | 09:09 |
| tangchen | milan: I think I have fixed your comments, and made the experimental functional tests pass. | 09:09 |
| *** d0ugal has joined #openstack-ironic | 09:12 | |
| *** milan has joined #openstack-ironic | 09:13 | |
| *** _vsaienko has joined #openstack-ironic | 09:14 | |
| lucasagomes | morning all :D | 09:17 |
| *** d0ugal_ has joined #openstack-ironic | 09:17 | |
| *** d0ugal_ has quit IRC | 09:18 | |
| *** d0ugal_ has joined #openstack-ironic | 09:18 | |
| tangchen | Morning lucasagomes. | 09:20 |
| *** d0ugal has quit IRC | 09:20 | |
| *** d0ugal_ has quit IRC | 09:20 | |
| *** d0ugal has joined #openstack-ironic | 09:20 | |
| tangchen | lucasagomes: Hi Lucas, please help to confirm this patch. https://review.openstack.org/#/c/347127/ | 09:22 |
| tangchen | lucasagomes: The oneview CI has passed. | 09:22 |
| *** tiendc has joined #openstack-ironic | 09:22 | |
| milan | morning lucasagomes tangchen :) | 09:25 |
| *** sambetts|afk is now known as sambetts | 09:25 | |
| sambetts | Hey milan! Awesome I'll take a look in a minute | 09:26 |
| vdrok | morning lucasagomes tangchen and milan | 09:26 |
| vdrok | morning sambetts :) | 09:26 |
| milan | sambetts, vdrok morning :) | 09:26 |
| sambetts | o/ vdrok, lucasagomes jroll | 09:26 |
| milan | sambetts, thx | 09:27 |
| *** electrofelix has joined #openstack-ironic | 09:28 | |
| sambetts | jroll: We looked into the NetworkTarget when me and dtantsur were experimenting with the different ways of handling waiting for the network devices to come up, unfortunatly the dhcp all interfaces script doesn't play nice with those targets because it runs late in the boot process | 09:30 |
| lucasagomes | sambetts, milan hi there | 09:32 |
| lucasagomes | loads of POST_FAILURE in gate :-/ | 09:33 |
| *** _vsaienko has quit IRC | 09:34 | |
| sambetts | :/ oh dear, infra must be having issues again | 09:35 |
| *** _vsaienko has joined #openstack-ironic | 09:39 | |
| sambetts | milan, am I missing something from your patches? a Depends-On or something? because I don't see how https://review.openstack.org/#/c/356982/ is testing version_id because it doesn't exist yet right? | 09:43 |
| * milan looks | 09:43 | |
| milan | sambetts, I've based in on top of the state patch | 09:44 |
| sambetts | oooooh, I'm being a derp :-P | 09:44 |
| milan | I hope it's the case if you download the patch ;) | 09:44 |
| sambetts | I wish gerrit indicated the chains better | 09:44 |
| milan | sambetts, yeah, it's quite invisible and why it has itself as a related patch I don't follow at all :) | 09:45 |
| sambetts | yeah :/ | 09:46 |
| sambetts | milan: I really like the way these patches are going | 09:57 |
| milan | sambetts, glad to hear that :) | 09:57 |
| *** d0ugal has quit IRC | 09:58 | |
| *** _vsaienko has quit IRC | 09:59 | |
| *** d0ugal has joined #openstack-ironic | 10:04 | |
| *** hoangcx_ has quit IRC | 10:08 | |
| openstackgerrit | Tang Chen proposed openstack/ironic: Move "server_profile_template_uri" to REQUIRED_ON_PROPERTIES https://review.openstack.org/347127 | 10:09 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Allow using TempURLs for deploy images https://review.openstack.org/344160 | 10:14 |
| *** amotoki_ has quit IRC | 10:14 | |
| *** amotoki has joined #openstack-ironic | 10:18 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Fix AgentDeploy take_over() docstring https://review.openstack.org/357076 | 10:27 |
| *** tiendc has quit IRC | 10:28 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Configure clean network to provision network https://review.openstack.org/356632 | 10:28 |
| moshele | lucasagomes: morning :) , can you review https://review.openstack.org/#/c/264263/ it has already +2 | 10:31 |
| *** amotoki has quit IRC | 10:45 | |
| *** amotoki_ has joined #openstack-ironic | 10:46 | |
| lucasagomes | moshele, will do | 10:47 |
| *** zhangjl has quit IRC | 10:54 | |
| *** eset has joined #openstack-ironic | 10:57 | |
| *** eset has quit IRC | 10:57 | |
| *** eset has joined #openstack-ironic | 10:57 | |
| jroll | sambetts: oh, so it's something we inject not being nice? | 11:01 |
| jroll | sambetts: what I'd noticed was "If you use systemd-networkd you can do this by enabling systemd-networkd-wait-online.service... This will ensure that all configured network devices are up and have an IP address assigned before boot continues" | 11:02 |
| sambetts | jroll: problem is the dhcp-all-interfaces enabled the interfaces after than logic has already been passed | 11:02 |
| jroll | sambetts: yeah got it | 11:03 |
| jroll | still sounds like NIH problems | 11:03 |
| jroll | :) | 11:03 |
| sambetts | yeah :/ | 11:06 |
| *** lucasagomes is now known as lucas-hungry | 11:13 | |
| *** Linkmark has joined #openstack-ironic | 11:15 | |
| openstackgerrit | Tang Chen proposed openstack/ironic: Move "server_profile_template_uri" to REQUIRED_ON_PROPERTIES https://review.openstack.org/347127 | 11:23 |
| *** stendulker has quit IRC | 11:24 | |
| openstackgerrit | Ankit Kumar proposed openstack/proliantutils: Fix Inspection failure in Gen7 https://review.openstack.org/357134 | 11:28 |
| *** ninguem has quit IRC | 11:29 | |
| *** Goneri has quit IRC | 11:44 | |
| TheJulia | Good morning everyone | 11:45 |
| vdrok | morning jroll and TheJulia | 11:47 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: [WIP] Add storage_interface DB field and object https://review.openstack.org/348005 | 11:50 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: [WIP] Add storage_interface to base driver class https://review.openstack.org/348006 | 11:51 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: [WIP] Add base cinder common interface https://review.openstack.org/355625 | 11:51 |
| *** dprince has joined #openstack-ironic | 11:52 | |
| *** moshele has quit IRC | 12:00 | |
| *** Goneri has joined #openstack-ironic | 12:00 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Always set DEFAULT/host in devstack. https://review.openstack.org/357154 | 12:08 |
| *** e0ne has joined #openstack-ironic | 12:09 | |
| *** thrash|g0ne is now known as thrash | 12:10 | |
| *** baoli has joined #openstack-ironic | 12:15 | |
| *** moshele has joined #openstack-ironic | 12:15 | |
| *** baoli_ has joined #openstack-ironic | 12:16 | |
| *** lucas-hungry is now known as lucasagomes | 12:19 | |
| *** baoli has quit IRC | 12:20 | |
| *** MattMan has quit IRC | 12:24 | |
| *** MattMan has joined #openstack-ironic | 12:24 | |
| *** athomas has quit IRC | 12:34 | |
| *** thiagop has joined #openstack-ironic | 12:36 | |
| thiagop | Good morning, Ironic | 12:38 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Conductor fails to do take_over for PXE drivers https://review.openstack.org/246033 | 12:39 |
| lucasagomes | vdrok, ^ reworded that release note | 12:39 |
| lucasagomes | hope it's simpler now | 12:39 |
| thiagop | jroll: apparently, I accomplished removing those tests from tempest | 12:39 |
| *** athomas has joined #openstack-ironic | 12:39 | |
| jroll | thiagop: O_O awesome | 12:39 |
| jroll | happy to review :) | 12:39 |
| thiagop | jroll: this one is the thing: https://review.openstack.org/#/c/355586/ | 12:39 |
| *** jcoufal has joined #openstack-ironic | 12:40 | |
| thiagop | jroll: the other one changes our configs on ironic to re-enable them for our gates: https://review.openstack.org/#/c/355591/ | 12:40 |
| jroll | thiagop: okay cool | 12:40 |
| jroll | thiagop: this does mean our jobs will be broken between the two merges | 12:41 |
| jroll | which, we could deal with | 12:41 |
| thiagop | jroll: yup | 12:41 |
| jroll | I wonder if we can stack them the other direction without oslo.config freaking out | 12:41 |
| thiagop | we cannot maintain the configs in both places during the change | 12:41 |
| jroll | boo | 12:42 |
| thiagop | in the first patch I remove them and create a feature-flag | 12:42 |
| thiagop | the second one uncomment the configurations on our plugin's config.py | 12:42 |
| jroll | right, I see that | 12:42 |
| jroll | ok I'll chat with mtreinish today, I feel like he doesn't like a "nova is using ironic" flag | 12:43 |
| jroll | thiagop: thanks for doing this! | 12:43 |
| *** rloo has joined #openstack-ironic | 12:43 | |
| *** rbudden has joined #openstack-ironic | 12:44 | |
| thiagop | jroll: I'd like some reviews from you and the other guy from infra that was talking to us the other day (forgot who he is) before writing proper commit messages | 12:44 |
| thiagop | but I'll create the bug now | 12:44 |
| thiagop | lucasagomes: ^ | 12:44 |
| *** bfournie has quit IRC | 12:45 | |
| * lucasagomes reads the scrollback | 12:45 | |
| jroll | thiagop: cool, I'll look today, I also pointed matt at these in qa channel | 12:45 |
| thiagop | nice, ty | 12:45 |
| thiagop | lucasagomes: the bug about the removal of our old tempest tests from tempest's tree | 12:46 |
| jroll | I don't love breaking the gate, even for a short time, but maybe we just merge it friday night and make sure we aren't landing other things in the meantime | 12:46 |
| lucasagomes | thiagop, oh nice yeah | 12:46 |
| * lucasagomes look at the links | 12:46 | |
| thiagop | jroll: maybe matt has an opinion on how to do that without breaking gates | 12:47 |
| * thiagop feels like a battering ram right now... | 12:47 | |
| lucasagomes | thiagop, luckily (or not) the jobs in tempest is -nv | 12:47 |
| lucasagomes | we def can fast forward the ironic patch once the first is merged if there's no other way | 12:47 |
| lucasagomes | and it would be better if we did this early next week | 12:48 |
| lucasagomes | merging things breaking the gate on thursday/friday is usually scary | 12:48 |
| jroll | thiagop: we can do something in ironic first like, "if option.is_not_defined(): register_opt() or whatever | 12:49 |
| thiagop | lucasagomes: no rush from my side. I just don't want it to be after next week cause I'm leaving UFCG on Aug 31st | 12:49 |
| lucasagomes | thiagop, fair enough | 12:50 |
| jroll | lucasagomes: if we know we have a patch to fix it coming in, it isn't too scary, I'd rather over the weekend because we won't be killing a bunch of work trying to merge | 12:50 |
| lucasagomes | jroll, over the weekend is a good point, probably the gate will be quiet there | 12:50 |
| thiagop | jroll: uhmmm. Didn't see some example of that on config.py. I'll search around a bit... | 12:50 |
| jroll | thiagop: yeah I'm not sure how to do it | 12:50 |
| jroll | maybe hasattr() | 12:50 |
| *** e0ne has quit IRC | 12:52 | |
| *** e0ne has joined #openstack-ironic | 12:55 | |
| *** jtomasek has quit IRC | 12:57 | |
| thiagop | lucasagomes jroll https://bugs.launchpad.net/ironic/+bug/1614516 | 12:59 |
| openstack | Launchpad bug 1614516 in tempest "Move baremetal tests and configs to ironic tree" [Undecided,New] | 12:59 |
| jroll | awesome, thanks | 12:59 |
| *** amotoki_ has quit IRC | 13:00 | |
| lucasagomes | ty | 13:00 |
| *** amotoki has joined #openstack-ironic | 13:06 | |
| *** cdearborn has joined #openstack-ironic | 13:07 | |
| *** ninguem has joined #openstack-ironic | 13:09 | |
| openstackgerrit | Markos Chandras proposed openstack/bifrost: Add SUSE support in scripts/env-setup.sh https://review.openstack.org/356964 | 13:11 |
| *** links has quit IRC | 13:16 | |
| *** bfournie has joined #openstack-ironic | 13:17 | |
| *** adu has joined #openstack-ironic | 13:19 | |
| *** ametts has joined #openstack-ironic | 13:20 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DO NOT REVIEW https://review.openstack.org/296432 | 13:23 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Allow using TempURLs for deploy images https://review.openstack.org/344160 | 13:24 |
| *** amotoki has quit IRC | 13:27 | |
| *** vikrant has quit IRC | 13:30 | |
| *** fumie has quit IRC | 13:37 | |
| *** amotoki has joined #openstack-ironic | 13:37 | |
| xavierr | good morning Ironic | 13:38 |
| sambetts | hi xavierr | 13:39 |
| xavierr | dtantsur|afk: I did it! Now is possible to execute in-band inspection for OneView drivers o/ | 13:39 |
| vdrok | morning thiagop and xavierr | 13:39 |
| xavierr | hey sambetts \o | 13:39 |
| vdrok | lucasagomes: thanks, will take a look | 13:39 |
| thiagop | vdrok: o/ | 13:39 |
| xavierr | hey vdrok :) | 13:40 |
| openstackgerrit | David Lenwell proposed openstack/ironic: Add REST API for volume connector and volume target operation https://review.openstack.org/214586 | 13:45 |
| *** ninguem has quit IRC | 13:46 | |
| openstackgerrit | Hugo Nicodemos proposed openstack/python-oneviewclient: Add auditing instrumentation for python-oneviewclient https://review.openstack.org/337281 | 13:46 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Operator documentation for multitenancy https://review.openstack.org/228496 | 13:50 |
| mtreinish | jroll: fwiw, there is a skip function (or 2) tempest exposes for doing if not defined check | 13:51 |
| mtreinish | jroll: https://github.com/openstack/tempest/blob/master/tempest/config.py#L1310-L1376 | 13:51 |
| jroll | mtreinish: well, that'd just skip all of our tests instead of failing them all, not sure which is worse :) | 13:52 |
| *** adu has quit IRC | 13:53 | |
| mtreinish | probably skipping, because then you didn't know you missed something :) | 13:53 |
| jroll | exactly | 13:53 |
| mtreinish | I was just skimming the backlog around my ping and saw the mention of something similar | 13:54 |
| mtreinish | was missing the whole context | 13:54 |
| jroll | yeah, sorry | 13:54 |
| sambetts | dtantsur: do we have docs explaining how to change the kernal parameters for the inspector IPA image | 13:55 |
| sambetts | ? | 13:56 |
| *** anush_ has joined #openstack-ironic | 14:00 | |
| xavierr | sambetts: After looking to doc/source in inspector repo, I don't think so. | 14:05 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Operator documentation for multitenancy https://review.openstack.org/228496 | 14:09 |
| *** causten has joined #openstack-ironic | 14:09 | |
| *** e0ne has quit IRC | 14:10 | |
| *** Lord_Phoenix has quit IRC | 14:11 | |
| *** e0ne has joined #openstack-ironic | 14:14 | |
| *** syed_ has joined #openstack-ironic | 14:17 | |
| *** baoli_ has quit IRC | 14:23 | |
| *** baoli has joined #openstack-ironic | 14:24 | |
| *** wajdi has joined #openstack-ironic | 14:27 | |
| *** moshele has quit IRC | 14:29 | |
| *** _vsaienko has joined #openstack-ironic | 14:33 | |
| openstackgerrit | Markos Chandras proposed openstack/bifrost: Add SUSE support in scripts/env-setup.sh https://review.openstack.org/356964 | 14:35 |
| *** rama_y has joined #openstack-ironic | 14:37 | |
| *** d0ugal has quit IRC | 14:41 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic-specs: Revise driver composition reform defaults https://review.openstack.org/357262 | 14:44 |
| *** rbartal has quit IRC | 14:44 | |
| *** _vsaienko has quit IRC | 14:44 | |
| TheJulia | dtantsur|afk: ^^^ I think that reflects the discussion fairly well and seems to conceptually make sense to me. Sorry for taking so long to get it posted, things have just been absurdly busy as of recent. :( | 14:46 |
| *** d0ugal has joined #openstack-ironic | 14:48 | |
| *** d0ugal has quit IRC | 14:48 | |
| *** d0ugal has joined #openstack-ironic | 14:48 | |
| *** rajinir has joined #openstack-ironic | 14:49 | |
| openstackgerrit | Markos Chandras proposed openstack/bifrost: Restore stable-2.0 as the default Ansible branch https://review.openstack.org/357268 | 14:52 |
| TheJulia | Hmm... wonder if that is going to pass CI | 14:53 |
| * TheJulia hopes it does | 14:53 | |
| *** _vsaienko has joined #openstack-ironic | 14:55 | |
| *** penick has quit IRC | 14:59 | |
| *** michauds has joined #openstack-ironic | 15:00 | |
| *** milan has quit IRC | 15:00 | |
| *** thrash is now known as thrash|biab | 15:00 | |
| *** abashmak has left #openstack-ironic | 15:02 | |
| *** hshiina has quit IRC | 15:03 | |
| *** mari0jv has joined #openstack-ironic | 15:03 | |
| *** sabeen has joined #openstack-ironic | 15:04 | |
| *** Linkmark has quit IRC | 15:05 | |
| *** d0ugal has quit IRC | 15:09 | |
| *** bfournie has left #openstack-ironic | 15:15 | |
| *** _vsaienko has quit IRC | 15:17 | |
| *** bfournie has joined #openstack-ironic | 15:18 | |
| *** michauds has quit IRC | 15:19 | |
| *** bfournie has left #openstack-ironic | 15:19 | |
| *** bfournie has joined #openstack-ironic | 15:19 | |
| *** mmedvede has quit IRC | 15:21 | |
| *** rcernin has quit IRC | 15:22 | |
| *** d0ugal has joined #openstack-ironic | 15:24 | |
| *** thrash|biab is now known as thrash | 15:25 | |
| *** rbudden has quit IRC | 15:27 | |
| *** moshele has joined #openstack-ironic | 15:27 | |
| *** sdake_ has joined #openstack-ironic | 15:29 | |
| JayF | I have a chain of patches up to add a docs build to ironic-lib, then add metrics docs on top of that: https://review.openstack.org/#/c/356753/ https://review.openstack.org/#/c/356761/ https://review.openstack.org/#/c/356796/ | 15:29 |
| JayF | the first couple, at least, should be very easy reviews if someone has the time. I'd like to get the ironic-lib docs build in project-config before the end of the week if possible. | 15:29 |
| *** e0ne has quit IRC | 15:30 | |
| *** rbudden has joined #openstack-ironic | 15:31 | |
| *** _vsaienko has joined #openstack-ironic | 15:31 | |
| *** _vsaienko has quit IRC | 15:34 | |
| *** mmedvede has joined #openstack-ironic | 15:34 | |
| *** rbudden has quit IRC | 15:35 | |
| *** _vsaienko has joined #openstack-ironic | 15:41 | |
| *** mmedvede has quit IRC | 15:45 | |
| *** jvgrant has joined #openstack-ironic | 15:45 | |
| *** michauds has joined #openstack-ironic | 15:52 | |
| devananda | g'morning, all | 15:56 |
| *** _vsaienko has quit IRC | 15:56 | |
| lucasagomes | devananda, morning | 15:59 |
| jroll | hey devananda | 15:59 |
| vdrok | morning devananda | 16:01 |
| *** _vsaienko has joined #openstack-ironic | 16:02 | |
| lucasagomes | JayF, have time to fix few nits in at #356753 ? | 16:04 |
| JayF | in a meeting but I'll work on it while I'm meeting | 16:05 |
| *** hjanssen-hpe has joined #openstack-ironic | 16:06 | |
| *** hpe-hj has joined #openstack-ironic | 16:07 | |
| * jlvillal sees that Pike and Queens are the code names for the upcoming releases | 16:07 | |
| JayF | lucasagomes: will do doc8 as a followon, it won't pass until my second patch in that set | 16:07 |
| lucasagomes | JayF, fair enough | 16:07 |
| vdrok | morning JayF and jlvillal | 16:13 |
| openstackgerrit | Merged openstack/ironic: Copy iPXE script over only when needed https://review.openstack.org/356562 | 16:14 |
| vdrok | JayF: also in the second patch class level vars are included in the generated docs for some reason | 16:14 |
| jlvillal | Good morning vdrok and everyone else :) | 16:14 |
| vdrok | in the exception.py and metrics_statsd at least | 16:14 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-lib: Add framework for doc building in ironic-lib https://review.openstack.org/356753 | 16:14 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Update code to use Pike as the code name https://review.openstack.org/357334 | 16:15 |
| *** causten has quit IRC | 16:15 | |
| *** sdake_ has quit IRC | 16:16 | |
| *** ametts has quit IRC | 16:16 | |
| sambetts | jlvillal: has the names changes since I last saw them? I though they had gone with Pico and Questa? | 16:17 |
| *** causten has joined #openstack-ironic | 16:17 | |
| jlvillal | sambetts: http://lists.openstack.org/pipermail/openstack-dev/2016-August/101891.html | 16:17 |
| JayF | lucasagomes: ^^^ fixed | 16:18 |
| *** rbrud has joined #openstack-ironic | 16:18 | |
| jlvillal | sambetts: I never saw anything official about Pico and Questa. I did see an internetnews.com article that said it was that. | 16:18 |
| lucasagomes | JayF, +2 | 16:18 |
| *** _vsaienko has quit IRC | 16:18 | |
| jlvillal | sambetts: They were wrong: http://www.internetnews.com/blog/skerner/openstack-pico-and-questa-set-to-debut-in-2017-and-2018..html | 16:18 |
| sambetts | jlvillal: well I'm sure thats confused a load of people... | 16:19 |
| jlvillal | sambetts: No doubt. I had a co-worker send me that a couple weeks ago telling me that those were the names. | 16:20 |
| sambetts | jlvillal: yeah same... :/ | 16:20 |
| *** Goneri has quit IRC | 16:20 | |
| *** mtanino has joined #openstack-ironic | 16:20 | |
| *** ametts has joined #openstack-ironic | 16:21 | |
| NobodyCam | Good Morning Ironic'ers :) | 16:22 |
| sambetts | o/ NobodyCam | 16:22 |
| NobodyCam | morning sambetts :) | 16:22 |
| *** causten has quit IRC | 16:22 | |
| *** causten has joined #openstack-ironic | 16:24 | |
| *** michauds has quit IRC | 16:25 | |
| *** tesseract- has quit IRC | 16:26 | |
| * sambetts -> home | 16:26 | |
| sambetts | night everyone | 16:26 |
| *** sambetts is now known as sambetts|afk | 16:27 | |
| NobodyCam | night sambetts|afk | 16:28 |
| *** stendulker has joined #openstack-ironic | 16:32 | |
| *** baoli has quit IRC | 16:32 | |
| lucasagomes | NobodyCam, morning | 16:33 |
| NobodyCam | morning lucasagomes | 16:33 |
| *** ohamada has quit IRC | 16:33 | |
| NobodyCam | hey question. anyone have a link to some good info on tftp mapfile rule writing ? | 16:34 |
| *** ccamacho has quit IRC | 16:34 | |
| *** _vsaienko has joined #openstack-ironic | 16:36 | |
| *** rbudden has joined #openstack-ironic | 16:39 | |
| *** amotoki has quit IRC | 16:40 | |
| JayF | vdrok: let me ask this question: are class vars included in generated docs for ipa/ironic today | 16:40 |
| JayF | vdrok: the answer is almost certainly yes, because I copypasted the config | 16:41 |
| openstackgerrit | Merged openstack/ironic: Adding InfiniBand Support https://review.openstack.org/264263 | 16:41 |
| JayF | vdrok: so maybe if that bugs you, file a bug to fix it everywhere? I'd rather not introduce a different config in ironic-lib vs ironic/ipa | 16:41 |
| lucasagomes | folks I'm calling it a day | 16:41 |
| *** jpich has quit IRC | 16:41 | |
| lucasagomes | have a great evening all | 16:41 |
| NobodyCam | have a good night lucasagomes | 16:41 |
| lucasagomes | you too | 16:42 |
| vdrok | JayF: I looked at the docs for exceptions.py in ironic - they are not there I think http://docs.openstack.org/developer/ironic/api/ironic.common.exception.html#module-ironic.common.exception | 16:42 |
| lucasagomes | talk later | 16:42 |
| *** lucasagomes is now known as lucas-dinner | 16:42 | |
| vdrok | night lucas-dinner | 16:42 |
| vdrok | there are some of them with status code defined at class level | 16:42 |
| vdrok | but it's not in the docs | 16:42 |
| vdrok | functions are not included too | 16:43 |
| vdrok | I mean inside classes | 16:43 |
| *** sdake has joined #openstack-ironic | 16:43 | |
| vdrok | I won't be blocking because of that, just pointing out that we have to fix it at some point I think | 16:43 |
| vdrok | ah, no, functions are there | 16:46 |
| JayF | vdrok: I can't find any difference in the config in ironic :/ | 16:47 |
| vdrok | yep, me too | 16:47 |
| vdrok | it should work the same | 16:47 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-lib: Enforce doc8, make it pass, + fix inaccuracies https://review.openstack.org/356761 | 16:48 |
| JayF | jroll: lucas-dinner ^ | 16:48 |
| jroll | sweetness | 16:49 |
| jroll | thanks | 16:49 |
| jroll | JayF: what's D001? | 16:49 |
| JayF | too-long-line | 16:49 |
| JayF | which is basically impossible to pass b/c you have to have long lines sometimes | 16:50 |
| jroll | boo, I like that one | 16:50 |
| JayF | for links | 16:50 |
| jroll | oh yeah | 16:50 |
| jroll | vdrok++ for pointing out warn_errors in setup.cfg, I forgot that's where it was :) | 16:50 |
| JayF | yeah but it doesn't work | 16:50 |
| JayF | lol | 16:50 |
| vdrok | heh yeah, it's hard sometimes to get sphinx right :) | 16:51 |
| jroll | it's supposed to in an upcoming versino of pbr | 16:52 |
| JayF | ayup | 16:52 |
| JayF | and it's going to blow up the ironic docs build jfyi | 16:52 |
| *** _vsaienko has quit IRC | 16:52 | |
| *** ccamacho has joined #openstack-ironic | 16:52 | |
| JayF | as I noticed when rendering metrics docs yesterday | 16:52 |
| jroll | ugh, we fixed that once | 16:53 |
| *** _vsaienko has joined #openstack-ironic | 16:53 | |
| JayF | yep | 16:53 |
| JayF | once devananda's refactor of that index page goes through I'll try and tackle them | 16:54 |
| JayF | I've done it before so I have an idea how to fix some of them | 16:54 |
| jroll | cool, ty | 16:54 |
| devananda | doc build generates ~570 warnings right now | 16:54 |
| devananda | most (all?) are from pages that it autogenereates from code, that aren't linked anywhere | 16:55 |
| devananda | I haven't dug into how to disable that | 16:55 |
| JayF | The easiest way is to make a page that indexes all autogenerated docs | 16:56 |
| JayF | and linking it from somewhere :) | 16:56 |
| JayF | I don't mind tackling it after this stuff gets in though | 16:56 |
| *** derekh has quit IRC | 16:59 | |
| *** fragatina has joined #openstack-ironic | 16:59 | |
| *** fragatina has quit IRC | 17:00 | |
| *** fragatina has joined #openstack-ironic | 17:00 | |
| *** anush_ has quit IRC | 17:00 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-lib: Add developer documentation on metrics https://review.openstack.org/356796 | 17:02 |
| *** sabeen has quit IRC | 17:03 | |
| vdrok | folks, if you have some time - https://review.openstack.org/354744 | 17:03 |
| *** _vsaienko has quit IRC | 17:03 | |
| JayF | looking | 17:03 |
| *** electrofelix has quit IRC | 17:03 | |
| *** vishwanathj_zzz is now known as vishwanathj | 17:04 | |
| JayF | vdrok: reviewied, but only +1 because I don't know the object code very well :/ | 17:04 |
| vdrok | JayF: heh, nobody does :) | 17:04 |
| vdrok | thanks! | 17:05 |
| *** stendulker has quit IRC | 17:07 | |
| *** stendulker has joined #openstack-ironic | 17:09 | |
| *** stendulker has quit IRC | 17:10 | |
| *** stendulker has joined #openstack-ironic | 17:10 | |
| stendulker | devananda: Hi | 17:10 |
| vdrok | good night everyone! | 17:11 |
| stendulker | devananda: Patch for RFE https://bugs.launchpad.net/ironic/+bug/1588177 has been re-proposed | 17:11 |
| openstack | Launchpad bug 1588177 in Ironic "RFE: Allow ilo drivers to choose the ports to be inspected" [Undecided,In progress] - Assigned to Bharath kumar (bharath-kumar3) | 17:11 |
| JayF | devananda: you commented "done" on all the stuff for https://review.openstack.org/#/c/356788 but never pushed the new patch up? accidental? | 17:12 |
| stendulker | devananda: This is based on the same approach that was discussed when inspection was enabled in Ironic. The approach was to allow user to specify the nic ports for which Ironic ports would be created | 17:12 |
| *** aNupoisc has joined #openstack-ironic | 17:12 | |
| *** anush_ has joined #openstack-ironic | 17:14 | |
| stendulker | devananda: You were not convinced with that approach at that time. Would you please look at this patch for the same. https://review.openstack.org/#/c/325230/ | 17:14 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add key_value_pairs_to_dict() method https://review.openstack.org/357363 | 17:14 |
| devananda | JayF: I'm reorganizing the dev-quickstart after you pointed out the bad heading issue | 17:15 |
| JayF | aha | 17:15 |
| JayF | :( | 17:15 |
| devananda | I don't htink it was rendering well to begin with, actually | 17:15 |
| JayF | that didn't look like it'd be a fun one to tackle | 17:15 |
| devananda | not that bad | 17:15 |
| *** fragatina has quit IRC | 17:16 | |
| devananda | but now that I look at it more, I want to reorganize the page | 17:16 |
| *** mmedvede has joined #openstack-ironic | 17:18 | |
| openstackgerrit | lokesh s proposed openstack/ironic: Renaming audit map conf sample file https://review.openstack.org/350399 | 17:20 |
| *** electrofelix has joined #openstack-ironic | 17:21 | |
| *** electrofelix has quit IRC | 17:22 | |
| *** athomas has quit IRC | 17:25 | |
| *** dprince has quit IRC | 17:30 | |
| *** stendulker has quit IRC | 17:36 | |
| *** _vsaienko has joined #openstack-ironic | 17:36 | |
| *** baoli has joined #openstack-ironic | 17:37 | |
| mjturek1 | hey devananda, After monday's neutron-ironic meeting I drafted up this nova patch to fail early if portgroups are used. Is this what you were thinking we should do? https://review.openstack.org/#/c/357222/ I'm not sure if we could fail earlier | 17:39 |
| *** sabeen has joined #openstack-ironic | 17:41 | |
| *** dprince has joined #openstack-ironic | 17:48 | |
| *** rcernin has joined #openstack-ironic | 17:51 | |
| *** baoli has quit IRC | 17:56 | |
| *** baoli has joined #openstack-ironic | 17:56 | |
| *** Sukhdev has joined #openstack-ironic | 18:05 | |
| *** jtomasek has joined #openstack-ironic | 18:08 | |
| *** mmedvede- has joined #openstack-ironic | 18:08 | |
| jroll | going to lunch, bbl | 18:09 |
| *** fragatina has joined #openstack-ironic | 18:11 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Adds node boot-device & passthu OSC commands https://review.openstack.org/357400 | 18:11 |
| *** moshele has quit IRC | 18:13 | |
| *** _vsaienko has quit IRC | 18:14 | |
| *** persia has quit IRC | 18:30 | |
| *** persia has joined #openstack-ironic | 18:32 | |
| *** _vsaienko has joined #openstack-ironic | 18:38 | |
| *** michauds has joined #openstack-ironic | 18:38 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Documentation update https://review.openstack.org/356788 | 18:42 |
| devananda | JayF: big changes to devquickstart .... ^ | 18:42 |
| devananda | I believe I covered everything else you mentioned | 18:42 |
| JayF | devananda: you completely removed the part abouve vagrant? | 18:44 |
| JayF | *about | 18:44 |
| devananda | no | 18:45 |
| devananda | it's moved and much smaller | 18:45 |
| JayF | oh there we go, found it second time through | 18:45 |
| JayF | man, that was awfully verbose before compared to this | 18:45 |
| devananda | yep | 18:46 |
| JayF | let me render it locally and look at that | 18:46 |
| JayF | it it look alright I'll +2 before lunch | 18:46 |
| devananda | also, "here's the complex long path .... oh, and option 2, the easy way" | 18:46 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic: Add metrics to administrator guide https://review.openstack.org/356811 | 18:46 |
| devananda | so likely someone will overlook it | 18:46 |
| devananda | so I put "here's the short easy way, and heeeeere's the long way" | 18:46 |
| JayF | devananda: ^ mind having a look at that too, since it's based off yours | 18:46 |
| JayF | I just rebased it using the nifty gerrit button | 18:46 |
| devananda | sure thing | 18:46 |
| devananda | nice :) | 18:47 |
| devananda | and then i'm grabbing lunch too | 18:47 |
| JayF | then maybe whoever comes along to land yours will land mine :) | 18:47 |
| *** catintheroof has joined #openstack-ironic | 18:49 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DO NOT REVIEW https://review.openstack.org/296432 | 18:52 |
| devananda | JayF: mind if I take a stab at editing your doc patch, rather than commenting on it? | 18:52 |
| JayF | devananda: I mean, I never mind folks updating my patches, but if you just comment you can preserve the ability to +2 it :) | 18:53 |
| JayF | "Hey, I wanna do your work for you" "OK by me!" lol | 18:53 |
| devananda | heh | 18:53 |
| JayF | devananda: I'd also suggest reviewing the ironic-lib metrics docs, as it goes into a little more detail about what the metrics are as wel | 18:54 |
| JayF | devananda: so you can get an idea how the docs work together | 18:54 |
| *** rbrud has quit IRC | 18:57 | |
| devananda | review posted, going to edit real quick | 18:57 |
| JayF | if you want I can just make those changes | 18:57 |
| JayF | I'm here and can fix it before lunch | 18:57 |
| *** _vsaienko has quit IRC | 18:57 | |
| JayF | devananda: I just kinda wanna kill the first 3 L2 headings | 18:58 |
| JayF | devananda: and I think that fixes the whole thing up. | 18:58 |
| *** jtomasek has quit IRC | 18:59 | |
| *** _vsaienko has joined #openstack-ironic | 18:59 | |
| JayF | devananda: /me holding off on pushing a fix patchset to not nuke yuor change | 19:00 |
| *** _vsaienko has quit IRC | 19:01 | |
| *** _vsaienko has joined #openstack-ironic | 19:01 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: Bring configurations from tempest to ironic_tempest_plugin https://review.openstack.org/355591 | 19:02 |
| devananda | JayF: building locally, will push shortly | 19:07 |
| devananda | including the comments you fixed | 19:08 |
| devananda | *commented | 19:08 |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Add metrics to administrator guide https://review.openstack.org/356811 | 19:09 |
| devananda | JayF: I put the config group together, and hte metrics group together | 19:10 |
| openstackgerrit | Hugo Nicodemos proposed openstack/python-oneviewclient: Add auditing instrumentation for python-oneviewclient https://review.openstack.org/337281 | 19:10 |
| devananda | makes things look cleaner, easier to navigate, IMHO | 19:10 |
| * devananda lunches | 19:11 | |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add classes for Portgroups API enablement https://review.openstack.org/347549 | 19:12 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add openstack baremetal chassis commands https://review.openstack.org/345815 | 19:13 |
| *** _vsaienko has quit IRC | 19:20 | |
| rloo | hi, is the gate golden today? the etherpad still indicates it is broken. it looks like ironic is ok? not sure about ironicclient? | 19:28 |
| openstackgerrit | Xavier proposed openstack/ironic: Fix for check if dynamic allocation model is enabled https://review.openstack.org/357425 | 19:28 |
| *** sabeen has quit IRC | 19:34 | |
| *** e0ne has joined #openstack-ironic | 19:34 | |
| openstackgerrit | Merged openstack/ironic: Clean imports in code https://review.openstack.org/355704 | 19:45 |
| openstackgerrit | Merged openstack/ironic: Fix incorrect order of params of assertEqual() https://review.openstack.org/355708 | 19:45 |
| openstackgerrit | Merged openstack/ironic: Fix test_find_node_by_macs test https://review.openstack.org/355776 | 19:46 |
| jroll | devananda: this update is awesome! | 19:47 |
| jroll | left some comments | 19:47 |
| jroll | holy cow we merged infiniband \o/ | 19:47 |
| jroll | I guess that means ironic's gate is happy | 19:47 |
| jroll | client gate looks okay too | 19:48 |
| jroll | rloo: ^^ | 19:48 |
| rloo | jroll: thx. | 19:48 |
| jroll | np | 19:48 |
| * jroll updates whiteboard | 19:48 | |
| openstackgerrit | Łukasz proposed openstack/ironic: Fix typo: interations -> iterations. https://review.openstack.org/357437 | 19:52 |
| *** moshele has joined #openstack-ironic | 20:06 | |
| JayF | devananda: reviewed. would like your thought on the comments before I fix it up | 20:10 |
| *** moshele has quit IRC | 20:12 | |
| openstackgerrit | Xavier proposed openstack/ironic: Fix for check if dynamic allocation model is enabled https://review.openstack.org/357425 | 20:14 |
| xavierr | morning rloo :) | 20:17 |
| rloo | hi xavierr | 20:17 |
| openstackgerrit | Merged openstack/ironic: Use memory mode for sqlite in db test https://review.openstack.org/355738 | 20:18 |
| openstackgerrit | Merged openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/356919 | 20:20 |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Allow changing lock purpose on lock upgrade https://review.openstack.org/356064 | 20:20 |
| xavierr | rloo: may you tell your opinion on these 8 lines? https://review.openstack.org/#/c/357425/1..2/ | 20:21 |
| xavierr | rloo: isinstance vs str question | 20:21 |
| xavierr | xavierr: :) | 20:21 |
| xavierr | rloo: :) | 20:21 |
| JayF | rloo: would love your review specifically on https://review.openstack.org/#/c/356796/2/doc/source/index.rst -- that is supposed to cover a lot of the metrics questions that I think you originally had when the spec came out. | 20:22 |
| rloo | xavierr: not sure what you are asking? | 20:22 |
| mat128 | xavierr: isn't there something in oslo for "looks like true/false" ? | 20:23 |
| rloo | JayF: ok... | 20:23 |
| mat128 | xavierr: http://docs.openstack.org/developer/oslo.utils/api/strutils.html#oslo_utils.strutils.bool_from_string | 20:23 |
| rloo | mat128, xavierr: OH, is that what you want to know? Yes, mat128 is right. | 20:23 |
| rloo | xavierr: ^^, see you didn't need to ask me :) | 20:24 |
| xavierr | rloo: ok ruby, thank you! | 20:26 |
| * devananda returns from lunch | 20:26 | |
| xavierr | mat128: I didn't know that method :) | 20:26 |
| devananda | jroll: glad you like the doc update | 20:26 |
| devananda | JayF: comments read. update away. | 20:27 |
| devananda | JayF: re: limiting the statement to timing data, I feel like that's acceptable because the doc should refer to what exists, not what _could_ exist | 20:28 |
| devananda | JayF: when we add metrics for other things, we should update the doc | 20:28 |
| openstackgerrit | Ricardo Araújo Santos proposed openstack/ironic: Adds instructions to perform nodes migration https://review.openstack.org/357454 | 20:28 |
| JayF | devananda: True; but I feel like timing vs counter vs gauge should be referenced in the "metrics emitted" section, not the intro | 20:28 |
| jroll | mat128: lol, I saw that patch, spent a couple minutes looking for that, came back to ask if anyone knew about something like that, read scrollback :D | 20:30 |
| mat128 | :) | 20:30 |
| mat128 | I knew it was in oslo | 20:30 |
| devananda | JayF: wdyt: s/emitting ... data to statsd/integration with statsd/ ? | 20:30 |
| mat128 | jroll: google-fu https://www.google.ca/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=oslo%20boolean | 20:30 |
| JayF | emitting internal performance data | 20:30 |
| JayF | is what I was going to go with | 20:30 |
| devananda | works for me | 20:30 |
| jroll | mat128: yeah, I was poking around various parse_driver_info methods | 20:31 |
| *** baoli has quit IRC | 20:34 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic: Add metrics to administrator guide https://review.openstack.org/356811 | 20:34 |
| JayF | devananda: ^ | 20:34 |
| *** causten has quit IRC | 20:35 | |
| *** jcoufal_ has joined #openstack-ironic | 20:35 | |
| devananda | JayF: LGTM | 20:36 |
| devananda | jroll: I can add a .htaccess to the root of the built html files :-D | 20:36 |
| * devananda spins up a local apache server to test this ... | 20:37 | |
| rloo | would someone explain to me why we want to do this? https://review.openstack.org/#/c/355704/ | 20:37 |
| *** jcoufal has quit IRC | 20:37 | |
| jroll | devananda: can you? I guess just cp doc/source/.htaccess doc/build/html/.htaccess? | 20:38 |
| JayF | rloo: http://docs.openstack.org/developer/hacking/#imports openstack coding guidelines indicate you should only import modules, not objects | 20:38 |
| mat128 | rloo: I don't see whats wrong with importing classes, other than potential name clashes | 20:38 |
| rloo | JayF: I can see that. But WHY? | 20:38 |
| JayF | rloo: as for why someone took time to actually fix that across the board, IDK | 20:38 |
| * JayF has no idea | 20:38 | |
| rloo | JayF: I don't feel like being a baaaa today... | 20:38 |
| JayF | I am not pythonic enough to know what is good and what is evil :) So I follow the rules | 20:39 |
| JayF | lol | 20:39 |
| rloo | JayF: if it is a hacking thing, wouldn't our pep8 jobs fail? | 20:39 |
| jroll | either that hacking check got removed or it's broken, I guess | 20:39 |
| mat128 | JayF: the pythonista in me cannot understand that requirement, other than it being a "style" thing | 20:39 |
| jroll | pep8 used to handle it | 20:39 |
| jroll | it's about easily recognizing where something comes from, without poking around a bunch of imports | 20:39 |
| rloo | i really hate it when someone starts submitting patches to change some sort of style thing, if it isn't something we care about. | 20:40 |
| mat128 | ctrl+click is your friend :) | 20:40 |
| devananda | jroll: I add a setting in doc/source/conf.py | 20:40 |
| mat128 | but yeah, readability | 20:40 |
| devananda | jroll: and add a .htaccess file in doc/source/ | 20:40 |
| jroll | mat128: itym ctrl+] | 20:40 |
| rloo | so yeah, i agree about readability. | 20:40 |
| JayF | rloo: tyvm for the review; was the explaination section about timers/counters/gauges helpful? | 20:40 |
| *** aNupoisc has quit IRC | 20:41 | |
| jroll | devananda: oh, neat. we might want to make sure that doesn't collide with any existing htaccess things docs folks already have | 20:41 |
| devananda | mat128: it is to avoid ambiguous method names | 20:41 |
| devananda | mat128: in a project as large as openstack, only importing modules (and naming our modules well) makes everything much more readable for folks not deeply versed in a project | 20:41 |
| rloo | JayF: yes. I think i figured that out from looking at the actual code. Probably good for someone to read it that hasn't looked/used the methods. | 20:41 |
| devananda | mat128: put another way, it's easier to jump into a file, read it, figure out what's wrong -- and backtrack it to othre modules -- when you only import modules | 20:42 |
| devananda | jroll: good point. i know nothing about those | 20:42 |
| mat128 | devananda: agreed | 20:42 |
| openstackgerrit | Merged openstack/python-ironicclient: Fail with more meaningful error while creating client https://review.openstack.org/344791 | 20:42 |
| jroll | devananda: I know they do them for folks sometimes | 20:42 |
| *** causten has joined #openstack-ironic | 20:43 | |
| *** baoli has joined #openstack-ironic | 20:44 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-lib: Add developer documentation on metrics https://review.openstack.org/356796 | 20:48 |
| ricardoas | JayF: hey! I've submitted a patch with the instructions to migrate nodes from pre-allocation to dynamic allocation in https://review.openstack.org/357454 | 20:49 |
| jroll | look at all these docs patches today! \o/ | 20:49 |
| * jroll loves it | 20:49 | |
| JayF | thanks | 20:49 |
| ricardoas | JayF: it would be great if you could take a look :) | 20:50 |
| JayF | I have it open already | 20:50 |
| openstackgerrit | Merged openstack/ironic-inspector: Fix order of arguments in assertEqual https://review.openstack.org/356391 | 20:53 |
| *** sabeen has joined #openstack-ironic | 20:54 | |
| JayF | ricardoas: posted a review for you. good start, ty | 20:59 |
| *** aNupoisc has joined #openstack-ironic | 21:01 | |
| *** dprince has quit IRC | 21:02 | |
| ricardoas | JayF: thanks! | 21:04 |
| *** e0ne has quit IRC | 21:04 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-lib: Add developer documentation on metrics https://review.openstack.org/356796 | 21:08 |
| * jroll is out for the night, see yall tomorrow | 21:12 | |
| JayF | o/ | 21:12 |
| rloo | ciao jroll | 21:13 |
| rloo | devananda: which has higher priority, your api-ref patch or documentation-update one? I may have time to look at one today. | 21:14 |
| mrda | Morning Ironic | 21:20 |
| *** bfournie has quit IRC | 21:21 | |
| *** catintheroof has quit IRC | 21:21 | |
| openstackgerrit | Merged openstack/ironic-lib: Add framework for doc building in ironic-lib https://review.openstack.org/356753 | 21:23 |
| *** Goneri has joined #openstack-ironic | 21:23 | |
| *** baoli has quit IRC | 21:24 | |
| *** rloo has quit IRC | 21:24 | |
| *** rloo has joined #openstack-ironic | 21:25 | |
| *** baoli has joined #openstack-ironic | 21:25 | |
| *** wajdi_ has joined #openstack-ironic | 21:32 | |
| *** jcoufal_ has quit IRC | 21:34 | |
| *** wajdi has quit IRC | 21:35 | |
| *** baoli has quit IRC | 21:35 | |
| *** wajdi_ has quit IRC | 21:36 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic-specs: Changes to some OSC commands https://review.openstack.org/357505 | 21:42 |
| openstackgerrit | Merged openstack/ironic-lib: Enforce doc8, make it pass, + fix inaccuracies https://review.openstack.org/356761 | 21:44 |
| *** thrash is now known as thrash|g0ne | 21:49 | |
| devananda | rloo: if it's still a choice, api-ref | 21:50 |
| rloo | devananda: i have about 10 min left. hmm. maybe early next week. | 21:52 |
| devananda | rloo: the api-ref change is really small, actually | 21:52 |
| devananda | actually, I need to update that real quick | 21:52 |
| rloo | devananda: ha ha. | 21:53 |
| devananda | rloo: have a good weekend. but pls take a look at it on monday, if it's not landed by then :) | 21:53 |
| rloo | devananda: thx and will do! (we all hope it will land by then!) | 21:54 |
| openstackgerrit | Thiago Paiva Brito proposed openstack/python-oneviewclient: Re-authenticating on session invalidation https://review.openstack.org/357509 | 22:00 |
| *** thiagop has quit IRC | 22:16 | |
| *** hpe-hj has quit IRC | 22:16 | |
| *** hjanssen-hpe has quit IRC | 22:16 | |
| anish | ifarkas_afk: does python-dracclient not pull any lifecycle settings on purpose, or was there just not a use case for them | 22:18 |
| *** Goneri has quit IRC | 22:20 | |
| *** cdearborn has quit IRC | 22:24 | |
| openstackgerrit | Devananda van der Veen proposed openstack/ironic: Update api-ref for v1.22 https://review.openstack.org/353117 | 22:32 |
| *** ametts has quit IRC | 22:51 | |
| *** ccamacho has quit IRC | 22:54 | |
| *** ccamacho1 has joined #openstack-ironic | 22:54 | |
| *** michauds has quit IRC | 23:07 | |
| *** sdake_ has joined #openstack-ironic | 23:12 | |
| *** sdake has quit IRC | 23:13 | |
| *** ccamacho1 has quit IRC | 23:14 | |
| *** bfournie has joined #openstack-ironic | 23:15 | |
| *** aNupoisc has quit IRC | 23:15 | |
| *** chlong has quit IRC | 23:20 | |
| openstackgerrit | Merged openstack/ironic: Remove CONF.import_opt() from api/controllers/v1/node.py https://review.openstack.org/354012 | 23:20 |
| *** mari0jv has quit IRC | 23:22 | |
| *** fumie has joined #openstack-ironic | 23:23 | |
| *** vishwanathj has quit IRC | 23:29 | |
| *** rcernin has quit IRC | 23:32 | |
| openstackgerrit | Merged openstack/python-oneviewclient: Re-authenticating on session invalidation https://review.openstack.org/357509 | 23:51 |
| *** aNupoisc has joined #openstack-ironic | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!