| *** mtanino has quit IRC | 00:00 | |
| *** praneshp has joined #openstack-ironic | 00:00 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/359458 | 00:09 |
|---|---|---|
| openstackgerrit | Merged openstack/ironic-python-agent: Fixes programmatic error in _install_grub() https://review.openstack.org/314147 | 00:10 |
| *** chlong has quit IRC | 00:13 | |
| *** chlong has joined #openstack-ironic | 00:26 | |
| *** bfournie has joined #openstack-ironic | 00:49 | |
| *** hoangcx has joined #openstack-ironic | 00:52 | |
| *** thrash is now known as thrash|g0ne | 00:55 | |
| *** tuanla_ has joined #openstack-ironic | 01:02 | |
| *** phuongnh has joined #openstack-ironic | 01:06 | |
| *** sdake has quit IRC | 01:06 | |
| *** Sukhdev has quit IRC | 01:10 | |
| *** rloo has quit IRC | 01:11 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironic-inspector-client: Updated from global requirements https://review.openstack.org/360151 | 01:11 |
| *** hoangcx has quit IRC | 01:23 | |
| *** hoangcx has joined #openstack-ironic | 01:31 | |
| *** baoli has joined #openstack-ironic | 01:32 | |
| *** sdake has joined #openstack-ironic | 01:36 | |
| *** sdake_ has joined #openstack-ironic | 01:39 | |
| *** sdake has quit IRC | 01:42 | |
| openstackgerrit | Tang Chen proposed openstack/python-ironicclient: Use osc_lib instead of cliff https://review.openstack.org/334803 | 01:45 |
| openstackgerrit | Tang Chen proposed openstack/python-ironicclient: Use osc-lib instead of openstackclient https://review.openstack.org/333311 | 01:45 |
| *** aNupoisc has quit IRC | 01:49 | |
| *** sdake_ has quit IRC | 01:54 | |
| *** mtanino has joined #openstack-ironic | 01:58 | |
| *** sabeen has quit IRC | 02:01 | |
| *** sdake has joined #openstack-ironic | 02:04 | |
| *** jrist has quit IRC | 02:05 | |
| *** sabeen has joined #openstack-ironic | 02:10 | |
| *** yibo has quit IRC | 02:13 | |
| *** jrist has joined #openstack-ironic | 02:18 | |
| *** jcook has quit IRC | 02:22 | |
| *** jcook has joined #openstack-ironic | 02:22 | |
| *** serverascode has quit IRC | 02:28 | |
| *** serverascode has joined #openstack-ironic | 02:30 | |
| *** mtanino has quit IRC | 02:31 | |
| *** syed_ has quit IRC | 02:32 | |
| *** sdake has quit IRC | 02:34 | |
| *** sdake has joined #openstack-ironic | 02:35 | |
| *** rama_y has joined #openstack-ironic | 02:39 | |
| *** sdake has quit IRC | 02:45 | |
| *** sdake has joined #openstack-ironic | 02:47 | |
| *** yuanying has quit IRC | 02:49 | |
| *** yuanying has joined #openstack-ironic | 02:53 | |
| *** rbudden has quit IRC | 02:53 | |
| *** zhangjl has joined #openstack-ironic | 03:00 | |
| *** hoangcx has quit IRC | 03:07 | |
| *** sdake has quit IRC | 03:12 | |
| *** hoangcx has joined #openstack-ironic | 03:15 | |
| *** chlong has quit IRC | 03:23 | |
| *** vishwanathj has joined #openstack-ironic | 03:25 | |
| *** vishwanathj is now known as vishwanathj_zzz | 03:31 | |
| *** chlong has joined #openstack-ironic | 03:35 | |
| *** vikrant has joined #openstack-ironic | 03:38 | |
| *** chlong has quit IRC | 03:38 | |
| *** chlong has joined #openstack-ironic | 03:38 | |
| *** baoli has quit IRC | 03:44 | |
| *** yuanying has quit IRC | 03:45 | |
| *** yuanying has joined #openstack-ironic | 03:48 | |
| *** rama_y has quit IRC | 03:52 | |
| *** hoangcx has quit IRC | 03:53 | |
| *** yogi has joined #openstack-ironic | 03:54 | |
| *** appu103_ has joined #openstack-ironic | 03:58 | |
| *** appu103_ is now known as aparnav | 03:58 | |
| openstackgerrit | Tang Chen proposed openstack/python-ironicclient: Use osc-lib instead of openstackclient https://review.openstack.org/333311 | 04:01 |
| *** hoangcx has joined #openstack-ironic | 04:03 | |
| *** amotoki has joined #openstack-ironic | 04:06 | |
| *** mtanino has joined #openstack-ironic | 04:08 | |
| openstackgerrit | Merged openstack/python-ironicclient: Add 'openstack baremetal node adopt' command https://review.openstack.org/356671 | 04:08 |
| *** hoangcx has quit IRC | 04:24 | |
| *** hoangcx has joined #openstack-ironic | 04:26 | |
| *** aparnav has quit IRC | 04:27 | |
| *** appu103_ has joined #openstack-ironic | 04:33 | |
| *** hoangcx has quit IRC | 04:33 | |
| *** hoangcx has joined #openstack-ironic | 04:37 | |
| *** links has joined #openstack-ironic | 04:37 | |
| *** aswadr_ has joined #openstack-ironic | 04:41 | |
| *** rama_y has joined #openstack-ironic | 04:50 | |
| *** mtanino has quit IRC | 04:53 | |
| *** appu103_ has quit IRC | 04:54 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/360233 | 04:59 |
| *** appu103_ has joined #openstack-ironic | 05:01 | |
| *** jaosorior has joined #openstack-ironic | 05:10 | |
| *** sabeen has quit IRC | 05:12 | |
| *** Sukhdev has joined #openstack-ironic | 05:20 | |
| *** baoli has joined #openstack-ironic | 05:21 | |
| *** harlowja_at_home has joined #openstack-ironic | 05:25 | |
| *** baoli has quit IRC | 05:27 | |
| *** phuongnh has quit IRC | 05:27 | |
| *** _vsaienko has joined #openstack-ironic | 05:28 | |
| *** _vsaienko has quit IRC | 05:29 | |
| *** _vsaienko has joined #openstack-ironic | 05:44 | |
| *** harlowja_at_home has quit IRC | 05:45 | |
| *** praneshp_ has joined #openstack-ironic | 05:46 | |
| *** praneshp has quit IRC | 05:47 | |
| *** praneshp_ is now known as praneshp | 05:47 | |
| *** rbrud has quit IRC | 05:51 | |
| *** appu103_ has quit IRC | 05:53 | |
| *** rbrud has joined #openstack-ironic | 05:56 | |
| *** syed_ has joined #openstack-ironic | 05:56 | |
| *** e0ne has joined #openstack-ironic | 05:57 | |
| *** Sukhdev has quit IRC | 05:59 | |
| *** ccamacho has joined #openstack-ironic | 06:04 | |
| *** rajinir has quit IRC | 06:05 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Introducing node introspection state management https://review.openstack.org/348943 | 06:07 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Introducing node introspection state management https://review.openstack.org/348943 | 06:09 |
| *** vishwanathj_zzz has quit IRC | 06:10 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 06:10 | |
| *** rbartal has joined #openstack-ironic | 06:11 | |
| *** _vsaienko has quit IRC | 06:14 | |
| *** _vsaienko has joined #openstack-ironic | 06:21 | |
| *** baoli has joined #openstack-ironic | 06:23 | |
| *** rama_y has quit IRC | 06:27 | |
| *** rama_y has joined #openstack-ironic | 06:27 | |
| *** baoli has quit IRC | 06:28 | |
| *** rcernin has joined #openstack-ironic | 06:28 | |
| *** vishwanathj_zzz has quit IRC | 06:32 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 06:32 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Remove neutron client workarounds https://review.openstack.org/354588 | 06:40 |
| *** praneshp has quit IRC | 06:44 | |
| *** keekz has quit IRC | 06:44 | |
| *** fragatina has quit IRC | 06:46 | |
| *** keekz has joined #openstack-ironic | 06:46 | |
| *** appu103_ has joined #openstack-ironic | 06:46 | |
| *** Lord_Phoenix has joined #openstack-ironic | 06:54 | |
| vsaienk0 | Morning dtantsur, sambetts, lucasagomes and all Ironic'ers! | 06:55 |
| *** hoangcx has quit IRC | 06:58 | |
| *** hoangcx has joined #openstack-ironic | 07:03 | |
| vsaienk0 | I'm wondered if sambetts is around? | 07:04 |
| *** tesseract- has joined #openstack-ironic | 07:08 | |
| *** ifarkas_afk is now known as ifarkas | 07:09 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/ironic-python-agent: Trust certificate based on fingerprint https://review.openstack.org/358457 | 07:16 |
| *** vishwanathj_zzz has quit IRC | 07:19 | |
| *** _vsaienko has quit IRC | 07:19 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 07:20 | |
| *** baoli has joined #openstack-ironic | 07:23 | |
| *** _vsaienko has joined #openstack-ironic | 07:27 | |
| *** baoli has quit IRC | 07:28 | |
| *** hoangcx has quit IRC | 07:29 | |
| *** hoangcx has joined #openstack-ironic | 07:29 | |
| *** _vsaienko has quit IRC | 07:30 | |
| *** _vsaienko has joined #openstack-ironic | 07:32 | |
| *** e0ne has quit IRC | 07:32 | |
| *** e0ne has joined #openstack-ironic | 07:33 | |
| *** rama_y has quit IRC | 07:35 | |
| *** yarkot1 has quit IRC | 07:40 | |
| aarefiev | morning! | 07:41 |
| *** jpich has joined #openstack-ironic | 07:41 | |
| *** _vsaienko has quit IRC | 07:42 | |
| *** _vsaienko has joined #openstack-ironic | 07:43 | |
| *** _vsaienko has quit IRC | 07:45 | |
| vsaienk0 | o/ aarefiev! | 07:45 |
| aarefiev | hey vsaienk0 | 07:46 |
| *** _vsaienko has joined #openstack-ironic | 07:46 | |
| *** appu103_ has quit IRC | 07:58 | |
| *** chas has joined #openstack-ironic | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-ironic | 08:00 | |
| *** syed_ has quit IRC | 08:02 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Bypassing NodeInfo.acquire_lock() to try OOL https://review.openstack.org/360311 | 08:02 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c https://review.openstack.org/318440 | 08:10 |
| *** vishwanathj_zzz has quit IRC | 08:10 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 08:10 | |
| *** rbrud has quit IRC | 08:11 | |
| *** athomas has joined #openstack-ironic | 08:15 | |
| *** yogi has quit IRC | 08:23 | |
| *** lucas-dinner is now known as lucasagomes | 08:28 | |
| *** appu103_ has joined #openstack-ironic | 08:28 | |
| lucasagomes | jlvillal, JayF so, the code to match the string in IPA will be replaced with the one in ironic-lib as well, which supports operators and is backward compat in case there's no operators present. Currently, no operator means == that's why we append it when parsing | 08:30 |
| lucasagomes | jlvillal, JayF so the new method handles it correctly | 08:30 |
| lucasagomes | jlvillal, see: https://review.openstack.org/#/c/358000 | 08:30 |
| *** yogi has joined #openstack-ironic | 08:31 | |
| *** dtantsur|afk is now known as dtantsur | 08:32 | |
| dtantsur | morning Ironic, morning lucasagomes, aarefiev, vsaienk0 | 08:32 |
| lucasagomes | dtantsur, morning | 08:32 |
| lucasagomes | morning all :D | 08:32 |
| dtantsur | so, the ironic-lib thing, it's not done yet, right? | 08:33 |
| aarefiev | morning dtantsur lucasagomes | 08:33 |
| lucasagomes | dtantsur, no :-/ there's a -1 atm | 08:33 |
| lucasagomes | dtantsur, but feel free to release it without it | 08:33 |
| lucasagomes | we can include it in the next release, it's not a big deal | 08:33 |
| dtantsur | lucasagomes, how are the chances to unblock the patches? I think the release team is not here yet anyway, so we can wait until jroll shows up | 08:34 |
| lucasagomes | dtantsur, it's simple, but I think jlvillal would like to review it again later because I don't think we are in sync with what's the strategy there | 08:35 |
| *** sborkows has joined #openstack-ironic | 08:36 | |
| dtantsur | sigh.. ok, I'm leaving the final decision up to jroll | 08:36 |
| *** ccamacho is now known as ccamacho|afk | 08:37 | |
| lucasagomes | yeah, it's ok tho | 08:38 |
| *** xuao has joined #openstack-ironic | 08:40 | |
| *** vnogin__ has joined #openstack-ironic | 08:43 | |
| *** yuriyz_ has joined #openstack-ironic | 08:43 | |
| *** aarefiev_ has joined #openstack-ironic | 08:43 | |
| *** vsaienk01 has joined #openstack-ironic | 08:44 | |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add update notifications for ironic resources https://review.openstack.org/357799 | 08:44 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add create and delete notifications for ironic resources https://review.openstack.org/356541 | 08:44 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add node provision state change notification https://review.openstack.org/348437 | 08:44 |
| *** yuriyz has quit IRC | 08:46 | |
| *** vsaienk0 has quit IRC | 08:46 | |
| *** vnogin_ has quit IRC | 08:46 | |
| *** aarefiev has quit IRC | 08:47 | |
| *** openstackgerrit has quit IRC | 08:48 | |
| *** openstackgerrit has joined #openstack-ironic | 08:49 | |
| *** aarefiev_ is now known as aarefiev | 08:50 | |
| aarefiev | dtantsur: I remember we've discussed tempest run on stable/mitaka | 08:51 |
| aarefiev | what was decision? | 08:52 |
| dtantsur | I don't remember, sorry | 08:52 |
| aarefiev | we have job w/o test | 08:53 |
| aarefiev | dtantsur: I'm proposing to skip it as for liberty, I don't see any reason to have it, wdyt? | 08:56 |
| dtantsur | +1 | 08:56 |
| *** appu103_ has quit IRC | 08:57 | |
| tangchen | lucasagomes, dtantsur: Morning, guys. Morning, all. :) | 09:00 |
| *** _vsaienko has quit IRC | 09:00 | |
| *** derekh has joined #openstack-ironic | 09:00 | |
| *** sambetts|afk is now known as sambetts | 09:01 | |
| skazi | hi all | 09:02 |
| tangchen | lucasagomes, dtantsur: osc-lib 1.0.2 has been bumped in global requirement. The patch has been merged. So, let's start to approve the ironicclient patches, shall we ? | 09:04 |
| tangchen | lucasagomes, dtantsur: https://review.openstack.org/#/c/334803/ https://review.openstack.org/#/c/333311/ | 09:04 |
| dtantsur | we should | 09:04 |
| tangchen | dtantsur: Thanks. :) | 09:04 |
| dtantsur | +2 both | 09:05 |
| tangchen | thanks a lot. ：） | 09:06 |
| *** vsaienko has joined #openstack-ironic | 09:06 | |
| lucasagomes | tangchen, ++ | 09:06 |
| * lucasagomes reviews | 09:06 | |
| skazi | lucasagomes, if you have time, please take a look at this: https://review.openstack.org/#/c/354685/ | 09:07 |
| tangchen | lucasagomes: Thanks :) | 09:07 |
| skazi | I got a +1 from Naohiro Tamura | 09:07 |
| lucasagomes | skazi, thanks for talking to him | 09:08 |
| lucasagomes | +2 | 09:08 |
| skazi | lucasagomes, thx! | 09:09 |
| *** appu103_ has joined #openstack-ironic | 09:11 | |
| openstackgerrit | Rodion Promyshlennikov proposed openstack/python-ironicclient: Add baremetal port delete command to OSC plugin https://review.openstack.org/346075 | 09:13 |
| *** ccamacho|afk is now known as ccamacho | 09:14 | |
| *** e0ne has quit IRC | 09:18 | |
| *** moshele has joined #openstack-ironic | 09:23 | |
| pas-ha | morning Ironic :) | 09:23 |
| dtantsur | morning pas-ha | 09:26 |
| openstackgerrit | Sam Betts proposed openstack/ironic-specs: Add spec for VLAN Aware Baremetal Instances https://review.openstack.org/277853 | 09:26 |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with Node https://review.openstack.org/342060 | 09:28 |
| *** e0ne has joined #openstack-ironic | 09:31 | |
| *** baoli has joined #openstack-ironic | 09:40 | |
| *** fragatina has joined #openstack-ironic | 09:43 | |
| *** baoli has quit IRC | 09:44 | |
| *** fragatina has quit IRC | 09:47 | |
| *** vishwanathj_zzz has quit IRC | 09:52 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 09:53 | |
| openstackgerrit | Merged openstack/python-ironicclient: Use osc_lib instead of cliff https://review.openstack.org/334803 | 09:54 |
| openstackgerrit | Merged openstack/python-ironicclient: Use osc-lib instead of openstackclient https://review.openstack.org/333311 | 09:57 |
| sambetts | \o/ woop | 09:57 |
| dtantsur | unfortunately this ^^ caused quite a few merge conflicts | 09:57 |
| dtantsur | and morning sambetts :) | 09:57 |
| sambetts | o/ Hi dtantsur | 09:57 |
| vdrok | morning all, lucasagomes pas-ha dtantsur sambetts | 10:00 |
| *** skazi has quit IRC | 10:00 | |
| *** skazi has joined #openstack-ironic | 10:00 | |
| dtantsur | vdrok, o/ | 10:01 |
| *** hoangcx has quit IRC | 10:04 | |
| *** Lord_Phoenix has quit IRC | 10:06 | |
| lucasagomes | vdrok, sambetts pas-ha good morning | 10:06 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-lib: Add match_root_device_hints() to the utils.py module https://review.openstack.org/358000 | 10:07 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-lib: Extend parse_root_device_hints to support operators https://review.openstack.org/348953 | 10:07 |
| vsaienk01 | sambetts: what do you think if we create a properties field in portgroup object and will store fallback key there? | 10:07 |
| vsaienk01 | I think there will be a lot of other portgroup paramters like protocol, mode, load_balancing strategy etc... that may be stored in properties | 10:09 |
| *** e0ne has quit IRC | 10:09 | |
| sambetts | vsaienk01: I guess thats what the extra field is for I guess | 10:09 |
| sambetts | vsaienk01: I'd rather not add anything in the API that is dependant on fields that aren't fixed fields | 10:11 |
| sambetts | But I think we need to discus this with more of us | 10:12 |
| sambetts | milan: QQ why does your patch change the order the of the paramters for some of the functions? e.g. node_info and ironic switching places ? | 10:13 |
| sambetts | milan: Also I think reapply can still get stuck right? | 10:13 |
| sambetts | milan: we need to bubble the exception up so it gets caught by the decorator and triggers the transition to Error state | 10:15 |
| *** vsaienko has quit IRC | 10:15 | |
| vsaienk01 | sambetts: follow by analogy for node object where properties field specify physical characteristic of the node, fallback and other protgroup settings should be stored in properties I think | 10:16 |
| *** electrofelix has joined #openstack-ironic | 10:17 | |
| vsaienk01 | vdrok, lucasagomes what do you think ^^ | 10:17 |
| vsaienk01 | dtantsur: could you please provide your opinion also ^ | 10:17 |
| dtantsur | vsaienk01, I don't have a complete context here, but I'm with sambetts on not creating more free-form fields | 10:19 |
| vdrok | if all that will be there will be filled by the operator, extra might be ok | 10:19 |
| dtantsur | vdrok, unless ironic will use it | 10:20 |
| dtantsur | if it's just for an operator - I'm all for it. just make sure Ironic never reads these fields ;) | 10:20 |
| vdrok | dtantsur: I always forget, so we can't rely on anything in extra? ironic will have to read those | 10:21 |
| vdrok | we can make it non-free-form | 10:21 |
| dtantsur | vdrok, we should not. unfortunately, we do it for ports, but sambetts is working on fixing it (IIRC) | 10:21 |
| dtantsur | vdrok, I'd prefer explicit fields, or at least a dict field with fixed schema | 10:22 |
| dtantsur | (like we have for local_link_connection, I guess) | 10:22 |
| vdrok | yep, that's what I mean | 10:22 |
| *** vsaienko has joined #openstack-ironic | 10:23 | |
| * lucasagomes is out of context | 10:23 | |
| lucasagomes | Ill be back to it soon, I've to relocate to the office | 10:25 |
| * lucasagomes brb | 10:25 | |
| *** lucasagomes is now known as lucas-relocate | 10:25 | |
| vsaienk01 | dtantsur: so if option is going to be used by Ironic, it shouldn't be stored under extra? | 10:26 |
| dtantsur | vsaienk01, definitely not extra | 10:26 |
| dtantsur | initially extra was planned only for operators | 10:27 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/ironic-python-agent: Trust certificate based on fingerprint https://review.openstack.org/358457 | 10:27 |
| sambetts | vsaienk01, vdrok: BTW dtantsur is refering to https://review.openstack.org/#/c/317636/ https://review.openstack.org/#/c/327046/ when he's says I'm fixing it :D | 10:28 |
| vsaienk01 | dtantsur: so following by analogy to properties in node object, we need to have something similar in portgroup that describes physical properties of portgroup | 10:28 |
| dtantsur | probably, here's where I'm out of context | 10:29 |
| sambetts | I definatly think we need somewhere to store that information, and I think it will need to be somewhat freeform because it may be different per network driver implementation | 10:29 |
| dtantsur | okie, we can use loose schema | 10:30 |
| vsaienk01 | sambetts: right, and it will be different based on channel protocol and hardware that is used | 10:30 |
| sambetts | but the network interfaces should be the ones responsible for validating they has the properties they require | 10:30 |
| *** zhangjl has quit IRC | 10:30 | |
| sambetts | but any code that is outside of the interfaces, should not read this data | 10:30 |
| sambetts | e.g. the API | 10:30 |
| sambetts | so it doesn't solve our ports can be used individually thing | 10:31 |
| sambetts | because that check needs to be in the API on port update | 10:31 |
| vsaienk01 | sambetts: right, so for options like fallback that is going to be used by API and network_driver we should create a separate field? | 10:32 |
| *** mvpnitesh has joined #openstack-ironic | 10:32 | |
| sambetts | (until my stuff linked above merges which moves it into the network interface) | 10:32 |
| sambetts | vsaienk01: right, I think an option which isn't "fallback" but just is portgroup is non-strict/not-enforced or something would be better | 10:33 |
| sambetts | because fallback is just one implementation of being able to use the ports individually | 10:33 |
| sambetts | there are other ways to do it e.g. dynamic programming from the ml2 driver | 10:34 |
| sambetts | so I think that we need to define a "the ports in this portgroup can be used by themselves" option | 10:34 |
| sambetts | which is a flag separate from properties | 10:35 |
| sambetts | I also think ports need properties too BTW, for storing things like max MTU, NIC speed etc, for more advanced schedualing in the future | 10:36 |
| jroll | morning | 10:36 |
| sambetts | Hey jroll | 10:36 |
| vsaienk01 | morning jroll | 10:36 |
| sambetts | jroll: you probably have opinions on ^^ | 10:36 |
| jroll | can someone summarize new problems with the portgroup thing in an email thread? I've seen like 5 different questions this week | 10:36 |
| jroll | no, I don't have opinions right now, I'm not fully awake yet | 10:37 |
| vsaienk01 | sambbets: I think the properties field is good for that, I mean storing things like MTU, load balancing algorithm and others | 10:37 |
| sambetts | yup and hash alogorithm etc | 10:37 |
| *** xuao has quit IRC | 10:37 | |
| vsaienk01 | sambetts: so what is appropriate name to tell that port may be/may not be used in single NIC mode? | 10:39 |
| *** newcomer25 has joined #openstack-ironic | 10:40 | |
| vsaienk01 | I'm thinking about "fallback" or "fallback_supported" | 10:41 |
| sambetts | hmm, I can't think of anything better than fallback_supported right now | 10:43 |
| vdrok | morning jroll | 10:45 |
| *** milan has joined #openstack-ironic | 10:52 | |
| milan | morning Ironic! :) | 10:52 |
| *** ccamacho is now known as ccamacho|afk | 10:53 | |
| *** mpsairam has quit IRC | 10:55 | |
| *** vishwanathj_zzz has quit IRC | 10:55 | |
| vsaienk01 | morning milan | 10:55 |
| milan | morning vsaienk01 :) | 10:55 |
| *** vishwanathj_zzz has joined #openstack-ironic | 10:56 | |
| sambetts | vsaienk01: maybe individual_mode_supported? I'm not a big fan of "fallback" because that is an implementation of running ports as single ports | 10:56 |
| vsaienk01 | sambetts: I don't have strong opinion here, I'm going to upload version with "individual_mode_supported" then | 10:58 |
| sambetts | vsaienk01: awesome :D | 10:58 |
| *** ccamacho|afk is now known as ccamacho | 11:05 | |
| dtantsur | huh, do we have another regression with keystone credentials? http://paste.openstack.org/show/563360/ | 11:07 |
| mvpnitesh | hi all , good evening | 11:08 |
| sambetts | dtantsur: eeeeh :/ | 11:08 |
| dtantsur | it might be puppet, I'm checking https://github.com/openstack/puppet-ironic/commit/eef5b11679e1c0e96a782f51f5e0c8aa6abfb3bd | 11:08 |
| mvpnitesh | I've one doubt. In mitaka ironic-api has a parent process running and if any of the child process is getting killed it is starting a new ironic-api. In the same way , why are we not having a parent process for ironic-conductor ? | 11:09 |
| *** lucas-relocate is now known as lucas-hungry | 11:13 | |
| dtantsur | folks, how to detect which conductor the node got mapped to? | 11:15 |
| sambetts | dtantsur: check the nodes DB record for reservation field? | 11:17 |
| dtantsur | meh :) | 11:17 |
| sambetts | quite :-P | 11:17 |
| dtantsur | well, reservation is None when nothing is happening to a node, right? | 11:17 |
| sambetts | dtantsur: conductor_affinity then? | 11:18 |
| dtantsur | yeah | 11:18 |
| sambetts | other than that I'm not sure :/ | 11:18 |
| dtantsur | would be cool to expose that | 11:18 |
| sambetts | do we want to expose it though? Isn't it supposed to be transparent? | 11:19 |
| mat128 | morning everyone | 11:21 |
| mat128 | reading scrollback and you guys got everything right ;) | 11:21 |
| sambetts | mat128: ;) | 11:21 |
| sambetts | dtantsur: why do you need to know which conductor a node is assigned to? I been thinking about using multinode CI to test our hash ring placment stuff based on different drivers | 11:22 |
| dtantsur | sambetts, to know which nodes to quickly hack on | 11:23 |
| sambetts | dtantsur: I'm not sure I get it :-P | 11:24 |
| dtantsur | well, I got broken by recent puppet-ironic changes, so I need to test a quick hack in ironic.conf, and I'd prefer not to do it on all 3 conductors | 11:25 |
| sambetts | ahhh right I see | 11:25 |
| pas-ha | dtantsur: question on ironic-staging-drivers - how often/automatic are docs on rtfd.org updated? cuz e.g. the iboot docs are not there yet, although they are in repo | 11:25 |
| dtantsur | lucas-hungry, ^^^ | 11:26 |
| *** vsaienko has quit IRC | 11:27 | |
| pas-ha | sambetts: I think we need to create an extra service endpoint that will report which node is managed by which conductor | 11:27 |
| *** rloo has joined #openstack-ironic | 11:27 | |
| *** bfournie has quit IRC | 11:27 | |
| pas-ha | since for example you have many conductor nodes, and need to check the deployment logs - which node should you log into? | 11:28 |
| pas-ha | loggin to all and grepping logs for node uuid is possible but not time-effective :) | 11:28 |
| dtantsur | ++++ | 11:29 |
| dtantsur | pas-ha, mind filing an RFE? | 11:29 |
| pas-ha | sure | 11:29 |
| sambetts | even just exposing conductor_affinity in the node show might be enough ? | 11:29 |
| sambetts | but I think we'd resolve it to the conductors hostname instead of just exposing the ID | 11:30 |
| dtantsur | yep | 11:30 |
| *** vsaienko has joined #openstack-ironic | 11:31 | |
| openstackgerrit | Merged openstack/ironic-inspector: Modify the SQL's string from double quote to single quote. https://review.openstack.org/358673 | 11:33 |
| *** jcoufal has joined #openstack-ironic | 11:37 | |
| *** jcoufal has quit IRC | 11:39 | |
| openstackgerrit | Merged openstack/ironic-inspector: Increase verbosity for functional tests https://review.openstack.org/357753 | 11:42 |
| *** foexle has joined #openstack-ironic | 11:43 | |
| pas-ha | dtantsur: sambetts: https://bugs.launchpad.net/ironic/+bug/1616878 | 11:45 |
| openstack | Launchpad bug 1616878 in Ironic "[RFE] expose which conductor instance is managing given Ironic node" [Undecided,New] | 11:45 |
| dtantsur | thanks | 11:46 |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: Switch to osc-lib instead of cliff https://review.openstack.org/360461 | 11:46 |
| dtantsur | sambetts, aarefiev ^^^ | 11:46 |
| dtantsur | oops, fixing deps | 11:47 |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: Switch to osc-lib instead of cliff https://review.openstack.org/360461 | 11:47 |
| jroll | is there any reason to expose which conductor is managing a node, other than to hack code on the conductor? | 11:47 |
| jroll | it's kind of an internal implementation detail | 11:48 |
| pas-ha | jroll, find where to log to check the logs of failed node deploy? | 11:48 |
| aarefiev | dtantsur: thanks, I saw this for ironic few minutes ago :) | 11:48 |
| jroll | pas-ha: syslog ;) | 11:48 |
| dtantsur | jroll, figuring our which nodes can be affected by conductor downtime? | 11:48 |
| jroll | for real though, if you're using more than one conductor and don't have centralized logging, you're doing something wrong | 11:48 |
| *** dansmith has quit IRC | 11:49 | |
| jroll | dtantsur: the hash ring takes care of that | 11:49 |
| dtantsur | jroll, yes, but how does operator know? e.g. which nodes to check after the downtime? | 11:49 |
| *** dansmith has joined #openstack-ironic | 11:49 | |
| jroll | dtantsur: not sure what you mean, planned downtime means none are affected, unplanned you would look at failure states | 11:50 |
| jroll | ironic node-list --provision-state deploy failed or similar | 11:50 |
| *** appu103_ has quit IRC | 11:51 | |
| dtantsur | jroll, what do you mean "none are affected"? I want to bring a conductor down, and I want to make sure no nodes are in deploy process on it. | 11:51 |
| dtantsur | how do I achieve that? | 11:51 |
| jroll | dtantsur: we have graceful shutdown, it will finish any tasks | 11:51 |
| jroll | anyway, if it's in deploy process, you have the reservation field :) | 11:51 |
| *** jaosorior has quit IRC | 11:52 | |
| jroll | if there's no lock, it won't be interrupted | 11:52 |
| *** jaosorior has joined #openstack-ironic | 11:52 | |
| dtantsur | so yeah, maybe it boils down to avoid accessing database when you need to debug something... | 11:53 |
| jroll | s/debug/edit code in production/ ? | 11:54 |
| *** dprince has joined #openstack-ironic | 11:55 | |
| openstackgerrit | Georgy Dyuldin proposed openstack/ironic: Add ironic multitenancy tests https://review.openstack.org/360465 | 11:57 |
| TheJulia | Good morning | 12:00 |
| vsaienk01 | morning TheJulia | 12:01 |
| *** bfournie has joined #openstack-ironic | 12:04 | |
| *** xuao has joined #openstack-ironic | 12:04 | |
| ifarkas | vdrok, hi, would you mind reviewing the drac raid patch? https://review.openstack.org/#/c/176319/ | 12:06 |
| dtantsur | jroll, s/code/code or configuration/ s/production/testing or QA environment/ but yeah | 12:08 |
| jroll | dtantsur: yeah, in testing environments, I tend to just go down to one conductor when I need to do that | 12:08 |
| vdrok | morning TheJulia ifarkas | 12:09 |
| vdrok | ifarkas: ok, will try to look today | 12:09 |
| ifarkas | vdrok, huge thanks! | 12:09 |
| openstackgerrit | Merged openstack/python-ironic-inspector-client: Updated from global requirements https://review.openstack.org/360151 | 12:09 |
| *** xuao has quit IRC | 12:09 | |
| *** appu103_ has joined #openstack-ironic | 12:09 | |
| openstackgerrit | Merged openstack/python-ironic-inspector-client: Increase verbosity for functional tests https://review.openstack.org/358650 | 12:10 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Fix fall back to legacy option https://review.openstack.org/360483 | 12:13 |
| dtantsur | pas-ha, jroll, please check ^^^ | 12:13 |
| dtantsur | my ironic work got broken by puppet-ironic, and then we figured out that we seem to have a problem with legacy options | 12:14 |
| openstackgerrit | Rodion Promyshlennikov proposed openstack/python-ironicclient: Add baremetal port delete command to OSC plugin https://review.openstack.org/346075 | 12:15 |
| dtantsur | aha, this is legacy one: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_auth.py#L34-L40 | 12:15 |
| dtantsur | this is a new-ish one: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L191-L198 | 12:15 |
| *** lucas-hungry is now known as lucasagomes | 12:15 | |
| * dtantsur updates the commit message | 12:15 | |
| lucasagomes | dtantsur, re: what conductor the nodes are mapped to. I think the hash-ring computes it on the flight, if you have to node uuid and driver you may be able to compute it again | 12:17 |
| lucasagomes | pas-ha, no idea, lemme check | 12:17 |
| *** vishwanathj_zzz has quit IRC | 12:18 | |
| lucasagomes | pas-ha, I've trigged a build manually let's see | 12:18 |
| *** jcook has quit IRC | 12:18 | |
| *** baoli has joined #openstack-ironic | 12:18 | |
| *** vishwanathj_zzz has joined #openstack-ironic | 12:18 | |
| *** baoli has quit IRC | 12:19 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Fix fall back to newer keystonemiddleware options https://review.openstack.org/360483 | 12:19 |
| dtantsur | pas-ha, with updated commit message ^^^ | 12:19 |
| *** wendar_ has joined #openstack-ironic | 12:19 | |
| *** wendar has quit IRC | 12:20 | |
| jroll | dtantsur: curious, those are the "new" conf options, why wouldn't that use the new auth? | 12:21 |
| *** cdearborn has joined #openstack-ironic | 12:21 | |
| jroll | missing some option, it seems | 12:21 |
| *** bradjones has quit IRC | 12:21 | |
| jroll | did those work previously? | 12:21 |
| dtantsur | jroll, because new auth requires filling in a few new sections, like [neutron] | 12:21 |
| lucasagomes | pas-ha, http://paste.openstack.org/show/563372/ | 12:22 |
| dtantsur | jroll, it works if you fill in legacy admin_* stuff. but it breaks if a user switches keystonemiddleware to new options without switching everything else | 12:22 |
| dtantsur | which is what happened in puppet-ironic (meh) | 12:22 |
| jroll | aha, missed the group | 12:22 |
| jroll | dtantsur: any reason not to add tests here? | 12:23 |
| *** hpe-hj has joined #openstack-ironic | 12:23 | |
| dtantsur | I will, just want to run it through you first | 12:23 |
| *** hj-hpe has quit IRC | 12:23 | |
| jroll | seems fine :) | 12:23 |
| *** lekha has quit IRC | 12:23 | |
| * jroll -1 for tests | 12:23 | |
| dtantsur | it's interesting, but it fails locally with "no such option in group keystone_authtoken: username". what. the. hell. | 12:23 |
| jroll | lol | 12:24 |
| lucasagomes | pas-ha, strange it should have installed it from the test-requirements | 12:24 |
| *** causten has joined #openstack-ironic | 12:24 | |
| *** baoli has joined #openstack-ironic | 12:24 | |
| *** baoli has quit IRC | 12:24 | |
| jroll | dtantsur: that should be fun to unwind... | 12:24 |
| pas-ha | lucasagomes: yep, to compile python-libvirt when installing it one needs libvirt-dev from apt/yum. Works on devstack as it is already installed there. | 12:25 |
| jroll | dtantsur: is keystone_authtoken no longer installed, maybe? | 12:25 |
| dtantsur | a lot of fun, especially so close to the FF... | 12:25 |
| sambetts | dtantsur: username won't be in the ironic_auth.LEGACY_SECTION right? because conf.username is a new field? | 12:25 |
| *** jaosorior is now known as jaosorior_away | 12:25 | |
| *** jcook has joined #openstack-ironic | 12:26 | |
| *** lekha has joined #openstack-ironic | 12:26 | |
| dtantsur | sambetts, it should be, we're taking options from keystoneauth..... | 12:26 |
| dtantsur | unless I misunderstand everything, which is probably the case | 12:26 |
| lucasagomes | pas-ha, hmm that may be it thne | 12:26 |
| lucasagomes | then* | 12:26 |
| *** MattMan has quit IRC | 12:26 | |
| *** MattMan has joined #openstack-ironic | 12:26 | |
| *** bradjones has joined #openstack-ironic | 12:27 | |
| *** bradjones has quit IRC | 12:27 | |
| *** bradjones has joined #openstack-ironic | 12:27 | |
| *** mtreinish has quit IRC | 12:27 | |
| jroll | dtantsur: nah, _get_legacy_auth() pulls from keystone_authtoken | 12:27 |
| jroll | LEGACY_SECTION = 'keystone_authtoken' | 12:28 |
| lucasagomes | pas-ha, maybe we should mock out libvirt for the tests | 12:28 |
| dtantsur | yeah, and where does it come from? | 12:28 |
| sambetts | dtantsur: keystonemiddleware | 12:28 |
| * dtantsur bangs his head against the table | 12:28 | |
| dtantsur | becoming a software engineer was a mistake >_< | 12:29 |
| sambetts | dtantsur: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L191 | 12:29 |
| sambetts | dtantsur: looks like it should be defined | 12:29 |
| jroll | well, I think keystonemiddleware is no longer in reqs.txt | 12:30 |
| sambetts | unless I'm missing something too | 12:30 |
| sambetts | oh... | 12:30 |
| pas-ha | dtantsur: I'll test it now too. So what you are doing is just changing the keystone_authtoken section to "new" config options w/o filling up the rest in glance, swift, neutron etc? | 12:30 |
| jroll | oh, it is | 12:30 |
| openstackgerrit | Dmitry Tantsur proposed openstack/python-ironic-inspector-client: Switch to osc-lib instead of cliff https://review.openstack.org/360461 | 12:30 |
| *** mtreinish has joined #openstack-ironic | 12:30 | |
| *** causten has quit IRC | 12:33 | |
| *** ccamacho is now known as ccamacho|lunch | 12:33 | |
| *** thrash|g0ne is now known as thrash | 12:33 | |
| rloo | hi and morning everyone, sambetts, dtantsur, lucasagomes, pas-ha. welcome back jroll, i'm sure you missed us :) | 12:37 |
| lucasagomes | rloo, hi there | 12:37 |
| jroll | morning rloo, of course :) | 12:37 |
| dtantsur | morning rloo | 12:37 |
| pas-ha | morning rloo | 12:37 |
| sambetts | morning rloo | 12:37 |
| *** jcoufal has joined #openstack-ironic | 12:40 | |
| *** derekh has quit IRC | 12:44 | |
| dtantsur | pas-ha, jroll, got a potential temporary fix on puppet side: https://review.openstack.org/#/c/360506/ | 12:44 |
| *** vsaienko has quit IRC | 12:45 | |
| *** vsaienk01 has quit IRC | 12:45 | |
| *** yuriyz_ has quit IRC | 12:46 | |
| *** vnogin__ has quit IRC | 12:46 | |
| *** jcoufal has quit IRC | 12:47 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Adds 'openstack baremetal node console' commands https://review.openstack.org/356759 | 12:47 |
| *** derekh has joined #openstack-ironic | 12:47 | |
| *** fxpester has joined #openstack-ironic | 12:47 | |
| lucasagomes | pas-ha, dtantsur https://review.openstack.org/#/c/360512/ that might do it | 12:48 |
| rloo | dtantsur: are you OK with 'openstack baremetal node console enable', '.. console disable'? (instead of set/unset, create/delete)? | 12:49 |
| dtantsur | fine with me | 12:49 |
| sambetts | I would very much like that | 12:49 |
| rloo | dtantsur: thx | 12:49 |
| rloo | sambetts: even better :) | 12:49 |
| jroll | +1 | 12:50 |
| rloo | thx jroll, sambetts, dtantsur. you might want to take a look at the spec update. i've got other changes :) https://review.openstack.org/#/c/357505/ | 12:50 |
| dtantsur | sure, just let me unbreak this puppet thing... | 12:51 |
| *** thiagop has joined #openstack-ironic | 12:51 | |
| thiagop | Good morning, Ironicers | 12:51 |
| dtantsur | morning thiagop | 12:51 |
| thiagop | is gerrit out? | 12:51 |
| rloo | dtantsur: no worries | 12:51 |
| dtantsur | for some people apparently | 12:51 |
| rloo | hi thiagop | 12:51 |
| thiagop | dtantsur rloo o/ | 12:52 |
| TheJulia | rloo: Good catches on the driver comp spec update, I'll update it today. Thank you for the reivew! | 12:53 |
| rloo | TheJulia: yw. Sorry for not reviewing it sooner. | 12:54 |
| TheJulia | no worries, I think we have all been extremely busy the last few weeks | 12:54 |
| *** mgagne_ is now known as mgagne | 12:54 | |
| *** yuriyz has joined #openstack-ironic | 12:55 | |
| *** vnogin has joined #openstack-ironic | 12:55 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: Reusing oneview_client when possible https://review.openstack.org/358041 | 12:55 |
| jroll | rloo: +2'd, I'll let dtantsur land it | 12:55 |
| *** [1]cdearborn has joined #openstack-ironic | 12:55 | |
| rloo | thx jroll. | 12:55 |
| thiagop | dtantsur deserves that, its beeing around for what? 3 cycles? | 12:55 |
| *** vsaienko has joined #openstack-ironic | 12:55 | |
| *** ccamacho|lunch is now known as ccamacho | 12:59 | |
| *** vishwanathj_zzz is now known as vishwanathj | 13:00 | |
| *** jrist has quit IRC | 13:00 | |
| *** [2]cdearborn has joined #openstack-ironic | 13:00 | |
| *** vsaienk0 has joined #openstack-ironic | 13:00 | |
| *** vikrant has quit IRC | 13:03 | |
| *** yarkot1 has joined #openstack-ironic | 13:03 | |
| *** foexle has quit IRC | 13:04 | |
| sambetts | rloo: what about maintenance enable/disable instead of set/unset, because set to me implies setting it to something? | 13:05 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Adds 'openstack baremetal node console' commands https://review.openstack.org/356759 | 13:05 |
| rloo | sambetts: that's an interesting one. I'm fine changing it if others want to | 13:06 |
| rloo | sambetts: on/off? | 13:06 |
| *** mjturek has joined #openstack-ironic | 13:06 | |
| *** baoli has joined #openstack-ironic | 13:07 | |
| rloo | sambetts: it isn't really enabling | 13:07 |
| rloo | sambetts: more like 'put in maintenance', 'take out of maintenance' ? | 13:07 |
| *** baoli_ has joined #openstack-ironic | 13:07 | |
| jroll | oh, we need to release all the things today | 13:08 |
| dtantsur | s/all the things/ironic-lib/ no? | 13:09 |
| dtantsur | everything else is next week | 13:09 |
| *** cdearborn has quit IRC | 13:09 | |
| rloo | dtantsur: +. just ironic-lib. | 13:09 |
| sambetts | rloo: I think of it as maintenance mode, so on/off makes sense to me "openstack baremetal node maintenance (mode) on <uuid>" but that might be just me | 13:09 |
| jroll | idk, I'm wondering what dracclient and wsmanclient qualify as | 13:09 |
| jroll | they aren't clients for openstack servers | 13:10 |
| dtantsur | ifarkas, do you have pending changes for these ^^^? | 13:10 |
| jroll | actually they probably aren't in requirements.txt so /shrug | 13:10 |
| sambetts | jroll: isn't just things in g-r we need to worry about? | 13:10 |
| sambetts | isn't it * | 13:10 |
| * ifarkas reads back | 13:10 | |
| jroll | right | 13:10 |
| dtantsur | actually, the only pending change is https://review.openstack.org/318691 | 13:10 |
| jroll | but may as well release these things | 13:10 |
| jroll | dtantsur: yeah, was just going to link that :) | 13:10 |
| jroll | someone land that please :D | 13:11 |
| *** mjturek has quit IRC | 13:11 | |
| dtantsur | jroll, ifarkas has some question inline | 13:11 |
| *** baoli has quit IRC | 13:11 | |
| ifarkas | jroll, dtantsur, I released dracclient a couple days ago and wsmanclient last week - no pending changes | 13:11 |
| jroll | ah | 13:11 |
| ifarkas | right, the constraints patch | 13:12 |
| dtantsur | even better :) | 13:12 |
| jroll | oh, maybe wsmanclient doesn't need tox_install.sh | 13:12 |
| jroll | things that are in upper-constraints.txt need that | 13:12 |
| sambetts | yeah, I just checked they aren't in there | 13:12 |
| *** foexle has joined #openstack-ironic | 13:12 | |
| jroll | yeah wtf was I doinfg | 13:13 |
| *** tuanla_ has quit IRC | 13:13 | |
| dtantsur | sambetts, aarefiev, ifarkas, we have quite a few pending changes for ironic-inspector-client, all are pretty small, could you please clean them up? :) | 13:13 |
| *** jrist has joined #openstack-ironic | 13:13 | |
| ifarkas | dtantsur, sure | 13:13 |
| sambetts | dtantsur: been going through them today :) | 13:13 |
| ifarkas | jroll, yeah, was wondering about that but thanks for the clarification | 13:13 |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with node-get command https://review.openstack.org/342060 | 13:13 |
| jroll | ifarkas: will fix quickly | 13:13 |
| *** [1]cdearborn has quit IRC | 13:14 | |
| jroll | dtantsur: ifarkas updated https://review.openstack.org/#/c/318691/ | 13:15 |
| jroll | no bot for that one I guess | 13:15 |
| * dtantsur waits for jenkins | 13:15 | |
| *** vishwanathj has quit IRC | 13:15 | |
| *** appu103_ has quit IRC | 13:15 | |
| *** vishwanathj has joined #openstack-ironic | 13:16 | |
| ifarkas | jroll, lgtm, thanks! | 13:16 |
| jroll | np, ty | 13:16 |
| * jroll does the ironic-lib now | 13:16 | |
| *** [2]cdearborn has quit IRC | 13:17 | |
| *** newcomer25 has quit IRC | 13:17 | |
| *** newcomer25 has joined #openstack-ironic | 13:18 | |
| *** appu103_ has joined #openstack-ironic | 13:19 | |
| rloo | jroll: thought lucas wanted to get 2 patches into ironic-lib | 13:20 |
| pas-ha | dtantsur: found how to fix this. it is all due to auth_plugins do not register their options until you try to load them. would you mind if I push to your Gerrit patch? | 13:20 |
| dtantsur | pas-ha, yes please. I think mine is wrong anyway | 13:20 |
| *** rbudden has joined #openstack-ironic | 13:20 | |
| *** newcomer25 has left #openstack-ironic | 13:21 | |
| rloo | lucasagomes: are you still trying to get those two patches into ironic-lib for today's release? | 13:22 |
| jroll | rloo: yeah, we did want to, but doesn't look like it'll make it (they still have -1s, and today is the deadline) | 13:22 |
| lucasagomes | rloo, if possible, but there's no big deal if that does not land | 13:22 |
| lucasagomes | rloo, I'm currently looking at the comments there | 13:22 |
| *** links has quit IRC | 13:22 | |
| jroll | we can always release again if they do get in quickly | 13:22 |
| rloo | lucasagomes: maybe lets wait on those. did you already make changes to ironic/ipa to use them? | 13:23 |
| *** causten has joined #openstack-ironic | 13:23 | |
| dtantsur | lucasagomes, rloo, we can request an exception from the release team based on the ground that nobody else is using ironic-lib.. but do we really think we'll manage to land the IPA and inspector changes in Newton? | 13:23 |
| lucasagomes | rloo, locally, I didn't submit the patches | 13:23 |
| dtantsur | this is the most important question to me | 13:23 |
| rloo | dtantsur: yup, i was wondering that | 13:24 |
| jroll | dtantsur: ++ | 13:24 |
| jroll | we have plenty of other things to do if this doesn't make it | 13:24 |
| *** jhooker has joined #openstack-ironic | 13:25 | |
| lucasagomes | +1 | 13:27 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Fix fall back to newer keystonemiddleware options https://review.openstack.org/360483 | 13:27 |
| pas-ha | will add unit test as asked by jroll in next patch set | 13:28 |
| pas-ha | dtantsur: can you test this with your config? | 13:28 |
| pas-ha | seems to work on my devstack | 13:28 |
| openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent: Fix IPA for stable/mitaka with noauth mode https://review.openstack.org/359991 | 13:28 |
| openstackgerrit | Georgy Dyuldin proposed openstack/ironic: Add ironic multitenancy tests https://review.openstack.org/360465 | 13:29 |
| *** mjturek has joined #openstack-ironic | 13:29 | |
| mjturek | vsaienk0 vsaienko: you already handling the portgroups comments? I was about to | 13:30 |
| dtantsur | pas-ha, my environment is down right now, but the code looks good, modulo missing tests and a release note | 13:30 |
| jroll | do we really need a release note for that? maybe just change the original release note for that feature? | 13:31 |
| *** mat128 is now known as mat128|away | 13:31 | |
| dtantsur | jroll, we've crossed the release boundary | 13:31 |
| dtantsur | so yes, we need it, and it should be separate | 13:31 |
| jroll | ooh, good point | 13:31 |
| *** jhooker has quit IRC | 13:32 | |
| jroll | probably a fixes: section imo | 13:32 |
| *** appu103_ has quit IRC | 13:32 | |
| dtantsur | yep | 13:32 |
| *** jhooker has joined #openstack-ironic | 13:32 | |
| dtantsur | pas-ha, I'll try to test it anyway, I'm rebuilding the environment. but anyone can test it by taking an ironic env and s/admin_user/username/ etc in [keystone_authtoken] | 13:33 |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with node-list command https://review.openstack.org/360549 | 13:35 |
| jroll | lemme see | 13:35 |
| ifarkas | jroll, should I do another release of wsmanclient with the constraint patch? | 13:36 |
| jroll | ifarkas: yeah, or I can, either way | 13:37 |
| lucasagomes | rloo, can I keep that _append_... method for now and later change it to use the same method to append the opearators? | 13:37 |
| jroll | dtantsur: need to remove auth stuff from [neutron], [glance], anything else? | 13:37 |
| rloo | lucasagomes: yeah. i'm fine with that. it is all localized. | 13:37 |
| ifarkas | jroll, I will | 13:37 |
| lucasagomes | rloo, cool, thanks | 13:37 |
| dtantsur | jroll, right | 13:37 |
| dtantsur | my environment is tripleo with HA, so it takes ages to build >_< | 13:38 |
| rloo | lucasagomes: there does seem to be duplicate (or more) parsings, but that can be cleaned up later. i'd really like some of that stuff to go into oslo's specmatcher if possible. | 13:38 |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add classes for Portgroups API enablement https://review.openstack.org/347549 | 13:38 |
| jroll | dtantsur: this goes in keystone_authtoken, yeah? | 13:38 |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: OneView test nodes to use dynamic allocation https://review.openstack.org/359990 | 13:39 |
| jroll | seems to start up okay, that was the bug, right? | 13:39 |
| dtantsur | jroll, yep, replace username, password, project_name and auth_url (not auth_uri!) with admin_user, admin_password, admin_tenant_name and identity_uri | 13:39 |
| jroll | api works | 13:39 |
| dtantsur | jroll, for me it failed when I tried cleaning | 13:39 |
| jroll | ah | 13:39 |
| dtantsur | because it tried to fetch api_url (I had it empty in the config) | 13:39 |
| dtantsur | so make sure you don't have [conductor]api_url as well | 13:40 |
| jroll | ok | 13:40 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-lib: Add match_root_device_hints() to the utils.py module https://review.openstack.org/358000 | 13:40 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic-lib: Extend parse_root_device_hints to support operators https://review.openstack.org/348953 | 13:40 |
| jroll | dtantsur: okay, I have a thing cleaning, it's booting up now | 13:41 |
| jroll | so I think it's good | 13:41 |
| * dtantsur is confused like hell | 13:41 | |
| dtantsur | or was it with patch? | 13:41 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Adds node boot device & passthu OSC commands https://review.openstack.org/357400 | 13:44 |
| *** mgoddard_ has joined #openstack-ironic | 13:45 | |
| jlvillal | lucasagomes, Thanks for the explanation on the operators patch. I hope I didn't mess anything up. | 13:45 |
| jroll | dtantsur: okay, confirmed the break on master and the fix on that patch | 13:46 |
| dtantsur | \o/ ship it! | 13:46 |
| dtantsur | pas-ha, unit tests and reno please ^^^ | 13:46 |
| * jroll comments the same on the patch | 13:47 | |
| *** jaosorior_away is now known as jaosorior | 13:48 | |
| ifarkas | jroll, release for wsmanclient: https://review.openstack.org/#/c/360559/ | 13:48 |
| *** mgoddard has quit IRC | 13:48 | |
| jroll | ifarkas: thanks, I'll poke release team | 13:49 |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add classes for Portgroups API enablement https://review.openstack.org/347549 | 13:49 |
| lucasagomes | jlvillal, hey man! Not at all | 13:50 |
| lucasagomes | jlvillal, it's all good man | 13:50 |
| jlvillal | lucasagomes, Thanks :) | 13:50 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add tempest tests for node Adoption https://review.openstack.org/344975 | 13:51 |
| openstackgerrit | Merged openstack/python-ironic-inspector-client: Deprecate global functions in favor of ClientV1 methods https://review.openstack.org/357743 | 13:51 |
| *** cdearborn has joined #openstack-ironic | 13:52 | |
| * dtantsur kills 2 of 3 conductors to make testing simpler | 13:52 | |
| openstackgerrit | Merged openstack/python-ironic-inspector-client: Add functional test for wait_for_finish https://review.openstack.org/357804 | 13:52 |
| milan | sambetts, hi, have you got a minute? ;) | 13:54 |
| sambetts | milan: literally 5 ;) | 13:54 |
| milan | :D | 13:54 |
| milan | just a quick one: I think I might have fixed the states patch ;) | 13:54 |
| milan | as a proof: | 13:55 |
| milan | https://review.openstack.org/#/c/360311/ | 13:55 |
| milan | sambetts, ^ locks removed | 13:55 |
| *** vishwanathj has quit IRC | 13:55 | |
| sambetts | milan: did you see my pings earlier? | 13:55 |
| milan | sambetts, reapply now reentrant: http://paste.openstack.org/show/563280/ without locks | 13:55 |
| milan | sambetts, nope | 13:55 |
| milan | :-/ | 13:55 |
| *** vishwanathj has joined #openstack-ironic | 13:55 | |
| milan | I went offline for a bit | 13:56 |
| *** vsaienko has quit IRC | 13:56 | |
| milan | sorry | 13:56 |
| sambetts | milan: http://paste.openstack.org/show/563384/ | 13:56 |
| vdrok | mjturek: ping | 13:57 |
| mjturek | hey vdrok | 13:58 |
| vdrok | morning :) | 13:58 |
| milan | sambetts, w/r the args change it is in order for the decorator to perform the state transition on the node_info object which is assumed to always be the first arg for simplicity | 13:58 |
| mjturek | morning :) | 13:58 |
| milan | sambetts, w/r the getting stuck: it should not be an issue: see the lock-less screenshot I've just posted ;) | 13:58 |
| vdrok | mjturek: I meant to move the portgroup constructor to the next patch too, the place where self.parent_node_ident is set | 13:58 |
| vdrok | morning milan rloo and jlvillal | 13:58 |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: Reusing oneview_client when possible https://review.openstack.org/358041 | 13:59 |
| milan | morning vdrok! :) | 13:59 |
| rloo | hi vdrok! | 13:59 |
| jlvillal | Privyet vdrok | 13:59 |
| milan | and morning rloo, jlvillal, jroll and all :) | 13:59 |
| rloo | hi milan :) | 13:59 |
| jlvillal | hi milan | 13:59 |
| jroll | morning milan :) | 13:59 |
| sambetts | milan: it can still get stuck if someone doesn't issue a second reapply | 13:59 |
| dtantsur | morning jlvillal, привет! | 14:00 |
| mjturek | vdrok: ahhh okay I'll do that now | 14:00 |
| *** e0ne has joined #openstack-ironic | 14:00 | |
| *** anush_ has joined #openstack-ironic | 14:00 | |
| jlvillal | Good morning dtantsur sambetts jroll mjturek rloo lucasagomes and everyone else :) | 14:01 |
| milan | sambetts, well. true, It would stay in that state, but we assume one day we'll have a safe (at-least-once-delivery) queue in front of the state machine, so it shouldn't be an issue | 14:01 |
| rloo | morning jlvillal | 14:01 |
| mjturek | good morning jlvillal :) | 14:01 |
| vdrok | mjturek: thanks! | 14:01 |
| jlvillal | :) | 14:01 |
| devananda|OSE | g'morning from the ops midcycle | 14:01 |
| *** devananda|OSE is now known as devananda|OPS | 14:01 | |
| milan | sambetts, to get it stuck you'd have to kill the inspector now without the queue | 14:02 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Optionally power off the node when needed https://review.openstack.org/360330 | 14:02 |
| dtantsur | well, at least it's "clean wait" now :) | 14:02 |
| vdrok | mjturek: also all the changes from test_utils in the second change should be moved to the first one, that's an easy one too :) | 14:02 |
| milan | but the user interface can be enhanced to report current state (possibly in a separate patch) so that user can re-submit the request if we want to poor-man-ha it right away | 14:02 |
| vdrok | morning devananda|OPS | 14:02 |
| thiagop | morning devananda|OPS jlvillal vdrok | 14:03 |
| *** foexle has quit IRC | 14:03 | |
| vdrok | morning thiagop | 14:03 |
| mjturek | thanks :) | 14:03 |
| sambetts | milan: I think if reapply fails the node should move into error state | 14:03 |
| jlvillal | Hi thiagop | 14:03 |
| *** hshiina has joined #openstack-ironic | 14:03 | |
| sambetts | milan: that currently doesn't happen, what happens if finished at gets set, but the node remains in reapplying | 14:03 |
| milan | sambetts, wdym? same way as processing? (strictly non-reentrant?) | 14:04 |
| milan | sambetts, the reapplying state is set before anything else happens | 14:04 |
| thiagop | devananda|OPS: I did 359422 to address that thing about ipv6 that we were discussing, but somehow I have a gut feeling that it's not the proper way... | 14:04 |
| dtantsur | pas-ha, confirming: works for me | 14:04 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Adds node boot device & passthough OSC commands https://review.openstack.org/357400 | 14:04 |
| *** mgoddard_ has quit IRC | 14:04 | |
| *** mgoddard has joined #openstack-ironic | 14:05 | |
| milan | sambetts, please note that any race detected will bubble up | 14:05 |
| dtantsur | pas-ha, wanna update the patch or wanna me to update it? | 14:05 |
| sambetts | milan: this has nothing to do with races | 14:05 |
| openstackgerrit | Georgy Dyuldin proposed openstack/ironic: New test for check instances in shared network https://review.openstack.org/360573 | 14:05 |
| thiagop | jroll: welcome back! In the middle of that tempest discussion, you mentioned that pxe drivers doesn't supports ipv6. But the multitenant job has it on somehow... | 14:05 |
| * milan thinks | 14:05 | |
| sambetts | milan: I'm talking about real exceptions from things like _run_post_hooks, if that happens we get stuck in reapplying | 14:05 |
| sambetts | milan: because the try except in reapply eats the exception | 14:06 |
| sambetts | milan: without issuing a state transition to error or finished | 14:06 |
| pas-ha | dtantsur: I'll do it (add unit tests) | 14:06 |
| dtantsur | thanks! | 14:06 |
| * dtantsur wants to merge it asap | 14:06 | |
| jroll | thiagop: we don't use ipv6 when booting. the PXE protocol doesn't support ipv6. nothing to do with the drivers. once the user image is up ipv6 is totally fair game | 14:06 |
| milan | sambetts, I don't think so, unless you filter the exception in the decorator, errors move to error state | 14:06 |
| milan | but let's try to be sure | 14:06 |
| *** vsaienko has joined #openstack-ironic | 14:07 | |
| sambetts | milan: the try except doesn't reraise the exception, it eats it | 14:07 |
| sambetts | milan: so the decorator doesn't catch it | 14:07 |
| dtantsur | thiagop, I think it's possible to make iPXE (not PXE) work with IPv6, but I never tried it | 14:07 |
| sambetts | milan: thats why I'm saying we need to reraise the exception, so the decorator catches it | 14:07 |
| milan | sambetts, it eats the no_error exceptions only (the race ones and invalid transitions only) | 14:08 |
| * milan double checks | 14:08 | |
| sambetts | milan: wrong try except, look in the _reapply functioon | 14:08 |
| *** jaosorior has quit IRC | 14:08 | |
| * milan looks | 14:08 | |
| jroll | thiagop: whether or not it's possible with some changes, right now we just want to remove those tests and change nothing, so I'd block it on ipv6 and figure it out later | 14:08 |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add classes for Portgroups API enablement https://review.openstack.org/347549 | 14:08 |
| thiagop | jroll: you might wanna look 355591, but it'll require some changes in project_config, and devstack... | 14:10 |
| milan | sambetts, I see, you're right; basically the _reapply eats all | 14:11 |
| thiagop | jroll: but it may work without actually removing anything from tesmpest though, so we avoid that downtime we expected | 14:11 |
| sambetts | milan: exactly | 14:11 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add node validate OSC command https://review.openstack.org/359322 | 14:12 |
| milan | sambetts, I see no other sane way but to raise some error instead of eating it, wdyt? | 14:13 |
| * milan would remove first try:except Exception block for sure | 14:14 | |
| sambetts | milan: I think we need to move the _finish call out of that try, and then reraise the exceptions from that except | 14:14 |
| milan | yeah, the later try block | 14:14 |
| jroll | thiagop: good stuff, reviewed | 14:14 |
| * thiagop checks | 14:15 | |
| *** mtanino has joined #openstack-ironic | 14:16 | |
| lucasagomes | devananda|OPS, morning, how is it going ? | 14:18 |
| milan | sambetts, we can kill both the try blocks, we'd lose only the log message containing the word 'reapplying' or we can add custom node_info.fsm_event('error') transitions in the exception handlers | 14:19 |
| milan | or re-raise, yeah | 14:20 |
| *** michauds has joined #openstack-ironic | 14:21 | |
| *** syed_ has joined #openstack-ironic | 14:21 | |
| *** wajdi has joined #openstack-ironic | 14:22 | |
| *** sborkows has quit IRC | 14:22 | |
| *** rbartal has quit IRC | 14:27 | |
| sambetts | milan: I think reraising should be ok | 14:28 |
| *** e0ne has quit IRC | 14:29 | |
| milan | sambetts, OK, thx, I'll fix that, feel free to -1 | 14:29 |
| sambetts | milan: awesome thanks :) | 14:29 |
| *** chas has quit IRC | 14:31 | |
| *** rajinir has joined #openstack-ironic | 14:32 | |
| *** e0ne has joined #openstack-ironic | 14:34 | |
| *** thrash is now known as thrash|biab | 14:35 | |
| *** hoangcx has joined #openstack-ironic | 14:37 | |
| sambetts | milan: definatly move the _finish() call out of the try though, because the _finish decorator will catch exceptions from then, and then if we reraise that error from _finish then the _reapply decorator will also try to move the node into error | 14:38 |
| mjturek | vdrok: also moved the utils.py changes from 332166 to 347549 as you requested | 14:40 |
| mjturek | 177* | 14:41 |
| *** sabeen has joined #openstack-ironic | 14:41 | |
| wznoinsk | would anyone have a clue what's the best way to return to the user that deployed an instance the name of the ironic node the instance was deployed to? | 14:41 |
| *** sdake has joined #openstack-ironic | 14:42 | |
| *** moshele has quit IRC | 14:43 | |
| *** vishwanathj has quit IRC | 14:44 | |
| *** vishwanathj has joined #openstack-ironic | 14:44 | |
| *** e0ne has quit IRC | 14:45 | |
| *** vishwanathj has quit IRC | 14:46 | |
| *** vishwanathj has joined #openstack-ironic | 14:46 | |
| vsaienk0 | hello mjturek | 14:47 |
| mjturek | Hey vsaienk0 | 14:47 |
| vsaienk0 | mjturek are you going to upload a new version of https://review.openstack.org/#/c/332177 ? | 14:48 |
| mjturek | I was just working on it | 14:48 |
| mjturek | is that okay?? | 14:48 |
| vsaienk0 | mjturek: I have a patch that should be on top of that | 14:48 |
| *** openstackgerrit has quit IRC | 14:48 | |
| mjturek | vsaienk0: can you point me to it? | 14:49 |
| vsaienk0 | mjturek: just let me know when new version is uploaded | 14:49 |
| mjturek | vsaienk0 will do :) | 14:49 |
| vsaienk0 | mjturek I didn't upload it yet | 14:49 |
| mjturek | ahhh got it | 14:49 |
| *** openstackgerrit has joined #openstack-ironic | 14:49 | |
| *** mvpnitesh has quit IRC | 14:50 | |
| lucasagomes | someone have seem this with QEMU on devstack already http://paste.openstack.org/show/563398/ ? (I'm running on fedora 24) | 14:51 |
| *** rama_y has joined #openstack-ironic | 14:52 | |
| thiagop | jroll: on skip_checks, you mean leave checking from driver_enabled? | 14:55 |
| *** praneshp has joined #openstack-ironic | 14:57 | |
| openstackgerrit | Merged openstack/ironic: IPMITool: Check the boot mode when setting the boot device https://review.openstack.org/354186 | 14:59 |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Centralize Config Options - patch merge, cleanup https://review.openstack.org/330160 | 15:00 |
| *** thrash|biab is now known as thrash | 15:02 | |
| *** sai has joined #openstack-ironic | 15:03 | |
| jroll | thiagop: something like that, not sure the best route, but those clearly aren't working right :) | 15:04 |
| *** jpich has quit IRC | 15:04 | |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Centralize Config Options - patch merge, cleanup https://review.openstack.org/330160 | 15:06 |
| milan | sambetts, I think it's on more spots :-/ maybe I should kill the exceptions handling inside the decorator and do it in the node_info.finished() instead | 15:07 |
| *** bnemec has quit IRC | 15:08 | |
| * milan hacks | 15:08 | |
| *** dprince has quit IRC | 15:09 | |
| sambetts | milan: tbh I'm not sure if we should be manually calling .finsihed anymore, I would rather if moving to Error or Finished did it for us right? | 15:09 |
| sambetts | milan: because we'll do it every time we move to one of those states right? | 15:10 |
| milan | sambetts, it is duplicate true | 15:10 |
| sambetts | milan: then we could just raise the exception and handle it in the decorator | 15:10 |
| sambetts | milan: or in the transition function I guess | 15:11 |
| milan | sambetts, I'd like that, but the pattern is wide-spread | 15:11 |
| milan | sambetts, for instance, the _reapply would be much more simpler if we killed the try blocks | 15:12 |
| milan | and the decorator would take care of it | 15:12 |
| sambetts | milan: ++ | 15:12 |
| *** bnemec has joined #openstack-ironic | 15:13 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Fix fall back to newer keystonemiddleware options https://review.openstack.org/360483 | 15:13 |
| sambetts | the less manual stuff we do in those functions relating to the state machine the better | 15:14 |
| pas-ha | dtantsur: jroll: ^ done, with unit tests | 15:14 |
| sambetts | milan: that includes setting .finished on a node | 15:14 |
| milan | sambetts, ideally the state transition would do a single thing only | 15:14 |
| milan | sambetts, yeah | 15:14 |
| dtantsur | pas-ha, awesome! | 15:15 |
| *** vishwanathj has quit IRC | 15:15 | |
| *** vishwanathj has joined #openstack-ironic | 15:16 | |
| mat128|away | anyone ever contributed in diskimage-builder with a depends-on IPA? | 15:16 |
| mat128|away | s/in/to | 15:16 |
| *** mat128|away is now known as mat128 | 15:16 | |
| JayF | cinerama: ^ would be a good person to ask that | 15:18 |
| milan | sambetts, but there's the other thing: we never know (from the decorator pov) which exceptions it should re-raise to avoid multiple error transitions from nested calls. Maybe it wasn't such a good idea after all | 15:18 |
| *** vishwanathj has quit IRC | 15:18 | |
| dtantsur | mat128, won't really work, I think | 15:18 |
| *** vishwanathj has joined #openstack-ironic | 15:19 | |
| sambetts | milan: right, I'm not sure if we should be calling functions which are also a transition from inside a transition | 15:19 |
| mat128 | looks like it's doing a git clone | 15:19 |
| milan | sambetts, right | 15:20 |
| mat128 | then I'll work towards merging my initial change :) | 15:20 |
| mat128 | jlvillal, tonyb: should be final https://review.openstack.org/#/c/358855/ :) | 15:20 |
| *** links has joined #openstack-ironic | 15:21 | |
| * milan suspects the node_info.finish() being the only true transition | 15:23 | |
| sambetts | milan: we could make Error -> Error a safe transition or ignored, then when an error is reraised in the decorator it'll be caught by the next decorator up and ignored | 15:24 |
| milan | sambetts, that might work | 15:25 |
| thiagop | jroll: the problem is just with ipv6, as far as I can tell... I'm thinking about removing just this test to check | 15:25 |
| thiagop | just this check to test* | 15:25 |
| jroll | thiagop: yeah, just remove that check in our plugin for now | 15:25 |
| sambetts | milan: or we wrap the exception in a differnt exception when we reraise it from the decortor so we can identify its the reraised exception and not the original one | 15:25 |
| milan | sambetts, that's actually a clever trick | 15:26 |
| milan | :) | 15:26 |
| sambetts | milan: tbh why does the decorator reraise the exception? Do we need that, if we move the error we in a final state and all processing should stop on that node right? | 15:26 |
| sambetts | milan: kind of multiple paths to go down | 15:27 |
| sambetts | I think the wrapping one makes the most sense | 15:27 |
| thiagop | jroll: and I'm thinking about adding a dependcy from 359422 | 15:28 |
| milan | sambetts, I thought the same | 15:28 |
| milan | I need to think it through again | 15:28 |
| vdrok | rloo: devananda|OPS - https://review.openstack.org/360634 tiny followup to the docs update | 15:28 |
| jroll | thiagop: yeah, tempest patch should depend on ironic patch | 15:28 |
| vdrok | mjturek: ^^ here is where the api history description is | 15:28 |
| milan | sambetts, thx for reviewing and discussing, I have to be running now but I'll try to figure out something for tomorrow's review | 15:29 |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with node-port-list. https://review.openstack.org/360636 | 15:29 |
| thiagop | in fact, the ironic patch would depend on 358116 | 15:29 |
| *** vsaienko has quit IRC | 15:29 | |
| thiagop | but this isn't fit for review yet | 15:29 |
| sambetts | milan: Its an awesome patch dude, just need to work out all the edge cases and wierd parts :-P | 15:30 |
| mjturek | vdrok: oh cool, thank you | 15:30 |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with node-list command https://review.openstack.org/360549 | 15:30 |
| milan | sambetts, thanks :D | 15:30 |
| * milan out good night everyone! :) | 15:31 | |
| *** derekh has quit IRC | 15:31 | |
| dtantsur | jroll, mind reviewing https://review.openstack.org/360483 please? | 15:32 |
| jroll | dtantsur: +2 | 15:33 |
| jroll | meh, +W | 15:33 |
| jroll | why not | 15:33 |
| JayF | I reviewed and +2'd as well | 15:34 |
| JayF | lannnnd | 15:34 |
| *** derekh has joined #openstack-ironic | 15:34 | |
| vdrok | good night milan | 15:35 |
| *** milan has quit IRC | 15:35 | |
| lucasagomes | :-O 4+2 then | 15:36 |
| dtantsur | thanks! :) | 15:36 |
| JayF | https://review.openstack.org/360634 <-- someone wanna land this for vdrok too? | 15:37 |
| * lucasagomes just found out that you can use brackets to go to the next/previous file in the web gerrit | 15:37 | |
| sambetts | lucasagomes: its the best isn't it | 15:37 |
| vdrok | lucasagomes: that's the best feature of gerrit :) | 15:37 |
| lucasagomes | JayF, done | 15:38 |
| lucasagomes | sambetts, vdrok indeed | 15:38 |
| lucasagomes | I'm still mad about binding ctrl+f tho | 15:38 |
| vdrok | thanks JayF and lucasagomes :) | 15:38 |
| *** hoangcx has quit IRC | 15:38 | |
| sambetts | lucasagomes: yeah that still sucks, I discovered why though | 15:38 |
| lucasagomes | sambetts, cause it's horrible slow ? | 15:39 |
| sambetts | lucasagomes: they don't actualy load all the code into the page, so using normal ctrl-f won't search all the code | 15:39 |
| sambetts | lucasagomes: only whats on the screen at the time | 15:39 |
| lucasagomes | sambetts, I'm fine with that... they already bind "/" for the gerrit search | 15:39 |
| lucasagomes | they should stick with it | 15:39 |
| lucasagomes | and leave ctrl+f for the browser | 15:40 |
| lucasagomes | as it should it be | 15:40 |
| sambetts | lucasagomes: ah I didn't know about / :-P | 15:40 |
| lucasagomes | yeah | 15:40 |
| *** praneshp has quit IRC | 15:42 | |
| *** hshiina has quit IRC | 15:43 | |
| *** vishwanathj has quit IRC | 15:44 | |
| *** hoangcx has joined #openstack-ironic | 15:44 | |
| *** vishwanathj has joined #openstack-ironic | 15:45 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add individual_mode_supported field to portgroup https://review.openstack.org/360646 | 15:45 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Rely on portgroup individual_mode_supported https://review.openstack.org/360647 | 15:46 |
| vsaienk0 | does anybody know if permissions for /var/log/ironic on devstack was changed recently? http://logs.openstack.org/14/314514/19/gate/gate-tempest-dsvm-ironic-multitenant-network/4c27d94/logs/screen-ir-cond.txt.gz?level=ERROR#_2016-08-25_14_58_10_999 | 15:48 |
| sambetts | vsaienk0: someone else had this issue a couple of days ago, I'm not sure what the resolution was | 15:49 |
| sambetts | vsaienk0: QQ shouldn't we add the new field first and then rebase the API patches on that? | 15:51 |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Centralize Config Options - patch merge, cleanup https://review.openstack.org/330160 | 15:52 |
| vsaienk0 | sambetts: you mean split db and API logic? | 15:53 |
| *** aNupoisc has joined #openstack-ironic | 15:54 | |
| sambetts | vsaienk0: no, I mean add the new individual_mode_supported field before we merge the portgroup API, so that the protection is in place before we expose portgroups in the API | 15:54 |
| vsaienk0 | sambetts: ok, I will move db part to the bottom of the chain, and merge individual_mode_supported API part with API patch https://review.openstack.org/#/c/332177 | 15:56 |
| sambetts | vsaienk0: makes sense to me :) thanks | 15:56 |
| vsaienk0 | sambetts: there will be no need to bump API version in this case :) | 15:57 |
| sambetts | yup | 15:58 |
| sambetts | just the one bump when we add the new API | 15:58 |
| *** links has quit IRC | 16:00 | |
| *** derekh has quit IRC | 16:02 | |
| *** hoangcx has quit IRC | 16:02 | |
| *** hoangcx has joined #openstack-ironic | 16:03 | |
| *** vishwanathj has quit IRC | 16:04 | |
| *** vishwanathj has joined #openstack-ironic | 16:05 | |
| *** vsaienko has joined #openstack-ironic | 16:06 | |
| *** rbudden has quit IRC | 16:06 | |
| *** jvgrant has joined #openstack-ironic | 16:06 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: DevStack: Configure retrieving logs from the deploy ramdisk https://review.openstack.org/360658 | 16:06 |
| *** hoangcx has quit IRC | 16:08 | |
| lucasagomes | someone else wants to take a look at: https://review.openstack.org/#/c/360018/ ? This has to do with the fallback from master IPA using Ironic mitaka services | 16:12 |
| lucasagomes | thx TheJulia for testing it | 16:12 |
| lucasagomes | and fixing :-) | 16:12 |
| sambetts | lucasagomes: trying to take a look, gerrit is being super slow right now | 16:13 |
| *** praneshp has joined #openstack-ironic | 16:13 | |
| lucasagomes | sambetts, no worries :-) | 16:13 |
| jlvillal | Ugh. Gerrit issues :( | 16:15 |
| jroll | +2 from me | 16:15 |
| lucasagomes | ty | 16:15 |
| sambetts | jlvillal: its painful for me right now | 16:15 |
| * lucasagomes feels the pain with gerrit now too | 16:15 | |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add portgroups to support LAG interfaces - API https://review.openstack.org/332177 | 16:16 |
| mjturek | vsaienk0 vdrok ^ | 16:16 |
| mjturek | vsaienk0: just saw your comment on 347549, sorry I wasn't sure what the etiquette was for splitting up patches :-\ I'll fix that now! | 16:18 |
| *** dprince has joined #openstack-ironic | 16:19 | |
| *** michauds has quit IRC | 16:21 | |
| *** michauds has joined #openstack-ironic | 16:21 | |
| *** aNupoisc has quit IRC | 16:23 | |
| sambetts | vsaienk0: just thinking we should probably have a check for pxe_enabled vs individual_mode_supported because we know that pxe can not be used on ports in a bond that does support fallback | 16:23 |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add classes for Portgroups API enablement https://review.openstack.org/347549 | 16:24 |
| *** hoangcx has joined #openstack-ironic | 16:25 | |
| *** vishwanathj has quit IRC | 16:27 | |
| *** vishwanathj has joined #openstack-ironic | 16:28 | |
| NobodyCam | Good Morning Ironicers | 16:29 |
| sambetts | o/ NobodyCam | 16:31 |
| NobodyCam | morning sambetts :) | 16:31 |
| *** chas has joined #openstack-ironic | 16:31 | |
| lucasagomes | NobodyCam, morning | 16:32 |
| NobodyCam | hey hey lucasagomes Good Morning :) | 16:32 |
| vdrok | morning NobodyCam | 16:33 |
| NobodyCam | morning vdrok :) | 16:33 |
| vdrok | ifarkas: did you see the comment re additional unittest? | 16:33 |
| sambetts | jroll, lucasagomes: Code looks good to me, you guys happy if I +W that fallback patch? | 16:35 |
| lucasagomes | sambetts, not at all | 16:35 |
| * lucasagomes already +2 it | 16:35 | |
| jroll | +1 | 16:35 |
| ifarkas | vdrok, hmm, not sure. which patchset? | 16:35 |
| NobodyCam | morning and welcome back jroll | 16:36 |
| vdrok | ifarkas: the last one, it's inside the comment with free_size_mb/free_space_mb | 16:36 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add openstack baremetal chassis commands https://review.openstack.org/345815 | 16:36 |
| ifarkas | vdrok, oh, I missed that, sorry | 16:36 |
| ifarkas | vdrok, will update the patch | 16:36 |
| jroll | NobodyCam: thanks, morning | 16:36 |
| *** chas has quit IRC | 16:36 | |
| *** dprince has quit IRC | 16:37 | |
| NobodyCam | :) | 16:37 |
| vdrok | ifarkas: yeah, np, thanks, it's looking good :) | 16:37 |
| ifarkas | vdrok, awesome! | 16:38 |
| *** rbrud has joined #openstack-ironic | 16:38 | |
| *** e0ne has joined #openstack-ironic | 16:39 | |
| *** jpich has joined #openstack-ironic | 16:40 | |
| *** ifarkas is now known as ifarkas_afk | 16:42 | |
| *** e0ne has quit IRC | 16:43 | |
| *** hoangcx has quit IRC | 16:45 | |
| *** rcernin has quit IRC | 16:45 | |
| *** fragatina has joined #openstack-ironic | 16:47 | |
| *** fragatina has quit IRC | 16:47 | |
| *** fragatina has joined #openstack-ironic | 16:48 | |
| *** fragatina has quit IRC | 16:49 | |
| *** fragatina has joined #openstack-ironic | 16:50 | |
| *** aNupoisc has joined #openstack-ironic | 16:51 | |
| *** dprince has joined #openstack-ironic | 16:53 | |
| *** vsaienko has quit IRC | 16:54 | |
| openstackgerrit | Merged openstack/bifrost: Update release notes for Newton https://review.openstack.org/357868 | 16:55 |
| *** hoangcx has joined #openstack-ironic | 16:55 | |
| *** tesseract- has quit IRC | 16:56 | |
| *** aNupoisc has quit IRC | 17:00 | |
| *** anush_ has quit IRC | 17:00 | |
| *** athomas has quit IRC | 17:01 | |
| *** vsaienko has joined #openstack-ironic | 17:03 | |
| *** e0ne has joined #openstack-ironic | 17:07 | |
| *** vsaienko has quit IRC | 17:10 | |
| *** aNupoisc has joined #openstack-ironic | 17:10 | |
| *** lucasagomes is now known as lucas-dinner | 17:12 | |
| lucas-dinner | folks I'm calling it a day, have a great evening all | 17:14 |
| lucas-dinner | talk to you all tomorrow | 17:14 |
| JayF | o/ | 17:14 |
| *** sabeen has quit IRC | 17:15 | |
| NobodyCam | have a good night lucas-dinner | 17:16 |
| *** amotoki has quit IRC | 17:17 | |
| openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/360233 | 17:18 |
| *** yogi has quit IRC | 17:19 | |
| *** chas has joined #openstack-ironic | 17:33 | |
| openstackgerrit | Rodion Promyshlennikov proposed openstack/python-ironicclient: Add baremetal port delete command to OSC plugin https://review.openstack.org/346075 | 17:35 |
| *** dtantsur is now known as dtantsur|afk | 17:36 | |
| * sambetts -> home | 17:36 | |
| sambetts | night all | 17:36 |
| *** sambetts is now known as sambetts|afk | 17:36 | |
| * vdrok leaves too, good night! | 17:37 | |
| *** chas has quit IRC | 17:37 | |
| *** rbudden has joined #openstack-ironic | 17:38 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic-specs: Revise driver composition reform defaults https://review.openstack.org/357262 | 17:46 |
| *** rcernin has joined #openstack-ironic | 17:54 | |
| *** jcoufal has joined #openstack-ironic | 17:59 | |
| *** sdake has quit IRC | 18:03 | |
| *** sdake has joined #openstack-ironic | 18:04 | |
| vgadiraj | was multitasking, messed up, and a bunch of local commits on my machine got pushed to gerrit as individual commits | 18:05 |
| mat128 | vgadiraj: havent seen notification for those | 18:06 |
| mat128 | are you sure they are in ironic? | 18:06 |
| mat128 | btw, you can always abandon them via the gerrit UI | 18:06 |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Centralize Config Options - patch merge, cleanup https://review.openstack.org/330160 | 18:06 |
| vgadiraj | thanks mat128 | 18:07 |
| vgadiraj | no they are in openstack-infra | 18:07 |
| mat128 | vgadiraj: to be honest, the commit titles look precise enough that I would keep them as is | 18:08 |
| mat128 | I'd rather see 3-4 chained commits that cover small changes each | 18:08 |
| mat128 | than a huge one | 18:08 |
| mat128 | Oh | 18:08 |
| mat128 | sorry | 18:08 |
| mat128 | thought you were "David Shrewsbury" for a minuute | 18:08 |
| mat128 | yeah, I would squash :) | 18:09 |
| thiagop | sambetts|afk rajinir mjturek received word from the talk now, unfortunately it was not selected | 18:12 |
| thiagop | gabriel-bezerra: ^ | 18:12 |
| *** vsaienko has joined #openstack-ironic | 18:13 | |
| *** david-lyle_ has joined #openstack-ironic | 18:15 | |
| *** david-lyle_ has quit IRC | 18:15 | |
| *** hoangcx has quit IRC | 18:15 | |
| *** fragatina has quit IRC | 18:17 | |
| *** hoangcx has joined #openstack-ironic | 18:20 | |
| mjturek | thiagop: :( thanks for the effort! | 18:21 |
| *** aswadr_ has quit IRC | 18:21 | |
| mat128 | thiagop: we were refused some of our talks too (others still unknown) | 18:22 |
| thiagop | mjturek: maybe we can submit again next year | 18:24 |
| *** e0ne has quit IRC | 18:24 | |
| mjturek | thiagop: definitely | 18:27 |
| * jlvillal is kind of surprised that his upgrade from Fedora 22 to Fedora 24 seems to have gone without any issues... | 18:28 | |
| thiagop | jlvillal: the hidden ones are the worst | 18:29 |
| thiagop | :P | 18:29 |
| *** electrofelix has quit IRC | 18:30 | |
| *** sabeen has joined #openstack-ironic | 18:31 | |
| jlvillal | thiagop: I guess I will find out. | 18:32 |
| jlvillal | thiagop: So far the important stuff is working. Browser, IRC, and my bash shell :) | 18:32 |
| *** Sukhdev has joined #openstack-ironic | 18:33 | |
| jlvillal | OpenStack Summit schedule is now up: https://www.openstack.org/summit/barcelona-2016/summit-schedule | 18:35 |
| mat128 | oh sweet | 18:35 |
| mat128 | some of our stuff was accepted | 18:35 |
| mat128 | https://www.openstack.org/summit/barcelona-2016/summit-schedule/global-search?t=Migrating+a+bare+metal+server+into | 18:35 |
| openstackgerrit | Merged openstack/ironic: Merge imports in code https://review.openstack.org/357597 | 18:36 |
| mat128 | https://www.openstack.org/summit/barcelona-2016/summit-schedule/global-search?t=Can+OpenStack+beat+Amazon | 18:36 |
| jlvillal | mat128: Cool :) | 18:40 |
| wajdi | \o/ | 18:41 |
| mat128 | lastly, https://www.openstack.org/summit/barcelona-2016/summit-schedule/events/16373/converting-a-traditional-app-to-containers-how-crowdstar-built-an-effective-ecosystem-on-openstack | 18:41 |
| *** vishwanathj has quit IRC | 18:47 | |
| *** vishwanathj has joined #openstack-ironic | 18:48 | |
| *** krotscheck has left #openstack-ironic | 18:50 | |
| *** jcoufal has quit IRC | 18:51 | |
| openstackgerrit | Hugo Nicodemos proposed openstack/python-oneviewclient: Add auditing instrumentation for python-oneviewclient https://review.openstack.org/337281 | 18:51 |
| *** hoangcx has quit IRC | 18:53 | |
| *** chas has joined #openstack-ironic | 18:54 | |
| *** jhooker has quit IRC | 18:55 | |
| *** hoangcx has joined #openstack-ironic | 18:55 | |
| *** jhooker has joined #openstack-ironic | 18:55 | |
| *** praneshp has quit IRC | 18:59 | |
| *** chas has quit IRC | 18:59 | |
| *** praneshp has joined #openstack-ironic | 19:01 | |
| *** praneshp has quit IRC | 19:01 | |
| *** praneshp has joined #openstack-ironic | 19:02 | |
| *** fragatina has joined #openstack-ironic | 19:02 | |
| *** Bill has joined #openstack-ironic | 19:02 | |
| *** Bill is now known as Guest79231 | 19:03 | |
| *** praneshp has quit IRC | 19:08 | |
| *** hshiina has joined #openstack-ironic | 19:09 | |
| *** Guest79231 has quit IRC | 19:14 | |
| rajinir | thiagop>sambetts|afk rajinir mjturek: Hard luck | 19:16 |
| *** jheroux has joined #openstack-ironic | 19:17 | |
| *** e0ne has joined #openstack-ironic | 19:21 | |
| *** JasonF has joined #openstack-ironic | 19:21 | |
| *** praneshp has joined #openstack-ironic | 19:22 | |
| *** e0ne has quit IRC | 19:23 | |
| mat128 | jlvillal: would you mind re-reviewing my upper-constraint change? https://review.openstack.org/#/c/358855/ | 19:23 |
| mat128 | this should be the last patchset :) | 19:23 |
| *** jhooker has quit IRC | 19:24 | |
| *** jvgrant_ has joined #openstack-ironic | 19:37 | |
| *** jvgrant has quit IRC | 19:41 | |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is restarting to implement some performance tuning adjustments, and should return to working order momentarily. | 19:46 | |
| *** jheroux has quit IRC | 19:48 | |
| *** jheroux has joined #openstack-ironic | 19:51 | |
| *** chas has joined #openstack-ironic | 19:55 | |
| openstackgerrit | Merged openstack/ironic: Fix fall back to newer keystonemiddleware options https://review.openstack.org/360483 | 19:59 |
| *** jheroux has quit IRC | 19:59 | |
| *** JayF has quit IRC | 20:00 | |
| *** chas has quit IRC | 20:00 | |
| *** jpich has quit IRC | 20:00 | |
| *** JasonF is now known as JayF | 20:00 | |
| *** sambetts|afk has quit IRC | 20:02 | |
| *** sdake has quit IRC | 20:03 | |
| *** jheroux has joined #openstack-ironic | 20:03 | |
| *** sdake has joined #openstack-ironic | 20:04 | |
| *** sambetts has joined #openstack-ironic | 20:05 | |
| *** dprince has quit IRC | 20:07 | |
| openstackgerrit | Merged openstack/ironic: Update the webapi version history reference https://review.openstack.org/360634 | 20:08 |
| *** bfournie has quit IRC | 20:13 | |
| openstackgerrit | Michael Turek proposed openstack/ironic: Prevent URL collisions with sub-controllers: nodes/ports https://review.openstack.org/314514 | 20:18 |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add classes for Portgroups API enablement https://review.openstack.org/347549 | 20:18 |
| *** vishwanathj has quit IRC | 20:19 | |
| *** vishwanathj has joined #openstack-ironic | 20:20 | |
| *** sabeen has quit IRC | 20:23 | |
| openstackgerrit | Michael Turek proposed openstack/ironic: Add portgroups to support LAG interfaces - API https://review.openstack.org/332177 | 20:28 |
| *** vishwanathj has quit IRC | 20:28 | |
| *** vishwanathj has joined #openstack-ironic | 20:29 | |
| *** sabeen has joined #openstack-ironic | 20:29 | |
| *** sdake has quit IRC | 20:29 | |
| *** sdake has joined #openstack-ironic | 20:35 | |
| devananda|OPS | impromptu session on bare metal at the OPS midcycle just finished - etherpad here: https://etherpad.openstack.org/p/NYC-ops-Bare-Metal | 20:41 |
| mat128 | devananda|OPS: nice, glad to see mgagne was part of the session :) | 20:42 |
| JayF | Is there a reason nodes don't go to DEPLOYWAIT while images are being downloaded/written by the agent? | 20:44 |
| JayF | morgabra: ^ relevant to downstrea mdiscussion | 20:44 |
| mat128 | JayF: they should, no? | 20:44 |
| *** aNupoisc has quit IRC | 20:44 | |
| JayF | morgabra: tl;dr in DEPLOYWAIT and DEPLOYFAIL state we support deletion | 20:44 |
| mgagne | mat128: sdague asked more info about scheduler performance issue. I will make sure to open a bug about it so we can look into it. | 20:45 |
| mat128 | mgagne: cool | 20:45 |
| devananda|OPS | JayF: does the driver know when the agent is downloading the image? | 20:45 |
| JayF | devananda|OPS: yes. | 20:45 |
| JayF | I'm going to double check to make sure that assumption is correct | 20:45 |
| devananda|OPS | JayF: then changing that state seems totally reasonable | 20:45 |
| devananda|OPS | JayF: historically, that's the inverse of the iscsi approach | 20:46 |
| mat128 | JayF: | 20:46 |
| mat128 | https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L278 | 20:46 |
| mat128 | prepare_image then "wait" | 20:46 |
| devananda|OPS | deploywait == while machine is booting; deploying == while image is being written over iscsi | 20:46 |
| mat128 | so it should go to deploywait.. | 20:46 |
| JayF | mat128: was looking for that, now to go see if what we have deployed downstream works that way | 20:46 |
| JayF | (6.0.0 + patches) | 20:46 |
| mat128 | JayF: "wait" is relatively new, if you had continue_deploy() overridden locally, it's possible you don't even have that call in there | 20:47 |
| mat128 | which would explain why you're stuck in deploying | 20:47 |
| jlvillal | mat128: On the upper-constraint change. It might be "fun" to backport it to stable/liberty and see if it works. | 20:47 |
| devananda|OPS | JayF: request for ironic to recover from maintenance mode, specifically when it turned on because of ipmi failures in power loop, came up again | 20:47 |
| jlvillal | mat128: My definition of "fun" maybe different than yours ;) | 20:47 |
| JayF | mat128: yep, we kick it to wait too | 20:47 |
| JayF | mat128: that's unfortunate :) | 20:47 |
| mat128 | jlvillal: you mean push the change and see what happens? | 20:48 |
| mat128 | jlvillal: I can do that :) I thought we cherry-picked only once the change landed in master | 20:48 |
| jlvillal | mat128: Just do a backport of the unmerged change to stable/liberty. And then see if it works | 20:48 |
| mat128 | but I guess I can push that as a test | 20:48 |
| JayF | devananda|OPS: https://review.openstack.org/#/c/334113/ very draft spec | 20:48 |
| jlvillal | mat128: As a test. You can -1 it. | 20:48 |
| JayF | devananda|OPS: mainly there to allow a place for chat, I was going to start running with it post-release | 20:48 |
| devananda|OPS | JayF: great | 20:49 |
| *** aNupoisc has joined #openstack-ironic | 20:49 | |
| jlvillal | mat128: The patch looks good to me. But the proof is in the pudding, as they say. | 20:49 |
| JayF | devananda|OPS: your comments are always appreciated on something like that :D | 20:49 |
| JayF | morgabra: tl;dr: you can call ironic delete API on any node, as long as the agent is doing work, ironic will happily delete it | 20:49 |
| devananda|OPS | JayF: TheJulia: there was a lot of positive reaction to node adoption, btw | 20:49 |
| JayF | mat128: yep, we do it right downstream | 20:49 |
| JayF | mat128: that seems to be happening more and more often as we get more and more of our patches upstream :D | 20:50 |
| mat128 | JayF: :) | 20:50 |
| morgabra | JayF: hm | 20:50 |
| mat128 | JayF: so you're saying you see nodes in deploying and you can see them doing the download/deploy? | 20:50 |
| * morgabra reads code | 20:50 | |
| mat128 | JayF: are you sure you're on the right now (i know, i know) :) | 20:51 |
| JayF | mat128: I'm saying that's how it used to be, and sometimes I miss patches that make things not terrible :D | 20:51 |
| JayF | mat128: everything in ironic's side works as expected, and is reasonable | 20:51 |
| mat128 | jlvillal: there's no proxy.sh in stable/liberty | 20:52 |
| mat128 | jlvillal: bunch of conflicts :( | 20:52 |
| morgabra | JayF: so the deploy attempting to finish even after setting provision_state to deleted is expected? | 20:53 |
| jlvillal | mat128: Sorry. However put that proxy.sh stuff in should be taken out behind the woodshed ;) | 20:53 |
| jlvillal | s/However/Whoever/ | 20:53 |
| mat128 | jlvillal: :P | 20:53 |
| mat128 | I dont think that was backported as it's more of a build tooling than actual code | 20:53 |
| jlvillal | mat128: Basically the command should be the same, just without proxy.sh in the beginning. I think. | 20:53 |
| mat128 | yes | 20:53 |
| JayF | morgabra: I suspect that nova driver +CCM is doing something bad | 20:53 |
| JayF | morgabra: if we set provision state to deleted successfully, ironic should not continue deploying | 20:54 |
| mat128 | JayF, morgabra: are you issuing nova delete or ironic node-delete while it's provisioning? | 20:54 |
| *** rbudden has quit IRC | 20:54 | |
| mat128 | nvm, nova delete (otherwise it's not a state) | 20:54 |
| JayF | mat128: we're looking at a case downstream where it looks like delete was called by nova but we're not sure ironic stoppped | 20:54 |
| morgabra | oh | 20:54 |
| morgabra | well | 20:54 |
| morgabra | https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L838 | 20:54 |
| morgabra | I don't think we care | 20:54 |
| morgabra | lol | 20:54 |
| morgabra | on the nova side | 20:55 |
| morgabra | oh, nevermind | 20:55 |
| morgabra | != | 20:55 |
| mat128 | morgabra: check that last line | 20:55 |
| openstack | morgabra: Error: "=" is not a valid command. | 20:55 |
| *** hoangcx has quit IRC | 20:55 | |
| JayF | so if it catches the node in a blip of DEPLOYING (instead of DEPLOYWAIT) it will fail | 20:55 |
| JayF | but I think the ironicclient itself has retries built in | 20:55 |
| TheJulia | devananda|OPS: \o/ | 20:55 |
| mat128 | JayF: didnt we have a bug specifically for handling deletes while building? | 20:56 |
| JayF | mat128: Maybe? I should search for it, eh? | 20:56 |
| mat128 | i vaguely remember something related to it | 20:56 |
| *** rbudden has joined #openstack-ironic | 20:57 | |
| mat128 | maybe it was https://bugs.launchpad.net/ironic/+bug/1477490 ? | 20:57 |
| openstack | Launchpad bug 1477490 in OpenStack Compute (nova) "Ironic: Deleting while spawning can leave orphan ACTIVE nodes in Ironic" [Medium,Confirmed] | 20:57 |
| JayF | https://bugs.launchpad.net/ironic/+bug/1477490 | 20:57 |
| JayF | d'oh, jinx | 20:57 |
| mat128 | JayF, morgabra: what are the symptoms? | 20:57 |
| JayF | mat128: I think that bug covers it | 20:58 |
| JayF | but morgabra was the one digging deeply | 20:58 |
| morgabra | afaict: | 20:58 |
| morgabra | https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L919 <-- this line is printed | 20:58 |
| morgabra | but on the ironic side it continued to finish the deploy some 60s later, which exploded for us on some networking stuff | 20:59 |
| morgabra | because nova cleaned those up too | 20:59 |
| mat128 | oh | 20:59 |
| mat128 | I think we can explain that | 20:59 |
| mat128 | we issue commands to ipa | 20:59 |
| mat128 | every heartbeat ironic checks those | 20:59 |
| mat128 | nothing will stop deployment | 20:59 |
| *** hoangcx has joined #openstack-ironic | 20:59 | |
| mat128 | but the process will not go any further | 20:59 |
| mat128 | check the heartbeat "router" | 21:00 |
| JayF | and morgabra, our downstream networking code prevents it from properly deleting out properly | 21:00 |
| JayF | because we assume the network ports are properly in place | 21:00 |
| morgabra | yeah, I was gonna say: we just need to be smarter about catching that in our deploy driver | 21:00 |
| morgabra | ok | 21:00 |
| *** causten has quit IRC | 21:00 | |
| JayF | or get 6.1.0 asap | 21:00 |
| JayF | and/or | 21:00 |
| JayF | lol | 21:00 |
| morgabra | on it boss | 21:00 |
| jroll | glhf! | 21:00 |
| jroll | :P | 21:00 |
| JayF | I'm not the baws of you anymore, thank goodness :P | 21:00 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Set/unset node's target RAID config via OSC command https://review.openstack.org/360787 | 21:00 |
| thiagop | lol | 21:01 |
| jroll | devananda|OPS: nice etherpad, no big surprises but good stuff | 21:02 |
| mat128 | JayF, morgabra: have to disconnect for a while, but I think you're good to go | 21:03 |
| *** causten has joined #openstack-ironic | 21:03 | |
| mat128 | jlvillal: having trouble rushing that cherry-pick (conflicts and stuff) and I can't think straight anymore lol | 21:03 |
| morgabra | any objection to just yolo powering off the node mid-deploy should a delete happen? | 21:03 |
| mat128 | morgabra: dont see why not | 21:04 |
| mat128 | OH | 21:04 |
| jroll | morgabra: what's it do today? | 21:04 |
| mat128 | was it that you couldn't reach the node anymore after changing network? | 21:04 |
| morgabra | jroll: idk, looking :P | 21:04 |
| jroll | mat128: nah, we change network after deploy is done... deploy, shut down, change networks, power on | 21:05 |
| mat128 | ok, same as us | 21:05 |
| *** sdake_ has joined #openstack-ironic | 21:05 | |
| mat128 | morgabra: how would powering off the node help you then? | 21:05 |
| JayF | mat128: that was re: your comment about "agent still runs commands and ironic checks on them", I think | 21:05 |
| JayF | mat128: you power off the node, no agent is doing shit anymore :D | 21:06 |
| mat128 | :) | 21:06 |
| mat128 | indeed | 21:06 |
| morgabra | yeah, just as a way to kill the deploy faster | 21:06 |
| morgabra | if you delete during it | 21:06 |
| *** causten_ has joined #openstack-ironic | 21:08 | |
| *** causten has quit IRC | 21:08 | |
| *** sdake has quit IRC | 21:08 | |
| * devananda|OPS follows the OPS crowd to a nearby bar, leaves IRC for tomorrow | 21:09 | |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic-python-agent: Enforce upper-constraints when building ramdisks https://review.openstack.org/360793 | 21:10 |
| mat128 | devananda|OPS: have fun | 21:10 |
| mat128 | say hi to mgagne | 21:10 |
| mat128 | jlvillal: completed your backport :) | 21:10 |
| *** rbudden has quit IRC | 21:11 | |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic-python-agent: Enforce upper-constraints when building ramdisks https://review.openstack.org/360795 | 21:13 |
| mat128 | jlvillal: and mitaka ^ | 21:13 |
| mat128 | alright, have fun everyone | 21:13 |
| mat128 | disconnecting | 21:13 |
| mat128 | good luck JayF and morgabra with that prod issue | 21:13 |
| jlvillal | mat128: Thanks. | 21:13 |
| jlvillal | mat128: I hope it passes. | 21:13 |
| JayF | mat128: not really an issue, just a race, and thanks for helping us understand it better | 21:13 |
| jroll | mat128: no liberty? :) | 21:13 |
| mat128 | https://review.openstack.org/360793 | 21:13 |
| morgabra | yeah, little anomaly, nbd :P ty | 21:13 |
| mat128 | done first | 21:14 |
| JayF | mat128: each time we deploy new ironic, these nova ccm races present just slightly differently | 21:14 |
| jroll | yeah sorry | 21:14 |
| JayF | but jroll and Jaypipes are going to save the world for us | 21:14 |
| jlvillal | mat128: Thanks again! | 21:14 |
| * jroll temp -2s those until master lands and such | 21:14 | |
| mat128 | i have my w-1 already | 21:14 |
| mat128 | no? | 21:14 |
| jlvillal | mat128: extra safety :) | 21:15 |
| jroll | mat128: not on mitaka :) | 21:15 |
| jroll | but yeah, just making sure | 21:15 |
| *** vishwanathj has quit IRC | 21:16 | |
| thiagop | Folks, I'm calling it a day | 21:16 |
| *** vishwanathj has joined #openstack-ironic | 21:16 | |
| thiagop | jroll: didn't send the patchset yet because I'm trying to test it on devstack first to avoid passing it on zuul to see that things aren't alright | 21:17 |
| jroll | thiagop: no worries | 21:17 |
| jroll | thiagop: I moved the "check on tempest thing" on my todo list to monday, so you're safe from me bugging you until then :P | 21:18 |
| Sukhdev | jroll : got a min to discuss about Security Groups? | 21:18 |
| jroll | Sukhdev: don't ask to ask, just ask :) | 21:18 |
| thiagop | see ya | 21:18 |
| *** thiagop has quit IRC | 21:18 | |
| *** hoangcx has quit IRC | 21:19 | |
| Sukhdev | jroll : :-) So, let me get to the bottom line - to make this work, I need to send admin tenant_id in the port_create() request to neutron - I am trying to figure out where can I pull that information in the ironic world | 21:19 |
| Sukhdev | jroll: any idea how I get access to it? | 21:19 |
| *** sdake_ has quit IRC | 21:20 | |
| *** hoangcx has joined #openstack-ironic | 21:21 | |
| mrda | Morning Ironic | 21:21 |
| jroll | Sukhdev: you need the tenant id itself or you need a neutron client object that has admin privileges? | 21:21 |
| Sukhdev | just the tenant_id | 21:22 |
| JayF | Ironic doesn't have the tenant id | 21:22 |
| JayF | Does it/ | 21:22 |
| jroll | it might, I'm not sure | 21:22 |
| *** sdake has joined #openstack-ironic | 21:22 | |
| JayF | I mean, it has Ironic's tenant id, but not the id of the tenant who owns the nova instance | 21:22 |
| jroll | Sukhdev: why does port_create() need a tenant id, that's weird | 21:23 |
| jroll | JayF: he needs the "admin tenant_id" | 21:23 |
| JayF | "admin" doesn't mean what it used to in ironic :P | 21:23 |
| JayF | the tenant_id of the nova user calling ironic? or the tenant_id of the user ironic is calling neutron with? | 21:23 |
| jroll | ugh, it really takes tenant_id | 21:24 |
| jroll | JayF: this is about provisioning network ports, so the latter I assume | 21:24 |
| Sukhdev | jroll : so, here is the gist of the issue - SG are per tenant - when we create_port on provisioning network, that network belong to admin | 21:24 |
| Sukhdev | the SG also belongs to admin tenant | 21:24 |
| openstackgerrit | Xavier proposed openstack/ironic: Fix for check if dynamic allocation model is enabled https://review.openstack.org/357425 | 21:24 |
| jroll | Sukhdev: and provisioning ports belong to admin, as well | 21:24 |
| Sukhdev | if Ironic does not send the tenant Id, Neutron stuffs in tenant id or tenant | 21:24 |
| Sukhdev | jroll : so, neutron rejects the request because it can not find SG under tenant's tenant id | 21:25 |
| Sukhdev | jroll : so, ironic needs to tell neutron that port, network, and SG belongs to admin tenant if | 21:26 |
| Sukhdev | s/if/id | 21:26 |
| *** vishwanathj has quit IRC | 21:26 | |
| jroll | Sukhdev: hrm, we should be calling it with ironic's tenant | 21:26 |
| jroll | we might not be though | 21:26 |
| jroll | I don't fully understand how our context thing works | 21:26 |
| *** vishwanathj has joined #openstack-ironic | 21:27 | |
| jroll | Sukhdev: at any rate, give task.context.tenant_id a shot | 21:27 |
| Sukhdev | jroll : I am in the middle of debug session and in pdb - let me pull tenant_id from this context and see if this works | 21:28 |
| jroll | just tenant. | 21:28 |
| jroll | sorry, task.context.tenant | 21:28 |
| Sukhdev | jroll : got it - let me give it shot - be back in a bit | 21:28 |
| jroll | Sukhdev: I probably won't be here, so good luck | 21:28 |
| Sukhdev | jroll : I am already back :-):-) that value is None | 21:29 |
| Sukhdev | jroll : (Pdb) pp task.context.tenant | 21:29 |
| Sukhdev | None | 21:29 |
| jroll | mmm | 21:29 |
| jroll | Sukhdev: how about task.context.is_admin | 21:29 |
| jroll | or task.context.project_name | 21:29 |
| jroll | actually, can you pastebin dir(task.context) | 21:30 |
| Sukhdev | jroll : that is True | 21:30 |
| Sukhdev | I mean the value is True | 21:30 |
| jroll | ok | 21:30 |
| jroll | so I suspect you created the SG/network with a different tenant than ironic's admin tenant | 21:30 |
| Sukhdev | jroll - here is the paste - http://paste.openstack.org/show/563683/ | 21:31 |
| Sukhdev | jroll : I create prov network and SG under admin tenant on the neutron side - then I do the nova boot with net-id of regular tenant | 21:32 |
| jroll | Sukhdev: define 'admin tenant' - is it the same tenant configured in [neutron] section of ironic.conf? | 21:33 |
| Sukhdev | jroll : Ironic does the port_create on the prov network - it needs to send the tenant_id of admin | 21:33 |
| jroll | Sukhdev: it should be making the request as admin, is that not enough? | 21:33 |
| Sukhdev | jroll : see this paste - http://paste.openstack.org/show/563684/ | 21:33 |
| Sukhdev | jroll : when Ironic calls create_port - there is not tenant_id in the request - | 21:34 |
| Sukhdev | jroll : by the time ML2 plugin processes it, it see tenant_id of "demo" and it can not match the SG and rejects the call | 21:34 |
| jroll | Sukhdev: care to paste the [neutron] section of ironic.conf? | 21:35 |
| Sukhdev | jroll - just a sec | 21:35 |
| jroll | I highly suspect it is using the username 'ironic' and the project name of 'service' | 21:36 |
| Sukhdev | jroll : here you go - http://paste.openstack.org/show/563685/ | 21:37 |
| jroll | right | 21:37 |
| jroll | project_name = service | 21:37 |
| jroll | which is not 'admin' | 21:37 |
| jroll | the network/SG need to be created by the service tenant | 21:38 |
| Sukhdev | jroll : that is a good thought - I considered doing that, but, I thought service tenant is a user tenant | 21:39 |
| jroll | it is not | 21:39 |
| jroll | that is the admin user that ironic uses in devstack | 21:39 |
| jroll | because nobody should be using global admin | 21:39 |
| *** wajdi_ has joined #openstack-ironic | 21:39 | |
| Sukhdev | jroll : however, still there is bit of an issue - neutron is stuffing the "demo" tenant ID | 21:40 |
| Sukhdev | jroll : even if we want to use service tenant, we still need to stuff service tenant ID in the call | 21:41 |
| Sukhdev | jroll : where can I get the service tenant_id in the ironic context | 21:41 |
| jroll | Sukhdev: it should be sending the request as service, no clue why neutron is picking up the demo tenant | 21:42 |
| jroll | that's extremely odd and I don't have an answer for that | 21:42 |
| jroll | nor do I know without digging way deep into things where you can get that tenant id | 21:43 |
| *** wajdi has quit IRC | 21:43 | |
| Sukhdev | jroll : oh - I see... | 21:44 |
| Sukhdev | jroll : OK let me dig a bit more into this | 21:44 |
| *** wajdi has joined #openstack-ironic | 21:44 | |
| Sukhdev | jroll : I noticed that even the prov network is created by admin, even if the tenant_id of "demo" is used, neutron is forgiving because networks are sharable and hence, they do not check for exact match | 21:45 |
| Sukhdev | jroll : but, that is not true for SG - hence, it craps out :-) | 21:45 |
| *** wajdi has quit IRC | 21:46 | |
| *** wajdi_ has quit IRC | 21:46 | |
| Sukhdev | jroll : I will dig more and if I find something, will report back | 21:46 |
| jroll | Sukhdev: sure | 21:46 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: Add power state change notifications https://review.openstack.org/321865 | 21:46 |
| jroll | Sukhdev: honestly I don't think this is going to make newton if the code isn't even up yet | 21:47 |
| Sukhdev | jroll : I will give it a shot - then let you make the call | 21:47 |
| Sukhdev | jroll : the good news is that SG for baremetals are working just fine for the tenant networks - only the provisioning and cleaning is what I am trying to fix | 21:48 |
| jroll | Sukhdev: that's what I'm doing now, it's going to take heroics to get this in at this point, and we don't have the resources to do heroics | 21:48 |
| Sukhdev | jroll : even if this patch does not make, we still have support for SG for tenant networks | 21:48 |
| jroll | and yes, I'm aware, that's good :) | 21:48 |
| *** cdearborn has quit IRC | 21:50 | |
| Sukhdev | jroll : So, verified that if I send the matching tenant_id in the port_create() request (i.e. matching with the network/SG tenant) everything works - | 21:56 |
| *** chas has joined #openstack-ironic | 21:56 | |
| Sukhdev | jroll : after network flip the correct SG (ACLs ) are applied correctly as well | 21:56 |
| jroll | Sukhdev: something is incredibly wrong if we need to give neutron a tenant id | 21:57 |
| jroll | Sukhdev: anyway, I'm walking away for the night, glad you got it working | 21:57 |
| Sukhdev | jroll : have a wonderful evening | 21:58 |
| *** vishwanathj has quit IRC | 22:01 | |
| *** chas has quit IRC | 22:01 | |
| *** vishwanathj has joined #openstack-ironic | 22:02 | |
| *** michauds has quit IRC | 22:05 | |
| jlvillal | Should backports have the same or different change-id from the master branch patch? | 22:06 |
| jlvillal | Anyone know. | 22:06 |
| jlvillal | Or it doesn't matter? | 22:06 |
| jlvillal | Looks like the same Change-ID: http://docs.openstack.org/project-team-guide/stable-branches.html#change-ids | 22:08 |
| *** vsaienko has quit IRC | 22:12 | |
| *** vishwanathj has quit IRC | 22:17 | |
| *** vishwanathj has joined #openstack-ironic | 22:18 | |
| *** Goneri has joined #openstack-ironic | 22:22 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Add node serial console documentation https://review.openstack.org/293872 | 22:22 |
| *** vishwanathj has quit IRC | 22:23 | |
| *** sdake has quit IRC | 22:24 | |
| *** jheroux has quit IRC | 22:26 | |
| *** sabeen has quit IRC | 22:33 | |
| *** sdake has joined #openstack-ironic | 22:37 | |
| *** Goneri has quit IRC | 22:39 | |
| openstackgerrit | Merged openstack/ironic: Centralize Config Options - patch merge, cleanup https://review.openstack.org/330160 | 22:45 |
| *** eset has quit IRC | 22:57 | |
| *** chlong has quit IRC | 22:58 | |
| *** eset has joined #openstack-ironic | 22:59 | |
| *** mpsairam has joined #openstack-ironic | 23:00 | |
| openstackgerrit | Merged openstack/python-ironicclient: Update hacking test-requirement https://review.openstack.org/359411 | 23:03 |
| *** causten_ has quit IRC | 23:08 | |
| *** chlong has joined #openstack-ironic | 23:12 | |
| *** hoangcx has quit IRC | 23:17 | |
| *** hoangcx has joined #openstack-ironic | 23:18 | |
| openstackgerrit | Merged openstack/ironic: Prevent URL collisions with sub-controllers: nodes/ports https://review.openstack.org/314514 | 23:23 |
| openstackgerrit | Merged openstack/ironic: Pass swiftclient header values as strings https://review.openstack.org/358020 | 23:23 |
| openstackgerrit | Merged openstack/ironic-python-agent: Update hacking test-requirement https://review.openstack.org/359412 | 23:31 |
| *** chlong has quit IRC | 23:35 | |
| openstackgerrit | Merged openstack/ironic-specs: Changes to some OSC commands https://review.openstack.org/357505 | 23:36 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Use constraints for all the things https://review.openstack.org/360823 | 23:38 |
| *** hoangcx2 has joined #openstack-ironic | 23:42 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Enforce upper-constraints when building ramdisks https://review.openstack.org/360795 | 23:43 |
| *** hoangcx has quit IRC | 23:45 | |
| jlvillal | JayF: You're fast...like a shadow ;) | 23:46 |
| * jlvillal never saw that movie, but remembers the trailer | 23:46 | |
| JayF | When I'm actively reviewing, I tend to click things that pop up in IRC around that time too | 23:46 |
| JayF | because it can be really nice to get a fast review sometimes | 23:46 |
| *** rybridges has joined #openstack-ironic | 23:46 | |
| jlvillal | JayF: Thanks for that | 23:47 |
| jlvillal | JayF: I'd review this one: https://review.openstack.org/293872 But I did some rebasing and refactoring on it. Final part of the Ironic console work. Still need the Nova patch to land. | 23:48 |
| jlvillal | JayF: If you have free time that is. Which the answer is usually no :) | 23:48 |
| jlvillal | For most people | 23:48 |
| JayF | you'd be surprised | 23:48 |
| JayF | I try not to commit out my review time for specific things unless I have to | 23:48 |
| JayF | you do realize I just landed that one, right? | 23:48 |
| jlvillal | JayF: I did not! | 23:49 |
| JayF | the one you just linked, I landed it like 26 minutes ago | 23:49 |
| JayF | lol | 23:49 |
| jlvillal | JayF: Woot! :) | 23:49 |
| jlvillal | JayF: It isn't actually mine, so it lands in my box ironic folder buried among all the other patches. | 23:49 |
| * jlvillal has a folder dedicated to emails about his own patches. | 23:50 | |
| jlvillal | own = Gerrit says I am the owner. | 23:50 |
| jlvillal | Thanks JayF | 23:50 |
| JayF | I use the review dash | 23:51 |
| JayF | and review things under "needs approval" first, generally | 23:51 |
| JayF | unless there's something specific, or a priority that I know needs a review first | 23:51 |
| jlvillal | I try to do that too. When I remember to use the dash | 23:51 |
| JayF | it's the only direct url I keep on my bookmarks toolbar (alongside all the folders) | 23:53 |
| JayF | that way if I'm just screwing around on the internet, and reach the end of the internet | 23:53 |
| JayF | I maybe review a thing or two :) | 23:53 |
| *** rcernin has quit IRC | 23:53 | |
| jlvillal | heh | 23:54 |
| jlvillal | mat128: FYI, I rebased the stable/mitaka version of your patch onto my backport of the upper-constraints patch I just did. Your patch made me realize that stable/mitaka was also broken. | 23:54 |
| *** chas has joined #openstack-ironic | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!