*** shobhar_ has joined #openstack-ironic | 00:12 | |
*** ijw has joined #openstack-ironic | 00:14 | |
*** portdirect has quit IRC | 00:16 | |
*** absubram has quit IRC | 00:18 | |
*** ijw has quit IRC | 00:19 | |
*** portdirect has joined #openstack-ironic | 00:19 | |
*** Nisha_away has joined #openstack-ironic | 00:21 | |
openstackgerrit | Richard G. Pioso proposed openstack/ironic: DRAC set_bios_config() times out waiting for reply https://review.openstack.org/395271 | 00:23 |
---|---|---|
*** Nisha_away has quit IRC | 00:25 | |
*** rpioso has quit IRC | 00:30 | |
*** moshele has quit IRC | 00:40 | |
*** chas_ has joined #openstack-ironic | 00:44 | |
*** hoangcx has joined #openstack-ironic | 00:48 | |
*** chas_ has quit IRC | 00:49 | |
*** amotoki has quit IRC | 00:49 | |
*** chlong has joined #openstack-ironic | 00:49 | |
*** ijw has joined #openstack-ironic | 00:55 | |
*** rama_y has quit IRC | 00:55 | |
*** tuanluong has joined #openstack-ironic | 00:57 | |
*** rbudden has joined #openstack-ironic | 01:08 | |
*** hoonetorg has quit IRC | 01:11 | |
*** shobhar_ has quit IRC | 01:11 | |
*** syed_ has quit IRC | 01:15 | |
*** Sukhdev has quit IRC | 01:23 | |
*** hoonetorg has joined #openstack-ironic | 01:25 | |
*** godp1301 has joined #openstack-ironic | 01:42 | |
*** amotoki has joined #openstack-ironic | 01:43 | |
*** chas_ has joined #openstack-ironic | 01:45 | |
*** zhangyufei has joined #openstack-ironic | 01:47 | |
*** amotoki has quit IRC | 01:48 | |
*** chas_ has quit IRC | 01:49 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Generic management I/F for Inject NMI https://review.openstack.org/348191 | 01:55 |
*** zhangjl has joined #openstack-ironic | 01:59 | |
*** ijw has quit IRC | 02:04 | |
*** godp1301 has quit IRC | 02:10 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic: Increase verbosity of devstack/lib/ironic https://review.openstack.org/370492 | 02:17 |
*** david-lyle has joined #openstack-ironic | 02:22 | |
*** zhangyufei has quit IRC | 02:23 | |
*** jcoufal has quit IRC | 02:23 | |
*** zhangyufei has joined #openstack-ironic | 02:23 | |
*** zhangyufei has joined #openstack-ironic | 02:24 | |
*** betherly has quit IRC | 02:25 | |
openstackgerrit | Merged openstack/ironic: Update guide section for messaging setup https://review.openstack.org/394916 | 02:26 |
*** zhangyufei has quit IRC | 02:28 | |
*** yibo has joined #openstack-ironic | 02:33 | |
*** cdearborn has quit IRC | 02:37 | |
*** chas_ has joined #openstack-ironic | 02:45 | |
*** zhangyufei has joined #openstack-ironic | 02:45 | |
*** betherly has joined #openstack-ironic | 02:46 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Update the existing APIs due to adding get_supported_power_states https://review.openstack.org/382194 | 02:47 |
*** chas_ has quit IRC | 02:50 | |
*** betherly has quit IRC | 02:55 | |
*** rloo has quit IRC | 02:56 | |
*** gcb has quit IRC | 03:22 | |
*** betherly has joined #openstack-ironic | 03:34 | |
*** kvcobb has quit IRC | 03:35 | |
zhangyufei | hi, is there any docs about how to configure neutron for ironic multitenants? | 03:36 |
*** gcb has joined #openstack-ironic | 03:38 | |
*** betherly has quit IRC | 03:40 | |
*** Nisha_away has joined #openstack-ironic | 03:40 | |
*** portdirect has quit IRC | 03:44 | |
*** godp1301 has joined #openstack-ironic | 03:45 | |
*** chas_ has joined #openstack-ironic | 03:46 | |
*** lindycoder has joined #openstack-ironic | 03:50 | |
*** chas_ has quit IRC | 03:51 | |
*** vmud213 has joined #openstack-ironic | 04:10 | |
*** Romanenko_K has joined #openstack-ironic | 04:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/bifrost: Updated from global requirements https://review.openstack.org/395305 | 04:14 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/395174 | 04:16 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/395175 | 04:16 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements https://review.openstack.org/395318 | 04:16 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/395319 | 04:16 |
*** Sukhdev has joined #openstack-ironic | 04:22 | |
*** alex_xu has quit IRC | 04:23 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironic-inspector-client: Updated from global requirements https://review.openstack.org/395363 | 04:23 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/395364 | 04:23 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-oneviewclient: Updated from global requirements https://review.openstack.org/389942 | 04:24 |
openstackgerrit | Bharath kumar proposed openstack/ironic-python-agent: Moving Reboot bashscript to python https://review.openstack.org/372478 | 04:25 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/virtualbmc: Updated from global requirements https://review.openstack.org/389959 | 04:26 |
*** fragatin_ has joined #openstack-ironic | 04:26 | |
*** hshiina has joined #openstack-ironic | 04:26 | |
*** bks has joined #openstack-ironic | 04:28 | |
*** rama_y has joined #openstack-ironic | 04:28 | |
*** alex_xu has joined #openstack-ironic | 04:29 | |
*** fragatina has quit IRC | 04:29 | |
*** fragatin_ has quit IRC | 04:31 | |
*** links has joined #openstack-ironic | 04:38 | |
*** godp1301 has quit IRC | 04:42 | |
*** wajdi_ has quit IRC | 04:44 | |
*** rbudden has quit IRC | 04:53 | |
*** pmannidi has quit IRC | 04:55 | |
*** fragatina has joined #openstack-ironic | 05:03 | |
*** fragatina has quit IRC | 05:08 | |
*** pmannidi has joined #openstack-ironic | 05:08 | |
*** rama_y has quit IRC | 05:09 | |
*** rama_y has joined #openstack-ironic | 05:10 | |
openstackgerrit | Hironori Shiina proposed openstack/ironic: Add REST API for volume connector and volume target operation https://review.openstack.org/214586 | 05:11 |
*** alex_xu has quit IRC | 05:17 | |
*** alex_xu has joined #openstack-ironic | 05:18 | |
*** gcb has quit IRC | 05:22 | |
*** david-lyle has quit IRC | 05:22 | |
*** fragatina has joined #openstack-ironic | 05:22 | |
*** gcb has joined #openstack-ironic | 05:22 | |
*** david-lyle has joined #openstack-ironic | 05:23 | |
*** fragatina has quit IRC | 05:27 | |
*** pmannidi_ has joined #openstack-ironic | 05:30 | |
*** pmannidi has quit IRC | 05:32 | |
*** kvcobb has joined #openstack-ironic | 05:32 | |
*** pmannidi_ is now known as pmannidi | 05:35 | |
*** gcb has quit IRC | 05:37 | |
*** gcb has joined #openstack-ironic | 05:38 | |
*** godp1301 has joined #openstack-ironic | 05:38 | |
*** godp1301 has quit IRC | 05:45 | |
*** chas_ has joined #openstack-ironic | 05:48 | |
*** garthb has joined #openstack-ironic | 05:48 | |
*** garthb has quit IRC | 05:48 | |
*** chas_ has quit IRC | 05:52 | |
*** gcb has quit IRC | 05:54 | |
*** rbartal has joined #openstack-ironic | 06:02 | |
*** gcb has joined #openstack-ironic | 06:06 | |
*** links has quit IRC | 06:11 | |
*** g3ek has quit IRC | 06:13 | |
*** g3ek has joined #openstack-ironic | 06:26 | |
*** moshele has joined #openstack-ironic | 06:34 | |
*** zhangyufei has quit IRC | 06:38 | |
*** links has joined #openstack-ironic | 06:39 | |
*** moshele has quit IRC | 06:45 | |
*** rama_y has quit IRC | 06:46 | |
*** betherly has joined #openstack-ironic | 06:47 | |
*** chas_ has joined #openstack-ironic | 06:48 | |
*** chas_ has quit IRC | 06:53 | |
*** rcernin has joined #openstack-ironic | 06:54 | |
*** jtomasek has quit IRC | 06:55 | |
hshiina | hi ironic | 07:07 |
*** tesseract has joined #openstack-ironic | 07:11 | |
*** tesseract is now known as Guest39033 | 07:11 | |
*** chas_ has joined #openstack-ironic | 07:19 | |
*** Sukhdev has quit IRC | 07:28 | |
*** gcb has quit IRC | 07:35 | |
*** Nisha_away has quit IRC | 07:38 | |
*** gcb has joined #openstack-ironic | 07:38 | |
*** moshele has joined #openstack-ironic | 07:46 | |
pas-ha | morning Ironic | 08:00 |
*** vsaienko has joined #openstack-ironic | 08:01 | |
openstackgerrit | Moshe Levi proposed openstack/ironic-python-agent: [WIP] Add a new Hardware Manager for Mellanox NICs https://review.openstack.org/334816 | 08:01 |
*** zhangjl1 has joined #openstack-ironic | 08:18 | |
*** vsaienko has quit IRC | 08:21 | |
*** zhangjl has quit IRC | 08:21 | |
*** zhangjl1 has quit IRC | 08:22 | |
*** vsaienko has joined #openstack-ironic | 08:22 | |
*** zhangyufei has joined #openstack-ironic | 08:22 | |
*** jaosorior has joined #openstack-ironic | 08:25 | |
tuanluong | Morning Ironic | 08:25 |
*** ralonsoh has joined #openstack-ironic | 08:26 | |
*** gcb has quit IRC | 08:33 | |
*** jpich has joined #openstack-ironic | 08:46 | |
*** gcb has joined #openstack-ironic | 08:47 | |
*** openstackgerrit has quit IRC | 08:48 | |
*** openstackgerrit has joined #openstack-ironic | 08:48 | |
*** priteau has joined #openstack-ironic | 08:54 | |
*** hshiina has quit IRC | 08:59 | |
*** jrist has quit IRC | 08:59 | |
*** vsaienko has quit IRC | 08:59 | |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-ironic | 09:00 | |
*** jrist has joined #openstack-ironic | 09:00 | |
*** Nisha_away has joined #openstack-ironic | 09:02 | |
*** kvcobb has quit IRC | 09:05 | |
openstackgerrit | Moshe Levi proposed openstack/ironic-python-agent: [WIP] Add a new Hardware Manager for Mellanox NICs https://review.openstack.org/334816 | 09:05 |
*** lucas-afk is now known as lucasagomes | 09:07 | |
lucasagomes | morning all | 09:07 |
*** dtantsur|afk is now known as dtantsur | 09:15 | |
dtantsur | Morning Ironic | 09:15 |
*** ohamada has joined #openstack-ironic | 09:19 | |
*** gcb has quit IRC | 09:20 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic-specs: Update ironic-ml2-integration spec https://review.openstack.org/393660 | 09:21 |
*** gcb has joined #openstack-ironic | 09:25 | |
*** zhangyufei has quit IRC | 09:29 | |
*** derekh has joined #openstack-ironic | 09:39 | |
*** zhangjl1 has joined #openstack-ironic | 09:51 | |
*** MattMan has quit IRC | 09:53 | |
*** MattMan has joined #openstack-ironic | 09:53 | |
*** bcornec1 has quit IRC | 09:54 | |
*** bcornec1 has joined #openstack-ironic | 09:54 | |
*** Nisha_away has quit IRC | 10:03 | |
*** zhangjl1 has quit IRC | 10:09 | |
*** tuanluong has quit IRC | 10:09 | |
*** sborkows has joined #openstack-ironic | 10:19 | |
vdrok | good morning ironic, pas-ha lucasagomes and dtantsur | 10:20 |
dtantsur | o/ | 10:20 |
lucasagomes | vdrok, hi there | 10:20 |
*** jtomasek has joined #openstack-ironic | 10:23 | |
*** milan has joined #openstack-ironic | 10:28 | |
*** gcb has quit IRC | 10:29 | |
*** gcb has joined #openstack-ironic | 10:29 | |
*** roeyc has joined #openstack-ironic | 10:31 | |
milan | morning Ironic! :) | 10:31 |
*** roeyc has quit IRC | 10:35 | |
*** dtantsur is now known as dtantsur|brb | 10:41 | |
vdrok | good morning milan | 10:43 |
milan | morning vdrok! :) | 10:43 |
milan | vdrok early today ;) | 10:43 |
vdrok | hah, not really :) | 10:44 |
karthiks | milan, regarding spec for retrieving the numa node information during introspection, what would be the right place for the spec. ironic inspector specs or ironic specs | 10:53 |
karthiks | RFE : https://bugs.launchpad.net/ironic-python-agent/+bug/1635253 | 10:54 |
openstack | Launchpad bug 1635253 in ironic-python-agent "[RFE] Retrieve NUMA node information during introspection" [Undecided,New] - Assigned to Karthik S (ksundara) | 10:54 |
milan | karthiks, the RFE is against isnpector, right? | 10:54 |
milan | aaah | 10:54 |
milan | karthiks, I feel inspector is more appropriate here; worst case scenario we'd have to move it to ironic's repo | 10:55 |
karthiks | I've moved the RFE from inspecto to IPA. | 10:55 |
karthiks | milan, Ok, I'll add the spec in inspector | 10:56 |
*** hw_wutianwei has joined #openstack-ironic | 10:57 | |
milan | karthiks, ack; the IPA and Inspector impact should coexist in a single spec w/r this feature | 10:57 |
karthiks | milan, ack | 10:58 |
*** amotoki has joined #openstack-ironic | 10:58 | |
*** hoangcx has quit IRC | 10:59 | |
*** ChubYann has quit IRC | 11:03 | |
*** vsaienko has joined #openstack-ironic | 11:06 | |
*** vsaienko has quit IRC | 11:07 | |
*** roeyc has joined #openstack-ironic | 11:07 | |
vsaienk0 | morning lucasagomes, dtantsur, sambetts, milan, mgould, vdrok and all Ironic'ers! | 11:09 |
vdrok | morning vsaienk0 :) | 11:09 |
milan | morning vsaienk0! :) | 11:09 |
*** livelace has joined #openstack-ironic | 11:11 | |
vmud213 | morning vdrok,milan,lucasagomes,dtantsur and everyone else | 11:15 |
openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/395174 | 11:16 |
milan | morning vmud213! :) | 11:16 |
*** priteau has quit IRC | 11:16 | |
openstackgerrit | Merged openstack/ironic: Update to hacking 0.12.0 and use new checks https://review.openstack.org/395102 | 11:19 |
vdrok | good morning vmud213 | 11:20 |
openstackgerrit | Merged openstack/python-ironic-inspector-client: Updated from global requirements https://review.openstack.org/395363 | 11:25 |
openstackgerrit | Merged openstack/ironic: DevStack: Support for creating UEFI VMs https://review.openstack.org/374346 | 11:28 |
*** hw_wutianwei has quit IRC | 11:28 | |
*** mgould|afk is now known as mgould | 11:29 | |
mgould | morning Ironic! | 11:29 |
mgould | morning milan vdrok dtantsur|brb lucasagomes pas-ha vsaienk0 sambetts|afk vmud213 karthiks | 11:30 |
vdrok | morning mgould | 11:30 |
pas-ha | morning mgould | 11:30 |
karthiks | morning mgould | 11:30 |
milan | morning mgould pas-ha! :) | 11:31 |
* mgould cheers quietly for the UEFI VM patch landing | 11:31 | |
*** priteau has joined #openstack-ironic | 11:32 | |
milan | \o/ patches landing :) | 11:36 |
*** dtantsur|brb is now known as dtantsur | 11:37 | |
*** portdirect has joined #openstack-ironic | 11:37 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM: Test patch to verify bond https://review.openstack.org/388660 | 11:38 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Ironic devstack portgroup support https://review.openstack.org/381743 | 11:38 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Rely on portgroup standalone_ports_supported https://review.openstack.org/360647 | 11:38 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Tempest tests for portgroups https://review.openstack.org/382476 | 11:38 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Integrate portgroups with ports to support LAG https://review.openstack.org/332177 | 11:38 |
vsaienk0 | lucasagomes, dtantsur: with kvm enabled it takes near 300 sec to boot and clean instance with ubuntu-cloud-image, bonding tests using it. With cirros and kvm disabled booting and cleaning instance took near 300 sec also. We may consider to using ubuntu-cloud-image for complicated tests like UEFI, BONDING, whatever not supported by cirros. What do you think? http://logs.openstack.org/60/388660/20/check/gate-tempest-dsvm-ironic-multitenant-netwo | 11:42 |
dtantsur | vsaienk0, what are the memory requirements? will we fit in 384 MiB (or how much do we have?)? | 11:43 |
*** amotoki has quit IRC | 11:43 | |
jroll | and can we guarantee we get hosts with nested kvm enabled? | 11:43 |
vsaienk0 | jroll need to check it with infra | 11:44 |
vsaienk0 | dtantsur: I'm using 1280Mb for ubuntu, but I think it should work with 512 I may try to decrease it. | 11:44 |
lucasagomes | vsaienk0, nice! We probably will need to decrease the size of this image a little | 11:45 |
openstackgerrit | Merged openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/395364 | 11:45 |
dtantsur | vsaienk0, even 512 is a regression for us, as I guess we'll fit less VMs.. | 11:45 |
vmud213 | Good morning mgould :) | 11:45 |
vsaienk0 | dtantsur: we don't run tests concurrently at the moment. Even if we do it in future, I hope we will do it soon, we may allocate different RAM based on VM purpose | 11:46 |
openstackgerrit | Merged openstack/ironic-lib: Updated from global requirements https://review.openstack.org/395318 | 11:47 |
dtantsur | vsaienk0, it the near future plan to run tests concurrently | 11:47 |
*** jkilpatr has quit IRC | 11:48 | |
vsaienk0 | dtantsur: I've almost finish this task :) | 11:48 |
vsaienk0 | dtantsur: hope to upload patch on this week | 11:48 |
*** jvgrant_ has joined #openstack-ironic | 11:50 | |
*** jvgrant__ has quit IRC | 11:53 | |
*** rbrud has joined #openstack-ironic | 11:56 | |
vdrok | morning jroll | 11:57 |
vdrok | yeah, ubuntu cloud image works in 512 ram | 11:57 |
*** vsaienko has joined #openstack-ironic | 11:58 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-specs: Amend dynamic iPXE configuration spec https://review.openstack.org/392290 | 11:59 |
*** moshele has quit IRC | 12:01 | |
openstackgerrit | Merged openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/395175 | 12:04 |
*** moshele has joined #openstack-ironic | 12:05 | |
*** jkilpatr has joined #openstack-ironic | 12:05 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-specs: Amend dynamic iPXE configuration spec https://review.openstack.org/392290 | 12:11 |
*** amotoki has joined #openstack-ironic | 12:13 | |
openstackgerrit | Merged openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/395319 | 12:17 |
openstackgerrit | Szymon Borkowski proposed openstack/ironic-python-agent: Add a new Hardware Manager for X710 network card https://review.openstack.org/391836 | 12:22 |
*** karthi has joined #openstack-ironic | 12:23 | |
karthi | Hi Ironic folks... | 12:24 |
*** sborkows has quit IRC | 12:26 | |
*** amotoki has quit IRC | 12:28 | |
mgould | morning jroll karthi | 12:32 |
*** zhangyufei has joined #openstack-ironic | 12:39 | |
*** betherly has quit IRC | 12:42 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: [install-guide] describe service clients auth https://review.openstack.org/382358 | 12:44 |
zhangyufei | hi, could anyone help tell me that does newton’s ironic and neutron support multi-tenant ? Is there any documents about how to configure it? | 12:45 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Simplify base interfaces in ironic.drivers.base https://review.openstack.org/393848 | 12:45 |
zhangyufei | I try to configure it with https://github.com/openstack/networking-generic-switch, but failed | 12:45 |
*** betherly has joined #openstack-ironic | 12:46 | |
*** amotoki has joined #openstack-ironic | 12:46 | |
*** lucasagomes is now known as lucas-hungry | 12:47 | |
*** d0ugal has quit IRC | 12:51 | |
*** gcb_ has joined #openstack-ironic | 12:52 | |
*** gcb has quit IRC | 12:52 | |
*** baoli has joined #openstack-ironic | 12:54 | |
*** rbudden has joined #openstack-ironic | 12:55 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Cleanup hung iscsi session https://review.openstack.org/388092 | 12:55 |
*** baoli_ has joined #openstack-ironic | 12:57 | |
*** baoli has quit IRC | 12:59 | |
*** d0ugal has joined #openstack-ironic | 12:59 | |
*** rbartal has quit IRC | 13:01 | |
jlvillal | sambetts|afk, Any chance you could run the QA meeting today? I have to go pick my wife up at the airport, so I won't be able to make it. | 13:02 |
*** rama_y has joined #openstack-ironic | 13:03 | |
*** karthi has quit IRC | 13:03 | |
*** portdirect has quit IRC | 13:04 | |
*** gcb_ has quit IRC | 13:04 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Create noop interfaces for use with hardware types https://review.openstack.org/393867 | 13:05 |
dtantsur | jroll, ^^^ and its parent, when you have some time please | 13:05 |
dtantsur | jroll, also g'morning (if this morning counts as good) | 13:06 |
*** vmud213 has quit IRC | 13:12 | |
*** rbartal has joined #openstack-ironic | 13:14 | |
*** amotoki has quit IRC | 13:17 | |
*** priteau has quit IRC | 13:19 | |
*** krtaylor has joined #openstack-ironic | 13:20 | |
*** shuquan has joined #openstack-ironic | 13:20 | |
*** priteau has joined #openstack-ironic | 13:22 | |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Update to hacking 0.12.0 and use new checks https://review.openstack.org/395588 | 13:23 |
*** zhangyufei has quit IRC | 13:24 | |
*** jistr is now known as jistr|brb | 13:26 | |
*** bks has quit IRC | 13:28 | |
*** baoli_ has quit IRC | 13:29 | |
*** jcoufal has joined #openstack-ironic | 13:32 | |
*** baoli has joined #openstack-ironic | 13:32 | |
*** priteau has quit IRC | 13:33 | |
*** jheroux has joined #openstack-ironic | 13:34 | |
jroll | morning dtantsur, vdrok, mgould | 13:35 |
jroll | dtantsur: will add it to my queue | 13:37 |
openstackgerrit | John L. Villalovos proposed openstack/ironic-inspector: Update to hacking 0.12.0 and use new checks https://review.openstack.org/395593 | 13:37 |
openstackgerrit | John L. Villalovos proposed openstack/ironic-inspector: Add py35 to tox job list https://review.openstack.org/395598 | 13:44 |
*** priteau has joined #openstack-ironic | 13:46 | |
*** jistr|brb is now known as jistr | 13:46 | |
*** nicodemos has joined #openstack-ironic | 13:47 | |
*** rbudden has quit IRC | 13:48 | |
*** xavierr has joined #openstack-ironic | 13:50 | |
*** lucas-hungry is now known as lucasagomes | 13:51 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic: Replace usage of 'repr' with '%r' in string https://review.openstack.org/395602 | 13:52 |
*** Goneri has joined #openstack-ironic | 13:57 | |
*** _mbelanger has joined #openstack-ironic | 13:58 | |
*** livelace has quit IRC | 13:58 | |
openstackgerrit | Milan Kováčik proposed openstack/python-ironic-inspector-client: UUID, started_at, finished_at in the status https://review.openstack.org/395609 | 13:59 |
milan | dtantsur, ^ if you've got some time, is tiny | 14:00 |
*** portdirect has joined #openstack-ironic | 14:00 | |
dtantsur | sure, after some coffee ;) | 14:00 |
milan | ack :) | 14:00 |
*** lennyb has quit IRC | 14:02 | |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add ironic resources CRUD notifications https://review.openstack.org/356541 | 14:02 |
*** rloo has joined #openstack-ironic | 14:03 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent: Fix several errors in LLDP handling code https://review.openstack.org/395632 | 14:04 |
dtantsur | sambetts|afk, ^^^ | 14:04 |
dtantsur | maybe jroll too if you know this code ^^^ | 14:05 |
*** hw_wutianwei has joined #openstack-ironic | 14:05 | |
* jroll 301 JoshNang | 14:05 | |
dtantsur | oh, I see | 14:05 |
* jroll adds that to his list | 14:05 | |
jroll | I somewhat know it | 14:06 |
dtantsur | cool, thanks! I was really confused by error handling there | 14:06 |
*** rama_y has quit IRC | 14:07 | |
*** hw_wutianwei has quit IRC | 14:09 | |
openstackgerrit | Ruby Loo proposed openstack/ironic: [install-guide] describe service clients auth https://review.openstack.org/382358 | 14:10 |
*** hw_wutianwei has joined #openstack-ironic | 14:11 | |
* jlvillal worries about code that makes dtantsur very confused. That is a very bad sign. | 14:13 | |
*** vsaienko has quit IRC | 14:13 | |
* jlvillal gets confused all the time, but people shouldn't worry :) | 14:13 | |
* rloo worries that jlvillal is confused about being confused | 14:13 | |
rloo | hi and good morning everyone, especially the Americans | 14:13 |
jlvillal | Morning rloo :) | 14:14 |
jroll | morning rloo, jlvillal | 14:14 |
mat128 | jlvillal: the code's readability is improved quite a bit by dtantsur's patch :D | 14:14 |
mat128 | hi rloo | 14:14 |
* jroll runs out for a haircut before diving into reviews | 14:14 | |
jlvillal | mat128, :) | 14:14 |
rloo | jroll, do we have it written down, what deprecated drivers mean? It is ok to fix it if the intent is to make it not deprecated, but otherwise... do we fix only major bugs? eg https://review.openstack.org/#/c/395602/ | 14:15 |
patchbot | patch 395602 - ironic - Replace usage of 'repr' with '%r' in string | 14:15 |
rloo | ^^ that's the ssh driver that is deprecated. do we continue making changes to it? | 14:15 |
* jlvillal hadn't noticed that it was a deprecated driver... | 14:15 | |
jroll | rloo: I would normally say don't bother, but it's a follow up comment from a previous patch, so | 14:15 |
jlvillal | Or forgot | 14:15 |
jroll | by itself, it's just noise imo | 14:16 |
rloo | was there a previous patch that touched the ssh driver? | 14:16 |
jroll | rloo: see commit message :) | 14:16 |
jlvillal | rloo, The hacking 0.12.0 update patch | 14:16 |
* jroll gotta run, bbiab | 14:16 | |
rloo | oh, the hacking thing. sigh. | 14:16 |
*** cdaniel has joined #openstack-ironic | 14:17 | |
mat128 | rloo: I'd say it's acceptable as this helps us enforce the hacking checks | 14:17 |
mat128 | rloo: in contrast to adding a feature (rfe) to the SNMP driver | 14:17 |
jlvillal | rloo, I'm happy to abandon it, since it isn't needed. I was following up on dtantsur's comment. | 14:17 |
*** jrist has quit IRC | 14:17 | |
rloo | i just looked at the hacking patch -- that was a nit to stuff that was already there so i say don't touch it | 14:17 |
jlvillal | Okay, I'll abandon it. I don't think dtantsur will object. | 14:18 |
rloo | thx jlvillal | 14:18 |
*** hw_wutianwei1 has joined #openstack-ironic | 14:18 | |
jlvillal | rloo, Abandoned | 14:18 |
*** lennyb has joined #openstack-ironic | 14:19 | |
rloo | jlvillal: not sure if that was faster than reviewing it, but wanted to be reminded of our process :) | 14:19 |
*** jrist has joined #openstack-ironic | 14:20 | |
*** hw_wutianwei has quit IRC | 14:20 | |
*** hw_wutianwei1 is now known as hw_wutianwei | 14:20 | |
mariojv | JayF: quick question. do you think all of https://review.openstack.org/#/c/389344/ should move to the install guide? | 14:21 |
patchbot | patch 389344 - ironic - Add notification documentation to administrator's ... | 14:21 |
jlvillal | rloo, I think you were correct. Thanks. | 14:21 |
mariojv | i think the details of individual notifications are best left where they're being put in that patch, and then we have a brief overview in the install guide with a link to there | 14:21 |
mariojv | also, good morning all | 14:22 |
vdrok | morning jlvillal rloo mat128 and mariojv ! | 14:27 |
xavierr | good-morning --all | 14:27 |
rloo | morning mariojv, vdrok, xavierr! | 14:27 |
jlvillal | Good morning vdrok mariojv xavierr mat128 lucasagomes dtantsur rloo and everyone else :) | 14:28 |
lucasagomes | jlvillal, hi there | 14:28 |
vdrok | and morning xavierr | 14:28 |
xavierr | rloo jlvillal lucasagomes vdrok o/ | 14:28 |
lucasagomes | o/ hi there | 14:29 |
*** dprince has joined #openstack-ironic | 14:29 | |
*** jvgrant__ has joined #openstack-ironic | 14:31 | |
*** jaosorior has quit IRC | 14:33 | |
*** cdearborn has joined #openstack-ironic | 14:33 | |
*** jaosorior has joined #openstack-ironic | 14:34 | |
*** jvgrant_ has quit IRC | 14:34 | |
*** nicodemos has quit IRC | 14:34 | |
*** lindycoder has joined #openstack-ironic | 14:35 | |
dtantsur | morning jlvillal, rloo, xavierr, mat128 and everyone else | 14:36 |
jlvillal | lucasagomes, dtantsur rloo jroll: FYI: I did the 'check experimental' to make sure the pep8 tests will pass when they make the change. | 14:36 |
jlvillal | I made a note of what I tested in the WhiteBoard. Line 104 | 14:36 |
*** Nisha_away has joined #openstack-ironic | 14:36 | |
jlvillal | vdrok, yuriyz ^^ | 14:36 |
*** cdaniel has quit IRC | 14:37 | |
jlvillal | Mailing list thread: http://lists.openstack.org/pipermail/openstack-dev/2016-November/106668.html | 14:37 |
rloo | jlvillal: thx. i saw and ignored that email, glad you didn't :) | 14:38 |
*** xavierr has quit IRC | 14:38 | |
jlvillal | :) | 14:38 |
openstackgerrit | Milan Kováčik proposed openstack/python-ironic-inspector-client: UUID, started_at, finished_at in the status https://review.openstack.org/395609 | 14:38 |
*** _mbelanger has quit IRC | 14:38 | |
*** causten has joined #openstack-ironic | 14:38 | |
mariojv | is there anything that could possibly in driver_info that we wouldn't want to send over the message bus for notifications, that wouldn't be masked by oslo utils mask_dict_password? | 14:39 |
rloo | jlvillal: so, wrt the whiteboard... i added 'status' to the subteams, to try to capture the latest status (as of the weekly meeting). cuz sometimes there is 'no update' and i don't know/remember what the 'latest' status is. maybe i should rename it to something other than 'status'? | 14:39 |
*** godp1301 has joined #openstack-ironic | 14:40 | |
openstackgerrit | Merged openstack/ironic: [install-guide] describe service clients auth https://review.openstack.org/382358 | 14:40 |
*** godp1301 has quit IRC | 14:40 | |
*** baoli has quit IRC | 14:40 | |
*** baoli has joined #openstack-ironic | 14:41 | |
*** godp1301 has joined #openstack-ironic | 14:41 | |
rloo | jlvillal: so you think the status should be below the 'current' stuff? | 14:41 |
jlvillal | rloo, Okay. So I moved my pep8 comments up above. Hopefully that is correct. | 14:41 |
jlvillal | I don't know.... | 14:41 |
*** snozhka has quit IRC | 14:41 | |
rloo | jlvillal: i want to make it easy for folks to update wrt their weekly stuff. thought they'd add to the end. (Others eg have a trello link.) | 14:41 |
jlvillal | Toe-may-toe, to-mah-toe | 14:41 |
jlvillal | For me. | 14:42 |
rloo | jlvillal: that looks better, thx. i'm going to change 'status' to something more verbose i think... i'm just experimenting with you all... | 14:42 |
jlvillal | rloo, moved lower | 14:42 |
jlvillal | Thanks | 14:42 |
milan | morning all I've missed since my last patch proposal ;) jlvillal, jroll, lucasagomes, mat128, mariojv, rloo, xavierr | 14:43 |
rloo | hi milan! | 14:43 |
milan | hi rloo :) | 14:44 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: [install-guide] describe service clients auth https://review.openstack.org/395648 | 14:44 |
*** roeyc has quit IRC | 14:46 | |
*** links has quit IRC | 14:49 | |
*** baoli has quit IRC | 14:51 | |
*** baoli has joined #openstack-ironic | 14:53 | |
*** roeyc has joined #openstack-ironic | 14:53 | |
*** snozhka has joined #openstack-ironic | 14:54 | |
*** yufei__ has joined #openstack-ironic | 14:56 | |
*** vsaienko has joined #openstack-ironic | 15:00 | |
*** moshele has quit IRC | 15:01 | |
jroll | jlvillal: nice, thanks! | 15:02 |
*** moshele has joined #openstack-ironic | 15:02 | |
jroll | morning milan :) | 15:02 |
*** vsaienko has quit IRC | 15:02 | |
milan | jroll o/ :) | 15:03 |
*** Nisha_away has quit IRC | 15:08 | |
*** yufei__ has quit IRC | 15:11 | |
*** godp1301 has quit IRC | 15:13 | |
JayF | mariojv: no. I think that should go in a sort of admin guide. For now where you have it is fine. | 15:15 |
vdrok | dtantsur: lucasagomes there are a couple of patches in staging drivers that i think are good to go, and maybe we can do a release sometime soonish? | 15:17 |
vdrok | morning JayF | 15:17 |
JayF | o/ | 15:17 |
lucasagomes | vdrok, ++ | 15:18 |
lucasagomes | tho I iwll take a look at it later on | 15:18 |
vdrok | thanks lucasagomes | 15:18 |
jroll | I'm going to land the ocata priorities doc, any objections? https://review.openstack.org/#/c/393753/ | 15:19 |
patchbot | patch 393753 - ironic-specs - Add Ocata priorities | 15:19 |
jroll | devananda|away and yuriyz are the only cores without a +2 there | 15:19 |
*** dtantsur is now known as dtantsur|brb | 15:19 | |
yuriyz | hi jroll will look | 15:20 |
lucasagomes | vdrok, thank you for keeping an eye at it | 15:20 |
*** zackf has quit IRC | 15:20 | |
vdrok | np :) | 15:20 |
*** Nisha_away has joined #openstack-ironic | 15:20 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update iptables rules and services IPs for multinode https://review.openstack.org/368648 | 15:23 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add devstack setup_vxlan_network() https://review.openstack.org/368647 | 15:23 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Skip some steps for multinode case https://review.openstack.org/368646 | 15:23 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update ironic node names for multinode case https://review.openstack.org/368645 | 15:23 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update devstack provision net config for multihost https://review.openstack.org/368644 | 15:23 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Testing multinode stuff https://review.openstack.org/368173 | 15:23 |
mariojv | JayF: ok, thanks for the advice. i'll propose a small note in the install guide for now, if that sounds good | 15:23 |
*** godp1301 has joined #openstack-ironic | 15:24 | |
mariojv | otherwise we can just leave it out - i'm not sure how much config-related stuff goes in the install guide, have not read a lot of it | 15:24 |
*** syed__ has joined #openstack-ironic | 15:24 | |
*** yufei__ has joined #openstack-ironic | 15:25 | |
*** zackf has joined #openstack-ironic | 15:27 | |
*** baoli has quit IRC | 15:28 | |
Nisha_away | jroll, other ironic members, i have a query. I wanted to understand when does a RFE require a spec. | 15:29 |
*** nicodemos has joined #openstack-ironic | 15:29 | |
*** jschwarz has joined #openstack-ironic | 15:29 | |
jschwarz | hey guys | 15:29 |
Nisha_away | I have heard that RFE can be approved without the spec also | 15:29 |
vdrok | Nisha_away: I think it's decided on case by case basis | 15:30 |
jschwarz | I heard you guys were building some kind of a CirrOS image at the gate as part of ironic-python-agent... where can I find the code that does the creation? | 15:30 |
vdrok | Nisha_away: just file an rfe, if it needs a spec, you eill be told about that in the bug | 15:30 |
Nisha_away | vdrok, ok. i wanted to understand it for the existing RFE | 15:30 |
jroll | Nisha_away: yes, what vdrok said. anything that is a bit complex, changes API/RPC, affects upgrades, etc usually needs a spec | 15:31 |
jroll | Nisha_away: then ask about that RFE :) | 15:31 |
Nisha_away | vdrok, for instance https://bugs.launchpad.net/ironic/+bug/1526382 | 15:31 |
openstack | Launchpad bug 1526382 in Ironic "[RFE] Enhance ilo drivers to do inband inspection along with OOB inspection" [Wishlist,In progress] - Assigned to Aparna (aparnavtce) | 15:31 |
jroll | jschwarz: hey there | 15:31 |
jschwarz | jroll, hey :) | 15:31 |
Nisha_away | this actually requires https://review.openstack.org/305864 to be merged | 15:31 |
patchbot | patch 305864 - ironic-specs - Boot management for in-band inspection | 15:32 |
jroll | jschwarz: we don't build cirros, but ironic-python-agent is designed to run in a ramdisk, so we have a couple image builders in tree: https://github.com/openstack/ironic-python-agent/tree/master/imagebuild | 15:32 |
*** _mbelanger has joined #openstack-ironic | 15:32 | |
jroll | jschwarz: we also have a diskimage-builder element for it | 15:32 |
jschwarz | jroll, awesome, thanks a lot :) | 15:32 |
*** vsaienko has joined #openstack-ironic | 15:32 | |
Nisha_away | and then when inspector start supporting virtual media as boot device, then ilo drivers just use that | 15:32 |
Nisha_away | to start supporting inband inspection | 15:33 |
Nisha_away | vdrok ^^^ | 15:33 |
rloo | everyone, esp cores jroll, JayF, sambetts|afk, jlvillal (cuz you looked at this), this has two +2, I'm going to +A later today if no one has objections: https://review.openstack.org/#/c/332177/ | 15:33 |
patchbot | patch 332177 - ironic - Integrate portgroups with ports to support LAG | 15:33 |
*** absubram has joined #openstack-ironic | 15:33 | |
JayF | woo hoo | 15:33 |
JayF | I'll review it this morning too :D | 15:34 |
jroll | rloo: yay! I was planning on reviewing it today, but go on without me if you like :) | 15:34 |
rloo | thx JayF! | 15:34 |
*** absubram_ has joined #openstack-ironic | 15:34 | |
*** shuquan has quit IRC | 15:35 | |
Nisha_away | jroll ^^^ | 15:35 |
vdrok | Nisha_away: soo, the rfe bug you linked has needs-spec tag, which is pretty self-describing :) | 15:35 |
jroll | Nisha_away: to be approved without a spec, the RFE would need more details on the changes... since you already have the spec written I think we should just review that | 15:35 |
vdrok | yep, it needs the spec | 15:35 |
jroll | vdrok: I added that because it had a spec, to be honest | 15:35 |
vdrok | ah | 15:35 |
jroll | or had a spec in review | 15:35 |
jlvillal | Thanks rloo | 15:35 |
*** godp1301 has quit IRC | 15:36 | |
Nisha_away | jroll, vdrok yes it already had a spec in review, but since spec review takes longer time i was thinking if really we need a spec for this RFE | 15:37 |
jroll | Nisha_away: then please add details in the RFE and we can evaluate it | 15:37 |
rloo | jroll: wrt nova blueprints, we have one for portgroups and one for attach/detach. For attach/detach, we have to get ironic's spec approved -- before nova's feature freeze? | 15:37 |
Nisha_away | jroll sure | 15:37 |
rloo | for portgroups -- ?? | 15:37 |
Nisha_away | jroll thanks... | 15:37 |
jroll | rloo: my goal for attach/detach is before their spec freeze (the 17th) | 15:37 |
jroll | rloo: they asked for a spec for portgroups which either sambetts|afk or vdrok was working on | 15:38 |
*** absubram has quit IRC | 15:38 | |
*** absubram_ is now known as absubram | 15:38 | |
rloo | jroll: the nova portgroups spec exists: https://review.openstack.org/#/c/387534/ | 15:38 |
patchbot | patch 387534 - nova-specs - Proposal for ironic static portgroups support | 15:38 |
vdrok | rloo: yup, that one | 15:38 |
jroll | rloo: ok, right, their spec freeze is nov 17 | 15:38 |
rloo | jroll: do we need more ironic cores to look/+1 that before nova will look at it? | 15:38 |
Nisha_away | jroll, vdrok i have same ques on https://bugs.launchpad.net/ironic/+bug/1609622 | 15:39 |
openstack | Launchpad bug 1609622 in Ironic "[RFE] Enhance iLO drivers to use snmp to do OOB inspection for local_gb" [Wishlist,In progress] - Assigned to Nisha Agarwal (agarwalnisha1980) | 15:39 |
jroll | rloo: can't hurt, but we'll need to ask them | 15:39 |
rloo | jroll: ok, thanks for volunteering to ask them :) (or did i hear wrong?) | 15:39 |
jroll | Nisha_away: needs more details on the changes required | 15:39 |
jroll | rloo: yeah, I'll review it and bug matt today | 15:39 |
Nisha_away | ok | 15:39 |
rloo | jroll: thx! :) | 15:39 |
Nisha_away | jroll, thx :) | 15:40 |
Nisha_away | i will add more details to the RFE now | 15:40 |
*** vsaienko has quit IRC | 15:40 | |
*** yufei__ has quit IRC | 15:42 | |
*** zackf has quit IRC | 15:42 | |
jlvillal | vdrok, Can you peek at: https://review.openstack.org/#/c/332177/35/ironic/api/controllers/v1/node.py L1092 ? | 15:45 |
patchbot | patch 332177 - ironic - Integrate portgroups with ports to support LAG | 15:45 |
vdrok | jlvillal: looking | 15:45 |
*** rpioso has joined #openstack-ironic | 15:45 | |
jlvillal | thanks | 15:45 |
vdrok | jlvillal: um, I'm not sure i get the question | 15:47 |
*** jkilpatr_ has joined #openstack-ironic | 15:47 | |
vdrok | we return not found in both cases | 15:47 |
jlvillal | vdrok, Well what does 'kilroy-was-here' return? | 15:47 |
jlvillal | vdrok, Then why do we explicity raise not found there? | 15:47 |
vdrok | 404, as there is no such node | 15:47 |
jlvillal | vdrok, More of a question. Not saying wrong. | 15:48 |
vdrok | in case of portgroups, we have to distinguish a case of portgroups controller if it is accessed with a lower api version | 15:48 |
vdrok | jlvillal: sure, I get that :) | 15:48 |
jroll | jlvillal: https://pecan.readthedocs.io/en/latest/routing.html#routing-to-subcontrollers-with-lookup | 15:48 |
jlvillal | vdrok, Right, but could it just fall through and not return subcontroller. | 15:48 |
jlvillal | Instead of raise. | 15:49 |
jroll | ah, I get the question now | 15:49 |
jlvillal | In reality it doesn't matter if they both return NOT_FOUND. | 15:49 |
*** jkilpatr has quit IRC | 15:49 | |
*** rajinir has joined #openstack-ironic | 15:49 | |
jlvillal | vdrok, It wasn't clear to me that falling through returned NOT_FOUND since the code was explicityly doing it for portgroups | 15:50 |
jlvillal | vdrok, Thanks! | 15:50 |
vdrok | jlvillal: I think we have to explicitly tell what to do there | 15:50 |
jlvillal | vdrok, Then how come we don't for 'killroy-was-here'? | 15:51 |
jlvillal | Is that a bug in the prior code? | 15:51 |
vdrok | ahh wait | 15:51 |
*** zackf has joined #openstack-ironic | 15:51 | |
vdrok | jlvillal: I misread the endpoint you were refering to | 15:51 |
* mgould drops back in | 15:52 | |
mgould | wait, what, kilroy? The WW2 graffiti artist? | 15:52 |
jlvillal | vdrok, I notice in that pecan link you posted they either return the subcontroller or abort | 15:52 |
jlvillal | mgould, Yep :) | 15:52 |
jroll | jlvillal: so falling through doesn't always return NotFound (it does in that case) | 15:52 |
jroll | https://github.com/pecan/pecan/blob/6ccba2564d0ee0a4322b80d6057e2bd3f13eae05/pecan/routing.py#L142 | 15:52 |
vdrok | jlvillal: we're getting the subcontroller from the dict | 15:53 |
vdrok | in case of kilroy, we don't have one | 15:53 |
rloo | jlvillal: i think maybe? what you're asking is why not change the code at line 1089 to only call subcontroller(), instead of explicitly calling pecan.abort()? | 15:53 |
jroll | if there's a routing exception, _lookup() is called, if that returns None it raises the original exception | 15:53 |
TheJulia | o/ | 15:53 |
*** Sukhdev has joined #openstack-ironic | 15:54 | |
jlvillal | rloo, Yeah. | 15:54 |
jlvillal | vdrok, rloo, jroll: Okay, code works. So I think we are good :) | 15:54 |
vdrok | jlvillal: we'll raise 500 if we'll do None() | 15:54 |
jlvillal | vdrok, So 'killroy-wa-here' gets 500, but 'portgroups' with lower API gets NOT_FOUND? | 15:54 |
jlvillal | vdrok, If that is how it should be, works for me. Thanks. | 15:55 |
openstackgerrit | Vadim Hmyrov proposed openstack/python-ironicclient: List required arguments in '--help' message in Ironic Client. https://review.openstack.org/382999 | 15:55 |
vdrok | jlvillal: no, ignore that, there is an if :) I'll just double check now with unittest | 15:56 |
jlvillal | vdrok, :) | 15:56 |
openstackgerrit | Moshe Levi proposed openstack/ironic-python-agent: [WIP] Add a new Hardware Manager for Mellanox NICs https://review.openstack.org/334816 | 15:57 |
*** dtantsur|brb is now known as dtantsur | 15:57 | |
* jlvillal goes back to interspersing work with preparing house for his wife's return | 15:57 | |
*** jerrygb has joined #openstack-ironic | 15:57 | |
*** roeyc has quit IRC | 15:59 | |
*** jkilpatr_ has quit IRC | 16:01 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-specs: Promote iPXE to separate boot interface https://review.openstack.org/385572 | 16:01 |
*** roeyc has joined #openstack-ironic | 16:02 | |
*** e0ne has joined #openstack-ironic | 16:05 | |
*** moshele has quit IRC | 16:08 | |
*** rcernin has quit IRC | 16:13 | |
*** jkilpatr_ has joined #openstack-ironic | 16:14 | |
vdrok | jlvillal: replied in the review | 16:14 |
jlvillal | vdrok, Thanks. Do you think should make a change? Or is it good? | 16:16 |
*** absubram has quit IRC | 16:17 | |
jlvillal | vdrok, Just thinking should it be the same error as would get now without patch. /v1/nodes/<node>/portgroups and /v1/nodes/<node>/killroy-was-here should return same code now and after patch if using old API. | 16:18 |
jlvillal | Unsure how critical that is. | 16:18 |
vdrok | jlvillal: I'm inclined to think that whatever we write after node_ident/... should be treated as a subcontroller. and if there is no subcontroller, better to return 404 instead of 400 | 16:19 |
jroll | sambetts|afk: reviewed attach/detach spec, I think we're close | 16:21 |
jlvillal | vdrok, makes sense to me. | 16:21 |
jroll | rloo: ^ wdyt about POST /v1/nodes/ident/vifs/ and DELETE /v1/nodes/ident/vifs/interface_id ? | 16:21 |
rloo | jroll: yeah, that seems good. i'll look at your comments in a sec. | 16:22 |
jroll | thanks, no rush | 16:22 |
jroll | seems like sam isn't here today | 16:22 |
rloo | jroll: oh. hopefully he is here tomorrow. if that spec isn't approved by monday, i think we shoudl have some 30 min or 1 hour meeting to get it done. | 16:23 |
jlvillal | krtaylor, can you run the QA meeting today? I have to fetch my wife from the airport today. | 16:23 |
jroll | rloo: yeah, I'm also happy to take it over if needed | 16:23 |
rloo | jroll: ok. sambetts|afk didn't say anything about being away for a long time, so for now, I think we're good :) if you take over, you won't be able to +2. | 16:24 |
jroll | rloo: indeed | 16:24 |
vdrok | jlvillal: that's complete fun :D | 16:24 |
vsaienk0 | http://paste.openstack.org/show/588587/ | 16:25 |
*** Guest39033 has quit IRC | 16:25 | |
* dtantsur is not feeling well, see you tomorrow | 16:25 | |
vsaienk0 | API returns field value when accessing to http://127.0.0.1:6385/v1/nodes/node-0/driver_info | 16:25 |
vdrok | night dtantsur | 16:25 |
jroll | gnight dtantsur, feel better | 16:25 |
*** dtantsur is now known as dtantsur|afk | 16:25 | |
rloo | bye dtantsur|afk, hope you're feeling better tomorrow! | 16:26 |
vdrok | rloo: jroll: how do you think we should handle that stuff jlvillal commented about? | 16:26 |
vdrok | if taking into account what vsaienk0 wrote above | 16:26 |
vdrok | personally, I did not know about this possibility | 16:26 |
jroll | vdrok: oh, interesting | 16:26 |
jroll | how... how does that work | 16:27 |
* jroll hates pecan/wsme | 16:27 | |
rloo | that is cool! | 16:27 |
vdrok | /o\ | 16:27 |
mgould | dtantsur|afk: o/ | 16:27 |
jlvillal | get better dtantsur|afk ! | 16:27 |
jroll | idk what to think about that | 16:28 |
jlvillal | lucasagomes, ^^^ Mr WSME :) | 16:28 |
* lucasagomes runs | 16:28 | |
jroll | yes, run | 16:28 |
rloo | so, there's WSME, and there's REST API -> what's right. | 16:28 |
jroll | vdrok: so what's the question, then? | 16:28 |
vdrok | jroll: the question is, if we don't find a subcontroller, like in case of /nodes/node-0/fffuuuuuu, should we do 400 or 404? | 16:29 |
jroll | vdrok: 404, of course :) | 16:30 |
jroll | why would we do 400? | 16:30 |
vdrok | right now, we consider fffuuuuuu a field, not a subcontroller | 16:30 |
jroll | it's a resource that was not found | 16:30 |
lucasagomes | vdrok, is fuuuuuuu suppose to be a name for the node ? | 16:30 |
lucasagomes | oh | 16:30 |
jroll | lucasagomes: node-0 is the name | 16:30 |
jlvillal | lucasagomes, No, a value | 16:30 |
lucasagomes | ignore me | 16:30 |
vdrok | jroll: and because of that, right now /nodes/node-0/fffuuuuuu returns 400 | 16:30 |
lucasagomes | yeah | 16:30 |
jroll | vdrok: oh lord | 16:30 |
lucasagomes | 404 seems correct then | 16:30 |
jlvillal | jroll, currently it is returning 400 | 16:30 |
jlvillal | I think that is why the question. | 16:31 |
jroll | http://www.osnews.com/images/comics/wtfm.jpg | 16:31 |
vsaienk0 | access to /nodes/node-0/fffuuuuuu/booo returns 404 | 16:31 |
* jlvillal repeats what vdrok already said :( | 16:31 | |
jroll | jlvillal: yep, got it | 16:31 |
jroll | heh | 16:31 |
* jlvillal likes the comic | 16:31 | |
vdrok | I'm overdosed with our api today after reviewing this one :D https://review.openstack.org/#/c/390558/7/ironic/api/controllers/v1/node.py | 16:32 |
patchbot | patch 390558 - ironic - Add possibility to remove chassis_uuid from a node | 16:32 |
* jroll https://media.giphy.com/media/p8Uw3hzdAE2dO/giphy.gif | 16:32 | |
vsaienk0 | it is a fun, I think we should always return 404 | 16:32 |
*** vmud213 has joined #openstack-ironic | 16:32 | |
jlvillal | That looks like the guy from Scrubs. | 16:32 |
jroll | yeah, we should. the question to me is, should we make that change now, given it's been a 400 for a few years now | 16:32 |
*** e0ne has quit IRC | 16:32 | |
vsaienk0 | when accessing to non existed endpoint we get 404, ie v1/fuuuu | 16:33 |
jroll | right | 16:33 |
*** godp1301 has joined #openstack-ironic | 16:33 | |
vsaienk0 | jroll, not sure it makes a big sense to keep 400 for not when accessing to /nodes/node-0/fffuuuuuu/booo returns 404 | 16:34 |
patchbot | https://review.openstack.org/#/c/400/ | 16:34 |
jroll | vsaienk0: yeah, agree | 16:34 |
jroll | but will this break people? (probably not, but need to consider it) | 16:34 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-python-agent: Remove old lookup/heartbeat from IPA https://review.openstack.org/386052 | 16:35 |
rloo | well, user is broken anyway if you know what i mean. | 16:35 |
jroll | for example I believe nova would microversion this fix | 16:35 |
jroll | which is... sad | 16:35 |
vdrok | so what I think is - changing 400 to 404 (or vice versa) does not require a microversion, so we can find all the bugs there, think what to do about them, and fix all together | 16:35 |
vdrok | jroll: ^^ | 16:35 |
jroll | vdrok: that's my thought as well | 16:35 |
JayF | jroll: vdrok: I really disagree with that assessment | 16:35 |
rloo | vdrok: yup, file a bug about it with that. then for this particular patch, do the right thing :) | 16:35 |
JayF | changing the return code, even if it's in the 4xx series, can break applications for people | 16:36 |
jlvillal | vdrok, I did -1 the patch as I think it should return the same before the patch for 'portgroups' and after the patch (with an older API) for 'portgroups' | 16:36 |
JayF | and so not hiding that kind of change behind a microversion seems like a bad idea | 16:36 |
Nisha_away | jroll, vdrok i updated the RFEs https://bugs.launchpad.net/ironic/+bug/1609622 and https://bugs.launchpad.net/ironic/+bug/1526382 | 16:36 |
openstack | Launchpad bug 1609622 in Ironic "[RFE] Enhance iLO drivers to use snmp to do OOB inspection for local_gb" [Wishlist,In progress] - Assigned to Nisha Agarwal (agarwalnisha1980) | 16:36 |
openstack | Launchpad bug 1526382 in Ironic "[RFE] Enhance ilo drivers to do inband inspection along with OOB inspection" [Wishlist,In progress] - Assigned to Aparna (aparnavtce) | 16:36 |
jroll | JayF: which is why I think we should consider it further | 16:36 |
jroll | Nisha_away: ok | 16:36 |
vdrok | JayF: hmm, if it is a bug, I think sdague was telling that it can be done without microversion, if we do 400 -> 404 | 16:37 |
jlvillal | vdrok, I think currently before patch it returns 400, and after the patch (with older API) it returns 404. | 16:37 |
jroll | vdrok: I believe nova's rule is 500->x is ok, not-500->x needs microversino | 16:37 |
rloo | i think we agree that it should be 404, right? we just don't know/agree yet on how to fix it? | 16:37 |
jlvillal | +1 | 16:37 |
jroll | rloo: agree | 16:37 |
rloo | so i think we should open a bug about it. | 16:37 |
jroll | agree. | 16:37 |
JayF | vdrok: I don't care what's permitted, or what the policies say can be done. I'm saying that as an operator, it's completely unexpected to have return codes change without a version swap | 16:37 |
rloo | and for this particular case, we know it should be 404 | 16:37 |
vdrok | JayF: ok, thats fair | 16:38 |
JayF | vdrok: the the 5xx->4xx case, that doesn't really count, as 5xx says "server error". 4xx is a type of client error, and one that an api client should handle | 16:38 |
rloo | JayF, vdrok: so that discussion could/should take place in the bug/rfe so it can be captured/recorded for ever. | 16:39 |
*** strigazi is now known as strigazi_AFK | 16:39 | |
JayF | Where is that bug? I couldn't find it in scrollback | 16:41 |
vdrok | ok, so I'm not sure what the decision is, change to 400 now, and fix later? | 16:41 |
jroll | I don't believe there is a bug yet | 16:41 |
jlvillal | vdrok, That would be my vote. | 16:41 |
vdrok | JayF: https://review.openstack.org/#/c/332177/35/ironic/api/controllers/v1/node.py@1092 | 16:42 |
patchbot | patch 332177 - ironic - Integrate portgroups with ports to support LAG | 16:42 |
*** fragatina has joined #openstack-ironic | 16:42 | |
mjturek | jlvillal: just confirmed with krtaylor that he can run today's QA meeting | 16:42 |
krtaylor | jlvillal, sure, np | 16:42 |
krtaylor | oh, yeah, what mjturek said :) | 16:43 |
mjturek | :) | 16:43 |
vsaienk0 | if we decide to return 400 on /nodes/node-1/portgroups than we should keep 404 for /nodes/node-1/portgroups/blah | 16:43 |
patchbot | https://review.openstack.org/#/c/404/ - openstack-attic/identity-api - Initial commit to create repository for Identity S... (MERGED) | 16:43 |
rloo | vdrok, jlvillal: no, I don't think we should change the code to 400. we've just decided it should be 404. so i'd go with what's right, vs consistency in this case. | 16:44 |
*** priteau has quit IRC | 16:44 | |
rloo | vdrok or anyone going to open a bug about the 400 -> 404? | 16:44 |
*** xavierr has joined #openstack-ironic | 16:45 | |
jlvillal | krtaylor, mjturek: Thanks :) | 16:45 |
vdrok | rloo: the problem is, I'm not sure it's a bug. If the things following node_uuid are considered node fields, not subcontrollers | 16:45 |
jroll | vdrok: at least some of us (me) believe that's a bug :) | 16:46 |
rloo | vdrok: sigh. i thought you all had established it was a bug. | 16:46 |
vdrok | jroll: rloo ok, will do it then | 16:46 |
jroll | vdrok: thank you :) | 16:46 |
*** priteau has joined #openstack-ironic | 16:46 | |
jlvillal | rloo, vdrok jroll JayF: I'll let you decide if go with consistency vs return the correct thing. Since they conflict. | 16:47 |
jlvillal | Regarding current patch set. | 16:47 |
jroll | jlvillal: I agree we should do the right thing | 16:47 |
vdrok | jlvillal: right now, we bump the microversion anyway, so i think we're safe anyway | 16:47 |
JayF | I don't have strong opinions or knowledge on what is "right" or "wrong" in API design; I just don't want some large amount of return codes to change without a version notifying it :D | 16:47 |
vdrok | not in terms of consistency tho :) | 16:48 |
rloo | JayF: i hear you and yes, we can do that. | 16:48 |
rloo | I'm looking forward to version 1.100 ! | 16:49 |
JayF | lol | 16:49 |
vdrok | jroll: rloo JayF in your opinion, we should still consider e.g. /nodes/node-0/driver_info a field, or start treating them all as subcontrollers? or just change the return code to 404? | 16:50 |
jroll | vdrok: subcontrollers | 16:50 |
jroll | and 404 | 16:50 |
vdrok | yep, that's what makes the most sense to me | 16:50 |
rloo | vdrok: so from the user's perspective, they aren't thinking 'subcontroller'. What makes sense to them? | 16:51 |
vdrok | rloo: in case of our api, I'd actually expect them to think subcontroller. we already do /nodes/node-0/ports | 16:52 |
* jroll has never seen an API where a part of the URL referred to a field on an object | 16:52 | |
* jroll agrees with vdrok | 16:52 | |
*** bnemec has quit IRC | 16:52 | |
rloo | vdrok, jroll: i don't have much of an opinion here, am good with what you both say :) | 16:52 |
*** bnemec has joined #openstack-ironic | 16:55 | |
*** vmud213 has quit IRC | 16:58 | |
jroll | landed the priorities doc | 17:01 |
jroll | rloo: do you want to update the subteams list or shall I? | 17:01 |
rloo | jroll: i can do it. are you going to use trello? | 17:01 |
jroll | rloo: yeah, I updated trello last week | 17:01 |
jroll | open to something else, but for now | 17:02 |
rloo | jroll: ok, just wanted to make sure the trello links existed before updating the subteams. will do it today. | 17:02 |
jroll | thanks! | 17:02 |
*** rbartal has quit IRC | 17:03 | |
krtaylor | reminder: ironic_qa meeting now in #openstack-meeting | 17:03 |
openstackgerrit | Merged openstack/ironic-specs: Add Ocata priorities https://review.openstack.org/393753 | 17:04 |
vdrok | jroll: https://bugs.launchpad.net/ironic/+bug/1640546, made it an rfe | 17:05 |
openstack | Launchpad bug 1640546 in Ironic "Sub-endpoints of ironic resources should be considered subcontrollers, not fields of the resource" [Wishlist,New] - Assigned to Vladyslav Drok (vdrok) | 17:05 |
jroll | vdrok: thanks | 17:05 |
jroll | JayF: ^ there's the bug you were looking for | 17:05 |
*** rbrud has quit IRC | 17:07 | |
*** chlong has quit IRC | 17:08 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic-lib: WIP/DNM: Initial skeleton support for mypy static type checking https://review.openstack.org/386892 | 17:08 |
*** roeyc has quit IRC | 17:09 | |
Nisha_away | jroll, regarding new out-of-band properties which we want to introduce/add via https://bugs.launchpad.net/ironic/+bug/1599425 ....coming back to same ques again on it...why do ilo drivers team need to do investigation for inband discovery of these new attribute | 17:09 |
openstack | Launchpad bug 1599425 in Ironic "[RFE]: Add few more capabilities to ilo drivers oob inspection" [Wishlist,Confirmed] | 17:09 |
*** ricardoas has joined #openstack-ironic | 17:10 | |
vdrok | rloo: https://review.openstack.org/#/c/390558/7 is rebased on top of the portgroups subcontrollers patch, no need to -2 it :) | 17:10 |
patchbot | patch 390558 - ironic - Add possibility to remove chassis_uuid from a node | 17:10 |
jroll | Nisha_away: we don't require the ilo team does that investigation, but we want to standardize these across drivers, so *someone* needs to do that investigation, right? | 17:10 |
*** zackf has quit IRC | 17:11 | |
Nisha_away | jroll, correct | 17:11 |
jroll | Nisha_away: so who do you suggest does that work? | 17:11 |
Nisha_away | jroll, :) i am not the one who can answer that | 17:11 |
jroll | Nisha_away: should it be the people who want to make progress on this feature, or should it be the people already full of work making progress on the rest of the project? | 17:11 |
jroll | Nisha_away: now you see my dillema :) | 17:12 |
Nisha_away | i can help to investigate but frankly speaking even i dont know how to discover them inband | 17:12 |
jroll | Nisha_away: we need that work to be done, I don't care who does it | 17:12 |
jroll | neither do I | 17:12 |
rloo | vdrok: ? it shows that it conflicts with 'Integrate portgroups with ports...' | 17:13 |
jroll | but there's a whole internet full of resources about how to do things like this | 17:13 |
Nisha_away | jroll, but the spec doesnt require to say that they will be implemented inband or oob? | 17:13 |
mariojv | jlvillal: wrt to https://review.openstack.org/#/c/395588 and the related patch sets - why is assertIs(Not)None bad again? i remember having a discussion about this with someone, but i don't remember the fine points | 17:13 |
patchbot | patch 395588 - python-ironicclient - Update to hacking 0.12.0 and use new checks | 17:13 |
vdrok | rloo: no idea why. if you look in related changes, you'll see portgroups patch in the bottom | 17:13 |
Nisha_away | jroll, do we need to say that | 17:13 |
Nisha_away | we can standardize the properties names | 17:13 |
jroll | Nisha_away: well, dtantsur|afk asked for this, not me, so I'm not sure what exactly he wanted | 17:14 |
*** roeyc has joined #openstack-ironic | 17:14 | |
*** causten has quit IRC | 17:14 | |
*** roeyc has quit IRC | 17:15 | |
*** causten has joined #openstack-ironic | 17:15 | |
rloo | vdrok: i don't want to spend the time trying to figure it out. better for me to actually review that patch etc. | 17:15 |
*** zackf has joined #openstack-ironic | 17:16 | |
*** causten has quit IRC | 17:17 | |
*** causten has joined #openstack-ironic | 17:17 | |
*** chlong has joined #openstack-ironic | 17:17 | |
rloo | vdrok: i think the conflict is due to the portgroups patch was updated, so this patch needs to be rebased again. | 17:19 |
jlvillal | mariojv, running out the door. But AssertIsNone is good, not bad. | 17:21 |
*** Romanenko_K has quit IRC | 17:21 | |
jlvillal | mariojv, Supposed to prefer that over AssertEqual(None, blah) | 17:21 |
mariojv | jlvillal: ah, i misunderstood H203 to mean the opposite. thanks | 17:21 |
*** roeyc has joined #openstack-ironic | 17:22 | |
*** hw_wutianwei has quit IRC | 17:24 | |
*** baoli has joined #openstack-ironic | 17:28 | |
mariojv | for releases, is ironic 6.2.0-273 going to become ironic 6.3.0? | 17:31 |
*** Sukhdev has quit IRC | 17:31 | |
mariojv | i.e. is that just a tag for release notes hanging on master without a release #? | 17:31 |
mariojv | "that" being the -273 | 17:31 |
mariojv | i'm curious because i'm writing install guide docs, and i want to reference notifications as being available after a certain release | 17:31 |
mariojv | the base merged for it before newton release, but power state notifications (the first ones) didn't merge until 6.2.0-273 | 17:32 |
JayF | mariojv: you don't know if the next one will be 6.3 or 7.0 | 17:32 |
JayF | mariojv: it depends on if we merge breaking changes between now and then | 17:32 |
mariojv | ok; maybe it's best to reference when the base was included, then | 17:33 |
JayF | mariojv: once the portgroup stuff lands, you could maybe bug jroll for a release, but we should probably wait until that whole chain is in | 17:33 |
jroll | agree | 17:33 |
mariojv | or i could just say "in the release following the 6.2.0 release" | 17:33 |
mariojv | not sure which is better | 17:33 |
jroll | mariojv: that means 273 commits since last release | 17:33 |
*** jpich has quit IRC | 17:33 | |
jroll | it will be 6.3.0 or 7.0.0, depending if we drop deprecated things | 17:33 |
mariojv | ok, thx | 17:34 |
jroll | mariojv: install guide is versioned, though, so no need to mention which release | 17:36 |
JayF | oh, good point | 17:36 |
mariojv | ah, nice | 17:36 |
* milan gone, night Ironic! :) | 17:37 | |
*** milan has quit IRC | 17:37 | |
*** aNuposic has joined #openstack-ironic | 17:37 | |
*** baoli has quit IRC | 17:39 | |
xavierr | how to configure ironic to do insecure communication to swift? | 17:39 |
*** baoli has joined #openstack-ironic | 17:39 | |
xavierr | to skip certificate validation etc. | 17:40 |
xavierr | is that possible? | 17:40 |
JayF | I don't believe we have that ability currently | 17:42 |
JayF | sorta an antifeature but I could see why someone would want it :D | 17:42 |
xavierr | JayF: haha yeah. we are starting a new cloud env for internal tests | 17:43 |
JayF | xavierr: certbot + letsencrypt is a good thing :D | 17:43 |
xavierr | we cant use certificates to it | 17:43 |
*** Nisha_away has quit IRC | 17:43 | |
xavierr | JayF: oh | 17:43 |
JayF | xavierr: and a lot easier of a fix than adding the ability to not verify certificates to ironic | 17:43 |
*** godp1301 has quit IRC | 17:44 | |
xavierr | JayF: great! I will tell guys here to add to they evil plans | 17:45 |
xavierr | ty JayF | 17:45 |
* jroll -> lunch | 17:45 | |
*** ionutbalutoiu has quit IRC | 17:48 | |
*** betherly has quit IRC | 17:54 | |
*** derekh has quit IRC | 17:57 | |
*** jtomasek has quit IRC | 17:58 | |
*** baoli has quit IRC | 18:00 | |
*** baoli has joined #openstack-ironic | 18:00 | |
*** ralonsoh has quit IRC | 18:02 | |
*** jcoufal_ has joined #openstack-ironic | 18:02 | |
*** fragatin_ has joined #openstack-ironic | 18:04 | |
*** rama_y has joined #openstack-ironic | 18:04 | |
*** jcoufal has quit IRC | 18:05 | |
*** fragatina has quit IRC | 18:07 | |
*** lucasagomes is now known as lucas-afk | 18:07 | |
*** bnemec has quit IRC | 18:11 | |
JayF | jroll: dtantsur|afk: tonyb: https://review.openstack.org/#/c/395648/ should be merged into stable/newton asap please -- apparently our install guide docs are broken w/r/t configuring service user access | 18:12 |
patchbot | patch 395648 - ironic (stable/newton) - [install-guide] describe service clients auth | 18:12 |
*** mgould is now known as mgould|afk | 18:12 | |
*** ionutbalutoiu has joined #openstack-ironic | 18:13 | |
*** bnemec has joined #openstack-ironic | 18:13 | |
*** rbudden has joined #openstack-ironic | 18:16 | |
JayF | rama_y: aslezil: I wonder if https://review.openstack.org/#/c/369245/ overlaps with any of the work you're doing -- in terms of desired outcome, if not being identical information | 18:18 |
patchbot | patch 369245 - ironic-python-agent - Get numa_node info when collecting pci devices info | 18:18 |
*** baoli has quit IRC | 18:21 | |
*** baoli has joined #openstack-ironic | 18:22 | |
*** portdirect is now known as portdirect_away | 18:22 | |
*** ohamada has quit IRC | 18:23 | |
*** bdeschenes has joined #openstack-ironic | 18:26 | |
*** jaosorior has quit IRC | 18:26 | |
*** roeyc has quit IRC | 18:29 | |
rama_y | Hi JayF, aslezil: this patch is collecting additional info in IPA - that part is similar. But, it is not identical information. | 18:34 |
JayF | rama_y: I know you all were working on things related to specific scheduling; I didn't know how much of that related to numa | 18:36 |
jroll | JayF: done | 18:41 |
openstackgerrit | Merged openstack/ironic-python-agent: Update to hacking 0.12.0 and use new checks https://review.openstack.org/395123 | 18:42 |
*** baoli has quit IRC | 18:42 | |
*** baoli has joined #openstack-ironic | 18:43 | |
rloo | jroll: i updated the subteams wrt the bigger priorities. was not going to add teams for the smaller things. wdyt? | 18:43 |
*** godp1301 has joined #openstack-ironic | 18:44 | |
jroll | rloo: last cycle we decided to add teams for the smaller things | 18:44 |
jroll | I'm a bit indifferent | 18:44 |
jroll | but might be nice to see progress there | 18:45 |
rloo | jroll: oh. ok, in that case, i'll add. no contacts/leads for those though. | 18:45 |
jroll | rloo: yeah, I think that's okay | 18:45 |
rloo | jroll: i'm already tired, thinking of the stuff to be done for high priorities :) | 18:45 |
jroll | rloo: indeed, lots of work to do | 18:46 |
*** fragatin_ has quit IRC | 18:47 | |
rloo | jroll: some of those smaller things are just 'specs for ...'. forget about that, i say we get the entire feature done! | 18:47 |
*** fragatina has joined #openstack-ironic | 18:48 | |
jroll | rloo: so much to do already. those specs will take quite a bit of work already | 18:48 |
rloo | jroll: aim HIGH! :D | 18:48 |
*** baoli has quit IRC | 18:49 | |
jroll | :) | 18:49 |
jroll | I won't be mad if we do it | 18:49 |
*** baoli has joined #openstack-ironic | 18:50 | |
rloo | JayF, mat128: I removed the subteam for install guide migration. The bulk of work was done. | 18:51 |
rloo | lucas-afk: I'm going to remove the subteam for 'Enhanced root device hints'; there's just the docs that need reviewing. | 18:52 |
JayF | rloo: that's fine; thanks! | 18:52 |
*** amotoki has joined #openstack-ironic | 18:55 | |
*** wajdi has joined #openstack-ironic | 18:55 | |
*** rcernin has joined #openstack-ironic | 18:59 | |
*** harlowja has quit IRC | 18:59 | |
*** ChubYann has joined #openstack-ironic | 18:59 | |
*** amotoki has quit IRC | 18:59 | |
*** baoli has quit IRC | 19:00 | |
*** dprince has quit IRC | 19:00 | |
*** Sukhdev has joined #openstack-ironic | 19:00 | |
*** baoli has joined #openstack-ironic | 19:01 | |
*** ijw has joined #openstack-ironic | 19:02 | |
openstackgerrit | Merged openstack/ironic: DevStack: Fix standard PXE on Ubuntu Xenial https://review.openstack.org/393353 | 19:03 |
openstackgerrit | Merged openstack/ironic: [install-guide] describe service clients auth https://review.openstack.org/395648 | 19:05 |
rloo | JayF: were you going to work on this: https://trello.com/c/sYafFLBy/36-specific-fault-support | 19:06 |
JayF | rloo: yes; I have a very draft spec up and I'm going to drive that to design-completion this cycle | 19:07 |
JayF | rloo: I added myself to the card | 19:07 |
rloo | JayF: ok thx. I'll put you down as the lead. | 19:07 |
*** godp1301 has quit IRC | 19:11 | |
*** ijw has quit IRC | 19:11 | |
rloo | mat128: were you planning on working/leading the effort on https://trello.com/c/M7PueRS0/35-deploy-steps? | 19:14 |
*** sabeen has joined #openstack-ironic | 19:18 | |
*** amotoki has joined #openstack-ironic | 19:21 | |
*** ijw has joined #openstack-ironic | 19:22 | |
*** baoli has quit IRC | 19:22 | |
*** amotoki has quit IRC | 19:25 | |
*** baoli_ has joined #openstack-ironic | 19:28 | |
*** baoli__ has joined #openstack-ironic | 19:29 | |
*** baoli_ has quit IRC | 19:32 | |
*** chas_ has quit IRC | 19:33 | |
zer0c00l | So we have approximately ~5000+ nodes in one ironic cluster. An 'ironic node-set-maintenance <uuid> on' takes ~60 secs. ironic node-create takes 2 mins. | 19:40 |
zer0c00l | Any idea on how to improve performance of this? | 19:40 |
zer0c00l | Has any one had same kind of performance issues before? | 19:40 |
*** siva has joined #openstack-ironic | 19:41 | |
JayF | zer0c00l: how scaled out is your api cluster, and what deploy driver are you using? | 19:41 |
zer0c00l | We have 3 API nodes running ironic api | 19:42 |
zer0c00l | 2 conductuctor | 19:42 |
zer0c00l | 2 conductors | 19:42 |
JayF | I'd strongly suggest scaling out more, especially if you're using the agent driver. | 19:42 |
zer0c00l | We have a custom deploy driver pxe_ipmitool (does some special stuff) | 19:42 |
JayF | Yeah; I'd strongly suggest scaling out further | 19:42 |
zer0c00l | We are not using agent driver | 19:42 |
JayF | We had more conductors and api servers for that with fewer servers in OnMetal | 19:42 |
JayF | obviously, I'm assuming you' | 19:43 |
*** vsaienko has joined #openstack-ironic | 19:43 | |
zer0c00l | Adding more ironic conductor could help? | 19:43 |
JayF | *you've checked basic, dependant services, (i.e. you know mysql db server is not ill performant) | 19:43 |
JayF | zer0c00l: node-create specifically does /not/ touch the conductors at all, I don't think | 19:43 |
JayF | zer0c00l: so I'm suspecting you need API servers | 19:43 |
JayF | zer0c00l: but going to doublecheck the code | 19:43 |
zer0c00l | yeah that's what i thought | 19:43 |
zer0c00l | One thing to note is our code is from juno :(, did we have any peformance related changes? | 19:45 |
JayF | heh | 19:45 |
*** ppiela has quit IRC | 19:45 | |
JayF | Ironic in Juno and Ironic today are ... probably barely the same piece of software | 19:45 |
zer0c00l | agree | 19:46 |
zer0c00l | We did backport some stuff . | 19:46 |
*** clenimar has joined #openstack-ironic | 19:46 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update ironic node names for multinode case https://review.openstack.org/368645 | 19:46 |
zer0c00l | Did we have any specific changes related improve DB query peformance? | 19:46 |
JayF | zer0c00l: I honestly don't know; Juno is so long ago that was before I worked full time on upstream Ironic. | 19:46 |
JayF | zer0c00l: you're talking literally years old code that's completely unsupported upstream now | 19:47 |
JayF | zer0c00l: my only suggestion is to strongly suggest you upgrade to a more recent ironic, and if you can't do that, throw conductors/api servers at the problem | 19:47 |
*** ppiela has joined #openstack-ironic | 19:48 | |
*** ijw has quit IRC | 19:49 | |
*** aarefiev has joined #openstack-ironic | 19:50 | |
*** vsaienko has quit IRC | 19:51 | |
*** godp1301 has joined #openstack-ironic | 19:51 | |
*** jkilpatr_ has quit IRC | 19:52 | |
rloo | zer0c00l: you're still on juno? i thought someone did perf at your company using that version | 19:52 |
*** clenimar has quit IRC | 19:52 | |
*** vsaienko has joined #openstack-ironic | 19:54 | |
rloo | zer0c00l: might be this issue: https://bugs.launchpad.net/ironic/+bug/1547139 | 19:54 |
openstack | Launchpad bug 1547139 in Ironic "API does two DB accesses when getting node, port" [Medium,Triaged] | 19:54 |
zer0c00l | rloo: yes unfortunately | 19:55 |
zer0c00l | still in juno | 19:55 |
*** rcernin has quit IRC | 19:55 | |
rloo | zer0c00l: i remember that bug being an issue, but i don't know if that is what you're encountering in this case -- someone at y! wrote up something about it though | 19:56 |
rloo | zer0c00l: and i don't know if the bug has been addressed | 19:56 |
zer0c00l | Thanks rloo , will investigate | 19:57 |
*** aNuposic has quit IRC | 19:57 | |
zer0c00l | rloo: jroll seems to have abandoned that change | 20:01 |
zer0c00l | doesn't say why it was abandoned | 20:01 |
jroll | zer0c00l: was waiting for some other stuff to land that conflicted, took too long | 20:03 |
*** jkilpatr has joined #openstack-ironic | 20:04 | |
*** jkilpatr has quit IRC | 20:05 | |
*** priteau has quit IRC | 20:07 | |
zer0c00l | okay | 20:08 |
*** vsaienko has quit IRC | 20:10 | |
*** vsaienko has joined #openstack-ironic | 20:13 | |
*** jkilpatr has joined #openstack-ironic | 20:13 | |
rloo | jroll: it strikes me that portgroup uuids in ports will make thing worse wrt ^^. 3 db calls... | 20:14 |
*** ijw has joined #openstack-ironic | 20:15 | |
*** ijw has quit IRC | 20:17 | |
mrda | Morning Ironic | 20:18 |
nicodemos | morning, mrda | 20:19 |
*** vsaienko has quit IRC | 20:20 | |
jroll | rloo: probably | 20:20 |
*** jkilpatr has quit IRC | 20:20 | |
*** priteau has joined #openstack-ironic | 20:20 | |
jroll | well | 20:21 |
jroll | yeah, yeah it will | 20:21 |
jroll | whomp, we need some joins | 20:22 |
jroll | (this is fairly easy to do, though, if someone wants to pick it up | 20:22 |
jroll | ) | 20:22 |
openstackgerrit | Mario Villaplana proposed openstack/ironic: Add notification documentation to administrator's guide https://review.openstack.org/389344 | 20:23 |
openstackgerrit | Mario Villaplana proposed openstack/ironic: Add notification documentation to install guide https://review.openstack.org/395787 | 20:23 |
*** ijw has joined #openstack-ironic | 20:25 | |
openstackgerrit | Merged openstack/ironic-inspector: Update to hacking 0.12.0 and use new checks https://review.openstack.org/395593 | 20:28 |
openstackgerrit | Merged openstack/ironic-inspector: Add py35 to tox job list https://review.openstack.org/395598 | 20:28 |
*** ijw has quit IRC | 20:30 | |
openstackgerrit | Merged openstack/ironic: Integrate portgroups with ports to support LAG https://review.openstack.org/332177 | 20:30 |
*** ijw has joined #openstack-ironic | 20:31 | |
*** vsaienko has joined #openstack-ironic | 20:33 | |
*** chas_ has joined #openstack-ironic | 20:34 | |
*** jkilpatr has joined #openstack-ironic | 20:34 | |
mat128 | rloo: yes, my understanding is that we are splitting the deploy steps from the RAID work? | 20:36 |
*** ijw has quit IRC | 20:36 | |
rloo | mat128: yup. the deploy steps would be the framework for the RAID work. | 20:37 |
rloo | mat128: the hard part is getting the nova bit to work; there was talk about it, nothing concrete. although i think jay pipes said he would propose something. (can't recall, see the etherpad from the design session). | 20:37 |
mat128 | rloo: but in any case we need Ironic to "apply" a RAID config on it's own, right? | 20:38 |
*** vsaienko has quit IRC | 20:38 | |
rloo | mat128: right. i think that's the easy part, ironic already knows how to apply a config. but how to get the config is the question. | 20:38 |
*** chas_ has quit IRC | 20:39 | |
rloo | so applying the raid config during deployment would be eg one deploy step. | 20:39 |
mat128 | rloo: yup, is this last part not a priority for the sprint? | 20:41 |
mat128 | s/sprint/cycle | 20:41 |
rloo | mat128: for ocata, i think jroll will be very happy if we have an approved spec or close-to-approved spec: http://specs.openstack.org/openstack/ironic-specs/priorities/ocata-priorities.html | 20:42 |
rloo | mat128: at bottom, 'spec for deploy steps' :) | 20:42 |
mat128 | my concern is "spec for deploy steps" vs "spec for RAID during deployment" | 20:42 |
rloo | mat128: the deploy steps needs to be done, to able to add raid as one of those steps. | 20:42 |
mat128 | I presume having (not only the spec but the impl too) RAID during deployment will need to be done for nova to accept to send anything raid-specific | 20:43 |
mat128 | rloo: yes, deploy steps are a prerequisite for raid during deploy | 20:43 |
rloo | mat128: yes, for the actual code changes. but we need from nova, some ack wrt the 'right' way for a user to get that config info down via nova to ironic | 20:43 |
*** bdeschenes has quit IRC | 20:44 | |
mat128 | rloo: I thought the hard part was the user <> nova interaction | 20:44 |
rloo | mat128: the deploy steps in ironic can be done separately from that other nova part though. | 20:44 |
rloo | yes, that's the hard part. | 20:44 |
mat128 | rloo: not the nova <> ironic, because nova can simply call "set-target-raid-config" stuff | 20:44 |
rloo | yup | 20:45 |
mat128 | as I said, I was hoping the "ironic configures RAID during deployment" (including the deploy-steps framework + an actual raid config deploy step) would be prioritized | 20:46 |
mat128 | but we have to start with the deploy steps, thats right | 20:47 |
*** baoli__ has quit IRC | 20:47 | |
rloo | mat128: well, the spec part was prioritized. of the deploy steps. one thing at a time. if the spec + code gets done in ocata that'd be great. the raid part would be easy after that. | 20:47 |
*** hamzy has quit IRC | 20:48 | |
rloo | mat128: ocata isn't that long. lots of stuff in our list of priorities; what can we cut out? | 20:48 |
mat128 | rloo: yeah I understand | 20:48 |
mat128 | rloo: nah thats fine :) | 20:48 |
mat128 | it's all about priorities :) | 20:49 |
*** baoli has joined #openstack-ironic | 20:49 | |
rloo | mat128: unfortunately. if i was super-something and could get it all done, it wouldn't be a problem! | 20:49 |
mat128 | we need more super-engineers :) | 20:50 |
rloo | mat128: yes!!! | 20:50 |
mat128 | alright then, to answer your original question: yes I will be leading this work | 20:50 |
*** baoli_ has joined #openstack-ironic | 20:50 | |
rloo | mat128: thx! I'll put you down for that then. | 20:51 |
mat128 | yay! | 20:51 |
mat128 | thx | 20:51 |
*** baoli__ has joined #openstack-ironic | 20:51 | |
*** baoli has quit IRC | 20:54 | |
*** baoli_ has quit IRC | 20:55 | |
*** priteau has quit IRC | 20:56 | |
*** marios has quit IRC | 20:57 | |
*** slagle has quit IRC | 20:57 | |
jroll | rloo: mat128: thanks :) | 21:04 |
*** baoli__ has quit IRC | 21:07 | |
*** baoli has joined #openstack-ironic | 21:08 | |
*** jrcloud has joined #openstack-ironic | 21:12 | |
*** zackf has quit IRC | 21:13 | |
*** priteau has joined #openstack-ironic | 21:14 | |
*** mjturek1 has joined #openstack-ironic | 21:22 | |
*** mjturek1 has quit IRC | 21:23 | |
*** mjturek1 has joined #openstack-ironic | 21:23 | |
*** mjturek has quit IRC | 21:25 | |
*** Goneri has quit IRC | 21:26 | |
*** marios has joined #openstack-ironic | 21:31 | |
*** slagle has joined #openstack-ironic | 21:31 | |
*** _mbelanger has quit IRC | 21:31 | |
*** jkilpatr has quit IRC | 21:34 | |
*** godp1301_ has joined #openstack-ironic | 21:35 | |
*** godp1301_ has quit IRC | 21:35 | |
*** godp1301 has quit IRC | 21:35 | |
*** chas_ has joined #openstack-ironic | 21:35 | |
*** godp1301 has joined #openstack-ironic | 21:36 | |
*** mjturek1 has quit IRC | 21:36 | |
*** priteau has quit IRC | 21:38 | |
rloo | jroll: were you planning on reviewing https://review.openstack.org/#/c/395632/? Otherwise, I'll +A. Oh, it can wait til tomorrow, was only submitted today. | 21:39 |
patchbot | patch 395632 - ironic-python-agent - Fix several errors in LLDP handling code | 21:39 |
*** chas_ has quit IRC | 21:40 | |
jroll | rloo: I'm looking right now | 21:40 |
jroll | hardest review I've done in a while :) | 21:41 |
jroll | if you're +2 I'll likely +A | 21:41 |
rloo | jroll: you need to get back into the swing of things. i'll find a hard review for you if you'd like :) | 21:41 |
jroll | rloo: well, this one is hard in a different way than most :) | 21:41 |
rloo | jroll: true | 21:41 |
*** godp1301 has quit IRC | 21:44 | |
*** hamzy has joined #openstack-ironic | 21:44 | |
JayF | jroll: yeah, I looked back at the history of that code to make sure it wasn't readding the endless-lldp-loop bug back | 21:46 |
*** ijw has joined #openstack-ironic | 21:48 | |
rloo | jroll, JayF: have you seen this RFE? I think we can approve it? https://bugs.launchpad.net/ironic/+bug/1639338 | 21:48 |
openstack | Launchpad bug 1639338 in Ironic "[RFE] Add support for DBDeadlock handling." [Undecided,In progress] - Assigned to Grzegorz Grasza (xek) | 21:48 |
*** harlowja has joined #openstack-ironic | 21:49 | |
JayF | rloo: sounds like a good idea to me | 21:50 |
jroll | ugh, galera | 21:50 |
*** amotoki has joined #openstack-ironic | 21:50 | |
jroll | yeah, I'm alright with that | 21:50 |
rloo | ok, am going to put your +1s on that and approve it then :) | 21:50 |
jroll | thanks | 21:50 |
*** mjturek has joined #openstack-ironic | 21:51 | |
*** amotoki has quit IRC | 21:53 | |
*** aNuposic has joined #openstack-ironic | 21:54 | |
*** ijw has quit IRC | 21:56 | |
*** jkilpatr has joined #openstack-ironic | 21:58 | |
*** rama_y has quit IRC | 21:59 | |
*** rama_y has joined #openstack-ironic | 22:00 | |
openstackgerrit | Félix Bouliane proposed openstack/ironic: WIP- Add virtualpdu to ironic devstack plugin https://review.openstack.org/388154 | 22:00 |
openstackgerrit | Félix Bouliane proposed openstack/ironic: DONOTMERGE-change IRONIC_DEPLOY_DRIVER to pxe_snmp https://review.openstack.org/388168 | 22:00 |
*** ijw has joined #openstack-ironic | 22:02 | |
*** jcoufal_ has quit IRC | 22:02 | |
*** jheroux has quit IRC | 22:04 | |
*** ijw has quit IRC | 22:07 | |
*** baoli has quit IRC | 22:09 | |
*** ppiela has quit IRC | 22:09 | |
*** aNuposic has quit IRC | 22:15 | |
jlvillal | JayF, I'm asking over on infra about: https://review.openstack.org/#/c/374147/ | 22:16 |
patchbot | patch 374147 - ironic-python-agent - Add bash scripts style checking for IPA (SUBMITTED) | 22:16 |
jlvillal | Seems stuck. Not sure why. | 22:16 |
*** baoli has joined #openstack-ironic | 22:18 | |
jlvillal | I'm going to rebase it. | 22:18 |
openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Add bash scripts style checking for IPA https://review.openstack.org/374147 | 22:22 |
*** baoli has quit IRC | 22:24 | |
*** baoli has joined #openstack-ironic | 22:26 | |
*** baoli has quit IRC | 22:26 | |
*** rbudden has quit IRC | 22:26 | |
openstackgerrit | Merged openstack/ironic-python-agent: Fix several errors in LLDP handling code https://review.openstack.org/395632 | 22:33 |
*** chas_ has joined #openstack-ironic | 22:36 | |
*** priteau has joined #openstack-ironic | 22:37 | |
*** priteau has quit IRC | 22:40 | |
*** chas_ has quit IRC | 22:41 | |
*** cdearborn has quit IRC | 22:42 | |
*** chlong has quit IRC | 22:47 | |
*** ijw has joined #openstack-ironic | 22:53 | |
*** e0ne has joined #openstack-ironic | 22:53 | |
jlvillal | jroll, I think I answered your question: https://review.openstack.org/#/c/395632/1/ironic_python_agent/tests/unit/test_netutils.py@260 | 22:55 |
patchbot | patch 395632 - ironic-python-agent - Fix several errors in LLDP handling code (MERGED) | 22:55 |
jlvillal | But yeah the wording is a bit confusing. | 22:56 |
jroll | jlvillal: ah, you're right, thanks | 22:57 |
*** ijw has quit IRC | 22:57 | |
*** ijw has joined #openstack-ironic | 22:59 | |
*** causten has quit IRC | 22:59 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Clarify test comment to minimize confusion https://review.openstack.org/395863 | 23:01 |
jroll | nice, +2 | 23:01 |
jlvillal | jroll, ^^^ heh :) | 23:01 |
jroll | :D | 23:01 |
jlvillal | I couldn't stop myself | 23:01 |
jroll | yeah, I hear ya | 23:01 |
*** lindycoder has quit IRC | 23:02 | |
*** ijw has quit IRC | 23:03 | |
* jroll turns into a pumpkin for the night | 23:04 | |
*** e0ne has quit IRC | 23:04 | |
jroll | see y'all tomorrow | 23:04 |
rloo | ciao jroll | 23:05 |
jlvillal | jroll, Good night. | 23:06 |
* JayF helps jlvillal pump up his commit stats by landing that | 23:08 | |
jlvillal | heh :) | 23:08 |
JayF | jlvillal: you just forgot the rule: your git commit message first line must only be "TrivialFix" | 23:08 |
* JayF ducks | 23:08 | |
jlvillal | JayF, Oh yeah, I saw that email thread from Kolla | 23:08 |
*** harlowja_ has joined #openstack-ironic | 23:08 | |
JayF | jlvillal: I was more talking about the ... infestation of barely-useful commits into our repos, but it applies there too :p | 23:09 |
jlvillal | If we have that rule, I don't know about it. Thankfully | 23:09 |
jlvillal | JayF, Oh yeah. Those! | 23:09 |
openstackgerrit | Merged openstack/ironic-python-agent: Clarify test comment to minimize confusion https://review.openstack.org/395863 | 23:10 |
*** aNuposic has joined #openstack-ironic | 23:11 | |
*** harlowja has quit IRC | 23:12 | |
*** patchbot has quit IRC | 23:13 | |
*** patchbot has joined #openstack-ironic | 23:13 | |
*** patchbot has quit IRC | 23:15 | |
*** patchbot has joined #openstack-ironic | 23:16 | |
*** aNuposic has quit IRC | 23:16 | |
*** jerrygb has quit IRC | 23:16 | |
*** aNuposic has joined #openstack-ironic | 23:16 | |
*** ijw has joined #openstack-ironic | 23:20 | |
*** ppiela has joined #openstack-ironic | 23:21 | |
*** jerrygb has joined #openstack-ironic | 23:23 | |
*** rama_y has quit IRC | 23:31 | |
*** Nisha_away has joined #openstack-ironic | 23:40 | |
*** wajdi has quit IRC | 23:41 | |
*** Nisha_away has quit IRC | 23:44 | |
*** cdearborn has joined #openstack-ironic | 23:48 | |
*** siva has quit IRC | 23:50 | |
*** sabeen has quit IRC | 23:50 | |
JayF | mariojv: I just picked a nit on 395787 (install guide + notifications), if you wanna fix it real quick I can flip my vote | 23:53 |
*** siva has joined #openstack-ironic | 23:53 | |
*** hw_wutianwei has joined #openstack-ironic | 23:54 | |
*** chas_ has joined #openstack-ironic | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!