| *** yufei has joined #openstack-ironic | 00:19 | |
| *** godp1301 has joined #openstack-ironic | 00:39 | |
| zer0c00l | Setting ipmi min_command_interval=5 seems to have borked some of our hardware in datacenter | 00:45 |
|---|---|---|
| zer0c00l | I mean they crashed the firmware and ipmi no longer responds to it | 00:45 |
| zer0c00l | Any one have experience with min_command_interval field? | 00:45 |
| zer0c00l | What is the optimal value for it? | 00:45 |
| zer0c00l | This setting seem to have crashed ipmi on a specific vendor | 00:46 |
| zer0c00l | JayF: ^^ ? | 00:46 |
| *** amotoki has joined #openstack-ironic | 00:56 | |
| *** SerenaFeng has joined #openstack-ironic | 00:57 | |
| *** hoangcx has joined #openstack-ironic | 00:58 | |
| *** chlong has quit IRC | 00:59 | |
| *** Syed__ has quit IRC | 01:05 | |
| *** jkilpatr has quit IRC | 01:06 | |
| *** SerenaFeng has quit IRC | 01:06 | |
| *** amotoki has quit IRC | 01:11 | |
| *** amotoki has joined #openstack-ironic | 01:12 | |
| *** zhangjl has joined #openstack-ironic | 01:22 | |
| *** amotoki has quit IRC | 01:28 | |
| *** amotoki has joined #openstack-ironic | 01:30 | |
| *** rloo has quit IRC | 01:37 | |
| *** godp1301 has quit IRC | 01:40 | |
| *** baoli has joined #openstack-ironic | 01:40 | |
| *** baoli has quit IRC | 01:45 | |
| *** tuanluong has joined #openstack-ironic | 01:46 | |
| *** SerenaFeng has joined #openstack-ironic | 01:49 | |
| *** pmannidi_ has joined #openstack-ironic | 01:56 | |
| *** pmannidi has quit IRC | 01:57 | |
| *** Sukhdev has quit IRC | 01:59 | |
| *** phuongnh has joined #openstack-ironic | 02:02 | |
| *** trananhkma has joined #openstack-ironic | 02:22 | |
| *** gcb has quit IRC | 02:30 | |
| openstackgerrit | yunfeng zhou proposed openstack/ironic-inspector: Add licensing info in source file. https://review.openstack.org/412704 | 02:34 |
| openstackgerrit | yunfeng zhou proposed openstack/ironic-inspector: Add licensing info in source file. https://review.openstack.org/412704 | 02:36 |
| *** fragatina has joined #openstack-ironic | 02:37 | |
| openstackgerrit | yunfeng zhou proposed openstack/ironic-inspector: replace logging with oslo_log. https://review.openstack.org/412711 | 02:46 |
| openstackgerrit | yunfeng zhou proposed openstack/ironic-inspector: replace logging with oslo_log. https://review.openstack.org/412711 | 02:48 |
| *** gcb has joined #openstack-ironic | 02:50 | |
| *** hw_wutianwei has joined #openstack-ironic | 02:57 | |
| *** lindycoder has joined #openstack-ironic | 03:17 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 03:32 | |
| *** amotoki has quit IRC | 03:33 | |
| *** vikrant has joined #openstack-ironic | 03:35 | |
| openstackgerrit | paresh sao proposed openstack/ironic: Boot from iSCSI volume https://review.openstack.org/308425 | 03:47 |
| *** rpioso has quit IRC | 03:50 | |
| *** godp1301 has joined #openstack-ironic | 04:00 | |
| openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: [WIP] snmp inspection https://review.openstack.org/394858 | 04:05 |
| *** amotoki has joined #openstack-ironic | 04:07 | |
| *** SerenaFeng has quit IRC | 04:12 | |
| *** godp1301 has quit IRC | 04:21 | |
| *** trananhkma has quit IRC | 04:39 | |
| *** links has joined #openstack-ironic | 04:52 | |
| *** amotoki has quit IRC | 04:58 | |
| *** amotoki has joined #openstack-ironic | 05:03 | |
| *** amotoki has quit IRC | 05:14 | |
| *** SerenaFeng has joined #openstack-ironic | 05:16 | |
| *** SerenaFeng has joined #openstack-ironic | 05:17 | |
| *** Sukhdev has joined #openstack-ironic | 05:22 | |
| *** SerenaFeng has quit IRC | 05:22 | |
| *** Nisha_Agarwal has quit IRC | 05:28 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 05:28 | |
| *** SerenaFeng has joined #openstack-ironic | 05:39 | |
| *** amotoki has joined #openstack-ironic | 05:50 | |
| *** Sukhdev has quit IRC | 05:52 | |
| *** jaosorior has joined #openstack-ironic | 05:57 | |
| *** shuquan_ has joined #openstack-ironic | 06:12 | |
| *** amotoki has quit IRC | 06:21 | |
| *** moshele has joined #openstack-ironic | 06:21 | |
| *** amotoki has joined #openstack-ironic | 06:27 | |
| *** rbartal has joined #openstack-ironic | 06:29 | |
| *** jaosorior has quit IRC | 06:41 | |
| *** jaosorior has joined #openstack-ironic | 06:42 | |
| *** dsneddon has quit IRC | 06:50 | |
| *** mjura has joined #openstack-ironic | 06:51 | |
| *** mjura has quit IRC | 06:57 | |
| *** mjura has joined #openstack-ironic | 06:58 | |
| *** rcernin has quit IRC | 06:59 | |
| *** SerenaFeng has quit IRC | 06:59 | |
| *** SerenaFeng has joined #openstack-ironic | 07:02 | |
| openstackgerrit | kobig proposed openstack/ironic: Code suggestion for implementing https://blueprints.launchpad.net/ironic/+spec/generic-image-partition-aproach https://review.openstack.org/412810 | 07:04 |
| *** shuquan_ has quit IRC | 07:08 | |
| openstackgerrit | kobig proposed openstack/ironic-lib: Code changes to implement https://blueprints.launchpad.net/ironic/+spec/generic-image-partition-aproach Change-Id: Id025c528f0cad485537713bb38e4e6a81406eac6 https://review.openstack.org/412817 | 07:08 |
| *** rcernin has joined #openstack-ironic | 07:10 | |
| *** tesseract has joined #openstack-ironic | 07:11 | |
| *** tesseract is now known as Guest14972 | 07:11 | |
| *** rbudden has quit IRC | 07:21 | |
| *** rcernin has quit IRC | 07:26 | |
| *** moshele has quit IRC | 07:27 | |
| *** amotoki has quit IRC | 07:31 | |
| *** Nisha_Agarwal has quit IRC | 07:32 | |
| *** moshele has joined #openstack-ironic | 07:34 | |
| vdrok | good morning ironic! | 07:36 |
| *** rcernin has joined #openstack-ironic | 07:42 | |
| tuanluong | mroning vdrok , ironic | 07:50 |
| vdrok | tuanluong: good morning :) | 07:51 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add ironic resources CRUD notifications https://review.openstack.org/356541 | 07:58 |
| openstackgerrit | Moshe Levi proposed openstack/ironic-inspector: Adding InfiniBand Support https://review.openstack.org/264257 | 08:00 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add node maintenance notifications https://review.openstack.org/396239 | 08:07 |
| *** ChubYann has quit IRC | 08:07 | |
| *** jvgrant has quit IRC | 08:13 | |
| *** jvgrant has joined #openstack-ironic | 08:13 | |
| openstackgerrit | yunfeng zhou proposed openstack/ironic-inspector-specs: add CONTRIBUTING.rst https://review.openstack.org/412858 | 08:14 |
| openstackgerrit | yunfeng zhou proposed openstack/ironic-python-agent: add CONTRIBUTING.rst https://review.openstack.org/412859 | 08:14 |
| openstackgerrit | yunfeng zhou proposed openstack/ironic-specs: add CONTRIBUTING.rst https://review.openstack.org/412860 | 08:15 |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Generic power interface for soft reboot and soft power off https://review.openstack.org/216730 | 08:15 |
| *** pcaruana has joined #openstack-ironic | 08:19 | |
| *** zhs__ has joined #openstack-ironic | 08:19 | |
| *** zhs_ has quit IRC | 08:23 | |
| *** amotoki has joined #openstack-ironic | 08:33 | |
| *** amoralej|off is now known as amoralej | 08:35 | |
| *** fxpester has joined #openstack-ironic | 08:35 | |
| *** rcernin has quit IRC | 08:36 | |
| *** fragatin_ has joined #openstack-ironic | 08:38 | |
| *** fragatina has quit IRC | 08:39 | |
| *** milan has joined #openstack-ironic | 08:39 | |
| milan | morning Ironic! :) | 08:40 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: ETAGs maintenance for all api node's requests https://review.openstack.org/392213 | 08:40 |
| galyna | morning, Milan! ^) | 08:41 |
| galyna | :) | 08:41 |
| milan | morning galyna! :) | 08:41 |
| *** jaosorior has quit IRC | 08:41 | |
| *** priteau has joined #openstack-ironic | 08:42 | |
| *** jaosorior has joined #openstack-ironic | 08:43 | |
| vdrok | morning milan and galyna | 08:44 |
| milan | morning vdrok! :) | 08:44 |
| galyna | morning vdrok | 08:47 |
| moshele | milan: hi can you review Adding InfiniBand Support https://review.openstack.org/#/c/264257/ | 08:47 |
| patchbot | patch 264257 - ironic-inspector - Adding InfiniBand Support | 08:47 |
| milan | moshele, morning! :) yeah, on my radar, most likely today /me has been checking https://review.openstack.org/#/c/311091/6..7/specs/approved/torrent-provisioning.rst | 08:48 |
| patchbot | patch 311091 - ironic-specs - Torrent-based provisioning | 08:48 |
| *** aarefiev has joined #openstack-ironic | 08:49 | |
| moshele | milan: also do you know if there is a problem in ironic-inspector gate? gate-grenade-dsvm-ironic-inspector-ubuntu-xenial and gate-tempest-dsvm-ironic-inspector-ubuntu-xenial and gate-tempest-dsvm-ironic-inspector-discovery-ubuntu-xenial always fails | 08:49 |
| milan | michele, yeah the gate has been hosed since yesterday :-/ | 08:50 |
| * milan pastes | 08:50 | |
| *** soliosg has quit IRC | 08:50 | |
| aarefiev | morning all! | 08:50 |
| milan | moshele, https://bugs.launchpad.net/ironic-inspector/+bug/1651123 | 08:51 |
| openstack | Launchpad bug 1651123 in Ironic Inspector "Tempest hosed because of removed test tags" [Critical,In progress] - Assigned to milan k (vetrisko) | 08:51 |
| milan | morning aarefiev! :) | 08:51 |
| aarefiev | morning :) | 08:51 |
| moshele | milan: thanks :) | 08:51 |
| milan | also https://review.openstack.org/#/c/400687/ | 08:51 |
| patchbot | patch 400687 - ironic - Grenade: configure tempest with Ironic plugin | 08:51 |
| milan | moshele, np | 08:51 |
| milan | the later one supposed to fix the fix for the original issue, but obviously requires some fixing itself :) | 08:52 |
| milan | *latter | 08:52 |
| * milan hasn't checked yet what's going on | 08:52 | |
| vdrok | morning aarefiev_afk | 08:53 |
| *** jpich has joined #openstack-ironic | 08:54 | |
| openstackgerrit | Milan Kováčik proposed openstack/ironic: Grenade: configure tempest with Ironic plugin https://review.openstack.org/400687 | 08:56 |
| *** yufei has quit IRC | 08:56 | |
| milan | aarefiev ^ I've added the tag removal as a dependency there | 08:57 |
| * milan hopes it will charm Zuul enough to +1 it | 08:58 | |
| *** rcernin has joined #openstack-ironic | 08:58 | |
| aarefiev | milan: what do you want to see? | 08:59 |
| aarefiev | morning vdrok | 08:59 |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-ironic | 09:00 | |
| milan | aarefiev, the key error disappearing but maybe it's nonsense | 09:02 |
| * milan just face rolls the keyboard | 09:02 | |
| aarefiev | hmm | 09:02 |
| *** lucas-afk is now known as lucasagomes | 09:03 | |
| lucasagomes | morning all | 09:03 |
| milan | morning lucasagomes! :) | 09:03 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add mode and properties to portgroup https://review.openstack.org/412545 | 09:03 |
| vdrok | morning lucasagomes | 09:04 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/python-ironicclient: [WIP] POC: Full-featured objects with ETAGs supporting https://review.openstack.org/400335 | 09:07 |
| *** ohamada has joined #openstack-ironic | 09:08 | |
| galyna | morning lucasagomes | 09:15 |
| *** yufei has joined #openstack-ironic | 09:16 | |
| *** e0ne has joined #openstack-ironic | 09:17 | |
| openstackgerrit | yunfeng zhou proposed openstack/python-ironic-inspector-client: add CONTRIBUTING.rst https://review.openstack.org/412953 | 09:17 |
| lucasagomes | o/ | 09:19 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add node console notifications https://review.openstack.org/397812 | 09:19 |
| *** amotoki has quit IRC | 09:21 | |
| *** athomas has joined #openstack-ironic | 09:24 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 09:27 | |
| *** amotoki has joined #openstack-ironic | 09:33 | |
| *** amotoki has quit IRC | 09:35 | |
| *** Nisha_Agarwal has quit IRC | 09:36 | |
| *** derekh has joined #openstack-ironic | 09:36 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 09:38 | |
| *** snecklifter_ has joined #openstack-ironic | 09:38 | |
| *** SerenaFeng has quit IRC | 09:43 | |
| *** snecklifter has quit IRC | 09:45 | |
| openstackgerrit | Aline Bousquet proposed openstack/ironic: Add unit tests for v1/nodes/<uuid>/validate endpoint https://review.openstack.org/412996 | 09:45 |
| *** snecklifter has joined #openstack-ironic | 09:45 | |
| *** snecklifter has quit IRC | 09:46 | |
| *** snecklifter_ is now known as snecklifter | 09:46 | |
| *** Nisha_Agarwal has quit IRC | 09:46 | |
| *** snecklifter_ has joined #openstack-ironic | 09:46 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 09:48 | |
| *** yufei has quit IRC | 09:51 | |
| *** yufei has joined #openstack-ironic | 09:51 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Forbid removing portgroup mode https://review.openstack.org/413000 | 09:52 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-specs: Promote iPXE to separate boot interface https://review.openstack.org/385572 | 09:55 |
| openstackgerrit | Derek Higgins proposed openstack/ironic-python-agent: lio: Listen for connections on both IPv4 and IPv6 ports https://review.openstack.org/411819 | 09:56 |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Add support of remote logging https://review.openstack.org/410247 | 09:59 |
| *** Romanenko_K has joined #openstack-ironic | 10:03 | |
| *** yufei has quit IRC | 10:08 | |
| sergek | morning Ironicers! | 10:12 |
| vdrok | morning sergek | 10:13 |
| milan | morning sergek! :) | 10:14 |
| sergek | o/ vdrok milan | 10:20 |
| *** Nisha_Agarwal has quit IRC | 10:20 | |
| *** hoangcx has quit IRC | 10:22 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Fix bashate warning in devstack plugin https://review.openstack.org/412606 | 10:24 |
| *** SerenaFeng has joined #openstack-ironic | 10:24 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/python-ironicclient: [WIP] ETAGs for node in ironicclient https://review.openstack.org/400335 | 10:27 |
| *** zhangjl has quit IRC | 10:40 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 10:47 | |
| *** e0ne has quit IRC | 10:49 | |
| *** e0ne has joined #openstack-ironic | 10:49 | |
| *** lucasagomes is now known as lucas-bbl | 10:53 | |
| *** jkilpatr has joined #openstack-ironic | 10:56 | |
| *** gcb has quit IRC | 10:59 | |
| *** amotoki has joined #openstack-ironic | 10:59 | |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add mode and properties to portgroup OSC plugin https://review.openstack.org/413028 | 11:01 |
| *** phuongnh has quit IRC | 11:07 | |
| *** amotoki has quit IRC | 11:10 | |
| *** ccamacho has joined #openstack-ironic | 11:10 | |
| *** jkilpatr has quit IRC | 11:28 | |
| *** dsneddon has joined #openstack-ironic | 11:30 | |
| *** amotoki has joined #openstack-ironic | 11:40 | |
| *** Nisha_Agarwal has quit IRC | 11:42 | |
| *** yufei has joined #openstack-ironic | 11:43 | |
| openstackgerrit | jiang wei proposed openstack/python-ironicclient: Replace logging library with oslo_log https://review.openstack.org/413042 | 11:48 |
| *** athomas has quit IRC | 11:50 | |
| *** fragatin_ has quit IRC | 11:51 | |
| *** yufei has quit IRC | 11:53 | |
| *** tuanluong has quit IRC | 11:58 | |
| *** athomas has joined #openstack-ironic | 12:00 | |
| *** skramaja has quit IRC | 12:01 | |
| *** lucas-bbl is now known as lucas-hungry | 12:04 | |
| *** jkilpatr has joined #openstack-ironic | 12:07 | |
| xavierr | morning ironic :) | 12:08 |
| * xavierr needs to stop using weechat :( | 12:09 | |
| *** nicodemos has joined #openstack-ironic | 12:15 | |
| milan | morning xavierr! :) | 12:17 |
| milan | guys I have to take PTO till EOY (thought would be able to stay till Thursday) but apparently the law changed here and I cannot transfer any PTO days to the next year. Sry :-/ | 12:19 |
| milan | moshele, I won't be able to review before new year :-/ ^ | 12:19 |
| *** amotoki has quit IRC | 12:20 | |
| moshele | milan: thanks for the head-up have fun :) | 12:20 |
| *** jkilpatr has quit IRC | 12:20 | |
| milan | moshele, thanks :) | 12:20 |
| *** jkilpatr has joined #openstack-ironic | 12:20 | |
| jroll | milan: enjoy :D | 12:24 |
| milan | jroll, thanks! :) | 12:24 |
| jroll | morning everyone | 12:25 |
| *** Nisha_Agarwal has joined #openstack-ironic | 12:25 | |
| aarefiev | milan: have nice pto :) | 12:26 |
| *** lucas-hungry is now known as lucasagomes | 12:26 | |
| aarefiev | morning jroll | 12:26 |
| lucasagomes | morning xavierr aarefiev jroll | 12:26 |
| aarefiev | morning lucasagomes | 12:27 |
| milan | aarefiev, thanks! :) | 12:27 |
| *** milan is now known as milan|PTO | 12:28 | |
| nicodemos | have a great PTO, milan. and morning, ironic. | 12:29 |
| *** Nisha_Agarwal has quit IRC | 12:30 | |
| *** SerenaFeng has quit IRC | 12:32 | |
| *** dprince has joined #openstack-ironic | 12:35 | |
| jroll | aarefiev: fyi, I updated https://review.openstack.org/#/c/412477/ a bit | 12:37 |
| patchbot | patch 412477 - openstack-infra/project-config - Use Ironic Inspector tempest plugin from master | 12:37 |
| *** amotoki has joined #openstack-ironic | 12:40 | |
| mrtenio | Enjoy milan|PTO :) | 12:40 |
| *** amotoki has quit IRC | 12:40 | |
| *** amotoki has joined #openstack-ironic | 12:41 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM: Test patch to verify bond https://review.openstack.org/388660 | 12:41 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: Ironic devstack portgroup support https://review.openstack.org/381743 | 12:41 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 | 12:41 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: Allow to attach/deatach vif to portgroup https://review.openstack.org/406915 | 12:41 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Tempest tests for portgroups https://review.openstack.org/382476 | 12:41 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface RPC APIs https://review.openstack.org/404239 | 12:41 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface Driver APIs https://review.openstack.org/327046 | 12:41 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Fix bashate warning in devstack plugin https://review.openstack.org/412606 | 12:42 |
| milan|PTO | mrtenio, thanks! :) | 12:42 |
| pas-ha | milan, have great holidays :) | 12:43 |
| milan|PTO | thanks pas-ha! :) | 12:43 |
| aarefiev | thanks jroll | 12:44 |
| *** hw_wutianwei has quit IRC | 12:46 | |
| milan|PTO | nicodemos, thanks! :) | 12:50 |
| *** chlong has joined #openstack-ironic | 12:53 | |
| vdrok | morning jroll nicodemos and mrtenio | 13:00 |
| vdrok | milan|PTO: wait, you don't review on PTO?!! | 13:00 |
| nicodemos | hey, vdrok o/ | 13:00 |
| milan|PTO | vdrok, I'd better not | 13:00 |
| milan|PTO | :D | 13:00 |
| vdrok | have great holidays then :) | 13:01 |
| milan|PTO | vdrok, thanks! :D | 13:01 |
| *** pcaruana has quit IRC | 13:01 | |
| *** hoangcx has joined #openstack-ironic | 13:02 | |
| milan|PTO | Have a nice holidays Ironic! :) aarefiev, jroll, lucasagomes, mrtenio, nicodemos, vdrok and patchbot and all I've missed! CU in new year! /me off | 13:02 |
| vdrok | thanks milan :) | 13:02 |
| *** milan|PTO has left #openstack-ironic | 13:02 | |
| lucasagomes | milan|PTO, oh man, you too! Enjoy it! | 13:02 |
| vdrok | lucasagomes: jroll how do you feel about this patch? https://review.openstack.org/350177 . it feels like a hack to me, but tests what it's supposed to. or maybe it's better to just add a bunch of tests to tempest for that? | 13:04 |
| patchbot | patch 350177 - ironic - Add test to ensure policy is always authorized | 13:04 |
| lucasagomes | vdrok, will take a look, is this the test for the thing you fixed yesterday ? | 13:05 |
| vdrok | yup | 13:05 |
| lucasagomes | about demo user not being able to see the ironic nodes ? | 13:05 |
| lucasagomes | cool | 13:05 |
| *** wajdi has joined #openstack-ironic | 13:06 | |
| vdrok | the problem is, it seems to be fragile (or I just don't fully understand how sys.modules work) eg if I do del sys.modules[<generated uuid>] after L60, random tests start to fail | 13:06 |
| *** pcaruana has joined #openstack-ironic | 13:06 | |
| *** mjturek has joined #openstack-ironic | 13:09 | |
| lucasagomes | vdrok, yeah, it looks a bit black magic-ish to dynamically import that module | 13:10 |
| lucasagomes | vdrok, but I also don't know how else we could test it as a unittest | 13:10 |
| lucasagomes | overall, I think I'm good with it the way it is, if it turns out to be bad form we can add tempest tests as you mentioned | 13:11 |
| vdrok | I have the same thoughts. but writing 50 unittests is frightening :) | 13:11 |
| lucasagomes | jroll, ^ wdyt ? | 13:11 |
| *** bfournie has quit IRC | 13:11 | |
| *** mjturek has quit IRC | 13:13 | |
| *** vikrant has quit IRC | 13:14 | |
| moshele | aarefiev, dtantsur|afk: hi can you review https://review.openstack.org/#/c/264257/ ? | 13:16 |
| patchbot | patch 264257 - ironic-inspector - Adding InfiniBand Support | 13:16 |
| aarefiev | moshele: in my review list, dtantsur is on pto | 13:17 |
| moshele | aarefiev:thanks :) | 13:18 |
| lucasagomes | vdrok, left a comment in the review | 13:18 |
| vdrok | lucasagomes: yup, thanks | 13:18 |
| jroll | vdrok: lucasagomes: yeah, I'm fine with it, at least it's tested | 13:19 |
| * jroll +2 | 13:19 | |
| vdrok | jroll: thanks for review :) | 13:20 |
| *** trown|outtypewww is now known as trown | 13:20 | |
| jroll | yep, thanks for fixing that patch up! | 13:20 |
| *** ohamada_ has joined #openstack-ironic | 13:20 | |
| *** jcoufal has joined #openstack-ironic | 13:20 | |
| *** ohamada has quit IRC | 13:20 | |
| *** ohamada__ has joined #openstack-ironic | 13:20 | |
| lucasagomes | ok +a then | 13:21 |
| jroll | cool | 13:21 |
| lucasagomes | lets land it quickly since the fix landed yesterday | 13:21 |
| vdrok | lucasagomes: you're fast :) fixing the nit in the followup then | 13:21 |
| lucasagomes | vdrok, just a typo | 13:22 |
| jroll | oh that's a fun fix | 13:22 |
| lucasagomes | vdrok, I can revoke the +a | 13:22 |
| lucasagomes | vdrok, are you going to put the patch-set now ? | 13:23 |
| vdrok | lucasagomes: yup, just one letter change | 13:23 |
| lucasagomes | vdrok, ok done | 13:23 |
| lucasagomes | -a | 13:23 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add test to ensure policy is always authorized https://review.openstack.org/350177 | 13:23 |
| vdrok | updated ^ | 13:24 |
| jroll | +A | 13:24 |
| jroll | shoulda left the nit for someone to get ATC later | 13:25 |
| *** ohamada_ has quit IRC | 13:25 | |
| jroll | >.> :D | 13:25 |
| vdrok | :) | 13:25 |
| *** ccamacho is now known as ccamacho|lunch | 13:28 | |
| openstackgerrit | Merged openstack/ironic: Add test to ensure policy is always authorized https://review.openstack.org/350177 | 13:39 |
| *** amoralej is now known as amoralej|lunch | 13:43 | |
| *** jheroux has joined #openstack-ironic | 13:45 | |
| *** ccamacho|lunch is now known as ccamacho | 13:46 | |
| TheJulia | Good morning | 13:50 |
| jroll | morning TheJulia :) | 13:51 |
| *** bfournie has joined #openstack-ironic | 13:52 | |
| * TheJulia wishes she was someplace warm, like florida or maui | 13:57 | |
| jroll | so ^C on ironic-conductor doesn't shut down the conductor correctly... that seems wrong | 13:57 |
| jroll | right? | 13:58 |
| jroll | TheJulia: sounds perfect right now | 13:58 |
| TheJulia | jroll: that does sound wrong... | 13:59 |
| TheJulia | on both counts... I think ;) | 13:59 |
| jroll | heh | 13:59 |
| *** rbudden has joined #openstack-ironic | 14:01 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: WIP: Register/unregister hardware interfaces for conductors https://review.openstack.org/412631 | 14:02 |
| jroll | this also feels wrong but it works ^ | 14:02 |
| * jroll stares at it for a bit hoping to improve it | 14:02 | |
| jroll | maybe is fine | 14:05 |
| vdrok | jroll yeah, you have to send sigint to unregister conductor properly | 14:05 |
| jroll | vdrok: that feels wrong :) | 14:05 |
| openstackgerrit | Merged openstack/bifrost: Improve bifrost inventory module https://review.openstack.org/409135 | 14:07 |
| jroll | thanks for the tip though | 14:07 |
| *** rloo has joined #openstack-ironic | 14:07 | |
| *** mtanino has quit IRC | 14:08 | |
| TheJulia | jroll: just glancing at that, would we have to touch that code whenever we add another interface? | 14:09 |
| jroll | TheJulia: shouldn't, why? | 14:09 |
| jroll | that's why I iterate over driver_base.ALL_INTERFACES | 14:10 |
| jroll | (which we already must touch when we add interfaces) | 14:10 |
| TheJulia | oh, so thats where interfaces comes from, for some reason I didn't see it in taht | 14:10 |
| vdrok | and morning TheJulia | 14:10 |
| TheJulia | Good morning vdrok | 14:10 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: WIP: Register/unregister hardware interfaces for conductors https://review.openstack.org/412631 | 14:10 |
| jroll | ah yeah, no worries | 14:11 |
| TheJulia | jroll: I'm just thinking through it because the pain of adding interfaces... well... it is painful | 14:11 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM: Test patch to verify bond https://review.openstack.org/388660 | 14:11 |
| jroll | TheJulia: indeed :/ | 14:14 |
| jroll | vdrok: hrm, 2016-12-20 14:10:01.500 INFO oslo_service.service [-] Caught SIGINT signal, instantaneous exiting | 14:14 |
| jroll | I think it's a different signal | 14:14 |
| * jroll looks at oslo.service | 14:14 | |
| vdrok | maybe sigterm | 14:14 |
| jroll | ah we want SIGTERM | 14:15 |
| jroll | yeah | 14:15 |
| openstackgerrit | Vadim Hmyrov proposed openstack/python-ironicclient: Simplify heading capitalization in shell's HelpFormatter. https://review.openstack.org/413105 | 14:15 |
| jroll | yeah, term works | 14:16 |
| *** chlong has quit IRC | 14:16 | |
| *** Goneri has joined #openstack-ironic | 14:17 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: WIP: Register/unregister hardware interfaces for conductors https://review.openstack.org/412631 | 14:18 |
| *** baoli has joined #openstack-ironic | 14:18 | |
| *** godp1301 has joined #openstack-ironic | 14:19 | |
| *** baoli has quit IRC | 14:19 | |
| *** baoli has joined #openstack-ironic | 14:19 | |
| openstackgerrit | Andre Aranha proposed openstack/python-oneviewclient: Added validation for local_link_connection https://review.openstack.org/377103 | 14:21 |
| *** cdearborn has joined #openstack-ironic | 14:22 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add API reference for portgroup's mode and properties https://review.openstack.org/413108 | 14:23 |
| *** pcaruana has quit IRC | 14:23 | |
| *** Sudhir_ has joined #openstack-ironic | 14:30 | |
| *** links has quit IRC | 14:32 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Fix oslo_log complaining about deploy_utils https://review.openstack.org/413113 | 14:32 |
| nicodemos | TheJulia, vdrok: https://review.openstack.org/#/c/340596/ OneView CI success =D | 14:36 |
| patchbot | patch 340596 - ironic - Onetime boot when set_boot_device isn't persistent | 14:36 |
| *** pcaruana has joined #openstack-ironic | 14:37 | |
| *** priteau has quit IRC | 14:37 | |
| *** godp1301_ has joined #openstack-ironic | 14:37 | |
| *** godp1301 has quit IRC | 14:40 | |
| *** Sudhir_ has quit IRC | 14:44 | |
| *** moshele has quit IRC | 14:48 | |
| *** jaosorior has quit IRC | 14:48 | |
| *** hoangcx has quit IRC | 15:02 | |
| *** amoralej|lunch is now known as amoralej | 15:02 | |
| TheJulia | nicodemos: \o/ | 15:05 |
| *** rbartal has quit IRC | 15:07 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Add support of remote logging https://review.openstack.org/410247 | 15:09 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Log warning if no property for (Un)Set commands https://review.openstack.org/411486 | 15:10 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: WIP: Register/unregister hardware interfaces for conductors https://review.openstack.org/412631 | 15:14 |
| jroll | whee | 15:14 |
| * jroll steps away for a bit | 15:14 | |
| *** fxpester has quit IRC | 15:22 | |
| pas-ha | small image bomb :) http://i.imgur.com/Xpok31V.png | 15:25 |
| sergek | 👍 | 15:26 |
| *** dprince has quit IRC | 15:31 | |
| *** mtanino has joined #openstack-ironic | 15:32 | |
| lucasagomes | pas-ha, hah wow | 15:36 |
| *** godp1301 has joined #openstack-ironic | 15:36 | |
| *** godp1301_ has quit IRC | 15:40 | |
| mariojv | was something wrong intermittently with the gate this morning? | 15:41 |
| mariojv | https://review.openstack.org/#/c/356541/32 passed after ~4 rechecks and is in the process of merging | 15:42 |
| patchbot | patch 356541 - ironic - Add ironic resources CRUD notifications | 15:42 |
| mariojv | https://review.openstack.org/#/c/404239/9..10 is failing and passed on a previous patchset with minimal changes between the two | 15:42 |
| patchbot | patch 404239 - ironic - Add Virtual Network Interface RPC APIs | 15:42 |
| mariojv | seems like randomish timeouts | 15:42 |
| *** galyna has left #openstack-ironic | 15:45 | |
| *** snecklifter has quit IRC | 15:45 | |
| *** rbartal has joined #openstack-ironic | 15:48 | |
| *** harlowja has joined #openstack-ironic | 15:49 | |
| *** chlong has joined #openstack-ironic | 15:53 | |
| *** [1]cdearborn has joined #openstack-ironic | 15:55 | |
| rloo | mariojv: yeah, i wondered too but i didn't look into them | 15:57 |
| rloo | pas-ha: you going to submit an rfe/spec to automate troubleshooting? :) | 15:58 |
| rloo | hi and good morning everyone, pas-ha, mariojv, sergek, lucasagomes, jroll, TheJulia, vdrok, nicodemos | 15:59 |
| mariojv | good morning | 15:59 |
| *** chas has joined #openstack-ironic | 15:59 | |
| nicodemos | rloo :) | 15:59 |
| lucasagomes | rloo, hello there! morning | 15:59 |
| jroll | hey rloo | 16:01 |
| jroll | mariojv: yeah, I feel like I saw something about that but didn't dig | 16:01 |
| *** tuan_luong has joined #openstack-ironic | 16:01 | |
| *** chlong has quit IRC | 16:01 | |
| *** baoli has quit IRC | 16:03 | |
| *** Syed__ has joined #openstack-ironic | 16:03 | |
| *** baoli has joined #openstack-ironic | 16:06 | |
| mariojv | looks like something might be wrong with interactions between the scheduler and our compute, not sure what yet | 16:10 |
| *** cdearborn has quit IRC | 16:10 | |
| mariojv | http://logs.openstack.org/41/356541/32/check/gate-tempest-dsvm-ironic-ipa-partition-agent_ipmitool-tinyipa-ubuntu-xenial/6f09c37/logs/screen-n-sch.txt.gz | 16:10 |
| NobodyCam | Good Morning Ironic'ers | 16:10 |
| *** snecklifter has joined #openstack-ironic | 16:11 | |
| jroll | hrm | 16:14 |
| jroll | morning NobodyCam | 16:14 |
| NobodyCam | Morning jroll :) | 16:14 |
| *** soliosg has joined #openstack-ironic | 16:15 | |
| jroll | mariojv: I feel like that's an intermittent unrelated thing that comes up sometimes | 16:15 |
| jroll | it seems like the things that time out are within like 30s, I wonder if we broke something somewhere | 16:15 |
| mariojv | not sure | 16:15 |
| mariojv | that happens soon after the compute issues this warning | 16:15 |
| jroll | in CI config or what have you | 16:15 |
| mariojv | "Failed to update inventory for resource provider fe0d165d-0f8d-43a5-a721-5f5781a4c5c6: 400 400 Bad Request | 16:15 |
| patchbot | Error: No closing quotation | 16:16 |
| mariojv | The server could not comply with the request since it is either malformed or otherwise incorrect. | 16:16 |
| mariojv | could be unrelated | 16:16 |
| jroll | hrm | 16:16 |
| *** chlong has joined #openstack-ironic | 16:17 | |
| nicodemos | morning, NobodyCam | 16:18 |
| NobodyCam | morning nicodemus :) | 16:18 |
| NobodyCam | happy not monday | 16:19 |
| mariojv | yuriyz: check out the ironic api logs for when CI passed: http://logs.openstack.org/41/356541/32/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-ubuntu-xenial/70545ad/logs/screen-ir-api.txt.gz | 16:19 |
| mariojv | yuriyz: lots of warnings about failing to send notifications because of missing node fields | 16:20 |
| jroll | ooo, that error in n-sch is during a build, I see | 16:22 |
| mariojv | yeah | 16:22 |
| mariojv | yuriyz: seems like the .end notifications are being sent OK at least, or we'd be seeing that same warning for .end as well | 16:22 |
| jroll | I see this but it's for cells https://github.com/openstack/nova/commit/784db5a1d73a304562404dd895f15da8963528aa | 16:22 |
| jroll | looks like maybe similar bug here | 16:23 |
| mariojv | hm | 16:23 |
| *** dyasny has joined #openstack-ironic | 16:23 | |
| jroll | maybe triggered by enabling the placement engine? | 16:23 |
| mariojv | there's an error about a missing "host" field before the instance gets deleted as well | 16:23 |
| jlvillal | Good morning Ironic :) | 16:25 |
| jlvillal | https://review.openstack.org/#/c/406376/ could use some reviews. One of our patches in work to get multi-node testing working. | 16:25 |
| patchbot | patch 406376 - ironic - Configure tempest for multitenancy/flat network | 16:25 |
| *** tuan_luong has quit IRC | 16:26 | |
| *** fragatina has joined #openstack-ironic | 16:26 | |
| mariojv | yuriyz: i'm betting that this happens because of the way populate_schema works in relation to objects that aren't instantiated in the db with all its fields yet | 16:26 |
| rloo | mariojv: haven't scrolled back -- I had +A'd the CRUD notifications; looks like I should remove that? | 16:27 |
| mariojv | yuriyz: at L1438 here, that node only has fields passed through the request body and attached by ironic during the POST: https://review.openstack.org/#/c/356541/32/ironic/api/controllers/v1/node.py | 16:27 |
| patchbot | patch 356541 - ironic - Add ironic resources CRUD notifications | 16:27 |
| mariojv | rloo: yeah, .start create notifications won't work | 16:28 |
| *** baoli has quit IRC | 16:28 | |
| rloo | mariojv: did they ever work then? | 16:28 |
| *** chlong has quit IRC | 16:28 | |
| mariojv | rloo: afaict CRUD .start notifications haven't worked, existing power state notifications should be good | 16:28 |
| mariojv | this is something that would only happen at the API level | 16:29 |
| *** MattMan has quit IRC | 16:29 | |
| *** MattMan has joined #openstack-ironic | 16:29 | |
| rloo | mariojv: yeah, so all the CRUD stuff | 16:29 |
| rloo | mariojv: maybe only the CR stuff. | 16:30 |
| mariojv | yeah, i think update/delete should be good | 16:30 |
| mariojv | i think one solution would be to change populate_schema to set payload fields to null if they're missing | 16:31 |
| mariojv | None rather | 16:31 |
| rloo | mariojv: yup, None. | 16:31 |
| mariojv | otherwise, we'd have to send .start after the node's in the db | 16:32 |
| rloo | mariojv: so close... i was hoping to get those patches merged soon... | 16:32 |
| mariojv | essentially after creation's done | 16:32 |
| rloo | mariojv: doesn't make sense to send the .start *after* it is in the db | 16:32 |
| mariojv | yeah | 16:32 |
| rloo | mariojv: that fix can be a separate patch from the CRUD stuff. | 16:34 |
| mariojv | i'll take a look at it today, shouldn't be a lot of code | 16:36 |
| rloo | yuriyz: ^^ | 16:41 |
| *** harlowja has quit IRC | 16:42 | |
| *** chlong has joined #openstack-ironic | 16:42 | |
| TheJulia | So, I was never really in support of re-doing the pxe/ipxe stuffs until I stuck my brain into this morning | 16:43 |
| jroll | mariojv: seems it isn't just us: http://bit.ly/2h8n0hI | 16:45 |
| jroll | I would think I would have heard something if this was breaking the world so hard | 16:45 |
| TheJulia | It is also approaching a holiday for a good chunk of those involved | 16:47 |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: [WIP]Reboot and Poweroff fails with coreos IPA image https://review.openstack.org/412594 | 16:47 |
| mariojv | rloo: yuriyz: filed bug for the notification issue here for tracking in case the fix doesn't land before i'm on pto: https://bugs.launchpad.net/ironic/+bug/1651517 | 16:49 |
| openstack | Launchpad bug 1651517 in Ironic "Sending notifications always fails when payload fields are missing" [Undecided,New] - Assigned to Mario Villaplana (mario-villaplana-j) | 16:49 |
| rloo | thx mariojv. I added comments to https://review.openstack.org/#/c/356541/ | 16:50 |
| *** jpich has quit IRC | 16:50 | |
| patchbot | patch 356541 - ironic - Add ironic resources CRUD notifications | 16:50 |
| rloo | mariojv: it is questionable as to whether it is a bug or not, and I don't care as long as it is fixed. (Ie, the code is right for what it was intended for, but now we're using it in a diff way...) | 16:51 |
| mariojv | yeah, just a case we didn't think about i suppose | 16:52 |
| * mariojv brb | 16:52 | |
| *** aarefiev has quit IRC | 16:53 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM: Test patch to verify bond https://review.openstack.org/388660 | 16:53 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: Ironic devstack portgroup support https://review.openstack.org/381743 | 16:53 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 | 16:53 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: Allow to attach/deatach vif to portgroup https://review.openstack.org/406915 | 16:53 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Tempest tests for portgroups https://review.openstack.org/382476 | 16:53 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface RPC APIs https://review.openstack.org/404239 | 16:53 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface Driver APIs https://review.openstack.org/327046 | 16:53 |
| *** igordcard has joined #openstack-ironic | 16:56 | |
| *** igordcard has quit IRC | 16:56 | |
| *** ohamada__ has quit IRC | 16:58 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM: Test patch to verify bond https://review.openstack.org/388660 | 16:58 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: Ironic devstack portgroup support https://review.openstack.org/381743 | 16:58 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 | 16:58 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: Allow to attach/deatach vif to portgroup https://review.openstack.org/406915 | 16:58 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Tempest tests for portgroups https://review.openstack.org/382476 | 16:58 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface RPC APIs https://review.openstack.org/404239 | 16:58 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface Driver APIs https://review.openstack.org/327046 | 16:58 |
| *** igordcard has joined #openstack-ironic | 16:58 | |
| *** igordcard has quit IRC | 16:58 | |
| * jroll needs lunch | 16:59 | |
| *** igordcard has joined #openstack-ironic | 16:59 | |
| *** igordcard has quit IRC | 16:59 | |
| *** fragatina has quit IRC | 16:59 | |
| *** fragatina has joined #openstack-ironic | 17:00 | |
| *** igordcard has joined #openstack-ironic | 17:00 | |
| vsaienk0 | rloo I've just submitted a new version of attach/detach please have look once you have a time | 17:01 |
| *** igordcard has quit IRC | 17:01 | |
| rloo | vsaienk0: thx! will look in a few minutes. | 17:01 |
| *** igordcard has joined #openstack-ironic | 17:02 | |
| *** Guest14972 has quit IRC | 17:03 | |
| *** e0ne has quit IRC | 17:08 | |
| *** dyasny has quit IRC | 17:11 | |
| *** aNuposic has joined #openstack-ironic | 17:11 | |
| lucasagomes | folks, I'm out for today! Have a great evening all | 17:18 |
| *** lucasagomes is now known as lucas-afk | 17:18 | |
| jlvillal | lucas-afk: Bye | 17:20 |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Add portgroup support to osc plugin https://review.openstack.org/362130 | 17:20 |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Add interface attach/detach support https://review.openstack.org/364420 | 17:20 |
| NobodyCam | night lucas-afk | 17:20 |
| jlvillal | jroll: Question on the tempest plugin. Do you think that maybe it should be in it's own repository? openstack/ironic-tempest ? | 17:24 |
| jlvillal | jroll: Only reason I was thinking that is that tempest has no stable branches. But openstack/ironic does. | 17:25 |
| jlvillal | I don't know all the pros/cons to each method though. | 17:25 |
| *** aNuposic has quit IRC | 17:27 | |
| pas-ha | jlvillal: https://review.openstack.org/#/q/project:openstack/ironic-tempest-plugin | 17:29 |
| pas-ha | there is one, but is empty for now | 17:29 |
| jlvillal | pas-ha: Ah, thanks! | 17:29 |
| * jlvillal wonders what the plan is for that. | 17:29 | |
| pas-ha | owned by ironic-core https://review.openstack.org/#/admin/projects/openstack/ironic-tempest-plugin,access so we should get going moving the tempest stuff there | 17:30 |
| jlvillal | Yeah, maybe | 17:31 |
| * pas-ha heads off, have a nice rest of the day all | 17:31 | |
| jlvillal | pas-ha: paka paka | 17:32 |
| *** baoli has joined #openstack-ironic | 17:33 | |
| openstackgerrit | Joanna Taryma proposed openstack/ironic: Fixed allowing non-uuids as node UUID for port and portgroup. https://review.openstack.org/403910 | 17:34 |
| *** trown is now known as trown|lunch | 17:41 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Functional tests for port groups in ironicclient https://review.openstack.org/297727 | 17:42 |
| *** dprince has joined #openstack-ironic | 17:46 | |
| *** harlowja has joined #openstack-ironic | 17:53 | |
| *** derekh has quit IRC | 17:55 | |
| *** pcaruana has quit IRC | 17:59 | |
| *** rbartal has quit IRC | 18:03 | |
| *** Romanenko_K has quit IRC | 18:04 | |
| *** godp1301_ has joined #openstack-ironic | 18:05 | |
| *** godp1301 has quit IRC | 18:09 | |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: Auto-set nullable notification payload fields when needed https://review.openstack.org/413197 | 18:10 |
| mariojv | rloo: yuriyz: that should fix the issue i discovered with the .start notifications ^ | 18:10 |
| rloo | mariojv: thx, looking... | 18:10 |
| *** MattMan has left #openstack-ironic | 18:26 | |
| *** ccamacho has quit IRC | 18:27 | |
| *** MattMan has joined #openstack-ironic | 18:28 | |
| mariojv | jlvillal: i think you're right about L156 here: https://review.openstack.org/#/c/413197/1/ironic/objects/notification.py | 18:28 |
| patchbot | patch 413197 - ironic - Auto-set nullable notification payload fields when... | 18:28 |
| *** ccamacho has joined #openstack-ironic | 18:28 | |
| *** Goneri has quit IRC | 18:28 | |
| mariojv | i think the only exception that line can raise is AttributeError | 18:28 |
| jlvillal | mariojv: I just don't like: "except Exception:" since it catches everything... | 18:29 |
| jlvillal | mariojv: So I vote for more granularity | 18:29 |
| *** rcernin has quit IRC | 18:29 | |
| mariojv | actually, apparently it raises NotImplementedError in oslo | 18:30 |
| jlvillal | mariojv: Are there any unit tests for: https://github.com/openstack/ironic/blob/master/ironic/objects/node.py#L405-L470 ? | 18:36 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: Auto-set nullable notification payload fields when needed https://review.openstack.org/413197 | 18:38 |
| *** athomas has quit IRC | 18:38 | |
| mariojv | jlvillal: doesn't appear so | 18:38 |
| jlvillal | mariojv: I guess I was wondering, what verifies that SCHEMA and field match up? I think they are supposed to align | 18:39 |
| *** amoralej is now known as amoralej|off | 18:40 | |
| mariojv | jlvillal: yeah, there's no real testing around that, you're right | 18:42 |
| mariojv | jlvillal: they don't necessarily have to align; SCHEMA defines fields that you want to auto-populate from some object | 18:42 |
| mariojv | i.e. there can be fields that aren't in SCHEMA | 18:43 |
| mariojv | it wouldn't make sense for there to be things in SCHEMA that aren't in fields though | 18:43 |
| jlvillal | mariojv: Okay. I guess I think there should be some sort of test to catch errors from future changes. | 18:43 |
| mariojv | yeah, i agree | 18:44 |
| jlvillal | mariojv: Now are there any fields which are not in SCHEMA right now? | 18:44 |
| mariojv | yeah, just two to my knowledge | 18:44 |
| mariojv | here: https://github.com/openstack/ironic/blob/e05e0609641b7706682be1fc59bd89ef998755bb/ironic/objects/node.py#L532 | 18:44 |
| mariojv | and L496 | 18:44 |
| mariojv | https://github.com/openstack/ironic/blob/e05e0609641b7706682be1fc59bd89ef998755bb/ironic/objects/node.py#L496 | 18:45 |
| jlvillal | mariojv: Ah, thanks. | 18:45 |
| mariojv | np | 18:45 |
| jlvillal | mariojv: But in the NodePayload class itself? | 18:46 |
| mariojv | nope, nothing in NodePayload | 18:46 |
| jlvillal | mariojv: Just thinking, could add a test in there that says they must match up, with a comment that if not the case they should remove this check. Unsure if good idea or not. | 18:47 |
| jlvillal | mariojv: And in NotificationPayloadBase() maybe a check in __init__. Still unsure if good idea. | 18:48 |
| jlvillal | mariojv: I'm full of ideas that I'm not sure about :) | 18:48 |
| mariojv | jlvillal: so just check everything in SCHEMA is also in fields? that seems reasonable | 18:49 |
| mariojv | the other way around, i'm not sure is a good idea | 18:49 |
| jlvillal | mariojv: Okay. | 18:50 |
| *** godp1301_ has quit IRC | 18:53 | |
| *** chlong has quit IRC | 18:56 | |
| *** fragatina has quit IRC | 19:05 | |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: Add a NodePayload test https://review.openstack.org/413207 | 19:09 |
| mariojv | jlvillal: ^ added that test | 19:09 |
| mariojv | looking at NodePayload again, i don't think that https://review.openstack.org/#/c/413197/ will be enough to fix the api create .start notifications :/ | 19:10 |
| patchbot | patch 413197 - ironic - Auto-set nullable notification payload fields when... | 19:10 |
| *** Sukhdev has joined #openstack-ironic | 19:12 | |
| mariojv | unless BooleanField has a default that gets auto-populated by default | 19:12 |
| mariojv | since some of the NodePayload fields aren't nullable: https://github.com/openstack/ironic/blob/e05e0609641b7706682be1fc59bd89ef998755bb/ironic/objects/node.py#L448 | 19:12 |
| *** chlong has joined #openstack-ironic | 19:13 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: [WIP / POC] Add Intel Node Manager sensor data collection https://review.openstack.org/410465 | 19:13 |
| *** rbudden_ has joined #openstack-ironic | 19:15 | |
| *** rbudden has quit IRC | 19:16 | |
| *** rbudden_ is now known as rbudden | 19:16 | |
| jlvillal | mariojv: Thanks. Though now I'm more confused on what the layout of SCHEMA is. | 19:17 |
| mariojv | jlvillal: this might explain it better: http://docs.openstack.org/developer/ironic/dev/notifications.html#adding-a-new-notification-to-ironic | 19:18 |
| jlvillal | mariojv: From quick glance it seems like every field is: name: ('node', name) Which makes me wonder about the value of it. | 19:18 |
| mariojv | jlvillal: it's "name_in_payload_field": ("name_of_object": "name_of_field_in_object") | 19:19 |
| mariojv | so if i wanted something to show up in the payload as "node_name" instead of just "name" | 19:19 |
| mariojv | i could do this | 19:19 |
| mariojv | "node_name": ("node", "name") | 19:19 |
| jlvillal | mariojv: If bored, maybe that could be a comment in the code. And maybe use a named_tuple :) | 19:20 |
| jlvillal | mariojv: Thanks for the explanation | 19:20 |
| *** trown|lunch is now known as trown | 19:24 | |
| mariojv | np | 19:28 |
| mariojv | yuriyz: i'm pretty sure a couple additional things have to be done in https://review.openstack.org/#/c/356541 after fix for https://bugs.launchpad.net/ironic/+bug/1651517 lands, left a comment there | 19:29 |
| openstack | Launchpad bug 1651517 in Ironic "Sending notifications always fails when payload fields are missing" [Undecided,In progress] - Assigned to Mario Villaplana (mario-villaplana-j) | 19:29 |
| patchbot | patch 356541 - ironic - Add ironic resources CRUD notifications | 19:29 |
| *** jkilpatr has quit IRC | 19:30 | |
| *** harlowja has quit IRC | 19:35 | |
| *** nicodemos has quit IRC | 19:37 | |
| *** nicodemos has joined #openstack-ironic | 19:37 | |
| *** godp1301 has joined #openstack-ironic | 19:37 | |
| jroll | jlvillal: yes, I started down the path of moving the plugin to separate repos, but was waiting for after the tempest patch dropping our code to merge before continuing | 19:38 |
| jlvillal | jroll: Ah cool. You are a few steps ahead of me :) | 19:39 |
| *** jkilpatr has joined #openstack-ironic | 19:39 | |
| *** godp1301_ has joined #openstack-ironic | 19:39 | |
| *** godp1301 has quit IRC | 19:41 | |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: [WIP]Reboot and Poweroff fails with coreos IPA image https://review.openstack.org/412594 | 19:43 |
| rloo | mariojv: i don't understand the code/fix: https://review.openstack.org/#/c/413197/2/ironic/tests/unit/objects/test_notification.py | 19:51 |
| patchbot | patch 413197 - ironic - Auto-set nullable notification payload fields when... | 19:52 |
| rloo | mariojv: L29 - fake_field_2 is nullable | 19:52 |
| rloo | mariojv: L234, why does it fail? | 19:52 |
| *** godp1301_ has quit IRC | 19:52 | |
| mariojv | rloo: L29 - fake_field_2 is nullable in the object, so i can create a TestObject without fake_field_2 | 19:54 |
| mariojv | L43 - fake_field_b is *not* nullable in the payload, and is required there | 19:54 |
| rloo | mariojv: oh, ugh. | 19:55 |
| mariojv | L234 - fails because test_obj doesn't have fake_field_2 which is necessary to populate fake_field_b | 19:55 |
| mariojv | maybe i should name these things better >_> | 19:55 |
| rloo | mariojv: sigh. | 19:56 |
| mariojv | rloo: would a comment for test_populate_schema_missing_required_obj_field help you think? | 19:57 |
| rloo | mariojv: so yuriyz emits the .start *after* he gets an Object. | 19:57 |
| rloo | mariojv: no, well maybe. it is really the payload class & what nullable means there, that tripped me | 19:58 |
| mariojv | right - a Node object, which hasn't been created in the DB, and is missing fields that the DB auto-populates for you later | 19:58 |
| mariojv | so getattr(node, 'db_populated_field') raises NotImplementedError when populating the payload, creating payload fails | 19:59 |
| mariojv | now, with that patch, populate_schema will see that the payload field is nullable and set the payload field to None automatically | 19:59 |
| mariojv | yuriyz also has to make the other NodePayload fields that might be missing before the DB creation nullable | 19:59 |
| mariojv | after that, everything should work | 20:00 |
| rloo | mariojv: right. | 20:00 |
| openstackgerrit | Andre Aranha proposed openstack/ironic: Added validation for local_link_connection https://review.openstack.org/377106 | 20:01 |
| *** ChubYann has joined #openstack-ironic | 20:08 | |
| *** clenimar has quit IRC | 20:12 | |
| *** fragatina has joined #openstack-ironic | 20:12 | |
| *** Goneri has joined #openstack-ironic | 20:14 | |
| *** chlong has quit IRC | 20:15 | |
| *** fragatina has quit IRC | 20:22 | |
| *** fragatina has joined #openstack-ironic | 20:23 | |
| *** aNuposic has joined #openstack-ironic | 20:25 | |
| *** cdaniel has quit IRC | 20:26 | |
| *** chlong has joined #openstack-ironic | 20:27 | |
| *** dyasny has joined #openstack-ironic | 20:35 | |
| *** e0ne has joined #openstack-ironic | 20:36 | |
| rloo | mariojv: want to just check wrt https://review.openstack.org/#/c/397812/. there is no explicit field that specifies the console setting; the assumption is that it is the value in the node's console_enabled. Which seems to be a bit diff from the power_set that has a 'to_power' field in the payload. is that good with you? | 20:36 |
| patchbot | patch 397812 - ironic - Add node console notifications | 20:36 |
| mariojv | rloo: yeah, i was fine with it since console_enabled is just true/false | 20:38 |
| mariojv | rloo: power can be "reboot" too, so i think to_power was necessary there to avoid ambiguity | 20:38 |
| rloo | mariojv: ok | 20:39 |
| *** zhs__ has quit IRC | 20:39 | |
| *** zhs__ has joined #openstack-ironic | 20:40 | |
| rloo | mariojv: i'll add a comment, but the problem with that, is you could have a node.console_enabled=True, and the user could try to set it to True. We do a .start, and the conductor will just return w/o doing anything except logging that nothing was done. | 20:42 |
| *** fragatina has quit IRC | 20:43 | |
| mariojv | rloo: i don't think that's possible, there's a check before the action gets passed to the driver: https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1688 | 20:48 |
| rloo | mariojv: i just realized, i've forgotten where the .start is emitted. can't keep all these patches straight any more. | 20:49 |
| mariojv | they're all pretty tricky :) | 20:49 |
| rloo | mariojv: I'm at the point where I want to just +A them so I can forget. | 20:49 |
| mariojv | rloo: console_set.start happens in the task spawned after the check: https://review.openstack.org/#/c/397812/16/ironic/conductor/manager.py | 20:50 |
| patchbot | patch 397812 - ironic - Add node console notifications | 20:50 |
| mariojv | .start/.end don't happen if console's already in the requested state | 20:50 |
| *** Sukhdev has quit IRC | 20:50 | |
| rloo | mariojv: then it is ok. am going to look at that patch soon... | 20:50 |
| *** romcheg has quit IRC | 20:54 | |
| *** romcheg has joined #openstack-ironic | 20:57 | |
| *** e0ne has quit IRC | 20:57 | |
| *** dsneddon_ has joined #openstack-ironic | 21:01 | |
| *** aNuposic has quit IRC | 21:01 | |
| *** godp1301 has joined #openstack-ironic | 21:02 | |
| *** fragatina has joined #openstack-ironic | 21:08 | |
| *** zhs_ has joined #openstack-ironic | 21:10 | |
| *** zhs__ has quit IRC | 21:11 | |
| *** jcoufal has quit IRC | 21:11 | |
| *** mtanino has quit IRC | 21:13 | |
| *** jkilpatr has quit IRC | 21:14 | |
| *** godp1301_ has joined #openstack-ironic | 21:16 | |
| *** cdearborn has joined #openstack-ironic | 21:16 | |
| *** mrtenio has quit IRC | 21:17 | |
| *** godp1301 has quit IRC | 21:19 | |
| mrda | Morning all | 21:21 |
| *** mrda is now known as michaeld | 21:22 | |
| *** michaeld is now known as mrda | 21:24 | |
| rloo | morning mrda, michaeld, and mrda | 21:25 |
| mrda | lol, morning rloo! | 21:29 |
| *** fragatina has quit IRC | 21:30 | |
| *** [1]cdearborn has quit IRC | 21:30 | |
| *** moshele has joined #openstack-ironic | 21:31 | |
| *** jkilpatr has joined #openstack-ironic | 21:33 | |
| *** moshele has quit IRC | 21:35 | |
| *** cdearborn has quit IRC | 21:37 | |
| *** chlong has quit IRC | 21:46 | |
| *** dprince has quit IRC | 21:48 | |
| *** nicodemos has quit IRC | 21:49 | |
| *** nicodemos has joined #openstack-ironic | 21:49 | |
| *** dyasny has quit IRC | 21:51 | |
| rloo | mariojv: nova encountered a similar issue: http://lists.openstack.org/pipermail/openstack-dev/2016-December/109086.html | 21:52 |
| *** godp1301_ has quit IRC | 21:56 | |
| jlvillal | rloo: Nice find | 21:58 |
| rloo | jlvillal: coincidence! | 21:58 |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: [WIP]Reboot and Poweroff fails with coreos IPA image https://review.openstack.org/412594 | 22:02 |
| mrda | jlvillal: Just took a quick look, no updates on Nova Ironic bugs since 2016-11-14, so I think there's nothing to be done this week | 22:07 |
| jlvillal | mrda: Sweet :) Thanks. | 22:07 |
| jlvillal | mrda: And I will be on vacation next week | 22:08 |
| mrda | jlvillal: So Merry Christmas! And have a lovely new year! | 22:08 |
| jlvillal | mrda: Thanks you too. | 22:08 |
| *** trown is now known as trown|outtypewww | 22:10 | |
| *** Sukhdev has joined #openstack-ironic | 22:10 | |
| *** jheroux has quit IRC | 22:12 | |
| *** wajdi has quit IRC | 22:13 | |
| rloo | TheJulia: you around? https://review.openstack.org/#/c/348005/. You want me to +A and then followup patch, or do you want to address now? | 22:15 |
| patchbot | patch 348005 - ironic - Add storage_interface DB field | 22:15 |
| TheJulia | rloo: looking, I've been head down in the ipxe code | 22:15 |
| rloo | TheJulia: no worries, it isn't urgent (at least not for me :)) | 22:16 |
| TheJulia | rloo: I'd prefer to fix it upon a rebase in a day or so | 22:17 |
| rloo | TheJulia: you mean while rebasing that patch? (so i won't +A now?) | 22:17 |
| TheJulia | yeah, I'll rebase the whole chain and revisions as I go | 22:18 |
| rloo | TheJulia: OK | 22:18 |
| *** mtanino has joined #openstack-ironic | 22:21 | |
| *** fragatina has joined #openstack-ironic | 22:23 | |
| *** mtanino has quit IRC | 22:29 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic-specs: Intel Node Manager sensor collection support https://review.openstack.org/413249 | 22:29 |
| *** vinsh has quit IRC | 22:35 | |
| *** Sukhdev has quit IRC | 22:36 | |
| *** Sukhdev has joined #openstack-ironic | 22:38 | |
| *** nicodemos has quit IRC | 22:39 | |
| *** nicodemos has joined #openstack-ironic | 22:40 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic-specs: Intel Node Manager sensor collection support https://review.openstack.org/413249 | 22:41 |
| *** ricardoas has quit IRC | 22:41 | |
| openstackgerrit | Merged openstack/ironic-python-agent: add CONTRIBUTING.rst https://review.openstack.org/412859 | 22:43 |
| *** fragatina has quit IRC | 22:47 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic-specs: Intel Node Manager sensor collection support https://review.openstack.org/413249 | 22:47 |
| *** chlong has joined #openstack-ironic | 22:57 | |
| *** ricardoas has joined #openstack-ironic | 22:57 | |
| *** aNuposic has joined #openstack-ironic | 22:58 | |
| *** dsneddon_ has quit IRC | 23:01 | |
| *** dsneddon has quit IRC | 23:01 | |
| *** dsneddon has joined #openstack-ironic | 23:02 | |
| *** lindycoder has joined #openstack-ironic | 23:03 | |
| *** lindycoder has quit IRC | 23:06 | |
| *** dsneddon has quit IRC | 23:13 | |
| *** dsneddon has joined #openstack-ironic | 23:14 | |
| *** rbudden has quit IRC | 23:16 | |
| *** bfournie has quit IRC | 23:19 | |
| *** Sukhdev_ has joined #openstack-ironic | 23:25 | |
| *** Sukhdev has quit IRC | 23:27 | |
| *** mtanino has joined #openstack-ironic | 23:34 | |
| *** chas has quit IRC | 23:39 | |
| *** chas has joined #openstack-ironic | 23:39 | |
| *** baoli has quit IRC | 23:45 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic: [WIP / POC] Add Intel Node Manager sensor data collection https://review.openstack.org/410465 | 23:45 |
| *** chas has quit IRC | 23:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
