| *** g3ek has quit IRC | 00:00 | |
| *** lindycoder has joined #openstack-ironic | 00:01 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 00:01 | |
| Nisha_Agarwal | TheJulia, hi | 00:02 |
|---|---|---|
| TheJulia | Hi Nisha_Agarwal | 00:03 |
| Nisha_Agarwal | Good Evening. | 00:03 |
| Nisha_Agarwal | NobodyCam, Hi | 00:05 |
| Nisha_Agarwal | I wanted to discuss with you guys on https://review.openstack.org/325230 | 00:05 |
| patchbot | patch 325230 - ironic - Add 'inspect_ports' as a 'driver_info' parameter t... | 00:05 |
| Nisha_Agarwal | We still think that the inspect_port option is required | 00:08 |
| *** g3ek has joined #openstack-ironic | 00:09 | |
| Nisha_Agarwal | the reasons being : 1. The OOB discovery has no mechanism to know which port is pxe-enabled/connected physically. | 00:09 |
| *** jcoufal has joined #openstack-ironic | 00:10 | |
| *** aslezil_ has quit IRC | 00:11 | |
| *** jcoufal has quit IRC | 00:12 | |
| Nisha_Agarwal | User has three approach to follow for above: a) He provides the connected port information manually, and then create ironic ports only for them. or b) Let ironic create all the ports and operator manually removes them. c) User provides the connected port info and ironci creates ports fr all and sets pxe_enabled flag for the ports given by user | 00:14 |
| Nisha_Agarwal | The point is that it's easier for operator to figure out which ports are intended for Ironic use. Once he/she provides this info to inspection api then everything else can be automated. On the other hand, if an operator has to manaully delete extra ports after ironic creates all the ports, it's more cubersome and may not be automated. | 00:15 |
| Nisha_Agarwal | TheJulia, ^^^^^ | 00:15 |
| Nisha_Agarwal | TheJulia, there? | 00:15 |
| Nisha_Agarwal | NobodyCam, ^^^^ | 00:16 |
| TheJulia | Nisha_Agarwal: reading | 00:18 |
| Nisha_Agarwal | TheJulia, if inspect_port option doesnt make any sense for all the drivers, we are fine to move it back to iLO drivers alone | 00:20 |
| Nisha_Agarwal | it was made generic as per community discussion | 00:21 |
| *** wanyen has joined #openstack-ironic | 00:21 | |
| TheJulia | typing... | 00:21 |
| Nisha_Agarwal | Hi wanyen | 00:21 |
| wanyen | hi | 00:21 |
| *** dprince has quit IRC | 00:22 | |
| wanyen | We are discussing inspect_port. Right? | 00:23 |
| TheJulia | An admin should, after the fact, be able to set properties. Like the B option, however the ports can still exist. They shouldn't need to know details ahead of time when the node is initially created. For what its worth, discovery is a misnomer, this is introspection, discovery is the act of finding new nodes in general. What I don't understand is why you | 00:23 |
| TheJulia | think ports _need_ to be deleted | 00:23 |
| Nisha_Agarwal | wanyen, yes | 00:23 |
| Nisha_Agarwal | TheJulia, ok. let me put myself in this manner | 00:24 |
| TheJulia | context == \o/ | 00:24 |
| Nisha_Agarwal | 1. You said Neutron driver now creates neutron port for pxe_enabled ironic ports. | 00:24 |
| Nisha_Agarwal | 2. The ironic port must have pxe_enabled flag set for it | 00:25 |
| Nisha_Agarwal | Am i correct? | 00:25 |
| wanyen | My understaning is that if unused ports are not deleted then nova may pick a port that is not working, namely no cable connected or [port is intended for storage, etc. | 00:25 |
| patchbot | Error: Missing "]". You may want to quote your arguments with double quotes in order to prevent extra brackets from being evaluated as nested commands. | 00:25 |
| TheJulia | Not exactly, that is an oversimplification | 00:25 |
| Nisha_Agarwal | TheJulia, ok could you make us understand what do u mean when u say neutron driver is pxe_aware | 00:26 |
| Nisha_Agarwal | wanyen, i also think the same. Lets see what Julia say | 00:27 |
| Nisha_Agarwal | TheJulia, there? | 00:29 |
| wanyen | qustion for pxe_enabled flag. For the non-pxe boot driver such as virtul media drivers, is pxe-enabled flag applicable? | 00:29 |
| Nisha_Agarwal | wanyen, as i read its applicable for any ironic port but the default behaviour is current behaviour without this enhancement | 00:30 |
| *** lindycoder has quit IRC | 00:30 | |
| TheJulia | Nisha_Agarwal: I didn't mean that the neutron driver is pxe aware, but you need local_link_information for it to be able to be utilized, which is not something, afaik, that you can get short of firing up the full blown inspection process and listening on the cabled ports | 00:30 |
| TheJulia | wanyen: I don't think it is necessarily applicable, however one of the ilo drivers is a pxe driver. | 00:32 |
| Nisha_Agarwal | TheJulia, then how can we have the pxe_enabled flag set? | 00:33 |
| Nisha_Agarwal | if its not through inspection | 00:33 |
| wanyen | Julia, I believe the default behavior of the inspection is going to discover all macs on the servers. However, inpsector provides an option similar to inspect_port to limit the mac discovery. | 00:34 |
| TheJulia | as I understand it, ports created have it enabled by default, the feature your advocating for is to make it default for ilo users | 00:34 |
| TheJulia | and not even that, but also just not create ports unless the slot number matches what a user identifies | 00:34 |
| TheJulia | which seems extremely unfriendly to an operator | 00:34 |
| Nisha_Agarwal | TheJulia, so we can marke the pxe_enabled flag as i mention in option 3 | 00:35 |
| Nisha_Agarwal | if that helps neutron to selct that port for creating neutron port | 00:35 |
| wanyen | Julia, I believe what we propose is consistent with inspector. Default is to inspect all macs. If the inspect_port option is provided then only inpsect that port. | 00:36 |
| TheJulia | so Nisha_Agarwal, how is a user with an ilo driver, or ilo centric environment, supposed manage their inventory in such terms of adding hundreds or thousands of new nodes? | 00:36 |
| Nisha_Agarwal | TheJulia, thats said, user provides input in inspect_port, ironic creates all ports and sets pxe_enabled flag for the inputted ports only. | 00:37 |
| Nisha_Agarwal | TheJulia, i think even though its manual step, but better than deploy failing at last | 00:37 |
| TheJulia | Except, I perceive a user as racking a server and powering it on to add to inventory. | 00:37 |
| TheJulia | you mean operator has to provide it, after just manually adding the node and credentials, and all? | 00:38 |
| wanyen | Nisha, I think by default we will inspect all ports for backward caompatibility, if inspect_port is specified then we only inspect that port. | 00:38 |
| Nisha_Agarwal | wanyen, yes true | 00:38 |
| Nisha_Agarwal | TheJulia, default behaviour will be as it is today | 00:39 |
| Nisha_Agarwal | TheJulia, it will create ironic ports for all ports by default | 00:39 |
| TheJulia | Oh, I interpretted it as only nodes pre-defined would ever be discovered via an introspection oob operation | 00:39 |
| TheJulia | err, oob introspection | 00:40 |
| *** jkilpatr has joined #openstack-ironic | 00:40 | |
| Nisha_Agarwal | if inspect_port is given then either 1) it creates ironci ports only for those ports or 2) creates ironic ports for all and sets pxe_enabled for only the inputted one(if this approach doesnt lead to deploy failure) | 00:40 |
| Nisha_Agarwal | TheJulia, if inspect_port is provided we have to follow either of above two approaches so that deploy doesnt fail | 00:42 |
| Nisha_Agarwal | TheJulia, pxe_enabled flag approach is not tested though | 00:42 |
| TheJulia | And an operator will still then need to go reconcile link information for tenant network separation, I think the existing behavior if not defined would work | 00:42 |
| wanyen | Nisha, I prefer the the 1st option that way operators don't need to manually deleted the un-intended ports. | 00:43 |
| Nisha_Agarwal | but as i understand from our discussion, neutron driver selects the ports with pxe_enabled flag set to true | 00:43 |
| Nisha_Agarwal | wanyen, even i | 00:43 |
| Nisha_Agarwal | TheJulia, on local link information, that information is manually provided or it is got by inspector during inspection | 00:44 |
| TheJulia | wanyen: but if they have to go manually delete, then they are still going to need to update the link info | 00:44 |
| Nisha_Agarwal | ? | 00:44 |
| Nisha_Agarwal | TheJulia, how do u get the link info | 00:45 |
| wanyen | for virtual media drivers such as agent-ilo or fujitsu driver, why does it need to set pxe-enabled flag? | 00:45 |
| TheJulia | Nisha_Agarwal: either, although as I understand it, it is a dictionary that is passed with multiple key/value pairs | 00:45 |
| TheJulia | translation: a pain to do by hand | 00:45 |
| Nisha_Agarwal | TheJulia, through inband it can be achieved, but oob cannot get that info and has to manually provide it | 00:45 |
| Nisha_Agarwal | TheJulia, so which option do u prefer? | 00:46 |
| Nisha_Agarwal | We will say to go by as it is implemented today | 00:47 |
| Nisha_Agarwal | if it has to be ilo specific, i can move the option back to ilo alone | 00:48 |
| Nisha_Agarwal | TheJulia, ^^^ | 00:48 |
| wanyen | Julia, for oob inspection, the current expectation is that oob inspection will inspect and create all ports but user will need to manually delete unused port to prevent nova picking the wrong port and fail the provisioning. | 00:48 |
| TheJulia | naturally, greater automation is more operator friendly | 00:48 |
| TheJulia | wanyen: s/user/operator/ correct? | 00:48 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP/DNM Testing tempest "smoke" 2 https://review.openstack.org/407258 | 00:48 |
| Nisha_Agarwal | TheJulia, wanyen i have to leave now...Please could u guys come to a conclusion | 00:49 |
| wanyen | yes. operator. | 00:49 |
| Nisha_Agarwal | TheJulia, wanyen my chat window is opened but i need to leave | 00:50 |
| TheJulia | I would think most operators would _prefer_ to discover active ports only, that way they don't need to prune any ports not required or desired. | 00:50 |
| wanyen | however, this approach is not friendly and cannot be automated. Therefore, it's better to provide an option for inspect_port, so no unused port will be created and no need to manually delete them. | 00:51 |
| wanyen | Julia, oob inspection cannot tell if a port is active or not. That's the issue. | 00:51 |
| TheJulia | It also can't provide local_link_information | 00:52 |
| wanyen | what kind of local link info are you referring to? | 00:52 |
| TheJulia | https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/plugins/local_link_connection.py | 00:53 |
| TheJulia | LLDP | 00:54 |
| wanyen | not yet via oob | 00:55 |
| wanyen | There is work in DMTF RedFish to define LLDP but the spec is not ready. | 00:56 |
| TheJulia | We had heard that there was discussion of making network information not optional/vendor specific in redfish, but I've not looked at redfish for a couple months | 00:58 |
| wanyen | The reason that we want to add inspect_port option is to remove the need to manually remove unwanted ports. We have customer feedbacks that they prefer inspect_port over manually port deletion. | 00:58 |
| *** causten has quit IRC | 00:59 | |
| *** causten has joined #openstack-ironic | 00:59 | |
| *** hoangcx has joined #openstack-ironic | 01:00 | |
| *** rpioso has quit IRC | 01:00 | |
| *** lindycoder has joined #openstack-ironic | 01:01 | |
| wanyen | The fault behavior will be to inpsect all ports. However, if inspect_ports is specified, then only inspect the specified ports. This will help some deployment environment where they have port for storage and netowrk or unactive ports. | 01:02 |
| wanyen | sorry fault should be default | 01:02 |
| TheJulia | As long as behavior is not really changing unless explicitly invoked, its not an issue, although I suspect that feedback is specific to flat network users. | 01:03 |
| wanyen | Likely because vLAN is not yet offically available for ironic. | 01:03 |
| *** causten has quit IRC | 01:04 | |
| wanyen | So, are u ok to for us to add inspect_port option? | 01:04 |
| TheJulia | wanyen: what do you mean vlan? | 01:04 |
| *** phuongnh has joined #openstack-ironic | 01:05 | |
| wanyen | I meant VLAN support for Ironic. | 01:05 |
| TheJulia | wanyen: I'm not a fan of it, but will not block it | 01:05 |
| TheJulia | wanyen: define vlan support | 01:05 |
| TheJulia | Do you mean tenant network separation? | 01:05 |
| wanyen | Julia, thanks not blockit. | 01:05 |
| TheJulia | or do you mean orchestration of trunks down to nodes? | 01:05 |
| wanyen | I thought Ironic want to allow different vLAN for management and data network as well as allow each tenant has its own vlan. | 01:06 |
| TheJulia | wanyen: that support landed in the last cycle | 01:07 |
| wanyen | Julia, yes if that's the offical term of it. | 01:07 |
| TheJulia | multitenant networking | 01:07 |
| wanyen | Oh. I thought all the neutron VLAN stuff landed but Nova code is not. Isn't it? | 01:08 |
| wanyen | I haven't followed that a while so my understanding maybe out-of-date. :) | 01:08 |
| TheJulia | wanyen: There are several pieces to the puzzle and evolutionary steps that have and continue to take place, but the fundamental part required in nova made it into the last cycle if memory serves. | 01:10 |
| wanyen | Julia, That's great! | 01:10 |
| *** mtanino has quit IRC | 01:11 | |
| *** rama_y_ has quit IRC | 01:11 | |
| wanyen | Julia, thanks for the discussion. I am signing off now. | 01:11 |
| TheJulia | goodnight | 01:11 |
| *** tuanluong has joined #openstack-ironic | 01:12 | |
| *** silenceli has joined #openstack-ironic | 01:18 | |
| *** wanyen has quit IRC | 01:23 | |
| *** Nisha_Agarwal has quit IRC | 01:25 | |
| *** hw_wutianwei has joined #openstack-ironic | 01:36 | |
| *** gcb has joined #openstack-ironic | 01:43 | |
| *** wajdi has joined #openstack-ironic | 01:52 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP/DNM: See if stable/newton is broken... https://review.openstack.org/419240 | 02:05 |
| jlvillal | TheJulia, rloo JayF vsaienk0 vdrok jroll: I think openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 broke stable/newton | 02:08 |
| patchbot | patch 404240 - ironic - Add Virtual Network Interface REST APIs (MERGED) | 02:08 |
| jlvillal | TheJulia, rloo JayF vsaienk0 vdrok jroll: I think openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 broke stable/newton | 02:08 |
| patchbot | patch 404240 - ironic - Add Virtual Network Interface REST APIs (MERGED) | 02:08 |
| jlvillal | http://logs.openstack.org/17/408417/2/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-ubuntu-xenial/39943ef/console.html#_2017-01-12_01_10_10_851647 | 02:08 |
| jlvillal | sambetts|afk, ^^^ | 02:09 |
| jlvillal | I have updated the Whiteboard | 02:11 |
| *** ijw has quit IRC | 02:18 | |
| *** lindycoder has quit IRC | 02:18 | |
| *** rbudden has joined #openstack-ironic | 02:25 | |
| *** bfournie has joined #openstack-ironic | 02:49 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Generic management I/F for Inject NMI https://review.openstack.org/348191 | 02:55 |
| *** rloo has quit IRC | 03:05 | |
| *** ijw has joined #openstack-ironic | 03:08 | |
| *** hoangcx_ has joined #openstack-ironic | 03:10 | |
| *** tuanluong_ has joined #openstack-ironic | 03:10 | |
| *** tuanluong has quit IRC | 03:10 | |
| *** hoangcx has quit IRC | 03:10 | |
| *** phuongnh has quit IRC | 03:11 | |
| *** phuongnh has joined #openstack-ironic | 03:11 | |
| *** hoangcx_ is now known as hoangcx | 03:12 | |
| *** ijw has quit IRC | 03:13 | |
| *** ijw_ has joined #openstack-ironic | 03:13 | |
| *** rloo has joined #openstack-ironic | 03:13 | |
| *** ijw_ has quit IRC | 03:14 | |
| *** phuongnh has quit IRC | 03:17 | |
| *** ijw has joined #openstack-ironic | 03:17 | |
| *** phuongnh has joined #openstack-ironic | 03:17 | |
| *** ijw has quit IRC | 03:18 | |
| *** lindycoder has joined #openstack-ironic | 03:18 | |
| *** baoli has joined #openstack-ironic | 03:20 | |
| *** ijw has joined #openstack-ironic | 03:22 | |
| *** lindycoder has quit IRC | 03:23 | |
| *** ijw_ has joined #openstack-ironic | 03:23 | |
| *** ijw has quit IRC | 03:27 | |
| *** vikrant has joined #openstack-ironic | 03:31 | |
| *** links has joined #openstack-ironic | 03:39 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 03:47 | |
| *** baoli has quit IRC | 03:57 | |
| *** aslezil_ has joined #openstack-ironic | 04:14 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Ipmitool management driver for Inject NMI https://review.openstack.org/348721 | 04:15 |
| *** lindycoder has joined #openstack-ironic | 04:15 | |
| *** lindycoder has quit IRC | 04:17 | |
| *** amotoki has quit IRC | 04:22 | |
| *** amotoki has joined #openstack-ironic | 04:22 | |
| *** lindycoder has joined #openstack-ironic | 04:33 | |
| *** lindycoder has quit IRC | 04:34 | |
| *** nmathew- has joined #openstack-ironic | 04:35 | |
| *** karthiks has joined #openstack-ironic | 04:40 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: iRMC management driver for Inject NMI https://review.openstack.org/348732 | 04:41 |
| *** karthiks has quit IRC | 04:46 | |
| *** Syed__ has quit IRC | 04:55 | |
| openstackgerrit | Dao Cong Tien proposed openstack/python-ironicclient: WIP: Extends driver-list, driver-show supporting new hardware types https://review.openstack.org/419274 | 04:59 |
| *** Nisha_Agarwal has quit IRC | 05:02 | |
| *** rloo has quit IRC | 05:05 | |
| *** karthiks has joined #openstack-ironic | 05:06 | |
| *** aslezil_ has quit IRC | 05:11 | |
| *** sasha2 has quit IRC | 05:18 | |
| *** sacharya has quit IRC | 05:25 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 05:37 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Ipmitool power driver for soft reboot and soft power off https://review.openstack.org/216738 | 05:38 |
| *** awidders_ has joined #openstack-ironic | 05:48 | |
| *** awiddersheim has quit IRC | 05:51 | |
| *** moshele has joined #openstack-ironic | 06:03 | |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic-inspector: Update documentation to deploy Ironic Inspector with DevStack https://review.openstack.org/410456 | 06:08 |
| *** zackf has quit IRC | 06:15 | |
| *** absubram has quit IRC | 06:17 | |
| *** karthiks has quit IRC | 06:19 | |
| *** lindycoder has joined #openstack-ironic | 06:23 | |
| *** sacharya has joined #openstack-ironic | 06:25 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: iRMC power driver for soft reboot and soft power off https://review.openstack.org/216743 | 06:28 |
| *** sacharya has quit IRC | 06:30 | |
| *** karthiks has joined #openstack-ironic | 06:34 | |
| *** rbudden has quit IRC | 06:36 | |
| *** mjura has joined #openstack-ironic | 06:42 | |
| *** makowals has quit IRC | 06:43 | |
| openstackgerrit | Hironori Shiina proposed openstack/ironic: Wire in storage interface attach/detach operations https://review.openstack.org/406290 | 06:43 |
| openstackgerrit | Hironori Shiina proposed openstack/ironic: Add REST API for volume connector and volume target operation https://review.openstack.org/214586 | 06:43 |
| openstackgerrit | Hironori Shiina proposed openstack/ironic: Add Cinder storage driver https://review.openstack.org/366197 | 06:43 |
| openstackgerrit | Hironori Shiina proposed openstack/ironic: Add base cinder common interface https://review.openstack.org/355625 | 06:43 |
| openstackgerrit | Hironori Shiina proposed openstack/ironic: [WIP] iPXE template support for iSCSI https://review.openstack.org/413324 | 06:43 |
| *** lindycoder has quit IRC | 06:44 | |
| *** makowals has joined #openstack-ironic | 06:44 | |
| *** lindycoder has joined #openstack-ironic | 06:52 | |
| *** e0ne has joined #openstack-ironic | 06:55 | |
| *** lindycoder has quit IRC | 06:57 | |
| *** e0ne has quit IRC | 06:57 | |
| *** hoangcx_ has joined #openstack-ironic | 06:57 | |
| *** ccamacho has quit IRC | 07:00 | |
| *** hoangcx has quit IRC | 07:00 | |
| *** SerenaFeng has joined #openstack-ironic | 07:05 | |
| *** rbartal has joined #openstack-ironic | 07:11 | |
| *** tesseract has joined #openstack-ironic | 07:14 | |
| *** zackf has joined #openstack-ironic | 07:14 | |
| openstackgerrit | Joanna Taryma proposed openstack/ironic-specs: Clean invalid conflict response usages and unnecessary retries https://review.openstack.org/414194 | 07:17 |
| *** zackf has quit IRC | 07:19 | |
| *** achadha has joined #openstack-ironic | 07:24 | |
| *** ChubYann has quit IRC | 07:32 | |
| *** gabriel-bezerra has quit IRC | 07:39 | |
| *** achadha has quit IRC | 07:45 | |
| vsaienk0 | jlvillal I'm not sure why on satable/newton we launch vif attach/detach tests. Looks like tempest tests on stable branches are still taken from master version of ironic tempest plugin | 07:46 |
| *** gabriel-bezerra has joined #openstack-ironic | 07:47 | |
| *** logan- has quit IRC | 07:47 | |
| *** tiendc has joined #openstack-ironic | 07:48 | |
| *** hoangcx has joined #openstack-ironic | 07:49 | |
| Nisha_Agarwal | vdrok, hi | 07:51 |
| *** hoangcx_ has quit IRC | 07:51 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Use kvm for ironic VMs when possible https://review.openstack.org/400941 | 07:51 |
| *** ralonsoh has joined #openstack-ironic | 07:52 | |
| *** logan- has joined #openstack-ironic | 07:56 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Add new capabilities to ironic https://review.openstack.org/338138 | 07:57 |
| *** sacharya has joined #openstack-ironic | 08:01 | |
| *** ccamacho has joined #openstack-ironic | 08:02 | |
| *** sacharya has quit IRC | 08:06 | |
| *** SerenaFeng has quit IRC | 08:08 | |
| openstackgerrit | Merged openstack/ironic-lib: Fix retrieval of config-2 existing partition https://review.openstack.org/417022 | 08:13 |
| *** amoralej|off is now known as amoralej | 08:21 | |
| yolanda | hi, good morning. I created a change for a new release of ironic-lib: https://review.openstack.org/419318 | 08:22 |
| patchbot | patch 419318 - releases - Add new release for ironic-lib | 08:22 |
| *** strigazi_AFK is now known as strigazi | 08:28 | |
| *** mgoddard has joined #openstack-ironic | 08:32 | |
| *** moshele has quit IRC | 08:32 | |
| *** moshele has joined #openstack-ironic | 08:33 | |
| *** moshele has quit IRC | 08:41 | |
| *** moshele has joined #openstack-ironic | 08:42 | |
| *** nmathew- has quit IRC | 08:43 | |
| vsaienk0 | jlvillal: for stable/newton tempest installs ironic_tempest_plugin from master http://logs.openstack.org/41/400941/5/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-ubuntu-xenial/c9cc2af/logs/devstacklog.txt.gz#_2017-01-12_08_11_59_916 | 08:48 |
| *** pmannidi has quit IRC | 08:49 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-ui: Imported Translations from Zanata https://review.openstack.org/418781 | 08:50 |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Extend VIF attach commands https://review.openstack.org/418894 | 08:53 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Add new capabilities to ironic https://review.openstack.org/338138 | 08:58 |
| *** athomas has joined #openstack-ironic | 08:58 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Add new capabilities to ironic https://review.openstack.org/338138 | 08:59 |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-ironic | 09:00 | |
| *** david-lyle has quit IRC | 09:01 | |
| *** sacharya has joined #openstack-ironic | 09:01 | |
| *** mgoddard has quit IRC | 09:02 | |
| openstackgerrit | Merged openstack/python-ironicclient: Add interface attach/detach support https://review.openstack.org/364420 | 09:05 |
| *** sacharya has quit IRC | 09:06 | |
| *** e0ne has joined #openstack-ironic | 09:07 | |
| openstackgerrit | yolanda.robla proposed openstack/bifrost: Allow deploy-dynamic on remote host https://review.openstack.org/411304 | 09:17 |
| *** nmathew has joined #openstack-ironic | 09:21 | |
| *** lucas-afk is now known as lucasagomes | 09:22 | |
| lucasagomes | morning all | 09:22 |
| *** david-lyle has joined #openstack-ironic | 09:24 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/bifrost: Updated from global requirements https://review.openstack.org/419338 | 09:34 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/419339 | 09:36 |
| *** Nisha_Agarwal has quit IRC | 09:40 | |
| *** mgoddard has joined #openstack-ironic | 09:44 | |
| *** skazi has quit IRC | 09:50 | |
| *** skazi has joined #openstack-ironic | 09:51 | |
| *** fxpester has joined #openstack-ironic | 09:51 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Ironic: Set default images for UEFI deployment https://review.openstack.org/419372 | 09:54 |
| lucasagomes | if someone has some time: https://review.openstack.org/#/c/414227 it has 2+2 already :-) | 09:56 |
| patchbot | patch 414227 - ironic - Move default image logic from DevStack to Ironic | 09:56 |
| *** tiendc has quit IRC | 10:00 | |
| *** e0ne has quit IRC | 10:06 | |
| *** derekh has joined #openstack-ironic | 10:08 | |
| openstackgerrit | Taku Izumi proposed openstack/ironic-python-agent: WIP: Add support for finalize_rescue https://review.openstack.org/417351 | 10:11 |
| *** e0ne has joined #openstack-ironic | 10:12 | |
| openstackgerrit | Sam Betts proposed openstack/ironic: Rework Ironic devstack baremetal network simulation https://review.openstack.org/392959 | 10:13 |
| sambetts|afk | jlvillal, vsaienk0: I guess we need to tag those tests with a don't run because your on an older branch tag or something?? | 10:14 |
| vsaienk0 | sambetts: yeah I'm looking how to do it, looks like we can use check_skip_with_microversion() from tempest https://github.com/openstack/tempest/blob/422ded886232067a393ec8fc4971580525e41ffe/tempest/lib/common/api_version_utils.py#L36 | 10:15 |
| *** MattMan has quit IRC | 10:15 | |
| *** MattMan has joined #openstack-ironic | 10:15 | |
| sambetts|afk | vsaienk0: +1 | 10:15 |
| *** sambetts|afk is now known as sambetts | 10:15 | |
| *** moshele has quit IRC | 10:16 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 10:17 | |
| *** ralonsoh_ has joined #openstack-ironic | 10:17 | |
| *** moshele has joined #openstack-ironic | 10:17 | |
| *** moshele has quit IRC | 10:19 | |
| *** moshele has joined #openstack-ironic | 10:19 | |
| *** ralonsoh has quit IRC | 10:20 | |
| sambetts | lucasagomes: RE: https://review.openstack.org/#/c/414227/ any idea what jroll didn't +A ?? | 10:21 |
| patchbot | patch 414227 - ironic - Move default image logic from DevStack to Ironic | 10:21 |
| lucasagomes | sambetts, no idea | 10:21 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Trivial fix https://review.openstack.org/419398 | 10:21 |
| sambetts | lucasagomes: sigh... ok /me is going to +A if you can't think of a reason to block it | 10:22 |
| lucasagomes | sambetts, heh it's ok, we can wait for jroll as well | 10:24 |
| *** pester has joined #openstack-ironic | 10:24 | |
| sambetts | lucasagomes: as far as I can tell it looks fine to me so I'm happy to put in the work to revert it if I need too | 10:25 |
| lucasagomes | sambetts, cool, yeah! Hope it won't need any revert :D | 10:25 |
| lucasagomes | I will seek for some reviews on the devstack patch to remove the logic from there once it's merged o/ | 10:25 |
| lucasagomes | sambetts, thanks | 10:25 |
| sambetts | \o/ | 10:25 |
| *** fxpester has quit IRC | 10:26 | |
| *** pester has quit IRC | 10:26 | |
| *** hoangcx has quit IRC | 10:27 | |
| *** phuongnh has quit IRC | 10:28 | |
| *** fxpester has joined #openstack-ironic | 10:40 | |
| *** nmathew has quit IRC | 10:42 | |
| *** xuao has joined #openstack-ironic | 10:51 | |
| * xuao Hi all～ | 10:51 | |
| *** amotoki has quit IRC | 10:56 | |
| *** sacharya has joined #openstack-ironic | 11:02 | |
| *** mgoddard has quit IRC | 11:05 | |
| *** amotoki has joined #openstack-ironic | 11:06 | |
| *** sacharya has quit IRC | 11:07 | |
| *** xuao has quit IRC | 11:11 | |
| openstackgerrit | M V P Nitesh proposed openstack/ironic: Removes unnecessary utf-8 encoding https://review.openstack.org/419419 | 11:12 |
| *** milan has joined #openstack-ironic | 11:13 | |
| milan | morning Ironic! :) | 11:13 |
| *** dtantsur|afk is now known as dtantsur | 11:28 | |
| dtantsur | morning Ironic | 11:29 |
| *** ptx0 has quit IRC | 11:29 | |
| milan | morning dtantsur! :) | 11:29 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Skip VIF api tests for old api versions https://review.openstack.org/419428 | 11:37 |
| *** vikrant has quit IRC | 11:37 | |
| lucasagomes | morning | 11:38 |
| *** crinkle_ is now known as crinkle | 11:38 | |
| *** ralonsoh_ is now known as ralonsoh | 11:42 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Set tempest baremetal.max_microversion https://review.openstack.org/419430 | 11:42 |
| *** jkilpatr has quit IRC | 11:49 | |
| *** vikrant has joined #openstack-ironic | 11:50 | |
| openstackgerrit | Merged openstack/ironic: Move default image logic from DevStack to Ironic https://review.openstack.org/414227 | 11:51 |
| lucasagomes | o/ | 11:52 |
| *** amotoki has quit IRC | 11:53 | |
| *** ralonsoh_ has joined #openstack-ironic | 11:55 | |
| vdrok | good late morning all | 11:57 |
| *** amotoki has joined #openstack-ironic | 11:58 | |
| *** ralonsoh has quit IRC | 11:59 | |
| *** amotoki_ has joined #openstack-ironic | 12:03 | |
| openstackgerrit | Bradley Jones proposed openstack/bifrost: Fix formatting of Role variables https://review.openstack.org/419436 | 12:03 |
| *** amotoki has quit IRC | 12:05 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Advertise the correct address when using IPv6 https://review.openstack.org/411817 | 12:05 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Remove check for UEFI + Whole disk images https://review.openstack.org/410784 | 12:06 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: DevStack: Configure nodes/environment to boot in UEFI mode https://review.openstack.org/374988 | 12:06 |
| *** tuanluong_ has quit IRC | 12:06 | |
| *** amotoki_ has quit IRC | 12:10 | |
| *** links has quit IRC | 12:13 | |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Rolling upgrades related dev documentation https://review.openstack.org/419439 | 12:14 |
| *** baoli has joined #openstack-ironic | 12:14 | |
| *** baoli has quit IRC | 12:15 | |
| *** baoli has joined #openstack-ironic | 12:15 | |
| *** derekh has quit IRC | 12:16 | |
| *** derekh has joined #openstack-ironic | 12:16 | |
| ricardoas | morning, Ironic! | 12:17 |
| *** baoli has quit IRC | 12:21 | |
| *** jkilpatr has joined #openstack-ironic | 12:21 | |
| openstackgerrit | Charlle Daniel proposed openstack/ironic: Ensures that OneView nodes are free for use by Ironic https://review.openstack.org/372762 | 12:22 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Skip VIF api tests for old api versions https://review.openstack.org/419428 | 12:24 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR Test patch https://review.openstack.org/419443 | 12:24 |
| *** lucasagomes is now known as lucas-hungry | 12:26 | |
| openstackgerrit | Jarrod Johnson proposed openstack/pyghmi: Provide more consistent attributes https://review.openstack.org/419446 | 12:30 |
| *** vikrant has quit IRC | 12:30 | |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Add RPC and object version pinning https://review.openstack.org/407491 | 12:34 |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Add version column https://review.openstack.org/412397 | 12:35 |
| *** dprince has joined #openstack-ironic | 12:35 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Fix assertEqual parmeters position in unittests https://review.openstack.org/419398 | 12:37 |
| *** hw_wutianwei has quit IRC | 12:38 | |
| *** gcb has quit IRC | 12:49 | |
| *** lindycoder has joined #openstack-ironic | 12:49 | |
| nicodemos | morning, all | 12:53 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR Test patch https://review.openstack.org/419443 | 12:57 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Skip VIF api tests for old api versions https://review.openstack.org/419428 | 12:57 |
| *** dtantsur is now known as dtantsur|brb | 12:58 | |
| *** lucas-hungry is now known as lucasagomes | 13:02 | |
| *** sacharya has joined #openstack-ironic | 13:03 | |
| *** vikrant has joined #openstack-ironic | 13:05 | |
| *** vikrant has quit IRC | 13:06 | |
| *** sacharya has quit IRC | 13:08 | |
| *** trown|outtypewww is now known as trown | 13:11 | |
| *** pester has joined #openstack-ironic | 13:14 | |
| *** alexpilo_ has joined #openstack-ironic | 13:15 | |
| *** fxpester has quit IRC | 13:17 | |
| *** alexpilotti has quit IRC | 13:17 | |
| *** dtantsur|brb has quit IRC | 13:17 | |
| *** yolanda has quit IRC | 13:18 | |
| *** dtantsur has joined #openstack-ironic | 13:18 | |
| *** yolanda has joined #openstack-ironic | 13:18 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _send_sensors_data concurrent https://review.openstack.org/407429 | 13:20 |
| *** ralonsoh_ is now known as ralonsoh | 13:23 | |
| *** links has joined #openstack-ironic | 13:25 | |
| *** aarefiev_afk is now known as aarefiev | 13:26 | |
| aarefiev | morning all! | 13:27 |
| aarefiev | hey milan, are you around? | 13:27 |
| milan | morning aarefiev! :) | 13:27 |
| milan | yup | 13:28 |
| milan | w/r the spec? | 13:28 |
| aarefiev | milan: no :) | 13:28 |
| milan | ok :) | 13:28 |
| aarefiev | milan: I've played with kombu | 13:29 |
| aarefiev | last year :) | 13:29 |
| patchbot | :) | 13:29 |
| milan | aarefiev, you just managed the patchbot to smile | 13:29 |
| aarefiev | milan: https://review.openstack.org/#/c/415645/1 | 13:29 |
| milan | :D | 13:29 |
| patchbot | patch 415645 - ironic-inspector - [POC] Split service on API and Engine | 13:29 |
| aarefiev | yeah | 13:29 |
| aarefiev | wdyt? | 13:29 |
| * milan looks | 13:29 | |
| aarefiev | milan: I've tested on devstack with rabbit | 13:30 |
| milan | nice | 13:30 |
| aarefiev | looks like we could use it | 13:31 |
| aarefiev | it's very simple poc | 13:31 |
| milan | aarefiev, cool | 13:31 |
| milan | I think we can use that indeed :) | 13:31 |
| * milan needs to read through | 13:31 | |
| *** amoralej is now known as amoralej|off | 13:32 | |
| aarefiev | milan: looks like it's pretty easy to implement ha with it | 13:32 |
| *** amoralej|off is now known as amoralej|lunch | 13:32 | |
| lucasagomes | the patch increasing the timeout for the nova boot has merged ? | 13:32 |
| *** ralonsoh_ has joined #openstack-ironic | 13:33 | |
| aarefiev | milan: it has ack mechanism, and messages could be rescheduled if worker die | 13:34 |
| milan | aarefiev, cool so it has sort of a retry logic over the media | 13:34 |
| milan | aarefiev, which is nice since our state machine is (hopefully) designed to cope w/ that | 13:34 |
| aarefiev | milan: and main benefit, it's in global requirements :) | 13:35 |
| milan | aarefiev, awesome! :D | 13:35 |
| milan | aarefiev, it's going to take me a bit to get to this | 13:35 |
| milan | I need to check kombu and give this a review | 13:36 |
| *** ralonsoh has quit IRC | 13:36 | |
| milan | aarefiev, but I'm interested a lot in using something that actually works :) | 13:36 |
| * milan blocked a bit on https://review.openstack.org/#/c/419010/ | 13:36 | |
| patchbot | patch 419010 - ironic-inspector - [WIP] introduce bmc port support | 13:36 |
| milan | aarefiev, mind a review while it's still small ;) ^ | 13:37 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Allow to attach/detach VIF to portgroup https://review.openstack.org/406915 | 13:38 |
| aarefiev | milan: sure, give me 10 min :) | 13:41 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Set tempest baremetal.max_microversion https://review.openstack.org/419430 | 13:41 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Allow to attach/detach VIF to portgroup https://review.openstack.org/406915 | 13:41 |
| vsaienk0 | sambetts, jlvillal, vdrok patch to skip VIF attach detach tests for older API versions https://review.openstack.org/#/c/419428/, patch that configures max_microversion for stable/newton is https://review.openstack.org/#/c/419430/ .Test patch that shows that skip works is https://review.openstack.org/#/c/419443. Example from the logs: http://logs.openstack.org/43/419443/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-pxe_snmp-tinyipa-ubuntu-xeni | 13:42 |
| patchbot | patch 419428 - ironic - Skip VIF api tests for old api versions | 13:42 |
| patchbot | patch 419430 - ironic (stable/newton) - Set tempest baremetal.max_microversion | 13:42 |
| patchbot | patch 419443 - ironic - DNM/DNR Test patch | 13:42 |
| milan | aarefiev, thanks! | 13:42 |
| sambetts | vsaienk0: I don't think we need to duplicate the code from BaseBaremetalTest that already does the microversion check | 13:46 |
| milan | dtantsur, https://review.openstack.org/#/c/419010/ I thought about the dropping of the BMC address and I guess it is on par being broken w/ my solution of the address:port; neither of those would work 100% unless the ports are created in Ironic so inspector can locate the node later | 13:46 |
| patchbot | patch 419010 - ironic-inspector - [WIP] introduce bmc port support | 13:46 |
| milan | dtantsur, but given what mat128 said yesterday, and I agree w/ him, hi mat :) , we imo better not drop the address | 13:47 |
| sambetts | vsaienk0: https://github.com/openstack/ironic/blob/master/ironic_tempest_plugin/tests/api/admin/base.py#L74 | 13:47 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR Test patch https://review.openstack.org/419443 | 13:49 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Skip VIF api tests for old api versions https://review.openstack.org/419428 | 13:49 |
| vsaienk0 | sambetts: I missed that part, just uploaded a new version of the patch | 13:50 |
| *** absubram has joined #openstack-ironic | 13:51 | |
| *** xavierr has joined #openstack-ironic | 13:51 | |
| milan | dtantsur, also if absolutely necessary, one could add the ipmi_port to the inventory on the IPA some other way than ipmitool, whereas if we drop the address, that won't work | 13:53 |
| * milan still worried we'd break silently someone that exported the port | 13:53 | |
| milan | but we'd break those even if we dropped the address | 13:53 |
| milan | lucasagomes, ^ | 13:54 |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Add version column https://review.openstack.org/412397 | 13:55 |
| *** pester has quit IRC | 13:56 | |
| aarefiev | milan: I thought we have separate field for ipmi port | 13:56 |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Add new dbsync command online_data_migrations with first migration https://review.openstack.org/408556 | 13:56 |
| milan | arefiev, issue is, if two nodes have the same ipmi_address and differ only in ipmi_port | 13:56 |
| milan | all is doomed | 13:56 |
| milan | aarefiev, happens in tripleO gate w/ virtualbmc | 13:57 |
| milan | aarefiev, and to make it worse, IPA doesn't report ipmi_port | 13:58 |
| milan | ipmitool neither | 13:58 |
| *** AlexeyAbashkin has quit IRC | 13:59 | |
| *** sasha2 has joined #openstack-ironic | 13:59 | |
| aarefiev | milan: ok, it's only test case, right | 13:59 |
| *** absubram_ has joined #openstack-ironic | 13:59 | |
| *** absubram has quit IRC | 14:00 | |
| *** absubram_ is now known as absubram | 14:00 | |
| sambetts | aarefiev: not for bridged IPMI tool | 14:00 |
| milan | sambetts, hey :) | 14:00 |
| milan | sambetts, also wdyt? | 14:00 |
| aarefiev | sambetts, morning | 14:00 |
| sambetts | aarefiev: sometimes single chassis have one management address and only differ in things like target channel and weird stuff like that | 14:00 |
| sambetts | milan: /me isn't really up to date on the conversation, just thought Id mention weird IPMI situations | 14:01 |
| milan | sambetts, ty :D | 14:01 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Skip VIF api tests for old api versions https://review.openstack.org/419428 | 14:01 |
| milan | sambetts, https://review.openstack.org/#/c/419010/ | 14:01 |
| patchbot | patch 419010 - ironic-inspector - [WIP] introduce bmc port support | 14:02 |
| aarefiev | ugh | 14:02 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Skip VIF api tests for old api versions https://review.openstack.org/419428 | 14:02 |
| *** AlexeyAbashkin has joined #openstack-ironic | 14:02 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR Test patch https://review.openstack.org/419443 | 14:02 |
| milan | sambetts, I've got a suggestion to store the port w/ the address together in that patch | 14:02 |
| milan | sambetts, other suggestions were to drop the ipmi_address in case ipmi_port is detected and just silently ignore | 14:03 |
| milan | it | 14:03 |
| milan | aarefiev, sambetts I'm open to ideas | 14:03 |
| milan | https://bugs.launchpad.net/tripleo/+bug/1651719 < the bug | 14:04 |
| openstack | Launchpad bug 1651719 in Ironic Inspector "Introspection fails on nodes with the same IPMI address but different IPMI ports" [High,In progress] - Assigned to milan k (vetrisko) | 14:04 |
| aarefiev | is it one possible case, with port I mean | 14:04 |
| milan | aarefiev, that's what I'm not sure about | 14:04 |
| *** jcoufal has joined #openstack-ironic | 14:05 | |
| sambetts | milan: TBH /me doesn't have any success with bmc_address on my hardware, and IMO we should rename it IPMI_address because thats the only case when I know it works :-P | 14:05 |
| milan | if the real thing hw exported a port this might break them | 14:05 |
| milan | sambetts, heh, we can, but I'd love to fix the port first :P | 14:05 |
| sambetts | milan: if we do port do we also need to do things like ipmi_local_address and ipmi_target_address ? | 14:07 |
| milan | sambetts, hmmm, maybe we do | 14:08 |
| milan | sambetts, so another option: treat it as not a bug? | 14:08 |
| sambetts | milan: maybe :/ | 14:08 |
| milan | dtantsur, aarefiev ^^ wdyt? | 14:09 |
| sambetts | so whats the expected return value from IPA? | 14:09 |
| sambetts | address:port? | 14:09 |
| sambetts | or two different fields | 14:09 |
| *** amotoki has joined #openstack-ironic | 14:09 | |
| *** rloo has joined #openstack-ironic | 14:09 | |
| aarefiev | yeah, I thought you said there is no port | 14:09 |
| aarefiev | in inventory | 14:10 |
| sambetts | if there is no port in the inventory, and there are multiple ironic nodes with the same address then I think we should fail lookup | 14:10 |
| milan | sambetts, the port isn't reported | 14:11 |
| milan | in IPA/ipmitool | 14:11 |
| milan | so no sane way how to know | 14:11 |
| milan | it | 14:11 |
| sambetts | milan: then the only option I think we have is to fall back to the mac addresses if there are more that one node with the same ipmi_address | 14:12 |
| milan | sambetts, so basically dropping the ipmi_address | 14:12 |
| milan | from the look-up table | 14:12 |
| milan | also not sure what happens if we don't save it but IPA reports it | 14:13 |
| sambetts | we can use it as long as when looking up the node in Ironic doesn't return more than one node | 14:13 |
| sambetts | if we get multiple results from trying to match the ipmi_address then fail and fall back to mac address | 14:14 |
| sambetts | if there is no mac addresses we fail lookup | 14:14 |
| aarefiev | sambetts: +1 sounds good | 14:14 |
| *** [1]cdearborn has joined #openstack-ironic | 14:15 | |
| sambetts | then if in the future we expand IPA to return the port some how, then we can add ipmi_port checks too | 14:15 |
| *** wajdi has quit IRC | 14:15 | |
| milan | sambetts, OK | 14:15 |
| aarefiev | https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/process.py#L88 | 14:15 |
| aarefiev | also did you check ipmitool on diff hw? | 14:17 |
| *** amoralej|lunch is now known as amoralej | 14:17 | |
| aarefiev | milan^ | 14:18 |
| *** aparnav has joined #openstack-ironic | 14:18 | |
| sambetts | milan: I'm not sure what you mean by make it possible to lookup later in your commit message, were you planning on caching the inspection it somehow? | 14:18 |
| sambetts | for manual assignment? | 14:18 |
| sambetts | or something | 14:18 |
| milan | aarefiev, I've checked on Dell, no port there | 14:18 |
| sambetts | on my hardware you get nothing at all, not even the address | 14:18 |
| milan | sambetts, later I meant once the discovery data comes | 14:19 |
| milan | needs rephrasing | 14:19 |
| *** Goneri has joined #openstack-ironic | 14:19 | |
| milan | huh | 14:19 |
| milan | sambetts, in your case, what does the ironic's driver info contain? | 14:19 |
| sambetts | milan: if I use the ipmitool drivers, ipmi_address username and password, just like everyone elses | 14:20 |
| mat128 | hi milan (1h later) :) | 14:20 |
| milan | hi mat128! :) | 14:20 |
| sambetts | hey milan | 14:20 |
| sambetts | hey mat128 * | 14:20 |
| milan | nevertheless right on time to have the discussion ;) | 14:21 |
| milan | about dropping the ipmi_address in case ipmi_port is reported in driver_info | 14:21 |
| milan | sambetts, I see | 14:22 |
| sambetts | milan: I basically always have to specify a mac address in Ironic or use auto-discovery | 14:23 |
| mat128 | I have to leave for the office, I'll catch up on your discussion right after | 14:23 |
| *** baoli has joined #openstack-ironic | 14:23 | |
| milan | mat128, cool :) | 14:23 |
| mat128 | if you have a command I can try and run on my hardware to find out if the IP comes back | 14:23 |
| mat128 | mostly Supermicro | 14:23 |
| milan | mat128, ipmitool lan print I guess | 14:24 |
| milan | but I guess it's the same everywhere | 14:24 |
| *** amotoki has quit IRC | 14:24 | |
| milan | rather if you've got a custom introspection collector that might export the ipmi_port by other means than ipmitool | 14:25 |
| milan | mat128, ^ | 14:25 |
| sambetts | yeah this is how IPMItool does it https://github.com/openstack/ironic-python-agent/blob/8271996fe8135fa80205a31024e190d700b83c21/ironic_python_agent/hardware.py#L900 | 14:25 |
| sambetts | in IPA | 14:25 |
| milan | yup | 14:26 |
| *** causten has joined #openstack-ironic | 14:26 | |
| milan | sambetts, the thing is, if you have the same ipmi_address for two nodes, introspection won't start for you at all | 14:27 |
| milan | sambetts, /me rereading your suggestion | 14:27 |
| mat128 | milan: checked real quick and port isnt part of the response | 14:27 |
| milan | yeah | 14:28 |
| sambetts | milan: why/ | 14:28 |
| sambetts | ? | 14:28 |
| sambetts | milan: because of the node cahce? | 14:28 |
| sambetts | cache* | 14:28 |
| milan | cause of the attributes table has to have unique values | 14:28 |
| milan | yup | 14:28 |
| * mat128 relocates | 14:29 | |
| milan | sambetts, https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/db.py#L72 | 14:29 |
| *** amotoki has joined #openstack-ironic | 14:29 | |
| sambetts | milan: hmm... I guess this is the issues we run into by have basically a duplication of the Ironic DB | 14:29 |
| milan | sambetts, right | 14:29 |
| *** makowals has quit IRC | 14:29 | |
| sambetts | milan: /me thinks we should fix that DB attribute to be not unique | 14:30 |
| sambetts | milan: /me also thinks that maybe we should be less IPMI specific in inspector | 14:31 |
| milan | to have and ID column and just try search what name/value combinations best describe a Node | 14:31 |
| *** amotoki has quit IRC | 14:31 | |
| jroll | rloo: I'll be here on MLK day | 14:31 |
| jroll | jlvillal: thanks for the CI breakage heads up, sadface, I have some thoughts on fixing that | 14:31 |
| milan | sambetts, I see | 14:31 |
| jroll | lucasagomes: I didn't +A due to the question there, glad it got merged | 14:31 |
| *** makowals has joined #openstack-ironic | 14:32 | |
| milan | sambetts, so name must not be a key either then | 14:32 |
| rloo | jroll: good to know, maybe it is just big companies like intel | 14:32 |
| lucasagomes | jroll, morning... Cool, yeah I put the patch up for the UEFI images but later I realized that it would be easier to just do it as part of the same patch which is configuring the nodes to boot with UEFI | 14:32 |
| lucasagomes | so it's there now :-) | 14:32 |
| jroll | morning y'all | 14:32 |
| jroll | lucasagomes: cool, thanks | 14:33 |
| *** amotoki has joined #openstack-ironic | 14:33 | |
| sambetts | milan: not sure what you mean | 14:33 |
| milan | https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/db.py#L72 | 14:33 |
| jroll | rloo: yeah, from what I've seen it varies... e.g. my fiancee has to work, but is considered a holiday so she gets 1.5x pay | 14:33 |
| milan | sambetts, ^ if we want the values non-unique | 14:33 |
| jroll | and her hospital isn't large | 14:33 |
| milan | morning jroll! :) | 14:33 |
| jroll | \o | 14:33 |
| sambetts | jroll: https://review.openstack.org/#/c/419428/ | 14:33 |
| patchbot | patch 419428 - ironic - Skip VIF api tests for old api versions | 14:33 |
| sambetts | jroll: for fixing the CI ^ | 14:33 |
| jroll | sambetts: yep, in my tab queue | 14:34 |
| * jroll just finished scrollback | 14:34 | |
| sambetts | coolioes | 14:34 |
| milan | morning rloo! :) | 14:34 |
| aarefiev | milan, sambetts: I guess we could add some id as primary to attributes | 14:35 |
| sambetts | milan, aarefiev: I think we can make name and uuid primary right?? | 14:35 |
| aarefiev | morning jroll, rloo | 14:35 |
| milan | aarefiev, exactly, and try a best-effort search biggest match to identify a node? | 14:35 |
| milan | sambetts, I think the uuid here is the node | 14:36 |
| milan | so it's the other way around attr_nameXattr_value-> node_uuid | 14:36 |
| aarefiev | yeah uuid | 14:36 |
| sambetts | milan: exaclt so making name and uuid the primary keys to that table would be that you could have 1 ipmi_addres per node | 14:37 |
| sambetts | milan: but the values are restricted | 14:37 |
| milan | but the thing is the IPA doesn't return the uuid | 14:37 |
| milan | so you won't know which node it's ringing the door bell | 14:38 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Skip VIF api tests for old api versions https://review.openstack.org/419428 | 14:38 |
| aarefiev | milan: but it has uuid as reference now | 14:38 |
| sambetts | milan: even if the uuid is the primary, you don't need to look it up by UUID | 14:39 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR Test patch https://review.openstack.org/419443 | 14:39 |
| sambetts | milan: e.g. you can still to select * from attrbutes where value == * | 14:39 |
| sambetts | milan: e.g. you can still to select * from attrbutes where value == <thing> | 14:39 |
| milan | aarefiev, just a reference to nodes table, right? | 14:39 |
| milan | sambetts, aaah | 14:40 |
| milan | sambetts, /me thinks | 14:40 |
| aarefiev | it just says this uuid exist | 14:40 |
| *** makowals has quit IRC | 14:41 | |
| rloo | hi and good morning milan, aarefiev, sambetts, jroll, lucasagomes and everyone else | 14:41 |
| milan | aarefiev, sambetts so the table key would be node_uuidXattribute_name | 14:42 |
| lucasagomes | rloo, morning :-) | 14:42 |
| sambetts | milan: yup | 14:42 |
| aarefiev | +1 | 14:42 |
| jlvillal | jroll, vsaienk0 has proposed two patches to fix the stable/newton issue: https://review.openstack.org/#/c/419428/ & https://review.openstack.org/#/c/419430/ | 14:42 |
| patchbot | patch 419428 - ironic - Skip VIF api tests for old api versions | 14:42 |
| patchbot | patch 419430 - ironic (stable/newton) - Set tempest baremetal.max_microversion | 14:42 |
| jlvillal | I have updated the whiteboard with the info | 14:42 |
| aarefiev | primary key | 14:42 |
| milan | aarefiev, sambetts thanks guys! that might work indeed | 14:42 |
| jroll | jlvillal: yeah, I see them / am reviewing now | 14:43 |
| vsaienk0 | jlvillal: we also need backport to sable/mitaka | 14:43 |
| * milan coffee break and hack it I guess | 14:43 | |
| sambetts | milan: as long as 1 node can't have multiple copies on one attrbiute | 14:43 |
| *** makowals has joined #openstack-ironic | 14:43 | |
| sambetts | milan: /me is unsure on that | 14:43 |
| milan | sambetts, hmmmmm | 14:43 |
| jlvillal | vsaienk0, Thanks. I updated the Whiteboard to say stable/mitaka is also broken then | 14:44 |
| *** ptx0 has joined #openstack-ironic | 14:44 | |
| jlvillal | vsaienk0, Thanks for the patches!!! :) | 14:44 |
| sambetts | milan: if that is the case then a id field is the only option | 14:44 |
| milan | dtantsur, do you remember why the values are keys? https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/db.py#L72 also wdyt about sambetts suggestion ^^^^^ | 14:44 |
| aarefiev | sambetts: unsure about multiple copies | 14:44 |
| milan | sambetts, yeah, id would be a safe bet | 14:44 |
| *** AlexeyAbashkin has quit IRC | 14:45 | |
| milan | idxattribute_name -> attribute_value, node_id | 14:45 |
| jroll | vsaienk0: check out my comments here, it's a bit more work, I'm happy to write the patch if you like: https://review.openstack.org/#/c/419430/2/devstack/lib/ironic | 14:45 |
| patchbot | patch 419430 - ironic (stable/newton) - Set tempest baremetal.max_microversion | 14:45 |
| sambetts | milan: no need for the attribute name to be a key | 14:45 |
| jroll | jlvillal: ^^ | 14:45 |
| milan | sambetts, true | 14:46 |
| milan | aarefiev, sambetts so te lookup query would be the biggest match | 14:46 |
| *** baoli has quit IRC | 14:46 | |
| *** aslezil_ has joined #openstack-ironic | 14:47 | |
| aarefiev | milan: is lookup query wrong now? | 14:48 |
| milan | aarefiev, nope but it depends on the value | 14:48 |
| *** ptx0 has quit IRC | 14:48 | |
| aarefiev | yeah | 14:49 |
| milan | I mean nameXvalue -> node_uuid | 14:49 |
| milan | so the node_uuid may appear more than once | 14:49 |
| milan | so the query is quite efficient if the value are part of the key I guess | 14:49 |
| aarefiev | make sense | 14:50 |
| *** dyasny has quit IRC | 14:50 | |
| milan | unless the combination isn't unique :D | 14:50 |
| milan | then everything blows up | 14:51 |
| sambetts | milan: the table is only setup that way so that it represents a unquie key:value store that is a many to one relationship with the node, I don't there there was any other reason for its strcuture | 14:51 |
| aarefiev | so we need to decide shoud node_uuidXattribute_name be unique | 14:51 |
| sambetts | making the table: ID -> name, value, node should be fine and if it starts being slow we can always force indexing on name and value | 14:51 |
| jroll | anyone have objections to releasing ironicclient? | 14:53 |
| milan | yeah and figure out reasonable query logic to identify the nodes | 14:53 |
| * jroll glances at review queue | 14:53 | |
| sambetts | milan: I don't think the query logic will need to change, its still SELECT node WHERE name=foo AND value=BAR | 14:54 |
| milan | sambetts, in case the ipmi_address is the same for more nodes it won't work | 14:54 |
| milan | it just won't blow up | 14:55 |
| milan | but multiple matches will be found | 14:55 |
| sambetts | milan: it'll just return 2 nodes, and then we go if result > 1 then fail | 14:55 |
| sambetts | or fall back to mac address checking | 14:55 |
| milan | or that, that was my query thinking | 14:55 |
| milan | ;) | 14:55 |
| TheJulia | Good morning | 14:55 |
| milan | morning TheJulia! :) | 14:56 |
| *** zackf has joined #openstack-ironic | 14:56 | |
| milan | aarefiev, sambetts but yeah, sound like a plan I can put up that patch, let's see | 14:56 |
| sambetts | milan: awesome :D | 14:56 |
| milan | right :P | 14:57 |
| aarefiev | milan, sambetts; but there is mac in query, no? | 14:57 |
| milan | aarefiev, /me checks | 14:57 |
| aarefiev | how it will return >1 node | 14:58 |
| sambetts | aarefiev: name=mac value=<mac address> | 14:58 |
| *** gcb has joined #openstack-ironic | 14:58 | |
| sambetts | aarefiev: if mac address isn't set on the node then its ingored | 14:58 |
| sambetts | ignored I think | 14:58 |
| *** rook has quit IRC | 14:59 | |
| aarefiev | ahh, I see | 14:59 |
| *** lucasagomes has quit IRC | 14:59 | |
| dtantsur | milan, sorry, we HAVE to ignore IPMI address when ports are set | 15:00 |
| *** lucasagomes has joined #openstack-ironic | 15:00 | |
| milan | dtantsur, mind elaborate on the reason? | 15:00 |
| dtantsur | milan, it's broken | 15:00 |
| lucasagomes | jroll, not really, there's a couple of patches in the queue for nmi injection support which may be interesting to get in since the base patches are merged in ironic already | 15:00 |
| lucasagomes | oh actually soft boot that got merged | 15:00 |
| lucasagomes | nmi is not yet | 15:00 |
| dtantsur | milan, are you asking me why we should not break introspection in this case? :) | 15:01 |
| milan | dtantsur, I'm asking rather why we have to drop it ;) | 15:01 |
| jroll | lucasagomes: hm, I don't see anything recent with a +2 other than nmi stuff | 15:01 |
| * milan wonders whether there aren't any constructive solutions | 15:02 | |
| jroll | we'll do another release in a week or two, we can get those things in yet | 15:02 |
| dtantsur | milan, any better ideas? | 15:02 |
| milan | dtantsur, best idea so far is to modify the look-up table? | 15:02 |
| lucasagomes | jroll, ++ | 15:03 |
| lucasagomes | yeah | 15:03 |
| dtantsur | milan, "modify" = "not put IPMI address there", right :) | 15:03 |
| *** chlong has joined #openstack-ironic | 15:03 | |
| milan | dtantsur, lol, rather change it from nameXvalue -> node_id to id -> name, value, node_id | 15:03 |
| dtantsur | unless you've found a way to get port from within the machine, that is | 15:03 |
| dtantsur | milan, how does it help with duplication? | 15:04 |
| *** sacharya has joined #openstack-ironic | 15:04 | |
| milan | dtantsur, the query would have to change to cope retry narrowing down w/ attributes from introspection | 15:04 |
| dtantsur | well, this is what we explicitly don't do | 15:05 |
| milan | if at the end we got still more nodes, just fail | 15:05 |
| *** amotoki has quit IRC | 15:05 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/419339 | 15:05 |
| *** rook has joined #openstack-ironic | 15:05 | |
| milan | dtantsur, why's that :) | 15:05 |
| *** rook is now known as Guest8298 | 15:05 | |
| dtantsur | milan, because we don't want to update the wrong data. it's better to fail than to screw up | 15:05 |
| dtantsur | milan, let's approach it from this end: what's the use of keeping IPMI address if we know that it's not unique? | 15:05 |
| sambetts | dtantsur: it might be unique, even if ipmi_port is set right? | 15:06 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Set tempest baremetal.max_microversion https://review.openstack.org/419430 | 15:06 |
| milan | dtantsur, cause the combination of portxaddress might still be unique | 15:06 |
| dtantsur | sambetts, it well might | 15:06 |
| dtantsur | milan, just like MAC only, yes :) | 15:07 |
| milan | yeah, true, no-one returns the port | 15:07 |
| rloo | jroll: i took a quick look at the client patches, i don't see anything urgent to get in. the only one is https://review.openstack.org/#/c/357627/ to unblock nova but not much reviewing has been done | 15:07 |
| patchbot | patch 357627 - python-ironicclient - Support soft reboot and soft power off with timeou... | 15:07 |
| jroll | rloo: yeah, we can release early next week again, I'd love to get that in | 15:07 |
| TheJulia | Good morning | 15:08 |
| dtantsur | morning TheJulia, rloo, jroll | 15:08 |
| *** absubram has quit IRC | 15:08 | |
| jroll | nova change should just be a: if soft: power_state = 'soft ' + power state | 15:08 |
| milan | aarefiev, sambetts you guys cool? | 15:08 |
| * jroll hasn't looked at that either | 15:08 | |
| rloo | jroll: it would be nice to get in but i don't see enough people lovin' and reviewin' it :-( | 15:08 |
| jroll | rloo: well, we can make that happen :) | 15:08 |
| *** rama_y has joined #openstack-ironic | 15:08 | |
| * jroll -2s everything else | 15:08 | |
| jroll | :D | 15:08 |
| *** rama_y_ has joined #openstack-ironic | 15:09 | |
| *** sacharya has quit IRC | 15:09 | |
| sambetts | milan, dtantsur: not sure what the conclusion of that was | 15:09 |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Add new dbsync command online_data_migrations with first migration https://review.openstack.org/408556 | 15:09 |
| milan | sambetts, just drop the address | 15:09 |
| dtantsur | I don't know what the better choice is.. changing database schema is not a perfect bug fix.. | 15:09 |
| sambetts | milan: just don't store it ? | 15:09 |
| TheJulia | Heh, my other good morning apparently made it through :\ | 15:09 |
| milan | sambetts, yeah | 15:09 |
| dtantsur | cutting out people with non-standard ports is also not awesome | 15:09 |
| milan | sambetts, neither the address nor the port to be more specific | 15:10 |
| rloo | jroll: also just noticed, that power patch is the 2nd of two client patches. so no, not in today's release. | 15:10 |
| milan | dtantsur, there's one thing though | 15:10 |
| jroll | rloo: yeah, I want to get this release out so that we can get networking going in nova | 15:10 |
| rloo | jroll: ++ me too | 15:10 |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Rolling upgrade procedure documentation https://review.openstack.org/416565 | 15:10 |
| milan | if node_a has address A and node_B has address A + Port, we cool to drop just the node_B correct? | 15:10 |
| milan | node_B address&port keep macs | 15:11 |
| aarefiev | why do we need to drop it | 15:11 |
| aarefiev | maybe just ignore | 15:12 |
| milan | dtantsur, as if the IPA reports the address it might point to node A instead | 15:12 |
| sambetts | milan: I think we need to check against Ironic for duplicates because we can't guarentee that A comes before B or visa versa | 15:12 |
| milan | aarefiev, I mean ignore | 15:12 |
| aarefiev | ok :) | 15:12 |
| milan | sambetts, exactly | 15:12 |
| dtantsur | milan, ugh | 15:12 |
| milan | dtantsur, on the other hand the modfied table might still work here | 15:13 |
| milan | or no? :D | 15:13 |
| * dtantsur thinks | 15:14 | |
| * milan recursive confuser today :D | 15:14 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Allow to set min,max API microversion in tempest https://review.openstack.org/419510 | 15:14 |
| dtantsur | milan, so essentially you suggest to replace OR in the lookup with AND, right? | 15:14 |
| * milan not sure | 15:14 | |
| milan | biggest result wins? | 15:15 |
| milan | I guess so yeah, OR is it then | 15:15 |
| milan | dtantsur, like a best match thing | 15:15 |
| milan | dtantsur, like a google-fight | 15:16 |
| sambetts | dtantsur: no still OR, but if you get more than one result you vomit | 15:17 |
| milan | sambetts, you retry to narrow down w/ different attr | 15:17 |
| sambetts | milan: yeah | 15:17 |
| milan | until you run out of attributes | 15:17 |
| milan | or have a decision | 15:17 |
| milan | :_ | 15:17 |
| milan | :) | 15:17 |
| *** rbartal has quit IRC | 15:17 | |
| dtantsur | milan, so essentially drop unique constraint from this table, and handle duplicates, right? | 15:18 |
| milan | dtantsur, right | 15:18 |
| sambetts | dtantsur: basically yeah | 15:18 |
| dtantsur | hmm, this may work | 15:18 |
| aarefiev | we are already handle duplicates | 15:18 |
| aarefiev | I guess | 15:18 |
| milan | aarefiev, yup seems like, if not exactly this way, the change won't be too big I guess | 15:19 |
| *** aslezil_ has quit IRC | 15:19 | |
| milan | and mat128 might like it this way too ;) | 15:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Allow to set min,max API microversion in tempest https://review.openstack.org/419430 | 15:19 |
| aarefiev | :) | 15:19 |
| milan | aarefiev, dtantsur, sambetts so I guess we've got a winner, right? | 15:20 |
| milan | let's do it? | 15:20 |
| milan | let's do it, me! :D | 15:20 |
| sambetts | \o/ sounds good | 15:20 |
| aarefiev | milan: you are a winner :) | 15:20 |
| dtantsur | yeah, let's try | 15:20 |
| milan | lol OK | 15:20 |
| * milan will relocate and just do it (tm) :D | 15:21 | |
| dtantsur | milan, do you also have a patch to ignore loopback addresses? I think this is less controversial | 15:21 |
| milan | dtantsur, excellent point! would be a quick fix for this! | 15:21 |
| milan | not yet | 15:21 |
| milan | I can or if you wish you can | 15:21 |
| * milan needs ~2h for an errand right now | 15:22 | |
| *** jaosorior has joined #openstack-ironic | 15:22 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Allow to set min,max API microversion in tempest https://review.openstack.org/419516 | 15:23 |
| dtantsur | milan, I will propose it then | 15:23 |
| vsaienk0 | jroll: please check if I did it correctly https://review.openstack.org/#/q/Id6d36280f622549a2877aab99c11e4008af67fe7,n,z | 15:23 |
| *** mtanino has joined #openstack-ironic | 15:24 | |
| jroll | vsaienk0: yep, looking now | 15:25 |
| openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Rolling upgrade procedure documentation https://review.openstack.org/416565 | 15:26 |
| milan | dtantsur, ack, thanks! | 15:27 |
| * milan gone | 15:27 | |
| *** milan has quit IRC | 15:27 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 15:28 | |
| *** Guest8298 is now known as rook-LOLLLL | 15:28 | |
| jroll | vsaienk0: +2 | 15:31 |
| jroll | I'll wait for the newton one until this lands | 15:31 |
| jroll | sambetts: mind reviewing 419510? | 15:32 |
| sambetts | jroll: sure :) | 15:32 |
| jroll | lucasagomes: TheJulia: vsaienk0: https://review.openstack.org/#/c/419398 | 15:34 |
| patchbot | patch 419398 - ironic - Fix assertEqual parmeters position in unittests | 15:34 |
| jroll | there's code changes not mentioned in the commit message? | 15:34 |
| * lucasagomes checks | 15:34 | |
| * jroll doesn't understand why that's changed | 15:34 | |
| jroll | I assume it's just __class__ isn't needed, but it's odd that it's changed without a mention | 15:34 |
| jroll | meh it's fine, looking at the code, sorry to bug | 15:35 |
| lucasagomes | jroll, yeah, the other methods on top removed it alreayd | 15:35 |
| lucasagomes | tho yeah, we probably need to add it to the commit message | 15:35 |
| jroll | ¯\_(ツ)_/¯ | 15:35 |
| lucasagomes | exactly heh | 15:36 |
| * jroll changed his vote | 15:36 | |
| *** mtanino has quit IRC | 15:36 | |
| TheJulia | I looked at it and figured it would be more hassle since it was super trivial in my brain | 15:37 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _send_sensors_data concurrent https://review.openstack.org/407429 | 15:37 |
| jroll | yeah | 15:38 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Do not use loopback BMC addresses for lookup https://review.openstack.org/419526 | 15:38 |
| jroll | just at first glance I was like O_O | 15:38 |
| jroll | and didn't realize it was already approved, clicked before y'all reviewed it | 15:38 |
| *** Nisha_Agarwal has joined #openstack-ironic | 15:38 | |
| TheJulia | I think this is where my standard "it is life" reply comes in | 15:39 |
| jroll | heh | 15:39 |
| jroll | +1 | 15:39 |
| *** sacharya has joined #openstack-ironic | 15:41 | |
| *** nicodemos has quit IRC | 15:46 | |
| *** nicodemos has joined #openstack-ironic | 15:47 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Add new capabilities to ironic https://review.openstack.org/338138 | 15:48 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Allow to attach/detach VIF to portgroup https://review.openstack.org/406915 | 15:48 |
| *** Nisha_Agarwal has quit IRC | 15:48 | |
| openstackgerrit | Derek Higgins proposed openstack/ironic-python-agent: Add IPv6 unit test for _get_route_source https://review.openstack.org/419533 | 15:48 |
| openstackgerrit | Derek Higgins proposed openstack/ironic-python-agent: Convert _get_route_source to use the socket module https://review.openstack.org/419534 | 15:48 |
| *** Nisha_Agarwal has joined #openstack-ironic | 15:50 | |
| openstackgerrit | Derek Higgins proposed openstack/ironic-python-agent: iscsi: Listen for connections on both IPv4 and IPv6 ports https://review.openstack.org/411819 | 15:51 |
| openstackgerrit | Derek Higgins proposed openstack/ironic-python-agent: Agent: Listen for connections on both IPv4 and IPv6 ports https://review.openstack.org/411818 | 15:51 |
| openstackgerrit | Derek Higgins proposed openstack/ironic-python-agent: Add IPv6 unit test for _get_route_source https://review.openstack.org/419533 | 15:51 |
| openstackgerrit | Derek Higgins proposed openstack/ironic-python-agent: Convert _get_route_source to use the socket module https://review.openstack.org/419534 | 15:51 |
| *** wajdi has joined #openstack-ironic | 15:52 | |
| NobodyCam | Good Morning Ironic'ers | 15:53 |
| dtantsur | hey-hey NobodyCam! | 15:53 |
| NobodyCam | morning dtantsur :) | 15:54 |
| TheJulia | good morning NobodyCam | 15:54 |
| Nisha_Agarwal | morning NobodyCam | 15:54 |
| NobodyCam | Morning TheJulia, Nisha_Agarwal :) | 15:55 |
| *** srobert has joined #openstack-ironic | 15:56 | |
| rloo | vdrok: if you didn't notice, you should rebase https://review.openstack.org/#/c/406915/ on top of https://review.openstack.org/#/c/419398/ | 15:56 |
| patchbot | patch 406915 - ironic - Allow to attach/detach VIF to portgroup | 15:56 |
| patchbot | patch 419398 - ironic - Fix assertEqual parmeters position in unittests | 15:56 |
| rloo | morning NobodyCam! | 15:57 |
| NobodyCam | Good Morning rloo :) | 15:57 |
| vdrok | rloo: yes, I didn't :) | 15:57 |
| vdrok | morning rloo NobodyCam TheJulia | 15:58 |
| *** aslezil_ has joined #openstack-ironic | 15:58 | |
| NobodyCam | morning vdrok :) | 15:58 |
| *** pcaruana has joined #openstack-ironic | 15:58 | |
| rloo | vdrok: :) and sorry about those late comments | 15:58 |
| vdrok | np | 15:58 |
| vdrok | rloo: better to look at newest PS tests, I've added some comments there | 15:59 |
| rloo | vdrok: ok | 15:59 |
| *** absubram has joined #openstack-ironic | 15:59 | |
| *** rpioso has joined #openstack-ironic | 16:02 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/python-ironicclient: [WIP] ETAGs for node in ironicclient https://review.openstack.org/400335 | 16:03 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: Agent driver rescue implementation https://review.openstack.org/400437 | 16:04 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: Add API and conductor methods for [un]rescue https://review.openstack.org/350831 | 16:04 |
| *** amarao has joined #openstack-ironic | 16:04 | |
| *** rbudden has joined #openstack-ironic | 16:05 | |
| *** aparnav has quit IRC | 16:08 | |
| openstackgerrit | Merged openstack/ironic: Don't translate exceptions w/ no message https://review.openstack.org/418374 | 16:10 |
| *** rook-LOLLLL is now known as rook | 16:10 | |
| vdrok | rloo: do you think we should include https://review.openstack.org/418894 in release too? | 16:11 |
| patchbot | patch 418894 - python-ironicclient - Extend VIF attach commands | 16:11 |
| vdrok | it's not really required for nova side | 16:11 |
| rloo | vdrok: i don't think so. | 16:11 |
| *** sacharya_ has joined #openstack-ironic | 16:11 | |
| rloo | vdrok: i am even wondering whether we should include it soon. ie maybe we shouldn't until it is needed. | 16:11 |
| rloo | vdrok: cuz nothing in ironic uses anything other than id right now | 16:12 |
| *** yufei has joined #openstack-ironic | 16:12 | |
| vdrok | rloo: well, it won't hurt, if someone wants to write a custom network interface with custom attachment and use client. but yeah, otherwise not needed | 16:12 |
| rloo | vdrok: yeah, that's the only reason. an outoftree interface in the meantime. | 16:13 |
| rloo | vdrok: anyway, i'm ok with it going in if it is ready :) | 16:13 |
| rloo | vdrok: main goal is getting client out to unblock nova part | 16:13 |
| *** rajinir has joined #openstack-ironic | 16:14 | |
| *** sacharya has quit IRC | 16:14 | |
| openstackgerrit | Merged openstack/ironic: Fix assertEqual parmeters position in unittests https://review.openstack.org/419398 | 16:15 |
| *** rama_y_ has quit IRC | 16:19 | |
| *** rama_y has quit IRC | 16:19 | |
| *** xhku_ has joined #openstack-ironic | 16:22 | |
| *** ccamacho has quit IRC | 16:23 | |
| *** xhku has quit IRC | 16:25 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Fix some mispellings in comments https://review.openstack.org/419551 | 16:26 |
| *** ccamacho has joined #openstack-ironic | 16:27 | |
| *** AlexeyAbashkin has quit IRC | 16:27 | |
| jroll | wtf: http://logs.openstack.org/10/419510/1/check/gate-ironic-pep8-ubuntu-xenial/4cbd9bd/console.html#_2017-01-12_15_23_40_342040 | 16:33 |
| jroll | on a patch that didn't touch that: https://review.openstack.org/#/c/419510/ | 16:33 |
| patchbot | patch 419510 - ironic - Allow to set min,max API microversion in tempest | 16:33 |
| jroll | ಠ_ಠ| 16:33 |
| jroll | oh the parent did that | 16:33 |
| jroll | but didn't fail CI | 16:33 |
| jroll | O_o | 16:33 |
| dtantsur | o_O | 16:34 |
| jroll | oh | 16:34 |
| jroll | rebased on older version | 16:34 |
| jroll | ignore me, I think it's being taken care of :P | 16:34 |
| lucasagomes | Nisha_Agarwal, hi there, re: https://review.openstack.org/#/c/338138/ I'm a bit confused... So the spec doesn't impact on anything... What it's actually doing ? Say one set "logical_raid_level_1" and request it | 16:36 |
| patchbot | patch 338138 - ironic-specs - Add new capabilities to ironic | 16:36 |
| lucasagomes | Nisha_Agarwal, does that imply that the driver supporting that capability should create a RAID with that level ? | 16:36 |
| lucasagomes | or simply, "cpu_vt=True" means that the driver should flip the VT bit according to it ? | 16:37 |
| *** links has quit IRC | 16:37 | |
| *** aparnav has joined #openstack-ironic | 16:38 | |
| *** blinky_ghost has joined #openstack-ironic | 16:38 | |
| jroll | lucasagomes: I think that's all just for nova to schedule on | 16:39 |
| jroll | which I've never liked :( | 16:39 |
| *** mtanino has joined #openstack-ironic | 16:39 | |
| lucasagomes | jroll, ok, so it basically finds out what the node is and just use it for scheduling ? | 16:40 |
| Nisha_Agarwal | lucasagomes, | 16:40 |
| jroll | I almost want to wait for nova's traits stuff but that's probably too far out to wait :/ | 16:40 |
| Nisha_Agarwal | lucasagomes, no it doesnt create raid here | 16:40 |
| lucasagomes | I left a comment on 2 capabilities there that I couldn't understand exactly why they are capability | 16:40 |
| *** aparna has joined #openstack-ironic | 16:40 | |
| jroll | lucasagomes: I assume so, will let Nisha_Agarwal answer | 16:40 |
| Nisha_Agarwal | it is for scheduling purpose as RAID is done today with cleaning steps | 16:40 |
| Nisha_Agarwal | we can have multiple RAIDs configured today | 16:41 |
| Nisha_Agarwal | but only one is the boot volume | 16:41 |
| vdrok | jroll: yeah, traits and resource classes will definitely bring more consistency there. at least we won't have to use capabilities filter to specify quantities, like gpus=10 | 16:41 |
| jroll | vdrok: yep | 16:42 |
| Nisha_Agarwal | so if operator wants to select the node with raid levels also(which may not be used for boot always) | 16:42 |
| * jroll is excited to see what nova+ironic looks like in 2 years or so | 16:42 | |
| * sambetts is excited to see what hardware will be able to do in 2 years | 16:43 | |
| vdrok | lucasagomes: the product_id one is for requesting a specific product to be present iiuc. the vendor one yeah, seems it can be replaces with vendor_gpu_count | 16:43 |
| *** aparnav has quit IRC | 16:43 | |
| Nisha_Agarwal | lucasagomes, does it answer ur ques | 16:43 |
| *** aslezil_ has quit IRC | 16:43 | |
| *** rama_y_ has joined #openstack-ironic | 16:44 | |
| *** rama_y has joined #openstack-ironic | 16:44 | |
| vdrok | like not just nvidia, but geforce 2 mx :D | 16:44 |
| jroll | sambetts: doesn't matter to us much until people get all the old crap out of their DCs :( | 16:44 |
| lucasagomes | Nisha_Agarwal, I see | 16:45 |
| lucasagomes | vdrok, gotcha! Yeah it had no explanation there so I was confused a bit | 16:45 |
| blinky_ghost | hi maybe this is the right channel to ask: I'm trying to deploy tripleo newton and I'm getting this error in ironic when trying to discover hw: instack.itcenter.local dnsmasq-dhcp[4098]: DHCPDISCOVER(tap2e59947b-28) a4:ba:db:40:29:33 no address available. Any Hint? thanks | 16:46 |
| openstackgerrit | Joanna Taryma proposed openstack/ironic-specs: Clean invalid conflict response usages and unnecessary retries https://review.openstack.org/414194 | 16:46 |
| sambetts | jroll: good point | 16:46 |
| Nisha_Agarwal | lucasagomes, regarding cpu_vt it may be similar to boot_mode...not very sure ...i had taken it from inspector | 16:46 |
| jroll | blinky_ghost: probably better off in #tripleo | 16:46 |
| sambetts | jroll: although Ironic doing cool stuff with new hardware might push them to update | 16:46 |
| sambetts | jroll: /me hopes | 16:46 |
| jroll | sambetts: yeah, +1, I'm excited | 16:47 |
| blinky_ghost | jroll: ok thanks :) | 16:47 |
| jroll | :) | 16:47 |
| *** aparna has quit IRC | 16:49 | |
| lucasagomes | Nisha_Agarwal, cool, so overall the spec looks good to me. It would be good to have some explanation on that capability that vdrok mentioned about the product id | 16:49 |
| lucasagomes | Nisha_Agarwal, and maybe just removing the vendor id one ? If you think it's not necessary | 16:49 |
| * lucasagomes commented on the spec | 16:49 | |
| Nisha_Agarwal | lucasagomes, yes i saw the comments ....yes it looks sensible to me | 16:50 |
| rloo | vdrok: sorry, i keep getting distracted. will really focus on the tests for 406915 now. i think... | 16:51 |
| vdrok | rloo: np. naming is hard for me. do you have any suggestion for naming these functions (or one combined if you prefer that) | 16:52 |
| lucasagomes | Nisha_Agarwal, maybe also mention that, there's no actions taken based on those capabilities | 16:52 |
| *** chlong has quit IRC | 16:52 | |
| lucasagomes | it's only used for scheduling, to make it more clear | 16:52 |
| lucasagomes | cause I couldn't get that by reading the spec | 16:52 |
| Nisha_Agarwal | ok | 16:52 |
| JayF | Can another stable core look at + potentially land https://review.openstack.org/#/c/408222/ -- thanks. | 16:52 |
| patchbot | patch 408222 - ironic-python-agent (stable/newton) - Skip API related work if no api url configured | 16:52 |
| Nisha_Agarwal | lucasagomes, sure will add that | 16:53 |
| lucasagomes | given that, for some stuff like boot_mode we do actully change the boot mode depending on the driver | 16:53 |
| lucasagomes | nicodemos, thanks | 16:53 |
| lucasagomes | ops | 16:53 |
| rloo | vdrok: for combined, something like _get_availorfree_portgroups_and_ports(). | 16:53 |
| lucasagomes | nicodemos, sorry, wrong ping :-) | 16:53 |
| lucasagomes | Nisha_Agarwal, ok thanks | 16:53 |
| nicodemos | lucasagomes: np :) | 16:53 |
| vdrok | rloo: why avail ? :) | 16:53 |
| rloo | vdrok: or free. whatever you call it. | 16:53 |
| jroll | JayF: I can +2 but stable/newton is out to lunch atm | 16:53 |
| rloo | vdrok: they are available to be used :) | 16:54 |
| vdrok | rloo: ok, will do | 16:54 |
| JayF | jroll: okie, when it's well fed and happy again at least I'll be able to land it | 16:54 |
| rloo | vdrok: but maybe free is better cuz that's how we 'talk' about it | 16:54 |
| jroll | ya | 16:54 |
| JayF | jroll: assuming someone already on that fix? | 16:54 |
| jroll | JayF: yeah, vsaienk0 has it | 16:54 |
| rloo | vdrok: so does that mean i can wait to review the tests? (my ulterior motive :D) | 16:55 |
| *** e0ne has quit IRC | 16:55 | |
| vdrok | rloo: hah, whatever you prefer :) | 16:55 |
| vdrok | I can wait, I can push now | 16:55 |
| vdrok | well, after renaming | 16:55 |
| jroll | JayF: +2'd | 16:55 |
| rloo | vdrok: push now. i'll take a break for lunch first. | 16:56 |
| vdrok | rloo: ok, no probs :) | 16:56 |
| rloo | vdrok: really, i hate reviewing test stuff. so i go with procrastination if i can. | 16:56 |
| vdrok | rloo: I'm with you on that :) | 16:56 |
| *** Syed__ has joined #openstack-ironic | 16:58 | |
| JayF | AFAICT the stable/newton fix looks good and is waiting more core reviews? https://review.openstack.org/#/c/419428/7 | 16:58 |
| patchbot | patch 419428 - ironic - Skip VIF api tests for old api versions | 16:58 |
| JayF | I'm going to add my +2 but not land in case there's something I'm missing here about why it's not been landed | 16:59 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Add new capabilities to ironic https://review.openstack.org/338138 | 17:01 |
| Nisha_Agarwal | lucasagomes, vdrok, ^^^ | 17:01 |
| jlvillal | JayF, I don't think it can land until the tempest changes land. | 17:02 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: WIP: API changes for driver-composition https://review.openstack.org/417970 | 17:02 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Enable manual-management hardware type in devstack https://review.openstack.org/417920 | 17:02 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Expose default interface calculation from driver_factory https://review.openstack.org/418573 | 17:02 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add hardware types to the hash ring https://review.openstack.org/419065 | 17:02 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Register/unregister hardware interfaces for conductors https://review.openstack.org/412631 | 17:02 |
| jroll | api version rebases are the worstest | 17:02 |
| jroll | JayF: that's only part of it | 17:02 |
| jlvillal | JayF, I was thinking the other patch. | 17:03 |
| jroll | JayF: still needs https://review.openstack.org/#/c/419510/ <- and a backport to newton with different versions | 17:03 |
| patchbot | patch 419510 - ironic - Allow to set min,max API microversion in tempest | 17:03 |
| jroll | (and mitaka because mitaka) | 17:03 |
| jroll | JayF: one more highlight just to make it a full on bombardment :) | 17:04 |
| * jroll goes to lunch | 17:04 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add base cinder common interface https://review.openstack.org/355625 | 17:04 |
| dtantsur | jroll, database changes rebases are worse :) | 17:04 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add Cinder storage driver https://review.openstack.org/366197 | 17:04 |
| jroll | dtantsur: fair :) | 17:04 |
| jlvillal | vsaienk0, Are you fixing pep8 issue? | 17:04 |
| jlvillal | https://review.openstack.org/#/c/419510/ | 17:05 |
| patchbot | patch 419510 - ironic - Allow to set min,max API microversion in tempest | 17:05 |
| jlvillal | I can jump on it... | 17:05 |
| *** mjura has quit IRC | 17:05 | |
| jroll | it just needs a rebase for the pep8 (and to get out from under that test patch) | 17:05 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Wire in storage interface attach/detach operations https://review.openstack.org/406290 | 17:06 |
| * jroll actually lunches now | 17:06 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: [WIP] iPXE template support for iSCSI https://review.openstack.org/413324 | 17:06 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add REST API for volume connector and volume target operation https://review.openstack.org/214586 | 17:06 |
| *** mtani____ has joined #openstack-ironic | 17:07 | |
| *** mtanino has quit IRC | 17:07 | |
| * jlvillal starts investigating | 17:07 | |
| *** xek has quit IRC | 17:07 | |
| jlvillal | Not sure how that pep8 issue happened? Since patch doesn't appear to touch that code... | 17:08 |
| *** xek has joined #openstack-ironic | 17:08 | |
| jlvillal | jroll, Ah. Thanks | 17:09 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Allow to set min,max API microversion in tempest https://review.openstack.org/419510 | 17:13 |
| *** ralonsoh_ has quit IRC | 17:13 | |
| sambetts | TheJulia: QQ about bifrost, while running playbook install.yaml how does hostvars[inventory_hostname]['ansible_' + ans_network_interface]['ipv4']['address'] get populated, I'm seeing a failure saying that the ipv4 key is missing | 17:13 |
| jlvillal | JayF, Can you look at: https://review.openstack.org/#/c/419510/2 please? | 17:14 |
| patchbot | patch 419510 - ironic - Allow to set min,max API microversion in tempest | 17:14 |
| jlvillal | TheJulia, sambetts vdrok lucasagomes dtantsur ^^^ | 17:14 |
| TheJulia | sambetts: Automatically, just ans_network_interface needs to point to a real network interface that you intend to use | 17:14 |
| sambetts | TheJulia: does that interface need to have an IP already then? | 17:14 |
| TheJulia | sambetts: yes | 17:15 |
| TheJulia | sambetts: that pulls the ipv4 address off of the inventory data that sensible collects | 17:15 |
| TheJulia | err, ansible | 17:15 |
| * TheJulia curses autocorrect | 17:15 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Allow to attach/detach VIF to portgroup https://review.openstack.org/406915 | 17:16 |
| sambetts | TheJulia: ah ok, we're using a separate subnet and NIC from our servers main NIC so didn't set any address on it assuming bifrost would just take it over and sort it out based on the dhcp pool or something | 17:16 |
| *** trown is now known as trown|lunch | 17:16 | |
| sambetts | TheJulia: there isn't a varaible we can see to make it do that right? | 17:17 |
| sambetts | TheJulia: we have to set up the hosts interface manually | 17:17 |
| sambetts | ? | 17:17 |
| *** swatson has joined #openstack-ironic | 17:17 | |
| TheJulia | sambetts: yes, we don't know what addressing you will want to use much less what interface, so it is one of the few things that someone setting up needs to change | 17:17 |
| TheJulia | sambetts: There is not a variable to make it do the interface setup for you :) | 17:18 |
| TheJulia | jlvillal: I +A'ed that revision | 17:18 |
| sambetts | TheJulia: ah, I would have assumed having picked set the interface and the dhcp pool in group_vars it would also do the hosts IP | 17:18 |
| jlvillal | TheJulia, thank you | 17:18 |
| sambetts | s/picked// | 17:18 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Allow to set min,max API microversion in tempest https://review.openstack.org/419430 | 17:19 |
| jlvillal | stable/newton version ^^^ Will depend on tempest changes landing first | 17:19 |
| vdrok | morning jlvillal ! | 17:19 |
| TheJulia | sambetts: That would be pretty cool.... | 17:19 |
| swatson | Hey channel! Anyone familiar with ironic and its gate jobs? | 17:20 |
| jlvillal | vdrok, Hi :) | 17:20 |
| TheJulia | swatson: Greetings | 17:21 |
| swatson | TheJulia: Hey! Do you know about the ironic gate jobs by chance? I have some questions about it if you don't mind | 17:22 |
| TheJulia | swatson: Best to just ask, each of us knows different things. | 17:22 |
| dtantsur | swatson, a lot of people here know quite something about it :) | 17:22 |
| swatson | TheJulia dtantsur: Alright, here goes :) | 17:23 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: Allow to set min,max API microversion in tempest https://review.openstack.org/419516 | 17:23 |
| jlvillal | stable/mitaka version ^^^^ | 17:23 |
| TheJulia | jlvillal: thank you | 17:23 |
| swatson | I'm implementing migration tests for magnum, borrowing heavily from ironic's own implementation | 17:23 |
| *** dsneddon_afk is now known as dsneddon | 17:23 | |
| swatson | The tests run and pass (barring 1, to be fixed later) on my machine, but on jenkins they fail to connect | 17:23 |
| jlvillal | I look forward to my patch landing: https://review.openstack.org/#/c/417450/ | 17:23 |
| patchbot | patch 417450 - openstack-infra/gerritbot - For patch submitted/merged, announce the branch | 17:23 |
| swatson | It appears to be that the DB for magnum doesn't have the openstack_citest user created when the tests run | 17:24 |
| swatson | Our magnum job doesn't seem to have anything that creates the user, so I took a look at the job for ironic but couldn't identify where it was getting created there either | 17:25 |
| swatson | For reference: https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/magnum.yaml | 17:25 |
| jlvillal | vsaienk0, FYI: I rebased the tempest variable setting patch | 17:26 |
| *** rama_y has quit IRC | 17:26 | |
| *** rama_y_ has quit IRC | 17:26 | |
| TheJulia | swatson: so I ran into issues like that with bifrost, https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/bifrost.yaml#L12 | 17:26 |
| TheJulia | swatson: but, for ironic it's self, it is node type your scheduled upon I believe | 17:26 |
| *** chlong has joined #openstack-ironic | 17:26 | |
| TheJulia | swatson: some of the templates run those two steps, some don't if memory serves | 17:27 |
| *** ccamacho has quit IRC | 17:28 | |
| swatson | TheJulia: I'm guessing mysql-prep is a macro available to anything on Jenkins? | 17:28 |
| TheJulia | swatson: yup | 17:28 |
| swatson | TheJulia: OK cool! Do you know happen to know where it's defined in openstack-infra? | 17:29 |
| TheJulia | swatson: Off the top of my head I do not, but it shouldn't be hard to find with grep | 17:30 |
| *** moshele has quit IRC | 17:30 | |
| swatson | TheJulia: I'll take a look for it :) Thanks for the help! | 17:30 |
| TheJulia | swatson: no problem! | 17:33 |
| sambetts | Thanks TheJulia, things seem to be proceeding now :) | 17:34 |
| TheJulia | \o/ | 17:34 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/419339 | 17:36 |
| *** derekh has quit IRC | 17:43 | |
| lucasagomes | folks, I'm calling it a day | 17:48 |
| *** karthiks has quit IRC | 17:48 | |
| lucasagomes | have a great evening all | 17:48 |
| TheJulia | goodnight lucasagomes | 17:49 |
| NobodyCam | night lucasagomes | 17:49 |
| nicodemos | night lucasagomes | 17:49 |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic-inspector: Update documentation to deploy Ironic Inspector with DevStack https://review.openstack.org/410456 | 17:49 |
| lucasagomes | o/ | 17:50 |
| *** lucasagomes is now known as lucas-afk | 17:50 | |
| *** yufei has quit IRC | 17:55 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 17:59 | |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: Reboot and Poweroff fails with coreos IPA image https://review.openstack.org/412594 | 18:00 |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic-inspector-specs: Collect Bios, Memory and Processor Info from Dmidecode https://review.openstack.org/406790 | 18:07 |
| openstackgerrit | Merged openstack/ironic: Skip VIF api tests for old api versions https://review.openstack.org/419428 | 18:11 |
| *** rama_y_ has joined #openstack-ironic | 18:13 | |
| *** rama_y has joined #openstack-ironic | 18:13 | |
| *** sacharya has joined #openstack-ironic | 18:17 | |
| *** sacharya_ has quit IRC | 18:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/419339 | 18:18 |
| JayF | the requirements keeps updating faster than they can merge | 18:19 |
| *** chlong has quit IRC | 18:19 | |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: Reboot and Poweroff fails with coreos IPA image https://review.openstack.org/412594 | 18:23 |
| *** ijw_ has quit IRC | 18:24 | |
| *** chlong has joined #openstack-ironic | 18:32 | |
| *** openstackgerrit has quit IRC | 18:33 | |
| *** pcaruana has quit IRC | 18:34 | |
| *** openstackgerrit has joined #openstack-ironic | 18:37 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Update troubleshooting docs on no valid host found error https://review.openstack.org/419595 | 18:37 |
| *** wajdi has quit IRC | 18:39 | |
| * sambetts -> home | 18:41 | |
| sambetts | night all | 18:41 |
| *** sambetts is now known as sambetts|afk | 18:41 | |
| *** jkilpatr has quit IRC | 18:43 | |
| openstackgerrit | Solio Sarabia proposed openstack/ironic-tempest-plugin: WIP/DNN: Migrate ironic-tempest-plugin to new repo https://review.openstack.org/419602 | 18:43 |
| NobodyCam | night sambetts|afk | 18:44 |
| openstackgerrit | Merged openstack/ironic: Fix take over for ACTIVE nodes in PXEBoot https://review.openstack.org/404858 | 18:44 |
| *** trown|lunch is now known as trown | 18:45 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP/DNM Testing tempest "smoke" 2 https://review.openstack.org/407258 | 18:47 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Update troubleshooting docs on no valid host found error https://review.openstack.org/419595 | 18:48 |
| *** jkilpatr has joined #openstack-ironic | 18:49 | |
| dtantsur | the day full of troubleshooting ^^^ :) | 18:50 |
| dtantsur | and now my watch is over, see you tomorrow | 18:50 |
| *** tesseract has quit IRC | 18:51 | |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: [WIP] Add documentation for using rescue mode https://review.openstack.org/419606 | 18:52 |
| rloo | ciao dtantsur | 18:52 |
| rloo | dtantsur: and thx for troubleshooting :) | 18:52 |
| *** dtantsur is now known as dtantsur|afk | 18:53 | |
| dtantsur|afk | :) | 18:53 |
| NobodyCam | night dtantsur|afk | 18:54 |
| *** AlexeyAbashkin has quit IRC | 18:55 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 18:59 | |
| *** ijw has joined #openstack-ironic | 18:59 | |
| *** ijw has quit IRC | 19:00 | |
| *** ijw has joined #openstack-ironic | 19:00 | |
| *** blinky_ghost has quit IRC | 19:00 | |
| *** AlexeyAbashkin has quit IRC | 19:01 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR Test patch https://review.openstack.org/419443 | 19:04 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update validate_ports from BaremetalBasicOps https://review.openstack.org/419612 | 19:04 |
| *** nicodemos has quit IRC | 19:06 | |
| *** nicodemos has joined #openstack-ironic | 19:06 | |
| NobodyCam | night dtantsur|afk | 19:07 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update validate_ports from BaremetalBasicOps https://review.openstack.org/419612 | 19:07 |
| *** Nisha_Agarwal has quit IRC | 19:08 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update validate_ports from BaremetalBasicOps https://review.openstack.org/419612 | 19:08 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR Test patch https://review.openstack.org/419443 | 19:08 |
| *** amoralej is now known as amoralej|off | 19:17 | |
| *** rama_y has quit IRC | 19:19 | |
| *** rama_y_ has quit IRC | 19:19 | |
| *** [1]rpioso has joined #openstack-ironic | 19:19 | |
| *** rpioso has quit IRC | 19:21 | |
| *** [1]rpioso has quit IRC | 19:24 | |
| *** rajinir has quit IRC | 19:26 | |
| *** ChubYann has joined #openstack-ironic | 19:31 | |
| *** makowals has quit IRC | 19:32 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic-lib: Fix exception for multiple devices with same label https://review.openstack.org/419621 | 19:34 |
| *** makowals has joined #openstack-ironic | 19:35 | |
| *** rama_y has joined #openstack-ironic | 19:38 | |
| *** rama_y_ has joined #openstack-ironic | 19:38 | |
| *** chlong has quit IRC | 19:41 | |
| *** lucas-afk has quit IRC | 19:41 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update validate_ports from BaremetalBasicOps https://review.openstack.org/419612 | 19:42 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR Test patch https://review.openstack.org/419443 | 19:42 |
| *** jkilpatr has quit IRC | 19:43 | |
| *** rook has quit IRC | 19:43 | |
| *** rook has joined #openstack-ironic | 19:44 | |
| *** lucasagomes has joined #openstack-ironic | 19:44 | |
| *** rook is now known as Guest87706 | 19:44 | |
| *** rajinir has joined #openstack-ironic | 19:45 | |
| *** Guest87706 is now known as rook-lollll | 19:45 | |
| rajinir | krtaylor: Have a question on MI. When I add a new node, do I have to restart MI? | 19:46 |
| *** mgoddard has joined #openstack-ironic | 19:46 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Allow to attach/detach VIF to portgroup https://review.openstack.org/406915 | 19:49 |
| vdrok | rloo: updated inconsistencies in tests ^ don't really want to refactor those common methods tests :) | 19:50 |
| vdrok | and thanks for reviews! :) | 19:50 |
| rloo | vdrok: ok, i was just about to start another review; will look at yours first :) | 19:50 |
| *** e0ne has joined #openstack-ironic | 19:54 | |
| *** jkilpatr has joined #openstack-ironic | 19:55 | |
| krtaylor | rajinir, via the add command? no, you shouldn't have to - what are you seeing? | 19:56 |
| *** mgoddard_ has joined #openstack-ironic | 19:56 | |
| krtaylor | mjturek, hamzy ^^^ | 19:56 |
| rajinir | krtaylor: ok, good. Just about to add new nodes, so wanted to check | 19:56 |
| rajinir | Thanks | 19:56 |
| krtaylor | ah, ok, sure np | 19:56 |
| hamzy | yeah, no you don't have to restart | 19:57 |
| *** chlong has joined #openstack-ironic | 19:57 | |
| krtaylor | rajinir, let me know how it goes with MI, anything that you'd like to add, etc | 19:57 |
| *** mgoddard has quit IRC | 19:57 | |
| krtaylor | or any of us | 19:57 |
| rajinir | krtaylor: sure, ty | 19:57 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Update validate_ports from BaremetalBasicOps https://review.openstack.org/419612 | 19:57 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR Test patch https://review.openstack.org/419443 | 19:58 |
| *** mgoddard has joined #openstack-ironic | 19:58 | |
| *** e0ne has quit IRC | 19:59 | |
| *** mgoddard_ has quit IRC | 20:01 | |
| openstackgerrit | Merged openstack/ironic: Fix logging if power interface does not support timeout https://review.openstack.org/418871 | 20:01 |
| *** e0ne has joined #openstack-ironic | 20:02 | |
| *** causten has quit IRC | 20:04 | |
| vdrok | rloo: you won't be setting vif on a port inside a portgroup, unless one of the ports has vif on it | 20:05 |
| vdrok | attach won't be doing it | 20:05 |
| vdrok | so the only way to achieve this is to set vif manually, by updating extra | 20:05 |
| vdrok | which will check that portgroup this port belongs to has standalone_ports_supported=True | 20:06 |
| vdrok | I know it's confusing, but that's what we have to deal with while we have attachment possible in two places, writing values to two different fields :( | 20:06 |
| rloo | vdrok: argh. ok, i take your word for it :) | 20:07 |
| -openstackstatus- NOTICE: Gerrit will be offline between now and 20:30 for scheduled maintenance: http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html | 20:08 | |
| *** ChanServ changes topic to "Gerrit will be offline between now and 20:30 for scheduled maintenance: http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html" | 20:08 | |
| jroll | welp | 20:08 |
| rloo | oh, i missed that email. 30 minute break i guess. | 20:09 |
| *** causten has joined #openstack-ironic | 20:09 | |
| *** causten has quit IRC | 20:10 | |
| *** [1]rpioso has joined #openstack-ironic | 20:11 | |
| *** mjturek has quit IRC | 20:12 | |
| vdrok | so, time to go then :) | 20:13 |
| vdrok | good night everyone! | 20:14 |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Extend VIF attach commands https://review.openstack.org/418894 | 20:15 |
| *** Sukhdev has joined #openstack-ironic | 20:18 | |
| rloo | good night vdrok! | 20:19 |
| *** awiddersheim has joined #openstack-ironic | 20:21 | |
| *** awidders_ has quit IRC | 20:21 | |
| *** awidders_ has joined #openstack-ironic | 20:23 | |
| *** awiddersheim has quit IRC | 20:23 | |
| *** awiddersheim has joined #openstack-ironic | 20:25 | |
| *** awidders_ has quit IRC | 20:25 | |
| *** e0ne has quit IRC | 20:26 | |
| *** mjturek has joined #openstack-ironic | 20:28 | |
| *** awiddersheim has quit IRC | 20:31 | |
| *** awiddersheim has joined #openstack-ironic | 20:32 | |
| NobodyCam | night vdrok | 20:32 |
| jlvillal | vdrok, Paka paka. Dos ve dos | 20:32 |
| -openstackstatus- NOTICE: Updated: Gerrit will be offline until 20:45 for scheduled maintenance (running longer than anticipated): http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html | 20:33 | |
| *** ChanServ changes topic to "Updated: Gerrit will be offline until 20:45 for scheduled maintenance (running longer than anticipated): http://lists.openstack.org/pipermail/openstack-dev/2017-January/109910.html" | 20:33 | |
| *** jrist has quit IRC | 20:33 | |
| *** chlong has quit IRC | 20:44 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 20:44 | |
| *** Goneri has quit IRC | 20:46 | |
| *** jrist has joined #openstack-ironic | 20:47 | |
| *** e0ne has joined #openstack-ironic | 20:48 | |
| *** d0ugal has quit IRC | 20:52 | |
| *** ChanServ changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic" | 20:53 | |
| mrda | Morning Ironic | 20:54 |
| *** d0ugal has joined #openstack-ironic | 20:54 | |
| *** d0ugal has quit IRC | 20:54 | |
| *** d0ugal has joined #openstack-ironic | 20:54 | |
| *** chlong has joined #openstack-ironic | 20:58 | |
| *** AlexeyAbashkin has quit IRC | 20:59 | |
| *** david-lyle has quit IRC | 21:01 | |
| *** david-lyle has joined #openstack-ironic | 21:02 | |
| *** d0ugal has quit IRC | 21:03 | |
| *** chlong has quit IRC | 21:04 | |
| *** e0ne has quit IRC | 21:06 | |
| NobodyCam | morning mrda | 21:07 |
| jroll | why can't I pass a list over rpc, this is dumb | 21:10 |
| jroll | morning mrda | 21:10 |
| *** [1]rpioso is now known as rpioso | 21:11 | |
| *** mgoddard has quit IRC | 21:16 | |
| *** openstackgerrit has quit IRC | 21:18 | |
| *** chlong has joined #openstack-ironic | 21:18 | |
| mrda | o/ | 21:23 |
| jkilpatr | if I needed to restart everything ironic related (to load a new config) how would I do that? | 21:23 |
| *** hamzy has quit IRC | 21:25 | |
| jkilpatr | ok found it | 21:26 |
| *** athomas has quit IRC | 21:26 | |
| jroll | jlvillal: that type I mentioned: https://github.com/rust-lang/rfcs/blob/master/text/1216-bang-type.md | 21:30 |
| jlvillal | jroll, Thanks | 21:31 |
| *** rama_y_ has quit IRC | 21:32 | |
| *** rama_y has quit IRC | 21:32 | |
| jroll | yerp | 21:33 |
| *** jkilpatr has quit IRC | 21:33 | |
| rloo | jroll: did you cut a client release yet? this looks ready to go: https://review.openstack.org/#/c/418894/ | 21:38 |
| patchbot | patch 418894 - python-ironicclient - Extend VIF attach commands | 21:38 |
| *** causten has joined #openstack-ironic | 21:42 | |
| jroll | rloo: yeah, it's done | 21:45 |
| jroll | rloo: we should wait for the soft power patch before we release another, I think | 21:45 |
| rloo | jroll: no worries. glad it's done! | 21:45 |
| rloo | jroll: do you know if the nova-related patch for attach/detach has been updated/ready to be reviewed? | 21:45 |
| *** ccamacho has joined #openstack-ironic | 21:47 | |
| jroll | rloo: I think so yes | 21:49 |
| jroll | I'd have to check again | 21:49 |
| rloo | jroll: ok, i'll take a look in a few min | 21:49 |
| *** jcoufal has quit IRC | 21:51 | |
| *** openstackgerrit has joined #openstack-ironic | 21:51 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/419339 | 21:51 |
| jroll | rloo: thanks, I'm trying to finish up some hairy driver comp stuff and then maybe be able to look | 21:52 |
| rloo | jroll: good luck. your mission is to make the driver comp stuff simple and easy to understand :) | 21:53 |
| jroll | rloo: if that is your expectation I am so sorry | 21:54 |
| * TheJulia +A's the g-r update.... again | 21:54 | |
| JayF | lol | 21:54 |
| JayF | that patch is freaking hilarious | 21:54 |
| rloo | jroll: no, just hoping. no expectations. but would be pleasantly surprised if :) | 21:55 |
| NobodyCam | JayF: I love lines like that :p > x but not x+1, x+1.01, x+1.02 | 21:57 |
| JayF | I just imagine that our reapprovals are just required because we didn't get to get broken yet | 21:58 |
| JayF | lol | 21:58 |
| NobodyCam | lol | 21:58 |
| TheJulia | JayF: Well, surely that will happen now ;) | 21:59 |
| *** amotoki has joined #openstack-ironic | 22:01 | |
| *** trown is now known as trown|outtypewww | 22:01 | |
| openstackgerrit | Merged openstack/ironic-specs: Abort in RESCUEWAIT should be supported https://review.openstack.org/417205 | 22:05 |
| *** d0ugal has joined #openstack-ironic | 22:07 | |
| *** absubram has quit IRC | 22:07 | |
| JayF | jcook: ^ fyi, the spec change merged in | 22:10 |
| JayF | jcook: jlvillal was nice enough to land it during the review party | 22:10 |
| openstackgerrit | Varun Gadiraju proposed openstack/ironic: WIP/DNM: Trying to test grenade multi-tenant experimental job https://review.openstack.org/403895 | 22:12 |
| *** jkilpatr has joined #openstack-ironic | 22:15 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: WIP: API changes for driver-composition https://review.openstack.org/417970 | 22:16 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: WIP: Add get_hardware_interface_info RPC method https://review.openstack.org/419669 | 22:16 |
| jroll | dtantsur|afk: can you look over the 2 WIP patches in my chain in the morning? I want to know how crazy it is before I go and write too many tests: https://review.openstack.org/#/q/topic:bug/1524745+status:open | 22:17 |
| jroll | thanks :) | 22:17 |
| jroll | JayF: succumbing to your coercion isn't being "nice enough" | 22:17 |
| jroll | :P | 22:17 |
| JayF | part of the coersion is giving them credit for being a nice person when they cave :P | 22:18 |
| *** wrouesnel has joined #openstack-ironic | 22:19 | |
| *** wrouesnel has quit IRC | 22:22 | |
| *** wrouesnel has joined #openstack-ironic | 22:22 | |
| *** causten has quit IRC | 22:24 | |
| *** chlong has quit IRC | 22:29 | |
| *** causten has joined #openstack-ironic | 22:31 | |
| *** dprince has quit IRC | 22:34 | |
| *** chlong has joined #openstack-ironic | 22:37 | |
| *** srobert has quit IRC | 22:44 | |
| jroll | rloo: this lgtm https://review.openstack.org/#/c/364413/14 | 22:50 |
| patchbot | patch 364413 - nova - Support Ironic interface attach/detach in nova virt | 22:50 |
| * jroll wonders if client is in g-r yet | 22:51 | |
| rloo | jroll: then you are going to hate me. i have a bunch of comments already, still reviewing | 22:51 |
| jroll | bah, constraint patch in the gate | 22:51 |
| jroll | rloo: I would never hate you for being a better reviewer than me | 22:51 |
| jroll | :) | 22:51 |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: Reboot and Poweroff fails with coreos IPA image https://review.openstack.org/412594 | 22:51 |
| rloo | jroll: :) at least i'm reviewing it now, instead of after it has a +2! | 22:52 |
| jroll | :) | 22:52 |
| *** rpioso has quit IRC | 23:12 | |
| *** jaosorior has quit IRC | 23:22 | |
| *** ElCoyote_ has quit IRC | 23:27 | |
| *** rama_y has joined #openstack-ironic | 23:29 | |
| *** rama_y_ has joined #openstack-ironic | 23:29 | |
| *** rama_y_ has quit IRC | 23:31 | |
| *** rama_y has quit IRC | 23:31 | |
| *** rook-lollll is now known as rook | 23:37 | |
| *** [1]cdearborn has quit IRC | 23:47 | |
| openstackgerrit | Merged openstack/ironic: Allow to set min,max API microversion in tempest https://review.openstack.org/419510 | 23:50 |
| *** pmannidi has joined #openstack-ironic | 23:50 | |
| *** lindycoder has quit IRC | 23:51 | |
| *** lindycoder has joined #openstack-ironic | 23:52 | |
| *** lindycoder has quit IRC | 23:52 | |
| openstackgerrit | Merged openstack/ironic-lib: Fix exception for multiple devices with same label https://review.openstack.org/419621 | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!