*** sacharya has joined #openstack-ironic | 00:03 | |
*** sacharya has quit IRC | 00:27 | |
*** sacharya has joined #openstack-ironic | 00:27 | |
*** zackf has joined #openstack-ironic | 00:39 | |
*** mtanino has quit IRC | 00:43 | |
*** zackf has quit IRC | 00:44 | |
*** hoangcx has joined #openstack-ironic | 00:54 | |
*** causten has joined #openstack-ironic | 00:56 | |
*** sacharya has quit IRC | 00:57 | |
*** alexpilotti has joined #openstack-ironic | 01:00 | |
*** causten has quit IRC | 01:01 | |
*** hw_wutianwei1 has joined #openstack-ironic | 01:02 | |
*** alexpilotti has quit IRC | 01:04 | |
*** hw_wutianwei has quit IRC | 01:05 | |
*** hw_wutianwei1 has quit IRC | 01:07 | |
*** phuongnh has joined #openstack-ironic | 01:07 | |
*** ijw has joined #openstack-ironic | 01:09 | |
*** hw_wutianwei has joined #openstack-ironic | 01:13 | |
*** ppiela has quit IRC | 01:18 | |
*** causten has joined #openstack-ironic | 01:21 | |
openstackgerrit | Cuong Nguyen proposed openstack/ironic: Use context manager for better file handling https://review.openstack.org/423121 | 01:49 |
---|---|---|
*** ijw_ has joined #openstack-ironic | 01:56 | |
*** ijw has quit IRC | 01:59 | |
*** baoli has quit IRC | 02:05 | |
*** tiendc has joined #openstack-ironic | 02:16 | |
*** hecliunyx has quit IRC | 02:21 | |
*** hecliunyx has joined #openstack-ironic | 02:27 | |
*** soliosg has quit IRC | 02:32 | |
*** soliosg_ is now known as soliosg | 02:32 | |
*** sacharya has joined #openstack-ironic | 02:43 | |
*** causten has quit IRC | 02:49 | |
*** soliosg has left #openstack-ironic | 02:50 | |
*** jerrygb has joined #openstack-ironic | 02:55 | |
*** amotoki has quit IRC | 02:59 | |
openstackgerrit | zhouya proposed openstack/ironic-python-agent: Get numa_node info when collecting pci devices info https://review.openstack.org/369245 | 03:01 |
*** rbudden has quit IRC | 03:02 | |
*** zackf has joined #openstack-ironic | 03:04 | |
*** amotoki has joined #openstack-ironic | 03:10 | |
*** zackf has quit IRC | 03:11 | |
*** amotoki has quit IRC | 03:15 | |
*** amotoki has joined #openstack-ironic | 03:20 | |
*** SerenaFeng has joined #openstack-ironic | 03:24 | |
*** SerenaFeng has quit IRC | 03:24 | |
*** SerenaFeng has joined #openstack-ironic | 03:24 | |
*** SerenaFeng has quit IRC | 03:24 | |
*** SerenaFeng has joined #openstack-ironic | 03:24 | |
*** baoli has joined #openstack-ironic | 03:26 | |
*** SerenaFeng has quit IRC | 03:27 | |
*** SerenaFeng has joined #openstack-ironic | 03:29 | |
*** baoli has quit IRC | 03:30 | |
*** amotoki_ has joined #openstack-ironic | 03:33 | |
*** amotoki has quit IRC | 03:35 | |
*** early has joined #openstack-ironic | 03:35 | |
*** early` has quit IRC | 03:36 | |
*** SerenaFeng has quit IRC | 03:39 | |
*** SerenaFeng has joined #openstack-ironic | 03:39 | |
*** amotoki_ has quit IRC | 03:42 | |
*** hecliunyx has quit IRC | 03:42 | |
*** csmart has quit IRC | 03:43 | |
*** SerenaFeng has quit IRC | 03:48 | |
*** baoli has joined #openstack-ironic | 03:53 | |
*** soliosg has joined #openstack-ironic | 03:53 | |
openstackgerrit | Dao Cong Tien proposed openstack/python-ironicclient: Extends driver-list, driver-show supporting new hardware types https://review.openstack.org/419274 | 03:54 |
openstackgerrit | Bob Fournier proposed openstack/ironic-inspector: Add plugin to process basic management LLDP TLVs https://review.openstack.org/406496 | 03:59 |
*** baoli has quit IRC | 04:00 | |
*** jerrygb has quit IRC | 04:03 | |
*** Sukhdev has joined #openstack-ironic | 04:03 | |
openstackgerrit | Bob Fournier proposed openstack/ironic-inspector: Add plugin to process basic management LLDP TLVs https://review.openstack.org/406496 | 04:09 |
*** aparnav has joined #openstack-ironic | 04:10 | |
*** amotoki has joined #openstack-ironic | 04:16 | |
*** csmart has joined #openstack-ironic | 04:17 | |
*** lindycoder has joined #openstack-ironic | 04:21 | |
openstackgerrit | Aparna proposed openstack/ironic: Doc for sanitize erase support in iLO drivers https://review.openstack.org/408441 | 04:23 |
openstackgerrit | Dao Cong Tien proposed openstack/python-ironicclient: Add args to CLI 'node-create' for selecting hardware interfaces https://review.openstack.org/418359 | 04:26 |
openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: snmp inspection for disk size https://review.openstack.org/394858 | 04:34 |
*** hecliunyx has joined #openstack-ironic | 04:44 | |
*** causten has joined #openstack-ironic | 04:50 | |
*** causten has quit IRC | 04:55 | |
*** lindycoder has quit IRC | 05:00 | |
*** hecliunyx has quit IRC | 05:00 | |
*** udesale has joined #openstack-ironic | 05:02 | |
*** sayantani01 has quit IRC | 05:03 | |
*** hecliunyx has joined #openstack-ironic | 05:08 | |
*** sayantani01 has joined #openstack-ironic | 05:13 | |
*** hecliunyx has quit IRC | 05:14 | |
openstackgerrit | Nisha Agarwal proposed openstack/ironic: SNMP agent support for OOB inspection for iLO Drivers https://review.openstack.org/372428 | 05:24 |
*** causten has joined #openstack-ironic | 05:27 | |
*** hecliunyx has joined #openstack-ironic | 05:32 | |
*** ijw_ has quit IRC | 05:32 | |
*** nmathew has joined #openstack-ironic | 05:34 | |
*** dyasny has quit IRC | 05:49 | |
*** jerrygb has joined #openstack-ironic | 06:04 | |
*** jerrygb has quit IRC | 06:08 | |
*** sacharya has quit IRC | 06:10 | |
openstackgerrit | Anh Tran proposed openstack/bifrost: Typo fix: enviroment => environment https://review.openstack.org/423929 | 06:17 |
*** causten has quit IRC | 06:24 | |
*** moshele has joined #openstack-ironic | 06:26 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add Inject NMI to api-ref https://review.openstack.org/423941 | 06:35 |
*** dyasny has joined #openstack-ironic | 06:46 | |
openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: snmp inspection for disk size https://review.openstack.org/394858 | 06:58 |
*** sacharya has joined #openstack-ironic | 07:11 | |
*** Sukhdev has quit IRC | 07:15 | |
*** sacharya has quit IRC | 07:15 | |
*** ChubYann has quit IRC | 07:18 | |
openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Add RPC and object version pinning https://review.openstack.org/407491 | 07:22 |
openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Add version column https://review.openstack.org/412397 | 07:22 |
openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Add version column https://review.openstack.org/412397 | 07:28 |
*** amarao has quit IRC | 07:30 | |
*** rbartal has joined #openstack-ironic | 07:30 | |
*** tesseract has joined #openstack-ironic | 07:31 | |
openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Add RPC and object version pinning https://review.openstack.org/407491 | 07:31 |
openstackgerrit | Grzegorz Grasza (xek) proposed openstack/ironic: Add version column https://review.openstack.org/412397 | 07:32 |
xek | morning ironic :) | 07:34 |
pas-ha | morning xek :) and all others :) | 07:38 |
openstackgerrit | Dao Cong Tien proposed openstack/python-ironicclient: Extends driver-list, driver-show supporting new hardware types https://review.openstack.org/419274 | 07:39 |
*** sayantani01 has quit IRC | 07:44 | |
*** yonglihe has joined #openstack-ironic | 07:45 | |
*** e0ne has joined #openstack-ironic | 07:46 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: ironic standalone tests https://review.openstack.org/423556 | 07:53 |
*** e0ne has quit IRC | 08:09 | |
*** amoralej|off is now known as amoralej | 08:12 | |
*** jtomasek has quit IRC | 08:15 | |
*** jtomasek has joined #openstack-ironic | 08:17 | |
*** pcaruana has joined #openstack-ironic | 08:17 | |
*** ccamacho has joined #openstack-ironic | 08:22 | |
*** causten has joined #openstack-ironic | 08:24 | |
*** causten has quit IRC | 08:29 | |
openstackgerrit | Yuiko Takada Mori proposed openstack/ironic: Add previous config name to Multitenancy doc https://review.openstack.org/423984 | 08:30 |
*** amarao has joined #openstack-ironic | 08:33 | |
openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add soft reboot, soft power off and power timeout to api-ref https://review.openstack.org/423986 | 08:35 |
*** mgoddard has joined #openstack-ironic | 08:36 | |
*** ohamada has joined #openstack-ironic | 08:38 | |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Serve boot configs from Ironic API https://review.openstack.org/369438 | 08:44 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Implement Driver API for dynamic boot config https://review.openstack.org/394398 | 08:44 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Add RPC API to get the boot config https://review.openstack.org/394399 | 08:44 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Allow not writing pxe configs to disk https://review.openstack.org/394397 | 08:44 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Convert iPXE boot config to proper Jinja template https://review.openstack.org/393462 | 08:44 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: DNM test enabled dynamic iPXE https://review.openstack.org/391943 | 08:45 |
*** ralonsoh has joined #openstack-ironic | 08:54 | |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-ironic | 09:01 | |
*** yolanda has quit IRC | 09:02 | |
*** mjura has joined #openstack-ironic | 09:05 | |
*** yolanda has joined #openstack-ironic | 09:07 | |
*** e0ne has joined #openstack-ironic | 09:08 | |
*** nmathew has quit IRC | 09:08 | |
*** mgoddard has quit IRC | 09:14 | |
*** yolanda has quit IRC | 09:15 | |
*** yolanda has joined #openstack-ironic | 09:24 | |
*** Nisha_Agarwal has joined #openstack-ironic | 09:26 | |
openstackgerrit | Anh Tran proposed openstack/python-ironicclient: Typo fix: prefered => preferred https://review.openstack.org/424015 | 09:26 |
*** yarkot has quit IRC | 09:29 | |
*** hw_wutianwei has quit IRC | 09:33 | |
*** hw_wutianwei has joined #openstack-ironic | 09:33 | |
*** lennyb has joined #openstack-ironic | 09:37 | |
*** nmathew has joined #openstack-ironic | 09:38 | |
*** amotoki has quit IRC | 09:44 | |
*** derekh has joined #openstack-ironic | 09:47 | |
*** MattMan has quit IRC | 09:54 | |
*** MattMan has joined #openstack-ironic | 09:54 | |
*** mgoddard has joined #openstack-ironic | 09:56 | |
*** lindycoder has joined #openstack-ironic | 10:03 | |
vdrok | good morning ironic, xek and pas-ha ! | 10:03 |
*** sambetts|afk is now known as sambetts | 10:06 | |
*** priteau has joined #openstack-ironic | 10:07 | |
phuongnh | morning vdrok :) | 10:15 |
*** sasha2 has quit IRC | 10:17 | |
*** phuongnh has quit IRC | 10:20 | |
openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Migrate to session for glance client https://review.openstack.org/410767 | 10:22 |
openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _send_sensors_data concurrent https://review.openstack.org/407429 | 10:23 |
*** hoangcx has quit IRC | 10:27 | |
openstackgerrit | Debayan Ray proposed openstack/proliantutils: Change Log as part of proliantutils 2.2.0 release https://review.openstack.org/424045 | 10:29 |
*** zhugaoxiao has quit IRC | 10:34 | |
*** udesale has quit IRC | 10:55 | |
*** dtantsur|afk is now known as dtantsur | 11:05 | |
dtantsur | Morning Ironic | 11:05 |
vdrok | good morning dtantsur ! | 11:06 |
dtantsur | pas-ha, hey! do you plan on backporting your PXE takeover patch? | 11:10 |
*** hw_wutianwei has quit IRC | 11:14 | |
*** zackf has joined #openstack-ironic | 11:21 | |
*** nmathew has quit IRC | 11:24 | |
*** zackf has quit IRC | 11:26 | |
*** ccamacho1 has joined #openstack-ironic | 11:29 | |
*** ccamacho has quit IRC | 11:29 | |
*** krtaylor has quit IRC | 11:31 | |
*** moshele has quit IRC | 11:31 | |
*** krtaylor has joined #openstack-ironic | 11:33 | |
mrtenio | Morning dtantsur vdrok! | 11:39 |
*** jkilpatr has quit IRC | 11:41 | |
vdrok | morning mrtenio | 11:44 |
yolanda | hi, good morning | 11:45 |
yolanda | dtantsur, so i'm working in the custom deployment steps spec | 11:45 |
yolanda | my initial thought was to expose all public methods from the base DeployInterface class, what do you think? | 11:46 |
dtantsur | yolanda, I think we should get something similar to clean steps, which we defined by http://specs.openstack.org/openstack/ironic-specs/specs/kilo-implemented/implement-cleaning-states.html | 11:46 |
dtantsur | note that actually other interfaces may provide deploy steps, e.g. RaidInterface | 11:47 |
yolanda | and do we have a common denominator of the steps that all interfaces provide? | 11:48 |
dtantsur | sorry, what do you mean by common denominator here? | 11:48 |
yolanda | to create the default deployment steps | 11:49 |
yolanda | or each one shall expose their own, similar as the get_clean_steps() there? get_deployment_steps() ? | 11:51 |
*** tiendc has quit IRC | 11:52 | |
*** nmathew has joined #openstack-ironic | 11:59 | |
yolanda | anyway, going to update the spec trying to resemble the cleanup part, that makes logic, then we can iterate from there | 12:00 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Add hardware type for IPMI using ipmitool https://review.openstack.org/422708 | 12:05 |
dtantsur | yolanda, yep. the default deployment steps should, I guess, be defined in the DeployInterface base class | 12:05 |
TheJulia | Good morning | 12:05 |
dtantsur | morning TheJulia! | 12:08 |
* dtantsur wonders why he doesn't see EU folks today | 12:08 | |
TheJulia | No clue... I'm only up early because I'm about to jump on a flight | 12:09 |
yolanda | dtantsur, and how could that help with custom vendor config, such as customizing an image, adding boot parameters, or touch config of files? | 12:09 |
dtantsur | TheJulia, I see. safe flight! | 12:09 |
dtantsur | yolanda, drivers overriding get_deploy_steps | 12:10 |
yolanda | dtantsur, so we shall override this driver in tripleo, let's say? | 12:10 |
dtantsur | yolanda, we may extend it even in ironic, we're just laying out the basis for now | 12:11 |
dtantsur | but yes, for clearly non-ironic things like touching files, it's probably going to be a custom driver or something like that | 12:11 |
dtantsur | we can do the same thing as in clean steps, and allow IPA to provide deploy steps | 12:12 |
TheJulia | dtantsur: thanks! I just hope inflight wifi works so I don't miss the weekly meeting | 12:12 |
yolanda | ok just using class inheritance, override it, etc | 12:12 |
*** jkilpatr has joined #openstack-ironic | 12:13 | |
*** amotoki has joined #openstack-ironic | 12:15 | |
TheJulia | Anyone seen hshiina recently on irc? | 12:22 |
openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Migrate to session for glance client https://review.openstack.org/410767 | 12:22 |
dtantsur | TheJulia, not me.. is it about overwriting your changes? | 12:25 |
TheJulia | Eh, yeah. Hoping to get a little better communication going | 12:29 |
*** amotoki has quit IRC | 12:33 | |
cdaniel | morning all | 12:38 |
*** baoli has joined #openstack-ironic | 12:38 | |
*** baoli has quit IRC | 12:39 | |
TheJulia | Good morning | 12:40 |
*** Nisha_Agarwal has quit IRC | 12:45 | |
*** patriciadomin_ is now known as patriciadomin | 12:49 | |
*** rbartal has quit IRC | 12:52 | |
*** dprince has joined #openstack-ironic | 13:00 | |
*** rbartal has joined #openstack-ironic | 13:04 | |
jroll | morning y'all | 13:07 |
*** trown|outtypewww is now known as trown | 13:12 | |
dtantsur | morning jroll | 13:12 |
vdrok | morning TheJulia cdaniel and jroll | 13:22 |
openstackgerrit | Aparna proposed openstack/ironic: Support `update_firmware` to hpsum based firmware update https://review.openstack.org/422572 | 13:22 |
*** amoralej is now known as amoralej|luch | 13:26 | |
*** awiddersheim has quit IRC | 13:27 | |
openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fixes to allow install Ironic on remote node https://review.openstack.org/409213 | 13:28 |
openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Add support of collecting logs from baremetal nodes https://review.openstack.org/415503 | 13:28 |
*** awiddersheim has joined #openstack-ironic | 13:29 | |
dtantsur | jroll, wdyt about https://bugs.launchpad.net/ironic/+bug/1654190? weren't we supposed to kill this code? | 13:29 |
openstack | Launchpad bug 1654190 in Ironic "Got 'ImportError' when build doc" [Undecided,Incomplete] | 13:29 |
mrtenio | Hi, I am trying to change the boot order using python-ironicclient, but I keep getting timeout. How could I increase the timeout limit? It is happening in one of our CI's jobs. Thanks | 13:30 |
jroll | dtantsur: yep, I believe we were waiting for deprecation period things | 13:30 |
* jroll takes a look | 13:31 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add usage documentation for Baremetal OSC Plugin https://review.openstack.org/415261 | 13:31 |
*** aparnav has quit IRC | 13:31 | |
jroll | aha, we've been clear to delete that | 13:32 |
mrtenio | traceback: http://paste.openstack.org/show/595829/ | 13:33 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Revert "Revert "Remove ClusteredComputeManager"" https://review.openstack.org/424113 | 13:34 |
jroll | dtantsur: we've already done it once, too, ^^ there you are :) | 13:34 |
*** mrtenio has quit IRC | 13:37 | |
*** mrtenio has joined #openstack-ironic | 13:38 | |
*** mrtenio has quit IRC | 13:39 | |
*** noama has joined #openstack-ironic | 13:46 | |
*** jheroux has joined #openstack-ironic | 13:50 | |
*** noama has quit IRC | 13:51 | |
*** noama has joined #openstack-ironic | 13:52 | |
*** amoralej|luch is now known as amoralej | 13:58 | |
*** sasha2 has joined #openstack-ironic | 14:02 | |
*** jcoufal has joined #openstack-ironic | 14:02 | |
dtantsur | w00t! | 14:03 |
dtantsur | jroll, also I've updated the IPMI hw type patch this morning | 14:03 |
jroll | dtantsur: thanks | 14:04 |
jroll | I kind of hit a wedge with vendor passthru friday night | 14:04 |
jroll | looking again to see if I'm missing something, though | 14:04 |
jroll | tl;dr vendor passthru stuff assumes we have the mapping mixin thing, which we don't in dynamic drivers | 14:04 |
*** rloo has joined #openstack-ironic | 14:05 | |
dtantsur | jroll, where do we have mixins beyond old agent passthru? | 14:05 |
dtantsur | anyway, I think this is why we need to keep vendor_interface changeable ;) | 14:05 |
*** Goneri has joined #openstack-ironic | 14:05 | |
jroll | dtantsur: these are all ready for code review, just needs docs/release notes afaik: https://review.openstack.org/#/c/417970/ https://review.openstack.org/#/c/423536/1 | 14:05 |
patchbot | patch 417970 - ironic - WIP: API changes for driver-composition | 14:05 |
patchbot | patch 423536 - ironic - WIP: support dynamic drivers in driver properties API | 14:05 |
jroll | let me look | 14:05 |
patchbot | (let <variable> = <value> in <command>) -- Defines <variable> to be equal to <value> in the <command> and runs the <command>. '=' and 'in' can be omitted. | 14:05 |
dtantsur | jroll, we get to them today then! /me is looking forward to play with API finally | 14:06 |
jroll | oh huh, we do just use them directly | 14:06 |
jroll | wtf was I thinking | 14:06 |
jroll | friday night coding isn't my best work :P | 14:06 |
dtantsur | we used to have mixins all over the place due to old agent API :) | 14:06 |
dtantsur | hah, I can imagine :D | 14:06 |
jroll | dtantsur: yeah, I can finish them this afternoon, if you want to review so I can get your comments fixed up | 14:07 |
jroll | oh here's the only one left in the project | 14:07 |
jroll | https://github.com/openstack/ironic/blob/master/ironic/drivers/fake.py#L74 | 14:07 |
jroll | I guess I could probably kill that | 14:07 |
dtantsur | I may or may not have a meeting soon. depending on it, I'll maybe get to it soon or late | 14:07 |
jroll | that's what confused me, though | 14:07 |
jroll | ok, no worries | 14:08 |
dtantsur | jroll, ignore this one, it's fake anyway | 14:08 |
jroll | right | 14:08 |
openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fix "Create SSH directory for ironic user" task https://review.openstack.org/424131 | 14:08 |
jroll | well, I was writing tests against that driver :) | 14:08 |
dtantsur | ouch, I see :D | 14:08 |
jroll | but yeah, I should be able to finish everything today | 14:09 |
*** ppiela has joined #openstack-ironic | 14:09 | |
dtantsur | fantastic! | 14:09 |
jroll | and hopefully set up a CI job tomorrow | 14:09 |
dtantsur | yeah.. I'll try to also get to the clients' review queue | 14:09 |
dtantsur | we have to do final releases of them by Thu | 14:09 |
jroll | oooo yeah | 14:10 |
dtantsur | speaking of which | 14:10 |
dtantsur | sambetts, around? | 14:10 |
jroll | dtantsur: are we just going to do driver composition client stuff in pike, then? | 14:10 |
dtantsur | jroll, unless we're super fast, yes. | 14:10 |
jroll | yeah, fair enough | 14:11 |
* jroll seems to recall someone wanting to pick that work up | 14:11 | |
dtantsur | yeah, there are patches up | 14:11 |
sambetts | dtantsur: hi whats up? | 14:11 |
jroll | ah cook | 14:11 |
jroll | cool* | 14:11 |
dtantsur | sambetts, mind checking https://review.openstack.org/#/c/409789/ please? we need to wrap up everything around client soon | 14:11 |
patchbot | patch 409789 - python-ironic-inspector-client - Clarify that node names can be used in addition to... | 14:11 |
*** amotoki has joined #openstack-ironic | 14:11 | |
sambetts | dtantsur: I'll take a look :) | 14:12 |
jroll | https://review.openstack.org/#/q/topic:bug/1524745+project:openstack/python-ironicclient+status:open | 14:12 |
dtantsur | sambetts, would be completely awesome if you manage to check bfournie's LLDP stuff too, as it has a client part | 14:12 |
jroll | these should be straightforward, maybe we can land them, hrm | 14:12 |
* jroll will look today | 14:13 | |
*** Nisha_Agarwal has joined #openstack-ironic | 14:13 | |
dtantsur | maybe I should not have asked for a Depends-On on these patches, as they're anyway coded according to the spec.. dunno | 14:13 |
*** moshele has joined #openstack-ironic | 14:13 | |
*** jerrygb has joined #openstack-ironic | 14:14 | |
jroll | meh, we can remove them if we want to land it | 14:14 |
jroll | oh | 14:14 |
jroll | there's functional tests, so it's needed | 14:14 |
jroll | looks like check-osc-commands might be broken | 14:15 |
jroll | good week for that | 14:15 |
*** jerrygb_ has joined #openstack-ironic | 14:15 | |
jroll | it's non-voting, ignore me | 14:15 |
openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _send_sensors_data concurrent https://review.openstack.org/407429 | 14:15 |
*** jerrygb__ has joined #openstack-ironic | 14:18 | |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: [trivial] Fix typo in documentation https://review.openstack.org/424138 | 14:18 |
*** jerrygb has quit IRC | 14:19 | |
*** baoli has joined #openstack-ironic | 14:19 | |
*** jerrygb_ has quit IRC | 14:20 | |
*** amotoki has quit IRC | 14:25 | |
dtantsur | heh | 14:26 |
*** jcoufal has quit IRC | 14:29 | |
openstackgerrit | yolanda.robla proposed openstack/ironic-specs: Ironic deployment steps https://review.openstack.org/412523 | 14:30 |
openstackgerrit | Miles Gould proposed openstack/ironic: Allow setting UEFI boot devices in DRAC driver https://review.openstack.org/420107 | 14:30 |
dtantsur | mgould|afk seems not so afk ^^^ | 14:30 |
openstackgerrit | Miles Gould proposed openstack/ironic: Allow setting UEFI boot devices in DRAC driver https://review.openstack.org/420107 | 14:31 |
*** jcoufal has joined #openstack-ironic | 14:31 | |
openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/423638 | 14:32 |
openstackgerrit | yolanda.robla proposed openstack/ironic-specs: Ironic deployment steps https://review.openstack.org/412523 | 14:34 |
yolanda | hi dtantsur , new version uploaded... when you have time, can you check that i have not said anything crazy? | 14:35 |
dtantsur | sure, though "when I have time" is not easy this time of the cycle :( | 14:35 |
openstackgerrit | Oksana Voshchana proposed openstack/ironic: WIP: TEST GRENADE DEV https://review.openstack.org/397126 | 14:35 |
dtantsur | yolanda, if you don't mind, please keep the status whiteboard updated for this work, see https://etherpad.openstack.org/p/IronicWhiteBoard around line 170 | 14:36 |
*** moshele has quit IRC | 14:36 | |
*** mgould|afk is now known as mgould | 14:37 | |
mgould | dtantsur: merely away from IRC :-) | 14:37 |
dtantsur | I see :) morning mgould | 14:37 |
mgould | ^^^ patch now ready for review, I think | 14:38 |
* mgould curses whichever DRAC engineer decided to use "Bios" and "Uefi" for setting boot modes, but "IPL" and "UEFI" for setting boot *devices* | 14:38 | |
*** jcoufal_ has joined #openstack-ironic | 14:38 | |
dtantsur | awesome | 14:39 |
mgould | consistency is the hobgoblin of little minds | 14:39 |
jroll | dtantsur: see open discussion re: resource classes: http://eavesdrop.openstack.org/meetings/nova_scheduler/2017/nova_scheduler.2017-01-23-14.00.log.html | 14:39 |
jroll | so I guess that's toward the top of my list this week | 14:39 |
mgould | AFAICT "IPL" is a term from mainframe bootloaders? | 14:39 |
openstackgerrit | Oksana Voshchana proposed openstack/ironic: WIP: TEST GRENADE DEV https://review.openstack.org/397126 | 14:40 |
*** nmathew has quit IRC | 14:40 | |
yolanda | sure | 14:40 |
*** jcoufal has quit IRC | 14:41 | |
*** jcoufal has joined #openstack-ironic | 14:42 | |
yolanda | of course i failed on linters, need to tidy it | 14:42 |
dtantsur | jroll, ugh! thanks for asking. Do we have some docs to refer to? | 14:43 |
jroll | dtantsur: I wrote some last cycle, people didn't want to merge them because they thought plans might change >.> | 14:44 |
jroll | https://review.openstack.org/#/c/345081/ | 14:44 |
patchbot | patch 345081 - ironic - Add docs for node.resource_class and flavor creation | 14:44 |
* jroll will rebase | 14:44 | |
openstackgerrit | Miles Gould proposed openstack/ironic: Allow setting UEFI boot devices in DRAC driver https://review.openstack.org/420107 | 14:45 |
*** jcoufal_ has quit IRC | 14:45 | |
jroll | dtantsur: fairly accurate as is thuogh | 14:45 |
openstackgerrit | Merged openstack/python-ironic-inspector-client: Clarify that node names can be used in addition to UUIDs https://review.openstack.org/409789 | 14:46 |
*** vinsh has quit IRC | 14:46 | |
*** vinsh has joined #openstack-ironic | 14:47 | |
dtantsur | jroll, let's try to land it asap (maybe get someone from nova review it too) | 14:47 |
jroll | dtantsur: yeah, working on things now | 14:47 |
jroll | flavor is still unclear | 14:47 |
dtantsur | jroll, what's the consequence of NOT doing it in Ocata? | 14:48 |
jroll | dtantsur: there will be a delay in scheduling availability until after the first resource tracker run post-upgrade | 14:49 |
*** Nisha_Agarwal has quit IRC | 14:50 | |
openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Negative tests for testing actions with port. https://review.openstack.org/259354 | 14:50 |
dtantsur | upgrade to Pike final, right? | 14:51 |
jroll | dtantsur: yeah | 14:51 |
jroll | still talking some things through in -nova, btw | 14:51 |
dtantsur | ah, ok | 14:51 |
jkilpatr | ok finally got statsd getting metrics, does anyone know what the units are for these? | 14:51 |
openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Add negative test-cases for openstack node create command https://review.openstack.org/381943 | 14:51 |
jkilpatr | node_sync_power_state has data points that are like 1k, I assume its micro or milli seconds | 14:51 |
jroll | jkilpatr: I believe it's milli | 14:52 |
*** udesale has joined #openstack-ironic | 14:52 | |
*** srobert has joined #openstack-ironic | 14:53 | |
jkilpatr | jroll, thanks. any idea hat a node stats controller is? | 14:53 |
jkilpatr | states* | 14:53 |
*** srobert has quit IRC | 14:53 | |
jroll | jkilpatr: controllers are the classes that are used for API request handling, e.g. ironic/api/v1/controllers/node.py would have a NodeStatesController | 14:55 |
openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Negative tests for testing actions with node-get command https://review.openstack.org/342060 | 14:55 |
jroll | jkilpatr: so that would have a metric of ironic.api.v1.controllers.node.NodeStatesController.foo_method | 14:55 |
jkilpatr | jralph, yup seeing that, so provision would be the time it took the api to respond to a provisioning request in milli seconds? | 14:56 |
jroll | jkilpatr: I believe so, yes | 14:56 |
*** jaosorior has joined #openstack-ironic | 14:56 | |
jroll | oh god there's three jr<tab> people here now | 14:56 |
jroll | we're ruined | 14:57 |
dtantsur | lol | 14:57 |
*** causten has joined #openstack-ironic | 14:57 | |
* jroll /nick trollenhagen | 14:57 | |
dtantsur | let's kick jrist out :D | 14:57 |
jroll | heh | 14:57 |
jkilpatr | every time that happens I want to go and write an irc plugin that is context sensitive (tab completes to the last person who talked) | 14:57 |
* dtantsur dreams about the same thing | 14:57 | |
jroll | weechat does this :P | 14:58 |
jkilpatr | jroll, so boot device controller would be how long it took to swap the boot device? | 14:58 |
openstackgerrit | Miles Gould proposed openstack/ironic: Allow setting UEFI boot devices in DRAC driver https://review.openstack.org/420107 | 14:58 |
jkilpatr | is that time for the full operation of just to register the request. Looks like the full operation because it takes like 2 seconds | 14:58 |
jroll | jkilpatr: probably, yes. some of these api calls send a message to the conductor and that will fire a thread and return immediately | 14:58 |
jroll | right, it depends, but for BMC things it's usually async | 14:58 |
openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Negative tests for testing actions with node-port-list. https://review.openstack.org/360636 | 14:59 |
jroll | jkilpatr: in which case you likely want to look for ironic.conductor.manager.ConductorManager._do_node_set_power_state or something like that | 14:59 |
*** rbartal has quit IRC | 15:00 | |
mgould | ^^^ /me learns to run tox *before* pushing, *especially* for trivial changes | 15:00 |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add nodes tagging support - objs https://review.openstack.org/233357 | 15:01 |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add DB layer support for node tags filter https://review.openstack.org/272624 | 15:01 |
openstackgerrit | yolanda.robla proposed openstack/ironic-specs: Ironic deployment steps https://review.openstack.org/412523 | 15:01 |
*** Syed__ has joined #openstack-ironic | 15:01 | |
*** rloo has quit IRC | 15:07 | |
*** sayantani01 has joined #openstack-ironic | 15:08 | |
*** rloo has joined #openstack-ironic | 15:08 | |
*** sayantani01 has quit IRC | 15:08 | |
dtantsur | jroll, I'm pressing the button on https://review.openstack.org/#/c/424113/ fyi | 15:09 |
patchbot | patch 424113 - ironic - Revert "Revert "Remove ClusteredComputeManager"" | 15:09 |
jroll | dtantsur: +1 | 15:09 |
*** sayantani01 has joined #openstack-ironic | 15:11 | |
*** Nisha_Agarwal has joined #openstack-ironic | 15:13 | |
TheJulia | I <3 ATC flight delays | 15:14 |
*** srobert has joined #openstack-ironic | 15:15 | |
rloo | hi and good morning to the start of another glorious week (TM) :) | 15:17 |
rloo | TheJulia: ? | 15:17 |
*** zackf has joined #openstack-ironic | 15:18 | |
rloo | jroll, xek, jlvillal: are you all available to discuss status of rolling upgrades in about an hour or so? (before weekly meeting?) | 15:18 |
*** mtanino has joined #openstack-ironic | 15:19 | |
jroll | rloo: I can be, yeah | 15:19 |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add DB layer support for node tags filter https://review.openstack.org/272624 | 15:19 |
jlvillal | rloo, Sure. Maybe vsaienk0 would like to join. | 15:19 |
openstackgerrit | Merged openstack/ironic: Turn NOTE into docstring https://review.openstack.org/422863 | 15:19 |
rloo | jlvillal: sure, anyone is welcome to join! just wanted a few key folks there :) | 15:19 |
openstackgerrit | Merged openstack/ironic: Fix typo in the metrics.rst file https://review.openstack.org/423094 | 15:19 |
TheJulia | rloo: traveling today, got a boarding notice for my next flight as we were taxiing to the arriving gate for my layover, got to the gate and air traffic control put a 1.5 hour hold on the flight. | 15:20 |
rloo | jlvillal: did we convert you to east coast time? :) | 15:20 |
rloo | TheJulia: OH :-( | 15:20 |
jlvillal | rloo, No. I just woke up about 10 minutes ago. | 15:21 |
*** vinsh_ has joined #openstack-ironic | 15:21 | |
rloo | TheJulia: I thought ATC = active tech. contributor in openstack, but there's another world out there :D | 15:21 |
rloo | jlvillal: good morning :) | 15:22 |
jlvillal | :) | 15:22 |
openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP/DNM: Testing multinode job https://review.openstack.org/422149 | 15:23 |
*** vinsh has quit IRC | 15:24 | |
TheJulia | rloo: I realized that might be how it was interpreted right after you raised the question mark. | 15:26 |
rloo | TheJulia: :) | 15:27 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add docs for node.resource_class and flavor creation https://review.openstack.org/345081 | 15:27 |
jroll | rloo: ^ it returns from the grave, would love your review there if you have time | 15:27 |
dtantsur | sambetts, hey, have you seen https://bugs.launchpad.net/ironic/+bug/1656010 ? mgould and I can't wrap our heads around it | 15:27 |
openstack | Launchpad bug 1656010 in neutron (Ubuntu) "Incorrect notification to nova about ironic baremetall port (for nodes in 'cleaning' state)" [Undecided,New] | 15:27 |
dtantsur | also morning jlvillal, rloo | 15:27 |
rloo | jroll: heh. sure, what's the urgency on that? | 15:28 |
jroll | rloo: this week? | 15:28 |
jroll | or like | 15:28 |
jroll | this release, I guess | 15:28 |
rloo | jroll: ah, ok, will look this afternoon then or tomorrow. | 15:28 |
sambetts | dtantsur: /me hates launchpads limited width for bug reports... | 15:28 |
dtantsur | heh | 15:29 |
openstackgerrit | Merged openstack/python-ironicclient: Typo fix: prefered => preferred https://review.openstack.org/424015 | 15:29 |
sambetts | dtantsur: I think I know whats happening | 15:29 |
*** baoli has quit IRC | 15:30 | |
dtantsur | mind triaging this one please? I barely understand a word :( | 15:30 |
jroll | is that even a bug? | 15:30 |
sambetts | dtantsur: basically in neutron they have a notifyer thing which when a new port is created it sends a message to nova so that nova can bind it without a user having to go to nova and do a vif-attach | 15:30 |
sambetts | dtantsur: this is saying that a notification is sent for the ports we create for cleaning | 15:31 |
*** ccamacho1 has quit IRC | 15:32 | |
vdrok | morning rloo jlvillal and sambetts | 15:33 |
jroll | dtantsur: do you know offhand if our osc plugin has a --wait for e.g. waiting for enroll->manageable->available? | 15:33 |
dtantsur | jroll, the patch is on review | 15:33 |
jroll | ah | 15:33 |
jroll | I'm updating devstack to do that thing | 15:33 |
*** beekneemech is now known as bnemec | 15:33 | |
mgould | sambetts: so the fix is "don't send that notification if we're not going to create an instance"? | 15:33 |
dtantsur | you can just merge it ;) | 15:33 |
jroll | lol | 15:34 |
rloo | dtantsur, jroll: you mean https://review.openstack.org/#/c/354806/? | 15:34 |
patchbot | patch 354806 - python-ironicclient - Add --wait to OSC provisioning commands | 15:34 |
jroll | apparently | 15:34 |
dtantsur | yep | 15:34 |
sambetts | dtantsur: nova ignores it because there is no device_id AKA instance id with a id == ironic so :/ I guess we probably need to add code to the nova notify to ignore ports with the baremetal vnic type | 15:34 |
sambetts | mgould: ^ | 15:34 |
openstackgerrit | Merged openstack/bifrost: Typo fix: enviroment => environment https://review.openstack.org/423929 | 15:34 |
rloo | jroll, dtantsur: was sitting in my inbox still. will look at it today ... | 15:34 |
dtantsur | cool | 15:35 |
*** yolanda has quit IRC | 15:36 | |
*** yolanda has joined #openstack-ironic | 15:36 | |
*** sayantani01 has quit IRC | 15:36 | |
*** sayantani01 has joined #openstack-ironic | 15:37 | |
*** yolanda has quit IRC | 15:37 | |
*** udesale has quit IRC | 15:37 | |
*** yolanda has joined #openstack-ironic | 15:38 | |
jroll | oh, we have it for ironic cli already, woohoo | 15:40 |
dtantsur | yep :) | 15:40 |
*** baoli has joined #openstack-ironic | 15:41 | |
jroll | the downside being now I have no excuse to fix a bunch of crap | 15:41 |
jroll | er, not to fix | 15:42 |
TheJulia | rloo: I'm going to review the rpc pin and patches up to the db online upgrade stuff. I still have the -2 on the first patch, and kind of feel like I should pull it so we can get that stuff landed | 15:42 |
rloo | TheJulia: thx for reviewing! we can discuss today about whether/when to remove the -2. I want to discuss with xek and see where testing is. i am hoping xek will be around in 30 min or so to discuss. you can join too! | 15:43 |
rloo | TheJulia: I'm currently 'stuck' on the version column patch. i think that is the most crucial one so i want to make sure i totally grok it. | 15:43 |
TheJulia | rloo: I'll try, they are telling us we should begin boarding in about 20-25 minutes and might be taking off during the beginning of the meeting | 15:44 |
TheJulia | rloo: 10-4 | 15:44 |
rloo | TheJulia: OH, don't miss your flight. guess you may not be at ironic meeting too? | 15:44 |
rloo | TheJulia: oh yeah, just read what you said (again). heh. | 15:44 |
openstackgerrit | Jesse J. Cook proposed openstack/ironic: Add rescuewait timeout periodic task https://review.openstack.org/353156 | 15:44 |
openstackgerrit | Jesse J. Cook proposed openstack/ironic: Add API and conductor methods for [un]rescue https://review.openstack.org/350831 | 15:44 |
TheJulia | I'm hoping to, but wifi was also refusing to work on my last flight. | 15:45 |
*** jerrygb has joined #openstack-ironic | 15:45 | |
rloo | TheJulia: for boot from volume, is there anything that must/want to get into ocata? I saw the note about not being able to get client stuff. in that case, is there anything else we should try to get in? | 15:46 |
rloo | TheJulia: if you could update etherpad with that, so we know whether there are any priorities there... | 15:46 |
*** ccamacho has joined #openstack-ironic | 15:46 | |
*** jerrygb__ has quit IRC | 15:47 | |
TheJulia | I'd like to try get more stuff under the hood, but I also wf-1'ed the current first patch because it got reverted, and I won't be in front of a git client for a few hours | 15:47 |
rloo | TheJulia: ok, maybe add a note/link to those and mention that they will be ready to review later today/tomorrow, whenever. | 15:48 |
TheJulia | rloo: but at the same time, if we can get it all lined up, first thing in pike would be awesome. | 15:48 |
rloo | TheJulia: definitely! | 15:48 |
TheJulia | rloo: I put a note on the first one like four hours ago :) | 15:48 |
* TheJulia has been up for a while | 15:49 | |
* rloo looks and yes, it is there. Thx TheJulia! | 15:49 | |
*** rbudden has joined #openstack-ironic | 15:51 | |
openstackgerrit | Michael Turek proposed openstack/ironic: [WIP] OpenBMC Driver https://review.openstack.org/403835 | 15:53 |
*** jcoufal_ has joined #openstack-ironic | 15:56 | |
sambetts | jroll: should the nova notifier be notifying nova of baremeta:none owned ports?? https://github.com/openstack/neutron/blob/master/neutron/notifiers/nova.py#L90 | 15:57 |
jroll | huh, we use capabilities in devstack now? O_o | 15:58 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Allow using resource classes https://review.openstack.org/407651 | 15:58 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: DNM: turn on resource classes https://review.openstack.org/423269 | 15:58 |
jroll | sambetts: I know absolutely nothing about neutron notifications | 15:58 |
*** jcoufal has quit IRC | 15:59 | |
mgould | sambetts: makes sense, thanks | 16:00 |
mgould | does that happen in code that we control? | 16:01 |
* mgould continues to be awed at wifi on planes | 16:02 | |
mgould | we're living in The Future, people | 16:02 |
sambetts | jroll: I think the problem is that we seem to be overriding the device_owner field for ports created/passed through nova for Ironic changing them to baremetal:none | 16:02 |
sambetts | jroll: which broke the nova notifications for those ports | 16:02 |
jroll | sambetts: I don't even understand what the problem is, or if it's a real problem (vs superficial scary looking things in logs), to be clear | 16:03 |
sambetts | jroll: and someone fixed it by changing the notification code in neutron instead of fixing the device_owner in Ironic | 16:03 |
*** aparnav has joined #openstack-ironic | 16:03 | |
sambetts | jroll: this is the bug report that lead to that neutron change: https://bugs.launchpad.net/neutron/+bug/1606229 | 16:04 |
openstack | Launchpad bug 1606229 in neutron "vif_port_id of ironic port is not updating after neutron port-delete" [Medium,In progress] - Assigned to Andrey Shestakov (ashestakov) | 16:04 |
jroll | I see | 16:04 |
jroll | so the problem is that we don't handle the case where a port we're using is deleted? | 16:04 |
sambetts | jroll: if we left the device_owner alone for ports that came through nova then our cleaning ports wouldn't have resulted in nova notifications | 16:04 |
*** dyasny has quit IRC | 16:04 | |
*** dyasny has joined #openstack-ironic | 16:05 | |
jroll | sambetts: which means... what exactly | 16:05 |
sambetts | jroll: yeah, we don't support interface detach in nova driver | 16:05 |
* jroll doesn't understand any of this | 16:05 | |
jroll | maybe you can summarize in a way that my 5-year-old brain can understand on the ML? :) | 16:05 |
*** yolanda has quit IRC | 16:06 | |
*** amotoki has joined #openstack-ironic | 16:06 | |
*** yolanda has joined #openstack-ironic | 16:06 | |
sambetts | jroll: heh, yeah I'll try to put something togther | 16:07 |
jroll | thanks :D | 16:08 |
aparnav | Hi jroll | 16:09 |
sambetts | jroll: TL;DR we change a nova set value on the port, which broke nova notifications, and they "fixed" it in neutron instead of ironic, which now results in notifications being sent to nova for neutron ports owned by Ironic | 16:09 |
jroll | hi aparnav | 16:09 |
TheJulia | rloo: Just looked at the version rev. Yeah, I totally get your comment earlier regarding it :) | 16:09 |
jroll | sambetts: ahhhh, even if it's totally unrelated, I see | 16:09 |
sambetts | jroll: yeah | 16:09 |
jroll | hrm | 16:10 |
rloo | TheJulia: it may be short, but is important! | 16:10 |
aparnav | I have reframed the rfe you have approved previously https://bugs.launchpad.net/ironic/+bug/1648448, I wanted to confirm whether change looks good or not | 16:10 |
openstack | Launchpad bug 1648448 in Ironic "[RFE]iLO driver `update_firmware` to support hpsum based firmware update" [Wishlist,In progress] - Assigned to Aparna (aparnavtce) | 16:10 |
sambetts | jroll: I suggest we revert the neutron change, and fix the device_owner thing on the Ironic side | 16:10 |
sambetts | jroll: tbh I think we do some weird stuff with device_id in the neutron net-interface which I'm not sure we should be doing | 16:11 |
jroll | aparnav: what did it say before? | 16:11 |
TheJulia | rloo: I feel like it is missing something, I just can't put my finger on it. Likely contextual with patches beyond the the database upgrade command rev | 16:11 |
rloo | TheJulia: some stuff related to that got merged a cycle or two ago... | 16:12 |
openstackgerrit | Sam Betts proposed openstack/ironic: Rework Ironic devstack baremetal network simulation https://review.openstack.org/392959 | 16:12 |
jroll | aparnav: is the update mode going to be a config, or how is that set? | 16:12 |
jroll | sambetts: I trust you to do the right thing, I don't have room in my brain for this, honestly | 16:12 |
sambetts | jroll: heh, I'll dig into it | 16:13 |
aparnav | jroll, I have proposed to add it as a new manual clean step. Now I decided to leverage the existing update_firmware availble for iLO drives. | 16:13 |
*** pcaruana has quit IRC | 16:13 | |
aparnav | jroll, It is not a config, It uses the existing `update_firmware` with some changes added to support hpsum mode of firmware update | 16:14 |
jroll | aparnav: ok cool, sounds great to me :) | 16:14 |
aparnav | jroll, thanks :) | 16:15 |
xek | rloo, Hi | 16:17 |
rloo | xek: hi! | 16:17 |
rloo | xek: you avail to talk about rolling upgrades now? | 16:17 |
xek | rloo, yes :) | 16:17 |
* jlvillal is here | 16:17 | |
rloo | xek: sweet. jroll, jlvillal, vsaienk0 ^^ | 16:17 |
jroll | cool | 16:18 |
rloo | xek: so where are you wrt coding? | 16:18 |
rloo | TheJulia: ^^ if you're around | 16:18 |
* jroll will be listening in 2 minutes, carry on and I'll read back | 16:18 | |
xek | rloo, I think we are finished on the implementation side | 16:18 |
xek | rloo, we tested the upgradability by running tempest | 16:18 |
xek | rloo, on partialy upgraded and upgraded installation | 16:19 |
xek | rloo, with pinning and whatnot, but without creating and testing resources between the upgrade steps | 16:19 |
rloo | xek: so wrt coding. is this the last code patch in the series: https://review.openstack.org/#/c/420728/ | 16:20 |
patchbot | patch 420728 - ironic - Add compatibility with Newton when creating a node | 16:20 |
TheJulia | rloo: perfect timing, just boarded the aircraft | 16:20 |
xek | rloo, this specifically fixes one of the incompatibilities we found | 16:21 |
*** moshele has joined #openstack-ironic | 16:21 | |
openstackgerrit | Merged openstack/ironic: Revert "Revert "Remove ClusteredComputeManager"" https://review.openstack.org/424113 | 16:21 |
rloo | xek: is it needed for rolling upgrades to work? | 16:21 |
xek | rloo, it is needed for the upgrade to ocata | 16:21 |
rloo | xek: ok, so we need that patch then. | 16:22 |
rloo | xek: the one after is a PoC: https://review.openstack.org/#/c/415462/ | 16:22 |
patchbot | patch 415462 - ironic - [PoC] Add fake fields in Node object and RPC | 16:22 |
rloo | xek: is that one needed? | 16:22 |
jroll | well, we upgrade the api side first, right? | 16:22 |
rloo | jroll: no conductor side | 16:22 |
jroll | er, sorry, conductor | 16:22 |
rloo | jroll: yeah, conductor side first :) | 16:22 |
xek | rloo, no that one we are using for the upgrade test, it contains various test changes in the rpc and the database | 16:23 |
rloo | xek: ok. | 16:23 |
jroll | so node-create is only broken if we upgrade with pins | 16:23 |
rloo | xek: so coding wise, i think if 'we' can all agree on the version column patch, we're probably good. | 16:23 |
*** moshele has quit IRC | 16:23 | |
jroll | I'm wondering, with driver composition, if changing node-create like that will cause some awkwardness | 16:23 |
xek | jroll, yes | 16:24 |
rloo | at least for me, that seems the most complex: https://review.openstack.org/#/c/412397/ | 16:24 |
patchbot | patch 412397 - ironic - Add version column | 16:24 |
jlvillal | I just updated the Whiteboard lines 110-117 with current progress of testing: https://etherpad.openstack.org/p/IronicWhiteBoard | 16:24 |
jroll | dtantsur: how bad would running ocata like this for some amount of time be? https://review.openstack.org/#/c/420728/5/ironic/conductor/rpcapi.py | 16:24 |
patchbot | patch 420728 - ironic - Add compatibility with Newton when creating a node | 16:24 |
* jroll thinks that's a rabbit hole | 16:24 | |
*** stendulker has joined #openstack-ironic | 16:25 | |
TheJulia | Possibly multiple rabbit holes | 16:26 |
rloo | oh, interesting. so rolling upgrades can be a problem if we switch how we create stuff. | 16:26 |
jroll | indeed | 16:26 |
rloo | what about disallowing node creation during upgrades? | 16:27 |
jroll | rloo: well, it's unclear if that causes problems, it's probably fine | 16:27 |
xek | rloo, jroll it only changes the place where we create it (to be the api service instead of the conductor) | 16:27 |
rloo | jroll, xek: ok, we should review/comment on that patch itself then. | 16:27 |
jroll | rloo: the issue would be, if someone creates a node with e.g. --deploy-interface foo, that wouldn't be validated, It hink | 16:27 |
xek | so for the pinned rolling upgrade timeframe, the behavior follows that of newton | 16:28 |
jroll | oh actually | 16:28 |
jroll | maybe you're right | 16:28 |
jroll | maybe not though | 16:28 |
jroll | xek: the problem is driver_factory.check_and_update_node_interfaces() may work differently on the conductor | 16:28 |
rloo | jroll: let's confirm. we can also add code in rpcapi.py to prevent the newton code from handling --deploy-interface. | 16:28 |
jroll | actually yes, this would cause API services to load drivers up, which is bad | 16:29 |
xek | rloo, yes | 16:29 |
rloo | jroll: err, ocata code from handling newton-api request with --deploy-interface | 16:29 |
jroll | hmm | 16:32 |
dtantsur | jroll, it's going to work, in some cases, I guess | 16:32 |
rloo | whatever we do to solve this, we may have a similar problem in the future if we move creation of eg chassis to conductor. | 16:32 |
*** dsneddon_afk is now known as dsneddon | 16:33 | |
openstackgerrit | Merged openstack/python-ironicclient: Add a new command "ironic node-inject-nmi" https://review.openstack.org/247905 | 16:33 |
jroll | rloo: yes, but we'll know in advance, so we can make sure we plan things out so that it doesn't completely fall apart if we fall back to old way | 16:34 |
rloo | jroll: right | 16:34 |
jroll | it's too far gone for this case, I think | 16:34 |
jroll | but I'm not sure if it will actually break | 16:34 |
TheJulia | Dropping off until we are in the air | 16:34 |
rloo | i think from coding pov, if we can grok the version column patch and solve this create-node issue, the feature is probably good to go in. | 16:34 |
rloo | i'll take a look at the create-node patch later today/this week. | 16:35 |
rloo | what about testing side? jlvillal said he updated etherpad with that status. | 16:35 |
jroll | rloo: sure, I agree with that. I'm curious if we'll get CI running, though, and if we won't then is it worth landing anyway? | 16:35 |
rloo | jroll: my current question! | 16:36 |
jroll | :) | 16:36 |
jlvillal | rloo, We aren't done yet for sure. But did make a lot of progress last week. Which I am very happy about :) | 16:36 |
rloo | https://etherpad.openstack.org/p/IronicWhiteBoard | 16:36 |
rloo | line 111 | 16:36 |
rloo | i don't recall what CI we need for this. need to look at spec... | 16:36 |
rloo | xek: all your testing has been with your local environment, right? | 16:37 |
xek | rloo, yes | 16:37 |
rloo | jroll: xek had mentioned to me that in other projects the CI wasn't avail when the code was, so they put it in as 'experimental'. something to consider. | 16:38 |
rloo | testing: http://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/support-rolling-upgrade.html#testing | 16:38 |
jroll | rloo: yeah, I suppose | 16:38 |
rloo | jlvillal, xek: in english, what of those do we think can be done in ocata? | 16:38 |
*** sacharya has joined #openstack-ironic | 16:39 | |
jlvillal | rloo, I doubt that the multi-node grenade will be done in Ocata. | 16:39 |
rloo | jlvillal: ok. so no testing of rolling upgrades. | 16:40 |
rloo | jlvillal: your status has 'multi-tenant', not multi-node. | 16:40 |
xek | jlvillal, rloo, jroll, I remember when discussing this list, that we accepted that the scope of the testing could be more narrow, or not ideal at first | 16:40 |
jlvillal | rloo, Correct. I have been working on getting grenade to work with multi-tenant. Will add multi-node after that. | 16:40 |
rloo | jlvillal: does multi-node need multi-tenant, or was that the order you decided to take? (just wondering) | 16:41 |
jlvillal | rloo, It will be multi-node, multi-tenant, and grenade. | 16:41 |
jroll | ok so with this rpcapi thing, we won't be setting the calculated defaults for nodes created without specific interfaces | 16:41 |
jroll | dtantsur: ^ | 16:41 |
jroll | I think that's the main point | 16:41 |
jlvillal | rloo, The current just multi-node job is tested with multi-tenant. But it was mostly just an order I decided. | 16:42 |
*** hshiina has joined #openstack-ironic | 16:42 | |
rloo | jlvillal: ok. | 16:42 |
dtantsur | sorry, I'm distracted with other things, what's the tl;dr of the problem? | 16:42 |
*** hoonetorg has joined #openstack-ironic | 16:42 | |
openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fix endpoint service name for inspector https://review.openstack.org/424227 | 16:42 |
jlvillal | rloo, We are close on the multi-tenant with grenade. So once that is done, add multi-node and see what breaks... | 16:43 |
rloo | jroll: i'm not a testing person. what do you think the minimum CI is needed for rolling upgrades, and/or for 'experimental' rolling upgrades? | 16:43 |
jroll | dtantsur: just trying to track down if this patch, when using the "old" node create stuff, will break us: https://review.openstack.org/#/c/420728/5 | 16:43 |
patchbot | patch 420728 - ironic - Add compatibility with Newton when creating a node | 16:43 |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add nodes tagging support - API https://review.openstack.org/250478 | 16:43 |
jroll | rloo: the first two sub-bullets in http://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/support-rolling-upgrade.html#testing IMO | 16:44 |
*** amarao has quit IRC | 16:44 | |
jroll | dtantsur: if you're busy just ignore me :) | 16:44 |
rloo | jlvillal: first bullet can be done? | 16:44 |
jroll | first bullet is already done | 16:44 |
jlvillal | rloo, I think that would be a question for xek. If you mean unit tests. | 16:44 |
dtantsur | jroll, this rolling upgrade thing, are we starting with Newton? | 16:44 |
dtantsur | I thought the first upgrade was Ocata->Pike.. | 16:45 |
rloo | jlvillal: no, grenade. but it is done. | 16:45 |
openstackgerrit | Merged openstack/ironic: Ipmitool management driver for Inject NMI https://review.openstack.org/348721 | 16:45 |
rloo | dtantsur: we're shooting for newton->ocata | 16:45 |
jroll | dtantsur: yeah, that's what current code does, newton->ocata | 16:45 |
*** hoonetorg has quit IRC | 16:45 | |
dtantsur | aha | 16:45 |
jroll | dtantsur: so the question is, does this break down enough that ocata-pike should be the first | 16:45 |
jlvillal | rloo, We have 'grenade' but not grenade with multi-node. So I think first bullet for multi-node grenade is not done. Since we don't have any multi-node grenade yet. | 16:45 |
dtantsur | so, is the concern that we won't have hardware types enabled on API? | 16:46 |
rloo | jroll: so most likely, 2nd bullet will not be done. if it is done and code is done, then upgrades can be in ocata. | 16:46 |
jroll | rloo: jlvillal: oh, I was wrong, the first sub-bullet is *not* done, jlvillal is right | 16:46 |
rloo | jroll: if 2nd bullet is not done and code is done, then ?? | 16:46 |
rloo | jroll: sigh. | 16:46 |
xek | jroll, dtantsur, also, keep in mind, that it is recomended in the upgrade procedure to upgrade the ironic client after the ironic service upgrade is finished, so would the --deploy-interface be somehow available in the old client when the new services are runnin pinned? | 16:46 |
jroll | dtantsur: right, we so far haven't loaded drivers in the api services | 16:46 |
openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add usage documentation for Baremetal OSC Plugin https://review.openstack.org/415261 | 16:47 |
jroll | xek: people just pip install ironicclient whenever they want, we must assume old/new clients need to always work | 16:47 |
jroll | xek: (except when used in services like nova) | 16:47 |
*** hoonetorg has joined #openstack-ironic | 16:47 | |
rloo | jroll, xek: i think we should spend some time looking into that create-node patch to see what the issues are. | 16:47 |
jroll | rloo: I'm half talking here and half doing that | 16:48 |
dtantsur | jroll, xek, right. we can take one more step back, and read the configuration options the way we used to; and forbid hardware types in the fallback case | 16:48 |
rloo | jroll: yeah, i figured so :) but i think we need to clarify the ci part. | 16:48 |
rloo | jroll: cuz i believe we can solve the coding part. i am not familiar enough about the testing part to have any confidence in that | 16:49 |
jroll | dtantsur: we never read the configs, we used rpcapi.get_topic_for(), which now includes hardware types :/ | 16:50 |
jroll | actually | 16:50 |
jroll | nope, it will, damn | 16:50 |
dtantsur | we did read the configs to determine the default network interface | 16:50 |
jroll | ah, yeah | 16:50 |
jroll | hrm, idk if I love that | 16:51 |
jroll | so here's where I'm at: | 16:51 |
jroll | 1) we'll need to take a step back (or two) in driver composition | 16:51 |
jroll | 2) we won't have CI at all | 16:51 |
jroll | 3) we're a week or so from our proposed soft feature freeze, and ~2 weeks from final release | 16:52 |
jroll | I'm not sure I see much benefit in landing this now, as opposed to the first week of pike, personally | 16:52 |
dtantsur | also, aren't we supposed to update all conductors first? | 16:52 |
jroll | other than to say "we did it!" | 16:52 |
jroll | dtantsur: we are, this is about the time between "everything is upgraded" and "rpc versions are unpinned" | 16:53 |
dtantsur | hmm, yes | 16:53 |
jroll | it would work if we didn't pin rpc | 16:53 |
vdrok | dtantsur: I think we won't be able to send ver 1.36 message if the rpc client is capped | 16:53 |
dtantsur | right, right | 16:53 |
xek | jroll, well, the https://review.openstack.org/#/c/420728/ patch is a fix for a bug we found doring testing, there may be others | 16:54 |
patchbot | patch 420728 - ironic - Add compatibility with Newton when creating a node | 16:54 |
jroll | xek: right, because we don't have CI, we don't even know if this works yet | 16:54 |
xek | jroll, shouldn't we treat all of them like bugs, and fix them after soft feature freeze? | 16:54 |
jroll | xek: right, but we can't say this works until we have CI anyway, so we won't actually know if the bug fixes actually fix it | 16:55 |
rloo | xek: what happens if there are bugs we don't find, and someone tries to do a rolling upgrade? if they could get into a bad state... i'm not sure we want to risk that. | 16:55 |
jroll | ++ | 16:55 |
rloo | jroll: is there any worth in having out there as experimental, so people can 'test' it? | 16:56 |
rloo | jroll: even with CI, there's only so much we'll be able to test. | 16:56 |
jroll | rloo: idk, people can just as easily test it after the branch. for example in a 7.1.0 release 3 weeks after PTG :) | 16:56 |
rloo | jroll: with the node-create, we could add code that just returns an error if they try with old api and conductor is pinned. | 16:57 |
*** david-lyle_ has joined #openstack-ironic | 16:57 | |
rloo | jroll: true, if/when there is a 7.1.0 release. | 16:57 |
jroll | rloo: we already did that (inadvertently) | 16:57 |
jroll | sure | 16:57 |
jroll | they can also test master, you get my point | 16:57 |
rloo | jroll: true | 16:58 |
rloo | jlvillal: the likelihood of getting multinode grenade is very low, right? | 16:58 |
rloo | jlvillal: in the next 2 weeks | 16:58 |
jlvillal | rloo, Yes. | 16:59 |
rloo | oh, meeting in one minute | 16:59 |
jroll | blah | 16:59 |
* jroll does the thing | 16:59 | |
rloo | we can discuss more at meeting or after. but i think we are punting to ocata. | 16:59 |
*** mjturek has joined #openstack-ironic | 16:59 | |
jroll | s/ocata/pike/ :) | 17:00 |
* jroll wonders out loud if a version column in ocata would be useful for ocata->pike | 17:00 | |
rloo | jroll: ++ to version column and yeah, pike. (pike, makes me think of star trek, i'm old...) | 17:01 |
*** baoli has quit IRC | 17:01 | |
*** Sukhdev has joined #openstack-ironic | 17:01 | |
*** rpioso has joined #openstack-ironic | 17:03 | |
*** david-lyle_ has quit IRC | 17:03 | |
*** stendulker has quit IRC | 17:05 | |
*** rajinir has joined #openstack-ironic | 17:06 | |
*** stendulker has joined #openstack-ironic | 17:08 | |
*** stendulker has quit IRC | 17:10 | |
openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Add wait_for_node_deploy parameter to deploy task with custom instance_info https://review.openstack.org/424244 | 17:10 |
*** e0ne has quit IRC | 17:13 | |
*** stendulker has joined #openstack-ironic | 17:13 | |
*** stendulker has quit IRC | 17:13 | |
*** stendulker has joined #openstack-ironic | 17:14 | |
*** ccamacho has quit IRC | 17:14 | |
openstackgerrit | Sam Betts proposed openstack/ironic: [WIP] Don't override device_owner for tenant network ports https://review.openstack.org/424248 | 17:15 |
*** tesseract has quit IRC | 17:15 | |
openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Allow enroll node with empty properties. https://review.openstack.org/424249 | 17:16 |
sambetts | jroll: ^ /me thinks that should solve the issue, but I'm waiting to see the consequences | 17:16 |
jroll | thanks | 17:16 |
*** baoli has joined #openstack-ironic | 17:18 | |
*** causten has quit IRC | 17:21 | |
*** causten has joined #openstack-ironic | 17:23 | |
*** causten has quit IRC | 17:26 | |
*** stendulker has quit IRC | 17:28 | |
*** mat128 is now known as mat128|afk | 17:28 | |
*** mat128_ has joined #openstack-ironic | 17:29 | |
*** stendulker has joined #openstack-ironic | 17:29 | |
openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Add missing packages https://review.openstack.org/424255 | 17:29 |
*** stendulker has quit IRC | 17:30 | |
*** stendulker has joined #openstack-ironic | 17:31 | |
*** causten has joined #openstack-ironic | 17:31 | |
*** stendulker has quit IRC | 17:32 | |
*** derekh has quit IRC | 17:33 | |
*** stendulker has joined #openstack-ironic | 17:33 | |
*** causten has quit IRC | 17:35 | |
*** dyasny has quit IRC | 17:36 | |
*** sayantani01 has quit IRC | 17:36 | |
*** aNuposic has joined #openstack-ironic | 17:36 | |
*** sacharya_ has joined #openstack-ironic | 17:37 | |
*** sacharya has quit IRC | 17:38 | |
*** stendulker has quit IRC | 17:39 | |
*** stendulker has joined #openstack-ironic | 17:41 | |
rook | dtantsur: hey - curious wrt nodes going into maintenance -- could we put in an interval to check if the node should _still_ be in maintenance mode? | 17:41 |
*** ohamada has quit IRC | 17:42 | |
dtantsur | rook, we've been planning on it for some time | 17:42 |
dtantsur | just never got to it. I think JayF was planning on something like that | 17:42 |
rook | dtantsur ok | 17:42 |
JayF | there is a spec under review | 17:42 |
jroll | rook: dtantsur https://review.openstack.org/#/c/334113/ | 17:42 |
patchbot | patch 334113 - ironic-specs - Add spec for specific faults support | 17:42 |
JayF | thanks for saving me a google jroll | 17:43 |
jroll | :P | 17:43 |
rook | dtantsur: we are seeing if there is another service hitting nodes via IPMI there is some sort of locking that causes nodes to be put into maintenance. | 17:43 |
rook | dtantsur: ie, Sat6 | 17:43 |
rook | thanks! | 17:43 |
*** stendulker has quit IRC | 17:44 | |
*** stendulker has joined #openstack-ironic | 17:45 | |
rloo | xek: is there any merit in adding the 'version' column and getting dbsync online migrations in, in ocata? (w/o the rolling upgrades code) | 17:45 |
rloo | xek: guess it'd need the mappings too. | 17:45 |
*** aparnav has quit IRC | 17:45 | |
jroll | we could skip this null bit: "This version column will be null at first and will be filled with the appropriate versions by a data migration script. If there is a change in Ocata that requires migration of data, we will check for null in the new version column." | 17:45 |
xek | rloo, I think the online migration scripts will be easier for developers | 17:46 |
TheJulia | I think there is always merit in getting the database structural changes in early, which is a behavior we will need to enforce moving forward. | 17:46 |
dtantsur | rook, why would Sat6 hit nodes via IPMI? this is a know problem indeed | 17:46 |
TheJulia | jroll: or s/a data migration script/`the command goes here` | 17:46 |
rloo | jroll: so my only concert wrt adding version column is that the feature itself that uses it, won't be avail. we have to be really sure we will use this... | 17:46 |
rook | dtantsur it captures the state of the node. | 17:46 |
jroll | rloo: I think we've agreed by now that it is useful | 17:47 |
TheJulia | rloo: if we suppress the version column from being returned by the API, which we should likely do anyway, then we can always remove it without it being a big deal | 17:47 |
jroll | ++ | 17:47 |
rloo | jroll: yup, just wanted to point it out cuz i'm always hesitant to add things too early :) but i'm good with it. | 17:47 |
jroll | rloo: you? hesitant? | 17:47 |
dtantsur | rook, why can't it use ironic API fo rthat? | 17:47 |
rloo | jroll: heh, like the resource classes stuff :) | 17:47 |
jroll | rloo: :) | 17:48 |
*** dyasny has joined #openstack-ironic | 17:48 | |
rloo | jroll, TheJulia, xek: so if we add new version column, jroll sez just use existing VERSION values, xek sez add dbsync migrations. ? | 17:48 |
jroll | I guess we'd need a migration to add existing values | 17:49 |
TheJulia | So.... | 17:49 |
*** stendulker_ has joined #openstack-ironic | 17:49 | |
TheJulia | The reason not to populate them now is not to churn the database | 17:50 |
rloo | jroll: right. i was thinking we could code, but that won't migrate any objects that aren't actually touched/modified. | 17:50 |
*** trown is now known as trown|lunch | 17:50 | |
rloo | it would be a good test/use of the new dbsync command. | 17:50 |
jroll | well, we wouldn't need the new command, though we could | 17:50 |
TheJulia | Our documentation would need to be a bit more specific in the upgrade process then, but I think that would work... | 17:51 |
jroll | ? | 17:52 |
*** stendulker_ has quit IRC | 17:52 | |
jroll | we don't have to add the new data migration command yet | 17:52 |
jroll | could just add 'update nodes set version=foo' in the migration to add the column | 17:52 |
TheJulia | Well, the spec details that it would just need to be run before, once we have it, we would need to be hyper detailed on the order of operations | 17:52 |
jroll | agree, but not for the ocata upgrade | 17:53 |
*** stendulker has quit IRC | 17:53 | |
TheJulia | jroll: exactly | 17:53 |
TheJulia | Sorry, my brain tends to think off in the future | 17:53 |
* jroll feels like there's a couple threads here | 17:53 | |
jroll | heh | 17:53 |
*** mgoddard has quit IRC | 17:54 | |
jroll | yeah my question right now is "how much of this, if any, should we land in the next 1.5 weeks" | 17:54 |
TheJulia | I think update nodes set version=blah could work, but I would be worried about how database locking would occur with all rows being updated, then again, it might not matter, I doubt there are many super large installs where that column update wouldn't take that long. | 17:55 |
aslezil | aareifiev: jayF: jroll: sambetts: (https://review.openstack.org/#/c/404372/) This is the spec for collecting biosdevname of NICs. re uploaded a patch as suggested by the community. Have a +2 on it. I would be great if someone could review it. | 17:55 |
patchbot | patch 404372 - ironic-inspector-specs - Collect NIC name given by BIOS | 17:55 |
TheJulia | jroll: I think if we add the version field and the versions, then we can add the command later | 17:55 |
vdrok | as it seems to me, the rpc version cap is pretty straightforward, and the behaviour does not change compared to the current situation | 17:55 |
TheJulia | Docs will need to be very specific on the upgrade happy path regardless | 17:55 |
dtantsur | see you tomorrow folks! | 17:56 |
TheJulia | goodnight dtantsur | 17:56 |
rloo | bye dtantsur! | 17:56 |
*** sayantani01 has joined #openstack-ironic | 17:56 | |
*** dtantsur is now known as dtantsur|afk | 17:56 | |
xek | TheJulia, they are updated using a limit, so this won't have a big impact | 17:56 |
rloo | vdrok: without CI, that part of it seems risky | 17:56 |
*** david-lyle_ has joined #openstack-ironic | 17:56 | |
*** david-lyle_ has quit IRC | 17:56 | |
rloo | xek: TheJulia was talking about not using the dbsync command | 17:56 |
rloo | xek: but doing a db update in code | 17:56 |
vdrok | good night dtta | 17:57 |
*** david-lyle_ has joined #openstack-ironic | 17:57 | |
vdrok | ouch, dtantsur|afk | 17:57 |
xek | rloo, in that case, the service will be down during the upgrade, so it doesn't matter | 17:57 |
rloo | xek: oh yeah, forgot about that! | 17:57 |
jroll | yeah, I think I'd be fine adding the version column/mappings this cycle, and hold the new dbsync command and rpc cap for pike | 17:57 |
rloo | xek: so what do you think? it'll make the code a bit easier in pike. but up to you i think. | 17:58 |
TheJulia | xek: I agree with the idea of that being helpful, I'm just not sure someone would actually do that out of the gate until they realize that their database is locked up for x amount of time and do something awful like control-c dbsync. Actually, that is the perfect argument for the online db upgrade command landing | 17:58 |
rloo | xek: cuz then, the .version will all be available for the objects | 17:58 |
rloo | TheJulia: if we assume a table with 10k nodes, any idea how long it'd take to add a new column and populate it? | 17:59 |
TheJulia | rloo: entirely dependent upon the disks, and db version at this point | 17:59 |
TheJulia | rloo: and any existing io contention | 17:59 |
jroll | I mean, even at a million rows, it should be fast | 18:00 |
xek | rloo, I can change the patch to go before the rpc one and add an (old style) offline migration in alembic | 18:00 |
jroll | and there's no way someone has a million rows in any of these tables without bragging about it | 18:00 |
rloo | jroll: yeah, that's what I'd think but I have no practical db experience | 18:00 |
TheJulia | jroll: That would be if the index is entirely in ram, if not, then it could be a not fun day for whoever the dab is | 18:00 |
TheJulia | err, s/dab/dba/ | 18:00 |
*** ralonsoh has quit IRC | 18:01 | |
* TheJulia has had indexes > physical ram and it is not fun | 18:01 | |
jroll | TheJulia: https://media.giphy.com/media/ordLtY9K29ZMk/giphy.gif | 18:01 |
vdrok | will the value of version be empty then? | 18:01 |
jroll | TheJulia: yeah, maybe you're right, dunno | 18:01 |
jroll | it'd be fine to populate it after the upgrade in the background somewhere | 18:01 |
rloo | vdrok: no, we're talking about coding it so the value of version == the object's VERSION value | 18:01 |
jroll | just... more code | 18:01 |
rloo | vdrok: and hence the lock on the db | 18:02 |
jroll | actually | 18:02 |
rloo | vdrok: and amoutn of time that would take | 18:02 |
openstackgerrit | Bob Fournier proposed openstack/ironic-inspector: Add plugin to process basic management LLDP TLVs https://review.openstack.org/406496 | 18:02 |
jroll | TheJulia: if the alembic migration sets a default for the new column, such that it is the right one, that shouldn't be any heavier than just adding the column, right? | 18:02 |
TheJulia | Of course, to have a db that size, someone would have to be operating a very, exceptionally large, ironic install | 18:02 |
jroll | or an exceptionally small db machine :P | 18:02 |
TheJulia | That does happen as well | 18:03 |
* TheJulia wonders what the airplane internet lag actually is at the moment | 18:04 | |
jroll | doesn't seem too bad | 18:04 |
*** mgould is now known as mgould|afk | 18:04 | |
TheJulia | jroll: Oh, that is right, setting a default, however if we set a table default, we would later have to remove the default | 18:04 |
* TheJulia hopes nobody interacts with ironic directly via the DB | 18:04 | |
jroll | TheJulia: yeah, I'm thinking if it can just write it and not set the table default | 18:05 |
rloo | TheJulia: the default value would be the object's class version. wouldn't need to remove it i think. | 18:05 |
jroll | Note that this statement uses the Column construct as is from the SQLAlchemy library. In particular, default values to be created on the database side are specified using the server_default parameter, and not default which only specifies Python-side defaults | 18:05 |
jroll | http://alembic.zzzcomputing.com/en/latest/ops.html#alembic.operations.Operations.add_column | 18:05 |
*** david-lyle_ is now known as david-lyle | 18:05 | |
jroll | I think default=foo is what we would want | 18:06 |
TheJulia | rloo: I need to think about that since we've been bitten by using current state with database upgrades before | 18:06 |
TheJulia | err, current state in code | 18:06 |
TheJulia | Specifically testing though... It should work if we just keep updating the default..... | 18:07 |
TheJulia | (for new records that is) | 18:07 |
rloo | TheJulia: ok, good to think about it. if we don't explicitly set the default value via code, what is the (if any) value of adding version column + dbsync-background-command-to-set in ocata, and rest of code in pike? | 18:07 |
xek | jroll, rloo, TheJulia, there wouldn't be an internal database default, the default value will be filled based on the object's version | 18:07 |
vdrok | yeah, having default=object.VERSION should be OK | 18:08 |
jroll | +1 | 18:08 |
rloo | +1 | 18:08 |
TheJulia | oh, that might bite us, old row, doesn't get touched, db upgrade, new default, no default on row... it might represent the new default automatically | 18:08 |
rloo | TheJulia: ? we want the old row to have the new default | 18:08 |
vdrok | TheJulia: if there were no updates, that means it should be OK | 18:09 |
xek | vdrok, it will be more complicated than that, because the version column is on the base mode and versioned objects are not that tightly coupled with sqlalchemy models | 18:09 |
TheJulia | but if there are migration activities, we need to undertake them, I would think | 18:09 |
xek | vdrok, *base model | 18:09 |
rloo | xek: if we add a version column in ocata (master), and set that value to be the object's VERSION, why won't that work? | 18:10 |
rloo | xek: this is during the cold upgrade to ocata. | 18:10 |
rloo | if this isn't that simple, we should just punt it all to pike. | 18:11 |
xek | rloo, because the version column is on the base model, so there is only one default we could set for all objects | 18:11 |
TheJulia | We would have to touch each row, I think we need the command + the version column field to at least build the pattern moving forward, since we can't use server side defaults for asserting the object version in the db | 18:11 |
xek | rloo, I think we should keep the version column on the base model, for consistency | 18:11 |
vdrok | xek: hmm, the create_node gets the values from object.get_changes right? And it could just include version=object.VERSION | 18:11 |
xek | rloo, so we can assume it's always present | 18:11 |
jroll | sounds like we should just punt the whole thing :P | 18:12 |
TheJulia | xek: except we need to scrub it from api replies | 18:12 |
TheJulia | s/api/all api/ | 18:12 |
rloo | jroll: yeah, that's what i'm thinking. i thought it was straightforward but am not sure now. | 18:12 |
jroll | ++ | 18:12 |
xek | rloo, vdrok, TheJulia the current implementation in my patch should work fine | 18:12 |
rloo | unless someone xek? can convince us otherwise. | 18:13 |
TheJulia | I think I'm onboard with eek as long as we not setting any server side table defaults | 18:13 |
TheJulia | xek | 18:13 |
* TheJulia tosses a wet cat at autocorrect | 18:13 | |
rloo | xek: what part of the current implementation? we don't want the rolling upgrades part. and unless we can guarantee that version column is populated in ocata (for upgrading to pike), i see no use in adding it in ocata | 18:13 |
xek | rloo, https://review.openstack.org/#/c/412397/29/ironic/objects/base.py@100 | 18:14 |
patchbot | patch 412397 - ironic - Add version column | 18:14 |
rloo | xek: i don't want to add obj_get_changes(). i don't think i do anyway. | 18:14 |
xek | rloo, the target_version would be always equal to obj.VERSION in this case | 18:14 |
TheJulia | But given we've got a shed, and we're trying to figure out how to modify the foundation without moving the shed, punting does sound like the ideal action project wise | 18:14 |
openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: snmp inspection for disk size https://review.openstack.org/394858 | 18:14 |
* TheJulia doesn't like the idea of punting | 18:15 | |
vdrok | xek: unless someone sets a pin :) We'd have to remove that option too for now | 18:15 |
rloo | xek: so we'd add a version column with null value, and then it would get set if an object gets modified. which means we'd need the offline dbsync command. | 18:15 |
xek | vdrok, agreed, so this line would just be changes['version'] = self.VERSION | 18:16 |
rloo | vdrok: we wouldnt' have a pin; we're talking about no rolling upgrades code, just the version column. | 18:16 |
xek | rloo, no, I will also add a data migration to the alembic script, to fill the columns with proper versions | 18:16 |
vdrok | rloo: I mean that, current patches don't do just set the version, they do more. Some things should be dropped from there | 18:16 |
rloo | vdrok: right, we wouldn't want all that code. | 18:17 |
xek | rloo, so that any scripts that are implemented later on can assume that there is always a version there | 18:17 |
jroll | yeah, this seems not worth it to me | 18:17 |
jroll | as much as I want it to be | 18:17 |
rloo | xek: by data migration, you mean using the dbsync command, right? | 18:17 |
*** amotoki has quit IRC | 18:18 | |
xek | xek, no, the old alembic upgrade migration | 18:18 |
rloo | xek: this is where i am confused then. that was what we were talking about i think, adding to the alembic migration to set version to the object's VERSION. why would we need the code you pointed out? | 18:19 |
xek | rloo, to set the version properly for objects created after the upgrade | 18:19 |
rloo | xek: right, in pike. we'd need that code before we change the version for any object, right? | 18:20 |
xek | rloo, yes, so that when doing a rolling upgrade to pike, the ocata version, that can still be running, writes it's object versions when it is writing data | 18:21 |
*** sambetts is now known as sambetts|afk | 18:21 | |
rloo | xek: gotcha. so it is needed as part of the rolling upgrades code that will go in pike (or as i mentioned, before we change the version for any object) | 18:22 |
rloo | xek: so maybe it isn't worth doing in ocata then. cuz i'm not sure i want to put in that code w/o the rest of the rolling upgrades code. | 18:23 |
xek | rloo, yes, that is if we want to assume that the we can always count on the version being there | 18:23 |
rloo | xek: exactly. so i think for now, if we punt to pike, we'll know exactly what state/value that new column will have. it might be safer to deal with then. | 18:23 |
TheJulia | I need to drop off because we're landing shortly. I think we should not make that assumption for pike, but that is just me. :) | 18:23 |
*** causten has joined #openstack-ironic | 18:24 | |
rloo | I agree with TheJulia. so lets punt this feature to pike. Sorry xek. | 18:24 |
xek | rloo, yeah, we can always get the patches as they are in pike, the upgrades from ocata will be possible just like upgrades from newton if we get it in in ocata | 18:24 |
*** ChubYann has joined #openstack-ironic | 18:25 | |
rloo | xek: i'll continue to review the patches, but probably not as frequently until we get ocata out. | 18:25 |
TheJulia | xek: alternatively, first thing we add is the version column, from there we cut a release, and version from there. | 18:25 |
TheJulia | or, we back-version the data | 18:25 |
*** causten has quit IRC | 18:25 | |
rloo | TheJulia: i think it is risky. we talk about getting rolling upgrades code in early pike, but it will still depend on CI. | 18:25 |
* TheJulia is thinking so Ocata -> Pike online upgrades would work | 18:25 | |
TheJulia | rloo: agreed | 18:26 |
TheJulia | rloo: then again, we should just get the command in that does a noop first | 18:26 |
rloo | TheJulia: i think we're good with Ocata -> Pike upgrade working, with xek's stuff. (just like we would have been with newton->ocata, and w/o the node-create issue) | 18:26 |
TheJulia | okay, going now since they are now going to yell at me for having a laptop out :) | 18:26 |
rloo | bye TheJulia! | 18:26 |
xek | I also have to go, it's my girlfriends birthday today :P | 18:27 |
vdrok | and /me leaves too :) | 18:27 |
joanna | xek: wish her best! | 18:27 |
vdrok | good night everyone! | 18:27 |
rloo | xek: enjoy! thx for staying late! | 18:27 |
xek | bye! | 18:28 |
joanna | night, vdrok :) | 18:28 |
rloo | bye vdrok | 18:29 |
openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Add socat package https://review.openstack.org/424255 | 18:31 |
*** mjura has quit IRC | 18:38 | |
* jroll lunches | 18:39 | |
*** jcoufal has joined #openstack-ironic | 18:39 | |
*** jcoufal__ has joined #openstack-ironic | 18:42 | |
*** jcoufal_ has quit IRC | 18:42 | |
*** jcoufal_ has joined #openstack-ironic | 18:45 | |
*** mgoddard has joined #openstack-ironic | 18:45 | |
*** jcoufal has quit IRC | 18:45 | |
*** e0ne has joined #openstack-ironic | 18:46 | |
*** mrtenio has joined #openstack-ironic | 18:46 | |
mrtenio | Hi, sorry, today morning I asked something and left. Is there a timeout parameter when setting the boot device? Or is it always 60 seconds? | 18:48 |
*** jcoufal__ has quit IRC | 18:48 | |
*** jcoufal has joined #openstack-ironic | 18:58 | |
openstackgerrit | Solio Sarabia proposed openstack/ironic-tempest-plugin: WIP/DNM: Migrate ironic-tempest-plugin to new repo https://review.openstack.org/419602 | 19:00 |
openstackgerrit | Hironori Shiina proposed openstack/python-ironicclient: Fix node-inject-nmi to pass an empty body https://review.openstack.org/424293 | 19:01 |
*** jcoufal_ has quit IRC | 19:01 | |
hshiina | hi, a small fix is necessary for nmi in ironicclient | 19:03 |
hshiina | please review : https://review.openstack.org/#/c/424293/ | 19:04 |
patchbot | patch 424293 - python-ironicclient - Fix node-inject-nmi to pass an empty body | 19:04 |
*** jcoufal_ has joined #openstack-ironic | 19:07 | |
*** trown|lunch is now known as trown | 19:09 | |
*** jcoufal has quit IRC | 19:10 | |
*** jcoufal__ has joined #openstack-ironic | 19:10 | |
*** hshiina has quit IRC | 19:11 | |
*** amarao has joined #openstack-ironic | 19:11 | |
*** jcoufal_ has quit IRC | 19:12 | |
aNuposic | mrtenio: This might be something helpful https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L969 | 19:13 |
*** amoralej is now known as amoralej|off | 19:13 | |
aNuposic | mrtenio: not sure though if that's exactly what you are looking | 19:14 |
*** amarao has quit IRC | 19:16 | |
*** amotoki has joined #openstack-ironic | 19:18 | |
*** Sukhdev_ has joined #openstack-ironic | 19:21 | |
*** hshiina has joined #openstack-ironic | 19:22 | |
*** mgoddard has quit IRC | 19:29 | |
*** strigazi is now known as strigazi_AFK | 19:30 | |
*** jkilpatr has quit IRC | 19:34 | |
*** causten has joined #openstack-ironic | 19:40 | |
openstackgerrit | Hironori Shiina proposed openstack/python-ironicclient: Fix node-inject-nmi to pass an empty body https://review.openstack.org/424293 | 19:46 |
*** jkilpatr has joined #openstack-ironic | 19:47 | |
*** Nisha_Agarwal has quit IRC | 19:48 | |
*** jaosorior has quit IRC | 19:50 | |
*** bcornec1 has joined #openstack-ironic | 19:52 | |
*** sayantani01 has quit IRC | 19:53 | |
*** sayantani01 has joined #openstack-ironic | 19:57 | |
*** causten has quit IRC | 19:58 | |
*** sayantan_ has joined #openstack-ironic | 19:58 | |
*** sayantani01 has quit IRC | 19:58 | |
*** hshiina has quit IRC | 19:59 | |
rloo | JayF: a while ago, we discussed some doc, was it admin? and how we have some of that stuff in our tree and others in the openstack admin guide. or whatever guide it was. did you ever remove the content from the openstack <whatever> guide, and/or point it to our intree stuff? | 19:59 |
*** Sukhdev has quit IRC | 20:01 | |
*** sayantan_ has quit IRC | 20:01 | |
*** jcoufal__ is now known as jcoufal | 20:04 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Allow using resource classes https://review.openstack.org/407651 | 20:06 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: DNM: turn on resource classes https://review.openstack.org/423269 | 20:06 |
*** dprince has quit IRC | 20:10 | |
*** dyasny has quit IRC | 20:14 | |
*** causten has joined #openstack-ironic | 20:28 | |
*** aNuposic has quit IRC | 20:31 | |
*** mat128_ has quit IRC | 20:36 | |
csmart | \o morning | 20:38 |
*** moshele has joined #openstack-ironic | 20:43 | |
*** bcornec1 has quit IRC | 20:48 | |
*** aNuposic has joined #openstack-ironic | 20:48 | |
*** jcoufal_ has joined #openstack-ironic | 20:50 | |
*** Sukhdev has joined #openstack-ironic | 20:51 | |
*** cfarquhar has joined #openstack-ironic | 20:52 | |
*** jcoufal has quit IRC | 20:53 | |
*** jcoufal has joined #openstack-ironic | 20:53 | |
*** causten has quit IRC | 20:56 | |
*** jcoufal_ has quit IRC | 20:56 | |
*** mjturek has quit IRC | 20:58 | |
*** causten has joined #openstack-ironic | 21:00 | |
*** hoangcx has joined #openstack-ironic | 21:01 | |
* TheJulia re-appears having had lunch \o/ | 21:04 | |
mrtenio | csmart, morning :) | 21:05 |
*** mjturek has joined #openstack-ironic | 21:11 | |
openstackgerrit | Mario Villaplana proposed openstack/ironic-python-agent: WIP: IPA rescue extension https://review.openstack.org/423521 | 21:11 |
openstackgerrit | Julia Kreger proposed openstack/ironic: Add base cinder common interface https://review.openstack.org/355625 | 21:12 |
*** jerrygb has quit IRC | 21:12 | |
mariojv | JayF: i have not tested this out yet, but that ^ has the bash, network config template, and cloud-config for coreos rescue w/ ipv4 dhcp tenant networks | 21:13 |
openstackgerrit | Julia Kreger proposed openstack/ironic: Add base cinder common interface https://review.openstack.org/355625 | 21:14 |
mariojv | i suspect tinyipa will be easier, going to focus on reviews the rest of the day and try to get the remainder of that working tomorrow | 21:14 |
mariojv | i think the agent driver patch will need a small change to make configdrive optional though | 21:14 |
*** rama_y has joined #openstack-ironic | 21:15 | |
openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic-inspector-specs: Collect Bios, Memory and Processor Info from Dmidecode https://review.openstack.org/406790 | 21:19 |
*** mrtenio is now known as mrtenio-afk | 21:20 | |
*** ijw has joined #openstack-ironic | 21:23 | |
*** mrtenio-afk has quit IRC | 21:24 | |
openstackgerrit | Merged openstack/ironic: Add tests for Payloads with SCHEMAs https://review.openstack.org/418148 | 21:28 |
*** aNuposic has quit IRC | 21:28 | |
jroll | rloo: how terrible would it be to add an api version in one patch, and use it for a thing in the next patch? should I squash those instead? | 21:30 |
*** causten has quit IRC | 21:30 | |
rloo | jroll: depends. do you mean it 'only' adds an api version? | 21:30 |
rloo | jroll: if it only does that, it makes no sense? | 21:31 |
*** jerrygb has joined #openstack-ironic | 21:31 | |
jroll | rloo: no, this api version does many things | 21:31 |
jroll | rloo: so would you rather those many things be in one patch or a couple | 21:31 |
*** causten has joined #openstack-ironic | 21:31 | |
rloo | jroll: oh. crap. in one patch. otherwise i think it messes things. ie, you'd need to bump the version with each patch. | 21:32 |
jroll | oh I'm not even sure I can version this, hm | 21:32 |
jroll | yeah | 21:32 |
*** jerrygb_ has joined #openstack-ironic | 21:32 | |
jroll | rloo: alright, I will squash these things | 21:33 |
jroll | thanks | 21:33 |
rloo | jroll: thx. i prefer bigger patches myself but i am the odd person out in that regard i think. | 21:33 |
jroll | rloo: huh, interesting | 21:33 |
*** jkilpatr has quit IRC | 21:34 | |
rloo | jroll: well, within reason. but 'reason' is interpreted differently so... | 21:34 |
*** Goneri has quit IRC | 21:35 | |
*** jerrygb has quit IRC | 21:36 | |
*** srobert_ has joined #openstack-ironic | 21:36 | |
*** srobert has quit IRC | 21:39 | |
*** srobert_ has quit IRC | 21:41 | |
jroll | fancy: https://www.kennethreitz.org/essays/announcing-pipenv | 21:42 |
openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic: Enable OSProfiler support in Ironic https://review.openstack.org/358142 | 21:45 |
*** moshele has quit IRC | 21:47 | |
*** jkilpatr has joined #openstack-ironic | 21:47 | |
*** anush has quit IRC | 21:48 | |
openstackgerrit | Mario Villaplana proposed openstack/ironic: Agent driver rescue implementation https://review.openstack.org/400437 | 21:53 |
*** priteau has quit IRC | 21:55 | |
openstackgerrit | Mario Villaplana proposed openstack/ironic-python-agent: WIP: IPA rescue extension https://review.openstack.org/423521 | 21:56 |
*** causten has quit IRC | 21:56 | |
*** causten has joined #openstack-ironic | 21:57 | |
*** causten has quit IRC | 22:01 | |
*** harlowja has quit IRC | 22:03 | |
* jroll is fairly certain all vendor passthru endpoints are broken, lol | 22:03 | |
*** ElCoyote_ has quit IRC | 22:03 | |
jroll | dtantsur|afk: ^^ | 22:03 |
*** baoli has quit IRC | 22:04 | |
*** e0ne has quit IRC | 22:04 | |
*** hoangcx has quit IRC | 22:05 | |
*** e0ne has joined #openstack-ironic | 22:06 | |
*** e0ne has quit IRC | 22:06 | |
*** e0ne has joined #openstack-ironic | 22:06 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add dynamic driver functionality to driver list/show APIs https://review.openstack.org/417970 | 22:06 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: WIP: vendor passthru for hw types https://review.openstack.org/423537 | 22:06 |
*** e0ne has quit IRC | 22:07 | |
*** e0ne has joined #openstack-ironic | 22:07 | |
*** dprince has joined #openstack-ironic | 22:07 | |
*** e0ne has quit IRC | 22:08 | |
*** e0ne has joined #openstack-ironic | 22:08 | |
*** e0ne has quit IRC | 22:08 | |
*** aNuposic has joined #openstack-ironic | 22:08 | |
*** e0ne has joined #openstack-ironic | 22:09 | |
*** e0ne has quit IRC | 22:09 | |
*** jheroux has quit IRC | 22:12 | |
*** dprince has quit IRC | 22:15 | |
openstackgerrit | Julia Kreger proposed openstack/ironic: Add Cinder storage driver https://review.openstack.org/366197 | 22:18 |
*** trown is now known as trown|outtypewww | 22:22 | |
*** mjturek has quit IRC | 22:24 | |
* jroll out for the night, see y'all tomorrow | 22:26 | |
*** mgoddard has joined #openstack-ironic | 22:26 | |
*** rama_y has quit IRC | 22:27 | |
jlvillal | Not sure if people know. But there is a known issue with all grenade jobs. Waiting for fix to land. So likely our gate is broken too. | 22:33 |
jlvillal | Need this to land: https://review.openstack.org/424323 | 22:33 |
patchbot | patch 424323 - requirements (stable/newton) - Update packaging to 16.8 | 22:33 |
*** dyasny has joined #openstack-ironic | 22:36 | |
rloo | jlvillal: thx for the heads up. that might explain why i couldn't get a newton ironic to work earlier today. | 22:40 |
jlvillal | rloo: Yeah. I was trying to figure out why I kept dying locally, after fixing the new Python 3 pip3 issue in devstack for my local build. And then ran into that issue. | 22:42 |
jlvillal | I feel like I've wasted most of my day because other stuff has broken me... | 22:42 |
rloo | jlvillal: :-(. I took the easy way out and didn't look into it. | 22:42 |
jlvillal | rloo: Smart! I wish I had that option. But since my work is make grenade work, I kind of had to look into it :) | 22:43 |
rloo | jlvillal: well, it is good that someone looks into the issue... | 22:43 |
jlvillal | rloo: Thanks | 22:44 |
rloo | jlvillal: so thank you! :D | 22:44 |
jlvillal | :) | 22:44 |
rloo | jlvillal: i'm already almost screaming cuz i wanted to check someone's patch, so didn't want to get side-tracked... | 22:44 |
jlvillal | I do see I have 210 unread threads in openstack-dev. maybe I should go read them... | 22:45 |
rloo | jlvillal: :) | 22:46 |
*** mtanino has quit IRC | 22:49 | |
*** mgoddard has quit IRC | 22:55 | |
*** rama_y has joined #openstack-ironic | 23:01 | |
*** dsneddon is now known as dsneddon_afk | 23:07 | |
*** dsneddon has joined #openstack-ironic | 23:11 | |
*** alexpilotti has joined #openstack-ironic | 23:19 | |
jlvillal | rloo: FYI: The fix for grenade has landed. So hopefully are grenade jobs are working again. | 23:23 |
*** jkilpatr has quit IRC | 23:29 | |
rloo | jlvillal: thx. we can only hope :) | 23:33 |
*** harlowja has joined #openstack-ironic | 23:34 | |
*** harlowja has quit IRC | 23:35 | |
*** mtanino has joined #openstack-ironic | 23:40 | |
*** Sukhdev has quit IRC | 23:41 | |
openstackgerrit | Joanna Taryma proposed openstack/ironic: WIP host ipxe static assets in devstack on :80 https://review.openstack.org/424374 | 23:44 |
*** awiddersheim has quit IRC | 23:45 | |
*** awiddersheim has joined #openstack-ironic | 23:45 | |
*** harlowja has joined #openstack-ironic | 23:48 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironic-inspector-client: Updated from global requirements https://review.openstack.org/423680 | 23:51 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/423681 | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!