| *** baoli has joined #openstack-ironic | 00:01 | |
| openstackgerrit | Lin Yang proposed openstack/sushy master: Parse generic attributions for redfish resource https://review.openstack.org/448834 | 00:04 |
|---|---|---|
| *** Goneri has quit IRC | 00:17 | |
| *** baoli has quit IRC | 00:17 | |
| *** baoli has joined #openstack-ironic | 00:17 | |
| *** rpioso has quit IRC | 00:18 | |
| *** Goneri has joined #openstack-ironic | 00:19 | |
| openstackgerrit | Lin Yang proposed openstack/sushy master: Parse generic attributions for redfish resource https://review.openstack.org/448834 | 00:33 |
| *** vishwanathj has joined #openstack-ironic | 00:39 | |
| openstackgerrit | Xiong proposed openstack/ironic master: remove log translations https://review.openstack.org/449373 | 00:42 |
| *** sayantani01 has quit IRC | 00:43 | |
| *** baoli has quit IRC | 00:44 | |
| *** vishwanathj has quit IRC | 00:44 | |
| *** causten has joined #openstack-ironic | 00:54 | |
| *** phuongnh has joined #openstack-ironic | 00:55 | |
| openstackgerrit | Lin Yang proposed openstack/sushy master: Parse generic attributions for redfish resource https://review.openstack.org/448834 | 00:56 |
| *** causten has quit IRC | 00:58 | |
| *** tovin07 has joined #openstack-ironic | 00:58 | |
| *** SerenaFeng has joined #openstack-ironic | 01:02 | |
| *** baoli has joined #openstack-ironic | 01:11 | |
| *** sayantani01 has joined #openstack-ironic | 01:13 | |
| *** baoli has quit IRC | 01:15 | |
| *** SerenaFeng has quit IRC | 01:25 | |
| *** zhurong has joined #openstack-ironic | 01:26 | |
| *** SerenaFeng has joined #openstack-ironic | 01:30 | |
| *** vishwanathj has joined #openstack-ironic | 01:40 | |
| *** vishwanathj has quit IRC | 01:45 | |
| *** gcb has joined #openstack-ironic | 01:48 | |
| *** vishwanathj has joined #openstack-ironic | 02:06 | |
| *** vishwanathj has quit IRC | 02:07 | |
| *** vishwanathj has joined #openstack-ironic | 02:09 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Add new dbsync command with first online data migration https://review.openstack.org/408556 | 02:10 |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Add version column https://review.openstack.org/412397 | 02:10 |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Add RPC and object version pinning https://review.openstack.org/407491 | 02:10 |
| *** vishwanathj has quit IRC | 02:10 | |
| *** vishwanathj has joined #openstack-ironic | 02:11 | |
| *** Sukhdev has quit IRC | 02:17 | |
| *** sayantani01 has quit IRC | 02:27 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Unit test for checking cross-version migrations compatibility https://review.openstack.org/419993 | 02:32 |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Rolling upgrade procedure documentation https://review.openstack.org/416565 | 02:33 |
| *** rloo has quit IRC | 02:44 | |
| *** raginbajin has quit IRC | 02:47 | |
| *** raginbajin has joined #openstack-ironic | 02:52 | |
| *** tuanluong has joined #openstack-ironic | 02:56 | |
| *** yuanying has quit IRC | 02:58 | |
| *** SerenaFeng has quit IRC | 02:58 | |
| *** gcb has quit IRC | 02:58 | |
| *** gcb has joined #openstack-ironic | 02:59 | |
| *** zackf has joined #openstack-ironic | 02:59 | |
| *** SerenaFeng has joined #openstack-ironic | 03:01 | |
| *** sasha21 has quit IRC | 03:05 | |
| *** SerenaFeng has quit IRC | 03:15 | |
| *** SerenaFeng has joined #openstack-ironic | 03:19 | |
| *** SerenaFeng has quit IRC | 03:32 | |
| *** aparnav has joined #openstack-ironic | 03:41 | |
| openstackgerrit | Merged openstack/ironic master: Updated from global requirements https://review.openstack.org/448137 | 03:42 |
| *** zhurong has quit IRC | 04:07 | |
| *** vmud213 has joined #openstack-ironic | 04:08 | |
| *** links has joined #openstack-ironic | 04:20 | |
| *** rbudden has quit IRC | 04:20 | |
| *** yuanying has joined #openstack-ironic | 04:20 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic master: DNM: Add RedfishInspect Interface https://review.openstack.org/449425 | 04:21 |
| openstackgerrit | Jun Yao proposed openstack/ironic-inspector master: Adds node state to the API response data https://review.openstack.org/436415 | 04:28 |
| *** amotoki has joined #openstack-ironic | 04:31 | |
| *** zer0c00l_ has quit IRC | 04:32 | |
| *** zer0c00l has joined #openstack-ironic | 04:32 | |
| *** amotoki has quit IRC | 04:35 | |
| *** amotoki has joined #openstack-ironic | 04:44 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Rolling upgrade procedure documentation https://review.openstack.org/416565 | 04:49 |
| *** udesale has joined #openstack-ironic | 04:57 | |
| *** amotoki has quit IRC | 04:58 | |
| *** amotoki has joined #openstack-ironic | 05:01 | |
| *** fragatin_ has joined #openstack-ironic | 05:01 | |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic master: Make terminal timeout value configurable https://review.openstack.org/449134 | 05:01 |
| *** fragati__ has joined #openstack-ironic | 05:03 | |
| *** Sukhdev has joined #openstack-ironic | 05:04 | |
| *** fragatina has quit IRC | 05:05 | |
| *** fragatin_ has quit IRC | 05:06 | |
| *** fragati__ has quit IRC | 05:07 | |
| *** amotoki has quit IRC | 05:09 | |
| *** udesale has quit IRC | 05:11 | |
| *** udesale__ has joined #openstack-ironic | 05:11 | |
| *** vikrant has joined #openstack-ironic | 05:11 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic master: DNM: Add RedfishInspect Interface https://review.openstack.org/449425 | 05:13 |
| *** zhurong has joined #openstack-ironic | 05:16 | |
| openstackgerrit | Karthik S proposed openstack/ironic-python-agent master: NUMA-topology collector https://review.openstack.org/424729 | 05:19 |
| *** udesale__ has quit IRC | 05:20 | |
| *** udesale has joined #openstack-ironic | 05:20 | |
| *** udesale has quit IRC | 05:21 | |
| *** fragatina has joined #openstack-ironic | 05:21 | |
| *** udesale has joined #openstack-ironic | 05:22 | |
| *** fragatina has quit IRC | 05:25 | |
| *** Sukhdev has quit IRC | 05:29 | |
| *** fragatina has joined #openstack-ironic | 05:33 | |
| *** fragatina has quit IRC | 05:33 | |
| *** fragatina has joined #openstack-ironic | 05:34 | |
| *** zackf has quit IRC | 05:42 | |
| *** sayantani01 has joined #openstack-ironic | 05:45 | |
| *** SerenaFeng has joined #openstack-ironic | 05:50 | |
| *** amotoki has joined #openstack-ironic | 05:58 | |
| *** yee37914 has quit IRC | 06:06 | |
| *** yee379 has joined #openstack-ironic | 06:08 | |
| *** yee379 has quit IRC | 06:12 | |
| *** yee379 has joined #openstack-ironic | 06:12 | |
| *** mjura has joined #openstack-ironic | 06:14 | |
| *** yee379 has quit IRC | 06:14 | |
| *** yee379 has joined #openstack-ironic | 06:15 | |
| *** sayantani01 has quit IRC | 06:25 | |
| *** sayantani01 has joined #openstack-ironic | 06:26 | |
| *** gcb has quit IRC | 06:28 | |
| *** phuongnh has quit IRC | 06:29 | |
| *** phuongnh has joined #openstack-ironic | 06:30 | |
| *** fxpester has joined #openstack-ironic | 06:42 | |
| *** yee379 has quit IRC | 06:44 | |
| *** yee379 has joined #openstack-ironic | 06:44 | |
| *** gcb has joined #openstack-ironic | 06:45 | |
| *** kavithahr has quit IRC | 06:48 | |
| *** ChubYann has quit IRC | 06:54 | |
| *** pmannidi has quit IRC | 07:21 | |
| *** ralonsoh has joined #openstack-ironic | 07:23 | |
| *** sayantani01 has quit IRC | 07:24 | |
| *** phuongnh has quit IRC | 07:27 | |
| *** phuongnh has joined #openstack-ironic | 07:28 | |
| *** pmannidi has joined #openstack-ironic | 07:28 | |
| *** tesseract has joined #openstack-ironic | 07:31 | |
| *** pmannidi has quit IRC | 07:32 | |
| openstackgerrit | Julian Edwards proposed openstack/ironic master: Don't retry power status if power action fails https://review.openstack.org/449454 | 07:35 |
| openstackgerrit | M V P Nitesh proposed openstack/python-ironicclient master: Adding the man page for Ironic https://review.openstack.org/449456 | 07:41 |
| *** jaosorior has joined #openstack-ironic | 07:55 | |
| *** kromanenko has joined #openstack-ironic | 07:56 | |
| *** ccamacho has joined #openstack-ironic | 07:58 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** SerenaFeng has quit IRC | 08:01 | |
| *** zzzeek has joined #openstack-ironic | 08:01 | |
| *** SerenaFeng has joined #openstack-ironic | 08:02 | |
| *** ralonsoh has quit IRC | 08:07 | |
| *** mgoddard has joined #openstack-ironic | 08:12 | |
| *** amarao has joined #openstack-ironic | 08:15 | |
| *** vikrant has quit IRC | 08:16 | |
| *** vikrant has joined #openstack-ironic | 08:18 | |
| *** amoralej|off is now known as amoralej | 08:23 | |
| *** stendulker has joined #openstack-ironic | 08:35 | |
| *** mgoddard has quit IRC | 08:40 | |
| *** milan has joined #openstack-ironic | 08:40 | |
| *** aarefiev_pto is now known as aarefiev | 08:42 | |
| aarefiev | morning all! | 08:42 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic master: Define minimum required API ver for portgroups https://review.openstack.org/449488 | 08:43 |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic master: Make terminal timeout value configurable https://review.openstack.org/449134 | 08:45 |
| openstackgerrit | Merged openstack/bifrost master: Fix clouds var in install.yaml playbook https://review.openstack.org/449125 | 08:52 |
| *** ralonsoh has joined #openstack-ironic | 08:52 | |
| openstackgerrit | klyang proposed openstack/ironic master: Add Error Codes to ironic api references,include nodes,nodes-management,node-passthru and chassis https://review.openstack.org/449495 | 08:52 |
| pas-ha | morning ironic :) | 08:53 |
| *** athomas has joined #openstack-ironic | 08:57 | |
| *** alex_xu has quit IRC | 08:58 | |
| *** alex_xu has joined #openstack-ironic | 08:59 | |
| *** vills has joined #openstack-ironic | 09:00 | |
| *** milan has quit IRC | 09:00 | |
| openstackgerrit | klyang proposed openstack/ironic master: Add Error Codes to ironic api references https://review.openstack.org/449495 | 09:00 |
| *** alex_xu has quit IRC | 09:01 | |
| *** alex_xu has joined #openstack-ironic | 09:02 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic stable/ocata: Pin version of proliantutils https://review.openstack.org/449504 | 09:03 |
| *** ralonsoh_ has joined #openstack-ironic | 09:05 | |
| *** alex_xu has quit IRC | 09:06 | |
| *** alex_xu has joined #openstack-ironic | 09:07 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic-specs master: API Evolution - ETAG identifiers https://review.openstack.org/381991 | 09:08 |
| *** ralonsoh has quit IRC | 09:09 | |
| *** yuanying has quit IRC | 09:12 | |
| *** udesale has quit IRC | 09:15 | |
| *** mgoddard has joined #openstack-ironic | 09:18 | |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector master: Test tempest jobs https://review.openstack.org/449516 | 09:21 |
| *** racedo has joined #openstack-ironic | 09:21 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/bifrost stable/ocata: Pin proliantutils version https://review.openstack.org/449518 | 09:21 |
| *** tuanluong has quit IRC | 09:23 | |
| *** Nisha_ has joined #openstack-ironic | 09:25 | |
| *** ralonsoh_ is now known as ralonsoh | 09:27 | |
| *** lucas-afk is now known as lucasagomes | 09:29 | |
| lucasagomes | morning all | 09:29 |
| Nisha_ | lucasagomes, o/ | 09:31 |
| *** Nisha_brb has joined #openstack-ironic | 09:33 | |
| *** Nisha_ has quit IRC | 09:33 | |
| *** Nisha_brb is now known as Nisha_Agarwal | 09:33 | |
| *** derekh has joined #openstack-ironic | 09:33 | |
| *** jrist has quit IRC | 09:34 | |
| *** Nisha_Agarwal has quit IRC | 09:39 | |
| *** Nisha_ has joined #openstack-ironic | 09:39 | |
| *** SerenaFeng has quit IRC | 09:40 | |
| *** Nisha_brb has joined #openstack-ironic | 09:47 | |
| *** Nisha_ has quit IRC | 09:47 | |
| *** snecklifter has joined #openstack-ironic | 09:48 | |
| *** Nisha_brb has quit IRC | 09:49 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 09:49 | |
| *** Nisha_ has joined #openstack-ironic | 09:50 | |
| *** Nisha_Agarwal has quit IRC | 09:50 | |
| *** vills has quit IRC | 09:51 | |
| *** Nisha_ has quit IRC | 09:52 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic master: Fixes boot and deploy interface validation for iLO https://review.openstack.org/445588 | 09:52 |
| *** mat128 has joined #openstack-ironic | 09:53 | |
| *** e0ne has joined #openstack-ironic | 09:53 | |
| vdrok | morning all, pas-ha lucasagomes | 09:54 |
| lucasagomes | o/ | 09:54 |
| vdrok | and morning aarefiev :) | 09:54 |
| *** yuanying has joined #openstack-ironic | 09:54 | |
| aarefiev | morning vdrok :) | 09:54 |
| aarefiev | morning lucasagomes, Nisha_ | 09:55 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic master: Define minimum required API ver for portgroups https://review.openstack.org/449488 | 09:56 |
| *** Serlex has joined #openstack-ironic | 09:57 | |
| *** karthiks is now known as karthiks_afk | 10:02 | |
| *** pcaruana has joined #openstack-ironic | 10:05 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic stable/newton: [devstack] Use global requirements for virtualbmc https://review.openstack.org/448631 | 10:06 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic stable/ocata: [devstack] Use global requirements for virtualbmc https://review.openstack.org/448632 | 10:07 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/bifrost stable/ocata: Change dib element to enable serial console https://review.openstack.org/449547 | 10:12 |
| *** MattMan has quit IRC | 10:12 | |
| *** MattMan has joined #openstack-ironic | 10:12 | |
| openstackgerrit | Fatih Degirmenci proposed openstack/bifrost master: Test OPNFV CI verify job. Please ignore. https://review.openstack.org/367608 | 10:13 |
| *** deadnull has joined #openstack-ironic | 10:23 | |
| deadnull | Is Ironic in Ocata still limited to a single flat network for hosts? | 10:23 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic stable/mitaka: DNM test gates with disabled *_ssh drivers https://review.openstack.org/439781 | 10:26 |
| pas-ha | deadnull: no, network separation aka multitenancy support is available since Newton | 10:28 |
| deadnull | Just saw that in docs, via the neutron driver, thanks pas-ha ! | 10:28 |
| deadnull | Working on an openstack deployment to run a lab infrastructure, offering bare metal, vms, and containers | 10:29 |
| deadnull | should be fun | 10:29 |
| lucasagomes | deadnull, I don't think so, I believe the support for multitenant network was merged prior to that (newton I think) | 10:30 |
| * lucasagomes checks release notes | 10:30 | |
| lucasagomes | deadnull, https://docs.openstack.org/releasenotes/ironic/newton.html | 10:30 |
| lucasagomes | yeah | 10:30 |
| deadnull | thx lucasagomes ! | 10:30 |
| *** zackf has joined #openstack-ironic | 10:31 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic master: Ensure dying SOL console on conductor death https://review.openstack.org/446571 | 10:32 |
| *** zackf has quit IRC | 10:36 | |
| *** zhurong has quit IRC | 10:40 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic master: Define minimum required API ver for portgroups https://review.openstack.org/449488 | 10:41 |
| *** athomas has quit IRC | 10:50 | |
| *** athomas has joined #openstack-ironic | 10:51 | |
| *** athomas has quit IRC | 10:52 | |
| *** [1]cdearborn has joined #openstack-ironic | 10:54 | |
| *** gcb has quit IRC | 10:56 | |
| *** athomas has joined #openstack-ironic | 10:58 | |
| *** phuongnh has quit IRC | 10:59 | |
| jroll | morning y'all | 11:00 |
| lucasagomes | jroll, morning o/ | 11:01 |
| *** aparnav has quit IRC | 11:06 | |
| *** stendulker has quit IRC | 11:06 | |
| *** hw_wutianwei has quit IRC | 11:09 | |
| *** e0ne has quit IRC | 11:10 | |
| *** e0ne has joined #openstack-ironic | 11:10 | |
| *** dtantsur|afk is now known as dtantsur | 11:18 | |
| *** udesale has joined #openstack-ironic | 11:19 | |
| *** tovin07 is now known as tovin07_at_work | 11:20 | |
| dtantsur | morning ironic | 11:20 |
| *** tovin07_at_work has quit IRC | 11:20 | |
| dtantsur | "a lab infrastructure, offering bare metal, vms, and containers" sounds like a lot of fun indeed :) | 11:21 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/ironic master: Fix API microversion for portgroup tempest tests https://review.openstack.org/449574 | 11:21 |
| *** udesale has quit IRC | 11:21 | |
| openstackgerrit | Derek Higgins proposed openstack/ironic master: Copy and conditionaly add to static lists https://review.openstack.org/449577 | 11:31 |
| *** alexpilotti has quit IRC | 11:40 | |
| *** alexpilotti has joined #openstack-ironic | 11:41 | |
| *** bfournie has quit IRC | 11:41 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/ironic master: Fix API microversion for portgroup tempest tests https://review.openstack.org/449574 | 11:42 |
| *** alexpilotti has quit IRC | 11:45 | |
| *** Serlex has quit IRC | 11:54 | |
| *** udesale has joined #openstack-ironic | 12:01 | |
| *** links has quit IRC | 12:02 | |
| *** links has joined #openstack-ironic | 12:05 | |
| openstackgerrit | Debayan Ray proposed openstack/proliantutils master: [WIP] Introducing Redfish API support https://review.openstack.org/406431 | 12:08 |
| *** alexpilotti has joined #openstack-ironic | 12:13 | |
| *** lucasagomes is now known as lucas-hungry | 12:14 | |
| openstackgerrit | Xavier proposed openstack/ironic master: Shutdown server before change boot order for agent drivers https://review.openstack.org/408298 | 12:15 |
| *** bfournie has joined #openstack-ironic | 12:16 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/ironic master: Add negative functional API tests for portgroups https://review.openstack.org/437535 | 12:18 |
| snecklifter | dtantsur: sorry to bother, just wondering on current state of software RAID support in Ironic | 12:18 |
| snecklifter | dtantsur: I started writing this spec https://review.openstack.org/#/c/327769/ | 12:18 |
| dtantsur | snecklifter, hey! no state for now. there are some foundation bits that we plan to finish first (i.e. deploy steps) | 12:19 |
| snecklifter | dtantsur: ok, thanks, should I abandon ^^^ or try and finish it up? | 12:20 |
| dtantsur | snecklifter, depends on whether you have time to work on it, I guess :) please sync with yolanda | 12:21 |
| snecklifter | dtantsur: ack, thanks | 12:21 |
| *** zackf has joined #openstack-ironic | 12:21 | |
| *** d0ugal has quit IRC | 12:24 | |
| *** dprince has joined #openstack-ironic | 12:25 | |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector master: Use eventlet version of subprocess https://review.openstack.org/449516 | 12:25 |
| *** zackf has quit IRC | 12:26 | |
| *** dprince has quit IRC | 12:26 | |
| *** dprince has joined #openstack-ironic | 12:26 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic master: DNM Test passing server to rpc context https://review.openstack.org/449607 | 12:31 |
| openstackgerrit | Miles Gould proposed openstack/ironic-ui master: Show boot device in Node Details/Configuration https://review.openstack.org/447085 | 12:34 |
| openstackgerrit | Miles Gould proposed openstack/ironic-ui master: Fix mocks that were breaking Jasmine tests https://review.openstack.org/449609 | 12:34 |
| *** racedo has quit IRC | 12:34 | |
| *** mgould|afk is now known as mgould | 12:36 | |
| mgould | hi everyone, happy friday | 12:37 |
| mgould | ppiela, TheJulia: I've fixed ironic-ui's jasmine tests ^^^ | 12:37 |
| *** jaypipes is now known as leakypipes | 12:37 | |
| mgould | I looked into running them in CI but it required more energy and focus than I had yesterday | 12:38 |
| mgould | horizon runs jasmine inside karma inside npm inside tox | 12:38 |
| mgould | and it wasn't clear how much of that I should copy into ironic-ui | 12:38 |
| *** trown|outtypewww is now known as trown | 12:39 | |
| mgould | but hey, at least I can run tests locally now | 12:39 |
| *** udesale has quit IRC | 12:42 | |
| robcresswell | mgould: you can just run karma. The other wrappers are just to prevent installing packages globally. | 12:43 |
| mgould | robcresswell: cool, thanks | 12:45 |
| mgould | looks like ironic-ui already has a CI job which runs `npm test` | 12:45 |
| mgould | but we don't have a test job in node_modules, so it does nothing | 12:46 |
| aarefiev | hey mgould | 12:46 |
| mgould | hi aarefiev | 12:46 |
| *** Nisha_Agarwal has joined #openstack-ironic | 12:46 | |
| aarefiev | dtantsur: hey, inspector's ci is down, please keep an eye on https://review.openstack.org/#/c/449516/ | 12:47 |
| dtantsur | aarefiev, ack, thanks for taking care of it | 12:47 |
| aarefiev | np | 12:47 |
| Nisha_Agarwal | dtantsur, hi | 12:48 |
| dtantsur | o/ | 12:49 |
| Nisha_Agarwal | Whats the process to deprecate a driver | 12:49 |
| Nisha_Agarwal | we would like to deprecate iscsi_ilo | 12:49 |
| Nisha_Agarwal | So wanted to know the process for the same | 12:49 |
| Nisha_Agarwal | dtantsur, ^^^^ | 12:49 |
| *** rbudden has joined #openstack-ironic | 12:50 | |
| dtantsur | Nisha_Agarwal, set "supported = False" on the driver and create a proper release note. btw, what's the reason for deprecating it? | 12:50 |
| Nisha_Agarwal | dtantsur, thanks :) the reason being that all the functionalities which iscsi_ilo supports is already covered by agent_ilo | 12:51 |
| dtantsur | similar to https://github.com/openstack/ironic/blob/master/ironic/drivers/pxe.py#L91 | 12:51 |
| dtantsur | good reason indeed | 12:51 |
| jroll | agent_ilo can do iscsi-based deploys? | 12:52 |
| jroll | how is direct vs iscsi decided there? | 12:52 |
| *** Serlex has joined #openstack-ironic | 12:52 | |
| jroll | Nisha_Agarwal: ^ | 12:53 |
| dtantsur | I assumed we end up with pxe_ilo vs agent_ilo | 12:55 |
| dtantsur | with both only differ in using iscsi vs a direct download. Nisha_Agarwal is this ^^^ right? | 12:55 |
| Nisha_Agarwal | jroll it cannot do iscsi based deploy | 12:55 |
| jroll | oh, we have pxe_ilo and iscsi_ilo? how'd that happen :/ | 12:55 |
| Nisha_Agarwal | jroll, yes | 12:56 |
| dtantsur | jroll, iscsi_ilo supports virtual media. I have to assume (based on what Nisha_Agarwal said) that pxe_ilo now supports it too. | 12:56 |
| jroll | I see | 12:56 |
| Nisha_Agarwal | dtantsur, pxe_ilo is pxebased | 12:56 |
| Nisha_Agarwal | jroll, ^^^ | 12:56 |
| jroll | yeah, I see that in code now | 12:56 |
| Nisha_Agarwal | iscsi_ilo is iscsi based deploy but it uses virtual media | 12:57 |
| vmud213 | dtantsur: with driver composition atleast, pxe-agent and vmedia-agent are the combinations | 12:57 |
| jroll | so pxe_ilo is pxe+iscsi, iscsi_ilo is vmedia+iscsi | 12:57 |
| Nisha_Agarwal | jroll, yes | 12:57 |
| jroll | is vmedia+iscsi not useful? | 12:57 |
| dtantsur | Nisha_Agarwal, then why do we deprecate iscsi_ilo? its features are not covered.. | 12:57 |
| dtantsur | vmud213, so are you folks deprecating the iscsi method at all? it's up to you, but it may turn some people (e.g. tripleo) away from your driver | 12:58 |
| vmud213 | In a way yes.. | 12:58 |
| Nisha_Agarwal | dtantsur, yes we wanted to deprecate the iscsi_ilo completely. But let me put this point across the team | 12:59 |
| * jroll is also sad that IloVirtualMediaAgentDeploy is a thing, understands why now but wonders if we can't move the secure boot support into the management driver | 12:59 | |
| dtantsur | jroll, we should consider that, tbh | 12:59 |
| * dtantsur is confused by the ilo drivers now... | 12:59 | |
| Nisha_Agarwal | dtantsur, why confused | 12:59 |
| dtantsur | Nisha_Agarwal, what is the feature matrix you want to support in the end (both for old and new drivers)? | 13:00 |
| jroll | dtantsur: I guess this shows us why the ilo hardware type doesn't add iscsi support to the deploy interface | 13:00 |
| vmud213 | jroll,dtantsur: it's not yet decided completely | 13:00 |
| dtantsur | jroll, I guess so. It's an unfortunate change, but I guess it's up to the folks.. | 13:00 |
| dtantsur | we just have to communicate that glance+swift or a separate HTTP server is a requirement for iLO drivers now | 13:01 |
| dtantsur | vmud213, ok, so a reasonable first step is to actually decide it :) | 13:01 |
| jroll | dtantsur: ideally vendors would not decide if direct or iscsi is supported, both should work on all hardware | 13:01 |
| vmud213 | :) | 13:01 |
| jroll | dtantsur: (in a future world where classic drivers are gone) | 13:03 |
| dtantsur | jroll, yeah. I'm trying to understand why we even need https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py | 13:03 |
| dtantsur | vmud213, Nisha_Agarwal, what prevents us from having ^^^ in boot interface? | 13:03 |
| jroll | dtantsur: secure boot and UEFI, see https://review.openstack.org/#/c/439404/5/setup.cfg@102 | 13:03 |
| jroll | stendulker's comment there | 13:03 |
| * Nisha_Agarwal would like to discuss it with team n get back on this | 13:03 | |
| dtantsur | jroll, this is all about "boot", right? | 13:03 |
| jroll | dtantsur: probably, yeah | 13:04 |
| dtantsur | so my questions stays: why can't we move it to the BootInterface (potentially expanding it) | 13:04 |
| dtantsur | Nisha_Agarwal, vmud213 ^^^ | 13:04 |
| dtantsur | your decisions would be much easier, if everything was contained in the boot interface.. | 13:04 |
| *** milan has joined #openstack-ironic | 13:04 | |
| jroll | dtantsur: I guess UEFI is kind of about deploy, because bootloader junk | 13:05 |
| * Nisha_Agarwal was a bit away...reading now | 13:05 | |
| dtantsur | jroll, yeah, but it's not driver-specific then | 13:05 |
| * dtantsur is still confused | 13:05 | |
| vsaienk0 | folks please have to merge https://review.openstack.org/#/c/449488/ - is a blocker for stable/mitaka | 13:05 |
| jroll | dtantsur: true, that should be directly in the normal deploy drivers | 13:06 |
| milan | morning Ironic! :) | 13:06 |
| vmud213 | dtantsur: Actually we do some stuff related to secure boot.. | 13:07 |
| dtantsur | vmud213, "boot", right? | 13:07 |
| dtantsur | we have a BootInterface for that | 13:07 |
| dtantsur | vmud213, Nisha_Agarwal, folks, I think we should attempt to clean it up before we create an ilo hardware | 13:07 |
| Nisha_Agarwal | dtantsur, we can do both parallely i guess | 13:07 |
| * vmud213 starts to think | 13:08 | |
| *** bcornec has joined #openstack-ironic | 13:08 | |
| Nisha_Agarwal | we can optimize the code...ut here i have one ques | 13:08 |
| dtantsur | Nisha_Agarwal, yes, but I'd prefer we don't have a separate deploy interface for iLO. I'm fine with extending the BootInterface as needed, if the current features are not enough. | 13:08 |
| jroll | vsaienk0: why does changing it from 1.25 to 1.23 unblock mitaka? or does making it a class variable have an effect elsewhere? | 13:08 |
| jroll | vsaienk0: can you show me a failure and a test patch for this? | 13:08 |
| *** sasha21 has joined #openstack-ironic | 13:08 | |
| Nisha_Agarwal | dtantsur, why not a seperate deploy interface? | 13:09 |
| vsaienk0 | jroll: min_microversion allows to skip those tests where specified API version is not available, for example stable/mitaka | 13:09 |
| Nisha_Agarwal | we need to set the vmedia | 13:09 |
| Nisha_Agarwal | that we do in our deploy interface | 13:09 |
| dtantsur | Nisha_Agarwal, because the deploy method is not different. vmedia is a boot method. | 13:09 |
| vsaienk0 | jroll: I don't know how to test this on CI, since Depends-On in stable branch will not work for master, but tempest uses master always | 13:09 |
| Nisha_Agarwal | dtantsur, deploy also uses vmedia to deploy the iso | 13:09 |
| dtantsur | Nisha_Agarwal, what do you mean by "deploy the ISO"? | 13:10 |
| jroll | vsaienk0: ah right, this is the problem with having the in-tree plugin (/me wonders what happened to the work to fix that) | 13:10 |
| Nisha_Agarwal | means to bring up the ISO on the server | 13:10 |
| jroll | vsaienk0: I see the code in the base class now, will approve | 13:10 |
| jroll | vsaienk0: thanks for the fix <3 | 13:10 |
| vsaienk0 | thanks jroll | 13:11 |
| dtantsur | Nisha_Agarwal, instance images are not ISO IIUC. Deploy is only concerned about flashing instance images on the target disk. | 13:11 |
| Nisha_Agarwal | dtantsur, i am talking about deploy iso | 13:11 |
| dtantsur | Nisha_Agarwal, right, it's boot interface. | 13:11 |
| dtantsur | Nisha_Agarwal, vmud213, looking at https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py, it just adds more hooks to change *boot* parameters. let's make this hook points generic in BootInterface and use them from generic DeployInterface | 13:12 |
| vmud213 | dtantsur: For partition images, we create ISO and attach to virtual media | 13:12 |
| dtantsur | vmud213, could you point me to the code attaching instance image as ISO? | 13:12 |
| jroll | dtantsur: it's the instance kernel/ramdisk, not the whole image | 13:13 |
| jroll | but | 13:13 |
| jroll | that's still a boot thing | 13:13 |
| jroll | (IMHO) | 13:13 |
| dtantsur | right. we have boot stuff in the deploy interface | 13:13 |
| Nisha_Agarwal | dtantsur, ok so to understand what shud a deploy contain | 13:14 |
| Nisha_Agarwal | ? | 13:14 |
| Nisha_Agarwal | i understand why you are saying its boot stuff | 13:14 |
| Nisha_Agarwal | but then what should be part of deploy | 13:14 |
| dtantsur | Nisha_Agarwal, deploy interface should specify the way you put an instance image to the target disk. | 13:14 |
| dtantsur | e.g. iscsi deploy uses an iscsi share exported from IPA | 13:14 |
| dtantsur | while direct deploy works on IPA side and fetches the image from swift/http | 13:15 |
| dtantsur | and ansible deploy (out-of-tree) does it through ansible | 13:15 |
| *** jcoufal has joined #openstack-ironic | 13:15 | |
| dtantsur | but e.g. https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L81-L113 has word "boot" in nearly every line | 13:15 |
| milan | aarefiev, hi, could you please take a look on the filter interface specs? I'd do an update today if not all OK w/ you: https://review.openstack.org/#/c/439862/ | 13:16 |
| vmud213 | dtantsur:https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/boot.py#L357-L360 | 13:16 |
| aarefiev | milan: hey, sure, I'll take a look today | 13:16 |
| milan | aarefiev, thanks! | 13:17 |
| dtantsur | vmud213, this is boot interface, so it's fine | 13:17 |
| jroll | oh, that will be fun to unwind if we switch default boot_option to local, will 'netboot' really mean iso here? | 13:17 |
| vmud213 | dtantsur: Yes, it makes sense to me now | 13:17 |
| * Nisha_Agarwal away for 2 min | 13:17 | |
| vmud213 | jroll: In which context? | 13:19 |
| jroll | vmud213: ignore me, that's some time in the future and I don't want to think about it much right now :) | 13:19 |
| vmud213 | jroll,dtantsur: I got what you are saying.. | 13:20 |
| vmud213 | jroll,dtantsur: I also feel theere is not clear demarkation w.r.t boot and deploy interfaces | 13:21 |
| vmud213 | I guess that is causing the issues.. | 13:22 |
| jroll | vmud213: yes, that's the problem here :) | 13:22 |
| *** jrist has joined #openstack-ironic | 13:22 | |
| dtantsur | vmud213, yes, it's not totally obvious. we're defining it as we go. | 13:22 |
| dtantsur | also ilo is probably the most sophisticated driver we currently have, this is why we discover such issues with you first :) | 13:22 |
| vmud213 | For instance, as part of validation of boot interface we don't have to validate the existence of the image_source | 13:22 |
| vmud213 | and at the same time as part of deploy interface we need not to validate deploy_kernel/deploy_ramdisk or vmedia_iso | 13:23 |
| vmud213 | dtantsur,jroll:What do you think? | 13:23 |
| dtantsur | vmud213, I think you're right | 13:24 |
| vmud213 | dtantsur: Thanks :D | 13:24 |
| dtantsur | I'm looking at this bit now https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L205-L206 and wonder why it has to be here and where it could go., | 13:26 |
| jroll | vmud213: yeah, I think that makes sense | 13:26 |
| lucas-hungry | do you know why I could get: Failed to prepare node a2f7b504-40cd-4360-8f7e-1356f5b3b0b8 for cleaning: No VIFs found for node a2f7b504-40cd-4360-8f7e-1356f5b3b0b8 when attempting to update DHCP BOOT o | 13:27 |
| lucas-hungry | wrong copy&paste | 13:27 |
| *** lucas-hungry is now known as lucasagomes | 13:27 | |
| vmud213 | dtantsur,jroll:https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L358-#L366 | 13:27 |
| jroll | dtantsur: feels like that should be in the base deploy driver as task.node.driver.boot.update_boot_mode(), etc | 13:28 |
| *** baoli has joined #openstack-ironic | 13:28 | |
| dtantsur | jroll, I even think it can go to prepare_instance | 13:28 |
| dtantsur | vmud213, oh fun | 13:29 |
| jroll | dtantsur: yeah, seems like either location would work | 13:30 |
| dtantsur | so we may still need image_source. but deploy interfaces should not need deploy_kernel/deploy_ramdisk/deploy_iso | 13:30 |
| *** gcb has joined #openstack-ironic | 13:31 | |
| vmud213 | dtantsur: Because user may be interested in other inband operations in which case it should still be fine with boot interface.. | 13:32 |
| vmud213 | i mean it should not raise the exception | 13:32 |
| vmud213 | for boot interface | 13:33 |
| *** pester has joined #openstack-ironic | 13:33 | |
| dtantsur | yeah, it may have to go to prepare_instance instead.. | 13:33 |
| dtantsur | vmud213, Nisha_Agarwal, ok, I need to think about the ways to handle it, and I guess you folks as well. but I'd really want us to stop confusion between boot and deploy interfaces (not only in ilo drivers, but everywhere). | 13:34 |
| * dtantsur -> food | 13:34 | |
| Nisha_Agarwal | dtantsur, sure | 13:34 |
| Nisha_Agarwal | dtantsur, BTW i had one ques on supported = False | 13:34 |
| dtantsur | sure | 13:35 |
| vmud213 | dtantsur,jroll: Thanks for the insights | 13:35 |
| jroll | dtantsur: yeah, seems we might need a spec put together to finally sort all of this out | 13:35 |
| *** lucasagomes is now known as lucas-brb | 13:35 | |
| *** fxpester has quit IRC | 13:36 | |
| Nisha_Agarwal | dtantsur, say we set it in this relase, then next release do we need to remove the code from ironci tree | 13:36 |
| Nisha_Agarwal | dtantsur, is that the next step we need to follow? | 13:36 |
| Nisha_Agarwal | after setting the variale to false | 13:37 |
| jroll | Nisha_Agarwal: yes, see the deprecation process here, we follow the same: https://governance.openstack.org/tc/reference/tags/assert_follows-standard-deprecation.html | 13:37 |
| dtantsur | Nisha_Agarwal, this is the plan | 13:37 |
| jroll | a release boundary and minimum of three months | 13:37 |
| jroll | it can be longer if you like | 13:37 |
| Nisha_Agarwal | dtantsur, jroll thanks | 13:37 |
| jroll | "For significant features, it is recommended that the deprecated feature appears at least in the next two stable release branches." | 13:37 |
| Nisha_Agarwal | jroll, sure. we would discuss all this internally in the team and get back onto this | 13:39 |
| Nisha_Agarwal | do we need to send out it in ML also? | 13:39 |
| dtantsur | Nisha_Agarwal, it won't hurt for sure. driver removal is a big thing. | 13:39 |
| Nisha_Agarwal | dtantsur, ok. I would summarize and send it in ML also after discussing with team internally here | 13:40 |
| jroll | Nisha_Agarwal: yes, we should send it on the ML. but before email I would like to discuss it with the ironic team, because other drivers don't cover these features | 13:40 |
| Nisha_Agarwal | jroll, sure | 13:40 |
| Nisha_Agarwal | jroll, dtantsur we know the consumers for agent_ilo and pxe_ilo atleast. We dont have anyinsight on who would be using the iscsi_ilo.... | 13:41 |
| *** causten has joined #openstack-ironic | 13:42 | |
| jroll | Nisha_Agarwal: right, which is why we have these processes. there's no way to know who is using what features | 13:43 |
| Nisha_Agarwal | jroll, yes .... | 13:43 |
| *** ElCoyote_ has joined #openstack-ironic | 13:43 | |
| *** jkilpatr has quit IRC | 13:44 | |
| *** jcoufal_ has joined #openstack-ironic | 13:44 | |
| *** d0ugal has joined #openstack-ironic | 13:45 | |
| *** jcoufal has quit IRC | 13:46 | |
| *** dansmith is now known as superdan | 13:49 | |
| *** mtanino has joined #openstack-ironic | 13:49 | |
| openstackgerrit | Duan Jiong proposed openstack/ironic-inspector master: Fix some reST field lists in docstrings https://review.openstack.org/449629 | 13:50 |
| Nisha_Agarwal | jroll, one more ques....if we deprecate the driver this release can we remove the CI support for the driver next release? | 13:53 |
| *** links has quit IRC | 13:53 | |
| Nisha_Agarwal | jroll, dtantsur or CI can be removed only when we remove the code from the tree? | 13:53 |
| *** stendulker has joined #openstack-ironic | 13:53 | |
| vsaienk0 | jlvillal: could you please add to your review queue https://review.openstack.org/#/c/440719 | 13:53 |
| jroll | Nisha_Agarwal: good question, I think I would ask dtantsur. I'd prefer to remove it when we remove the code, I think | 13:54 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic master: DNM Test passing server to rpc context https://review.openstack.org/449607 | 13:54 |
| Nisha_Agarwal | jroll, ok. | 13:54 |
| Nisha_Agarwal | dtantsur, whats ur take | 13:54 |
| * dtantsur agrees | 13:54 | |
| Nisha_Agarwal | dtantsur, ok | 13:54 |
| jroll | Nisha_Agarwal: that said, if we deprecated now, we could remove the code on the first day of the Q cycle | 13:55 |
| Nisha_Agarwal | jroll, ok :) | 13:55 |
| Nisha_Agarwal | jroll, we are still discussing on it. But we wanted to know the process | 13:56 |
| Nisha_Agarwal | so we will come back on it after discussion | 13:56 |
| jroll | sure | 13:56 |
| *** alexpilotti has quit IRC | 13:58 | |
| *** alexpilotti has joined #openstack-ironic | 13:59 | |
| stendulker | dtantsur, jroll: Hi | 13:59 |
| jroll | hey stendulker | 14:00 |
| stendulker | dtantsur, jroll: I saw -2 on iLO Hardware type patch https://review.openstack.org/#/c/439404 | 14:00 |
| stendulker | Do you want to move the code related to boot mode settings to boot interface? | 14:01 |
| jroll | stendulker: yes | 14:01 |
| *** lucas-brb is now known as lucasagomes | 14:01 | |
| stendulker | For vMedia based boot, it should be ok. But we would need new boot interface for PXE | 14:01 |
| stendulker | And such a change would impact classic drivers as well | 14:02 |
| jroll | stendulker: please see the conversation starting here, btw: http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-03-24.log.html#t2017-03-24T12:48:46 | 14:02 |
| jroll | stendulker: what's the problem with pxe? | 14:02 |
| stendulker | I went through that | 14:02 |
| jroll | cool | 14:02 |
| stendulker | All boot mode related stuff we do in the deploy interface | 14:03 |
| *** alexpilotti has quit IRC | 14:03 | |
| stendulker | https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L366 | 14:03 |
| jroll | from what I can tell, that's all virtualmedia based | 14:03 |
| stendulker | This in case of pxe_ilo classic driver | 14:03 |
| stendulker | There are 3 iLO drivers | 14:04 |
| jroll | right, right | 14:04 |
| * jroll reads code | 14:04 | |
| stendulker | 2 are vmedia (iscsi and agent) and 1 is pxe (iscsi) | 14:04 |
| stendulker | All of them support UEFI secure boot mode, that needs little special handling in prepare and tear_down methods | 14:05 |
| stendulker | This is handled in repsctive drivers deploy interfaces | 14:05 |
| jroll | so if I'm reading this right, the pxe deploy driver still talks to the ilo interface? | 14:05 |
| stendulker | yes | 14:06 |
| jroll | both in _disable_secure_boot() and update_boot_mode() | 14:06 |
| jroll | sigh, that seems odd | 14:06 |
| stendulker | it uses iLO for power and management | 14:06 |
| stendulker | its uses PXEBoot interface but has its own deploy | 14:06 |
| jroll | right | 14:06 |
| stendulker | and thsi deploy interface takes care of boot modes | 14:06 |
| * jroll wonders what the use case for avoiding virtualmedia is | 14:07 | |
| stendulker | So if we were to refactor, this would impact classic drivers in a big way | 14:07 |
| stendulker | especially pxe_ilo | 14:07 |
| dtantsur | stendulker, "new boot interface for PXE" I kind of anticipate it as well. It's still much better than having deploy interfaces bound to boot methods IMO | 14:07 |
| stendulker | I think we may be able to manage vmedia drivers but pxe_ilo would need new BootInterface derived from PXEBoot | 14:07 |
| jroll | yeah, I think I'd prefer a new boot interface for PXE+iLO, over an ilo deploy interface | 14:08 |
| stendulker | its doable, but only little bit more efforts | 14:08 |
| jroll | still would love to hear the use case for it, too, but that's a different subject :) | 14:08 |
| stendulker | use case for? | 14:09 |
| dtantsur | jroll, glance not backed by swift? | 14:10 |
| jroll | stendulker: for using pxe boot instead of virtualmedia | 14:10 |
| stendulker | To summarize: All the boot mode related things in deploy.prepare() should move to prepare_ramdisk() | 14:10 |
| jroll | dtantsur: not for iscsi, for pxe :) | 14:10 |
| dtantsur | jroll, virtual media requires swift temp urls, no? | 14:10 |
| stendulker | jroll: Also, vMedia is a licensed thingy so pxe helps if one does not have that | 14:11 |
| jroll | dtantsur: ah, right, or a web server | 14:11 |
| stendulker | + pxe is simpler to setup | 14:11 |
| jroll | stendulker: so it's a different license for vmedia than for secure boot, power management, etc? | 14:11 |
| stendulker | I think only for vmedia its separate... | 14:12 |
| jroll | nod, that makes sense | 14:12 |
| jroll | okay, thanks | 14:12 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic-specs master: API Evolution - ETAG identifiers https://review.openstack.org/381991 | 14:12 |
| openstackgerrit | Merged openstack/ironic-inspector master: Mention state machine diagram generation in contrib guide https://review.openstack.org/447494 | 14:13 |
| stendulker | To summarize: All the boot mode related things in deploy.prepare() should move to prepare_ramdisk() and boot mode related things in deploy.tear_down() would move to boot.clean_up_instance() | 14:14 |
| dtantsur | stendulker, s/prepare_ramdisk/prepare_instance/ I think. otherwise correct. | 14:14 |
| stendulker | Yes, thats right | 14:15 |
| stendulker | jroll: No, | 14:15 |
| stendulker | it should be prepare_ramdisk() | 14:15 |
| * jroll didn't say that, and isn't knowledgable enough to know | 14:16 | |
| stendulker | as we do these things before booting up the deploy ramdisk | 14:16 |
| *** baha has joined #openstack-ironic | 14:16 | |
| dtantsur | ah, ok, sorry | 14:17 |
| stendulker | jroll: I can understand, I too get confused with the method names | 14:17 |
| *** racedo has joined #openstack-ironic | 14:17 | |
| jroll | stendulker: I just haven't read the code recently :) | 14:17 |
| stendulker | jroll: sorry.. | 14:17 |
| jroll | stendulker: it's no problem | 14:18 |
| stendulker | dtantsur, jroll : Then I will put a separate patch for code refactor and then rebase the current patch on top of it (them) | 14:18 |
| jroll | stendulker: sounds good, thank you | 14:19 |
| dtantsur | yep. thanks! | 14:19 |
| stendulker | jroll, dtantsur: Thank you for helping me | 14:19 |
| jroll | you're welcome :) | 14:19 |
| stendulker | jroll, dtantsur : Another dumb question | 14:20 |
| *** alexpilotti has joined #openstack-ironic | 14:20 | |
| stendulker | If the instance image size is too large, like say Windows image runnning into few GBs | 14:20 |
| *** tuan_luong has joined #openstack-ironic | 14:21 | |
| stendulker | Would it be provisionable using agent based drivers as it relies on memory size as the max size for provisioning | 14:21 |
| jroll | if the image is raw, we stream it to disk | 14:21 |
| jroll | else you need enough memory, yes | 14:21 |
| *** tuanla_ has joined #openstack-ironic | 14:21 | |
| openstackgerrit | vinay kumar muddu proposed openstack/ironic master: Fixes boot and deploy interface validation for iLO https://review.openstack.org/445588 | 14:21 |
| *** amoralej is now known as amoralej|lunch | 14:21 | |
| stendulker | how do one enable streaming? | 14:21 |
| jroll | raw means more bandwidth but at least it can provision | 14:21 |
| jroll | I think it just works | 14:22 |
| * jroll double checks | 14:22 | |
| stendulker | so is there a different method to create a raw image? | 14:22 |
| jroll | you just don't compress it as a qcow or whatever | 14:23 |
| jroll | easy mode: have an image on a disk, and dd if=/dev/sda1 of=my-raw-image | 14:23 |
| *** bnemec is now known as beekneemech | 14:23 | |
| stendulker | ok... oh that simple to create raw image | 14:23 |
| stendulker | jroll: Thank you :) | 14:24 |
| jroll | yeah, it's just the raw bits. of course you might need to clear cloud-init metadata or something but it's close | 14:24 |
| * jroll still looking for the stream thing | 14:24 | |
| *** Nisha_Agarwal has quit IRC | 14:24 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 14:24 | |
| stendulker | But rest of the process of adding config drive should remain same for raw image as well, I suppose | 14:25 |
| jroll | stendulker: CONF.agent.stream_raw_images, it's True by default | 14:25 |
| jroll | yeah, that all still works | 14:25 |
| stendulker | jroll: ok. Thank you | 14:25 |
| jroll | welcome! | 14:25 |
| *** chlong has joined #openstack-ironic | 14:25 | |
| stendulker | Good day all !! | 14:26 |
| jroll | \o | 14:26 |
| *** ralonsoh_ has joined #openstack-ironic | 14:31 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/sushy master: Sushy to adhere to the resource identifier portion of the spec https://review.openstack.org/448539 | 14:32 |
| *** vmud213 has quit IRC | 14:33 | |
| lucasagomes | dtantsur, ^ renamed to identities | 14:33 |
| openstackgerrit | Derek Higgins proposed openstack/ironic master: Copy and append to static lists https://review.openstack.org/449577 | 14:34 |
| dtantsur | lucasagomes, thanks! | 14:34 |
| lucasagomes | btw, any chance someone else can take a look at https://review.openstack.org/#/c/445478/ ? It has 2+2 already | 14:34 |
| *** ralonsoh has quit IRC | 14:34 | |
| dtantsur | jroll, maybe ^^^? | 14:34 |
| *** amotoki has quit IRC | 14:35 | |
| dtantsur | jroll, JayF, TheJulia, FYI added README to https://github.com/dtantsur/ci-report | 14:35 |
| dtantsur | in case somebody wants to run it too | 14:35 |
| *** Nisha_ has joined #openstack-ironic | 14:36 | |
| *** Nisha_Agarwal has quit IRC | 14:36 | |
| NobodyCam | Good Morning Ironic'ers and (ofc)..... | 14:36 |
| NobodyCam | TGIF | 14:36 |
| NobodyCam | :) | 14:36 |
| dtantsur | morning NobodyCam | 14:37 |
| NobodyCam | morning dtantsur :) | 14:37 |
| *** alex_xu has quit IRC | 14:37 | |
| *** alex_xu has joined #openstack-ironic | 14:38 | |
| *** udesale has joined #openstack-ironic | 14:38 | |
| jroll | lucasagomes: starred it, I'll try to get to it today | 14:39 |
| *** causten has quit IRC | 14:40 | |
| *** causten has joined #openstack-ironic | 14:41 | |
| *** rama_y_ has joined #openstack-ironic | 14:43 | |
| *** amotoki has joined #openstack-ironic | 14:45 | |
| *** causten has quit IRC | 14:46 | |
| *** causten has joined #openstack-ironic | 14:46 | |
| *** amotoki has quit IRC | 14:47 | |
| *** fragatina has quit IRC | 14:47 | |
| lucasagomes | jroll, thanks! No rush | 14:50 |
| *** causten has quit IRC | 14:52 | |
| *** vills has joined #openstack-ironic | 14:52 | |
| openstackgerrit | Merged openstack/ironic master: Define minimum required API ver for portgroups https://review.openstack.org/449488 | 14:53 |
| *** fragatina has joined #openstack-ironic | 14:53 | |
| *** causten has joined #openstack-ironic | 14:53 | |
| *** alexpilo_ has joined #openstack-ironic | 14:57 | |
| *** jkilpatr has joined #openstack-ironic | 14:58 | |
| *** causten has quit IRC | 14:58 | |
| *** mjura has quit IRC | 14:58 | |
| *** alexpilotti has quit IRC | 14:58 | |
| jcook | dtantsur Is anything in ironic-inspector a priority for Pike? I don't see any here https://specs.openstack.org/openstack/ironic-specs/priorities/pike-priorities.html or a priority spec in ironic-inspector-specs | 14:59 |
| *** tuanla_ has quit IRC | 14:59 | |
| *** tuan_luong has quit IRC | 14:59 | |
| *** tuan_luong has joined #openstack-ironic | 14:59 | |
| *** tuanla_ has joined #openstack-ironic | 14:59 | |
| dtantsur | jcook, we did not have a priority spec, as our priority list is pretty short | 14:59 |
| jcook | dtantsur so this is accurate for inspector: https://etherpad.openstack.org/p/ironic-pike-ptg-planning ? | 15:00 |
| *** tuanla_ has quit IRC | 15:00 | |
| *** tuan_luong has quit IRC | 15:00 | |
| dtantsur | jcook, yes | 15:00 |
| jcook | dtantsur maybe an odd question, but would you say all ironic proper priorities are > ironic inspector priorities ? | 15:01 |
| dtantsur | jcook, mmm, an odd question indeed :) | 15:01 |
| dtantsur | at least openstack-wide priorities like wsgi are on the same level | 15:01 |
| jcook | yeah, so it's clear what's most important in Ironic but not how Ironic Inspector priorities compare relatively | 15:02 |
| dtantsur | also for people more involved in inspector, its priority are probably bigger | 15:02 |
| jcook | makes sense | 15:02 |
| *** alexpilo_ has quit IRC | 15:02 | |
| *** causten has joined #openstack-ironic | 15:03 | |
| jcook | thanks | 15:03 |
| dtantsur | np | 15:04 |
| *** vills has quit IRC | 15:06 | |
| *** alexpilotti has joined #openstack-ironic | 15:06 | |
| jcook | dtantsur I'm assuming inspector ha is essential. Is that accurate? | 15:11 |
| dtantsur | quite so | 15:11 |
| * dtantsur is in a meeting, sorry | 15:11 | |
| jcook | Also, would you say inspector pxe item is essential, high, or optional? | 15:11 |
| jcook | dtantsur no worries, appreciate you helping me understand priorities | 15:11 |
| openstackgerrit | Merged openstack/ironic master: Fix docstrings for creating methods in baremetal api tests https://review.openstack.org/447565 | 15:13 |
| *** mnaser has left #openstack-ironic | 15:14 | |
| *** vills has joined #openstack-ironic | 15:15 | |
| *** vikrant has quit IRC | 15:16 | |
| rama_y_ | Hi dtantsur, milan: this is regarding https://review.openstack.org/#/c/406790/ | 15:17 |
| rama_y_ | dtantsur, milan: my original proposal was to collect under a separate key, not under 'inventory' | 15:18 |
| *** stendulker has quit IRC | 15:19 | |
| *** rpioso has joined #openstack-ironic | 15:20 | |
| *** tuanla_ has joined #openstack-ironic | 15:21 | |
| *** tuan_luong has joined #openstack-ironic | 15:21 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic master: Ensure dying SOL console on conductor death https://review.openstack.org/446571 | 15:22 |
| milan | rama_y_ yeah, sorry about that, should be separate, you were correct the first time. But also, this has to be implemented as a custom (out of tree) HardwareManager | 15:22 |
| rama_y_ | Hi milan: thanks. This info is optional collector and it doesn't exactly fit the custom h/w manager | 15:24 |
| rama_y_ | milan: from my understanding, I think the main concern is not to modify 'inventory' | 15:24 |
| milan | rama_y_ the issue is each vendor may have different bios fields | 15:25 |
| milan | and potentially different processing | 15:25 |
| rama_y_ | milan: from my understanding, fields are either available or not available | 15:26 |
| openstackgerrit | Merged openstack/ironic-inspector-specs master: Multiple PXE filtering backends https://review.openstack.org/439862 | 15:26 |
| rama_y_ | fields do not change by vendor | 15:26 |
| milan | rama_y_ can you speak for all the vendors? | 15:26 |
| rama_y_ | milan: no I cannot :) | 15:26 |
| milan | ;) | 15:26 |
| aarefiev | imo we could put some common info in inventory, but I'd like to see it's structure predictable | 15:27 |
| *** udesale has quit IRC | 15:27 | |
| aarefiev | milan: merged \o/ | 15:27 |
| *** Nisha_ has quit IRC | 15:27 | |
| *** Nisha_ has joined #openstack-ironic | 15:27 | |
| milan | aarefiev, splendid! :D ty! | 15:27 |
| aarefiev | milan: btw CI is down https://review.openstack.org/#/c/449516/ | 15:28 |
| rama_y_ | aarefiev, milan: I think the main concern is not to put in the inventory and it makes sense to me. That is why putting it under a 'dmi' key is the solution for this optional collector | 15:28 |
| *** baha has quit IRC | 15:28 | |
| milan | aarefiev, hmmm, me looks | 15:29 |
| aarefiev | we need to document this to avoid questions in future | 15:29 |
| milan | rama_y_, OK, so given the fact the dmidecode tool is used here, the structure will be the same among vendors | 15:30 |
| milan | so yeah, maybe it can be generic after all | 15:30 |
| *** jaosorior has quit IRC | 15:30 | |
| milan | just all the fields may be optional | 15:30 |
| rama_y_ | milan: yes | 15:30 |
| milan | depending on the vendor | 15:30 |
| *** Nisha_ has quit IRC | 15:30 | |
| *** Nisha_ has joined #openstack-ironic | 15:31 | |
| pas-ha | dtantsur: as the PTL, could you nag the stable requirements cores to merge this backport? please... :) https://review.openstack.org/#/c/440368/ | 15:31 |
| rama_y_ | milan: yes; | 15:31 |
| dtantsur | pas-ha, actually anyone can nag them :) | 15:31 |
| dtantsur | pas-ha, I'm worried about CI failure on Newton. we cannot merge mitaka backport without merging newton one | 15:32 |
| pas-ha | I tried, no response in IRC (only bots are in #openstack-requirements..) | 15:32 |
| rama_y_ | milan, aarefiev: are you ok to have this info under 'dmi' key? | 15:33 |
| *** athomas has quit IRC | 15:33 | |
| pas-ha | NEwton requirements are completely broken due to pbr thing | 15:33 |
| pas-ha | is that really the process of gradual master->master-1->master-2... merge?... | 15:33 |
| dtantsur | pas-ha, not necessary gradual, but we cannot accept merging mitaka and NOT merging newton before or quickly after | 15:34 |
| milan | rama_y_ I'm fine | 15:34 |
| rama_y_ | milan: thanks. | 15:34 |
| milan | rama_y_, no prob! | 15:35 |
| *** jkilpatr has quit IRC | 15:35 | |
| rama_y_ | dtantsur, aarefiev, are you ok to add the info under the 'dmi' key? | 15:37 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/bifrost master: Enforce upper constraints on all pip installs https://review.openstack.org/449689 | 15:38 |
| aarefiev | rama_y_: I'm fine | 15:38 |
| dtantsur | rama_y_, fine with me (I was not following the discussion above though) | 15:38 |
| jcook | dtantsur Would you say "inspector needs to update PXE enabled" is essential, high, or optional? | 15:39 |
| rama_y_ | dtantsur, thanks, my first proposal was to add under a separate key; so, I will change the spec to put the dmi data under 'dmi' key | 15:40 |
| dtantsur | jcook, high(ish). not essential for sure | 15:40 |
| *** vills has quit IRC | 15:40 | |
| dtantsur | rama_y_, ack | 15:40 |
| jcook | dtantsur right on, thanks! | 15:40 |
| rama_y_ | dtansur, that was the suggestion in the spec by you; will modify accordingly. | 15:40 |
| dtantsur | thanks | 15:41 |
| *** bcornec has quit IRC | 15:41 | |
| rama_y_ | dtansur, aarefiev, milan: thanks! | 15:41 |
| *** amarao has quit IRC | 15:52 | |
| *** d0ugal has quit IRC | 15:52 | |
| *** amoralej|lunch is now known as amoralej | 15:52 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic stable/mitaka: Pin version of virtualbmc in devstack plugin https://review.openstack.org/440288 | 15:54 |
| *** amotoki has joined #openstack-ironic | 15:56 | |
| *** vishwanathj has quit IRC | 15:58 | |
| *** vishwanathj has joined #openstack-ironic | 15:58 | |
| *** krtaylor has joined #openstack-ironic | 15:59 | |
| *** pcaruana has quit IRC | 16:03 | |
| *** udesale has joined #openstack-ironic | 16:04 | |
| *** Syed__ has joined #openstack-ironic | 16:07 | |
| *** udesale has quit IRC | 16:09 | |
| *** udesale has joined #openstack-ironic | 16:09 | |
| *** trown is now known as trown|lunch | 16:10 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/ironic master: Add functional api tests for node resource class https://review.openstack.org/437963 | 16:10 |
| *** e0ne has quit IRC | 16:11 | |
| *** d0ugal has joined #openstack-ironic | 16:14 | |
| *** d0ugal has quit IRC | 16:14 | |
| *** d0ugal has joined #openstack-ironic | 16:14 | |
| *** Goneri has quit IRC | 16:15 | |
| *** joanna_mac has joined #openstack-ironic | 16:21 | |
| joanna_mac | morning! :) | 16:22 |
| openstackgerrit | Miles Gould proposed openstack/ironic-ui master: Show boot device in Node Details/Configuration https://review.openstack.org/447085 | 16:22 |
| mgould | morning joanna_mac | 16:22 |
| *** d0ugal has quit IRC | 16:22 | |
| alezil | milan: could you please add this "https://review.openstack.org/#/c/396406/" to your review list. | 16:27 |
| milan | alezil, it's in my list but I've been too lazy to review O:-) | 16:29 |
| * milan reviews | 16:30 | |
| alezil | milan: :( | 16:30 |
| alezil | milan: thanks :) | 16:30 |
| milan | ;) | 16:30 |
| dtantsur | folks knowing about networking (vsaienk0?), do we need to fail if this list is empty? https://github.com/openstack/ironic/blob/c9397e1699537d21b94a6e2a6da2db89ac37866f/ironic/common/neutron.py#L214 | 16:30 |
| joanna_mac | galyna1: thanks for the suggestion in my retry spec :) | 16:31 |
| *** kaifeng has joined #openstack-ironic | 16:33 | |
| vsaienk0 | dtantsur: I think we should, otherwise deployment will succeed | 16:37 |
| vsaienk0 | s/will/will not/ | 16:37 |
| aNuposic | Hi alezil were you seeing apache2 error yesterday when you said gate were failing for you? If you have that link handy can you please paste that? | 16:41 |
| alezil | aNuposic: it was an inspector gate failure. aarefiev: had the fix for it "https://bugs.launchpad.net/ironic-inspector/+bug/1675744" | 16:44 |
| openstack | Launchpad bug 1675744 in Ironic Inspector "Tempest jobs fail to clean up iptables chain" [Critical,In progress] - Assigned to Anton Arefiev (aarefiev) | 16:44 |
| *** fragatina has quit IRC | 16:46 | |
| *** aarefiev is now known as aarefiev_afk | 16:49 | |
| aNuposic | alezil, I see its a different one, never mind. My devstack setup is failing due to http://paste.openstack.org/show/604067/ but seems it is something different | 16:49 |
| aNuposic | need to check the setup | 16:49 |
| alezil | aNuposic: this was the error console.log of jobs were prompting. | 16:54 |
| *** kromanenko has quit IRC | 16:54 | |
| dtantsur | vsaienk0, ok, I'll file a bug | 16:55 |
| *** Serlex has quit IRC | 16:56 | |
| dtantsur | vsaienk0, I think it cases a confusing message later: Failed to prepare node a2f7b504-40cd-4360-8f7e-1356f5b3b0b8 for cleaning: No VIFs found for node a2f7b504-40cd-4360-8f7e-1356f5b3b0b8 when attempting to update DHCP BOOT options. | 16:56 |
| Nisha_ | milan, hi | 16:56 |
| vsaienk0 | dtantsur: thanks, I can fix that if you wish :) | 16:56 |
| dtantsur | yes please :) | 16:56 |
| *** e0ne has joined #openstack-ironic | 16:56 | |
| *** racedo has quit IRC | 16:57 | |
| Nisha_ | dtantsur, milan has a comment https://review.openstack.org/#/c/305864/10 with respect to inspector's firewall. Could you help to answer? | 16:57 |
| soliosg | lucasagomes: regarding this comment https://review.openstack.org/#/c/448196/3//COMMIT_MSG@20 | 16:58 |
| dtantsur | vsaienk0, https://bugs.launchpad.net/ironic/+bug/1675857 | 16:58 |
| openstack | Launchpad bug 1675857 in Ironic "Neutron add_ports_to_network should validate if any ports are present in Ironic" [Medium,Triaged] | 16:58 |
| lucasagomes | soliosg, hi there | 16:58 |
| soliosg | lucasagomes: if you work on a patch that depends on other three patches in the same project, assume you create a commit dependency chain by cherry-picking such patches and apply your changes on top of them. | 16:58 |
| dtantsur | milan, mind explaining your concern to Nisha_ please? | 16:59 |
| soliosg | lucasagomes: if these three patches are constantly updated, how do you handle such rebases? | 16:59 |
| aNuposic | alezil, so are you saying it can be the same reason why yours was failing? | 16:59 |
| soliosg | lucasagomes: btw, it's good to know that 'Depends-On' should only be used for cross-project dependencies | 16:59 |
| *** makowals has quit IRC | 17:00 | |
| vsaienk0 | dtantsur: thanks, I will prepare patch soon | 17:00 |
| lucasagomes | soliosg, yeah, you can checkout from the patch you want to depend on and code yours on top of it | 17:00 |
| dtantsur | thanks! | 17:00 |
| lucasagomes | soliosg, you don't need to keep on cherry picking | 17:00 |
| lucasagomes | the problem when you don't actually have a chain but instead a lot of loose patches all around | 17:00 |
| lucasagomes | that's a problem... | 17:01 |
| dtantsur | Nisha_, I think his comment boils down to s/update the firewall/whitelist the node on the PXE firewall/ in the spec text, but I'll leave it up to him for comment (I have to run soon anyway) | 17:01 |
| alezil | aNuposic: I am not sure, yesterday while I was looking into it saw a couple of reasons for the same failure. | 17:02 |
| Nisha_ | dtantsur, ok. I am not sure if thats how inspector works because of my limited experience with inspector | 17:03 |
| soliosg | lucasagomes: thanks | 17:03 |
| *** Serlex has joined #openstack-ironic | 17:03 | |
| lucasagomes | np | 17:03 |
| *** yogi has quit IRC | 17:03 | |
| aNuposic | alezil, ok let me ask other folks if they saw anything like this | 17:05 |
| *** udesale has quit IRC | 17:06 | |
| aNuposic | Hi all, has anyone seen devstack setup failing due to unable to connect to 6385 port? These are the logs http://paste.openstack.org/show/604068/ | 17:07 |
| *** joanna_mac has quit IRC | 17:07 | |
| dtantsur | folks, jroll, anyone. I'm going on my 1-week-long PTO really soon. Anything you need from me before that? | 17:08 |
| milan | dtantsur, Nisha_, /me reads scrollback | 17:08 |
| Nisha_ | dtantsur, happy vacations | 17:09 |
| dtantsur | thanks Nisha_ | 17:09 |
| Nisha_ | milan, thanks | 17:09 |
| jroll | dtantsur: would you be opposed to a release next week? (note: I haven't looked at release notes yet) | 17:10 |
| *** pester has quit IRC | 17:10 | |
| jroll | or should I just wait :) | 17:10 |
| jroll | there's a couple features it seems, nothing major | 17:10 |
| dtantsur | jroll, I was definitely planning on a release around M1, we can do it earlier though. lemme check the release notes | 17:10 |
| jroll | https://docs.openstack.org/releasenotes/ironic/unreleased.html | 17:10 |
| jroll | that periodic task bug seems nice to fix | 17:11 |
| jroll | and the galera thing | 17:11 |
| dtantsur | jroll, yes, nice calm release before we start landing serious stuff. go for it. | 17:11 |
| jroll | dtantsur: cool, adding to my list now. will check clients and such too | 17:12 |
| milan | Nisha_, if we don't update firewall to block a node in the inspector, pxe booting w/ nova/ironic might interfere (no matter we set inspection virtual media) | 17:12 |
| aNuposic | Hi jlvillal, are you around? | 17:12 |
| jroll | dtantsur: have a good holiday :) | 17:12 |
| dtantsur | jroll, https://docs.openstack.org/releasenotes/python-ironicclient/unreleased.html may use a release | 17:12 |
| milan | dtantsur, enjoy PTO! :) | 17:12 |
| dtantsur | jroll, but probably after we land the remaining driver-comp patches | 17:12 |
| jroll | dtantsur: yeah, that was my thought | 17:13 |
| dtantsur | ok, then I guess only ironic | 17:13 |
| dtantsur | thanks milan | 17:13 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic-lib stable/mitaka: DNM test the virtualbmc from g-r fix https://review.openstack.org/440562 | 17:13 |
| jroll | well, hopefully we merge those too :D | 17:13 |
| jroll | s/too/soon | 17:13 |
| openstackgerrit | Merged openstack/ironic-inspector master: Use eventlet version of subprocess https://review.openstack.org/449516 | 17:14 |
| dtantsur | if they can merged - then ironicclient too | 17:14 |
| jlvillal | aNuposic, Yes.... | 17:14 |
| aNuposic | jlvillal, will update the patch today by deprecating 'temp_url_endpoint_type' wanted to know your opinion basically on deprecating that option because that option is related to glance | 17:14 |
| jlvillal | aNuposic, link? | 17:15 |
| jlvillal | I haven't looked into it, but I think vdrok suggested it. Usually he has good ideas :) | 17:15 |
| aNuposic | jlvillal, https://review.openstack.org/#/c/407639/ | 17:16 |
| jlvillal | aNuposic, So do you have reasons for and/or against doing that? | 17:16 |
| vdrok | hello everyone :) | 17:16 |
| jlvillal | Hi vdrok :) | 17:17 |
| *** baha has joined #openstack-ironic | 17:17 | |
| *** d0ugal has joined #openstack-ironic | 17:17 | |
| *** makowals has joined #openstack-ironic | 17:17 | |
| *** ralonsoh_ has quit IRC | 17:17 | |
| aNuposic | jlvillal, not really I agree we can deprecate just wanted an opinion that day so included you, will update that today :) | 17:18 |
| vdrok | jlvillal: the main reason is - there is no point to have two separate options that say "we use radosgw" | 17:18 |
| jlvillal | aNuposic, Okay. I'm still looking at the code | 17:18 |
| aNuposic | i am testing the patch after deprecating the option jlvillal vdrok | 17:18 |
| aNuposic | will upload the new patch after that :) | 17:18 |
| jlvillal | vdrok, That makes sense to me. Make it easier for operators | 17:19 |
| *** joanna_mac has joined #openstack-ironic | 17:19 | |
| *** racedo has joined #openstack-ironic | 17:20 | |
| jlvillal | aNuposic, Yeah, that makes sense to me. Looking at the code. I doubt people will run both swift and radosgw at the same time. One for configdrive and one for temp_url | 17:20 |
| jlvillal | vdrok, aNuposic: I guess neither of you think that deployers will be using swift for one and radosgw for another. Correct? | 17:22 |
| *** dtantsur is now known as dtantsur|pto | 17:22 | |
| dtantsur|pto | o/ | 17:22 |
| vdrok | jlvillal: exactly, there is no point in that | 17:22 |
| jlvillal | dtantsur|pto, Enjoy that PTO! :) | 17:22 |
| aNuposic | jlvillal, yes, first I had a doubt glance is using radosgw with keystone but I was wrong it is using the same radosgw authentication that will be used for config drive | 17:22 |
| dtantsur|pto | thanks jlvillal | 17:22 |
| aNuposic | vdrok, jlvillal I agree | 17:23 |
| vdrok | dtantsur|pto: have some good rest! :) | 17:23 |
| jlvillal | vdrok, aNuposic Then makes sense to combine them into one option. | 17:23 |
| jlvillal | Not sure if anyone else has an opinion :) | 17:23 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector stable/ocata: Use eventlet version of subprocess https://review.openstack.org/449743 | 17:24 |
| dtantsur|pto | aarefiev_afk, I assume we need it ^^ correct me if I'm wrong (on the patch) | 17:24 |
| * dtantsur|pto is afk for real now | 17:24 | |
| *** Serlex has quit IRC | 17:27 | |
| *** sayantani01 has joined #openstack-ironic | 17:28 | |
| *** rama_y_ has quit IRC | 17:33 | |
| Nisha_ | milan, dtantsur|pto has gone on a week PTO. May be we can get consent from other expertise in Inspector | 17:33 |
| Nisha_ | aarefiev_afk, could you help with comment on https://review.openstack.org/#/c/305864/ | 17:34 |
| *** trown|lunch is now known as trown | 17:34 | |
| milan | Nisha_, sure | 17:35 |
| Nisha_ | milan, aarefiev_afk is one of the expertise in inspector | 17:36 |
| Nisha_ | i guess so | 17:36 |
| Nisha_ | milan, do u know anyone else | 17:36 |
| milan | alezil, I made a progress (me @build-tinyipa.sh) but got distracted, I'll finish on Monday though | 17:36 |
| milan | Nisha_, sambetts_ | 17:37 |
| Nisha_ | milan, sambetts_ is also inspector expertise i guess | 17:37 |
| Nisha_ | milan, but he looks to be away | 17:37 |
| Nisha_ | :( | 17:38 |
| milan | Nisha_, let's wait till Monday? | 17:38 |
| Nisha_ | milan, sure | 17:38 |
| Nisha_ | milan, meanwhile if you happen to find an answer for the comment plz leave a note in the patch | 17:38 |
| Nisha_ | :) | 17:38 |
| * Nisha_ calls it a day. Happy weekend to all | 17:39 | |
| milan | Nisha_, have a nice weekend! | 17:40 |
| *** Nisha_ is now known as Nisha|afk | 17:40 | |
| *** derekh has quit IRC | 17:40 | |
| alezil | milan: thanks :) | 17:41 |
| milan | alezil, np ;) | 17:41 |
| * milan out | 17:41 | |
| milan | Good night, Ironic! :) | 17:41 |
| *** milan has quit IRC | 17:41 | |
| alezil | good night milan: | 17:42 |
| *** mtanino has quit IRC | 17:43 | |
| lucasagomes | calling it a day as well, have a great night all! | 17:44 |
| *** lucasagomes is now known as lucas-afk | 17:44 | |
| NobodyCam | night lucas-afk | 17:48 |
| *** tesseract has quit IRC | 17:50 | |
| *** Nisha|afk has quit IRC | 17:51 | |
| *** alexpilotti has quit IRC | 17:52 | |
| *** alexpilotti has joined #openstack-ironic | 17:52 | |
| *** baoli has quit IRC | 17:56 | |
| *** mgoddard has quit IRC | 17:58 | |
| *** sayantani01 has quit IRC | 17:58 | |
| *** jcoufal has joined #openstack-ironic | 17:58 | |
| *** causten has quit IRC | 17:59 | |
| *** sayantani01 has joined #openstack-ironic | 17:59 | |
| *** causten has joined #openstack-ironic | 17:59 | |
| *** jcoufal__ has joined #openstack-ironic | 18:01 | |
| *** causten_ has joined #openstack-ironic | 18:01 | |
| *** jcoufal_ has quit IRC | 18:01 | |
| *** jcoufal has quit IRC | 18:03 | |
| *** causten has quit IRC | 18:04 | |
| *** Serlex has joined #openstack-ironic | 18:06 | |
| *** causten_ has quit IRC | 18:06 | |
| *** causten has joined #openstack-ironic | 18:07 | |
| *** baoli has joined #openstack-ironic | 18:07 | |
| *** causten_ has joined #openstack-ironic | 18:08 | |
| *** evgenyl has quit IRC | 18:08 | |
| *** evgenyl has joined #openstack-ironic | 18:09 | |
| *** alexpilotti has quit IRC | 18:10 | |
| *** causten has quit IRC | 18:11 | |
| *** kaifeng has quit IRC | 18:12 | |
| *** causten_ has quit IRC | 18:12 | |
| *** causten has joined #openstack-ironic | 18:13 | |
| *** mtanino has joined #openstack-ironic | 18:13 | |
| * mgould -> home; have a good weekend everyone! | 18:14 | |
| *** mgould is now known as mgould|afk | 18:14 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic master: Add DB layer support for node tags filters https://review.openstack.org/272624 | 18:15 |
| *** causten_ has joined #openstack-ironic | 18:15 | |
| *** jkilpatr has joined #openstack-ironic | 18:16 | |
| *** causten has quit IRC | 18:17 | |
| *** d0ugal has quit IRC | 18:17 | |
| *** e0ne has quit IRC | 18:19 | |
| *** chlong has quit IRC | 18:24 | |
| *** e0ne has joined #openstack-ironic | 18:25 | |
| *** jcoufal has joined #openstack-ironic | 18:29 | |
| *** jcoufal__ has quit IRC | 18:31 | |
| *** mgoddard has joined #openstack-ironic | 18:35 | |
| *** e0ne has quit IRC | 18:35 | |
| *** e0ne has joined #openstack-ironic | 18:37 | |
| *** racedo has quit IRC | 18:41 | |
| openstackgerrit | Anup Navare proposed openstack/ironic master: Config drive support for Ceph https://review.openstack.org/407639 | 18:49 |
| aNuposic | jlvillal, vdrok soliosg joanna addressed the issues ^ | 18:50 |
| *** racedo has joined #openstack-ironic | 18:51 | |
| openstackgerrit | Merged openstack/ironic stable/mitaka: Pin version of virtualbmc in devstack plugin https://review.openstack.org/440288 | 18:51 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic master: Add DB layer support for node tags filters https://review.openstack.org/272624 | 18:54 |
| *** jcoufal_ has joined #openstack-ironic | 18:57 | |
| jlvillal | aNuposic, Thanks | 18:58 |
| *** jcoufal has quit IRC | 18:58 | |
| *** e0ne has quit IRC | 18:59 | |
| *** crushil has joined #openstack-ironic | 18:59 | |
| openstackgerrit | Rushil Chugh proposed openstack/ironic-ui master: Adds Ironic-UI Devstack plugin https://review.openstack.org/446298 | 19:00 |
| pas-ha | g'night all | 19:01 |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Rolling upgrade procedure documentation https://review.openstack.org/416565 | 19:01 |
| JayF | #success pas-ha fixed the long-broken ironic-lib stable/mitaka gate | 19:02 |
| openstackstatus | JayF: Added success to Success page | 19:02 |
| JayF | pas-ha: awesome awesome work ++++++ | 19:02 |
| jroll | nice!! | 19:03 |
| jroll | thank you pas-ha! :) | 19:03 |
| JayF | speaking of which, isn't it time to deprecate stable/mitaka ironic-lib? /s | 19:03 |
| JayF | :P | 19:03 |
| *** tuan_luong has quit IRC | 19:10 | |
| *** tuanla_ has quit IRC | 19:10 | |
| *** crushil has quit IRC | 19:11 | |
| *** mgoddard has quit IRC | 19:16 | |
| *** racedo has quit IRC | 19:22 | |
| *** jkilpatr has quit IRC | 19:24 | |
| *** racedo has joined #openstack-ironic | 19:25 | |
| *** jcoufal_ has quit IRC | 19:28 | |
| *** jcoufal has joined #openstack-ironic | 19:29 | |
| *** crushil has joined #openstack-ironic | 19:30 | |
| *** crushil has quit IRC | 19:38 | |
| *** [1]rpioso has joined #openstack-ironic | 19:44 | |
| *** dprince has quit IRC | 19:44 | |
| *** jcoufal_ has joined #openstack-ironic | 19:45 | |
| *** rpioso has quit IRC | 19:46 | |
| *** rbudden has quit IRC | 19:47 | |
| *** jcoufal has quit IRC | 19:47 | |
| *** gcb has quit IRC | 19:49 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Rolling upgrades related dev documentation https://review.openstack.org/419439 | 19:59 |
| openstackgerrit | Merged openstack/ironic-lib stable/mitaka: Limit memory usage when running qemu-img https://review.openstack.org/422855 | 20:00 |
| *** dprince has joined #openstack-ironic | 20:03 | |
| *** racedo has quit IRC | 20:05 | |
| *** jcoufal_ has quit IRC | 20:12 | |
| *** joanna_mac has quit IRC | 20:13 | |
| *** rpioso has joined #openstack-ironic | 20:19 | |
| *** joanna_mac has joined #openstack-ironic | 20:19 | |
| *** [1]rpioso has quit IRC | 20:22 | |
| *** zackf has joined #openstack-ironic | 20:22 | |
| *** amoralej is now known as amoralej|off | 20:25 | |
| *** zackf has quit IRC | 20:26 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic stable/mitaka: [devstack] Use global requirements for virtualbmc https://review.openstack.org/440559 | 20:33 |
| *** causten_ has quit IRC | 20:33 | |
| *** causten has joined #openstack-ironic | 20:34 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic stable/mitaka: DNM test gates with disabled *_ssh drivers https://review.openstack.org/439781 | 20:35 |
| *** amarao has joined #openstack-ironic | 20:37 | |
| *** causten has quit IRC | 20:38 | |
| *** trown is now known as trown|outtypewww | 20:41 | |
| *** joanna_mac is now known as joanna_lunch | 20:44 | |
| *** jcoufal has joined #openstack-ironic | 20:49 | |
| *** yolanda has quit IRC | 20:54 | |
| *** baoli has quit IRC | 20:55 | |
| *** yolanda has joined #openstack-ironic | 20:56 | |
| *** baoli has joined #openstack-ironic | 20:58 | |
| *** e0ne has joined #openstack-ironic | 21:04 | |
| *** yolanda has quit IRC | 21:04 | |
| *** dprince has quit IRC | 21:05 | |
| *** yolanda has joined #openstack-ironic | 21:05 | |
| *** links has joined #openstack-ironic | 21:05 | |
| *** causten has joined #openstack-ironic | 21:06 | |
| *** zackf has joined #openstack-ironic | 21:07 | |
| jlvillal | aNuposic, You need to get the unit tests to patch on the Ceph patch. | 21:10 |
| jlvillal | s/to patch/to pass/ | 21:10 |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: [PoC] Add fake fields in Node object and RPC https://review.openstack.org/415462 | 21:11 |
| aNuposic | jlvillal, ah i ran tox tests actually and they all passed | 21:11 |
| aNuposic | jlvillal, reading your comments | 21:11 |
| jlvillal | aNuposic, Uh, that seems hard to believe... | 21:11 |
| *** ChubYann has joined #openstack-ironic | 21:13 | |
| aNuposic | jlvillal, let me run again and address your comments | 21:13 |
| aNuposic | jlvillal, thnx | 21:13 |
| jlvillal | aNuposic, Thanks. | 21:13 |
| jlvillal | aNuposic, And there is something wrong with the release notes too. That job failed too. | 21:13 |
| *** amarao has quit IRC | 21:15 | |
| aNuposic | jlvillal, ohhh shit, let me re-run all tests again, yeah i see jenkins gave -1 | 21:15 |
| *** jcoufal_ has joined #openstack-ironic | 21:16 | |
| aNuposic | jlvillal, ugh my bad..will fix re-run and upload new patch | 21:17 |
| jlvillal | aNuposic, As a note, you can use this: http://status.openstack.org/zuul/ | 21:17 |
| *** yolanda has quit IRC | 21:17 | |
| *** jcoufal has quit IRC | 21:17 | |
| *** baoli has quit IRC | 21:17 | |
| jlvillal | aNuposic, And then watch your job go through the gate. Don't need to wait 2 hours to see a test failed after 5 minutes. | 21:17 |
| jlvillal | aNuposic, But better to run the tox tests locally | 21:17 |
| jlvillal | aNuposic, But I have had tox tests fail in the gate due to my fault more times than I wish :( | 21:18 |
| *** yolanda has joined #openstack-ironic | 21:19 | |
| aNuposic | jlvillal, yes http://status.openstack.org/zuul/ will be helpful. | 21:19 |
| *** baha has quit IRC | 21:19 | |
| aNuposic | jlvillal, and i see tox failing locally now.. last time I ran the tests and then actually made few changes but forgot to re-run those...ugh | 21:20 |
| *** mpotdar has quit IRC | 21:21 | |
| *** joanna has quit IRC | 21:21 | |
| *** vgadiraj has quit IRC | 21:21 | |
| jlvillal | aNuposic, it happens | 21:21 |
| *** crushil has joined #openstack-ironic | 21:23 | |
| aNuposic | jlvillal, actually forgot to change group to conductor from glance in image_service.. I believe tests will pass now :) | 21:24 |
| *** bfournie has quit IRC | 21:24 | |
| *** yolanda has quit IRC | 21:26 | |
| *** zackf has quit IRC | 21:27 | |
| *** fragatina has joined #openstack-ironic | 21:29 | |
| *** zackf has joined #openstack-ironic | 21:29 | |
| *** jcoufal has joined #openstack-ironic | 21:32 | |
| *** yolanda has joined #openstack-ironic | 21:32 | |
| *** jcoufal_ has quit IRC | 21:32 | |
| *** e0ne has quit IRC | 21:32 | |
| *** yolanda has quit IRC | 21:39 | |
| *** yolanda has joined #openstack-ironic | 21:39 | |
| openstackgerrit | Anup Navare proposed openstack/ironic master: Config drive support for Ceph https://review.openstack.org/407639 | 21:40 |
| *** zackf has quit IRC | 21:41 | |
| *** causten has quit IRC | 21:42 | |
| *** causten has joined #openstack-ironic | 21:43 | |
| openstackgerrit | Annie Lezil proposed openstack/ironic-inspector master: Remove translation of log messages Part-1 https://review.openstack.org/447884 | 21:45 |
| *** jcoufal_ has joined #openstack-ironic | 21:46 | |
| *** jcoufal has quit IRC | 21:47 | |
| *** causten has quit IRC | 21:47 | |
| *** causten has joined #openstack-ironic | 21:48 | |
| *** Serlex has quit IRC | 21:59 | |
| *** sayantani01 has quit IRC | 22:01 | |
| *** xavierr has quit IRC | 22:17 | |
| *** ricardoas has quit IRC | 22:18 | |
| *** zackf has joined #openstack-ironic | 22:20 | |
| *** baoli has joined #openstack-ironic | 22:21 | |
| *** zackf has quit IRC | 22:21 | |
| *** ElCoyote_ has left #openstack-ironic | 22:32 | |
| *** xavierr has joined #openstack-ironic | 22:34 | |
| *** ricardoas has joined #openstack-ironic | 22:34 | |
| *** emerson has joined #openstack-ironic | 22:35 | |
| aNuposic | Hi jlvillal wrt to the exception if any config values are None I see that test fail when swiftAPI() call is made at L66 of https://review.openstack.org/#/c/407639/24/ironic/tests/unit/common/test_swift.py | 22:39 |
| aNuposic | jlvillal, do you think a separate test should be there just for those config options? | 22:39 |
| jlvillal | aNuposic, That test at L66 is not testing invalid values. | 22:40 |
| jlvillal | aNuposic, It sets up "valid" values. | 22:40 |
| jlvillal | aNuposic, What test is checking for the assertion raised? | 22:40 |
| aNuposic | jlvillal, no but if None are passed then those get caught by the test when swiftAPI is called | 22:40 |
| jlvillal | aNuposic, What do you mean by "the test when swiftAPI is called"? | 22:41 |
| aNuposic | jlvillal, this is how it fails http://paste.openstack.org/show/604111/ | 22:44 |
| jlvillal | aNuposic, looking | 22:44 |
| aNuposic | jlvillal, i can add but think it would be a duplicate | 22:44 |
| jlvillal | aNuposic, Uh, that isn't the code that is in the patch. | 22:44 |
| jlvillal | aNuposic, I want that code added to the patch. Another test case. | 22:45 |
| jlvillal | aNuposic, Where it checks that if any of the values are missing, that the code will raise an assertion | 22:45 |
| jlvillal | aNuposic, Want to check that code path. And make sure it detects bad values. | 22:45 |
| aNuposic | jlvillal, oh okay | 22:46 |
| aNuposic | jlvillal, got you | 22:46 |
| jlvillal | aNuposic, def test___init_ceph_missing_config(...) | 22:47 |
| aNuposic | jlvillal, so you want to have where values are None | 22:47 |
| aNuposic | jlvillal, okay | 22:47 |
| jlvillal | aNuposic, Better yet. Set them all and then test by making each one of them None, with the others set. | 22:47 |
| jlvillal | aNuposic, Similar to code you are doing to test base_manager.py | 22:48 |
| jlvillal | aNuposic, We want the unit tests to hopefully cover all code paths. | 22:48 |
| aNuposic | jlvillal, yup okay | 22:49 |
| *** mat128 has quit IRC | 22:53 | |
| *** mtanino has quit IRC | 22:57 | |
| *** mpotdar has joined #openstack-ironic | 23:03 | |
| *** zackf has joined #openstack-ironic | 23:03 | |
| *** mpotdar has quit IRC | 23:03 | |
| *** mat128 has joined #openstack-ironic | 23:04 | |
| *** zackf has quit IRC | 23:05 | |
| *** zackf has joined #openstack-ironic | 23:07 | |
| *** mpotdar has joined #openstack-ironic | 23:09 | |
| *** joanna_lunch is now known as joanna_max | 23:11 | |
| *** joanna_max is now known as joanna_mac | 23:11 | |
| *** joanna has joined #openstack-ironic | 23:12 | |
| *** rbudden has joined #openstack-ironic | 23:12 | |
| *** causten has quit IRC | 23:14 | |
| *** yolanda has quit IRC | 23:17 | |
| *** baoli_ has joined #openstack-ironic | 23:20 | |
| *** ijw has joined #openstack-ironic | 23:23 | |
| *** zackf has quit IRC | 23:24 | |
| *** baoli has quit IRC | 23:24 | |
| *** links has quit IRC | 23:24 | |
| *** racedo has joined #openstack-ironic | 23:37 | |
| *** racedo has quit IRC | 23:42 | |
| *** joanna_mac has quit IRC | 23:43 | |
| *** jcoufal has joined #openstack-ironic | 23:46 | |
| *** jcoufal_ has quit IRC | 23:49 | |
| *** jcoufal has quit IRC | 23:50 | |
| *** baoli_ has quit IRC | 23:51 | |
| *** nicodemos has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!