| *** MattMan has quit IRC | 00:03 | |
| *** MattMan has joined #openstack-ironic | 00:03 | |
| *** root has joined #openstack-ironic | 00:05 | |
| *** root is now known as Guest68273 | 00:06 | |
| *** Guest68273 has quit IRC | 00:06 | |
| *** Guest68273 has joined #openstack-ironic | 00:07 | |
| *** Guest87120 has quit IRC | 00:08 | |
| *** rama_y has quit IRC | 00:15 | |
| *** SerenaFeng has joined #openstack-ironic | 00:31 | |
| *** SerenaFeng has quit IRC | 00:31 | |
| *** SerenaFeng has joined #openstack-ironic | 00:31 | |
| *** SerenaFeng has quit IRC | 00:33 | |
| *** zhurong has joined #openstack-ironic | 00:39 | |
| *** tuanluong has joined #openstack-ironic | 00:42 | |
| *** rloo has quit IRC | 00:48 | |
| *** litao__ has joined #openstack-ironic | 00:50 | |
| *** shuyingya has joined #openstack-ironic | 00:56 | |
| *** jaypipes has quit IRC | 00:59 | |
| *** phuongnh has joined #openstack-ironic | 01:05 | |
| *** SerenaFeng has joined #openstack-ironic | 01:06 | |
| *** SerenaFeng has quit IRC | 01:07 | |
| *** amotoki_away is now known as amotoki | 01:10 | |
| *** gcb has joined #openstack-ironic | 01:30 | |
| openstackgerrit | Wang KaiFeng proposed openstack/ironic master: Make IP address of socat console configurable https://review.openstack.org/473201 | 01:36 |
|---|---|---|
| *** SerenaFeng has joined #openstack-ironic | 01:51 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/bifrost master: Define hacking rules to ensure code quality https://review.openstack.org/474412 | 01:53 |
| *** SerenaFeng has quit IRC | 01:53 | |
| *** SerenaFeng has joined #openstack-ironic | 02:00 | |
| *** SerenaFeng has quit IRC | 02:03 | |
| *** tenobreg has joined #openstack-ironic | 02:04 | |
| *** tellesnobrega has quit IRC | 02:08 | |
| *** baoli has joined #openstack-ironic | 02:10 | |
| *** wrouesnel has joined #openstack-ironic | 02:25 | |
| *** bfournie has quit IRC | 02:39 | |
| *** baoli has quit IRC | 02:47 | |
| *** FrankJ has joined #openstack-ironic | 02:55 | |
| *** vinsh has quit IRC | 03:05 | |
| *** jaganathan has joined #openstack-ironic | 03:07 | |
| *** crushil has quit IRC | 03:19 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic master: py3.5:Workaround fix for forcing virtualbmc installation with pip2 https://review.openstack.org/473913 | 03:21 |
| openstackgerrit | Vu Cong Tuan proposed openstack/ironic-inspector master: Define hacking rules to ensure code quality https://review.openstack.org/474436 | 03:29 |
| *** jrcloud has joined #openstack-ironic | 03:37 | |
| *** jrcloud has quit IRC | 03:42 | |
| openstackgerrit | Nisha Agarwal proposed openstack/proliantutils master: Discover Storage details https://review.openstack.org/341370 | 03:46 |
| openstackgerrit | Nisha Agarwal proposed openstack/proliantutils master: Discover iscsi_boot attribute https://review.openstack.org/341653 | 03:54 |
| *** SerenaFeng has joined #openstack-ironic | 04:05 | |
| *** rbudden has quit IRC | 04:10 | |
| *** SerenaFeng has quit IRC | 04:11 | |
| *** adisky__ has joined #openstack-ironic | 04:24 | |
| *** wrouesnel has quit IRC | 04:25 | |
| *** wrouesnel has joined #openstack-ironic | 04:25 | |
| *** zhurong has quit IRC | 04:28 | |
| *** zhurong has joined #openstack-ironic | 04:40 | |
| *** jaosorior has quit IRC | 05:00 | |
| *** udesale has joined #openstack-ironic | 05:11 | |
| *** rama_y has joined #openstack-ironic | 05:14 | |
| *** wrouesnel has quit IRC | 05:24 | |
| *** samodid has joined #openstack-ironic | 05:24 | |
| *** wrouesnel has joined #openstack-ironic | 05:25 | |
| *** udesale has quit IRC | 05:30 | |
| *** wrouesnel has quit IRC | 05:35 | |
| *** wrouesnel has joined #openstack-ironic | 05:35 | |
| *** ijw has joined #openstack-ironic | 05:39 | |
| *** FrankJ has quit IRC | 05:40 | |
| *** mjura has joined #openstack-ironic | 05:40 | |
| *** wrouesnel has quit IRC | 05:42 | |
| *** wrouesnel has joined #openstack-ironic | 05:42 | |
| *** fragatina has joined #openstack-ironic | 05:42 | |
| *** ijw has quit IRC | 05:44 | |
| *** dtantsur|afk is now known as dtantsur | 05:49 | |
| *** udesale has joined #openstack-ironic | 05:49 | |
| dtantsur | morning ironic | 05:50 |
| *** jrcloud has joined #openstack-ironic | 05:54 | |
| *** jaganathan has quit IRC | 05:56 | |
| *** jrcloud has quit IRC | 05:58 | |
| openstackgerrit | Rajat Sharma proposed openstack/ironic master: Using assertFalse(A) instead of assertEqual(False, A) https://review.openstack.org/474453 | 05:58 |
| *** makowals has joined #openstack-ironic | 05:59 | |
| *** ChubYann has quit IRC | 06:03 | |
| *** makowals has quit IRC | 06:03 | |
| *** udesale has quit IRC | 06:04 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 06:08 | |
| Nisha_Agarwal | pmannidi, hi | 06:09 |
| *** udesale has joined #openstack-ironic | 06:09 | |
| *** rcernin has quit IRC | 06:11 | |
| *** gcb has quit IRC | 06:17 | |
| *** gcb has joined #openstack-ironic | 06:28 | |
| *** rbartal has joined #openstack-ironic | 06:37 | |
| *** rcernin has joined #openstack-ironic | 06:37 | |
| *** SerenaFeng has joined #openstack-ironic | 06:39 | |
| *** makowals has joined #openstack-ironic | 06:40 | |
| *** tesseract has joined #openstack-ironic | 06:43 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic master: py3.5:Workaround fix for forcing virtualbmc installation with pip2 https://review.openstack.org/473913 | 06:43 |
| *** samodid has quit IRC | 06:44 | |
| *** dims has quit IRC | 06:44 | |
| *** dims has joined #openstack-ironic | 06:46 | |
| *** jaganathan has joined #openstack-ironic | 06:53 | |
| *** David_Orange has joined #openstack-ironic | 06:54 | |
| *** pcaruana has joined #openstack-ironic | 06:58 | |
| *** ccamacho|brb has quit IRC | 07:12 | |
| *** jaosorior has joined #openstack-ironic | 07:12 | |
| *** samodid has joined #openstack-ironic | 07:14 | |
| *** ccamacho has joined #openstack-ironic | 07:16 | |
| dtantsur | /quit/quit | 07:17 |
| *** shuyingya has quit IRC | 07:19 | |
| *** shuyingya has joined #openstack-ironic | 07:19 | |
| *** ralonsoh has joined #openstack-ironic | 07:21 | |
| *** shuyingya has quit IRC | 07:22 | |
| *** shuyingya has joined #openstack-ironic | 07:23 | |
| *** mvpnitesh has joined #openstack-ironic | 07:24 | |
| *** bcornec1 has joined #openstack-ironic | 07:25 | |
| *** udesale has quit IRC | 07:26 | |
| *** racedo has joined #openstack-ironic | 07:27 | |
| *** udesale has joined #openstack-ironic | 07:27 | |
| *** SerenaFeng has quit IRC | 07:30 | |
| openstackgerrit | Merged openstack/proliantutils master: Redfish: Add system push power button operations https://review.openstack.org/472631 | 07:30 |
| *** SerenaFeng has joined #openstack-ironic | 07:30 | |
| *** hoonetorg has joined #openstack-ironic | 07:34 | |
| *** stendulker has joined #openstack-ironic | 07:45 | |
| *** SerenaFeng has quit IRC | 07:46 | |
| *** mgoddard has joined #openstack-ironic | 07:47 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-ironic | 08:00 | |
| *** amarao has joined #openstack-ironic | 08:02 | |
| *** SerenaFeng has joined #openstack-ironic | 08:05 | |
| *** SerenaFeng has quit IRC | 08:05 | |
| *** shuyingy_ has joined #openstack-ironic | 08:10 | |
| *** SerenaFeng has joined #openstack-ironic | 08:11 | |
| openstackgerrit | Wang KaiFeng proposed openstack/ironic-inspector master: Exception information is not logged in periodical tasks https://review.openstack.org/474481 | 08:12 |
| *** shuyingya has quit IRC | 08:14 | |
| *** lucas-afk is now known as lucasagomes | 08:18 | |
| lucasagomes | morning all | 08:18 |
| *** Nisha_Agarwal has quit IRC | 08:22 | |
| *** Nisha_ has joined #openstack-ironic | 08:22 | |
| *** dtantsur is now known as dtantsur|lunch | 08:33 | |
| *** shuyingy_ has quit IRC | 08:34 | |
| *** shuyingya has joined #openstack-ironic | 08:34 | |
| *** aparnav has joined #openstack-ironic | 08:44 | |
| *** xiefp has quit IRC | 08:54 | |
| *** yolanda_ has joined #openstack-ironic | 08:59 | |
| *** karts is now known as karthiks | 09:04 | |
| *** SerenaFeng has quit IRC | 09:11 | |
| *** e0ne has joined #openstack-ironic | 09:12 | |
| vdrok | good morning ironic, dtantsur|lunch and lucasagomes ! | 09:15 |
| lucasagomes | o/ | 09:15 |
| *** bfournie has joined #openstack-ironic | 09:18 | |
| *** shuyingya has quit IRC | 09:22 | |
| *** Nisha_ has quit IRC | 09:23 | |
| *** shuyingya has joined #openstack-ironic | 09:23 | |
| *** mvpnitesh has quit IRC | 09:24 | |
| openstackgerrit | Madhuri Kumari proposed openstack/ironic master: [WIP] Add new API to expose ironic-conductors https://review.openstack.org/474512 | 09:26 |
| *** SerenaFeng has joined #openstack-ironic | 09:27 | |
| *** SerenaFeng has quit IRC | 09:29 | |
| *** shuyingy_ has joined #openstack-ironic | 09:31 | |
| *** shuyingya has quit IRC | 09:34 | |
| *** d0ugal has quit IRC | 09:48 | |
| *** d0ugal has joined #openstack-ironic | 09:49 | |
| *** milan has joined #openstack-ironic | 09:55 | |
| milan | morning Ironic! :) | 09:56 |
| *** dtantsur|lunch is now known as dtantsur | 09:56 | |
| *** David_Orange has quit IRC | 10:04 | |
| *** jrcloud has joined #openstack-ironic | 10:10 | |
| *** jrcloud has quit IRC | 10:15 | |
| *** e0ne has quit IRC | 10:17 | |
| *** sambetts|afk is now known as sambetts | 10:23 | |
| *** phuongnh has quit IRC | 10:26 | |
| *** jkilpatr has quit IRC | 10:32 | |
| openstackgerrit | Merged openstack/ironic-inspector master: Deprecate removing old status and disable it by default https://review.openstack.org/472656 | 10:33 |
| openstackgerrit | Debayan Ray proposed openstack/proliantutils master: [WIP] Redfish: Add secure boot API support https://review.openstack.org/472244 | 10:34 |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic master: Tempest scenario test for boot-from-volume https://review.openstack.org/472740 | 10:38 |
| *** derekh has joined #openstack-ironic | 10:40 | |
| *** jkilpatr has joined #openstack-ironic | 10:49 | |
| *** e0ne has joined #openstack-ironic | 10:49 | |
| *** shuyingy_ has quit IRC | 10:56 | |
| *** jrcloud has joined #openstack-ironic | 10:56 | |
| *** shuyingya has joined #openstack-ironic | 10:56 | |
| *** shuyingy_ has joined #openstack-ironic | 10:57 | |
| *** shuyingya has quit IRC | 10:57 | |
| *** shuyingy_ has quit IRC | 10:59 | |
| *** shuyingya has joined #openstack-ironic | 11:00 | |
| *** jrcloud has quit IRC | 11:00 | |
| *** e0ne has quit IRC | 11:09 | |
| *** ralonsoh has quit IRC | 11:10 | |
| *** ralonsoh has joined #openstack-ironic | 11:10 | |
| *** stendulker has quit IRC | 11:17 | |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector master: Use new oslo db EngineFacade https://review.openstack.org/453057 | 11:20 |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector master: Use new oslo db EngineFacade https://review.openstack.org/453057 | 11:26 |
| *** udesale has quit IRC | 11:26 | |
| *** udesale has joined #openstack-ironic | 11:28 | |
| *** yolanda__ has joined #openstack-ironic | 11:30 | |
| *** yolanda_ has quit IRC | 11:30 | |
| *** chlong has joined #openstack-ironic | 11:32 | |
| *** fragatina has quit IRC | 11:43 | |
| *** fragatina has joined #openstack-ironic | 11:43 | |
| *** dyasny has quit IRC | 11:44 | |
| vdrok | good morning milan | 11:50 |
| milan | morning vdrok! :) | 11:50 |
| pas-ha | morning ironic :) | 11:52 |
| openstackgerrit | Anshul Jain proposed openstack/proliantutils master: Adds manager support for redfish API's. https://review.openstack.org/473719 | 11:53 |
| vdrok | morning pas-ha | 12:01 |
| *** root2 has joined #openstack-ironic | 12:04 | |
| *** jaganathan has quit IRC | 12:05 | |
| *** yolanda__ is now known as yolanda | 12:05 | |
| *** Guest68273 has quit IRC | 12:07 | |
| *** tuanluong has quit IRC | 12:10 | |
| openstackgerrit | Mark Goddard proposed openstack/ironic master: Validate portgroup physical network consistency https://review.openstack.org/469932 | 12:10 |
| *** e0ne has joined #openstack-ironic | 12:12 | |
| TheJulia | Good morning everyone | 12:13 |
| *** shuyingya has quit IRC | 12:13 | |
| *** ccamacho is now known as ccamacho|lunch | 12:15 | |
| *** rbudden has joined #openstack-ironic | 12:16 | |
| *** shuyingya has joined #openstack-ironic | 12:23 | |
| *** trown|outtypewww is now known as trown | 12:24 | |
| *** zhurong has quit IRC | 12:26 | |
| *** shuyingya has quit IRC | 12:27 | |
| *** zhurong has joined #openstack-ironic | 12:28 | |
| *** shuyingya has joined #openstack-ironic | 12:28 | |
| *** baoli has joined #openstack-ironic | 12:31 | |
| *** vinsh has joined #openstack-ironic | 12:32 | |
| dtantsur | morning vdrok, lucasagomes, TheJulia, pas-ha | 12:33 |
| *** dyasny has joined #openstack-ironic | 12:35 | |
| *** zhurong has quit IRC | 12:36 | |
| *** dyasny has quit IRC | 12:37 | |
| *** dyasny has joined #openstack-ironic | 12:38 | |
| TheJulia | good morning dtantsur | 12:40 |
| *** e0ne has quit IRC | 12:42 | |
| *** shuyingy_ has joined #openstack-ironic | 12:43 | |
| *** mvpnitesh has joined #openstack-ironic | 12:45 | |
| *** shuyingya has quit IRC | 12:46 | |
| *** paramite has joined #openstack-ironic | 12:48 | |
| paramite | dtantsur, so to repeat myself I have left oooq prepare one more node for me in overcloud and now I'm trying to boot it by "nova boot --image overcloud-full --flavor oooq_opstools opstools" the only reasonable error I found both in ironic and nova logs is https://paste.fedoraproject.org/paste/~11ENdouXDOJyr6TCj6Baw , so now I'm trying to figure out what I did wrong or if there is some bug. Any hints anybody? | 12:49 |
| dtantsur | paramite: which version of ironic is it? | 12:50 |
| dtantsur | please also fetch the preceding logs for this node. it's not clear which operation was executed | 12:51 |
| paramite | dtantsur, openstack-ironic-api-8.0.1-0.20170610002959.adf3461.el7.centos.noarch | 12:51 |
| dtantsur | so, master, I guess | 12:53 |
| paramite | yup | 12:53 |
| paramite | dtantsur, https://paste.fedoraproject.org/paste/r~K128q0GhFL0rB5a-qMfQ | 12:53 |
| paramite | dtantsur, wanna more preceding logs? | 12:54 |
| *** appu103 has joined #openstack-ironic | 12:54 | |
| paramite | dtantsur, or I can give you access to the host if it will help | 12:54 |
| dtantsur | paramite: the logs seem fine.. how does the error manifest? does the node go to "error" state? | 12:55 |
| *** Goneri has joined #openstack-ironic | 12:56 | |
| paramite | dtantsur, https://paste.fedoraproject.org/paste/~1tmlHWA9zk8~nLJPbiUZQ | 12:56 |
| *** aparnav has quit IRC | 12:57 | |
| dtantsur | aha, so deploy failed.. wow, this is something new to me. | 12:57 |
| paramite | dtantsur, yeah, because nova timeouted | 12:58 |
| *** appu103 has quit IRC | 12:58 | |
| paramite | dtantsur, /var/log/nova/nova-compute.log:10768:2017-06-15 12:19:25.343 21422 ERROR oslo.service.loopingcall InstanceDeployFailure: Failed to provision instance f690f83c-9ea6-49d2-b4b6-55abe61e4279: Timeout reached while waiting for callback for node da3fb2fa-e947-4516-a957-dc51d1f968f4 | 12:59 |
| dtantsur | yeah.. lemme dive into code | 12:59 |
| paramite | ack | 13:00 |
| paramite | dtantsur, for nova: https://paste.fedoraproject.org/paste/WmnMEbWKuUkZXH~NNz6XPg | 13:00 |
| *** sasha2 has joined #openstack-ironic | 13:02 | |
| dtantsur | paramite: putting aside this failure for a second, do you see the nodes trying to power on during these attempts to deploy? | 13:04 |
| *** udesale has quit IRC | 13:05 | |
| *** rloo has joined #openstack-ironic | 13:05 | |
| *** mjturek has joined #openstack-ironic | 13:08 | |
| paramite | dtantsur, let me check | 13:09 |
| *** jcoufal has joined #openstack-ironic | 13:10 | |
| paramite | dtantsur, nope, all the nodes are still "power off" | 13:10 |
| openstackgerrit | Merged openstack/ironic-lib master: Support for NVMe drives for config drives https://review.openstack.org/471914 | 13:11 |
| *** shuyingy_ has quit IRC | 13:19 | |
| dtantsur | paramite: could you please check that you can even power on this particular node: openstack baremetal power on da3fb2fa-e947-4516-a957-dc51d1f968f4 | 13:19 |
| *** shuyingya has joined #openstack-ironic | 13:20 | |
| paramite | dtantsur, openstack: 'baremetal power on da3fb2fa-e947-4516-a957-dc51d1f968f4' is not an openstack command. | 13:20 |
| dtantsur | paramite: sorry, should be "baremetal node power.." | 13:20 |
| *** dprince has joined #openstack-ironic | 13:20 | |
| *** mjturek has left #openstack-ironic | 13:21 | |
| paramite | dtantsur, nope, cannot: https://paste.fedoraproject.org/paste/2diHlkMEhMiDf3CWcF2IHw | 13:21 |
| dtantsur | paramite: even after some time? please paste 'openstack baremetal node show da3fb2fa-e947-4516-a957-dc51d1f968f4' | 13:29 |
| paramite | dtantsur, ok, now it is on | 13:30 |
| paramite | dtantsur, https://paste.fedoraproject.org/paste/~IJnWiEQ0F9SkKE81kv2xA | 13:30 |
| *** ccamacho|lunch is now known as ccamacho | 13:30 | |
| *** shuyingya has quit IRC | 13:30 | |
| dtantsur | ok, so that was not the problem in the end.. | 13:32 |
| openstackgerrit | Peter Piela proposed openstack/ironic-ui master: Extend backend mock with port operations https://review.openstack.org/473539 | 13:38 |
| *** mvpnitesh has quit IRC | 13:38 | |
| *** mjturek has joined #openstack-ironic | 13:40 | |
| *** mjturek has left #openstack-ironic | 13:41 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Wire in storage interface attach/detach operations https://review.openstack.org/406290 | 13:41 |
| *** mjturek has joined #openstack-ironic | 13:42 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: iPXE template support for iSCSI https://review.openstack.org/413324 | 13:44 |
| *** tenobreg has quit IRC | 13:45 | |
| *** zzzeek has quit IRC | 13:46 | |
| *** zzzeek has joined #openstack-ironic | 13:47 | |
| *** zhurong has joined #openstack-ironic | 13:49 | |
| *** vinsh has quit IRC | 13:50 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Logic for skipping deployment with BFV https://review.openstack.org/454243 | 13:52 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add CRUD notification objects for volume connector and volume target https://review.openstack.org/463930 | 13:54 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add REST API for volume connector and volume target operation https://review.openstack.org/214586 | 13:54 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Enable cinder storage interface for generic hardware https://review.openstack.org/463908 | 13:54 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add storage interface field to node-related notifications https://review.openstack.org/463972 | 13:55 |
| *** crushil has joined #openstack-ironic | 13:57 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: iRMC: Support volume boot for iRMC virtual media boot interface https://review.openstack.org/467911 | 13:57 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: DevStack: Add configuration for boot-from-volume https://review.openstack.org/466333 | 13:57 |
| dtantsur | wow :D | 13:58 |
| *** jistr is now known as jistr|mtg | 13:59 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add a guide for Devstack configuration for boot-from-volume https://review.openstack.org/466568 | 14:00 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add a guide for Devstack configuration for boot-from-volume https://review.openstack.org/466568 | 14:01 |
| *** mvpnitesh has joined #openstack-ironic | 14:01 | |
| *** bnemec has joined #openstack-ironic | 14:01 | |
| openstackgerrit | Merged openstack/ironic master: Minor changes to object version-related code https://review.openstack.org/474325 | 14:04 |
| TheJulia | dtantsur: I only rebased the doc change and edited it. I need to go back through the entire list of patches at this point | 14:04 |
| dtantsur | so much work ahead, sigh.. | 14:05 |
| * dtantsur imagines review all this :) | 14:05 | |
| * rloo thinks dtantsur is secretly excited about reviewing all that! | 14:06 | |
| rloo | hi and good morning all, TheJulia, dtantsur | 14:06 |
| dtantsur | morning rloo, I actually am. Just no idea where to find any time ;) | 14:07 |
| openstackgerrit | Christopher Dearborn proposed openstack/ironic master: Wait until iDRAC is ready before out-of-band cleaning https://review.openstack.org/466086 | 14:07 |
| rloo | dtantsur: i hear you! | 14:07 |
| *** mvpnitesh has quit IRC | 14:07 | |
| *** mvpnitesh has joined #openstack-ironic | 14:10 | |
| * TheJulia grumbles about time machines being the only way | 14:12 | |
| *** SerenaFeng has joined #openstack-ironic | 14:15 | |
| *** SerenaFeng has quit IRC | 14:17 | |
| openstackgerrit | Michael Turek proposed openstack/ironic master: Fail if boot_from_volume enabled but not ipxe https://review.openstack.org/472856 | 14:18 |
| *** SerenaFeng has joined #openstack-ironic | 14:20 | |
| *** zhurong has quit IRC | 14:22 | |
| *** ccamacho has quit IRC | 14:22 | |
| *** ccamacho has joined #openstack-ironic | 14:22 | |
| *** udesale has joined #openstack-ironic | 14:30 | |
| aarefiev | dtantsur: hey, I had to rebase https://review.openstack.org/453057 , mind to recheck when you have time | 14:32 |
| patchbot | patch 453057 - ironic-inspector - Use new oslo db EngineFacade | 14:32 |
| dtantsur | sure (but unlikely today) | 14:32 |
| TheJulia | mjturek: merge conflict | 14:32 |
| aarefiev | thx | 14:32 |
| *** rbartal has quit IRC | 14:38 | |
| *** vinsh has joined #openstack-ironic | 14:45 | |
| *** makowals has quit IRC | 14:47 | |
| *** mjturek has quit IRC | 14:52 | |
| *** makowals has joined #openstack-ironic | 14:53 | |
| *** e0ne has joined #openstack-ironic | 14:53 | |
| *** amarao has quit IRC | 14:56 | |
| *** jistr|mtg is now known as jistr | 14:59 | |
| *** mvpnitesh has quit IRC | 15:01 | |
| *** crushil has quit IRC | 15:02 | |
| *** dtantsur is now known as dtantsur|bbl | 15:02 | |
| *** crushil has joined #openstack-ironic | 15:03 | |
| *** mjura has quit IRC | 15:06 | |
| *** rcernin has quit IRC | 15:09 | |
| *** bcornec1 has quit IRC | 15:10 | |
| jlvillal | Good morning Ironic :) | 15:11 |
| TheJulia | Good morning | 15:11 |
| rloo | mornin' jlvillal | 15:15 |
| *** rama_y has quit IRC | 15:15 | |
| *** rama_y has joined #openstack-ironic | 15:15 | |
| *** rpioso has joined #openstack-ironic | 15:17 | |
| rloo | hi vdrok, wrt https://review.openstack.org/#/c/233357/, my mind is on other stuff, but I guess you'd like the new _set_from_db_object() sooner (today) rather than next Mon? | 15:18 |
| patchbot | patch 233357 - ironic - Add nodes tagging support - RPC objects | 15:18 |
| vdrok | morning all, dtantsur|bbl TheJulia rloo jlvillal | 15:19 |
| vdrok | rloo: no rush with this :) but I can do the patch too I hope, if you have other more high priority things | 15:20 |
| rloo | vdrok: ok, whoever gets to it first then. thx! | 15:20 |
| *** root4 has joined #openstack-ironic | 15:21 | |
| *** root has joined #openstack-ironic | 15:22 | |
| *** root is now known as Guest83141 | 15:23 | |
| *** root_____ has joined #openstack-ironic | 15:24 | |
| *** jaypipes has joined #openstack-ironic | 15:24 | |
| *** root_____ has quit IRC | 15:24 | |
| *** root2 has quit IRC | 15:24 | |
| *** root_____ has joined #openstack-ironic | 15:25 | |
| *** root_____ has quit IRC | 15:25 | |
| openstackgerrit | Merged openstack/ironic stable/ocata: [devstack] Use global requirements for virtualbmc https://review.openstack.org/448632 | 15:26 |
| *** root4 has quit IRC | 15:26 | |
| *** Guest83141 has quit IRC | 15:26 | |
| openstackgerrit | Michael Turek proposed openstack/ironic master: Move _abort_attach_volumes functionality to detach_volumes https://review.openstack.org/467766 | 15:29 |
| vdrok | rloo: oh, btw, regarding that patch, I'm not sure that setting self.tags=None would suffice. do I understand correctly that we should remove the field completely, so that it is not sent over the rpc wire at all? | 15:34 |
| rloo | vdrok: that's what i want to confirm. i mean, i think it is OK to send the field, and I thought I had tested it, but cannot remember now. | 15:35 |
| rloo | vdrok: i know that i need that 'change' when saving to the DB though. | 15:35 |
| vdrok | rloo: mhm, makes sense | 15:36 |
| rloo | vdrok: if i recall correctly (which i want to confirm) all object fields are sent over when serialized; just that if they aren't set, they have a different value to indicate not set, but yeah, need to confirm. | 15:36 |
| vdrok | rloo: I was looking at https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L953 and https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L553-L556 | 15:38 |
| *** SerenaFeng has quit IRC | 15:39 | |
| *** jkilpatr_ has joined #openstack-ironic | 15:40 | |
| rloo | vdrok: yes, which is why i am wondering why i thought the ones that weren't set, had also been serialized, but maybe i am wrong. also, it may be fine to set to None -- i need to check deserialization too. | 15:41 |
| *** jkilpatr has quit IRC | 15:43 | |
| *** rcernin has joined #openstack-ironic | 15:44 | |
| vdrok | rloo: also, our current docs say to use obj_make_compatible https://github.com/openstack/ironic/blob/d8e5a269ac3e098fedea7e509750670156e650d3/doc/source/dev/code-contribution-guide.rst#L179 (and ovo triggers it too), while we now use this https://github.com/openstack/ironic/blob/master/ironic/objects/base.py#L320 | 15:47 |
| NobodyCam | Good Morning Ironic'ers | 15:48 |
| *** crushil has quit IRC | 15:48 | |
| vdrok | (sorry, I was a bit off ironic recently, may have missed the discussion on this) | 15:48 |
| vdrok | morning NobodyCam ! | 15:48 |
| NobodyCam | Morning vdrok :) | 15:48 |
| *** dtantsur|bbl is now known as dtantsur | 15:49 | |
| *** crushil has joined #openstack-ironic | 15:49 | |
| vdrok | NobodyCam: is there a special phrase for thursday? :) like humpday or tgif? | 15:49 |
| dtantsur | morning jlvillal, NobodyCam | 15:49 |
| NobodyCam | morning dtantsur :) | 15:49 |
| NobodyCam | hum, not that I know... ofc other then It's almost Friday! :p | 15:50 |
| rloo | vdrok: yup, the previous design was to use obj_make_compatible. I wanted to simplify things. otherwise with future changes, we'd need to provide obj_make_compatible AND convert_to_version, which basically do similar stuff, just acting on different data structures. | 15:50 |
| NobodyCam | morning rloo :) | 15:50 |
| *** bcornec1 has joined #openstack-ironic | 15:50 | |
| rloo | vdrok: so for serialize/deserialize, i thought, why not convert the object to the desired version first, before doing the actual serial/deserial stuff (or err before serial, after deserial) | 15:50 |
| rloo | morning NobodyCam! | 15:51 |
| *** e0ne has quit IRC | 15:51 | |
| vdrok | rloo: right, but I'm thinking when we'll have more elaborate sub-objects, we might still have to do obj_make_compatible. like if node version 1.21 uses tag 1.0 and node version 1.25 uses tag 1.1 | 15:51 |
| NobodyCam | :) | 15:51 |
| vdrok | or add more logic to our methods? not sure how it would look like, just thinking | 15:51 |
| rloo | vdrok: hmm, i didn't look into subobjects cuz we didn't have any before. i need to test out the tagging stuff with this. | 15:52 |
| rloo | vdrok: i think it should work though, i don't think i did anything to stop subobjects but on the other hand, ignorance of how that works... | 15:52 |
| vdrok | rloo: nah, I mean, we can always change things if needed :) thanks! | 15:53 |
| rloo | vdrok: heh. i am wondering what happens if we have node version 1.21 use tag 1.0 in release N, and node version 1.21 use tag 1.1 in release N+1 | 15:54 |
| rloo | vdrok: i think we don't allow that, if tag changes to 1.1, we'd have to up node to 1.22. | 15:54 |
| vdrok | yup, I supposed so | 15:55 |
| rloo | vdrok: more documentation... | 15:55 |
| rama_y | Hi dtantsur, question about https://bugs.launchpad.net/ironic-inspector/+bug/1694842 | 15:55 |
| openstack | Launchpad bug 1694842 in Ironic "IPA fails ironic devstack jobs when tls-proxy is enabled in devstack" [High,In progress] - Assigned to Dmitry Tantsur (divius) | 15:55 |
| dtantsur | sure | 15:55 |
| rama_y | There is another part for inspector, right? | 15:56 |
| dtantsur | rama_y: there will be, I guess | 15:56 |
| rloo | vdrok: and the node has a list of node-tag objects instead of node-tag IDs for efficiency, right? (vs the chassis id, portgroup id, all ids everywhere else) | 15:56 |
| rama_y | So, currently there is nothing to fix for inspector? | 15:57 |
| vdrok | rloo: well, I think there was a patch from jroll some time ago to do the same thing with joinedload for all connected objects | 15:57 |
| vdrok | rloo: to enable doing things like node.ports[0] on the object level | 15:57 |
| rloo | vdrok: i recall a performance hit at the API level at least (I think i filed a bug for it). if a node is associated with a chassis, the API does two DB requests, one to get the node and one to get the chassis :-( | 15:58 |
| vdrok | rloo: iiuc that will do the join on db level and return everything so the second call won't be necessary | 15:59 |
| rloo | vdrok: right. too bad we didn't get that in. one of these days... | 15:59 |
| vdrok | i might be wrong though | 15:59 |
| rloo | vdrok: ok, on my list to test the tags stuff with the rolling upgrades stuff. | 16:00 |
| TheJulia | Time for the BFV meeting in #openstack-meeting-5 | 16:01 |
| rama_y | dtantsur, what might be the part for inspector for tls-proxy? | 16:02 |
| *** crushil has quit IRC | 16:02 | |
| *** litao__ has quit IRC | 16:02 | |
| *** crushil has joined #openstack-ironic | 16:03 | |
| dtantsur | rama_y: no idea, sorry. I barely understand the patch I wrote :) I need someone's help on figuring it out.. | 16:03 |
| rama_y | dtantsur, ok. thanks. I see you have a -1 on your patch. | 16:04 |
| dtantsur | yep, I need to ping clarkb to take a look.. | 16:05 |
| jlvillal | dtantsur: Does nova support tls-proxy yet? | 16:05 |
| *** udesale__ has joined #openstack-ironic | 16:05 | |
| dtantsur | apparently yes | 16:06 |
| dtantsur | otherwise I would not get pinged due to ironic not supporting it, I guess :) | 16:06 |
| jlvillal | dtantsur: Okay good. Since we are dependent on a bunch of things, like nova :) | 16:06 |
| *** lucasagomes is now known as lucas-afk | 16:07 | |
| *** udesale has quit IRC | 16:07 | |
| *** derekh has quit IRC | 16:07 | |
| *** milan has quit IRC | 16:12 | |
| *** rcernin has quit IRC | 16:12 | |
| openstackgerrit | Merged openstack/python-ironicclient master: Adds --driver option to OSC "node list" command https://review.openstack.org/472462 | 16:12 |
| *** rama_y has quit IRC | 16:15 | |
| jlvillal | dtantsur: rloo: So do you prefer to let it fail in the API then? https://review.openstack.org/#/c/472457/2/ironicclient/osc/v1/baremetal_port.py | 16:18 |
| patchbot | patch 472457 - python-ironicclient - Add options for osc 'port set' command | 16:18 |
| jlvillal | Instead of failing early in the client? | 16:18 |
| rloo | jlvillal: yes, or if not, it should be in a separate patch. | 16:18 |
| openstackgerrit | Merged openstack/python-ironicclient master: Add --uuid option to OSC "port create" cmd https://review.openstack.org/472390 | 16:18 |
| dtantsur | jlvillal: I'd prefer to have only basic checks in client, to be honest. Like, we can check that --driver is required, but content of this JSOB blob.. dunno | 16:18 |
| jlvillal | Okay then. | 16:19 |
| rloo | jlvillal: but yeah, we haev lots of other cases where we check at server part. | 16:19 |
| *** stendulker has joined #openstack-ironic | 16:19 | |
| jlvillal | Makes sense as less trouble keeping client in sync with server. | 16:19 |
| rloo | jlvillal: exactly, server is source of truth :-) | 16:19 |
| jlvillal | rloo: +2 | 16:20 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/bifrost master: Updated from global requirements https://review.openstack.org/474627 | 16:21 |
| rpioso | When will we be meeting at PTG Denver? | 16:21 |
| *** Nisha_Agarwal has joined #openstack-ironic | 16:21 | |
| jlvillal | rpioso: https://www.openstack.org/ptg/ | 16:21 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic master: Updated from global requirements https://review.openstack.org/474642 | 16:24 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector master: Updated from global requirements https://review.openstack.org/474643 | 16:24 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib master: Updated from global requirements https://review.openstack.org/474644 | 16:24 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent master: Updated from global requirements https://review.openstack.org/474646 | 16:24 |
| rpioso | jlvillal: Thank you. A link off of there, https://www.openstack.org/ptg/#tab_schedule, recommends checking with your PTL before booking travel. It in turn points to an in progress schedule, which is at https://docs.google.com/spreadsheets/u/1/d/1xmOdT6uZ5XqViActr5sBOaz_mEgjKSCY7NEWcAEcT-A/pubhtml?gid=397241312&single=true. | 16:25 |
| *** athomas has quit IRC | 16:26 | |
| rpioso | jlvillal: In ironic's row, there's a question mark regarding Friday. | 16:26 |
| TheJulia | Ideally, teams should always plan on friday | 16:27 |
| TheJulia | Even if it is just spend some time hacking on code, or drinking coffee | 16:27 |
| dtantsur | TheJulia: if I need to tell someone that we're good with Friday, lemme know. I think I've seen a question like that on the ML, but I cannot find it. | 16:27 |
| rpioso | TheJulia: That sounds very reasonable. | 16:27 |
| rloo | TheJulia: although in past years, Fri has not been very productive | 16:27 |
| dtantsur | I do intend to show up in the morning, then potentially leave in the afternoon | 16:28 |
| dtantsur | depends on flights of course | 16:28 |
| TheJulia | productivity is not the purpose of what friday is intended as | 16:28 |
| rloo | TheJulia: Oh. I only go to be productive :-) | 16:28 |
| rpioso | dtantsur: Is an itinerary available for the VM & BM WG inter-project discussions planned for Monday and Tuesday? | 16:29 |
| dtantsur | rpioso: I'm not aware of such. I've been involved in it much less than I should have been. | 16:30 |
| * dtantsur blames jroll of course | 16:30 | |
| rpioso | dtantsur: :-) | 16:30 |
| TheJulia | dtantsur: perhaps toss it as a meeting agenda item for monday? | 16:30 |
| dtantsur | TheJulia: what exactly? the PTG layout? | 16:30 |
| TheJulia | well s/toss/add/ or /toss/toss it out to the group during the meeting/ | 16:30 |
| TheJulia | friday | 16:31 |
| openstackgerrit | Mark Goddard proposed openstack/python-ironicclient master: Add physical network to osc port commands https://review.openstack.org/461893 | 16:31 |
| dtantsur | TheJulia: easily, lemme add it. formally I should also ask the folks if they want the PTG at all :) | 16:31 |
| jlvillal | dtantsur: Oh, how did the audio bridge weekly meeting go while I was on vacation? | 16:32 |
| * TheJulia was going to ask dtantsur about it later today :) | 16:32 | |
| rpioso | dtantsur: Also, it would be helpful to have more insight into that cross-project meeting, specifically our involvement. | 16:32 |
| dtantsur | jlvillal: well, this is a shameful thing: I simply forgot about it :( | 16:33 |
| jlvillal | dtantsur: heh | 16:33 |
| dtantsur | rpioso: I'm not sure it's set in stone yet | 16:33 |
| dtantsur | that happens when you do a dozen of things in parallel :( sorry for that | 16:33 |
| dtantsur | I do feel like trying it.. if anybody feels like proposing it on the ML - I'll be very greatful | 16:34 |
| dtantsur | TheJulia: agenda updated | 16:34 |
| TheJulia | \o/ | 16:35 |
| *** jkilpatr has joined #openstack-ironic | 16:36 | |
| *** jkilpatr_ has quit IRC | 16:37 | |
| *** ijw has joined #openstack-ironic | 16:38 | |
| * dtantsur starts moving towards the wine fest | 16:38 | |
| dtantsur | see you tomorrow :) | 16:38 |
| *** dtantsur is now known as dtantsur|afk | 16:38 | |
| TheJulia | enjoy! | 16:38 |
| rpioso | dtantsur: ty | 16:39 |
| *** athomas has joined #openstack-ironic | 16:39 | |
| TheJulia | jlvillal: btw, I updated https://review.openstack.org/#/c/406290/ this morning and would <3 if you were able to take a little bit and re-review. It failed due to the fun neutron delete issue, so I rechecked it. Later patch sets that were reboot passed. | 16:40 |
| patchbot | patch 406290 - ironic - Wire in storage interface attach/detach operations | 16:40 |
| jlvillal | TheJulia: I will review it today! | 16:40 |
| TheJulia | much appreciated | 16:40 |
| TheJulia | Stepping away for a little while to bolt my brain back into my skull... err... I mean have lunch. | 16:41 |
| *** phuongnh has joined #openstack-ironic | 16:42 | |
| *** root_____ has joined #openstack-ironic | 16:43 | |
| phuongnh | TheJulia: I found an instruction here, should I follow it? http://git.tutorialhorizon.com/2014/10/05/replace-the-master-branch-with-another-branch-in-git/ | 16:43 |
| *** tesseract has quit IRC | 16:46 | |
| openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient master: Update releasenote for osc-port-set https://review.openstack.org/474705 | 16:47 |
| openstackgerrit | Merged openstack/python-ironicclient master: Add options for osc 'port set' command https://review.openstack.org/472457 | 16:47 |
| jlvillal | rloo: ^^^ on my proposed patch | 16:47 |
| *** udesale__ has quit IRC | 16:47 | |
| openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient master: Update releasenote for osc-port-set https://review.openstack.org/474705 | 16:48 |
| *** stendulker has quit IRC | 16:50 | |
| *** Nisha_Agarwal has quit IRC | 16:51 | |
| *** crushil has quit IRC | 16:51 | |
| *** rama_y has joined #openstack-ironic | 16:53 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic master: py3.5:Workaround fix for forcing virtualbmc installation with pip2 https://review.openstack.org/473913 | 16:54 |
| jroll | dtantsur|afk: you're welcome :D | 16:55 |
| *** crushil has joined #openstack-ironic | 16:56 | |
| *** ralonsoh has quit IRC | 17:01 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 17:04 | |
| openstackgerrit | Peter Piela proposed openstack/ironic-ui master: Extend backend mock with port operations https://review.openstack.org/473539 | 17:06 |
| * sambetts -> home | 17:08 | |
| sambetts | night all | 17:08 |
| *** sambetts is now known as sambetts|afk | 17:08 | |
| *** root has joined #openstack-ironic | 17:11 | |
| *** root is now known as Guest41938 | 17:12 | |
| *** root2 has joined #openstack-ironic | 17:13 | |
| *** jtomasek has quit IRC | 17:13 | |
| *** root_____ has quit IRC | 17:16 | |
| *** pcaruana has quit IRC | 17:16 | |
| *** trown is now known as trown|lunch | 17:16 | |
| *** Guest41938 has quit IRC | 17:16 | |
| *** greghaynes is now known as greghayn1 | 17:18 | |
| *** root2 has quit IRC | 17:18 | |
| *** greghaynes has joined #openstack-ironic | 17:18 | |
| *** root2 has joined #openstack-ironic | 17:18 | |
| *** root2 has quit IRC | 17:20 | |
| *** root2 has joined #openstack-ironic | 17:20 | |
| *** greghaynes has quit IRC | 17:22 | |
| *** greghaynes has joined #openstack-ironic | 17:23 | |
| *** jcoufal_ has joined #openstack-ironic | 17:24 | |
| *** greghayn1 has quit IRC | 17:25 | |
| *** jcoufal has quit IRC | 17:25 | |
| TheJulia | phuongnh: no | 17:27 |
| TheJulia | phuongnh: do this, git review -d $new_parent | 17:27 |
| TheJulia | git review -x $your_change | 17:27 |
| TheJulia | git review -R | 17:27 |
| TheJulia | if you get any errors, naturally you'll need to resolve them, but I don't think you will | 17:28 |
| *** jcoufal has joined #openstack-ironic | 17:29 | |
| *** phuongnh has quit IRC | 17:30 | |
| *** jcoufal_ has quit IRC | 17:31 | |
| *** bcornec1 has quit IRC | 17:42 | |
| openstackgerrit | Anup Navare proposed openstack/ironic-ui master: Allow selecting interfaces while enrolling nodes https://review.openstack.org/473957 | 17:53 |
| *** crushil has quit IRC | 17:54 | |
| *** crushil has joined #openstack-ironic | 17:55 | |
| *** ChubYann has joined #openstack-ironic | 17:56 | |
| *** samodid has quit IRC | 17:56 | |
| *** fragatina has quit IRC | 18:00 | |
| *** Nisha_Agarwal has quit IRC | 18:00 | |
| *** ijw has quit IRC | 18:01 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 18:01 | |
| *** ijw has joined #openstack-ironic | 18:02 | |
| rloo | thx jlvillal, commented! | 18:03 |
| *** Nisha_Agarwal has quit IRC | 18:03 | |
| *** ijw has quit IRC | 18:03 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 18:04 | |
| *** ijw has joined #openstack-ironic | 18:04 | |
| *** zzzeek has quit IRC | 18:04 | |
| *** Nisha_Agarwal has quit IRC | 18:04 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 18:05 | |
| *** mriedem has joined #openstack-ironic | 18:14 | |
| mriedem | wondering if someone can confirm something for me - that when showing server details for a bm server, the 'node' field is actually the ironic node's uuid | 18:14 |
| mriedem | not a name | 18:14 |
| rloo | mriedem: i highly doubt it would be the name | 18:15 |
| rloo | mriedem: which isn't confirming. let me see if i know where it is being done... | 18:16 |
| mriedem | i've traced the code down in nova | 18:16 |
| mriedem | i can probably also just find it in some ci logs | 18:17 |
| rloo | mriedem: that'd be faster than me looking. if it is the name, i'd think it was a bug but i'm not that involved at the nova level. | 18:18 |
| mriedem | it's just really confusing because within nova we pass around the "nodename" | 18:18 |
| mriedem | which is a hostname for most driers | 18:18 |
| mriedem | *drivers | 18:18 |
| mriedem | but for ironic it's the uuid | 18:18 |
| mriedem | anyway, just trying to fix a mistake in our api ref and verifying that instance.node part of it is surprisingly difficult | 18:18 |
| mriedem | i guess is shouldn't actually be surprised | 18:19 |
| rloo | yup. to not being surprised. but we're only human :-) | 18:19 |
| rloo | in the nova/virt/ironic code, some of the docstrings refer to your 'nodename' as the UUID of the ironic node. | 18:20 |
| *** crushil has quit IRC | 18:21 | |
| *** crushil has joined #openstack-ironic | 18:21 | |
| rloo | mriedem: and the list of fields that we get from an ironic node doesn't include 'name'. but i didn't look through all the code to confirm that nothing slipped past. | 18:22 |
| mriedem | https://review.openstack.org/474723 | 18:23 |
| patchbot | patch 474723 - nova - api-ref: fix hypervisor_hostname description for I... | 18:23 |
| *** samodid has joined #openstack-ironic | 18:30 | |
| *** mgoddard has quit IRC | 18:42 | |
| *** mriedem has left #openstack-ironic | 18:46 | |
| *** Nisha_Agarwal has quit IRC | 18:47 | |
| openstackgerrit | Merged openstack/python-ironicclient master: Add OSC 'baremetal driver raid property list' cmd https://review.openstack.org/362047 | 18:52 |
| openstackgerrit | Merged openstack/python-ironicclient master: Update releasenote for osc-port-set https://review.openstack.org/474705 | 18:52 |
| jlvillal | rloo: Thanks for the comment. Not sure exactly what you want to be changed. Since the help message doesn't have style formatters. Do you want my slight wording change in the help text? | 19:02 |
| rloo | jlvillal: i just meant put the key words in some sort of quotation. | 19:02 |
| jlvillal | rloo: Ah. | 19:02 |
| jlvillal | Let me look | 19:03 |
| rloo | jlvillal: that seems more useful than the release notes :-) | 19:03 |
| *** rloo has quit IRC | 19:04 | |
| *** rloo has joined #openstack-ironic | 19:04 | |
| *** ijw has quit IRC | 19:05 | |
| *** jaosorior is now known as jaosorior_away | 19:08 | |
| openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient master: Improve help text for --local-link-connection https://review.openstack.org/474732 | 19:10 |
| jlvillal | rloo: ^^^ | 19:10 |
| openstackgerrit | Michael Turek proposed openstack/ironic master: Fail if boot_from_volume enabled but not ipxe https://review.openstack.org/472856 | 19:20 |
| *** trown|lunch is now known as trown | 19:22 | |
| *** Sukhdev has joined #openstack-ironic | 19:26 | |
| openstackgerrit | Michael Turek proposed openstack/ironic master: Move _abort_attach_volumes functionality to detach_volumes https://review.openstack.org/467766 | 19:27 |
| openstackgerrit | Peter Piela proposed openstack/ironic-ui master: Refactor BasePortController https://review.openstack.org/474741 | 19:33 |
| *** vinsh has quit IRC | 19:36 | |
| *** [1]rpioso has joined #openstack-ironic | 19:40 | |
| *** rpioso has quit IRC | 19:43 | |
| *** mtanino_ has joined #openstack-ironic | 19:44 | |
| *** jcoufal_ has joined #openstack-ironic | 19:44 | |
| *** mtanino_ is now known as mtanino | 19:46 | |
| *** jcoufal has quit IRC | 19:47 | |
| *** dprince has quit IRC | 19:50 | |
| *** jcoufal has joined #openstack-ironic | 20:14 | |
| *** jcoufal_ has quit IRC | 20:17 | |
| *** jkilpatr has quit IRC | 20:18 | |
| rloo | hi, looks like vasyl and i have been the ones reviewing this recently. does anyone else plan to do so? otherwise I'll +A: https://review.openstack.org/#/c/469932/ | 20:18 |
| patchbot | patch 469932 - ironic - Validate portgroup physical network consistency | 20:18 |
| *** jcoufal_ has joined #openstack-ironic | 20:21 | |
| *** jcoufal has quit IRC | 20:23 | |
| jlvillal | TheJulia: I'm a little confused on your comment for: https://review.openstack.org/#/c/406290/37..38/ironic/conductor/utils.py | 20:38 |
| patchbot | patch 406290 - ironic - Wire in storage interface attach/detach operations | 20:38 |
| *** fragatina has joined #openstack-ironic | 20:39 | |
| jlvillal | TheJulia: I guess I'm confused on why the "allow_errors=True" got removed. | 20:40 |
| *** crushil has quit IRC | 20:42 | |
| *** samodid has quit IRC | 20:43 | |
| *** crushil has joined #openstack-ironic | 20:43 | |
| *** crushil has quit IRC | 20:49 | |
| *** baoli has quit IRC | 20:50 | |
| *** crushil has joined #openstack-ironic | 20:51 | |
| *** fragatina has quit IRC | 20:51 | |
| *** hamzy has quit IRC | 20:58 | |
| *** trown is now known as trown|lunch | 20:58 | |
| *** jkilpatr has joined #openstack-ironic | 20:59 | |
| TheJulia | jlvillal: because it is not an actual thing for the storage interface | 21:11 |
| jlvillal | TheJulia: I commented in the patch. Let me know if I am crazy :) | 21:11 |
| TheJulia | jlvillal: will I be sad and cry? | 21:12 |
| jlvillal | TheJulia: No, based on the and statement ;) | 21:12 |
| TheJulia | jlvillal: are they actually re-raising in utils? | 21:13 |
| jlvillal | TheJulia: Most of the generic exception catching seems to do it. | 21:14 |
| TheJulia | jlvillal: I glanced earlier, and had it set to StorageError, and then decided to pattern after the surrounding code. Also, it is not a "OMG the world is exploding" error/exception | 21:14 |
| * jlvillal has an aversion to "except Exception" | 21:14 | |
| * TheJulia has same aversion | 21:14 | |
| jlvillal | https://github.com/openstack/ironic/blob/master/ironic/conductor/utils.py#L122-L123 | 21:15 |
| jlvillal | https://github.com/openstack/ironic/blob/master/ironic/conductor/utils.py#L180-L181 | 21:15 |
| * TheJulia changes the exception | 21:15 | |
| jlvillal | The outlier: https://github.com/openstack/ironic/blob/master/ironic/conductor/utils.py#L225 | 21:16 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Wire in storage interface attach/detach operations https://review.openstack.org/406290 | 21:18 |
| TheJulia | I though I looked at a couple, but $TOOMANYTHINGS | 21:19 |
| TheJulia | jlvillal: ^^^^^^ updated | 21:19 |
| jlvillal | TheJulia: Thanks | 21:20 |
| TheJulia | jlvillal: no problem, thank you! | 21:20 |
| jlvillal | TheJulia: +2, but likely someone else will come along and find something to -1 about ;) | 21:21 |
| * jlvillal realizes his effectiveness goes down each time he reviews the same patch... | 21:22 | |
| *** oanson has quit IRC | 21:23 | |
| TheJulia | jlvillal: I'll cry with additional -1's, although child revisions have positive feedback thus far | 21:23 |
| *** oanson has joined #openstack-ironic | 21:26 | |
| *** Goneri has quit IRC | 21:29 | |
| *** adisky__ has quit IRC | 21:34 | |
| *** rpioso has joined #openstack-ironic | 21:36 | |
| *** paramite has quit IRC | 21:40 | |
| *** fragatina has joined #openstack-ironic | 21:41 | |
| *** [1]rpioso has quit IRC | 21:41 | |
| *** yolanda has quit IRC | 21:45 | |
| *** vinsh has joined #openstack-ironic | 21:51 | |
| openstackgerrit | Merged openstack/bifrost master: Updated from global requirements https://review.openstack.org/474627 | 21:56 |
| rloo | jlvillal: wrt https://review.openstack.org/#/c/469932/, you really want those paren? | 22:00 |
| patchbot | patch 469932 - ironic - Validate portgroup physical network consistency | 22:00 |
| *** jcoufal has joined #openstack-ironic | 22:00 | |
| jlvillal | rloo: I want them, but okay to go in without them. | 22:01 |
| rloo | jlvillal: you want to just edit that file? | 22:01 |
| rloo | jlvillal: it is ok, i'll edit and then +A | 22:02 |
| jlvillal | rloo: I can do the edit if you like | 22:02 |
| *** jcoufal_ has quit IRC | 22:02 | |
| rloo | either is fine, go ahead :-) | 22:02 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic master: Validate portgroup physical network consistency https://review.openstack.org/469932 | 22:03 |
| jlvillal | rloo: ^^^ | 22:03 |
| jlvillal | rloo: I think it did it correctly :) https://review.openstack.org/#/c/469932/6..7/ironic/conductor/utils.py | 22:03 |
| patchbot | patch 469932 - ironic - Validate portgroup physical network consistency | 22:03 |
| jlvillal | s/it did/I did/ | 22:04 |
| rloo | jlvillal: looks right. thx. | 22:04 |
| *** ijw has joined #openstack-ironic | 22:04 | |
| jlvillal | rloo: Thank you | 22:05 |
| rloo | jlvillal: :) | 22:06 |
| *** fragatina has quit IRC | 22:08 | |
| rloo | jlvillal: wrt where this test file is: https://review.openstack.org/#/c/408556/52/ironic/tests/unit/db/test_api.py | 22:13 |
| patchbot | patch 408556 - ironic - Add new dbsync command with first online data migr... | 22:13 |
| rloo | jlvillal: i think i just followed what was there already. | 22:13 |
| jlvillal | rloo: Yeah. It has always confused me why it is setup like that. | 22:13 |
| *** deadnull has joined #openstack-ironic | 22:14 | |
| rloo | jlvillal: i don't know that it is confusing. there was no rule in the beginning about hwere things should live. | 22:14 |
| jlvillal | rloo: I'm not sure if I have ever heard a good reason for it. | 22:14 |
| rloo | jlvillal: it just isn't consistent now | 22:14 |
| rloo | jlvillal: i mean, there is still no rule. | 22:14 |
| rloo | jlvillal: we are busy with stuff; that's one thing that hasn't been a high priority. in the big scheme of things. | 22:14 |
| jlvillal | rloo: Well I expect the unit test file's directory location to match up with what it is testing. | 22:14 |
| rloo | jlvillal: i know what you expect, that is clear :-) | 22:15 |
| jlvillal | rloo: So that is why I find it confusing when it isn't | 22:15 |
| jlvillal | :D | 22:15 |
| rloo | jlvillal: i understand that. i'm just going 'with the flow' though, to be consistent with what is there already. | 22:15 |
| jlvillal | rloo: Makes sense. | 22:15 |
| jlvillal | rloo: I hope to finish reviewing that patch today. | 22:15 |
| jlvillal | rloo: So far it looks good | 22:16 |
| rloo | jlvillal: thx. | 22:16 |
| rloo | one thing bothers me about that, maybe i should mention it somewhere. it doesn't conform to the way nova does it. | 22:16 |
| rloo | but i don't know if folks care. and i never got around to asking why it was coded this way. | 22:16 |
| rloo | but it makes more sense this way, than nova's way. so... | 22:17 |
| jlvillal | rloo: How does nova do it? | 22:19 |
| rloo | jlvillal: the 'total' that nova uses is the 'total' for the particular 'batch' that is being done. whereas in ironic, the 'total' is the total number that needs to be done, regardless of the batch-amount of the particular command instance. | 22:20 |
| rloo | jlvillal: and nova spits out some sort of table in its output. i don't recall the details now. | 22:20 |
| jlvillal | Ah, okay. | 22:20 |
| rloo | jlvillal: couldn't find any doc on nova side, was based on looking at nova code. | 22:21 |
| rloo | jlvillal: and i wasn't sure if we wanted to diverge from nova's way or not. so i kept it functionally the way xek had written it. | 22:21 |
| jlvillal | rloo: I'll trust you :) | 22:22 |
| rloo | jlvillal: heh. i don't feel strongly about it one way or the other which is why i didn't spend more time on it. | 22:23 |
| *** jkilpatr has quit IRC | 22:24 | |
| *** jcoufal has quit IRC | 22:24 | |
| rloo | jlvillal: thx for reviewing today; i'm off to dinner. | 22:26 |
| jlvillal | rloo: Bon appetit! | 22:26 |
| *** oanson has quit IRC | 22:38 | |
| *** oanson has joined #openstack-ironic | 22:39 | |
| *** deadnull has quit IRC | 22:54 | |
| *** ijw has quit IRC | 23:00 | |
| *** ijw has joined #openstack-ironic | 23:09 | |
| *** zzzeek has joined #openstack-ironic | 23:09 | |
| *** hoonetorg has quit IRC | 23:10 | |
| *** trown|lunch is now known as trown|outtypewww | 23:12 | |
| *** ijw has quit IRC | 23:13 | |
| *** Goneri has joined #openstack-ironic | 23:16 | |
| openstackgerrit | Peter Piela proposed openstack/ironic-ui master: Extend backend mock with port operations https://review.openstack.org/473539 | 23:19 |
| *** jkilpatr has joined #openstack-ironic | 23:43 | |
| *** rpioso has quit IRC | 23:45 | |
| *** root2 has quit IRC | 23:51 | |
| *** root2 has joined #openstack-ironic | 23:51 | |
| *** wrouesnel has quit IRC | 23:54 | |
| *** wrouesnel has joined #openstack-ironic | 23:55 | |
| *** crushil has quit IRC | 23:58 | |
| *** crushil has joined #openstack-ironic | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!