*** shobhar has quit IRC | 00:03 | |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Add new dbsync command with first online data migration https://review.openstack.org/408556 | 00:10 |
---|---|---|
openstackgerrit | Ruby Loo proposed openstack/ironic master: Unit test for checking cross-version migrations compatibility https://review.openstack.org/419993 | 00:12 |
*** rama_y has quit IRC | 00:15 | |
*** sasha2 has quit IRC | 00:47 | |
*** hoonetorg has quit IRC | 00:53 | |
*** litao__ has joined #openstack-ironic | 01:00 | |
*** rpioso has quit IRC | 01:03 | |
*** hoonetorg has joined #openstack-ironic | 01:05 | |
*** phuongnh has joined #openstack-ironic | 01:06 | |
*** SerenaFeng has joined #openstack-ironic | 01:06 | |
*** hoonetorg has quit IRC | 01:16 | |
*** hshiina has joined #openstack-ironic | 01:21 | |
openstackgerrit | Ruby Loo proposed openstack/ironic master: [POC|DNM|TEST] Add node.configdrive https://review.openstack.org/455811 | 01:24 |
*** hoonetorg has joined #openstack-ironic | 01:30 | |
*** bfournie has joined #openstack-ironic | 01:40 | |
*** tuanluong has joined #openstack-ironic | 01:43 | |
*** rloo has quit IRC | 01:43 | |
*** gcb has joined #openstack-ironic | 01:52 | |
*** joe817_ has joined #openstack-ironic | 02:32 | |
*** joe817 has quit IRC | 02:32 | |
*** baoli has joined #openstack-ironic | 02:38 | |
*** SerenaFeng has quit IRC | 02:57 | |
*** SerenaFeng has joined #openstack-ironic | 02:58 | |
*** jcoufal has quit IRC | 03:04 | |
*** adisky__ has joined #openstack-ironic | 03:17 | |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Modifications for rolling upgrades https://review.openstack.org/476779 | 03:19 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Add new dbsync command with first online data migration https://review.openstack.org/408556 | 03:21 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Unit test for checking cross-version migrations compatibility https://review.openstack.org/419993 | 03:21 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: [POC|DNM|TEST] Add node.configdrive https://review.openstack.org/455811 | 03:22 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Rolling upgrades support for port.physical_network https://review.openstack.org/477694 | 03:22 |
*** rbudden has quit IRC | 03:37 | |
*** links has joined #openstack-ironic | 03:42 | |
*** aparnav has joined #openstack-ironic | 03:52 | |
*** Dinesh_Bhor has joined #openstack-ironic | 04:02 | |
*** SerenaFeng has quit IRC | 04:03 | |
openstackgerrit | Hironori Shiina proposed openstack/ironic master: [DNM] Test grenade job with fleetifying nova conductor patch https://review.openstack.org/477738 | 04:07 |
*** amotoki_away is now known as amotoki | 04:10 | |
*** udesale has joined #openstack-ironic | 04:19 | |
*** baoli has quit IRC | 04:20 | |
*** joe817_ has quit IRC | 04:25 | |
*** joe817 has joined #openstack-ironic | 04:26 | |
*** jaganathan has joined #openstack-ironic | 04:53 | |
*** vmud213 has joined #openstack-ironic | 04:54 | |
*** udesale has quit IRC | 04:59 | |
*** udesale has joined #openstack-ironic | 05:01 | |
*** jaganathan has quit IRC | 05:01 | |
*** livelace has joined #openstack-ironic | 05:04 | |
openstackgerrit | Yushiro FURUKAWA proposed openstack/ironic master: Fix document for portgroup with ML2 driver support status https://review.openstack.org/459338 | 05:08 |
*** appu103 has joined #openstack-ironic | 05:09 | |
*** jmorgan1_ has joined #openstack-ironic | 05:10 | |
*** hw_wutianwei1 has joined #openstack-ironic | 05:11 | |
openstackgerrit | Yushiro FURUKAWA proposed openstack/ironic master: Remove future plan from portgroup document https://review.openstack.org/459338 | 05:11 |
*** jmorgan1 has quit IRC | 05:13 | |
*** aparnav has quit IRC | 05:13 | |
*** exodusftw has quit IRC | 05:13 | |
*** EmilienM has quit IRC | 05:13 | |
*** hw_wutianwei has quit IRC | 05:13 | |
*** honza has quit IRC | 05:13 | |
*** hw_wutianwei1 is now known as hw_wutianwei | 05:13 | |
*** honza has joined #openstack-ironic | 05:14 | |
*** honza is now known as Guest48689 | 05:15 | |
*** dansmith has quit IRC | 05:15 | |
*** dansmith has joined #openstack-ironic | 05:15 | |
*** dansmith is now known as Guest63234 | 05:15 | |
*** EmilienM has joined #openstack-ironic | 05:20 | |
*** exodusftw has joined #openstack-ironic | 05:21 | |
*** SerenaFeng has joined #openstack-ironic | 05:29 | |
*** mjura has joined #openstack-ironic | 05:35 | |
*** mjura has quit IRC | 05:35 | |
*** mjura__ has joined #openstack-ironic | 05:35 | |
*** oomichi_ has joined #openstack-ironic | 05:36 | |
*** ianw_ has joined #openstack-ironic | 05:36 | |
*** ChubYann has quit IRC | 05:38 | |
*** appu103 has quit IRC | 05:38 | |
*** mpotdar has quit IRC | 05:39 | |
*** oomichi has quit IRC | 05:39 | |
*** ianw has quit IRC | 05:39 | |
*** oomichi_ is now known as oomichi | 05:39 | |
*** ianw_ is now known as ianw | 05:39 | |
*** joanna has quit IRC | 05:39 | |
*** marios has joined #openstack-ironic | 05:39 | |
*** appu103 has joined #openstack-ironic | 05:39 | |
*** mpotdar has joined #openstack-ironic | 05:39 | |
*** eglute_s has quit IRC | 05:41 | |
*** joanna has joined #openstack-ironic | 05:41 | |
*** eglute has joined #openstack-ironic | 05:44 | |
*** SerenaFeng has quit IRC | 05:53 | |
*** SerenaFeng has joined #openstack-ironic | 05:53 | |
*** rcernin has joined #openstack-ironic | 05:55 | |
*** SerenaFeng has quit IRC | 06:02 | |
*** SerenaFeng has joined #openstack-ironic | 06:05 | |
*** hshiina has quit IRC | 06:06 | |
*** SerenaFeng has quit IRC | 06:20 | |
*** SerenaFeng has joined #openstack-ironic | 06:21 | |
*** rcernin has quit IRC | 06:26 | |
*** rama_y has joined #openstack-ironic | 06:27 | |
*** rcernin has joined #openstack-ironic | 06:32 | |
*** ccamacho has quit IRC | 06:32 | |
*** jaganathan has joined #openstack-ironic | 06:39 | |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Refactoring the firewall https://review.openstack.org/471831 | 06:44 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Introducing a dnsmasq PXE filter driver https://review.openstack.org/466448 | 06:44 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: TEST check dnsmasq PXE filter in devstack https://review.openstack.org/468712 | 06:44 |
*** tesseract has joined #openstack-ironic | 06:55 | |
*** aarefiev_afk is now known as aarefiev_pto | 07:07 | |
*** karthiks has joined #openstack-ironic | 07:31 | |
*** pcaruana has joined #openstack-ironic | 07:32 | |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Refactoring the firewall https://review.openstack.org/471831 | 07:38 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: PXE boot filtering drivers https://review.openstack.org/439603 | 07:38 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Introducing a dnsmasq PXE filter driver https://review.openstack.org/466448 | 07:38 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: TEST check dnsmasq PXE filter in devstack https://review.openstack.org/468712 | 07:38 |
*** hshiina has joined #openstack-ironic | 07:43 | |
*** SerenaFeng has quit IRC | 07:44 | |
*** appu103 has quit IRC | 07:44 | |
*** SerenaFeng has joined #openstack-ironic | 07:44 | |
*** appu103 has joined #openstack-ironic | 07:45 | |
*** appu103 has quit IRC | 07:48 | |
*** aparnav has joined #openstack-ironic | 07:48 | |
*** ralonsoh has joined #openstack-ironic | 07:49 | |
thaj | Good Morning | 07:49 |
*** litao__ has quit IRC | 07:50 | |
*** aparnav has quit IRC | 07:54 | |
*** gcb has quit IRC | 07:58 | |
*** gcb has joined #openstack-ironic | 07:58 | |
*** zzzeek has quit IRC | 08:00 | |
*** litao__ has joined #openstack-ironic | 08:01 | |
*** ccamacho has joined #openstack-ironic | 08:03 | |
*** zzzeek has joined #openstack-ironic | 08:03 | |
*** vmud213 has quit IRC | 08:04 | |
*** crushil has quit IRC | 08:07 | |
*** crushil has joined #openstack-ironic | 08:08 | |
*** crushil has quit IRC | 08:12 | |
*** e0ne has joined #openstack-ironic | 08:18 | |
*** racedo has joined #openstack-ironic | 08:18 | |
*** priteau has joined #openstack-ironic | 08:21 | |
*** e0ne has quit IRC | 08:21 | |
*** e0ne has joined #openstack-ironic | 08:25 | |
*** milan has joined #openstack-ironic | 08:35 | |
milan | morning Ironic! :) | 08:36 |
*** mgoddard has joined #openstack-ironic | 08:38 | |
*** rbartal has joined #openstack-ironic | 08:38 | |
*** _milan_ has joined #openstack-ironic | 08:38 | |
*** milan has quit IRC | 08:41 | |
*** derekh has joined #openstack-ironic | 08:42 | |
*** makowals has joined #openstack-ironic | 08:43 | |
*** aparnav has joined #openstack-ironic | 08:50 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Changes log level of a message https://review.openstack.org/476847 | 08:51 |
*** hshiina has quit IRC | 08:52 | |
*** vmud213 has joined #openstack-ironic | 08:54 | |
*** d0ugal has quit IRC | 08:58 | |
*** d0ugal_ has joined #openstack-ironic | 08:59 | |
*** d0ugal_ has quit IRC | 08:59 | |
*** d0ugal has joined #openstack-ironic | 08:59 | |
*** d0ugal has quit IRC | 08:59 | |
*** d0ugal has joined #openstack-ironic | 08:59 | |
tuanluong | morning ironic | 09:00 |
*** e0ne has quit IRC | 09:01 | |
*** e0ne has joined #openstack-ironic | 09:05 | |
openstackgerrit | Merged openstack/ironic-inspector master: add disabled option to VALID_ADD_PORTS_VALUES https://review.openstack.org/471156 | 09:08 |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: Adds clean step 'retore_irmc_bios_config' to iRMC drivers https://review.openstack.org/416403 | 09:19 |
*** Guest48689 is now known as honza | 09:22 | |
*** yee379 has joined #openstack-ironic | 09:24 | |
*** appu103 has joined #openstack-ironic | 09:25 | |
*** priteau_ has joined #openstack-ironic | 09:26 | |
*** slagle_ has joined #openstack-ironic | 09:30 | |
*** dnikisho1 has joined #openstack-ironic | 09:30 | |
*** jlvillal_ has joined #openstack-ironic | 09:33 | |
*** logan_ has joined #openstack-ironic | 09:33 | |
*** exoduswtf has joined #openstack-ironic | 09:34 | |
*** d0ugal has quit IRC | 09:34 | |
*** aparnav has quit IRC | 09:34 | |
*** rbartal has quit IRC | 09:34 | |
*** priteau has quit IRC | 09:34 | |
*** exodusftw has quit IRC | 09:34 | |
*** hoonetorg has quit IRC | 09:34 | |
*** dsneddon has quit IRC | 09:34 | |
*** ElCoyote_ has quit IRC | 09:34 | |
*** mrtenio has quit IRC | 09:34 | |
*** yee37924 has quit IRC | 09:34 | |
*** dnikishov has quit IRC | 09:34 | |
*** logan- has quit IRC | 09:34 | |
*** slagle has quit IRC | 09:34 | |
*** mgagne has quit IRC | 09:35 | |
*** jlvillal has quit IRC | 09:35 | |
*** dtantsur|afk is now known as dtantsur | 09:35 | |
dtantsur | morning ironic | 09:35 |
openstackgerrit | Debayan Ray proposed openstack/proliantutils master: Redfish: Add secure boot API support https://review.openstack.org/472244 | 09:35 |
*** jlvillal_ is now known as jlvillal | 09:36 | |
*** jlvillal is now known as Guest60319 | 09:37 | |
*** mgagne has joined #openstack-ironic | 09:37 | |
*** mgagne is now known as Guest28796 | 09:37 | |
*** logan_ is now known as logan- | 09:37 | |
*** mkovacik__ has joined #openstack-ironic | 09:39 | |
*** mrtenio has joined #openstack-ironic | 09:40 | |
*** ElCoyote_ has joined #openstack-ironic | 09:40 | |
*** mkovacik__ is now known as milan | 09:40 | |
*** d0ugal has joined #openstack-ironic | 09:40 | |
*** rbartal has joined #openstack-ironic | 09:41 | |
*** hoonetorg has joined #openstack-ironic | 09:41 | |
*** priteau_ has quit IRC | 09:41 | |
*** _milan_ has quit IRC | 09:41 | |
*** priteau has joined #openstack-ironic | 09:42 | |
*** amarao has joined #openstack-ironic | 09:42 | |
sambetts | Morning all | 09:44 |
milan | morning sambetts! :) | 09:45 |
openstackgerrit | Mark Goddard proposed openstack/ironic master: Fix VIF list for noop network interface https://review.openstack.org/477493 | 09:45 |
*** chlong has joined #openstack-ironic | 09:46 | |
milan | morning dtantsur! :) | 09:47 |
dtantsur | o/ | 09:49 |
sambetts | hey milan, dtantsur | 09:49 |
milan | dtantsur, sambetts, pxe filter review time? O:-) | 09:49 |
dtantsur | folks, does anyone know where we are with the potential grenade breakage? | 09:49 |
dtantsur | milan: need to sync on ^^^ first | 09:50 |
milan | dtantsur, I see, yeah | 09:50 |
*** SerenaFeng has quit IRC | 09:50 | |
milan | dtantsur, inspector gate seems passing (just done couple of rechecks) | 09:50 |
*** SerenaFeng has joined #openstack-ironic | 09:50 | |
milan | but last issue I remember was (not) sourcing the nova stuff | 09:51 |
openstackgerrit | Anshul Jain proposed openstack/proliantutils master: Adds 'update_firmware' APIs support through redfish https://review.openstack.org/472532 | 09:51 |
dtantsur | milan: yes, because the devstack patch was reverted | 09:51 |
milan | so what's the plan? | 09:51 |
dtantsur | but it will land again, I guess | 09:51 |
milan | yeah | 09:51 |
milan | exactly | 09:51 |
dtantsur | I think our bet is on https://review.openstack.org/#/c/477313/ now | 09:51 |
patchbot | patch 477313 - ironic - Set nomulticell flag for starting nova-compute in ... | 09:51 |
* milan checks | 09:51 | |
milan | dtantsur, I'm wondering: should we also source the lib/rpc_backend? | 09:54 |
milan | vdrok 's comment on that patch | 09:54 |
milan | hey vdrok! :) | 09:54 |
*** priteau has quit IRC | 09:55 | |
milan | the glance thing seems landed https://review.openstack.org/#/c/476498/ | 09:58 |
patchbot | patch 476498 - ironic - Fetch Glance endpoint from Keystone if it's not pr... (MERGED) | 09:58 |
mgoddard | morning folks | 10:01 |
dtantsur | morning mgoddard | 10:02 |
milan | morning mgoddard! :) | 10:06 |
sambetts | dtantsur: looking at my power state retry patch, do you think I need to add a deprecation period for the existing IPMI timeout configuration option? its a weird one because the config option still needs to exist for its actual useage, retrys on failed IPMI commands, but not for the power status loop | 10:07 |
dtantsur | sambetts: I thought we still use it for power status too, no? | 10:08 |
dtantsur | via PowerInterface.power_retry_something? | 10:08 |
sambetts | dtantsur: yeah, just wondering if it was nessesary, because it makes adding the new config options a little messy, i.e. I can't decide if the new config option should take priority over that option | 10:09 |
sambetts | if set | 10:09 |
dtantsur | sambetts: fair. I think the right course may be to add a new option that only works for failed IPMI commands, and deprecate the existing one in favor of it | 10:09 |
dtantsur | sambetts: thus, the existing option will behave the same as before, but the new one will not affect power (we need to make it clear in the reno) | 10:10 |
*** SerenaFeng has quit IRC | 10:10 | |
*** crushil has joined #openstack-ironic | 10:10 | |
sambetts | hmmm, so we set the existing option to default to None, and then add the new option with the default for the retrys, and then do timeout = CONF.existing_option or CONF.new_option? | 10:15 |
*** oanson has quit IRC | 10:15 | |
sambetts | during the deprecation period? | 10:15 |
*** oanson has joined #openstack-ironic | 10:16 | |
dtantsur | sambetts: for power it should be CONF.ipmi.existing_option or CONF.new_driver_independent_option. for failed commands it will be CONF.ipmi.new_option or CONF.ipmi.existing_option | 10:17 |
sambetts | yup yup that sounds good | 10:17 |
*** priteau has joined #openstack-ironic | 10:20 | |
*** milan has quit IRC | 10:23 | |
*** phuongnh has quit IRC | 10:28 | |
*** amotoki is now known as amotoki_away | 10:46 | |
*** mvpnitesh has joined #openstack-ironic | 10:51 | |
*** amotoki_away is now known as amotoki | 10:51 | |
*** marios has quit IRC | 10:55 | |
*** SerenaFeng has joined #openstack-ironic | 10:55 | |
*** jkilpatr has joined #openstack-ironic | 10:57 | |
*** makowals has quit IRC | 11:00 | |
*** amotoki is now known as amotoki_away | 11:01 | |
openstackgerrit | Merged openstack/bifrost master: scripts: install-deps: Enable the EPEL repo when running in OpenStack CI https://review.openstack.org/476868 | 11:01 |
*** makowals has joined #openstack-ironic | 11:01 | |
openstackgerrit | Merged openstack/bifrost master: Added the py35 env https://review.openstack.org/477364 | 11:01 |
openstackgerrit | Aparna proposed openstack/proliantutils master: Adds manager support for redfish API's. https://review.openstack.org/473719 | 11:02 |
openstackgerrit | Aparna proposed openstack/proliantutils master: Redfish: Add support for Virtual Media Operations https://review.openstack.org/473798 | 11:02 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-ui master: Imported Translations from Zanata https://review.openstack.org/477886 | 11:03 |
*** chlong_ has joined #openstack-ironic | 11:04 | |
*** chlong has quit IRC | 11:04 | |
openstackgerrit | Debayan Ray proposed openstack/proliantutils master: Redfish: Add secure boot API support https://review.openstack.org/472244 | 11:07 |
openstackgerrit | iswarya vakati proposed openstack/ironic master: Add python 3.5 in classifier and envlist https://review.openstack.org/477890 | 11:09 |
openstackgerrit | Sam Betts proposed openstack/ironic master: Don't retry power status if power action fails https://review.openstack.org/449454 | 11:13 |
*** johnthetubaguy has quit IRC | 11:16 | |
*** johnthetubaguy has joined #openstack-ironic | 11:18 | |
*** mvpnitesh has left #openstack-ironic | 11:21 | |
*** mvpnitesh has joined #openstack-ironic | 11:22 | |
*** bfournie has quit IRC | 11:46 | |
openstackgerrit | Aparna proposed openstack/ironic master: Adds functionality test for erase_devices https://review.openstack.org/472558 | 11:48 |
*** litao__ has quit IRC | 11:50 | |
*** rbudden has joined #openstack-ironic | 11:54 | |
*** tuanluong has quit IRC | 12:03 | |
*** gcb has quit IRC | 12:04 | |
*** amotoki_away is now known as amotoki | 12:07 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/bifrost master: Updated from global requirements https://review.openstack.org/477913 | 12:08 |
*** dnikisho1 has quit IRC | 12:09 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic master: Updated from global requirements https://review.openstack.org/477936 | 12:10 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector master: Updated from global requirements https://review.openstack.org/477937 | 12:11 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib master: Updated from global requirements https://review.openstack.org/477938 | 12:11 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent master: Updated from global requirements https://review.openstack.org/477940 | 12:11 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-ui master: Updated from global requirements https://review.openstack.org/477941 | 12:11 |
*** racedo has quit IRC | 12:13 | |
*** racedo has joined #openstack-ironic | 12:14 | |
*** marios has joined #openstack-ironic | 12:14 | |
*** SerenaFeng has quit IRC | 12:16 | |
*** bfournie has joined #openstack-ironic | 12:17 | |
openstackgerrit | Merged openstack/ironic-inspector stable/ocata: grenade: Only 'enable_plugin ironic-inspector' if not already in conf https://review.openstack.org/476725 | 12:20 |
fellypefca | Morning, Ironic :) | 12:21 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironic-inspector-client master: Updated from global requirements https://review.openstack.org/478075 | 12:21 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient master: Updated from global requirements https://review.openstack.org/478076 | 12:21 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-oneviewclient master: Updated from global requirements https://review.openstack.org/478085 | 12:22 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/sushy master: Updated from global requirements https://review.openstack.org/478110 | 12:23 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/virtualbmc master: Updated from global requirements https://review.openstack.org/478121 | 12:24 |
*** aparnav has joined #openstack-ironic | 12:27 | |
dtantsur | morning fellypefca | 12:27 |
dtantsur | oh, the bot has been busy today :D | 12:27 |
*** jcoufal has joined #openstack-ironic | 12:27 | |
*** SerenaFeng has joined #openstack-ironic | 12:28 | |
*** appu103 has quit IRC | 12:29 | |
*** lifeless has quit IRC | 12:30 | |
*** aparnav has quit IRC | 12:32 | |
*** mvpnitesh has quit IRC | 12:34 | |
*** mvpnitesh has joined #openstack-ironic | 12:35 | |
fellypefca | dtantsur Hi! Just a little doubt. Ruby Loo posted in one of my patches that before being merged, the RFE should be approved. So I need to talk to one of the Cores that gave +2 in my patch to approve this RFE? | 12:36 |
*** xavierr has quit IRC | 12:37 | |
*** vmud213 has quit IRC | 12:37 | |
dtantsur | fellypefca: not necessary that specific cores. generally, we need a few cores to agree with it to approve (unless somebody asks for a spec). | 12:37 |
dtantsur | we also have a section on the meeting for RFE reviews | 12:37 |
*** SerenaFeng has quit IRC | 12:38 | |
*** milan has joined #openstack-ironic | 12:38 | |
fellypefca | dtantsur Oh, I didn't know this :/ So I can only ask to approve this RFE during the Meeting? | 12:40 |
dtantsur | fellypefca: well, you can catch a few cores in this channel and ask them :) | 12:41 |
dtantsur | but the preferred way is during the meeting. | 12:41 |
dtantsur | So, what's the RFE in question? | 12:41 |
fellypefca | This one here: https://bugs.launchpad.net/ironic/+bug/1666497 | 12:42 |
openstack | Launchpad bug 1666497 in Ironic "[RFE] Onetime boot feature in OneView drivers" [Low,In progress] - Assigned to Fellype Cavalcante (fellypefca) | 12:42 |
*** lifeless has joined #openstack-ironic | 12:43 | |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Refactoring the firewall https://review.openstack.org/471831 | 12:46 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Introducing a dnsmasq PXE filter driver https://review.openstack.org/466448 | 12:46 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: TEST check dnsmasq PXE filter in devstack https://review.openstack.org/468712 | 12:46 |
dtantsur | fellypefca: as you know, I have certain concerns about this feature. so I suspect you may want to ask someone else first ;) | 12:48 |
fellypefca | Oh :/ thats ok. Thank you, dtantsur. I'll talk to vdrok and TheJulia when they're around here. | 12:51 |
*** bcornec1 has joined #openstack-ironic | 12:56 | |
*** e0ne has quit IRC | 12:56 | |
*** dyasny has joined #openstack-ironic | 12:57 | |
openstackgerrit | Merged openstack/ironic master: Add docs for node.resource_class and flavor creation https://review.openstack.org/345081 | 13:00 |
*** sasha21 has joined #openstack-ironic | 13:02 | |
*** e0ne has joined #openstack-ironic | 13:04 | |
TheJulia | dtantsur: fellypefca: I'm all for it knowing too much about the interaction with oneview | 13:06 |
*** rloo has joined #openstack-ironic | 13:07 | |
sambetts | TheJulia, dtantsur: I'm leaving a comment on the bug, there is some significant ickyness with the code as it is toda | 13:07 |
sambetts | today | 13:07 |
*** baoli has joined #openstack-ironic | 13:07 | |
* TheJulia signs and grumbles privately | 13:08 | |
sambetts | qq, do we expect nodes to not have managemnt interfaces today? | 13:08 |
sambetts | or put better, to be able to not have a management interface | 13:08 |
sambetts | ? | 13:08 |
rloo | sambetts: the 'only' thing that might be useful from mgt is 'set_boot_device'. i guess if that isn't needed, then maybe not. i mean, if the code insists, we could change it. | 13:09 |
rloo | and hi and good morning sambetts! | 13:10 |
sambetts | rloo: basically I'm questioning the need for the existence of this help function | 13:10 |
sambetts | https://github.com/openstack/ironic/blob/master/ironic/conductor/utils.py#L44 | 13:10 |
rloo | sambetts: if we coded it right, the only two interfaces needed are deploy and power | 13:10 |
rloo | sambetts: now i'm afraid i'm being drawn into a bigger hole... | 13:11 |
sambetts | turtles all the way down | 13:11 |
rloo | sambetts: cuz i can't answer that question w/o spending minutes thinking/looking/refreshing my memory and i need to focus... :) | 13:11 |
TheJulia | sambetts: turtles and power controlled peanut butter all the way down | 13:13 |
sambetts | TheJulia: left my comments here: | 13:14 |
sambetts | https://bugs.launchpad.net/ironic/+bug/1666497 | 13:15 |
openstack | Launchpad bug 1666497 in Ironic "[RFE] Onetime boot feature in OneView drivers" [Low,In progress] - Assigned to Fellype Cavalcante (fellypefca) | 13:15 |
* TheJulia drives a 30,000 vehicle in for its yearly inspection | 13:15 | |
TheJulia | Err, 30,000 pound | 13:15 |
sambetts | see my brain just went £30,000 thats like the price of a mid/high range car | 13:16 |
*** dyasny has quit IRC | 13:16 | |
sambetts | then it clicks that you are refering to 'merican weighs XD | 13:16 |
*** dyasny has joined #openstack-ironic | 13:16 | |
* TheJulia turns up the KMFDM and begins the battle of getting out of the driveway | 13:17 | |
rloo | sambetts, vdrok: I'm surprised there isn't a bug associated with this nova-ironic-virt patch: https://review.openstack.org/#/c/419975/ (not that i care) | 13:24 |
patchbot | patch 419975 - nova - Implement interface attach/detach in ironic virt d... | 13:24 |
rloo | sambetts, vdrok: forget it, i see the 'Implements' line... | 13:24 |
sambetts | no problem :) | 13:24 |
*** Guest63234 is now known as dansmith | 13:28 | |
*** dansmith is now known as Guest19168 | 13:29 | |
fellypefca | sambetts: So, there is something that I can do or wait for what vdrok has to say about RFE? | 13:30 |
*** e0ne has quit IRC | 13:33 | |
*** e0ne has joined #openstack-ironic | 13:35 | |
*** e0ne has quit IRC | 13:37 | |
*** mjturek has joined #openstack-ironic | 13:37 | |
*** dtantsur is now known as dtantsur|brb | 13:41 | |
*** mjturek has quit IRC | 13:41 | |
*** e0ne has joined #openstack-ironic | 13:44 | |
*** rbartal has quit IRC | 13:46 | |
*** udesale has quit IRC | 13:49 | |
openstackgerrit | Peter Piela proposed openstack/ironic-ui master: Set current boot device on a node https://review.openstack.org/473926 | 13:55 |
*** e0ne has quit IRC | 13:56 | |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Refactoring the firewall https://review.openstack.org/471831 | 13:56 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: PXE boot filtering drivers https://review.openstack.org/439603 | 13:56 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Introducing a dnsmasq PXE filter driver https://review.openstack.org/466448 | 13:56 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: TEST check dnsmasq PXE filter in devstack https://review.openstack.org/468712 | 13:56 |
*** mjturek has joined #openstack-ironic | 13:58 | |
openstackgerrit | Merged openstack/virtualbmc master: Updated from global requirements https://review.openstack.org/478121 | 13:59 |
*** mikal has quit IRC | 14:00 | |
*** slagle_ is now known as slagle | 14:01 | |
*** cdearborn has joined #openstack-ironic | 14:01 | |
*** mrtenio has quit IRC | 14:01 | |
*** mikal has joined #openstack-ironic | 14:02 | |
*** e0ne has joined #openstack-ironic | 14:04 | |
*** mvpnitesh has quit IRC | 14:04 | |
*** crushil has quit IRC | 14:16 | |
*** crushil has joined #openstack-ironic | 14:17 | |
*** mrtenio has joined #openstack-ironic | 14:23 | |
milan | sambetts, thanks for the review! :D | 14:28 |
* milan will update the docs as suggested | 14:28 | |
milan | once I figure out why the hack iptables is not mocked further in the chain :-/ | 14:28 |
milan | hack :D yeah | 14:29 |
*** larivee has joined #openstack-ironic | 14:29 | |
*** Guest19168 is now known as dansmith | 14:31 | |
larivee | Hi, can't find doc on using the IPA api to send it commands ( /v1/commands ) I want to list the drive size it sees | 14:32 |
*** d0ugal has quit IRC | 14:32 | |
*** d0ugal has joined #openstack-ironic | 14:32 | |
*** d0ugal has quit IRC | 14:32 | |
*** d0ugal has joined #openstack-ironic | 14:32 | |
*** skazi__ has joined #openstack-ironic | 14:34 | |
*** cdearborn_ has joined #openstack-ironic | 14:41 | |
*** shvepsy has joined #openstack-ironic | 14:47 | |
*** cdearborn has quit IRC | 14:47 | |
*** rama_y has quit IRC | 14:50 | |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Refactoring the firewall https://review.openstack.org/471831 | 14:57 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Introducing a dnsmasq PXE filter driver https://review.openstack.org/466448 | 14:57 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: TEST check dnsmasq PXE filter in devstack https://review.openstack.org/468712 | 14:57 |
*** cdearborn_ has quit IRC | 14:59 | |
*** mjura__ has quit IRC | 15:00 | |
*** Guest60319 is now known as jlvillal | 15:04 | |
*** rcernin has quit IRC | 15:04 | |
jlvillal | Good morning Ironic | 15:04 |
*** links has quit IRC | 15:05 | |
jlvillal | vdrok, Any updates on the grenade issue and the proposed nova patch for devstack? | 15:05 |
*** dtantsur|brb is now known as dtantsur | 15:05 | |
dtantsur | morning jlvillal | 15:06 |
jlvillal | Hi dtantsur :) | 15:06 |
vdrok | jlvillal: on a sick leave today, so not really. Could not figure out why the old files are sourced instead of new yesterday. | 15:07 |
jlvillal | vdrok, Ouch. Get better and get some rest! | 15:07 |
dtantsur | vdrok: feel better, and please /leave all work channels ;) | 15:08 |
rloo | morning jlvillal. BYE vdrok :) | 15:08 |
jlvillal | :) | 15:08 |
* jlvillal gets ready to go to work location | 15:09 | |
vdrok | Thx all :) | 15:09 |
openstackgerrit | Merged openstack/ironic-ui master: Updated from global requirements https://review.openstack.org/477941 | 15:10 |
*** skazi__ has quit IRC | 15:10 | |
milan | lol | 15:11 |
openstackgerrit | Merged openstack/ironic-ui master: Imported Translations from Zanata https://review.openstack.org/477886 | 15:11 |
*** milan has quit IRC | 15:13 | |
*** skazi__ has joined #openstack-ironic | 15:13 | |
*** cdearborn has joined #openstack-ironic | 15:16 | |
openstackgerrit | Debayan Ray proposed openstack/proliantutils master: Redfish: Add secure boot API support https://review.openstack.org/472244 | 15:17 |
*** deray has joined #openstack-ironic | 15:21 | |
deray | good morning all Ironic'ers! | 15:25 |
*** rama_y has joined #openstack-ironic | 15:26 | |
deray | could somebody have time to bless this -> https://review.openstack.org/#/c/441236/ ? it's been waiting for some time now | 15:27 |
patchbot | patch 441236 - sushy - Add manager resource | 15:27 |
dtantsur | deray: morning. slowly, slowly, I'm getting there :) | 15:28 |
dtantsur | it | 15:28 |
dtantsur | it's been really busy time recently | 15:28 |
deray | dtantsur, I have already got ur blessing on this :) | 15:29 |
dtantsur | oh, really? lol, ok | 15:29 |
* dtantsur shows first signs of overworking, not good | 15:29 | |
deray | sambetts, hi .. have looked into ur comment on https://review.openstack.org/#/c/346683/ | 15:30 |
patchbot | patch 346683 - ironic - Refresh firmware versions on firmware update | 15:30 |
deray | sambetts, these days little busy with so many non-ironic stuff as well. So didn't get time to acknowledge you. Am also working on that CI | 15:31 |
deray | dtantsur, yeah with the code freeze nearing, it will happen so often for you. Hope you can cope up, as usually | 15:32 |
dtantsur | oh, the freeze | 15:33 |
*** vinsh has joined #openstack-ironic | 15:33 | |
dtantsur | deray: this is a good point. for non-client libraries the freeze is on July 21st. This is not far indeed. | 15:34 |
dtantsur | deray: both lucas-afk and vdrok are out today though. we need a new victim for sushy reviews ;) | 15:34 |
deray | dtantsur, ya .. me also hoping that this time don't bombard you with multiple requests of extending that code freeze deadline :) | 15:35 |
NobodyCam | Good Morning Ironic'ers | 15:35 |
dtantsur | deray: I personally have nothing to do with this particular deadline, it's imposed by the release team. they're unlikely to give any exceptions. | 15:37 |
dtantsur | morning NobodyCam | 15:37 |
deray | dtantsur, about sushy: TheJulia was also one of those review victims ;) what say, TheJulia? | 15:37 |
deray | dtantsur, agree | 15:37 |
NobodyCam | :) Morning dtantsur :) | 15:37 |
deray | NobodyCam, g'morning | 15:37 |
NobodyCam | good morning delay :) | 15:38 |
deray | and morning to all others :) | 15:38 |
*** skazi__ has quit IRC | 15:39 | |
deray | TheJulia, time for this -> https://review.openstack.org/#/c/441236/ ? probably a low hanging one ;) | 15:39 |
patchbot | patch 441236 - sushy - Add manager resource | 15:40 |
deray | NobodyCam, o/ | 15:40 |
rama_y | Good morning to all. | 15:40 |
deray | rama_y, g'morning o/ | 15:40 |
rama_y | good morning deray! | 15:41 |
*** mgoddard has quit IRC | 15:42 | |
deray | dtantsur, just fyi .. we are using sushy as a dependent lib in proliantutils to do stuff related to Redfish | 15:43 |
deray | hence some of those outstanding reviews on sushy are turning out to be so important for us. | 15:44 |
deray | dtantsur, https://github.com/openstack/proliantutils/blob/master/requirements.txt#L12 | 15:45 |
dtantsur | yep, I get it | 15:45 |
TheJulia | deray: I can take a look at sushy this afternoob | 15:53 |
TheJulia | Afternoon | 15:53 |
TheJulia | My morning I has been effectively derailed :( | 15:53 |
* dtantsur tries to imagine a meaning of afternoob :) | 15:53 | |
* dtantsur hands TheJulia a huge cup of coffee | 15:53 | |
deray | TheJulia, so good of you :) | 15:53 |
*** deray is now known as deray-afk | 15:55 | |
NobodyCam | morning rama_y, TheJulia :) | 15:58 |
rama_y | morning NobyCam, TheJulia and dtantsur! | 15:59 |
dtantsur | o/ | 15:59 |
NobodyCam | :) | 15:59 |
*** hamzy has quit IRC | 16:00 | |
*** links has joined #openstack-ironic | 16:02 | |
TheJulia | dtantsur: that is what I'm missing! Coffee! | 16:03 |
dtantsur | !! | 16:04 |
openstack | dtantsur: Error: "!" is not a valid command. | 16:04 |
dtantsur | openstack: I knew you're going to say that :) | 16:04 |
*** chlong has joined #openstack-ironic | 16:05 | |
*** chlong has quit IRC | 16:05 | |
*** pcaruana has quit IRC | 16:09 | |
*** jaganathan has quit IRC | 16:11 | |
*** ccamacho has quit IRC | 16:13 | |
*** mgoddard has joined #openstack-ironic | 16:20 | |
*** marios has quit IRC | 16:20 | |
* jlvillal didn't know that and know wonders what commands it knows | 16:22 | |
jlvillal | s/know wonders/now wonders/ | 16:22 |
*** srart has quit IRC | 16:23 | |
*** deray-afk is now known as deray | 16:25 | |
*** ralonsoh has quit IRC | 16:27 | |
*** joe817 has quit IRC | 16:28 | |
*** joe817_ has joined #openstack-ironic | 16:28 | |
*** srart has joined #openstack-ironic | 16:29 | |
*** amarao has quit IRC | 16:33 | |
*** tesseract has quit IRC | 16:40 | |
*** b00tcat_ has quit IRC | 16:40 | |
*** b00tcat_ has joined #openstack-ironic | 16:41 | |
*** trown is now known as trown|lunch | 16:44 | |
*** cdearborn_ has joined #openstack-ironic | 16:44 | |
*** e0ne has quit IRC | 16:47 | |
rama_y | hi TheJulia, mjturek, derekh: I setup devstack enabled for boot-from-volume (with help from derekh's info and patch #466568) | 16:53 |
patchbot | https://review.openstack.org/#/c/466568/ - ironic - Add a guide for Devstack configuration for boot-fr... | 16:53 |
*** racedo has quit IRC | 16:54 | |
rama_y | TheJulia, mjturek, derekh: I added what I am doing to an etherpad: https://etherpad.openstack.org/p/Testing_'boot_from_volume'_patches | 16:54 |
*** dsneddon has joined #openstack-ironic | 16:55 | |
derekh | rama_y: nice one, looks like its working? | 16:57 |
rama_y | derekh: yes, it is. | 16:57 |
*** cdearborn has quit IRC | 16:57 | |
*** amotoki is now known as amotoki_away | 16:57 | |
*** links has quit IRC | 16:57 | |
rama_y | derekh: There are several patches in queue, right? any pointers on testing those? | 16:58 |
*** cdearborn__ has joined #openstack-ironic | 16:58 | |
derekh | rama_y: yup, there is a bunch for them, listed here https://etherpad.openstack.org/p/Ironic-BFV | 16:59 |
*** baoli has quit IRC | 16:59 | |
*** baoli has joined #openstack-ironic | 17:00 | |
derekh | rama_y: the devstack you set up should be using all of the main ones, so I guess you've just tested them (at least the simple case), maybe try some other things to get more coverage (delete, reboot, different images etc...) | 17:01 |
TheJulia | Okay, mostly back today... not having a good day day today :( | 17:02 |
rama_y | Ah yes, that is what I am thinking of. | 17:02 |
rama_y | Thanks for pointing me in the right direction, derekh. | 17:03 |
derekh | rama_y: no prob | 17:04 |
* derekh has to run to do dinner things | 17:04 | |
fellypefca | TheJulia Is there anything I can do for RFE approval? | 17:04 |
TheJulia | fellypefca: got the link handy? | 17:04 |
*** derekh has quit IRC | 17:04 | |
* TheJulia is taking today as an ordered queue | 17:05 | |
fellypefca | TheJulia Yeah :) https://bugs.launchpad.net/ironic/+bug/1666497 | 17:05 |
openstack | Launchpad bug 1666497 in Ironic "[RFE] Onetime boot feature in OneView drivers" [Low,In progress] - Assigned to Fellype Cavalcante (fellypefca) | 17:05 |
*** mjturek has quit IRC | 17:06 | |
*** cdearborn has joined #openstack-ironic | 17:08 | |
jlvillal | TheJulia: Will you have time to look at: https://review.openstack.org/#/c/454243/ | 17:10 |
patchbot | patch 454243 - ironic - Logic for skipping deployment with BFV | 17:10 |
jlvillal | TheJulia: sambetts left some comments. I also just did a review. | 17:10 |
TheJulia | one thing at a time at the moment :) | 17:10 |
jlvillal | sambetts: on https://review.openstack.org/#/c/454243/ did you have a vote? | 17:10 |
patchbot | patch 454243 - ironic - Logic for skipping deployment with BFV | 17:10 |
TheJulia | I now need to run to the store to get a 50A extension cable... or a 30A extension cable. I'll settle for either at the moment | 17:10 |
jlvillal | sambetts: You reviewed but no vote. | 17:10 |
TheJulia | but I'll do that after the UI meeting | 17:10 |
jlvillal | TheJulia: 50A sounds pretty big. | 17:10 |
TheJulia | skimming over the oneview code one more time and then commenting on the ref ticket | 17:11 |
TheJulia | jlvillal: and heavy! | 17:11 |
jlvillal | Yep! | 17:11 |
TheJulia | It is surely braided cable... but still.... | 17:11 |
sambetts | jlvillal, TheJulia: wanted some feedback on the comments before I voted, but didn't want to -1 because they are just questions, | 17:12 |
fellypefca | TheJulia haha ok! thanks and good luck with the cables | 17:12 |
dtantsur | sambetts: it's a tricky bit. if you think you questions *must* be answered, -1 is appropriate. otherwise a +1 with a comment will do | 17:13 |
*** mat128 has joined #openstack-ironic | 17:13 | |
*** cdearborn_ has quit IRC | 17:14 | |
*** mmagr has quit IRC | 17:14 | |
*** makowals has quit IRC | 17:14 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic master: Test proposed nova devstack change and our grenade https://review.openstack.org/478220 | 17:16 |
*** hamzy has joined #openstack-ironic | 17:18 | |
fellypefca | sambetts About your comment on RFE, when we saw that we needed this feature, the first thinking that comes to our mind was that this was modified in Ironic, as you suggested. | 17:18 |
fellypefca | sambetts But after some discussions with the people of the community we saw that the best solution is to leave this internal behavior to our driver, and so we did the patch. | 17:19 |
sambetts | fellypefca: I don't think its an internal behaviour many people might want to use one time boot order settings for deploy | 17:20 |
sambetts | fellypefca: I think either an global config or per node config override makes the most sense, but like I said in the comment, I think there is refactoring to be done there, and I personally think deploy_utils try_set_boot_device should go away | 17:21 |
TheJulia | fellypefca: I commented in approval, but we need multiple cores to agree to approve | 17:21 |
*** cdearborn__ has quit IRC | 17:21 | |
TheJulia | sambetts: By chance have you ever used oneview? | 17:22 |
openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic-inspector stable/newton: grenade: Only 'enable_plugin ironic-inspector' if not already in conf https://review.openstack.org/478221 | 17:22 |
sambetts | no, but its incredibly similar to our project UCSM from the conversations I've had | 17:22 |
TheJulia | sambetts: Oneview, so you understand that changing the machine profile is not a quick thing in oneview? | 17:24 |
TheJulia | jlvillal: looking, context loading | 17:25 |
jlvillal | :) | 17:25 |
TheJulia | trying not to get distracted by the wasp in front of my windshield | 17:26 |
sambetts | right, but I don't think the set this boot device only on next boot thing is a oneview specific feature either, thats why we support it in our managment interface, so why not make it configurable in deploy to make the pxe boot interface optionally set boot device only for the next boot | 17:26 |
TheJulia | If you feel that way, then we should likely write a spec (or ask them to write a spec as good citizens of the community) at about adding that capability across drivers, at the same time, we likely ought to let the oneview folks land their feature as-is because it solves their specific deployment performance problem for now. | 17:28 |
sambetts | IMO if oneview were going to make this a oneview specific thing they'd have to right a oneview specific pxe boot interface | 17:29 |
TheJulia | I guess some of the discontent regarding this is we kind of have the opposite in a sense, but for buggy ipmi controllers. | 17:29 |
*** cdearborn_ has joined #openstack-ironic | 17:30 | |
sambetts | TheJulia: right which is why we'd make it configurable defaulting to persistent=True, and if we make it per node configuration then if you have IPMI nodes they'll be persistent true all the time, and for oneview they can set pxe_boot_device_persistnece=False | 17:31 |
TheJulia | I kind of agree with that, however, they have it for the deploy interface which is where they feel the need at this time. They may want to retool with pxe as time moves on for boot from volume | 17:31 |
*** vinsh has quit IRC | 17:31 | |
*** vinsh has joined #openstack-ironic | 17:32 | |
sambetts | I'd rather fix the real problem, than introduce hacky ways around stuff that quickly end up becoming standard ways of doing stuff if we aren't careful | 17:32 |
TheJulia | except, this is not just pxe, just so happens that pxe is the reason why at the moment. I think, and fellypefca can correct if my assumption is wrong, that virtual media booting would have the same need | 17:32 |
*** vinsh has joined #openstack-ironic | 17:32 | |
sambetts | TheJulia: right, but they'll have their own boot driver for that, and they can add a configuration option in there if they want too | 17:33 |
*** athomas has quit IRC | 17:33 | |
*** karthiks has quit IRC | 17:34 | |
TheJulia | I don't exactly see this as a problem as you see it, since while we assume persistence with boot devices, we know there are ipmi BMCs that do not take the setting persistently which is why the setting even exists. So they are told every single time what the next boot device should be. | 17:35 |
TheJulia | Exactly, and they will likely have a boot interface soon. They don't seem to now. :) | 17:36 |
ricardoas | sambetts TheJulia: my feeling about this is that we (oneview guys) have not been successful in proposing general solutions instead of fixes specific to the driver we maintain... | 17:36 |
ricardoas | sambetts: but i agree this could have been solved with an specific boot interface | 17:36 |
sambetts | perhaps I'm just not aware of the history behind the option then, but I've got to run, perhaps we can follow up with this on bug?? | 17:37 |
TheJulia | ricardoas: and you inability to feel successful in that is frustrating to me :( | 17:37 |
*** vinsh has quit IRC | 17:37 | |
TheJulia | sambetts: broken bmc workaround.... | 17:37 |
*** sambetts is now known as sambetts|afk | 17:38 | |
TheJulia | that is the tl;dr | 17:38 |
openstackgerrit | Merged openstack/ironic-python-agent master: Updated from global requirements https://review.openstack.org/477940 | 17:38 |
sambetts|afk | TheJulia: hmm, yeah... I can tell that because the pxe boot interface is currently catching IPMI specific exceptions which it shouldn't be | 17:38 |
sambetts|afk | really got to run cya tomorrow o/ | 17:38 |
TheJulia | heh, another bug! \o/ | 17:38 |
ricardoas | TheJulia: maybe we are not in sync yet with the way things happen in ironic community... i.e. the missing rfe approval for this | 17:39 |
ricardoas | :( | 17:39 |
*** deray has quit IRC | 17:39 | |
ricardoas | sambetts|afk: we can continue at the bug... :D | 17:39 |
TheJulia | ricardoas: I thought this had already been marked approved. Truthfully, I absolutely hate the excess process and bounds we've placed on driver teams | 17:39 |
TheJulia | it is your driver, if your making a change with-in that context and bounds... awesome | 17:40 |
*** karthiks has joined #openstack-ironic | 17:42 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic master: Updated from global requirements https://review.openstack.org/477936 | 17:43 |
ricardoas | TheJulia: maybe we shouldnt have discarded the general solution too soon... but i kind of hope to have this solved before restart thinking on a more general approach | 17:43 |
ricardoas | TheJulia: thanks for helping us! | 17:45 |
*** cdearborn has quit IRC | 17:46 | |
TheJulia | ricardoas: Ideally, we should only approach general if more than one driver has a possible need or use case.... but ideally :) | 17:47 |
* dtantsur has to run | 17:47 | |
dtantsur | see you tomorrow | 17:47 |
*** dtantsur is now known as dtantsur|afk | 17:47 | |
*** fellypefca has quit IRC | 17:48 | |
*** trown|lunch is now known as trown | 17:51 | |
*** links has joined #openstack-ironic | 17:55 | |
*** e0ne has joined #openstack-ironic | 17:58 | |
*** mjturek has joined #openstack-ironic | 17:58 | |
*** links has quit IRC | 18:02 | |
*** bcornec1 has quit IRC | 18:02 | |
*** mjturek has quit IRC | 18:03 | |
*** cdearborn_ has quit IRC | 18:04 | |
*** thaj has quit IRC | 18:07 | |
*** jaganathan has joined #openstack-ironic | 18:13 | |
*** cdearborn has joined #openstack-ironic | 18:18 | |
*** mjturek has joined #openstack-ironic | 18:18 | |
*** e0ne has quit IRC | 18:20 | |
openstackgerrit | Ruby Loo proposed openstack/python-ironicclient master: reno: feature parity between ironic & OSC https://review.openstack.org/478230 | 18:22 |
rloo | jlvillal and anyone else, i found a few issues with rolling upgrades, here is a smallish patch if you have time: https://review.openstack.org/#/c/476779/ | 18:28 |
patchbot | patch 476779 - ironic - Modifications for rolling upgrades | 18:28 |
jlvillal | rloo: That 'change_fields' parameter confuses me. | 18:36 |
jlvillal | So if change_fields is False it changes fields and removes fields? | 18:36 |
rloo | jlvillal: which part of it? what it is meant to convey? | 18:36 |
jlvillal | Or changes values. | 18:36 |
openstackgerrit | Anup Navare proposed openstack/ironic-ui master: Allow selecting interfaces while enrolling nodes https://review.openstack.org/473957 | 18:36 |
rloo | if change_fields is false, it means that for fields that do not exist in target version, do not change the value of that field, delete it. | 18:37 |
jlvillal | param change_fields: True to change the values of any object fields when converting (default). False to remove fields that are unavailable in the target version (and change values of any existing object fields in the target version as appropriate). | 18:37 |
rloo | jlvillal: better words would be great. or name of the parameter. i hit a mental block. | 18:37 |
jlvillal | So 'true' changes values. 'false' removes fields and changes values. | 18:37 |
rloo | jlvillal: right. | 18:37 |
jlvillal | rloo: So it kind of confuses me | 18:37 |
jlvillal | rloo: Maybe I'm being dense | 18:38 |
rloo | jlvillal: hide-unavail-fields? | 18:38 |
jlvillal | remove_fields? | 18:38 |
rloo | jlvillal: what confuses you. the name of the param, or the behavior: 'So 'true' changes values. 'false' removes fields and changes values.' | 18:38 |
rloo | jlvillal: i guess the key is that it affects any fields that are unavail in target version. | 18:39 |
jlvillal | rloo: The name of the parameter: 'change_fields' | 18:39 |
rloo | jlvillal: yeah. how about remove_unavail_fields? | 18:39 |
jlvillal | rloo: That would make more sense to me | 18:39 |
rloo | jlvillal: remove_nonexist_fields? | 18:40 |
jlvillal | rloo: first one sounds slightly better to me. But kind of a toss-up | 18:40 |
rloo | jlvillal: ok, first one it is then. | 18:41 |
rloo | jlvillal: is that the only issue? or should i wait before revising? | 18:41 |
jlvillal | rloo: Still looking. So where is this 'change_fields' actually used? | 18:42 |
jlvillal | rloo: The function I see has 'pass' | 18:42 |
rloo | jlvillal: by objects that have different versions. | 18:42 |
rloo | jlvillal: you won't see it in that patch. | 18:42 |
rloo | jlvillal: two examples are ... | 18:42 |
jlvillal | Ah | 18:42 |
rloo | https://review.openstack.org/#/c/455811/9/ironic/objects/node.py | 18:43 |
patchbot | patch 455811 - ironic - [POC|DNM|TEST] Add node.configdrive | 18:43 |
rloo | jlvillal: L161 | 18:43 |
rloo | jlvillal: and https://review.openstack.org/#/c/477694/2/ironic/objects/port.py | 18:43 |
patchbot | patch 477694 - ironic - Rolling upgrades support for port.physical_network | 18:43 |
jlvillal | Ah | 18:44 |
jlvillal | rloo: Thanks | 18:44 |
jlvillal | rloo: So the call to: self.obj_reset_changes() | 18:45 |
jlvillal | rloo: It doesn't undo everything? | 18:45 |
rloo | jlvillal: self.obj_reset_changes(). sigh. i thought i had a comment cuz dmitry had a similar question. | 18:46 |
* jlvillal doesn't know enough about the objects | 18:46 | |
rloo | jlvillal: you have to understand VersionedObjects. Under the hood, the object keeps track of the fields that were changed, in addition to the actual changed fields. | 18:46 |
rloo | jlvillal: obj_reset_changes() just clears the tracking/list of changed fields. | 18:47 |
rloo | jlvillal: it doesn't undo the actual changes. | 18:47 |
jlvillal | Yeah, I don't know that much about versionedobjects sadly | 18:47 |
jlvillal | A comment might be nice. | 18:47 |
rloo | jlvillal: i don't really think anyone should know how it works if it works 'well', but umm... | 18:47 |
rloo | jlvillal: the .obj_reset_changes() code is sprinkled throughout. | 18:47 |
jlvillal | rloo: Okay. | 18:47 |
rloo | jlvillal: i put in a comment somewhere, but again, it is used in a lot of places. | 18:47 |
jlvillal | rloo: Understandable. | 18:48 |
jlvillal | rloo: I have to head out to lunch. Be back in a bit. | 18:48 |
rloo | jlvillal: thx | 18:48 |
*** baoli has quit IRC | 18:51 | |
*** baoli has joined #openstack-ironic | 18:56 | |
*** ChubYann has joined #openstack-ironic | 19:08 | |
*** adisky__ has quit IRC | 19:10 | |
*** joe817_ has quit IRC | 19:13 | |
*** joe817 has joined #openstack-ironic | 19:13 | |
*** jaganathan has quit IRC | 19:18 | |
openstackgerrit | Peter Piela proposed openstack/ironic-ui master: Set current boot device on a node https://review.openstack.org/473926 | 19:22 |
*** livelace has quit IRC | 19:22 | |
*** karthiks has quit IRC | 19:22 | |
*** karthiks has joined #openstack-ironic | 19:22 | |
*** vinsh has joined #openstack-ironic | 19:23 | |
TheJulia | jlvillal: replied to the wire-in patch comments | 19:24 |
TheJulia | jlvillal: good catch about using lambda, I think it should be a follow-up, personally. | 19:25 |
*** mmedvede has quit IRC | 19:25 | |
*** mmedvede has joined #openstack-ironic | 19:26 | |
*** mmedvede has quit IRC | 19:28 | |
*** mmedvede has joined #openstack-ironic | 19:31 | |
*** shobhar has joined #openstack-ironic | 19:32 | |
openstackgerrit | Merged openstack/python-ironicclient master: Updated from global requirements https://review.openstack.org/478076 | 19:40 |
*** mgoddard has quit IRC | 19:41 | |
*** mmedvede has quit IRC | 19:42 | |
*** mmedvede has joined #openstack-ironic | 19:42 | |
*** rfolco_ has joined #openstack-ironic | 19:55 | |
*** mrtenio has quit IRC | 19:56 | |
*** mjturek has quit IRC | 19:58 | |
*** mjturek has joined #openstack-ironic | 19:59 | |
openstackgerrit | Merged openstack/ironic-lib master: Updated from global requirements https://review.openstack.org/477938 | 20:00 |
*** jkilpatr has quit IRC | 20:12 | |
*** joe817 has quit IRC | 20:13 | |
*** e0ne has joined #openstack-ironic | 20:17 | |
jlvillal | TheJulia: Thanks. Hopefully you came to a resolution on sambetts|afk comments | 20:17 |
*** joe817 has joined #openstack-ironic | 20:18 | |
*** rfolco_ is now known as rfolco | 20:19 | |
openstackgerrit | Merged openstack/ironic master: Fix VIF list for noop network interface https://review.openstack.org/477493 | 20:26 |
*** joe817_ has joined #openstack-ironic | 20:27 | |
*** joe817 has quit IRC | 20:30 | |
*** jkilpatr has joined #openstack-ironic | 20:31 | |
*** srart has quit IRC | 20:32 | |
*** rcarrill1 has joined #openstack-ironic | 20:33 | |
*** rcarrillocruz has quit IRC | 20:34 | |
*** rbudden has quit IRC | 20:40 | |
*** rbudden has joined #openstack-ironic | 20:41 | |
*** srart has joined #openstack-ironic | 20:41 | |
*** trown is now known as trown|outtypewww | 20:49 | |
*** vinsh has quit IRC | 20:49 | |
openstackgerrit | Xavier proposed openstack/ironic master: Introduce hpOneView and ilorest to OneView https://review.openstack.org/468129 | 21:02 |
*** jkilpatr has quit IRC | 21:18 | |
*** paramite has joined #openstack-ironic | 21:25 | |
*** mjturek has quit IRC | 21:31 | |
*** jkilpatr has joined #openstack-ironic | 21:32 | |
openstackgerrit | Merged openstack/bifrost master: Updated from global requirements https://review.openstack.org/477913 | 21:37 |
*** jaypipes has quit IRC | 21:44 | |
openstackgerrit | Peter Piela proposed openstack/ironic-ui master: Add functionality to view portgroups https://review.openstack.org/474326 | 21:52 |
*** jkilpatr has quit IRC | 21:53 | |
*** jkilpatr has joined #openstack-ironic | 21:53 | |
*** baoli has quit IRC | 21:56 | |
*** shobhar has quit IRC | 22:01 | |
*** bfournie has quit IRC | 22:02 | |
*** e0ne has quit IRC | 22:02 | |
*** priteau has quit IRC | 22:06 | |
*** jcoufal has quit IRC | 22:14 | |
*** racedo has joined #openstack-ironic | 22:17 | |
*** MattMan_1 has quit IRC | 22:18 | |
*** MattMan_1 has joined #openstack-ironic | 22:18 | |
*** racedo has quit IRC | 22:21 | |
*** shvepsy has quit IRC | 22:30 | |
openstackgerrit | Merged openstack/ironic master: Updated from global requirements https://review.openstack.org/477936 | 22:43 |
*** shobhar has joined #openstack-ironic | 22:47 | |
*** cdearborn has quit IRC | 23:05 | |
*** hoonetorg has quit IRC | 23:09 | |
*** joe817_ has quit IRC | 23:15 | |
*** racedo has joined #openstack-ironic | 23:16 | |
*** shvepsy has joined #openstack-ironic | 23:19 | |
*** crushil_ has joined #openstack-ironic | 23:23 | |
*** hoonetorg has joined #openstack-ironic | 23:26 | |
*** crushil_ has quit IRC | 23:32 | |
*** racedo has quit IRC | 23:35 | |
*** ElCoyote_ has quit IRC | 23:45 | |
*** rbudden has quit IRC | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!