* TheJulia reads the log and kind of wonders if we need to actually be aware of what the back-end dhcp interface is in neutron | 00:00 | |
TheJulia | anupn: I guess my question would be, is IPA actually booting, and what is in the console log. Since IPA does write some logs to the console, if it boots, we can at least see if network connectivity fails, and kind of troubleshoot from there | 00:02 |
---|---|---|
*** namnh has quit IRC | 00:04 | |
anupn | TheJulia, Yes i saw the node console log, It said Starting Ironic Python Agent and then abruptly failed. I did not see specific reason for failure inside console log, but n-cpu logs showed unable to find resource. And I wonder that was because of low memory for my Vagrant machine. I am running now with increased memory | 00:07 |
anupn | TheJulia, unfortunately i did not saved console logs in the last run | 00:07 |
anupn | TheJulia, i am able to put the nodes into available state :) So, it was due to low memory assigned | 00:10 |
anupn | TheJulia, thanks | 00:10 |
TheJulia | ahh! | 00:10 |
TheJulia | yeah, if there is not enough memory, things can go sideways quickly | 00:11 |
TheJulia | Out of curiosity, how much memory were you trying to use | 00:11 |
TheJulia | ? | 00:11 |
*** Sukhdev_ has quit IRC | 00:13 | |
*** charcol has quit IRC | 00:20 | |
anupn | TheJulia, my Vagrant machine had 8gb | 00:21 |
anupn | TheJulia, oh no it was actually 6gb now i have increased it to 8 | 00:22 |
*** ijw has quit IRC | 00:23 | |
*** ijw has joined #openstack-ironic | 00:23 | |
TheJulia | interesting, coreos? | 00:25 |
anupn | TheJulia, nope ubuntu | 00:26 |
anupn | 16.04 | 00:26 |
anupn | TheJulia, actually it is interesting because till now i used that that much memory | 00:26 |
anupn | TheJulia, but today when i started to run stack.sh it complained about this | 00:26 |
TheJulia | ubuntu for IPA, or ubuntu for a devstack test machine? | 00:27 |
anupn | ubuntu for devstack test machine | 00:27 |
anupn | IPA was TinyIPA which devstack use by default. | 00:28 |
TheJulia | wow, interesting | 00:29 |
TheJulia | I guess, 6GB is kind of riding at what ws the minimum | 00:29 |
anupn | TheJulia, hmm. Devstack documentation says 8gb is required minimum actually from what i remember | 00:31 |
anupn | n-cpu logs complained resource not found, that kinda gave me the hint of this memory. I hate using vagrant sometimes :( | 00:32 |
*** hshiina has joined #openstack-ironic | 00:36 | |
*** baoli has joined #openstack-ironic | 00:36 | |
*** baoli has quit IRC | 00:36 | |
*** racedo has joined #openstack-ironic | 00:37 | |
TheJulia | anupn: Yeah, 8GB has been the functional minimum for a while, especially if you ad in a couple other services. | 00:38 |
TheJulia | anupn: I would guess resource not found was more a scheduling issue, but you also indicated an issue with from manageable -> available | 00:39 |
TheJulia | and nova doesn't know about managable nodes | 00:39 |
*** openstackgerrit has quit IRC | 00:41 | |
anupn | TheJulia, hmm that's true. My console log for that node was similar to this http://paste.openstack.org/show/621578/ with multiple devices listed like /sys/devices/virtual/.. | 00:45 |
anupn | TheJulia, not sure, was memory indeed the prob but increasing it did the work | 00:47 |
*** bfournie has joined #openstack-ironic | 00:48 | |
*** sasha21 has quit IRC | 00:49 | |
*** TuanLA has joined #openstack-ironic | 00:50 | |
*** rloo has quit IRC | 00:51 | |
*** litao__ has joined #openstack-ironic | 00:54 | |
*** hoonetorg has joined #openstack-ironic | 00:56 | |
*** openstackgerrit has joined #openstack-ironic | 01:06 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironic-inspector-client stable/pike: Updated from global requirements https://review.openstack.org/505877 | 01:06 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient stable/pike: Updated from global requirements https://review.openstack.org/505878 | 01:06 |
TheJulia | yeah, doing block IO ops can result in lots of read-ahead caching, so I can see that tanking a VM | 01:07 |
TheJulia | or, greatly impacting performance if things get swapped | 01:07 |
*** phuongnh has joined #openstack-ironic | 01:07 | |
*** charcol has joined #openstack-ironic | 01:08 | |
*** trungnv has joined #openstack-ironic | 01:16 | |
*** namnh has joined #openstack-ironic | 01:27 | |
*** hw_wutianwei has joined #openstack-ironic | 01:39 | |
*** Sukhdev has quit IRC | 01:39 | |
*** racedo has quit IRC | 01:49 | |
*** crushil has joined #openstack-ironic | 01:54 | |
*** amotoki has quit IRC | 01:55 | |
*** amotoki has joined #openstack-ironic | 01:56 | |
*** anupn has quit IRC | 01:56 | |
*** strigazi has quit IRC | 01:56 | |
*** hamzy has quit IRC | 01:57 | |
*** hamzy has joined #openstack-ironic | 01:57 | |
*** aNuposic has joined #openstack-ironic | 01:58 | |
*** ijw has quit IRC | 01:58 | |
*** strigazi has joined #openstack-ironic | 01:58 | |
*** ijw has joined #openstack-ironic | 02:01 | |
*** ijw has quit IRC | 02:05 | |
*** rbudden has quit IRC | 02:09 | |
*** trungnv has quit IRC | 02:16 | |
*** crushil has quit IRC | 02:20 | |
*** zhangfei has joined #openstack-ironic | 02:25 | |
*** trungnv has joined #openstack-ironic | 02:28 | |
*** yolanda has quit IRC | 02:34 | |
*** yolanda has joined #openstack-ironic | 02:35 | |
*** causten has joined #openstack-ironic | 02:38 | |
*** kzaitsev_pi has quit IRC | 03:00 | |
*** kzaitsev1pi has joined #openstack-ironic | 03:00 | |
*** baoli has joined #openstack-ironic | 03:01 | |
*** rwsu has quit IRC | 03:14 | |
*** sasha21 has joined #openstack-ironic | 03:20 | |
*** baoli has quit IRC | 03:23 | |
*** Sukhdev has joined #openstack-ironic | 03:24 | |
*** zhangfei has quit IRC | 03:28 | |
*** rwsu has joined #openstack-ironic | 03:31 | |
*** sasha21 has quit IRC | 03:38 | |
*** udesale has joined #openstack-ironic | 03:41 | |
*** zhangfei has joined #openstack-ironic | 03:41 | |
*** hshiina has quit IRC | 03:42 | |
*** hshiina has joined #openstack-ironic | 03:46 | |
*** rwsu has quit IRC | 03:50 | |
*** rwsu has joined #openstack-ironic | 04:09 | |
*** rwsu has quit IRC | 04:21 | |
*** jrist has joined #openstack-ironic | 04:31 | |
*** rwsu has joined #openstack-ironic | 04:41 | |
*** links has joined #openstack-ironic | 04:43 | |
*** causten has quit IRC | 04:55 | |
*** pcaruana has joined #openstack-ironic | 05:09 | |
*** e0ne has joined #openstack-ironic | 05:16 | |
*** rwsu has quit IRC | 05:18 | |
*** e0ne has quit IRC | 05:20 | |
*** marios has joined #openstack-ironic | 05:20 | |
*** Sukhdev has quit IRC | 05:23 | |
*** marios_ has joined #openstack-ironic | 05:24 | |
*** marios has quit IRC | 05:25 | |
*** marios_ is now known as marios | 05:25 | |
*** jtomasek has joined #openstack-ironic | 05:29 | |
*** dpawar has joined #openstack-ironic | 05:32 | |
*** rwsu has joined #openstack-ironic | 05:33 | |
*** udesale__ has joined #openstack-ironic | 05:35 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add API and conductor methods for [un]rescue https://review.openstack.org/350831 | 05:37 |
*** udesale has quit IRC | 05:38 | |
*** rwsu has quit IRC | 05:39 | |
*** mjura has joined #openstack-ironic | 05:40 | |
*** exodusftw has quit IRC | 05:40 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add rescue interface field to node-related notifications https://review.openstack.org/502889 | 05:41 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add rescuewait timeout periodic task https://review.openstack.org/353156 | 05:42 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Agent driver rescue implementation https://review.openstack.org/400437 | 05:45 |
*** exodusftw has joined #openstack-ironic | 05:45 | |
*** udesale has joined #openstack-ironic | 05:50 | |
*** udesale__ has quit IRC | 05:52 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic master: Insert the description of the change. https://review.openstack.org/505982 | 05:53 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic stable/pike: Insert the description of the change. https://review.openstack.org/505984 | 05:53 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic master: DNR: check dell CI https://review.openstack.org/505982 | 06:13 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic stable/pike: DNR: check dell CI https://review.openstack.org/505984 | 06:13 |
*** racedo has joined #openstack-ironic | 06:24 | |
*** rcernin has joined #openstack-ironic | 06:28 | |
*** udesale has quit IRC | 06:29 | |
*** udesale has joined #openstack-ironic | 06:30 | |
*** mcarden has quit IRC | 06:32 | |
*** ralonsoh has joined #openstack-ironic | 06:45 | |
*** Nisha_Agarwal has joined #openstack-ironic | 06:48 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic stable/ocata: Skip PortNotFound when unbinding port https://review.openstack.org/505367 | 06:50 |
*** ChubYann has quit IRC | 07:04 | |
*** pcaruana has quit IRC | 07:05 | |
*** jaganathan has joined #openstack-ironic | 07:10 | |
*** racedo has joined #openstack-ironic | 07:10 | |
*** ccamacho has quit IRC | 07:13 | |
*** ChanServ sets mode: +o openstack | 07:16 | |
*** tesseract has joined #openstack-ironic | 07:19 | |
*** trungnv has quit IRC | 07:22 | |
*** jtomasek has quit IRC | 07:23 | |
*** pcaruana has joined #openstack-ironic | 07:23 | |
*** jtomasek has joined #openstack-ironic | 07:25 | |
*** kzaitsev_pi has joined #openstack-ironic | 07:31 | |
*** kzaitsev1pi has quit IRC | 07:32 | |
openstackgerrit | Merged openstack/ironic-python-agent master: Fix wrong link about Hardware Managers https://review.openstack.org/505915 | 07:36 |
*** dpawar has quit IRC | 07:41 | |
*** chihhsin has joined #openstack-ironic | 07:55 | |
*** dpawar has joined #openstack-ironic | 08:00 | |
*** rwsu has joined #openstack-ironic | 08:07 | |
*** racedo has quit IRC | 08:08 | |
*** stendulker has joined #openstack-ironic | 08:12 | |
stendulker | vsaienk0: Hi | 08:13 |
vsaienk0 | hello stendulker | 08:13 |
stendulker | vsaienk0: Do lte me know if anything I can be of help for DHCP opts issue | 08:14 |
stendulker | vsaienk0: This is another patch where only pxe-ilo failed | 08:15 |
stendulker | https://review.openstack.org/#/c/474331/ | 08:15 |
patchbot | patch 474331 - ironic - reloads mutable config values on SIGHUP | 08:15 |
vsaienk0 | stendulker: I found at least 1 job of ILO and dell passed with numbered options | 08:16 |
stendulker | vsaienk0: yes, it passed with iscsi-ilo and agent-ilo | 08:16 |
stendulker | vsaienk0: But not for pxe-ilo. | 08:17 |
stendulker | Can this fix impact tftp? | 08:17 |
stendulker | iscsi-ilo and agent-ilo are vmedia based drivers | 08:17 |
vsaienk0 | stendulker: but all ilo jobs uses pxe without chainloading to ipxe right? | 08:18 |
vsaienk0 | ah | 08:18 |
*** mgoddard has joined #openstack-ironic | 08:18 | |
stendulker | no. agent_ilo and iscsi_ilo would use vmedia | 08:19 |
stendulker | pxe-ilo would use pxe. No ipxe is used in pxe-ilo driver either | 08:19 |
vsaienk0 | stendulker: can you dump dhcp packets on baremetal interface before start deployment on pxe-ilo? | 08:22 |
stendulker | sure. Will rerun the pxe-ilo test and capture the packets | 08:23 |
*** nmathew has joined #openstack-ironic | 08:24 | |
*** kzaitsev1pi has joined #openstack-ironic | 08:32 | |
*** kzaitsev_pi has quit IRC | 08:33 | |
vsaienk0 | stendulker: something like sudo tcpdump -nei <baremtal_interface> udp port 67 or port 68 -w /var/log/baremetal-dhcp.pcap | 08:36 |
stendulker | yes | 08:37 |
stendulker | for every test, it re-stacks the devstack, so it will take few mins | 08:37 |
*** etingof has quit IRC | 08:42 | |
*** derekh has joined #openstack-ironic | 08:43 | |
*** amarao1 has joined #openstack-ironic | 08:50 | |
openstackgerrit | zhangyangyang proposed openstack/ironic-ui master: Cleanup test-requirements https://review.openstack.org/506064 | 08:51 |
openstackgerrit | zhangyangyang proposed openstack/ironic-tempest-plugin master: Cleanup test-requirements https://review.openstack.org/506065 | 08:52 |
openstackgerrit | zhangyangyang proposed openstack/ironic-python-agent master: Cleanup test-requirements https://review.openstack.org/506069 | 08:54 |
vsaienk0 | stendulker: thanks! | 08:56 |
stendulker | vsaienk0: here is the logs http://paste.openstack.org/show/621597/ | 08:57 |
stendulker | It does get DHCP IP, but is not able to fetch tftp file | 08:58 |
vsaienk0 | stendulker: could you please also add -vvee to tcpdump or provide pcap file? | 08:58 |
*** etingof has joined #openstack-ironic | 08:59 | |
openstackgerrit | Wang KaiFeng proposed openstack/ironic-specs master: Agent provisioning with HTTP server https://review.openstack.org/504039 | 09:01 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic master: WIP: pass both numbered and named dhcp options https://review.openstack.org/506074 | 09:03 |
*** zhangfei has quit IRC | 09:03 | |
stendulker | vsaienk0: Will redo with that -vvee option | 09:03 |
vsaienk0 | stendulker: what do you mean not able? it doesn't recognize filename/tftp server address? or can't access to tftp what is the error on the console? | 09:03 |
stendulker | on console i could see it gets IP, but nota ble to pull the tftp file | 09:04 |
stendulker | error moves very fast on the console, cant read | 09:05 |
*** dpawar has quit IRC | 09:06 | |
*** hshiina has quit IRC | 09:06 | |
*** milan has joined #openstack-ironic | 09:13 | |
stendulker | vsaienk0: Here are the logs http://paste.openstack.org/show/621599/ | 09:17 |
stendulker | vsaienk0: Only other thing is pxe-ilo test is runs in UEFI boot mode. | 09:19 |
*** zhangfei has joined #openstack-ironic | 09:20 | |
vsaienk0 | stendulker: this looks strange BF Option 67, length 12: "bootx64.efi^@" TFTP Option 66, length 14: "10.13.120.199^@" | 09:21 |
vsaienk0 | could you show your ironic.conf? | 09:21 |
stendulker | vsaienk0: sure | 09:22 |
*** ccamacho has joined #openstack-ironic | 09:25 | |
stendulker | vsaienk0: It is http://paste.openstack.org/show/621600/ | 09:26 |
* stendulker in meeting for next one hour. | 09:31 | |
*** dpawar has joined #openstack-ironic | 09:31 | |
*** sambetts|afk is now known as sambetts | 09:36 | |
*** tesseract has quit IRC | 09:41 | |
*** tesseract has joined #openstack-ironic | 09:41 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic master: WIP: check another boot option order https://review.openstack.org/506094 | 09:43 |
sambetts | vsaienk0: are all our CI jobs running iPXE now?? | 09:44 |
sambetts | vsaienk0: wondering if we disable iPXE if we also see failures | 09:45 |
sambetts | stendulker: can you check that the bootx64.efi file actually exists in the TFTP server on the conductor at /opt/stack/data/ironic/tftp I think | 09:47 |
sambetts | currently UEFI is only supported in devstack with iPXE | 09:48 |
vsaienk0 | sambetts: yes all jobs using IPXE except of third party CI | 09:51 |
vsaienk0 | sambetts: I didn't find how to switch kvm VM to use pxe :( | 09:52 |
vsaienk0 | sambetts: the only thing that is different it request is options ordering | 09:52 |
vsaienk0 | in the patch I swapped server-name and server-address | 09:53 |
sambetts | vsaienk0, stendulker said they are not using iPXE but also said they are using UEFI, but we require iPXE for UEFI I though | 09:53 |
sambetts | thought* | 09:53 |
vsaienk0 | sambetts: I'm not sure how theirs CI is configured but it works somehow :) | 09:54 |
*** rwsu has quit IRC | 09:54 | |
vsaienk0 | and looks like switching to dhcp option numbers indeed broke it | 09:54 |
*** chihhsin has quit IRC | 09:59 | |
pas-ha | morning ironic :) | 10:00 |
vsaienk0 | morning pas-ha | 10:00 |
sambetts | o/ pas-ha | 10:01 |
*** Nisha_Agarwal has quit IRC | 10:02 | |
*** rwsu has joined #openstack-ironic | 10:07 | |
*** rwsu has quit IRC | 10:13 | |
*** e0ne has joined #openstack-ironic | 10:13 | |
*** udesale has quit IRC | 10:16 | |
*** mgoddard has quit IRC | 10:17 | |
*** yee37927 has joined #openstack-ironic | 10:24 | |
*** yee379 has quit IRC | 10:24 | |
*** rwsu has joined #openstack-ironic | 10:32 | |
*** jkilpatr has quit IRC | 10:38 | |
openstackgerrit | Vasyl Saienko proposed openstack/ironic master: WIP: check another boot option order https://review.openstack.org/506094 | 10:38 |
vsaienk0 | sambetts: what do you think about passing both name and option code? https://review.openstack.org/#/c/506074/ dell ci passed | 10:39 |
patchbot | patch 506074 - ironic - WIP: pass both numbered and named dhcp options | 10:39 |
*** zhangfei has quit IRC | 10:39 | |
sambetts | vsaienk0: I'm kind of -1 on that, the point of using the number is so that we are compatible with all dns servers that might be under neutron, if we pass the name and the number then if the dns server doesn't understand the names its likely to break | 10:43 |
sambetts | vsaienk0: /me is very interested why this is breaking the third party CIs but not breaking our CI | 10:44 |
stendulker | sambetts: No ipxe is used for UEFI in pxe-ilo CI tests | 10:44 |
vsaienk0 | sambetts: this depends on dns server, usually unknown options are just ignored | 10:44 |
vsaienk0 | *dhcp | 10:45 |
sambetts | we can't assume they'll be ignored though, so we should only pass the ones we know are going to be compat with everything | 10:45 |
sambetts | stendulker: are you using dnsmasq under neutron? | 10:47 |
stendulker | sambetts: yes | 10:48 |
*** ijw has joined #openstack-ironic | 10:50 | |
vsaienk0 | sambetts: the only one difference I found between pcap provided by stendulker http://paste.openstack.org/show/621599/ is that order for 67 and 68 options are not the same as when we using option names. | 10:50 |
sambetts | if your using iPXE with UEFI, then it shouldn't be looking at the TFTP server for bootx64.efi | 10:50 |
sambetts | I don't think | 10:50 |
vsaienk0 | with numbers ( BF Option 67, length 12: "bootx64.efi^@" TFTP Option 66, length 14: "10.13.120.199^@"); with names (TFTP Option 66, length 13: "192.168.90.5^@" BF Option 67, length 31: "http://172.18.170.35/boot.ipxe^@") | 10:50 |
*** ccamacho has quit IRC | 10:51 | |
*** ccamacho has joined #openstack-ironic | 10:51 | |
sambetts | the noticable difference there is that option 67 has the full URL | 10:51 |
sambetts | and is actually loading the ipxe script correctly | 10:52 |
*** ijw has quit IRC | 10:54 | |
*** jaganathan has quit IRC | 10:54 | |
*** ccamacho has quit IRC | 10:58 | |
*** ccamacho has joined #openstack-ironic | 10:59 | |
*** mat128 has joined #openstack-ironic | 11:00 | |
*** namnh has quit IRC | 11:01 | |
stendulker | sambetts: Does the path to bootx64.efi shoudl matter? Isnt that something to be handled by tftp map-file? | 11:01 |
*** dtantsur|afk is now known as dtantsur | 11:02 | |
dtantsur | morning ironic | 11:02 |
* dtantsur still lives in the US time lol | 11:02 | |
sambetts | stendulker: the bootx64.efi rom needs to be in the location the tftp map-file points to thats what I'm thinking, although the devstack plugin should have done that foor you | 11:04 |
stendulker | sambetts: yes that is how it used to work | 11:05 |
stendulker | sambetts: The pxe-ilo test passed on the patch https://review.openstack.org/#/c/505797/ where the change was removed | 11:07 |
patchbot | patch 505797 - ironic - Revert "Change pxe dhcp options name to codes." | 11:07 |
stendulker | sambetts: In the failure case there is no request made by BM to fetch the bootx64.efi | 11:09 |
stendulker | sambetts: So I think tftp is not coming into play here | 11:09 |
sambetts | stendulker: IRONIC_IPXE_ENABLED=False in your local.conf for that job | 11:09 |
*** jkilpatr has joined #openstack-ironic | 11:10 | |
stendulker | We donot use ipxe, but I'll confirm about this variable | 11:10 |
stendulker | sambetts: yes, its set to False | 11:11 |
sambetts | the devstack plugin only supports iPXE for UEFI | 11:11 |
sambetts | it won't copy the files into the right locations if you don't enable that | 11:11 |
sambetts | are you using a custom applied patch | 11:12 |
sambetts | ? | 11:12 |
stendulker | sambetts:yes | 11:13 |
stendulker | sambetts: Its under review\ | 11:13 |
stendulker | sambetts: https://review.openstack.org/#/c/454026/ | 11:13 |
sambetts | this one: https://review.openstack.org/#/c/454026/ | 11:13 |
patchbot | patch 454026 - ironic - Adding grub2 bootloader support to devstack plugin | 11:13 |
patchbot | patch 454026 - ironic - Adding grub2 bootloader support to devstack plugin | 11:13 |
stendulker | This enables support for both UEFI and UEFI secure boot | 11:13 |
sambetts | yeah... I think the map file for that patch is broken | 11:13 |
stendulker | sambetts: No. Why do you think so? | 11:14 |
stendulker | UEFI requests file from 2 paths | 11:15 |
stendulker | sambetts: First file is BOOTX64.EFI from /tftpboot | 11:17 |
stendulker | sambetts: Then grub.cfg from /tftpboot/EFI/fedora | 11:17 |
stendulker | sambetts: Then node specific grub.cfg from the /tftpboot | 11:18 |
stendulker | sambetts: And all these files are not requested as absolute paths but mix of relative and absolute path by the BM. | 11:19 |
*** rwsu has quit IRC | 11:21 | |
* stendulker leaving for the day. | 11:23 | |
*** stendulker has quit IRC | 11:29 | |
*** dprince has joined #openstack-ironic | 11:30 | |
openstackgerrit | Sam Betts proposed openstack/ironic master: [DNM] Disable iPXE and make sure normal PXE works https://review.openstack.org/506128 | 11:30 |
sambetts | vsaienk0: ^ this should force the tests to use normal PXE, because the iPXE ROMs can support normal PXE | 11:31 |
*** phuongnh has quit IRC | 11:32 | |
*** nmathew has quit IRC | 11:32 | |
*** rwsu has joined #openstack-ironic | 11:34 | |
vsaienk0 | stendulker: can you please dump all packes for specific node ie (tcpdump -nei <baremetal_infteface> ether host <mac_address> -w /var/log/baremetal.pcap) and upload pcap somewhere? | 11:47 |
*** gmonteiro has joined #openstack-ironic | 11:48 | |
*** fellypefca-afk is now known as fellypefca | 11:49 | |
fellypefca | Good morning Ironic | 11:50 |
fellypefca | rajinir hey, around? Any news with TFTP issue? | 11:51 |
*** chlong has joined #openstack-ironic | 11:53 | |
vsaienk0 | fellypefca: we are working on it | 11:54 |
fellypefca | vsaienk0 thanks! I just noticed that this patch passed on our CI https://review.openstack.org/#/c/505797/ | 11:55 |
patchbot | patch 505797 - ironic - Revert "Change pxe dhcp options name to codes." | 11:55 |
sambetts | fellypefca: are you using pxe or ipxe and are you using efi? | 11:56 |
*** litao__ has quit IRC | 11:59 | |
openstackgerrit | Merged openstack/ironic master: Rework update_port_address logic https://review.openstack.org/496249 | 12:00 |
fellypefca | sambetts we use pxe and legacy bios | 12:00 |
*** TuanLA has quit IRC | 12:00 | |
sambetts | fellypefca: any custom dhcp stuff? e.g. not dnsmasq etc? | 12:01 |
*** udesale has joined #openstack-ironic | 12:02 | |
fellypefca | sambetts no, nothing customized | 12:04 |
sambetts | cool thanks | 12:04 |
*** udesale has quit IRC | 12:04 | |
*** udesale has joined #openstack-ironic | 12:04 | |
*** jaganathan has joined #openstack-ironic | 12:05 | |
*** bfournie has quit IRC | 12:05 | |
dtantsur | sambetts: is it a good enough reason to land the revert? | 12:05 |
dtantsur | I don't feel well of having landed something with the CI all-red.. | 12:06 |
sambetts | yeah :/ I just don't want to land the revert not knowing what caused the problem, because all our CI is green but it uses iPXE | 12:09 |
sambetts | basically don't want us to land the revert and then forget about it | 12:09 |
sambetts | because its "fixed" | 12:09 |
dtantsur | sambetts: "all our CI" was NOT green. 3rdparty CI is a critical part of our CI. | 12:10 |
sambetts | I mean, all our upstream CI was green | 12:10 |
dtantsur | this is true, but that means roughly nothing :) | 12:10 |
dtantsur | people in real life do not deploy on devstack, as you know | 12:11 |
sambetts | so I'm trying to determine the differences between third party CI and the CI we run | 12:11 |
sambetts | the third party CIs all use devstack too | 12:11 |
sambetts | :-P | 12:11 |
dtantsur | true :) | 12:11 |
dtantsur | but that's kinda closer to real life, right? we cannot guarantee that people out there do not use a similar configuration for their prod | 12:11 |
dtantsur | anyway, I'll get W+1 back, and I'm pretty sure the authors of the original patch will get back to it | 12:12 |
sambetts | oh totally | 12:12 |
openstackgerrit | yolanda.robla proposed openstack/bifrost stable/ocata: scripts: test-bifrost: Start MySQL service before configuring the DB https://review.openstack.org/506138 | 12:12 |
sambetts | but there are undocumented differences between the CIs which makes it hard to determine which part of the patch is the problem, e.g. ipxe vs pxe, different parts of the code are exercides | 12:13 |
openstackgerrit | yolanda.robla proposed openstack/bifrost stable/newton: scripts: test-bifrost: Start MySQL service before configuring the DB https://review.openstack.org/506139 | 12:13 |
sambetts | and without knowing which CIs use which its going to be hard to debug | 12:13 |
dtantsur | sambetts: which gets us back to kolla folks' point: devstack is not flexible, and is very fragile | 12:13 |
sambetts | same with ilo's CI using an unmerged patch... | 12:13 |
*** rbudden has joined #openstack-ironic | 12:13 | |
dtantsur | if we used something production-ready, people would have to do less crazy things, I hope.... | 12:13 |
* dtantsur reads https://githubengineering.com/kubernetes-at-github/ | 12:14 | |
sambetts | fellypefca: do you have a way to get the console logs for the server that is being deployed saved to the CI logs?? | 12:18 |
openstackgerrit | Merged openstack/ironic master: Drop neutron masking exception in vif_attach https://review.openstack.org/504874 | 12:19 |
*** dpawar has quit IRC | 12:19 | |
dtantsur | oh, this is even more interesting: https://githubengineering.com/githubs-metal-cloud/ has anyone here read it? | 12:22 |
dtantsur | sambetts, TheJulia ^^? | 12:22 |
*** gmonteiro_ has joined #openstack-ironic | 12:24 | |
*** trown|outtypewww is now known as trown | 12:24 | |
fellypefca | sambetts not that I know... | 12:24 |
fellypefca | sambetts only the devstack logs | 12:25 |
dtantsur | good time to implement a console interface for oneview :D | 12:25 |
vsaienk0 | dtantsur: sambetts I think I can rework dhcp options patch to pass both name and number https://review.openstack.org/#/c/506074/ | 12:28 |
patchbot | patch 506074 - ironic - WIP: pass both numbered and named dhcp options | 12:28 |
dtantsur | nice! | 12:28 |
dtantsur | well, at least it passes upstream, Dell and HPE CI | 12:29 |
vsaienk0 | sambetts: has concerns about it, but hence we passed option names previously it shouldn't be a problem | 12:29 |
dtantsur | I'm not sure what is happening with the iRMC CI, but it seems ot be all red | 12:29 |
sambetts | I'm really not keen on sending duplicate options :/ | 12:29 |
fellypefca | dtantsur actually we have a PoC using iLO IPMI. But we are not sure yet if it's work :/ | 12:29 |
*** jaypipes has joined #openstack-ironic | 12:33 | |
fellypefca | I will put this patch on top of our CI queue https://review.openstack.org/#/c/506074/ | 12:33 |
patchbot | patch 506074 - ironic - WIP: pass both numbered and named dhcp options | 12:33 |
fellypefca | dtantsur btw i just received the ironic t-shirt. Thanks! :) | 12:34 |
dtantsur | awesome :) | 12:34 |
*** bfournie has joined #openstack-ironic | 12:38 | |
*** udesale has quit IRC | 12:39 | |
*** catintheroof has joined #openstack-ironic | 12:42 | |
*** hw_wutianwei has quit IRC | 12:42 | |
openstackgerrit | Ruby Loo proposed openstack/ironic master: ListType preserves the order of the input https://review.openstack.org/505837 | 12:46 |
*** rloo has joined #openstack-ironic | 12:46 | |
dtantsur | rloo: I'd prefer a bug on ^^^ in case we ever need to backport it | 12:50 |
dtantsur | in spirit of your recent email ;) | 12:50 |
dtantsur | also morning | 12:50 |
*** gmonteiro_ has quit IRC | 12:51 | |
rloo | hey, good morning dtantsur! is it a bug? | 12:51 |
dtantsur | rloo: it depends on why you make this change :) | 12:52 |
dtantsur | if you find the current behavior incorrect - it is a bug | 12:52 |
rloo | dtantsur: i need that behaviour to fix https://bugs.launchpad.net/ironic/+bug/1717880 | 12:52 |
openstack | Launchpad bug 1717880 in Ironic ""Next" in node pagination ignores 'fields' parameter" [Medium,Triaged] - Assigned to Ruby Loo (rloo) | 12:52 |
dtantsur | then Related-Bug or Closes-Bug, right? | 12:53 |
rloo | dtantsur: i thought it was a separate 'thing'. i could just do it all in one patch. | 12:53 |
rloo | dtantsur: it seemed like 'code cleanup' | 12:53 |
rloo | dtantsur: i can do a related bug, i wasn't sure | 12:53 |
dtantsur | rloo: if you need it for the bug fix, then you may want to backport it, right? | 12:53 |
dtantsur | if you plan on backporting the said fix too | 12:53 |
rloo | dtantsur: oh, i wasn't planning on backporting it, but i suppose someone might want to. | 12:53 |
dtantsur | yep | 12:53 |
rloo | dtantsur: in that case, you think it is better to put it all in one patch? | 12:54 |
dtantsur | we should treat all bugs as backportable, unless proven otherwise | 12:54 |
dtantsur | no, not necessary, just a reference to a bug is enough. and a release note, if it is user visible in any sense | 12:54 |
rloo | dtantsur: cuz i err, found a few bugs while fixing and am trying to figure out how to split it up | 12:54 |
dtantsur | several patches for several things are fine with me | 12:54 |
rloo | dtantsur: ok, i'll reference a bug, it isn't user-facing. not this one anyway. | 12:55 |
rloo | dtantsur: thx for feedback! | 12:55 |
dtantsur | np, thank you! | 12:55 |
* rloo glad folks read my emails :) | 12:55 | |
dtantsur | :) | 12:55 |
* dtantsur gets back to learning German | 12:56 | |
rloo | dtantsur: danke! | 12:56 |
*** mat128 has quit IRC | 13:00 | |
*** sasha21 has joined #openstack-ironic | 13:01 | |
*** d0ugal has quit IRC | 13:02 | |
*** d0ugal has joined #openstack-ironic | 13:03 | |
*** d0ugal has quit IRC | 13:03 | |
*** d0ugal has joined #openstack-ironic | 13:03 | |
*** jcoufal has joined #openstack-ironic | 13:09 | |
*** Goneri has joined #openstack-ironic | 13:13 | |
openstackgerrit | Merged openstack/ironic master: Revert "Change pxe dhcp options name to codes." https://review.openstack.org/505797 | 13:23 |
openstackgerrit | Merged openstack/ironic stable/pike: Document setting discover_hosts_in_cells_interval in nova.conf https://review.openstack.org/505777 | 13:24 |
*** rbudden has quit IRC | 13:26 | |
*** weshay is now known as weshay_bbiab | 13:30 | |
*** milan has quit IRC | 13:31 | |
*** rbudden has joined #openstack-ironic | 13:34 | |
*** baoli has joined #openstack-ironic | 13:43 | |
*** mat128 has joined #openstack-ironic | 13:46 | |
*** racedo has joined #openstack-ironic | 13:46 | |
rajinir | sambetts>dtansur:fellypefca> vsaienk0> thanks for reverting the patch. Definitely broke our CI. We don't have anything custom. | 13:47 |
*** mjturek has joined #openstack-ironic | 13:55 | |
*** yangyapeng has joined #openstack-ironic | 13:59 | |
openstackgerrit | Stenio Araujo proposed openstack/ironic master: [DNM|WIP] Use mac virtual for OneView drivers https://review.openstack.org/485618 | 14:00 |
*** mjturek has quit IRC | 14:00 | |
fellypefca | vsaienk0, dtantsur all-green here at oneview too https://review.openstack.org/#/c/506074/ | 14:00 |
patchbot | patch 506074 - ironic - WIP: pass both numbered and named dhcp options | 14:00 |
vsaienk0 | fellypefca: it is a hacky, we want to avoid doing that | 14:01 |
fellypefca | vsaienk0 oh, ok | 14:02 |
vsaienk0 | I'm doubt why numbered options doesn't work | 14:02 |
TheJulia | Good morning everyone | 14:02 |
sambetts | vsaienk0: https://review.openstack.org/#/c/506128/ turning iPXE off in the gate results in timeouts across the board trying to download pxelinux.0 | 14:02 |
patchbot | patch 506128 - ironic - [DNM] Disable iPXE and make sure normal PXE works | 14:02 |
sambetts | http://paste.openstack.org/show/621627/ | 14:03 |
sambetts | VM console log ^ | 14:03 |
TheJulia | fun :( | 14:05 |
sambetts | vsaienk0: I put that patch up pre-revert | 14:06 |
pas-ha | I think the posgresql job is also using the PXE (no iPXE) and it is red for quite long already | 14:06 |
sambetts | le sigh... | 14:06 |
openstackgerrit | Sam Betts proposed openstack/ironic master: [DNM] Disable iPXE and make sure normal PXE works https://review.openstack.org/506128 | 14:06 |
sambetts | rerunning ^ post-revert | 14:07 |
sambetts | see if it makes a difference | 14:07 |
mariojv | hi all - i have a question | 14:09 |
mariojv | would anyone be interested in more thorough ironic UI docs? if you compare https://docs.openstack.org/horizon/latest/ to https://docs.openstack.org/ironic-ui/latest/ it's really just an install guide | 14:09 |
mariojv | i've never used ironic ui in horizon, so i'm not sure how intuitive it is | 14:10 |
sambetts | mariojv: more docs always == better, think configuration references, admin guides on enabling any features that are not enabled by default | 14:10 |
mariojv | cool - idk if i will personally get time to make them, but i hope so :) | 14:11 |
openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/ironic master: Add default configuration files to data_files https://review.openstack.org/506198 | 14:11 |
*** crushil_ has joined #openstack-ironic | 14:14 | |
*** mjturek has joined #openstack-ironic | 14:14 | |
*** crushil has joined #openstack-ironic | 14:14 | |
*** crushil has quit IRC | 14:15 | |
*** crushil_ is now known as crushil | 14:15 | |
dtantsur | mariojv++ docs++ :) | 14:15 |
dtantsur | morning TheJulia | 14:15 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic master: WIP: try to disable map file https://review.openstack.org/506202 | 14:15 |
*** zshi__ has joined #openstack-ironic | 14:16 | |
openstackgerrit | Ruby Loo proposed openstack/ironic master: No 'next' for GET /nodes?limit=1&instance_uuid= https://review.openstack.org/506205 | 14:18 |
sambetts | vsaienk0: I think the map file is definatly the cause of some of these issues, in the devstack plugin we write out the map-file in the way our docs describe for iPXE, https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L1923 | 14:19 |
dtantsur | rloo: tbh I read things like "No 'next'" as if you were removing them, not adding :( | 14:19 |
dtantsur | mmm, that meant to be :) | 14:19 |
dtantsur | which reminds me of taking a break, brb | 14:19 |
*** dtantsur is now known as dtantsur|brb | 14:20 | |
rloo | dtantsur: i am removing it :) | 14:20 |
dtantsur|brb | rloo: ah, nice, then it's correct :) I'd still use explicit verbs like Add or Remove | 14:20 |
rloo | dtantsur|brb: i can try, i was trying to fit w/i 50 chars :-( | 14:20 |
dtantsur|brb | because some contributors use titles like "No smth" when they're adding smth | 14:20 |
* dtantsur|brb tend to care less about number of chars | 14:21 | |
rloo | dtantsur|brb: ah, if folks don't care about the 50 char thing, that makes things easier! | 14:21 |
vsaienk0 | sambetts: do we even need map-file when using native ipxe? ipxe will never contact our tftp | 14:23 |
sambetts | vsaienk0: I don't think so :/ | 14:23 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Remove 'next' for GET /nodes?limit=1&instance_uuid= https://review.openstack.org/506205 | 14:24 |
vsaienk0 | the benefit of ipxe is that we can store ramdisk on http because it is much faster | 14:24 |
vsaienk0 | I doubt what is the case to use ipxe which gets files from tftp | 14:24 |
sambetts | there isn't one really, its just the iPXE firmware supports normal PXE so its good for testing both | 14:25 |
sambetts | the reason we setup the map file is to PXE chain to iPXE | 14:26 |
openstackgerrit | Merged openstack/python-ironicclient stable/pike: Updated from global requirements https://review.openstack.org/505878 | 14:29 |
*** racedo has quit IRC | 14:31 | |
openstackgerrit | Merged openstack/bifrost master: Cleanup test-requirements https://review.openstack.org/505687 | 14:32 |
*** openstackgerrit has quit IRC | 14:33 | |
TheJulia | mariojv: two pieces of context, on ironic-ui, it is an admin pane, and there are a couple tunables if memory serves | 14:34 |
mariojv | alright - i was thinking more "here's how to use ironic-ui" | 14:41 |
mariojv | config/tunable docs would be good too though | 14:42 |
*** chandankumar has joined #openstack-ironic | 14:42 | |
*** fellypefca is now known as fellypefca-brb | 14:44 | |
* mjturek waves to mariojv | 14:46 | |
NobodyCam | Good Morning Ironic'ers | 15:01 |
*** openstackgerrit has joined #openstack-ironic | 15:01 | |
openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/ironic master: Add default configuration files to data_files https://review.openstack.org/506198 | 15:01 |
openstackgerrit | Oksana Voshchana proposed openstack/ironic master: Use uWSGI instead of WSGI https://review.openstack.org/458394 | 15:04 |
vsaienk0 | morning NobodyCam | 15:07 |
*** links has quit IRC | 15:07 | |
NobodyCam | hey there good morning vsaienk0 :) | 15:07 |
*** trown is now known as trown|brb | 15:10 | |
*** trown|brb is now known as trown | 15:14 | |
* aNuposic anupn | 15:23 | |
*** aNuposic is now known as anupn | 15:24 | |
anupn | Good Morning Ironic'ers :) | 15:24 |
*** amarao1 has quit IRC | 15:27 | |
*** amarao2 has joined #openstack-ironic | 15:27 | |
*** amarao2 has quit IRC | 15:30 | |
*** marios has quit IRC | 15:30 | |
*** marios has joined #openstack-ironic | 15:31 | |
*** rpioso has joined #openstack-ironic | 15:37 | |
*** e0ne has quit IRC | 15:40 | |
openstackgerrit | zhangyangyang proposed openstack/python-ironicclient master: Cleanup test-requirements https://review.openstack.org/506265 | 15:40 |
vsaienk0 | rloo: have you checked this? https://bugs.launchpad.net/ironic/+bug/1715541 I tried to request with limit and fields and get correct result | 15:42 |
openstack | Launchpad bug 1715541 in Ironic "Listing resources with 'fields' and 'limit' doesn't return a 'next' link correctly" [Undecided,New] | 15:42 |
rloo | vsaienk0: i just saw that bug, it is a dup of the other one. (and got sidetracked) | 15:43 |
rloo | vsaienk0: you actually got a 'next' link that has the fields=... in the url? | 15:43 |
rloo | vsaienk0: i have a fix for it, just writing up the release notes and need to open another bug cuz it isn't just fields, other prameters are missing too | 15:44 |
*** milan has joined #openstack-ironic | 15:44 | |
vsaienk0 | rloo: right no fields in next http://paste.openstack.org/show/621638/ | 15:44 |
rloo | vsaienk0: that's the bug, so you reproduced it | 15:45 |
NobodyCam | Good Morning anupn and rloo :) | 15:50 |
rloo | Morning NobodyCam, anupn, vsaienk0, mjturek, mariojv!, sambetts, TheJulia and everyone else (or did I already say that...) | 15:51 |
NobodyCam | hehehe :) | 15:52 |
mjturek | gm rloo, NobodyCam :) | 15:52 |
NobodyCam | morning mjturek :) | 15:52 |
*** trown is now known as trown|brb | 15:53 | |
* sambetts --> heading off | 15:54 | |
*** sambetts is now known as sambetts|afk | 15:54 | |
sambetts|afk | Night all! | 15:54 |
NobodyCam | have a good night sambetts|afk | 15:54 |
*** jaganathan has quit IRC | 15:55 | |
*** hshiina has joined #openstack-ironic | 15:57 | |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Remove 'next' for GET /nodes?limit=1&instance_uuid= https://review.openstack.org/506205 | 15:57 |
rloo | mjturek: ^^ thx for reviewing | 15:58 |
mjturek | np rloo! | 16:00 |
TheJulia | good morning rloo | 16:00 |
TheJulia | BFV meeting now starting in #openstack-meeting-5 | 16:01 |
*** fellypefca-brb is now known as fellypefca | 16:01 | |
openstackgerrit | Ruby Loo proposed openstack/ironic master: ListType preserves the order of the input https://review.openstack.org/505837 | 16:01 |
*** trown|brb is now known as trown | 16:01 | |
*** ralonsoh has quit IRC | 16:02 | |
TheJulia | mjturek: Do you have time to join the BFV meeting? | 16:02 |
mjturek | just did! | 16:02 |
*** ralonsoh has joined #openstack-ironic | 16:02 | |
*** ralonsoh has quit IRC | 16:02 | |
*** milan has quit IRC | 16:06 | |
*** weshay_bbiab is now known as weshay | 16:07 | |
*** marios has quit IRC | 16:09 | |
*** zshi__ has quit IRC | 16:14 | |
*** mjura has quit IRC | 16:19 | |
jlvillal | pas-ha: Can https://review.openstack.org/#/c/505239/ just be rebased onto the tip of master? | 16:22 |
patchbot | patch 505239 - ironic - Cleanup test-requirements | 16:22 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Add missing query parameters to 'next' link for GET /nodes?... https://review.openstack.org/506280 | 16:30 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Remove 'next' for GET /nodes?limit=1&instance_uuid= https://review.openstack.org/506205 | 16:31 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Add missing query parameters to 'next' link for GET /nodes?... https://review.openstack.org/506280 | 16:31 |
*** rama_y has joined #openstack-ironic | 16:34 | |
*** hshiina has quit IRC | 16:45 | |
*** dtantsur|brb is now known as dtantsur | 16:46 | |
dtantsur | morning NobodyCam, jlvillal, anupn, mjturek | 16:46 |
jlvillal | Hi | 16:46 |
NobodyCam | hey hey Good Morning dtantsur :) ... its almost Friday | 16:47 |
jlvillal | rloo: On https://review.openstack.org/#/c/506205/ Shouldn't it in general not return a 'next' link if there are no more items? I've only looked at the patch for 20 seconds :) | 16:47 |
patchbot | patch 506205 - ironic - Remove 'next' for GET /nodes?limit=1&instance_uuid= | 16:47 |
rloo | jlvillal: yes, in general | 16:48 |
rloo | jlvillal: how do you know there are no more items? | 16:48 |
jlvillal | rloo: I don't know :) I thought you knew ;) | 16:48 |
rloo | jlvillal: in collections.py (or something like that), it uses a simple test (that mjturek mentions in that patch) | 16:48 |
rloo | jlvillal: so, unless you 'look ahead' you don't know if there are more resources. | 16:49 |
*** jtomasek has quit IRC | 16:49 | |
jlvillal | rloo: Okay. So just curious. What happens in the case where there is a next link, but nothing there? | 16:49 |
rloo | jlvillal: so the code checks if the #resources returned is < limit requested, you know there are no more. | 16:50 |
*** tesseract has quit IRC | 16:50 | |
rloo | jlvillal: if # resources returned == limit, you don't know, but good chance there might be more | 16:50 |
*** jtomasek has joined #openstack-ironic | 16:50 | |
rloo | jlvillal: i originally thought it'd be a quick fix to fix the missing 'fields' query param in the 'next' url. but found these other bugs :-( | 16:51 |
jlvillal | :( | 16:51 |
rloo | jlvillal: i guess on the bright side, folks are noticing it now cuz they have > 1000 nodes! | 16:51 |
*** rcernin has quit IRC | 16:52 | |
jlvillal | rloo: Left a comment/question | 16:53 |
rloo | jlvillal: i think there is something about the code that you dont' understand. not that it is easilyl understood :-( | 16:54 |
rloo | jlvillal: (and no, I didn't write it) | 16:54 |
jlvillal | rloo: That could be the case. | 16:54 |
jlvillal | rloo: Oh I see, I thought parameters was passed in. NVM | 16:55 |
rloo | jlvillal: basically there are two paths there. 1 get node associated with instance uuid, or 2. get nodes based on the other filtering criteria. | 16:55 |
rloo | jlvillal: yeah, that. | 16:55 |
jlvillal | rloo: Though now we are ignoring 'maintenance' and 'associated'. Where before we did seem to honor that. | 16:58 |
rloo | jlvillal: i moved those cuz they are only relevant/used for a 'next' link. for instance_uuid filtering, we never want to have a 'next' link; it doesn't make sense. | 16:59 |
jlvillal | rloo: Sorry we have to evacuate the building immediately | 16:59 |
rloo | jlvillal: so it was confusing to me the way the code was, cuz it didn't make sense. | 16:59 |
rloo | jlvillal: BYE | 16:59 |
* anupn missed so many morning wishes ;) | 17:00 | |
*** baoli has quit IRC | 17:00 | |
*** baoli has joined #openstack-ironic | 17:01 | |
*** derekh has quit IRC | 17:02 | |
*** trown is now known as trown|lunch | 17:07 | |
NobodyCam | jlvillal: Hope everything is okay :/ | 17:12 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: [reno] update for MAC address update fix https://review.openstack.org/506314 | 17:13 |
jlvillal | NobodyCam: Just an evacuation drill. All done :) | 17:20 |
NobodyCam | :) | 17:20 |
NobodyCam | thats a good thing :) | 17:21 |
*** dpawar has joined #openstack-ironic | 17:23 | |
*** osdev has quit IRC | 17:24 | |
*** mat128 has quit IRC | 17:32 | |
*** crushil has quit IRC | 17:38 | |
*** crushil has joined #openstack-ironic | 17:38 | |
*** mat128 has joined #openstack-ironic | 17:43 | |
*** mat128 has quit IRC | 17:47 | |
rloo | mjturek: thx for your comments to https://review.openstack.org/#/c/506205/. let me know if i have addressed them. in essence, the 'next' link is meant to get you more nodes that are filtered based on the same criteria. | 17:49 |
patchbot | patch 506205 - ironic - Remove 'next' for GET /nodes?limit=1&instance_uuid= | 17:49 |
*** mat128 has joined #openstack-ironic | 17:49 | |
*** srobert has joined #openstack-ironic | 17:51 | |
*** srobert has quit IRC | 17:52 | |
*** srobert has joined #openstack-ironic | 17:52 | |
*** amarao1 has joined #openstack-ironic | 17:54 | |
*** srobert_ has joined #openstack-ironic | 17:55 | |
*** ijw has joined #openstack-ironic | 17:56 | |
*** ianychoi has quit IRC | 17:57 | |
*** Sukhdev has joined #openstack-ironic | 17:57 | |
*** ianychoi has joined #openstack-ironic | 17:58 | |
*** srobert has quit IRC | 17:58 | |
*** dpawar has quit IRC | 17:58 | |
*** mat128 has quit IRC | 18:02 | |
*** Sukhdev has quit IRC | 18:03 | |
*** amarao1 has quit IRC | 18:05 | |
*** crushil has quit IRC | 18:06 | |
dtantsur | ugh, I haven't finished even one third of my PTG summary, and I already have a squared head >_< | 18:07 |
dtantsur | I guess I'll get some wine and continue tomorrow | 18:08 |
NobodyCam | :) | 18:08 |
dtantsur | see you | 18:08 |
*** dtantsur is now known as dtantsur|afk | 18:08 | |
NobodyCam | have a good nit | 18:08 |
NobodyCam | night even | 18:08 |
*** mat128 has joined #openstack-ironic | 18:16 | |
-openstackstatus- NOTICE: Gerrit OpenIDs have been accidentally overwritten and are in the process of being restored | 18:17 | |
jlvillal | What does that mean? | 18:17 |
NobodyCam | lol they just deleted all our accounts | 18:17 |
NobodyCam | would be my guess | 18:18 |
jlvillal | NobodyCam: Yeah, a bit more detail would be nice | 18:18 |
NobodyCam | hehehe | 18:19 |
NobodyCam | I'll wait for the RCA | 18:19 |
jlvillal | Supposedly if you had logged out and back in, you would get somebody elses account. | 18:19 |
NobodyCam | oh thats bad | 18:19 |
jlvillal | Yeah. So gerrit be down... | 18:19 |
NobodyCam | oh joy just lost power | 18:21 |
* jlvillal decides to go have lunch | 18:21 | |
rloo | good time to take a break... | 18:21 |
NobodyCam | :) | 18:22 |
-openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being taken offline briefly to perform database repair work but should be back up shortly | 18:22 | |
*** ChanServ changes topic to "The Gerrit service on review.openstack.org is being taken offline briefly to perform database repair work but should be back up shortly" | 18:22 | |
NobodyCam | and there it is | 18:22 |
*** ijw has quit IRC | 18:25 | |
*** pooja has joined #openstack-ironic | 18:25 | |
*** crushil has joined #openstack-ironic | 18:28 | |
*** ijw has joined #openstack-ironic | 18:29 | |
*** ChubYann has joined #openstack-ironic | 18:30 | |
*** vsaienko has joined #openstack-ironic | 18:34 | |
*** trown|lunch is now known as trown | 18:36 | |
*** fellypefca has quit IRC | 18:47 | |
*** etingof has quit IRC | 18:51 | |
*** ijw has quit IRC | 18:52 | |
mjturek | rloo: sorry for being confusing. In my example, pretend there are 1000 nodes, but only one in the available provision state. if you query for nodes in the available provision state you'll only get one and a next link (linking to no more nodes), is that right? | 18:53 |
rloo | mjturek: right, if you tried the next link, you'd get 0 nodes | 18:54 |
rloo | mjturek: i mean, *after* we fix the bug about that | 18:54 |
*** MattMan has quit IRC | 18:55 | |
mjturek | ahhhh I see, so having the "next" link is intended outside of the querying by uuid | 18:55 |
mjturek | ? | 18:55 |
*** MattMan has joined #openstack-ironic | 18:55 | |
rloo | mjturek: not sure hwat you mean. | 18:55 |
rloo | mjturek: think of it as 'pagination' | 18:55 |
rloo | mjturek: you have a query, and you want the results, but say, 10 results at a time. | 18:56 |
rloo | mjturek: the 'next' url is meant to give you the next X results, for that original query | 18:56 |
rloo | mjturek: similar to what you see on websites, when there are pages associatedwith a particular search | 18:56 |
mjturek | yep, that's understood | 18:56 |
mjturek | but your patch is getting rid of the "next" link when querying by node_uuid (because there's 1 node). If any query results in 1 node (and there's a pagination limit of 1), we still want the next link? | 18:57 |
mjturek | basically I'm asking, in the example above (1000 nodes, 1 in available state, query for available nodes), you would actually want to have the next link leading to zero nodes? | 19:00 |
rloo | mjturek: that patch is getting rid of the 'next' link when querying by instance_uuid (you can't query by node_uuid) | 19:01 |
mjturek | ahhh okay understood | 19:01 |
rloo | mjturek: that query can produce at most 1 node. so there cannot be a next link; it doesn't make sense. | 19:01 |
mjturek | yeah agreed | 19:01 |
rloo | mjturek: in your example, there are 1000 nodes, does the request have limit=1&provision_state=available? | 19:02 |
mjturek | yes, no instance_uuid=, just those criteria | 19:02 |
rloo | mjturek: ok, so you do this query, you expect it to return at most one node cuz you specified limit=1. the response has one node and a next URL. you invoke the next URL, there are no more avail nodes after the one returned in the first request. done. | 19:03 |
rloo | mjturek: are you stuck on the 'if there is only one avail node', why would we return the 'next' link? | 19:04 |
mjturek | yeah, exactly | 19:05 |
*** penick_ has joined #openstack-ironic | 19:07 | |
rloo | mjturek: so ideally, as gods, we can see that there is only one node that satisfies that query, and we wouldn't return the 'next' link. however, the way the code is written, there is no 'look ahead'. so we don't know if there are more nodes or not. | 19:08 |
mjturek | ahhhhhhhhhh - okay awesome | 19:08 |
mjturek | so ideally we wouldn't but we basically have to | 19:08 |
mjturek | sorry for all the questions rloo, just trying to understand :) thanks for working through it | 19:09 |
rloo | mjturek: right. i don't know if it is a bug or not. and i guess someone could try to clean it up. but given everything else on our plate i don't think it is worth it | 19:09 |
mjturek | yeah totally understandable | 19:09 |
rloo | mjturek: no worries. i suppose someone could try to add comments in the code to explain it... | 19:10 |
rloo | mjturek: i mean, to be consistent, i suppose we could issue a 'next' link for the instance_uuid case, but it just doesn't make sense to me, and easier to not return it than to clean up the code to return the right 'next' link for that case. | 19:10 |
rloo | mjturek: forget that. we *know* there will be at most 1 result, the 'next' link doesn't make sense there. | 19:11 |
mjturek | right, which is what I was getting at in my second comment, do we want to consider consistency? But agreed. If we can avoid having a meaningless next link, we should | 19:11 |
*** etingof has joined #openstack-ironic | 19:12 | |
rloo | mjturek: it isn't 'consistent' anyway. the handling of instance_uuid is odd to me. i don't understand why it doesn't do an AND of all the query parameters. | 19:13 |
rloo | mjturek: the good news is that it is only at the REST API layer. you can't invoke that via the CLI. | 19:13 |
rloo | mjturek: the CLI provides an openstack baremetal node show --instance-uuid (or something like that) | 19:14 |
rloo | mjturek: all this to actually fix what i meant to fix (the patch after that...) | 19:14 |
mjturek | rloo: ahhhhh, that makes sense :). I'll review that next! | 19:15 |
*** ijw has joined #openstack-ironic | 19:17 | |
*** ChanServ changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic" | 19:20 | |
-openstackstatus- NOTICE: OpenIDs for the Gerrit service have been restored from a recent backup and the service is running again; before/after table states are being analyzed now to identify any remaining cleanup needed for changes made to accounts today | 19:20 | |
*** e0ne has joined #openstack-ironic | 19:21 | |
*** ijw has quit IRC | 19:22 | |
rloo | yay, we can work again :) ^^ | 19:28 |
*** etingof has quit IRC | 19:31 | |
*** e0ne has quit IRC | 19:31 | |
*** etingof has joined #openstack-ironic | 19:32 | |
*** jaypipes has quit IRC | 19:35 | |
*** pcaruana has quit IRC | 19:41 | |
*** crushil has quit IRC | 19:43 | |
*** crushil has joined #openstack-ironic | 19:44 | |
*** weshay is now known as weshay_bbiab | 19:50 | |
NobodyCam | :) | 19:50 |
openstackgerrit | Vasyl Saienko proposed openstack/ironic master: WIP: Revert "Revert "Change pxe dhcp options name to codes."" https://review.openstack.org/506173 | 19:53 |
*** mat128 has quit IRC | 19:54 | |
*** ricardoas has joined #openstack-ironic | 19:59 | |
*** causten has joined #openstack-ironic | 20:01 | |
*** ijw has joined #openstack-ironic | 20:06 | |
*** crushil has quit IRC | 20:09 | |
*** crushil has joined #openstack-ironic | 20:09 | |
rloo | folks, are any of you planning on reviewing the ansible spec? If not, I'm going to approve it today. | 20:10 |
*** ijw has quit IRC | 20:11 | |
*** crushil has quit IRC | 20:26 | |
*** ijw has joined #openstack-ironic | 20:27 | |
TheJulia | rloo: I had reviewed it recently | 20:31 |
TheJulia | but... looks like it doesn't show :( | 20:31 |
rloo | TheJulia: :-( did your comments get lost? | 20:32 |
TheJulia | This is the second time I've had major deja vu | 20:32 |
TheJulia | oh, nope, found it | 20:32 |
* TheJulia diffs | 20:32 | |
TheJulia | lgtm | 20:35 |
*** dsneddon has quit IRC | 20:36 | |
rloo | thx TheJulia! | 20:37 |
*** ijw has quit IRC | 20:38 | |
openstackgerrit | Merged openstack/ironic-specs master: Promote Ansible deploy driver to ironic https://review.openstack.org/241946 | 20:38 |
*** dsneddon has joined #openstack-ironic | 20:40 | |
*** jkilpatr has quit IRC | 20:47 | |
*** ntpttr_laptop has joined #openstack-ironic | 20:49 | |
ntpttr_laptop | hey all, I'm looking into writing a driver for Rack Scale Design hardware and am working on getting a spec together. I found the spec deprecating 'classic drivers' in favor of hardware types, can someone tell me what is meant by classic driver? | 20:50 |
ntpttr_laptop | what should that mean for my spec? We're working on getting together a CI for RSD hardware as well. | 20:50 |
rloo | ntpttr_laptop: this is the spec about the hardware types: http://specs.openstack.org/openstack/ironic-specs/specs/7.0/driver-composition-reform.html | 20:52 |
rloo | ntpttr_laptop: i'm guessing you'd have a 'rsd' hardware type | 20:52 |
ntpttr_laptop | thank you rloo I'll take a look at that | 20:52 |
ntpttr_laptop | I would guess you're right about that :) | 20:52 |
jlvillal | rloo: do they need to do a release to make your patch go active? https://review.openstack.org/#/c/505348/ | 20:53 |
patchbot | patch 505348 - openstackdocstheme - No red with double backticks markup (MERGED) | 20:53 |
rloo | jlvillal: yup | 20:53 |
jlvillal | rloo: Okay. Hopefully soon :) And thanks for that. | 20:54 |
rloo | jlvillal: it was less painful than i thought. i mean wrt no one actually disagreeing with me. doing the patch, well, i had to figure out how that stuff worked ;) | 20:54 |
*** trown is now known as trown|outtypewww | 20:58 | |
NobodyCam | LOL | 20:59 |
NobodyCam | me: oh thats easy one line | 20:59 |
NobodyCam | reality: 7 files changed, 152 insertions(+), 2 deletions(-) | 20:59 |
rloo | ntpttr_laptop: these might help (or not): https://docs.openstack.org/ironic/latest/admin/upgrade-to-hardware-types.html, https://docs.openstack.org/ironic/latest/install/enabling-drivers.html | 20:59 |
*** bfournie has quit IRC | 21:01 | |
*** hamzy has quit IRC | 21:03 | |
*** jkilpatr has joined #openstack-ironic | 21:04 | |
*** jcoufal has quit IRC | 21:06 | |
ntpttr_laptop | thanks rloo | 21:07 |
*** catintheroof has quit IRC | 21:07 | |
*** ijw has joined #openstack-ironic | 21:15 | |
*** ijw has quit IRC | 21:19 | |
*** rama_y has quit IRC | 21:20 | |
*** rama_y_ has joined #openstack-ironic | 21:20 | |
*** rama_y__ has joined #openstack-ironic | 21:21 | |
*** rama_y_ has quit IRC | 21:21 | |
*** rloo has quit IRC | 21:23 | |
*** rloo has joined #openstack-ironic | 21:23 | |
*** baoli has quit IRC | 21:23 | |
*** mjturek has quit IRC | 21:25 | |
openstackgerrit | Ruby Loo proposed openstack/ironic master: main page: add links to docs on Upgrade to HW Types https://review.openstack.org/506382 | 21:25 |
openstackgerrit | John L. Villalovos proposed openstack/ironic master: Configuration option [ipmi]/retry_timeout has been removed. https://review.openstack.org/506386 | 21:28 |
*** Sukhdev has joined #openstack-ironic | 21:28 | |
*** Goneri has quit IRC | 21:35 | |
*** dprince has quit IRC | 21:42 | |
*** makowals_ has joined #openstack-ironic | 21:44 | |
*** zhenguo has quit IRC | 21:45 | |
*** fdegir has quit IRC | 21:45 | |
*** fdegir has joined #openstack-ironic | 21:45 | |
*** adisky has quit IRC | 21:46 | |
*** pas-ha has quit IRC | 21:47 | |
*** makowals has quit IRC | 21:47 | |
*** jroll has quit IRC | 21:47 | |
*** dr_gogeta86 has quit IRC | 21:48 | |
*** sergek_ has quit IRC | 21:48 | |
*** pas-ha has joined #openstack-ironic | 21:48 | |
*** adisky has joined #openstack-ironic | 21:48 | |
*** amotoki has quit IRC | 21:48 | |
*** sergek_ has joined #openstack-ironic | 21:50 | |
*** amotoki has joined #openstack-ironic | 21:51 | |
*** dr_gogeta86 has joined #openstack-ironic | 21:53 | |
*** dr_gogeta86 has quit IRC | 21:53 | |
*** dr_gogeta86 has joined #openstack-ironic | 21:53 | |
*** zhenguo has joined #openstack-ironic | 22:01 | |
*** jroll has joined #openstack-ironic | 22:01 | |
openstackgerrit | Nate Potter proposed openstack/ironic-specs master: Add Intel Rack Scale Design Driver https://review.openstack.org/506400 | 22:09 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Rolling upgrades related dev documentation https://review.openstack.org/419439 | 22:09 |
openstackgerrit | Nate Potter proposed openstack/ironic-specs master: Add Intel Rack Scale Design Driver https://review.openstack.org/506400 | 22:10 |
*** ijw has joined #openstack-ironic | 22:13 | |
*** srobert_ has quit IRC | 22:16 | |
* TheJulia tries to remember all of the reasoning behind cleanhold | 22:17 | |
*** mcarden has joined #openstack-ironic | 22:17 | |
*** yolanda has quit IRC | 22:18 | |
*** yolanda has joined #openstack-ironic | 22:20 | |
*** Nisha_Agarwal has joined #openstack-ironic | 22:27 | |
*** bfournie has joined #openstack-ironic | 22:31 | |
*** penick_ has quit IRC | 22:31 | |
*** bfournie has quit IRC | 22:34 | |
*** Nisha_Agarwal has quit IRC | 22:34 | |
*** Nisha_ has joined #openstack-ironic | 22:34 | |
* jlvillal sighs when cleaning up some unit tests and discovers some pre-existing problems... | 22:35 | |
TheJulia | I feel like that is the nature of the universe | 22:36 |
*** sasha21 has quit IRC | 22:37 | |
jlvillal | TheJulia: This. https://review.openstack.org/#/c/293873/29/ironic/tests/unit/drivers/modules/test_ipmitool.py@1040 | 22:37 |
patchbot | patch 293873 - ironic - IPMITool: add IPMISocatConsole and IPMIConsole class (MERGED) | 22:37 |
jlvillal | TheJulia: They renamed the mocks and thought it worked like that | 22:37 |
jlvillal | TheJulia: But 'make_password_file' mock is not passed to the function. It is defined. | 22:38 |
*** sasha21 has joined #openstack-ironic | 22:38 | |
* jlvillal goes to clean it up | 22:38 | |
* TheJulia sighs | 22:39 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic master: Cleanup unit tests for ipmittool https://review.openstack.org/506413 | 22:54 |
*** Sukhdev has quit IRC | 22:57 | |
*** Nisha_ has quit IRC | 23:00 | |
*** Nisha_ has joined #openstack-ironic | 23:00 | |
NobodyCam | off the wall question... anyone know if I can force a bmc (iLo in this case) to refresh it dhcp'd IP with a factory reset? | 23:01 |
openstackgerrit | John L. Villalovos proposed openstack/ironic master: Cleanup unit tests for ipmittool https://review.openstack.org/506413 | 23:01 |
NobodyCam | s/it/it's/ | 23:01 |
NobodyCam | s/with/with OUT/ | 23:01 |
jlvillal | NobodyCam: I don't know | 23:02 |
*** penick has joined #openstack-ironic | 23:02 | |
*** bfournie has joined #openstack-ironic | 23:04 | |
*** penick has quit IRC | 23:06 | |
*** hamzy has joined #openstack-ironic | 23:15 | |
*** rpioso has quit IRC | 23:15 | |
*** ijw has quit IRC | 23:18 | |
TheJulia | NobodyCam: no idea :( | 23:23 |
openstackgerrit | Nate Potter proposed openstack/ironic-specs master: Add Intel Rack Scale Design Driver https://review.openstack.org/506400 | 23:30 |
*** rloo has quit IRC | 23:32 | |
*** Nisha_away has joined #openstack-ironic | 23:35 | |
*** Nisha_ has quit IRC | 23:35 | |
*** Nisha_ has joined #openstack-ironic | 23:39 | |
*** Nisha_away has quit IRC | 23:39 | |
*** Nisha_away has joined #openstack-ironic | 23:42 | |
*** Nisha_ has quit IRC | 23:42 | |
NobodyCam | :) | 23:43 |
*** Nisha_away has quit IRC | 23:46 | |
*** alineb has quit IRC | 23:54 | |
*** Goneri has joined #openstack-ironic | 23:55 | |
*** ntpttr_laptop has quit IRC | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!