| *** catintheroof has quit IRC | 00:00 | |
| *** yangyapeng has quit IRC | 00:07 | |
| *** yangyapeng has joined #openstack-ironic | 00:07 | |
| *** baoli has quit IRC | 00:08 | |
| *** yangyapeng has quit IRC | 00:08 | |
| *** yangyapeng has joined #openstack-ironic | 00:08 | |
| *** yangyapeng has quit IRC | 00:13 | |
| *** rama_y has quit IRC | 00:24 | |
| *** charcol has quit IRC | 00:34 | |
| *** charcol has joined #openstack-ironic | 00:40 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 00:48 | |
| *** AlexeyAbashkin has quit IRC | 00:52 | |
| *** phuongnh has joined #openstack-ironic | 01:04 | |
| *** yangyapeng has joined #openstack-ironic | 01:17 | |
| *** zshi__ has joined #openstack-ironic | 01:17 | |
| *** catintheroof has joined #openstack-ironic | 01:19 | |
| openstackgerrit | Merged openstack/ironic-python-agent master: Fix OSError catch https://review.openstack.org/501386 | 01:19 |
|---|---|---|
| *** catintheroof has quit IRC | 01:21 | |
| *** ijw has joined #openstack-ironic | 01:25 | |
| *** ijw has quit IRC | 01:25 | |
| *** ijw has joined #openstack-ironic | 01:27 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 01:28 | |
| *** AlexeyAbashkin has quit IRC | 01:32 | |
| *** zhangfei has joined #openstack-ironic | 01:35 | |
| *** jkilpatr_ has quit IRC | 01:37 | |
| *** links has joined #openstack-ironic | 01:44 | |
| *** links is now known as Jaison|away | 01:45 | |
| *** chlong has joined #openstack-ironic | 01:49 | |
| *** masber has quit IRC | 02:07 | |
| *** trungnv has quit IRC | 02:18 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 02:27 | |
| *** ijw has quit IRC | 02:31 | |
| *** AlexeyAbashkin has quit IRC | 02:31 | |
| *** jhesketh has quit IRC | 02:35 | |
| *** mcarden has quit IRC | 02:36 | |
| *** tonyb has quit IRC | 02:36 | |
| *** cinerama has quit IRC | 02:36 | |
| *** mcarden has joined #openstack-ironic | 02:37 | |
| *** JayF has quit IRC | 02:37 | |
| *** tonyb has joined #openstack-ironic | 02:37 | |
| *** jhesketh has joined #openstack-ironic | 02:38 | |
| *** JayF has joined #openstack-ironic | 02:40 | |
| *** cinerama has joined #openstack-ironic | 02:41 | |
| *** mat128 has quit IRC | 02:42 | |
| *** sasha2 has quit IRC | 02:43 | |
| *** TuanLA has joined #openstack-ironic | 02:44 | |
| *** TuanLA has quit IRC | 02:44 | |
| *** masber has joined #openstack-ironic | 02:49 | |
| *** TuanLA has joined #openstack-ironic | 02:52 | |
| *** udesale has joined #openstack-ironic | 03:08 | |
| *** trungnv has joined #openstack-ironic | 03:17 | |
| *** Jaison|away is now known as links | 03:23 | |
| *** jlabarre has quit IRC | 03:24 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 03:26 | |
| *** rama_y has joined #openstack-ironic | 03:27 | |
| *** rama_y has quit IRC | 03:29 | |
| *** AlexeyAbashkin has quit IRC | 03:31 | |
| *** mtreinish has quit IRC | 03:42 | |
| *** mtreinish has joined #openstack-ironic | 03:42 | |
| *** TuanLA has quit IRC | 03:45 | |
| *** phuongnh has quit IRC | 03:45 | |
| *** TuanLA has joined #openstack-ironic | 03:46 | |
| *** phuongnh has joined #openstack-ironic | 03:46 | |
| *** masber has quit IRC | 03:46 | |
| *** udesale has quit IRC | 03:47 | |
| *** yangyapeng has quit IRC | 03:49 | |
| *** udesale has joined #openstack-ironic | 03:50 | |
| *** yangyapeng has joined #openstack-ironic | 03:50 | |
| *** udesale has quit IRC | 03:52 | |
| *** udesale has joined #openstack-ironic | 03:53 | |
| *** rbudden has quit IRC | 04:03 | |
| *** phuongnh has quit IRC | 04:05 | |
| *** phuongnh has joined #openstack-ironic | 04:05 | |
| *** trungnv has quit IRC | 04:10 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 04:26 | |
| *** AlexeyAbashkin has quit IRC | 04:31 | |
| *** marios has joined #openstack-ironic | 04:48 | |
| *** crushil has quit IRC | 04:52 | |
| *** rbartal has quit IRC | 04:53 | |
| openstackgerrit | zenghui.shi proposed openstack/ironic-specs master: Hardware interface for BIOS configuration https://review.openstack.org/496481 | 04:54 |
| *** mjura has joined #openstack-ironic | 05:11 | |
| *** jaganathan has joined #openstack-ironic | 05:23 | |
| *** ccamacho has quit IRC | 05:28 | |
| *** rama_y has joined #openstack-ironic | 05:35 | |
| *** rbudden has joined #openstack-ironic | 05:36 | |
| *** ChubYann has quit IRC | 05:36 | |
| *** yangyapeng has quit IRC | 05:49 | |
| *** yangyapeng has joined #openstack-ironic | 05:59 | |
| *** karthiks has joined #openstack-ironic | 06:02 | |
| *** rama_y has quit IRC | 06:04 | |
| *** e0ne has joined #openstack-ironic | 06:07 | |
| *** zshi__ has quit IRC | 06:07 | |
| *** rbudden has quit IRC | 06:11 | |
| *** rbudden has joined #openstack-ironic | 06:16 | |
| *** gcb has joined #openstack-ironic | 06:18 | |
| pas-ha | morning ironic :) | 06:21 |
| *** masber has joined #openstack-ironic | 06:21 | |
| *** vsaienk0 has joined #openstack-ironic | 06:23 | |
| *** noam_ has joined #openstack-ironic | 06:24 | |
| *** zshi__ has joined #openstack-ironic | 06:24 | |
| *** parlos has joined #openstack-ironic | 06:25 | |
| *** vsaienk0 has quit IRC | 06:33 | |
| *** jtomasek has joined #openstack-ironic | 06:34 | |
| *** jtomasek has quit IRC | 06:34 | |
| *** jtomasek has joined #openstack-ironic | 06:34 | |
| TuanLA | morning ironic, pas-ha | 06:36 |
| *** vsaienk0 has joined #openstack-ironic | 06:41 | |
| *** pcaruana has joined #openstack-ironic | 06:44 | |
| *** e0ne has quit IRC | 06:45 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic-python-agent master: Build tiny disk partitioned image with grub https://review.openstack.org/504888 | 06:46 |
| *** rbartal has joined #openstack-ironic | 06:52 | |
| openstackgerrit | Nam Nguyen Hoai proposed openstack/python-ironicclient master: Use generic user for both zuul v2 and v3 https://review.openstack.org/512510 | 06:59 |
| openstackgerrit | Debayan Ray proposed openstack/sushy master: Refining the resource refresh https://review.openstack.org/485799 | 07:00 |
| *** namnh has joined #openstack-ironic | 07:01 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic master: [devstack] Switch ironic to uWSGI https://review.openstack.org/507067 | 07:06 |
| *** mgoddard has joined #openstack-ironic | 07:08 | |
| *** tesseract has joined #openstack-ironic | 07:16 | |
| *** ccamacho has joined #openstack-ironic | 07:30 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 07:34 | |
| openstackgerrit | Nam Nguyen Hoai proposed openstack/python-ironicclient master: Use generic user for both zuul v2 and v3 https://review.openstack.org/512510 | 07:35 |
| openstackgerrit | zhufl proposed openstack/ironic master: Fix "import xx as xx" grammer https://review.openstack.org/512525 | 07:37 |
| *** trungnv has joined #openstack-ironic | 07:43 | |
| *** fragatina has joined #openstack-ironic | 07:48 | |
| *** fragatina has quit IRC | 07:49 | |
| *** ralonsoh has joined #openstack-ironic | 07:49 | |
| *** fragatina has joined #openstack-ironic | 07:49 | |
| *** ralonsoh_ has joined #openstack-ironic | 07:50 | |
| *** karimb has joined #openstack-ironic | 07:51 | |
| *** karimb has quit IRC | 07:52 | |
| *** ralonsoh has quit IRC | 07:54 | |
| *** ralonsoh_ is now known as ralonsoh | 07:55 | |
| *** hw_wutianwei has joined #openstack-ironic | 07:56 | |
| *** mgoddard has quit IRC | 07:57 | |
| openstackgerrit | Nguyen Hung Phuong proposed openstack/ironic master: Add additional capabilities discovery for iRMC driver https://review.openstack.org/417347 | 07:59 |
| *** zshi__ has quit IRC | 08:06 | |
| openstackgerrit | zhufl proposed openstack/ironic master: Fix missing print format error https://review.openstack.org/512535 | 08:17 |
| *** hw_wutianwei has quit IRC | 08:18 | |
| *** hw_wutianwei has joined #openstack-ironic | 08:19 | |
| *** zshi__ has joined #openstack-ironic | 08:19 | |
| *** karimb has joined #openstack-ironic | 08:19 | |
| *** zhangfei has quit IRC | 08:25 | |
| *** stendulker has joined #openstack-ironic | 08:25 | |
| *** lucas-afk is now known as lucasagomes | 08:33 | |
| *** derekh has joined #openstack-ironic | 08:34 | |
| *** zhangfei has joined #openstack-ironic | 08:39 | |
| *** jaganathan has quit IRC | 08:41 | |
| *** priteau has joined #openstack-ironic | 08:43 | |
| *** dtantsur|afk is now known as dtantsur | 08:43 | |
| *** mgoddard has joined #openstack-ironic | 08:43 | |
| dtantsur | morning ironic | 08:43 |
| mgoddard | Morning dtantsur | 08:44 |
| dtantsur | o/ | 08:50 |
| *** mrtenio has joined #openstack-ironic | 08:56 | |
| *** vsaienk0 has quit IRC | 08:56 | |
| *** mrch has joined #openstack-ironic | 09:02 | |
| *** amarao has joined #openstack-ironic | 09:09 | |
| *** vsaienk0 has joined #openstack-ironic | 09:11 | |
| *** ccamacho has quit IRC | 09:11 | |
| *** e0ne has joined #openstack-ironic | 09:13 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Add ansible deploy interface https://review.openstack.org/510522 | 09:14 |
| *** vmud213 has joined #openstack-ironic | 09:14 | |
| dtantsur | \o/ | 09:17 |
| *** udesale__ has joined #openstack-ironic | 09:19 | |
| *** udesale has quit IRC | 09:19 | |
| *** sambetts|afk is now known as sambetts | 09:20 | |
| *** udesale__ has quit IRC | 09:22 | |
| *** udesale has joined #openstack-ironic | 09:22 | |
| *** ktibi has joined #openstack-ironic | 09:23 | |
| openstackgerrit | zhufl proposed openstack/ironic master: Fix missing logging format error https://review.openstack.org/512535 | 09:23 |
| *** karimb has quit IRC | 09:28 | |
| vdrok | good morning ironic, dtantsur mgoddard | 09:30 |
| dtantsur | o/ | 09:33 |
| *** noam_ has quit IRC | 09:34 | |
| *** hw_wutianwei has quit IRC | 09:39 | |
| vdrok | dtantsur: vsaienk0 https://review.openstack.org/512510 this seems to fix the client functional job | 09:40 |
| patchbot | patch 512510 - python-ironicclient - Use generic user for both zuul v2 and v3 | 09:40 |
| *** yolanda has quit IRC | 09:44 | |
| dtantsur | nice, lemme check | 09:46 |
| *** yolanda has joined #openstack-ironic | 09:47 | |
| *** karimb has joined #openstack-ironic | 09:55 | |
| *** TuanLA has quit IRC | 10:05 | |
| *** trungnv has quit IRC | 10:05 | |
| *** zshi__ has quit IRC | 10:13 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Finish the guide on upgrading to hardware types https://review.openstack.org/511240 | 10:17 |
| dtantsur | sambetts: ^^^ | 10:17 |
| sambetts | dtantsur: awesome :) | 10:18 |
| *** priteau has quit IRC | 10:19 | |
| *** priteau has joined #openstack-ironic | 10:21 | |
| *** ccamacho has joined #openstack-ironic | 10:24 | |
| *** openstackgerrit has quit IRC | 10:33 | |
| *** openstackgerrit has joined #openstack-ironic | 10:33 | |
| openstackgerrit | Merged openstack/python-ironicclient master: Use generic user for both zuul v2 and v3 https://review.openstack.org/512510 | 10:33 |
| *** zhangfei has quit IRC | 10:34 | |
| *** namnh has quit IRC | 10:36 | |
| *** stendulker_ has joined #openstack-ironic | 10:38 | |
| *** stendulker has quit IRC | 10:40 | |
| *** dprince has joined #openstack-ironic | 10:42 | |
| *** dprince has quit IRC | 10:42 | |
| *** tesseract has quit IRC | 10:43 | |
| *** stendulker_ has quit IRC | 10:43 | |
| openstackgerrit | zenghui.shi proposed openstack/ironic master: WIP: Add BIOSInterface for BIOS configuration https://review.openstack.org/507793 | 10:43 |
| openstackgerrit | zenghui.shi proposed openstack/ironic master: Add node BIOS support - RPC API https://review.openstack.org/512200 | 10:43 |
| openstackgerrit | zenghui.shi proposed openstack/ironic master: Add node BIOS support https://review.openstack.org/511714 | 10:43 |
| openstackgerrit | zenghui.shi proposed openstack/ironic master: Add db api layer for node bios operations https://review.openstack.org/511402 | 10:43 |
| openstackgerrit | zenghui.shi proposed openstack/ironic master: Add Node BIOS support - REST API https://review.openstack.org/512579 | 10:43 |
| *** tesseract has joined #openstack-ironic | 10:43 | |
| *** rbudden_ has joined #openstack-ironic | 10:48 | |
| *** rbudden has quit IRC | 10:50 | |
| *** rbudden_ is now known as rbudden | 10:50 | |
| *** priteau has quit IRC | 10:52 | |
| *** milan has joined #openstack-ironic | 10:54 | |
| dtantsur | TheJulia: FYI looking into releases today, starting with ironic-lib master | 10:55 |
| *** yangyapeng has quit IRC | 10:55 | |
| dtantsur | milan: hey, mind re-reviewing https://review.openstack.org/#/c/511630/ please? | 10:59 |
| patchbot | patch 511630 - ironic-inspector - pep8: Add 'application-import-names = ironic_inspe... | 10:59 |
| milan | dtantsur, ah yeah, saw those in the inbox | 10:59 |
| dtantsur | milan: and checking https://review.openstack.org/512226 too | 10:59 |
| patchbot | patch 512226 - ironic-inspector - Update tests to do not use deprecated test.services() | 10:59 |
| * milan a+ | 10:59 | |
| dtantsur | I'm trying to release today | 10:59 |
| milan | sure thing! | 10:59 |
| dtantsur | aarefiev or sambetts, will you have time for https://review.openstack.org/#/c/471831/ today? I'd like to include it in the release | 11:00 |
| patchbot | patch 471831 - ironic-inspector - Refactoring the firewall | 11:00 |
| *** jkilpatr has joined #openstack-ironic | 11:06 | |
| *** vmud213 has quit IRC | 11:07 | |
| openstackgerrit | Merged openstack/ironic-python-agent master: Fix for broken zuul v3 job and releasenotes https://review.openstack.org/512416 | 11:08 |
| *** lucasagomes is now known as lucas-hungry | 11:13 | |
| pas-ha | dtantsur: re ansible-deploy patch - should I add a release note right away, or after docs are added too? (could add a stub for release note, and then update it with a link to docs in the docs patch) | 11:18 |
| dtantsur | pas-ha: release notes should always go with a patch. you can add a docs link later though | 11:19 |
| pas-ha | ok, cool, will add one | 11:19 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Add ansible deploy interface https://review.openstack.org/510522 | 11:27 |
| *** jkilpatr has quit IRC | 11:27 | |
| *** jkilpatr has joined #openstack-ironic | 11:27 | |
| * dtantsur -> short walk | 11:28 | |
| *** dtantsur is now known as dtantsur|brb | 11:28 | |
| *** karimb has quit IRC | 11:38 | |
| *** udesale has quit IRC | 11:38 | |
| *** zhangfei has joined #openstack-ironic | 11:39 | |
| *** udesale has joined #openstack-ironic | 11:44 | |
| *** bfournie has joined #openstack-ironic | 11:45 | |
| *** bfournie has quit IRC | 11:45 | |
| *** mnarusze has joined #openstack-ironic | 11:46 | |
| *** mnarusze_ has joined #openstack-ironic | 11:46 | |
| *** mnarusze_ has quit IRC | 11:46 | |
| *** parlos has quit IRC | 11:48 | |
| *** mnarusze has quit IRC | 11:55 | |
| *** mat128 has joined #openstack-ironic | 11:55 | |
| *** jlabarre has joined #openstack-ironic | 11:55 | |
| openstackgerrit | Gustavo Diniz Monteiro proposed openstack/ironic master: Add an timeout for powering on/off an node on HPE OneView Driver https://review.openstack.org/510963 | 12:00 |
| *** chlong has quit IRC | 12:01 | |
| *** phuongnh has quit IRC | 12:01 | |
| *** udesale has quit IRC | 12:01 | |
| *** gmonteiro has quit IRC | 12:08 | |
| *** nicodemos has quit IRC | 12:09 | |
| *** gmonteiro has joined #openstack-ironic | 12:10 | |
| *** nicodemos has joined #openstack-ironic | 12:10 | |
| *** ricardoas1 has joined #openstack-ironic | 12:11 | |
| *** ricardoas has quit IRC | 12:12 | |
| *** dprince has joined #openstack-ironic | 12:17 | |
| TheJulia | dtantsur|brb: ack | 12:18 |
| openstackgerrit | Merged openstack/python-ironicclient master: Deprecate the ironic CLI https://review.openstack.org/508218 | 12:19 |
| *** lucas-hungry is now known as lucasagomes | 12:19 | |
| *** zhangfei has quit IRC | 12:21 | |
| *** bfournie has joined #openstack-ironic | 12:23 | |
| *** zshi__ has joined #openstack-ironic | 12:26 | |
| TheJulia | dtantsur|brb: are you double checking renos? | 12:27 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Migrate python-oneviewclient validations to Ironic OneView drivers https://review.openstack.org/468428 | 12:30 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Add validations for OneView ML2 driver https://review.openstack.org/508946 | 12:31 |
| *** trown|outtypewww is now known as trown | 12:33 | |
| *** jcoufal has joined #openstack-ironic | 12:41 | |
| *** mrtenio has quit IRC | 12:50 | |
| *** yangyapeng has joined #openstack-ironic | 12:53 | |
| *** rbudden has quit IRC | 12:53 | |
| *** mjturek has joined #openstack-ironic | 12:54 | |
| *** sasha2 has joined #openstack-ironic | 13:00 | |
| *** mrtenio has joined #openstack-ironic | 13:02 | |
| *** rloo has joined #openstack-ironic | 13:05 | |
| *** karimb has joined #openstack-ironic | 13:13 | |
| openstackgerrit | Merged openstack/ironic-inspector master: pep8: Add 'application-import-names = ironic_inspector' https://review.openstack.org/511630 | 13:15 |
| openstackgerrit | Merged openstack/ironic-inspector master: flake8: Enable some off-by-default checks https://review.openstack.org/511634 | 13:15 |
| *** baoli has joined #openstack-ironic | 13:20 | |
| *** dtantsur|brb is now known as dtantsur | 13:21 | |
| dtantsur | TheJulia: I will. Reno for sushy is quite short, and no reno for ironic-lib | 13:21 |
| TheJulia | \o/ | 13:26 |
| TheJulia | yay merge failures :( | 13:26 |
| dtantsur | so, for ironicclient release we have https://review.openstack.org/#/c/359061/ left | 13:31 |
| patchbot | patch 359061 - python-ironicclient - Switch to none auth for standalone mode | 13:31 |
| * TheJulia takes a look at the dsvm log | 13:34 | |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Migrate python-oneviewclient validations to Ironic OneView drivers https://review.openstack.org/468428 | 13:34 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector master: Update tests to do not use deprecated test.services() https://review.openstack.org/512226 | 13:37 |
| dtantsur | milan: rebased ^^^ | 13:37 |
| milan | dtantsur, ack, /me looks | 13:37 |
| *** zshi__ has quit IRC | 13:40 | |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Add validations for OneView ML2 driver https://review.openstack.org/508946 | 13:40 |
| *** stendulker has joined #openstack-ironic | 13:42 | |
| *** chlong has joined #openstack-ironic | 13:42 | |
| *** MattMan has quit IRC | 13:43 | |
| *** MattMan has joined #openstack-ironic | 13:43 | |
| *** gcb has quit IRC | 13:45 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: Release notes clean up for the upcoming release https://review.openstack.org/512624 | 13:47 |
| dtantsur | TheJulia, rloo ^^^ | 13:47 |
| *** gcb has joined #openstack-ironic | 13:47 | |
| rloo | hi and good morning all, dtantsur, TheJulia, milan | 13:49 |
| TheJulia | good morning rloo! | 13:49 |
| rloo | dtantsur: didn't realize we were going to do an ipa release soon. We're back to business :) | 13:49 |
| milan | morning rloo! :) | 13:49 |
| dtantsur | morning rloo | 13:50 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: Release notes clean up for the upcoming release https://review.openstack.org/512624 | 13:50 |
| dtantsur | TheJulia, rloo, even better ^^^ | 13:50 |
| *** cdearborn has joined #openstack-ironic | 13:51 | |
| *** trown is now known as trown|brb | 13:53 | |
| *** catintheroof has joined #openstack-ironic | 13:53 | |
| openstackgerrit | Merged openstack/ironic master: Support SUM based firmware update as clean step for iLO drivers https://review.openstack.org/422572 | 13:53 |
| openstackgerrit | Merged openstack/ironic stable/ocata: Skip PortNotFound when unbinding port https://review.openstack.org/505367 | 13:54 |
| openstackgerrit | Merged openstack/ironic master: Fix some mis-formatted log messages in oneview driver https://review.openstack.org/511002 | 13:54 |
| openstackgerrit | Merged openstack/ironic master: Change pxe dhcp options name to codes. https://review.openstack.org/506173 | 13:54 |
| dtantsur | merge! merge! MERGE! | 13:54 |
| * dtantsur feels like an ironic release is coming too | 13:54 | |
| TheJulia | heh | 13:55 |
| rloo | wheeeeee | 13:55 |
| TheJulia | It would be good.... | 13:55 |
| TheJulia | dtantsur: w/r/t ipa, I left a comment on the review, +2, but I think we should get a few non-cores to take a look | 13:55 |
| rloo | dtantsur: honestly, we should NOT do an ironic release w/o getting the rolling upgrades patches in | 13:55 |
| dtantsur | ouch, yeah | 13:56 |
| TheJulia | yeah | 13:56 |
| dtantsur | mmm, let's get them in? :) | 13:56 |
| rloo | dtantsur: yeah, let's get them in! :D | 13:56 |
| * dtantsur looks | 13:56 | |
| TheJulia | dtantsur: btw, w/r/t python-ironicclient, I kicked a recheck off on the auth patch before I started reviewing it. Looks like it should clear CI soon-ish | 14:00 |
| stendulker | Good morning dtantsur, TheJulia, rloo, milan | 14:00 |
| TheJulia | good morning stendulker | 14:00 |
| *** noam_ has joined #openstack-ironic | 14:00 | |
| noam_ | Hi guys | 14:00 |
| *** rpioso has joined #openstack-ironic | 14:00 | |
| rloo | morning (evening?) stendulker! | 14:00 |
| milan | morning stendulker! :) | 14:01 |
| rloo | hi noam_ | 14:01 |
| stendulker | rloo: Its evening here :) | 14:01 |
| noam_ | i got some issue with one bm node. inspection and provide went okay and node available but node not appear in hypervisor list | 14:01 |
| rloo | stendulker: :) | 14:01 |
| stendulker | TheJulia: I saw your comment related to rescue DB patch https://review.openstack.org/#/c/509334/ | 14:02 |
| patchbot | patch 509334 - ironic - Add rescue_interface to node DB table | 14:02 |
| rloo | dtantsur: "The ipmi_address field is no longer sent as part of the inspection process. The inventory[bmc_address] field should be used instead." | 14:02 |
| rloo | dtantsur: that is under ipa's upgrade. does it break anyone if that ipmi_address field is not longer sent? | 14:02 |
| stendulker | TheJulia: I'm not much familiar with DB side of the code. | 14:02 |
| *** trown|brb is now known as trown | 14:02 | |
| TheJulia | stendulker: at a glance, it reminded me of something I ran into with adding the storage_interface, I'm just not remembering right now | 14:02 |
| stendulker | TheJulia: Can you help me in fixing it | 14:02 |
| stendulker | TheJulia: I compared code with storage interface, and could not find anything amiss | 14:03 |
| rloo | stendulker, TheJulia: i can take a look... | 14:03 |
| stendulker | Though I was doing crude search and comapred with DB patch of storage | 14:03 |
| TheJulia | stendulker: it would be order of things landing if memory serves. I think we had to add the column and then update the model across separte patches | 14:04 |
| *** e0ne_ has joined #openstack-ironic | 14:04 | |
| *** e0ne has quit IRC | 14:04 | |
| TheJulia | oh no | 14:05 |
| stendulker | TheJulia: You mean alembic side of code in first patch and then models? | 14:05 |
| rloo | TheJulia, stendulker: that wouldn't make sense. at some point, all the code will be in | 14:06 |
| TheJulia | your change is identical in behavior | 14:06 |
| TheJulia | I think I know what is happening | 14:06 |
| *** marios has quit IRC | 14:08 | |
| * stendulker eagerly waiting to know ... | 14:08 | |
| TheJulia | looking | 14:08 |
| *** marios has joined #openstack-ironic | 14:08 | |
| rloo | TheJulia, stendulker: my guess is a bug in ironic-dbsync's _check-versions... :-( | 14:08 |
| TheJulia | rloo: yeah | 14:09 |
| stendulker | oh :( | 14:09 |
| * rloo wonders if a chicken/egg thing... am looking... | 14:09 | |
| * milan relocates; bbib | 14:10 | |
| dtantsur | rloo: it might, I guess | 14:10 |
| TheJulia | rloo: it is as far as I can tell | 14:10 |
| TheJulia | because the code references the model | 14:11 |
| dtantsur | I don't think we have any guarantee around inventory, but I also think we did deprecate it | 14:11 |
| *** milan has quit IRC | 14:11 | |
| TheJulia | I wonder if it could be split across patches? because I thought the grenade patches were passing before the patch was split | 14:11 |
| rloo | dtantsur: oh, it had already been deprecated? then it is fine. although the reno should mention that it had been deprecated already? | 14:11 |
| *** catintheroof has quit IRC | 14:11 | |
| dtantsur | rloo: also, my internet is too bad for gerrit UI, but the by_path value is the whole path, not only its trailing part | 14:12 |
| rloo | dtantsur: OH. so i misinterpreted that. | 14:12 |
| rloo | dtantsur: worth clarifying; I thought it was just the XXX part. | 14:12 |
| dtantsur | rloo: suggestions welcome, "in the form of" was the most explicit way to put it I can think of :) | 14:13 |
| rloo | dtantsur: will comment, putting on my thinking cap as i type... | 14:13 |
| dtantsur | thanks | 14:14 |
| *** mrch has quit IRC | 14:15 | |
| stendulker | rloo, TheJulia : Anything that can be done in this patch? | 14:17 |
| rloo | stendulker: sorry, i got side tracked. my feeling is that no, it isn't your patch. | 14:18 |
| * stendulker on vacation till from tomorrow till Monday. Its Diwali festival here. | 14:18 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent master: Release notes clean up for the upcoming release https://review.openstack.org/512624 | 14:19 |
| stendulker | rloo: Ok. | 14:19 |
| TheJulia | stendulker: I agree with rloo, although the check_version method landed on August 2nd, the prior patch did patch grenade a month later without any issues | 14:19 |
| rloo | stendulker: enjoy! don't worry, I'll make sure it is fixed. i suspect i can fix it in one of the rolling-upgrade patches that the rescue stuff is based on | 14:19 |
| TheJulia | err, pass grenade | 14:20 |
| stendulker | rloo: Thank you :) | 14:20 |
| openstackgerrit | Stenio Araujo proposed openstack/ironic master: Soft power operations for OneView hardware type https://review.openstack.org/510685 | 14:20 |
| stendulker | TheJulia: Thank you for traiging this. I always thought its zuul issue and did not double check these results | 14:21 |
| *** karimb has quit IRC | 14:21 | |
| stendulker | Thank you dtantsur. | 14:21 |
| rloo | TheJulia: that dbsync's check_version is being added in master, I just need to figure out how to fix it... | 14:23 |
| TheJulia | yeah, I'm looking at it also | 14:23 |
| *** crushil has joined #openstack-ironic | 14:23 | |
| openstackgerrit | Merged openstack/ironic-python-agent master: Fix waiting for target disk to appear https://review.openstack.org/443649 | 14:24 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent stable/pike: Fix waiting for target disk to appear https://review.openstack.org/512643 | 14:25 |
| TheJulia | rloo: I guess an exception catch might be the way to handle it since column additions wouldn't have versions yet, and subtractions (whenever that would happen) would first need to be removed from the model then later removed from the db so we would never really encounter the same exact failure condition in the opposite case | 14:25 |
| rloo | TheJulia: how much do you know about this db stuff? Anyway for me to do a db query, just getting the object model's uuid & version columns? | 14:27 |
| rloo | TheJulia: the exception thing would work, but more maintenance, e.g. would need to actually code which fields are new. | 14:28 |
| TheJulia | actually | 14:29 |
| TheJulia | I'm not sure it would | 14:29 |
| TheJulia | pulling the exception back up | 14:29 |
| rloo | TheJulia: Unknown column 'nodes.rescue_interface' in 'field list | 14:30 |
| * stendulker logging off now | 14:30 | |
| TheJulia | yeah, because it is asking for each column in the model | 14:30 |
| TheJulia | http://logs.openstack.org/34/509334/4/check/legacy-grenade-dsvm-ironic/a38c631/logs/grenade.sh.txt.gz#_2017-10-16_07_29_58_320 | 14:31 |
| TheJulia | so a catch, will just make the entire model validation pointless since it will be bypassed if we were to validate that only a column is missing | 14:32 |
| noam_ | Hi, got some issue with one bm node. inspection and provide went okay and node available but node not appear in hypervisor list, what could have gone wrong? | 14:33 |
| *** rbartal has quit IRC | 14:33 | |
| *** chlong has quit IRC | 14:34 | |
| *** yangyapeng has quit IRC | 14:35 | |
| *** cdearborn has quit IRC | 14:36 | |
| *** yangyapeng has joined #openstack-ironic | 14:36 | |
| *** cdearborn has joined #openstack-ironic | 14:37 | |
| dtantsur | noam_: this may give more hints: https://docs.openstack.org/ironic/latest/admin/troubleshooting.html#nova-returns-no-valid-host-was-found-error | 14:37 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Add validations for OneView ML2 driver https://review.openstack.org/508946 | 14:40 |
| *** namnh has joined #openstack-ironic | 14:40 | |
| * TheJulia pulls up the sqlalchemy docs | 14:41 | |
| *** links has quit IRC | 14:41 | |
| TheJulia | rloo: we need to simplify the query such that we only query what we explicitly want out of the db | 14:43 |
| rloo | TheJulia: yeah, that's what i'd like to do... do you know how... | 14:43 |
| rloo | TheJulia: basically i'm saying, if you are looking into how to do it, i'll let you do it and not look; otherwise, i'll look :) | 14:44 |
| *** mjura has quit IRC | 14:44 | |
| TheJulia | digging still | 14:44 |
| *** karthiks has quit IRC | 14:47 | |
| TheJulia | rloo: we need to open a session and specifically query instead of using the model_query helper | 14:47 |
| rloo | TheJulia: ok | 14:48 |
| TheJulia | err | 14:48 |
| *** chlong has joined #openstack-ironic | 14:48 | |
| TheJulia | disregard last | 14:49 |
| *** catintheroof has joined #openstack-ironic | 14:51 | |
| openstackgerrit | Stenio Araujo proposed openstack/ironic master: Get a new OneView client when needed https://review.openstack.org/510644 | 14:53 |
| *** jtomasek has quit IRC | 14:54 | |
| TheJulia | well my mind just went to a simplified object, but the problem is we only need the two columns, and we're trying to checke verything | 14:55 |
| *** jtomasek has joined #openstack-ironic | 14:55 | |
| TheJulia | rloo: http://docs.sqlalchemy.org/en/latest/orm/loading_relationships.html#advanced-usage-with-arbitrary-statements | 14:56 |
| TheJulia | so, maybe separate query helper to perform direct statements, and since we know the column names, we explicitly query for the two columns out of each model | 14:57 |
| rloo | TheJulia: that should work. i think we actually *only* need the version column | 14:57 |
| *** jtomasek has quit IRC | 14:58 | |
| rloo | TheJulia: cuz we aren't reporting (I don't think) which objects are out of sync. but i should verify; has been a few weeks/months since i worked on that code. hey, this change would make it even faster :-) | 14:58 |
| *** jtomasek has joined #openstack-ironic | 14:58 | |
| TheJulia | very fast hopefully if it is just pulling the column for each model, make a prepared query string with model.__name__ substituted for each query, and then you'd have to re-write the validation code I think because I don't think you could really use the filter at that point... well... actually you could build a sql statement maybe | 15:01 |
| TheJulia | err, might need to pull down the column and process locally | 15:01 |
| *** catintheroof has quit IRC | 15:03 | |
| rloo | TheJulia: hey, take a look at this nova code: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L494 | 15:04 |
| rloo | TheJulia: i wonder if we can do a similar thing, using models.<Object>.version | 15:04 |
| rloo | TheJulia: and do a filter thing with it. i can try it :-) | 15:05 |
| TheJulia | rloo: so there is a sql where in query, so you can ship the list of versions up to the server in the query and it can do it all server side | 15:05 |
| TheJulia | that might be different between db platforms to actually have it count | 15:06 |
| TheJulia | but a number of returned rows can be handled/counted very quickly :) | 15:06 |
| NobodyCam | Good Morning Ironic'ers :) | 15:06 |
| rloo | TheJulia: i don't think i need to count, just need to know if zero or not zero, so easier. | 15:07 |
| TheJulia | rloo: oh, that might just work, ask it to get model.version, I wonder if it would handle that correctly.... | 15:07 |
| rloo | TheJulia: i shall try :) | 15:07 |
| rloo | morning NobodyCam! | 15:07 |
| TheJulia | excellent, well, I'm going to go make a cup of coffee then | 15:07 |
| NobodyCam | ++ for coffee | 15:08 |
| rloo | thanks for helping TheJulia! | 15:08 |
| vdrok | morning rloo TheJulia NobodyCam | 15:08 |
| rloo | hi vdrok! | 15:08 |
| NobodyCam | Good mOrning vdrok, rloo, TheJulia and dtantsur :) | 15:09 |
| vdrok | rloo: sorry, was buried in the internal stuff for the whole day, will check the osc bit now, can not remember exactly the arguments, just remember it worked fine :) | 15:09 |
| rloo | vdrok: thx for checking -- whatever it is, I think we should mention it in the release notes :) | 15:09 |
| vdrok | yeah, makes sense | 15:09 |
| *** penick has joined #openstack-ironic | 15:13 | |
| *** edleafe- is now known as edleafe | 15:14 | |
| *** ccamacho has quit IRC | 15:14 | |
| openstackgerrit | Derek Higgins proposed openstack/ironic master: [bfv] Set the correct iqn for pxe https://review.openstack.org/512662 | 15:17 |
| vdrok | rloo: gah, indeed it wants --os-cloud :( I guess I was checking the endpoint_token auth_type previously | 15:22 |
| vdrok | I think it needs to be fixed in osc-lib now | 15:22 |
| vdrok | this bit https://github.com/openstack/osc-lib/blob/master/osc_lib/api/auth.py#L104-L107 | 15:22 |
| rloo | vdrok: but nothing broke with your patch? for osc, it works the same as before? | 15:22 |
| TheJulia | derekh: interesting.... | 15:22 |
| *** stendulker has quit IRC | 15:24 | |
| TheJulia | oh! | 15:24 |
| vdrok | rloo: yeah it does | 15:24 |
| TheJulia | doh! | 15:24 |
| derekh | TheJulia: ya, I'm guess it works in CI because its the same target and initiato or something? | 15:25 |
| dtantsur | works on devstack \o/ | 15:25 |
| vdrok | rloo: here is the one that worked properly "openstack --debug --os-auth-type token_endpoint --os-url http://192.168.122.22:6385/v1 --os-token none baremetal node list", not none :( | 15:25 |
| derekh | but I am only taking a wild guess | 15:25 |
| vdrok | hrm | 15:26 |
| rloo | vdrok: oh, so osc 'never' worked with none? | 15:26 |
| vdrok | rloo: ok, I see noauth plugin now | 15:26 |
| * vdrok checks again | 15:26 | |
| TheJulia | derekh: could be a couple things.... | 15:27 |
| TheJulia | derekh: most likely related to devstack | 15:27 |
| TheJulia | derekh: uhh, I think you need to generate the file with reno new so it tracks the files correctly | 15:27 |
| derekh | TheJulia: thanks, will do | 15:28 |
| *** amarao has quit IRC | 15:28 | |
| TheJulia | derekh: also, changing the url out to be a link would be nice for when we do reno cleanup prior to release | 15:28 |
| vdrok | rloo: shit, noauth refers to custom cinder plugin :) | 15:28 |
| derekh | TheJulia: ack | 15:28 |
| TheJulia | vdrok: ugh | 15:29 |
| vdrok | rloo: so yeah, it didn't. the one that did are token_endpoint, token, password | 15:29 |
| vdrok | *ones | 15:29 |
| rloo | vdrok: so.... none doesn't work for osc? | 15:29 |
| vdrok | I'll update the reno and report a bug to osc-lib | 15:29 |
| rloo | vdrok: so that patch works for 'ironic' CLI and python API only. | 15:30 |
| *** AlexeyAbashkin has quit IRC | 15:30 | |
| vdrok | yah | 15:30 |
| *** AlexeyAbashkin has joined #openstack-ironic | 15:30 | |
| rloo | vdrok: i am wondering if we want to push the patch, if it doesn't work for osc...? | 15:30 |
| rloo | vdrok: cuz we're deprecating ironic. so i don't know if want ironic to be able to do something that osc baremetal can't? | 15:31 |
| vdrok | rloo: I'll take a look at osc-lib now and how to fix it. if it's easy, I'll just push a fix. yeah what you're saying makes sense | 15:32 |
| rloo | vdrok: ok thx. | 15:32 |
| * vdrok wips the patch | 15:33 | |
| rloo | dtantsur: ^^ fyi, wrt https://review.openstack.org/#/c/359061/ | 15:33 |
| patchbot | patch 359061 - python-ironicclient - Switch to none auth for standalone mode | 15:33 |
| dtantsur | rloo, vdrok, yeah.. so we can release ironicclient without this patch, right? | 15:36 |
| vdrok | yeah go ahead. sorry for slowing you down | 15:36 |
| rloo | vdrok: no worries, you didn't slow us down. zuul3 did :) | 15:37 |
| rloo | dtantsur: so the client should have a prelude i think, to highlight deprecation of ironic CLI | 15:37 |
| openstackgerrit | Derek Higgins proposed openstack/ironic master: [bfv] Set the correct iqn for pxe https://review.openstack.org/512662 | 15:37 |
| openstackgerrit | Gustavo Diniz Monteiro proposed openstack/ironic master: Add an timeout for powering on/off an node on HPE OneView Driver https://review.openstack.org/510963 | 15:38 |
| *** ktibi has quit IRC | 15:38 | |
| *** AlexeyAbashkin has quit IRC | 15:41 | |
| dtantsur | rloo: thanks for volunteering to write it ;) | 15:42 |
| rloo | dtantsur: ha ha. are you in a hurry for it? I can do it later today; right now i want to get that ironic-dbsync thing working | 15:42 |
| * rloo reminds folks that i wasn't fond of the release-often thing and said it was fine as long as it didn't make more work for me :) | 15:43 | |
| *** e0ne_ has quit IRC | 15:46 | |
| dtantsur | rloo: no hurry from my side. we also need someone to take a look at reno | 15:46 |
| * dtantsur suspects it will be him | 15:46 | |
| dtantsur | "Releases repo frozen". yeah, no hurry with ironicclient | 15:52 |
| rloo | dtantsur: heh. i guess they didn't mention when they would be thawed? | 15:53 |
| dtantsur | rloo: when they fix something around zuul v3 and post jobs | 15:53 |
| rloo | ah. well, maybe by tomorrow then | 15:54 |
| *** markguz_ has joined #openstack-ironic | 15:56 | |
| dtantsur | hopefully | 15:57 |
| *** rama_y has joined #openstack-ironic | 15:59 | |
| *** pcaruana has quit IRC | 16:01 | |
| *** namnh has quit IRC | 16:02 | |
| *** namnh has joined #openstack-ironic | 16:04 | |
| *** trown is now known as trown|lunch | 16:05 | |
| *** lucasagomes is now known as lucas-afk | 16:10 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Finish the guide on upgrading to hardware types https://review.openstack.org/511240 | 16:16 |
| dtantsur | TheJulia, rloo ^^^ | 16:16 |
| *** marios has quit IRC | 16:16 | |
| rloo | thx dtantsur, will look in an hour or so (lunch time) | 16:17 |
| dtantsur | rloo: enjoy! | 16:17 |
| *** namnh has quit IRC | 16:19 | |
| *** namnh has joined #openstack-ironic | 16:20 | |
| *** jcoufal has quit IRC | 16:26 | |
| * sambetts --> home | 16:26 | |
| sambetts | night all | 16:26 |
| *** sambetts is now known as sambetts|afk | 16:26 | |
| NobodyCam | Have a good night sambetts|afk | 16:30 |
| *** ralonsoh has quit IRC | 16:33 | |
| *** vsaienk0 has quit IRC | 16:37 | |
| *** penick_ has joined #openstack-ironic | 16:38 | |
| *** parlos has joined #openstack-ironic | 16:38 | |
| *** penick has quit IRC | 16:40 | |
| openstackgerrit | Merged openstack/ironic master: Fix "import xx as xx" grammer https://review.openstack.org/512525 | 16:45 |
| *** snaz has joined #openstack-ironic | 16:57 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: ironic-dbsync: check object versions https://review.openstack.org/497703 | 17:01 |
| *** mrtenio has quit IRC | 17:01 | |
| *** tesseract has quit IRC | 17:02 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Add rescue_interface to node DB table https://review.openstack.org/509334 | 17:03 |
| *** rpioso has quit IRC | 17:03 | |
| *** karimb has joined #openstack-ironic | 17:04 | |
| *** mgoddard has quit IRC | 17:04 | |
| *** penick_ has quit IRC | 17:05 | |
| openstackgerrit | Merged openstack/ironic-python-agent stable/ocata: Remove hard-coded path to grub binaries https://review.openstack.org/507469 | 17:07 |
| *** penick has joined #openstack-ironic | 17:07 | |
| *** trown|lunch is now known as trown | 17:08 | |
| openstackgerrit | John Garbutt proposed openstack/ironic-specs master: Traits on Ironic Nodes https://review.openstack.org/504531 | 17:08 |
| *** derekh has quit IRC | 17:09 | |
| openstackgerrit | Mathieu Gagné proposed openstack/ironic master: Add ability to provide configdrive when rebuilding https://review.openstack.org/501761 | 17:14 |
| *** weshay|ruck is now known as weshay|afk_see_r | 17:14 | |
| dtantsur | night all | 17:16 |
| TheJulia | good night dtantsur | 17:17 |
| *** leyal has quit IRC | 17:17 | |
| *** dtantsur is now known as dtantsur|afk | 17:19 | |
| *** leyal has joined #openstack-ironic | 17:19 | |
| mgagne | Hi all, could I get a second opinion on dtantsur's comment? I want to make sure we are making the right change: https://review.openstack.org/#/c/501761/9/ironic/api/controllers/v1/utils.py@404 | 17:21 |
| patchbot | patch 501761 - ironic - Add ability to provide configdrive when rebuilding | 17:21 |
| mgagne | my main concern is a change in error response | 17:21 |
| *** AlexeyAbashkin has joined #openstack-ironic | 17:22 | |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic master: Add missing 'autospec' to unit tests - /unit/common/ https://review.openstack.org/512758 | 17:22 |
| *** AlexeyAbashkin has quit IRC | 17:24 | |
| openstackgerrit | John Garbutt proposed openstack/ironic-specs master: Config Template traits https://review.openstack.org/504952 | 17:26 |
| *** penick_ has joined #openstack-ironic | 17:27 | |
| TheJulia | I'm kind of -1 to changing the response code from what we were. We should likely note that it is just continuity and maybe something to re-evaluate should we ever go to a v2 | 17:27 |
| *** penick has quit IRC | 17:30 | |
| mgagne | TheJulia: thanks for the review =) | 17:31 |
| *** jcoufal has joined #openstack-ironic | 17:32 | |
| *** penick_ has quit IRC | 17:36 | |
| *** ijw has joined #openstack-ironic | 17:41 | |
| *** rwsu has quit IRC | 17:41 | |
| *** ijw has quit IRC | 17:45 | |
| openstackgerrit | Yusef Shaban proposed openstack/sushy master: Implement Redfish Sessions https://review.openstack.org/471942 | 17:47 |
| *** ijw has joined #openstack-ironic | 17:48 | |
| *** ijw has quit IRC | 17:50 | |
| *** ijw has joined #openstack-ironic | 17:50 | |
| *** parlos has quit IRC | 17:50 | |
| noam_ | dtantsur: http://paste.openstack.org/show/623874/ what could be the reason nova could not find this baremetal? | 17:51 |
| *** fragatina has quit IRC | 17:53 | |
| *** penick has joined #openstack-ironic | 18:00 | |
| *** baoli has quit IRC | 18:00 | |
| *** baoli has joined #openstack-ironic | 18:01 | |
| *** rwsu has joined #openstack-ironic | 18:02 | |
| *** namnh has quit IRC | 18:15 | |
| *** jcoufal_ has joined #openstack-ironic | 18:24 | |
| *** rpioso has joined #openstack-ironic | 18:25 | |
| *** jcoufal has quit IRC | 18:26 | |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient master: Switch to none auth for standalone mode https://review.openstack.org/359061 | 18:27 |
| *** baoli has quit IRC | 18:27 | |
| *** penick has quit IRC | 18:30 | |
| *** ChubYann has joined #openstack-ironic | 18:32 | |
| *** rwsu has quit IRC | 18:32 | |
| *** baoli has joined #openstack-ironic | 18:36 | |
| *** vishwanathj has joined #openstack-ironic | 18:41 | |
| *** mrtenio has joined #openstack-ironic | 18:43 | |
| *** rwsu has joined #openstack-ironic | 18:45 | |
| openstackgerrit | Merged openstack/ironic-inspector master: Update tests to do not use deprecated test.services() https://review.openstack.org/512226 | 18:46 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Add ansible deploy interface https://review.openstack.org/510522 | 18:50 |
| *** gmonteiro has quit IRC | 19:16 | |
| *** namnh has joined #openstack-ironic | 19:16 | |
| rloo | jlvillal: did you see this: https://review.openstack.org/#/c/512535/ | 19:18 |
| patchbot | patch 512535 - ironic - Fix missing logging format error | 19:18 |
| rloo | jlvillal: shouldn't your https://review.openstack.org/#/c/232257/ have detected it? | 19:19 |
| patchbot | patch 232257 - ironic - Detect when log messages are mis-formatted | 19:19 |
| jlvillal | rloo, let me look | 19:20 |
| *** namnh has quit IRC | 19:20 | |
| jlvillal | rloo, Hmmm. I thought I would detect those. I put in code to check to see if missing specifier. | 19:21 |
| jlvillal | rloo, Python will format: "%(node) skips" % {'node': 'hello'} as "hellokips" :( | 19:22 |
| jlvillal | rloo, Oh. I think I know! | 19:22 |
| jlvillal | rloo, If they unit tests mock the LOG, then I don't catch it :( | 19:22 |
| jlvillal | s/If they/If the/ | 19:22 |
| jlvillal | Since it is mocked | 19:22 |
| rloo | jlvillal: ahh | 19:23 |
| rloo | jlvillal: so we shouldn't mock the log any more? | 19:23 |
| rloo | jlvillal: after your patch merges i mean? | 19:23 |
| jlvillal | rloo, Uh, maybe. In the future can get the output from the log by using: self.logger.output | 19:23 |
| jlvillal | rloo, if my patch is merged | 19:24 |
| jlvillal | rloo, I also wanted to check an option in mock | 19:24 |
| rloo | jlvillal: well, if/when your patch merges, i am worried that folks will be lulled into a false sense of security that 'we have tests to check so no need to review properly' | 19:24 |
| openstackgerrit | Merged openstack/ironic master: Add online data migrations for conductor version https://review.openstack.org/497666 | 19:25 |
| jlvillal | rloo, Well that is the case for any check we add. The checks are to assist in catching things. But they can't replace people do reviews. | 19:26 |
| jlvillal | s/people do/people doing/ | 19:26 |
| rloo | jlvillal: well, the hacks do | 19:27 |
| jlvillal | rloo, For some reason I thought mock had a "passthru" type option. But it appears I am wrong :( | 19:27 |
| rloo | jlvillal: your stuff is probably still useful. it is just good to know the limitations... | 19:28 |
| jlvillal | rloo, +1 on knowing the limitations | 19:28 |
| *** mgoddard has joined #openstack-ironic | 19:31 | |
| jlvillal | rloo, So the other possibility it didn't catch those issues is that the code is never run during unit tests. Those log messages. | 19:32 |
| jlvillal | rloo, I don't see any mocking of those calls. So my idea about mocking is not applicable. | 19:32 |
| rloo | jlvillal: oh, that'd do it! | 19:32 |
| rloo | jlvillal: maybe that fix should also throw in a test or two then. | 19:33 |
| rloo | jlvillal: not your fix, the other patch | 19:33 |
| jlvillal | rloo, Yeah. I'm testing my hypothesis now | 19:34 |
| *** rbudden has joined #openstack-ironic | 19:37 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 19:40 | |
| jlvillal | rloo, Okay. So my check isn't catching that for some reason. I'm investigating. Not sure if it is because it is a LOG.debug() message. | 19:40 |
| jlvillal | rloo, Two of the proposed changes do have unit tests exercising the log messages. | 19:41 |
| jlvillal | Maybe 3 | 19:41 |
| jlvillal | 3 is all the changes | 19:41 |
| *** hjensas has quit IRC | 19:42 | |
| *** weshay|afk_see_r is now known as weshay|ruck | 19:42 | |
| jlvillal | rloo, Ah. So it isn't catching errors with LOG.debug. I'll investigate. | 19:43 |
| rloo | jlvillal: thx for looking into it | 19:43 |
| *** AlexeyAbashkin has quit IRC | 19:44 | |
| *** mgoddard has quit IRC | 19:45 | |
| *** penick has joined #openstack-ironic | 19:45 | |
| *** rama_y has quit IRC | 19:46 | |
| *** catintheroof has joined #openstack-ironic | 19:49 | |
| *** e0ne has joined #openstack-ironic | 19:52 | |
| *** gregwork has quit IRC | 19:54 | |
| jlvillal | rloo, I figured out the issue. And my new code detects the two log messages that the patch fixed. I'll post an update. | 19:54 |
| jlvillal | rloo, Thanks for pointing that out to me. | 19:54 |
| *** gregwork has joined #openstack-ironic | 19:54 | |
| rloo | jlvillal: thx! | 19:54 |
| *** fragatina has joined #openstack-ironic | 19:55 | |
| *** rama_y has joined #openstack-ironic | 19:56 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic master: Fix missing logging format error https://review.openstack.org/512535 | 19:59 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic master: Detect when log messages are mis-formatted https://review.openstack.org/232257 | 19:59 |
| *** jtomasek has quit IRC | 20:00 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient master: [reno] Prelude for release 2.0 https://review.openstack.org/512812 | 20:00 |
| *** jtomasek has joined #openstack-ironic | 20:07 | |
| *** fragatina has quit IRC | 20:08 | |
| *** e0ne has quit IRC | 20:13 | |
| *** e0ne has joined #openstack-ironic | 20:13 | |
| *** chlong has quit IRC | 20:16 | |
| *** jcoufal_ has quit IRC | 20:17 | |
| *** e0ne has quit IRC | 20:19 | |
| *** ricardoas1 is now known as ricardoas | 20:20 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 20:22 | |
| *** ijw has quit IRC | 20:24 | |
| *** AlexeyAbashkin has quit IRC | 20:27 | |
| *** jtomasek has quit IRC | 20:28 | |
| *** crushil has quit IRC | 20:35 | |
| *** catintheroof has quit IRC | 20:35 | |
| *** crushil has joined #openstack-ironic | 20:36 | |
| *** catintheroof has joined #openstack-ironic | 20:36 | |
| *** catintheroof has quit IRC | 20:36 | |
| *** namnh has joined #openstack-ironic | 20:43 | |
| *** rbudden has quit IRC | 20:45 | |
| *** namnh has quit IRC | 20:47 | |
| *** ijw has joined #openstack-ironic | 20:52 | |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient master: Clean up the release notes https://review.openstack.org/512854 | 20:56 |
| *** ijw has quit IRC | 21:01 | |
| *** trown is now known as trown|outtypewww | 21:07 | |
| *** mat128 has quit IRC | 21:07 | |
| *** crushil has quit IRC | 21:08 | |
| *** sasha2 has quit IRC | 21:10 | |
| *** sasha2 has joined #openstack-ironic | 21:15 | |
| *** rbudden has joined #openstack-ironic | 21:16 | |
| *** chlong has joined #openstack-ironic | 21:18 | |
| *** dprince has quit IRC | 21:19 | |
| *** rbudden has quit IRC | 21:22 | |
| *** fragatina has joined #openstack-ironic | 21:30 | |
| *** bfournie has quit IRC | 21:43 | |
| *** bfournie has joined #openstack-ironic | 21:44 | |
| *** bfournie has quit IRC | 21:45 | |
| *** fragatina has quit IRC | 21:48 | |
| *** baoli has quit IRC | 22:10 | |
| *** ijw has joined #openstack-ironic | 22:16 | |
| *** ijw has quit IRC | 22:20 | |
| *** penick has quit IRC | 22:22 | |
| *** cdearborn has quit IRC | 22:28 | |
| *** bfournie has joined #openstack-ironic | 22:34 | |
| *** bfournie has quit IRC | 22:35 | |
| *** jcoufal has joined #openstack-ironic | 22:39 | |
| *** catintheroof has joined #openstack-ironic | 22:43 | |
| *** oanson has quit IRC | 22:50 | |
| *** oanson has joined #openstack-ironic | 22:52 | |
| *** mjturek has quit IRC | 22:54 | |
| *** rpioso has quit IRC | 22:59 | |
| *** markguz_ has quit IRC | 23:02 | |
| *** rloo has quit IRC | 23:06 | |
| *** rloo has joined #openstack-ironic | 23:06 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent master: Detect when log messages are mis-formatted https://review.openstack.org/511066 | 23:10 |
| *** rloo has quit IRC | 23:10 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent master: tox: Use the default version of Python 3 for tox tests https://review.openstack.org/512900 | 23:13 |
| *** ijw has joined #openstack-ironic | 23:17 | |
| *** catintheroof has quit IRC | 23:17 | |
| *** sasha2 has quit IRC | 23:18 | |
| *** sasha2 has joined #openstack-ironic | 23:18 | |
| *** ijw has quit IRC | 23:22 | |
| *** crushil has joined #openstack-ironic | 23:36 | |
| *** rbudden has joined #openstack-ironic | 23:39 | |
| *** ijw has joined #openstack-ironic | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!