vdrok | TheJulia: small question regarding adoption. I see that the prepare method in iscsi deploy calls boot.prepare_instance when adopting, while agent does not. Is there a reason for it? I thought in case of adoption we should not touch the node, while in boot.prepare_instance we eg set boot device | 00:00 |
---|---|---|
*** yuanying_ has joined #openstack-ironic | 00:04 | |
*** yuanying has quit IRC | 00:05 | |
*** Sukhdev has joined #openstack-ironic | 00:09 | |
*** Sukhdev has quit IRC | 00:10 | |
*** mjturek has quit IRC | 00:12 | |
*** akhilaki_ has quit IRC | 00:16 | |
*** Sukhdev has joined #openstack-ironic | 00:17 | |
*** ijw has quit IRC | 00:20 | |
*** Goneri has quit IRC | 00:21 | |
*** threestrands has quit IRC | 00:21 | |
*** akhilaki has joined #openstack-ironic | 00:22 | |
*** yangyapeng has quit IRC | 00:22 | |
*** ijw has joined #openstack-ironic | 00:22 | |
NobodyCam | wow early morning vdrok :p | 00:33 |
NobodyCam | and Good Morning | 00:33 |
vdrok | NobodyCam: heh yeah, half past 4 pm but anyway :) | 00:33 |
NobodyCam | why did I think you where not in pst :p | 00:34 |
*** trown is now known as trown|outtypewww | 00:37 | |
*** Sukhdev has quit IRC | 00:41 | |
*** bfournie has joined #openstack-ironic | 00:49 | |
*** bfournie has quit IRC | 00:50 | |
*** zshi has quit IRC | 00:51 | |
*** zshi has joined #openstack-ironic | 00:52 | |
*** Sukhdev has joined #openstack-ironic | 00:52 | |
*** yangyapeng has joined #openstack-ironic | 00:55 | |
*** bfournie has joined #openstack-ironic | 00:57 | |
*** yangyapeng has quit IRC | 00:59 | |
*** ijw has quit IRC | 00:59 | |
*** yangyapeng has joined #openstack-ironic | 01:04 | |
*** akhilaki has quit IRC | 01:06 | |
*** links has joined #openstack-ironic | 01:09 | |
vdrok | good night everyone! | 01:11 |
TheJulia | vdrok: that is it exactly, and the intent/expectation that if a node is set to a pxe driver, then then it is network booting, where if agent driver then it would boot on its own. We still don't want to touch the boot device | 01:22 |
*** crushil has joined #openstack-ironic | 01:22 | |
TheJulia | well, touch the node. | 01:22 |
TheJulia | hogepodge: eek :( tcpdump inside the namespace? I wonder if things are getting plumbed properly | 01:22 |
*** crushil_ has joined #openstack-ironic | 01:24 | |
*** crushil has quit IRC | 01:27 | |
*** yuanying_ has quit IRC | 01:29 | |
*** yuanying has joined #openstack-ironic | 01:29 | |
*** priteau has joined #openstack-ironic | 01:32 | |
*** yuanying_ has joined #openstack-ironic | 01:33 | |
*** priteau has quit IRC | 01:37 | |
*** yuanying has quit IRC | 01:37 | |
*** litao__ has joined #openstack-ironic | 01:56 | |
*** zhangfei has joined #openstack-ironic | 02:03 | |
hogepodge | TheJulia: with all the stopping and restarting of my linuxbridge agent, I think I had bad iptables rules on my node | 02:09 |
*** namnh has joined #openstack-ironic | 02:11 | |
*** Gr3nth has joined #openstack-ironic | 02:20 | |
*** Grenth has quit IRC | 02:20 | |
*** phuongnh has joined #openstack-ironic | 02:21 | |
*** rloo has quit IRC | 02:27 | |
hogepodge | TheJulia: more progress. Turns out it was the set of dangling iptables rules. I'm getting the DHCP ack, now on to figure out how to deliver the ironic boot agent | 02:40 |
*** gcb has joined #openstack-ironic | 02:40 | |
*** threestrands has joined #openstack-ironic | 02:55 | |
*** trungnv has quit IRC | 03:03 | |
*** masber has joined #openstack-ironic | 03:03 | |
*** trungnv has joined #openstack-ironic | 03:04 | |
*** Sukhdev has quit IRC | 03:07 | |
*** masuberu has quit IRC | 03:07 | |
*** fragatina has quit IRC | 03:09 | |
*** fragatina has joined #openstack-ironic | 03:09 | |
*** fragatin_ has joined #openstack-ironic | 03:12 | |
TheJulia | hogepodge: Ironic should be sending along enough parameters to point to tftp when it has neutron allocate the dhcp address... but perhaps your falling to non-reserved addresses inside the subnets? | 03:12 |
*** fragatina has quit IRC | 03:14 | |
*** fragatin_ has quit IRC | 03:16 | |
*** absubram has quit IRC | 03:17 | |
*** fragatina has joined #openstack-ironic | 03:19 | |
*** fragatina has quit IRC | 03:24 | |
*** gcb has quit IRC | 03:25 | |
*** gcb has joined #openstack-ironic | 03:26 | |
*** e0ne has joined #openstack-ironic | 03:28 | |
*** masber has quit IRC | 03:30 | |
*** e0ne has quit IRC | 03:32 | |
*** priteau has joined #openstack-ironic | 03:33 | |
*** masber has joined #openstack-ironic | 03:34 | |
*** priteau has quit IRC | 03:38 | |
phuongnh | TheJulia: I have updated "Add additional capabilities discovery for iRMC driver" patchset, could you please help me to review it? The link is: https://review.openstack.org/#/c/417347/ | 03:39 |
patchbot | patch 417347 - ironic - Add additional capabilities discovery for iRMC driver | 03:39 |
*** Nisha_Agarwal has joined #openstack-ironic | 03:41 | |
*** Nisha_Agarwal has quit IRC | 03:44 | |
*** d0ugal_ has joined #openstack-ironic | 03:50 | |
*** d0ugal has quit IRC | 03:52 | |
*** e0ne has joined #openstack-ironic | 03:55 | |
*** e0ne has quit IRC | 04:00 | |
*** Nisha_Agarwal has joined #openstack-ironic | 04:02 | |
*** rbudden has quit IRC | 04:04 | |
*** gcb has quit IRC | 04:09 | |
*** e0ne has joined #openstack-ironic | 04:11 | |
*** AlexeyAbashkin has joined #openstack-ironic | 04:15 | |
*** crushil_ has quit IRC | 04:15 | |
*** e0ne has quit IRC | 04:16 | |
*** AlexeyAbashkin has quit IRC | 04:20 | |
*** udesale has joined #openstack-ironic | 04:21 | |
*** e0ne has joined #openstack-ironic | 04:23 | |
*** e0ne has quit IRC | 04:28 | |
*** priteau has joined #openstack-ironic | 04:37 | |
TheJulia | phuongnh: sure | 04:39 |
*** e0ne has joined #openstack-ironic | 04:39 | |
*** crushil_ has joined #openstack-ironic | 04:39 | |
phuongnh | TheJulia: Thank you | 04:40 |
*** priteau has quit IRC | 04:43 | |
*** e0ne has quit IRC | 04:44 | |
TheJulia | phuongnh: Question, if I have a list of capabilities defined by an operator, will the code delete them? | 04:48 |
*** e0ne has joined #openstack-ironic | 04:50 | |
*** zhangfei has quit IRC | 04:52 | |
TheJulia | phuongnh: nevermind, re-read the helper code and then the inspection code again | 04:54 |
*** tzumainn has quit IRC | 04:57 | |
*** Sukhdev has joined #openstack-ironic | 04:57 | |
*** crushil_ has quit IRC | 05:00 | |
*** e0ne has quit IRC | 05:03 | |
*** e0ne has joined #openstack-ironic | 05:07 | |
*** zhangfei has joined #openstack-ironic | 05:08 | |
TheJulia | phuongnh: The release note needs an upgrade section detailing the bump of the python-scciclient version. I'm 100% okay with it being done as a quick follow-up, and happy to approve the feature to land once a follow-up has been proposed. | 05:11 |
*** e0ne has quit IRC | 05:12 | |
*** e0ne has joined #openstack-ironic | 05:17 | |
*** e0ne has quit IRC | 05:22 | |
*** Sukhdev has quit IRC | 05:25 | |
*** fragatina has joined #openstack-ironic | 05:26 | |
*** fragatina has quit IRC | 05:27 | |
*** fragatina has joined #openstack-ironic | 05:27 | |
*** fragatina has quit IRC | 05:28 | |
*** fragatina has joined #openstack-ironic | 05:29 | |
*** e0ne has joined #openstack-ironic | 05:30 | |
*** e0ne has quit IRC | 05:35 | |
*** e0ne has joined #openstack-ironic | 05:38 | |
*** jaganathan has joined #openstack-ironic | 05:40 | |
*** e0ne has quit IRC | 05:43 | |
*** e0ne has joined #openstack-ironic | 05:45 | |
*** mikal has quit IRC | 05:47 | |
*** absubram has joined #openstack-ironic | 05:47 | |
phuongnh | TheJulia: for your question, the code will delete the list of capabilities that will be inspected. That list is defined in line 93 ironic/drivers/modules/irmc/inspect.py | 05:48 |
TheJulia | phuongnh: I noticed that, I just wanted to make sure and had to review the code in common/utils.py to be sure first | 05:49 |
TheJulia | phuongnh: Thanks for the reply! :) | 05:49 |
phuongnh | I got it, thanks | 05:49 |
TheJulia | Anyway, I'm going to get some sleep | 05:50 |
TheJulia | have a wonderful day! | 05:50 |
phuongnh | TheJulia: have a nice sleep | 05:50 |
phuongnh | TheJulia: Thanks | 05:50 |
*** absubram_ has joined #openstack-ironic | 05:50 | |
*** e0ne has quit IRC | 05:51 | |
*** absubram has quit IRC | 05:52 | |
*** absubram_ is now known as absubram | 05:52 | |
*** mikal has joined #openstack-ironic | 05:55 | |
*** e0ne has joined #openstack-ironic | 05:57 | |
*** udesale__ has joined #openstack-ironic | 06:01 | |
*** e0ne has quit IRC | 06:02 | |
*** e0ne has joined #openstack-ironic | 06:04 | |
*** udesale has quit IRC | 06:04 | |
*** pcaruana has joined #openstack-ironic | 06:05 | |
*** mikal_ has joined #openstack-ironic | 06:06 | |
*** e0ne has quit IRC | 06:09 | |
*** mikal has quit IRC | 06:10 | |
*** e0ne has joined #openstack-ironic | 06:15 | |
*** pcaruana has quit IRC | 06:16 | |
*** sasha21 has quit IRC | 06:18 | |
*** e0ne has quit IRC | 06:20 | |
*** e0ne has joined #openstack-ironic | 06:24 | |
*** e0ne has quit IRC | 06:29 | |
*** zhangfei has quit IRC | 06:32 | |
*** rwsu has joined #openstack-ironic | 06:33 | |
*** mcarden has quit IRC | 06:38 | |
*** masuberu has joined #openstack-ironic | 06:42 | |
*** zhangfei has joined #openstack-ironic | 06:45 | |
*** mikal_ has quit IRC | 06:45 | |
*** masber has quit IRC | 06:46 | |
*** mikal has joined #openstack-ironic | 06:47 | |
*** threestrands has quit IRC | 06:50 | |
*** marios has joined #openstack-ironic | 06:59 | |
*** hw_wutianwei has joined #openstack-ironic | 07:06 | |
*** vsaienko has joined #openstack-ironic | 07:06 | |
*** rbartal has joined #openstack-ironic | 07:11 | |
*** athomas has joined #openstack-ironic | 07:16 | |
*** pmannidi has quit IRC | 07:20 | |
*** rcernin has quit IRC | 07:20 | |
*** rwsu has quit IRC | 07:22 | |
*** vsaienko has quit IRC | 07:27 | |
pas-ha | morning ironic | 07:28 |
*** ijw has joined #openstack-ironic | 07:28 | |
*** jtomasek has joined #openstack-ironic | 07:29 | |
*** Nisha_ has joined #openstack-ironic | 07:31 | |
*** Nisha_Agarwal has quit IRC | 07:33 | |
*** rwsu has joined #openstack-ironic | 07:35 | |
*** udesale has joined #openstack-ironic | 07:38 | |
*** udesale__ has quit IRC | 07:39 | |
*** fragatina has quit IRC | 07:41 | |
*** racedo has joined #openstack-ironic | 07:54 | |
*** pcaruana has joined #openstack-ironic | 07:55 | |
*** ijw has quit IRC | 08:04 | |
*** ijw has joined #openstack-ironic | 08:05 | |
*** Nisha_away has joined #openstack-ironic | 08:05 | |
*** AlexeyAbashkin has joined #openstack-ironic | 08:06 | |
*** TuanLA has joined #openstack-ironic | 08:07 | |
*** rcernin has joined #openstack-ironic | 08:07 | |
*** Nisha_ has quit IRC | 08:09 | |
*** ijw has quit IRC | 08:09 | |
*** hoonetorg has quit IRC | 08:11 | |
*** makowals has quit IRC | 08:16 | |
*** e0ne has joined #openstack-ironic | 08:18 | |
*** hoonetorg has joined #openstack-ironic | 08:26 | |
*** hoonetorg has quit IRC | 08:26 | |
*** hoonetorg has joined #openstack-ironic | 08:27 | |
*** vsaienko has joined #openstack-ironic | 08:29 | |
*** makowals has joined #openstack-ironic | 08:36 | |
*** priteau has joined #openstack-ironic | 08:40 | |
*** AlexeyAbashkin has quit IRC | 08:41 | |
*** AlexeyAbashkin has joined #openstack-ironic | 08:42 | |
*** priteau has quit IRC | 08:45 | |
*** milan has joined #openstack-ironic | 08:48 | |
*** ccamacho has joined #openstack-ironic | 08:52 | |
*** vsaienko has quit IRC | 08:59 | |
*** vsaienko has joined #openstack-ironic | 09:01 | |
*** ccamacho has quit IRC | 09:02 | |
*** ccamacho has joined #openstack-ironic | 09:05 | |
*** ccamacho has quit IRC | 09:06 | |
*** ccamacho has joined #openstack-ironic | 09:06 | |
*** adisky_ has joined #openstack-ironic | 09:08 | |
*** d0ugal_ has quit IRC | 09:17 | |
*** d0ugal has joined #openstack-ironic | 09:18 | |
*** d0ugal has quit IRC | 09:18 | |
*** d0ugal has joined #openstack-ironic | 09:18 | |
*** Nisha_away has quit IRC | 09:19 | |
*** namnh has quit IRC | 09:21 | |
*** udesale has quit IRC | 09:31 | |
*** udesale has joined #openstack-ironic | 09:31 | |
*** zhangfei has quit IRC | 09:36 | |
*** pester has joined #openstack-ironic | 09:36 | |
*** asettle_ has joined #openstack-ironic | 09:38 | |
*** EmilienM_ has joined #openstack-ironic | 09:39 | |
*** asettle has quit IRC | 09:39 | |
*** marlinc has quit IRC | 09:39 | |
*** mkrai has quit IRC | 09:39 | |
*** EmilienM has quit IRC | 09:39 | |
*** fxpester has quit IRC | 09:39 | |
*** dr_gogeta86 has quit IRC | 09:39 | |
*** andymccr has quit IRC | 09:39 | |
*** pcaruana has quit IRC | 09:39 | |
*** dr_gogeta86_ has joined #openstack-ironic | 09:39 | |
*** lucas-afk is now known as lucasagomes | 09:40 | |
*** pcaruana has joined #openstack-ironic | 09:40 | |
*** EmilienM_ is now known as EmilienM | 09:40 | |
*** andymccr has joined #openstack-ironic | 09:40 | |
*** e0ne has quit IRC | 09:40 | |
*** EmilienM has quit IRC | 09:41 | |
*** EmilienM has joined #openstack-ironic | 09:41 | |
*** parlos has joined #openstack-ironic | 09:42 | |
*** mgoddard has joined #openstack-ironic | 09:42 | |
*** marlinc has joined #openstack-ironic | 09:44 | |
*** mkrai has joined #openstack-ironic | 09:44 | |
*** zhangfei has joined #openstack-ironic | 09:49 | |
*** vsaienko has quit IRC | 09:54 | |
*** TuanLA has quit IRC | 09:58 | |
*** hw_wutianwei has quit IRC | 10:00 | |
*** charcol-v2 has joined #openstack-ironic | 10:01 | |
*** e0ne has joined #openstack-ironic | 10:01 | |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: devstack: add support for setting rescue interface https://review.openstack.org/524118 | 10:09 |
*** charcol has quit IRC | 10:09 | |
*** fyxim has quit IRC | 10:09 | |
*** zhenguo has quit IRC | 10:09 | |
*** v12aml has quit IRC | 10:09 | |
*** dtantsur|afk has quit IRC | 10:09 | |
*** amarao has joined #openstack-ironic | 10:10 | |
*** dtantsur has joined #openstack-ironic | 10:15 | |
*** fyxim has joined #openstack-ironic | 10:15 | |
*** zhenguo has joined #openstack-ironic | 10:15 | |
*** v12aml has joined #openstack-ironic | 10:15 | |
*** dtantsur has quit IRC | 10:15 | |
*** dtantsur has joined #openstack-ironic | 10:15 | |
*** trungnv has quit IRC | 10:15 | |
*** udesale has quit IRC | 10:16 | |
*** jesusaur has quit IRC | 10:17 | |
*** jesusaur has joined #openstack-ironic | 10:22 | |
*** phuongnh has quit IRC | 10:43 | |
*** phuongnh has joined #openstack-ironic | 10:44 | |
*** derekh has joined #openstack-ironic | 10:45 | |
*** vsaienko has joined #openstack-ironic | 10:46 | |
*** vsaienko has quit IRC | 10:48 | |
*** masuberu has quit IRC | 10:49 | |
*** vsaienko has joined #openstack-ironic | 10:50 | |
*** jlabarre has quit IRC | 10:50 | |
*** milan has quit IRC | 10:51 | |
*** jlabarre has joined #openstack-ironic | 10:55 | |
openstackgerrit | Nguyen Hung Phuong proposed openstack/ironic master: Follow up Add additional capabilities discovery for iRMC driver https://review.openstack.org/524137 | 10:56 |
*** vsaienko has quit IRC | 10:58 | |
*** zhangfei has quit IRC | 11:03 | |
*** jlabarre has quit IRC | 11:10 | |
*** efried has quit IRC | 11:10 | |
*** natorious has quit IRC | 11:11 | |
*** racedo_ has joined #openstack-ironic | 11:11 | |
*** phuongnh has quit IRC | 11:12 | |
*** racedo has quit IRC | 11:12 | |
*** retr0h has quit IRC | 11:13 | |
*** csmart has quit IRC | 11:13 | |
*** natorious has joined #openstack-ironic | 11:14 | |
*** efried has joined #openstack-ironic | 11:14 | |
*** mkrai has quit IRC | 11:14 | |
*** jlabarre has joined #openstack-ironic | 11:15 | |
*** priteau has joined #openstack-ironic | 11:23 | |
*** vsaienko has joined #openstack-ironic | 11:27 | |
*** jesusaur has quit IRC | 11:30 | |
*** jesusaur has joined #openstack-ironic | 11:31 | |
*** vsaienko has quit IRC | 11:32 | |
openstackgerrit | John Garbutt proposed openstack/ironic-specs master: Deploy Templates https://review.openstack.org/504952 | 11:36 |
*** jkilpatr has quit IRC | 11:37 | |
*** vsaienko has joined #openstack-ironic | 11:40 | |
dtantsur | morning ironic | 11:43 |
*** udesale has joined #openstack-ironic | 11:47 | |
openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: scripts: install-deps.sh: Add missing e2fsprogs dependency https://review.openstack.org/524148 | 11:48 |
*** mat128 has joined #openstack-ironic | 11:49 | |
*** rcernin has quit IRC | 11:52 | |
*** jkilpatr has joined #openstack-ironic | 11:56 | |
*** vsaienko has quit IRC | 12:05 | |
*** vsaienko has joined #openstack-ironic | 12:06 | |
*** qsyqian has joined #openstack-ironic | 12:08 | |
*** qsyqian_ has joined #openstack-ironic | 12:09 | |
*** amarao1 has joined #openstack-ironic | 12:09 | |
*** racedo_ has quit IRC | 12:09 | |
*** etingof has quit IRC | 12:12 | |
*** jkilpatr has quit IRC | 12:14 | |
*** jkilpatr has joined #openstack-ironic | 12:17 | |
*** bfournie has quit IRC | 12:17 | |
*** bfournie has joined #openstack-ironic | 12:18 | |
*** bfournie has quit IRC | 12:22 | |
*** qsyqian has quit IRC | 12:24 | |
*** retr0h has joined #openstack-ironic | 12:30 | |
*** lucasagomes is now known as lucas-hungry | 12:30 | |
*** vsaienko has quit IRC | 12:34 | |
*** wsl has joined #openstack-ironic | 12:38 | |
*** wsl has quit IRC | 12:39 | |
*** early has quit IRC | 12:44 | |
*** vsaienko has joined #openstack-ironic | 12:47 | |
*** etingof has joined #openstack-ironic | 12:50 | |
*** early has joined #openstack-ironic | 12:51 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Switch emphasis to hardware types in the installation guide https://review.openstack.org/517290 | 12:52 |
*** bfournie has joined #openstack-ironic | 12:56 | |
*** etingof has quit IRC | 12:58 | |
*** qsyqian_ has quit IRC | 12:58 | |
*** dprince has joined #openstack-ironic | 12:59 | |
*** MattMan has quit IRC | 13:03 | |
*** MattMan has joined #openstack-ironic | 13:04 | |
*** etingof has joined #openstack-ironic | 13:10 | |
*** trown|outtypewww is now known as trown | 13:11 | |
*** mkrai has joined #openstack-ironic | 13:12 | |
*** csmart has joined #openstack-ironic | 13:12 | |
*** dtantsur is now known as dtantsur|brb | 13:13 | |
*** mcarden has joined #openstack-ironic | 13:14 | |
*** vsaienko has joined #openstack-ironic | 13:16 | |
*** vsaienko has quit IRC | 13:16 | |
*** tzumainn has joined #openstack-ironic | 13:19 | |
*** zhangfei has joined #openstack-ironic | 13:22 | |
*** yangyapeng has quit IRC | 13:26 | |
*** yangyapeng has joined #openstack-ironic | 13:27 | |
sambetts|afk | dtantsur|brb: I'm not sure what to do with the networking docs, the networking information in the install guide might need some significant changes to incorporate the information about the interfaces in a way that makes sense | 13:29 |
*** sambetts|afk is now known as sambetts | 13:29 | |
*** crushil_ has joined #openstack-ironic | 13:29 | |
sambetts | dtantsur|brb: so the patch will become more that just simply adding the information about the interfaces | 13:30 |
sambetts | s/that/than | 13:30 |
*** yangyapeng has quit IRC | 13:36 | |
*** lucas-hungry is now known as lucasagomes | 13:39 | |
*** stendulker has joined #openstack-ironic | 13:41 | |
*** milan_ has joined #openstack-ironic | 13:51 | |
milan_ | morning Ironic! :) | 13:53 |
*** links has quit IRC | 13:54 | |
*** sasha21 has joined #openstack-ironic | 14:02 | |
*** d0ugal has quit IRC | 14:03 | |
*** Goneri has joined #openstack-ironic | 14:06 | |
*** mat128 has quit IRC | 14:08 | |
*** rloo has joined #openstack-ironic | 14:14 | |
gmonteiro | Good morning milan_ and all o/ | 14:16 |
milan_ | morning gmonteiro! :) | 14:17 |
*** d0ugal has joined #openstack-ironic | 14:17 | |
*** jaypipes has joined #openstack-ironic | 14:19 | |
*** rbudden has joined #openstack-ironic | 14:20 | |
openstackgerrit | Sam Betts proposed openstack/ironic master: Receive and store agent version on heartbeat https://review.openstack.org/364861 | 14:22 |
*** racedo_ has joined #openstack-ironic | 14:24 | |
*** zhangfei has quit IRC | 14:30 | |
*** jaganathan has quit IRC | 14:39 | |
*** e0ne has quit IRC | 14:39 | |
*** e0ne has joined #openstack-ironic | 14:40 | |
*** dtantsur|brb is now known as dtantsur | 14:42 | |
dtantsur | sambetts: yeah, but then folks following the install guide will simply miss this information.. | 14:42 |
sambetts | that also miss all the information about network interfaces | 14:43 |
sambetts | they* | 14:43 |
*** mjturek has joined #openstack-ironic | 14:43 | |
sambetts | today, so thats why I'm saying we need to rewrite the whole doc about networking | 14:43 |
sambetts | configuration | 14:43 |
dtantsur | yeah, we may use some extensive cross-linking.. | 14:43 |
dtantsur | sambetts: approved the patch, but please consider how we could clean it up | 14:44 |
sambetts | dtantsur: will do :) | 14:45 |
*** jaganathan has joined #openstack-ironic | 14:45 | |
*** stendulker has quit IRC | 14:49 | |
*** rloo has quit IRC | 14:50 | |
*** rloo has joined #openstack-ironic | 14:51 | |
*** jaganathan has quit IRC | 14:53 | |
TheJulia | Good morning everyone | 15:06 |
*** jrist has quit IRC | 15:08 | |
*** mat128 has joined #openstack-ironic | 15:09 | |
*** jrist has joined #openstack-ironic | 15:09 | |
*** actatux has quit IRC | 15:09 | |
*** udesale has quit IRC | 15:13 | |
*** udesale has joined #openstack-ironic | 15:14 | |
*** udesale has quit IRC | 15:14 | |
dtantsur | morning TheJulia | 15:15 |
*** litao__ has quit IRC | 15:16 | |
dtantsur | milan_, sambetts, aarefiev: could you please review all in https://review.openstack.org/#/q/project:openstack/python-ironic-inspector-client+status:open more or less urgently? we need a release for Queens. | 15:18 |
rpioso | Good morning, ironicers! | 15:18 |
milan_ | ack | 15:18 |
sambetts | dtantsur: looking now | 15:19 |
milan_ | morning rpioso, sambetts, TheJulia! | 15:19 |
*** stendulker has joined #openstack-ironic | 15:19 | |
rpioso | milan_ :) | 15:19 |
*** rbartal has quit IRC | 15:22 | |
*** stendulker_ has joined #openstack-ironic | 15:24 | |
dtantsur | sambetts: thanks! more importantly, the 2 breaking changes that require a major bump | 15:26 |
dtantsur | morning rpioso | 15:26 |
*** stendulker has quit IRC | 15:26 | |
*** stendulker_ has quit IRC | 15:26 | |
*** stendulker_ has joined #openstack-ironic | 15:27 | |
rpioso | dtantsur: Hey! :) | 15:30 |
stendulker_ | Good morning all :) | 15:33 |
milan_ | morning stendulker_! :) | 15:34 |
stendulker_ | rloo: Hi | 15:34 |
openstackgerrit | Ruby Loo proposed openstack/ironic-specs master: Ironic deployment steps https://review.openstack.org/412523 | 15:35 |
stendulker_ | rloo: Do you have few mins to discuss DB migration for rescue interface | 15:35 |
rloo | stendulker_: hi and good morning | 15:35 |
rloo | stendulker_: oh yeah. sorry, i was heads down on deployment steps ^^. good timing. | 15:35 |
rloo | stendulker_: so... basically, i need to think about it. i'm not convinced it will work | 15:35 |
stendulker_ | milan_: :) | 15:35 |
rloo | stendulker_: sec, let me find a link... | 15:35 |
stendulker_ | rloo: ok :) | 15:36 |
rloo | stendulker_: this is what I meant by online data migrations: https://docs.openstack.org/ironic/latest/contributor/rolling-upgrades.html#online-data-migrations | 15:36 |
rloo | stendulker_: which isn't what you did. i didn't realize that the default rescue interface value had to be no-rescue for hardware types | 15:36 |
stendulker_ | rloo: If busy, we can discuss it later... | 15:36 |
rloo | stendulker_: does it have to be no-rescue, or can it be None too? | 15:37 |
stendulker_ | rloo: Yes, I think we can have default value as 'None' | 15:37 |
rloo | stendulker_: if it is None, then things are easier, cuz that's the default value when that column is added to the DB, right? | 15:37 |
-openstackstatus- NOTICE: if you receieved a result of "RETRY_LIMIT" after 14:15 UTC, it was likely due to an error since corrected. please "recheck" | 15:37 | |
stendulker_ | Initially logic was different and hence we were setting it as no-rescue. We can have it None now | 15:37 |
dtantsur | morning rloo | 15:38 |
stendulker_ | I will change the default value to 'None'. | 15:38 |
rloo | stendulker_: ok, if None, you don't need that patch that upgrades based on the config setting. | 15:38 |
stendulker_ | rloo: yes | 15:38 |
rloo | stendulker_: and i need to think again, but i think we don't need an online data migration either | 15:38 |
rloo | hiya dtantsur | 15:38 |
stendulker_ | But dont we need to provide mechanism to populate based on users default_rescue_interface valuie? | 15:39 |
rloo | and good morning to everyone else! rpioso, milan_, sambetts, TheJulia | 15:39 |
sambetts | hey rloo | 15:39 |
stendulker_ | like we do it for network interface? https://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/alembic/versions/c14cef6dfedf_populate_node_network_interface.py | 15:40 |
rpioso | Good morning, rloo :) | 15:40 |
rloo | stendulker_: hmm, i'm not sure. i don't think so... | 15:40 |
rloo | stendulker_: well, for network, we needed to or things would have broken i think | 15:40 |
milan_ | morning rloo! :) | 15:40 |
rloo | stendulker_: for rescue, who knows if they want to use the rescue interface? | 15:40 |
rloo | stendulker_: what did we do for storage interface? | 15:40 |
stendulker_ | rloo: There is no such thing done for storage | 15:42 |
rloo | stendulker_: by the way, i've got a question about rescue. it isn't clear how it is meant to be used (not clear to me). i've never tried to 'rescue' anything. is it the user of the instance that initiates this rescue via nova rescue (or whatever) | 15:42 |
stendulker_ | I think storage interface is a better reference. Then we might not need any migration stuff. | 15:43 |
stendulker_ | rloo: That's right. | 15:43 |
stendulker_ | rloo: User would initiate it using nova rescue | 15:43 |
rloo | stendulker_: so we're letting the user get access to the node, as we assume the user knows what they're doing.. | 15:43 |
stendulker_ | yes | 15:44 |
stendulker_ | Good morning dtantsur, sambetts, rpioso, TheJulia :) | 15:44 |
rloo | stendulker_: hmm. i wonder if that is good or not, but i guess it is up to the operator/admin to allow. | 15:44 |
dtantsur | hi stendulker_ | 15:45 |
stendulker_ | rloo: yes, thats understanding | 15:45 |
rloo | dtantsur, sambetts, TheJulia: do you have an opinion on the default value of RescueInterface? Once we introduce it, it will be None for all existing nodes. Are operators going to want us to set that value to something other than none for their nodes, or can we assume they can do that themselves? | 15:45 |
stendulker_ | rloo: To summarise, we would not need any migration things for rescue. | 15:45 |
*** stendulker_ has quit IRC | 15:46 | |
*** stendulker_ has joined #openstack-ironic | 15:46 | |
TheJulia | i think None is fine as long as it maps to no-rescue since that would align with what exists now | 15:46 |
rloo | stendulker_: ^^ just want to get more opinions. Also, is rescue interface avail to existing classic drivers? | 15:46 |
rloo | TheJulia: good, that's what I think too :) | 15:46 |
stendulker_ | rloo: no, its not going to be available for classic drivers | 15:47 |
rloo | stendulker_: another good, and another reason for folks to migrate to hardware types :) | 15:47 |
TheJulia | That being said, we have allowed for the field to be populated if explicitly set as a default when upgrading, like we have done for many of the interfaces we've added/enabld. | 15:47 |
rloo | TheJulia: we have? stendulker_ just indicated that we don't for storage interface. | 15:48 |
TheJulia | we did for network.... I thought we did for storage as well... | 15:48 |
rloo | TheJulia: i thought we *had* to for network or things would have broken. | 15:48 |
TheJulia | well, yes | 15:49 |
* TheJulia looks at storage | 15:49 | |
stendulker_ | TheJulia: I did not find any population of storage interface... | 15:49 |
TheJulia | nope we didn't | 15:49 |
*** stendulker_ has quit IRC | 15:51 | |
TheJulia | I pulled up the commit that landed. I guess that is because we mapped None in that case to a noop interface as it was explicitly an opt-in interface | 15:51 |
*** stendulker_ has joined #openstack-ironic | 15:51 | |
stendulker_ | rloo, TheJulia: I have flaky connection today... | 15:52 |
rloo | TheJulia: I suspect that is what stendulker_ will do with the rescue interface. (Although I ALWAYS get confused with 'noop' and 'no-X' interface implementation) | 15:52 |
rloo | stendulker_: I think it is OK to have the default value be None, and no data migration / upgrade code needed. | 15:53 |
rloo | stendulker_: i'll comment in the/some patch... | 15:53 |
stendulker_ | rloo, TheJulia: I think storage is a better reference for rescue. | 15:53 |
stendulker_ | rloo: Ok. | 15:54 |
*** dprince has quit IRC | 15:54 | |
stendulker_ | rloo: Another thing, since we will not have rescue support for classic drivers, adding AgentRescue as a supported interface to fake-hardware | 15:55 |
*** UForgotten has quit IRC | 15:55 | |
rloo | stendulker_: not sure i understand | 15:55 |
stendulker_ | rloo: One sec, getting link | 15:55 |
*** UForgotten has joined #openstack-ironic | 15:56 | |
stendulker_ | rloo: https://review.openstack.org/#/c/400437/69/ironic/drivers/fake_hardware.py | 15:57 |
patchbot | patch 400437 - ironic - Agent rescue implementation | 15:57 |
rloo | so why did you add AgentDeploy ? | 15:57 |
rloo | stendulker_: I thought fake hardware did nothing | 15:58 |
stendulker_ | rloo: Ok, I think I will have to re-look I added AgentDeploy | 15:58 |
rloo | stendulker_: same question for AgentRescue | 15:58 |
stendulker_ | I will check and get back to you... I thougt it for AgentREscue | 15:58 |
dtantsur | milan_: the last two patches are only waiting for 1x +2 ;) and I can make the release team happy | 15:59 |
stendulker_ | rloo: For AgentRescue it was added for unit testing | 15:59 |
rloo | stendulker_: i don't think that is a good reason for adding it in. can't you mock the call instead? | 15:59 |
stendulker_ | since we do not have this interface supported for classic drivers | 15:59 |
milan_ | dtantsur, lol OK, let's make some people happy :D | 15:59 |
TheJulia | stendulker_: you can dynamically update on a per test-level so you don't need to do that | 15:59 |
stendulker_ | biut wont mocking wont it be at method level... HOw do I do it to track the flow within method? | 16:01 |
rloo | stendulker_: i haven't actually looked at the tests yet. but please, remove that stuff from fake hardware. | 16:02 |
stendulker_ | rloo: Ok. I was trying to do like in FakeAgentDriver https://github.com/openstack/ironic/blob/master/ironic/drivers/fake.py#L113-L120 | 16:03 |
*** mat128 has quit IRC | 16:04 | |
*** mat128 has joined #openstack-ironic | 16:04 | |
rloo | stendulker_: honestly, i would need to look through the tests, etc, to figure out how other stuff was done/tested. you could do a similar thing. | 16:05 |
*** mat128 has quit IRC | 16:05 | |
stendulker_ | rloo: sure. Thanks a lot. | 16:05 |
rloo | stendulker_: which means, i don't know the solution right now and don't want to look into it :) | 16:05 |
stendulker_ | rloo: No problem. I got lots of my dobts cleared. :) | 16:06 |
stendulker_ | rloo, TheJulia: Thank you. | 16:06 |
rloo | stendulker_: great! | 16:06 |
openstackgerrit | Merged openstack/ironic master: Add missing 'autospec' to unit tests - /unit/objects/ https://review.openstack.org/517168 | 16:07 |
rpioso | Hey stendulker_ :) | 16:07 |
*** mat128 has joined #openstack-ironic | 16:08 | |
stendulker_ | rpioso: Hi | 16:08 |
*** dprince has joined #openstack-ironic | 16:08 | |
*** stendulker_ has quit IRC | 16:09 | |
dtantsur | TheJulia: we don't have a BFV meeting any more, do we? | 16:10 |
TheJulia | not really, lots of interest dropped off since we got something minimally viable in place. :( | 16:10 |
TheJulia | Also UI, I'm going to propose to pull the ui meeting | 16:10 |
TheJulia | that and I've also been crazy busy | 16:11 |
dtantsur | I see, yeah.. | 16:12 |
*** mat128 has quit IRC | 16:12 | |
* TheJulia doesn't even know what time it really is anymore | 16:13 | |
TheJulia | Ahh, it is breakfast time :) | 16:13 |
openstackgerrit | Merged openstack/ironic master: Fix the format command-line https://review.openstack.org/523001 | 16:16 |
*** dyasny has quit IRC | 16:20 | |
*** phuongnh has joined #openstack-ironic | 16:27 | |
NobodyCam | Good Morning Ironic'ers | 16:28 |
rloo | Morning NobodyCam | 16:29 |
NobodyCam | Morning rloo :) | 16:29 |
dtantsur | morning NobodyCam | 16:30 |
NobodyCam | Morning dtantsur :) | 16:30 |
rloo | yolanda, dtantsur, TheJulia: I've updated the deploy steps spec; please let me know if you wish to be an assignee/contributor (or comment on the spec): https://review.openstack.org/#/c/412523/ | 16:30 |
patchbot | patch 412523 - ironic-specs - Ironic deployment steps | 16:30 |
dtantsur | rloo: I can be a contributor, if you need moar of those :) | 16:31 |
TheJulia | rloo: pulled my -2 at this point since we had the discussion yesterday | 16:31 |
rloo | dtantsur: heh, i haven't even looked at the coding involved; hopefully minimal, but if you will/want to contribute, i'll leave your name there | 16:32 |
NobodyCam | oh I have to read over that one! | 16:32 |
rloo | NobodyCam: that'd be greatly appreciated :) | 16:32 |
NobodyCam | will be later today! | 16:32 |
rloo | TheJulia: thx! (and a +2 would be even better, ha ha) | 16:33 |
TheJulia | NobodyCam: speaking of the crazy one that we discussed, I might try to write that this weekend if I have nothing going on. | 16:33 |
NobodyCam | oh :) | 16:33 |
phuongnh | TheJulia: I have added follow up patchset, https://review.openstack.org/#/c/524137/, it is my first time I create follow up patchset so please help me to review. I can see it is Zuul -1 because of merge conflict. | 16:34 |
patchbot | patch 524137 - ironic - Follow up Add additional capabilities discovery fo... | 16:34 |
TheJulia | phuongnh: awesome! | 16:34 |
phuongnh | TheJulia: :) | 16:34 |
dtantsur | milan_: any opinion on https://review.openstack.org/#/c/521069/ ? | 16:35 |
patchbot | patch 521069 - python-ironic-inspector-client - Drop default URI, make either a session or inspect... | 16:35 |
NobodyCam | merge conflict prob just needs to be rebased | 16:35 |
milan_ | dtantsur, reading thru right now | 16:35 |
dtantsur | okay | 16:35 |
openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: Test OPNFV CI verify job. Please ignore. https://review.openstack.org/367608 | 16:39 |
phuongnh | NobodyCam: should I rebase the patchset 524137 now? | 16:39 |
*** charcol-v2 has quit IRC | 16:40 | |
*** mat128 has joined #openstack-ironic | 16:43 | |
*** e0ne has quit IRC | 16:43 | |
* dtantsur has learned about "HTTP 418 I'm a teapot" code and intends to use it in ironic API from now on | 16:44 | |
TheJulia | lol | 16:45 |
TheJulia | phuongnh: you started a new patch off master instead of the parent patch, you should just rebase on top of it, and edit the files instead of adding new. If that makes sense. Also left feedback in the change. | 16:46 |
TheJulia | dtantsur: yes please | 16:46 |
phuongnh | TheJulia: lol, I got it | 16:48 |
dtantsur | btw it's good code for UnsupportedVendorExtension. like, "I'm a teapot, what do you want of me?" | 16:48 |
openstackgerrit | Nguyen Hung Phuong proposed openstack/ironic master: Follow up Add additional capabilities discovery for iRMC driver https://review.openstack.org/524137 | 16:49 |
NobodyCam | dtantsur: LOL ++++ | 16:50 |
NobodyCam | but then we would need to implement RFC: 2324 | 16:51 |
NobodyCam | https://www.ietf.org/rfc/rfc2324.txt | 16:51 |
TheJulia | If only there was a coffee pot driver? ;) | 16:52 |
phuongnh | TheJulia: look like it is easier for me to start a new patch of the parent patch than fix the current follow up patch | 16:52 |
TheJulia | phuongnh: that works, just please preserve the Change-ID | 16:53 |
phuongnh | TheJulia: is that I1958e18a5b9d933e2aa405b200bac7717f146611 ? | 16:53 |
TheJulia | "Change-Id: I1ca1e1e02b8c2102e0dbd858c0a51df0dd6b58fb" | 16:53 |
TheJulia | The change-id of the follow-up. You don't need a depends-on in this case | 16:54 |
NobodyCam | TheJulia: https://github.com/NoBodyCam/ironic | 16:54 |
NobodyCam | its a little out of date now but.... | 16:54 |
TheJulia | :0 | 16:55 |
TheJulia | err :) | 16:55 |
*** d0ugal has quit IRC | 16:55 | |
NobodyCam | :p | 16:56 |
*** fragatina has joined #openstack-ironic | 16:56 | |
dtantsur | LOL | 16:57 |
openstackgerrit | Merged openstack/python-ironic-inspector-client master: Remove support for passing auth_token to ClientV1 https://review.openstack.org/521063 | 16:59 |
openstackgerrit | Merged openstack/python-ironic-inspector-client master: Functional tests: pin *inspector* to HEAD https://review.openstack.org/453556 | 16:59 |
*** marios has quit IRC | 17:00 | |
TheJulia | So anyone want to talk about BFV today? | 17:00 |
dtantsur | TheJulia: it was 1 hour ago, I think? :) anyway, I don't have anything useful | 17:01 |
*** AlexeyAbashkin has quit IRC | 17:01 | |
TheJulia | awesome! | 17:01 |
*** fragatina has quit IRC | 17:01 | |
TheJulia | oh... daylight savings time hit my calendar | 17:01 |
TheJulia | AWESOME! | 17:02 |
dtantsur | heh | 17:02 |
* TheJulia goes back to creating some rfes | 17:02 | |
dtantsur | ++ | 17:02 |
dtantsur | and I'll go check out some Glühwein | 17:02 |
*** dtantsur is now known as dtantsur|afk | 17:03 | |
dtantsur|afk | see you all | 17:03 |
TheJulia | enjoy! | 17:03 |
rloo | dtantsur|afk: tschuss | 17:04 |
NobodyCam | rloo: +2 for this line alone: `rloo, wow, that seems so easy; is that all there is too it? :D` | 17:06 |
rloo | NobodyCam: heh, I knew I'd have to update that patch, so threw that in. | 17:06 |
NobodyCam | well now I could only give two +1's | 17:06 |
rloo | NobodyCam: we could change that, if ... | 17:07 |
NobodyCam | :) +++ | 17:07 |
NobodyCam | :) | 17:07 |
*** pcaruana has quit IRC | 17:08 | |
*** d0ugal has joined #openstack-ironic | 17:08 | |
phuongnh | TheJulia: Thanks for your review. | 17:09 |
phuongnh | TheJulia: so my next actions are: 1. Remove the depend-on in the follow up patch. 2. Wait for the main patchset are merged and then click on rebase button? | 17:10 |
*** akhilaki has joined #openstack-ironic | 17:14 | |
TheJulia | phuongnh: you can just download the main patchset, then use git review -x follow-up-patch-id-number | 17:17 |
TheJulia | err | 17:17 |
TheJulia | follow-up-change-number | 17:17 |
TheJulia | edit, and resubmit | 17:17 |
phuongnh | thanks, very detail and useful instructions | 17:18 |
openstackgerrit | John L. Villalovos proposed openstack/ironic master: Detect when log messages are mis-formatted https://review.openstack.org/232257 | 17:21 |
*** lucasagomes is now known as lucas-afk | 17:21 | |
*** d0ugal has quit IRC | 17:24 | |
TheJulia | jlvacation: Hey, you should be on vacation! :) | 17:25 |
*** jlvacation is now known as jlvillal | 17:25 | |
jlvillal | TheJulia: I'm back! | 17:25 |
jlvillal | TheJulia: Or is that. I'm back :( | 17:25 |
TheJulia | :( | 17:25 |
jlvillal | Portugal was fun though. I recommend it. | 17:26 |
jlvillal | Especially for lucas-afk since he speaks the language :) | 17:26 |
*** fragatina has joined #openstack-ironic | 17:26 | |
milan_ | sambetts, hey got a second for https://review.openstack.org/#/c/521069/2 | 17:27 |
patchbot | patch 521069 - python-ironic-inspector-client - Drop default URI, make either a session or inspect... | 17:27 |
milan_ | ? | 17:27 |
milan_ | there's a bit of an (unintended?) discrepancy in exceptions in unittest | 17:27 |
* milan_ would a+ but probably would be nice to have a follow up | 17:28 | |
milan_ | dtantsur|afk seems gone already ;) | 17:28 |
milan_ | sambetts, wdyt? | 17:28 |
* milan_ approved never mind :D | 17:30 | |
*** penick has joined #openstack-ironic | 17:31 | |
*** dsneddon has joined #openstack-ironic | 17:32 | |
*** d0ugal has joined #openstack-ironic | 17:35 | |
*** phuongnh has quit IRC | 17:36 | |
*** trown is now known as trown|lunch | 17:36 | |
*** amarao1 has quit IRC | 17:46 | |
*** yangyapeng has joined #openstack-ironic | 17:49 | |
*** derekh has quit IRC | 17:49 | |
*** yangyapeng has quit IRC | 17:54 | |
*** fragatina has quit IRC | 17:57 | |
*** fragatina has joined #openstack-ironic | 18:01 | |
*** absubram has quit IRC | 18:01 | |
jlvillal | So where do we meet these days? Here? | 18:02 |
*** milan_ has quit IRC | 18:02 | |
jlvillal | Oh, I forgot it isn't Monday. heh | 18:03 |
jlvillal | Just because it is my first day back to work doesn't make it Monday :) | 18:03 |
NobodyCam | Welcome back jlvillal :) | 18:06 |
jlvillal | Thanks NobodyCam :) | 18:07 |
*** srart has quit IRC | 18:09 | |
*** srart has joined #openstack-ironic | 18:10 | |
NobodyCam | :) | 18:10 |
*** amarao has quit IRC | 18:11 | |
openstackgerrit | Merged openstack/python-ironic-inspector-client master: Drop default URI, make either a session or inspector_url required https://review.openstack.org/521069 | 18:19 |
*** actatux has joined #openstack-ironic | 18:21 | |
openstackgerrit | Michael Turek proposed openstack/ironic-python-agent master: Use LSHW in place of dmidecode for the default hardware manager https://review.openstack.org/501799 | 18:22 |
*** srart has quit IRC | 18:22 | |
*** jkilpatr has quit IRC | 18:23 | |
openstackgerrit | Fellype Cavalcante proposed openstack/ironic master: [WIP/DNM] Migrate oneview driver to use python-hpOneView https://review.openstack.org/524310 | 18:25 |
vdrok | good morning all, rloo TheJulia NobodyCam and jlvillal | 18:35 |
vdrok | TheJulia: reported https://bugs.launchpad.net/ironic/+bug/1735517 | 18:35 |
openstack | Launchpad bug 1735517 in Ironic "iscsi deploy interface triggers set boot device in case of adoption" [Medium,New] - Assigned to Vladyslav Drok (vdrok) | 18:36 |
NobodyCam | Good Morning vdrok :) | 18:36 |
TheJulia | vdrok: *sigh8 | 18:36 |
TheJulia | sigh* | 18:36 |
rloo | Morning vdrok! | 18:36 |
* TheJulia just lacks spoons right now | 18:36 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent master: Fix issue with double mocking of utils.execute functions https://review.openstack.org/524312 | 18:36 |
NobodyCam | no soup for you :p | 18:37 |
jlvillal | Hi vdrok :) | 18:37 |
*** trown|lunch is now known as trown | 18:37 | |
*** jkilpatr has joined #openstack-ironic | 18:39 | |
* TheJulia steps away for a little while | 18:40 | |
*** absubram has joined #openstack-ironic | 18:43 | |
*** crushil_ has quit IRC | 18:47 | |
*** openstackgerrit has quit IRC | 18:48 | |
*** pcaruana has joined #openstack-ironic | 18:50 | |
*** openstackgerrit has joined #openstack-ironic | 18:52 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent master: Fix issue with double mocking of utils.execute functions https://review.openstack.org/524312 | 18:53 |
*** srart has joined #openstack-ironic | 18:59 | |
*** derekh has joined #openstack-ironic | 19:04 | |
*** Goneri has quit IRC | 19:14 | |
*** mat128_ has joined #openstack-ironic | 19:19 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic master: Fix issue with double mocking of utils.execute functions https://review.openstack.org/524321 | 19:21 |
*** mat128 has quit IRC | 19:22 | |
*** dyasny has joined #openstack-ironic | 19:23 | |
*** adisky_ has quit IRC | 19:30 | |
*** serlex has joined #openstack-ironic | 19:33 | |
*** serlex has quit IRC | 19:33 | |
*** penick has quit IRC | 19:36 | |
NobodyCam | rloo: that is a awesome spec :) I left a question and comment. | 19:38 |
rloo | NobodyCam: thx! looking... | 19:38 |
*** jkilpatr has quit IRC | 19:39 | |
rloo | NobodyCam: good point about the timeout. i need to see what we did for cleaning. | 19:39 |
*** penick has joined #openstack-ironic | 19:39 | |
NobodyCam | :) | 19:40 |
rloo | NobodyCam: about a deploy_prepare state... I suppose that could be added in follow on work. i'm not quite sure where prepare starts & ends... and would it mean that we'd have a deploy_prepare_wait state too? I guess it depends on what 'prepare' means. | 19:40 |
NobodyCam | I was just thinking that might be a clean way to identify where in the deploy process things went sideways | 19:42 |
*** rwsu has quit IRC | 19:42 | |
NobodyCam | ie deploy breaks on deploy_prepare: I would;t have to trouble shoot the whole deploy process | 19:43 |
NobodyCam | I just right in to the prepare steps and see whats up | 19:43 |
NobodyCam | just = jump | 19:44 |
NobodyCam | was just a thought I had while reading and in way the reason for the -1 | 19:44 |
NobodyCam | in way == in NO way | 19:45 |
rloo | NobodyCam: so i think when/if we break up the existing deployment process into separate steps, that will help. it'll be clearer at which step a deployment failed. | 19:45 |
* NobodyCam needs more ☕️ | 19:45 | |
*** yangyapeng has joined #openstack-ironic | 19:45 | |
NobodyCam | :) | 19:45 |
rloo | NobodyCam: and i suspect there will be some 'prepare' or 'init', and some 'final' part of the deployment, i haven't actually looked at the code to see how to implement this :) | 19:46 |
*** crushil_ has joined #openstack-ironic | 19:46 | |
NobodyCam | :) | 19:46 |
rloo | NobodyCam: I am hoping it will be obvious once the coding starts, and I think I will be coding it. (volunteers are of course, welcome!) | 19:47 |
rloo | NobodyCam: i'll comment in the patch | 19:47 |
NobodyCam | :) +++ | 19:48 |
NobodyCam | I'll do my best to assist | 19:48 |
*** yangyapeng has quit IRC | 19:50 | |
*** akhilaki has quit IRC | 19:52 | |
*** AlexeyAbashkin has joined #openstack-ironic | 19:52 | |
*** rwsu has joined #openstack-ironic | 19:56 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: Fix issue with double mocking of utils.execute functions https://review.openstack.org/524329 | 19:57 |
*** AlexeyAbashkin has quit IRC | 19:59 | |
openstackgerrit | Merged openstack/ironic master: Add additional capabilities discovery for iRMC driver https://review.openstack.org/417347 | 20:00 |
openstackgerrit | Merged openstack/ironic master: Add information about neutron ML2 drivers to multitenancy docs https://review.openstack.org/523391 | 20:00 |
openstackgerrit | Merged openstack/ironic master: Updated from global requirements https://review.openstack.org/523729 | 20:00 |
*** crushil__ has joined #openstack-ironic | 20:00 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: Fix issue with double mocking of utils.execute functions https://review.openstack.org/524329 | 20:03 |
*** crushil_ has quit IRC | 20:04 | |
*** affie has joined #openstack-ironic | 20:05 | |
*** AlexeyAbashkin has joined #openstack-ironic | 20:12 | |
*** jtomasek has quit IRC | 20:13 | |
*** AlexeyAbashkin has quit IRC | 20:17 | |
*** rwsu has quit IRC | 20:19 | |
*** penick has quit IRC | 20:24 | |
*** Goneri has joined #openstack-ironic | 20:30 | |
*** penick has joined #openstack-ironic | 20:36 | |
*** e0ne has joined #openstack-ironic | 20:39 | |
*** mgoddard has quit IRC | 20:43 | |
*** penick has quit IRC | 20:47 | |
*** penick has joined #openstack-ironic | 20:47 | |
*** penick has quit IRC | 20:50 | |
*** derekh has quit IRC | 20:52 | |
*** pcaruana has quit IRC | 20:55 | |
*** penick has joined #openstack-ironic | 20:55 | |
*** e0ne has quit IRC | 20:58 | |
*** akhilaki has joined #openstack-ironic | 21:06 | |
*** bfournie has quit IRC | 21:07 | |
*** jkilpatr has joined #openstack-ironic | 21:09 | |
*** bfournie has joined #openstack-ironic | 21:10 | |
*** bfournie has quit IRC | 21:12 | |
*** threestrands has joined #openstack-ironic | 21:12 | |
*** ccamacho has quit IRC | 21:21 | |
*** pcaruana has joined #openstack-ironic | 21:24 | |
*** pcaruana has quit IRC | 21:39 | |
*** mat128_ has quit IRC | 21:39 | |
*** bfournie has joined #openstack-ironic | 21:51 | |
*** bfournie has quit IRC | 21:52 | |
*** affie has quit IRC | 21:54 | |
*** akhilaki has quit IRC | 22:01 | |
*** affie has joined #openstack-ironic | 22:02 | |
*** marlinc has quit IRC | 22:08 | |
*** priteau has quit IRC | 22:13 | |
*** rcernin has joined #openstack-ironic | 22:18 | |
*** rcernin has quit IRC | 22:21 | |
*** rcernin has joined #openstack-ironic | 22:21 | |
*** marlinc has joined #openstack-ironic | 22:22 | |
openstackgerrit | Merged openstack/ironic master: Fix HPE headers for oneview. https://review.openstack.org/523975 | 22:25 |
*** vsaienko has joined #openstack-ironic | 22:30 | |
*** mjturek has quit IRC | 22:31 | |
*** Goneri has quit IRC | 22:38 | |
*** dyasny has quit IRC | 22:47 | |
openstackgerrit | Ilya Etingof proposed openstack/ironic master: devstack to `git pull sushy-tools` if required https://review.openstack.org/524417 | 22:47 |
*** rbudden has quit IRC | 22:49 | |
*** affie has quit IRC | 22:52 | |
*** affie has joined #openstack-ironic | 22:53 | |
*** etingof has quit IRC | 22:53 | |
*** akhilaki has joined #openstack-ironic | 23:02 | |
*** akhilaki has quit IRC | 23:07 | |
*** AlexeyAbashkin has joined #openstack-ironic | 23:12 | |
*** dprince has quit IRC | 23:16 | |
*** AlexeyAbashkin has quit IRC | 23:16 | |
*** racedo_ has quit IRC | 23:19 | |
*** bnemec has quit IRC | 23:22 | |
*** athomas has quit IRC | 23:24 | |
*** penick_ has joined #openstack-ironic | 23:47 | |
*** penick has quit IRC | 23:49 | |
*** etingof has joined #openstack-ironic | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!