Thursday, 2018-01-04

openstackgerritIlya Etingof proposed openstack/sushy-tools master: documentation on simulators added  https://review.openstack.org/52344500:00
*** rpioso is now known as rpioso|afk00:02
*** etingof has quit IRC00:25
*** ijw has quit IRC00:50
openstackgerritVladyslav Drok proposed openstack/ironic master: [WIP] Refactor deploy interface methods  https://review.openstack.org/52443300:55
*** threestrands has joined #openstack-ironic01:55
openstackgerritKaifeng Wang proposed openstack/ironic-inspector master: Doc update: remove discoverd reference  https://review.openstack.org/53105102:04
*** sasha2 has quit IRC02:23
*** ijw has joined #openstack-ironic02:26
*** ijw has quit IRC02:30
openstackgerritKaifeng Wang proposed openstack/ironic-inspector master: Doc update: remove discoverd reference  https://review.openstack.org/53105102:38
*** namnh has joined #openstack-ironic02:47
openstackgerritDebayan Ray proposed openstack/sushy master: Update method docstring  https://review.openstack.org/53087203:04
*** ijw has joined #openstack-ironic03:14
*** pmannidi has joined #openstack-ironic03:35
*** pmannidi has quit IRC03:37
*** pmannidi has joined #openstack-ironic03:45
*** kiseok7 has quit IRC04:26
*** udesale has joined #openstack-ironic04:37
*** rbudden has quit IRC05:12
*** ijw has quit IRC05:13
openstackgerritMadhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic  https://review.openstack.org/47121705:45
openstackgerritMadhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic  https://review.openstack.org/47121705:47
*** bcornec has quit IRC06:34
*** hieulq has joined #openstack-ironic06:58
*** kiseok7 has joined #openstack-ironic06:59
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-ui master: Imported Translations from Zanata  https://review.openstack.org/53109507:10
*** threestrands has quit IRC07:25
*** jrist has quit IRC07:29
*** pcaruana has joined #openstack-ironic07:32
openstackgerritfupingxie proposed openstack/ironic master: Add a provisioning target:adopt  https://review.openstack.org/53109907:34
*** jaypipes has quit IRC07:53
*** rcernin has quit IRC08:04
*** dtantsur|afk is now known as dtantsur08:49
*** lucas-afk is now known as lucasagomes08:49
dtantsurmorning ironic! happy new year :)08:50
yongimanHappy new year too :)08:50
*** amarao has joined #openstack-ironic08:59
*** hjensas has joined #openstack-ironic08:59
*** e0ne has joined #openstack-ironic09:05
openstackgerritMadhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic  https://review.openstack.org/47121709:09
*** jrist has joined #openstack-ironic09:13
*** derekh has joined #openstack-ironic09:24
*** milan has joined #openstack-ironic09:26
*** mgoddard has joined #openstack-ironic09:26
milanmorning Ironic! :)09:27
*** phuongnh has joined #openstack-ironic09:46
*** fragatina has quit IRC09:49
openstackgerritDmitry Tantsur proposed openstack/ironic master: Rework exception handling on deploy failures in conductor  https://review.openstack.org/53112010:13
*** ijw has joined #openstack-ironic10:17
openstackgerritMerged openstack/sushy master: Update method docstring  https://review.openstack.org/53087210:17
*** MattMan_1 has quit IRC10:20
*** MattMan_1 has joined #openstack-ironic10:20
*** ijw has quit IRC10:21
openstackgerritlongfei.zhang proposed openstack/networking-generic-switch master: Fix test with OVS example failed case when exec ovs-vsctl add-port  https://review.openstack.org/53112110:25
*** namnh has quit IRC10:27
openstackgerritlongfei.zhang proposed openstack/networking-generic-switch master: Fix test with OVS example failed case when exec ovs-vsctl add-port  https://review.openstack.org/53112110:30
*** stendulker has joined #openstack-ironic10:31
*** phuongnh has quit IRC10:51
openstackgerritShivanand Tendulker proposed openstack/ironic master: Agent rescue implementation  https://review.openstack.org/40043711:13
*** stendulker has quit IRC11:25
-openstackstatus- NOTICE: zuul seems to have gotten stuck and will probably need a restart, please be patient11:27
*** openstackstatus has quit IRC11:28
*** openstack has quit IRC11:28
*** openstack has joined #openstack-ironic13:08
*** ChanServ sets mode: +o openstack13:08
*** openstackstatus has joined #openstack-ironic13:09
*** ChanServ sets mode: +v openstackstatus13:09
*** trown|outtypewww is now known as trown13:21
*** lucas-hungry is now known as lucasagomes13:32
*** tzumainn has joined #openstack-ironic13:41
*** dtantsur is now known as dtantsur|brb13:49
*** rpioso|afk is now known as rpioso13:54
rpiosoGood morning :)13:54
TheJuliagood morning everyone14:00
rpiosoTheJulia: Morning14:02
openstackgerritIlya Etingof proposed openstack/sushy-tools master: add dvsm CI job  https://review.openstack.org/52456014:16
*** dtantsur|brb is now known as dtantsur14:22
dtantsurmorning TheJulia, rpioso14:22
rpiosodtantsur: Happy 2018!14:23
dtantsur:)14:23
*** mrtenio has joined #openstack-ironic14:25
*** dansmith has quit IRC14:25
*** therve_ is now known as therve14:29
*** rbudden has joined #openstack-ironic14:37
dtantsurTheJulia: do you remember why we even have this get_client() indirection?14:40
TheJuliabecause we have a v1, and not yet a v214:41
TheJuliaand consistency :)14:41
* TheJulia wonders if we are thus professional indirection setters....14:41
*** yolanda has quit IRC14:45
*** baha has joined #openstack-ironic14:45
-openstackstatus- NOTICE: zuul has been restarted, all queues have been reset. please recheck your patches when appropriate14:47
dtantsurwell, I wonder why not just use ironicclient.v1.Client14:47
dtantsurand maybe ironicclient.v2.Client one day14:47
dtantsurbecause we anyway require an explicit major version supplied to get_client call14:47
TheJuliayeah, which is always "1" :(14:56
TheJuliait is a positional arg, we could change it to have a default value..... *looks around innocently*14:57
openstackgerritJohn L. Villalovos proposed openstack/ironic master: WIP/DNM: Test to get idea of 3rd Party CI status  https://review.openstack.org/53116715:04
TheJuliajlvillal: good morning!15:11
jlvillalTheJulia, Good morning :)15:11
* jlvillal still waking up15:11
dtantsurmorning jlvillal15:16
dtantsurTheJulia: heh, indeed15:16
jlvillal:)15:17
dtantsurjlvillal: note that ironic-inspector does not have 3rd party CI15:17
jlvillaldtantsur, Yeah, I realized that after I copy-pasted my recheck message :)15:18
NobodyCamGood Morning Ironic'ers15:18
dtantsurmorning NobodyCam15:18
jlvillaldtantsur, Hopefully we can remove the plugin code soon. I think a fair amount of 3rd Party CI is already broken with or without the plugin code...15:18
NobodyCam:) Morning dtantsur :)15:18
dtantsurtrue :(15:18
TheJuliaThey seemed to be in decent shape before the holidays... well... decent for 3rd party ci with the occasional sporadic failure15:23
openstackgerritDmitry Tantsur proposed openstack/ironic master: [WIP] Handle case when a glance image contains no data  https://review.openstack.org/53118015:48
openstackgerritIlya Etingof proposed openstack/ironic master: added redfish boot mode management  https://review.openstack.org/52831415:56
*** udesale has joined #openstack-ironic16:01
*** udesale has quit IRC16:14
*** mgoddard has quit IRC16:21
*** e0ne has quit IRC16:36
*** zshi has quit IRC16:38
*** dtantsur is now known as dtantsur|afk16:41
dtantsur|afko/16:41
*** rbudden has quit IRC16:44
*** ChanServ sets mode: -r 16:48
*** gcb has quit IRC16:49
*** gcb has joined #openstack-ironic16:50
*** pcaruana has quit IRC16:52
*** milan has quit IRC16:56
*** dsneddon has joined #openstack-ironic17:01
*** amarao has quit IRC17:07
rpiosojlvillal: FYI, rajinir is out this week. I believe she'll be back in on Monday.17:21
*** Nisha_Agarwal has joined #openstack-ironic17:24
*** rbudden has joined #openstack-ironic17:29
*** Nisha_ has joined #openstack-ironic17:32
*** Nisha_Agarwal has quit IRC17:32
*** Nisha_ has quit IRC17:33
*** Nisha_ has joined #openstack-ironic17:33
*** mgoddard has joined #openstack-ironic17:40
*** Nisha_Agarwal has joined #openstack-ironic17:42
*** Nisha_ has quit IRC17:42
jlvillalrpioso: Thanks. Looks like almost all of Dell CI is broken anyway. So I don't think we need to wait for them to update for tempest changes. But that is my opinion :)17:44
jlvillalBased on this run: https://review.openstack.org/53116717:45
patchbotpatch 531167 - ironic - WIP/DNM: Test to get idea of 3rd Party CI status17:45
*** lucasagomes is now known as lucas-afk17:46
*** Nisha_Agarwal has quit IRC17:51
jlvillalUhhh. Did something break the unit tests?  https://review.openstack.org/#/c/531167/17:56
patchbotpatch 531167 - ironic - WIP/DNM: Test to get idea of 3rd Party CI status17:56
jlvillalI also reproduced locally17:56
jlvillalTheJulia: dtantsur|afk vdrok jroll ^^17:57
*** racedo has quit IRC17:57
jrollhey, morning jlvillal17:58
jlvillalMorning jroll :)17:58
jrollhaven't noticed anything, but looking17:58
jrollinteresting17:59
jlvillalI wonder when that happened. Last time anything was merged was back on 27-18:00
jlvillalDec-201718:00
jrollO_o18:00
jrollI had a patch yesterday that passed unit tests fine, fwiw18:01
jlvillaljroll: Good data point.18:01
jrollah, it's only the acl middleware tests18:01
jrollwhich depend on keystonemiddleware18:02
jrollwhich.. https://github.com/openstack/requirements/commit/1790ffa06c1b47da2be1b1afee6481f8e6d21e62#diff-0bdd949ed8a7fdd4f95240bd951779c818:02
jlvillaljroll: Cool. You beat me to finding that :)18:03
*** derekh has quit IRC18:03
jroll:D18:05
jrollI still got it!18:05
jlvillaljroll: Maybe they changed the response codes from 403 to 503 or vice-versa18:05
*** Goneri has joined #openstack-ironic18:05
jrolljlvillal: suspect something is throwing an exception in keystonemiddleware and coming back to the tests as an error18:05
jrollyou could also be right though18:06
* jroll is in a meeting so can't put his full brain on this, but is poking around18:07
jlvillaljroll: I'm asking in keystone channel if there is a, "After update you should change X" thingy18:07
jrollhopefully something like that isn't intentional in a minor release :)18:07
jlvillalhopefully...18:09
jlvillaljroll: Didn't seem to break any of the DSVM jobs. But then again they don't really exercise the failure paths like the unit tests do18:09
jrollright, this is only the negative acl tests, which tempest doesn't do afaik18:10
jrollhttps://github.com/openstack/ironic/blob/5603a215b726ca465eed2867d830821bb24b1a72/ironic/tests/unit/api/test_acl.py#L51-L5218:17
jrollhttps://github.com/openstack/keystonemiddleware/compare/4.18.0...4.20.018:17
jrollspecifically https://github.com/openstack/keystonemiddleware/commit/9d8e2836fe7fca186e0380d8a532540ff5cc521518:18
jrollsuspect these are related, but unsure18:19
jlvillaljroll: Verified that it is keystonemiddleware 4.20.0. As running with 4.18.0 it works18:20
* jroll might play with it18:20
jlvillaljroll: lbragstad is helping out in keystone channel now18:20
jrolloh cool18:20
jrollthanks18:20
jlvillaljroll: I can copy those links over there18:21
jrollgo for it18:21
* jroll just joined to listen18:21
*** lbragstad has joined #openstack-ironic18:32
jrolljlvillal: so fyi it isn't as easy as just making this dogpule compatible:     ValueError: Valid values are [oslo_cache.memcache_pool, oslo_cache.dict, oslo_cache.mongo, oslo_cache.etcd3gw, dogpile.cache.memcached, dogpile.cache.pylibmc, dogpile.cache.bmemcached, dogpile.cache.dbm, dogpile.cache.redis, dogpile.cache.memory, dogpile.cache.memory_pickle, dogpile.cache.null], but found 'fake.cache'18:48
*** jlabarre has joined #openstack-ironic18:53
*** ijw has joined #openstack-ironic18:55
*** amarao has joined #openstack-ironic18:56
*** Goneri has quit IRC19:00
jlvillaljroll: Oh and :(19:01
jlvillaljroll: Sorry I had something come up here. I can try to take a look when I get back from lunch. 90+ minutes from now. Depending on when I can leave for lunch :)19:02
jrolljlvillal: no worries, I'm sure your office is a mess today :P19:02
jlvillaljroll: No comment ;)19:03
jrollI'll be looking shortly as well19:03
*** amarao has quit IRC19:05
*** amarao has joined #openstack-ironic19:12
rpiosojlvillal: You're welcome. If memory serves, before the holidays, she and Arkady Kanevsky asked that the tempest changes wait until Dell CI could accommodate them. Does that sound familiar?19:16
jlvillalrpioso: Sounds familiar and asked for a three week delay.19:16
rpiosojlvillal: Is the time up or ...?19:17
jlvillalrpioso: Three weeks is about up. And the CI already seems broken right now. Before the proposed changes have landed.19:17
jlvillalrpioso: Since the Dell CI is already broken. I don't see any reason to delay for Dell CI on moving forward. Do you?19:18
rpiosojlvillal: Could it wait until rajinir can be consulted? She should be back on Monday.19:18
jlvillalrpioso: I am proposing to remove the tempest plugin in the Monday meeting.19:19
rpiosojlvillal: Sounds good. I'll try to ensure rajinir is aware of that. Thank you for your patience.19:20
jlvillalrpioso: You're welcome19:21
*** baha has quit IRC19:22
rpiosojroll: Since you still have it, do you understand why the ilo driver management interface's update_boot_mode() does not update the node instance_info's deploy_boot_mode when the capabilities within the properties of the node contain boot_mode? Please see lines 486-501 in https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/common.py19:38
jrollrpioso: no, sorry, I wouldn't know19:41
rpiosojroll: No worries. I figured it was worth a try :)19:42
rpiosojroll: I'll try stendulker.19:44
jrollyep, he should know :)19:45
*** mgoddard has quit IRC19:45
rpiosoI'm adding UEFI support to the drac driver. I'm thinking that it should be broken up into a number of commits as advised by the discussion of "Sending large new features in a single giant commit." on https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes19:58
rpiosoThere'll be about 5 commits, +/-.19:58
rpiosoIs it preferred that all of them be completed before any are submitted for review? Or may they be submitted individually over a stretch of time, as one-by-one they're done?20:01
rpiosoPerhaps some critical mass of code should be completed before any are uploaded to Gerrit?20:03
*** Goneri has joined #openstack-ironic20:07
jrollrpioso: work in progress code is always welcome on gerrit, mark it workflow -1 if you don't think it's ready to be reviewed yet20:17
jrollwe generally don't have a problem with landing the earlier commits before the later ones are done20:17
rpiosojroll: Cool! Thank you.20:18
jrollyep, no problem :)20:18
jrollrpioso: it might be worth putting a general plan in the RFE, just so reviewers can tell that the earlier code is heading in the right direction20:19
rpiosojroll: That makes sense. Thanks for that pointer, too :)20:20
* rpioso needs to create that RFE20:20
jrollsure thing!20:20
*** amarao has quit IRC20:24
*** mgoddard has joined #openstack-ironic20:28
jrolljlvillal: I'm a bit stuck on this. feels like we should be mocking something instead of injecting our own cache, but either way I'm having trouble finding a clean way to access the middleware from those tests :/20:49
*** mgoddard has quit IRC21:05
*** fragatina has joined #openstack-ironic21:11
jlvillaljroll: Hey. Just got back from lunch.21:17
jlvillaljroll: I can take a look now, though I imagine you are further along then me. Going to go re-read the log from the keystone channel21:18
jrolljlvillal: I didn't really get anywhere21:18
jlvillaljroll: Okay. I'll start looking. I think I have some free time now :)21:19
jrolljlvillal: cool, thank you21:19
*** mdorman has joined #openstack-ironic21:19
jlvillaljroll: And thanks to you too21:20
mdormani keep getting 401s back from swift on validating the tempurl image source on hardware provisioning.  i've verified the secret set on the swift account matches swift_temp_url_key in ironic.conf.  i am at a loss here.  is there something else i need to do on the swift side to turn that on?21:25
mdormani can confirm it's actually not working in swift, b/c i get a 401 when just curling the url as well.21:25
jrollmdorman: is the clock accurate in the agent image?21:25
jrollor in the ironic box, maybe21:26
mdormanrunning via kolla-ansible, so everything is in docker across two machines.  timestamps on each are within a second or two.21:27
*** fragatina has quit IRC21:27
jrollhm, that's the one thing I remember having issues with, offhand21:27
jrollthere's no action to take on the swift side, though21:28
mdormankk.  yeah just thought i'd check here in case there's something obvious i'm missing21:28
*** baha has joined #openstack-ironic21:29
jrollmdorman: just to be sure, you set the temp url key for the same user that glance uses to store images in swift, right?21:30
mdormanjroll: yeah it's set on the account which has the glance contaier21:31
mdorman*container21:31
jrollokay21:32
jrollthe one other thing... there's a way for glance to shard across many containers21:32
jrollI assume that isn't in play here?21:32
jrollif so, there's an ironic setting to match that21:32
mdormani don't think so.  i only have two glance images at this point and i can see the objects for each in the single glance container21:32
jrollok21:33
jrollvery strange then21:33
mdormanis there a glance command to create temp urls?  i should probably figure out how to reproduce it manually21:34
jrollI think there's a swift command, yeah21:34
jrollswift tempurl <method> <seconds> <path> <key>21:35
mdormanah, kk21:35
jrollor in python: https://docs.openstack.org/swift/latest/api/temporary_url_middleware.html21:35
*** threestrands has joined #openstack-ironic21:35
*** threestrands has quit IRC21:35
*** threestrands has joined #openstack-ironic21:35
mdormanprobably should've just googled that myself.  thanks jroll !21:37
jrollno problem :)21:38
jrollgood luck21:38
*** jcoufal has quit IRC21:40
*** dmellado has quit IRC21:43
*** dmellado has joined #openstack-ironic21:46
*** rcernin has joined #openstack-ironic22:12
*** Goneri has quit IRC22:21
*** jistr has quit IRC22:29
*** rbudden has quit IRC22:34
*** rbudden has joined #openstack-ironic22:59
*** gutter has joined #openstack-ironic23:06
*** ijw has quit IRC23:10
*** gutter has quit IRC23:14
*** ijw has joined #openstack-ironic23:15
*** jistr has joined #openstack-ironic23:19
jlvillaljroll: TheJulia dtantsur|afk vdrok: I updated the whiteboard that the unit tests are broken. And that I don't know yet how to fix it :(23:26
TheJuliaThanks :(23:26
TheJuliaI'm sure I'll see it once I wrap up the patch I'm working on and update my reqs23:26
jlvillalTheJulia: Unfortunately yes, you should see the error23:27
*** mtreinish has quit IRC23:39
*** mtreinish has joined #openstack-ironic23:42
*** jlabarre has quit IRC23:43
*** jistr has quit IRC23:54
*** jistr has joined #openstack-ironic23:55
*** mdorman has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!