*** r-daneel has quit IRC | 00:05 | |
openstackgerrit | Merged openstack/sushy-tools master: Updated from global requirements https://review.openstack.org/531744 | 00:10 |
---|---|---|
openstackgerrit | fupingxie proposed openstack/ironic master: Add more parameter explanation when create a node https://review.openstack.org/531941 | 00:43 |
*** tuanla____ has joined #openstack-ironic | 00:46 | |
openstackgerrit | Merged openstack/ironic master: Devstack: install qemu-system-x86 on RHEL https://review.openstack.org/530994 | 00:56 |
*** rloo has quit IRC | 00:58 | |
openstackgerrit | Merged openstack/ironic-tempest-plugin master: Update README and setup.cfg, initial version of usage guide https://review.openstack.org/529538 | 01:08 |
*** phuongnh has joined #openstack-ironic | 01:11 | |
*** tzumainn has quit IRC | 01:17 | |
*** phuongnh has quit IRC | 01:24 | |
*** phuongnh has joined #openstack-ironic | 01:25 | |
*** charcol has joined #openstack-ironic | 01:25 | |
*** zhangfei has joined #openstack-ironic | 01:43 | |
openstackgerrit | lei zhang proposed openstack/ironic master: Fix the incorrect git.openstack.org source URL https://review.openstack.org/531952 | 01:58 |
*** zhangfei has quit IRC | 02:00 | |
openstackgerrit | fupingxie proposed openstack/ironic master: Add more parameter explanation when create a node https://review.openstack.org/531941 | 02:01 |
*** zhangfei has joined #openstack-ironic | 02:13 | |
*** namnh has joined #openstack-ironic | 02:17 | |
*** hshiina has joined #openstack-ironic | 02:18 | |
*** etingof has quit IRC | 02:26 | |
*** etingof has joined #openstack-ironic | 02:27 | |
*** harlowja has quit IRC | 02:32 | |
*** pas-ha has quit IRC | 02:37 | |
*** pas-ha has joined #openstack-ironic | 02:37 | |
*** udesale has joined #openstack-ironic | 02:46 | |
openstackgerrit | fupingxie proposed openstack/ironic master: Add more parameter explanation when create a node https://review.openstack.org/531941 | 02:57 |
*** sasha2 has quit IRC | 03:03 | |
openstackgerrit | lei zhang proposed openstack/bifrost master: Fix the incorrect git.openstack.org source URL https://review.openstack.org/531988 | 03:04 |
*** adreznec has quit IRC | 03:07 | |
*** adreznec has joined #openstack-ironic | 03:08 | |
*** hoonetorg has quit IRC | 03:12 | |
*** adreznec has quit IRC | 03:16 | |
openstackgerrit | fupingxie proposed openstack/ironic master: Add more parameter explanation when create a node https://review.openstack.org/531941 | 03:19 |
*** adreznec has joined #openstack-ironic | 03:21 | |
*** ijw has quit IRC | 03:21 | |
*** hoonetorg has joined #openstack-ironic | 03:25 | |
openstackgerrit | zenghui.shi proposed openstack/ironic-specs master: Hardware interface for BIOS configuration https://review.openstack.org/496481 | 04:14 |
*** rbudden has quit IRC | 04:15 | |
openstackgerrit | fupingxie proposed openstack/ironic master: Add more parameter explanation when create a node https://review.openstack.org/531941 | 04:19 |
*** yangyapeng has quit IRC | 04:31 | |
*** yangyapeng has joined #openstack-ironic | 04:31 | |
*** pmannidi has quit IRC | 04:44 | |
*** dpawar has joined #openstack-ironic | 05:03 | |
*** links has joined #openstack-ironic | 05:07 | |
*** ijw has joined #openstack-ironic | 05:19 | |
*** arnewiebalck_ has quit IRC | 05:24 | |
mkrai | Hi, Can anyone please help review https://review.openstack.org/#/c/306078/ ? | 05:42 |
patchbot | patch 306078 - ironic-specs - External display drivers | 05:42 |
mkrai | Thank you in advance | 05:42 |
*** hoonetorg has quit IRC | 05:55 | |
*** ccollett has joined #openstack-ironic | 05:59 | |
*** hoonetorg has joined #openstack-ironic | 05:59 | |
*** tuanla____ has quit IRC | 06:00 | |
*** charcol has quit IRC | 06:01 | |
*** tuanla____ has joined #openstack-ironic | 06:05 | |
*** tuanla____ has quit IRC | 06:09 | |
openstackgerrit | Merged openstack/ironic master: Adds rescue_interface to base driver class https://review.openstack.org/509335 | 06:11 |
*** jaganathan has joined #openstack-ironic | 06:12 | |
*** marios has joined #openstack-ironic | 06:18 | |
*** pmannidi has joined #openstack-ironic | 06:18 | |
*** etingof has quit IRC | 06:18 | |
*** etingof has joined #openstack-ironic | 06:21 | |
openstackgerrit | Zachary Ma proposed openstack/ironic master: add warning log about empty pxe_enabled_ports https://review.openstack.org/531320 | 06:34 |
*** links has quit IRC | 06:35 | |
*** rcernin has quit IRC | 06:38 | |
openstackgerrit | Zachary Ma proposed openstack/ironic master: remove unused code in TestNeutronNetworkActions https://review.openstack.org/532024 | 06:46 |
*** ameeda has joined #openstack-ironic | 06:47 | |
ameeda | Hello | 06:47 |
ameeda | I have problem with ironic | 06:47 |
ameeda | when I execute this command "openstack baremetal node show <UUID>" I got this "Failed to change power state to 'power on' by 'rebooting'. Error: IPMI call failed: power status" | 06:47 |
ameeda | so when I try to manage the node. the status changed to verifying then back to enroll state | 06:48 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add documentation for rescue interface https://review.openstack.org/419606 | 06:49 |
openstackgerrit | Zachary Ma proposed openstack/ironic master: remove unused code in TestNeutronNetworkActions https://review.openstack.org/532024 | 06:49 |
*** links has joined #openstack-ironic | 06:52 | |
openstackgerrit | Zachary Ma proposed openstack/ironic master: remove unused code in TestNeutronNetworkActions https://review.openstack.org/532024 | 06:52 |
*** hoonetorg has quit IRC | 06:56 | |
*** pcaruana has joined #openstack-ironic | 06:56 | |
*** mjura has joined #openstack-ironic | 06:57 | |
*** stendulker has joined #openstack-ironic | 06:57 | |
*** gcb has joined #openstack-ironic | 06:58 | |
*** links has quit IRC | 07:03 | |
*** hoonetorg has joined #openstack-ironic | 07:12 | |
*** links has joined #openstack-ironic | 07:14 | |
ameeda | I found an error in "ironic-conductor.log" said "Error: Unable to establish IPMI v2 / RMCP+ session\n': ProcessExecutionError: Unexpected error while running command" | 07:19 |
*** jtomasek has joined #openstack-ironic | 07:27 | |
*** links has quit IRC | 07:27 | |
*** ccollett has quit IRC | 07:29 | |
*** hoonetorg has quit IRC | 07:32 | |
*** pmannidi has quit IRC | 07:34 | |
*** ricardoas1 has joined #openstack-ironic | 07:37 | |
*** ricardoas has quit IRC | 07:37 | |
openstackgerrit | lei zhang proposed openstack/ironic-ui master: Fix the incorrect git.openstack.org source URL https://review.openstack.org/532038 | 07:37 |
*** makowals has joined #openstack-ironic | 07:39 | |
*** vsaienk0 has joined #openstack-ironic | 07:42 | |
*** e0ne has joined #openstack-ironic | 07:44 | |
*** links has joined #openstack-ironic | 07:45 | |
*** udesale has quit IRC | 07:46 | |
*** d0ugal has joined #openstack-ironic | 07:51 | |
*** AlexeyAbashkin has joined #openstack-ironic | 07:56 | |
ameeda | anyone help me please | 07:59 |
*** hoonetorg has joined #openstack-ironic | 08:01 | |
*** rbartal has joined #openstack-ironic | 08:08 | |
openstackgerrit | lei zhang proposed openstack/networking-baremetal master: Fix the incorrect git.openstack.org source URL https://review.openstack.org/532056 | 08:09 |
*** amarao has joined #openstack-ironic | 08:13 | |
*** tesseract has joined #openstack-ironic | 08:20 | |
openstackgerrit | vinay kumar muddu proposed openstack/ironic master: [WIP} Fixes issue with UEFI bootable ISO creation https://review.openstack.org/531700 | 08:26 |
*** namnh has quit IRC | 08:38 | |
*** hieulq has quit IRC | 08:38 | |
*** phuongnh has quit IRC | 08:38 | |
*** phuongnh has joined #openstack-ironic | 08:38 | |
*** namnh has joined #openstack-ironic | 08:38 | |
*** hieulq has joined #openstack-ironic | 08:38 | |
*** etingof has quit IRC | 08:48 | |
*** hshiina has quit IRC | 08:49 | |
*** racedo has joined #openstack-ironic | 08:49 | |
*** priteau has joined #openstack-ironic | 08:56 | |
openstackgerrit | lei zhang proposed openstack/python-ironicclient master: Fix the incorrect git.openstack.org source URL https://review.openstack.org/532101 | 09:12 |
*** lucas-afk is now known as lucasagomes | 09:18 | |
*** dtantsur|afk is now known as dtantsur | 09:20 | |
dtantsur | morning ironic | 09:21 |
dtantsur | ameeda: hi, mostly likely wrong IPMI credentials or problems with the BMC | 09:22 |
hjensas | morning dtantsur | 09:24 |
dtantsur | o/ | 09:24 |
*** etingof has joined #openstack-ironic | 09:26 | |
pas-ha | morning ironic :) | 09:27 |
ameeda | dtantsur: Morning, I am sure about the credentials , what about the BMC, is that from server ? | 09:29 |
dtantsur | ameeda: yes. the thing that talks IPMI | 09:30 |
dtantsur | it can be iLO, iDrac, etc | 09:30 |
ameeda | the server not mine, but I can access ilo using browser | 09:31 |
*** hoonetorg has quit IRC | 09:32 | |
dtantsur | ameeda: check that IPMI is enabled in it | 09:32 |
ameeda | yes its enabled and the port is 623 | 09:33 |
*** derekh has joined #openstack-ironic | 09:33 | |
*** jistr|off|mtg is now known as jistr | 09:36 | |
*** milan has joined #openstack-ironic | 09:44 | |
ameeda | dtantsur: what you guess me to solve the issue ? | 09:44 |
*** tuanla____ has joined #openstack-ironic | 09:44 | |
dtantsur | ameeda: try replicating the failed IPMI line locally, it may help figuring out what goes wrong. | 09:44 |
ameeda | dtantsur: I tried "ipmitool -I lanplus -H <IP> -L ADMINISTRATOR -U <user> -R 12 -N 5 -P <password> power status" and got the same error | 09:47 |
dtantsur | ameeda: then the problem is indeed on the hardware side. also check that the user actually has ADMINISTRATOR privileges. if nothing helps, you may want to contact the vendor for help. | 09:48 |
*** hoonetorg has joined #openstack-ironic | 09:49 | |
ameeda | dtantsur: yes the user has ADMINISTRATOR privileges, I will contact server owner. Thanks for help :) have a great day | 09:49 |
dtantsur | you too :) | 09:50 |
*** udesale has joined #openstack-ironic | 09:59 | |
openstackgerrit | longfei.zhang proposed openstack/networking-generic-switch master: Fix test with OVS example failed case when exec ovs-vsctl add-port https://review.openstack.org/531121 | 10:01 |
ameeda | dtantsur: the version of impi on server is 1.5 and the error message said that Unable to establish IPMI v2 , is that cause the issue ? | 10:02 |
dtantsur | ameeda: likely. is it possible to upgrade ipmi version on the server? | 10:07 |
ameeda | dtantsur: I am not sure, as I said the server isn't mine, so we can't change ipmi on openstack locally ? | 10:09 |
*** tuanla____ has quit IRC | 10:10 | |
sambetts|afk | ameeda: I think you need to set an optional parameter on your Ironic node to make ironic aware which IPMI version the server has | 10:16 |
*** sambetts|afk is now known as sambetts | 10:16 | |
sambetts | ameeda: by default Ironic assumes v2.0, but you can set driver_info/ipmi_protocol_version=1.5 and Ironic will adjust the protocol version it uses to talk to the server | 10:17 |
*** d0ugal has quit IRC | 10:19 | |
*** d0ugal has joined #openstack-ironic | 10:21 | |
*** MattMan_1 has quit IRC | 10:23 | |
*** MattMan_1 has joined #openstack-ironic | 10:24 | |
johnthetubaguy | dtantsur: was catching up with mgoddard, time is catch up with me, but will try move things forward today | 10:27 |
ameeda | dtantsur: ironic node-update add <UUID or name> driver_info/ipmi_protocol_version=<version> not working anymore, and openstack baremetal it seems that doesn't has this option | 10:27 |
sambetts | ameeda: in openstack baremetal the option is "openstack baremetal node set .... " https://docs.openstack.org/python-ironicclient/latest/cli/osc/v1/index.html#baremetal-node-set | 10:29 |
ameeda | sambetts: thanks | 10:30 |
ricardoas1 | morning, ironic! | 10:33 |
*** ricardoas1 is now known as ricardoas | 10:33 | |
ameeda | dtantsur: unfortunately that not work, I will contact the server owner. Thanks!! | 10:40 |
*** priteau has quit IRC | 10:43 | |
*** priteau has joined #openstack-ironic | 10:44 | |
*** vsaienk0 has quit IRC | 10:45 | |
*** hoonetorg has quit IRC | 10:46 | |
*** hoonetorg has joined #openstack-ironic | 10:47 | |
*** priteau has quit IRC | 10:48 | |
*** namnh has quit IRC | 10:48 | |
*** zhangfei has quit IRC | 10:49 | |
*** vsaienk0 has joined #openstack-ironic | 10:57 | |
*** AlexeyAbashkin has quit IRC | 11:02 | |
*** AlexeyAbashkin has joined #openstack-ironic | 11:02 | |
*** hoonetorg has quit IRC | 11:04 | |
*** priteau has joined #openstack-ironic | 11:11 | |
*** stendulker has quit IRC | 11:15 | |
*** priteau has quit IRC | 11:15 | |
dtantsur | pas-ha, vsaienk0, hey, do you plan on splitting the tempest plugin out of n-g-s? | 11:19 |
*** tuanla____ has joined #openstack-ironic | 11:20 | |
vsaienk0 | dtantsur: since it is official project we should... I will take care about it | 11:21 |
*** udesale has quit IRC | 11:24 | |
dtantsur | thanks! the way it's done now is also a bit problematic for packaging | 11:25 |
dtantsur | (global tempest_plugin package not installed by setup.py) | 11:26 |
dtantsur | also FYI: https://review.rdoproject.org/r/#/c/11242/ | 11:28 |
*** udesale has joined #openstack-ironic | 11:36 | |
*** priteau has joined #openstack-ironic | 11:38 | |
*** udesale has quit IRC | 11:39 | |
*** udesale has joined #openstack-ironic | 11:39 | |
*** dpawar has quit IRC | 11:58 | |
*** vsaienk0 has quit IRC | 12:03 | |
*** tuanla____ has quit IRC | 12:04 | |
openstackgerrit | Merged openstack/ironic-inspector master: Centralize config options https://review.openstack.org/515786 | 12:07 |
*** ijw has quit IRC | 12:08 | |
*** dpawar has joined #openstack-ironic | 12:16 | |
*** jaganathan has quit IRC | 12:18 | |
*** jkilpatr has quit IRC | 12:18 | |
*** vsaienk0 has joined #openstack-ironic | 12:27 | |
*** rbartal has quit IRC | 12:29 | |
*** bfournie has quit IRC | 12:32 | |
*** bfournie has joined #openstack-ironic | 12:32 | |
*** rbartal has joined #openstack-ironic | 12:32 | |
*** lucasagomes is now known as lucas-hungry | 12:33 | |
*** hoonetorg has joined #openstack-ironic | 12:34 | |
*** bfournie has quit IRC | 12:37 | |
*** ijw has joined #openstack-ironic | 12:40 | |
*** jkilpatr has joined #openstack-ironic | 12:54 | |
*** zhurong_ has joined #openstack-ironic | 12:56 | |
*** makowals has quit IRC | 13:00 | |
*** makowals has joined #openstack-ironic | 13:01 | |
*** hoonetorg has quit IRC | 13:03 | |
*** trown|outtypewww is now known as trown | 13:04 | |
*** udesale has quit IRC | 13:06 | |
*** zhurong_ has quit IRC | 13:07 | |
*** udesale has joined #openstack-ironic | 13:08 | |
*** jlabarre has joined #openstack-ironic | 13:09 | |
*** bfournie has joined #openstack-ironic | 13:19 | |
openstackgerrit | Merged openstack/networking-generic-switch master: Add physical network awareness https://review.openstack.org/524178 | 13:21 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs master: Amend future of classic drivers with automated migration https://review.openstack.org/528308 | 13:25 |
*** yangyapeng has quit IRC | 13:27 | |
*** tzumainn has joined #openstack-ironic | 13:30 | |
*** lucas-hungry is now known as lucasagomes | 13:31 | |
*** jaganathan has joined #openstack-ironic | 13:36 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Switch non-vendor parts admin guide to hardware types https://review.openstack.org/528337 | 13:44 |
*** mjturek has joined #openstack-ironic | 13:46 | |
jroll | johnthetubaguy: I'm happy to help with the ironic side if your time (or more likely sleep) is short | 13:46 |
jroll | morning everyone | 13:46 |
sambetts | o/ jroll | 13:47 |
*** phuongnh has quit IRC | 13:47 | |
*** dprince has joined #openstack-ironic | 13:48 | |
*** crushil has joined #openstack-ironic | 13:49 | |
TheJulia | good morning | 13:49 |
johnthetubaguy | jroll: help would be good, I am getting onto things today, was at a conference yesterday | 13:50 |
johnthetubaguy | jroll: not totally sure on the best split right now, maybe catch up in a few hours to see what shape we are in? | 13:50 |
jroll | johnthetubaguy: sure, I'll be around all day | 13:50 |
jroll | dbapi patch looks good already | 13:51 |
*** AlexeyAbashkin has quit IRC | 13:52 | |
johnthetubaguy | jroll: sweet, will let you know how I get on | 13:53 |
jroll | sounds good :) | 13:53 |
*** yangyapeng has joined #openstack-ironic | 13:54 | |
*** stendulker has joined #openstack-ironic | 13:55 | |
dtantsur | morning jroll, TheJulia, johnthetubaguy | 13:55 |
*** sasha2 has joined #openstack-ironic | 13:59 | |
*** AlexeyAbashkin has joined #openstack-ironic | 14:00 | |
mjturek | hey TheJulia yesterday you mentioned that you were seeing IPA jobs hit a timeout. I'm debugging the IPA lshw patch CI failures and saw this "/home/ubuntu/devstack-gate/functions.sh: line 976: 25736 Killed timeout -s 9 ${REMAINING_TIME}m bash -c "source $WORKSPACE/devstack-gate/functions.sh && $cmd" Is it related to what you were talking about? | 14:01 |
TheJulia | stendulker: mjturek timeouts downloading tinyipa | 14:01 |
TheJulia | err | 14:01 |
mjturek | ahhh nvm then! | 14:01 |
openstackgerrit | John Garbutt proposed openstack/ironic master: Join nodes with traits https://review.openstack.org/530723 | 14:03 |
*** rloo has joined #openstack-ironic | 14:04 | |
*** cdearborn has joined #openstack-ironic | 14:05 | |
stendulker | Good Morning Ironic, TheJulia, mjturek, dtantsur, jroll, johnthetubaguy | 14:06 |
mjturek | gm! | 14:06 |
TheJulia | stendulker: Sorry for waking you :( | 14:06 |
dtantsur | morning stendulker, mjturek | 14:06 |
TheJulia | stendulker: I am curious if you know when we should expect proliantutils to be released | 14:06 |
stendulker | TheJulia: No problem :) | 14:06 |
stendulker | TheJulia: Sometime by next week. | 14:06 |
TheJulia | stendulker: do you know if we need to get a sushy release cut prior? | 14:08 |
stendulker | TheJulia: Oh, yes. Good you reminded me. | 14:08 |
stendulker | We need that as proliantutils uses sushy | 14:08 |
stendulker | We need to use new updated refresh() method from ResourceBase | 14:10 |
*** Goneri has joined #openstack-ironic | 14:14 | |
TheJulia | stendulker: looks like only the doc update is going to be able to land quickly since many of the patches are in merge conflict | 14:17 |
stendulker | TheJulia: Ok | 14:18 |
*** jroll has quit IRC | 14:19 | |
*** jroll has joined #openstack-ironic | 14:19 | |
*** hjensas has quit IRC | 14:19 | |
*** dpawar has quit IRC | 14:20 | |
stendulker | TheJulia: By schedule I think we need to make proliantutils release before Jan 26.. | 14:20 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Clean up release notes before a release https://review.openstack.org/532193 | 14:21 |
dtantsur | TheJulia, rloo, I know you like these things ^^^ :D | 14:21 |
rloo | dtantsur: i knew there was a reason why i disliked releases... | 14:21 |
dtantsur | haha, morning rloo :) | 14:21 |
rloo | morning stendulker, mjturek, dtantsur, TheJulia and everyone else! | 14:21 |
TheJulia | stendulker: jan 15-19th is non-client library freeze | 14:21 |
*** makowals has quit IRC | 14:21 | |
stendulker | Good morning rloo :) | 14:22 |
stendulker | TheJulia: Correct. Jan 19th. | 14:22 |
*** makowals has joined #openstack-ironic | 14:22 | |
*** rbudden has joined #openstack-ironic | 14:24 | |
*** rloo has quit IRC | 14:25 | |
*** rloo has joined #openstack-ironic | 14:26 | |
TheJulia | stendulker: Do you think Debayan Ray would be willing to generate a follow-up patch for the redfish sessions work since they have been fairly actively reviewing it? | 14:29 |
*** makowals has quit IRC | 14:29 | |
stendulker | TheJulia: I will check with him. | 14:30 |
TheJulia | stendulker: Thanks! | 14:30 |
dtantsur | stendulker: related, can we get someone's attention to https://review.openstack.org/519967 please? | 14:30 |
patchbot | patch 519967 - proliantutils - Retry power on operation for Blade servers | 14:30 |
dtantsur | this is a serious issue for us, affecting several customers | 14:31 |
stendulker | dtantsur: That's getting tested internally and will get released shortly in coming proliantutils library. | 14:31 |
dtantsur | stendulker: nice, thanks a lot | 14:32 |
stendulker | dtantsur: Would youtr customer wait till then? Or would want an intermittent release? | 14:32 |
stendulker | We are planning release before 19th Jan. | 14:32 |
dtantsur | stendulker: as soon as you merge it into master, we can provide it internally | 14:32 |
dtantsur | I just don't want to apply a patch downstream that is not accepted upstream | 14:33 |
stendulker | dtantsur: ok. Also big thanks to you for getting the fix validated with customer | 14:33 |
dtantsur | that's not thanks to me really :) thanks for working on it | 14:33 |
stendulker | dtantsur: It was kind of difficult issue for us to reproduce and also to test it out. | 14:34 |
*** makowals has joined #openstack-ironic | 14:34 | |
dtantsur | yeah, these things are always tricky | 14:34 |
stendulker | Its a race condition amongst multipe f/w components | 14:34 |
*** hjensas has joined #openstack-ironic | 14:37 | |
*** hjensas has quit IRC | 14:37 | |
*** hjensas has joined #openstack-ironic | 14:37 | |
rloo | dtantsur: we have an inconsistency wrt configuration option naming in our release notes, do you care? The '/': eg [DEFAULT]enabled_deploy_interfaces vs [ansible]/playbooks_path. | 14:38 |
dtantsur | rloo: I don't care too much, to be honest.. | 14:38 |
dtantsur | I don't really feel like leaving "-1 please remove (add) slash" on reviews :) | 14:39 |
stendulker | rloo: If you have few mins, wanted to discuss a comment in rescue interface related to DELETE_ALLOWED_STATES | 14:39 |
stendulker | https://review.openstack.org/#/c/509336/23/ironic/common/states.py@217 | 14:39 |
patchbot | patch 509336 - ironic - Adds RPC calls for rescue interface | 14:39 |
rloo | dtantsur: well, going forward, we should agree so folks know. we've used '/' in the past. | 14:39 |
rloo | stendulker: give me 10 min to finish up what i'm doing and refresh myself about that patch | 14:40 |
dtantsur | rloo: to me / looks redundant, since we already have []. but I don't really care. | 14:40 |
dtantsur | I suspect I may be the only one using [this]style | 14:40 |
stendulker | rloo: Sure. Thanks | 14:40 |
rloo | dtantsur: i think it is correct w/o the '/' but folks have been using '/' | 14:40 |
rloo | dtantsur: i've only been trying to keep it consistent within a doc. anyway, can ignore for now. | 14:40 |
*** cdearborn_ has joined #openstack-ironic | 14:43 | |
TheJulia | rloo: stendulker: fwiw, I'm kind of against adding more states where an api user is allowed to delete the node from the db since so many people think that is their only avenue to correct issues, as opposed to move the node through the state machine. | 14:45 |
TheJulia | dtantsur: your not alone in the / looks redundant camp :) | 14:45 |
dtantsur | cool :) | 14:45 |
stendulker | TheJulia: Yes. I think we should not as these rescue states needs to perform cleaning before removing node from Ironic | 14:46 |
*** mjturek has quit IRC | 14:47 | |
stendulker | The patch allows regular tear_down() in these rescue states. | 14:47 |
TheJulia | Well, cleaning before removal doesn't matter as much since uppon being re-created and moved through the state machine (at least if the microversion is >1.9), then they will go through cleaning to re-add. | 14:48 |
stendulker | I mean user would have to move the node in one of the DELETE_ALLOWED_STATE through API | 14:49 |
TheJulia | regular tear_down is fine since it is undeploy | 14:50 |
*** mjturek has joined #openstack-ironic | 14:50 | |
stendulker | The spec have used 'delete node' and 'delete instance' interchageably. I'm thinking of updating spec to make it explicit that its only 'instance delete' | 14:50 |
stendulker | https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/implement-rescue-mode.html | 14:51 |
TheJulia | stendulker: +10000000 to updating | 14:51 |
TheJulia | The spec that is | 14:51 |
stendulker | Will post the patch shortly. Just wanted to confirm with rloo for the same. | 14:51 |
* dtantsur watches ironic-tempest-plugin 1.0.0 being released | 14:52 | |
TheJulia | dtantsur: is there a smile involved? | 14:52 |
dtantsur | something like =^_^= | 14:52 |
*** hjensas has quit IRC | 14:52 | |
rloo | stendulker, TheJulia: 'delete' here means instance deletion or node deletion? | 14:55 |
TheJulia | If a core could take a quick look at https://review.openstack.org/#/c/524560/ to add dsvm job to sushy-tools to help prevent breaking changes. I'm basically +2 although I'm not a fan of duplication. That being said, if a non-redhat core is good with it, I think we should go ahead and land it | 14:56 |
patchbot | patch 524560 - sushy-tools - add dvsm CI job | 14:56 |
TheJulia | rloo: delete_allowed_states, if I remember correctly is node deletion | 14:56 |
stendulker | rloo: In some places its mentioned as 'instance delete' and in othe its 'delete node' | 14:56 |
stendulker | rloo: I think it should only be 'instance delete' everywhere. | 14:57 |
*** cdearborn has quit IRC | 14:57 | |
rloo | stendulker: just looked at code in conductor/manager.py. it is destroying the node. | 14:57 |
stendulker | TheJulia: Yes. https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1629-L1630 | 14:57 |
stendulker | rloo, TheJulia : So we should have only instance delete. And user would have to move node to one of the delete_allowed_state using API calls and then perform 'delete node'. WDYT? | 14:59 |
rloo | stendulker: yes, we should not support deletion of a node if it is in a rescu* state, since we don't allow it when it is active. | 15:00 |
TheJulia | stendulker: s/user/operator/ since they would be the ones managing the inventory. Users are typically using ironic through nova. | 15:00 |
*** ElCoyote_ has quit IRC | 15:00 | |
stendulker | rloo,TheJulia: yes, agree. | 15:01 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Clean up release notes before a release https://review.openstack.org/532193 | 15:01 |
rloo | stendulker: i'll comment in the patch. sorry, i haven't yet gotten around to reviewing the rescue patches again. | 15:01 |
dtantsur | does anyone here like removing code? we could remove elilo and glance v1 support this release, since it's going to be major anyway | 15:01 |
stendulker | rloo, TheJulia : Will post the spec patch indicating its only 'instance delete' | 15:02 |
stendulker | rloo: I will shortly post RPC patch addressing comment from TheJulia. Rest all patches are up to date. | 15:02 |
rloo | stendulker: thx | 15:03 |
rloo | dtantsur: have we mentioned that they are deprecated? (I think so, but can't recall) | 15:03 |
stendulker | rloo, TheJulia : Thank you :) | 15:03 |
dtantsur | rloo: we have, yes | 15:04 |
dtantsur | and glance v1 is going away anyway | 15:04 |
*** dpawar has joined #openstack-ironic | 15:05 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic-specs master: Update 'Nova rescue/unrescue in Ironic' https://review.openstack.org/532211 | 15:08 |
rloo | dtantsur: when is glance v1 going away? | 15:09 |
dtantsur | rloo: I think this release, but I'm not 100% sure | 15:10 |
*** rpioso|eat is now known as rpioso | 15:10 | |
rpioso | Good morning, ironicers | 15:10 |
rloo | dtantsur: oh. then we should delete our glance v1 code. | 15:10 |
dtantsur | morning rpioso | 15:10 |
rloo | morning rpioso | 15:10 |
rpioso | stendulker: I have a question about the ilo driver's update_boot_mode() function. | 15:10 |
rpioso | dtantsur, rloo: :) | 15:10 |
stendulker | rpioso: Good morning :) | 15:11 |
rpioso | stendulker: My reading of the code is that it doesn't update the node's instance_info if properties contains a boot_mode capability. | 15:12 |
rpioso | stendulker: Is my understanding correct? | 15:13 |
stendulker | rpioso: let me chk | 15:13 |
stendulker | rpioso: yes | 15:14 |
stendulker | It will update only if nothing is set | 15:14 |
stendulker | rpioso: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/common.py#L486-L494 | 15:15 |
rpioso | stendulker: Why doesn't it set it? | 15:15 |
stendulker | rpioso: It does set it. https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/common.py#L533-L536 | 15:16 |
*** hoonetorg has joined #openstack-ironic | 15:16 | |
rpioso | stendulker: Hrm Doen't it return before that block -- https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/common.py#L501 | 15:17 |
stendulker | It tries to use the boot mode based on node settings https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L757-L767 | 15:17 |
openstackgerrit | Pierre Riteau proposed openstack/networking-generic-switch master: Raise exception when failing to plug port to network https://review.openstack.org/532213 | 15:17 |
stendulker | rpioso: It may go beyond L501 if CONF.ilo.default_boot_mode is set to 'auto' | 15:20 |
stendulker | https://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L1996-L2003 | 15:20 |
stendulker | the value of 'auto' is a behavior preserved for compatibility reasons. | 15:21 |
stendulker | iLO drivers were setting boot mode based on pending boot mode settings and Conf variable default_boot_mode was introduced in later releases. | 15:22 |
rpioso | stendulker: I'm referring to when it's set in properties, which has a higher precedence than the config option. | 15:23 |
*** ElCoyote_ has joined #openstack-ironic | 15:23 | |
rpioso | stendulker: In the end, shouldn't instance_info contain the deploy_boot_mode to reflect what was configured on the instance, even if it's redundant from the perspective of deploy_utils.get_boot_mode_for_deploy()'s processing? | 15:25 |
rpioso | stendulker: Does other processing rely on instance_info['deploy_boot_mode'] or do operators expect it to be set? | 15:26 |
stendulker | rpioso: It could have been, but get_boot_mode_for_deploy() also tries to read it from instance_info | 15:27 |
stendulker | https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L784-L786 | 15:27 |
stendulker | It uses get_boot_mode_for_deploy() which could internally rely on instance_info['deploy_boot_mode'] | 15:28 |
*** cdearborn_ has quit IRC | 15:30 | |
*** makowals has quit IRC | 15:32 | |
openstackgerrit | Vasyl Saienko proposed openstack/networking-generic-switch master: Prepare releasenotes https://review.openstack.org/530946 | 15:34 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Adds RPC calls for rescue interface https://review.openstack.org/509336 | 15:35 |
*** links has quit IRC | 15:36 | |
*** hjensas has joined #openstack-ironic | 15:38 | |
*** hjensas has quit IRC | 15:38 | |
*** hjensas has joined #openstack-ironic | 15:38 | |
rpioso | stendulker: get_boot_mode_for_deploy() is executed after update_boot_mode(), correct? | 15:39 |
*** ameeda has quit IRC | 15:41 | |
*** hoonetorg has quit IRC | 15:41 | |
rpioso | stendulker: It seems that instance_info and properties.capabilities are left out-of-sync when properties.capabilities is used as the source of truth. | 15:42 |
stendulker | rpioso: It may get called before update_boot_mode() | 15:43 |
TheJulia | sambetts: Do you happen to know if Nickolay is on irc? | 15:43 |
TheJulia | instance info is what was scheduled for, capabilities are what an operator says the node is allowed to do or be scheduled for | 15:44 |
stendulker | rpioso: Here https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/boot.py#L359 | 15:44 |
sambetts | TheJulia: he was on here pre-the-holiday, I can't see him around now | 15:44 |
*** makowals has joined #openstack-ironic | 15:45 | |
rpioso | stendulker: I believe update_boot_mode() is not called in that case. Do you agree? | 15:46 |
stendulker | rpioso: yes | 15:47 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: [devstack] Switch ironic to uWSGI https://review.openstack.org/507067 | 15:47 |
rpioso | TheJulia: At the end of deployment, shouldn't instance_info contain the deploy_boot_mode that was used? | 15:48 |
sambetts | rpioso: instance_info isn't the information about the deployed instance, its the input to Ironic for how to deploy the instance | 15:49 |
rpioso | sambetts: Is it only set internally? | 15:51 |
TheJulia | if it is being set internally, it should be determined based upon all available present information, and if needs to be a flag to drive behavior later on, in driver_internal_info | 15:52 |
hjensas | sambetts: Regarding https://review.openstack.org/#/c/456235/ and the dsvm job. I think we would have to make ngs a mech_agent driver as well and use tenant vlans for existing tempest tests to pass. Or add type vlan to the baremetal_mech driver and change ngs to call call ctx.continue_binding instead of ctx.set_binding, and in this case have bot ngs and baremetal mech drivers enabled. | 15:53 |
patchbot | patch 456235 - networking-baremetal - Add baremetal neutron agent | 15:53 |
sambetts | rpioso: no, ironic never sets a value on that field it only reads it, its a field used for external input on how to deploy the instance, so nova writes into it | 15:53 |
TheJulia | sambetts: ugh, any chance you could ping him down stream, I don't want to step on his toes if he is going to revise a patch he created. | 15:53 |
stendulker | rpioso: I think we should set the boot mode based on instance_info capability 'boot_mode' in get_boot_mode_for_deploy() before using one from capabilities in node.properties https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L783 | 15:54 |
hjensas | sambetts: I think possibly dropping the tempest part and leaving just a succesfull devstack with cleaning could suffice as testing, for now? | 15:54 |
*** hoonetorg has joined #openstack-ironic | 15:55 | |
sambetts | hjensas: it might be worth creating a new tempest test which examines the placement API to make sure the information is being set correctly | 15:55 |
sambetts | TheJulia: sure I'll ping him :) | 15:55 |
TheJulia | sambetts: thanks | 15:56 |
rpioso | sambetts: Hrm https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/common.py#L486-L494 | 15:56 |
sambetts | TheJulia: whichi patch is it you want his attention on? the IPA one? | 15:57 |
TheJulia | sambetts: yeah, the IPA one | 15:57 |
*** SerenaFeng has joined #openstack-ironic | 15:59 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Clean up release notes before a release https://review.openstack.org/532193 | 15:59 |
sambetts | TheJulia: ping sent :) | 16:00 |
TheJulia | sambetts: thanks! | 16:02 |
rpioso | stendulker: To confirm, are you suggesting that that line be moved down in get_boot_mode_for_deploy()? | 16:02 |
rpioso | sambetts: ^^^ | 16:04 |
stendulker | rpioso: I was suggesting adding a check if the boot_mode exists in instance_info/capabilities and use it. If its absent, check one in node's properties/capabilities | 16:04 |
rpioso | stendulker: Got it :) | 16:05 |
*** mjura has quit IRC | 16:06 | |
rpioso | stendulker: So instance_info has precedence over properties.capabilities? | 16:06 |
stendulker | it shoudl have. Just as we look for secure_boot and trusted_boot from isntance_info | 16:07 |
stendulker | we have these capabilities in properties/capabilities as well, but we check them in instance_info | 16:08 |
* TheJulia fears how traits will complicate this stuff | 16:08 | |
* TheJulia suspects it will involve lots of whiskey | 16:08 | |
*** rbartal has quit IRC | 16:08 | |
rpioso | stendulker: Do you agree with sambetts that ironic shouldn't internally set instance_info? | 16:08 |
TheJulia | rpioso: It has been a standing for quite a while that we shouldn't set it, that only the requestor sets it | 16:09 |
rpioso | stendulker: I don't know how the configuration option could get conveyed if it doesn't -- https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/common.py#L486-L494 | 16:10 |
TheJulia | Yeah, that is the kind of thing driver_internal_info is for | 16:11 |
rpioso | stendulker: Btw, I'm asking these questions, because I'm adding uefi support to the drac driver. I've been learning what needs to be done from your ilo implementation :) | 16:12 |
openstackgerrit | Merged openstack/ironic master: Run in superconductor cellsv2 mode for non-grenade jobs https://review.openstack.org/527289 | 16:12 |
rpioso | TheJulia: And get_boot_mode_for_deploy() would use driver_internal_infro? | 16:12 |
TheJulia | in a perfect world, yes but that still needs to consult if there is an instance_info driven override | 16:13 |
stendulker | rpioso: yes, we should not be setting it. But this part of the code is a legacy code and came in before driver_internal_info was devised, I suppose. | 16:13 |
stendulker | rpioso: We should be computing boot mode and set it in the node's driver_internal_info | 16:14 |
rpioso | TheJulia, stendulker: Isn't driver_internal_info vendor specific? | 16:17 |
etingof | rpioso, this patch may be relevant to the topic -- https://git.openstack.org/cgit/openstack/ironic/tree/ironic/drivers/modules/redfish/management.py?id=572b6c32d1a2c68e6ebee4d05c4692d2664b1b3f#n162 | 16:18 |
stendulker | rpioso: Not really, its Ironic internal data, it can have both common as well as vendor specific | 16:18 |
rpioso | TheJulia, stendulker: If so, it seems like get_boot_mode_for_deploy() could not use it. | 16:18 |
rpioso | stendulker: Cool | 16:19 |
*** udesale has quit IRC | 16:20 | |
rpioso | etingof: Thank you for the pointer. | 16:22 |
*** jkilpatr_ has joined #openstack-ironic | 16:24 | |
*** SerenaFeng has quit IRC | 16:24 | |
*** stendulker has quit IRC | 16:24 | |
*** stendulker has joined #openstack-ironic | 16:24 | |
rpioso | etingof: I'm going to review https://review.openstack.org/#/c/526773/ | 16:25 |
patchbot | patch 526773 - ironic - boot mode support at ManagementInterface | 16:25 |
dtantsur | https://pypi.python.org/pypi/ironic-tempest-plugin/1.0.0 \o/ | 16:25 |
*** jkilpatr has quit IRC | 16:26 | |
rpioso | stendulker, TheJulia: To summarize, as part of adding uefi support to drac, get_boot_mode_for_deploy() should be modified to account for driver_internal_info containing a setting. | 16:29 |
TheJulia | dtantsur: \o/ | 16:29 |
TheJulia | rpioso: ideally, yes | 16:30 |
stendulker | rpioso: yes. | 16:30 |
rpioso | stendulker, TheJulia: And it would be the third choice -- 1) instance_info, 2) properties.capabilities, and 3) driver_internal_info? | 16:31 |
stendulker | rpioso: yes | 16:31 |
rpioso | stendulker, TheJulia: Do I have creative license on the name of the driver_internal_info property? ;-) | 16:31 |
TheJulia | third choice used for undeployment? instance_info gets wiped by nova, so the task may or may not have the info when undeploying | 16:32 |
TheJulia | rpioso: everyone gets a creative license, as long as it is generally agreeable :) | 16:32 |
rpioso | TheJulia: I haven't looked at UEFI boot mode support from the perspective of undeployment. | 16:33 |
openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Setup ansible interface in devstack https://review.openstack.org/529383 | 16:33 |
*** stendulker_ has joined #openstack-ironic | 16:35 | |
dtantsur | pas-ha, vsaienk0, is there any kind of puppet support for n-g-s? I see nothing in https://github.com/openstack/puppet-neutron/tree/master/manifests/plugins/ml2 | 16:35 |
*** e0ne has quit IRC | 16:35 | |
rpioso | TheJulia, stendulker: Are there undeployment breadcrumbs in the ilo driver? | 16:35 |
*** stendulker has quit IRC | 16:35 | |
vsaienk0 | dtantsur: I don't think so | 16:35 |
TheJulia | rpioso: I think the ilo driver operates on a default from the properties.capabilites or the confiuration file | 16:36 |
* dtantsur adds on his TODO list | 16:36 | |
*** makowals has quit IRC | 16:37 | |
stendulker_ | rpioso: For clearing driver_internal_info, you can have a look at https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/boot.py#L501-L524 | 16:37 |
rpioso | TheJulia: From our discussion, during deployment, the configuration option would be used to set driver_internal_info. | 16:38 |
TheJulia | as a hint for later on as needed? | 16:40 |
rpioso | TheJulia: Yes. It's one of the hints/settings that get_boot_mode_for_deploy() would use. | 16:42 |
stendulker_ | Good night all ! | 16:42 |
*** stendulker_ has quit IRC | 16:43 | |
* TheJulia ponders reply | 16:43 | |
rpioso | TheJulia: In the order 1) instance_info, 2) properties.capabilities, and 3) driver_internal_info | 16:43 |
TheJulia | I think 3, 1, 2 | 16:44 |
TheJulia | and here is why | 16:44 |
rpioso | stendulker_: Good nite! Thank you for your assistance. | 16:44 |
*** mjturek has quit IRC | 16:44 | |
TheJulia | (1) can be deleted before undeployment, (3) will never be touched if node properties.capabilites are still present. what was done should ideally succeed... if that makes sense. Operational default becomes 2 as the last resort | 16:45 |
TheJulia | s/undeployment/teardown tasks actually execute | 16:46 |
rpioso | TheJulia: How does undeployment affect boot mode? | 16:47 |
TheJulia | if we are going through the exercise of undeploying using the same boot mode we deployed in, to perform cleaning we need to preserve that information. I can delete instance_info before setting the node to undeploy, and if I fall to a different default than what was requested, then the driver needs to re-assert boot mode configuration prior to rebooting into cleaning. | 16:50 |
rpioso | Does cleaning call BootInterface.prepare_ramdisk() ? | 16:54 |
*** vsaienk0 has quit IRC | 16:54 | |
TheJulia | I believe so, yes | 16:55 |
*** huats has quit IRC | 16:55 | |
*** jaganathan has quit IRC | 16:56 | |
rpioso | TheJulia: I found it does. | 16:57 |
*** dpawar has quit IRC | 17:00 | |
*** dpawar has joined #openstack-ironic | 17:01 | |
rpioso | TheJulia: I thought that 1) has top priority during deployment, since nova can set it. | 17:01 |
*** amarao has quit IRC | 17:02 | |
rpioso | 1) is the instance_info | 17:02 |
*** AlexeyAbashkin has quit IRC | 17:02 | |
*** dpawar has quit IRC | 17:03 | |
*** dpawar has joined #openstack-ironic | 17:03 | |
*** karthiks has quit IRC | 17:05 | |
*** huats has joined #openstack-ironic | 17:05 | |
NobodyCam | Good Morning Ironic'ers | 17:07 |
*** alex_xu_ has quit IRC | 17:07 | |
dtantsur | morning NobodyCam | 17:08 |
*** alex_xu has joined #openstack-ironic | 17:08 | |
*** jaganathan has joined #openstack-ironic | 17:09 | |
*** jkilpatr has joined #openstack-ironic | 17:09 | |
rpioso | NobodyCam: :) | 17:09 |
*** jkilpatr_ has quit IRC | 17:09 | |
NobodyCam | Good Morning dtantsur and rpioso :) | 17:10 |
NobodyCam | happy not monday | 17:10 |
rpioso | NobodyCam: \o/ | 17:11 |
NobodyCam | :) | 17:11 |
TheJulia | rpioso: yes, instance_info is top priority, I'm speaking about when going back to use the driver_internal_info cached data later in time | 17:13 |
*** lucasagomes is now known as lucas-afk | 17:16 | |
rpioso | TheJulia: I'm describing changes to get_boot_mode_for_deploy() -- https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L757. | 17:16 |
TheJulia | oh, yeah, for deploy at least, for undeploy logic would be slightly different :) | 17:18 |
* TheJulia was thinking during undeployment, not deployment | 17:18 | |
rpioso | TheJulia: Presently, after it considers the secure boot and trusted boot , it proceeds to look at properties.capabilites, and finally instance_info. | 17:19 |
TheJulia | okay | 17:19 |
rpioso | TheJulia: I'm proposing the secure boot and trusted boot consideration remains as is. | 17:19 |
TheJulia | that should be fine, trusted/secure boot enforcement settings is going to be entirely dependent upon operator settings, so they should have the appropriate customized images | 17:20 |
rpioso | TheJulia: Following that, it would consider 1) instance_info, 2) properties.capabilities, and 3) driver_internal_info. | 17:20 |
rpioso | TheJulia: Sounds good? | 17:21 |
rpioso | TheJulia: Note that the order of properties.capabilities and instance_info would be swapped. | 17:22 |
*** penick has joined #openstack-ironic | 17:23 | |
openstackgerrit | John Garbutt proposed openstack/ironic master: Node traits: Add DB API & model https://review.openstack.org/528238 | 17:24 |
openstackgerrit | John Garbutt proposed openstack/ironic master: Join nodes with traits https://review.openstack.org/530723 | 17:24 |
openstackgerrit | John Garbutt proposed openstack/ironic master: WIP: Add RPC object for traits https://review.openstack.org/532268 | 17:24 |
openstackgerrit | John Garbutt proposed openstack/ironic master: WIP: API: Node Traits API https://review.openstack.org/532269 | 17:24 |
TheJulia | Oh, interesting, but yes, that seems correct, we might want to link back to this discussion in the commit message | 17:24 |
TheJulia | ohhhhhh ahhhhhhhhhhhh | 17:24 |
TheJulia | traits patches! | 17:25 |
rpioso | TheJulia: Where's the logic for selecting boot mode during undeploy located? | 17:25 |
rpioso | TheJulia: Thanks for confirming :) | 17:25 |
johnthetubaguy | TheJulia: its not as complete as you might hope, but moving forward now :) | 17:27 |
TheJulia | rpioso: I think that is part of the problem, it might be driver specific if they are wrapping their deploy cod,e or they are just calling the same deploy helper | 17:27 |
*** marios has quit IRC | 17:27 | |
TheJulia | johnthetubaguy: \o/ | 17:27 |
johnthetubaguy | jroll: could you take the client piece, there are patches you can depend on now | 17:27 |
TheJulia | johnthetubaguy: do you want reviews on it now, or to wait? | 17:27 |
johnthetubaguy | TheJulia: would be good to know if I am going in the wrong direction, but its probably not worth more than a quick eyeball? | 17:28 |
TheJulia | johnthetubaguy: ack, I'll try to take a look after my lunch time | 17:29 |
johnthetubaguy | TheJulia: thanks that would be awesome | 17:29 |
jroll | johnthetubaguy: perfect, yes I can do that :) | 17:30 |
* jroll will poke at the patches as well | 17:30 | |
*** makowals has joined #openstack-ironic | 17:33 | |
*** vsaienk0 has joined #openstack-ironic | 17:37 | |
rpioso | TheJulia: stendulker_ pointed me at the ilo clearing of driver_internaL_info at https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/boot.py#L501-L524. | 17:45 |
rpioso | TheJulia: As a result of this discussion, under certain circumstances, the drac driver will set a boot mode in driver_internal_info. I expect it its boot interface's clean_up_instance() method will need to remove that. | 17:46 |
TheJulia | rpioso: most excellent | 17:47 |
*** trown is now known as trown|lunch | 17:48 | |
rpioso | TheJulia: Should that theoretically cover underployment? | 17:48 |
rpioso | s/underployment/undeployment/ | 17:49 |
TheJulia | rpioso: I think so yes, I think clean_up_instance() gets triggered towards the end. | 17:49 |
*** rama_y has joined #openstack-ironic | 17:49 | |
* TheJulia remembers we found an issue someplace around that in one of the drivers, but simply doesn't remember nor can context switch at this point. | 17:50 | |
rpioso | TheJulia: Awesome | 17:50 |
rpioso | TheJulia: Excellent discussion. I learned a bunch. Thank you. | 17:51 |
rpioso | TheJulia: Now to code it :) | 17:51 |
rpioso | sambetts: Thank you for clarifying the use of instance_info. | 17:51 |
*** rpioso is now known as rpioso|eat | 17:52 | |
sambetts | rpioso: no problem :) | 17:52 |
TheJulia | rpioso|eat: \o/ | 17:54 |
TheJulia | eating sounds like a really good idea. | 17:54 |
*** tesseract has quit IRC | 17:57 | |
jroll | can confirm, was a good idea | 17:58 |
*** racedo has quit IRC | 17:59 | |
*** milan_ has joined #openstack-ironic | 17:59 | |
*** derekh has quit IRC | 18:00 | |
*** milan has quit IRC | 18:02 | |
*** rmcall has joined #openstack-ironic | 18:05 | |
*** penick has quit IRC | 18:10 | |
*** vsaienk0 has quit IRC | 18:12 | |
*** vsaienk0 has joined #openstack-ironic | 18:12 | |
*** jkilpatr has quit IRC | 18:17 | |
*** dtantsur is now known as dtantsur|afk | 18:17 | |
dtantsur|afk | o/ | 18:17 |
sambetts | o/ dtantsur|afk | 18:17 |
*** jaganathan has quit IRC | 18:19 | |
*** dpawar has quit IRC | 18:21 | |
*** dpawar has joined #openstack-ironic | 18:21 | |
*** AlexeyAbashkin has joined #openstack-ironic | 18:26 | |
*** dpawar has quit IRC | 18:26 | |
*** vsaienk0 has quit IRC | 18:28 | |
*** etingof has quit IRC | 18:30 | |
*** AlexeyAbashkin has quit IRC | 18:30 | |
*** vsaienk0 has joined #openstack-ironic | 18:33 | |
*** mjturek has joined #openstack-ironic | 18:35 | |
*** jkilpatr has joined #openstack-ironic | 18:38 | |
*** baha has joined #openstack-ironic | 18:38 | |
*** ricardoas has quit IRC | 18:39 | |
*** ricardoas1 has joined #openstack-ironic | 18:39 | |
*** ricardoas1 is now known as ricardoas | 18:39 | |
*** dprince has quit IRC | 18:45 | |
*** oanson has quit IRC | 18:48 | |
*** penick has joined #openstack-ironic | 18:57 | |
*** penick has quit IRC | 19:00 | |
*** trown|lunch is now known as trown | 19:01 | |
*** milan_ has quit IRC | 19:02 | |
*** jtomasek has quit IRC | 19:06 | |
*** rama_y has quit IRC | 19:07 | |
openstackgerrit | Merged openstack/ironic-inspector master: Make the Python 3 job voting https://review.openstack.org/531400 | 19:13 |
openstackgerrit | Merged openstack/ironic master: Clean up release notes before a release https://review.openstack.org/532193 | 19:13 |
*** fragatina has joined #openstack-ironic | 19:17 | |
*** fragatina has quit IRC | 19:18 | |
*** fragatina has joined #openstack-ironic | 19:19 | |
*** mjturek has quit IRC | 19:20 | |
*** sambetts is now known as sambetts|afk | 19:23 | |
sambetts|afk | night all | 19:23 |
*** hoonetorg has quit IRC | 19:25 | |
*** priteau has quit IRC | 19:32 | |
*** penick has joined #openstack-ironic | 19:32 | |
*** harlowja has joined #openstack-ironic | 19:33 | |
*** penick has quit IRC | 19:36 | |
*** harlowja_ has joined #openstack-ironic | 19:41 | |
*** harlowja has quit IRC | 19:43 | |
*** harlowja_ has quit IRC | 19:55 | |
*** harlowja has joined #openstack-ironic | 19:55 | |
openstackgerrit | John Garbutt proposed openstack/ironic master: WIP: Add RPC object for traits https://review.openstack.org/532268 | 19:55 |
*** ricardoas is now known as ricardoas-away | 19:58 | |
*** rbudden has quit IRC | 19:58 | |
*** rbudden has joined #openstack-ironic | 20:00 | |
*** fragatina has quit IRC | 20:15 | |
*** rpioso|eat is now known as rpioso | 20:19 | |
*** ijw has quit IRC | 20:20 | |
*** hoonetorg has joined #openstack-ironic | 20:21 | |
*** dprince has joined #openstack-ironic | 20:37 | |
*** priteau has joined #openstack-ironic | 20:55 | |
*** penick has joined #openstack-ironic | 21:00 | |
TheJulia | johnthetubaguy: posted comments on the first patch, I'm kind of wondering if we should follow the trend of shipping things to the conductor to create/update/destroy instead of just going directly to the db... then again, I suspect that would only matter for folks who would prefer API nodes only have read-only database interactions | 21:01 |
TheJulia | johnthetubaguy: also, not super convinced on population upon node creation, because I'm an awful crazy person | 21:01 |
*** makowals has quit IRC | 21:12 | |
*** crushil has quit IRC | 21:20 | |
*** pcaruana has quit IRC | 21:38 | |
*** threestrands has joined #openstack-ironic | 21:44 | |
*** threestrands has quit IRC | 21:44 | |
*** threestrands has joined #openstack-ironic | 21:44 | |
*** trown is now known as trown|outtypewww | 21:45 | |
*** Goneri has quit IRC | 21:45 | |
*** rmcall has quit IRC | 21:52 | |
*** AlexeyAbashkin has joined #openstack-ironic | 22:00 | |
*** dprince has quit IRC | 22:04 | |
*** AlexeyAbashkin has quit IRC | 22:05 | |
*** rcernin has joined #openstack-ironic | 22:06 | |
*** fragatina has joined #openstack-ironic | 22:15 | |
*** baha has quit IRC | 22:16 | |
*** yee37932 has joined #openstack-ironic | 22:26 | |
*** yee379 has quit IRC | 22:28 | |
*** priteau has quit IRC | 22:40 | |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Switch from MechanismDriver to SimpleAgentMechanismDriverBase https://review.openstack.org/521838 | 22:42 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Devstack - Add ironic-neutron-agent https://review.openstack.org/530117 | 22:42 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add dsvm job https://review.openstack.org/530409 | 22:42 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add support to bind type vlan networks https://review.openstack.org/532349 | 22:42 |
*** penick has quit IRC | 22:43 | |
*** e0ne has joined #openstack-ironic | 22:58 | |
*** penick has joined #openstack-ironic | 23:00 | |
*** charcol has joined #openstack-ironic | 23:04 | |
*** bfournie has quit IRC | 23:10 | |
*** etingof has joined #openstack-ironic | 23:12 | |
*** vsaienk0 has quit IRC | 23:12 | |
*** vsaienk0 has joined #openstack-ironic | 23:20 | |
*** AlexeyAbashkin has joined #openstack-ironic | 23:22 | |
*** pmannidi has joined #openstack-ironic | 23:24 | |
*** AlexeyAbashkin has quit IRC | 23:27 | |
*** rloo has quit IRC | 23:29 | |
*** ianw has quit IRC | 23:50 | |
*** ianw has joined #openstack-ironic | 23:51 | |
*** hshiina has joined #openstack-ironic | 23:52 | |
*** ijw has joined #openstack-ironic | 23:54 | |
*** bfournie has joined #openstack-ironic | 23:54 | |
*** bfournie has quit IRC | 23:56 | |
*** bfournie has joined #openstack-ironic | 23:56 | |
openstackgerrit | Harald Jensås proposed openstack/ironic master: Add a sleep if ironic-neutron-agent is enabled https://review.openstack.org/531637 | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!