Friday, 2018-02-02

openstackgerritJohn L. Villalovos proposed openstack/ironic-tempest-plugin master: Replace use of functools.wraps() with six.wraps()  https://review.openstack.org/54018700:26
*** rcernin has joined #openstack-ironic00:27
*** yangyapeng has quit IRC00:31
*** yangyapeng has joined #openstack-ironic00:32
*** hshiina|afk is now known as hshiina00:32
openstackgerritJohn L. Villalovos proposed openstack/ironic-inspector master: Replace use of functools.wraps() with six.wraps()  https://review.openstack.org/54019100:33
jlvillalhshiina, Good catch on figuring out it was the METRIC.timer() decorator breaking things00:33
jlvillalhshiina, I guess we have been broken all this time for the 'timeout' method when we have used get_signature. Sadly :(00:34
openstackgerritJohn L. Villalovos proposed openstack/python-ironicclient master: Replace use of functools.wraps() with six.wraps()  https://review.openstack.org/54019300:35
*** yangyapeng has quit IRC00:36
openstackgerritHarald Jensås proposed openstack/ironic master: Remove unused code in unittest  https://review.openstack.org/54019400:38
openstackgerritMerged openstack/ironic master: node_tag_exists(): raise exception if bad node  https://review.openstack.org/53370000:38
openstackgerritMerged openstack/ironic master: [api-ref] clarify what /v1/lookup returns  https://review.openstack.org/53967600:38
hshiinajlvillal: power methods with timeout seems to be saved by task_manager.require_exclusive_lock if it is used.00:42
hshiinathis uses six.wraps00:42
openstackgerritJames E. Blair proposed openstack/networking-generic-switch master: Zuul: Remove project name  https://review.openstack.org/54019500:42
jlvillalhshiina, Hmm. I'm not sure. I would think each decorator would have to use it...00:45
jlvillalhshiina, But I haven't actually done any testing or investigating.00:46
openstackgerritJulia Kreger proposed openstack/bifrost master: Deprecate Classic Drivers  https://review.openstack.org/54015300:55
openstackgerritwangdequn proposed openstack/ironic master: correct referenced url in comments  https://review.openstack.org/53471001:08
*** priteau has joined #openstack-ironic01:08
*** priteau has quit IRC01:12
rpiosoGood nite01:12
*** rpioso is now known as rpioso|afk01:12
*** liuzz has joined #openstack-ironic01:14
*** liuzz_ has quit IRC01:14
*** jlabarre has quit IRC01:22
*** tiendc has joined #openstack-ironic01:23
*** yangyapeng has joined #openstack-ironic01:26
*** mjturek has quit IRC01:27
*** zhangfei has joined #openstack-ironic01:39
*** crushil has joined #openstack-ironic01:49
*** yolanda_ has joined #openstack-ironic02:06
*** yolanda has quit IRC02:07
*** namnh has joined #openstack-ironic02:46
openstackgerritHironori Shiina proposed openstack/ironic master: DNM: See if 'timeout' paremeter is visible with reflection  https://review.openstack.org/54021902:55
*** racedo has quit IRC03:00
*** racedo has joined #openstack-ironic03:01
*** liuzz has quit IRC03:06
*** priteau has joined #openstack-ironic03:09
*** priteau has quit IRC03:13
openstackgerritDao Cong Tien proposed openstack/ironic master: devstack: add support for rescue mode  https://review.openstack.org/52411803:15
rloohshiina: I just saw your patch ^^. Did you see jroll's patch that merged today: https://review.openstack.org/53996103:16
patchbotpatch 539961 - ironic - Remove mode argument from boot.(prepare|clean_up)_... (MERGED)03:16
rloohshiina: also, jlvillal has a patch to fix the metrics decorator in ironic-lib: https://review.openstack.org/#/c/540031/03:17
patchbotpatch 540031 - ironic-lib - Use six.wraps() for Metrics so decorated methods c...03:17
openstackgerritRuby Loo proposed openstack/ironic master: Fix handling of 'timeout' parameter to power methods  https://review.openstack.org/54015003:18
openstackgerritDao Cong Tien proposed openstack/ironic master: Update a CI job for rescue mode  https://review.openstack.org/52870403:18
rloohshiina: and as far as timeout goes, it was broken too :-( there's the fix ^^03:18
openstackgerritDao Cong Tien proposed openstack/ironic master: Update "standalone" job for supporting rescue mode  https://review.openstack.org/53782103:19
openstackgerritDao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode standalone tests  https://review.openstack.org/53811903:20
*** lennyb has quit IRC03:22
*** sapd__ has joined #openstack-ironic03:23
*** sapd_ has quit IRC03:23
*** rloo has quit IRC03:26
openstackgerritinspurericzhang proposed openstack/ironic-inspector master: fixed some "ironic" misspelling  https://review.openstack.org/54023303:27
hshiinarloo, jroll: thank you for the fix. rescue mode worked in my local evnironment with the latest master.04:04
*** harlowja_ has quit IRC04:09
*** devananda has quit IRC04:38
openstackgerritparesh sao proposed openstack/ironic master: [docs] Firmware based boot from volume for iLO drivers  https://review.openstack.org/53915804:48
*** harlowja has joined #openstack-ironic04:56
*** vsaienk0 has joined #openstack-ironic04:59
*** vsaienk0 has quit IRC05:09
*** links has joined #openstack-ironic05:15
*** dpawar has joined #openstack-ironic05:16
*** jaganathan has quit IRC05:18
*** yangyapeng has quit IRC05:25
openstackgerritJohn L. Villalovos proposed openstack/ironic-tempest-plugin master: TESTING: Is gate broken?  https://review.openstack.org/54025905:54
*** dpawar has quit IRC05:58
*** zhangfei has quit IRC05:59
jlvillaldtantsur|afk, TheJulia sambett|afk vdrok: The ironic-tempest-plugin gate "may" be broken. I updated the whiteboard. There is a test job running now: https://review.openstack.org/54025906:00
patchbotpatch 540259 - ironic-tempest-plugin - TESTING: Is gate broken?06:00
jlvillalI'm going to go to sleep :)06:00
*** yangyapeng has joined #openstack-ironic06:00
jlvillalhshiina, ^^^ as an FYI06:01
hshiinajlvillal: good night06:02
openstackgerritJames E. Blair proposed openstack/ironic-inspector master: Zuul: Remove project name  https://review.openstack.org/54026206:05
*** marios has joined #openstack-ironic06:06
*** rcernin has quit IRC06:20
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-inspector master: Imported Translations from Zanata  https://review.openstack.org/54026406:21
*** tiendc has quit IRC06:23
*** vsaienk0 has joined #openstack-ironic06:39
*** crushil has quit IRC06:43
*** mjura has joined #openstack-ironic06:51
*** olivierbourdon38 has quit IRC06:56
*** charcol-v2 has quit IRC06:57
*** jaganathan has joined #openstack-ironic06:59
*** makowals has quit IRC07:01
*** makowals has joined #openstack-ironic07:02
*** threestrands has quit IRC07:05
*** jaganathan has quit IRC07:09
*** priteau has joined #openstack-ironic07:10
*** priteau has quit IRC07:15
*** AlexeyAbashkin has joined #openstack-ironic07:18
openstackgerritoctopuszhang proposed openstack/networking-generic-switch master: Remove save configuration implement  https://review.openstack.org/54029507:18
*** dpawar has joined #openstack-ironic07:21
*** vsaienk0 has quit IRC07:23
*** yolanda_ has quit IRC07:23
*** jaganathan has joined #openstack-ironic07:25
openstackgerritwangdequn proposed openstack/ironic master: correct referenced url in comments  https://review.openstack.org/53471007:26
*** vsaienk0 has joined #openstack-ironic07:27
*** olivierbourdon38 has joined #openstack-ironic07:30
*** olivierbourdon38 has quit IRC07:32
pas-hamorning ironic, TGIF :)07:38
etingofhappy Friday, pas-ha ;)07:41
*** AlexeyAbashkin has quit IRC07:47
*** tuanla____ has joined #openstack-ironic07:48
*** jtomasek has joined #openstack-ironic07:50
*** AlexeyAbashkin has joined #openstack-ironic07:55
*** zhenguo has joined #openstack-ironic07:59
*** vabada2 has joined #openstack-ironic08:06
*** vabada2 has quit IRC08:06
*** vabada has quit IRC08:06
*** vabada has joined #openstack-ironic08:07
*** pcaruana has joined #openstack-ironic08:09
*** charcol-v2 has joined #openstack-ironic08:15
*** e0ne has joined #openstack-ironic08:23
*** tesseract has joined #openstack-ironic08:26
*** amarao has joined #openstack-ironic08:31
*** amarao1 has joined #openstack-ironic08:32
*** rbartal has joined #openstack-ironic08:42
*** yangyapeng has quit IRC08:55
*** yangyapeng has joined #openstack-ironic08:55
*** makowals has quit IRC08:57
openstackgerritDao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode tempest tests  https://review.openstack.org/52869908:59
*** makowals has joined #openstack-ironic08:59
*** mgoddard_ has joined #openstack-ironic09:03
*** athomas has joined #openstack-ironic09:03
openstackgerritoctopuszhang proposed openstack/networking-generic-switch master: Remove save configuration implement  https://review.openstack.org/54029509:03
*** rbartal has quit IRC09:10
*** hshiina is now known as hshiina|afk09:13
*** exodusftw has quit IRC09:16
*** exodusftw has joined #openstack-ironic09:24
openstackgerritMerged openstack/ironic master: Wait for ironic-neutron-agent to report state  https://review.openstack.org/53163709:24
openstackgerritMerged openstack/ironic master: Fix configure-networking docs  https://review.openstack.org/54008509:24
*** marios has quit IRC09:26
*** jaganathan has quit IRC09:27
*** jaganathan has joined #openstack-ironic09:27
*** marios has joined #openstack-ironic09:28
*** marios has joined #openstack-ironic09:29
*** racedo has quit IRC09:31
openstackgerritOlivier Bourdon proposed openstack/bifrost master: Add creation of openrc file when keystone enabled  https://review.openstack.org/54009609:37
*** jaganathan has quit IRC09:44
*** derekh has joined #openstack-ironic09:44
openstackgerritoctopuszhang proposed openstack/networking-generic-switch master: Fix bind_port error  https://review.openstack.org/54029509:52
openstackgerritoctopuszhang proposed openstack/networking-generic-switch master: Fix bind_port error  https://review.openstack.org/54029509:54
*** yangyapeng has quit IRC09:55
*** hshiina|afk has quit IRC09:59
*** jaganathan has joined #openstack-ironic09:59
*** makowals has quit IRC10:01
*** tuanla____ has quit IRC10:03
*** makowals has joined #openstack-ironic10:05
*** dsneddon has quit IRC10:09
*** dsneddon has joined #openstack-ironic10:12
*** ijw has joined #openstack-ironic10:13
*** hieulq_ has quit IRC10:13
*** AlexeyAbashkin has quit IRC10:14
*** AlexeyAbashkin has joined #openstack-ironic10:14
*** ijw has quit IRC10:18
*** ijw has joined #openstack-ironic10:19
*** racedo has joined #openstack-ironic10:19
*** AlexeyAbashkin has quit IRC10:23
*** AlexeyAbashkin has joined #openstack-ironic10:23
*** priteau has joined #openstack-ironic10:29
*** priteau has quit IRC10:30
*** priteau has joined #openstack-ironic10:30
*** ijw has quit IRC10:36
*** ijw has joined #openstack-ironic10:36
*** olivierbourdon38 has joined #openstack-ironic10:39
*** ijw_ has joined #openstack-ironic10:42
*** ijw has quit IRC10:45
*** d0ugal has quit IRC10:48
*** smoriya has joined #openstack-ironic10:50
*** smoriya has quit IRC10:50
*** d0ugal has joined #openstack-ironic10:56
*** lucas-afk is now known as lucasagomes11:03
openstackgerritDmitry Tantsur proposed openstack/ironic master: Remove sample policy and config files  https://review.openstack.org/53634911:21
*** exodusftw has quit IRC11:24
*** exodusftw has joined #openstack-ironic11:29
*** dsneddon has quit IRC11:33
*** ijw_ has quit IRC11:34
jrollmorning everyone11:37
* jroll says you're welcome to hshiina even though they are not here11:38
sambett|afkMorning jroll11:38
jrolloh no, jlvillal was right about the tempest plugin gate :(11:38
sambett|afk:(11:39
jrollsome of this: Details: (BaremetalAgentIpmitoolWholedisk:setUpClass) Node 85d5de24-94fd-4b6e-9c86-c14666b8e9f1 failed to reach power_state=['power on'] within the required time (600 s).11:40
jrollsome of this (ruh roh): Details: {u'error_message': u'{"debuginfo":null,"faultcode":"Client","faultstring":"Driver ipmi does not support inspect (disabled or not implemented)."}'}11:40
sambett|afk:/11:41
*** sambett|afk is now known as sambetts11:41
jrollnot sure if the first one is sporadic or not, but the second one probably comes from https://review.openstack.org/#/c/53741511:42
patchbotpatch 537415 - ironic-inspector - Switch the CI to hardware types (MERGED)11:42
jrolldtantsur|afk: ^^ fyi11:42
jrollaha, that's the ocata job :x11:43
*** ijw has joined #openstack-ironic11:45
* jroll will fix in a moment11:46
jrollthough I don't see why it wouldn't be supported11:47
sambettsjroll: it is supported, as long as inspector is enabled in the config file11:48
jrollright11:48
jroll[inspect]/enabled = True11:48
sambettshuh :/11:48
jrolloh, enabled_inspect_interfaces isn't set despite the https://review.openstack.org/#/c/537415/2/devstack/plugin.sh11:49
patchbotpatch 537415 - ironic-inspector - Switch the CI to hardware types (MERGED)11:49
sambettsjroll: I feel like that might be a devstack plugin order thing11:51
jrollah, the devstack bits need to be backported, I think11:51
jrollbecause the ironic-tempest-dsvm-ironic-inspector-ocata will use the master zuul config but ocata devstack plugins11:51
sambettsoh right? the bits that process the *_INTERFACES options11:51
sambetts?11:52
jrollyeah11:52
jrollor, or, we make this change not happen on ocata: https://review.openstack.org/#/c/537415/2/playbooks/legacy/ironic-inspector-tempest-dsvm-discovery/run.yaml11:52
patchbotpatch 537415 - ironic-inspector - Switch the CI to hardware types (MERGED)11:52
sambettsNot sure why we are making it happen on ocata personally, I missed that conversation11:52
* jroll backs up11:53
jrollhere's the patch, it's to our tempest plugin on master: https://review.openstack.org/#/c/540259/11:53
patchbotpatch 540259 - ironic-tempest-plugin - TESTING: Is gate broken?11:53
jrollwhich has jobs that run ocata/pike code, like ironic-tempest-dsvm-ironic-inspector-ocata11:53
jrollthose jobs still use the zuul config from master, because that's where the patch is11:54
sambettsyup got that, because its branchless etc etc11:54
jrollso when this patch landed, it changed how that ocata job is configured: https://review.openstack.org/#/c/537415/11:54
patchbotpatch 537415 - ironic-inspector - Switch the CI to hardware types (MERGED)11:54
jrollbut we don't have the devstack code in ocata to support it11:54
jrollit should really only change the job config for queens11:54
sambettsjroll: right thats why I'm trying to work out why it broke ocata11:55
sambettsjroll: is it because its using the same job definition11:55
sambettsand therefore the same local.conf11:55
sambettsfor all releases11:55
sambetts?11:55
jrollkind of11:56
jrollit's using the same job definition, and therefore the same local.conf, for any patches to ironic-tempest-plugin master branch11:56
jrollincluding the ocata/pike jobs that run against those changes11:56
sambettsjroll: because its pulling the job definition from ironic-insepctors master branch nots its ocata/pike branches11:57
*** namnh has quit IRC11:57
sambetts?11:57
jrollsambetts: yes, AIUI11:58
*** dtantsur|afk is now known as dtantsur11:58
dtantsurmorning/afternoon11:58
sambettso/ dtantsur11:58
jrollmorning dtantsur, just in time :P11:58
dtantsuroh fun, we're using normal playbooks on ocata...11:59
dtantsurjroll: I hope I did not step on your shoes with https://review.openstack.org/#/c/536349/12:00
patchbotpatch 536349 - ironic - Remove sample policy and config files12:00
jrolldtantsur: how dare you fix my release note :)12:01
* dtantsur EVIL12:01
dtantsurjroll: did not expect you to be up at this time12:01
* jroll notices he did not publish his comments on PS412:01
jrolldtantsur: it's 7am, not too early, honestly I got online to send someone a reddit thread and wound up in a CI rabbithole :P12:02
dtantsurthat's how it works!12:02
* dtantsur needs to practice a bit of bass before people make him fix the CI12:02
jrollheh12:03
jrollI'll put up a patch shortly12:03
dtantsurjroll: just note that the inspector change is likely unrelated, the inspector job is defined in ironic12:03
*** pcaruana has quit IRC12:04
dtantsurjroll: https://review.openstack.org/#/c/536875/5/playbooks/legacy/tempest-dsvm-ironic-inspector/run.yaml12:04
patchbotpatch 536875 - ironic - Switch the CI to hardware types (MERGED)12:04
dtantsurjroll: and I wonder if we can just backport the change introducing support for inspect interfaces..12:04
dtantsuranyway, thanks for looking into it!12:04
jrolldtantsur: ah, I see, thanks12:05
sambettsjroll, dtantsur: Just putting up a patch quick to test something, zuul recently changed branch_override to override_checkout, they did support both for a while, but I wonder if they've just removed the the old one12:06
dtantsursambetts: I don't think it's related. ironic-tempest-plugin master pulls playbooks from ironic master12:07
* dtantsur brb12:07
sambettsthats why I'm wondering if its the override thats not working right, e.g. its not reading the override and is looking for the job on master12:09
jrollsambetts: no, job configs are intentionally all combined from the same branch, that's how it's always worked12:10
openstackgerritSam Betts proposed openstack/ironic-tempest-plugin master: Switch to override_checkout for stable branch jobs  https://review.openstack.org/54035512:10
sambettshmmm so we really need to make our CI jobs branchless too ... like infra's ones12:11
jrollnot sure what you mean12:12
jrolljobs like this one are meant to make sure we don't break ocata CI with tempest-plugin changes12:12
jrollnot sure how to do that any other way12:12
sambettsproject-config / openstack-zuul-jobs etc are all branchless, so they don't have this issue everyone pulls the same version of the jobs for all branches12:12
sambettsand you just handle it in the job itself12:13
sambettsI guess :/12:13
sambettslike we did before with the flags in the devstack local.conf, except this time we can do it in a real templating language12:13
sambettsj212:13
jrollI'm not sure that solves the problem, rather just pushes it to all jobs on all branches so we're forced to think about it12:14
sambettsjust a possble solution (obviously not ideal)12:14
jrollgotcha12:15
sambettsI think it was in denver, when monty was talking about zuulv3, the impression I got was that zuul would only load jobs off master for each project for all branches, I think at some point that changed12:16
jrollyeah, I believe it did, not sure when, wasn't around for the transition12:19
dtantsuryep, it did change (thankfully)12:19
sambetts"This value is also used to help select which variants of a job to run. If override-checkout is set, then Zuul will use this value instead of the branch of the item being tested when collecting jobs to run."12:19
jrollorly12:19
dtantsursambetts: oh, this sounds like something we need!12:20
jrollnice, let's see how it goes then12:20
* jroll puts up the other, just in case it's needed12:20
openstackgerritSam Betts proposed openstack/ironic-tempest-plugin master: Switch to override-checkout for stable branch jobs  https://review.openstack.org/54035512:22
sambettsjust revised it a little because I think we were using it slightly wrong too12:23
*** pcaruana has joined #openstack-ironic12:23
sambettsI've used this option heavily for networking-cisco because we support mitaka to pike backwards12:23
sambettson our master branch12:23
jrollsurprising that branch_override didn't do the same thing12:24
openstackgerritJim Rollenhagen proposed openstack/ironic master: Don't use hardware types on Ocata CI  https://review.openstack.org/54035912:24
*** dpawar has quit IRC12:24
sambettsI think that mgiht have been because of how it was being used in the "vars:" section12:24
jrollah12:24
sambettsits should have been "branch-override" in the top of the job12:25
jrollyes, this makes sense12:25
jrollthanks :)12:25
sambettsit was our feature request that changed it from branch-override to override-checkout because we needed the ability to checkout tags e.g. "mitaka-eol"12:25
sambettsand they used to specifically check for a branch12:26
sambettsinstead of just using it as a commitish reference12:26
jrollheh, nice12:26
openstackgerritJim Rollenhagen proposed openstack/ironic-tempest-plugin master: TESTING: Is gate broken?  https://review.openstack.org/54025912:29
jrolladded depends-on for mine, but I think yours will do the right thing12:29
sambettsif the docs are to be believed :)12:30
dtantsurdocs cannot lie12:30
sambetts;)12:31
openstackgerritMerged openstack/bifrost master: roles: bifrost-create-vm-nodes: Set NIC model to 'virtio'  https://review.openstack.org/53925812:39
*** yangyapeng has joined #openstack-ironic12:42
openstackgerritMerged openstack/networking-baremetal master: Update docs and generate config file example  https://review.openstack.org/53901012:51
openstackgerritMerged openstack/sushy-tools master: Zuul: Remove project name  https://review.openstack.org/53990612:54
*** jlabarre has joined #openstack-ironic12:55
*** gcb has quit IRC12:57
openstackgerritJacek Tomasiak proposed openstack/virtualbmc master: Remove devices/*/boot when setting bootdev  https://review.openstack.org/54036812:58
*** ijw has quit IRC13:00
*** ijw has joined #openstack-ironic13:01
*** ricardoas-away is now known as ricardoas13:02
*** ijw_ has joined #openstack-ironic13:05
*** ijw has quit IRC13:07
*** ijw_ has quit IRC13:09
*** hamzy has quit IRC13:13
*** vsaienk0 has quit IRC13:14
*** d0ugal has quit IRC13:16
*** d0ugal has joined #openstack-ironic13:16
*** d0ugal has quit IRC13:16
*** d0ugal has joined #openstack-ironic13:16
openstackgerritJacek Tomasiak proposed openstack/virtualbmc master: Remove devices/*/boot when setting bootdev  https://review.openstack.org/54036813:18
*** hamzy has joined #openstack-ironic13:18
*** vsaienk0 has joined #openstack-ironic13:29
dtantsursambetts: if you have a minute: https://review.openstack.org/#/c/536349/13:33
patchbotpatch 536349 - ironic - Remove sample policy and config files13:33
dtantsurjroll: do you plan on a similar ^^^ change for ironic-inspector?13:33
*** saop has joined #openstack-ironic13:34
*** saop has quit IRC13:35
*** trown|outtypewww is now known as trown13:36
*** ricardoas has quit IRC13:39
*** pcaruana has quit IRC13:46
openstackgerritShivanand Tendulker proposed openstack/ironic-python-agent master: Add documentation for rescue mode  https://review.openstack.org/43162213:48
*** ijw has joined #openstack-ironic14:00
*** ijw has quit IRC14:05
*** pcaruana has joined #openstack-ironic14:06
openstackgerritShivanand Tendulker proposed openstack/ironic master: Follow-up patch for api-ref documentation for rescue  https://review.openstack.org/54039214:07
jrolldtantsur: I can do that, if you like14:08
*** jcoufal has joined #openstack-ironic14:08
dtantsurjroll: if you have a minute :) I'd like the two projects to be consistent14:08
jrollof course14:09
jrolldtantsur: would you like me to keep devstack/example.local.conf, I assume? I don't see something similar in docs14:11
*** edleafe is now known as figleaf14:11
dtantsurjroll: yep, it is for docs actually14:12
jrollcool, thank you14:12
*** ijw has joined #openstack-ironic14:18
*** ijw has quit IRC14:19
*** ijw has joined #openstack-ironic14:19
*** Goneri has joined #openstack-ironic14:22
*** ijw_ has joined #openstack-ironic14:23
*** ijw has quit IRC14:23
*** jaganathan has quit IRC14:24
*** ijw_ has quit IRC14:25
*** ijw has joined #openstack-ironic14:25
openstackgerritOlivier Bourdon proposed openstack/bifrost master: Add creation of openrc file when keystone enabled  https://review.openstack.org/54009614:26
*** lucasagomes is now known as lucas-hungry14:26
*** links has quit IRC14:30
*** cdearborn has joined #openstack-ironic14:32
*** rbudden has joined #openstack-ironic14:32
openstackgerritJim Rollenhagen proposed openstack/ironic-inspector master: Remove sample policy and config files  https://review.openstack.org/54040214:36
jrolldtantsur: that should do it14:36
dtantsurthanks!14:36
*** mjturek has joined #openstack-ironic14:47
openstackgerritMerged openstack/ironic master: Update api-ref for port group create  https://review.openstack.org/53780314:48
*** ricardoas has joined #openstack-ironic14:50
openstackgerritMerged openstack/networking-baremetal master: Add dsvm job  https://review.openstack.org/53040914:51
* TheJulia tries to wake up14:52
dtantsurmorning TheJulia14:52
*** r-daneel has joined #openstack-ironic14:52
TheJuliais it really morning?14:52
dtantsurdunno, there was some sun a few hours ago14:57
*** saop has joined #openstack-ironic14:59
saopTheJulia, Hello I updated the comments please review this https://review.openstack.org/#/c/539158/14:59
patchbotpatch 539158 - ironic - [docs] Firmware based boot from volume for iLO dri...14:59
TheJuliaI overslept a little and now feel like a train hit me15:00
saopTheJulia, :) take your time15:00
*** r-daneel has quit IRC15:01
*** Goneri has quit IRC15:01
dtantsurTheJulia: this can happen, yeah :( sometimes too much sleep is just as bad as not enough sleep15:04
dtantsursaop: lemme check it15:04
TheJuliadtantsur: thanks15:05
* TheJulia is sipping coffee to try and feel awake enough to start her day15:05
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Fix nits in networking-baremetal docs  https://review.openstack.org/54041315:06
dtantsursaop: reviewed. it's close, just a few minor things15:10
*** pcaruana has quit IRC15:13
*** pcaruana has joined #openstack-ironic15:14
*** Goneri has joined #openstack-ironic15:17
*** rpioso|afk is now known as rpioso15:22
rpiosoMorning15:23
*** livelace-link has joined #openstack-ironic15:23
TheJuliagood morning rpioso15:24
*** vsaienk0 has quit IRC15:24
rpiosoTheJulia: Hey :)15:24
cdearborni9-]'=15:25
cdearbornoops!  wiping off keyboard :-)15:25
*** livelace-link has quit IRC15:26
openstackgerritIlya Etingof proposed openstack/ironic master: Add boot mode support to ManagementInterface  https://review.openstack.org/52677315:28
*** livelace-link has joined #openstack-ironic15:28
dtantsurmorning rpioso, cdearborn :)15:28
*** lucas-hungry is now known as lucasagomes15:29
rpiosodtantsur: Happy Friday!15:29
rpiosodtantsur: Your weekend is almost here.15:30
dtantsur\o/15:30
cdearborngood morning dtantsur, TheJulia15:32
dtantsurcan someone please tell me if we still have any of FFEs not finished?15:39
dtantsurhjensas: is your FFE done?15:39
openstackgerritSam Betts proposed openstack/ironic-tempest-plugin master: Switch to override-checkout for stable branch jobs  https://review.openstack.org/54035515:39
openstackgerritShivanand Tendulker proposed openstack/ironic master: Implements rescue interface for 'ilo' hardware type  https://review.openstack.org/45301215:40
*** makowals has quit IRC15:44
dtantsurthis is the last bit for rescue ^^^ right?15:45
*** dsneddon has joined #openstack-ironic15:47
openstackgerritIlya Etingof proposed openstack/ironic master: added redfish boot mode management  https://review.openstack.org/52831415:47
*** vsaienk0 has joined #openstack-ironic15:48
hjensasdtantsur: 524709 and 539600 did not land yet, I don't have time for adding tests to 524709. But I am fine with leaving these for Rocky.15:48
hjensasdtantsur: so, yes.15:48
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Node state configuration - add log_agent_heartbeat  https://review.openstack.org/53960015:49
openstackgerritparesh sao proposed openstack/ironic master: [docs] Firmware based boot from volume for iLO drivers  https://review.openstack.org/53915815:50
hjensasdtantsur: to be honest, I only added 539600 because the auto generated docs include the option. :)15:50
dtantsurokay, rescue needs fixing, see my comments on https://review.openstack.org/#/c/453012/17/ironic/drivers/modules/agent.py@17115:50
patchbotpatch 453012 - ironic - Implements rescue interface for 'ilo' hardware type15:50
dtantsurhow did we end up merging it initially, I wonder?15:50
TheJuliadtantsur:just routed networks hash ringt15:51
dtantsurack15:52
dtantsurTheJulia, hjensas, https://review.openstack.org/#/c/539600/ can be merged, but if it goes in Queens, it does not need a release note15:52
patchbotpatch 539600 - networking-baremetal - Node state configuration - add log_agent_heartbeat15:52
dtantsurbecause it's a small addition to a feature in the same release15:53
dtantsurokay, so only rescue is of a concern15:53
TheJuliaI thought that merged for some reason15:53
*** dsneddon has quit IRC15:54
TheJuliahmm, must have gotten lost in the mix and is not on the whiteboard15:54
jrollTheJulia: is the hash ring thing a must have for q?15:54
hjensasTheJulia: yeah, I forgot to put that on the whiteboard.15:54
dtantsurTheJulia: having explicit checks on an interface implementation breaks the whole idea of the driver composition :(15:55
*** saop has quit IRC15:55
* hjensas will take out the reno then.15:55
TheJuliajroll: I do not believe so, I think it is a nice to have for hjensas, although having it makes it usable out of the gate15:55
dtantsur(and potentially out-of-tree drivers)15:55
TheJuliadtantsur: *sigh*15:55
*** dsneddon has joined #openstack-ironic15:55
dtantsurokay, we may treat it as a bug next week15:55
jrollTheJulia: got it, it has some work to do, unless I'm missing something. so, don't think it will make it15:55
jroll(it being the hash ring bits)15:56
TheJuliadtantsur: so if the class structure can't be validated, and we shouldn't use the interface name in the db how exactly do we know what path the node should take for logic that is interface specific in other areas?15:56
dtantsurTheJulia: it means that such logic is misplaced15:58
dtantsuri.e. it should go to the interface in question15:58
TheJuliaso we need to add a method to call the other interface, that will have to be abstracted off base because base would need to be something like pass15:59
TheJuliaor... we just statically tag and see if the driver loaded has it16:00
* TheJulia has a headache16:00
dtantsurTheJulia: yep, something like task.driver.network.validate_rescue OR task.driver.network.supports_rescue_network16:00
jrolldtantsur: ++16:00
dtantsurbut what we do makes it impossible to create an out-of-tree network interface that supports a rescue network16:00
*** dsneddon has quit IRC16:01
dtantsurwithout inheriting it from NeutronNetwork, even if it does not use Neutron :)16:01
jrolldtantsur: and the base RescueInterface.validate should be calling task.driver.network.validate_rescue16:01
dtantsuryes16:01
* jroll could cook that patch16:01
TheJuliayeah, I agree with that approach, I think I'm just brain fried at the moment16:01
*** r-daneel has joined #openstack-ironic16:02
jrolldtantsur: that said, this doesn't block out-of-tree network interfaces that support a rescue network, it just skips validation of them :)16:02
dtantsurwell, right, okay16:02
dtantsurunless we have something like that in other places16:02
* jroll notes it is pedantic friday for jroll16:02
dtantsurjroll: please do, but leave a note on that patch so that Shiv does not duplicate the effort16:02
jrolldtantsur: I'll leave a note if I start working on it, not sure I'll have time today16:03
dtantsurack16:03
*** dsneddon has joined #openstack-ironic16:03
rpiosoI have a couple of silly questions. What is the purpose of our MissingParameterValue exception? When should it be used?16:05
openstackgerritSam Betts proposed openstack/ironic-tempest-plugin master: Switch to override-checkout for stable branch jobs  https://review.openstack.org/54035516:05
rpiosoIf a function/method does not have an explicit kwargs arg, can a missing parameter be detected by the function/method?16:07
*** dsneddon has quit IRC16:08
openstackgerritShivanand Tendulker proposed openstack/ironic master: Implements rescue interface for 'ilo' hardware type  https://review.openstack.org/45301216:08
* rpioso needs to hang a caffeine pump on his IV pole.16:09
dtantsurrpioso: it's e.g. when your driver needs a driver_info field, but it's not provided16:09
*** olivierbourdon38 has quit IRC16:10
openstackgerritSam Betts proposed openstack/ironic master: Use zuul.override_checkout  instead of custom branch_override var  https://review.openstack.org/54043216:10
*** pcaruana has quit IRC16:11
*** dmellado has quit IRC16:11
rpiosodtantsur: So it typically doesn't directly apply to a function's formal parameters, correct?16:11
dtantsurrpioso: correct16:11
rpiosodtantsur: ty16:11
dtantsurit's a user-facing error16:11
dtantsurnp16:11
TheJuliarpioso: If you find such for an IV pole, please let me know, I'm still asleep16:12
*** dsneddon has joined #openstack-ironic16:12
* jroll throws a handful of these in the channel https://img.medscapestatic.com/pi/features/drugdirectory/octupdate/AMR00200.jpg16:13
TheJuliaooooooo16:13
rpiosojroll: That's what I'm talking about!16:13
jrollI had no idea this was a thing, but webmd says it is: https://www.webmd.com/drugs/2/drug-144281/caffeine-citrate-intravenous/details16:14
*** dmellado has joined #openstack-ironic16:14
*** AlexeyAbashkin has quit IRC16:14
*** ijw has quit IRC16:14
*** ijw has joined #openstack-ironic16:14
*** livelace-link has quit IRC16:15
*** ijw has quit IRC16:15
*** ijw has joined #openstack-ironic16:15
rpiosojroll: The overdose tab must be a mistake ;-)16:15
jrollheh16:15
*** yangyapeng has quit IRC16:15
jrolloverdose symptoms: euphoria16:15
*** livelace-link has joined #openstack-ironic16:16
*** yangyapeng has joined #openstack-ironic16:16
rpiosoor alive16:16
*** rpioso is now known as rpioso|caffeine16:17
jroll:P16:17
*** livelace-link has quit IRC16:17
*** dsneddon has quit IRC16:18
*** links has joined #openstack-ironic16:18
*** ijw has quit IRC16:20
*** yangyapeng has quit IRC16:20
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Node state configuration - add log_agent_heartbeat  https://review.openstack.org/53960016:23
*** dsneddon has joined #openstack-ironic16:24
TheJuliaoverdose of caffeine is bad16:29
*** saop has joined #openstack-ironic16:29
*** yangyapeng has joined #openstack-ironic16:30
saopTheJulia, dtantsur Updated comments please review, https://review.openstack.org/#/c/539158/16:33
patchbotpatch 539158 - ironic - [docs] Firmware based boot from volume for iLO dri...16:33
*** dsneddon has quit IRC16:34
*** saop has quit IRC16:34
*** rpioso|caffeine is now known as rpioso16:35
TheJuliamgoddard: replied to https://review.openstack.org/#/c/534441/616:38
patchbotpatch 534441 - ironic - Don't try to lock for vif actions16:38
TheJuliaalso sambetts, dtantsur, jroll  may want to take a look16:39
dtantsurk16:39
* jroll sets aside for later today16:40
*** dsneddon has joined #openstack-ironic16:44
*** stendulker has joined #openstack-ironic16:44
mgoddardTheJulia: thanks, I'll take a look16:45
*** ijw has joined #openstack-ironic16:47
*** devananda has joined #openstack-ironic16:50
*** trown is now known as trown|lunch16:51
*** ijw has quit IRC16:52
openstackgerritShivanand Tendulker proposed openstack/ironic master: Add validate_rescue() method to network interface  https://review.openstack.org/54044516:55
jrollstendulker: nice! thank you for that16:55
stendulkerjroll: Thank you for the suggestion. Please have a look.16:55
*** AlexeyAbashkin has joined #openstack-ironic16:56
dtantsurthanks stendulker!16:57
*** e0ne has quit IRC16:57
jrollstendulker: +1'd with a question about adding a release note, looks good though, thank you! :)16:58
stendulkerok. Thanks17:00
*** mjura has quit IRC17:01
*** vsaienk0 has quit IRC17:07
TheJulianow, where did I put that brain de-scrambler17:09
*** marios has quit IRC17:09
*** r-daneel has quit IRC17:10
spotzHey guys is there a way to troubleshoot why a node is enroll, manage doesn't change the state on it17:10
openstackgerritJames E. Blair proposed openstack/virtualbmc master: Zuul: Remove project name  https://review.openstack.org/54045217:11
TheJuliaspotz: anything in last_error?17:11
dtantsurspotz: hi, check the last_error field. chances are very high that ironic cannot verify the power credentials17:11
spotzdtantsur TheJulia - It definitely could be the power creds its virtual nodes for testing vs baremetal17:12
TheJuliaspotz: that is generally what will cause a failure17:13
*** amarao has quit IRC17:13
openstackgerritMerged openstack/ironic-ui master: Updated from global requirements  https://review.openstack.org/53493517:13
openstackgerritMerged openstack/ironic-ui master: Imported Translations from Zanata  https://review.openstack.org/53776117:13
spotzdtantsur TheJulia - I'll troubleshoot from that angle, thanks!17:14
*** athomas has quit IRC17:16
*** amarao1 has quit IRC17:16
mgoddard_Hi TheJulia: just finished catching up on those IRC logs re VIFs17:17
TheJuliamgoddard: I like your comments w/r/t adding more locking possibly. PTG discussion for sure17:18
mgoddard_TheJulia: there was a lot of back and forth, so it's hard to work out exactly where everyone ended up, but AFAICT, the thing that dtantsur agreed to was jroll's comment: "TheJulia: I guess I'm back to thinking we probably don't need to lock for vif-detach, but I don't have evidence to support that case in either direction"17:18
mgoddard_TheJulia: so detach, but not attach17:19
*** ijw has joined #openstack-ironic17:19
mgoddard_TheJulia: I may have misinterpreted17:19
TheJuliayeah, and shifting points of view based on the discussion17:19
TheJuliaI took the endpoint as vif actions in general17:19
TheJuliaendpoint of the discussion17:19
mgoddard_TheJulia: perhaps it would be easiest to just ask (again)?17:21
jlvillalGood morning Ironic :)17:21
mgoddard_I'm quite strongly -1 to removing the lock for *attach*, although I wouldn't block a consensus17:21
mgoddard_I'm ok with removing it for detach17:22
TheJuliaI'd rather jroll sambetts and dtantsur to just review and see if we reach consensus at this point. My brain is not quite up for lots of irc discussion today. I'll just hang a sign up saying "purple is the color for the bikeshed"17:22
dtantsurmorning jlvillal17:22
dtantsurmgoddard_, TheJulia, my brain is also not up to speed :(17:22
TheJuliawhiskey o'clock?17:23
*** racedo has quit IRC17:23
*** ijw has quit IRC17:23
mgoddard_TheJulia: sure, I'll reply on the review, and discussion can continue there17:23
devanandag'morning, folks :)17:24
TheJuliagood morning devananda17:24
openstackgerritJohn L. Villalovos proposed openstack/networking-generic-switch master: Mark multinode job as non-voting  https://review.openstack.org/54045917:25
TheJuliajlvillal: let me guess, 50% failure rate or something?17:26
jlvillalTheJulia, 100% failure rate I think.17:27
jlvillalTheJulia, It is basically your patch for Ironic ported to networking-generic-switch17:27
TheJuliawoot!17:27
TheJuliasigh17:27
jlvillalTheJulia, They used the same job as Ironic that got disabled.17:28
TheJuliafun fun :(17:28
*** r-daneel has joined #openstack-ironic17:28
*** derekh has quit IRC17:29
*** tesseract has quit IRC17:30
jrollmorning devananda, mgoddard_17:30
jrollI also am not in an irc discussion mood, heh17:31
dtantsurmorning devananda17:31
* jroll gets lunch17:31
TheJuliaperhaps it is time for more coffee?17:33
mgoddard_morning all, looks like it will be a quiet day today then :)17:33
*** dmellado has quit IRC17:34
*** harlowja has quit IRC17:37
sambettsdtantsur, jlvillal: latest https://review.openstack.org/#/c/540355/ patch should fix the tempest plugin CI17:38
patchbotpatch 540355 - ironic-tempest-plugin - Switch to override-checkout for stable branch jobs17:38
sambettsand I've added a note and a patch about how to get rid of branch_override and use the native zuul options instead of custom ones17:38
sambettshttps://review.openstack.org/#/c/540418/17:39
jlvillalsambetts, Cool! and thanks17:39
patchbotpatch 540418 - openstack-infra/zuul - Add ZUUL_OVERRIDE_BRANCH support for legacy jobs (ABANDONED)17:39
sambettsthats the wrong patch... hold on17:39
*** AlexeyAbashkin has quit IRC17:39
sambettshttps://review.openstack.org/#/c/540432/17:39
patchbotpatch 540432 - ironic - Use zuul.override_checkout  instead of custom bran...17:39
* sambetts --> home 17:40
openstackgerritShivanand Tendulker proposed openstack/ironic master: Add validate_rescue() method to network interface  https://review.openstack.org/54044517:40
sambettsNight all o/17:40
*** sambetts is now known as sambetts|afk17:40
jlvillalsambetts, Good night17:40
sambetts|afkcya'll Monday17:40
NobodyCamGood Morning Ironic'ers : night sambetts|afk17:40
TheJuliamgoddard_: quiet is good. Quiet is very good.17:43
*** SerenaFeng has joined #openstack-ironic17:47
*** baha has joined #openstack-ironic17:48
*** racedo has joined #openstack-ironic17:50
*** dsneddon has quit IRC17:51
mgoddard_bon weekend all o/17:55
NobodyCamhave a good one mgoddard_17:57
*** dsneddon has joined #openstack-ironic17:59
*** mgoddard_ has quit IRC17:59
*** jbags has joined #openstack-ironic18:01
jbagsHello and good morning! I have recently switched from pike to queens , and an experiencing a problem. When I execute the step: "openstack overcloud node configure --all-manageable --root-device=sda" I encounter an error that I havent before, and a google search is turning up nothing.18:02
jbagsThe error is "got an unexpected keyword argument 'auth_token'"], u'result': None}"18:02
jbagsthe full stacktrace is here : https://pastebin.com/i7TnEXy818:03
jbagscan anyone assist?18:03
jrolljbags: that looks like a tripleo issue (iroinc doesn't use mistral), you might check with #tripleo18:08
jlvillaljbags, That looks like triplo-o stuff18:08
* jroll requests his soda18:08
jbagsok thank you18:08
*** harlowja has joined #openstack-ironic18:21
*** dtantsur is now known as dtantsur|afk18:23
dtantsur|afkhave a nice weekend18:23
NobodyCamhave a good one dtantsur|afk :)18:23
*** trown|lunch is now known as trown18:26
*** racedo has quit IRC18:29
*** racedo has joined #openstack-ironic18:29
*** racedo has quit IRC18:29
*** racedo has joined #openstack-ironic18:30
*** racedo has quit IRC18:30
*** SerenaFeng has quit IRC18:34
*** dmellado has joined #openstack-ironic18:35
*** kjw3 has joined #openstack-ironic18:41
*** links has quit IRC18:41
*** yangyape_ has joined #openstack-ironic18:41
openstackgerritShivanand Tendulker proposed openstack/ironic master: Implements rescue interface for 'ilo' hardware type  https://review.openstack.org/45301218:44
*** yangyapeng has quit IRC18:45
*** Goneri has quit IRC18:47
openstackgerritShivanand Tendulker proposed openstack/ironic master: Implements rescue interface for 'ilo' hardware type  https://review.openstack.org/45301218:48
*** ricardoas is now known as ricardoas-away18:57
*** lucasagomes is now known as lucas-afk19:05
*** kjw3 has quit IRC19:05
*** AlexeyAbashkin has joined #openstack-ironic19:11
*** stendulker has quit IRC19:20
*** Goneri has joined #openstack-ironic19:41
*** amarao has joined #openstack-ironic19:46
*** Goneri has quit IRC19:46
openstackgerritJames E. Blair proposed openstack/python-ironic-inspector-client master: Zuul: Remove project name  https://review.openstack.org/54050019:52
*** AlexeyAbashkin has quit IRC19:58
*** AlexeyAbashkin has joined #openstack-ironic20:04
*** Goneri has joined #openstack-ironic20:06
openstackgerritJulia Kreger proposed openstack/bifrost master: Deprecate Classic Drivers  https://review.openstack.org/54015320:08
*** AlexeyAbashkin has quit IRC20:19
openstackgerritJulia Kreger proposed openstack/bifrost master: Fedora 25-27 support  https://review.openstack.org/47175020:22
*** amarao has quit IRC20:25
*** rbudden_ has joined #openstack-ironic20:28
*** rbudden has quit IRC20:29
*** rbudden_ is now known as rbudden20:29
openstackgerritMerged openstack/python-ironic-inspector-client master: Updated from global requirements  https://review.openstack.org/53848220:33
*** charcol-v2 has quit IRC20:46
openstackgerritJulia Kreger proposed openstack/bifrost master: Make Fedora26 CI job voting  https://review.openstack.org/54052420:52
openstackgerritJulia Kreger proposed openstack/bifrost master: Make Fedora26 CI job voting  https://review.openstack.org/54052421:12
*** e0ne has joined #openstack-ironic21:17
*** priteau has quit IRC21:33
*** baha has quit IRC21:46
openstackgerritJulia Kreger proposed openstack/bifrost master: Fix upper-constraints use  https://review.openstack.org/54053821:57
*** e0ne has quit IRC21:58
*** trown is now known as trown|outtypewww22:06
openstackgerritJulia Kreger proposed openstack/bifrost master: Fix upper-constraints use  https://review.openstack.org/54053822:11
*** Goneri has quit IRC22:11
*** jcoufal has quit IRC22:21
openstackgerritJulia Kreger proposed openstack/bifrost master: Fix upper-constraints use  https://review.openstack.org/54053822:32
openstackgerritJulia Kreger proposed openstack/bifrost master: Fix non-venv keystone handling  https://review.openstack.org/49891022:32
openstackgerritJulia Kreger proposed openstack/bifrost master: Experimental Neutron Installation  https://review.openstack.org/45251422:32
openstackgerritJulia Kreger proposed openstack/bifrost master: VM networking for Neutron testing  https://review.openstack.org/49827122:32
openstackgerritJulia Kreger proposed openstack/bifrost master: WIP: Initial neutron task changes  https://review.openstack.org/45251522:32
openstackgerritJulia Kreger proposed openstack/bifrost master: DNM: Execute tests for neutron integration  https://review.openstack.org/49826822:32
openstackgerritJulia Kreger proposed openstack/bifrost master: Add LLDP discovery for IPA/Inspector  https://review.openstack.org/49897222:32
*** jlabarre has quit IRC22:34
*** cdearborn has quit IRC22:56
*** figleaf is now known as edleafe22:58
*** saop has joined #openstack-ironic23:15
saopTheJulia, Hello23:15
saopTheJulia, Need one workflow https://review.openstack.org/#/c/539158/, would you please give me.23:17
patchbotpatch 539158 - ironic - [docs] Firmware based boot from volume for iLO dri...23:17
*** saop has quit IRC23:23
*** priteau has joined #openstack-ironic23:34
*** MattMan has quit IRC23:36
*** MattMan has joined #openstack-ironic23:37
*** priteau has quit IRC23:39

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!