| *** linkmark has quit IRC | 00:12 | |
| *** livelace has quit IRC | 00:19 | |
| *** livelace has joined #openstack-ironic | 00:19 | |
| *** phuongnh has joined #openstack-ironic | 01:13 | |
| *** liuzz has joined #openstack-ironic | 01:14 | |
| *** tiendc has joined #openstack-ironic | 01:31 | |
| *** r-daneel has joined #openstack-ironic | 01:33 | |
| *** prasen has joined #openstack-ironic | 01:52 | |
| *** trungnv has joined #openstack-ironic | 02:24 | |
| *** bfournie has joined #openstack-ironic | 02:25 | |
| *** prasen has quit IRC | 02:26 | |
| openstackgerrit | Nguyen Van Trung proposed openstack/ironic master: Update docs for troubleshooting with maintainance mode https://review.openstack.org/585126 | 02:50 |
|---|---|---|
| *** gkadam has joined #openstack-ironic | 03:30 | |
| *** yolanda_ has joined #openstack-ironic | 03:38 | |
| *** links has joined #openstack-ironic | 03:39 | |
| *** yolanda has quit IRC | 03:41 | |
| openstackgerrit | lei zhang proposed openstack/ironic master: Mark the ZeroMQ driver deprecated https://review.openstack.org/581936 | 03:59 |
| *** sambetts_ has quit IRC | 04:07 | |
| *** sambetts_ has joined #openstack-ironic | 04:09 | |
| *** links has quit IRC | 04:15 | |
| *** hoonetorg has quit IRC | 04:28 | |
| *** jaganathan has joined #openstack-ironic | 04:30 | |
| *** links has joined #openstack-ironic | 04:33 | |
| *** rbartal has joined #openstack-ironic | 04:39 | |
| *** hoonetorg has joined #openstack-ironic | 04:45 | |
| *** ddurst has quit IRC | 04:53 | |
| *** ddurst has joined #openstack-ironic | 04:58 | |
| *** phuongnh has quit IRC | 05:03 | |
| *** tiendc has quit IRC | 05:03 | |
| *** trungnv has quit IRC | 05:03 | |
| *** phuongnh has joined #openstack-ironic | 05:04 | |
| *** tiendc has joined #openstack-ironic | 05:04 | |
| *** trungnv has joined #openstack-ironic | 05:04 | |
| *** rbartal has quit IRC | 05:06 | |
| *** e0ne has joined #openstack-ironic | 05:28 | |
| openstackgerrit | Ankit Kumar proposed openstack/ironic-tempest-plugin master: Test cases for iLO drivers in standalone ironic https://review.openstack.org/535652 | 05:33 |
| *** e0ne has quit IRC | 06:00 | |
| *** ltomasbo has joined #openstack-ironic | 06:07 | |
| *** mjura has joined #openstack-ironic | 06:09 | |
| *** mjura has quit IRC | 06:09 | |
| *** mjura has joined #openstack-ironic | 06:13 | |
| *** jtomasek has joined #openstack-ironic | 06:18 | |
| *** melwitt has quit IRC | 06:31 | |
| *** sdake has quit IRC | 06:31 | |
| *** melwitt has joined #openstack-ironic | 06:32 | |
| *** melwitt is now known as Guest9714 | 06:32 | |
| *** sdake has joined #openstack-ironic | 06:32 | |
| *** sdake has quit IRC | 06:32 | |
| *** sdake has joined #openstack-ironic | 06:32 | |
| *** threestrands has joined #openstack-ironic | 06:38 | |
| *** threestrands has quit IRC | 06:38 | |
| *** threestrands has joined #openstack-ironic | 06:38 | |
| *** sambetts_ has quit IRC | 06:41 | |
| *** sambetts_ has joined #openstack-ironic | 06:45 | |
| *** pcaruana has joined #openstack-ironic | 06:56 | |
| *** tesseract has joined #openstack-ironic | 07:04 | |
| *** skazi has joined #openstack-ironic | 07:07 | |
| *** rbartal has joined #openstack-ironic | 07:08 | |
| *** rcernin has quit IRC | 07:09 | |
| *** pcaruana has quit IRC | 07:14 | |
| *** pcaruana has joined #openstack-ironic | 07:18 | |
| openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Remove testrepository and .testr.conf https://review.openstack.org/581679 | 07:19 |
| *** yolanda_ is now known as yolanda | 07:21 | |
| *** arnewiebalck__ has joined #openstack-ironic | 07:22 | |
| *** ajya has joined #openstack-ironic | 07:26 | |
| *** rbartal has quit IRC | 07:29 | |
| *** threestrands has quit IRC | 07:32 | |
| *** jtomasek_ has joined #openstack-ironic | 07:34 | |
| *** jtomasek has quit IRC | 07:34 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 07:39 | |
| *** rpittau has joined #openstack-ironic | 07:43 | |
| *** mgoddard has joined #openstack-ironic | 07:47 | |
| *** dougsz has joined #openstack-ironic | 07:47 | |
| *** rbartal has joined #openstack-ironic | 07:48 | |
| *** e0ne has joined #openstack-ironic | 07:50 | |
| *** hjensas has joined #openstack-ironic | 08:04 | |
| *** hjensas has quit IRC | 08:04 | |
| *** hjensas has joined #openstack-ironic | 08:04 | |
| *** derekh has joined #openstack-ironic | 08:08 | |
| openstackgerrit | Aija Jaunteva proposed openstack/sushy-tools master: Cleanup libvirt driver for BIOS emulator https://review.openstack.org/586967 | 08:09 |
| *** tssurya has joined #openstack-ironic | 08:21 | |
| *** w-miller has joined #openstack-ironic | 08:22 | |
| *** mbeierl has quit IRC | 08:25 | |
| *** ajya has quit IRC | 08:26 | |
| *** ajya has joined #openstack-ironic | 08:26 | |
| *** etingof has quit IRC | 08:28 | |
| *** mgoddard has quit IRC | 08:29 | |
| *** etingof has joined #openstack-ironic | 08:30 | |
| *** d0ugal has joined #openstack-ironic | 08:31 | |
| *** d0ugal has quit IRC | 08:31 | |
| *** d0ugal has joined #openstack-ironic | 08:31 | |
| *** rbartal has quit IRC | 08:32 | |
| *** serlex has joined #openstack-ironic | 08:45 | |
| *** rbartal has joined #openstack-ironic | 08:45 | |
| yolanda | hi, is ironic gate broken? i get errors like Error when trying to get requirement for VCS system Command "git config --get-regexp remote\..*\.url" failed with error code 1 in /opt/stack/keystone, falling back to uneditable format | 08:45 |
| *** skazi has quit IRC | 08:53 | |
| *** rbartal has quit IRC | 08:53 | |
| etingof | yolanda, is it reported in some patch? | 09:01 |
| yolanda | etingof, http://logs.openstack.org/91/585991/9/check/ironic-dsvm-standalone/78a1c01/ | 09:04 |
| *** rbartal has joined #openstack-ironic | 09:05 | |
| openstackgerrit | Kaifeng Wang proposed openstack/ironic master: Prevents deletion of ports for active nodes https://review.openstack.org/470273 | 09:05 |
| *** arnewiebalck__ has quit IRC | 09:08 | |
| etingof | yolanda, hmm, does it fail anything in the end? | 09:10 |
| etingof | yolanda, btw, I see other weird errors in the log -- http://logs.openstack.org/91/585991/9/check/ironic-dsvm-standalone/78a1c01/job-output.txt.gz#_2018-07-30_08_05_47_325723 | 09:11 |
| yolanda | mm, you are right | 09:11 |
| yolanda | that other may be a red herring | 09:12 |
| etingof | yolanda, this seems to be the last nail in the coffin -- http://logs.openstack.org/91/585991/9/check/ironic-dsvm-standalone/78a1c01/job-output.txt.gz#_2018-07-30_08_07_15_189815 | 09:14 |
| yolanda | ah, again those api version problems | 09:14 |
| * etingof looks into that suspicious KeyError thing | 09:15 | |
| yolanda | i tested in my local devstack and works, but i needed to depen on the python-ironicclient patch | 09:15 |
| yolanda | i added a depends-on here as well, but doesn't seem to work | 09:15 |
| etingof | yolanda, which patch? | 09:17 |
| yolanda | https://review.openstack.org/#/c/586508/ | 09:17 |
| patchbot | patch 586508 - python-ironicclient - Add management of automated_clean field | 09:17 |
| yolanda | the one that fails is https://review.openstack.org/#/c/585991/ | 09:18 |
| patchbot | patch 585991 - ironic - Add automated_clean field to the node object and API | 09:18 |
| yolanda | i tried to depend on the first one, because locally, on my devstack, bumping the client version seems to help | 09:18 |
| yolanda | but that's strange, i don't recall having to bump version on the client to add bios field | 09:19 |
| *** sambetts_ is now known as sambetts | 09:19 | |
| *** skazi has joined #openstack-ironic | 09:20 | |
| *** skazi has quit IRC | 09:21 | |
| *** rpioso is now known as rpioso|afk | 09:22 | |
| etingof | yolanda, this is not the right version, is it? -- http://logs.openstack.org/91/585991/9/check/ironic-dsvm-standalone/78a1c01/job-output.txt.gz#_2018-07-30_07_59_46_276041 | 09:24 |
| yolanda | etingof, i guess the patch is still running at zuul. But the logs looks similar anyway | 09:24 |
| yolanda | that's from the prev recheck | 09:24 |
| * etingof expects the job to pull dependent patch, not the master branch... -- http://logs.openstack.org/91/585991/9/check/ironic-dsvm-standalone/78a1c01/job-output.txt.gz#_2018-07-30_07_51_28_594969 | 09:25 | |
| yolanda | etingof, by the time of that log, the depends-on was already there | 09:26 |
| yolanda | then, seems that the ci is not acting properly on the depends-on... | 09:26 |
| etingof | I am vaguely recalling the cross-repo dependency does not work in some cases, possibly for libraries... and this seems not to work as well | 09:26 |
| yolanda | anyway Julia put a comment, telling that my patch should not depend on the client api version... but i cannot make it work without bumping it | 09:27 |
| yolanda | i tested on devstack and couldn't make it work until i bumped client to 1.47 | 09:27 |
| yolanda | i may miss something on the ironic rest api, but i double checked with the bios patch and i don't see differences | 09:28 |
| etingof | well, this api versioning thing needs to be figured out I think ;) | 09:29 |
| yolanda | yes | 09:29 |
| yolanda | has there been some change recently, since we landed the bios rest api? | 09:30 |
| yolanda | in terms of api versioning? | 09:30 |
| etingof | yolanda, this is what I do not know yet ;) | 09:30 |
| etingof | yolanda, btw, that job does not seem to fail on CI generally -- http://ci-watch.tintri.com/project?project=ironic&time=24+hours | 09:30 |
| yolanda | it's my patch yep... | 09:31 |
| *** dtantsur|afk is now known as dtantsur | 09:35 | |
| dtantsur | morning ironic | 09:35 |
| etingof | dtantsur, good cool Monday morning o/ | 09:36 |
| dtantsur | etingof: oh, already cool at your place? it's keeping boiling here :) | 09:36 |
| dtantsur | or was it sarcasm? | 09:36 |
| etingof | dtantsur, most certainly, sarcasm ;) | 09:37 |
| etingof | aren't we on ironic channel? | 09:37 |
| dtantsur | etingof: ah, that's bad :) going to be +35 tomorrow >_< | 09:37 |
| etingof | that's tough to tolerate | 09:38 |
| dtantsur | right, yeah. I cannot promise to be able to work... | 09:38 |
| etingof | it's 32 down here | 09:39 |
| dtantsur | yeah, the same today | 09:39 |
| etingof | and local water reserve is contaminated | 09:39 |
| dtantsur | OUCH. how come? | 09:40 |
| etingof | cyanobacteria strikes again | 09:40 |
| dtantsur | no way :( | 09:41 |
| etingof | yeah, that happens at times esp when it's too hot for long | 09:41 |
| dtantsur | right, yeah. we mostly use bottled or boiled tap water anyway though. | 09:41 |
| etingof | well, you can't swim because the water gets toxic | 09:42 |
| etingof | even vapors are toxic (theoretically) | 09:43 |
| etingof | tap water should just end once the bacteria colonies clog the filtration system | 09:44 |
| etingof | so we are safe from that prospect \o/ | 09:45 |
| dtantsur | the human civilization is quite fragile, isn't it? | 09:45 |
| etingof | yes, and it's our job to add more risks to it (by coding) | 09:46 |
| dtantsur | \o/ | 09:46 |
| *** AlexeyAbashkin has quit IRC | 09:53 | |
| openstackgerrit | Merged openstack/bifrost master: Add openstacksdk to required-projects https://review.openstack.org/586562 | 09:58 |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic master: Node gets stuck in ING state when conductor goes down https://review.openstack.org/586993 | 10:08 |
| etingof | yolanda, so I read the conversation wrt automated clean patch... may understanding is that TheJulia proposes to split up this patch onto three: new node field, client API version bump, API support of the new field | 10:15 |
| etingof | with client API bump patch dependent on your API patch | 10:16 |
| etingof | but may be I misinterpreted the discussion ;) | 10:16 |
| yolanda | etingof, then somehow testa fail again. I remember zshi having to submit a temporary patch when adding the object, otherwise rest api was failing | 10:25 |
| openstackgerrit | chandra shekar proposed openstack/ironic-specs master: Added new spec for L3 based Ironic deployment https://review.openstack.org/543936 | 10:25 |
| *** zzzeek has quit IRC | 10:49 | |
| openstackgerrit | chandra shekar proposed openstack/ironic-specs master: Added new spec for L3 based Ironic deployment https://review.openstack.org/543936 | 10:51 |
| *** zzzeek has joined #openstack-ironic | 10:53 | |
| *** phuongnh has quit IRC | 10:54 | |
| *** rh-jelabarre has joined #openstack-ironic | 10:56 | |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Clean up unit tests https://review.openstack.org/586029 | 10:59 |
| openstackgerrit | Derek Higgins proposed openstack/virtualbmc master: Specifiy encoding for xml string https://review.openstack.org/587000 | 11:00 |
| openstackgerrit | Aija Jaunteva proposed openstack/sushy master: Add Redfish Message Registry resource https://review.openstack.org/586259 | 11:04 |
| openstackgerrit | Derek Higgins proposed openstack/ironic master: Switch ironic-tempest-dsvm-ipa-partition-pxe_ipmitool-tinyipa-python3 https://review.openstack.org/583555 | 11:04 |
| *** AlexeyAbashkin has joined #openstack-ironic | 11:06 | |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Fix nova unit tests https://review.openstack.org/586496 | 11:21 |
| *** mbeierl has joined #openstack-ironic | 11:59 | |
| *** tiendc has quit IRC | 12:06 | |
| TheJulia | Good morning everyone | 12:08 |
| openstackgerrit | Merged openstack/networking-generic-switch master: Adds ngs_switchport_mode config option to Dell PowerConnect driver https://review.openstack.org/581631 | 12:08 |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Unify BIOS unit tests with others https://review.openstack.org/587035 | 12:09 |
| *** MattMan has quit IRC | 12:09 | |
| *** MattMan has joined #openstack-ironic | 12:10 | |
| etingof | good morning TheJulia o/ | 12:11 |
| dtantsur | morning TheJulia | 12:15 |
| *** gkadam has quit IRC | 12:19 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector master: [WIP] Remove deprecate authentication options https://review.openstack.org/587041 | 12:26 |
| * TheJulia types and types and types | 12:28 | |
| dtantsur | a great day to type! (kidding) | 12:33 |
| *** jcoufal has joined #openstack-ironic | 12:34 | |
| TheJulia | heh | 12:35 |
| *** mjturek has joined #openstack-ironic | 12:42 | |
| etingof | that's what mother nature intended us (coders) for - to type ascii text | 12:42 |
| *** jaypipes has quit IRC | 12:43 | |
| *** jaypipes has joined #openstack-ironic | 12:43 | |
| jroll | morning y'all | 12:44 |
| * jroll declares scrollback bankruptcy | 12:44 | |
| *** links has quit IRC | 12:44 | |
| dtantsur | morning jroll | 12:47 |
| *** mjturek has quit IRC | 12:51 | |
| TheJulia | Good morning jroll | 12:53 |
| *** rloo has joined #openstack-ironic | 12:54 | |
| *** links has joined #openstack-ironic | 12:56 | |
| *** markguz_ has joined #openstack-ironic | 13:05 | |
| *** bfournie has quit IRC | 13:09 | |
| *** jroll has quit IRC | 13:10 | |
| *** markguz_ has quit IRC | 13:10 | |
| *** jroll has joined #openstack-ironic | 13:10 | |
| *** bfournie has joined #openstack-ironic | 13:11 | |
| *** bnemec has joined #openstack-ironic | 13:20 | |
| *** arnewiebalck__ has joined #openstack-ironic | 13:21 | |
| *** arnewiebalck__ has quit IRC | 13:22 | |
| *** alexpilotti has joined #openstack-ironic | 13:27 | |
| *** r-daneel has quit IRC | 13:28 | |
| *** rpioso|afk is now known as rpioso | 13:29 | |
| rpioso | Good morning, ironicers | 13:29 |
| *** arnewiebalck__ has joined #openstack-ironic | 13:31 | |
| *** Goneri has joined #openstack-ironic | 13:38 | |
| *** markguz is now known as markguz_ | 13:40 | |
| *** AlexeyAbashkin has quit IRC | 13:40 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 13:41 | |
| *** mjturek has joined #openstack-ironic | 13:42 | |
| mjturek | gm ironic! | 13:42 |
| etingof | o/ mjturek rpioso | 13:44 |
| *** lbragstad has joined #openstack-ironic | 13:46 | |
| rpioso | etingof, mjturek: \o | 13:47 |
| TheJulia | derekh: I think we're in good shape to begin landing the CI changes, because largely I think we're going to be landing documentation. https://review.openstack.org/#/c/583185/ | 13:50 |
| patchbot | patch 583185 - ironic - Switch ironic-tempest-dsvm-pxe_ipmitool-postgres | 13:50 |
| TheJulia | good morning rpioso mjturek | 13:51 |
| rpioso | TheJulia: :) | 13:52 |
| derekh | TheJulia: cool, I'll remove the WIP, also I took a deeper look at the python3 problem this morning, turns out it was a problem with vbmc and python3 https://review.openstack.org/#/c/587000/ | 13:53 |
| patchbot | patch 587000 - virtualbmc - Specifiy encoding for xml string | 13:53 |
| * derekh will fix pep8 now | 13:53 | |
| TheJulia | derekh: oh awesome! | 13:55 |
| TheJulia | \o/ | 13:55 |
| openstackgerrit | Derek Higgins proposed openstack/virtualbmc master: Specifiy encoding for xml string https://review.openstack.org/587000 | 13:56 |
| openstackgerrit | Aija Jaunteva proposed openstack/sushy master: Add Message Registry File resource https://review.openstack.org/587068 | 13:58 |
| *** baha has joined #openstack-ironic | 14:01 | |
| *** hongbin has joined #openstack-ironic | 14:14 | |
| *** rbartal has quit IRC | 14:20 | |
| rloo | Happy Monday morning ironickers, TheJulia, derekh, rpioso, mjturek! | 14:23 |
| rpioso | rloo: Hey! | 14:23 |
| dtantsur | morning rloo | 14:23 |
| rloo | hi dtantsur! | 14:24 |
| TheJulia | Good morning rloo! | 14:24 |
| * TheJulia updates https://etherpad.openstack.org/p/IronicWhiteBoard | 14:26 | |
| *** links has quit IRC | 14:27 | |
| *** markguz has joined #openstack-ironic | 14:29 | |
| dtantsur | TheJulia: I'm going to cool down before the meeting. If I'm not back in time, please record my -0 to FFEs touching API/RPC and +1 to the others. | 14:35 |
| TheJulia | dtantsur: ack | 14:35 |
| *** ChanServ changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75" | 14:36 | |
| *** dtantsur is now known as dtantsur|brb | 14:38 | |
| *** markguz has quit IRC | 14:40 | |
| *** hshiina has joined #openstack-ironic | 14:45 | |
| *** cdearborn has joined #openstack-ironic | 14:46 | |
| *** jiapei has joined #openstack-ironic | 14:49 | |
| *** stendulker has joined #openstack-ironic | 14:50 | |
| jiapei | Good morning Ironicers | 14:51 |
| TheJulia | good morning jiapei | 14:56 |
| TheJulia | Wow, it is almost meeting time | 14:56 |
| TheJulia | This day is flying by | 14:56 |
| *** kaifeng has joined #openstack-ironic | 14:57 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Change PXE logic to always link macs with UEFI https://review.openstack.org/578959 | 14:57 |
| openstackgerrit | Will Miller proposed openstack/ironic-inspector master: Allow nested action value formatting https://review.openstack.org/585779 | 15:00 |
| TheJulia | #startmeeting ironic | 15:00 |
| openstack | Meeting started Mon Jul 30 15:00:08 2018 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| *** openstack changes topic to " (Meeting topic: ironic)" | 15:00 | |
| TheJulia | o/ | 15:00 |
| openstack | The meeting name has been set to 'ironic' | 15:00 |
| mjturek | o/ | 15:00 |
| kaifeng | o/ | 15:00 |
| bdodd | o/ | 15:00 |
| rpioso | \o | 15:00 |
| etingof | o/ | 15:00 |
| hshiina | o/ | 15:00 |
| rloo | o/ | 15:00 |
| stendulker | o/ | 15:00 |
| jroll | \o | 15:00 |
| TheJulia | Our agenda this week is on the wiki. We have a few discussion topics this week, but hopefully it should go quickly. | 15:01 |
| TheJulia | #link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting | 15:01 |
| TheJulia | #topic Announcements/Reminders | 15:01 |
| *** openstack changes topic to "Announcements/Reminders (Meeting topic: ironic)" | 15:01 | |
| TheJulia | This week is R-4, which means we're closing in on release quite quickly. | 15:02 |
| rajinir | o/ | 15:02 |
| TheJulia | #info python-ironicclient and python-ironic-inspector-client were released last week. | 15:02 |
| TheJulia | #info Reminder: Please add topics and update if you will be present on the Stein PTG planning etherpad. | 15:03 |
| TheJulia | #link https://etherpad.openstack.org/p/ironic-stein-ptg | 15:03 |
| TheJulia | #info Next week is R-3, or Rocky RC1 release. We should expect to release ironic 11.1 next week as a result. | 15:04 |
| TheJulia | Also worth noting, PTL nominations are underway and close tomorrow evening near midnight UTC. | 15:05 |
| TheJulia | Does anyone have anything to announce or remind us of? | 15:05 |
| TheJulia | I guess not, we can move on then. | 15:06 |
| *** MrBerns has joined #openstack-ironic | 15:07 | |
| TheJulia | Looks like we had no action items last week, so we can skip that | 15:07 |
| *** MrBerns has quit IRC | 15:08 | |
| TheJulia | #topic Review subteam status reports | 15:08 |
| *** openstack changes topic to "Review subteam status reports (Meeting topic: ironic)" | 15:08 | |
| TheJulia | #link https://etherpad.openstack.org/p/IronicWhiteBoard | 15:08 |
| TheJulia | Starting at line 163 | 15:08 |
| rloo | wrt the Bugs, can we delete the stuff about moving to storyboard, and whether anythign needs to be addressed? | 15:09 |
| rloo | L169 & 171 | 15:09 |
| TheJulia | I don't see why not | 15:10 |
| rloo | done :) | 15:10 |
| TheJulia | Looks like there is some discussion in the neutron event spec | 15:11 |
| etingof | may be line 37 needs to be deleted as well | 15:11 |
| TheJulia | But, that really doesn't need to be focused on at the moment since we're not going to be able to move it forward until Stein | 15:11 |
| rloo | I updated the BIOS status (L186) | 15:12 |
| TheJulia | rloo: awesome | 15:12 |
| *** MrBerns has joined #openstack-ironic | 15:13 | |
| rpioso | The idrac vendor priority is up-to-date. | 15:13 |
| TheJulia | I saw the notes, looks like a new CI job was added for that, \o/ | 15:13 |
| TheJulia | etingof: Okay, consider it done | 15:14 |
| rloo | wrt classic driver removal: is the only thing left, api-ref examples? | 15:14 |
| rloo | L243ish | 15:14 |
| rpioso | TheJulia: That's correct, thanks to rajinir | 15:14 |
| TheJulia | rloo: I believe so... we'll have to confirm with dtantsur|brb | 15:15 |
| rloo | thx derekh for doing the zuul v3 playbook refactoring! | 15:15 |
| TheJulia | ++ | 15:15 |
| TheJulia | I think we're good to move on to review priorities for the week. Which I did some cleanup of earlier but didn't remove all of the merged items. | 15:15 |
| derekh | rloo: no problem, still more to do, will start the next batch ASAP | 15:16 |
| *** pcaruana has quit IRC | 15:16 | |
| jroll | whoa, ramdisk deploy driver landed, nice work | 15:16 |
| TheJulia | Everyone good to move on? | 15:16 |
| rloo | derekh: :) | 15:16 |
| TheJulia | jroll: yeah, forgot to dance over the weekend :) | 15:17 |
| rloo | awesomeness! | 15:17 |
| TheJulia | Anyway, lets move on to priorites if there are no objections | 15:17 |
| *** arnewiebalck__ has quit IRC | 15:17 | |
| rloo | oh, nice, the nova bug fixes landed too | 15:17 |
| TheJulia | #topic Deciding on priorities for the coming week | 15:18 |
| *** openstack changes topic to "Deciding on priorities for the coming week (Meeting topic: ironic)" | 15:18 | |
| rloo | nothing to do I think :) | 15:18 |
| TheJulia | #link https://etherpad.openstack.org/p/IronicWhiteBoard | 15:18 |
| TheJulia | Line 184 | 15:18 |
| TheJulia | er,r line 103 | 15:18 |
| rloo | ? line 100? | 15:18 |
| TheJulia | Yeah, 100 is the header | 15:20 |
| TheJulia | Anyway, I just deleted things that merged from the list | 15:20 |
| TheJulia | Lots of stuff merged last week \o/ | 15:20 |
| TheJulia | This week looks to largely be documentation and bug fix related since we're essentially feature frozen. I have a few FFE discussion topics up next though :) | 15:21 |
| TheJulia | Everyone good with the list or is anyone aware of anything else that we should add for this next week? | 15:21 |
| jroll | yeah, list looks good to me | 15:21 |
| jroll | I'll add conductor group docs when they're up | 15:21 |
| TheJulia | jroll: thanks | 15:21 |
| *** tssurya has quit IRC | 15:22 | |
| rloo | ++ good | 15:22 |
| TheJulia | Okay, discussion time! | 15:22 |
| w-miller | hi all, i posted a story this morning for a feature i was looking at working on, regarding adding introspection rules for ironic ports (https://storyboard.openstack.org/#!/story/2003149). i’m not really au fait with the RFE workflow so apologies if this is the wrong time to bring it up, but if anyone had any feedback on the story it would be much appreciated :) | 15:22 |
| TheJulia | w-miller: great timing! | 15:23 |
| TheJulia | #topic Discussion | 15:23 |
| *** openstack changes topic to "Discussion (Meeting topic: ironic)" | 15:23 | |
| *** r-daneel has joined #openstack-ironic | 15:23 | |
| TheJulia | I have three items that we might wish to grant a FFE to on the agenda, The item w-miller brought up happens to be one of them | 15:23 |
| TheJulia | The change looks very minor, which is why I included it as a possibility | 15:24 |
| TheJulia | errr | 15:24 |
| TheJulia | wait a second | 15:24 |
| w-miller | ah yeah, i think that’s the change i made last week - but the story is a new one for a different feature | 15:24 |
| TheJulia | I was speaking regarding https://storyboard.openstack.org/#!/story/1670768 | 15:24 |
| rloo | that only affects ironic-inspector? | 15:24 |
| jroll | yeah I don't see it on the list :) | 15:24 |
| * TheJulia got confused | 15:25 | |
| jroll | I think w-miller is only asking for an RFE review | 15:25 |
| TheJulia | sorry :( | 15:25 |
| TheJulia | Yeah, he is sekeing an RFE review for 2003149 | 15:25 |
| TheJulia | Seeking | 15:25 |
| *** gyee has joined #openstack-ironic | 15:25 | |
| w-miller | Yeah :) | 15:25 |
| jroll | ok, let's loop back to that | 15:26 |
| TheJulia | I'm wondering if we should allow https://storyboard.openstack.org/#!/story/1670768 to be granted a FFE https://review.openstack.org/#/c/585779 | 15:26 |
| patchbot | patch 585779 - ironic-inspector - Allow nested action value formatting | 15:26 |
| openstackgerrit | Merged openstack/networking-generic-switch master: add alias for hpe_comware https://review.openstack.org/586681 | 15:26 |
| TheJulia | wow | 15:26 |
| TheJulia | okay, wrong link | 15:26 |
| * TheJulia needs more coffee... or something | 15:26 | |
| TheJulia | https://review.openstack.org/#/c/585779/ | 15:26 |
| patchbot | patch 585779 - ironic-inspector - Allow nested action value formatting | 15:26 |
| TheJulia | I have no objections, dtantsur|brb indicated he was +1 to it based on his prior statement | 15:27 |
| TheJulia | Any objections to granting a FFE? | 15:27 |
| jroll | I'm not sure about how I feel about FFEs where the patch was initially proposed... a day before (?) feature freeze? | 15:28 |
| rloo | there are two things: rfe needs to be approved, and code needs to be approved | 15:28 |
| rloo | the code change itself doesn't look difficult | 15:29 |
| rloo | how useful is this? | 15:29 |
| rloo | Having asked those questions, I'm good with FFE if we have two cores that are willing to shepherd it along | 15:29 |
| jroll | this one seems minimal, so I'm not totally against it, but proposed a day before is the epitome of rushing things :) so I'm -0 I guess | 15:29 |
| jroll | basically what rloo said | 15:30 |
| TheJulia | It seems like it could be very useful for more complex rules. I'm good with shepherding it | 15:30 |
| rloo | yes, it is rushing things. note that the rfe was started in march. | 15:30 |
| TheJulia | anyone else? | 15:30 |
| openstackgerrit | Merged openstack/networking-generic-switch stable/queens: Set neutron branch name in tox_install.sh https://review.openstack.org/586611 | 15:30 |
| w-miller | without the change, a couple of extra ‘boilerplate’ rules are required for the same behaviour - that’s the main point i think | 15:31 |
| TheJulia | march 2017 | 15:31 |
| rloo | even better (or worse) | 15:31 |
| TheJulia | Anyway, dtantsur|brb indicated he was +1, so I say we just kind of let things progress there and see what happens. | 15:31 |
| rloo | i think for ffe, we need two cores to step up | 15:32 |
| TheJulia | Well, dtantsur|brb is also away, so by that we're basically blocked on that | 15:32 |
| rloo | you mean, dtantsur|brb coudl be one of the cores? | 15:32 |
| TheJulia | rloo: yes | 15:32 |
| rloo | who is the other core? | 15:32 |
| TheJulia | rloo: I volunteered earlier | 15:33 |
| rloo | oh, i missed that. | 15:33 |
| TheJulia | Oh, okay | 15:33 |
| rloo | OK, so how about FFE oked if we get a second (hopefully dtantsur|brb) core. | 15:33 |
| *** tssurya has joined #openstack-ironic | 15:33 | |
| rloo | are we at least good with approving rfe? i guess the two cores can approve that too. | 15:33 |
| TheJulia | rloo: works for me. | 15:33 |
| rloo | Good. next... ? :) | 15:34 |
| TheJulia | Next: The automated_clean feature setting on nodes that yolanda has been working on. | 15:34 |
| TheJulia | This involves changes all the way to the API. dtantsur|brb is -0 based upon the fact that it does involve an API change, we can merge it and just not merge client code since that has already been released | 15:35 |
| jroll | yeah, I have the same issues with rushing on this one, it was also first proposed july 25 | 15:35 |
| rloo | is there a link? | 15:35 |
| TheJulia | I'm kind of -0 as well, I feel that we are rushing | 15:35 |
| jroll | and also has api changes which are irreversible | 15:35 |
| jroll | rloo: https://review.openstack.org/#/c/585795/ | 15:35 |
| patchbot | patch 585795 - ironic - Add automated_clean field | 15:35 |
| TheJulia | rloo: Three patches linked on the agenda. | 15:35 |
| TheJulia | https://review.openstack.org/586508 | 15:36 |
| patchbot | patch 586508 - python-ironicclient - Add management of automated_clean field | 15:36 |
| rloo | thx. but also good to put it in the minutes, since the agenda will change. | 15:36 |
| jroll | I'm -2 tbh, I don't want to rush an API change | 15:36 |
| TheJulia | that one can't land | 15:36 |
| jroll | #link https://review.openstack.org/#/c/585795/ | 15:36 |
| patchbot | patch 585795 - ironic - Add automated_clean field | 15:36 |
| jroll | there | 15:36 |
| jroll | :) | 15:36 |
| TheJulia | and https://review.openstack.org/#/c/585991/ | 15:37 |
| patchbot | patch 585991 - ironic - Add automated_clean field to the node object and API | 15:37 |
| TheJulia | I really feel that we need to wait until Stein | 15:37 |
| *** dtantsur|brb is now known as dtantsur | 15:37 | |
| jroll | the RFE also has no info whatsoever | 15:37 |
| * dtantsur is back | 15:37 | |
| rloo | It has a client change, it might be useful w/o it, but I don't think it is worth rushing to get this in. is there a serious need for this now? | 15:38 |
| TheJulia | jroll: yeah, tripleo context is needed there since there is the resistance to have cleaning by default, but ceph requires it. | 15:38 |
| dtantsur | I'll look into the introspection rules RFE if needed | 15:38 |
| * TheJulia adds that context real quick | 15:39 | |
| jroll | TheJulia: well, I mean implementation things | 15:39 |
| rloo | dtantsur: and review the code for that? | 15:39 |
| jroll | what's the API? etc | 15:39 |
| dtantsur | rloo: yes | 15:39 |
| jroll | how is it used? | 15:39 |
| rloo | dtantsur: thx, so FFE granted for that one! | 15:39 |
| dtantsur | as to the API addition, I think it's very useful, but I'm quiet against API changes after FF | 15:39 |
| jroll | this RFE has zero info that is useful to decide whether it's a good feature to accept | 15:39 |
| dtantsur | * quite | 15:39 |
| rloo | if you're running tripleO for real, it seems dangerous to NOT clean. | 15:41 |
| TheJulia | I think it is necessary, if the context of deployments with automated_clean being disbaled is taken into account. | 15:41 |
| rloo | is this just for testing purpoess? | 15:41 |
| dtantsur | rloo: no, tripleo undercloud has cleaning off by default :( | 15:41 |
| TheJulia | But I think we can just wait until Stein since it involves a client change as well. | 15:41 |
| dtantsur | and fwiw it will be mostly useless for tripleo without client changes, either ironicclient or tripleoclient | 15:42 |
| rloo | let's wait then. but it would be good to update to provide more info as to why it is useful | 15:42 |
| jroll | yeah, we need more than a single sentence for an api change :) | 15:42 |
| rloo | (I mean, the rfe has to be approved first, and jroll has asked...) | 15:42 |
| dtantsur | I think a real use case is something like diskless nodes | 15:42 |
| dtantsur | and the new ramdisk deploy | 15:42 |
| jroll | I would especially like to discuss somewhere how safe the None/true/false thing is | 15:43 |
| dtantsur | where you simply don't need cleaning for this particular node (but may need for regular ones) | 15:43 |
| TheJulia | dtantsur: that is a good point, might not want it if your just spinning ramdisks around... or you may explicitly need it on some nodes | 15:43 |
| rloo | we used to say that a spec was needed if there was an API change. | 15:43 |
| rloo | I'm fine relaxing that, as long as the story has more info | 15:43 |
| TheJulia | rloo: I think it evolved last week, but yeah | 15:43 |
| rloo | ok, i think we've discussed this enough now :) | 15:43 |
| TheJulia | Agreed! | 15:44 |
| TheJulia | Next! | 15:44 |
| TheJulia | kaifeng proposed a patch to add the ability to save introspection results to the database, https://review.openstack.org/#/c/583930/ which seems very useful as presently the only option is swift. | 15:45 |
| patchbot | patch 583930 - ironic-inspector - Supports database as an introspection data storage | 15:45 |
| TheJulia | We've kind of talked about this some in the past, and I'm +1 to the idea | 15:46 |
| rloo | ugh. rfe hasn't been approved yet. | 15:46 |
| rloo | all of a sudden, the inspector has the spotlight... | 15:46 |
| sambetts | I believe we did that at some point in the past, and we remove that because it blew out the DB | 15:46 |
| dtantsur | it looks straightforward and benefits the standalone case *a lot* | 15:46 |
| dtantsur | sambetts: no, it was storing huge JSONs in node.extra :) | 15:47 |
| dtantsur | IIRC | 15:47 |
| sambetts | I thought we had stored the inspection results in inspectors DB too, pre-dmidecode | 15:47 |
| sambetts | then we added that and it made it HHUUUGE | 15:47 |
| dtantsur | I don't think so? but maybe my memory lets me down | 15:47 |
| dtantsur | anyway, as long as it's a separate table, it should not be a big hit | 15:48 |
| TheJulia | If we did, we should check and hold off | 15:48 |
| rloo | where's the spec? details on how to decide whether to store in inspector db or in swift? | 15:48 |
| jroll | that's a pretty large change, it seems to me | 15:48 |
| jroll | and basic pieces like this make me skeptical that it's anywhere near ready https://review.openstack.org/#/c/514552/21/ironic_inspector/conf/processing.py | 15:48 |
| patchbot | patch 514552 - ironic-inspector - Supports database as introspection data storage: p... | 15:48 |
| TheJulia | rloo: essentially the storage feature is completely useless without swift, and there are deployments that just don't want swift... | 15:49 |
| *** tssurya has quit IRC | 15:49 | |
| jroll | oh lord it's making all the storage stuff fully pluggable | 15:49 |
| * TheJulia takes that as a -1 from jroll | 15:49 | |
| sambetts | I thought we had saving to disk in there somewhere (we might have removed that too) | 15:49 |
| rloo | TheJulia: right, but saying 'store it in inspector's database', doesn't give much detail. is it a new table? what field? what is the size of the field? | 15:49 |
| *** tesseract has quit IRC | 15:49 | |
| dtantsur | to be fair, I think it was me asking about pluggability | 15:49 |
| jroll | and again this RFE is one sentence. | 15:49 |
| rloo | i don't think the rfe is ready to be approved. | 15:49 |
| rloo | so no FFE for this. unless two cores feel strongly for it. | 15:50 |
| jroll | I don't usually review inspector things (sorry), but if I did I would be -1 on an FFE here | 15:50 |
| sambetts | we should definatly ask the question about the size of the data too, the json returned by IPA is massive with the dmi data hence we use swift, its fine in a small deployment, but any good sized ironic deployment with inspector :/ | 15:50 |
| TheJulia | I think that is fair | 15:50 |
| TheJulia | Okay, moving on! | 15:50 |
| TheJulia | and 10 minutes reamining | 15:51 |
| TheJulia | err, 9 | 15:51 |
| rloo | w-miller had that question earlier on | 15:51 |
| TheJulia | #topic RFE Review | 15:51 |
| *** openstack changes topic to "RFE Review (Meeting topic: ironic)" | 15:51 | |
| TheJulia | w-miller has brought forth https://storyboard.openstack.org/#!/story/2003149 | 15:51 |
| w-miller | apologies for the mistiming | 15:51 |
| TheJulia | to allow conditionals in inspection rules on ports | 15:52 |
| TheJulia | w-miller: no worries :) | 15:52 |
| sambetts | now that is a nice RFE | 15:52 |
| dtantsur | honestly, we should rewrite introspection rules in some less awkward DSL | 15:53 |
| TheJulia | I like it | 15:53 |
| TheJulia | the RFE that is | 15:54 |
| sambetts | it would be cool if it just worked with the jq like json accessing logic, so we could write conditions for any data in the returned inspection data | 15:54 |
| w-miller | the RFE would also be to allow for port actions as well as conditionals - setting/extending an attribute, for example, is also applicable to a port | 15:54 |
| dtantsur | I'm -0 on any big additions to what we have now. I'll be +2 and helping with any effort to make it more universal. | 15:54 |
| TheJulia | +1 re rewriting, but that is out of scope discussion wise at the moment | 15:54 |
| dtantsur | well, for me it's in scope | 15:54 |
| TheJulia | I don't think we can take it on, and we would have to support the old syntax and migrate | 15:55 |
| TheJulia | s/and/and or/ | 15:55 |
| dtantsur | as someone who is responsible for this horror :) | 15:55 |
| w-miller | mgoddard had rewriting of conditional logic to use Jinja2 as a possible feature for me to look at in future but i think that’s a bridge to be crossed if/when it comes to it | 15:55 |
| dtantsur | well, the old syntax is quite rigid, it's not hard to convert from it (yet) | 15:55 |
| TheJulia | dtantsur: you know inspecctor the best, which do you feel brings more value to a user? | 15:56 |
| dtantsur | I'm afraid the approach we take only fixed some cases. i.e. what to do when you want to update port AND node? | 15:57 |
| TheJulia | Two minute warning | 15:58 |
| TheJulia | dtantsur: So do you think changing to a less awkward syntax would be better than the RFE for users in the short term? | 15:58 |
| w-miller | dtantsur: you mean for the same conditional/within the same rule? | 15:59 |
| dtantsur | w-miller: yes; TheJulia: yes. | 15:59 |
| dtantsur | w-miller: I'm ready to discuss after the meeting | 15:59 |
| w-miller | okay great, thanks | 15:59 |
| TheJulia | Sounds good | 15:59 |
| TheJulia | Well, if there is nothing else for anyone to bring up, we can call the meeting done. | 16:00 |
| rpioso | I would very much appreciate reviews of https://review.openstack.org/#/c/579673 | 16:00 |
| patchbot | patch 579673 - python-dracclient - Filter out non-ASCII characters on invalid UTF8 | 16:00 |
| rpioso | Oops, wrong change. | 16:00 |
| rpioso | https://review.openstack.org/#/c/545184/ | 16:00 |
| patchbot | patch 545184 - ironic - Fix iDRAC hardware type does not work with UEFI | 16:00 |
| dtantsur | rpioso: will look | 16:01 |
| rpioso | dtantsur: ty | 16:01 |
| TheJulia | Thanks everyone! | 16:01 |
| TheJulia | #endmeeting | 16:01 |
| *** openstack changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75" | 16:01 | |
| openstack | Meeting ended Mon Jul 30 16:01:35 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:01 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/ironic/2018/ironic.2018-07-30-15.00.html | 16:01 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ironic/2018/ironic.2018-07-30-15.00.txt | 16:01 |
| jroll | thanks \o | 16:01 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/ironic/2018/ironic.2018-07-30-15.00.log.html | 16:01 |
| * jroll finds lunch | 16:01 | |
| dtantsur | w-miller: what prevent us just fixing set-attribute right now as a quick workaround? | 16:01 |
| dtantsur | the "resource" solution feels wrong since not all actions can operator on a port | 16:02 |
| dtantsur | e.g. set-capabilities makes no sense for ports | 16:02 |
| w-miller | dtantsur: what do you mean by “fix”? unless you mean creating something like set-port-attribute as a separate action? | 16:03 |
| dtantsur | w-miller: not necessary, but I see a problem with port-scope conditions in this case.. | 16:03 |
| * dtantsur thinks more | 16:03 | |
| w-miller | i suppose you would have to disallow node-scope actions in a rule with port-scope conditions | 16:04 |
| w-miller | if you chose to go that way | 16:05 |
| *** hshiina has quit IRC | 16:05 | |
| sambetts | which I don't think we want to do | 16:05 |
| *** kaifeng has quit IRC | 16:05 | |
| dtantsur | w-miller: do you have a draft patch for your proposal? because I suspect it may be quite a big change in reality | 16:06 |
| dtantsur | I'd like to see the proposed change to the rules action interface. currently we accept node_info. | 16:06 |
| dtantsur | I guess I'd prefer this to have a spec, but at least makes ^^^ detailed in the RFE | 16:07 |
| w-miller | dtantsur: i’ve been working on it but don’t yet have a draft patch ready. you’re right that even so far it’s a bigger change than i’d anticipated | 16:07 |
| *** mbeierl has quit IRC | 16:07 | |
| dtantsur | yep | 16:07 |
| dtantsur | w-miller: anyway, please update the RFE with the changes to the Action interface you anticipate | 16:08 |
| dtantsur | (well, and Condition too - if any) | 16:08 |
| sambetts | I think this is why we need to have a more flexible rules DSL (for want of a better example kinda of "ansible"y) so we could do things like with_items: {{ introspection_data.ports }}; when: {{ item.switch_info }} == sw1; set-port-attribute: port: {{item.uuid}} value: pn1; | 16:08 |
| w-miller | dtantsur: i can do that | 16:09 |
| dtantsur | sambetts: yeah, I also have ansible on my mind. or mistral which is quite similar. | 16:09 |
| dtantsur | thanks w-miller | 16:09 |
| w-miller | sambetts: i actually originally drafted the concept in pseudo-ansible when thinking through the idea, so i agree haha | 16:10 |
| sambetts | \o/ | 16:10 |
| sambetts | so we build the ansible engine into inspector right? | 16:10 |
| dtantsur | simple! problem solved? | 16:10 |
| sambetts | tbh it could be interesting to have inspector generate an inventory file with the inspection data injects as a var, then we just output the inspector rules data into a temp dir and call ansible-playbook -i <generated inventory file> /tmp/inspector-rule-<hash> | 16:13 |
| sambetts | and the actions like set-atribute could be ansible lib extentions | 16:13 |
| *** Guest9714 is now known as melwitt | 16:15 | |
| sambetts | (can you tell I'm neck deep in ansible transitioning our CI to zuul v3...) | 16:16 |
| *** mjura has quit IRC | 16:18 | |
| w-miller | that’s an interesting idea sambetts - what would the inventory file look like? presumably the introspection actions would only need to be run from one host with openstack API access? | 16:22 |
| dtantsur | sambetts: heh :) | 16:23 |
| sambetts | I was thinking something like http://paste.openstack.org/show/726856/ | 16:23 |
| *** jesusaur has quit IRC | 16:24 | |
| dtantsur | let's just rewrite ironic-inspector in ansible :) we can leave the discovery part in place, everything else is just calling ansible | 16:24 |
| w-miller | sambetts: right, makes sense. | 16:25 |
| *** stendulker has quit IRC | 16:25 | |
| *** ajya has quit IRC | 16:26 | |
| sambetts | then the rule you proposed in the RFE might look something like: http://paste.openstack.org/show/726858/ | 16:30 |
| *** AlexeyAbashkin has quit IRC | 16:30 | |
| *** e0ne has quit IRC | 16:31 | |
| sambetts | and the playbook we generate might look something like: http://paste.openstack.org/show/726859/ | 16:32 |
| *** priteau has joined #openstack-ironic | 16:33 | |
| sambetts | where /tmp/inspector-rule-<uuid> is the file output by inspector using the inspector rule data in the DB | 16:34 |
| *** prasen has joined #openstack-ironic | 16:35 | |
| w-miller | sambetts: that looks good - similar to what i was imagining. is this something we’d actually like an RFE for? | 16:39 |
| w-miller | …or a spec | 16:39 |
| dtantsur | 30C in my room \o/ kmp | 16:39 |
| sambetts | dtantsur: what do you think? its an interesting idea is it something we want to play with? it would significantly simplfy the rules logic carried by inspector I think, we might need to inject some rules for ansible play to lock some of the ansible side of it down too | 16:41 |
| openstackgerrit | Merged openstack/networking-baremetal master: Update neutron-lib requirement for rocky https://review.openstack.org/585510 | 16:42 |
| dtantsur | sambetts: it's curious, I'd like to see a PoC for it | 16:42 |
| sambetts | I agree | 16:42 |
| dtantsur | otherwise the only answer to "what do you think" in this weather is "I do not" :) | 16:42 |
| sambetts | dtantsur: haha I agree with that too | 16:43 |
| w-miller | i can have a chat with mark on wednesday about it - i’d be up for working on a PoC | 16:44 |
| sambetts | w-miller: I would say at least an RFE to keep track of this conversation and the fact the idea exists | 16:44 |
| * w-miller feeling grateful for an air-conditioned office | 16:44 | |
| sambetts | and a PoC would be awesome | 16:44 |
| *** priteau has quit IRC | 16:44 | |
| w-miller | no probs, i’ll get it noted down | 16:45 |
| *** w-miller has left #openstack-ironic | 16:59 | |
| *** derekh has quit IRC | 17:01 | |
| *** priteau has joined #openstack-ironic | 17:02 | |
| *** sambetts is now known as sambetts|afk | 17:08 | |
| sambetts|afk | night all | 17:08 |
| TheJulia | So pondering for soon(): how would people feel if we had some sort of more formalized mentoring ? | 17:08 |
| TheJulia | sambetts|afk: goodnight | 17:08 |
| *** serlex has quit IRC | 17:10 | |
| *** MrBerns has quit IRC | 17:11 | |
| *** dougsz has quit IRC | 17:11 | |
| rpioso | sambetts|afk: Good evening | 17:19 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Prepare for Rocky release https://review.openstack.org/586342 | 17:32 |
| mjturek | TheJulia: should I apply for FFE on https://storyboard.openstack.org/#!/story/1749057 ? | 17:38 |
| TheJulia | mjturek: yeah, I guess | 17:39 |
| mjturek | will do | 17:40 |
| *** e0ne has joined #openstack-ironic | 17:43 | |
| *** jaganathan has quit IRC | 17:50 | |
| *** jiapei has quit IRC | 18:09 | |
| dtantsur | TheJulia: overall positive, depending on what exactly you mean | 18:13 |
| rpioso | dtantsur, TheJulia: I'm wondering why there's an aversion to asserts in the production code? Like https://mail.python.org/pipermail/python-list/2013-November/660568.html , I feel they're reasonable to use as a form of defensive programming and for Design by Contract. | 18:14 |
| dtantsur | rpioso: because they work differently for optimized and non-optimized builds | 18:14 |
| dtantsur | specifically, byte-compiling with -O will remove them without traces | 18:14 |
| rpioso | dtantsur: Well understood. In the situations I'm referring to, the asserts are being used by internal functions to belt and suspender verify input arguments that were already scrubbed by their callers. | 18:17 |
| rpioso | It's defensive and Design by Contract. | 18:17 |
| dtantsur | rpioso: right, but you don't want these removed in actual production. | 18:18 |
| rpioso | It wouldn't matter, since they've already been checked. | 18:18 |
| rpioso | The outer checks cannot be compiled away. | 18:19 |
| dtantsur | rpioso: yeah, but you start returning None instead of raising | 18:19 |
| rpioso | They're useful during development and unit test, and as a form of documentation. | 18:19 |
| dtantsur | I think it's much more useful to raise an exception in all cases | 18:20 |
| rpioso | I've changed it to not do that. | 18:20 |
| rpioso | From that article: | 18:20 |
| rpioso | https://www.irccloud.com/pastebin/wvzZPFmz/ | 18:21 |
| rpioso | Again, this is a secondary, internal check. | 18:21 |
| rpioso | Or checks :-) | 18:22 |
| TheJulia | So is there then no reason to raise an exception? | 18:22 |
| rpioso | Not in those internal functions. | 18:22 |
| rpioso | They're raised by the callers. | 18:22 |
| TheJulia | Then why have a secondary check if we're not going to raise an exception? | 18:23 |
| rpioso | Because changes and bugs happen :) | 18:23 |
| rpioso | They should be caught during unit test against actual h/w. | 18:23 |
| TheJulia | True, but should we not still raise an exception if something is very wrong is found? | 18:23 |
| TheJulia | The caller can still raise then if the input or self validation is wrong, the original caller could then just have the try/except block to catch the same exception | 18:24 |
| rpioso | We do, e.g., https://review.openstack.org/#/c/545184/8/ironic/drivers/modules/drac/management.py@231 | 18:26 |
| patchbot | patch 545184 - ironic - Fix iDRAC hardware type does not work with UEFI | 18:26 |
| rpioso | That's the caller. | 18:26 |
| rpioso | The article proceeds, | 18:27 |
| rpioso | https://www.irccloud.com/pastebin/vvpp1hm1/ | 18:27 |
| TheJulia | Python's model is not defensive though, it is to ask for forgiveness | 18:28 |
| rpioso | The article is from python.org :) | 18:28 |
| TheJulia | "oh, sorry, that didn't work, lets try this!" | 18:28 |
| dtantsur | well, asserts are NOT defensive programming | 18:29 |
| TheJulia | or "Oh, something is really wrong, lets raise the exception because something is really wrong and we should all stop eveyrthing" | 18:29 |
| dtantsur | nor is anything that is stripped from production builds | 18:29 |
| TheJulia | Yeah, then we never actually do anything error handling wise | 18:30 |
| * dtantsur waves | 18:31 | |
| *** dtantsur is now known as dtantsur|afk | 18:31 | |
| rpioso | This is an internal function. The caller already checks the input. | 18:31 |
| rpioso | dtantsur|afk: Good nite | 18:31 |
| dtantsur|afk | o/ | 18:31 |
| openstackgerrit | Merged openstack/ironic master: Switch ironic-tempest-dsvm-pxe_ipmitool-postgres https://review.openstack.org/583185 | 18:32 |
| TheJulia | rpioso: so then there is no actual reason to have the assert then? | 18:32 |
| rpioso | TheJulia: There is. The article captures this well. | 18:33 |
| rpioso | https://www.irccloud.com/pastebin/bcvmmzT1/ | 18:34 |
| rpioso | And | 18:34 |
| rpioso | https://www.irccloud.com/pastebin/y6eU9CDx/ | 18:34 |
| *** prasen has quit IRC | 18:37 | |
| openstackgerrit | Aleksandra Bezborodova proposed openstack/sushy master: Add a virtual media resource https://review.openstack.org/570810 | 18:41 |
| openstackgerrit | Merged openstack/ironic master: Switch ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://review.openstack.org/583337 | 18:46 |
| TheJulia | I guess what I'm confused by is that your insisting that it should be present because it should never be hit... because it is checked before it is called. I feel like we should legitimately be raising the exception the orignal caller's parent is expecting to indicate a failure has occurred... that is if we're that sure it sure it should present. What I'd prefer to avoid is us getting in a practice in relying upon | 18:48 |
| TheJulia | assertion in the code because of the pitfalls. | 18:48 |
| openstackgerrit | Merged openstack/ironic master: Switch ironic-tempest-dsvm-ipa-wholedisk-bios-pxe_snmp-tinyipa https://review.openstack.org/583546 | 18:55 |
| openstackgerrit | Merged openstack/ironic master: Switch ironic-tempest-dsvm-ipa-partition-uefi-pxe_ipmitool-tinyipa https://review.openstack.org/583551 | 18:55 |
| rpioso | TheJulia: "What I'd prefer to avoid is us getting in a practice in relying upon assertion in the code because of the pitfalls." +1 | 18:56 |
| rpioso | TheJulia: The use cases in question don't rely upon them. | 18:57 |
| rpioso | TheJulia: Belts and suspenders :-) | 18:57 |
| TheJulia | heh | 18:57 |
| TheJulia | that is a really good analogy | 18:57 |
| rpioso | TheJulia: During development and unit testing against real h/w, when they're not compiled away, asserts can quickly find gotchas due to unforeseen changes that need to be accounted for. | 18:58 |
| rpioso | s/Belts/Belt/ | 18:59 |
| TheJulia | well there is a slight problem to that | 18:59 |
| rpioso | Only one belt is needed ;-) | 18:59 |
| TheJulia | In that many deployments run the interpretted code instead of pure compiled | 18:59 |
| TheJulia | Of course, we also had to turn off the object compile caching for a CI job at one point if memory serves | 19:00 |
| TheJulia | of course, that also really doesn't matter much | 19:00 |
| TheJulia | Well, it is official, I've started a post-Rocky patch list | 19:03 |
| rpioso | TheJulia: Also, I prefer that such internal functions not raise an exception that should have already been raised by the caller. What exception should be raised? What should its message be? Now the caller has to catch and wrap it in the desired exception. After all, the caller knows the context. | 19:05 |
| *** baha_ has joined #openstack-ironic | 19:07 | |
| TheJulia | Well, the immediate caller doesn't have to catch it. The caller's caller can just read the same exception, it would just depend on what makes sense in each case. | 19:07 |
| *** baha has quit IRC | 19:09 | |
| *** baha_ is now known as baha | 19:10 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Ramdisk deploy driver doc https://review.openstack.org/585486 | 19:40 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Follow-up patch to ramdisk interface https://review.openstack.org/586327 | 19:48 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Rework ironic landing page new docs standard https://review.openstack.org/586627 | 19:59 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Add admin-only provisioner reference arch https://review.openstack.org/586618 | 20:16 |
| *** EranBD has joined #openstack-ironic | 20:21 | |
| *** rpioso is now known as rpioso|afk | 20:38 | |
| *** cdearborn has quit IRC | 20:40 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: ipxe boot interface - begin the process https://review.openstack.org/583407 | 20:49 |
| *** hamzy_ is now known as hamzy | 20:59 | |
| openstackgerrit | Merged openstack/networking-generic-switch master: Follow up for Juniper Junos OS device support https://review.openstack.org/586490 | 21:01 |
| *** r-daneel has quit IRC | 21:03 | |
| eandersson | When running Ironic with Mitaka, is only flat networks supported? Or is it more like in a experimental state in Mitaka? | 21:11 |
| *** r-daneel has joined #openstack-ironic | 21:11 | |
| eandersson | Also, in general how mature was Ironic in Mitaka? | 21:11 |
| TheJulia | eandersson: you realize mitaka is unsupported by the community correct? | 21:12 |
| eandersson | Yea - that does unfortunately not change the fact that we are not yet ready to upgrade. | 21:12 |
| TheJulia | :( | 21:12 |
| TheJulia | Okay | 21:12 |
| TheJulia | I'm fairly sure we didn't add network_interface until newton | 21:13 |
| TheJulia | but I'm looking | 21:13 |
| eandersson | Thanks - we are deploying Ironic both as Mitaka and Queens, but we ideally want to roll out Ironic in PROD before the upgrade. | 21:13 |
| *** priteau has quit IRC | 21:14 | |
| *** baha has quit IRC | 21:14 | |
| TheJulia | yup, it is not in ocata, so only flat networks. | 21:14 |
| TheJulia | err | 21:14 |
| TheJulia | mitaka | 21:15 |
| TheJulia | only flat networks in mitaka | 21:15 |
| jroll | pretty sure it was newton, yeah | 21:15 |
| eandersson | Thanks - I thought so | 21:15 |
| TheJulia | mitaka was fairly stable if memory serves | 21:16 |
| TheJulia | But we've added a lot of functionality and refactored quite a bit since then. Queens would be better... You won't just be able to run a mixed environment with a queens ironic and a mitaka deployment otherwise since I believe we had to land binding profile stuffs into neutron and you need a ml2 plugin to manage the switches that supports the baremetal vnic_type | 21:18 |
| TheJulia | jroll: I was thinking newton because I was fairly sure I was reviewing network_interface patches when I first visited the future mother-in-law's driveway with my motorhome | 21:20 |
| jroll | heh, weird how memories work | 21:21 |
| jroll | I was thinking newton because it was like, "finally" | 21:21 |
| *** ak has joined #openstack-ironic | 21:21 | |
| jroll | release notes confirm newton, 6.1 | 21:22 |
| TheJulia | jroll: thanks! | 21:24 |
| jroll | :) | 21:24 |
| jroll | have a good night y'all | 21:24 |
| TheJulia | Anyway, speaking of future mother in law's... I need to go make myself presentable to take the other half and her mom out to dinner | 21:24 |
| TheJulia | goodnight jroll | 21:24 |
| *** ceryx has joined #openstack-ironic | 21:25 | |
| TheJulia | eandersson: let us know if you have any more questions or if we can be of any more assistance. For now, I'm stepping away. Have a wonderful evening | 21:25 |
| eandersson | Sounds good, appreciate that | 21:25 |
| *** dsneddon has quit IRC | 21:29 | |
| *** dsneddon has joined #openstack-ironic | 21:31 | |
| *** Goneri has quit IRC | 21:36 | |
| *** bnemec has quit IRC | 21:46 | |
| *** rcernin has joined #openstack-ironic | 22:02 | |
| *** jesusaur has joined #openstack-ironic | 22:03 | |
| *** priteau has joined #openstack-ironic | 22:14 | |
| *** pmannidi has joined #openstack-ironic | 22:17 | |
| *** threestrands has joined #openstack-ironic | 22:18 | |
| *** threestrands has quit IRC | 22:18 | |
| *** threestrands has joined #openstack-ironic | 22:18 | |
| *** e0ne has quit IRC | 22:39 | |
| *** jcoufal has quit IRC | 22:40 | |
| *** linkmark has joined #openstack-ironic | 22:40 | |
| *** hongbin has quit IRC | 22:52 | |
| *** EranBD has quit IRC | 23:00 | |
| *** markguz has joined #openstack-ironic | 23:08 | |
| *** alineb has quit IRC | 23:14 | |
| *** markguz has quit IRC | 23:15 | |
| *** markguz has joined #openstack-ironic | 23:16 | |
| *** r-daneel has quit IRC | 23:16 | |
| *** markguz has quit IRC | 23:20 | |
| *** alineb has joined #openstack-ironic | 23:39 | |
| *** etingof has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!