| *** jesusaur has quit IRC | 00:12 | |
| *** jesusaur has joined #openstack-ironic | 00:18 | |
| *** rpioso is now known as rpioso|afk | 00:20 | |
| *** spartakos has quit IRC | 00:40 | |
| *** jasontle has joined #openstack-ironic | 00:52 | |
| jasontle | hi | 00:52 |
|---|---|---|
| jasontle | I have a set up Ironic with Devstack | 00:53 |
| *** phuongnh has joined #openstack-ironic | 01:02 | |
| *** etingof has quit IRC | 01:06 | |
| *** rh-jelabarre has quit IRC | 01:08 | |
| *** zigo has joined #openstack-ironic | 01:09 | |
| *** r-daneel has joined #openstack-ironic | 01:53 | |
| *** spartakos has joined #openstack-ironic | 01:56 | |
| openstackgerrit | Kaifeng Wang proposed openstack/ironic-inspector master: Add API reference https://review.openstack.org/495752 | 02:00 |
| *** gyee has quit IRC | 02:12 | |
| *** sambetts_ has quit IRC | 02:16 | |
| *** rloo has quit IRC | 02:45 | |
| *** sw3 has quit IRC | 03:06 | |
| *** sw3 has joined #openstack-ironic | 03:14 | |
| *** rloo has joined #openstack-ironic | 03:20 | |
| *** sw3 has quit IRC | 03:21 | |
| *** gkadam has joined #openstack-ironic | 03:21 | |
| *** rloo has quit IRC | 03:22 | |
| *** spartakos has quit IRC | 03:57 | |
| *** gkadam has quit IRC | 04:10 | |
| *** gkadam has joined #openstack-ironic | 04:10 | |
| *** edleafe has quit IRC | 04:31 | |
| *** tonyb has quit IRC | 04:40 | |
| *** tonyb has joined #openstack-ironic | 04:40 | |
| *** skazi has quit IRC | 04:45 | |
| *** etingof has joined #openstack-ironic | 05:01 | |
| *** ijw has joined #openstack-ironic | 05:42 | |
| *** ijw has quit IRC | 05:47 | |
| *** jiapei has joined #openstack-ironic | 05:48 | |
| *** hjensas has quit IRC | 05:52 | |
| *** skazi has joined #openstack-ironic | 05:56 | |
| *** skazi has quit IRC | 05:56 | |
| *** pcaruana has joined #openstack-ironic | 06:23 | |
| *** Bhujay has joined #openstack-ironic | 06:25 | |
| *** Bhujay has quit IRC | 06:26 | |
| *** Bhujay has joined #openstack-ironic | 06:26 | |
| *** ijw has joined #openstack-ironic | 06:37 | |
| *** ijw has quit IRC | 06:42 | |
| *** adrianc has joined #openstack-ironic | 06:48 | |
| *** hjensas has joined #openstack-ironic | 06:54 | |
| *** ijw has joined #openstack-ironic | 07:00 | |
| *** rcernin has quit IRC | 07:04 | |
| *** ijw has quit IRC | 07:04 | |
| *** milan has quit IRC | 07:05 | |
| *** tssurya has joined #openstack-ironic | 07:08 | |
| *** MattMan_1 has joined #openstack-ironic | 07:11 | |
| *** MattMan has quit IRC | 07:11 | |
| *** adrianc has quit IRC | 07:20 | |
| *** olivierb has joined #openstack-ironic | 07:23 | |
| *** adrianc has joined #openstack-ironic | 07:40 | |
| *** arne_wiebalck_ has joined #openstack-ironic | 07:46 | |
| *** e0ne has joined #openstack-ironic | 07:46 | |
| *** mgoddard has joined #openstack-ironic | 08:16 | |
| *** dougsz_ has joined #openstack-ironic | 08:16 | |
| *** arne_wiebalck_ has quit IRC | 08:19 | |
| *** dsneddon has quit IRC | 08:22 | |
| *** gkadam_ has joined #openstack-ironic | 08:23 | |
| *** gkadam has quit IRC | 08:27 | |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: zuul: Add openSUSE Leap 15 jobs https://review.openstack.org/599521 | 08:28 |
| *** Bhujay has quit IRC | 08:30 | |
| *** dtantsur|afk is now known as dtantsur | 08:35 | |
| *** Bhujay has joined #openstack-ironic | 08:35 | |
| dtantsur | morning ironic | 08:35 |
| dtantsur | TheJulia: wild thought: what if we update this channel's topic with a time (in UTC) when most contributors are online? | 08:36 |
| dtantsur | I'm really sad to see people coming at 1am with questions and getting ignored :( | 08:36 |
| dtantsur | maybe something like "If you have a question between 8am UTC and 12 am UTC, better use openstack-dev ML or wait till tomorrow"? | 08:37 |
| * dtantsur is pondering an autoreply bot | 08:37 | |
| *** priteau has quit IRC | 08:42 | |
| *** priteau has joined #openstack-ironic | 08:42 | |
| *** derekh has joined #openstack-ironic | 08:44 | |
| *** pcaruana has quit IRC | 08:50 | |
| *** arne_wiebalck_ has joined #openstack-ironic | 08:58 | |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: zuul: Add openSUSE Leap 15 jobs https://review.openstack.org/599521 | 09:11 |
| openstackgerrit | Kaifeng Wang proposed openstack/ironic master: Remove inspecting state support from inspect_hardware https://review.openstack.org/599978 | 09:29 |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: zuul: Add openSUSE Leap 15 jobs https://review.openstack.org/599521 | 09:53 |
| *** adrianc has quit IRC | 09:55 | |
| *** pcaruana has joined #openstack-ironic | 09:58 | |
| *** arne_wiebalck_ has quit IRC | 10:04 | |
| *** adrianc has joined #openstack-ironic | 10:04 | |
| openstackgerrit | Nguyen Van Trung proposed openstack/ironic master: [WIP] Support firmware upgrade for irmc driver https://review.openstack.org/599992 | 10:09 |
| *** adrianc has quit IRC | 10:37 | |
| *** pvc has quit IRC | 10:46 | |
| *** phuongnh has quit IRC | 10:50 | |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: zuul: Add openSUSE Leap 15 jobs https://review.openstack.org/599521 | 10:56 |
| *** dtantsur is now known as dtantsur|brb | 11:08 | |
| *** rh-jelabarre has joined #openstack-ironic | 11:11 | |
| olivierb | good morning ironicers | 11:11 |
| olivierb | I have a situation where my deploy node is stuck in verifying state | 11:19 |
| olivierb | both bifrost node and provisioned node are running as KVM/libvirt VMs on my Xenial system | 11:19 |
| olivierb | connectivity seems ok between IPA node and bifrost (can ping, see packets arriving on port 5050, ...) | 11:20 |
| olivierb | however last message in IPA log is | 11:20 |
| olivierb | No ipa-url configured, ... | 11:21 |
| olivierb | what should I bee looking at next to solve this issue | 11:21 |
| openstackgerrit | Markos Chandras (hwoarang) proposed openstack/bifrost master: zuul: Add openSUSE Leap 15 jobs https://review.openstack.org/599521 | 11:37 |
| *** zigo has quit IRC | 11:45 | |
| *** gkadam_ has quit IRC | 11:54 | |
| olivierb | all driver info seems to be there: | 11:54 |
| olivierb | driver | ipmi | 11:54 |
| olivierb | driver_info | {u'ipmi_port': u'6001', u'ipmi_username': u'admin', u'deploy_kernel': u'http://10.20.128.254:8080//ipa.vmlinuz', u'ipmi_address': u'10.20.118.1', u'deploy_ramdisk': u'http://10.20.128.254:8080//ipa.initramfs', u'ipmi_password': u'******'} | 11:54 |
| *** bfournie has joined #openstack-ironic | 11:55 | |
| olivierb | nginx is up and listening on 8080 and reachable from IPA :_( | 11:56 |
| olivierb | introspection has worked (addition of extra field in Ironic DB with provisioning node characteristics was done properly) | 12:00 |
| *** gcb_ has joined #openstack-ironic | 12:01 | |
| *** e0ne has quit IRC | 12:03 | |
| jroll | morning folks | 12:09 |
| jroll | dtantsur|brb: not opposed to adding something to the topic, but IME most people don't read the topic | 12:11 |
| jroll | olivierb: ipa-url is generated from either keystone's service catalog or the endpoint_override thing, iirc | 12:12 |
| olivierb | please note also that exact same setup but with baremetal machine provisioning local KVM/libvirt VMs works great with same configuration | 12:12 |
| olivierb | endpoint_override = http://10.20.128.254:6385 | 12:12 |
| olivierb | with fix https://review.openstack.org/599612 due to keystone | 12:13 |
| patchbot | patch 599612 - bifrost - Fix Ironic configuration when Keystone enabled - 0h 17m 58s spent in CI | 12:13 |
| jroll | hmm | 12:13 |
| jroll | using ipxe I assume? | 12:13 |
| olivierb | jroll yes | 12:13 |
| jroll | there should be an ipxe script with the kernel parameters for IPA in /tftpboot somewhere | 12:13 |
| jroll | if you wanna check what is being passed for ipa-url | 12:14 |
| jroll | I wonder if it's just invalid somehow | 12:14 |
| olivierb | :introspect | 12:16 |
| olivierb | kernel http://10.20.128.254:8080/ipa.vmlinuz ipa-inspection-callback-url=http://10.20.128.254:5050/v1/continue systemd.journald.forward_to_console=yes ip=${ip}:${next-server}:${gateway}:${netmask} BOOTIF=${mac} | 12:16 |
| olivierb | nofb nomodeset vga=normal console=ttyS0 | 12:16 |
| olivierb | seems equivalent to my other working system (besides Ironic IP value of course) | 12:16 |
| jroll | olivierb: hm, that looks like it's still configured to boot up for inspection | 12:18 |
| jroll | er | 12:19 |
| jroll | can you put the whole script on paste.openstack.org? | 12:19 |
| *** e0ne has joined #openstack-ironic | 12:19 | |
| jroll | I think that's just the inspection part | 12:19 |
| olivierb | in fact it is the contents of /httpboot/pxelinux.cfg/default no other file is created with mac address like on the other system for next stage | 12:20 |
| jroll | hmm | 12:20 |
| jroll | wait, which state exactly is it in? | 12:21 |
| jroll | I see now "stuck in verifying" | 12:21 |
| olivierb | stuck verifying | 12:21 |
| jroll | I don't think validation/verify/whatever it's called boots IPA | 12:21 |
| jroll | oh it is called verifying, huh | 12:22 |
| jroll | so verifying is where we check that we can talk to the bmc | 12:22 |
| jroll | so feels like it must be hanging there, can your VM reach 10.20.118.1 for power control? | 12:23 |
| jroll | should be UDP port 623 IIRC | 12:23 |
| olivierb | oops, my bad did not see that, should not be 10.20.118.1, I now understand the issue, many thx jroll | 12:24 |
| jroll | \o/ | 12:24 |
| jroll | you're welcome :) | 12:24 |
| *** rh-jelabarre has quit IRC | 12:26 | |
| *** rh-jelabarre has joined #openstack-ironic | 12:26 | |
| TheJulia | dtantsur|brb: i like it enough to just do it. | 12:30 |
| *** edleafe has joined #openstack-ironic | 12:32 | |
| *** trown|outtypewww is now known as trown | 12:37 | |
| TheJulia | etingof: dtantsur|brb: What time in UTC do you guys tend to get your day started? | 12:49 |
| *** adrianc has joined #openstack-ironic | 13:06 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic-lib stable/queens: Make search for config drive partition case insensitive https://review.openstack.org/598607 | 13:13 |
| etingof | TheJulia, around 6am UTC on average | 13:15 |
| *** dtantsur|brb is now known as dtantsur | 13:17 | |
| dtantsur | morning TheJulia. 8-9am | 13:17 |
| dtantsur | also morning jroll | 13:17 |
| jroll | \o | 13:17 |
| openstackgerrit | Julia Kreger proposed openstack/ironic-lib stable/ocata: Make search for config drive partition case insensitive https://review.openstack.org/598609 | 13:19 |
| TheJulia | so I think I've tracked down our doc build issue | 13:20 |
| TheJulia | although to verify it, I'm having to update many of our docstrings | 13:20 |
| *** ChanServ changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75 | Contributors are generally present between 6 AM and 12 AM UTC, If we do not answer, please feel free to pose questions to openstack-dev mailing list." | 13:26 | |
| *** rloo has joined #openstack-ironic | 13:33 | |
| *** r-daneel has quit IRC | 13:34 | |
| TheJulia | This doc issue is making me sad | 13:42 |
| *** hjensas has quit IRC | 13:48 | |
| *** mjturek has joined #openstack-ironic | 13:57 | |
| *** d0ugal has quit IRC | 13:58 | |
| *** baha has joined #openstack-ironic | 14:04 | |
| *** jtomasek has quit IRC | 14:15 | |
| openstackgerrit | Merged openstack/ironic-lib stable/rocky: Make search for config drive partition case insensitive https://review.openstack.org/598606 | 14:21 |
| TheJulia | woot, I got docs to finally build | 14:22 |
| dtantsur | \o/ | 14:22 |
| *** dtantsur is now known as dtantsur|brb | 14:24 | |
| openstackgerrit | Michal Arbet proposed openstack/ironic master: Fix async keyword for Python 3.7 https://review.openstack.org/597468 | 14:31 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix doc builds for ironic https://review.openstack.org/600075 | 14:34 |
| TheJulia | ^^^^ builds locally without errors, as long as graphviz is installed | 14:35 |
| NobodyCam | Good Morning Ironic'ers | 14:35 |
| TheJulia | good morning NobodyCam | 14:36 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix doc builds for ironic https://review.openstack.org/600075 | 14:36 |
| NobodyCam | :) morning TheJulia :) | 14:36 |
| *** cdearborn has joined #openstack-ironic | 14:36 | |
| *** phuongnh has joined #openstack-ironic | 14:40 | |
| *** cdearborn has quit IRC | 14:42 | |
| *** cdearborn has joined #openstack-ironic | 14:44 | |
| *** d0ugal has joined #openstack-ironic | 14:57 | |
| *** r-daneel has joined #openstack-ironic | 14:59 | |
| openstackgerrit | Derek Higgins proposed openstack/ironic master: Switch ironic-tempest-dsvm-functional-python2 to zuulv3 https://review.openstack.org/600093 | 15:04 |
| openstackgerrit | Derek Higgins proposed openstack/ironic master: Switch ironic-tempest-dsvm-functional-python3 to zuulv3 https://review.openstack.org/600094 | 15:04 |
| openstackgerrit | Mark Goddard proposed openstack/ironic-specs master: Deploy Templates https://review.openstack.org/504952 | 15:09 |
| *** jtomasek has joined #openstack-ironic | 15:14 | |
| *** dsneddon has joined #openstack-ironic | 15:14 | |
| *** Bhujay has quit IRC | 15:18 | |
| *** gyee has joined #openstack-ironic | 15:22 | |
| *** pcaruana has quit IRC | 15:25 | |
| *** cdearborn has quit IRC | 15:30 | |
| *** skazi has joined #openstack-ironic | 15:33 | |
| *** tssurya has quit IRC | 15:36 | |
| *** spartakos has joined #openstack-ironic | 15:43 | |
| *** cdearborn has joined #openstack-ironic | 15:47 | |
| *** cdearborn has quit IRC | 15:56 | |
| *** dtantsur|brb is now known as dtantsur | 16:01 | |
| dtantsur | TheJulia: great! Just one thing: I'd prefer we used rst literal block instead of indentations from examples | 16:02 |
| dtantsur | e.g. in https://review.openstack.org/#/c/600075/2/ironic/common/cinder.py | 16:02 |
| patchbot | patch 600075 - ironic - Fix doc builds for ironic | 16:02 |
| *** phuongnh has quit IRC | 16:02 | |
| *** baha has quit IRC | 16:04 | |
| *** spartakos has quit IRC | 16:05 | |
| *** spartakos has joined #openstack-ironic | 16:06 | |
| TheJulia | dtantsur: I tried it, it didn't work. | 16:09 |
| TheJulia | I feel like I've gotten it to work before though :\ | 16:10 |
| dtantsur | TheJulia: that's curious, I'm pretty sure I did it before. how did it fail? | 16:10 |
| * dtantsur tries locally | 16:10 | |
| TheJulia | said the anticipated spacing is off. Problem is in many cases we're putting these things on return values or parameters, which is also handled differently string wise, afaik | 16:10 |
| dtantsur | TheJulia: yeah, but they all should support :: syntax. lemme try it locally | 16:12 |
| TheJulia | ++ | 16:13 |
| TheJulia | however the sphinx wsme extentions were processing, it was allowing it to tollerate quite a it :( | 16:13 |
| dtantsur | TheJulia: tried locally on cinder.py, and :: worked correctly for me with JSON rendering for the example | 16:14 |
| TheJulia | mind pushing that up so I can see exactly what you did? | 16:15 |
| dtantsur | maybe you're missing something? e.g. sphinx is sometimes picky about newlines after :: and initial indentation | 16:15 |
| TheJulia | that could entirely be it | 16:15 |
| dtantsur | yeah, lemme clean it up a bit | 16:15 |
| TheJulia | I noticed slightly different behavior with [ and { | 16:15 |
| *** bfournie has left #openstack-ironic | 16:15 | |
| *** bfournie has joined #openstack-ironic | 16:16 | |
| TheJulia | After banging my head against it for a couple of hours, is when I started stripping it all down. | 16:17 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Fix doc builds for ironic https://review.openstack.org/600075 | 16:21 |
| dtantsur | TheJulia: updated cinder.py with an example ^^^ | 16:21 |
| dtantsur | you need a new line and some indentation (even if one space) | 16:22 |
| *** jiapei has quit IRC | 16:22 | |
| TheJulia | yeah, that looks right. I don't even remember the variations I tried last night | 16:23 |
| dtantsur | I started liking sphinx less with time. too many ways to screw up indentation. | 16:23 |
| dtantsur | e.g. people constantly insert indentation that makes it render blockquotes | 16:23 |
| dtantsur | essentially, any indentation not after :: ends up being a blockquote. there is one in cinder.py. | 16:23 |
| *** dsneddon has quit IRC | 16:25 | |
| dtantsur | TheJulia: I can do the remaining files if you don't have spoons left for this patch | 16:27 |
| TheJulia | dtantsur: by all means | 16:27 |
| dtantsur | TheJulia: sorry, just to double-check my English: this means yes? | 16:27 |
| TheJulia | dtantsur: yes | 16:27 |
| * dtantsur is sometimes confused by such phrases | 16:27 | |
| TheJulia | and yes | 16:27 |
| TheJulia | :) | 16:28 |
| dtantsur | okie, TIL :) | 16:28 |
| openstackgerrit | Mark Goddard proposed openstack/ironic-specs master: Deploy Templates https://review.openstack.org/504952 | 16:28 |
| TheJulia | \o/ | 16:29 |
| dtantsur | mmm, templates! | 16:29 |
| *** bfournie has quit IRC | 16:29 | |
| jroll | TheJulia: our secureboot driver thing is finally public. still a little hacky (POC status) but it does work: https://github.com/yahoo/ironic-secureboot-driver/blob/master/ironic_secureboot_driver/driver.py | 16:35 |
| jroll | still working on writing something I can make public to go with it, but the readme has some hand wavy details | 16:36 |
| *** mgoddard has quit IRC | 16:36 | |
| dtantsur | mmm, long read for tomorrow morning :) | 16:36 |
| dtantsur | thanks jroll | 16:36 |
| jroll | dtantsur: it's pretty short, tbh :) | 16:36 |
| jroll | lots of boilerplate | 16:37 |
| dtantsur | jroll: yeah, but I'm fixing docs, then it will be 7pm :) | 16:37 |
| jroll | heh, fair enough | 16:37 |
| * TheJulia is really starting to enjoy the back and forth on locking with mgoddard | 16:42 | |
| *** olivierb has quit IRC | 16:44 | |
| *** baha has joined #openstack-ironic | 16:45 | |
| dtantsur | ooook, sphinx really decided to piss me off today | 16:51 |
| * dtantsur feels sorry for TheJulia even more now | 16:51 | |
| TheJulia | lol | 16:54 |
| * dtantsur tries to guess which form works for :returns: | 16:54 | |
| dtantsur | sphinx:dmitry 4:0 so far :( | 16:54 |
| TheJulia | standard wise it is :returns: string | 16:54 |
| dtantsur | yeah, now this :: beast... | 16:55 |
| dtantsur | 5:0 | 16:55 |
| TheJulia | Yeah, I think those are incompatible :\ | 16:55 |
| TheJulia | maybe it was a return that I started on which is why I got so frustrated last night | 16:55 |
| dtantsur | meh, I'll try a few more ideas | 16:56 |
| dtantsur | :param: seem quite straightforward | 16:56 |
| TheJulia | :param name: string or :param name type: string | 16:58 |
| * TheJulia had it up on her screen last night | 16:58 | |
| *** dougsz_ has quit IRC | 16:58 | |
| *** derekh has quit IRC | 17:00 | |
| TheJulia | dtantsur: if you have a moment, could you take a quick look at https://review.openstack.org/#/c/598607/2 | 17:01 |
| patchbot | patch 598607 - ironic-lib (stable/queens) - Make search for config drive partition case insens... - 1h 52m 55s spent in CI | 17:01 |
| *** bfournie has joined #openstack-ironic | 17:01 | |
| TheJulia | my minor fix passed ci, I've already +2'ed it, but since I uploaded the revised changeset | 17:02 |
| *** e0ne has quit IRC | 17:02 | |
| dtantsur | TheJulia: okay, I give up. my next idea is to move the block into the docstring body, leaving a short :returns: section | 17:05 |
| *** S4ren has quit IRC | 17:06 | |
| TheJulia | dtantsur: yeah... I didn't actually look at what got rendered for the drac driver | 17:07 |
| *** trown is now known as trown|lunch | 17:09 | |
| *** dsneddon has joined #openstack-ironic | 17:10 | |
| dtantsur | well, without :: everything renders on one line as text | 17:11 |
| TheJulia | Yeah, and I think that is partially how the design is supposed to work, we've just slightly abused it | 17:13 |
| * TheJulia pulls the existing docs to look at how they were rendered | 17:14 | |
| *** adrianc has quit IRC | 17:14 | |
| TheJulia | https://docs.openstack.org/ironic/latest/contributor/api/ironic.drivers.modules.drac.common.html | 17:15 |
| TheJulia | anything is better than nothing :( | 17:15 |
| *** dsneddon has quit IRC | 17:15 | |
| *** dsneddon has joined #openstack-ironic | 17:18 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Fix doc builds for ironic https://review.openstack.org/600075 | 17:25 |
| dtantsur | TheJulia: I call this ^^^ a moderate success :) | 17:25 |
| dtantsur | but that sphinx... would be easier to write docs in haskell | 17:26 |
| *** dtantsur is now known as dtantsur|afk | 17:26 | |
| dtantsur|afk | see y'all | 17:26 |
| openstackgerrit | Corey Wright proposed openstack/ironic-python-agent master: Allow erasing metadata from disk partitions https://review.openstack.org/600139 | 17:30 |
| *** olivierb has joined #openstack-ironic | 17:31 | |
| *** olivierb has quit IRC | 17:38 | |
| *** hjensas has joined #openstack-ironic | 17:39 | |
| *** pcaruana has joined #openstack-ironic | 17:52 | |
| *** openstackgerrit has quit IRC | 18:00 | |
| *** dsneddon has quit IRC | 18:01 | |
| *** dsneddon has joined #openstack-ironic | 18:01 | |
| TheJulia | hmmm | 18:07 |
| *** spartakos has quit IRC | 18:09 | |
| *** d0ugal has quit IRC | 18:10 | |
| *** openstackgerrit has joined #openstack-ironic | 18:10 | |
| openstackgerrit | Merged openstack/ironic-lib stable/queens: Make search for config drive partition case insensitive https://review.openstack.org/598607 | 18:10 |
| *** trown|lunch is now known as trown | 18:17 | |
| *** e0ne has joined #openstack-ironic | 18:18 | |
| *** patchbot has quit IRC | 18:32 | |
| *** patchbot has joined #openstack-ironic | 18:32 | |
| *** priteau has quit IRC | 18:35 | |
| *** priteau has joined #openstack-ironic | 18:36 | |
| *** patchbot has quit IRC | 18:37 | |
| *** patchbot has joined #openstack-ironic | 18:37 | |
| *** spartakos has joined #openstack-ironic | 18:38 | |
| *** spartakos has quit IRC | 18:39 | |
| *** spartakos has joined #openstack-ironic | 18:40 | |
| *** dhellmann has left #openstack-ironic | 18:41 | |
| mgagne | I had a question on #openstack-nova about how Nova API behaves when you try to hotplug an interface to a node which has a "flat" network. And I found that it would return a 500 error. The Ironic API would return a 400 with a specific error message but Nova just can't tell what kind of 400 error it is and just translate it to "failed to attach interface" which gets translated to "server error". | 18:46 |
| mgagne | so what would be the best way for Ironic (and Nova) to properly communicate *how* the attach_interface failed and properly translate to a 400 on the Nova API side? | 18:47 |
| mgagne | someone suggested introducing error code in the error response. But it's only a theoretical idea that we discussed in Vancouver. | 18:48 |
| TheJulia | Core reviewers: https://review.openstack.org/#/c/600075/ should be a fairly quick fix to the gate. | 18:50 |
| patchbot | patch 600075 - ironic - Fix doc builds for ironic - 4 patch sets | 18:50 |
| TheJulia | mgagne: so the instance is deployed, and the desire is to support hotplug of a vif? | 18:51 |
| * TheJulia tries to remember if there is a reason we just don't permit it other than microversions | 18:52 | |
| mgagne | TheJulia: in theory, this is already supported. If you have trunk network, you can attach as much virtual interfaces as you want. Now if you have a flat network, you can't attach more virtual interfaces than physical interfaces. | 18:52 |
| mgagne | TheJulia: my concern is with the UX in Nova API when you try to hotplug a new port (virtual interface) to an Ironic node which already has all its physical ports used and attached. | 18:53 |
| TheJulia | seems like if there are no available ports we should be responding with insufficent resources to complete the request | 18:54 |
| mgagne | Ironic will return a 400 and an error message: "Unable to attach VIF %(vif)s, not enough free physical ports." | 18:54 |
| mgagne | but Nova will just translate that to "Server error" which isn't cool for the user. | 18:54 |
| *** e0ne has quit IRC | 18:54 | |
| mgagne | does such http code exist? | 18:56 |
| TheJulia | I believe so, one moment | 18:56 |
| TheJulia | hmm | 18:56 |
| mgagne | eitherway, I don't feel http code along has enough granularity to fully express the nature of the error without requiring the http client to parse the response body. | 18:58 |
| mgagne | we would parse the error message but I think it can be translated and therefore we can't fully rely on the message to be in English. | 18:59 |
| TheJulia | 507 is insufficent storage | 18:59 |
| TheJulia | not exactly the same | 19:00 |
| mgagne | and a server side error | 19:00 |
| TheJulia | yeah, well in a sense it kind of is | 19:00 |
| TheJulia | server can't support the request | 19:00 |
| TheJulia | I _think_ errors are supposed to remain untranslated but yeah :\ | 19:02 |
| mgagne | they are all wrapped with _() | 19:02 |
| *** r-daneel has quit IRC | 19:03 | |
| TheJulia | 402 would be funny | 19:04 |
| mgagne | yea, I suggested that in nova channel :P | 19:04 |
| *** jtomasek has quit IRC | 19:04 | |
| mgagne | I think it should be 400. here is a similar exception: https://github.com/openstack/ironic/blob/master/ironic/common/exception.py#L479-L481 | 19:04 |
| *** r-daneel has joined #openstack-ironic | 19:05 | |
| TheJulia | 409 is a conflict in the current state in the resource | 19:06 |
| mgagne | so anyway, the challenge so far is that Nova can't really tell *why* the attach interface failed without parsing the error message. | 19:06 |
| mgagne | which is currently 400 https://github.com/openstack/ironic/blob/master/ironic/common/exception.py#L235-L237 | 19:06 |
| TheJulia | with a microversion bump we could return a 409 I think | 19:08 |
| TheJulia | to indicate that there is a conflict with the addition of a vif | 19:08 |
| jroll | well, we return 409 for other reasons too, I'm not sure that is sufficient to tell | 19:08 |
| mgagne | I think 409 is reserved for PUT request which generates conflicts | 19:09 |
| jroll | I'm not sure there's much we can do other than pick up the "API error codes" thing, get that done, and make an error code for this | 19:09 |
| jroll | mgagne: yeah, we use it for locked resources and such too | 19:09 |
| TheJulia | yeah, which I think is partially why we backed out some 409s like 2 years ago | 19:09 |
| mgagne | ok so: not much that can be done in the short/mid term unless someone invests time. that's fine. | 19:12 |
| mgagne | unfortunately I can't invest time at the moment. If it was a much smaller change, that would have been fine. ¯\_(ツ)_/¯ | 19:15 |
| TheJulia | pretty much, returning the a different code microversion seems moderately reasonable and kind of a light lift | 19:16 |
| *** e0ne has joined #openstack-ironic | 19:18 | |
| TheJulia | now I'm remembering the api error codes stuff | 19:18 |
| TheJulia | that.... yeah, is not a light lift | 19:18 |
| jroll | :) | 19:18 |
| *** arne_wiebalck_ has joined #openstack-ironic | 19:19 | |
| mgagne | yea, from #openstack-nova: http://specs.openstack.org/openstack/api-wg/guidelines/errors.html | 19:20 |
| *** d0ugal has joined #openstack-ironic | 19:33 | |
| *** ijw has joined #openstack-ironic | 19:37 | |
| *** d0ugal has quit IRC | 19:37 | |
| openstackgerrit | Merged openstack/ironic-lib stable/pike: Make search for config drive partition case insensitive https://review.openstack.org/598608 | 19:44 |
| *** jcoufal has joined #openstack-ironic | 19:47 | |
| *** r-daneel_ has joined #openstack-ironic | 19:48 | |
| *** r-daneel has quit IRC | 19:49 | |
| *** r-daneel_ is now known as r-daneel | 19:49 | |
| *** ijw has quit IRC | 19:49 | |
| *** ijw has joined #openstack-ironic | 20:05 | |
| *** arne_wiebalck_ has quit IRC | 20:06 | |
| *** jcoufal has quit IRC | 20:07 | |
| *** e0ne has quit IRC | 20:08 | |
| *** arne_wiebalck_ has joined #openstack-ironic | 20:17 | |
| *** mbeierl has quit IRC | 20:17 | |
| *** mbeierl has joined #openstack-ironic | 20:19 | |
| *** cdearborn has joined #openstack-ironic | 20:24 | |
| *** arne_wiebalck_ has quit IRC | 20:33 | |
| *** pcaruana has quit IRC | 20:40 | |
| *** rloo has quit IRC | 20:57 | |
| *** rloo has joined #openstack-ironic | 20:57 | |
| *** arne_wiebalck_ has joined #openstack-ironic | 21:01 | |
| *** arne_wiebalck_ has quit IRC | 21:02 | |
| *** trown is now known as trown|outtypewww | 21:03 | |
| *** r-daneel has quit IRC | 21:09 | |
| *** baha has quit IRC | 21:17 | |
| *** jesusaur has quit IRC | 21:22 | |
| *** jesusaur has joined #openstack-ironic | 21:22 | |
| *** r-daneel has joined #openstack-ironic | 21:24 | |
| *** cdearborn has quit IRC | 21:24 | |
| *** priteau has quit IRC | 21:56 | |
| *** rloo has quit IRC | 21:58 | |
| *** rloo has joined #openstack-ironic | 21:58 | |
| *** ijw has quit IRC | 22:15 | |
| *** rloo has quit IRC | 22:17 | |
| *** rloo has joined #openstack-ironic | 22:17 | |
| *** rh-jelabarre has quit IRC | 22:22 | |
| *** rcernin has joined #openstack-ironic | 22:43 | |
| *** r-daneel has quit IRC | 22:45 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: ipxe boot interface - begin the process https://review.openstack.org/583407 | 23:09 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: pxe/ipxe: Move common calls out pxe.py https://review.openstack.org/600276 | 23:09 |
| *** ijw has joined #openstack-ironic | 23:16 | |
| openstackgerrit | Merged openstack/ironic master: Fix doc builds for ironic https://review.openstack.org/600075 | 23:20 |
| *** ijw has quit IRC | 23:22 | |
| *** r-daneel has joined #openstack-ironic | 23:37 | |
| *** ijw has joined #openstack-ironic | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!