| *** gyee has quit IRC | 00:14 | |
| *** ElCoyote_ has quit IRC | 00:31 | |
| *** trungnv has quit IRC | 00:35 | |
| *** sai_p_ has quit IRC | 00:36 | |
| *** ElCoyote_ has joined #openstack-ironic | 00:47 | |
| *** bfournie has joined #openstack-ironic | 00:51 | |
| *** dtrainor has quit IRC | 01:04 | |
| *** dtrainor has joined #openstack-ironic | 01:05 | |
| *** dtrainor has quit IRC | 01:24 | |
| jiapei | Good morning Ironicers | 01:31 |
|---|---|---|
| *** tiendc has joined #openstack-ironic | 01:33 | |
| *** MattMan_ has quit IRC | 01:47 | |
| *** MattMan_ has joined #openstack-ironic | 01:48 | |
| *** openstackgerrit has joined #openstack-ironic | 02:19 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: [WIP] Migration step to update objects to latest version https://review.openstack.org/613181 | 02:19 |
| rloo | dtantsur|afk: ^^ sorry, i didn't have a chance to work on it; that's what I'm thinking. Haven't tested it at all. Will touch base with you tomorrow. | 02:20 |
| *** rloo has quit IRC | 02:21 | |
| *** munimeha1 has quit IRC | 02:30 | |
| *** dtrainor has joined #openstack-ironic | 02:42 | |
| *** jesusaur has joined #openstack-ironic | 03:21 | |
| *** jaganathan has quit IRC | 03:58 | |
| *** skazi has quit IRC | 04:36 | |
| openstackgerrit | Tuan Do Anh proposed openstack/ironic master: Add download link apache configuration with mod_wsgi https://review.openstack.org/611497 | 04:48 |
| *** jaganathan has joined #openstack-ironic | 05:10 | |
| openstackgerrit | Debayan Ray proposed openstack/sushy master: Follow-up to 27c725c to move up ``cache_clear`` https://review.openstack.org/613197 | 05:28 |
| *** skazi has joined #openstack-ironic | 05:34 | |
| *** skazi has quit IRC | 05:34 | |
| *** adrianc has joined #openstack-ironic | 05:53 | |
| *** jaganathan has quit IRC | 06:09 | |
| *** moshele has joined #openstack-ironic | 06:22 | |
| *** jaganathan has joined #openstack-ironic | 06:27 | |
| openstackgerrit | Merged openstack/ironic master: Fix DHCPv6 support https://review.openstack.org/611600 | 06:29 |
| openstackgerrit | Kaifeng Wang proposed openstack/python-ironic-inspector-client master: [DNM/TEST] Zuul migration https://review.openstack.org/613216 | 06:56 |
| *** rcernin has quit IRC | 07:00 | |
| *** pcaruana has joined #openstack-ironic | 07:04 | |
| iurygregory | good morning all | 07:04 |
| jiapei | o/ morning iurygregory | 07:07 |
| iurygregory | \o | 07:07 |
| *** SpamapS has quit IRC | 07:11 | |
| etingof | good morning iurygregory & jiapei o/ | 07:21 |
| iurygregory | \o | 07:21 |
| jiapei | morning etingof o/ | 07:21 |
| *** SpamapS has joined #openstack-ironic | 07:24 | |
| *** hjensas has quit IRC | 07:24 | |
| *** yolanda has joined #openstack-ironic | 07:24 | |
| arne_wiebalck | Good morning, Ironic! | 07:26 |
| arne_wiebalck | rloo dtantsur: When preparing the upgrade from Q to R, we ran into a situation where 'db-sync upgrade' on R failed due to the object versions, but 'db-sync online_data_migrations' on Q did not find anything to migrate. FWIU, https://review.openstack.org/#/c/613181/ is supposed to fix exactly this? | 07:26 |
| patchbot | patch 613181 - ironic - [WIP] Migration step to update objects to latest v... - 1 patch set | 07:26 |
| openstackgerrit | Debayan Ray proposed openstack/sushy master: Follow-up to 27c725c to move up ``cache_clear`` https://review.openstack.org/613197 | 07:28 |
| *** hjensas has joined #openstack-ironic | 07:28 | |
| *** Emine has joined #openstack-ironic | 07:46 | |
| *** serlex has joined #openstack-ironic | 07:58 | |
| *** dougsz has joined #openstack-ironic | 08:10 | |
| *** moshele has quit IRC | 08:14 | |
| openstackgerrit | Kaifeng Wang proposed openstack/python-ironic-inspector-client master: [DNM/TEST] Zuul migration https://review.openstack.org/613216 | 08:29 |
| *** e0ne has joined #openstack-ironic | 08:42 | |
| *** stendulker has joined #openstack-ironic | 08:52 | |
| *** stendulker has quit IRC | 08:58 | |
| *** hkominos has joined #openstack-ironic | 09:05 | |
| *** dtantsur|afk is now known as dtantsur | 09:09 | |
| dtantsur | morning ironic | 09:09 |
| dtantsur | arne_wiebalck: yeah, it sounds like the same problem | 09:09 |
| iurygregory | morning dtantsur | 09:12 |
| *** jaganathan has quit IRC | 09:17 | |
| arne_wiebalck | dtantsur: thx. We moved forward by setting the versions in the DB directly. | 09:23 |
| dtantsur | sigh | 09:24 |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Refactor tests to pass without dependencies https://review.openstack.org/611859 | 09:29 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Migration step to update objects to latest version https://review.openstack.org/613181 | 09:31 |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Make external dependencies optional https://review.openstack.org/611859 | 09:35 |
| *** derekh has joined #openstack-ironic | 09:39 | |
| *** adrianc has quit IRC | 09:46 | |
| *** adrianc has joined #openstack-ironic | 09:51 | |
| *** jaganathan has joined #openstack-ironic | 10:25 | |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Make external dependencies optional https://review.openstack.org/611859 | 10:30 |
| *** stendulker has joined #openstack-ironic | 10:32 | |
| *** Emine has quit IRC | 10:38 | |
| *** Emine has joined #openstack-ironic | 10:39 | |
| *** moshele has joined #openstack-ironic | 11:04 | |
| *** stendulker has quit IRC | 11:25 | |
| *** rh-jelabarre has joined #openstack-ironic | 11:34 | |
| openstackgerrit | wanghui proposed openstack/ironic-specs master: Update tox minversion to 2.0 https://review.openstack.org/613281 | 11:35 |
| *** jesusaur has quit IRC | 11:43 | |
| *** jesusaur has joined #openstack-ironic | 11:46 | |
| *** dnuka has joined #openstack-ironic | 11:53 | |
| openstackgerrit | Digambar proposed openstack/ironic master: Fix CPU count returned by introspection in Ironic iDRAC driver https://review.openstack.org/609982 | 12:02 |
| *** jistr_ is now known as jistr | 12:14 | |
| *** dnuka has quit IRC | 12:16 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-tempest-plugin master: Add API tests for protected nodes https://review.openstack.org/613014 | 12:20 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Migration step to update objects to latest version https://review.openstack.org/613181 | 12:24 |
| *** pcaruana has quit IRC | 12:26 | |
| *** S4ren has joined #openstack-ironic | 12:30 | |
| *** pcaruana has joined #openstack-ironic | 12:39 | |
| dtantsur | etingof: hey, what's the current state of the sushy fix? do we have something final? | 12:42 |
| etingof | dtantsur, here is the latest take -- https://review.openstack.org/#/c/613062/ | 12:43 |
| patchbot | patch 613062 - sushy - Allow HTTP session info to be set on authenticator - 2 patch sets | 12:43 |
| etingof | dtantsur, used by this -- https://review.openstack.org/#/c/605408/ | 12:44 |
| patchbot | patch 605408 - ironic - Reuse Redfish session tokens - 11 patch sets | 12:44 |
| dtantsur | etingof: this is not backportable | 12:44 |
| dtantsur | can we please start with caching Sushy objects and then dive into micro-optimizing it? | 12:45 |
| dtantsur | I'm quite worried about not fixing the problem for Queens and Rocky | 12:45 |
| etingof | dtantsur, could we get away with just disabling session auth there? -- https://review.openstack.org/#/c/603818/ | 12:46 |
| patchbot | patch 603818 - ironic - Add configurable Redfish client authentication - 15 patch sets | 12:46 |
| dtantsur | etingof: and get a feature regression? what about hardware that does not support basic auth? | 12:48 |
| dtantsur | maybe the fix we need right now is simply to close any sessions we open. then think about caching and stuff. | 12:49 |
| *** jcoufal has joined #openstack-ironic | 12:50 | |
| dtantsur | TheJulia: I suggest we move on with the sushy release. figuring this ^^ out is definitely going to take more time. | 12:51 |
| etingof | dtantsur, so when somebody has issues with session exhaustion at their BMC, they can switch to basic auth via configuration option | 12:53 |
| *** rloo has joined #openstack-ironic | 12:53 | |
| dtantsur | etingof: on master - yes | 12:53 |
| etingof | dtantsur, if the BMC suffers from session exhaustion and it does not support basic auth, then that fix ^ won't help indeed | 12:54 |
| * etingof is not sure if that qualifies as feature regression | 12:55 | |
| dtantsur | well, it's definitely a bug, and a quite serious one :) | 12:55 |
| dtantsur | also, I'm not entirely sure that all hardware that requires session auth will support basic auth | 12:55 |
| etingof | because in the worst case the above fix does not help, but all the features are still there | 12:56 |
| dtantsur | this seems not quite intuitive | 12:56 |
| *** bnemec has joined #openstack-ironic | 12:56 | |
| dtantsur | etingof: actually the commit message explicitly answers my question: https://github.com/openstack/sushy/commit/9610c06a179be10b19939b4285f23657b2925245 | 12:56 |
| etingof | on the other hand, using session for just one API call sort of undermines the purpose of sessions... | 12:56 |
| dtantsur | right, yeah. we need to cache them, we just need to find a way to do it without adding features to the library | 12:57 |
| etingof | dtantsur, that's where we have started more or less - messing with private attributes of sushy authenticator (IIRC) | 12:58 |
| dtantsur | sigh | 12:58 |
| etingof | anyway, let's do immediate close | 12:58 |
| etingof | that should not require sushy changes | 12:58 |
| dtantsur | ... or we could cache Sushy objects.... | 12:58 |
| etingof | I am afraid of this doubly independent caching we'd create | 12:59 |
| etingof | e.g. we cache auth, urllib caches connections | 12:59 |
| dtantsur | this sounds much less problematic to me than other solutions | 13:00 |
| dtantsur | on the other hand, closing sessions + caching sounds like a can of worms | 13:01 |
| etingof | that's what I fair if we talk about caching the entire sushy connection | 13:02 |
| dtantsur | if we talk about caching anything | 13:03 |
| dtantsur | we need a way to make sure that a session we close is not used by anything right now | 13:03 |
| etingof | also, we cache request objects that might change pooling behavior in the future potentially colliding with our higher-level caching logic | 13:04 |
| dtantsur | in what way? | 13:05 |
| etingof | I am thinking of leaks here | 13:06 |
| etingof | since we keep a ref to the whole sushy->requests->urllib->socket chain | 13:06 |
| etingof | we manage it at the sushy level while requests manage its own cache of the rest independently | 13:07 |
| etingof | perhaps the worst thing could be that requests frees up its stuff while we still hold everything in memory | 13:08 |
| dtantsur | etingof: if requests frees up stuff, it's responsible for recreating it or whatever | 13:09 |
| dtantsur | encapsulations \o/ | 13:09 |
| dtantsur | :) | 13:09 |
| rloo | Good morning ironickers, etingof, dtantsur | 13:10 |
| hkominos | morning all. I need a quick top regarding grub. I have setup a grub.cfg file as defined here. https://docs.openstack.org/ironic/rocky/install/configure-pxe.html. However when the boards boots I am forwarded to a grub menu which does not define any kernel/initrd to boot from. It is basically a text copy of what I have in my grub.cfg | 13:10 |
| etingof | rloo, o/ | 13:10 |
| dtantsur | morning rloo | 13:10 |
| dtantsur | rloo: did you few updates to your patch, I hope you do not mind | 13:10 |
| rloo | morning hkominos | 13:10 |
| rloo | dtantsur: i don't mind at all. wanted to you if you wanted to take over :) | 13:10 |
| hkominos | rloo: Good morning to you | 13:10 |
| rloo | dtantsur: i hate writing unit tests etc. but i can continue. probably should. | 13:11 |
| etingof | dtantsur, requests will recreate stuff, trouble is that if we still hold something in memory (sockets, whatever) we may exhaust something (memory, sockets) | 13:11 |
| rloo | dtantsur: anyway, wanted to give you a chance to have some glory too, if you wanted ;) | 13:11 |
| dtantsur | rloo: I can take it over, but I may not have enough time today (meetings! excitement!!) | 13:11 |
| hkominos | (i.e. configfile /var/lib/tftpboot/$net_default_mac.conf this is what I see in my grub menu ) | 13:11 |
| dtantsur | etingof: this sounds like the smallest of our problems :) | 13:11 |
| rloo | dtantsur: ok, we can tag team. i'll see how much i can get done today, then will pass to you. | 13:11 |
| dtantsur | ++ great plan | 13:12 |
| etingof | dtantsur, I am not sure, if we care about the scale... | 13:12 |
| dtantsur | etingof: if you care about this issue, you have to measure it. my gut feeling is that it's minor compared to other things we do. | 13:13 |
| dtantsur | now, failing redfish deployment because of session problems IS a real problem | 13:13 |
| etingof | dtantsur, so to summarize: my gut feeling is that by caching sushy sessions we introduce a risk of resource leaks sooner or later | 13:14 |
| etingof | dtantsur, but I can change the patch into caching the entire sushy session to get this done | 13:14 |
| dtantsur | I'd like a better idea, but other ideas don't look necessary better | 13:15 |
| *** jistr is now known as jistr|call | 13:29 | |
| *** rnoriega has quit IRC | 13:31 | |
| *** d0ugal has quit IRC | 13:33 | |
| *** d0ugal has joined #openstack-ironic | 13:34 | |
| TheJulia | the database migration fix basically lgtm, just needs a release note I think | 13:36 |
| *** pcaruana has quit IRC | 13:37 | |
| dtantsur | yeah, and unit tests | 13:37 |
| TheJulia | yeah | 13:37 |
| * TheJulia is still sipping coffee | 13:37 | |
| dtantsur | also good morning | 13:37 |
| etingof | enjoy your coffee, TheJulia! o/ | 13:37 |
| *** rnoriega has joined #openstack-ironic | 13:38 | |
| etingof | actually, if we cache the entire sushy sessions I am not sure we could invalidate the sessions we'd like to close... because sushy does not do that by itself -- https://github.com/openstack/sushy/blob/master/sushy/auth.py#L191 | 13:40 |
| dtantsur | etingof: I really don't know what to do with session invalidation.. if we cache anything, it will be racy. | 13:40 |
| dtantsur | don't we have something like Sushy.close that also calls self._auth.close? | 13:41 |
| etingof | dtantsur, the thing is that we can't easily tell BMC - "please, forget this session" | 13:41 |
| etingof | dtantsur, I do not see that .close() call -- https://github.com/openstack/sushy/search?q=close&unscoped_q=close | 13:42 |
| dtantsur | meh | 13:42 |
| etingof | dtantsur, still, if we start reusing sessions, we would be less aggressive wrt requesting new sessions | 13:43 |
| dtantsur | we should reuse sessions, yes | 13:43 |
| etingof | but never close at BMC atm | 13:43 |
| dtantsur | so, we cannot even fix it in a simple way by closing sushy objects right after opening? this is.. bad.. | 13:44 |
| dtantsur | something we can fix is close auth/connector in __del__ (yes, I know, __del__..) | 13:44 |
| etingof | conductor restart may cause more pressure to BMC sessions | 13:44 |
| TheJulia | wow https://review.openstack.org/#/c/613169/ got really far all things considered | 13:44 |
| patchbot | patch 613169 - ironic - WIP: ipv6 ipxe BFV?!? - 2 patch sets | 13:44 |
| TheJulia | Am I crazy? | 13:44 |
| etingof | dtantsur, do you mean introducing sushy.close() calling auth.close() ? | 13:45 |
| dtantsur | etingof: we probably need to do it, but again - not backportable | 13:45 |
| etingof | dtantsur, yes, so the only option is to reuse sessions but never close them at BMC for the time being | 13:46 |
| dtantsur | right | 13:46 |
| etingof | ...or mess with sushy internals | 13:46 |
| etingof | pulling .close() from there | 13:47 |
| *** jezogwza has joined #openstack-ironic | 13:47 | |
| etingof | I mean at runtime | 13:47 |
| *** mjturek has joined #openstack-ironic | 13:48 | |
| *** jcoufal has quit IRC | 13:48 | |
| *** baha has joined #openstack-ironic | 13:49 | |
| *** d0ugal has quit IRC | 13:49 | |
| etingof | ...I wonder if Sushy.__del__ would work given the cyclic connector<->authenticator reference it holds... | 13:50 |
| dtantsur | depends on how we implement it. we can break the cycle | 13:51 |
| *** jcoufal has joined #openstack-ironic | 13:51 | |
| *** homegrown has left #openstack-ironic | 13:51 | |
| *** rpittau has quit IRC | 13:52 | |
| etingof | so the call flow would be like this: GC calls Sushy.__del__ which calls auth.close() which runs HTTP DELETE against BMC. if that all goes well we could unset connector from auth (in a hacky way atm) | 13:55 |
| etingof | feels shaky because it's __del__ | 13:56 |
| dtantsur | yeah | 13:56 |
| *** skazi has joined #openstack-ironic | 13:56 | |
| *** skazi has quit IRC | 13:56 | |
| dtantsur | on the other hand, leaving dangling sessions after Sushy deletion is also bad | 13:56 |
| dtantsur | so we need __del__ and close(), __del__ calling close() | 13:56 |
| dtantsur | then in ironic we rely on __del__ for the backportable part | 13:56 |
| dtantsur | then we can switch to close() for master | 13:56 |
| etingof | so is that what I've just described? ^ | 13:57 |
| dtantsur | I think yes | 13:57 |
| etingof | then we need to wait with sushy release a bit ;) | 13:58 |
| *** mjturek has quit IRC | 13:59 | |
| dtantsur | okay, asked them to wait till early next week | 14:00 |
| etingof | ack, thanks! | 14:01 |
| *** mjturek has joined #openstack-ironic | 14:07 | |
| mjturek | gm ironic | 14:08 |
| TheJulia | good morning mjturek | 14:19 |
| *** moshele has quit IRC | 14:29 | |
| etingof | debugging unittest mocks deprive my mind of happiness | 14:31 |
| TheJulia | There are mocks that do the reverse at times :) | 14:33 |
| TheJulia | just please don't mock 3+ layers down... :( | 14:33 |
| TheJulia | lots of our pxe tests are that way | 14:33 |
| etingof | these unhappy mocks are exactly 3-store mocks | 14:34 |
| dtantsur | heh | 14:35 |
| * etingof now seeks happiness in coffee | 14:35 | |
| -openstackstatus- NOTICE: Zuul and Nodepool services are being restarted to migrate them to a new Zookeeper cluster. THis brings us an HA database running on newer servers. | 14:39 | |
| TheJulia | wheeeee | 14:41 |
| *** munimeha1 has joined #openstack-ironic | 14:42 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Support for protecting nodes from undeploying and rebuilding https://review.openstack.org/611662 | 14:43 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-tempest-plugin master: Add API tests for protected nodes https://review.openstack.org/613014 | 14:44 |
| *** tiendc has quit IRC | 14:45 | |
| *** jistr|call is now known as jistr | 14:50 | |
| *** jtomasek has quit IRC | 15:01 | |
| *** hkominos has quit IRC | 15:11 | |
| -openstackstatus- NOTICE: The Zuul and Nodepool database transition is complete. Changes updated during the Zuul outage may need to be rechecked. | 15:31 | |
| *** jaganathan has quit IRC | 15:32 | |
| *** mjturek has quit IRC | 15:34 | |
| *** mjturek has joined #openstack-ironic | 15:40 | |
| NobodyCam | Good Morning Ironic'ers | 15:47 |
| *** derekh has quit IRC | 15:58 | |
| *** e0ne has quit IRC | 15:59 | |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Add memoization to emulator connections https://review.openstack.org/612758 | 16:14 |
| *** gyee has joined #openstack-ironic | 16:16 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP: ipv6 ipxe BFV?!? https://review.openstack.org/613169 | 16:18 |
| * TheJulia crosses her fingers | 16:18 | |
| *** emine__ has joined #openstack-ironic | 16:21 | |
| *** dtantsur is now known as dtantsur|afk | 16:22 | |
| dtantsur|afk | see you | 16:22 |
| NobodyCam | night dtantsur|afk | 16:24 |
| *** Emine has quit IRC | 16:24 | |
| *** jhesketh has joined #openstack-ironic | 16:25 | |
| TheJulia | xclarity logs \o/ http://lxca-logs.electronicjungle.net/62/611662/5/check/lenovo-xclarity-ironic/32a9fc0/ | 16:26 |
| TheJulia | goodnight dtantsur|afk | 16:26 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Cleanup of remaining pxe focused is_ipxe_enabled https://review.openstack.org/611933 | 16:27 |
| *** jhesketh_ has quit IRC | 16:27 | |
| rpioso | Good afternoon | 16:27 |
| *** S4ren has quit IRC | 16:29 | |
| TheJulia | I'm sure arne_wiebalck would be happy if https://review.openstack.org/#/c/592639 got reviews #NotSubtle | 16:31 |
| patchbot | patch 592639 - ironic-python-agent - Fix multi-device behavior - 5 patch sets | 16:31 |
| *** trown is now known as trown|lunch | 16:32 | |
| *** mjturek has quit IRC | 16:40 | |
| *** mjturek has joined #openstack-ironic | 16:49 | |
| *** adrianc_ has joined #openstack-ironic | 16:52 | |
| *** moshele has joined #openstack-ironic | 16:55 | |
| *** adrianc has quit IRC | 16:55 | |
| *** adrianc_ has quit IRC | 16:57 | |
| *** pcaruana has joined #openstack-ironic | 17:03 | |
| *** dougsz has quit IRC | 17:03 | |
| *** moshele has quit IRC | 17:15 | |
| openstackgerrit | Bill Dodd proposed openstack/ironic master: WIP: Add BIOS interface to Redfish hardware type https://review.openstack.org/582314 | 17:26 |
| *** skazi has joined #openstack-ironic | 17:35 | |
| *** mjturek has quit IRC | 17:36 | |
| *** trown|lunch is now known as trown | 17:54 | |
| *** betherly has joined #openstack-ironic | 17:55 | |
| *** mbeierl has quit IRC | 17:58 | |
| *** zzzeek_ has joined #openstack-ironic | 17:59 | |
| *** mbeierl has joined #openstack-ironic | 17:59 | |
| *** betherly has quit IRC | 17:59 | |
| *** serlex has quit IRC | 18:14 | |
| *** bnemec has quit IRC | 18:29 | |
| TheJulia | bdodd: nice, I put some comments in | 18:35 |
| bdodd | Thanks TheJulia - I'll check them out! | 18:36 |
| TheJulia | It is looking in really good shape, the only real issue that I see is a test seems to be missing | 18:36 |
| *** munimeha1 has quit IRC | 18:37 | |
| *** moshele has joined #openstack-ironic | 18:38 | |
| TheJulia | moshele: Sorry, I've not had a chance to look at the spec again this week | 18:39 |
| moshele | TheJulia: no worries | 18:40 |
| *** dsneddon__ has quit IRC | 18:43 | |
| *** dsneddon__ has joined #openstack-ironic | 18:43 | |
| *** dtrainor has quit IRC | 18:45 | |
| *** dtrainor has joined #openstack-ironic | 18:45 | |
| bdodd | TheJulia - for the reboot requested test, the logic is that we only set the 'post_config_reboot_requested' flag in the driver_internal_info after we issue the reboot. The reboot is done from post_configuration() and the flag is set in _set_reboot_requested(). | 18:47 |
| bdodd | Is the concern that the flag could be left over or set via some other means? | 18:48 |
| TheJulia | no, the concern is that the second time it is called, it is essentially an independent call so we should have a test that validates that behavior is what we expect | 18:48 |
| bdodd | So like a call to the service (via sushy) that would verify the reboot had been requested? | 18:50 |
| TheJulia | No, I mean like a test that sets the stage as if the node has rebooted already | 18:51 |
| TheJulia | and apply_configuration is called again | 18:51 |
| *** moshele has quit IRC | 18:57 | |
| bdodd | TheJulia - Are you pointing out the lack of a unit test that tests this stage? (which is definitely missing.) Sorry if I'm being especially dense. | 18:58 |
| TheJulia | i am | 19:01 |
| TheJulia | no worries, we're just using different words | 19:01 |
| bdodd | Ah, good. Yes, I was aware of that will fix it. :-) | 19:02 |
| TheJulia | awesome | 19:09 |
| *** jcoufal_ has joined #openstack-ironic | 19:26 | |
| *** jcoufal has quit IRC | 19:27 | |
| *** irclogbot_1 has joined #openstack-ironic | 20:01 | |
| *** moshele has joined #openstack-ironic | 20:01 | |
| *** moshele has quit IRC | 20:04 | |
| *** jcoufal_ has quit IRC | 20:19 | |
| *** jcoufal has joined #openstack-ironic | 20:21 | |
| *** irclogbot_1 has quit IRC | 20:22 | |
| *** jcoufal has quit IRC | 20:54 | |
| *** betherly has joined #openstack-ironic | 20:56 | |
| *** munimeha1 has joined #openstack-ironic | 20:58 | |
| *** betherly has quit IRC | 21:01 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent master: zuul-ify primary IPA jobs https://review.openstack.org/613426 | 21:14 |
| *** irclogbot_1 has joined #openstack-ironic | 21:15 | |
| *** trown is now known as trown|outtypewww | 21:15 | |
| *** betherly has joined #openstack-ironic | 21:16 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent master: zuul-ify primary IPA jobs https://review.openstack.org/613426 | 21:17 |
| *** betherly has quit IRC | 21:21 | |
| *** betherly has joined #openstack-ironic | 21:37 | |
| *** dsneddon__ has quit IRC | 21:39 | |
| *** dsneddon__ has joined #openstack-ironic | 21:40 | |
| *** betherly has quit IRC | 21:42 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Migration step to update objects to latest version https://review.openstack.org/613181 | 21:49 |
| rloo | dtantsur|afk: ^^ that's my contribution for today. unit tests. it is based on the old backfill code so should work :).but didn't have time to put together a test env to try it out. | 21:52 |
| *** betherly has joined #openstack-ironic | 21:58 | |
| *** betherly has quit IRC | 22:02 | |
| *** betherly has joined #openstack-ironic | 22:18 | |
| *** betherly has quit IRC | 22:23 | |
| *** baha has quit IRC | 22:24 | |
| *** emine__ has quit IRC | 22:24 | |
| *** ElCoyote_ has quit IRC | 22:34 | |
| *** dtrainor has quit IRC | 22:35 | |
| *** betherly has joined #openstack-ironic | 22:49 | |
| *** betherly has quit IRC | 22:53 | |
| *** munimeha1 has quit IRC | 23:00 | |
| *** betherly has joined #openstack-ironic | 23:09 | |
| *** betherly has quit IRC | 23:14 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent master: zuul-ify primary IPA jobs https://review.openstack.org/613426 | 23:43 |
| *** gyee has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!